#8986: Add support for convex rational polyhedral cones
----------------------------------+-----------------------------------------
   Reporter:  novoselt            |       Owner:  mhampton    
       Type:  enhancement         |      Status:  needs_review
   Priority:  major               |   Milestone:  sage-4.4.4  
  Component:  geometry            |    Keywords:              
     Author:  Andrey Novoseltsev  |    Upstream:  N/A         
   Reviewer:  Volker Braun        |      Merged:              
Work_issues:                      |  
----------------------------------+-----------------------------------------

Comment(by vbraun):

 I think the == comparison is not so critical, as it is the default python
 behavior to compare actual objects. Should not cause any confusion as long
 as one is somewhat familiar with Sage. So I'm happy with that.

 The `Polyhedron` class already has a `contains()` method that tests for
 inclusion (I wrote it with toric varieties in mind :-).
 `ConvexRationalPolyhedralCone._contains()` could have called that, saving
 a few lines of duplicate code. Not that big a deal, though. I'm happy to
 give it a positive review either way. Let me know what you think.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8986#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to