#9960: require SAGE_CHECK to be "yes"
------------------------------+---------------------------------------------
   Reporter:  jhpalmieri      |       Owner:  was         
       Type:  defect          |      Status:  needs_review
   Priority:  major           |   Milestone:  sage-4.6.1  
  Component:  user interface  |    Keywords:              
     Author:  John Palmieri   |    Upstream:  N/A         
   Reviewer:                  |      Merged:              
Work_issues:                  |  
------------------------------+---------------------------------------------

Comment(by leif):

 Replying to [comment:17 jhpalmieri]:
 > Leif: just to clarify, are you suggesting changing ''every'' instance of
 {{{exit}}} to {{{return}}} in sage-env, or just changing the one relevant
 to SAGE64?

 Yes, every. If you exit in a sourced file, the sourcing shell exits.

 (We should then test the return code when/whereever {{{sage-env}}} is
 sourced.)

 > As far as suppressing output from sage-env, it turns out that there is
 one bad instance: the output from sage-check-64.  If this is not
 suppressed, then you can get behavior like this on a 64-bit OS X machine:
 {{{
 $ sage -hg status
 Building Sage on OS X in 64-bit mode
 ...
 $ sage
 Building Sage on OS X in 64-bit mode
 ...
 $ sage -pkg ...
 Building Sage on OS X in 64-bit mode
 ...
 }}}
 > This is confusing since nothing is actually being built.

 The {{{sage-check-64}}} script is a bit funny...

 > It is also not necessary to print this every time any script in
 local/bin runs, so right now I'm suppressing output from it in sage-env.

 We should echo ''warning and error messages'' in {{{sage-env}}} to
 {{{stderr}}}, then we can redirect {{{stdout}}} ("informative" messages)
 to {{{/dev/null}}} in the usual case.

 > Output from it is not suppressed in sage-build.  Perhaps the right place
 to print this message would be somewhere in sage-spkg?

 {{{sage -b}}} doesn't call {{{sage-spkg}}}. We could call {{{sage-
 check-64}}} there, though its use isn't very clear. I either set
 {{{SAGE64}}} or leave it; I don't think there needs to be some extra file
 which sets it if it ever has been set before. Perhaps Dave can explain the
 use of that.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9960#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to