#9976: Decorated functions/methods have generic signature in documentation
--------------------------------+-------------------------------------------
   Reporter:  jsrn              |       Owner:  mvngu                           
        
       Type:  enhancement       |      Status:  needs_review                    
        
   Priority:  major             |   Milestone:  sage-4.7                        
        
  Component:  documentation     |    Keywords:  sphinx, documentation, cython 
inspection
     Author:  jsrn, Simon King  |    Upstream:  N/A                             
        
   Reviewer:                    |      Merged:                                  
        
Work_issues:                    |  
--------------------------------+-------------------------------------------

Comment(by SimonKing):

 Replying to [comment:64 jsrn]:
 > No, groebner_basis has never worked with my patch; for my patch to work,
 it requires that the decorator use @sage_wraps on the wrapping function
 which is returned.

 Did you check whether it works with my latest patches? With them,
 `sage_getargspec` works on `groebner_basis()`.

 In fact, I just checked that the documentation looks ok if I apply both
 our patches.

 By the way, I asked at [sage-devel http://groups.google.com/group/sage-
 devel/browse_thread/thread/dd7de9c504c13164] whether it is ok if I review
 your patch and you review mine.

 > cached_method doesn't do this. As far as I can see, however, it should
 be possible to make (the non-Cython version of) cached_method use
 sage_wraps; this would remove some lines in _common_init and replace it
 with a @sage_wraps somewhere. You have been working on this so what do you
 say?

 I think that would be a waste of time. The to-be-submitted Cython version
 of @cached_method will be ''vastly'' superior to the old Python version,
 but you can't use a decorator such as @sage_wraps in Cython code.
 Moreover, if I am not mistaken, the problem is already solved with our
 patches.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9976#comment:65>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to