#9976: Decorated functions/methods have generic signature in documentation
--------------------------------+-------------------------------------------
   Reporter:  jsrn              |       Owner:  mvngu                           
        
       Type:  enhancement       |      Status:  needs_review                    
        
   Priority:  major             |   Milestone:  sage-4.7                        
        
  Component:  documentation     |    Keywords:  sphinx, documentation, cython 
inspection
     Author:  jsrn, Simon King  |    Upstream:  N/A                             
        
   Reviewer:                    |      Merged:                                  
        
Work_issues:                    |  
--------------------------------+-------------------------------------------
Changes (by SimonKing):

  * status:  needs_work => needs_review


Old description:

> Functions or methods that have been decorated by generic decorators such
> as sage.misc.decorators.options (moved from sage.misc.plot.options with
> Trac #9907) degrade documentation by reducing the signature for these
> callables to the generic "(*args, **kwargs)".
>
> See also the following sage.devel discussion:
> http://groups.google.com/group/sage-
> devel/browse_thread/thread/cbd888f0e60130ff/f533792113c45c2f
>
> Let's say that the advanced patch is the most useful and scalable. So
> ignore the first one and:
>
> Apply trac_9976_decorated_generic_sigs_alternative.patch
> inspection_of_cython.patch

New description:

 Functions or methods that have been decorated by generic decorators such
 as sage.misc.decorators.options (moved from sage.misc.plot.options with
 Trac #9907) degrade documentation by reducing the signature for these
 callables to the generic "(*args, **kwargs)".

 See also the following sage.devel discussion:
 http://groups.google.com/group/sage-
 devel/browse_thread/thread/cbd888f0e60130ff/f533792113c45c2f

 Let's say that the advanced patch is the most useful and scalable. So
 ignore the first one and:

 Apply trac_9976_decorated_generic_sigs_alternative.patch
 inspection_of_cython.patch 9976_doc_fixes.patch

--

Comment:

 I was able to submit new patches earlier than expected.

 First, there is another fix in sage_getargspec. It is now tested:
 {{{
 sage: from sage.rings.polynomial.real_roots import
 bernstein_polynomial_factory_ratlist
 sage: sage_getargspec(bernstein_polynomial_factory_ratlist.coeffs_bitsize)
 ArgSpec(args=['self'], varargs=None, keywords=None, defaults=None)
 sage: from sage.rings.polynomial.pbori import BooleanMonomialMonoid
 sage: sage_getargspec(BooleanMonomialMonoid.gen)
 ArgSpec(args=['self', 'i'], varargs=None, keywords=None, defaults=(0,))
 sage: P.<x,y> = QQ[]
 sage: I = P*[x,y]
 sage: sage_getargspec(I.groebner_basis)
 ArgSpec(args=['self', 'algorithm', 'deg_bound', 'mult_bound', 'prot',
 '*args', '**kwds'], varargs=None, keywords=None, defaults=('', None, None,
 False))
 }}}

 When building the documentation, I got a couple of warnings. I fixed them
 in the other patch.

 I will only be able to look at the resulting reference manual tomorrow.
 However, if someone in a different time zone wants to look at it now, it
 shall be "needs review"...

 For the patchbot:

 Apply trac_9976_decorated_generic_sigs_alternative.patch
 inspection_of_cython.patch 9976_doc_fixes.patch

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9976#comment:63>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to