#9944: categories for polynomial rings
--------------------------------------------+-------------------------------
Reporter: robertwb | Owner: nthiery
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: categories | Resolution:
Keywords: | Work_issues:
Upstream: N/A | Reviewer: Nicolas M.
Thiéry, Mike Hansen, Martin Raum
Author: Robert Bradshaw, Simon King | Merged:
Dependencies: sage-4.7 + #11139 |
--------------------------------------------+-------------------------------
Comment(by mraum):
I'm done with reading. All tests (-long) passed, but with the latest
version I want to try again. This might take some time.
I encountered only two further issues:
in polynomial_zz_pex.pyx new line 107f there is no specification of the
except clause and I think raise TypeError ... is what belongs there. I
know this is not your code, but it would be nice to fix this "on the fly".
Can we have a doctest for this?
I don't understand the changes to qqbar.py. And also I have the feeling I
saw this kind of change already. Have you, perhaps, confused this change?
If not, could you say, why you made it?
There is still the issue with the rejects. Will you rebase to 4.7.1? In
that case the problem might disappear. I will start compiling the latest
version right now. So by tomorrow, if you could provide a rebased version
and all tests pass, I can give this a positive review.
But already: Greate work!
Martin
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9944#comment:78>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
