#9944: categories for polynomial rings
--------------------------------------------+-------------------------------
Reporter: robertwb | Owner: nthiery
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: categories | Resolution:
Keywords: | Work_issues:
Upstream: N/A | Reviewer: Nicolas M.
Thiéry, Mike Hansen, Martin Raum
Author: Robert Bradshaw, Simon King | Merged:
Dependencies: sage-4.7 + #11139 |
--------------------------------------------+-------------------------------
Comment(by mraum):
For the record: I'm at sage/rings/polynomial/polynomial_zmod_flint.pxd
Simon, you are completely right about the doctest with span. Could we add
#indirect doctest so that attention is drawn to this?
Some issues, that I encountered:
in polynomial_element.pxy new line 5352 : what about p-adics? I haven't
had the time to check, but perhaps you can already say something about it.
in polynomial_element.pxy new line 6180ff : there are two returns that do
not belong there
in polynomial_real_mpfr_dense.pxy new line 57: Do you mean [0]?
in polynomial_ring.py new line 468 : The coercing is the other way around.
Please don't forget to check the rejects that I've mentioned above. This
could be a real problem for Jeroen.
So far, these are amazingly few issues for such a huge patch!
Hope to continue this by tomorrow (night).
Martin
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9944#comment:70>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
