#9944: categories for polynomial rings
--------------------------------------------+-------------------------------
Reporter: robertwb | Owner: nthiery
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: categories | Resolution:
Keywords: | Work_issues:
Upstream: N/A | Reviewer: Nicolas M.
Thiéry, Mike Hansen, Martin Raum
Author: Robert Bradshaw, Simon King | Merged:
Dependencies: sage-4.7 + #11139 |
--------------------------------------------+-------------------------------
Comment(by SimonKing):
Replying to [comment:78 mraum]:
> I encountered only two further issues:
> in polynomial_zz_pex.pyx new line 107f there is no specification of the
except clause and I think raise TypeError ... is what belongs there. I
know this is not your code, but it would be nice to fix this "on the fly".
Can we have a doctest for this?
I am trying. But probably you are right, it should probably be `except
TypeError`.
> I don't understand the changes to qqbar.py. And also I have the feeling
I saw this kind of change already. Have you, perhaps, confused this
change? If not, could you say, why you made it?
That change only concerns a doctest involving the function `sage_input`.
Its purpose is to give a construction to any given object. Apparently, the
coercion changes led to a different but equivalent construction in one of
the examples.
> There is still the issue with the rejects.
Is there really? Meanwhile I got sage-4.7.rc2, and I did ''not'' get any
rejects for any of the patches. I merely got an "applied with fuzz", but
that's not a reject. Are you sure that you started with a fresh
sage-4.7.rc2, applied #11139, and then applied the 6 patches in order as
listed in the ticket description, and only these? Please do not apply
[attachment:trac9944_second_referee.patch], if that was the problem.
> Will you rebase to 4.7.1?
I don't see the need, since it does apply to 4.7.rc2, IMHO.
Cheers,
Simon
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9944#comment:79>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
