#11246: flint-1.5.0.p5's extraneous #includes break typedef ulong in sys/types.h
-----------------------------------+----------------------------------------
Reporter: dimpase | Owner: tbd
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7.1
Component: packages | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: Dima Pasechnik
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Comment(by dimpase):
Replying to [comment:19 kcrisman]:
> Replying to [comment:18 leif]:
> > I know the FLINT spkg is currently a mess anyway, but
> >
> > * (in general) please add the ticket number to commit messages, and
limit `SPKG.txt` lines to 80 columns;
>
> Interestingly, I was just chewed out on another ticket for having cut
some lines in that file down to size! It's true that the new lines are
just a little over that, apparently.
>
> > * the patches are applied without any error checking.
> You mean
> {{{
> +for j in `ls patches/*.patch` ; do
> + patch -p0 < $j
> +done
> }}}
> Do we ever do error checking for these? Most spkg-install files seem to
have just "cp" or "patch". What should be added?
IMHO there is no need to check in spkg-install that patches apply
correctly --- going this way, one woud also could start asking for a
check that tar worked correctly, etc...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11246#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
