Thanks for the comments everyone, and the praise Jake.
Based on this conversation, I think a good avenue would be:
1) Rename MSTCluster to SingleLinkageCluster
2) Merge (after checks, I still need to rebase again)
3) Gael's PR can either use this class, or replace it if he comes up with
something better/faster/stronger. If the second case, remove this class
then.
Thoughts?
On 9 September 2013 04:55, Andreas Mueller <amuel...@ais.uni-bonn.de> wrote:
> On 09/08/2013 06:51 PM, Olivier Grisel wrote:
> >
> > I just had a look at the results section and it looks very
> > interesting, in particular in its ability to bring noise robustness to
> > single linkage. Have you tried to compare it with ward?
> Yeah. I think the "experiments.py" had ward in it:
>
> https://github.com/amueller/information-theoretic-mst/blob/master/experiments.py
> It faired quite nicely.
> If the intrinsic dimensionality is far from n_features, it is better to
> use an estimate of the intrinsic dimensionality.
>
> Hum it seems I forgot to check in a file from my work box. The current
> master doesn't seem to run :(
> I'll fix that tomorrow, then you can run it or I can post the results.
> It was usually better than ward, sometimes a bit slower, though.
>
>
>
> ------------------------------------------------------------------------------
> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
> Discover the easy way to master current and previous Microsoft technologies
> and advance your career. Get an incredible 1,500+ hours of step-by-step
> tutorial videos with LearnDevNow. Subscribe today and save!
> http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
> _______________________________________________
> Scikit-learn-general mailing list
> Scikit-learn-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
>
--
Public key at: http://pgp.mit.edu/ Search for this email address and select
the key from "2011-08-19" (key id: 54BA8735)
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________
Scikit-learn-general mailing list
Scikit-learn-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
