Richard Lowe wrote:
> Vladimir Kotal <Vladimir.Kotal at Sun.COM> writes:
> 
>> Hi all,
>>
>> http://cr.opensolaris.org/ asks for help:
>>    Auto-post to the site from webrev
>>
>> Instead of doing it from webrev.sh itself, why not to solve 2 things at 
>> once [*] by doing it from Cadmium ?
>>
> 
> I think this would be useful to people who use neither cdm nor
> mercurial, I'd far prefer it be done for the general case.

It's not entirely clear to me why is this needed (or maybe I should say 
the scope of intended audience) since everybody in OpenSolaris seems to 
be moving to Mercurial (and webrev.sh resides in ON) but I will rewrite 
the Python code to Korn shell to satisfy the code review comment and 
also to reach beyond OSol.

Nevertheless, I am still missing 'hg webrev':
   6751994 hg webrev is missing

Having one tool to manage all repository based tasks makes sense. 
Previously (with wx/Teamware) we had 'workspace' command which sticked 
out its head above wx, now its under 'hg reparent' and 'hg paths' but we 
have webrev protruding.

Anyway, here's the upload RFE:
   6752000 automatic webrev upload

new webrev is here:
   http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/

The output looks like this:

vk199839:tessier:/local/workspaces/magic_marker-6638987.onnv$ hg webrev -O
Generating webrev:
    SCM detected: mercurial
  File list from: hg-active -p /net/grok.czech/ws-local/onnv-clone ... Done.
       Workspace: /local/workspaces/magic_marker-6638987.onnv (at 
d8eeddf500e7)
Compare against: /net/grok.czech/ws-local/onnv-clone (at df8814607da7)
       Output to: /local/workspaces/magic_marker-6638987.onnv/webrev
    Output Files:
        usr/src/lib/pkcs11/pkcs11_softtoken/common/softSessionUtil.c
                 patch cdiffs udiffs wdiffs sdiffs frames ps old new
  Generating PDF: Done.
      index.html: Done.
Removing old remote webrev: Done.
Uploading webrev: Done.


In case someone wants the webrev functionality in Cadmium, it's here:
   http://cr.opensolaris.org/~vkotal/cdm-with-webrev.py


v.

Reply via email to