Vladimir Kotal wrote: > Vladimir Kotal wrote: > > <snip> > >> new webrev is here: >> http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/ > > For potential reviewers: I am little bit torn between upload by default > with -O and having an option to trigger the upload. > > It's the question of statistics - for most of the time, do people > generate _OpenSolaris_ webrevs to upload them OR to view them and upload > them afterwards ? My belief is that non-OSol webrevs are used for > self-review and whenever -O is used, the webrev is meant for upload. > Also, usually we do not want to upload non-OSol webrevs to > cr.opensolaris.org which also speaks for current state of the code (on > the other hand, the upload-trigger option can be limited to -O, sigh).
Personally, I generate them to look at them first. After I'm certain I haven't missed anything, then I upload them. I ended up writing my own script to rsync them to cr.opensolaris.org though, so I'm glad to see this functionality added... -- Shawn Walker
