On Wed 24 Sep 2008 at 09:17PM, Vladimir Kotal wrote:
> Vladimir Kotal wrote:
>
> <snip>
>
> > new webrev is here:
> > http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/
>
> For potential reviewers: I am little bit torn between upload by default
> with -O and having an option to trigger the upload.
>
> It's the question of statistics - for most of the time, do people
> generate _OpenSolaris_ webrevs to upload them OR to view them and upload
> them afterwards ? My belief is that non-OSol webrevs are used for
> self-review and whenever -O is used, the webrev is meant for upload.
> Also, usually we do not want to upload non-OSol webrevs to
> cr.opensolaris.org which also speaks for current state of the code (on
> the other hand, the upload-trigger option can be limited to -O, sigh).
Vlad: I have been planning to do this RFE for a while, and I really
appreciate that you took the time to tackle it.
I would suggest that upload be enabled via a separate flag.
-O was really intended to be an ON specific hack, when I added it.
Some consolidations (like packaging and the installer) are using
defect.opensolaris.org and -O doesn't really help them.
I suggest:
webrev -u <rsync argument>
webrev -U (i.e. do it all automagically)
That way, I could do:
webrev -u cr.opensolaris.org:name_i_want
If I want to be picky about what I name the webrev.
Or even webrev -u username at cr.opensolaris.org:name_i_want
Anyway, mostly I'd like -O to not get muddled up with other
functionality-- that just makes it harder to kill it off later.
I haven't looked at the code yet but will try to find the time to do
so.
-dp
--
Daniel Price - Solaris Kernel Engineering - dp at eng.sun.com - blogs.sun.com/dp
