Vladimir Kotal wrote: > Vladimir Kotal wrote: > > <snip> > >> new webrev is here: >> http://cr.opensolaris.org/~vkotal/webrev_upload.onnv/ > > For potential reviewers: I am little bit torn between upload by default > with -O and having an option to trigger the upload. > > It's the question of statistics - for most of the time, do people > generate _OpenSolaris_ webrevs to upload them OR to view them and upload > them afterwards ? My belief is that non-OSol webrevs are used for > self-review and whenever -O is used, the webrev is meant for upload. > Also, usually we do not want to upload non-OSol webrevs to > cr.opensolaris.org which also speaks for current state of the code (on > the other hand, the upload-trigger option can be limited to -O, sigh).
I pretty much never publish a webrev without intervening steps. Those include, variously: examining it, chmod'ing it, renaming it, adding comments, rewriting and/or modifying index.html files, massaging file comments and/or bug links. That sounds like a ton of crap, but I don't ever do much of it. Just usually some of it. And always examining it. --Mark
