> ???> Also, usually we do not want to upload non-OSol webrevs to > > cr.opensolaris.org which also speaks for current state of the code (on > > the other hand, the upload-trigger option can be limited to -O, sigh). > > I pretty much never publish a webrev without intervening steps. Those > include, variously: examining it, chmod'ing it, renaming it, adding > comments, rewriting and/or modifying index.html files, massaging file > comments and/or bug links. > > That sounds like a ton of crap, but I don't ever do much of it. Just > usually some of it. And always examining it. > > --Mark
I almost forgot about that. I too sometimes edit the index.html file (as suggested by the comments in the generated one) and my reviewers often thank me for doing so. Here's an example: http://cr.opensolaris.org/~gwr/reconn2/webrev/ How can it be possible to add such useful comments if upload is combined with the webrev command? I'd much prefer a separate upload command, not bundled with webrev. Gordon
