On Thu, Jan 9, 2014 at 2:30 AM, Dirk Bächle <[email protected]> wrote: > On 08.01.2014 22:52, Gary Oberbrunner wrote: >> >> If you can confirm the small change makes sense, I’ll let some of our >> developer test more in detail this configuration. >> >> > It makes sense to me, but Dirk will have to have a say. > > > thanks a lot for testing the new version. Please continue with the reset of > self.cwd commented out (or remove the whole line). If you find further > issues, just let us know immediately. > > > @Gary: Let's wait another day and see if Roberto finds more errors, then I'd > prepare a pull request for removing the offending lines, okay? Trying to > reproduce the failing build on our side and then working around it, is > probably not a good idea so short before the release.
I'd say that it is a best engineering practice to cover legacy code with tests, especially for optimizations. Is there a problem with testing this case? -- anatoly t. _______________________________________________ Scons-dev mailing list [email protected] http://two.pairlist.net/mailman/listinfo/scons-dev
