D27914: [Kilpper] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in urlgrabber.h:185
> I think it's a silly way to do the port but okay, probably works and we get 
> to move on.

What is silly about it?

The original code in ClipCommandProcess used:
const QStringList matches = action.regExpMatches();
which was:
QStringList regExpMatches() const { return m_myRegExp.capturedTexts(); }

REPOSITORY
  R120 Plasma Workspace

BRANCH
  l-klipper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27914

To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D28360#636615 , @eszlari wrote:
  
  > In D28360#636610 , @kossebau 
wrote:
  >
  > > Can you tell which packagers missed that this is a required runtime 
dependency?
  >
  >
  > https://packages.ubuntu.com/focal/kde-config-gtk-style
  >  
https://src.fedoraproject.org/rpms/kde-gtk-config/blob/master/f/kde-gtk-config.spec
  >  
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-plasma/kde-gtk-config/kde-gtk-config-5.18.3.ebuild
  
  
  Okay, that is quite a few. Though, I wonder why they missed it. The current 
addition to RUNTIME dependency was only added post 5.18, right? And no-one told 
the  packagers explicitly otherwise by the usual ways (like in release 
announcement). They do read the cmake log though, and usually ask for that 
listing as RUNTIME dependency.
  
  So the current state with those packages might not be a reason for the 
proposed noisy approach.
  
  >> Edit: The proposed solution to make it simply required only forces 
packagers to add that and all what it pulls in as build-time dependency to 
their package creation, even if not needed for the package creation itself at 
all, which is not something packagers like (wastes resources on package build 
servers).
  > 
  > But they don't have to! They can just compile with
  > 
  >   cmake -DENABLE_XSETTINGSD=OFF ...
  
  They can, but `ENABLE_XSETTINGSD` needs extra work, makes things more 
complex, and the term is also misleading (does it enable support for the 
demon?). One has to know detais.
  
  All in all, this is an unusual approach. Best talk to packagers what they 
prefer and expect, instead of more complex code based on assumption of how 
packagers operate. Done that before myself, and pure listing as RUNTIME dep 
always worked out :)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Peter Eszlari]

eszlari added a comment.


  In D28360#636448 , @gikari wrote:
  
  > Again, why not just make XSettingsd required? It's simpler.
  
  
  To quote yourself: "We cannot add mandatory dependencies to the stable 
branches/releases."
  
  I think it's important to get it in 5.18 LTS.
  
  In D28360#636610 , @kossebau wrote:
  
  > Can you tell which packagers missed that this is a required runtime 
dependency?
  
  
  https://packages.ubuntu.com/focal/kde-config-gtk-style
  
https://src.fedoraproject.org/rpms/kde-gtk-config/blob/master/f/kde-gtk-config.spec
  
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-plasma/kde-gtk-config/kde-gtk-config-5.18.3.ebuild
  
  > Edit: The proposed solution to make it simply required only forces 
packagers to add that and all what it pulls in as build-time dependency to 
their package creation, even if not needed for the package creation itself at 
all, which is not something packagers like (wastes resources on package build 
servers).
  
  But they don't have to! They can just compile with
  
cmake -DENABLE_XSETTINGSD=OFF ...

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Friedrich W. H. Kossebau]

kossebau added a comment.


  See how it is done across KDE repos here:
  
https://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=TYPE+RUNTIME&_casesensitive=1
  
  There should be no reason the same works here as well.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: kossebau, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28354: [applets/digital-clock] Fix calendar events not being shown at first

[Eugene Popov]

epopov updated this revision to Diff 78715.
epopov added a comment.


  Put the `dateEquals` function outside the `onAgendaUpdated` handler, so it 
can be used elsewhere.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28354?vs=78694=78715

REVISION DETAIL
  https://phabricator.kde.org/D28354

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> backend.cpp:236-239
> +auto *job = new KIO::ApplicationLauncherJob(service);
> +auto *delegate = new KNotificationJobUiDelegate;
> +delegate->setAutoErrorHandlingEnabled(true);
> +job->setUiDelegate(delegate);

I see that redundant code in many places can you wrap it in function

  KJob* createApplicationNotificationLauncherJob

or something similar.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Mikhail Zolotukhin]

gikari added a comment.


  In D28360#636610 , @kossebau wrote:
  
  > Edit: The proposed solution to make it simply required only forces 
packagers to add that and all what it pulls in as build-time dependency to 
their package creation, even if not needed for the package creation itself at 
all, which is not something packagers like (wastes resources on package build 
servers).
  
  
  The thing is that xsettigsd is a daemon, which allows some settings, which 
were set to GTK applications, to be applied to the current running GTK 
applications without restarting them. Without it settings are still applied, 
but GTK applications must be restarted in order to use new settings. Daemon 
absence is the user experience sacrifice and IMO we should use this daemon by 
default. So, that's why I proposed making the daemon dependency mandatory.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D28286#636668 , @dfaure wrote:
  
  > Benefit: available everywhere, unlike a local wrapper function.
  
  
  I think wrapper function in KIO :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks good to me, but please wait until D28367 
 and D28268 
 land, since they change the API of 
ApplicationLauncherJob for KServiceAction.
  
  Many thanks for helping with this!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28347: Port services and shell runner away from KRun

[David Faure]

dfaure added a comment.


  Looks good to me, but please wait until D28367 
 and D28268 
 land, since they change the API of 
ApplicationLauncherJob for KServiceAction.
  
  I do not think KActivities::ResourceInstance::notifyAccessed should be done 
from KIO, which doesn't depend on KActivities (and I would like to keep it that 
way).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28347

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

[David Faure]

dfaure added a comment.


  Alternatively I'm wondering if we should add constructors to the delegates 
that take some AutoErrorHandlingEnabled enum value, then it can become 
something like
  
auto *job = new KIO::ApplicationLauncherJob(service);
job->setUiDelegate(new 
KNotificationJobUiDelegate(KJob::AutoErrorHandlingEnabled));
  
  (and the same with KDialogJobUiDelegate in widget applications)
  
  Benefit: available everywhere, unlike a local wrapper function.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

[David Faure]

dfaure added a comment.


  I don't think we want to have wrapper functions in KIO for all combinations 
of jobs and delegates. There are many of each.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Rik Mills]

rikmills added a comment.


  In D28360#636615 , @eszlari wrote:
  
  > https://packages.ubuntu.com/focal/kde-config-gtk-style
  >  
https://src.fedoraproject.org/rpms/kde-gtk-config/blob/master/f/kde-gtk-config.spec
  >  
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-plasma/kde-gtk-config/kde-gtk-config-5.18.3.ebuild
  
  
  
  
  In D28360#636617 , @kossebau wrote:
  
  > Okay, that is quite a few. Though, I wonder why they missed it. The current 
addition to RUNTIME dependency was only added post 5.18, right? And no-one told 
the  packagers explicitly otherwise by the usual ways (like in release 
announcement). They do read the cmake log though, and usually ask for that 
listing as RUNTIME dependency.
  
  
  To be specific, this has been added as a runtime check in the 5.18 branch 
AFTER release of the 5.18.3 tars, so it would only be someone who is doing 
stable git builds (CI or otherwise) who would have had build logs flag this up.
  
  As far as K/Ubuntu is concerned, this has also been added at a point what we 
are well past feature freeze for 20.04. Adding a runtime depends/recommends 
that draws a new package into the default install AND on the ISO needs a 
feature freeze exception application to be made, and since this is not just 
that but a persistent runtime daemon, that is doubly so.
  
  Given that this is ENTIRELY optional, and designed to fix a 'problem' that I 
honestly cannot recall any users raising (at all, or) as a significant problem, 
then I certainly won't be looking at it until after the 20.04 beta next week, 
as there are many more important things to deal with for now.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27595: Watch for language change events, and forward those to the QML engine

[Rik Mills]

rikmills added a comment.


  In D27595#636640 , @vkrause wrote:
  
  > I haven't seen a backtrace for this, but from what I understood from the 
chat backlog this is triggering a QML bug (?) due to the re-evaluation of 
qsTr() with 5.12, rather than actually crashing in the code of this patch?
  
  
  Did not have time to last night, but I will file a bug with both backtraces 
shortly. For now I have reverted the commit in Kubuntu, as a crashing KCM is 
the greater evil, but a better solution would be great. :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27595

To: vkrause, mart
Cc: davidedmundson, broulik, rikmills, ngraham, apol, plasma-devel, 
fbampaloukas, GB_2, domson, dkardarakos, ahiemstra, mart

D28192: WIP: Refactor dictionary runner

[Alexander Lohnau]

alex added inline comments.

INLINE COMMENTS

> sitter wrote in dictionaryrunner.cpp:90
> You could simply use the lastPartOfSpeech I would guess. From what I've seen 
> and what Kai tells me you really only need to set setData if you want to 
> implement actions (`::actionsForMatch`) and need to carry some information to 
> figure out what the match result was or what its actions ought to be, or 
> runability (`::run`). The latter in fact only appears to need id() so it can 
> persistently track how often a given thing was run and thus give it higher 
> relevance if the user chooses that option a lot.
> That is to say: the runner as-is wouldn't benefit from setData at all.

The current behavior is that KRunner closes when a match is selected.
But if you set the data, for instance:
`match.setData(QStringLiteral("Hello There!"));`
The text `Hello There!` will show up in KRunner (like in the converter runner).
The run method won't be called, because the match type is set to 
InformationalMatch.

So the runner would benefit from setData, or am I missing something?

> sitter wrote in dictionaryrunner_config.cpp:24
> I wouldn't remove this without good reason.
> 
> Without this blocking load() call the UI gets set up and shown and only then 
> the data gets loaded in a kinda async fashion. That is cool, but only iff the 
> KCM is actually equipped for handling the intermediate time frame with a "I'm 
> still loading" UI state (busyindicator or something; or is completely empty 
> at least). If that is not the case then relying on async load will result in 
> the KCM appearing in an incomplete state until the load() is run which may 
> take a noticeable amount of time depending on system performance. So, when 
> load() is doing trivial/cheap work it makes a whole lot of sense to call it 
> blockingly form the ctor.

Thanks for the detailed explanation.
Calling the method twice seemed weird to me but  as you have said the load 
method does only cheap work and it should not matter that much.

> sitter wrote in dictionaryrunner_config.cpp:29
> Could you elaborate on why you removed the baseclass calls for 
> load/save/defaults please?

The baseclass implementations for these methods handle the KConfigDialogManager 
widgets and the corresponding changed signals.
I removed them, because the KConfigDialogManager class is not used in this kcm 
and the signals are manually handled.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D28192

To: alex, broulik, ngraham, sitter, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Sadly Cmake does not have separate "RUNTIME-OPTIONAL" & "RUNTIME-REQUIRED" so 
far. Previously that was solved by noting the required vs. optional in the 
purpose text, so the info still arrived with packagers.
  Just "REQUIRED" means, it is required for the build. Could be even a 
build-only requirement.
  
  So "RUNTIME" is the right type here, with the hint to be a required 
dependency done in the "PURPOSE" text:
  
set_package_properties(XSettingsd PROPERTIES
DESCRIPTION "XSettingsd daemon"
TYPE RUNTIME
PURPOSE "Required to have GTK Config kded module to apply settings to 
GTK applications on the fly"
)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28366: [krunner] Don't set the position three times in a row

[Nathaniel Graham]

ngraham added a comment.


  In D28366#636969 , @broulik wrote:
  
  > Can we just nuke this option? I know people on the internetz™ are quite 
vocal about it but effectively it's just broken and unmaintained
  
  
  ...That, or make it configurable with a user-facing UI. I agree that hidden 
features will bit-rot, though.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28366

To: davidedmundson, #plasma, apol
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28389: Add support for logging categories

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> CMakeLists.txt:23
> +Critical
> +)
> +

Any idea how to reuse the declaration from the top-directory CMake file?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D28389

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27595: Watch for language change events, and forward those to the QML engine

[Volker Krause]

vkrause added subscribers: broulik, davidedmundson.
vkrause added a comment.


  In D27595#636543 , @rikmills wrote:
  
  > git bisect also shows that this crashes the virtual desktop and regional 
settings KCM in Kubuntu 20.04
  
  
  I haven't seen a backtrace for this, but from what I understood from the chat 
backlog this is triggering a QML bug (?) due to the re-evaluation of qsTr() 
with 5.12, rather than actually crashing in the code of this patch? If so, I 
see three options:
  
  - ifdef the connect() call in initializeEngine() for Qt 5.12, breaking 
translations in that version only.
  - Replace this patch by the alternative approach proposed in D25984 
 for fixing translations, and see if that 
has less side effects.
  - Revert this entirely and break translations
  
  @mart @davidedmundson @broulik?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27595

To: vkrause, mart
Cc: davidedmundson, broulik, rikmills, ngraham, apol, plasma-devel, 
fbampaloukas, GB_2, domson, dkardarakos, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

[Anthony Fieroni]

anthonyfieroni added a comment.


  Why not? Furthermore they can be easy fixable.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D6056: [Run Command] Auto-close on focus loss only if query field is empty

[Robert Barat]

rwbarat added a comment.


  Hey @ngraham @davidedmundson @broulik I was wondering if there are any 
updates on this patch, as closing when losing focus is a frequent issue for me 
with KRunner a bunch of other people too according to the Bugzilla issue page 
for this . Thanks so much!!
  
  In D6056#572826 ,  wrote:
  
  > Actually I see a problem with this now that I try it out again: if you 
switch away from Krunner while it's still open with input and then trigger it 
again, a second one opens!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6056

To: broulik, #plasma, #vdg, davidedmundson, ngraham
Cc: rwbarat, GB_2, elcste, ngraham, cfeck, anthonyfieroni, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Alexandre Pereira]

pereira.alex updated this revision to Diff 78758.
pereira.alex added a comment.


  Deal with upgrading configuration
  
  Added code to deal with old configuration:
  
  - created a check to see if the user is using list mode view and doesn't have 
listViewIconSize set. If it doesnt, then use small icon size ( which was old 
behaviour )
  - created code to set the slider to correct size when its used the first time 
for users upgrading. It does it by setting the slider value to the current 
value. When saving, it will then deal with saving into the correct value.
  
  I haven't found any problems/bugs so far on my testing ( manually editing the 
applets rc plasma file to fake like if it was an old configuration ). The only 
issue I have with this, is that that check will need to run whenever the 
folderview is opened.
  You think it is worth it ? or don't check it and let users handle migration ?

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28057?vs=78755=78758

BRANCH
  fix-folderview-popup-icon-list-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28057

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28081: Populate Greeter process exit stderr

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:c893e333b060: Populate Greeter process exit stderr 
(authored by romangg).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28081?vs=77784=78759

REVISION DETAIL
  https://phabricator.kde.org/D28081

AFFECTED FILES
  greeter/main.cpp
  ksldapp.cpp

To: romangg, #plasma, apol
Cc: davidedmundson, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28082: Take file descriptor only instead of whole KWayland Display

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R133:decf7c9d4f43: Take file descriptor only instead of whole 
KWayland Display (authored by romangg).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28082?vs=77785=78761

REVISION DETAIL
  https://phabricator.kde.org/D28082

AFFECTED FILES
  autotests/noscreens.cpp
  ksldapp.cpp
  ksldapp.h
  waylandlocker.cpp
  waylandlocker.h

To: romangg, #plasma, davidedmundson
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28366: [krunner] Don't set the position three times in a row

[Alexandre Pereira]

pereira.alex added a comment.


  I don't want to be *that guy* but this is one of the things I do in every kde 
desktop I have. User facing configurable UI would be great !
  
  That said, although I love the free floating version, I wouldn't run to xxx 
desktop if it was removed ! :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28366

To: davidedmundson, #plasma, apol
Cc: pereira.alex, ngraham, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28389: Add support for logging categories

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Adds category logging to the KScreenLocker daemon/library and the greeter.
  
  Replaces all current uncategorized messages with categorized ones in these
  parts.

TEST PLAN
  Tested messages with autotests and QT_LOGGING_RULES="kscreenlocker*=true".

REPOSITORY
  R133 KScreenLocker

BRANCH
  logging-categories

REVISION DETAIL
  https://phabricator.kde.org/D28389

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  greeter/CMakeLists.txt
  greeter/greeterapp.cpp
  greeter/main.cpp
  ksldapp.cpp
  logind.cpp
  x11locker.cpp

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Alexandre Pereira]

pereira.alex added a comment.


  Also forgot to mention:
  
  Tested with removing the new values from 
.config/plasma-org.kde.plasma.desktop-appletsrc :
  
  - If user doesn't go to properties and changes size or view mode, the 
old/current value is respected and used ( which might be a problem, if the 
previous iconSize is from gridview mode and set to huge, the user will face 
from size small to size huge on the list )
  - If user changes the size or view mode, the default values for the size are 
used on the slider.
  
  I could do a check to see if the property iconSize of list mode is 
configured. if not, return the default ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28386: fix(kded): watch config also when known config is applied

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  When a known config is applied the doApplyConfig with the Config wrapper
  override is called. In this case we still want to activate config watching
  like when a config from the ConfigPtr override is applied.
  
  Otherwise we are not be able to detect a control change until the first time
  a new config is applied.

TEST PLAN
  Started with rotation in manual mode. Switched in KCM only from manual to
  automatic mode without changing anything else. With the patch the daemon
  notices this change, without it not.

REPOSITORY
  R104 KScreen

BRANCH
  control-watching-fix

REVISION DETAIL
  https://phabricator.kde.org/D28386

AFFECTED FILES
  kded/daemon.cpp

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28383: Add PageRouter component

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  This needs way more description and explanation of the problem it's trying to 
solve.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28383

To: cblack, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart

D28383: Add PageRouter component

[Carson Black]

cblack updated this revision to Diff 78747.
cblack added a comment.


  Get arc to deal with multiple commits properly

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28383?vs=78746=78747

BRANCH
  cblack/pagerouter

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart

D28369: [runners/recentdocuments] disable executables or .desktop files

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28369

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.14 - Build # 9 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.14/9/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 28 Mar 2020 19:45:46 +
 Build duration:
49 sec and counting
   CONSOLE OUTPUT
  [...truncated 348 lines...][2020-03-28T19:46:34.949Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2020-03-28T19:46:34.949Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2020-03-28T19:46:34.949Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2020-03-28T19:46:34.949Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2020-03-28T19:46:34.949Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2020-03-28T19:46:34.949Z] -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.69.0") [2020-03-28T19:46:34.949Z] -- Found KF5: success (found version "5.69.0") found components: Notifications KIO [2020-03-28T19:46:35.206Z] -- The following features have been enabled:[2020-03-28T19:46:35.206Z] [2020-03-28T19:46:35.206Z]  * Fwupd, Exposes fwupd[2020-03-28T19:46:35.206Z] [2020-03-28T19:46:35.206Z] -- The following RUNTIME packages have been found:[2020-03-28T19:46:35.206Z] [2020-03-28T19:46:35.206Z]  * KF5Kirigami2 (required version >= 2.7.0), KDE's lightweight user interface framework for mobile and convergent applications, [2020-03-28T19:46:35.206Z]Required by discover qml components[2020-03-28T19:46:35.206Z] [2020-03-28T19:46:35.206Z] -- The following OPTIONAL packages have been found:[2020-03-28T19:46:35.206Z] [2020-03-28T19:46:35.206Z]  * KF5Package (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * AppStreamQt (required version >= 0.11.1), Library that lists Appstream resources, [2020-03-28T19:46:35.206Z]Required to build the PackageKit and Flatpak backends[2020-03-28T19:46:35.206Z]  * KF5Attica (required version >= 5.68.0), KDE Framework that implements the Open Collaboration Services API[2020-03-28T19:46:35.206Z]Required to build the KNewStuff3 backend[2020-03-28T19:46:35.206Z]  * KF5NewStuffCore (required version >= 5.69.0)[2020-03-28T19:46:35.206Z]  * KF5NewStuff (required version >= 5.53), Qt library that allows to interact with KNewStuff implementations[2020-03-28T19:46:35.206Z]Required to build the KNS backend[2020-03-28T19:46:35.206Z]  * KUserFeedback[2020-03-28T19:46:35.206Z]  * KF5Service (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5Bookmarks (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5Completion (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5ItemViews (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5JobWidgets (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5Solid (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5Auth (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5Codecs (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5WidgetsAddons (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5ConfigWidgets (required version >= 5.68.0)[2020-03-28T19:46:35.206Z]  * KF5WindowSystem (required version >= 5.68.0)[2020-03-28T19:46:35.206Z] [2020-03-28T19:46:35.206Z] -- The following REQUIRED packages have been found:[2020-03-28T19:46:35.206Z] [2020-03-28T19:46:35.206Z]  * Qt5Gui (required version >= 5.14.1)[2020-03-28T19:46:35.206Z]  * Qt5Test[2020-03-28T19:46:35.206Z]  * Qt5Qml (required version >= 5.14.1)[2020-03-28T19:46:35.206Z]  * Qt5QmlModels (required version >= 5.14.1)[2020-03-28T19:46:35.206Z]  * PkgConfig[2020-03-28T19:46:35.206Z]  * KF5Crash (required version >= 5.62.0)[2020-03-28T19:46:35.206Z]  * KF5DBusAddons (required version >= 5.62.0)[2020-03-28T19:46:35.206Z]  * Gettext[2020-03-28T19:46:35.206Z]  * KF5I18n (required version >= 5.62.0)[2020-03-28T19:46:35.206Z]  * KF5Archive (required version >= 5.62.0)[2020-03-28T19:46:35.206Z]  * KF5ItemModels (required version >= 5.62.0)[2020-03-28T19:46:35.206Z]  * Qt5Quick (required version >= 5.12.0)[2020-03-28T19:46:35.206Z]  * ECM (required version >= 1.6.0)[2020-03-28T19:46:35.206Z]  * KF5Declarative (required version >= 5.62.0)[2020-03-28T19:46:35.207Z]  * Qt5 (required version >= 5.14)[2020-03-28T19:46:35.207Z]  * KF5Notifications[2020-03-28T19:46:35.207Z]  * KF5CoreAddons (required version >= 5.68.0)[2020-03-28T19:46:35.207Z]  * Qt5Core (required version >= 5.12.0)[2020-03-28T19:46:35.207Z]  * Qt5Xml (required version >= 5.12.0)[2020-03-28T19:46:35.207Z]  * KF5Config (required version >= 5.68.0)[2020-03-28T19:46:35.207Z]  * KF5XmlGui (required version >= 5.68.0)[2020-03-28T19:46:35.207Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-28T19:46:35.207Z]  * Qt5Network (required version >= 5.12.0)[2020-03-28T19:46:35.207Z]  * Qt5Concurrent (required version >= 5.12.0)[2020-03-28T19:46:35.207Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-28T19:46:35.207Z]  * KF5KIO[2020-03-28T19:46:35.207Z]  * 

D28382: QQC2-Desktop-Style: Convert license headers to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license headers to SPDX expressions and add license texts
  as required by REUSE specification.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D28382

AFFECTED FILES
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/LicenseRef-KFQF-Accepted-GPL.txt
  LICENSES/LicenseRef-Qt-Commercial.txt
  Mainpage.dox
  kirigami-plasmadesktop-integration/kirigamiplasmafactory.cpp
  kirigami-plasmadesktop-integration/kirigamiplasmafactory.h
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
  kirigami-plasmadesktop-integration/plasmadesktoptheme.h
  org.kde.desktop/BusyIndicator.qml
  org.kde.desktop/Button.qml
  org.kde.desktop/CheckBox.qml
  org.kde.desktop/CheckDelegate.qml
  org.kde.desktop/CheckIndicator.qml
  org.kde.desktop/ComboBox.qml
  org.kde.desktop/Container.qml
  org.kde.desktop/Control.qml
  org.kde.desktop/DelayButton.qml
  org.kde.desktop/Dial.qml
  org.kde.desktop/Dialog.qml
  org.kde.desktop/DialogButtonBox.qml
  org.kde.desktop/Drawer.qml
  org.kde.desktop/Frame.qml
  org.kde.desktop/GroupBox.qml
  org.kde.desktop/ItemDelegate.qml
  org.kde.desktop/Label.qml
  org.kde.desktop/Menu.qml
  org.kde.desktop/MenuBarItem.qml
  org.kde.desktop/MenuItem.qml
  org.kde.desktop/MenuSeparator.qml
  org.kde.desktop/Popup.qml
  org.kde.desktop/ProgressBar.qml
  org.kde.desktop/RadioButton.qml
  org.kde.desktop/RadioDelegate.qml
  org.kde.desktop/RangeSlider.qml
  org.kde.desktop/RoundButton.qml
  org.kde.desktop/ScrollBar.qml
  org.kde.desktop/ScrollView.qml
  org.kde.desktop/Slider.qml
  org.kde.desktop/SpinBox.qml
  org.kde.desktop/Switch.qml
  org.kde.desktop/SwitchDelegate.qml
  org.kde.desktop/SwitchIndicator.qml
  org.kde.desktop/TabBar.qml
  org.kde.desktop/TabButton.qml
  org.kde.desktop/TextArea.qml
  org.kde.desktop/TextField.qml
  org.kde.desktop/ToolBar.qml
  org.kde.desktop/ToolButton.qml
  org.kde.desktop/ToolTip.qml
  org.kde.desktop/private/DefaultListItemBackground.qml
  org.kde.desktop/private/FocusRect.qml
  org.kde.desktop/private/MobileCursor.qml
  org.kde.desktop/private/MobileTextActionsToolBar.qml
  plugin/kpropertywriter.cpp
  plugin/kpropertywriter_p.h
  plugin/kquickpadding_p.h
  plugin/kquickstyleitem.cpp
  plugin/kquickstyleitem_p.h
  plugin/qqc2desktopstyleplugin.cpp
  plugin/qqc2desktopstyleplugin.h
  plugin/qsgdefaultninepatchnode.cpp
  plugin/qsgdefaultninepatchnode_p.h
  plugin/qsgninepatchnode.cpp
  plugin/qsgninepatchnode.h
  tests/LineEditWithClearButton.qml
  tests/buttonIcons.qml

To: cordlandwehr
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28383: Add PageRouter component

[Carson Black]

cblack created this revision.
cblack added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  PageRouter is a component that manages named routes of pages.

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/pagerouter

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  src/CMakeLists.txt
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28366: [krunner] Don't set the position three times in a row

[Kai Uwe Broulik]

broulik added a comment.


  Can we just nuke this option? I know people on the internetz™ are quite vocal 
about it but effectively it's just broken and unmaintained

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28366

To: davidedmundson, #plasma, apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28286: [Task Manager] Port backend to ApplicationLauncherJob

[David Faure]

dfaure added a comment.


  Why not -> because it just doesn't scale. 30 jobs * 4 delegates = 120 wrapper 
methods...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28286

To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28385: Remove unused file

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78753.
apol added a comment.


  was only meant to include this

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28385?vs=78752=78753

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28385

AFFECTED FILES
  ksmserver/KSMServerInterface.h

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28383: Add PageRouter component

[Carson Black]

cblack updated this revision to Diff 78746.
cblack added a comment.


  Add documentation comments

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28383?vs=78744=78746

BRANCH
  cblack/pagerouter

REVISION DETAIL
  https://phabricator.kde.org/D28383

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/pagerouter.cpp
  src/pagerouter.h

To: cblack, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart

D28385: Remove unused file

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Still included dcop, hadn't been compiled in years I presume.

TEST PLAN
  All good and normal

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28385

AFFECTED FILES
  ksmserver/KSMServerInterface.h
  ksplash/ksplashqml/splashapp.cpp
  ksplash/ksplashqml/splashwindow.cpp
  shell/screenpool.cpp
  shell/shellcorona.cpp
  startkde/plasma-shutdown/shutdown.cpp
  startkde/plasma-shutdown/shutdown.h
  startkde/startplasma.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28354: [applets/digital-clock] Fix calendar events not being shown at first

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28354

To: epopov, ngraham, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Carson Black]

cblack updated this revision to Diff 78754.
cblack added a comment.


  Optimize toolbar rect function

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27669?vs=78667=78754

BRANCH
  cblack/toolsarea

REVISION DETAIL
  https://phabricator.kde.org/D27669

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/16/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 28 Mar 2020 19:45:46 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 286 lines...][2020-03-28T19:46:48.916Z] [2020-03-28T19:46:48.916Z] [2020-03-28T19:46:48.916Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2020-03-28T19:46:49.176Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2020-03-28T19:46:49.176Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2020-03-28T19:46:49.176Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2020-03-28T19:46:49.176Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2020-03-28T19:46:49.176Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2020-03-28T19:46:49.176Z] -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.69.0") [2020-03-28T19:46:49.176Z] -- Found KF5: success (found version "5.69.0") found components: Notifications KIO [2020-03-28T19:46:49.435Z] -- The following RUNTIME packages have been found:[2020-03-28T19:46:49.435Z] [2020-03-28T19:46:49.435Z]  * KF5Kirigami2 (required version >= 2.7.0), KDE's lightweight user interface framework for mobile and convergent applications, [2020-03-28T19:46:49.435Z]Required by discover qml components[2020-03-28T19:46:49.435Z] [2020-03-28T19:46:49.435Z] -- The following OPTIONAL packages have been found:[2020-03-28T19:46:49.435Z] [2020-03-28T19:46:49.435Z]  * KF5Package (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5Attica (required version >= 5.68.0), KDE Framework that implements the Open Collaboration Services API[2020-03-28T19:46:49.435Z]Required to build the KNewStuff3 backend[2020-03-28T19:46:49.435Z]  * KF5NewStuffCore (required version >= 5.69.0)[2020-03-28T19:46:49.435Z]  * KF5NewStuff (required version >= 5.53), Qt library that allows to interact with KNewStuff implementations[2020-03-28T19:46:49.435Z]Required to build the KNS backend[2020-03-28T19:46:49.435Z]  * KUserFeedback[2020-03-28T19:46:49.435Z]  * KF5Service (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5Bookmarks (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5Completion (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5ItemViews (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5JobWidgets (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5Solid (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5Auth (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5Codecs (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5WidgetsAddons (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5ConfigWidgets (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5WindowSystem (required version >= 5.68.0)[2020-03-28T19:46:49.435Z] [2020-03-28T19:46:49.435Z] -- The following REQUIRED packages have been found:[2020-03-28T19:46:49.435Z] [2020-03-28T19:46:49.435Z]  * Qt5Gui (required version >= 5.14.1)[2020-03-28T19:46:49.435Z]  * Qt5Test[2020-03-28T19:46:49.435Z]  * Qt5Qml (required version >= 5.14.1)[2020-03-28T19:46:49.435Z]  * Qt5QmlModels (required version >= 5.14.1)[2020-03-28T19:46:49.435Z]  * PkgConfig[2020-03-28T19:46:49.435Z]  * KF5Crash (required version >= 5.62.0)[2020-03-28T19:46:49.435Z]  * KF5DBusAddons (required version >= 5.62.0)[2020-03-28T19:46:49.435Z]  * Gettext[2020-03-28T19:46:49.435Z]  * KF5I18n (required version >= 5.62.0)[2020-03-28T19:46:49.435Z]  * KF5Archive (required version >= 5.62.0)[2020-03-28T19:46:49.435Z]  * KF5ItemModels (required version >= 5.62.0)[2020-03-28T19:46:49.435Z]  * Qt5Quick (required version >= 5.12.0)[2020-03-28T19:46:49.435Z]  * ECM (required version >= 1.6.0)[2020-03-28T19:46:49.435Z]  * KF5Declarative (required version >= 5.62.0)[2020-03-28T19:46:49.435Z]  * Qt5 (required version >= 5.14)[2020-03-28T19:46:49.435Z]  * KF5Notifications[2020-03-28T19:46:49.435Z]  * KF5CoreAddons (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * Qt5Core (required version >= 5.12.0)[2020-03-28T19:46:49.435Z]  * Qt5Xml (required version >= 5.12.0)[2020-03-28T19:46:49.435Z]  * KF5Config (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * KF5XmlGui (required version >= 5.68.0)[2020-03-28T19:46:49.435Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-28T19:46:49.435Z]  * Qt5Network (required version >= 5.12.0)[2020-03-28T19:46:49.435Z]  * Qt5Concurrent (required version >= 5.12.0)[2020-03-28T19:46:49.435Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-28T19:46:49.435Z]  * KF5KIO[2020-03-28T19:46:49.435Z]  * KF5[2020-03-28T19:46:49.435Z] [2020-03-28T19:46:49.435Z] -- The following features have been disabled:[2020-03-28T19:46:49.435Z] [2020-03-28T19:46:49.435Z]  * Flatpak, Library that exposes flatpak repositories. Required to build the Flatpak 

D28057: Fix/Allow folderview popup mode icon and list icon size

[Alexandre Pereira]

pereira.alex updated this revision to Diff 78755.
pereira.alex added a comment.


  Use single slider and sync values
  
  Removed duplicated slider, to only use one slider that uses and updates the 
correct value.
  
  Added an event when changing viewmode grid or list, to load the slider with 
the correct value.
  
  If there isn't any issue with the code and behaviour, I think its ready:
  
  - adds feature to allow choosing size on list mode
  - fixes the bug reported in that the list mode icon size updates properly 
without needing a plasmashell restart

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28057?vs=78238=78755

BRANCH
  fix-folderview-popup-icon-list-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28057

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28366: [krunner] Don't set the position three times in a row

[Nathaniel Graham]

ngraham added a comment.


  Yeah, it's not like the KRunner KCM is currently overflowing with options and 
it would get lost. :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28366

To: davidedmundson, #plasma, apol
Cc: pereira.alex, ngraham, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  I've discovered another bug. When you move a window by dragging on an empty 
area, the hover effect on toolbar buttons stops working.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28386: fix(kded): watch config also when known config is applied

[Bhushan Shah]

bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.


  Makes sense

REPOSITORY
  R104 KScreen

BRANCH
  control-watching-fix

REVISION DETAIL
  https://phabricator.kde.org/D28386

To: romangg, #plasma, bshah
Cc: bshah, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  I just found an interesting bug. KDE apps with menubars show a mis-colored 
area to the right of the menubar when maximized: F8203808: 
vokoscreenNG-2020-03-28_22-03-54.webm 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart