[webkit-changes] [225330] trunk/Source/WebCore

[cdumez]

Title: [225330] trunk/Source/WebCore








Revision 225330
Author cdu...@apple.com
Date 2017-11-30 10:02:48 -0800 (Thu, 30 Nov 2017)


Log Message
Mark ServiceWorkerGlobalScope as final
https://bugs.webkit.org/show_bug.cgi?id=180201

Reviewed by Alex Christensen.

* workers/service/ServiceWorkerGlobalScope.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225329 => 225330)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 16:24:48 UTC (rev 225329)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 18:02:48 UTC (rev 225330)
@@ -1,3 +1,12 @@
+2017-11-30  Chris Dumez  
+
+Mark ServiceWorkerGlobalScope as final
+https://bugs.webkit.org/show_bug.cgi?id=180201
+
+Reviewed by Alex Christensen.
+
+* workers/service/ServiceWorkerGlobalScope.h:
+
 2017-11-30  Zan Dobersek  
 
 [CoordGraphics] Move CoordinatedGraphicsLayer painting behind Nicosia::PaintingEngine


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h (225329 => 225330)

--- trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h	2017-11-30 16:24:48 UTC (rev 225329)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h	2017-11-30 18:02:48 UTC (rev 225330)
@@ -40,7 +40,7 @@
 class ServiceWorkerClients;
 class ServiceWorkerThread;
 
-class ServiceWorkerGlobalScope : public WorkerGlobalScope {
+class ServiceWorkerGlobalScope final : public WorkerGlobalScope {
 public:
 template static Ref create(Args&&... args)
 {
@@ -47,7 +47,7 @@
 return adoptRef(*new ServiceWorkerGlobalScope(std::forward(args)...));
 }
 
-virtual ~ServiceWorkerGlobalScope();
+~ServiceWorkerGlobalScope();
 
 bool isServiceWorkerGlobalScope() const final { return true; }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225329] trunk/LayoutTests

[Ms2ger]

Title: [225329] trunk/LayoutTests








Revision 225329
Author ms2...@igalia.com
Date 2017-11-30 08:24:48 -0800 (Thu, 30 Nov 2017)


Log Message
[GTK] Enable all wpt touch-events tests.
https://bugs.webkit.org/show_bug.cgi?id=180198

Unreviewed test gardening.


LayoutTests/imported/w3c:

* web-platform-tests/touch-events/create-touch-touchlist-expected.txt: Added.
* web-platform-tests/touch-events/historical-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/touch-events/historical-expected.txt.
* web-platform-tests/touch-events/touch-globaleventhandler-interface-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/touch-events/touch-globaleventhandler-interface-expected.txt.
* web-platform-tests/touch-events/touch-retargeting-expected.txt:
* web-platform-tests/touch-events/touch-touchevent-constructor-expected.txt:

LayoutTests:

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/touch-retargeting-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/touch-touchevent-constructor-expected.txt
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/create-touch-touchlist-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/historical-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/touch-globaleventhandler-interface-expected.txt


Removed Paths

trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/touch-events/




Diff

Modified: trunk/LayoutTests/ChangeLog (225328 => 225329)

--- trunk/LayoutTests/ChangeLog	2017-11-30 15:12:58 UTC (rev 225328)
+++ trunk/LayoutTests/ChangeLog	2017-11-30 16:24:48 UTC (rev 225329)
@@ -1,3 +1,12 @@
+2017-11-30  Ms2ger  
+
+[GTK] Enable all wpt touch-events tests.
+https://bugs.webkit.org/show_bug.cgi?id=180198
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations:
+
 2017-11-29  Antoine Quint  
 
 Move modern media controls test expectations from ios-simulator to ios


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (225328 => 225329)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-11-30 15:12:58 UTC (rev 225328)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-11-30 16:24:48 UTC (rev 225329)
@@ -1,3 +1,16 @@
+2017-11-30  Ms2ger  
+
+[GTK] Enable all wpt touch-events tests.
+https://bugs.webkit.org/show_bug.cgi?id=180198
+
+Unreviewed test gardening.
+
+* web-platform-tests/touch-events/create-touch-touchlist-expected.txt: Added.
+* web-platform-tests/touch-events/historical-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/touch-events/historical-expected.txt.
+* web-platform-tests/touch-events/touch-globaleventhandler-interface-expected.txt: Renamed from LayoutTests/platform/gtk/imported/w3c/web-platform-tests/touch-events/touch-globaleventhandler-interface-expected.txt.
+* web-platform-tests/touch-events/touch-retargeting-expected.txt:
+* web-platform-tests/touch-events/touch-touchevent-constructor-expected.txt:
+
 2017-11-29  Chris Dumez  
 
 Start exposing self.registration inside service workers


Added: trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/create-touch-touchlist-expected.txt (0 => 225329)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/create-touch-touchlist-expected.txt	(rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/create-touch-touchlist-expected.txt	2017-11-30 16:24:48 UTC (rev 225329)
@@ -0,0 +1,6 @@
+
+PASS document.createTouch exists and creates a Touch object with requested properties 
+PASS document.createTouchList exists and correctly creates a TouchList from zero Touch objects 
+FAIL document.createTouchList exists and correctly creates a TouchList from a single Touch assert_true: radiusX attribute in Touch object expected true got false
+FAIL document.createTouchList exists and correctly creates a TouchList from two Touch objects assert_true: radiusX attribute in Touch object expected true got false
+


Copied: trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/historical-expected.txt (from rev 225328, trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/touch-events/historical-expected.txt) (0 => 225329)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/historical-expected.txt	(rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/touch-events/historical-expected.txt	2017-11-30 16:24:48 UTC (rev 225329)
@@ -0,0 +1,3 @@
+
+PASS TouchList::identifiedTouch 
+


Copied: 

[webkit-changes] [225331] trunk/Source

[darin]

Title: [225331] trunk/Source








Revision 225331
Author da...@apple.com
Date 2017-11-30 10:17:07 -0800 (Thu, 30 Nov 2017)


Log Message
[Mac] remove unneeded RetainPtr use introduced in r225142
https://bugs.webkit.org/show_bug.cgi?id=180202

Reviewed by Tim Horton.

Source/WebCore:

* editing/mac/DictionaryLookup.h: Changed out arguments back to NSDictionary ** instead
of RetainPtr because these use autorelease.

* editing/mac/DictionaryLookup.mm:
(WebCore::tokenRange): Use NSDictionary **.
(WebCore::DictionaryLookup::rangeForSelection): Ditto.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Ditto.
(WebCore::DictionaryLookup::stringForPDFSelection): Ditto.

Source/WebKit:

* WebProcess/Plugins/PDF/PDFPlugin.h: Got rid of unnecessary RetainPtr.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::lookupTextAtLocation const): Ditto.
* WebProcess/WebPage/WebPage.h: Ditto.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation): Ditto.
(WebKit::WebPage::performDictionaryLookupForSelection): Ditto.
(WebKit::WebPage::performImmediateActionHitTestAtLocation): Ditto.
(WebKit::WebPage::lookupTextAtLocation): Ditto.

Source/WebKitLegacy/mac:

* WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
RetainPtr.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/mac/DictionaryLookup.h
trunk/Source/WebCore/editing/mac/DictionaryLookup.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (225330 => 225331)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 18:02:48 UTC (rev 225330)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 18:17:07 UTC (rev 225331)
@@ -1,3 +1,19 @@
+2017-11-30  Darin Adler  
+
+[Mac] remove unneeded RetainPtr use introduced in r225142
+https://bugs.webkit.org/show_bug.cgi?id=180202
+
+Reviewed by Tim Horton.
+
+* editing/mac/DictionaryLookup.h: Changed out arguments back to NSDictionary ** instead
+of RetainPtr because these use autorelease.
+
+* editing/mac/DictionaryLookup.mm:
+(WebCore::tokenRange): Use NSDictionary **.
+(WebCore::DictionaryLookup::rangeForSelection): Ditto.
+(WebCore::DictionaryLookup::rangeAtHitTestResult): Ditto.
+(WebCore::DictionaryLookup::stringForPDFSelection): Ditto.
+
 2017-11-30  Chris Dumez  
 
 Mark ServiceWorkerGlobalScope as final


Modified: trunk/Source/WebCore/editing/mac/DictionaryLookup.h (225330 => 225331)

--- trunk/Source/WebCore/editing/mac/DictionaryLookup.h	2017-11-30 18:02:48 UTC (rev 225330)
+++ trunk/Source/WebCore/editing/mac/DictionaryLookup.h	2017-11-30 18:17:07 UTC (rev 225331)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014-2015 Apple Inc. All rights reserved.
+ * Copyright (C) 2014-2017 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -50,9 +50,9 @@
 
 class DictionaryLookup {
 public:
-WEBCORE_EXPORT static RefPtr rangeForSelection(const VisibleSelection&, RetainPtr *options);
-WEBCORE_EXPORT static RefPtr rangeAtHitTestResult(const HitTestResult&, RetainPtr *options);
-WEBCORE_EXPORT static NSString *stringForPDFSelection(PDFSelection *, RetainPtr *options);
+WEBCORE_EXPORT static RefPtr rangeForSelection(const VisibleSelection&, NSDictionary **options);
+WEBCORE_EXPORT static RefPtr rangeAtHitTestResult(const HitTestResult&, NSDictionary **options);
+WEBCORE_EXPORT static NSString *stringForPDFSelection(PDFSelection *, NSDictionary **options);
 
 // FIXME: Should move/unify dictionaryPopupInfoForRange here too.
 


Modified: trunk/Source/WebCore/editing/mac/DictionaryLookup.mm (225330 => 225331)

--- trunk/Source/WebCore/editing/mac/DictionaryLookup.mm	2017-11-30 18:02:48 UTC (rev 225330)
+++ trunk/Source/WebCore/editing/mac/DictionaryLookup.mm	2017-11-30 18:17:07 UTC (rev 225331)
@@ -52,7 +52,7 @@
 
 namespace WebCore {
 
-static NSRange tokenRange(const String& string, NSRange range, RetainPtr* options)
+static NSRange tokenRange(const String& string, NSRange range, NSDictionary **options)
 {
 if (!getLULookupDefinitionModuleClass())
 return NSMakeRange(NSNotFound, 0);
@@ -59,14 +59,8 @@
 
 BEGIN_BLOCK_OBJC_EXCEPTIONS;
 
-if (!options)
-return [classLULookupDefinitionModule tokenRangeForString:string range:range options:nullptr];
+return [classLULookupDefinitionModule tokenRangeForString:string range:range options:options];
 
-NSDictionary 

[webkit-changes] [225321] trunk/Tools

[ap]

Title: [225321] trunk/Tools








Revision 225321
Author a...@apple.com
Date 2017-11-30 00:21:25 -0800 (Thu, 30 Nov 2017)


Log Message
Silence the BitVector leak for
https://bugs.webkit.org/show_bug.cgi?id=121662

The out of line data pointer isn't stored directly, so the leaks tool cannot see it.

* Scripts/webkitpy/port/leakdetector.py:
(LeakDetector._callstacks_to_exclude_from_leaks):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/leakdetector.py




Diff

Modified: trunk/Tools/ChangeLog (225320 => 225321)

--- trunk/Tools/ChangeLog	2017-11-30 07:53:21 UTC (rev 225320)
+++ trunk/Tools/ChangeLog	2017-11-30 08:21:25 UTC (rev 225321)
@@ -1,3 +1,13 @@
+2017-11-30  Alexey Proskuryakov  
+
+Silence the BitVector leak for
+https://bugs.webkit.org/show_bug.cgi?id=121662
+
+The out of line data pointer isn't stored directly, so the leaks tool cannot see it.
+
+* Scripts/webkitpy/port/leakdetector.py:
+(LeakDetector._callstacks_to_exclude_from_leaks):
+
 2017-11-29  Aakash Jain  
 
 Fix build.webkit.org broken unit-test after r225080


Modified: trunk/Tools/Scripts/webkitpy/port/leakdetector.py (225320 => 225321)

--- trunk/Tools/Scripts/webkitpy/port/leakdetector.py	2017-11-30 07:53:21 UTC (rev 225320)
+++ trunk/Tools/Scripts/webkitpy/port/leakdetector.py	2017-11-30 08:21:25 UTC (rev 225321)
@@ -54,8 +54,7 @@
 
 def _callstacks_to_exclude_from_leaks(self):
 callstacks = [
-# List substrings here, e.g.
-# 'TextCodecICU::registerCodecs',  # https://bugs.webkit.org/show_bug.cgi?id=118505
+'WTF::BitVector::OutOfLineBits::create', # https://bugs.webkit.org/show_bug.cgi?id=121662
 ]
 return callstacks
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225335] trunk/Source/WebCore

[cdumez]

Title: [225335] trunk/Source/WebCore








Revision 225335
Author cdu...@apple.com
Date 2017-11-30 11:17:55 -0800 (Thu, 30 Nov 2017)


Log Message
Rename RegistrationOptions to ServiceWorkerRegistrationOptions
https://bugs.webkit.org/show_bug.cgi?id=180207

Reviewed by Geoffrey Garen.

Rename RegistrationOptions to ServiceWorkerRegistrationOptions as the name
RegistrationOptions is too generic and likely to conflict. Also modernize
ServiceWorkerRegistrationOptions' IPC decoder.

* workers/service/ServiceWorkerContainer.h:
* workers/service/ServiceWorkerJobData.h:
(WebCore::ServiceWorkerJobData::decode):
* workers/service/ServiceWorkerRegistrationOptions.cpp:
(WebCore::ServiceWorkerRegistrationOptions::isolatedCopy const):
* workers/service/ServiceWorkerRegistrationOptions.h:
(WebCore::ServiceWorkerRegistrationOptions::encode const):
(WebCore::ServiceWorkerRegistrationOptions::decode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h
trunk/Source/WebCore/workers/service/ServiceWorkerJobData.h
trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationOptions.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerRegistrationOptions.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225334 => 225335)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 19:14:04 UTC (rev 225334)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 19:17:55 UTC (rev 225335)
@@ -1,3 +1,23 @@
+2017-11-30  Chris Dumez  
+
+Rename RegistrationOptions to ServiceWorkerRegistrationOptions
+https://bugs.webkit.org/show_bug.cgi?id=180207
+
+Reviewed by Geoffrey Garen.
+
+Rename RegistrationOptions to ServiceWorkerRegistrationOptions as the name
+RegistrationOptions is too generic and likely to conflict. Also modernize
+ServiceWorkerRegistrationOptions' IPC decoder.
+
+* workers/service/ServiceWorkerContainer.h:
+* workers/service/ServiceWorkerJobData.h:
+(WebCore::ServiceWorkerJobData::decode):
+* workers/service/ServiceWorkerRegistrationOptions.cpp:
+(WebCore::ServiceWorkerRegistrationOptions::isolatedCopy const):
+* workers/service/ServiceWorkerRegistrationOptions.h:
+(WebCore::ServiceWorkerRegistrationOptions::encode const):
+(WebCore::ServiceWorkerRegistrationOptions::decode):
+
 2017-11-30  Darin Adler  
 
 [Mac] remove unneeded RetainPtr use introduced in r225142


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h (225334 => 225335)

--- trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h	2017-11-30 19:14:04 UTC (rev 225334)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h	2017-11-30 19:17:55 UTC (rev 225335)
@@ -53,13 +53,12 @@
 ServiceWorkerContainer(ScriptExecutionContext&, NavigatorBase&);
 ~ServiceWorkerContainer();
 
-typedef WebCore::RegistrationOptions RegistrationOptions;
-
 ServiceWorker* controller() const;
 
 using ReadyPromise = DOMPromiseProxy;
 ReadyPromise& ready() { return m_readyPromise; }
 
+using RegistrationOptions = ServiceWorkerRegistrationOptions;
 void addRegistration(const String& scriptURL, const RegistrationOptions&, Ref&&);
 void removeRegistration(const URL& scopeURL, Ref&&);
 void updateRegistration(const URL& scopeURL, const URL& scriptURL, WorkerType, Ref&&);


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerJobData.h (225334 => 225335)

--- trunk/Source/WebCore/workers/service/ServiceWorkerJobData.h	2017-11-30 19:14:04 UTC (rev 225334)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerJobData.h	2017-11-30 19:17:55 UTC (rev 225335)
@@ -51,7 +51,7 @@
 URL scopeURL;
 ServiceWorkerJobType type;
 
-RegistrationOptions registrationOptions;
+ServiceWorkerRegistrationOptions registrationOptions;
 
 Identifier identifier() const { return m_identifier; }
 ServiceWorkerRegistrationKey registrationKey() const;
@@ -89,11 +89,11 @@
 if (!identifier)
 return std::nullopt;
 
-std::optional jobData = { ServiceWorkerJobData { WTFMove(*identifier) } };
+ServiceWorkerJobData jobData { WTFMove(*identifier) };
 
-if (!decoder.decode(jobData->scriptURL))
+if (!decoder.decode(jobData.scriptURL))
 return std::nullopt;
-if (!decoder.decode(jobData->clientCreationURL))
+if (!decoder.decode(jobData.clientCreationURL))
 return std::nullopt;
 
 std::optional topOrigin;
@@ -100,24 +100,28 @@
 decoder >> topOrigin;
 if (!topOrigin)
 return std::nullopt;
-jobData->topOrigin = WTFMove(*topOrigin);
+jobData.topOrigin = WTFMove(*topOrigin);
 
-if (!decoder.decode(jobData->scopeURL))
+if (!decoder.decode(jobData.scopeURL))
 return std::nullopt;
-if (!decoder.decodeEnum(jobData->type))
+if (!decoder.decodeEnum(jobData.type))
 return std::nullopt;
 
-switch (jobData->type) 

[webkit-changes] [225336] trunk/Tools

[clopez]

Title: [225336] trunk/Tools








Revision 225336
Author clo...@igalia.com
Date 2017-11-30 11:29:54 -0800 (Thu, 30 Nov 2017)


Log Message
Add a script for automatically running the buildbot configurations on a test environment.
https://bugs.webkit.org/show_bug.cgi?id=169084

Reviewed by Michael Catanzaro.

This new script does the following:
- Creates a temporal workingdir.
- Installs buildbot and its dependencies there (very same version used by the webkit.org buildbot master https://build.webkit.org/about ).
  This is important as there are problems that that may not be detected if you don't test with the same version that will be used on production.
- Copies the buildmaster config files to the temporal workingdir.
- Performs the required steps to start a buildmaster.
- Creates the required config for each slave and starts all of them.

The test buildmaster should be accessible at http://localhost:8710/ allowing to trigger manual builds.
This allows to test any configuration changes on this test environment that is pretty much identical to the production one.

* BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py: Added.
(check_tcp_port_open):
(upgrade_db_needed):
(create_tempdir):
(print_if_error_stdout_stderr):
(setup_master_workdir):
(wait_for_master_ready):
(start_master):
(get_list_workers):
(start_worker):
(clean):
(cmd_exists):
(check_buildbot_installed):
(setup_virtualenv):
(configdir_is_valid):
(main):

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py




Diff

Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py (0 => 225336)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py	2017-11-30 19:29:54 UTC (rev 225336)
@@ -0,0 +1,347 @@
+#!/usr/bin/env python
+#
+# Copyright (C) 2017 Igalia S.L.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+#
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+#
+import sys
+import signal
+import os
+import argparse
+import subprocess
+import tempfile
+import shutil
+import socket
+import json
+import traceback
+import multiprocessing
+from time import sleep
+
+test_buildbot_master_tac = """
+import os
+from twisted.application import service
+try:
+from buildbot.master.bot import BuildMaster
+except:
+from buildbot.master import BuildMaster
+
+basedir = os.path.dirname(os.path.realpath(__file__))
+configfile = r'master.cfg'
+
+application = service.Application('buildmaster')
+BuildMaster(basedir, configfile).setServiceParent(application)
+"""
+
+worker_buildbot_master_tac = """
+import os
+from twisted.application import service
+from buildslave.bot import BuildSlave
+
+basedir = os.path.dirname(os.path.realpath(__file__))
+buildmaster_host = 'localhost'
+port = 17000
+slavename = '%(worker)s'
+passwd = '1234'
+keepalive = 600
+usepty = 1
+
+application = service.Application('buildslave')
+BuildSlave(buildmaster_host, port, slavename, passwd, basedir, keepalive, usepty).setServiceParent(application)
+"""
+
+
+def check_tcp_port_open(address, port):
+s = socket.socket()
+try:
+s.connect((address, port))
+return True
+except:
+return False
+
+
+def upgrade_db_needed(log):
+try:
+with open(log) as f:
+for l in f:
+if 'upgrade the database' in l:
+return True
+except:
+return False
+return False
+
+
+def create_tempdir(tmpdir=None):
+if tmpdir is not None:
+if not os.path.isdir(tmpdir):
+raise ValueError('%s is not a directory' % tmpdir)
+return 

[webkit-changes] [225338] trunk/LayoutTests

[cdumez]

Title: [225338] trunk/LayoutTests








Revision 225338
Author cdu...@apple.com
Date 2017-11-30 11:52:19 -0800 (Thu, 30 Nov 2017)


Log Message
Unreviewed, unskip a few Service Workers tests that no longer seem to be flaky.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (225337 => 225338)

--- trunk/LayoutTests/ChangeLog	2017-11-30 19:42:14 UTC (rev 225337)
+++ trunk/LayoutTests/ChangeLog	2017-11-30 19:52:19 UTC (rev 225338)
@@ -1,3 +1,9 @@
+2017-11-30  Chris Dumez  
+
+Unreviewed, unskip a few Service Workers tests that no longer seem to be flaky.
+
+* TestExpectations:
+
 2017-11-30  Ms2ger  
 
 [GTK] Enable all wpt touch-events tests.


Modified: trunk/LayoutTests/TestExpectations (225337 => 225338)

--- trunk/LayoutTests/TestExpectations	2017-11-30 19:42:14 UTC (rev 225337)
+++ trunk/LayoutTests/TestExpectations	2017-11-30 19:52:19 UTC (rev 225338)
@@ -188,16 +188,13 @@
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https.html [ Pass Failure ]
 webkit.org/b/179248 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https.html [ Pass Failure ]
-imported/w3c/web-platform-tests/service-workers/service-worker/fetch-header-visibility.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html [ Pass Failure Timeout ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/foreign-fetch-cors.https.html [ Pass Failure ]
-imported/w3c/web-platform-tests/service-workers/service-worker/invalid-header.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/multiple-update.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/performance-timeline.https.html [ Pass Failure ]
 webkit.org/b/179452 imported/w3c/web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https.html [ Pass Failure ]
 webkit.org/b/179194 imported/w3c/web-platform-tests/service-workers/service-worker/registration-mime-types.https.html [ Pass Failure ]
-imported/w3c/web-platform-tests/service-workers/service-worker/registration-script.https.html [ Pass Failure ]
 webkit.org/b/179138 imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-default.https.html [ Pass Failure ]
@@ -205,11 +202,9 @@
 imported/w3c/web-platform-tests/service-workers/service-worker/uncontrolled-page.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/update-bytecheck.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/unregister-controller.https.html [ Pass Failure ]
-imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html [ Pass Failure ]
-imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers.serviceworker.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ DumpJSConsoleLogInStdErr Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ DumpJSConsoleLogInStdErr Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225334] trunk/Tools

[aakash_jain]

Title: [225334] trunk/Tools








Revision 225334
Author aakash_j...@apple.com
Date 2017-11-30 11:14:04 -0800 (Thu, 30 Nov 2017)


Log Message
[build.webkit.org] Move python code from master.cfg in separate files
https://bugs.webkit.org/show_bug.cgi?id=180180

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved code to steps.py and master.cfg appropriately.
* BuildSlaveSupport/build.webkit.org-config/factories.py: Moved all factory related code from master.cfg.
* BuildSlaveSupport/build.webkit.org-config/steps.py: Moved all steps related code from master.cfg

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py




Diff

Added: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py (0 => 225334)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py	2017-11-30 19:14:04 UTC (rev 225334)
@@ -0,0 +1,193 @@
+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+from buildbot.process import factory
+from buildbot.steps import trigger
+
+from steps import *
+
+
+class Factory(factory.BuildFactory):
+def __init__(self, platform, configuration, architectures, buildOnly, additionalArguments, SVNMirror):
+factory.BuildFactory.__init__(self)
+self.addStep(ConfigureBuild(platform=platform, configuration=configuration, architecture=" ".join(architectures), buildOnly=buildOnly, additionalArguments=additionalArguments, SVNMirror=SVNMirror))
+if SVNMirror:
+self.addStep(WaitForSVNServer())
+self.addStep(CheckOutSource(SVNMirror=SVNMirror))
+if not (platform == "jsc-only"):
+self.addStep(KillOldProcesses())
+self.addStep(CleanBuildIfScheduled())
+self.addStep(DeleteStaleBuildFiles())
+if platform == "win":
+self.addStep(InstallWin32Dependencies())
+if platform == "gtk" and additionalArguments != ["--no-experimental-features"]:
+self.addStep(InstallGtkDependencies())
+if platform == "wpe":
+self.addStep(InstallWpeDependencies())
+
+
+class BuildFactory(Factory):
+def __init__(self, platform, configuration, architectures, triggers=None, additionalArguments=None, SVNMirror=None):
+Factory.__init__(self, platform, configuration, architectures, True, additionalArguments, SVNMirror)
+
+if platform == "win":
+self.addStep(CompileWebKit(timeout=2 * 60 * 60))
+else:
+self.addStep(CompileWebKit())
+
+if triggers:
+self.addStep(ArchiveBuiltProduct())
+self.addStep(UploadBuiltProduct())
+if platform.startswith('mac') or platform.startswith('ios-simulator'):
+self.addStep(ArchiveMinifiedBuiltProduct())
+self.addStep(UploadMinifiedBuiltProduct())
+self.addStep(TransferToS3())
+self.addStep(trigger.Trigger(schedulerNames=triggers))
+
+
+class TestFactory(Factory):
+JSCTestClass = RunJavaScriptCoreTests
+LayoutTestClass = RunWebKitTests
+
+def getProduct(self):
+self.addStep(DownloadBuiltProduct())
+self.addStep(ExtractBuiltProduct())
+
+def __init__(self, platform, configuration, architectures, additionalArguments=None, SVNMirror=None, **kwargs):
+Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, SVNMirror, **kwargs)
+

[webkit-changes] [225337] branches/safari-604-branch/Source

[jmarcell]

Title: [225337] branches/safari-604-branch/Source








Revision 225337
Author jmarc...@apple.com
Date 2017-11-30 11:42:14 -0800 (Thu, 30 Nov 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig (225336 => 225337)

--- branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-11-30 19:29:54 UTC (rev 225336)
+++ branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-11-30 19:42:14 UTC (rev 225337)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 604;
-MINOR_VERSION = 4;
-TINY_VERSION = 8;
+MINOR_VERSION = 5;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (225336 => 225337)

--- branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-11-30 19:29:54 UTC (rev 225336)
+++ branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-11-30 19:42:14 UTC (rev 225337)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 604;
-MINOR_VERSION = 4;
-TINY_VERSION = 8;
+MINOR_VERSION = 5;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig (225336 => 225337)

--- branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig	2017-11-30 19:29:54 UTC (rev 225336)
+++ branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig	2017-11-30 19:42:14 UTC (rev 225337)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 604;
-MINOR_VERSION = 4;
-TINY_VERSION = 8;
+MINOR_VERSION = 5;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (225336 => 225337)

--- branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-11-30 19:29:54 UTC (rev 225336)
+++ branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-11-30 19:42:14 UTC (rev 225337)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 604;
-MINOR_VERSION = 4;
-TINY_VERSION = 8;
+MINOR_VERSION = 5;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (225336 => 225337)

--- branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-11-30 19:29:54 UTC (rev 225336)
+++ branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-11-30 19:42:14 UTC (rev 225337)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 604;
-MINOR_VERSION = 4;
-TINY_VERSION = 8;
+MINOR_VERSION = 5;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig (225336 => 225337)

--- branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig	2017-11-30 19:29:54 UTC (rev 225336)
+++ branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig	2017-11-30 19:42:14 UTC (rev 225337)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 604;
-MINOR_VERSION = 4;
-TINY_VERSION = 8;
+MINOR_VERSION = 5;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (225336 => 225337)

--- branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2017-11-30 19:29:54 UTC (rev 225336)
+++ branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2017-11-30 19:42:14 UTC (rev 225337)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, 

[webkit-changes] [225333] trunk/Source/JavaScriptCore

[msaboff]

Title: [225333] trunk/Source/_javascript_Core








Revision 225333
Author msab...@apple.com
Date 2017-11-30 11:12:01 -0800 (Thu, 30 Nov 2017)


Log Message
Allow JSC command line tool to accept UTF8
https://bugs.webkit.org/show_bug.cgi?id=180205

Reviewed by Keith Miller.

This unifies the UTF8 handling of interactive mode with that of source files.

* jsc.cpp:
(runInteractive):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225332 => 225333)

--- trunk/Source/_javascript_Core/ChangeLog	2017-11-30 18:58:06 UTC (rev 225332)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-11-30 19:12:01 UTC (rev 225333)
@@ -1,3 +1,15 @@
+2017-11-30  Michael Saboff  
+
+Allow JSC command line tool to accept UTF8
+https://bugs.webkit.org/show_bug.cgi?id=180205
+
+Reviewed by Keith Miller.
+
+This unifies the UTF8 handling of interactive mode with that of source files.
+
+* jsc.cpp:
+(runInteractive):
+
 2017-11-30  Yusuke Suzuki  
 
 REGRESSION(r225314): [Linux] More than 2000 jsc tests are failing after r225314


Modified: trunk/Source/_javascript_Core/jsc.cpp (225332 => 225333)

--- trunk/Source/_javascript_Core/jsc.cpp	2017-11-30 18:58:06 UTC (rev 225332)
+++ trunk/Source/_javascript_Core/jsc.cpp	2017-11-30 19:12:01 UTC (rev 225333)
@@ -2310,7 +2310,7 @@
 shouldQuit = !line;
 if (!line)
 break;
-source = source + line;
+source = source + String::fromUTF8(line);
 source = source + '\n';
 checkSyntax(vm, makeSource(source, sourceOrigin), error);
 if (!line[0]) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225341] trunk

[cdumez]

Title: [225341] trunk








Revision 225341
Author cdu...@apple.com
Date 2017-11-30 12:40:04 -0800 (Thu, 30 Nov 2017)


Log Message
Populate self.registration.installing/waiting/active inside service workers
https://bugs.webkit.org/show_bug.cgi?id=180168

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline a couple of WPT that now pass for checks.

* web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https-expected.txt:
* web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:

Source/WebCore:

Populate self.registration.installing/waiting/active inside service workers.
Also make sure the ServiceWorker's state properly gets updated inside
service workers.

No new tests, extended existing test for self.registration.

* workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::scheduleTaskToUpdateState):
* workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::forEachServiceWorkerThread):
* workers/service/context/SWContextManager.h:
* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::fireInstallEvent):
(WebCore::ServiceWorkerThread::fireActivateEvent):
* workers/service/server/SWClientConnection.cpp:
(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::updateWorkerState):
(WebCore::SWClientConnection::fireUpdateFoundEvent):
* workers/service/server/SWClientConnection.h:

Source/WTF:

Add CrossThreadCopier support for std::optional<>.

* wtf/CrossThreadCopier.h:

LayoutTests:

Extend layout test coverage.

* http/tests/workers/service/resources/self_registration-worker.js:
* http/tests/workers/service/self_registration-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/workers/service/resources/self_registration-worker.js
trunk/LayoutTests/http/tests/workers/service/self_registration-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CrossThreadCopier.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorker.cpp
trunk/Source/WebCore/workers/service/context/SWContextManager.cpp
trunk/Source/WebCore/workers/service/context/SWContextManager.h
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
trunk/Source/WebCore/workers/service/server/SWClientConnection.cpp
trunk/Source/WebCore/workers/service/server/SWClientConnection.h




Diff

Modified: trunk/LayoutTests/ChangeLog (225340 => 225341)

--- trunk/LayoutTests/ChangeLog	2017-11-30 20:39:54 UTC (rev 225340)
+++ trunk/LayoutTests/ChangeLog	2017-11-30 20:40:04 UTC (rev 225341)
@@ -1,5 +1,17 @@
 2017-11-30  Chris Dumez  
 
+Populate self.registration.installing/waiting/active inside service workers
+https://bugs.webkit.org/show_bug.cgi?id=180168
+
+Reviewed by Brady Eidson.
+
+Extend layout test coverage.
+
+* http/tests/workers/service/resources/self_registration-worker.js:
+* http/tests/workers/service/self_registration-expected.txt:
+
+2017-11-30  Chris Dumez  
+
 Unreviewed, unskip a few Service Workers tests that no longer seem to be flaky.
 
 * TestExpectations:


Modified: trunk/LayoutTests/http/tests/workers/service/resources/self_registration-worker.js (225340 => 225341)

--- trunk/LayoutTests/http/tests/workers/service/resources/self_registration-worker.js	2017-11-30 20:39:54 UTC (rev 225340)
+++ trunk/LayoutTests/http/tests/workers/service/resources/self_registration-worker.js	2017-11-30 20:40:04 UTC (rev 225341)
@@ -5,11 +5,25 @@
 results.push(msg);
 }
 
+function dumpServiceWorker(workerName, serviceWorker)
+{
+if (!serviceWorker) {
+log(workerName + " worker: null");
+return;
+}
+log(workerName + " worker:");
+log("- scriptURL: " + serviceWorker.scriptURL);
+log("- state: " + serviceWorker.state);
+}
+
 function dumpRegistration()
 {
 log("* self.registration");
 log("scope: " + self.registration.scope);
 log("updateViaCache: " + self.registration.updateViaCache);
+dumpServiceWorker("installing", self.registration.installing);
+dumpServiceWorker("waiting", self.registration.waiting);
+dumpServiceWorker("active", self.registration.active);
 log("");
 }
 
@@ -16,11 +30,26 @@
 self.addEventListener("install", function() {
 log("Received install event");
 dumpRegistration();
+
+if (self.registration.installing) {
+self.registration.installing.addEventListener("statechange", function() {
+log("Received statechange event on service worker");
+})
+}
 });
 

[webkit-changes] [225342] trunk

[utatane . tea]

Title: [225342] trunk








Revision 225342
Author utatane@gmail.com
Date 2017-11-30 12:48:53 -0800 (Thu, 30 Nov 2017)


Log Message
[DFG][FTL] operationHasIndexedProperty does not consider negative int32_t
https://bugs.webkit.org/show_bug.cgi?id=180190

Reviewed by Mark Lam.

JSTests:

* stress/operation-in-may-have-negative-int32-array-storage.js: Added.
(shouldBe):
(test1):
* stress/operation-in-may-have-negative-int32-contiguous-array.js: Added.
(shouldBe):
(test1):
* stress/operation-in-may-have-negative-int32-double-array.js: Added.
(shouldBe):
(test1):
* stress/operation-in-may-have-negative-int32-generic-array.js: Added.
(shouldBe):
(test1):
* stress/operation-in-may-have-negative-int32-int32-array.js: Added.
(shouldBe):
(test1):
* stress/operation-in-may-have-negative-int32.js: Added.
(shouldBe):
(test2):
* stress/operation-in-negative-int32-cast.js: Added.
(shouldBe):
(test1):

Source/_javascript_Core:

If DFG HasIndexedProperty node observes negative index, it goes to a slow
path by calling operationHasIndexedProperty. The problem is that
operationHasIndexedProperty does not account negative index. Negative index
was used as uint32 array index.

In this patch we add a path for negative index in operationHasIndexedProperty.
And rename it to operationHasIndexedPropertyByInt to make intension clear.
We also move operationHasIndexedPropertyByInt from JITOperations to DFGOperations
since it is only used in DFG and FTL.

While fixing this bug, we found that our op_in does not record OutOfBound feedback.
This causes repeated OSR exit and significantly regresses the performance. We opened
a bug to track this issue[1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=180192

* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):
* jit/JITOperations.cpp:
* jit/JITOperations.h:

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/JITOperations.cpp
trunk/Source/_javascript_Core/jit/JITOperations.h


Added Paths

trunk/JSTests/stress/operation-in-may-have-negative-int32-array-storage.js
trunk/JSTests/stress/operation-in-may-have-negative-int32-contiguous-array.js
trunk/JSTests/stress/operation-in-may-have-negative-int32-double-array.js
trunk/JSTests/stress/operation-in-may-have-negative-int32-generic-array.js
trunk/JSTests/stress/operation-in-may-have-negative-int32-int32-array.js
trunk/JSTests/stress/operation-in-may-have-negative-int32.js
trunk/JSTests/stress/operation-in-negative-int32-cast.js




Diff

Modified: trunk/JSTests/ChangeLog (225341 => 225342)

--- trunk/JSTests/ChangeLog	2017-11-30 20:40:04 UTC (rev 225341)
+++ trunk/JSTests/ChangeLog	2017-11-30 20:48:53 UTC (rev 225342)
@@ -1,3 +1,32 @@
+2017-11-30  Yusuke Suzuki  
+
+[DFG][FTL] operationHasIndexedProperty does not consider negative int32_t
+https://bugs.webkit.org/show_bug.cgi?id=180190
+
+Reviewed by Mark Lam.
+
+* stress/operation-in-may-have-negative-int32-array-storage.js: Added.
+(shouldBe):
+(test1):
+* stress/operation-in-may-have-negative-int32-contiguous-array.js: Added.
+(shouldBe):
+(test1):
+* stress/operation-in-may-have-negative-int32-double-array.js: Added.
+(shouldBe):
+(test1):
+* stress/operation-in-may-have-negative-int32-generic-array.js: Added.
+(shouldBe):
+(test1):
+* stress/operation-in-may-have-negative-int32-int32-array.js: Added.
+(shouldBe):
+(test1):
+* stress/operation-in-may-have-negative-int32.js: Added.
+(shouldBe):
+(test2):
+* stress/operation-in-negative-int32-cast.js: Added.
+(shouldBe):
+(test1):
+
 2017-11-28  JF Bastien  
 
 Strict and sloppy functions shouldn't share structure


Added: trunk/JSTests/stress/operation-in-may-have-negative-int32-array-storage.js (0 => 225342)

--- trunk/JSTests/stress/operation-in-may-have-negative-int32-array-storage.js	(rev 0)
+++ trunk/JSTests/stress/operation-in-may-have-negative-int32-array-storage.js	2017-11-30 20:48:53 UTC (rev 225342)
@@ -0,0 +1,19 @@
+function shouldBe(actual, expected)
+{
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+var k = -1;
+var o1 = [20];
+o1[k] = 42;
+ensureArrayStorage(o1);
+
+function test1(o)
+{
+return k in o;
+}
+noInline(test1);
+
+for (var i = 0; i < 1e6; ++i)
+

[webkit-changes] [225347] trunk/Source/WebCore

[cdumez]

Title: [225347] trunk/Source/WebCore








Revision 225347
Author cdu...@apple.com
Date 2017-11-30 13:42:29 -0800 (Thu, 30 Nov 2017)


Log Message
SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=180214

Reviewed by Brady Eidson.

SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted.
RefCounted is sufficient as there is no longer any multithreading on server side.

* workers/service/server/SWServerToContextConnection.h:
* workers/service/server/SWServerWorker.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h
trunk/Source/WebCore/workers/service/server/SWServerWorker.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225346 => 225347)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 21:41:59 UTC (rev 225346)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 21:42:29 UTC (rev 225347)
@@ -1,5 +1,18 @@
 2017-11-30  Chris Dumez  
 
+SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted
+https://bugs.webkit.org/show_bug.cgi?id=180214
+
+Reviewed by Brady Eidson.
+
+SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted.
+RefCounted is sufficient as there is no longer any multithreading on server side.
+
+* workers/service/server/SWServerToContextConnection.h:
+* workers/service/server/SWServerWorker.h:
+
+2017-11-30  Chris Dumez  
+
 ServiceWorkerGlobalScope::skipWaiting() should resolve its promise
 https://bugs.webkit.org/show_bug.cgi?id=180204
 


Modified: trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h (225346 => 225347)

--- trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h	2017-11-30 21:41:59 UTC (rev 225346)
+++ trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h	2017-11-30 21:42:29 UTC (rev 225347)
@@ -29,7 +29,7 @@
 
 #include "ServiceWorkerIdentifier.h"
 #include "ServiceWorkerTypes.h"
-#include 
+#include 
 
 namespace WebCore {
 
@@ -37,7 +37,7 @@
 struct ServiceWorkerContextData;
 struct ServiceWorkerJobDataIdentifier;
 
-class SWServerToContextConnection : public ThreadSafeRefCounted {
+class SWServerToContextConnection : public RefCounted {
 public:
 WEBCORE_EXPORT virtual ~SWServerToContextConnection();
 


Modified: trunk/Source/WebCore/workers/service/server/SWServerWorker.h (225346 => 225347)

--- trunk/Source/WebCore/workers/service/server/SWServerWorker.h	2017-11-30 21:41:59 UTC (rev 225346)
+++ trunk/Source/WebCore/workers/service/server/SWServerWorker.h	2017-11-30 21:42:29 UTC (rev 225347)
@@ -32,7 +32,7 @@
 #include "ServiceWorkerRegistrationKey.h"
 #include "ServiceWorkerTypes.h"
 #include "URL.h"
-#include 
+#include 
 
 namespace WebCore {
 
@@ -41,7 +41,7 @@
 enum class WorkerType;
 struct ServiceWorkerJobDataIdentifier;
 
-class SWServerWorker : public ThreadSafeRefCounted {
+class SWServerWorker : public RefCounted {
 public:
 template  static Ref create(Args&&... args)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225346] trunk

[cdumez]

Title: [225346] trunk








Revision 225346
Author cdu...@apple.com
Date 2017-11-30 13:41:59 -0800 (Thu, 30 Nov 2017)


Log Message
ServiceWorkerGlobalScope::skipWaiting() should resolve its promise
https://bugs.webkit.org/show_bug.cgi?id=180204

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline test which uses skipWaiting().

* web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt:

Source/WebCore:

ServiceWorkerGlobalScope::skipWaiting() should resolve its promise, even if it is not
implemented yet. For now, always reject the promise.

* workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::skipWaiting):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (225345 => 225346)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-11-30 21:35:47 UTC (rev 225345)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-11-30 21:41:59 UTC (rev 225346)
@@ -1,5 +1,16 @@
 2017-11-30  Chris Dumez  
 
+ServiceWorkerGlobalScope::skipWaiting() should resolve its promise
+https://bugs.webkit.org/show_bug.cgi?id=180204
+
+Reviewed by Brady Eidson.
+
+Rebaseline test which uses skipWaiting().
+
+* web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt:
+
+2017-11-30  Chris Dumez  
+
 Populate self.registration.installing/waiting/active inside service workers
 https://bugs.webkit.org/show_bug.cgi?id=180168
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt (225345 => 225346)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt	2017-11-30 21:35:47 UTC (rev 225345)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt	2017-11-30 21:41:59 UTC (rev 225346)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Cannot update a null/nonexistent service worker registration
+CONSOLE MESSAGE: line 27: Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'r.update')
   
 
 FAIL Claim works after redirection to another origin assert_equals: expected (string) "updated" but got (undefined) undefined


Modified: trunk/Source/WebCore/ChangeLog (225345 => 225346)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 21:35:47 UTC (rev 225345)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 21:41:59 UTC (rev 225346)
@@ -1,5 +1,18 @@
 2017-11-30  Chris Dumez  
 
+ServiceWorkerGlobalScope::skipWaiting() should resolve its promise
+https://bugs.webkit.org/show_bug.cgi?id=180204
+
+Reviewed by Brady Eidson.
+
+ServiceWorkerGlobalScope::skipWaiting() should resolve its promise, even if it is not
+implemented yet. For now, always reject the promise.
+
+* workers/service/ServiceWorkerGlobalScope.cpp:
+(WebCore::ServiceWorkerGlobalScope::skipWaiting):
+
+2017-11-30  Chris Dumez  
+
 Mark a few heap-allocated service worker types as WTF_MAKE_FAST_ALLOCATED
 https://bugs.webkit.org/show_bug.cgi?id=180212
 


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp (225345 => 225346)

--- trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp	2017-11-30 21:35:47 UTC (rev 225345)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp	2017-11-30 21:41:59 UTC (rev 225346)
@@ -46,8 +46,10 @@
 
 ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope() = default;
 
-void ServiceWorkerGlobalScope::skipWaiting(Ref&&)
+void ServiceWorkerGlobalScope::skipWaiting(Ref&& promise)
 {
+// FIXME: Implement this.
+promise->reject(Exception { NotSupportedError, ASCIILiteral("self.skipWaiting() is not yet supported") });
 }
 
 EventTargetInterface ServiceWorkerGlobalScope::eventTargetInterface() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225349] trunk/LayoutTests

[jlewis3]

Title: [225349] trunk/LayoutTests








Revision 225349
Author jlew...@apple.com
Date 2017-11-30 14:21:31 -0800 (Thu, 30 Nov 2017)


Log Message
Marked http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html as flaky on High Sierra.
https://bugs.webkit.org/show_bug.cgi?id=179644

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (225348 => 225349)

--- trunk/LayoutTests/ChangeLog	2017-11-30 21:49:05 UTC (rev 225348)
+++ trunk/LayoutTests/ChangeLog	2017-11-30 22:21:31 UTC (rev 225349)
@@ -1,5 +1,14 @@
 2017-11-30  Matt Lewis  
 
+Marked http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html as flaky on High Sierra.
+https://bugs.webkit.org/show_bug.cgi?id=179644
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2017-11-30  Matt Lewis  
+
 Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded.html as flak on macOS.
 https://bugs.webkit.org/show_bug.cgi?id=176078
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (225348 => 225349)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-11-30 21:49:05 UTC (rev 225348)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-11-30 22:21:31 UTC (rev 225349)
@@ -796,7 +796,6 @@
 [ HighSierra+ ] http/tests/ssl/applepay/ApplePaySessionV3.html [ Pass ]
 # 
 [ HighSierra+ ] http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html [ Pass ]
-[ HighSierra+ ] http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html [ Pass ]
 [ HighSierra+ ] http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout.html [ Pass Failure ]
 [ HighSierra+ ] http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html [ Pass Failure ]
 [ HighSierra+ ] http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html [ Pass ]
@@ -837,3 +836,4 @@
 
 webkit.org/b/176078 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded.html [ Pass Failure ]
 
+webkit.org/b/179644 [ HighSierra Release ] http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225343] trunk/Source/WebCore

[beidson]

Title: [225343] trunk/Source/WebCore








Revision 225343
Author beid...@apple.com
Date 2017-11-30 13:01:12 -0800 (Thu, 30 Nov 2017)


Log Message
Make WorkerThread lifetime much more predictable.
https://bugs.webkit.org/show_bug.cgi?id=180203

Reviewed by Chris Dumez.

No new tests (Fixes flakiness in existing and future tests).

The family of classes related to Workers has a complicated ownership model.

For Dedicated Workers, the WorkerThread object is owned by the WorkerMessagingProxy,
which manages its own lifetime. Additionally, other object(s) have raw C++ references
to it, and the expected lifetimes are described in comments scattered through a few files.

What it boils down to is that the "Worker" DOM object - which lives on the main thread -
is the key to the proper destruction of all of these objects.

For ServiceWorkers running in their own context process, there is no "Worker" on the main thread.

As a result, ServiceWorkers can get into a situation where their WorkerThread can be destroyed before
their ServiceWorkerGlobalScope is destroyed on the running background thread.

There's no reason to not have WorkerThread guarantee its own lifetime until its background thread
has actually completed.

* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread): Protect the WorkerThread object during the entire runtime
  of the background thread itself, and release that protection on the main thread.
* workers/WorkerThread.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerThread.cpp
trunk/Source/WebCore/workers/WorkerThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225342 => 225343)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 20:48:53 UTC (rev 225342)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 21:01:12 UTC (rev 225343)
@@ -1,3 +1,34 @@
+2017-11-30  Brady Eidson  
+
+Make WorkerThread lifetime much more predictable.
+https://bugs.webkit.org/show_bug.cgi?id=180203
+
+Reviewed by Chris Dumez.
+
+No new tests (Fixes flakiness in existing and future tests).
+
+The family of classes related to Workers has a complicated ownership model.
+
+For Dedicated Workers, the WorkerThread object is owned by the WorkerMessagingProxy,
+which manages its own lifetime. Additionally, other object(s) have raw C++ references
+to it, and the expected lifetimes are described in comments scattered through a few files.
+
+What it boils down to is that the "Worker" DOM object - which lives on the main thread - 
+is the key to the proper destruction of all of these objects.
+
+For ServiceWorkers running in their own context process, there is no "Worker" on the main thread.
+
+As a result, ServiceWorkers can get into a situation where their WorkerThread can be destroyed before
+their ServiceWorkerGlobalScope is destroyed on the running background thread.
+
+There's no reason to not have WorkerThread guarantee its own lifetime until its background thread
+has actually completed.
+
+* workers/WorkerThread.cpp:
+(WebCore::WorkerThread::workerThread): Protect the WorkerThread object during the entire runtime
+  of the background thread itself, and release that protection on the main thread.
+* workers/WorkerThread.h:
+
 2017-11-30  Chris Dumez  
 
 Populate self.registration.installing/waiting/active inside service workers


Modified: trunk/Source/WebCore/workers/WorkerThread.cpp (225342 => 225343)

--- trunk/Source/WebCore/workers/WorkerThread.cpp	2017-11-30 20:48:53 UTC (rev 225342)
+++ trunk/Source/WebCore/workers/WorkerThread.cpp	2017-11-30 21:01:12 UTC (rev 225343)
@@ -149,6 +149,8 @@
 
 void WorkerThread::workerThread()
 {
+auto protectedThis = makeRef(*this);
+
 // Propagate the mainThread's fenv to workers.
 #if PLATFORM(IOS)
 FloatingPointEnvironment::singleton().propagateMainThreadEnvironment();
@@ -231,6 +233,9 @@
 // Clean up WebCore::ThreadGlobalData before WTF::Thread goes away!
 threadGlobalData().destroy();
 
+// Send the last WorkerThread Ref to be Deref'ed on the main thread.
+callOnMainThread([protectedThis = WTFMove(protectedThis)] { });
+
 // The thread object may be already destroyed from notification now, don't try to access "this".
 protector->detach();
 }


Modified: trunk/Source/WebCore/workers/WorkerThread.h (225342 => 225343)

--- trunk/Source/WebCore/workers/WorkerThread.h	2017-11-30 20:48:53 UTC (rev 225342)
+++ trunk/Source/WebCore/workers/WorkerThread.h	2017-11-30 21:01:12 UTC (rev 225343)
@@ -59,7 +59,7 @@
 
 struct WorkerThreadStartupData;
 
-class WorkerThread : public RefCounted {
+class WorkerThread : public ThreadSafeRefCounted {
 public:
 virtual ~WorkerThread();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [225345] branches/safari-604-branch

[jmarcell]

Title: [225345] branches/safari-604-branch








Revision 225345
Author jmarc...@apple.com
Date 2017-11-30 13:35:47 -0800 (Thu, 30 Nov 2017)


Log Message
Cherry-pick r225141. rdar://problem/35732184

Modified Paths

branches/safari-604-branch/LayoutTests/ChangeLog
branches/safari-604-branch/Source/WebCore/ChangeLog
branches/safari-604-branch/Source/WebCore/platform/CalculationValue.cpp
branches/safari-604-branch/Source/WebCore/platform/CalculationValue.h


Added Paths

branches/safari-604-branch/LayoutTests/transitions/transition-with-calc-spin-expected.txt
branches/safari-604-branch/LayoutTests/transitions/transition-with-calc-spin.html




Diff

Modified: branches/safari-604-branch/LayoutTests/ChangeLog (225344 => 225345)

--- branches/safari-604-branch/LayoutTests/ChangeLog	2017-11-30 21:16:22 UTC (rev 225344)
+++ branches/safari-604-branch/LayoutTests/ChangeLog	2017-11-30 21:35:47 UTC (rev 225345)
@@ -1,3 +1,18 @@
+2017-11-30  Jason Marcell  
+
+Cherry-pick r225141. rdar://problem/35732184
+
+2017-11-24  Antti Koivisto  
+
+Style resolution spin due to calc() values always comparing inequal (seen on arstechnica.com)
+https://bugs.webkit.org/show_bug.cgi?id=179982
+
+
+Reviewed by Darin Adler.
+
+* transitions/transition-with-calc-spin-expected.txt: Added.
+* transitions/transition-with-calc-spin.html: Added.
+
 2017-11-03  Jason Marcell  
 
 Cherry-pick r224405. rdar://problem/35339758


Added: branches/safari-604-branch/LayoutTests/transitions/transition-with-calc-spin-expected.txt (0 => 225345)

--- branches/safari-604-branch/LayoutTests/transitions/transition-with-calc-spin-expected.txt	(rev 0)
+++ branches/safari-604-branch/LayoutTests/transitions/transition-with-calc-spin-expected.txt	2017-11-30 21:35:47 UTC (rev 225345)
@@ -0,0 +1,3 @@
+Test that calc values in transitions don't lead to a style resolution spin.
+PASS
+


Added: branches/safari-604-branch/LayoutTests/transitions/transition-with-calc-spin.html (0 => 225345)

--- branches/safari-604-branch/LayoutTests/transitions/transition-with-calc-spin.html	(rev 0)
+++ branches/safari-604-branch/LayoutTests/transitions/transition-with-calc-spin.html	2017-11-30 21:35:47 UTC (rev 225345)
@@ -0,0 +1,39 @@
+
+#testdiv {
+background-color: inherit; /* needed to dodge the matched properties cache */
+}
+.test {
+transition: 1s;
+width: calc(100% - 10px); /* calc compares inequal with the same exact calc value */
+}
+
+
+Test that calc values in transitions don't lead to a style resolution spin.
+
+
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+function test() {
+document.body.offsetWidth;
+
+const startStyleRecalcCount = window.internals ? internals.styleRecalcCount() : 0;
+
+testdiv.classList.add('test');
+
+if (!window.internals)
+return;
+setTimeout(() => {
+   const styleRecalcCount = internals.styleRecalcCount() - startStyleRecalcCount;
+   if (styleRecalcCount <= 3)
+   log.innerHTML = "PASS"
+   else
+   log.innerHTML = `FAIL: styleRecalcCount: ${ internals.styleRecalcCount() - startStyleRecalcCount}`;
+   testRunner.notifyDone();
+}, 10);
+}
+
+


Modified: branches/safari-604-branch/Source/WebCore/ChangeLog (225344 => 225345)

--- branches/safari-604-branch/Source/WebCore/ChangeLog	2017-11-30 21:16:22 UTC (rev 225344)
+++ branches/safari-604-branch/Source/WebCore/ChangeLog	2017-11-30 21:35:47 UTC (rev 225345)
@@ -1,3 +1,27 @@
+2017-11-30  Jason Marcell  
+
+Cherry-pick r225141. rdar://problem/35732184
+
+2017-11-24  Antti Koivisto  
+
+Style resolution spin due to calc() values always comparing inequal (seen on arstechnica.com)
+https://bugs.webkit.org/show_bug.cgi?id=179982
+
+
+Reviewed by Darin Adler.
+
+Test: transitions/transition-with-calc-spin.html
+
+Something like calc(100% - 10px) would compare inequal to itself. This causes the implicit animation engine think that
+there is a new target value after style resolution and restart the transition. Starting the transition triggers another style
+resolution on zero duration timer and so on.
+
+* platform/CalculationValue.cpp:
+(WebCore::operator==):
+* platform/CalculationValue.h:
+
+Deep compare the child vectors.
+
 2017-11-03  Jason Marcell  
 
 Cherry-pick r224405. rdar://problem/35339758


Modified: branches/safari-604-branch/Source/WebCore/platform/CalculationValue.cpp (225344 => 225345)

--- branches/safari-604-branch/Source/WebCore/platform/CalculationValue.cpp	2017-11-30 21:16:22 UTC (rev 225344)
+++ 

[webkit-changes] [225344] trunk/Source/WebCore

[cdumez]

Title: [225344] trunk/Source/WebCore








Revision 225344
Author cdu...@apple.com
Date 2017-11-30 13:16:22 -0800 (Thu, 30 Nov 2017)


Log Message
Mark a few heap-allocated service worker types as WTF_MAKE_FAST_ALLOCATED
https://bugs.webkit.org/show_bug.cgi?id=180212

Reviewed by Geoffrey Garen.

Mark a few heap-allocated service worker types as WTF_MAKE_FAST_ALLOCATED for performance.

* workers/service/server/SWOriginStore.h:
* workers/service/server/SWServer.h:
* workers/service/server/SWServerJobQueue.h:
* workers/service/server/SWServerRegistration.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/server/SWOriginStore.h
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebCore/workers/service/server/SWServerJobQueue.h
trunk/Source/WebCore/workers/service/server/SWServerRegistration.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225343 => 225344)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 21:01:12 UTC (rev 225343)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 21:16:22 UTC (rev 225344)
@@ -1,3 +1,17 @@
+2017-11-30  Chris Dumez  
+
+Mark a few heap-allocated service worker types as WTF_MAKE_FAST_ALLOCATED
+https://bugs.webkit.org/show_bug.cgi?id=180212
+
+Reviewed by Geoffrey Garen.
+
+Mark a few heap-allocated service worker types as WTF_MAKE_FAST_ALLOCATED for performance.
+
+* workers/service/server/SWOriginStore.h:
+* workers/service/server/SWServer.h:
+* workers/service/server/SWServerJobQueue.h:
+* workers/service/server/SWServerRegistration.h:
+
 2017-11-30  Brady Eidson  
 
 Make WorkerThread lifetime much more predictable.


Modified: trunk/Source/WebCore/workers/service/server/SWOriginStore.h (225343 => 225344)

--- trunk/Source/WebCore/workers/service/server/SWOriginStore.h	2017-11-30 21:01:12 UTC (rev 225343)
+++ trunk/Source/WebCore/workers/service/server/SWOriginStore.h	2017-11-30 21:16:22 UTC (rev 225344)
@@ -34,6 +34,7 @@
 class SecurityOrigin;
 
 class SWOriginStore {
+WTF_MAKE_FAST_ALLOCATED;
 public:
 virtual ~SWOriginStore() = default;
 


Modified: trunk/Source/WebCore/workers/service/server/SWServer.h (225343 => 225344)

--- trunk/Source/WebCore/workers/service/server/SWServer.h	2017-11-30 21:01:12 UTC (rev 225343)
+++ trunk/Source/WebCore/workers/service/server/SWServer.h	2017-11-30 21:16:22 UTC (rev 225344)
@@ -60,9 +60,11 @@
 struct ServiceWorkerRegistrationData;
 
 class SWServer {
+WTF_MAKE_FAST_ALLOCATED;
 public:
 class Connection {
-friend class SWServer;
+WTF_MAKE_FAST_ALLOCATED;
+friend class SWServer;
 public:
 WEBCORE_EXPORT virtual ~Connection();
 


Modified: trunk/Source/WebCore/workers/service/server/SWServerJobQueue.h (225343 => 225344)

--- trunk/Source/WebCore/workers/service/server/SWServerJobQueue.h	2017-11-30 21:01:12 UTC (rev 225343)
+++ trunk/Source/WebCore/workers/service/server/SWServerJobQueue.h	2017-11-30 21:16:22 UTC (rev 225344)
@@ -35,6 +35,7 @@
 namespace WebCore {
 
 class SWServerJobQueue {
+WTF_MAKE_FAST_ALLOCATED;
 public:
 explicit SWServerJobQueue(SWServer&, const ServiceWorkerRegistrationKey&);
 SWServerJobQueue(const SWServerRegistration&) = delete;


Modified: trunk/Source/WebCore/workers/service/server/SWServerRegistration.h (225343 => 225344)

--- trunk/Source/WebCore/workers/service/server/SWServerRegistration.h	2017-11-30 21:01:12 UTC (rev 225343)
+++ trunk/Source/WebCore/workers/service/server/SWServerRegistration.h	2017-11-30 21:16:22 UTC (rev 225344)
@@ -44,6 +44,7 @@
 struct ServiceWorkerFetchResult;
 
 class SWServerRegistration {
+WTF_MAKE_FAST_ALLOCATED;
 public:
 SWServerRegistration(SWServer&, const ServiceWorkerRegistrationKey&, ServiceWorkerUpdateViaCache, const URL& scopeURL, const URL& scriptURL);
 ~SWServerRegistration();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225348] trunk/LayoutTests

[jlewis3]

Title: [225348] trunk/LayoutTests








Revision 225348
Author jlew...@apple.com
Date 2017-11-30 13:49:05 -0800 (Thu, 30 Nov 2017)


Log Message
Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded.html as flak on macOS.
https://bugs.webkit.org/show_bug.cgi?id=176078

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (225347 => 225348)

--- trunk/LayoutTests/ChangeLog	2017-11-30 21:42:29 UTC (rev 225347)
+++ trunk/LayoutTests/ChangeLog	2017-11-30 21:49:05 UTC (rev 225348)
@@ -1,3 +1,12 @@
+2017-11-30  Matt Lewis  
+
+Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded.html as flak on macOS.
+https://bugs.webkit.org/show_bug.cgi?id=176078
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2017-11-30  Chris Dumez  
 
 Populate self.registration.installing/waiting/active inside service workers


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (225347 => 225348)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-11-30 21:42:29 UTC (rev 225347)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-11-30 21:49:05 UTC (rev 225348)
@@ -834,3 +834,6 @@
 webkit.org/b/179176 [ Release ] svg/wicd/test-rightsizing-a.xhtml [ Pass Failure ]
 
 webkit.org/b/179773 imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html [ Pass Failure ]
+
+webkit.org/b/176078 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded.html [ Pass Failure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225350] trunk/LayoutTests

[dino]

Title: [225350] trunk/LayoutTests








Revision 225350
Author d...@apple.com
Date 2017-11-30 14:25:52 -0800 (Thu, 30 Nov 2017)


Log Message
Skip WebGL on iOS while working out what ANGLE has broken.

* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (225349 => 225350)

--- trunk/LayoutTests/ChangeLog	2017-11-30 22:21:31 UTC (rev 225349)
+++ trunk/LayoutTests/ChangeLog	2017-11-30 22:25:52 UTC (rev 225350)
@@ -1,3 +1,9 @@
+2017-11-30  Dean Jackson  
+
+Skip WebGL on iOS while working out what ANGLE has broken.
+
+* platform/ios/TestExpectations:
+
 2017-11-30  Matt Lewis  
 
 Marked http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html as flaky on High Sierra.


Modified: trunk/LayoutTests/platform/ios/TestExpectations (225349 => 225350)

--- trunk/LayoutTests/platform/ios/TestExpectations	2017-11-30 22:21:31 UTC (rev 225349)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2017-11-30 22:25:52 UTC (rev 225350)
@@ -3275,3 +3275,6 @@
 
 # 
 media/modern-media-controls/time-labels-support/elapsed-time.html [ Skip ]
+
+# Skip WebGL while the ANGLE update has caused many failures
+webgl [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225332] trunk/Tools

[wenson_hsieh]

Title: [225332] trunk/Tools








Revision 225332
Author wenson_hs...@apple.com
Date 2017-11-30 10:58:06 -0800 (Thu, 30 Nov 2017)


Log Message
WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS bots
https://bugs.webkit.org/show_bug.cgi?id=180200

Reviewed by Alexey Proskuryakov.

Rewrites an API test to avoid checking against the hard-coded platform-dependent size of an attachment element.
Instead, first insert the attachment element as an icon and compute its size, and then check that the size of
the element is restored to this original value after toggling the display mode to in-place mode and back.

* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(-[TestWKWebView attachmentElementSize]):
(-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
(TestWebKitAPI::TEST):
(platformAttachmentIconElementSize): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm




Diff

Modified: trunk/Tools/ChangeLog (225331 => 225332)

--- trunk/Tools/ChangeLog	2017-11-30 18:17:07 UTC (rev 225331)
+++ trunk/Tools/ChangeLog	2017-11-30 18:58:06 UTC (rev 225332)
@@ -1,3 +1,20 @@
+2017-11-30  Wenson Hsieh  
+
+WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS bots
+https://bugs.webkit.org/show_bug.cgi?id=180200
+
+Reviewed by Alexey Proskuryakov.
+
+Rewrites an API test to avoid checking against the hard-coded platform-dependent size of an attachment element.
+Instead, first insert the attachment element as an icon and compute its size, and then check that the size of
+the element is restored to this original value after toggling the display mode to in-place mode and back.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+(-[TestWKWebView attachmentElementSize]):
+(-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
+(TestWebKitAPI::TEST):
+(platformAttachmentIconElementSize): Deleted.
+
 2017-11-30  Michael Catanzaro  
 
 [WPE] Stop building Wayland in JHBuild moduleset


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm (225331 => 225332)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm	2017-11-30 18:17:07 UTC (rev 225331)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm	2017-11-30 18:58:06 UTC (rev 225332)
@@ -34,15 +34,6 @@
 
 #if WK_API_ENABLED
 
-CGSize platformAttachmentIconElementSize()
-{
-#if PLATFORM(IOS)
-return CGSizeMake(160, 119);
-#else
-return CGSizeMake(61, 89);
-#endif
-}
-
 @interface AttachmentUpdateObserver : NSObject 
 @property (nonatomic, readonly) NSArray *inserted;
 @property (nonatomic, readonly) NSArray *removed;
@@ -192,18 +183,22 @@
 return attachment.autorelease();
 }
 
+- (CGSize)attachmentElementSize
+{
+__block CGSize size;
+__block bool doneEvaluatingScript = false;
+[self evaluateJavaScript:@"r = document.querySelector('attachment').getBoundingClientRect(); [r.width, r.height]" completionHandler:^(NSArray *sizeResult, NSError *) {
+size = CGSizeMake(sizeResult.firstObject.floatValue, sizeResult.lastObject.floatValue);
+doneEvaluatingScript = true;
+}];
+TestWebKitAPI::Util::run();
+return size;
+}
+
 - (void)waitForAttachmentElementSizeToBecome:(CGSize)expectedSize
 {
 while ([[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantPast]]) {
-__block bool doneEvaluatingScript = false;
-__block BOOL sizeIsEqual = NO;
-[self evaluateJavaScript:@"r = document.querySelector('attachment').getBoundingClientRect(); [r.width, r.height]" completionHandler:^(NSArray *sizeResult, NSError *) {
-CGSize observedSize { sizeResult.firstObject.floatValue, sizeResult.lastObject.floatValue };
-sizeIsEqual = CGSizeEqualToSize(expectedSize, observedSize);
-doneEvaluatingScript = true;
-}];
-TestWebKitAPI::Util::run();
-if (sizeIsEqual)
+if (CGSizeEqualToSize(self.attachmentElementSize, expectedSize))
 break;
 }
 }
@@ -499,15 +494,19 @@
 RetainPtr<_WKAttachment> attachment;
 {
 ObserveAttachmentUpdatesForScope observer(webView.get());
-attachment = retainPtr([webView synchronouslyInsertAttachmentWithFilename:@"icon.png" contentType:@"image/png" data:imageData.get() options:displayOptionsWithMode(_WKAttachmentDisplayModeInPlace)]);
+attachment = retainPtr([webView synchronouslyInsertAttachmentWithFilename:@"icon.png" contentType:@"image/png" data:imageData.get() options:displayOptionsWithMode(_WKAttachmentDisplayModeAsIcon)]);
+[attachment expectRequestedDataToBe:imageData.get()];
 observer.expectAttachmentUpdates(@[], @[attachment.get()]);
-[attachment expectRequestedDataToBe:imageData.get()];
-[webView 

[webkit-changes] [225339] tags/Safari-604.5.1/

[jmarcell]

Title: [225339] tags/Safari-604.5.1/








Revision 225339
Author jmarc...@apple.com
Date 2017-11-30 11:54:45 -0800 (Thu, 30 Nov 2017)


Log Message
Tag Safari-604.5.1.

Added Paths

tags/Safari-604.5.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225368] trunk/Source

[commit-queue]

Title: [225368] trunk/Source








Revision 225368
Author commit-qu...@webkit.org
Date 2017-11-30 16:14:34 -0800 (Thu, 30 Nov 2017)


Log Message
Unreviewed, rolling out r225362.
https://bugs.webkit.org/show_bug.cgi?id=180225

removeIf predicate function can touch remove target set
(Requested by yusukesuzuki on #webkit).

Reverted changeset:

"[JSC] Remove easy toRemove & map.remove() use"
https://bugs.webkit.org/show_bug.cgi?id=180208
https://trac.webkit.org/changeset/225362

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp
trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp
trunk/Source/_javascript_Core/wasm/WasmSignature.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashMap.h
trunk/Source/WTF/wtf/HashSet.h
trunk/Source/WTF/wtf/HashTable.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225367 => 225368)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-01 00:11:39 UTC (rev 225367)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-01 00:14:34 UTC (rev 225368)
@@ -1,3 +1,17 @@
+2017-11-30  Commit Queue  
+
+Unreviewed, rolling out r225362.
+https://bugs.webkit.org/show_bug.cgi?id=180225
+
+removeIf predicate function can touch remove target set
+(Requested by yusukesuzuki on #webkit).
+
+Reverted changeset:
+
+"[JSC] Remove easy toRemove & map.remove() use"
+https://bugs.webkit.org/show_bug.cgi?id=180208
+https://trac.webkit.org/changeset/225362
+
 2017-11-30  Yusuke Suzuki  
 
 [JSC] Use AllocatorIfExists for MaterializeNewObject


Modified: trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp (225367 => 225368)

--- trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp	2017-12-01 00:11:39 UTC (rev 225367)
+++ trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp	2017-12-01 00:14:34 UTC (rev 225368)
@@ -342,8 +342,10 @@
 }
 
 Procedure& m_proc;
+Vector m_toRemove;
 HashMap m_constTable;
 int64_t* m_dataSection;
+HashMap m_constants;
 InsertionSet m_insertionSet;
 };
 


Modified: trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp (225367 => 225368)

--- trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp	2017-12-01 00:11:39 UTC (rev 225367)
+++ trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp	2017-12-01 00:14:34 UTC (rev 225368)
@@ -192,10 +192,20 @@
 {
 bool changed;
 do {
-changed = m_candidates.removeIf(
-[&] (Node* candidate) {
-return !isStillValidCandidate(candidate);
-});
+changed = false;
+Vector toRemove;
+
+for (Node* candidate : m_candidates) {
+if (!isStillValidCandidate(candidate))
+toRemove.append(candidate);
+}
+
+if (toRemove.size()) {
+changed = true;
+for (Node* node : toRemove)
+m_candidates.remove(node);
+}
+
 } while (changed);
 }
 


Modified: trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp (225367 => 225368)

--- trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp	2017-12-01 00:11:39 UTC (rev 225367)
+++ trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp	2017-12-01 00:14:34 UTC (rev 225368)
@@ -507,10 +507,14 @@
 
 void pruneByLiveness(const NodeSet& live)
 {
-m_pointers.removeIf(
-[&] (const auto& entry) {
-return !live.contains(entry.key);
-});
+Vector toRemove;
+for (const auto& entry : m_pointers) {
+if (!live.contains(entry.key))
+toRemove.append(entry.key);
+}
+for (Node* node : toRemove)
+m_pointers.remove(node);
+
 prune();
 }
 
@@ -678,10 +682,15 @@
 }
 
 // Remove unreachable allocations
-m_allocations.removeIf(
-[&] (const auto& entry) {
-return !reachable.contains(entry.key);
-});
+{
+Vector toRemove;
+for (const auto& entry : m_allocations) {
+if (!reachable.contains(entry.key))
+toRemove.append(entry.key);
+}
+for (Node* identifier : toRemove)
+m_allocations.remove(identifier);
+}
 }
 
 bool m_reached = false;
@@ -1240,10 +1249,14 @@
 {
 // We don't create materializations if the escapee is not a
 // sink candidate
-escapees.removeIf(
-[&] (const auto& entry) {
-return !m_sinkCandidates.contains(entry.key);
-});
+Vector 

[webkit-changes] [225370] trunk/Source/ThirdParty/ANGLE

[ryanhaddad]

Title: [225370] trunk/Source/ThirdParty/ANGLE








Revision 225370
Author ryanhad...@apple.com
Date 2017-11-30 16:33:00 -0800 (Thu, 30 Nov 2017)


Log Message
Unreviewed build fix, remove executable property from a header file.

* include/KHR/khrplatform.h: Removed property svn:executable.

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog


Property Changed

trunk/Source/ThirdParty/ANGLE/include/KHR/khrplatform.h




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (225369 => 225370)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-01 00:18:08 UTC (rev 225369)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-01 00:33:00 UTC (rev 225370)
@@ -1,3 +1,9 @@
+2017-11-30  Ryan Haddad  
+
+Unreviewed build fix, remove executable property from a header file.
+
+* include/KHR/khrplatform.h: Removed property svn:executable.
+
 2017-11-30  Dean Jackson  
 
 Update ANGLE
Index: trunk/Source/ThirdParty/ANGLE/include/KHR/khrplatform.h
===
--- trunk/Source/ThirdParty/ANGLE/include/KHR/khrplatform.h	2017-12-01 00:18:08 UTC (rev 225369)
+++ trunk/Source/ThirdParty/ANGLE/include/KHR/khrplatform.h	2017-12-01 00:33:00 UTC (rev 225370)


Property changes: trunk/Source/ThirdParty/ANGLE/include/KHR/khrplatform.h



Deleted: svn:executable
-*
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225371] trunk/Source/WebKit

[commit-queue]

Title: [225371] trunk/Source/WebKit








Revision 225371
Author commit-qu...@webkit.org
Date 2017-11-30 16:40:12 -0800 (Thu, 30 Nov 2017)


Log Message
[Cocoa] Web Automation: _WKAutomationSessionConfiguration leak
https://bugs.webkit.org/show_bug.cgi?id=180222

Patch by Joseph Pecoraro  on 2017-11-30
Reviewed by Brian Burg.

* UIProcess/Cocoa/AutomationClient.mm:
(WebKit::AutomationClient::requestAutomationSessionWithCapabilities):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/AutomationClient.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (225370 => 225371)

--- trunk/Source/WebKit/ChangeLog	2017-12-01 00:33:00 UTC (rev 225370)
+++ trunk/Source/WebKit/ChangeLog	2017-12-01 00:40:12 UTC (rev 225371)
@@ -1,5 +1,15 @@
 2017-11-30  Joseph Pecoraro  
 
+[Cocoa] Web Automation: _WKAutomationSessionConfiguration leak
+https://bugs.webkit.org/show_bug.cgi?id=180222
+
+Reviewed by Brian Burg.
+
+* UIProcess/Cocoa/AutomationClient.mm:
+(WebKit::AutomationClient::requestAutomationSessionWithCapabilities):
+
+2017-11-30  Joseph Pecoraro  
+
 Fix some NSOperationQueue leaks
 https://bugs.webkit.org/show_bug.cgi?id=180221
 


Modified: trunk/Source/WebKit/UIProcess/Cocoa/AutomationClient.mm (225370 => 225371)

--- trunk/Source/WebKit/UIProcess/Cocoa/AutomationClient.mm	2017-12-01 00:33:00 UTC (rev 225370)
+++ trunk/Source/WebKit/UIProcess/Cocoa/AutomationClient.mm	2017-12-01 00:40:12 UTC (rev 225371)
@@ -77,7 +77,7 @@
 
 void AutomationClient::requestAutomationSessionWithCapabilities(NSString *sessionIdentifier, NSDictionary *forwardedCapabilities)
 {
-_WKAutomationSessionConfiguration *configuration = [_WKAutomationSessionConfiguration new];
+_WKAutomationSessionConfiguration *configuration = [[[_WKAutomationSessionConfiguration alloc] init] autorelease];
 if (NSNumber *value = forwardedCapabilities[WIRAllowInsecureMediaCaptureCapabilityKey]) {
 if ([value isKindOfClass:[NSNumber class]])
 configuration.allowsInsecureMediaCapture = value.boolValue;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225372] trunk/Source/WebKit

[dbates]

Title: [225372] trunk/Source/WebKit








Revision 225372
Author dba...@webkit.org
Date 2017-11-30 16:51:14 -0800 (Thu, 30 Nov 2017)


Log Message
Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS
https://bugs.webkit.org/show_bug.cgi?id=180218


Reviewed by Alex Christensen.

We want to support the SPI didClickAlternativePresentationButtonWithUserInfo on Cocoa platforms.

* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didClickAlternativePresentationButton):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (225371 => 225372)

--- trunk/Source/WebKit/ChangeLog	2017-12-01 00:40:12 UTC (rev 225371)
+++ trunk/Source/WebKit/ChangeLog	2017-12-01 00:51:14 UTC (rev 225372)
@@ -1,3 +1,19 @@
+2017-11-30  Daniel Bates  
+
+Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS
+https://bugs.webkit.org/show_bug.cgi?id=180218
+
+
+Reviewed by Alex Christensen.
+
+We want to support the SPI didClickAlternativePresentationButtonWithUserInfo on Cocoa platforms.
+
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+* UIProcess/Cocoa/UIDelegate.h:
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::setDelegate):
+(WebKit::UIDelegate::UIClient::didClickAlternativePresentationButton):
+
 2017-11-30  Joseph Pecoraro  
 
 [Cocoa] Web Automation: _WKAutomationSessionConfiguration leak


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (225371 => 225372)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2017-12-01 00:40:12 UTC (rev 225371)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2017-12-01 00:51:14 UTC (rev 225372)
@@ -113,6 +113,8 @@
 - (void)_webView:(WKWebView *)webView didRemoveAttachment:(_WKAttachment *)attachment WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
 - (void)_webView:(WKWebView *)webView didInsertAttachment:(_WKAttachment *)attachment WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
 
+- (void)_webView:(WKWebView *)webView didClickAlternativePresentationButtonWithUserInfo:(id )userInfo WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
+
 #if TARGET_OS_IPHONE
 - (BOOL)_webView:(WKWebView *)webView shouldIncludeAppLinkActionsForElement:(_WKActivatedElementInfo *)element WK_API_AVAILABLE(ios(9.0));
 - (NSArray *)_webView:(WKWebView *)webView actionsForElement:(_WKActivatedElementInfo *)element defaultActions:(NSArray<_WKElementAction *> *)defaultActions;
@@ -165,7 +167,6 @@
 - (void)_webView:(WKWebView *)webView didNotHandleWheelEvent:(NSEvent *)event WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView handleAutoplayEvent:(_WKAutoplayEvent)event withFlags:(_WKAutoplayEventFlags)flags WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView didClickAutoFillButtonWithUserInfo:(id )userInfo WK_API_AVAILABLE(macosx(WK_MAC_TBA));
-- (void)_webView:(WKWebView *)webView didClickAlternativePresentationButtonWithUserInfo:(id )userInfo WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView getToolbarsAreVisibleWithCompletionHandler:(void(^)(BOOL))completionHandler WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView saveDataToFile:(NSData *)data suggestedFilename:(NSString *)suggestedFilename mimeType:(NSString *)mimeType originatingURL:(NSURL *)url WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (CGFloat)_webViewHeaderHeight:(WKWebView *)webView WK_API_AVAILABLE(macosx(WK_MAC_TBA));


Modified: trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h (225371 => 225372)

--- trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h	2017-12-01 00:40:12 UTC (rev 225371)
+++ trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h	2017-12-01 00:51:14 UTC (rev 225372)
@@ -93,6 +93,7 @@
 void runBeforeUnloadConfirmPanel(WebPageProxy*, const WTF::String&, WebFrameProxy*, const WebCore::SecurityOriginData&, Function&& completionHandler) final;
 void exceededDatabaseQuota(WebPageProxy*, WebFrameProxy*, API::SecurityOrigin*, const WTF::String& databaseName, const WTF::String& displayName, unsigned long long currentQuota, unsigned long long currentOriginUsage, unsigned long long currentUsage, unsigned long long expectedUsage, Function&& completionHandler) final;
 void reachedApplicationCacheOriginQuota(WebPageProxy*, const WebCore::SecurityOrigin&, uint64_t currentQuota, uint64_t totalBytesNeeded, Function&& completionHandler) final;
+void didClickAlternativePresentationButton(WebPageProxy&, API::Object*) final;
 

[webkit-changes] [225374] trunk/Source/WebCore

[commit-queue]

Title: [225374] trunk/Source/WebCore








Revision 225374
Author commit-qu...@webkit.org
Date 2017-11-30 16:57:13 -0800 (Thu, 30 Nov 2017)


Log Message
[Cocoa] Fix CVPixelBuffer leak
https://bugs.webkit.org/show_bug.cgi?id=180224

Patch by Joseph Pecoraro  on 2017-11-30
Reviewed by Youenn Fablet.

* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp:
(WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferFromVideoFrame):
Adopt the newly created pixel buffer.

(WebCore::RealtimeIncomingVideoSourceCocoa::OnFrame):
Release the format description as soon as we are done with it. Otherwise
we could have bailed before releasing it.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (225373 => 225374)

--- trunk/Source/WebCore/ChangeLog	2017-12-01 00:54:41 UTC (rev 225373)
+++ trunk/Source/WebCore/ChangeLog	2017-12-01 00:57:13 UTC (rev 225374)
@@ -1,3 +1,18 @@
+2017-11-30  Joseph Pecoraro  
+
+[Cocoa] Fix CVPixelBuffer leak
+https://bugs.webkit.org/show_bug.cgi?id=180224
+
+Reviewed by Youenn Fablet.
+
+* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp:
+(WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferFromVideoFrame):
+Adopt the newly created pixel buffer.
+
+(WebCore::RealtimeIncomingVideoSourceCocoa::OnFrame):
+Release the format description as soon as we are done with it. Otherwise
+we could have bailed before releasing it.
+
 2017-11-30  Simon Fraser  
 
 Improve filter logging


Modified: trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp (225373 => 225374)

--- trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp	2017-12-01 00:54:41 UTC (rev 225373)
+++ trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.cpp	2017-12-01 00:57:13 UTC (rev 225374)
@@ -65,7 +65,7 @@
 auto status = CVPixelBufferCreate(kCFAllocatorDefault, frame.width(), frame.height(), kCVPixelFormatType_420YpCbCr8Planar, nullptr, );
 ASSERT_UNUSED(status, status == noErr);
 
-m_blackFrame = pixelBuffer;
+m_blackFrame = adoptCF(pixelBuffer);
 m_blackFrameWidth = frame.width();
 m_blackFrameHeight = frame.height();
 
@@ -114,11 +114,11 @@
 
 CMSampleBufferRef sampleBuffer;
 ostatus = CMSampleBufferCreateReadyWithImageBuffer(kCFAllocatorDefault, (CVImageBufferRef)pixelBuffer, formatDescription, , );
+CFRelease(formatDescription);
 if (ostatus != noErr) {
 LOG_ERROR("Failed to create the sample buffer: %d", static_cast(ostatus));
 return;
 }
-CFRelease(formatDescription);
 
 auto sample = adoptCF(sampleBuffer);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225375] trunk/Source

[utatane . tea]

Title: [225375] trunk/Source








Revision 225375
Author utatane@gmail.com
Date 2017-11-30 17:02:47 -0800 (Thu, 30 Nov 2017)


Log Message
[JSC] Remove easy toRemove & map.remove() use in OAS phase
https://bugs.webkit.org/show_bug.cgi?id=180208

Reviewed by Mark Lam.

Source/_javascript_Core:

In this patch, we replace Vector<> toRemove & map.remove loop with removeIf,
to optimize this common pattern. This patch only modifies apparent ones.
But we can apply this refactoring further to OAS phase in the future.

One thing we should care is that predicate of removeIf should not touch the
removing set itself. In this patch, we apply this change to (1) apparently
correct one and (2) things in DFG OAS phase since it is very slow.

* b3/B3MoveConstants.cpp:
* dfg/DFGObjectAllocationSinkingPhase.cpp:

Source/WTF:

* wtf/HashMap.h:
(WTF::X>::removeIf):
* wtf/HashSet.h:
(WTF::V>::removeIf):
* wtf/HashTable.h:
(WTF::KeyTraits>::removeIf):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp
trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashMap.h
trunk/Source/WTF/wtf/HashSet.h
trunk/Source/WTF/wtf/HashTable.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225374 => 225375)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-01 00:57:13 UTC (rev 225374)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-01 01:02:47 UTC (rev 225375)
@@ -1,3 +1,21 @@
+2017-11-30  Yusuke Suzuki  
+
+[JSC] Remove easy toRemove & map.remove() use in OAS phase
+https://bugs.webkit.org/show_bug.cgi?id=180208
+
+Reviewed by Mark Lam.
+
+In this patch, we replace Vector<> toRemove & map.remove loop with removeIf,
+to optimize this common pattern. This patch only modifies apparent ones.
+But we can apply this refactoring further to OAS phase in the future.
+
+One thing we should care is that predicate of removeIf should not touch the
+removing set itself. In this patch, we apply this change to (1) apparently
+correct one and (2) things in DFG OAS phase since it is very slow.
+
+* b3/B3MoveConstants.cpp:
+* dfg/DFGObjectAllocationSinkingPhase.cpp:
+
 2017-11-30  Commit Queue  
 
 Unreviewed, rolling out r225362.


Modified: trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp (225374 => 225375)

--- trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp	2017-12-01 00:57:13 UTC (rev 225374)
+++ trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp	2017-12-01 01:02:47 UTC (rev 225375)
@@ -342,10 +342,8 @@
 }
 
 Procedure& m_proc;
-Vector m_toRemove;
 HashMap m_constTable;
 int64_t* m_dataSection;
-HashMap m_constants;
 InsertionSet m_insertionSet;
 };
 


Modified: trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp (225374 => 225375)

--- trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp	2017-12-01 00:57:13 UTC (rev 225374)
+++ trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp	2017-12-01 01:02:47 UTC (rev 225375)
@@ -507,14 +507,10 @@
 
 void pruneByLiveness(const NodeSet& live)
 {
-Vector toRemove;
-for (const auto& entry : m_pointers) {
-if (!live.contains(entry.key))
-toRemove.append(entry.key);
-}
-for (Node* node : toRemove)
-m_pointers.remove(node);
-
+m_pointers.removeIf(
+[&] (const auto& entry) {
+return !live.contains(entry.key);
+});
 prune();
 }
 
@@ -682,15 +678,10 @@
 }
 
 // Remove unreachable allocations
-{
-Vector toRemove;
-for (const auto& entry : m_allocations) {
-if (!reachable.contains(entry.key))
-toRemove.append(entry.key);
-}
-for (Node* identifier : toRemove)
-m_allocations.remove(identifier);
-}
+m_allocations.removeIf(
+[&] (const auto& entry) {
+return !reachable.contains(entry.key);
+});
 }
 
 bool m_reached = false;
@@ -1249,14 +1240,10 @@
 {
 // We don't create materializations if the escapee is not a
 // sink candidate
-Vector toRemove;
-for (const auto& entry : escapees) {
-if (!m_sinkCandidates.contains(entry.key))
-toRemove.append(entry.key);
-}
-for (Node* identifier : toRemove)
-escapees.remove(identifier);
-
+escapees.removeIf(
+[&] (const auto& entry) {
+return !m_sinkCandidates.contains(entry.key);
+});
 if (escapees.isEmpty())
 return;
 


Modified: trunk/Source/WTF/ChangeLog (225374 => 

[webkit-changes] [225367] trunk/Source/WebKit

[bburg]

Title: [225367] trunk/Source/WebKit








Revision 225367
Author bb...@apple.com
Date 2017-11-30 16:11:39 -0800 (Thu, 30 Nov 2017)


Log Message
Web Automation: computeElementLayout does not correctly translate iframe client coordinates to main frame coordinates
https://bugs.webkit.org/show_bug.cgi?id=180213


Reviewed by Simon Fraser.

The current implementation computes points in terms of the frame in which the element is located.
However, WebDriver expects coordinates to be relative to the top-level document since
these coordinates are used for generating click events, among other things.

To convert from frame client coordinates to main frame client coordinates, round-trip
both inViewCenterPoint and elementBounds to root view coordinates and back
to the main frame's contents/client coordinates. Then convert this to page coordinates if needed.

This progresses several tests in the Selenium Python test suite:

 - event_firing_webdriver_tests.py::test_should_fire_navigation_events
 - frame_switching_tests.py::testShouldBeAbleToClickInAFrameThatRewritesTopWindowLocation
 - frame_switching_tests.py::testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUs
 - frame_switching_tests.py::testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithFrameIndex
 - frame_switching_tests.py::testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithWebelement
 - frame_switching_tests.py::testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs
 - position_and_size_tests.py::testShouldGetCoordinatesOfAnInvisibleElement

* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::computeElementLayout):
Get both the frame and main frame FrameViews and convert coordinates to the root view.
This is somewhat lossy as clientToDocument* deals with FloatPoints but contentsToRootView
deals with IntPoints. For the purposes of WebDriver, lossiness is not a problem since
integer values are expected anyway.

The imperative nature of the coordinate calculations is difficult to debug, so I converted
this function to only assign to each variable once.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (225366 => 225367)

--- trunk/Source/WebKit/ChangeLog	2017-12-01 00:05:11 UTC (rev 225366)
+++ trunk/Source/WebKit/ChangeLog	2017-12-01 00:11:39 UTC (rev 225367)
@@ -1,3 +1,39 @@
+2017-11-30  Brian Burg  
+
+Web Automation: computeElementLayout does not correctly translate iframe client coordinates to main frame coordinates
+https://bugs.webkit.org/show_bug.cgi?id=180213
+
+
+Reviewed by Simon Fraser.
+
+The current implementation computes points in terms of the frame in which the element is located.
+However, WebDriver expects coordinates to be relative to the top-level document since
+these coordinates are used for generating click events, among other things.
+
+To convert from frame client coordinates to main frame client coordinates, round-trip
+both inViewCenterPoint and elementBounds to root view coordinates and back
+to the main frame's contents/client coordinates. Then convert this to page coordinates if needed.
+
+This progresses several tests in the Selenium Python test suite:
+
+ - event_firing_webdriver_tests.py::test_should_fire_navigation_events
+ - frame_switching_tests.py::testShouldBeAbleToClickInAFrameThatRewritesTopWindowLocation
+ - frame_switching_tests.py::testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUs
+ - frame_switching_tests.py::testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithFrameIndex
+ - frame_switching_tests.py::testShouldBeAbleToSwitchToTheTopIfTheFrameIsDeletedFromUnderUsWithWebelement
+ - frame_switching_tests.py::testShouldNotBeAbleToDoAnythingTheFrameIsDeletedFromUnderUs
+ - position_and_size_tests.py::testShouldGetCoordinatesOfAnInvisibleElement
+
+* WebProcess/Automation/WebAutomationSessionProxy.cpp:
+(WebKit::WebAutomationSessionProxy::computeElementLayout):
+Get both the frame and main frame FrameViews and convert coordinates to the root view.
+This is somewhat lossy as clientToDocument* deals with FloatPoints but contentsToRootView
+deals with IntPoints. For the purposes of WebDriver, lossiness is not a problem since
+integer values are expected anyway.
+
+The imperative nature of the coordinate calculations is difficult to debug, so I converted
+this function to only assign to each variable once.
+
 2017-11-30  Alex Christensen  
 
 WKURLSchemeHandler.request should include HTTPBody


Modified: trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp (225366 => 225367)

--- 

[webkit-changes] [225369] trunk/Source

[commit-queue]

Title: [225369] trunk/Source








Revision 225369
Author commit-qu...@webkit.org
Date 2017-11-30 16:18:08 -0800 (Thu, 30 Nov 2017)


Log Message
Fix some NSOperationQueue leaks
https://bugs.webkit.org/show_bug.cgi?id=180221

Patch by Joseph Pecoraro  on 2017-11-30
Reviewed by Wenson Hsieh.

Source/WebKit:

* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::performDragOperation):

Source/WebKitLegacy/mac:

* WebView/WebView.mm:
(-[WebView performDragOperation:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (225368 => 225369)

--- trunk/Source/WebKit/ChangeLog	2017-12-01 00:14:34 UTC (rev 225368)
+++ trunk/Source/WebKit/ChangeLog	2017-12-01 00:18:08 UTC (rev 225369)
@@ -1,3 +1,13 @@
+2017-11-30  Joseph Pecoraro  
+
+Fix some NSOperationQueue leaks
+https://bugs.webkit.org/show_bug.cgi?id=180221
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/Cocoa/WebViewImpl.mm:
+(WebKit::WebViewImpl::performDragOperation):
+
 2017-11-30  Brian Burg  
 
 Web Automation: computeElementLayout does not correctly translate iframe client coordinates to main frame coordinates


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (225368 => 225369)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	2017-12-01 00:14:34 UTC (rev 225368)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm	2017-12-01 00:18:08 UTC (rev 225369)
@@ -3723,7 +3723,8 @@
 NSFilePromiseReceiver *item = draggingItem.item;
 NSDictionary *options = @{ };
 
-[item receivePromisedFilesAtDestination:dropLocation options:options operationQueue:[NSOperationQueue new] reader:^(NSURL * _Nonnull fileURL, NSError * _Nullable errorOrNil) {
+RetainPtr queue = adoptNS([NSOperationQueue new]);
+[item receivePromisedFilesAtDestination:dropLocation options:options operationQueue:queue.get() reader:^(NSURL * _Nonnull fileURL, NSError * _Nullable errorOrNil) {
 if (errorOrNil)
 return;
 


Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (225368 => 225369)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2017-12-01 00:14:34 UTC (rev 225368)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2017-12-01 00:18:08 UTC (rev 225369)
@@ -1,3 +1,13 @@
+2017-11-30  Joseph Pecoraro  
+
+Fix some NSOperationQueue leaks
+https://bugs.webkit.org/show_bug.cgi?id=180221
+
+Reviewed by Wenson Hsieh.
+
+* WebView/WebView.mm:
+(-[WebView performDragOperation:]):
+
 2017-11-30  Darin Adler  
 
 [Mac] remove unneeded RetainPtr use introduced in r225142


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (225368 => 225369)

--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2017-12-01 00:14:34 UTC (rev 225368)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm	2017-12-01 00:18:08 UTC (rev 225369)
@@ -6729,7 +6729,8 @@
 NSFilePromiseReceiver *item = draggingItem.item;
 NSDictionary *options = @{ };
 
-[item receivePromisedFilesAtDestination:dropLocation options:options operationQueue:[NSOperationQueue new] reader:^(NSURL * _Nonnull fileURL, NSError * _Nullable errorOrNil) {
+RetainPtr queue = adoptNS([NSOperationQueue new]);
+[item receivePromisedFilesAtDestination:dropLocation options:options operationQueue:queue.get() reader:^(NSURL * _Nonnull fileURL, NSError * _Nullable errorOrNil) {
 if (errorOrNil)
 return;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225373] trunk/Source/WebKit

[ryanhaddad]

Title: [225373] trunk/Source/WebKit








Revision 225373
Author ryanhad...@apple.com
Date 2017-11-30 16:54:41 -0800 (Thu, 30 Nov 2017)


Log Message
Unreviewed build fix, suppress deprecation warnings.

* Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtensionImpl::sandboxExtensionForType):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/SandboxExtensionMac.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (225372 => 225373)

--- trunk/Source/WebKit/ChangeLog	2017-12-01 00:51:14 UTC (rev 225372)
+++ trunk/Source/WebKit/ChangeLog	2017-12-01 00:54:41 UTC (rev 225373)
@@ -1,3 +1,10 @@
+2017-11-30  Ryan Haddad  
+
+Unreviewed build fix, suppress deprecation warnings.
+
+* Shared/mac/SandboxExtensionMac.mm:
+(WebKit::SandboxExtensionImpl::sandboxExtensionForType):
+
 2017-11-30  Daniel Bates  
 
 Expose SPI didClickAlternativePresentationButtonWithUserInfo on iOS


Modified: trunk/Source/WebKit/Shared/mac/SandboxExtensionMac.mm (225372 => 225373)

--- trunk/Source/WebKit/Shared/mac/SandboxExtensionMac.mm	2017-12-01 00:51:14 UTC (rev 225372)
+++ trunk/Source/WebKit/Shared/mac/SandboxExtensionMac.mm	2017-12-01 00:54:41 UTC (rev 225373)
@@ -86,9 +86,12 @@
 {
 switch (type) {
 case SandboxExtension::Type::ReadOnly:
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 return sandbox_extension_issue_file(APP_SANDBOX_READ, path, 0);
 case SandboxExtension::Type::ReadWrite:
 return sandbox_extension_issue_file(APP_SANDBOX_READ_WRITE, path, 0);
+#pragma clang diagnostic pop
 case SandboxExtension::Type::Generic:
 return sandbox_extension_issue_generic(path, 0);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225361] trunk/Tools

[commit-queue]

Title: [225361] trunk/Tools








Revision 225361
Author commit-qu...@webkit.org
Date 2017-11-30 15:39:14 -0800 (Thu, 30 Nov 2017)


Log Message
[WinCairo] Cannot build without Internet connection
https://bugs.webkit.org/show_bug.cgi?id=180068

Patch by Basuke Suzuki  on 2017-11-30
Reviewed by Alex Christensen

With no Internet connection, if libraries has been downloaded
before, trust that version and keep building.

* Scripts/download-latest-github-release.py:
(Status):
(current_release):
(has_latest_release):
(main):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/download-latest-github-release.py




Diff

Modified: trunk/Tools/ChangeLog (225360 => 225361)

--- trunk/Tools/ChangeLog	2017-11-30 23:22:18 UTC (rev 225360)
+++ trunk/Tools/ChangeLog	2017-11-30 23:39:14 UTC (rev 225361)
@@ -1,3 +1,19 @@
+2017-11-30  Basuke Suzuki  
+
+[WinCairo] Cannot build without Internet connection
+https://bugs.webkit.org/show_bug.cgi?id=180068
+
+Reviewed by Alex Christensen
+
+With no Internet connection, if libraries has been downloaded
+before, trust that version and keep building.
+
+* Scripts/download-latest-github-release.py:
+(Status):
+(current_release):
+(has_latest_release):
+(main):
+
 2017-11-30  Alex Christensen  
 
 WKURLSchemeHandler.request should include HTTPBody


Modified: trunk/Tools/Scripts/download-latest-github-release.py (225360 => 225361)

--- trunk/Tools/Scripts/download-latest-github-release.py	2017-11-30 23:22:18 UTC (rev 225360)
+++ trunk/Tools/Scripts/download-latest-github-release.py	2017-11-30 23:39:14 UTC (rev 225361)
@@ -46,6 +46,7 @@
 DOWNLOADED = 0
 UP_TO_DATE = 1
 COULD_NOT_FIND = 2
+USE_EXISTING_VERSION = 3
 
 
 def parse_args(argv):
@@ -81,14 +82,18 @@
 return None, None
 
 
-def has_latest_release(version_info_path, version_info):
+def existing_version_info(version_info_path):
 if not os.path.exists(version_info_path):
-return False
+return None
 
 with open(version_info_path) as file:
-return json.load(file) == version_info
+return json.load(file)
 
 
+def has_latest_release(version_info_path, version_info):
+return existing_version_info(version_info_path) == version_info
+
+
 def download_release(source_url, target_path):
 with open(target_path, 'wb') as file:
 file.write(urllib2.urlopen(source_url).read())
@@ -102,24 +107,36 @@
 def main(argv):
 args = parse_args(argv)
 
+binary_path = os.path.join(args.output_dir, args.filename)
+version_info_path = binary_path + '.version'
+
 print 'Seeking latest release of {} from {}...'.format(args.filename, args.repo)
-release_url, version_info = find_latest_release(args)
 
-if not release_url:
-print 'No release found!'
-return Status.COULD_NOT_FIND
+try:
+release_url, version_info = find_latest_release(args)
 
-binary_path = os.path.join(args.output_dir, args.filename)
-version_info_path = binary_path + '.version'
+if not release_url:
+print 'No release found!'
+return Status.COULD_NOT_FIND
 
-if has_latest_release(version_info_path, version_info):
-print 'Already up-to-date!'
-return Status.UP_TO_DATE
+if has_latest_release(version_info_path, version_info):
+print 'Already up-to-date:', existing_version_info(version_info_path)
+return Status.UP_TO_DATE
 
+except urllib2.URLError, error:
+print error
+
+version_info = existing_version_info(version_info_path)
+if version_info:
+print 'Use existing version:', version_info
+return Status.USE_EXISTING_VERSION
+else:
+return Status.COULD_NOT_FIND
+
 if not os.path.exists(args.output_dir):
 os.makedirs(args.output_dir)
 
-print 'Downloading to {}...'.format(os.path.abspath(args.output_dir))
+print 'Downloading {} to {}...'.format(version_info['tag_name'], os.path.abspath(args.output_dir))
 download_release(release_url, binary_path)
 save_version_info(version_info_path, version_info)
 print 'Done!'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225351] trunk/Source/WebCore

[cdumez]

Title: [225351] trunk/Source/WebCore








Revision 225351
Author cdu...@apple.com
Date 2017-11-30 14:35:25 -0800 (Thu, 30 Nov 2017)


Log Message
ServiceWorkerThread's m_extendedEvents gets destroyed on the wrong thread
https://bugs.webkit.org/show_bug.cgi?id=180216

Reviewed by Brady Eidson.

ServiceWorkerThread's m_extendedEvents gets destroyed on the wrong thread. Those events live on the worker
thread so we should destroy them on the worker thread, not the main thread. To address the issue, m_extendedEvents
was moved to ServiceWorkerGlobalScope, which actually lives on the right thread.

* workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::updateExtendedEventsSet):
* workers/service/ServiceWorkerGlobalScope.h:
* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::postFetchTask):
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
(WebCore::ServiceWorkerThread::updateExtendedEventsSet): Deleted.
* workers/service/context/ServiceWorkerThread.h:
(WebCore::ServiceWorkerThread::hasPendingEvents const): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMGuardedObject.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225350 => 225351)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 22:25:52 UTC (rev 225350)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 22:35:25 UTC (rev 225351)
@@ -1,5 +1,26 @@
 2017-11-30  Chris Dumez  
 
+ServiceWorkerThread's m_extendedEvents gets destroyed on the wrong thread
+https://bugs.webkit.org/show_bug.cgi?id=180216
+
+Reviewed by Brady Eidson.
+
+ServiceWorkerThread's m_extendedEvents gets destroyed on the wrong thread. Those events live on the worker
+thread so we should destroy them on the worker thread, not the main thread. To address the issue, m_extendedEvents
+was moved to ServiceWorkerGlobalScope, which actually lives on the right thread.
+
+* workers/service/ServiceWorkerGlobalScope.cpp:
+(WebCore::ServiceWorkerGlobalScope::updateExtendedEventsSet):
+* workers/service/ServiceWorkerGlobalScope.h:
+* workers/service/context/ServiceWorkerThread.cpp:
+(WebCore::ServiceWorkerThread::postFetchTask):
+(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
+(WebCore::ServiceWorkerThread::updateExtendedEventsSet): Deleted.
+* workers/service/context/ServiceWorkerThread.h:
+(WebCore::ServiceWorkerThread::hasPendingEvents const): Deleted.
+
+2017-11-30  Chris Dumez  
+
 SWServerToContextConnection / SWServerWorker do not need to be ThreadSafeRefCounted
 https://bugs.webkit.org/show_bug.cgi?id=180214
 


Modified: trunk/Source/WebCore/bindings/js/JSDOMGuardedObject.cpp (225350 => 225351)

--- trunk/Source/WebCore/bindings/js/JSDOMGuardedObject.cpp	2017-11-30 22:25:52 UTC (rev 225350)
+++ trunk/Source/WebCore/bindings/js/JSDOMGuardedObject.cpp	2017-11-30 22:35:25 UTC (rev 225351)
@@ -53,6 +53,7 @@
 m_globalObject->guardedObjects(locker).remove(this);
 }
 m_guarded.clear();
+m_globalObject.clear();
 }
 
 void DOMGuardedObject::contextDestroyed()


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp (225350 => 225351)

--- trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp	2017-11-30 22:25:52 UTC (rev 225350)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp	2017-11-30 22:35:25 UTC (rev 225351)
@@ -28,6 +28,8 @@
 
 #if ENABLE(SERVICE_WORKER)
 
+#include "ExtendableEvent.h"
+#include "SWContextManager.h"
 #include "ServiceWorkerClient.h"
 #include "ServiceWorkerClients.h"
 #include "ServiceWorkerThread.h"
@@ -79,6 +81,36 @@
 ASSERT_UNUSED(isRemoved, isRemoved);
 }
 
+// https://w3c.github.io/ServiceWorker/#update-service-worker-extended-events-set-algorithm
+void ServiceWorkerGlobalScope::updateExtendedEventsSet(ExtendableEvent* newEvent)
+{
+ASSERT(!isMainThread());
+ASSERT(!newEvent || !newEvent->isBeingDispatched());
+bool hadPendingEvents = hasPendingEvents();
+m_extendedEvents.removeAllMatching([](auto& event) {
+return !event->pendingPromiseCount();
+});
+
+if (newEvent && newEvent->pendingPromiseCount()) {
+m_extendedEvents.append(*newEvent);
+newEvent->whenAllExtendLifetimePromisesAreSettled([this](auto&&) {
+updateExtendedEventsSet();
+});
+// Clear out the event's target as it is the WorkerGlobalScope and we do not want to keep it
+// alive unnecessarily.
+newEvent->setTarget(nullptr);
+}
+
+bool hasPendingEvents = 

[webkit-changes] [225352] trunk

[mark . lam]

Title: [225352] trunk








Revision 225352
Author mark@apple.com
Date 2017-11-30 14:51:59 -0800 (Thu, 30 Nov 2017)


Log Message
jsc shell's flashHeapAccess() should not do JS work after releasing access to the heap.
https://bugs.webkit.org/show_bug.cgi?id=180219


Reviewed by Filip Pizlo.

JSTests:

* stress/regress-180219.js: Added.

Source/_javascript_Core:

* jsc.cpp:
(functionFlashHeapAccess):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp


Added Paths

trunk/JSTests/stress/regress-180219.js




Diff

Modified: trunk/JSTests/ChangeLog (225351 => 225352)

--- trunk/JSTests/ChangeLog	2017-11-30 22:35:25 UTC (rev 225351)
+++ trunk/JSTests/ChangeLog	2017-11-30 22:51:59 UTC (rev 225352)
@@ -1,3 +1,13 @@
+2017-11-30  Mark Lam  
+
+jsc shell's flashHeapAccess() should not do JS work after releasing access to the heap.
+https://bugs.webkit.org/show_bug.cgi?id=180219
+
+
+Reviewed by Filip Pizlo.
+
+* stress/regress-180219.js: Added.
+
 2017-11-30  Yusuke Suzuki  
 
 [DFG][FTL] operationHasIndexedProperty does not consider negative int32_t


Added: trunk/JSTests/stress/regress-180219.js (0 => 225352)

--- trunk/JSTests/stress/regress-180219.js	(rev 0)
+++ trunk/JSTests/stress/regress-180219.js	2017-11-30 22:51:59 UTC (rev 225352)
@@ -0,0 +1,3 @@
+//@ runDefault
+gc();
+flashHeapAccess({});


Modified: trunk/Source/_javascript_Core/ChangeLog (225351 => 225352)

--- trunk/Source/_javascript_Core/ChangeLog	2017-11-30 22:35:25 UTC (rev 225351)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-11-30 22:51:59 UTC (rev 225352)
@@ -1,3 +1,14 @@
+2017-11-30  Mark Lam  
+
+jsc shell's flashHeapAccess() should not do JS work after releasing access to the heap.
+https://bugs.webkit.org/show_bug.cgi?id=180219
+
+
+Reviewed by Filip Pizlo.
+
+* jsc.cpp:
+(functionFlashHeapAccess):
+
 2017-11-30  Yusuke Suzuki  
 
 [DFG][FTL] operationHasIndexedProperty does not consider negative int32_t


Modified: trunk/Source/_javascript_Core/jsc.cpp (225351 => 225352)

--- trunk/Source/_javascript_Core/jsc.cpp	2017-11-30 22:35:25 UTC (rev 225351)
+++ trunk/Source/_javascript_Core/jsc.cpp	2017-11-30 22:51:59 UTC (rev 225352)
@@ -1720,12 +1720,15 @@
 VM& vm = exec->vm();
 auto scope = DECLARE_THROW_SCOPE(vm);
 
-vm.heap.releaseAccess();
+double sleepTimeMs = 0;
 if (exec->argumentCount() >= 1) {
-double ms = exec->argument(0).toNumber(exec);
+sleepTimeMs = exec->argument(0).toNumber(exec);
 RETURN_IF_EXCEPTION(scope, encodedJSValue());
-sleep(Seconds::fromMilliseconds(ms));
 }
+
+vm.heap.releaseAccess();
+if (sleepTimeMs)
+sleep(Seconds::fromMilliseconds(sleepTimeMs));
 vm.heap.acquireAccess();
 return JSValue::encode(jsUndefined());
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225355] trunk/Source/WebCore

[cdumez]

Title: [225355] trunk/Source/WebCore








Revision 225355
Author cdu...@apple.com
Date 2017-11-30 15:06:34 -0800 (Thu, 30 Nov 2017)


Log Message
Move SWClientConnection class out of server/ folder
https://bugs.webkit.org/show_bug.cgi?id=180217

Reviewed by Brady Eidson.

Move SWClientConnection class out of server/ folder since the client connection
lives in the WebProcess, not the Storage process.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* workers/service/SWClientConnection.cpp: Renamed from Source/WebCore/workers/service/server/SWClientConnection.cpp.
(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):
(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
(WebCore::SWClientConnection::forEachContainer):
(WebCore::SWClientConnection::updateRegistrationState):
(WebCore::SWClientConnection::updateWorkerState):
(WebCore::SWClientConnection::fireUpdateFoundEvent):
(WebCore::SWClientConnection::notifyClientsOfControllerChange):
* workers/service/SWClientConnection.h: Renamed from Source/WebCore/workers/service/server/SWClientConnection.h.
* workers/service/ServiceWorkerContainer.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp
trunk/Source/WebCore/workers/service/server/SWOriginStore.cpp
trunk/Source/WebCore/workers/service/server/SWOriginStore.h


Added Paths

trunk/Source/WebCore/workers/service/SWClientConnection.cpp
trunk/Source/WebCore/workers/service/SWClientConnection.h


Removed Paths

trunk/Source/WebCore/workers/service/server/SWClientConnection.cpp
trunk/Source/WebCore/workers/service/server/SWClientConnection.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225354 => 225355)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 23:04:36 UTC (rev 225354)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 23:06:34 UTC (rev 225355)
@@ -1,5 +1,34 @@
 2017-11-30  Chris Dumez  
 
+Move SWClientConnection class out of server/ folder
+https://bugs.webkit.org/show_bug.cgi?id=180217
+
+Reviewed by Brady Eidson.
+
+Move SWClientConnection class out of server/ folder since the client connection
+lives in the WebProcess, not the Storage process.
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* workers/service/SWClientConnection.cpp: Renamed from Source/WebCore/workers/service/server/SWClientConnection.cpp.
+(WebCore::SWClientConnection::scheduleJob):
+(WebCore::SWClientConnection::finishedFetchingScript):
+(WebCore::SWClientConnection::failedFetchingScript):
+(WebCore::SWClientConnection::jobRejectedInServer):
+(WebCore::SWClientConnection::registrationJobResolvedInServer):
+(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
+(WebCore::SWClientConnection::startScriptFetchForServer):
+(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
+(WebCore::SWClientConnection::forEachContainer):
+(WebCore::SWClientConnection::updateRegistrationState):
+(WebCore::SWClientConnection::updateWorkerState):
+(WebCore::SWClientConnection::fireUpdateFoundEvent):
+(WebCore::SWClientConnection::notifyClientsOfControllerChange):
+* workers/service/SWClientConnection.h: Renamed from Source/WebCore/workers/service/server/SWClientConnection.h.
+* workers/service/ServiceWorkerContainer.cpp:
+
+2017-11-30  Chris Dumez  
+
 ServiceWorkerThread's m_extendedEvents gets destroyed on the wrong thread
 https://bugs.webkit.org/show_bug.cgi?id=180216
 


Modified: trunk/Source/WebCore/Sources.txt (225354 => 225355)

--- trunk/Source/WebCore/Sources.txt	2017-11-30 23:04:36 UTC (rev 225354)
+++ trunk/Source/WebCore/Sources.txt	2017-11-30 23:06:34 UTC (rev 225355)
@@ -2175,6 +2175,7 @@
 workers/service/ExtendableEvent.cpp
 workers/service/ExtendableMessageEvent.cpp
 workers/service/FetchEvent.cpp
+workers/service/SWClientConnection.cpp
 workers/service/ServiceWorker.cpp
 workers/service/ServiceWorkerClient.cpp
 workers/service/ServiceWorkerClientData.cpp
@@ -2199,7 +2200,6 @@
 workers/service/context/ServiceWorkerThreadProxy.cpp
 workers/service/context/SWContextManager.cpp
 
-workers/service/server/SWClientConnection.cpp
 workers/service/server/SWOriginStore.cpp
 workers/service/server/SWServer.cpp
 workers/service/server/SWServerJobQueue.cpp


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (225354 => 225355)

--- 

[webkit-changes] [225356] tags/Safari-605.1.14.3/

[jmarcell]

Title: [225356] tags/Safari-605.1.14.3/








Revision 225356
Author jmarc...@apple.com
Date 2017-11-30 15:06:48 -0800 (Thu, 30 Nov 2017)


Log Message
New tag.

Added Paths

tags/Safari-605.1.14.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225357] tags/Safari-605.1.14.3/Source

[jmarcell]

Title: [225357] tags/Safari-605.1.14.3/Source








Revision 225357
Author jmarc...@apple.com
Date 2017-11-30 15:10:26 -0800 (Thu, 30 Nov 2017)


Log Message
Versioning.

Modified Paths

tags/Safari-605.1.14.3/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-605.1.14.3/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-605.1.14.3/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-605.1.14.3/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-605.1.14.3/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-605.1.14.3/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-605.1.14.3/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-605.1.14.3/Source/_javascript_Core/Configurations/Version.xcconfig (225356 => 225357)

--- tags/Safari-605.1.14.3/Source/_javascript_Core/Configurations/Version.xcconfig	2017-11-30 23:06:48 UTC (rev 225356)
+++ tags/Safari-605.1.14.3/Source/_javascript_Core/Configurations/Version.xcconfig	2017-11-30 23:10:26 UTC (rev 225357)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-605.1.14.3/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (225356 => 225357)

--- tags/Safari-605.1.14.3/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-11-30 23:06:48 UTC (rev 225356)
+++ tags/Safari-605.1.14.3/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-11-30 23:10:26 UTC (rev 225357)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-605.1.14.3/Source/WebCore/Configurations/Version.xcconfig (225356 => 225357)

--- tags/Safari-605.1.14.3/Source/WebCore/Configurations/Version.xcconfig	2017-11-30 23:06:48 UTC (rev 225356)
+++ tags/Safari-605.1.14.3/Source/WebCore/Configurations/Version.xcconfig	2017-11-30 23:10:26 UTC (rev 225357)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-605.1.14.3/Source/WebCore/PAL/Configurations/Version.xcconfig (225356 => 225357)

--- tags/Safari-605.1.14.3/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-11-30 23:06:48 UTC (rev 225356)
+++ tags/Safari-605.1.14.3/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-11-30 23:10:26 UTC (rev 225357)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-605.1.14.3/Source/WebInspectorUI/Configurations/Version.xcconfig (225356 => 225357)

--- tags/Safari-605.1.14.3/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-11-30 23:06:48 UTC (rev 225356)
+++ tags/Safari-605.1.14.3/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-11-30 23:10:26 UTC (rev 225357)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-605.1.14.3/Source/WebKit/Configurations/Version.xcconfig (225356 => 225357)

--- tags/Safari-605.1.14.3/Source/WebKit/Configurations/Version.xcconfig	2017-11-30 23:06:48 UTC (rev 225356)
+++ tags/Safari-605.1.14.3/Source/WebKit/Configurations/Version.xcconfig	2017-11-30 23:10:26 UTC (rev 225357)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-605.1.14.3/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (225356 => 225357)

--- tags/Safari-605.1.14.3/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2017-11-30 23:06:48 UTC (rev 225356)
+++ tags/Safari-605.1.14.3/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2017-11-30 23:10:26 UTC (rev 225357)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 2;
+MICRO_VERSION = 3;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225359] trunk/Source/WebCore

[ryanhaddad]

Title: [225359] trunk/Source/WebCore








Revision 225359
Author ryanhad...@apple.com
Date 2017-11-30 15:17:34 -0800 (Thu, 30 Nov 2017)


Log Message
Unreviewed build fix, removed unused lambda captures.

* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::postFetchTask):
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (225358 => 225359)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 23:16:19 UTC (rev 225358)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 23:17:34 UTC (rev 225359)
@@ -1,3 +1,11 @@
+2017-11-30  Ryan Haddad  
+
+Unreviewed build fix, removed unused lambda captures.
+
+* workers/service/context/ServiceWorkerThread.cpp:
+(WebCore::ServiceWorkerThread::postFetchTask):
+(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
+
 2017-11-30  Chris Dumez  
 
 Move SWClientConnection class out of server/ folder


Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp (225358 => 225359)

--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp	2017-11-30 23:16:19 UTC (rev 225358)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp	2017-11-30 23:17:34 UTC (rev 225359)
@@ -98,7 +98,7 @@
 {
 // FIXME: instead of directly using runLoop(), we should be using something like WorkerGlobalScopeProxy.
 // FIXME: request and options come straigth from IPC so are already isolated. We should be able to take benefit of that.
-runLoop().postTaskForMode([this, client = WTFMove(client), clientId, request = request.isolatedCopy(), options = options.isolatedCopy()] (ScriptExecutionContext& context) mutable {
+runLoop().postTaskForMode([client = WTFMove(client), clientId, request = request.isolatedCopy(), options = options.isolatedCopy()] (ScriptExecutionContext& context) mutable {
 auto& serviceWorkerGlobalScope = downcast(context);
 auto fetchEvent = ServiceWorkerFetch::dispatchFetchEvent(WTFMove(client), serviceWorkerGlobalScope, clientId, WTFMove(request), WTFMove(options));
 serviceWorkerGlobalScope.updateExtendedEventsSet(fetchEvent.ptr());
@@ -107,7 +107,7 @@
 
 void ServiceWorkerThread::postMessageToServiceWorkerGlobalScope(Ref&& message, std::unique_ptr&& channels, ServiceWorkerClientIdentifier sourceIdentifier, ServiceWorkerClientData&& sourceData)
 {
-ScriptExecutionContext::Task task([this, channels = WTFMove(channels), message = WTFMove(message), sourceIdentifier, sourceData = sourceData.isolatedCopy()] (ScriptExecutionContext& context) mutable {
+ScriptExecutionContext::Task task([channels = WTFMove(channels), message = WTFMove(message), sourceIdentifier, sourceData = sourceData.isolatedCopy()] (ScriptExecutionContext& context) mutable {
 auto& serviceWorkerGlobalScope = downcast(context);
 auto ports = MessagePort::entanglePorts(serviceWorkerGlobalScope, WTFMove(channels));
 RefPtr source = ServiceWorkerClient::getOrCreate(serviceWorkerGlobalScope, sourceIdentifier, WTFMove(sourceData));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225360] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [225360] trunk/Source/_javascript_Core








Revision 225360
Author utatane@gmail.com
Date 2017-11-30 15:22:18 -0800 (Thu, 30 Nov 2017)


Log Message
[JSC] Use getEffectiveAddress more in JSC
https://bugs.webkit.org/show_bug.cgi?id=180154

Reviewed by Mark Lam.

We can use MacroAssembler::getEffectiveAddress for stack height calculation.
And we also add MacroAssembler::negPtr(src, dest) variation.

* assembler/MacroAssembler.h:
(JSC::MacroAssembler::negPtr):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::neg32):
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::neg32):
(JSC::MacroAssemblerARM64::neg64):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::neg32):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::neg32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::neg32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::neg64):
* dfg/DFGThunks.cpp:
(JSC::DFG::osrEntryThunkGenerator):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
* jit/SetupVarargsFrame.cpp:
(JSC::emitSetVarargsFrame):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
trunk/Source/_javascript_Core/dfg/DFGThunks.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/SetupVarargsFrame.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225359 => 225360)

--- trunk/Source/_javascript_Core/ChangeLog	2017-11-30 23:17:34 UTC (rev 225359)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-11-30 23:22:18 UTC (rev 225360)
@@ -1,3 +1,35 @@
+2017-11-29  Yusuke Suzuki  
+
+[JSC] Use getEffectiveAddress more in JSC
+https://bugs.webkit.org/show_bug.cgi?id=180154
+
+Reviewed by Mark Lam.
+
+We can use MacroAssembler::getEffectiveAddress for stack height calculation.
+And we also add MacroAssembler::negPtr(src, dest) variation.
+
+* assembler/MacroAssembler.h:
+(JSC::MacroAssembler::negPtr):
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::neg32):
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::neg32):
+(JSC::MacroAssemblerARM64::neg64):
+* assembler/MacroAssemblerARMv7.h:
+(JSC::MacroAssemblerARMv7::neg32):
+* assembler/MacroAssemblerMIPS.h:
+(JSC::MacroAssemblerMIPS::neg32):
+* assembler/MacroAssemblerX86Common.h:
+(JSC::MacroAssemblerX86Common::neg32):
+* assembler/MacroAssemblerX86_64.h:
+(JSC::MacroAssemblerX86_64::neg64):
+* dfg/DFGThunks.cpp:
+(JSC::DFG::osrEntryThunkGenerator):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
+* jit/SetupVarargsFrame.cpp:
+(JSC::emitSetVarargsFrame):
+
 2017-11-30  Mark Lam  
 
 jsc shell's flashHeapAccess() should not do JS work after releasing access to the heap.


Modified: trunk/Source/_javascript_Core/assembler/MacroAssembler.h (225359 => 225360)

--- trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2017-11-30 23:17:34 UTC (rev 225359)
+++ trunk/Source/_javascript_Core/assembler/MacroAssembler.h	2017-11-30 23:22:18 UTC (rev 225360)
@@ -597,6 +597,11 @@
 neg32(dest);
 }
 
+void negPtr(RegisterID src, RegisterID dest)
+{
+neg32(src, dest);
+}
+
 void orPtr(RegisterID src, RegisterID dest)
 {
 or32(src, dest);
@@ -906,6 +911,11 @@
 neg64(dest);
 }
 
+void negPtr(RegisterID src, RegisterID dest)
+{
+neg64(src, dest);
+}
+
 void orPtr(RegisterID src, RegisterID dest)
 {
 or64(src, dest);


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (225359 => 225360)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2017-11-30 23:17:34 UTC (rev 225359)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2017-11-30 23:22:18 UTC (rev 225360)
@@ -224,6 +224,11 @@
 m_assembler.rsbs(srcDest, srcDest, ARMAssembler::getOp2Byte(0));
 }
 
+void neg32(RegisterID src, RegisterID dest)
+{
+m_assembler.rsbs(dest, src, ARMAssembler::getOp2Byte(0));
+}
+
 void or32(RegisterID src, RegisterID dest)
 {
 m_assembler.orrs(dest, dest, src);


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h (225359 => 225360)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h	

[webkit-changes] [225363] trunk/Source

[mark . lam]

Title: [225363] trunk/Source








Revision 225363
Author mark@apple.com
Date 2017-11-30 15:47:35 -0800 (Thu, 30 Nov 2017)


Log Message
Let's scramble MacroAssemblerCodePtr values.
https://bugs.webkit.org/show_bug.cgi?id=180169


Reviewed by Filip Pizlo, Saam Barati, and JF Bastien.

Source/_javascript_Core:

1. MacroAssemblerCodePtr now stores a ScrambledPtr instead of a void*.

2. MacroAssemblerCodePtr's executableAddress() and dataLocation() now take a
   template argument type that will be used to cast the result.  This makes the
   client code that uses these functions a little less verbose.

3. Change the code base in general to minimize passing void* code pointers around.
   We now pass MacroAssemblerCodePtr as much as possible, and descramble it only
   at the last moment when we need the underlying code pointer.

4. Added some MasmScrambledPtr paranoid asserts that are disabled (not built) by
   default.  I'm leaving them in because they are instrumental in finding bugs
   where not all MacroAssemblerCodePtr values were not scrambled as expected.
   I expect them to be useful in the near future as we add more scrambling.

5. Also disable the casting operator on MacroAssemblerCodePtr (except for
   explicit casts to a boolean).  This ensures that clients will always explicitly
   use scrambledBits() or executableAddress() to get a value based on which value
   they actually need.

5. Added currentThread() id to the logging in LLIntSlowPath trace functions.
   This was helpful when debugging tests that ran multiple VMs concurrently on
   different threads.

MacroAssemblerCodePtr is currently supported on 64-bit builds (including the
CLoop).  It is not yet supported in 32-bit and Windows because we don't
currently have a way to read a global variable from their LLInt code.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::differenceBetweenCodePtr):
(JSC::AbstractMacroAssembler::linkPointer):
* assembler/CodeLocation.h:
(JSC::CodeLocationCommon::instructionAtOffset):
(JSC::CodeLocationCommon::labelAtOffset):
(JSC::CodeLocationCommon::jumpAtOffset):
(JSC::CodeLocationCommon::callAtOffset):
(JSC::CodeLocationCommon::nearCallAtOffset):
(JSC::CodeLocationCommon::dataLabelPtrAtOffset):
(JSC::CodeLocationCommon::dataLabel32AtOffset):
(JSC::CodeLocationCommon::dataLabelCompactAtOffset):
(JSC::CodeLocationCommon::convertibleLoadAtOffset):
* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
* assembler/LinkBuffer.h:
(JSC::LinkBuffer::link):
(JSC::LinkBuffer::patch):
* assembler/MacroAssemblerCodeRef.cpp:
(JSC::MacroAssemblerCodePtr::initialize):
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
(JSC::FunctionPtr::value const):
(JSC::FunctionPtr::executableAddress const):
(JSC::ReturnAddressPtr::ReturnAddressPtr):
(JSC::ReturnAddressPtr::value const):
(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::createFromExecutableAddress):
(JSC::MacroAssemblerCodePtr::scrambledPtr const):
(JSC::MacroAssemblerCodePtr:: const):
(JSC::MacroAssemblerCodePtr::operator! const):
(JSC::MacroAssemblerCodePtr::operator bool const):
(JSC::MacroAssemblerCodePtr::operator== const):
(JSC::MacroAssemblerCodePtr::hash const):
(JSC::MacroAssemblerCodePtr::emptyValue):
(JSC::MacroAssemblerCodePtr::deletedValue):
(JSC::MacroAssemblerCodePtr::executableAddress const): Deleted.
(JSC::MacroAssemblerCodePtr::dataLocation const): Deleted.
* b3/B3LowerMacros.cpp:
* b3/testb3.cpp:
(JSC::B3::testInterpreter):
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dumpDisassembly):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
(JSC::DFG::SpeculativeJIT::emitSwitchImm):
(JSC::DFG::SpeculativeJIT::emitSwitchCharStringJump):
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
* dfg/DFGSpeculativeJIT.h:
* disassembler/Disassembler.cpp:
(JSC::disassemble):
* disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassembleWithUDis86):
* ftl/FTLCompile.cpp:
(JSC::FTL::compile):
* ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::executableAddressAtOffset):
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMathIC):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
* interpreter/InterpreterInlines.h:
(JSC::Interpreter::getOpcodeID):
* jit/JITArithmetic.cpp:
(JSC::JIT::emitMathICFast):
(JSC::JIT::emitMathICSlow):
* jit/JITCode.cpp:
(JSC::JITCodeWithCodeRef::executableAddressAtOffset):
(JSC::JITCodeWithCodeRef::dataAddressAtOffset):
(JSC::JITCodeWithCodeRef::offsetOf):
* jit/JITDisassembler.cpp:
(JSC::JITDisassembler::dumpDisassembly):
* jit/PCToCodeOriginMap.cpp:

[webkit-changes] [225365] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [225365] trunk/Source/_javascript_Core








Revision 225365
Author utatane@gmail.com
Date 2017-11-30 15:56:17 -0800 (Thu, 30 Nov 2017)


Log Message
[JSC] Use AllocatorIfExists for MaterializeNewObject
https://bugs.webkit.org/show_bug.cgi?id=180189

Reviewed by Filip Pizlo.

I don't think anyone guarantees this allocator exists at this phase.
And nullptr allocator just works here. We change AllocatorForMode
to AllocatorIfExists to accept nullptr for allocator.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225364 => 225365)

--- trunk/Source/_javascript_Core/ChangeLog	2017-11-30 23:50:15 UTC (rev 225364)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-11-30 23:56:17 UTC (rev 225365)
@@ -1,3 +1,17 @@
+2017-11-30  Yusuke Suzuki  
+
+[JSC] Use AllocatorIfExists for MaterializeNewObject
+https://bugs.webkit.org/show_bug.cgi?id=180189
+
+Reviewed by Filip Pizlo.
+
+I don't think anyone guarantees this allocator exists at this phase.
+And nullptr allocator just works here. We change AllocatorForMode
+to AllocatorIfExists to accept nullptr for allocator.
+
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
+
 2017-11-30  Mark Lam  
 
 Let's scramble MacroAssemblerCodePtr values.


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (225364 => 225365)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2017-11-30 23:50:15 UTC (rev 225364)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2017-11-30 23:56:17 UTC (rev 225365)
@@ -9688,7 +9688,7 @@
 
 if (structure->outOfLineCapacity() || hasIndexedProperties(structure->indexingType())) {
 size_t allocationSize = JSFinalObject::allocationSize(structure->inlineCapacity());
-MarkedAllocator* cellAllocator = subspaceFor(vm())->allocatorForNonVirtual(allocationSize, AllocatorForMode::MustAlreadyHaveAllocator);
+MarkedAllocator* cellAllocator = subspaceFor(vm())->allocatorForNonVirtual(allocationSize, AllocatorForMode::AllocatorIfExists);
 
 bool hasIndexingHeader = hasIndexedProperties(structure->indexingType());
 unsigned indexingHeaderSize = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225353] tags/Safari-604.5.1/

[jmarcell]

Title: [225353] tags/Safari-604.5.1/








Revision 225353
Author jmarc...@apple.com
Date 2017-11-30 15:03:51 -0800 (Thu, 30 Nov 2017)


Log Message
Delete tag.

Removed Paths

tags/Safari-604.5.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225354] tags/Safari-604.5.1/

[jmarcell]

Title: [225354] tags/Safari-604.5.1/








Revision 225354
Author jmarc...@apple.com
Date 2017-11-30 15:04:36 -0800 (Thu, 30 Nov 2017)


Log Message
Tag Safari-604.5.1.

Added Paths

tags/Safari-604.5.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225358] trunk

[achristensen]

Title: [225358] trunk








Revision 225358
Author achristen...@apple.com
Date 2017-11-30 15:16:19 -0800 (Thu, 30 Nov 2017)


Log Message
WKURLSchemeHandler.request should include HTTPBody
https://bugs.webkit.org/show_bug.cgi?id=180220

Reviewed by Brady Eidson.

Source/WebKit:

* Shared/URLSchemeTaskParameters.cpp: Added.
(WebKit::URLSchemeTaskParameters::encode const):
(WebKit::URLSchemeTaskParameters::decode):
* Shared/URLSchemeTaskParameters.h: Added.
* UIProcess/API/Cocoa/WKURLSchemeTask.mm:
(-[WKURLSchemeTaskImpl request]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::startURLSchemeTask):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebURLSchemeHandler.cpp:
(WebKit::WebURLSchemeHandler::startTask):
* UIProcess/WebURLSchemeHandler.h:
* UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::create):
(WebKit::WebURLSchemeTask::WebURLSchemeTask):
* UIProcess/WebURLSchemeTask.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebURLSchemeTaskProxy.cpp:
(WebKit::WebURLSchemeTaskProxy::startLoading):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
(-[FormSubmissionDelegate webView:startURLSchemeTask:]):

Modified Paths

trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKURLSchemeTask.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/UIProcess/WebURLSchemeHandler.cpp
trunk/Source/WebKit/UIProcess/WebURLSchemeHandler.h
trunk/Source/WebKit/UIProcess/WebURLSchemeTask.cpp
trunk/Source/WebKit/UIProcess/WebURLSchemeTask.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebPage/WebURLSchemeTaskProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm


Added Paths

trunk/Source/WebKit/Shared/URLSchemeTaskParameters.cpp
trunk/Source/WebKit/Shared/URLSchemeTaskParameters.h




Diff

Modified: trunk/Source/WebKit/CMakeLists.txt (225357 => 225358)

--- trunk/Source/WebKit/CMakeLists.txt	2017-11-30 23:10:26 UTC (rev 225357)
+++ trunk/Source/WebKit/CMakeLists.txt	2017-11-30 23:16:19 UTC (rev 225358)
@@ -184,6 +184,7 @@
 Shared/SharedStringHashTableReadOnly.cpp
 Shared/SharedStringHashTable.cpp
 Shared/StatisticsData.cpp
+Shared/URLSchemeTaskParameters.cpp
 Shared/UpdateInfo.cpp
 Shared/UserData.cpp
 Shared/WebBackForwardListItem.cpp


Modified: trunk/Source/WebKit/ChangeLog (225357 => 225358)

--- trunk/Source/WebKit/ChangeLog	2017-11-30 23:10:26 UTC (rev 225357)
+++ trunk/Source/WebKit/ChangeLog	2017-11-30 23:16:19 UTC (rev 225358)
@@ -1,3 +1,31 @@
+2017-11-30  Alex Christensen  
+
+WKURLSchemeHandler.request should include HTTPBody
+https://bugs.webkit.org/show_bug.cgi?id=180220
+
+Reviewed by Brady Eidson.
+
+* Shared/URLSchemeTaskParameters.cpp: Added.
+(WebKit::URLSchemeTaskParameters::encode const):
+(WebKit::URLSchemeTaskParameters::decode):
+* Shared/URLSchemeTaskParameters.h: Added.
+* UIProcess/API/Cocoa/WKURLSchemeTask.mm:
+(-[WKURLSchemeTaskImpl request]):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::startURLSchemeTask):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebPageProxy.messages.in:
+* UIProcess/WebURLSchemeHandler.cpp:
+(WebKit::WebURLSchemeHandler::startTask):
+* UIProcess/WebURLSchemeHandler.h:
+* UIProcess/WebURLSchemeTask.cpp:
+(WebKit::WebURLSchemeTask::create):
+(WebKit::WebURLSchemeTask::WebURLSchemeTask):
+* UIProcess/WebURLSchemeTask.h:
+* WebKit.xcodeproj/project.pbxproj:
+* WebProcess/WebPage/WebURLSchemeTaskProxy.cpp:
+(WebKit::WebURLSchemeTaskProxy::startLoading):
+
 2017-11-30  Darin Adler  
 
 [Mac] remove unneeded RetainPtr use introduced in r225142


Added: trunk/Source/WebKit/Shared/URLSchemeTaskParameters.cpp (0 => 225358)

--- trunk/Source/WebKit/Shared/URLSchemeTaskParameters.cpp	(rev 0)
+++ trunk/Source/WebKit/Shared/URLSchemeTaskParameters.cpp	2017-11-30 23:16:19 UTC (rev 225358)
@@ -0,0 +1,77 @@
+/*
+ * Copyright (C) 2017 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED 

[webkit-changes] [225362] trunk/Source

[utatane . tea]

Title: [225362] trunk/Source








Revision 225362
Author utatane@gmail.com
Date 2017-11-30 15:44:24 -0800 (Thu, 30 Nov 2017)


Log Message
[JSC] Remove easy toRemove & map.remove() use
https://bugs.webkit.org/show_bug.cgi?id=180208

Reviewed by Mark Lam.

Source/_javascript_Core:

In this patch, we replace Vector<> toRemove & map.remove loop with removeIf,
to optimize this common pattern. This patch only modifies apparent ones.
But we can apply this refactoring further to OAS phase in the future.

* b3/B3MoveConstants.cpp:
* dfg/DFGArgumentsEliminationPhase.cpp:
* dfg/DFGObjectAllocationSinkingPhase.cpp:
* wasm/WasmSignature.cpp:
(JSC::Wasm::SignatureInformation::tryCleanup):

Source/WTF:

Return bool from removeIf. It is true if removeIf removes at least one entry.
This interface is similar to existing HashSet::remove, which returns true
if it actually removes entry.

* wtf/HashMap.h:
(WTF::X>::removeIf):
* wtf/HashSet.h:
(WTF::V>::removeIf):
* wtf/HashTable.h:
(WTF::KeyTraits>::removeIf):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp
trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp
trunk/Source/_javascript_Core/wasm/WasmSignature.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/HashMap.h
trunk/Source/WTF/wtf/HashSet.h
trunk/Source/WTF/wtf/HashTable.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225361 => 225362)

--- trunk/Source/_javascript_Core/ChangeLog	2017-11-30 23:39:14 UTC (rev 225361)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-11-30 23:44:24 UTC (rev 225362)
@@ -1,3 +1,20 @@
+2017-11-30  Yusuke Suzuki  
+
+[JSC] Remove easy toRemove & map.remove() use
+https://bugs.webkit.org/show_bug.cgi?id=180208
+
+Reviewed by Mark Lam.
+
+In this patch, we replace Vector<> toRemove & map.remove loop with removeIf,
+to optimize this common pattern. This patch only modifies apparent ones.
+But we can apply this refactoring further to OAS phase in the future.
+
+* b3/B3MoveConstants.cpp:
+* dfg/DFGArgumentsEliminationPhase.cpp:
+* dfg/DFGObjectAllocationSinkingPhase.cpp:
+* wasm/WasmSignature.cpp:
+(JSC::Wasm::SignatureInformation::tryCleanup):
+
 2017-11-29  Yusuke Suzuki  
 
 [JSC] Use getEffectiveAddress more in JSC


Modified: trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp (225361 => 225362)

--- trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp	2017-11-30 23:39:14 UTC (rev 225361)
+++ trunk/Source/_javascript_Core/b3/B3MoveConstants.cpp	2017-11-30 23:44:24 UTC (rev 225362)
@@ -342,10 +342,8 @@
 }
 
 Procedure& m_proc;
-Vector m_toRemove;
 HashMap m_constTable;
 int64_t* m_dataSection;
-HashMap m_constants;
 InsertionSet m_insertionSet;
 };
 


Modified: trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp (225361 => 225362)

--- trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp	2017-11-30 23:39:14 UTC (rev 225361)
+++ trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp	2017-11-30 23:44:24 UTC (rev 225362)
@@ -192,20 +192,10 @@
 {
 bool changed;
 do {
-changed = false;
-Vector toRemove;
-
-for (Node* candidate : m_candidates) {
-if (!isStillValidCandidate(candidate))
-toRemove.append(candidate);
-}
-
-if (toRemove.size()) {
-changed = true;
-for (Node* node : toRemove)
-m_candidates.remove(node);
-}
-
+changed = m_candidates.removeIf(
+[&] (Node* candidate) {
+return !isStillValidCandidate(candidate);
+});
 } while (changed);
 }
 


Modified: trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp (225361 => 225362)

--- trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp	2017-11-30 23:39:14 UTC (rev 225361)
+++ trunk/Source/_javascript_Core/dfg/DFGObjectAllocationSinkingPhase.cpp	2017-11-30 23:44:24 UTC (rev 225362)
@@ -507,14 +507,10 @@
 
 void pruneByLiveness(const NodeSet& live)
 {
-Vector toRemove;
-for (const auto& entry : m_pointers) {
-if (!live.contains(entry.key))
-toRemove.append(entry.key);
-}
-for (Node* node : toRemove)
-m_pointers.remove(node);
-
+m_pointers.removeIf(
+[&] (const auto& entry) {
+return !live.contains(entry.key);
+});
 prune();
 }
 
@@ -682,15 +678,10 @@
 }
 
 // Remove unreachable allocations
-{
-Vector toRemove;
-for (const auto& entry : 

[webkit-changes] [225364] trunk/LayoutTests

[cdumez]

Title: [225364] trunk/LayoutTests








Revision 225364
Author cdu...@apple.com
Date 2017-11-30 15:50:15 -0800 (Thu, 30 Nov 2017)


Log Message
Unreviewed, unskip service worker test that no longer times out after r225346.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt:
* web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https-expected.txt:

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (225363 => 225364)

--- trunk/LayoutTests/ChangeLog	2017-11-30 23:47:35 UTC (rev 225363)
+++ trunk/LayoutTests/ChangeLog	2017-11-30 23:50:15 UTC (rev 225364)
@@ -1,3 +1,9 @@
+2017-11-30  Chris Dumez  
+
+Unreviewed, unskip service worker test that no longer times out after r225346.
+
+* TestExpectations:
+
 2017-11-30  Dean Jackson  
 
 Skip WebGL on iOS while working out what ANGLE has broken.


Modified: trunk/LayoutTests/TestExpectations (225363 => 225364)

--- trunk/LayoutTests/TestExpectations	2017-11-30 23:47:35 UTC (rev 225363)
+++ trunk/LayoutTests/TestExpectations	2017-11-30 23:50:15 UTC (rev 225364)
@@ -176,7 +176,6 @@
 imported/w3c/web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/serviceworker-message-event-historical.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https.html [ Skip ]
-imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/update-after-navigation-fetch-event.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/update-after-oneday.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/update-recovery.https.html [ Skip ]


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (225363 => 225364)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-11-30 23:47:35 UTC (rev 225363)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-11-30 23:50:15 UTC (rev 225364)
@@ -1,5 +1,12 @@
 2017-11-30  Chris Dumez  
 
+Unreviewed, unskip service worker test that no longer times out after r225346.
+
+* web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt:
+* web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https-expected.txt:
+
+2017-11-30  Chris Dumez  
+
 ServiceWorkerGlobalScope::skipWaiting() should resolve its promise
 https://bugs.webkit.org/show_bug.cgi?id=180204
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt (225363 => 225364)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt	2017-11-30 23:47:35 UTC (rev 225363)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt	2017-11-30 23:50:15 UTC (rev 225364)
@@ -2,5 +2,4 @@
 Harness Error (TIMEOUT), message = null
 
 PASS Test skipWaiting while a client is using the registration 
-TIMEOUT skipWaiting Test timed out
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https-expected.txt (225363 => 225364)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https-expected.txt	2017-11-30 23:47:35 UTC (rev 225363)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https-expected.txt	2017-11-30 23:50:15 UTC (rev 225364)
@@ -1,6 +1,4 @@
 
-Harness Error (TIMEOUT), message = null
-
 PASS Test single skipWaiting() when no client attached 
-TIMEOUT skipWaiting Test timed out
+FAIL skipWaiting promise_test: Unhandled rejection with value: object "NotSupportedError: self.skipWaiting() is not yet supported"
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225379] trunk

[zalan]

Title: [225379] trunk








Revision 225379
Author za...@apple.com
Date 2017-11-30 18:54:29 -0800 (Thu, 30 Nov 2017)


Log Message
Source/WebCore:
[Simple line layout] Incorrect repaint rect with vertically shrinking content and bottom-padding.
https://bugs.webkit.org/show_bug.cgi?id=180223


Reviewed by Simon Fraser.

Repaint rect should be extended all the way to bottom border/padding.

Test: fast/repaint/simple-line-layout-shrinking-content.html

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutSimpleLines):

LayoutTests:
[Simple line layout] Incorrect repaint rect with vertically shrinking content.
https://bugs.webkit.org/show_bug.cgi?id=180223


Reviewed by Simon Fraser.

* fast/repaint/simple-line-layout-shrinking-content-expected.txt: Added.
* fast/repaint/simple-line-layout-shrinking-content.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp


Added Paths

trunk/LayoutTests/fast/repaint/simple-line-layout-shrinking-content-expected.txt
trunk/LayoutTests/fast/repaint/simple-line-layout-shrinking-content.html




Diff

Modified: trunk/LayoutTests/ChangeLog (225378 => 225379)

--- trunk/LayoutTests/ChangeLog	2017-12-01 02:41:10 UTC (rev 225378)
+++ trunk/LayoutTests/ChangeLog	2017-12-01 02:54:29 UTC (rev 225379)
@@ -1,3 +1,14 @@
+2017-11-30  Zalan Bujtas  
+
+[Simple line layout] Incorrect repaint rect with vertically shrinking content.
+https://bugs.webkit.org/show_bug.cgi?id=180223
+
+
+Reviewed by Simon Fraser.
+
+* fast/repaint/simple-line-layout-shrinking-content-expected.txt: Added.
+* fast/repaint/simple-line-layout-shrinking-content.html: Added.
+
 2017-11-30  Simon Fraser  
 
 Improve filter logging


Added: trunk/LayoutTests/fast/repaint/simple-line-layout-shrinking-content-expected.txt (0 => 225379)

--- trunk/LayoutTests/fast/repaint/simple-line-layout-shrinking-content-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/repaint/simple-line-layout-shrinking-content-expected.txt	2017-12-01 02:54:29 UTC (rev 225379)
@@ -0,0 +1,9 @@
+foo
+(repaint rects
+  (rect 8 40 784 20)
+  (rect 8 39 784 1)
+  (rect 8 9 784 31)
+  (rect 8 40 784 20)
+  (rect 0 48 800 20)
+)
+


Added: trunk/LayoutTests/fast/repaint/simple-line-layout-shrinking-content.html (0 => 225379)

--- trunk/LayoutTests/fast/repaint/simple-line-layout-shrinking-content.html	(rev 0)
+++ trunk/LayoutTests/fast/repaint/simple-line-layout-shrinking-content.html	2017-12-01 02:54:29 UTC (rev 225379)
@@ -0,0 +1,41 @@
+
+
+
+
+div {
+white-space: pre-line;
+padding-bottom: 10px;
+font-size: 20px;
+font-family: ahem;
+border: 1px solid blue;
+}
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+
+
+foo
+bar
+
+document.body.offsetWidth;
+setTimeout(function() {
+if (window.internals)
+internals.startTrackingRepaints();
+document.getElementById('text').innerHTML = "foo";
+if (window.internals) {
+let repaintRects = internals.repaintRectsAsText();
+internals.stopTrackingRepaints();
+
+let pre = document.createElement('pre');
+document.body.appendChild(pre);
+pre.innerHTML = repaintRects;
+testRunner.notifyDone();
+}
+}, 10);
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (225378 => 225379)

--- trunk/Source/WebCore/ChangeLog	2017-12-01 02:41:10 UTC (rev 225378)
+++ trunk/Source/WebCore/ChangeLog	2017-12-01 02:54:29 UTC (rev 225379)
@@ -1,3 +1,18 @@
+2017-11-30  Zalan Bujtas  
+
+[Simple line layout] Incorrect repaint rect with vertically shrinking content and bottom-padding.
+https://bugs.webkit.org/show_bug.cgi?id=180223
+
+
+Reviewed by Simon Fraser.
+
+Repaint rect should be extended all the way to bottom border/padding.
+
+Test: fast/repaint/simple-line-layout-shrinking-content.html
+
+* rendering/RenderBlockFlow.cpp:
+(WebCore::RenderBlockFlow::layoutSimpleLines):
+
 2017-11-30  Stephan Szabo  
 
 Make LegacyCustomProtocolManager optional for network process


Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (225378 => 225379)

--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2017-12-01 02:41:10 UTC (rev 225378)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2017-12-01 02:54:29 UTC (rev 225379)
@@ -3594,7 +3594,7 @@
 LayoutUnit lineLayoutHeight = SimpleLineLayout::computeFlowHeight(*this, *m_simpleLineLayout);
 LayoutUnit lineLayoutTop = borderAndPaddingBefore();
 repaintLogicalTop = lineLayoutTop;
-repaintLogicalBottom = needsLayout ? repaintLogicalTop + lineLayoutHeight : repaintLogicalTop;
+repaintLogicalBottom = needsLayout ? repaintLogicalTop + lineLayoutHeight + borderAndPaddingAfter() : 

[webkit-changes] [225376] trunk/Tools

[dewei_zhu]

Title: [225376] trunk/Tools








Revision 225376
Author dewei_...@apple.com
Date 2017-11-30 17:52:37 -0800 (Thu, 30 Nov 2017)


Log Message
HTTP server driver is responsible for ensuring the dependencies of HTTP server.
https://bugs.webkit.org/show_bug.cgi?id=180231

Reviewed by Stephanie Lewis.

Added the logic to ensure system environment meet the requirments of launching the http server.

* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver.set_device_id):
(SimpleHTTPServerDriver):
(SimpleHTTPServerDriver._ensure_http_server_dependencies):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py




Diff

Modified: trunk/Tools/ChangeLog (225375 => 225376)

--- trunk/Tools/ChangeLog	2017-12-01 01:02:47 UTC (rev 225375)
+++ trunk/Tools/ChangeLog	2017-12-01 01:52:37 UTC (rev 225376)
@@ -1,3 +1,18 @@
+2017-11-30  Dewei Zhu  
+
+HTTP server driver is responsible for ensuring the dependencies of HTTP server.
+https://bugs.webkit.org/show_bug.cgi?id=180231
+
+Reviewed by Stephanie Lewis.
+
+Added the logic to ensure system environment meet the requirments of launching the http server.
+
+* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
+(SimpleHTTPServerDriver.serve):
+(SimpleHTTPServerDriver.set_device_id):
+(SimpleHTTPServerDriver):
+(SimpleHTTPServerDriver._ensure_http_server_dependencies):
+
 2017-11-30  Basuke Suzuki  
 
 [WinCairo] Cannot build without Internet connection


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py (225375 => 225376)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py	2017-12-01 01:02:47 UTC (rev 225375)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py	2017-12-01 01:52:37 UTC (rev 225376)
@@ -25,6 +25,7 @@
 self._server_process = None
 self._server_port = 0
 self._ip = '127.0.0.1'
+self._ensure_http_server_dependencies()
 
 def serve(self, web_root):
 _log.info('Launching an http server')
@@ -93,3 +94,14 @@
 
 def set_device_id(self, device_id):
 pass
+
+def _ensure_http_server_dependencies(self):
+_log.info('Ensure dependencies of http server is satisfied')
+from pkg_resources import require, VersionConflict, DistributionNotFound
+try:
+require("Twisted>=15.5.0")
+import twisted
+except (ImportError, VersionConflict, DistributionNotFound):
+_log.info("Will install twisted in webkitpy, and twisted will be used by webkitpy only")
+sys.path.append(os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)), '../../../..')))
+from webkitpy.thirdparty.autoinstalled.twisted_15_5_0 import twisted






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225377] trunk

[commit-queue]

Title: [225377] trunk








Revision 225377
Author commit-qu...@webkit.org
Date 2017-11-30 18:04:07 -0800 (Thu, 30 Nov 2017)


Log Message
Make LegacyCustomProtocolManager optional for network process
https://bugs.webkit.org/show_bug.cgi?id=176230

Patch by Stephan Szabo  on 2017-11-30
Reviewed by Alex Christensen.

.:

* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests, only sets up feature define

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initializeNetworkProcess):
* PlatformGTK.cmake:
* PlatformMac.cmake:
* PlatformWPE.cmake:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didClose):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setLegacyCustomProtocolManagerClient):
(WebKit::WebProcessPool::registerSchemeForCustomProtocol):
(WebKit::WebProcessPool::unregisterSchemeForCustomProtocol):

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformMac.cmake
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/cmake/OptionsWin.cmake
trunk/Source/cmake/WebKitFeatures.cmake
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/ChangeLog (225376 => 225377)

--- trunk/ChangeLog	2017-12-01 01:52:37 UTC (rev 225376)
+++ trunk/ChangeLog	2017-12-01 02:04:07 UTC (rev 225377)
@@ -1,3 +1,13 @@
+2017-11-30  Stephan Szabo  
+
+Make LegacyCustomProtocolManager optional for network process
+https://bugs.webkit.org/show_bug.cgi?id=176230
+
+Reviewed by Alex Christensen.
+
+* Source/cmake/OptionsWin.cmake:
+* Source/cmake/WebKitFeatures.cmake:
+
 2017-11-29  Alex Christensen  
 
 Fix Mac CMake build.


Modified: trunk/Source/_javascript_Core/ChangeLog (225376 => 225377)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-01 01:52:37 UTC (rev 225376)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-01 02:04:07 UTC (rev 225377)
@@ -1,3 +1,12 @@
+2017-11-30  Stephan Szabo  
+
+Make LegacyCustomProtocolManager optional for network process
+https://bugs.webkit.org/show_bug.cgi?id=176230
+
+Reviewed by Alex Christensen.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-11-30  Yusuke Suzuki  
 
 [JSC] Remove easy toRemove & map.remove() use in OAS phase


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (225376 => 225377)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-12-01 01:52:37 UTC (rev 225376)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-12-01 02:04:07 UTC (rev 225377)
@@ -132,6 +132,7 @@
 ENABLE_KEYBOARD_KEY_ATTRIBUTE = ENABLE_KEYBOARD_KEY_ATTRIBUTE;
 ENABLE_KEYBOARD_CODE_ATTRIBUTE = ENABLE_KEYBOARD_CODE_ATTRIBUTE;
 ENABLE_LEGACY_CSS_VENDOR_PREFIXES = ENABLE_LEGACY_CSS_VENDOR_PREFIXES;
+ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER = ENABLE_LEGACY_CUSTOM_PROTOCOL_MANAGER;
 ENABLE_LEGACY_ENCRYPTED_MEDIA = ENABLE_LEGACY_ENCRYPTED_MEDIA;
 ENABLE_LETTERPRESS[sdk=iphone*] = ENABLE_LETTERPRESS;
 ENABLE_LINK_PREFETCH = ;
@@ -249,4 +250,4 @@
 ENABLE_DATA_INTERACTION[sdk=iphoneos10*] = ;
 ENABLE_DATA_INTERACTION[sdk=iphonesimulator10*] = ;
 
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_ALTERNATIVE_PRESENTATION_BUTTON_ELEMENT) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CHANNEL_MESSAGING) 

[webkit-changes] [225378] trunk

[jfbastien]

Title: [225378] trunk








Revision 225378
Author jfbast...@apple.com
Date 2017-11-30 18:41:10 -0800 (Thu, 30 Nov 2017)


Log Message
WebAssembly: improve stack trace
https://bugs.webkit.org/show_bug.cgi?id=179343

Reviewed by Saam Barati.

JSTests:

Update the tests to follow the new format. Notably, SHA1 module
hash is now included in traces, and stubs are properly identified.

* wasm/assert.js: Add an assertion which matches regular expressions.
* wasm/function-tests/nameSection.js:
* wasm/function-tests/stack-overflow.js:
(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.assertOverflows):
(assertOverflows.assertThrows.wasm.1):
(assertOverflows.assertThrows.wasm.0):
(assertOverflows.assertThrows):
(assertOverflows):
* wasm/function-tests/stack-trace.js:
(import.Builder.from.string_appeared_here.assert): Deleted.
* wasm/function-tests/trap-after-cross-instance-call.js:
(wasmFrameCountFromError):
* wasm/function-tests/trap-load-2.js:
(wasmFrameCountFromError):
* wasm/function-tests/trap-load.js:
(wasmFrameCountFromError):

Source/_javascript_Core:

Stack traces now include:

  - Module name, if provided by the name section.
  - Module SHA1 hash if no name was provided
  - Stub identification, to differentiate from user code
  - Slightly different naming to match design from:
  https://github.com/WebAssembly/design/blob/master/Web.md#developer-facing-display-conventions

* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::functionName const):
* runtime/StackFrame.cpp:
(JSC::StackFrame::functionName const):
(JSC::StackFrame::visitChildren):
* wasm/WasmIndexOrName.cpp:
(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::makeString):
* wasm/WasmIndexOrName.h:
(JSC::Wasm::IndexOrName::nameSection const):
* wasm/WasmModuleInformation.cpp:
(JSC::Wasm::ModuleInformation::ModuleInformation):
* wasm/WasmModuleInformation.h:
* wasm/WasmNameSection.h:
(JSC::Wasm::NameSection::NameSection):
(JSC::Wasm::NameSection::get):
* wasm/WasmNameSectionParser.cpp:
(JSC::Wasm::NameSectionParser::parse):

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/assert.js
trunk/JSTests/wasm/function-tests/nameSection.js
trunk/JSTests/wasm/function-tests/stack-overflow.js
trunk/JSTests/wasm/function-tests/stack-trace.js
trunk/JSTests/wasm/function-tests/trap-after-cross-instance-call.js
trunk/JSTests/wasm/function-tests/trap-load-2.js
trunk/JSTests/wasm/function-tests/trap-load.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp
trunk/Source/_javascript_Core/runtime/StackFrame.cpp
trunk/Source/_javascript_Core/wasm/WasmIndexOrName.cpp
trunk/Source/_javascript_Core/wasm/WasmIndexOrName.h
trunk/Source/_javascript_Core/wasm/WasmModuleInformation.cpp
trunk/Source/_javascript_Core/wasm/WasmModuleInformation.h
trunk/Source/_javascript_Core/wasm/WasmNameSection.h
trunk/Source/_javascript_Core/wasm/WasmNameSectionParser.cpp




Diff

Modified: trunk/JSTests/ChangeLog (225377 => 225378)

--- trunk/JSTests/ChangeLog	2017-12-01 02:04:07 UTC (rev 225377)
+++ trunk/JSTests/ChangeLog	2017-12-01 02:41:10 UTC (rev 225378)
@@ -1,3 +1,30 @@
+2017-11-30  JF Bastien  
+
+WebAssembly: improve stack trace
+https://bugs.webkit.org/show_bug.cgi?id=179343
+
+Reviewed by Saam Barati.
+
+Update the tests to follow the new format. Notably, SHA1 module
+hash is now included in traces, and stubs are properly identified.
+
+* wasm/assert.js: Add an assertion which matches regular expressions.
+* wasm/function-tests/nameSection.js:
+* wasm/function-tests/stack-overflow.js:
+(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.assertOverflows):
+(assertOverflows.assertThrows.wasm.1):
+(assertOverflows.assertThrows.wasm.0):
+(assertOverflows.assertThrows):
+(assertOverflows):
+* wasm/function-tests/stack-trace.js:
+(import.Builder.from.string_appeared_here.assert): Deleted.
+* wasm/function-tests/trap-after-cross-instance-call.js:
+(wasmFrameCountFromError):
+* wasm/function-tests/trap-load-2.js:
+(wasmFrameCountFromError):
+* wasm/function-tests/trap-load.js:
+(wasmFrameCountFromError):
+
 2017-11-30  Mark Lam  
 
 jsc shell's flashHeapAccess() should not do JS work after releasing access to the heap.


Modified: trunk/JSTests/wasm/assert.js (225377 => 225378)

--- trunk/JSTests/wasm/assert.js	2017-12-01 02:04:07 UTC (rev 225377)
+++ trunk/JSTests/wasm/assert.js	2017-12-01 02:41:10 UTC (rev 225378)
@@ -89,6 +89,13 @@
 }
 };
 
+export const matches = (lhs, rhs, msg) => {
+if (typeof lhs !== "string" || !(rhs instanceof RegExp))
+_fail(`Expected string and regex object, got ${typeof lhs} and ${typeof rhs}`, msg);
+if (!rhs.test(lhs))
+_fail(`"${msg}" does not match ${rhs}`, msg);
+};
+
 const 

[webkit-changes] [225327] trunk/Tools

[mcatanzaro]

Title: [225327] trunk/Tools








Revision 225327
Author mcatanz...@igalia.com
Date 2017-11-30 07:01:53 -0800 (Thu, 30 Nov 2017)


Log Message
[WPE] Stop building Wayland in JHBuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=179951

Reviewed by Žan Doberšek.

Since Wayland is not used for running tests, and since it does not seem to depend on
anything in the JHBuild moduleset, I think we can remove it safely without having to worry
that the system version of Wayland might use libraries in the JHBuild environment (which
would be unsafe).

* wpe/install-dependencies: Install Wayland.
* wpe/jhbuild.modules: Stop building Wayland.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/wpe/install-dependencies
trunk/Tools/wpe/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (225326 => 225327)

--- trunk/Tools/ChangeLog	2017-11-30 13:48:46 UTC (rev 225326)
+++ trunk/Tools/ChangeLog	2017-11-30 15:01:53 UTC (rev 225327)
@@ -1,3 +1,18 @@
+2017-11-30  Michael Catanzaro  
+
+[WPE] Stop building Wayland in JHBuild moduleset
+https://bugs.webkit.org/show_bug.cgi?id=179951
+
+Reviewed by Žan Doberšek.
+
+Since Wayland is not used for running tests, and since it does not seem to depend on
+anything in the JHBuild moduleset, I think we can remove it safely without having to worry
+that the system version of Wayland might use libraries in the JHBuild environment (which
+would be unsafe).
+
+* wpe/install-dependencies: Install Wayland.
+* wpe/jhbuild.modules: Stop building Wayland.
+
 2017-11-30  Alexey Proskuryakov  
 
 Silence the BitVector leak for


Modified: trunk/Tools/wpe/install-dependencies (225326 => 225327)

--- trunk/Tools/wpe/install-dependencies	2017-11-30 13:48:46 UTC (rev 225326)
+++ trunk/Tools/wpe/install-dependencies	2017-11-30 15:01:53 UTC (rev 225327)
@@ -122,6 +122,7 @@
 libvpx-dev \
 libxcb-xkb-dev \
 libxml-libxml-perl \
+libwayland-dev \
 luajit"
 
 # These are dependencies necessary for using webkit-patch
@@ -210,8 +211,9 @@
 mesa-libgl \
 opus \
 orc \
-perl-xml-libxml\
-v4l-utils"
+perl-xml-libxml \
+v4l-utils \
+wayland"
 
 # These are dependencies necessary for using webkit-patch
 packages="$packages \
@@ -292,7 +294,8 @@
 opus-devel \
 orc-devel \
 perl-XML-LibXML \
-pulseaudio-libs-devel"
+pulseaudio-libs-devel \
+wayland-devel"
 
 # These are dependencies necessary for using webkit-patch
 packages="$packages


Modified: trunk/Tools/wpe/jhbuild.modules (225326 => 225327)

--- trunk/Tools/wpe/jhbuild.modules	2017-11-30 13:48:46 UTC (rev 225326)
+++ trunk/Tools/wpe/jhbuild.modules	2017-11-30 15:01:53 UTC (rev 225327)
@@ -16,7 +16,6 @@
   
   
   
-  
   
   
   
@@ -36,8 +35,6 @@
   href=""
  href=""
-href=""
   @@ -161,14 +158,6 @@
 hash="sha1:7127993bfb69e13cdff25fb8b3c8f26ce6be5bfa"/>
   
 
-  
-
-  
-
   
  tag="3013faaebab42e7ef7497b3850a2902978eb3d6f" />
@@ -178,7 +167,6 @@
 
   
   
-  
   
 
 





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225328] trunk/Source

[zandobersek]

Title: [225328] trunk/Source








Revision 225328
Author zandober...@gmail.com
Date 2017-11-30 07:12:58 -0800 (Thu, 30 Nov 2017)


Log Message
[CoordGraphics] Move CoordinatedGraphicsLayer painting behind Nicosia::PaintingEngine
https://bugs.webkit.org/show_bug.cgi?id=180141

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Introduce a painting engine concept that's used to perform painting
for a given GraphicsLayer object.

The Nicosia::PaintingEngine object is leveraged in the
CoordinatedGraphicsLayer::updateContentBuffers() method. It's retrieved
through the CoordinatedGraphicsLayerClient interface, with a new method
introduced there for this purpose.

The Nicosia::PaintingEngine interface is kept simple for now, with only
a single paint() method. The only current implementation is the
PaintingEngineBasic class, which simply reuses the code that was
previously in CoordinatedGraphicsLayer::updateContentBuffers(),
maintaining the current functionality.

The Nicosia::PaintingEngine::create() function returns a new
PaintingEngine object. For now it defaults to PaintingEngineBasic, but
it could be configured at configure-time or even runtime in the future
to return a more advanced engine implementation.

No new tests -- no change in behavior.

* platform/TextureMapper.cmake:
* platform/graphics/nicosia/NicosiaPaintingEngine.cpp: Added.
(Nicosia::PaintingEngine::create):
* platform/graphics/nicosia/NicosiaPaintingEngine.h: Added.
* platform/graphics/nicosia/NicosiaPaintingEngineBasic.cpp: Added.
(Nicosia::PaintingEngineBasic::paint):
* platform/graphics/nicosia/NicosiaPaintingEngineBasic.h: Added.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

CompositingCoordinator must implement the paintingEngine() method now
that the method's been added to the CoordinatedGraphicsLayerClient
interface. The CompositingCoordinator manages the Nicosia::PaintingEngine
object through the new m_paintingEngine member variable, and returns the
reference to this object in the paintingEngine() method.

* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::CompositingCoordinator):
(WebKit::CompositingCoordinator::paintingEngine):
* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
Drop unnecessary typedefs.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/TextureMapper.cmake
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h


Added Paths

trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.cpp
trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngine.h
trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineBasic.cpp
trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineBasic.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225327 => 225328)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 15:01:53 UTC (rev 225327)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 15:12:58 UTC (rev 225328)
@@ -1,3 +1,42 @@
+2017-11-30  Zan Dobersek  
+
+[CoordGraphics] Move CoordinatedGraphicsLayer painting behind Nicosia::PaintingEngine
+https://bugs.webkit.org/show_bug.cgi?id=180141
+
+Reviewed by Carlos Garcia Campos.
+
+Introduce a painting engine concept that's used to perform painting
+for a given GraphicsLayer object.
+
+The Nicosia::PaintingEngine object is leveraged in the
+CoordinatedGraphicsLayer::updateContentBuffers() method. It's retrieved
+through the CoordinatedGraphicsLayerClient interface, with a new method
+introduced there for this purpose.
+
+The Nicosia::PaintingEngine interface is kept simple for now, with only
+a single paint() method. The only current implementation is the
+PaintingEngineBasic class, which simply reuses the code that was
+previously in CoordinatedGraphicsLayer::updateContentBuffers(),
+maintaining the current functionality.
+
+The Nicosia::PaintingEngine::create() function returns a new
+PaintingEngine object. For now it defaults to PaintingEngineBasic, but
+it could be configured at configure-time or even runtime in the future
+to return a more advanced engine implementation.
+
+No new tests -- no change in behavior.
+
+* platform/TextureMapper.cmake:
+* platform/graphics/nicosia/NicosiaPaintingEngine.cpp: Added.
+(Nicosia::PaintingEngine::create):
+* 

[webkit-changes] [225322] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [225322] trunk/Source/_javascript_Core








Revision 225322
Author utatane@gmail.com
Date 2017-11-30 03:27:43 -0800 (Thu, 30 Nov 2017)


Log Message
REGRESSION(r225314): [Linux] More than 2000 jsc tests are failing after r225314
https://bugs.webkit.org/show_bug.cgi?id=180185

Reviewed by Carlos Garcia Campos.

After r225314, we start using AllocatorForMode::MustAlreadyHaveAllocator for JSRopeString's allocatorFor.
But it is different from the original code used before r225314. Since DFGSpeculativeJIT::emitAllocateJSCell
can accept nullptr allocator, the behavior of the original code is AllocatorForMode::AllocatorIfExists.
And JSRopeString's allocator may not exist at this point if any JSRopeString is not allocated. But MakeRope
DFG node can be emitted if we see untaken path includes String + String code.

This patch fixes Linux JSC crashes by changing JSRopeString's AllocatorForMode to AllocatorIfExists.
As a result, only one user of AllocatorForMode::MustAlreadyHaveAllocator is MaterializeNewObject in FTL.
I'm not sure why this condition (MustAlreadyHaveAllocator) is ensured. But this code is the same to the
original code used before r225314.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileMakeRope):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225321 => 225322)

--- trunk/Source/_javascript_Core/ChangeLog	2017-11-30 08:21:25 UTC (rev 225321)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-11-30 11:27:43 UTC (rev 225322)
@@ -1,3 +1,26 @@
+2017-11-30  Yusuke Suzuki  
+
+REGRESSION(r225314): [Linux] More than 2000 jsc tests are failing after r225314
+https://bugs.webkit.org/show_bug.cgi?id=180185
+
+Reviewed by Carlos Garcia Campos.
+
+After r225314, we start using AllocatorForMode::MustAlreadyHaveAllocator for JSRopeString's allocatorFor.
+But it is different from the original code used before r225314. Since DFGSpeculativeJIT::emitAllocateJSCell
+can accept nullptr allocator, the behavior of the original code is AllocatorForMode::AllocatorIfExists.
+And JSRopeString's allocator may not exist at this point if any JSRopeString is not allocated. But MakeRope
+DFG node can be emitted if we see untaken path includes String + String code.
+
+This patch fixes Linux JSC crashes by changing JSRopeString's AllocatorForMode to AllocatorIfExists.
+As a result, only one user of AllocatorForMode::MustAlreadyHaveAllocator is MaterializeNewObject in FTL.
+I'm not sure why this condition (MustAlreadyHaveAllocator) is ensured. But this code is the same to the
+original code used before r225314.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileMakeRope):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
+
 2017-11-28  Filip Pizlo  
 
 CodeBlockSet::deleteUnmarkedAndUnreferenced can be a little more efficient


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (225321 => 225322)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2017-11-30 08:21:25 UTC (rev 225321)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2017-11-30 11:27:43 UTC (rev 225322)
@@ -4249,7 +4249,7 @@
 GPRReg scratchGPR = scratch.gpr();
 
 JITCompiler::JumpList slowPath;
-MarkedAllocator* markedAllocator = subspaceFor(*m_jit.vm())->allocatorForNonVirtual(sizeof(JSRopeString), AllocatorForMode::MustAlreadyHaveAllocator);
+MarkedAllocator* markedAllocator = subspaceFor(*m_jit.vm())->allocatorForNonVirtual(sizeof(JSRopeString), AllocatorForMode::AllocatorIfExists);
 m_jit.move(TrustedImmPtr(markedAllocator), allocatorGPR);
 emitAllocateJSCell(resultGPR, markedAllocator, allocatorGPR, TrustedImmPtr(m_jit.graph().registerStructure(m_jit.vm()->stringStructure.get())), scratchGPR, slowPath);
 


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (225321 => 225322)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2017-11-30 08:21:25 UTC (rev 225321)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2017-11-30 11:27:43 UTC (rev 225322)
@@ -5783,7 +5783,7 @@
 
 LBasicBlock lastNext = m_out.insertNewBlocksBefore(slowPath);
 
-MarkedAllocator* allocator = subspaceFor(vm())->allocatorForNonVirtual(sizeof(JSRopeString), AllocatorForMode::MustAlreadyHaveAllocator);
+MarkedAllocator* allocator = subspaceFor(vm())->allocatorForNonVirtual(sizeof(JSRopeString), AllocatorForMode::AllocatorIfExists);
 
 LValue result = allocateCell(
 m_out.constIntPtr(allocator), vm().stringStructure.get(), slowPath);

[webkit-changes] [225324] trunk/PerformanceTests

[antti]

Title: [225324] trunk/PerformanceTests








Revision 225324
Author an...@apple.com
Date 2017-11-30 04:30:25 -0800 (Thu, 30 Nov 2017)


Log Message
Add StyleBench
https://bugs.webkit.org/show_bug.cgi?id=180140

Reviewed by Simon Fraser and Joseph Pecoraro.

StyleBench tests performance of the CSS style resolution and style invalidation. Each test run
creates a large document and a large stylesheet using varying settings. It then applies
a series of mutations to the document and measures the time to update the style and rendering.
The resulting layout is simple, most of the pressure is on selector matching.

StyleBench uses Speedometer framework for UI and measurements. For profiling purposes, it can also
be run locally by opening style-bench.html directly.

There are currently four subtests:

- child and descendant combinators only (all other tests have these too).
- sibling combinators: '~' and '+'
- positional pseudo classes: :nth-child and similar
- ::before and ::after pseudo elements

The measured DOM mutations are:

- add classes
- remove classes
- add leaf elements
- remove leaf elements

* StyleBench: Added.
* StyleBench/InteractiveRunner.html: Added.

Copied and customized from Speedometer.

* StyleBench/index.html: Added.

Copied and customized from Speedometer.

* StyleBench/resources: Added.
* StyleBench/resources/style-bench.html: Added.
* StyleBench/resources/style-bench.js: Added.

The test class.

(Random):
(Random.prototype.get next):
(Random.prototype.chance):
(Random.prototype.number):
(nextAnimationFrame):
(defaultConfiguration):
(descendantCombinatorConfiguration):
(siblingCombinatorConfiguration):
(pseudoClassConfiguration):
(beforeAndAfterConfiguration):
(predefinedConfigurations):

Four predefined configurations.

(prototype.randomElementName):
(prototype.randomCombinator):
(prototype.randomPseudoClass):
(prototype.makeSimpleSelector):
(prototype.makeSelector):
(prototype.get randomColorComponent):
(prototype.makeDeclaration):
(prototype.makeRule):
(prototype.makeStylesheet):
(prototype.makeStyle):
(prototype.makeElement):
(prototype.makeTreeWithDepth):
(prototype.makeTree):
(prototype.updateCachedTestElements):
(prototype.randomTreeElement):
(prototype.addClasses):
(prototype.removeClasses):
(prototype.addLeafElements):
(prototype.removeLeafElements):
(prototype.async.runForever):
* StyleBench/resources/tests.js: Added.
(makeSteps):
(makeSuite):

Generates Speedometer Suites.

Modified Paths

trunk/PerformanceTests/ChangeLog


Added Paths

trunk/PerformanceTests/StyleBench/
trunk/PerformanceTests/StyleBench/InteractiveRunner.html
trunk/PerformanceTests/StyleBench/index.html
trunk/PerformanceTests/StyleBench/resources/
trunk/PerformanceTests/StyleBench/resources/style-bench.html
trunk/PerformanceTests/StyleBench/resources/style-bench.js
trunk/PerformanceTests/StyleBench/resources/tests.js




Diff

Modified: trunk/PerformanceTests/ChangeLog (225323 => 225324)

--- trunk/PerformanceTests/ChangeLog	2017-11-30 12:00:56 UTC (rev 225323)
+++ trunk/PerformanceTests/ChangeLog	2017-11-30 12:30:25 UTC (rev 225324)
@@ -1,3 +1,87 @@
+2017-11-30  Antti Koivisto  
+
+Add StyleBench
+https://bugs.webkit.org/show_bug.cgi?id=180140
+
+Reviewed by Simon Fraser and Joseph Pecoraro.
+
+StyleBench tests performance of the CSS style resolution and style invalidation. Each test run
+creates a large document and a large stylesheet using varying settings. It then applies
+a series of mutations to the document and measures the time to update the style and rendering.
+The resulting layout is simple, most of the pressure is on selector matching.
+
+StyleBench uses Speedometer framework for UI and measurements. For profiling purposes, it can also
+be run locally by opening style-bench.html directly.
+
+There are currently four subtests:
+
+- child and descendant combinators only (all other tests have these too).
+- sibling combinators: '~' and '+'
+- positional pseudo classes: :nth-child and similar
+- ::before and ::after pseudo elements
+
+The measured DOM mutations are:
+
+- add classes
+- remove classes
+- add leaf elements
+- remove leaf elements
+
+* StyleBench: Added.
+* StyleBench/InteractiveRunner.html: Added.
+
+Copied and customized from Speedometer.
+
+* StyleBench/index.html: Added.
+
+Copied and customized from Speedometer.
+
+* StyleBench/resources: Added.
+* StyleBench/resources/style-bench.html: Added.
+* StyleBench/resources/style-bench.js: Added.
+
+The test class.
+
+(Random):
+(Random.prototype.get next):
+(Random.prototype.chance):
+(Random.prototype.number):
+(nextAnimationFrame):
+(defaultConfiguration):
+(descendantCombinatorConfiguration):
+

[webkit-changes] [225325] trunk/Source/WebDriver

[carlosgc]

Title: [225325] trunk/Source/WebDriver








Revision 225325
Author carlo...@webkit.org
Date 2017-11-30 05:47:19 -0800 (Thu, 30 Nov 2017)


Log Message
WebDriver: remove elementSubmit command
https://bugs.webkit.org/show_bug.cgi?id=180186

Reviewed by Carlos Alberto Lopez Perez.

It's not in the spec, we had it only because selenium used it, but now it uses execute_script with custom code
to implement submit, so we can just remove it.

* Session.cpp:
(WebDriver::Session::elementSubmit): Deleted.
* Session.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::elementSubmit): Deleted.
* WebDriverService.h:

Modified Paths

trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/Session.cpp
trunk/Source/WebDriver/Session.h
trunk/Source/WebDriver/WebDriverService.cpp
trunk/Source/WebDriver/WebDriverService.h




Diff

Modified: trunk/Source/WebDriver/ChangeLog (225324 => 225325)

--- trunk/Source/WebDriver/ChangeLog	2017-11-30 12:30:25 UTC (rev 225324)
+++ trunk/Source/WebDriver/ChangeLog	2017-11-30 13:47:19 UTC (rev 225325)
@@ -1,3 +1,20 @@
+2017-11-30  Carlos Garcia Campos  
+
+WebDriver: remove elementSubmit command
+https://bugs.webkit.org/show_bug.cgi?id=180186
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+It's not in the spec, we had it only because selenium used it, but now it uses execute_script with custom code
+to implement submit, so we can just remove it.
+
+* Session.cpp:
+(WebDriver::Session::elementSubmit): Deleted.
+* Session.h:
+* WebDriverService.cpp:
+(WebDriver::WebDriverService::elementSubmit): Deleted.
+* WebDriverService.h:
+
 2017-11-14  Carlos Garcia Campos  
 
 Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h


Modified: trunk/Source/WebDriver/Session.cpp (225324 => 225325)

--- trunk/Source/WebDriver/Session.cpp	2017-11-30 12:30:25 UTC (rev 225324)
+++ trunk/Source/WebDriver/Session.cpp	2017-11-30 13:47:19 UTC (rev 225325)
@@ -1603,37 +1603,6 @@
 });
 }
 
-void Session::elementSubmit(const String& elementID, Function&& completionHandler)
-{
-if (!m_toplevelBrowsingContext) {
-completionHandler(CommandResult::fail(CommandResult::ErrorCode::NoSuchWindow));
-return;
-}
-
-handleUserPrompts([this, elementID, completionHandler = WTFMove(completionHandler)](CommandResult&& result) mutable {
-if (result.isError()) {
-completionHandler(WTFMove(result));
-return;
-}
-RefPtr arguments = JSON::Array::create();
-arguments->pushString(createElement(elementID)->toJSONString());
-
-RefPtr parameters = JSON::Object::create();
-parameters->setString(ASCIILiteral("browsingContextHandle"), m_toplevelBrowsingContext.value());
-if (m_currentBrowsingContext)
-parameters->setString(ASCIILiteral("frameHandle"), m_currentBrowsingContext.value());
-parameters->setString(ASCIILiteral("function"), FormSubmitJavaScript);
-parameters->setArray(ASCIILiteral("arguments"), WTFMove(arguments));
-m_host->sendCommandToBackend(ASCIILiteral("evaluateJavaScriptFunction"), WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
-if (response.isError) {
-completionHandler(CommandResult::fail(WTFMove(response.responseObject)));
-return;
-}
-completionHandler(CommandResult::success());
-});
-});
-}
-
 RefPtr Session::handleScriptResult(RefPtr&& resultValue)
 {
 RefPtr resultArray;


Modified: trunk/Source/WebDriver/Session.h (225324 => 225325)

--- trunk/Source/WebDriver/Session.h	2017-11-30 12:30:25 UTC (rev 225324)
+++ trunk/Source/WebDriver/Session.h	2017-11-30 13:47:19 UTC (rev 225325)
@@ -95,7 +95,6 @@
 void elementClick(const String& elementID, Function&&);
 void elementClear(const String& elementID, Function&&);
 void elementSendKeys(const String& elementID, Vector&& keys, Function&&);
-void elementSubmit(const String& elementID, Function&&);
 void executeScript(const String& script, RefPtr&& arguments, ExecuteScriptMode, Function&&);
 void getAllCookies(Function&&);
 void getNamedCookie(const String& name, Function&&);


Modified: trunk/Source/WebDriver/WebDriverService.cpp (225324 => 225325)

--- trunk/Source/WebDriver/WebDriverService.cpp	2017-11-30 12:30:25 UTC (rev 225324)
+++ trunk/Source/WebDriver/WebDriverService.cpp	2017-11-30 13:47:19 UTC (rev 225325)
@@ -135,9 +135,6 @@
 { HTTPMethod::Post, "/session/$sessionId/element/$elementId/clear", ::elementClear },
 { HTTPMethod::Post, "/session/$sessionId/element/$elementId/value", ::elementSendKeys },
 
-// FIXME: Not in the spec, but still used by Selenium.
-{ HTTPMethod::Post, "/session/$sessionId/element/$elementId/submit", 

[webkit-changes] [225323] trunk/Source/WebCore

[aperez]

Title: [225323] trunk/Source/WebCore








Revision 225323
Author ape...@igalia.com
Date 2017-11-30 04:00:56 -0800 (Thu, 30 Nov 2017)


Log Message
[GStreamer] Builds fails with ENABLE_VIDEO=OFF due to GStreamer usage
https://bugs.webkit.org/show_bug.cgi?id=179373

Reviewed by Xabier Rodriguez-Calvar.

This allows to build with WebAudio enabled even if video support is
disabled by guarding usage of HTMLMediaElement with ENABLE(VIDEO).

No new tests needed.

* page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::setGStreamerEnabled): Guard usage of HTMLMediaElement.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (225322 => 225323)

--- trunk/Source/WebCore/ChangeLog	2017-11-30 11:27:43 UTC (rev 225322)
+++ trunk/Source/WebCore/ChangeLog	2017-11-30 12:00:56 UTC (rev 225323)
@@ -1,3 +1,18 @@
+2017-11-30  Adrian Perez de Castro  
+
+[GStreamer] Builds fails with ENABLE_VIDEO=OFF due to GStreamer usage
+https://bugs.webkit.org/show_bug.cgi?id=179373
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+This allows to build with WebAudio enabled even if video support is
+disabled by guarding usage of HTMLMediaElement with ENABLE(VIDEO).
+
+No new tests needed.
+
+* page/DeprecatedGlobalSettings.cpp:
+(WebCore::DeprecatedGlobalSettings::setGStreamerEnabled): Guard usage of HTMLMediaElement.
+
 2017-11-29  Chris Dumez  
 
 ServiceWorker WebProcess sometimes crashes in JSVMClientData::~JSVMClientData()


Modified: trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp (225322 => 225323)

--- trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp	2017-11-30 11:27:43 UTC (rev 225322)
+++ trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp	2017-11-30 12:00:56 UTC (rev 225323)
@@ -141,7 +141,10 @@
 return;
 
 gGStreamerEnabled = enabled;
+
+#if ENABLE(VIDEO)
 HTMLMediaElement::resetMediaEngines();
+#endif
 }
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225326] trunk/Source/WebDriver

[carlosgc]

Title: [225326] trunk/Source/WebDriver








Revision 225326
Author carlo...@webkit.org
Date 2017-11-30 05:48:46 -0800 (Thu, 30 Nov 2017)


Log Message
WebDriver: locator strategy should be validated before trying to find elements
https://bugs.webkit.org/show_bug.cgi?id=180187

Reviewed by Carlos Alberto Lopez Perez.

We currently rely on the js atom to raise an exception in case the locator strategy is not valid, but in case of
find element from element, if the element doesn't exist we fail with stale element error instead of invalid
argument as expected. So, let's validate the strategies when parsing them, which would also avoid going to the
browser in cae of invalid strategy.

Fixes: imported/w3c/webdriver/tests/retrieval/find_element_from_element.py::test_invalid_using_argument[a]

* WebDriverService.cpp:
(WebDriver::isValidStrategy):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):

Modified Paths

trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/WebDriverService.cpp




Diff

Modified: trunk/Source/WebDriver/ChangeLog (225325 => 225326)

--- trunk/Source/WebDriver/ChangeLog	2017-11-30 13:47:19 UTC (rev 225325)
+++ trunk/Source/WebDriver/ChangeLog	2017-11-30 13:48:46 UTC (rev 225326)
@@ -1,5 +1,23 @@
 2017-11-30  Carlos Garcia Campos  
 
+WebDriver: locator strategy should be validated before trying to find elements
+https://bugs.webkit.org/show_bug.cgi?id=180187
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+We currently rely on the js atom to raise an exception in case the locator strategy is not valid, but in case of
+find element from element, if the element doesn't exist we fail with stale element error instead of invalid
+argument as expected. So, let's validate the strategies when parsing them, which would also avoid going to the
+browser in cae of invalid strategy.
+
+Fixes: imported/w3c/webdriver/tests/retrieval/find_element_from_element.py::test_invalid_using_argument[a]
+
+* WebDriverService.cpp:
+(WebDriver::isValidStrategy):
+(WebDriver::findStrategyAndSelectorOrCompleteWithError):
+
+2017-11-30  Carlos Garcia Campos  
+
 WebDriver: remove elementSubmit command
 https://bugs.webkit.org/show_bug.cgi?id=180186
 


Modified: trunk/Source/WebDriver/WebDriverService.cpp (225325 => 225326)

--- trunk/Source/WebDriver/WebDriverService.cpp	2017-11-30 13:47:19 UTC (rev 225325)
+++ trunk/Source/WebDriver/WebDriverService.cpp	2017-11-30 13:48:46 UTC (rev 225326)
@@ -984,9 +984,20 @@
 return elementID;
 }
 
+static inline bool isValidStrategy(const String& strategy)
+{
+// §12.1 Locator Strategies.
+// https://w3c.github.io/webdriver/webdriver-spec.html#dfn-table-of-location-strategies
+return strategy == "css selector"
+|| strategy == "link text"
+|| strategy == "partial link text"
+|| strategy == "tag name"
+|| strategy == "xpath";
+}
+
 static bool findStrategyAndSelectorOrCompleteWithError(JSON::Object& parameters, Function& completionHandler, String& strategy, String& selector)
 {
-if (!parameters.getString(ASCIILiteral("using"), strategy)) {
+if (!parameters.getString(ASCIILiteral("using"), strategy) || !isValidStrategy(strategy)) {
 completionHandler(CommandResult::fail(CommandResult::ErrorCode::InvalidArgument));
 return false;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225384] trunk/Source/ThirdParty/ANGLE

[achristensen]

Title: [225384] trunk/Source/ThirdParty/ANGLE








Revision 225384
Author achristen...@apple.com
Date 2017-11-30 21:36:23 -0800 (Thu, 30 Nov 2017)


Log Message
Speculative WinCairo fix.
https://bugs.webkit.org/show_bug.cgi?id=180177

* CMakeLists.txt:
* PlatformWin.cmake:

Modified Paths

trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/PlatformWin.cmake




Diff

Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (225383 => 225384)

--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2017-12-01 05:32:11 UTC (rev 225383)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2017-12-01 05:36:23 UTC (rev 225384)
@@ -24,12 +24,13 @@
 set(ANGLEGLESv2_SOURCES
 src/libGLESv2/entry_points_egl.cpp
 src/libGLESv2/entry_points_egl_ext.cpp
-src/libGLESv2/entry_points_gles_2_0.cpp
+src/libGLESv2/entry_points_gles_2_0_autogen.cpp
 src/libGLESv2/entry_points_gles_2_0_ext.cpp
-src/libGLESv2/entry_points_gles_3_0.cpp
-src/libGLESv2/entry_points_gles_3_1.cpp
+src/libGLESv2/entry_points_gles_3_0_autogen.cpp
+src/libGLESv2/entry_points_gles_3_1_autogen.cpp
 src/libGLESv2/global_state.cpp
 src/libGLESv2/libGLESv2.cpp
+src/libGLESv2/proc_table_autogen.cpp
 )
 
 set(ANGLEGLESv2_COMPILE_DEFINITIONS


Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (225383 => 225384)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-01 05:32:11 UTC (rev 225383)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-01 05:36:23 UTC (rev 225384)
@@ -1,3 +1,11 @@
+2017-11-30  Alex Christensen  
+
+Speculative WinCairo fix.
+https://bugs.webkit.org/show_bug.cgi?id=180177
+
+* CMakeLists.txt:
+* PlatformWin.cmake:
+
 2017-11-30  Ryan Haddad  
 
 Unreviewed build fix, remove executable property from a header file.


Modified: trunk/Source/ThirdParty/ANGLE/PlatformWin.cmake (225383 => 225384)

--- trunk/Source/ThirdParty/ANGLE/PlatformWin.cmake	2017-12-01 05:32:11 UTC (rev 225383)
+++ trunk/Source/ThirdParty/ANGLE/PlatformWin.cmake	2017-12-01 05:36:23 UTC (rev 225384)
@@ -121,7 +121,6 @@
 src/libANGLE/renderer/d3d/TextureD3D.cpp
 src/libANGLE/renderer/d3d/VertexBuffer.cpp
 src/libANGLE/renderer/d3d/VertexDataManager.cpp
-src/third_party/murmurhash/MurmurHash3.cpp
 src/third_party/systeminfo/SystemInfo.cpp
 )
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225381] trunk

[achristensen]

Title: [225381] trunk








Revision 225381
Author achristen...@apple.com
Date 2017-11-30 21:27:11 -0800 (Thu, 30 Nov 2017)


Log Message
Extra PerformanceEntryList entry after iframe navigation
https://bugs.webkit.org/show_bug.cgi?id=178433

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: http/tests/security/PerformanceEntryList-parent-only-first-navigation.html

When an iframe is loaded, its main resource load should be reported to the parent frame's PerformanceEntryList.
Subsequent main resource loads should not.

* loader/FrameLoader.h:
(WebCore::FrameLoader::shouldReportResourceTimingToParentFrame):
* loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):

LayoutTests:

* http/tests/security/PerformanceEntryList-parent-only-first-navigation-expected.txt: Added.
* http/tests/security/PerformanceEntryList-parent-only-first-navigation.html: Added.
* http/tests/security/resources/navigate-and-postMessage.html: Added.
* http/tests/security/resources/postMessage.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.h
trunk/Source/WebCore/loader/ResourceTimingInformation.cpp


Added Paths

trunk/LayoutTests/http/tests/security/PerformanceEntryList-parent-only-first-navigation-expected.txt
trunk/LayoutTests/http/tests/security/PerformanceEntryList-parent-only-first-navigation.html
trunk/LayoutTests/http/tests/security/resources/navigate-and-postMessage.html
trunk/LayoutTests/http/tests/security/resources/postMessage.html




Diff

Modified: trunk/LayoutTests/ChangeLog (225380 => 225381)

--- trunk/LayoutTests/ChangeLog	2017-12-01 05:24:19 UTC (rev 225380)
+++ trunk/LayoutTests/ChangeLog	2017-12-01 05:27:11 UTC (rev 225381)
@@ -1,3 +1,15 @@
+2017-11-30  Alex Christensen  
+
+Extra PerformanceEntryList entry after iframe navigation
+https://bugs.webkit.org/show_bug.cgi?id=178433
+
+Reviewed by Joseph Pecoraro.
+
+* http/tests/security/PerformanceEntryList-parent-only-first-navigation-expected.txt: Added.
+* http/tests/security/PerformanceEntryList-parent-only-first-navigation.html: Added.
+* http/tests/security/resources/navigate-and-postMessage.html: Added.
+* http/tests/security/resources/postMessage.html: Added.
+
 2017-11-30  Zalan Bujtas  
 
 [Simple line layout] Incorrect repaint rect with vertically shrinking content.


Added: trunk/LayoutTests/http/tests/security/PerformanceEntryList-parent-only-first-navigation-expected.txt (0 => 225381)

--- trunk/LayoutTests/http/tests/security/PerformanceEntryList-parent-only-first-navigation-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/PerformanceEntryList-parent-only-first-navigation-expected.txt	2017-12-01 05:27:11 UTC (rev 225381)
@@ -0,0 +1,2 @@
+ALERT: posting message 1 http://127.0.0.1:8000/security/resources/navigate-and-postMessage.html
+


Added: trunk/LayoutTests/http/tests/security/PerformanceEntryList-parent-only-first-navigation.html (0 => 225381)

--- trunk/LayoutTests/http/tests/security/PerformanceEntryList-parent-only-first-navigation.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/PerformanceEntryList-parent-only-first-navigation.html	2017-12-01 05:27:11 UTC (rev 225381)
@@ -0,0 +1,13 @@
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+window.addEventListener("message", (e)=>{
+var entries = performance.getEntriesByType("resource");
+alert(e.data + " " + entries.length + " " + entries[0].name);
+if (window.testRunner)
+testRunner.notifyDone();
+}, false);
+
+

Added: trunk/LayoutTests/http/tests/security/resources/navigate-and-postMessage.html (0 => 225381)

--- trunk/LayoutTests/http/tests/security/resources/navigate-and-postMessage.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/resources/navigate-and-postMessage.html	2017-12-01 05:27:11 UTC (rev 225381)
@@ -0,0 +1,3 @@
+
+window.location = "postMessage.html";
+


Added: trunk/LayoutTests/http/tests/security/resources/postMessage.html (0 => 225381)

--- trunk/LayoutTests/http/tests/security/resources/postMessage.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/resources/postMessage.html	2017-12-01 05:27:11 UTC (rev 225381)
@@ -0,0 +1,3 @@
+
+window.parent.postMessage("posting message", "*");
+


Modified: trunk/Source/WebCore/ChangeLog (225380 => 225381)

--- trunk/Source/WebCore/ChangeLog	2017-12-01 05:24:19 UTC (rev 225380)
+++ trunk/Source/WebCore/ChangeLog	2017-12-01 05:27:11 UTC (rev 225381)
@@ -1,3 +1,20 @@
+2017-11-30  Alex Christensen  
+
+Extra PerformanceEntryList entry after iframe navigation
+https://bugs.webkit.org/show_bug.cgi?id=178433
+
+Reviewed by Joseph 

[webkit-changes] [225383] trunk

[achristensen]

Title: [225383] trunk








Revision 225383
Author achristen...@apple.com
Date 2017-11-30 21:32:11 -0800 (Thu, 30 Nov 2017)


Log Message
REGRESSION (r224791): cookies are shared between ephemeral sessions in the same process pool
https://bugs.webkit.org/show_bug.cgi?id=180235

Reviewed by Joseph Pecoraro.

Source/WebKit:

In r224791 I assumed that uiProcessCookieStorageIdentifier would be empty in the ephemeral session initialization message.
This is not the case.  We did not catch this because almost all of our ephemeral session testing uses the legacyPrivateSessionID.
I add checks for if the SessionID is ephemeral like we already have in WebFrameNetworkingContext::ensureWebsiteDataStoreSession.
I also add an API test that makes sure cookies are not shared between ephemeral sessions the way they are made through the API.

* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm: Added.
(-[CookiePrivateBrowsingDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (225382 => 225383)

--- trunk/Source/WebKit/ChangeLog	2017-12-01 05:30:14 UTC (rev 225382)
+++ trunk/Source/WebKit/ChangeLog	2017-12-01 05:32:11 UTC (rev 225383)
@@ -1,3 +1,18 @@
+2017-11-30  Alex Christensen  
+
+REGRESSION (r224791): cookies are shared between ephemeral sessions in the same process pool
+https://bugs.webkit.org/show_bug.cgi?id=180235
+
+Reviewed by Joseph Pecoraro.
+
+In r224791 I assumed that uiProcessCookieStorageIdentifier would be empty in the ephemeral session initialization message.
+This is not the case.  We did not catch this because almost all of our ephemeral session testing uses the legacyPrivateSessionID.
+I add checks for if the SessionID is ephemeral like we already have in WebFrameNetworkingContext::ensureWebsiteDataStoreSession.
+I also add an API test that makes sure cookies are not shared between ephemeral sessions the way they are made through the API.
+
+* NetworkProcess/mac/RemoteNetworkingContext.mm:
+(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
+
 2017-11-30  Stephan Szabo  
 
 Make LegacyCustomProtocolManager optional for network process


Modified: trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm (225382 => 225383)

--- trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm	2017-12-01 05:30:14 UTC (rev 225382)
+++ trunk/Source/WebKit/NetworkProcess/mac/RemoteNetworkingContext.mm	2017-12-01 05:32:11 UTC (rev 225383)
@@ -97,7 +97,7 @@
 SandboxExtension::consumePermanently(parameters.cookieStoragePathExtensionHandle);
 
 RetainPtr uiProcessCookieStorage;
-if (!parameters.uiProcessCookieStorageIdentifier.isEmpty())
+if (!sessionID.isEphemeral() && !parameters.uiProcessCookieStorageIdentifier.isEmpty())
 uiProcessCookieStorage = cookieStorageFromIdentifyingData(parameters.uiProcessCookieStorageIdentifier);
 
 NetworkStorageSession::ensureSession(sessionID, base + '.' + String::number(sessionID.sessionID()), WTFMove(uiProcessCookieStorage));
@@ -106,7 +106,7 @@
 for (const auto& cookie : parameters.pendingCookies)
 session->setCookie(cookie);
 
-if (!parameters.cacheStorageDirectory.isNull()) {
+if (!sessionID.isEphemeral() && !parameters.cacheStorageDirectory.isNull()) {
 SandboxExtension::consumePermanently(parameters.cacheStorageDirectoryExtensionHandle);
 session->setCacheStorageDirectory(WTFMove(parameters.cacheStorageDirectory));
 session->setCacheStoragePerOriginQuota(parameters.cacheStoragePerOriginQuota);


Modified: trunk/Tools/ChangeLog (225382 => 225383)

--- trunk/Tools/ChangeLog	2017-12-01 05:30:14 UTC (rev 225382)
+++ trunk/Tools/ChangeLog	2017-12-01 05:32:11 UTC (rev 225383)
@@ -1,3 +1,15 @@
+2017-11-30  Alex Christensen  
+
+REGRESSION (r224791): cookies are shared between ephemeral sessions in the same process pool
+https://bugs.webkit.org/show_bug.cgi?id=180235
+
+Reviewed by Joseph Pecoraro.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm: Added.
+(-[CookiePrivateBrowsingDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
+(TEST):
+
 2017-11-30  Stephan Szabo  
 
 

[webkit-changes] [225382] branches/safari-604-branch/Source

[jmarcell]

Title: [225382] branches/safari-604-branch/Source








Revision 225382
Author jmarc...@apple.com
Date 2017-11-30 21:30:14 -0800 (Thu, 30 Nov 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig (225381 => 225382)

--- branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-12-01 05:27:11 UTC (rev 225381)
+++ branches/safari-604-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-12-01 05:30:14 UTC (rev 225382)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (225381 => 225382)

--- branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-12-01 05:27:11 UTC (rev 225381)
+++ branches/safari-604-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-12-01 05:30:14 UTC (rev 225382)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig (225381 => 225382)

--- branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig	2017-12-01 05:27:11 UTC (rev 225381)
+++ branches/safari-604-branch/Source/WebCore/Configurations/Version.xcconfig	2017-12-01 05:30:14 UTC (rev 225382)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (225381 => 225382)

--- branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-12-01 05:27:11 UTC (rev 225381)
+++ branches/safari-604-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-12-01 05:30:14 UTC (rev 225382)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (225381 => 225382)

--- branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-12-01 05:27:11 UTC (rev 225381)
+++ branches/safari-604-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-12-01 05:30:14 UTC (rev 225382)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig (225381 => 225382)

--- branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig	2017-12-01 05:27:11 UTC (rev 225381)
+++ branches/safari-604-branch/Source/WebKit/Configurations/Version.xcconfig	2017-12-01 05:30:14 UTC (rev 225382)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (225381 => 225382)

--- branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2017-12-01 05:27:11 UTC (rev 225381)
+++ branches/safari-604-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2017-12-01 05:30:14 UTC (rev 225382)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225380] trunk/Source

[jmarcell]

Title: [225380] trunk/Source








Revision 225380
Author jmarc...@apple.com
Date 2017-11-30 21:24:19 -0800 (Thu, 30 Nov 2017)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (225379 => 225380)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2017-12-01 02:54:29 UTC (rev 225379)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2017-12-01 05:24:19 UTC (rev 225380)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (225379 => 225380)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-12-01 02:54:29 UTC (rev 225379)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-12-01 05:24:19 UTC (rev 225380)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (225379 => 225380)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2017-12-01 02:54:29 UTC (rev 225379)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2017-12-01 05:24:19 UTC (rev 225380)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (225379 => 225380)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-12-01 02:54:29 UTC (rev 225379)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-12-01 05:24:19 UTC (rev 225380)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (225379 => 225380)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-12-01 02:54:29 UTC (rev 225379)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-12-01 05:24:19 UTC (rev 225380)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (225379 => 225380)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2017-12-01 02:54:29 UTC (rev 225379)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2017-12-01 05:24:19 UTC (rev 225380)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (225379 => 225380)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2017-12-01 02:54:29 UTC (rev 225379)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2017-12-01 05:24:19 UTC (rev 225380)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes