Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-12-05 Thread Martin Aspeli
Wichert Akkerman wrote:
> Previously Godefroid Chapelle wrote:
>> Tres Seaver wrote:
>>
>>> As an aside / vent:  the reason for the now-removed EXTERNALS.txt files
>>> was to keep the canonical information about the externals in a diffable
>>> file:  why subversion can't do a proper diff on its own line-oriented
>>> property is beyond me.  Another benefit of an EXTERNALS.txt file was
>>> that it could be inspected in the web view of a directory, which isn't
>>> true for the svn:externals property itself.
>>>
>>>
>>> Tres.
>> I want to support this. The noise made by keeping EXTERNALS.txt in svn 
>> is very low compared to the signal it provides.
> 
> I don't. EXTERNALS.txt is only useful if your tools suck. There are
> perfectly capable svn commit mailers and web browsers that show
> property changes correctly.

I'm normally not one to play the "get better tools" argument, but 
EXTERNALS.txt have a tendency to drift out of sync with reality when 
people get used to "svn pe .", and confuse people who (not unreasonably) 
think that this is a "magic" file and so edit it and forget to do "svn 
ps svn:externals -F EXTERNALS .".

Martin

-- 
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-12-05 Thread Wichert Akkerman
Previously Godefroid Chapelle wrote:
> Tres Seaver wrote:
> 
> > 
> > As an aside / vent:  the reason for the now-removed EXTERNALS.txt files
> > was to keep the canonical information about the externals in a diffable
> > file:  why subversion can't do a proper diff on its own line-oriented
> > property is beyond me.  Another benefit of an EXTERNALS.txt file was
> > that it could be inspected in the web view of a directory, which isn't
> > true for the svn:externals property itself.
> > 
> > 
> > Tres.
> 
> I want to support this. The noise made by keeping EXTERNALS.txt in svn 
> is very low compared to the signal it provides.

I don't. EXTERNALS.txt is only useful if your tools suck. There are
perfectly capable svn commit mailers and web browsers that show
property changes correctly.

Wichert.

-- 
Wichert Akkerman <[EMAIL PROTECTED]>It is simple to make things.
http://www.wiggy.net/   It is hard to make things simple.
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-12-04 Thread Godefroid Chapelle
Tres Seaver wrote:

> 
> As an aside / vent:  the reason for the now-removed EXTERNALS.txt files
> was to keep the canonical information about the externals in a diffable
> file:  why subversion can't do a proper diff on its own line-oriented
> property is beyond me.  Another benefit of an EXTERNALS.txt file was
> that it could be inspected in the web view of a directory, which isn't
> true for the svn:externals property itself.
> 
> 
> Tres.

I want to support this. The noise made by keeping EXTERNALS.txt in svn 
is very low compared to the signal it provides.

-- 
Godefroid Chapelle (aka __gotcha) http://bubblenet.be
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-12-04 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Sidnei da Silva wrote:
> Hi Tres,
> 
> On Thu, Dec 4, 2008 at 1:12 PM, Tres Seaver <[EMAIL PROTECTED]> wrote:
>> My hypothesis is that one or more of the 'svn:externals' changes Sidnei
>> made to bring in 2.6-compatible packages is the culprit (maybe an
>> interaction between several of them).  I am attaching readable diff for
>> each of 'lib/python', 'lib/python/zope', and 'lib/python/zope/app'.
>>
>> As an aside / vent:  the reason for the now-removed EXTERNALS.txt files
>> was to keep the canonical information about the externals in a diffable
>> file:  why subversion can't do a proper diff on its own line-oriented
>> property is beyond me.  Another benefit of an EXTERNALS.txt file was
>> that it could be inspected in the web view of a directory, which isn't
>> true for the svn:externals property itself.
> 
> I agree with your analysis: it is certainly related to the changes in
> externals, but maybe not for the reason you think! Last I looked at
> this, I found out that the failing zope.testbrowser test did not exist
> in the previous version of zope.testbrowser that we were pulling as
> externals. So I think that means we are missing an upgrade to some
> external that makes zope.testbrowser tests work when run standalone.
> That's just my feeling though, and I don't have much right now to back
> this claim.

(CC'ing the newsgroup).

OK, so the buildout.cfg for zope.testbrowser 3.5.1 (the version now
linked into the Zope trunk) has:

 [versions]
 mechanize = 0.1.9
 setuptools = 0.6c9
 zope.testbrowser =
 zope.publisher = 3.5.1
 zope.app.publication = 3.4.2

The version of zope.app.publication linked into the Zope trunk is 3.5.0
(bumped from 3.4.3).  However, zope.app.publication is not listed as any
kind of dependency in either version's setup.py.  In fact, it isn't
imported (or referenced in ZCML) anywhere other than in the buildout.cfg :(.



Tres.
- --
===
Tres Seaver  +1 540-429-0999  [EMAIL PROTECTED]
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJOAoY+gerLs4ltQ4RAnkMAJ49XjAka9QWdnuLLIQO6rbqk/fWFgCeMlZ9
cYqP4W6I28xMOKGfTW20WTk=
=iitF
-END PGP SIGNATURE-

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-12-04 Thread Brian Sutherland
On Thu, Dec 04, 2008 at 04:21:51PM +0100, Wichert Akkerman wrote:
> Previously Tres Seaver wrote:
> > As an aside / vent:  the reason for the now-removed EXTERNALS.txt files
> > was to keep the canonical information about the externals in a diffable
> > file:  why subversion can't do a proper diff on its own line-oriented
> > property is beyond me.  Another benefit of an EXTERNALS.txt file was
> > that it could be inspected in the web view of a directory, which isn't
> > true for the svn:externals property itself.
> 
> If only svn.zope.org had a trac-based browser, which does show those
> properties properly...

Like this one: http://zope3.pov.lt/trac/browser

?

> 
> Wichert.
> 
> -- 
> Wichert Akkerman <[EMAIL PROTECTED]>It is simple to make things.
> http://www.wiggy.net/   It is hard to make things simple.
> ___
> Zope-Dev maillist  -  Zope-Dev@zope.org
> http://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists - 
>  http://mail.zope.org/mailman/listinfo/zope-announce
>  http://mail.zope.org/mailman/listinfo/zope )

-- 
Brian Sutherland
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-12-04 Thread Wichert Akkerman
Previously Tres Seaver wrote:
> As an aside / vent:  the reason for the now-removed EXTERNALS.txt files
> was to keep the canonical information about the externals in a diffable
> file:  why subversion can't do a proper diff on its own line-oriented
> property is beyond me.  Another benefit of an EXTERNALS.txt file was
> that it could be inspected in the web view of a directory, which isn't
> true for the svn:externals property itself.

If only svn.zope.org had a trac-based browser, which does show those
properties properly...

Wichert.

-- 
Wichert Akkerman <[EMAIL PROTECTED]>It is simple to make things.
http://www.wiggy.net/   It is hard to make things simple.
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-12-04 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hanno Schlichting wrote:
> Tres Seaver wrote:
>> Hanno Schlichting wrote:
>>> In general all tests pass now, when run from the eggified Zope in:
>>> svn://svn.zope.org/repos/main/Zope2.buildout/trunk
>> I just vendor imported mechanize 0.1.9 into the Zope SVN, and have
>> changed the svn:external in my Z2 trunk checkout to point to it.  I then
>> made a separate tree and vendor imported ClientForm 0.2.9, including
>> hacking on the faked-out package we are using to support svn:externals,
>> and switched the external to point to it.
>>
>> At this point, the 'aqlegacy_ftest' doctest still fails in my trunk
>> sandbox, as does the 'zope.testborwser.README' doctest.
> 
> Hhm, the zope.testbrowser tests aren't run in the buildout version. It
> doesn't run tests for egg dependencies.
> 
> I tried this again and now that aqlegacy_ftest fails for me again as
> well. Either a test interdependency or a timing issue I'd guess.

My hypothesis is that one or more of the 'svn:externals' changes Sidnei
made to bring in 2.6-compatible packages is the culprit (maybe an
interaction between several of them).  I am attaching readable diff for
each of 'lib/python', 'lib/python/zope', and 'lib/python/zope/app'.

As an aside / vent:  the reason for the now-removed EXTERNALS.txt files
was to keep the canonical information about the externals in a diffable
file:  why subversion can't do a proper diff on its own line-oriented
property is beyond me.  Another benefit of an EXTERNALS.txt file was
that it could be inspected in the web view of a directory, which isn't
true for the svn:externals property itself.


Tres.
- --
===
Tres Seaver  +1 540-429-0999  [EMAIL PROTECTED]
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJN/NL+gerLs4ltQ4RApouAJ0WUYuUh3btoXQaLNNBLISqXcVFJACgyhsB
YP0uIear89z8b5qP2x6F6Gs=
=slqV
-END PGP SIGNATURE-
2,3c2,3
< ClientForm   svn://svn.zope.org/repos/main/Zope3/trunk/src/ClientForm
< RestrictedPython svn://svn.zope.org/repos/main/RestrictedPython/tags/3.4.2/src/RestrictedPython
---
> ClientForm   svn://svn.zope.org/repos/main/ClientForm/as_package/0.2.9
> RestrictedPython svn://svn.zope.org/repos/main/RestrictedPython/tags/3.4.3/src/RestrictedPython
6c6
< ZEO  svn://svn.zope.org/repos/main/ZODB/tags/3.8.1/src/ZEO
---
> ZEO  svn://svn.zope.org/repos/main/ZODB/branches/3.8/src/ZEO
10c10
< mechanizesvn://svn.zope.org/repos/main/Zope3/trunk/src/mechanize
---
> mechanizesvn://svn.zope.org/repos/main/mechanize/tags/0.1.9/mechanize
17,18d16
< 
< 
12c12
< documenttemplate svn://svn.zope.org/repos/main/zope.documenttemplate/tags/3.4.0/src/zope/documenttemplate
---
> documenttemplate svn://svn.zope.org/repos/main/zope.documenttemplate/tags/3.4.2/src/zope/documenttemplate
32c32
< rdb  svn://svn.zope.org/repos/main/zope.rdb/tags/3.4.0/src/zope/rdb
---
> rdb  svn://svn.zope.org/repos/main/zope.rdb/tags/3.4.2/src/zope/rdb
44,45c44,45
< testbrowser  svn://svn.zope.org/repos/main/zope.testbrowser/tags/3.4.2-zope2/src/zope/testbrowser
< testing  svn://svn.zope.org/repos/main/zope.testing/tags/3.5.3/src/zope/testing
---
> testbrowser  svn://svn.zope.org/repos/main/zope.testbrowser/tags/3.5.1/src/zope/testbrowser
> testing  svn://svn.zope.org/repos/main/zope.testing/tags/3.5.6/src/zope/testing
51d50
< 
4c4
< appsetup svn://svn.zope.org/repos/main/zope.app.appsetup/tags/3.4.1/src/zope/app/appsetup
---
> appsetup svn://svn.zope.org/repos/main/zope.app.appsetup/tags/3.8.0/src/zope/app/appsetup
9,10c9,10
< componentsvn://svn.zope.org/repos/main/zope.app.component/tags/3.4.1/src/zope/app/component
< containersvn://svn.zope.org/repos/main/zope.app.container/tags/3.5.3/src/zope/app/container
---
> componentsvn://svn.zope.org/repos/main/zope.app.component/tags/3.5.0/src/zope/app/component
> containersvn://svn.zope.org/repos/main/zope.app.container/tags/3.6.2/src/zope/app/container
18c18
< form svn://svn.zope.org/repos/main/zope.app.form/tags/3.4.1/src/zope/app/form

---
> form svn://svn.zope.org/repos/main/zope.app.form/tags/3.6.3/src/zope/app/form
33,34c33,34
< publication  svn://svn.zope.org/repos/main/zope.app.publication/tags/3.4.3/src/zope/app/publication
< publishersvn://svn.zope.org/repos/main/zope.app.publisher/tags/3.4.1/src/zope/app/publisher
---
> publication  svn://svn.zope.org/repos/main/zope.app.publication/tags/3.5.0/src/zope/app/publication
> publishersvn://svn.zope.org/repos/main/zope.app.publisher/tags/3.5.1/src/zope/app/publisher
38c38

Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-12-01 Thread Hanno Schlichting
Tres Seaver wrote:
> Hanno Schlichting wrote:
>> In general all tests pass now, when run from the eggified Zope in:
> 
>> svn://svn.zope.org/repos/main/Zope2.buildout/trunk
> 
> I just vendor imported mechanize 0.1.9 into the Zope SVN, and have
> changed the svn:external in my Z2 trunk checkout to point to it.  I then
> made a separate tree and vendor imported ClientForm 0.2.9, including
> hacking on the faked-out package we are using to support svn:externals,
> and switched the external to point to it.
> 
> At this point, the 'aqlegacy_ftest' doctest still fails in my trunk
> sandbox, as does the 'zope.testborwser.README' doctest.

Hhm, the zope.testbrowser tests aren't run in the buildout version. It
doesn't run tests for egg dependencies.

I tried this again and now that aqlegacy_ftest fails for me again as
well. Either a test interdependency or a timing issue I'd guess.

Hanno

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-11-30 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hanno Schlichting wrote:
> Hi.
> 
> I just looked over this and fixed one test failure in Five.

I will trust that stubbing out the assertions in the 'update' method
(revision 93450) is the Right Thing (TM).

> In general all tests pass now, when run from the eggified Zope in:
> 
> svn://svn.zope.org/repos/main/Zope2.buildout/trunk
> 
> I guess that the zope.testbrowser problems are a mix of test
> interdependencies and maybe a differing mechanize version. The eggified
> Zope2 does not run tests for its dependencies but only for itself, so a
> lot less tests are run.
> 
> Secondly the normal Zope2 trunk pulls in mechanize as a SVN checkout
> from the Zope repository. The eggified version has a normal egg
> dependency and pulls in the later mechanize 0.1.9. I have no idea what
> version that mechanize in our SVN is actually.

I just vendor imported mechanize 0.1.9 into the Zope SVN, and have
changed the svn:external in my Z2 trunk checkout to point to it.  I then
made a separate tree and vendor imported ClientForm 0.2.9, including
hacking on the faked-out package we are using to support svn:externals,
and switched the external to point to it.

At this point, the 'aqlegacy_ftest' doctest still fails in my trunk
sandbox, as does the 'zope.testborwser.README' doctest.

I am therefore not checking in my svn:externals changes just yet.


Tres.
- --
===
Tres Seaver  +1 540-429-0999  [EMAIL PROTECTED]
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJM3lY+gerLs4ltQ4RAonrAKDc/4VNsX0XRkKW8p/vNTqftlsx/wCfY1Mr
TxKr3hOEgOQXcyIGtKzouBY=
=NXAI
-END PGP SIGNATURE-

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-11-30 Thread Hanno Schlichting
Hi.

I just looked over this and fixed one test failure in Five. In general
all tests pass now, when run from the eggified Zope in:

svn://svn.zope.org/repos/main/Zope2.buildout/trunk

I guess that the zope.testbrowser problems are a mix of test
interdependencies and maybe a differing mechanize version. The eggified
Zope2 does not run tests for its dependencies but only for itself, so a
lot less tests are run.

Secondly the normal Zope2 trunk pulls in mechanize as a SVN checkout
from the Zope repository. The eggified version has a normal egg
dependency and pulls in the later mechanize 0.1.9. I have no idea what
version that mechanize in our SVN is actually.

Tres Seaver wrote:
> Any chance you can get these worked out?  I looked at the Products.Five
> tests today, with the following observations:
> 
>  - Not as many tests fail if I run '-s Products.Five' as when I run the
>whole set:  in particular, the first two in 'aqlegacy_ftest.txt'
>   ('HTTPError', 'falcon.pt' not called) don't occur.
> 
>  - The next 'aqlegacy_ftest.txt' failure is because the content provider
>is not being acquisition wrapped.  The remaining failure is likely
>due to the same cause (it is on the following line).

This was caused by a change by Malthe, who forgot to update the tests.
Fixed now.

>  - All the failing tests in Products.Five come from code which relies
>on zope.testbrowser, via the Products.Five.testbrowser shim.
> 
>  - The first failing zope.testbrowser test (README.txt line 1162) seems
>to be due to a change somewhere which contradicts the comment just
>below the example:  "Here, the body is left in place because it isn't
>form data."
> 
>  - The testing requirements for zope.testbrowser itself are really
>snarled up:  it pulls in basically all of Zope3.

As Benji figured out, these are really hard to trim down. I think it
will cost us some more month of work before we have the zope.app
dependency soup cleaned up, if we ever get there at all.

Hanno

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-11-29 Thread Benji York
On Sat, Nov 29, 2008 at 2:18 PM, Benji York <[EMAIL PROTECTED]> wrote:

> I'm working on a new package (maybe named zope.functionaltesting) that
> will provide only what's needed for functional testing of Zope 3 apps
> using testbrowser without all the baggage of zope.app.testing (see
> http://hannosch.eu/zope2-dependencies/zope.app.testing.jpeg).

I give up.  zope.app.testing.functional.HTTPCaller depends on
zope.app.testing.functional.FunctionalTestSetup which opens a huge can
of worms.

I believe it's possible to reduce zope.app.testing.functional's
dependencies, but it'll take a lot of work tracking down just what's
needed and factoring out new components to break dependencies.
-- 
Benji York
Senior Software Engineer
Zope Corporation
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-11-29 Thread Benji York
On Sat, Nov 29, 2008 at 1:21 PM, Benji York <[EMAIL PROTECTED]> wrote:
> On Sat, Nov 29, 2008 at 11:37 AM, Tres Seaver <[EMAIL PROTECTED]> wrote:
>> Note that this means that any other package which wants to use
>> zope.testbrowser to run functional tests also suffers, transitively,
>> from the hairball.
>
> Not exactly.  The "test" extra is only needed for zope.testbrowser's
> tests.  To use testbrowser in a functional test the base dependencies
> should do it.
>
> Well, not exactly; I just noticed that zope.app.testing would also be
> required, but you have to depend on that to do functional tests anyway.
> I'll look into making that dependency explicit.  It'll probably mean
> adding a "zope" extra that no one will use because things work without
> it anyway.

I just added a zope-functional-testing extra for those doing functional
tests of Zope 3 apps.  It only adds zope.app.testing, but increases the
number of dependencies (transitively) to 81 packages.

The non-extra dependencies (including transitive dependencies) remain
thus:

ClientForm
mechanize
setuptools
zope.event
zope.i18nmessageid
zope.interface
zope.schema
zope.testing

I'm working on a new package (maybe named zope.functionaltesting) that
will provide only what's needed for functional testing of Zope 3 apps
using testbrowser without all the baggage of zope.app.testing (see
http://hannosch.eu/zope2-dependencies/zope.app.testing.jpeg).
-- 
Benji York
Senior Software Engineer
Zope Corporation
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-11-29 Thread Benji York
On Sat, Nov 29, 2008 at 11:37 AM, Tres Seaver <[EMAIL PROTECTED]> wrote:
> I did notice that revision 92597, whose log message was "Revert to an
> older zope.testing. New one is way too new", also bumpted
> zope.testbrowser from 3.4.2 to 3.5.1.  Reverting to 3.4.2 doesn't get
> the tests to pass, however.

When this topic came up a few weeks ago I looked at the zope.testbrowser
tests and they passed (IIRC) on both the trunk and 3.5.1 branches, so
I'm not sure what's going on here... I just reran trunk and 3.5.1 and
both pass, so I'm still confused.

> I started to look at the zope.testbrowser failures, but gave up when I
> discovered the dependency snarl which its tests create:  running the
> tests pulls in *all* of zope.app, including even rotterdam!

I suspect our old friend zope.app.zcmlfiles is the culprit there.  I
don't think it'd be too hard to reduce the test dependencies.  I'm also
not particularly motivated to do so either. ;)

> Note that this means that any other package which wants to use
> zope.testbrowser to run functional tests also suffers, transitively,
> from the hairball.

Not exactly.  The "test" extra is only needed for zope.testbrowser's
tests.  To use testbrowser in a functional test the base dependencies
should do it.

Well, not exactly; I just noticed that zope.app.testing would also be
required, but you have to depend on that to do functional tests anyway.
I'll look into making that dependency explicit.  It'll probably mean
adding a "zope" extra that no one will use because things work without
it anyway.
-- 
Benji York
Senior Software Engineer
Zope Corporation
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-11-29 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Sidnei da Silva wrote:

> It is certainly in my plans to look at this. With December right
> ahead, I'm sure I will make time for this before the end of this year.

Hmm, just let me note that we have had the Zope2 trunk broken now broken
for a month, which is contrary to our stock policy.

I did notice that revision 92597, whose log message was "Revert to an
older zope.testing. New one is way too new", also bumpted
zope.testbrowser from 3.4.2 to 3.5.1.  Reverting to 3.4.2 doesn't get
the tests to pass, however.

I started to look at the zope.testbrowser failures, but gave up when I
discovered the dependency snarl which its tests create:  running the
tests pulls in *all* of zope.app, including even rotterdam!

Note that this means that any other package which wants to use
zope.testbrowser to run functional tests also suffers, transitively,
from the hairball.

Any chance that stripping down the dependency set is on folks' radar?


Tres.
- --
===
Tres Seaver  +1 540-429-0999  [EMAIL PROTECTED]
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJMW+u+gerLs4ltQ4RAogaAJ4wH/2u508Q6DdoeAIxGlvfRCZeegCgiCvI
aFRRsD2lSY5Yzv3yFHuUFxs=
=LHeb
-END PGP SIGNATURE-
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-11-29 Thread Sidnei da Silva
It is certainly in my plans to look at this. With December right
ahead, I'm sure I will make time for this before the end of this year.

On Sat, Nov 29, 2008 at 1:41 PM, Tres Seaver <[EMAIL PROTECTED]> wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Any chance you can get these worked out?  I looked at the Products.Five
> tests today, with the following observations:
>
>  - Not as many tests fail if I run '-s Products.Five' as when I run the
>   whole set:  in particular, the first two in 'aqlegacy_ftest.txt'
>  ('HTTPError', 'falcon.pt' not called) don't occur.
>
>  - The next 'aqlegacy_ftest.txt' failure is because the content provider
>   is not being acquisition wrapped.  The remaining failure is likely
>   due to the same cause (it is on the following line).
>
>  - All the failing tests in Products.Five come from code which relies
>   on zope.testbrowser, via the Products.Five.testbrowser shim.
>
>  - The first failing zope.testbrowser test (README.txt line 1162) seems
>   to be due to a change somewhere which contradicts the comment just
>   below the example:  "Here, the body is left in place because it isn't
>   form data."
>
>  - The testing requirements for zope.testbrowser itself are really
>   snarled up:  it pulls in basically all of Zope3.
>
>
>
> -  Original Message 
> Subject: Zope Tests: 4 OK, 2 Failed
> Date: Sat, 29 Nov 2008 13:00:03 +0100
> From: Zope Tests Summarizer <[EMAIL PROTECTED]>
> To: Zope-dev 
> Newsgroups: gmane.comp.web.zope.devel
>
> Summary of messages to the zope-tests list.
> Period Fri Nov 28 12:00:00 2008 UTC to Sat Nov 29 12:00:00 2008 UTC.
> There were 6 messages: 6 from Zope Tests.
>
>
> Test failures
> - -
>
> Subject: FAILED (failures=3) : Zope-trunk Python-2.4.5 : Linux
> From: Zope Tests
> Date: Fri Nov 28 20:38:21 EST 2008
> URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010572.html
>
> Subject: FAILED (failures=3) : Zope-trunk Python-2.5.2 : Linux
> From: Zope Tests
> Date: Fri Nov 28 20:39:51 EST 2008
> URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010573.html
>
>
> Tests passed OK
> - ---
>
> Subject: OK : Zope-2.8 Python-2.3.7 : Linux
> From: Zope Tests
> Date: Fri Nov 28 20:32:16 EST 2008
> URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010568.html
>
> Subject: OK : Zope-2.9 Python-2.4.5 : Linux
> From: Zope Tests
> Date: Fri Nov 28 20:33:51 EST 2008
> URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010569.html
>
> Subject: OK : Zope-2.10 Python-2.4.5 : Linux
> From: Zope Tests
> Date: Fri Nov 28 20:35:21 EST 2008
> URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010570.html
>
> Subject: OK : Zope-2.11 Python-2.4.5 : Linux
> From: Zope Tests
> Date: Fri Nov 28 20:36:51 EST 2008
> URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010571.html
>
> ___
> Zope-Dev maillist  -  Zope-Dev@zope.org
> http://mail.zope.org/mailman/listinfo/zope-dev
> **  No cross posts or HTML encoding!  **
> (Related lists -
>  http://mail.zope.org/mailman/listinfo/zope-announce
>  http://mail.zope.org/mailman/listinfo/zope )
>
>
> - --
> ===
> Tres Seaver  +1 540-429-0999  [EMAIL PROTECTED]
> Palladion Software   "Excellence by Design"http://palladion.com
> -BEGIN PGP SIGNATURE-
> Version: GnuPG v1.4.6 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFJMWKt+gerLs4ltQ4RAh0MAJ4gBJZOdsRw+Q8ZqhOU+VlajxuC6wCgw0BP
> oCiVHZ0ig6wiItTk9clcBJU=
> =KihL
> -END PGP SIGNATURE-
>



-- 
Sidnei da Silva
Enfold Systems
http://enfoldsystems.com
Fax +1 832 201 8856
Office +1 713 942 2377 Ext 214
Skype zopedc
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] [Fwd: Zope Tests: 4 OK, 2 Failed]

2008-11-29 Thread Tres Seaver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Any chance you can get these worked out?  I looked at the Products.Five
tests today, with the following observations:

 - Not as many tests fail if I run '-s Products.Five' as when I run the
   whole set:  in particular, the first two in 'aqlegacy_ftest.txt'
  ('HTTPError', 'falcon.pt' not called) don't occur.

 - The next 'aqlegacy_ftest.txt' failure is because the content provider
   is not being acquisition wrapped.  The remaining failure is likely
   due to the same cause (it is on the following line).

 - All the failing tests in Products.Five come from code which relies
   on zope.testbrowser, via the Products.Five.testbrowser shim.

 - The first failing zope.testbrowser test (README.txt line 1162) seems
   to be due to a change somewhere which contradicts the comment just
   below the example:  "Here, the body is left in place because it isn't
   form data."

 - The testing requirements for zope.testbrowser itself are really
   snarled up:  it pulls in basically all of Zope3.



-  Original Message 
Subject: Zope Tests: 4 OK, 2 Failed
Date: Sat, 29 Nov 2008 13:00:03 +0100
From: Zope Tests Summarizer <[EMAIL PROTECTED]>
To: Zope-dev 
Newsgroups: gmane.comp.web.zope.devel

Summary of messages to the zope-tests list.
Period Fri Nov 28 12:00:00 2008 UTC to Sat Nov 29 12:00:00 2008 UTC.
There were 6 messages: 6 from Zope Tests.


Test failures
- -

Subject: FAILED (failures=3) : Zope-trunk Python-2.4.5 : Linux
From: Zope Tests
Date: Fri Nov 28 20:38:21 EST 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010572.html

Subject: FAILED (failures=3) : Zope-trunk Python-2.5.2 : Linux
From: Zope Tests
Date: Fri Nov 28 20:39:51 EST 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010573.html


Tests passed OK
- ---

Subject: OK : Zope-2.8 Python-2.3.7 : Linux
From: Zope Tests
Date: Fri Nov 28 20:32:16 EST 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010568.html

Subject: OK : Zope-2.9 Python-2.4.5 : Linux
From: Zope Tests
Date: Fri Nov 28 20:33:51 EST 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010569.html

Subject: OK : Zope-2.10 Python-2.4.5 : Linux
From: Zope Tests
Date: Fri Nov 28 20:35:21 EST 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010570.html

Subject: OK : Zope-2.11 Python-2.4.5 : Linux
From: Zope Tests
Date: Fri Nov 28 20:36:51 EST 2008
URL: http://mail.zope.org/pipermail/zope-tests/2008-November/010571.html

___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists -
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )


- --
===
Tres Seaver  +1 540-429-0999  [EMAIL PROTECTED]
Palladion Software   "Excellence by Design"http://palladion.com
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJMWKt+gerLs4ltQ4RAh0MAJ4gBJZOdsRw+Q8ZqhOU+VlajxuC6wCgw0BP
oCiVHZ0ig6wiItTk9clcBJU=
=KihL
-END PGP SIGNATURE-
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
 http://mail.zope.org/mailman/listinfo/zope-announce
 http://mail.zope.org/mailman/listinfo/zope )