[GitHub] blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error

blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381298167 Trillian test result (tid-2501) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 113772 seconds

[cloudstack-cloudmonkey] branch master updated: set: autocompletion for set parameters

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git The following commit(s) were added to refs/heads/master by this push: new 3584ac0 set: autocompletion for

[cloudstack-cloudmonkey] branch master updated: help: fix help to work with -h and help

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git The following commit(s) were added to refs/heads/master by this push: new 15697d8 help: fix help to work

[cloudstack-cloudmonkey] branch master updated: lint: introduce lint and fix lint issues

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git The following commit(s) were added to refs/heads/master by this push: new 0eb9c6b lint: introduce lint

[cloudstack-cloudmonkey] 03/04: about: add separate go file for cli name, version

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git commit 86b9e4a347a6f56c62af6ec98765a0c900884f47 Author: Rohit Yadav AuthorDate: Sat Apr 14

[cloudstack-cloudmonkey] 02/04: config: implement ini based config same as legacy cloudmonkey

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git commit ed77ec07d952c49d987a26a3c3d355bcaf00233b Author: Rohit Yadav AuthorDate: Sat Apr 14

[cloudstack-cloudmonkey] 04/04: prompt: emoji-roulette on new shell

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git commit 88fcf8fe17735eb8a29613f228960815c189550b Author: Rohit Yadav AuthorDate: Sat Apr 14

[cloudstack-cloudmonkey] branch master updated (fa6d97b -> 88fcf8f)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git. from fa6d97b docs: display better formatted help with 80char width new 351fb28 vendor: merge

[GitHub] jorgesumle commented on a change in pull request #2571: Improve Spanish translation

jorgesumle commented on a change in pull request #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181508825 ## File path: ui/l10n/es.js ## @@ -32,15 +32,15 @@ var dictionary = { "error.password.not.match": "Los campos

[GitHub] jorgesumle commented on a change in pull request #2571: Improve Spanish translation

jorgesumle commented on a change in pull request #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181503750 ## File path: ui/l10n/es.js ## @@ -2159,66 +2159,66 @@ var dictionary = {

[GitHub] rafaelweingartner commented on a change in pull request #2571: Improve Spanish translation

rafaelweingartner commented on a change in pull request #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181506196 ## File path: ui/l10n/es.js ## @@ -32,15 +32,15 @@ var dictionary = { "error.password.not.match": "Los

[GitHub] rafaelweingartner commented on a change in pull request #2571: Improve Spanish translation

rafaelweingartner commented on a change in pull request #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181506196 ## File path: ui/l10n/es.js ## @@ -32,15 +32,15 @@ var dictionary = { "error.password.not.match": "Los

[GitHub] blueorangutan commented on issue #2499: Updates to capacity management

blueorangutan commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-381255928 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1927 This is an automated

[GitHub] jorgesumle commented on issue #2571: Improve Spanish translation

jorgesumle commented on issue #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#issuecomment-381255969 > you please translate the PR description in Spanish to English? I would have to link to every grammar rule I quoted and there are no

[cloudstack] branch bugfix/CID-1254835 deleted (was ef30300)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1254835 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was ef30300 CID-1254834 secStorageVm can only be null in a special case The revisions that were on

[cloudstack] branch bugfix/CID-1249801 deleted (was ab980cd)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1249801 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was ab980cd CID-1249801 This should be a string comparison, not an object comparison The revisions

[cloudstack] branch bugfix/CID-1249803 deleted (was 0080905)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1249803 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 0080905 CID-1249803 Remove dead code The revisions that were on this branch are still contained in

[cloudstack] branch bugfix/CID-1249800 deleted (was 320544f)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1249800 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 320544f CID-1249800 Fix a coverity bug, but disable the code its used in as it needs rethinking

[GitHub] jorgesumle commented on a change in pull request #2571: Improve Spanish translation

jorgesumle commented on a change in pull request #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181504697 ## File path: ui/l10n/es.js ## @@ -32,15 +32,15 @@ var dictionary = { "error.password.not.match": "Los campos

[cloudstack] branch bugfix/CID-1232333 deleted (was 9eb2b27)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1232333 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 9eb2b27 Fix for CID-1232333, CID-1232334, CID-1232335, CID-1232336 and CID-1232337 The revisions

[cloudstack] branch bugfix/CID-1230587-2ndtime deleted (was 1c2a29f)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1230587-2ndtime in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 1c2a29f Move the kickstart pxe vr commands to the virtualroutingresource instead of using

[cloudstack] branch bugfix/CID-1230585 deleted (was d2aa1c4)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1230585 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was d2aa1c4 Fix concurrency issues CID-1230585 and CID-1230586 The revisions that were on this branch

[cloudstack] branch bugfix/CID-1230587 deleted (was 328599a)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1230587 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 328599a Don't depend on static paths especially if we are already checking that location using the

[cloudstack] branch bugfix/CID-1222206 deleted (was 93c7242)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-106 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 93c7242 CID-106 Simplify isDmcEnabled. This change permanently discards the following

[cloudstack] branch bugfix/CID-1212198 deleted (was 008e0e3)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1212198 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 008e0e3 CID-1212198: remove unused assignment This change permanently discards the following

[cloudstack] branch bugfix/CID-1192810 deleted (was 38f8ca7)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1192810 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 38f8ca7 CID-1192810: Remove useless control flow This change permanently discards the following

[cloudstack] branch bugfix/CID-1192805 deleted (was d7850d5)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1192805 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was d7850d5 CID-1192805: Fix dead local store. This change permanently discards the following

[cloudstack] branch bugfix/CID-116538 deleted (was de26a72)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-116538 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was de26a72 Fix resource leaks on exception paths The revisions that were on this branch are still

[cloudstack] branch bugfix/CS-7580 deleted (was 2aec165)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CS-7580 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 2aec165 Remove duplicate field in constructor This change permanently discards the following

[cloudstack] branch bugfix/CS-7665 deleted (was 47ac3e4)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CS-7665 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 47ac3e4 CLOUDSTACK-7665 File.separator shouldn't be used in this case, the separator is fixed just

[cloudstack] branch bugfix/TO-hierarchy-flatening deleted (was 6fa1bd8)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/TO-hierarchy-flatening in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 6fa1bd8 nic shouldn't inherit from net but be part of it/hooked into it This change

[GitHub] jorgesumle commented on a change in pull request #2571: Improve Spanish translation

jorgesumle commented on a change in pull request #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181503750 ## File path: ui/l10n/es.js ## @@ -2159,66 +2159,66 @@ var dictionary = {

[cloudstack] branch bugfix/CID-1116850 deleted (was d9560c5)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1116850 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was d9560c5 CID-1116850: Remove dead local store. The revisions that were on this branch are still

[cloudstack] branch bugfix/CID-1114601 deleted (was 4ad2734)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1114601 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 4ad2734 CID-1114601 to 1114604 Recommended practice is to test the result of skip and read for EOF

[cloudstack] branch bugfix/CID-1114591 deleted (was 2df41e8)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch bugfix/CID-1114591 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 2df41e8 CID-1114592 Replaced duplicate code with a call to super The revisions that were on this

[cloudstack] branch dedicate_public_ip_range_2 deleted (was cddf266)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch dedicate_public_ip_range_2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was cddf266 nose won't discover the test if it is executable. This change permanently discards

[cloudstack] branch dedicate_public_ip_range deleted (was c447e53)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch dedicate_public_ip_range in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was c447e53 Dedicate Public IP range This change permanently discards the following revisions:

[cloudstack] branch dedicate-guest-vlan-ranges_2 deleted (was 16293cc)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch dedicate-guest-vlan-ranges_2 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 16293cc Fix unit test to include the isolation type check of the physical network This

[cloudstack] branch dedicate-guest-vlan-ranges deleted (was 5f15f38)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch dedicate-guest-vlan-ranges in repository https://gitbox.apache.org/repos/asf/cloudstack.git. was 5f15f38 guest-vlan: fix tests This change permanently discards the following revisions:

[GitHub] blueorangutan commented on issue #2499: Updates to capacity management

blueorangutan commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-381250752 @mike-tutkowski a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management

mike-tutkowski commented on issue #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-381250553 Two LGTMs and regression tests looking good, so merging. This is an automated

[GitHub] mike-tutkowski closed pull request #2499: Updates to capacity management

mike-tutkowski closed pull request #2499: Updates to capacity management URL: https://github.com/apache/cloudstack/pull/2499 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[cloudstack-cloudmonkey] branch master updated: docs: display better formatted help with 80char width

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git The following commit(s) were added to refs/heads/master by this push: new fa6d97b docs: display better

[cloudstack-cloudmonkey] 02/05: cli: improve docs output

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git commit 49d5d1ef40375ec4912e12e8af63fe7368b4f434 Author: Rohit Yadav AuthorDate: Fri Apr 13

[cloudstack-cloudmonkey] branch master updated (ff373cd -> 6027bf7)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git. from ff373cd cli: implement auto-completion for apis new 06b38b7 cli: improve selector and

[cloudstack-cloudmonkey] 04/05: config: use a cross-platform compatible monkey emoji

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git commit 3f2ce7501565f937c596d74fed48cb8c08bbedca Author: Rohit Yadav AuthorDate: Fri Apr 13

[cloudstack-cloudmonkey] 03/05: cmk: on error return non-zero exit code

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git commit c453cc9213c8f34c7a2c053630c559795039e564 Author: Rohit Yadav AuthorDate: Fri Apr 13

[cloudstack-cloudmonkey] 01/05: cli: improve selector and autocompletion

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git commit 06b38b73bdbb2431ed151d183ae1367de0c78803 Author: Rohit Yadav AuthorDate: Fri Apr 13

[cloudstack-cloudmonkey] 05/05: travis: enable travis for build checks

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git commit 6027bf744ccae3c6218ad40a15ae7f99970ec172 Author: Rohit Yadav AuthorDate: Sat Apr 14

[GitHub] nvazquez commented on a change in pull request #2571: Improve Spanish translation

nvazquez commented on a change in pull request #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181452244 ## File path: ui/l10n/es.js ## @@ -2159,66 +2159,66 @@ var dictionary = { "message.password.has.been.reset.to":

[GitHub] nvazquez commented on a change in pull request #2571: Improve Spanish translation

nvazquez commented on a change in pull request #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#discussion_r181450185 ## File path: ui/l10n/es.js ## @@ -32,15 +32,15 @@ var dictionary = { "error.password.not.match": "Los campos

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381171566 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1926 This

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381163219 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block

DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381162834 @lzh3636 changes seem fine to me, but keep in mind that a lot more cleanup of logging code can be done in the system. you can

[GitHub] DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381161993 ah, in that case I stand corrected, @rafaelweingartner. once again looks good

[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381159586 The method `encodeURIComponent` is not a third party library. It is a native function in Javascript.

[GitHub] lzh3636 commented on issue #2553: WIP: Update inconsistent debugging info in catch block

lzh3636 commented on issue #2553: WIP: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381148383 @DaanHoogland Thank you so much. I'm done, I'll not do more commit in this PR if the existing changes are fine

[GitHub] DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381147561 btw: look good in general it is just that I would have opted for giving a better name to todb and use the wrapper

[GitHub] DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381147283 right, but having a wrapper around an external piece of code is always good. Per our older discussions; let's reduce the

[GitHub] DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block

DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381146302 @lzh3636 i see you added yet another commit, I'll mark this as work in progress. Please let us know when you are done, so we

[GitHub] blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error

blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381143956 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1925 This is an automated

[GitHub] blueorangutan commented on issue #2554: agent: Add logging to libvirt qemu hook and cleanup

blueorangutan commented on issue #2554: agent: Add logging to libvirt qemu hook and cleanup URL: https://github.com/apache/cloudstack/pull/2554#issuecomment-381141209 Trillian test result (tid-2499) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381138853 Good question. Why not use directly a function that everybody knows (everybody that works with javascript)? When

[GitHub] rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

rafaelweingartner commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381138853 Good question. Why not use directly a function that everybody knows (everybody that works with javascript)? When

[GitHub] DaanHoogland commented on issue #2571: Improve Spanish translation

DaanHoogland commented on issue #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#issuecomment-381137498 @milamberspace can you please advise if this is the proper way to go? This is an

[GitHub] DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

DaanHoogland commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381137051 Why remove todb for the longer encodeURIComponent, when the first is only a wrapper for the latter?

[GitHub] blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error

blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381135949 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] nvazquez commented on issue #2567: [Vmware] Fix for OVF parsing error

nvazquez commented on issue #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381135750 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] blueorangutan commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

blueorangutan commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381132999 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1924 This is

[GitHub] blueorangutan commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'.

blueorangutan commented on issue #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572#issuecomment-381126316 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rafaelweingartner opened a new pull request #2572: Remove 'todb' in favor of 'encodeURIComponent'.

rafaelweingartner opened a new pull request #2572: Remove 'todb' in favor of 'encodeURIComponent'. URL: https://github.com/apache/cloudstack/pull/2572 ## Description While executing the find/replace, I found some blocks of duplicated code. Therefore, I extracted the duplicated part

[GitHub] rafaelweingartner commented on issue #2571: Improve Spanish translation

rafaelweingartner commented on issue #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571#issuecomment-38443 We will need Spanish speakers to help us review this one :) This is an

[GitHub] jorgesumle opened a new pull request #2571: Improve Spanish translation

jorgesumle opened a new pull request #2571: Improve Spanish translation URL: https://github.com/apache/cloudstack/pull/2571 ## Description Improve Spanish translation: - _Pone coma después de «por favor». El complemento oracional «por favor» debe ir seguido de una coma._

[GitHub] rhtyd commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

rhtyd commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-381108121 We can wait for Travis to go green and then this PR may be merged based on reviews and test results.

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181360657 ## File path: core/src/com/cloud/info/ConsoleProxyInfo.java ## @@ -55,6 +57,9 @@

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181360178 ## File path: server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java ## @@

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181360220 ## File path: core/src/com/cloud/info/ConsoleProxyInfo.java ## @@ -55,6 +57,9 @@

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381106659 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block

DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381106436 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381105269 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1923 This

[GitHub] rafaelweingartner commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

rafaelweingartner commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181356856 ## File path: core/src/com/cloud/info/ConsoleProxyInfo.java ## @@ -55,6

[GitHub] rafaelweingartner commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

rafaelweingartner commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181356856 ## File path: core/src/com/cloud/info/ConsoleProxyInfo.java ## @@ -55,6

[cloudstack] branch master updated: readme: Improve README (#2570)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 68b2b17 readme: Improve README (#2570)

[GitHub] rhtyd closed pull request #2570: Improve README

rhtyd closed pull request #2570: Improve README URL: https://github.com/apache/cloudstack/pull/2570 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181354685 ## File path: core/src/com/cloud/info/ConsoleProxyInfo.java ## @@ -55,6 +57,9 @@

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381099849 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block

DaanHoogland commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381099635 debian packaging is still failing on git clone. It seems very intermitted as centos does the samething and builds fine

[GitHub] jorgesumle opened a new pull request #2570: Improve README

jorgesumle opened a new pull request #2570: Improve README URL: https://github.com/apache/cloudstack/pull/2570 ## Description - Add space between stop and next sentence - Add missing full stops ## Types of changes - [ ] Breaking change (fix or feature

[GitHub] blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block

blueorangutan commented on issue #2553: Update inconsistent debugging info in catch block URL: https://github.com/apache/cloudstack/pull/2553#issuecomment-381096489 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1922 This

[GitHub] blueorangutan commented on issue #2568: Log command output in CsHelper.execute command

blueorangutan commented on issue #2568: Log command output in CsHelper.execute command URL: https://github.com/apache/cloudstack/pull/2568#issuecomment-381096488 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1921 This is

[GitHub] rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181346949 ## File path: api/src/com/cloud/agent/api/storage/OVFHelper.java ## @@ -113,7 +113,7 @@ public static Long

[GitHub] nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart URL: https://github.com/apache/cloudstack/pull/2508#discussion_r181347015 ## File path: ui/scripts/network.js ## @@ -1100,11 +1100,23 @@

[GitHub] rafaelweingartner commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

rafaelweingartner commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181346594 ## File path: api/src/com/cloud/agent/api/storage/OVFHelper.java ## @@ -113,7 +113,7 @@ public

[GitHub] DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181345229 ## File path: api/src/com/cloud/agent/api/storage/OVFHelper.java ## @@ -113,7 +113,7 @@ public static

[GitHub] rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

rhtyd commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#discussion_r18138 ## File path: api/src/com/cloud/agent/api/storage/OVFHelper.java ## @@ -113,7 +113,7 @@ public static Long

[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181344148 ## File path: core/src/com/cloud/info/ConsoleProxyInfo.java ## @@ -55,6 +57,9 @@

[GitHub] DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181344017 ## File path: api/src/com/cloud/agent/api/storage/OVFHelper.java ## @@ -113,7 +113,7 @@ public static

[GitHub] DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error

DaanHoogland commented on a change in pull request #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#discussion_r181343883 ## File path: api/src/com/cloud/agent/api/storage/OVFHelper.java ## @@ -113,7 +113,7 @@ public static

[GitHub] blueorangutan commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12

blueorangutan commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12 URL: https://github.com/apache/cloudstack/pull/2559#issuecomment-381089699 Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1920 This is an

[GitHub] blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error

blueorangutan commented on issue #2567: [Vmware] Fix for OVF parsing error URL: https://github.com/apache/cloudstack/pull/2567#issuecomment-381089537 Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1919 This is an automated

  1   2   >