kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411518
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java
###
kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411766
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/CombineGroupByOrderByOperator.java
kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411811
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java
##
@@ -
kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411231
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler
kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411786
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.ja
kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411567
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java
###
kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411445
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/table/ConcurrentIndexedTable.java
###
kishoreg commented on a change in pull request #4602: First pass of GROUP BY
with ORDER BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#discussion_r324411303
##
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##
codecov-io edited a comment on issue #4597: [WIP] Adding json_path function to
extract field from json object
URL: https://github.com/apache/incubator-pinot/pull/4597#issuecomment-529669548
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4597?src=pr&el=h1)
Report
> Mergin
codecov-io edited a comment on issue #4553: Refactor ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#issuecomment-524232323
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4553?src=pr&el=h1)
Report
> Merging
[#4553](https://codecov.io/gh/a
jackjlli commented on a change in pull request #4567: Add integration test for
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324392158
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerLea
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388158
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388249
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388229
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388119
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324388084
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324386815
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
jackjlli commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324379250
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
jackjlli commented on issue #4583: Support default value for Byte column
URL: https://github.com/apache/incubator-pinot/pull/4583#issuecomment-531390467
@mayankshriv tests for both HLL and TDigest columns added.
This is an aut
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch byte-default-value
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 57364a4 Update doc
add 96af561 Add tests for Tdigest and HLL byte columns
No new revisions
mcvsubbu commented on a change in pull request #4607: Add code for pinot
benchmark as a service
URL: https://github.com/apache/incubator-pinot/pull/4607#discussion_r324358479
##
File path:
pinot-benchmark/src/main/java/org/apache/pinot/benchmark/PinotBenchmarkServiceStarter.java
#
mcvsubbu commented on a change in pull request #4607: Add code for pinot
benchmark as a service
URL: https://github.com/apache/incubator-pinot/pull/4607#discussion_r324358298
##
File path:
pinot-benchmark/src/main/java/org/apache/pinot/benchmark/PinotBenchmarkServiceStarter.java
#
mcvsubbu commented on a change in pull request #4607: Add code for pinot
benchmark as a service
URL: https://github.com/apache/incubator-pinot/pull/4607#discussion_r324357773
##
File path:
pinot-benchmark/src/main/java/org/apache/pinot/benchmark/PinotBenchmarkServiceStarter.java
#
xiaohui-sun opened a new pull request #4613: [TE] consider anomaly type during
merge
URL: https://github.com/apache/incubator-pinot/pull/4613
This PR fixes the logic so that we don't merge two anomalies if they have
different types.
akshayrai commented on a change in pull request #4609: [TE][Composite-Alert]
Entity Anomaly Merger
URL: https://github.com/apache/incubator-pinot/pull/4609#discussion_r324308652
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/spi/model/Anomal
akshayrai commented on a change in pull request #4609: [TE][Composite-Alert]
Entity Anomaly Merger
URL: https://github.com/apache/incubator-pinot/pull/4609#discussion_r324308660
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/EntityAn
codecov-io edited a comment on issue #4602: First pass of GROUP BY with ORDER
BY support
URL: https://github.com/apache/incubator-pinot/pull/4602#issuecomment-530129911
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4602?src=pr&el=h1)
Report
> Merging
[#4602](https://co
chenboat commented on issue #4608: Unit tests and bug fixes for DeleteTable
rest API for controller.
URL: https://github.com/apache/incubator-pinot/pull/4608#issuecomment-531331597
> Is this somehow causing an issue in your environment? What is the
motivation behind this change?
Yes
vincentchenjl commented on a change in pull request #4611: [TE] Remove the
logic of reading stderr from phantomjs to avoid zombie processes
URL: https://github.com/apache/incubator-pinot/pull/4611#discussion_r324294233
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/
mcvsubbu commented on a change in pull request #4567: Add integration test for
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324293457
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerLea
mcvsubbu commented on a change in pull request #4567: Add integration test for
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324291564
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerLea
mcvsubbu commented on a change in pull request #4567: Add integration test for
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4567#discussion_r324293752
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerLea
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324286616
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324278948
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324281828
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324271954
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324278317
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324287164
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324284314
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324280388
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324271534
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
mcvsubbu commented on a change in pull request #4553: Refactor
ControllerLeaderLocator
URL: https://github.com/apache/incubator-pinot/pull/4553#discussion_r324285734
##
File path:
pinot-core/src/main/java/org/apache/pinot/server/realtime/ControllerLeaderLocator.java
##
@@
akshayrai commented on a change in pull request #4611: [TE] Remove the logic of
reading stderr from phantomjs to avoid zombie processes
URL: https://github.com/apache/incubator-pinot/pull/4611#discussion_r324279730
##
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pino
mcvsubbu commented on issue #4608: Unit tests and bug fixes for DeleteTable
rest API for controller.
URL: https://github.com/apache/incubator-pinot/pull/4608#issuecomment-531289428
Is this somehow causing an issue in your environment? What is the motivation
behind this change?
---
chenboat commented on a change in pull request #4608: Unit tests and bug fixes
for DeleteTable rest API for controller.
URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r324223469
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resour
chenboat commented on a change in pull request #4608: Unit tests and bug fixes
for DeleteTable rest API for controller.
URL: https://github.com/apache/incubator-pinot/pull/4608#discussion_r324223312
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resour
fx19880617 edited a comment on issue #4597: [WIP] Adding json_path function to
extract field from json object
URL: https://github.com/apache/incubator-pinot/pull/4597#issuecomment-531218134
Will add more documents, this could be used in selection/filtering/groupby,
please refer to integrat
fx19880617 commented on issue #4597: [WIP] Adding json_path function to extract
field from json object
URL: https://github.com/apache/incubator-pinot/pull/4597#issuecomment-531218134
Will add more documents, this could be used in selection/filtering/groupby,
please refer to integration tes
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch jsonpath_function
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 21e2810 Adding json_path function to extract field from json object
add 382d5f6 Adding in
AnishKanth commented on issue #4603: Can not find a deserializer for
non-concrete Map type
URL:
https://github.com/apache/incubator-pinot/issues/4603#issuecomment-531136177
Facing the same issue with above mentioned docker
image(https://github.com/apache/incubator-pinot/tree/master/docker
codecov-io commented on issue #4612: Add column types info to the selection and
aggregation query results.
URL: https://github.com/apache/incubator-pinot/pull/4612#issuecomment-531124397
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4612?src=pr&el=h1)
Report
> Merging
51 matches
Mail list logo