rdhabalia commented on a change in pull request #1208: Add
hostname-verification at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167159624
##
File path:
pulsar-broker/src/test/resources/authentication/tls/hn-verification/broker-cert.pe
rdhabalia commented on a change in pull request #1208: Add
hostname-verification at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167158945
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientConfiguration.java
rdhabalia commented on a change in pull request #1208: Add
hostname-verification at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167165234
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/util/ssl/DefaultHostnameVerif
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 3f2c1f2 Updated site at revision
ivankelly commented on a change in pull request #1205: Algorithm to find start
point of compacted ledger
URL: https://github.com/apache/incubator-pulsar/pull/1205#discussion_r167196940
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
#
zhaijack commented on a change in pull request #1066: Issue 937: add
CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167251458
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/client/api/T
zhaijack commented on issue #1066: Issue 937: add CommandGetLastMessageId to
make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#issuecomment-364459531
retest this please
This is an aut
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167252486
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167258867
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167261106
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167263964
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167263964
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167264860
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167264860
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
merlimat commented on a change in pull request #1209: Fixed missing '"' sign in
system metrics for Prometheus
URL: https://github.com/apache/incubator-pulsar/pull/1209#discussion_r167297551
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/Promethe
merlimat commented on issue #1074: Document features and usage of Pulsar proxy
URL:
https://github.com/apache/incubator-pulsar/issues/1074#issuecomment-364506591
Fixed in #1086
This is an automated message from the Apache Git
merlimat closed issue #1074: Document features and usage of Pulsar proxy
URL: https://github.com/apache/incubator-pulsar/issues/1074
This is an automated message from the Apache Git Service.
To respond to the message, please
merlimat commented on a change in pull request #1200: Add pluggable
authorization mechanism
URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r167298488
##
File path: conf/proxy.conf
##
@@ -49,6 +49,9 @@ authenticationProviders=
# Enforce authorization
merlimat commented on a change in pull request #1205: Algorithm to find start
point of compacted ledger
URL: https://github.com/apache/incubator-pulsar/pull/1205#discussion_r167300225
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
##
merlimat commented on a change in pull request #1205: Algorithm to find start
point of compacted ledger
URL: https://github.com/apache/incubator-pulsar/pull/1205#discussion_r167300931
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
##
merlimat commented on a change in pull request #1208: Add hostname-verification
at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167302047
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientConfiguration.java
merlimat commented on a change in pull request #1208: Add hostname-verification
at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167302744
##
File path: pom.xml
##
@@ -138,6 +138,18 @@ flexible messaging model and an intuitive
merlimat commented on a change in pull request #1208: Add hostname-verification
at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167302503
##
File path: pulsar-client/pom.xml
##
@@ -74,6 +74,17 @@
com.google.code.gson
jai1 commented on issue #1208: Add hostname-verification at client tls
connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#issuecomment-364523700
retest this please
This is an automated message from the Apach
rdhabalia commented on a change in pull request #1208: Add
hostname-verification at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167318158
##
File path: pom.xml
##
@@ -138,6 +138,18 @@ flexible messaging model and an intuitive
jai1 commented on issue #1208: Add hostname-verification at client tls
connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#issuecomment-364523700
retest this please
This is an automated message from the Apach
merlimat opened a new pull request #1210: Cancel keep-alive timer task after
the proxy switch to TCP proxy
URL: https://github.com/apache/incubator-pulsar/pull/1210
### Motivation
After initial handshake, the Pulsar proxy switches to TCP proxy mode, by
just copying buffers between t
merlimat opened a new issue #1211: Intermittent test failure int
ProxyForwardAuthDataTest.testForwardAuthData
URL: https://github.com/apache/incubator-pulsar/issues/1211
https://builds.apache.org/job/pulsar-pull-request/org.apache.pulsar$pulsar-proxy/1581/testReport/junit/org.apache.pulsar
merlimat commented on issue #1211: Intermittent test failure int
ProxyForwardAuthDataTest.testForwardAuthData
URL:
https://github.com/apache/incubator-pulsar/issues/1211#issuecomment-364546359
@jai1 Can you take a look at this?
merlimat commented on a change in pull request #1208: Add hostname-verification
at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167332300
##
File path: pulsar-client-shaded/pom.xml
##
@@ -81,6 +81,8 @@
org.a
rdhabalia commented on a change in pull request #1208: Add
hostname-verification at client tls connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167332606
##
File path: pulsar-client-shaded/pom.xml
##
@@ -81,6 +81,8 @@
org.
merlimat commented on a change in pull request #1066: Issue 937: add
CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167336300
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@
merlimat closed pull request #1209: Fixed missing '"' sign in system metrics
for Prometheus
URL: https://github.com/apache/incubator-pulsar/pull/1209
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 50beaca Fixed missing '"' sign in sys
rdhabalia commented on issue #1210: Cancel keep-alive timer task after the
proxy switch to TCP proxy
URL: https://github.com/apache/incubator-pulsar/pull/1210#issuecomment-364559864
> so it's forcefully closing the connection after 60s
but right now, shouldn't proxy also handle clien
merlimat commented on issue #1210: Cancel keep-alive timer task after the proxy
switch to TCP proxy
URL: https://github.com/apache/incubator-pulsar/pull/1210#issuecomment-364562235
> but right now, shouldn't proxy also handle client's keep-alive request on
PulsarHandler.handlePing() which
rdhabalia commented on issue #1210: Cancel keep-alive timer task after the
proxy switch to TCP proxy
URL: https://github.com/apache/incubator-pulsar/pull/1210#issuecomment-364563293
yes, once proxy state is in `ProxyConnectionToBroker` then it becomes just
pass through.
--
merlimat closed pull request #1210: Cancel keep-alive timer task after the
proxy switch to TCP proxy
URL: https://github.com/apache/incubator-pulsar/pull/1210
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of pr
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new f288db5 Cancel keep-alive timer task
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167372153
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167372586
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide
`TopicsConsumer` to consume from several topics under same namespace
URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167372863
##
File path:
pulsar-client/src/main/java/org/apache/pulsar
merlimat commented on a change in pull request #1066: Issue 937: add
CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167382938
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/
merlimat commented on a change in pull request #1066: Issue 937: add
CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167382781
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/
merlimat commented on a change in pull request #1066: Issue 937: add
CommandGetLastMessageId to make reader know the end of topic
URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167382822
##
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/
merlimat commented on issue #1207: Allow to configure most
client/producer/consumer options in Kafka API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/1207#issuecomment-364614000
retest this please
This is an a
merlimat commented on issue #1207: Allow to configure most
client/producer/consumer options in Kafka API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/1207#issuecomment-364614000
retest this please
This is an a
rdhabalia closed pull request #1208: Add hostname-verification at client tls
connection
URL: https://github.com/apache/incubator-pulsar/pull/1208
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
This is an automated email from the ASF dual-hosted git repository.
rdhabalia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 8d3ab43 Add hostname-verification
maskit commented on issue #1208: Add hostname-verification at client tls
connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#issuecomment-364618475
Actually I was looking into the code, and found much of duplicate code.
The blocks for `trustManager` and `keyManager`
sijie commented on a change in pull request #1156: Introduce
ConsumerGroupListener for realizing if a consumer is active in a failover
subscription group
URL: https://github.com/apache/incubator-pulsar/pull/1156#discussion_r167388187
##
File path:
pulsar-client/src/main/java/org/a
maskit opened a new pull request #1212: Support custom URL scheme handlers
URL: https://github.com/apache/incubator-pulsar/pull/1212
### Motivation
Data URL scheme is implemented in Athenz auth plugin but it's not Athenz
specific and should be able to use from other places.
##
sijie commented on a change in pull request #1156: Introduce
ConsumerGroupListener for realizing if a consumer is active in a failover
subscription group
URL: https://github.com/apache/incubator-pulsar/pull/1156#discussion_r167388965
##
File path:
pulsar-broker/src/main/java/org/a
sijie commented on issue #1156: Introduce ConsumerGroupListener for realizing
if a consumer is active in a failover subscription group
URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-364625065
@merlimat I have addressed your comments. can you review this again? After
merlimat closed pull request #1207: Allow to configure most
client/producer/consumer options in Kafka API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/1207
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
t
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 16a554b Allow to configure most clien
maskit opened a new pull request #1213: Use SecurityUtility class
URL: https://github.com/apache/incubator-pulsar/pull/1213
### Motivation
- Duplicate code makes maintenance hard
### Modifications
- Rename `createNettySslContext` to `createNettySslContextForClient`
-
maskit commented on a change in pull request #1213: Use SecurityUtility class
URL: https://github.com/apache/incubator-pulsar/pull/1213#discussion_r167390938
##
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ServiceChannelInitializer.java
##
@@ -55,24
maskit commented on issue #1213: Use SecurityUtility class
URL: https://github.com/apache/incubator-pulsar/pull/1213#issuecomment-364630011
I know `SecurityUtility` class itself should be refactored too but I'll do
that later to make this PR simple and easy to review.
-
maskit commented on issue #1208: Add hostname-verification at client tls
connection
URL: https://github.com/apache/incubator-pulsar/pull/1208#issuecomment-364630116
Submitted a PR #1213 to address the code duplication.
This i
rdhabalia commented on a change in pull request #1213: Use SecurityUtility class
URL: https://github.com/apache/incubator-pulsar/pull/1213#discussion_r167391135
##
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ServiceChannelInitializer.java
##
@@ -55
rdhabalia opened a new pull request #1214: Support hostname verification on
proxy to broker connection
URL: https://github.com/apache/incubator-pulsar/pull/1214
### Motivation
In #1208, we have added support for hostname verification at client when
client creates tls connection with
62 matches
Mail list logo
