[GitHub] flink pull request #6201: [FLINK-8866][Table API & SQL] Add support for unif...

2018-06-28 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/6201#discussion_r199066851 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/MemoryTableSourceSinkUtil.scala --- @@ -0,0 +1,151 @@ +/* + * Lic

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527250#comment-16527250 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff i

[GitHub] flink pull request #6201: [FLINK-8866][Table API & SQL] Add support for unif...

2018-06-28 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/6201#discussion_r199066578 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java --- @@ -321,6 +327,18 @@ public voi

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527249#comment-16527249 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff i

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527247#comment-16527247 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on the issu

[jira] [Commented] (FLINK-8866) Create unified interfaces to configure and instatiate TableSinks

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527246#comment-16527246 ] ASF GitHub Bot commented on FLINK-8866: --- Github user suez1224 commented on a diff i

[GitHub] flink issue #6201: [FLINK-8866][Table API & SQL] Add support for unified tab...

2018-06-28 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/6201 @twalthr , for sink only table, I dont think the user need to define any rowtimes on it, since it will never use as a source. For table as both source and sink, when registering it as sink, I think

[GitHub] flink pull request #6201: [FLINK-8866][Table API & SQL] Add support for unif...

2018-06-28 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/6201#discussion_r199065915 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java --- @@ -321,6 +327,18 @@ public voi

[jira] [Commented] (FLINK-6160) Retry JobManager/ResourceManager connection in case of timeout

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527223#comment-16527223 ] ASF GitHub Bot commented on FLINK-6160: --- Github user zhangminglei closed the pull r

[GitHub] flink pull request #5440: [FLINK-6160] [flip-6] Retry JobManager/ResourceMan...

2018-06-28 Thread zhangminglei
Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/5440 ---

[jira] [Commented] (FLINK-9640) Checkpointing is aways aborted if any task has been finished

2018-06-28 Thread Hai Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527141#comment-16527141 ] Hai Zhou commented on FLINK-9640: - CC [~StephanEwen], what do you think about this ticket

[jira] [Issue Comment Deleted] (FLINK-9091) Failure while enforcing releasability in building flink-json module

2018-06-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-9091: -- Comment: was deleted (was: What should be the next step ? Thanks) > Failure while enforcing releasability in

[jira] [Updated] (FLINK-9236) Use Apache Parent POM 19

2018-06-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-9236: -- Description: Flink is still using Apache Parent POM 18. Apache Parent POM 19 is out. This will also fix Javado

[jira] [Resolved] (FLINK-9393) LocatableInputSplit#hashCode should take hostnames into account

2018-06-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved FLINK-9393. --- Resolution: Later > LocatableInputSplit#hashCode should take hostnames into account > ---

[jira] [Updated] (FLINK-9363) Bump up the Jackson version

2018-06-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-9363: -- Labels: security (was: ) > Bump up the Jackson version > --- > > Key:

[jira] [Comment Edited] (FLINK-7588) Document RocksDB tuning for spinning disks

2018-06-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258309#comment-16258309 ] Ted Yu edited comment on FLINK-7588 at 6/29/18 2:56 AM: bq. Be ca

[GitHub] flink pull request #6188: [FLINK-6846][Table API] add timestampAdd tableApi

2018-06-28 Thread xueyumusic
Github user xueyumusic commented on a diff in the pull request: https://github.com/apache/flink/pull/6188#discussion_r199040249 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1029,6 +1029,29 @@ object temporalOverl

[jira] [Commented] (FLINK-6846) Add TIMESTAMPADD supported in TableAPI

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527093#comment-16527093 ] ASF GitHub Bot commented on FLINK-6846: --- Github user xueyumusic commented on a diff

[jira] [Commented] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527083#comment-16527083 ] ASF GitHub Bot commented on FLINK-9666: --- Github user lamber-ken commented on the is

[GitHub] flink issue #6212: [FLINK-9666] short-circuit logic should be used in boolea...

2018-06-28 Thread lamber-ken
Github user lamber-ken commented on the issue: https://github.com/apache/flink/pull/6212 hi, @tillrohrmann , what does this mean? I don't understand, need I delete the branch? ![image](https://user-images.githubusercontent.com/20113411/42070083-75c684f2-7b87-11e8-96d8-575e1134

[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527046#comment-16527046 ] ASF GitHub Bot commented on FLINK-9567: --- Github user Clark commented on a diff

[GitHub] flink pull request #6192: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

2018-06-28 Thread Clarkkkkk
Github user Clark commented on a diff in the pull request: https://github.com/apache/flink/pull/6192#discussion_r199036840 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -334,8 +335,11 @@ public void onContainersCompleted(final List li

[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527034#comment-16527034 ] ASF GitHub Bot commented on FLINK-9567: --- Github user Clark commented on a diff

[GitHub] flink pull request #6192: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

2018-06-28 Thread Clarkkkkk
Github user Clark commented on a diff in the pull request: https://github.com/apache/flink/pull/6192#discussion_r199035271 --- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java --- @@ -421,4 +425,139 @@ public void testDeleteApplicationFiles() th

[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527033#comment-16527033 ] ASF GitHub Bot commented on FLINK-9567: --- Github user Clark commented on a diff

[GitHub] flink pull request #6192: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

2018-06-28 Thread Clarkkkkk
Github user Clark commented on a diff in the pull request: https://github.com/apache/flink/pull/6192#discussion_r199035236 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -1120,5 +1120,28 @@ public void reportPayload(R

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527026#comment-16527026 ] ASF GitHub Bot commented on FLINK-9456: --- Github user sihuazhou commented on the iss

[GitHub] flink issue #6132: [FLINK-9456][Distributed Coordination]Let ResourceManager...

2018-06-28 Thread sihuazhou
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6132 @tillrohrmann Thanks for your review and good suggestions, changing the code according to it. ---

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526910#comment-16526910 ] ASF GitHub Bot commented on FLINK-9687: --- Github user Aitozi commented on the issue:

[jira] [Updated] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9687: -- Labels: pull-request-available (was: ) > Delay the state fetch only when the triggerResult is

[GitHub] flink issue #6224: [FLINK-9687]Delay the state fetch only when the triggerRe...

2018-06-28 Thread Aitozi
Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6224 The failed info in travis error shows the test with `checkClusterEmpty` is wrong, Is this happened due to the reuse of yarn cluster? It seems unrelated with this pull request. ---

[jira] [Created] (FLINK-9691) Modify run loop in Kinesis ShardConsumer to not sleep for a fixed fetchIntervalMillis

2018-06-28 Thread Lakshmi Rao (JIRA)
Lakshmi Rao created FLINK-9691: -- Summary: Modify run loop in Kinesis ShardConsumer to not sleep for a fixed fetchIntervalMillis Key: FLINK-9691 URL: https://issues.apache.org/jira/browse/FLINK-9691 Proje

[jira] [Commented] (FLINK-9690) Restoring state with FlinkKafkaProducer and Kafka 1.1.0 client fails

2018-06-28 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526709#comment-16526709 ] Piotr Nowojski commented on FLINK-9690: --- Yep, it looks so. Once I was trying to upg

[jira] [Commented] (FLINK-9514) Create wrapper with TTL logic for value state

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526671#comment-16526671 ] ASF GitHub Bot commented on FLINK-9514: --- Github user azagrebin commented on a diff

[GitHub] flink pull request #6186: [FLINK-9514,FLINK-9515,FLINK-9516] State ttl wrapp...

2018-06-28 Thread azagrebin
Github user azagrebin commented on a diff in the pull request: https://github.com/apache/flink/pull/6186#discussion_r198947650 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlFoldFunction.java --- @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache

[jira] [Created] (FLINK-9690) Restoring state with FlinkKafkaProducer and Kafka 1.1.0 client fails

2018-06-28 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-9690: -- Summary: Restoring state with FlinkKafkaProducer and Kafka 1.1.0 client fails Key: FLINK-9690 URL: https://issues.apache.org/jira/browse/FLINK-9690 Project: Flink

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-28 Thread snuyanzin
Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6226#discussion_r198928207 --- Diff: docs/dev/table/sql.md --- @@ -115,6 +115,10 @@ The following BNF-grammar describes the superset of supported SQL features in ba {% hig

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526602#comment-16526602 ] ASF GitHub Bot commented on FLINK-8650: --- Github user snuyanzin commented on a diff

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526601#comment-16526601 ] ASF GitHub Bot commented on FLINK-8650: --- Github user snuyanzin commented on a diff

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-28 Thread snuyanzin
Github user snuyanzin commented on a diff in the pull request: https://github.com/apache/flink/pull/6226#discussion_r198928117 --- Diff: docs/dev/table/sql.md --- @@ -139,7 +143,8 @@ select: [ WHERE booleanExpression ] [ GROUP BY { groupItem [, groupItem ]* } ]

[jira] [Updated] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-8650: -- Labels: pull-request-available (was: ) > Add tests and documentation for WINDOW clause > -

[jira] [Commented] (FLINK-8650) Add tests and documentation for WINDOW clause

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526597#comment-16526597 ] ASF GitHub Bot commented on FLINK-8650: --- GitHub user snuyanzin opened a pull reques

[GitHub] flink pull request #6226: [FLINK-8650] Tests for WINDOW clause and documenta...

2018-06-28 Thread snuyanzin
GitHub user snuyanzin opened a pull request: https://github.com/apache/flink/pull/6226 [FLINK-8650] Tests for WINDOW clause and documentation update *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community rev

[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526563#comment-16526563 ] ASF GitHub Bot commented on FLINK-9567: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526564#comment-16526564 ] ASF GitHub Bot commented on FLINK-9567: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9567) Flink does not release resource in Yarn Cluster mode

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526565#comment-16526565 ] ASF GitHub Bot commented on FLINK-9567: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6192: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6192#discussion_r198914433 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -1120,5 +1120,28 @@ public void reportPayloa

[GitHub] flink pull request #6192: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6192#discussion_r198915014 --- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java --- @@ -421,4 +425,139 @@ public void testDeleteApplicationFiles()

[GitHub] flink pull request #6192: [FLINK-9567][runtime][yarn] Fix the bug that Flink...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6192#discussion_r198917467 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -334,8 +335,11 @@ public void onContainersCompleted(final List

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198910651 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java --- @@ -53,4 +56,13 @@ * @para

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198491021 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java --- @@ -278,4 +279,13 @@ void heartbeatFromTaskManager(

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526540#comment-16526540 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[jira] [Updated] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9456: -- Labels: pull-request-available (was: ) > Let ResourceManager notify JobManager about failed/ki

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526534#comment-16526534 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[jira] [Updated] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9456: -- Labels: pull-request-available (was: ) > Let ResourceManager notify JobManager about failed/ki

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526541#comment-16526541 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526537#comment-16526537 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198491683 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java --- @@ -1120,5 +1131,14 @@ public void reportPayloa

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526535#comment-16526535 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198490490 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -984,6 +985,15 @@ private void startCheckpointScheduler(

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198493145 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java --- @@ -1202,6 +1209,111 @@ public void

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526538#comment-16526538 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198912464 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java --- @@ -717,6 +728,32 @@ private void alloc

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526536#comment-16526536 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526542#comment-16526542 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198491884 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java --- @@ -53,4 +56,13 @@ * @para

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198490029 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/TaskManagerSlot.java --- @@ -45,6 +46,9 @@ /** Allocation

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198489897 --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java --- @@ -619,7 +619,11 @@ public void task

[jira] [Created] (FLINK-9689) Flink consumer deserialization example

2018-06-28 Thread Satheesh (JIRA)
Satheesh created FLINK-9689: --- Summary: Flink consumer deserialization example Key: FLINK-9689 URL: https://issues.apache.org/jira/browse/FLINK-9689 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526533#comment-16526533 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[GitHub] flink pull request #6132: [FLINK-9456][Distributed Coordination]Let Resource...

2018-06-28 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6132#discussion_r198491333 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterGateway.java --- @@ -278,4 +279,13 @@ void heartbeatFromTaskManager(

[jira] [Commented] (FLINK-9456) Let ResourceManager notify JobManager about failed/killed TaskManagers

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526539#comment-16526539 ] ASF GitHub Bot commented on FLINK-9456: --- Github user tillrohrmann commented on a di

[jira] [Commented] (FLINK-9672) Fail fatally if we cannot submit job on added JobGraph signal

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526528#comment-16526528 ] ASF GitHub Bot commented on FLINK-9672: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #6213: [FLINK-9672] Fail fatally if job submission fails ...

2018-06-28 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/6213#discussion_r198912529 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -322,9 +322,6 @@ private JobManagerRunner createJobManagerRunn

[GitHub] flink pull request #6083: [FLINK-8983] End-to-end test: Confluent schema reg...

2018-06-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6083 ---

[jira] [Commented] (FLINK-8983) End-to-end test: Confluent schema registry

2018-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526502#comment-16526502 ] ASF GitHub Bot commented on FLINK-8983: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-8983) End-to-end test: Confluent schema registry

2018-06-28 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8983. Resolution: Fixed Fix Version/s: 1.6.0 Added via a36b56999240d1ead0793be7acb4ad13cd0559f2 9b

[jira] [Updated] (FLINK-8745) Reduce travis usage

2018-06-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8745: Affects Version/s: (was: 1.5.0) (was: 1.4.0)

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-06-28 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526454#comment-16526454 ] Hequn Cheng commented on FLINK-9687: Good catch. When isFire=false, there is no need

[jira] [Commented] (FLINK-9684) HistoryServerArchiveFetcher not working properly with secure hdfs cluster

2018-06-28 Thread Ethan Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526449#comment-16526449 ] Ethan Li commented on FLINK-9684: - PR: https://github.com/apache/flink/pull/6225 > Histo

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-06-28 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526330#comment-16526330 ] aitozi commented on FLINK-9687: --- Hi, [~kkl0u] I have added my thought/description on this

[jira] [Updated] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-06-28 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] aitozi updated FLINK-9687: -- Description: When the window operator is fired by the event timer or processing timer, it fetch the state conte

[jira] [Commented] (FLINK-9687) Delay the state fetch only when the triggerResult is fire

2018-06-28 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526286#comment-16526286 ] Kostas Kloudas commented on FLINK-9687: --- Hi [~aitozi]. Can you provide a descripti

[jira] [Commented] (FLINK-9662) Task manager isolation for jobs

2018-06-28 Thread Renjie Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526247#comment-16526247 ] Renjie Liu commented on FLINK-9662: --- Would it be better if we reuse the existing job id

[jira] [Resolved] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-06-28 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-9666. -- Resolution: Fixed Fixed via da37daa8ba387435abf6a3bc5629ce7d21a6b017 > short-circuit logic sho

[jira] [Assigned] (FLINK-9666) short-circuit logic should be used in boolean contexts

2018-06-28 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-9666: Assignee: lamber-ken > short-circuit logic should be used in boolean contexts > --

[jira] [Commented] (FLINK-9662) Task manager isolation for jobs

2018-06-28 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526224#comment-16526224 ] Till Rohrmann commented on FLINK-9662: -- I think you can still solve the problem of t

[jira] [Closed] (FLINK-9624) Move jar/artifact upload logic out of JobGraph

2018-06-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-9624. --- Resolution: Fixed master: dd4c8469b11184b633d2b9514b9910622734270f > Move jar/artifact uploa

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

2018-06-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526175#comment-16526175 ] Fabian Hueske commented on FLINK-9688: -- We aim of course for a large set of built-in

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

2018-06-28 Thread Sergey Nuyanzin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526166#comment-16526166 ] Sergey Nuyanzin commented on FLINK-9688: ok I see, thank you for clarification >

[jira] [Commented] (FLINK-9688) ATAN2 Sql Function support

2018-06-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526161#comment-16526161 ] Fabian Hueske commented on FLINK-9688: -- This is issue requests a new feature. The {{

[jira] [Updated] (FLINK-9688) ATAN2 Sql Function support

2018-06-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-9688: - Issue Type: New Feature (was: Bug) > ATAN2 Sql Function support > -- > >

[jira] [Updated] (FLINK-9688) ATAN2 Sql Function support

2018-06-28 Thread Sergey Nuyanzin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-9688: --- Issue Type: Bug (was: New Feature) > ATAN2 Sql Function support > --

[jira] [Updated] (FLINK-9688) ATAN2 Sql Function support

2018-06-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-9688: - Priority: Minor (was: Major) > ATAN2 Sql Function support > -- > >

[jira] [Updated] (FLINK-9688) ATAN2 Sql Function support

2018-06-28 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-9688: - Issue Type: New Feature (was: Bug) > ATAN2 Sql Function support > -- > >

[jira] [Assigned] (FLINK-9682) Add setDescription to execution environment and display it in the UI

2018-06-28 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-9682: --- Assignee: vinoyang > Add setDescription to execution environment and display it in the UI >

[jira] [Updated] (FLINK-9688) ATAN2 Sql Function support

2018-06-28 Thread Sergey Nuyanzin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-9688: --- Description: simple query fails {code} ExecutionEnvironment env = ExecutionEnvironment.getExe

[jira] [Created] (FLINK-9688) ATAN2 Sql Function support

2018-06-28 Thread Sergey Nuyanzin (JIRA)
Sergey Nuyanzin created FLINK-9688: -- Summary: ATAN2 Sql Function support Key: FLINK-9688 URL: https://issues.apache.org/jira/browse/FLINK-9688 Project: Flink Issue Type: Bug Compon

[jira] [Closed] (FLINK-9580) Potentially unclosed ByteBufInputStream in RestClient#readRawResponse

2018-06-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-9580. --- Resolution: Fixed Fix Version/s: 1.5.1 1.6.0 master: b4574c9bb53987

[jira] [Closed] (FLINK-9629) Datadog metrics reporter does not have shaded dependencies

2018-06-28 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-9629. --- Resolution: Fixed Fix Version/s: 1.5.1 1.6.0 master: afcb513e21afae

  1   2   >