> -Original Message-
> From: Julian Calaby [mailto:julian.cal...@gmail.com]
> Sent: Saturday, August 5, 2017 8:51 AM
> To: Reizer, Eyal
> Cc: Kalle Valo; ,Tony Lindgren; linux-wireless@vger.kernel.org; linux-
> ker...@vger.kernel.org; sebastian.reic...@collabora.co.uk
> Subject: Re: [v4]
The following commits:
c815fde wlcore: spi: Populate config firmware data
d776fc8 wlcore: sdio: Populate config firmware data
Populated the nvs entry for wilink6 and wilink7 only while it is
still needed for wilink8 as well.
This broke user space backward compatibility when upgrading from older
ke
* Reizer, Eyal [170807 00:32]:
> The following commits:
> c815fde wlcore: spi: Populate config firmware data
> d776fc8 wlcore: sdio: Populate config firmware data
>
> Populated the nvs entry for wilink6 and wilink7 only while it is
> still needed for wilink8 as well.
> This broke user space backw
Hi Tony,
>
> * Reizer, Eyal [170807 00:32]:
> > The following commits:
> > c815fde wlcore: spi: Populate config firmware data
> > d776fc8 wlcore: sdio: Populate config firmware data
> >
> > Populated the nvs entry for wilink6 and wilink7 only while it is
> > still needed for wilink8 as well.
> >
From: Chung-Hsien Hsu
After association, ping is not working when sweeping the channel at the
AP side. It is caused by having incorrect carrier state (OFF) for the STA
in successful roaming. This patch sets the carrier state ON for the case.
Signed-off-by: Chung-Hsien Hsu
---
drivers/net/wirel
2.4GHz and the lower 5GHz band can now be use with up to 23dBm. But the DFS
channels in general require TPC to be usable. Only 5150 - 5250 has an
exception which allows the use of it without TPC when reducing the power to
20 dBm.
Signed-off-by: Sven Eckelmann
---
Please check this twice because t
Luca Coelho writes:
> Here are some pending mac80211 patches from our internal tree.
>
> The "mac80211: add api to start ba session timer expired flow" patch
> is needed by an iwlwifi patch that I want to send for -fixes, so it
> would have to be applied to -fixes as well.
We are getting to the
On Mon, 2017-08-07 at 12:06 +0300, Kalle Valo wrote:
> Luca Coelho writes:
>
> > Here are some pending mac80211 patches from our internal tree.
> >
> > The "mac80211: add api to start ba session timer expired flow" patch
> > is needed by an iwlwifi patch that I want to send for -fixes, so it
> >
Greetings from Mr. Abdul Karim.
Assalamu`Alaikum.
My Name is Mr. Abdul Karim I am a banker by profession. I'm from
Ouagadougou, Burkina Faso, West Africa. My reason for contacting you
is to transfer an abandoned $15.5M to your account.
The owner of this fund died since 2004 with his Next Of K
On 7/26/2017 10:25 PM, Ian Molton wrote:
All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.
Acked-by: Arend van Spriel
Signed-off-by: Ian Molton
---
drivers/net/wireless/broadcom/b
Hi Ian,
So it took me a while to get to this patch series. It is indeed way to
big and not well structured making it difficult to review the patches on
a per-patch basis.
I decided to limit myself to looking at the patches involving bcmsdh.c
doing a 'git log bcmsdh.c' on the applied patches.
On 26-07-17 22:25, Ian Molton wrote:
The 4 IO functions in this patch are incorrect as they use compiler types
to determine how many bytes to send to the hardware.
I see no incorrectness here. It is validating the regsz value and those
compiler types are pretty well defined I would say. Anyway,
On 26-07-17 22:25, Ian Molton wrote:
This function is obfuscating how IO works on this chip. Remove it
and push its logic into brcmf_sdiod_reg_{read,write}().
Handling of -ENOMEDIUM is altered, but as that's pretty much broken anyway
we can ignore that.
Please explain why you think it is broke
On 26-07-17 22:25, Ian Molton wrote:
The value passed to brcmf_sdiod_addrprep() is *always* 4
remove this parameter and the unused code to handle it.
Reviewed-by: Arend van Spriel
Signed-off-by: Ian Molton
---
.../net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 18 -
On 26-07-17 22:25, Ian Molton wrote:
Register access code is not the place for band-aid fixes like this.
If this is a genuine problem, it should be fixed further up in the driver
stack.
So lets make it a SDIO debug message for all register accesses getting
rid of the error message.
Reviewed-by
On 7/26/2017 10:25 PM, Ian Molton wrote:
Trivial cleanup of nasty variable name
Did not look, but here is...
Acked-by: Arend van Spriel
Signed-off-by: Ian Molton
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletion
On 7/26/2017 10:25 PM, Ian Molton wrote:
Unlikely to be a problem, but brcmf_sdiod_regrb() is
not symmetric with brcmf_sdiod_regrl() in this regard.
You are pretty keen on symmetry, but you could also remove the
initialization in brcmf_sdiod_regrl(). As long as no -Wunitialized pops
u
On 26-07-17 22:25, Ian Molton wrote:
This large function is concealing a LOT of obscure logic about
how the hardware functions. Time to split it up.
This first patch splits the function into two pieces - read and write,
doing away with the rw flag in the process.
I really don't this it
On 7/26/2017 10:25 PM, Ian Molton wrote:
If you need debugging this low level, you're doing something wrong.
Remove these noisy debug statements so the code is more readable.
Needing this debugging does not necessarily means you are doing
something wrong. You may be dealing with hardware that
On 7/26/2017 10:25 PM, Ian Molton wrote:
This function needs to be split up into separate read / write variants
for clarity.
Reviewed-by: Arend van Spriel
Signed-off-by: Ian Molton
more comments below...
# Conflicts:
# drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
---
On 7/26/2017 10:25 PM, Ian Molton wrote:
Primarily this patch removes:
brcmf_sdiod_f0_writeb()
brcmf_sdiod_reg_write()
brcmf_sdiod_reg_read()
Having [patch 30/34] "brcmfmac: Correctly handle accesses to SDIO func0"
before this patch could make this look cleaner.
Since we no longer use the
On 7/26/2017 10:25 PM, Ian Molton wrote:
This function has become trivial enough that it may as well be pushed into
its callers, which has the side-benefit of clarifying what's going on.
Remove it, and rename brcmf_sdiod_set_sbaddr_window() to
brcmf_sdiod_set_backplane_window() as it's easier to
On 8/7/2017 1:11 PM, Arend van Spriel wrote:
On 7/26/2017 10:25 PM, Ian Molton wrote:
All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.
Actually noticed a minor nit. The subject says
On 8/3/2017 11:37 AM, Wright Feng wrote:
brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/OPEN security mode
When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP security,
firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and
probe response. The security type in soft
On 8/3/2017 11:37 AM, Wright Feng wrote:
From: Chi-Hsien Lin
Add support for CYW4373 SDIO/USB chipset.
CYW4373 is a 1x1 dual-band 11ac chipset with 20/40/80Mhz channel support.
It's a WiFi/BT combo device.
Reviewed-by: Arend van Spriel
Signed-off-by: Chi-Hsien Lin
---
v2: add new chip(4737
So now I jump to this patch
On 7/26/2017 10:25 PM, Ian Molton wrote:
The IO functions operate within the Chipcommon IO window. Explicitly
set this, rather than relying on the last initialisation IO access to
leave it set to the right value by chance.
Signed-off-by: Ian Molton
---
drivers/ne
On 8/3/2017 11:37 AM, Wright Feng wrote:
brcmfmac: fix wrong num_different_channels when mchan feature enabled
When the device/firmware supports multi-channel, it can have P2P
connection and regular connection with AP simultaneous. In this case,
the num_different_channels in wiphy info was not c
"Reizer, Eyal" writes:
> The following commits:
> c815fde wlcore: spi: Populate config firmware data
> d776fc8 wlcore: sdio: Populate config firmware data
It's recommended to use 12 chars when abbreviating commit ids so the
format should be this:
c815fdebef44 wlcore: spi: Populate config firmwa
On 8/7/2017 10:16 AM, Wright Feng wrote:
From: Chung-Hsien Hsu
After association, ping is not working when sweeping the channel at the
AP side. It is caused by having incorrect carrier state (OFF) for the STA
in successful roaming. This patch sets the carrier state ON for the case.
This seems
Sergey Matyukevich writes:
>> > + if (timer_pending(&mac->scan_timeout))
>> > + del_timer_sync(&mac->scan_timeout);
>>
>> What if the device is removed while the timer is pending, is that
>> handled?
>
> Good point. I took another look at this kind of corner cases. Timer is not
Luca Coelho writes:
> From: Christophe Jaillet
>
> We should free 'wgds.pointer' here as done a few lines above in another
> error handling path.
> It was allocated within 'acpi_evaluate_object()'.
>
> Fixes: c52030a01ccc ("iwlwifi: mvm: add GEO_TX_POWER_LIMIT cmd for geographic
> tx power tabl
Luca Coelho writes:
> From: Avraham Stern
>
> Under DQA, when tx is deferred because a queue needs to be allocated,
> the mac queue for that TID is stopped until the new stream is added.
> If at this point the station that this stream belongs to is removed,
> all the deferred tx frames are purge
Luca Coelho writes:
> On Mon, 2017-08-07 at 12:06 +0300, Kalle Valo wrote:
>> Luca Coelho writes:
>>
>> > Here are some pending mac80211 patches from our internal tree.
>> >
>> > The "mac80211: add api to start ba session timer expired flow" patch
>> > is needed by an iwlwifi patch that I want
Luca Coelho writes:
> From: Chaya Rachel Ivgi
>
> In order to test the enter/exit CT-kill flow.
>
> Signed-off-by: Chaya Rachel Ivgi
> Signed-off-by: Luca Coelho
The commit log doesn't explain what's CT-kill and how/where it could be
used. For example, I have no clue what this could be about.
On Mon, 2017-08-07 at 15:57 +0300, Kalle Valo wrote:
> Luca Coelho writes:
>
> > From: Christophe Jaillet
> >
> > We should free 'wgds.pointer' here as done a few lines above in another
> > error handling path.
> > It was allocated within 'acpi_evaluate_object()'.
> >
> > Fixes: c52030a01ccc (
Luca Coelho writes:
> From: Haim Dreyfuss
>
> Support new version of beacon template command. This rplaces v8 command
typo: "rplaces"
--
Kalle Valo
On Mon, 2017-08-07 at 16:11 +0300, Kalle Valo wrote:
> Luca Coelho writes:
>
> > From: Chaya Rachel Ivgi
> >
> > In order to test the enter/exit CT-kill flow.
> >
> > Signed-off-by: Chaya Rachel Ivgi
> > Signed-off-by: Luca Coelho
>
> The commit log doesn't explain what's CT-kill and how/wh
Luca Coelho writes:
> On Mon, 2017-08-07 at 16:11 +0300, Kalle Valo wrote:
>> Luca Coelho writes:
>>
>> > From: Chaya Rachel Ivgi
>> >
>> > In order to test the enter/exit CT-kill flow.
>> >
>> > Signed-off-by: Chaya Rachel Ivgi
>> > Signed-off-by: Luca Coelho
>>
>> The commit log doesn't
Luca Coelho writes:
> On Mon, 2017-08-07 at 15:57 +0300, Kalle Valo wrote:
>> Luca Coelho writes:
>>
>> > From: Christophe Jaillet
>> >
>> > We should free 'wgds.pointer' here as done a few lines above in another
>> > error handling path.
>> > It was allocated within 'acpi_evaluate_object()'.
On Mon, 2017-08-07 at 16:37 +0300, Kalle Valo wrote:
> Luca Coelho writes:
>
> > On Mon, 2017-08-07 at 15:57 +0300, Kalle Valo wrote:
> > > Luca Coelho writes:
> > >
> > > > From: Christophe Jaillet
> > > >
> > > > We should free 'wgds.pointer' here as done a few lines above in another
> > >
Hi Dave,
here's the first pull request to net-next for 4.14, more info in the
signed tag below. This time there's a simple conflict in iwlwifi but
you can fix it just like Stephen did:
https://lkml.kernel.org/r/20170804120408.0d147...@canb.auug.org.au
Please let me know if you have any problems.
Set RX_FLAG_DECRYPTED in case of MMIC failure so that
ieee80211_rx_h_decrypt() doesnt drop the frame before getting to
ieee80211_rx_h_michael_mic_verify().
Signed-off-by: Michael Skeffington
---
drivers/net/wireless/ralink/rt2x00/rt2800mmio.c | 13 +++--
drivers/net/wireless/ralink/rt2x
Sorry about that, I work on other projects that use spaces and I must have
missed that when double checking the patch. I sent out a new patch with
the correct line length, removal of trailing '.' and indentation fix.
On Mon, Aug 7, 2017 at 2:31 AM, Stanislaw Gruszka wrote:
> On Thu, Aug 03, 2017
On 07/08/17 12:25, Arend van Spriel wrote:
> On 26-07-17 22:25, Ian Molton wrote:
>> This large function is concealing a LOT of obscure logic about
>> how the hardware functions. Time to split it up.
>>
>> This first patch splits the function into two pieces - read and write,
>> doing away with
On 07/08/17 12:25, Arend van Spriel wrote:
>> Handling of -ENOMEDIUM is altered, but as that's pretty much broken
>> anyway
>> we can ignore that.
>
> Please explain why you think it is broken.
Not got the code to hand right now, but from memory, theres a trapdoor
case where the state can wind up
On 07/08/17 12:26, Arend van Spriel wrote:
> On 7/26/2017 10:25 PM, Ian Molton wrote:
>> Primarily this patch removes:
>>
>> brcmf_sdiod_f0_writeb()
>> brcmf_sdiod_reg_write()
>> brcmf_sdiod_reg_read()
>
> Having [patch 30/34] "brcmfmac: Correctly handle accesses to SDIO func0"
> before this patch
From: Kalle Valo
Date: Mon, 07 Aug 2017 17:55:40 +0300
> here's the first pull request to net-next for 4.14, more info in the
> signed tag below. This time there's a simple conflict in iwlwifi but
> you can fix it just like Stephen did:
>
> https://lkml.kernel.org/r/20170804120408.0d147...@canb.
On 26-07-17 22:25, Ian Molton wrote:
> Trivial tidy of register definitions.
Initially skipped this one, but it is indeed trivial.
Reviewed-by: Arend van Spriel
> Signed-off-by: Ian Molton
comment below...
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.h | 11 ++-
> 1
+ linux-wireless
On 07-08-17 21:38, Paolo Bettini wrote:
> Hi , i am Paolo and i installed Debian stretch on my ezbook2 . One
> problem is the wifi , the card a SDIO device , seems to be 02d0:a9a6
> linux id or Broadcom AP6212 for windowsi installed deb package
> firmware-brcm80211 and nvram s
prism54 is deprecated in favor of the p54pci device driver. Although
only *one soul* had reported issues with it long ago Linux most Linux
distributions these days just disable the device driver given the
conflicts with the PCI IDs of p54pci and the *very* unlikely situation
of folks really need th
This will ensure I get emails on my work and personal email address.
Signed-off-by: Luis R. Rodriguez
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3deaddc8c578..997b8062397a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -
Greg,
This v2 adds the TODO you requested to clarify prism54 will be removed in
two kernel releases from now, and so no further cleanup is needed other
than to ensure the driver compiles.
This is based on linux-next tag next-20170807.
Luis
Luis R. Rodriguez (2):
wireless: move prism54 out
The latest low power radio frequency devices technical regulations [1]
released by Taiwan's regulatory body, NCC, opens up 57 GHz ~ 66 GHz to
most devices, including WiGig.
[1] LP0002 Low-power Radio-frequency Devices Technical Regulations 2016/8/23
http://www.ncc.gov.tw/english/show_file.aspx
Taiwan's Ministry of Transportation and Communications updated its
frequency allocation rules again on 2017/02/22. The amended articles
are not related to this database, but the link should be kept up to
date, as the old one is no longer accessible.
Taiwan's regulatory body, NCC, published its upd
* Reizer, Eyal [170807 00:47]:
> Hi Tony,
> >
> > * Reizer, Eyal [170807 00:32]:
> > > The following commits:
> > > c815fde wlcore: spi: Populate config firmware data
> > > d776fc8 wlcore: sdio: Populate config firmware data
> > >
> > > Populated the nvs entry for wilink6 and wilink7 only while
On Mon, Aug 07, 2017 at 12:47:36PM -0400, Michael Skeffingfon wrote:
> Set RX_FLAG_DECRYPTED in case of MMIC failure so that
> ieee80211_rx_h_decrypt() doesnt drop the frame before getting to
> ieee80211_rx_h_michael_mic_verify().
>
> Signed-off-by: Michael Skeffington
Acked-by: Stanislaw Gruszk
On 08/07/2017 8:27, Arend van Spriel wrote:
On 8/3/2017 11:37 AM, Wright Feng wrote:
From: Chi-Hsien Lin
Add support for CYW4373 SDIO/USB chipset.
CYW4373 is a 1x1 dual-band 11ac chipset with 20/40/80Mhz channel support.
It's a WiFi/BT combo device.
Reviewed-by: Arend van Spriel
Signed-o
57 matches
Mail list logo