[lng-odp] Flow aware scheduler

2018-05-17 Thread Bala Manoharan
Hi All, Below is the initial design draft for Flow aware scheduler. Pls review the document and provide your valuable feedback. https://docs.google.com/document/d/1HDHHxSMtHNWl9_ sWIVoKRaB4zdsb4hT-PKK6sUB708s/edit?usp=sharing Regards, Bala

Re: [lng-odp] Flow aware scheduler enhancement for ODP

2018-04-06 Thread Bala Manoharan
y the application. >> Once the application receives the incoming packet based on the HW generate >> flow he might switch the packet to a SW generated flow in the next phase >> which could be based on a hash generated from set of fields or a "tag" >> like >> SPI

Re: [lng-odp] Flow aware scheduler enhancement for ODP

2018-04-06 Thread Bala Manoharan
t of fields or a "tag" like SPI index. Regards, Bala > > On Fri, Apr 6, 2018 at 8:35 AM, Bala Manoharan > wrote: > > Hi, > > > > Based on the requirements from our customers, we have come across certain > > limitations in the current scheduler design, >

[lng-odp] Flow aware scheduler enhancement for ODP

2018-04-06 Thread Bala Manoharan
Hi, Based on the requirements from our customers, we have come across certain limitations in the current scheduler design, 1) Creating a huge number of odp_queue_t is very expensive operation since each queue contains a context and having millions of queues creates memory constraints in the platf

Re: [lng-odp] odp_packet_data() considered harmful

2018-02-15 Thread Bala Manoharan
This API is being supported in ODP for quite some time. The minimum header length in the pool is set by the applications and they are usually aware of the header length supported in the first segment. Hence applications calling this API should be aware that this will not contain the entire packet l

Re: [lng-odp] RSS in ODP

2018-01-12 Thread Bala Manoharan
re not destroyed. So I > assume either it should be done there, or the user is responsible for > retrieving and destroying those queues. > The queue created using this mechanism will have to be destroyed by the implementation. Application will not have to worry about these implementation crea

Re: [lng-odp] RSS in ODP

2018-01-04 Thread Bala Manoharan
hash_proto_t hash_proto; }; }; > > -- > Oriol Arcas > Software Engineer > Starflow Networks > > On Thu, Jan 4, 2018 at 5:11 PM, Bala Manoharan > wrote: > >> Hi, >> >> In addition configuring the hashing on the pktio interface as Petri >> suggested, you ca

Re: [lng-odp] RSS in ODP

2018-01-04 Thread Bala Manoharan
Hi, In addition configuring the hashing on the pktio interface as Petri suggested, you can also configure hashing on CoS. By configuring hashing on CoS, you can effectively configure hashing for a particular flow. Regards, Bala On 4 January 2018 at 20:51, Oriol Arcas wrote: > Bill, Petri, Bogd

Re: [lng-odp] ODP development process proposal

2017-12-27 Thread Bala Manoharan
My two cents I personally prefer Proposal 1, since it provides a single branch (api-next) which gives me a snapshot of the future of master branch. In case of proposal 2, let's say there are two different branches/PR for API changes in pktio and queue we will not know how they will look together

Re: [lng-odp] IPsec: handling dummy packets (NH=59)

2017-12-04 Thread Bala Manoharan
Hi, IMO We need to add the following enhancements to IPsec if we want to include handling of Dummy packets and TCP arbitrary padding Dummy packets = 1). We need to add bits in odp_ipsec_warn_t to indicate the reception of dummy packets so that when an IPsec implementation receives an

Re: [lng-odp] [EXT] Re: classifier with pktio in ODP_PKTIN_MODE_QUEUE

2017-11-10 Thread Bala Manoharan
packet with DST ip addr 10.10.x.x it will be delivered to queue1 (CoS1) and the application will have to call odp_queue_deq(queue1) to receive this packet. Regards, Bala > > Liron > > -Original Message- > From: Bala Manoharan [mailto:bala.manoha...@linaro.org] > Sent: Frid

Re: [lng-odp] [EXT] Re: classifier with pktio in ODP_PKTIN_MODE_QUEUE

2017-11-10 Thread Bala Manoharan
onfigured using odp_pktin_event_queue(). Packets delivered after classification can be received by application either using odp_queue_deq() or odp_schedule() function depending upon the dst_queue configured with CoS. Regards, Bala > > Liron > > -Original Message- > From: Bala

Re: [lng-odp] classifier with pktio in ODP_PKTIN_MODE_QUEUE

2017-11-09 Thread Bala Manoharan
Hi, Both these modes cannot co-exist. There is a parameter 'classifier_enable' and 'hash_enable' as part of odp_pktin_queue_param_t which is used to identify whether classifier or hashing is enabled for a particular pktio interface. Both classifier and hash configuration are orthogonal and only o

Re: [lng-odp] [Bug 2903] validation: add test case for PMR LD_VNI

2017-11-09 Thread Bala Manoharan
I was hoping my PR for RED will get in soon. I will work on this bug and get this in before TigerMoth. Regards, Bala On 9 November 2017 at 21:22, wrote: > https://bugs.linaro.org/show_bug.cgi?id=2903 > > --- Comment #10 from Bill Fischofer --- > Ping to Bala. Still on your to-do list? > > --

Re: [lng-odp] Latest odp_ipsec_sa_disable() discussion and proposed resolution

2017-10-23 Thread Bala Manoharan
Hi, I was on vacation and went through this mail thread just now. I wasn't sure where to inject my comments hence I am providing them at the top for clarity. 1). I am not a huge fan of the idea of starting a timer to perform the SA delete since calculating this timer's timeout will be an issue an

Re: [lng-odp] Let's remove odp_packet_unshared_len

2017-10-05 Thread Bala Manoharan
Hi, I would propose to remove this odp_packet_unshared_length(), from an implementation point of view this API will require additional software overhead as this feature is not inherently supported in the HW and there are concerns when creating multiple references. If we do not foresee any serious

Re: [lng-odp] [EXT] Re: odp_pktin_queue_param_t - classifier_enable & num_queues

2017-10-03 Thread Bala Manoharan
Yes. This is an implementation bug. Will fix the bug. Minor correction, when classifier_enabled is set the current design is to create all the queues in a single shot rather than as needed since it will create network jitter if queues are created at random. Regards, Bala On 3 October 2017 at 09:5

Re: [lng-odp] [EXT] Re: PKTIO and classification

2017-07-27 Thread Bala Manoharan
umentation as is setting "classifier_enable" is a mandatory field. I will update the test cases accordingly. Regards, Bala > > > Liron > > > > *From:* Bala Manoharan [mailto:bala.manoha...@linaro.org] > *Sent:* Thursday, July 27, 2017 04:48 > *To:* Liron Himi > *

Re: [lng-odp] PKTIO and classification

2017-07-26 Thread Bala Manoharan
On 26 July 2017 at 01:24, Liron Himi wrote: > Hi, > > I have a few questions/clarifications regarding classification in PKTIO: > > 1. As part of the 'odp_pktin_queue_param_t' application should set > 'classifier_enable' to '1' if classification support is wanted. Is that > correct? > > 2.

Re: [lng-odp] [API-NEXTv4 1/3] api: classification: add support for packet hashing in classification

2017-07-25 Thread Bala Manoharan
On 25 July 2017 at 16:17, Nikhil Agarwal wrote: > > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Balasubramanian Manoharan > Sent: Thursday, July 20, 2017 8:07 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXTv4 1/3] api: cla

Re: [lng-odp] [API-NEXTv4 1/3] api: classification: add support for packet hashing in classification

2017-07-25 Thread Bala Manoharan
Regards, Bala On 25 July 2017 at 06:51, Bill Fischofer wrote: > > > On Wed, Jul 19, 2017 at 9:37 PM, Balasubramanian Manoharan < > bala.manoha...@linaro.org> wrote: > >> Enable packet hashing per CoS to be able to distribute incoming packets to >> multiple queues linked with a CoS. >> >> Signed-

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: add warning status event

2017-07-17 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 14 July 2017 at 18:13, Petri Savolainen wrote: > Add status ID for warning messages. Outbound inline soft lifetime > expiration is currently the only source of these events. API spec > keeps simple when the same warning structure is shared with IPSEC >

Re: [lng-odp] [RFC/API-NEXTv3 1/3] api: classification: add support for packet hashing in classification

2017-07-14 Thread Bala Manoharan
On 14 July 2017 at 19:18, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > > Balasubramanian Manoharan > > Sent: Friday, July 14, 2017 12:12 PM > > To: lng-odp@lis

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

2017-07-14 Thread Bala Manoharan
On 14 July 2017 at 04:33, Bill Fischofer wrote: > > > On Thu, Jul 13, 2017 at 4:32 PM, Dmitry Eremin-Solenikov < > dmitry.ereminsoleni...@linaro.org> wrote: > >> On 13.07.2017 21:20, Bill Fischofer wrote: >> > On Thu, Jul 13, 2017 at 12:58 PM, Bala Manoharan &

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

2017-07-13 Thread Bala Manoharan
On 13 July 2017 at 16:25, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > > Github ODP bot > > Sent: Wednesday, July 12, 2017 5:00 PM > > To: lng-odp@lists.linaro

Re: [lng-odp] [API-NEXT PATCH v3 1/9] api: ipsec: add salt parameter

2017-07-13 Thread Bala Manoharan
For the series: Reviewed-by: Balasubramanian Manoharan On 12 July 2017 at 19:24, Petri Savolainen wrote: > Added a parameter for passing salt/nonce for algorithms that > need it. Currently, only AES GCM needs it with 4 bytes of > salt. Later on, other cipher (or auth) algorithms may need > als

Re: [lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: add retain header capability

2017-07-13 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 13 July 2017 at 15:13, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > Reviewed-by: Petri Savolainen > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > > Github ODP bot

Re: [lng-odp] [PATCH API-NEXT v8 3/10] api: crypto: drop async mode support

2017-07-12 Thread Bala Manoharan
On 11 July 2017 at 18:24, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > > Github ODP bot > > Sent: Wednesday, July 05, 2017 5:00 PM > > To: lng-odp@lists.linaro

Re: [lng-odp] [API-NEXT PATCH v3] api: pool: additional packet length configuration

2017-06-27 Thread Bala Manoharan
Regards, Bala On 15 June 2017 at 19:51, Petri Savolainen wrote: > Added packet pool parameters for more fine grained pool > configuration. The basic usage of the parameters is not changed, > except that implementation may now round up 'num' by default. > Application can limit the round up with n

Re: [lng-odp] [API-NEXT PATCH v3 0/3] IPSEC packet event

2017-06-21 Thread Bala Manoharan
For the series: Reviewed-by: Balasubramanian Manoharan On 16 June 2017 at 16:19, Petri Savolainen wrote: > Applies on top of: "[API-NEXT PATCH v2 0/2] IPsec API update" > > Input and output of IPSEC operations are packets. Parameter and > result structures are cleaner when packet arrays are dir

Re: [lng-odp] [RFC/API-NEXT] api: schedule: add ordered context unlock-lock

2017-06-16 Thread Bala Manoharan
On 16 June 2017 at 21:14, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > Can you please explain the use case for this API? > > We already have odp_schedule_order_unlock and odp_schedule_order_lock. > These APIs can be used to do the same operation. > Yes. This API can be interna

Re: [lng-odp] [RFC/API-NEXT] api: schedule: add ordered context unlock-lock

2017-06-16 Thread Bala Manoharan
Regards, Bala On 16 June 2017 at 19:42, Bill Fischofer wrote: > On Fri, Jun 16, 2017 at 6:21 AM, Balasubramanian Manoharan > wrote: > > Adds api to release an existing ordered lock and acquire a new lock. > > > > Signed-off-by: Balasubramanian Manoharan > > --- > > include/odp/api/spec/schedu

Re: [lng-odp] Mem pool creation in Cavium/NXP implementations

2017-06-15 Thread Bala Manoharan
Regards, Bala On 15 June 2017 at 23:20, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > On 15 June 2017 at 10:58, Bala Manoharan > wrote: > > On 15 June 2017 at 20:00, Francois Ozog > wrote: > > > >> I wonder then how packet receive in

Re: [lng-odp] Mem pool creation in Cavium/NXP implementations

2017-06-15 Thread Bala Manoharan
> > FF > > On 15 June 2017 at 15:42, Bala Manoharan > wrote: > >> Add on. It is also possible that the pool might not be linked to any pktio >> eg buffer pools, hence in implementation we can not wait for the pool to >> be >> linked to pktio. >>

Re: [lng-odp] Mem pool creation in Cavium/NXP implementations

2017-06-15 Thread Bala Manoharan
t; opportunity the implementation has to fail the pool creation in a > defined manner. > > On Thu, Jun 15, 2017 at 2:29 AM, Bala Manoharan > wrote: > > Same here. Pool is created during odp_pool_create API. > > > > > > Regards, > > Bala > > > > O

Re: [lng-odp] Mem pool creation in Cavium/NXP implementations

2017-06-15 Thread Bala Manoharan
Same here. Pool is created during odp_pool_create API. Regards, Bala On 15 June 2017 at 12:36, Nikhil Agarwal wrote: > Pool is created at odp_pool_create only. You can allocate packets form it > even before pktio_open. > > Regards > Nikhil > > -Original Message- > From: lng-odp [mailto

Re: [lng-odp] [RFC] api: classification: add random early discard

2017-06-13 Thread Bala Manoharan
On 13 June 2017 at 04:10, Bill Fischofer wrote: > On Mon, Jun 12, 2017 at 6:41 AM, Balasubramanian Manoharan > wrote: > > Add random early discard configuration to class-of-service > > > > Signed-off-by: Balasubramanian Manoharan > > --- > > include/odp/api/spec/classification.h | 44 > +++

Re: [lng-odp] [API-NEXT PATCH v2 0/2] IPsec API update

2017-06-09 Thread Bala Manoharan
For the series: Reviewed-by: Balasubramanian Manoharan

Re: [lng-odp] [RFC] api: pool: add threshold limit to the pool

2017-06-05 Thread Bala Manoharan
Regards, Bala On 5 June 2017 at 21:52, Bill Fischofer wrote: > On Mon, Jun 5, 2017 at 8:24 AM, Bala Manoharan > wrote: >> Regards, >> Bala >> >> >> On 5 June 2017 at 18:24, Bill Fischofer wrote: >>> On Mon, Jun 5, 2017 at 7:32 AM, Stanisla

Re: [lng-odp] [RFC] api: pool: add threshold limit to the pool

2017-06-05 Thread Bala Manoharan
Regards, Bala On 5 June 2017 at 18:24, Bill Fischofer wrote: > On Mon, Jun 5, 2017 at 7:32 AM, Stanislaw Kardach wrote: >> >> >> Best Regards, >> Stanislaw Kardach >> >> On 06/05/2017 02:27 PM, Balasubramanian Manoharan wrote: >>> Adds threshold limit of the pool to the pool parameters. >>> Thi

Re: [lng-odp] [RFC] api: pool: add threshold limit to the pool

2017-06-05 Thread Bala Manoharan
Regards, Bala On 5 June 2017 at 18:42, Stanislaw Kardach wrote: > > > Best Regards, > Stanislaw Kardach > > On 06/05/2017 02:54 PM, Bill Fischofer wrote: >> On Mon, Jun 5, 2017 at 7:32 AM, Stanislaw Kardach wrote: >>> >>> >>> Best Regards, >>> Stanislaw Kardach >>> >>> On 06/05/2017 02:27 PM, B

Re: [lng-odp] [RFC] api: pool: add threshold limit to the pool

2017-06-05 Thread Bala Manoharan
Regards, Bala On 5 June 2017 at 18:02, Stanislaw Kardach wrote: > > > Best Regards, > Stanislaw Kardach > > On 06/05/2017 02:27 PM, Balasubramanian Manoharan wrote: >> Adds threshold limit of the pool to the pool parameters. >> This threshold limit is a percentage of total size of the pool. >> >

Re: [lng-odp] [RFC API-NEXT PATCH] api: init: add unused feature hints to init struct

2017-05-31 Thread Bala Manoharan
On 31 May 2017 at 14:03, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> diff --git a/include/odp/api/spec/init.h b/include/odp/api/spec/init.h > > I think it's better to have a new file for this (feature.h). It may be needed > also in other parts (of implementation) than init. > > >> index 154c

Re: [lng-odp] [PATCH API-NEXT v5 1/1] api: crypto: add odp_crypto_session_create2 returning odp_crypto_session_t

2017-05-30 Thread Bala Manoharan
On 30 May 2017 at 21:24, Dmitry Eremin-Solenikov wrote: > On 30 May 2017 at 18:30, Bala Manoharan wrote: >> On 30 May 2017 at 20:46, Dmitry Eremin-Solenikov >> wrote: >>> On 30 May 2017 at 18:06, Bala Manoharan wrote: >>>> On 30 May 2017 at 20:30, Githu

Re: [lng-odp] [PATCH API-NEXT v5 1/1] api: crypto: add odp_crypto_session_create2 returning odp_crypto_session_t

2017-05-30 Thread Bala Manoharan
On 30 May 2017 at 20:46, Dmitry Eremin-Solenikov wrote: > On 30 May 2017 at 18:06, Bala Manoharan wrote: >> On 30 May 2017 at 20:30, Github ODP bot wrote: >>> From: Dmitry Eremin-Solenikov >>> >>> Currently odp_crypto_session_create() (unlike other creati

Re: [lng-odp] [PATCH API-NEXT v5 1/1] api: crypto: add odp_crypto_session_create2 returning odp_crypto_session_t

2017-05-30 Thread Bala Manoharan
On 30 May 2017 at 20:30, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov > > Currently odp_crypto_session_create() (unlike other creation functions) > returns int result with session being returned through pointer argument. > Replace it with odp_crypto_session_create2 directly returning a s

Re: [lng-odp] [API-NEXT PATCHv4] api: crypto: change iv_len field to feature min-max len

2017-05-19 Thread Bala Manoharan
Regards, Bala On 19 May 2017 at 07:23, Balakrishna Garapati wrote: > dpdk pmd's require to minatain min, max, inc fields for all > crypto capabilitites. By making iv_len to feature like dpdk pmd's > it is easier to create cipher entires in odp based on key_len. > > Signed-off-by: Balakrishna Gar

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api: ipsec: add AH capability

2017-05-10 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 10 May 2017 at 12:00, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov > > RFC4301 marks AH support as MAY instead of MUST. Some platforms might > skip implementing AH. Thus we should provide capability to allow > applications to check if AH is act

Re: [lng-odp] odp_packet_free_multi with invalid packets

2017-05-10 Thread Bala Manoharan
On 10 May 2017 at 11:00, Dmitry Eremin-Solenikov wrote: > On 10.05.2017 20:57, Maxim Uvarov wrote: >> On 05/10/2017 08:14 PM, Dmitry Eremin-Solenikov wrote: >>> On 10.05.2017 20:13, Savolainen, Petri (Nokia - FI/Espoo) wrote: > -Original Message- > From: lng-odp [mailto:lng-od

Re: [lng-odp] [PATCH API-NEXT v2 3/5] api: ipsec: add soft limit expiration event

2017-05-10 Thread Bala Manoharan
if you send them to a specific control core/queue then it would cause a bottleneck. IMO it is better to have them as part of the packet result. Regards, Bala > > On 9 May 2017 at 21:37, Bala Manoharan wrote: >> On 9 May 2017 at 00:04, Bogdan Pricope wrote: >>> Hi, >&

Re: [lng-odp] [PATCH API-NEXT v2 3/5] api: ipsec: add soft limit expiration event

2017-05-09 Thread Bala Manoharan
On 9 May 2017 at 00:04, Bogdan Pricope wrote: > Hi, > > Can we have this event for all cases: sync/async/inline, > inbound/outbound, soft/hard limits? Lifetime expiration is destined to > control part of the application... we should be able to process it on > a different thread/queue. In the othe

Re: [lng-odp] [PATCH 3/3] linux-generic: classification: implement packet hashing in classifier

2017-05-04 Thread Bala Manoharan
Regards, Bala On 3 May 2017 at 18:15, Peltonen, Janne (Nokia - FI/Espoo) wrote: > Hi, > >> @@ -846,11 +897,91 @@ int cls_classify_packet(pktio_entry_t *entry, const >> uint8_t *base, >> >> *pool = cos->s.pool; >> pkt_hdr->p.input_flags.dst_queue = 1; >> - pkt_hdr->dst_queue = co

Re: [lng-odp] Traffic Manager no applying policies?

2017-05-03 Thread Bala Manoharan
eed of transmission. Regards, Bala > > -- > Oriol Arcas > Software Engineer > Starflow Networks > > On Tue, May 2, 2017 at 5:27 PM, Bala Manoharan > wrote: >> >> Can you please share the code as to how are you enqueing packets to >> odp_tm_queue() are you creating pa

Re: [lng-odp] Traffic Manager no applying policies?

2017-05-02 Thread Bala Manoharan
Can you please share the code as to how are you enqueing packets to odp_tm_queue() are you creating packets of same size? I would like to know how these packets are enqueued to these 3 queues? Regards, Bala On 2 May 2017 at 18:50, Oriol Arcas wrote: > Bill, Barry, Bala, > > I've been thinking a

Re: [lng-odp] IPsec SA disabling

2017-04-28 Thread Bala Manoharan
On 28 April 2017 at 18:32, Dmitry Eremin-Solenikov wrote: > On 28.04.2017 15:32, Bala Manoharan wrote: >> On 28 April 2017 at 15:41, Dmitry Eremin-Solenikov >> wrote: >>> On 28.04.2017 12:27, Peltonen, Janne (Nokia - FI/Espoo) wrote: >>>> Hi, >>>>

Re: [lng-odp] IPsec SA disabling

2017-04-28 Thread Bala Manoharan
On 28 April 2017 at 15:41, Dmitry Eremin-Solenikov wrote: > On 28.04.2017 12:27, Peltonen, Janne (Nokia - FI/Espoo) wrote: >> Hi, >> >>> -Original Message- >>> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Dmitry >>> Eremin- >>> Solenikov >>> Sent: Friday, April 28,

Re: [lng-odp] [PATCH v4] linux-generic: crypto: properly handle errors in packet copy

2017-04-24 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan > On 25-Apr-2017, at 4:56 AM, Bill Fischofer wrote: > > On Mon, Apr 24, 2017 at 9:46 AM, Dmitry Eremin-Solenikov < > dmitry.ereminsoleni...@linaro.org> wrote: > >> Add proper handling for errors returned by odp_packet_copy_from_pkt(). >> >> Signed-off-b

Re: [lng-odp] [PATCH v3] linux-generic: crypto: properly handle errors in packet copy

2017-04-23 Thread Bala Manoharan
Regards, Bala On 22 April 2017 at 22:15, Dmitry Eremin-Solenikov wrote: > Add proper handling for errors returned by odp_packet_copy_from_pkt(). > > Signed-off-by: Dmitry Eremin-Solenikov > --- > platform/linux-generic/odp_crypto.c | 22 +++--- > 1 file changed, 19 insertions(+

Re: [lng-odp] shmem pool APIs

2017-04-20 Thread Bala Manoharan
On 21 April 2017 at 02:05, Honnappa Nagarahalli wrote: > On 20 April 2017 at 13:54, Bill Fischofer wrote: >> >> On Thu, Apr 20, 2017 at 12:26 PM, Honnappa Nagarahalli >> wrote: >>> >>> Hi, >>>I looked at the shmem pool APIs for allocating smaller chunks of >>> shared memory. Following are th

Re: [lng-odp] [API-NEXT PATCH 1/4] api: pool: add maximum packet counts to pool info

2017-04-18 Thread Bala Manoharan
Regards, Bala On 12 April 2017 at 18:28, Matias Elo wrote: > Add fields to odp_pool_info_t for maximum number of packets of any length, > maximum number of minimum length packets, and maximum number of maximum > length packets. > > odp_pool_param_t documentation is updated to reflect these new f

Re: [lng-odp] [API-NEXT v3] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 15 April 2017 at 07:18, Dmitry Eremin-Solenikov wrote: > Instead of having magic 0-1-2 numbers, let's have the special enum for > feature support levels (unsupported/supported/preferred). > > Signed-off-by: Dmitry Eremin-Solenikov > --- > include/odp/

Re: [lng-odp] [API-NEXT v2] api: feature: factor out definitions for feature support levels

2017-04-14 Thread Bala Manoharan
> On 14-Apr-2017, at 11:28 PM, Bill Fischofer wrote: > > On Fri, Apr 14, 2017 at 11:28 AM, Dmitry Eremin-Solenikov > wrote: >> Instead of having magic 0-1-2 numbers, let's have the special enum for >> feature support levels (unsupported/supported/preferred). >> >> Signed-off-by: Dmitry Eremin

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bala Manoharan
Regards, Bala On 14 April 2017 at 16:52, Bill Fischofer wrote: > On Fri, Apr 14, 2017 at 5:58 AM, Dmitry Eremin-Solenikov > wrote: >> Instead of having magic 0-1-2 numbers, let's have the special enum for >> feature support levels (unsupported/supported/preferred). >> >> Signed-off-by: Dmitry E

Re: [lng-odp] [API-NEXT PATCH v4 1/2] api: queue: added queue size param

2017-04-13 Thread Bala Manoharan
For the series: Reviewed-by: Balasubramanian Manoharan > On 13-Apr-2017, at 9:13 PM, Honnappa Nagarahalli > wrote: > > For this series: Reviewed-by: Honnappa Nagarahalli > > >> On 13 April 2017 at 10:14, Bill Fischofer wrote: >> For this series: Reviewed-by: Bill Fischofer >> >> This sho

Re: [lng-odp] [PATCH v3 1/2] api: queue: added queue size param

2017-04-12 Thread Bala Manoharan
Regards, Bala On 3 April 2017 at 15:41, Petri Savolainen wrote: > Added capability information about maximum number of queues > and queue sizes. Both are defined per queue type, since > plain and scheduled queues may have different implementations > (e.g. one uses HW while the other is SW). > >

Re: [lng-odp] [PATCH 1/2] add queue size param and related capability

2017-04-11 Thread Bala Manoharan
Regards, Bala On 12 April 2017 at 10:05, Honnappa Nagarahalli wrote: > On 11 April 2017 at 05:51, Bala Manoharan wrote: >> On 10 April 2017 at 21:47, Honnappa Nagarahalli >> wrote: >>> Hi Bala, >>> Continuing the discussion from the call, as I mentioned

Re: [lng-odp] [PATCH 1/2] add queue size param and related capability

2017-04-11 Thread Bala Manoharan
On 10 April 2017 at 21:47, Honnappa Nagarahalli wrote: > Hi Bala, > Continuing the discussion from the call, as I mentioned in the > call today, the queues need to hold all kinds of events and not just > packets. The events need not be defined by ODP (like timeout events) > also. The applicati

Re: [lng-odp] [RFC/API-NEXT 1/1] api: classification: packet hashing per class of service

2017-04-06 Thread Bala Manoharan
Hi Bill, I will post a patch implementing this proposal next week. Regards, Bala On 6 April 2017 at 18:07, Bill Fischofer wrote: > Bala, any idea when this can advance from the RFC stage to a real patch? > > On Thu, Apr 6, 2017 at 6:15 AM, Bala Manoharan > wrote: >>

Re: [lng-odp] [RFC/API-NEXT 1/1] api: classification: packet hashing per class of service

2017-04-06 Thread Bala Manoharan
Regards, Bala On 6 April 2017 at 00:53, Brian Brooks wrote: > On Fri, Dec 9, 2016 at 5:54 AM, Balasubramanian Manoharan > wrote: >> Adds support to spread packet from a single CoS to multiple queues by >> configuring hashing at CoS level. >> >> Signed-off-by: Balasubramanian Manoharan >> --- >

Re: [lng-odp] [API-NEXT PATCH v4 1/3] api: ipsec: extend lookaside API

2017-04-03 Thread Bala Manoharan
For this series: Reviewed-by: Balasubramanian Manoharan On 30 March 2017 at 15:59, Petri Savolainen wrote: > Added configuration option for inbound SPI range (for > lookups). Removed unique SPI requirement and added config > option for overlap. Added default queue for lookup misses. > Added SA

Re: [lng-odp] [API-NEXT PATCH] api: packet: add per packet checksum control

2017-04-03 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 28 March 2017 at 16:37, Petri Savolainen wrote: > Checksum insertion has pktio interface level configuration > options. Per packet override is needed for example when > L4 checksumming is enabled and application forwards packets. > Forwarded packets nee

Re: [lng-odp] [API-NEXT PATCH v2 2/3] api: ipsec: add inline IPSEC support

2017-03-23 Thread Bala Manoharan
n "enable_lookup" per SA which when disabled will remove the SA from any lookup and we can configure the lookup mode as a global configuration. Regards, Bala > > Janne > > >> -Original Message- >> From: lng-odp [mailto:lng-odp-boun...@lis

Re: [lng-odp] [API-NEXT PATCH v2 2/3] api: ipsec: add inline IPSEC support

2017-03-23 Thread Bala Manoharan
Regards, Bala On 23 March 2017 at 17:40, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> > >> > /** >> > @@ -381,11 +547,29 @@ typedef enum odp_ipsec_lookup_mode_t { >> > ODP_IPSEC_LOOKUP_DISABLED = 0, >> > >> > /** Inbound SA lookup is enabled. Used SPI values must be >> unique.

Re: [lng-odp] [API-NEXT PATCH v2 2/3] api: ipsec: add inline IPSEC support

2017-03-23 Thread Bala Manoharan
Regards, Bala On 23 March 2017 at 17:32, Nikhil Agarwal wrote: > Few initial comments: > > - For Mixing inline and async processing must maintain same SA context in HW > and implementation. In that case, we should shift to async SA creation so > that while creating an SA, HWinterface can r

Re: [lng-odp] [API-NEXT PATCH v2 2/3] api: ipsec: add inline IPSEC support

2017-03-23 Thread Bala Manoharan
Regards, Bala On 21 March 2017 at 19:47, Petri Savolainen wrote: > > Added support for inline IPSEC processing on packet input and > output. Inline mode IPSEC and traffic manager cannot be enabled > (currently) on the same pktio interface. > > Signed-off-by: Petri Savolainen > --- > include/odp

Re: [lng-odp] [API-NEXT PATCH v2 1/3] api: ipsec: extend lookaside API

2017-03-23 Thread Bala Manoharan
Regards, Bala On 21 March 2017 at 19:47, Petri Savolainen wrote: > Added configuration option for inbound SPI range and default > queue. Added SA disable function and status event for the > response from it. The same event may be used for e.g. IPSEC > statistics, etc queries. Improved outbound f

Re: [lng-odp] [RFC, API-NEXT v1 1/1] comp:compression interface

2017-03-21 Thread Bala Manoharan
Hi, This proposal supports both sync and async compression offload in a single API following the crypto model, IMO We can separate SYNC and ASYNC compression offload as two different APIs and only add ASYNC compression offload in the first version and if required we can add SYNC compression mode a

Re: [lng-odp] Regarding Chained Buffers and Crypto

2017-03-16 Thread Bala Manoharan
gment APIs documented in packet.h file to access the packet. Regards, Bala > > Regards, > {Nanda] > > > > On Thu, 16 Mar 2017 at 15:51 Verma, Shally > wrote: > >> Have a question by chained , do you mean a "Segmented" packets? >> >> ---

Re: [lng-odp] Regarding Chained Buffers and Crypto

2017-03-16 Thread Bala Manoharan
egards, Bala > > On Thu, 16 Mar 2017 at 14:01 Bala Manoharan > wrote: > >> >> On 15 March 2017 at 18:42, Nanda Gopal wrote: >> >> *Hi,* >> >> >> >> *When we pass, odp_crypto_op_params_tparams to odp_crypto_operation >> >&g

Re: [lng-odp] Regarding Chained Buffers and Crypto

2017-03-16 Thread Bala Manoharan
On 15 March 2017 at 18:42, Nanda Gopal wrote: > *Hi,* > > > > *When we pass, odp_crypto_op_params_tparams to odp_crypto_operation > (), as per the documentation, if we set params-> out_pkt to INVALID, a new > pkt would be created from the original pkt pool, data copied from original > pkt a

Re: [lng-odp] ABI and deprecated API flag

2017-03-14 Thread Bala Manoharan
On 15 March 2017 at 09:35, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > On 14 March 2017 at 17:18, Bill Fischofer > wrote: > > > > > > On Tue, Mar 14, 2017 at 4:02 PM, Honnappa Nagarahalli > > wrote: > >> > >> On 14 March 2017 at 14:41, Dmitry Eremin-Solenikov > >> wrote: >

Re: [lng-odp] [PATCH] validation: packet: do not require a max packet length

2017-03-13 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan mailto:bala.manoha...@linaro.org>> > On 13-Mar-2017, at 7:32 PM, Bill Fischofer wrote: > > Address bug https://bugs.linaro.org/show_bug.cgi?id=2908 by checking > the pool capability max packet length and modifying the test in > test_extend_ref() to account

[lng-odp] IPsec inline offload proposal

2017-03-06 Thread Bala Manoharan
Hi, Pls find the architecture document for IPsec inline offload proposal. https://docs.google.com/a/linaro.org/document/d/1vwOGNHJcRSiQaHgyRrKhlGxgEw9156Dnna8AmXA7G5k/edit?usp=sharing Regards, Bala

Re: [lng-odp] [PATCH v2 1/2] linux-gen: ipc: use hdr to handle conversion function

2017-03-01 Thread Bala Manoharan
For the series: Reviewed-by: Balasubramanian Manoharan On 1 March 2017 at 14:57, Petri Savolainen wrote: > Use conversion function instead of casting. > > Signed-off-by: Petri Savolainen > --- > platform/linux-generic/include/odp_packet_internal.h | 5 + > platform/linux-generic/odp_packet

Re: [lng-odp] [API-NEXT PATCH 1/2] validation: packet: increase test pool size

2017-02-26 Thread Bala Manoharan
Regards, Bala On 24 February 2017 at 21:43, Matias Elo wrote: > Previously packet_test_concatsplit() could fail on some pool > implementations as the pool ran out of buffers. Increase default pools size > and use capability to make sure the value is valid. > > Signed-off-by: Matias Elo > --- >

Re: [lng-odp] [EXT] Re: ODP crypto support with HW offload

2017-02-21 Thread Bala Manoharan
to API to use the same approach as single? > > Thanks > Dima > > > -Original Message- > From: Bala Manoharan [mailto:bala.manoha...@linaro.org] > Sent: Thursday, February 16, 2017 4:17 PM > To: Dmitri Epshtein > Cc: lng-odp-forward; Nir Erez; Mike Holmes > S

Re: [lng-odp] [EXT] Re: ODP crypto support with HW offload

2017-02-16 Thread Bala Manoharan
On 16 February 2017 at 13:31, Dmitri Epshtein wrote: > Hello, > > As part of action items from previous meeting I am going to suggest crypto > APIs with burst support. > > But before I would like to confirm my understanding of existing > odp_crypto_operation() API definition > > int odp_cryp

Re: [lng-odp] Packet references API

2017-02-09 Thread Bala Manoharan
On 9 February 2017 at 21:02, Savolainen, Petri (Nokia - FI/Espoo) wrote: > Hi, > > I still think that packet ref API should be defined so that an implementation > may fall back to doing packet copy instead of reference to shared data (if it > simply cannot handle packets by reference). Now after

Re: [lng-odp] [EXT] Re: ODP crypto support with HW offload

2017-02-07 Thread Bala Manoharan
Hi Dmitri, Pls see inline.. Regards, Bala On 7 February 2017 at 16:46, Dmitri Epshtein wrote: > Hi Bala, > > See inline > > Thanks > Dima > > -Original Message- > From: Bala Manoharan [mailto:bala.manoha...@linaro.org] > Sent: Tuesday, February 07, 2017

Re: [lng-odp] [EXT] Re: ODP crypto support with HW offload

2017-02-07 Thread Bala Manoharan
Regards, Bala On 6 February 2017 at 18:08, Dmitri Epshtein wrote: > Hi, > > There are two issues in current odp_crypto APIs (file > $ODP_DIR/include/odp/api/spec/crypto.h) > > 1. No support batch/burst for crypto operations > 2. No support crypto results polling by application in case

Re: [lng-odp] pktio: enable_loop

2017-01-24 Thread Bala Manoharan
Regards, Bala On 25 January 2017 at 13:07, Nicolas Morey-Chaisemartin wrote: > > Le 01/24/2017 à 06:11 PM, Bala Manoharan a écrit : >> On 24 January 2017 at 22:25, Nicolas Morey-Chaisemartin >> wrote: >>> Just a quick question about the API. >>> >>

Re: [lng-odp] pktio: enable_loop

2017-01-24 Thread Bala Manoharan
On 24 January 2017 at 22:25, Nicolas Morey-Chaisemartin wrote: > Just a quick question about the API. > > Bala introduced a patch to check/enable loopback mode on interface. > But the patch adds an "enable_loop" in odp_pktio_config_t and a > "loop_supported" in odp_pktio_capability_t. > > As ther

Re: [lng-odp] ODP installation issues on Cavium ThunderX

2017-01-19 Thread Bala Manoharan
Hi, ODP Cavium implementation has not been publicly released. Regards, Bala On 19 January 2017 at 22:23, Mike Holmes wrote: > > > On 19 January 2017 at 11:43, Gyanesh Patra > wrote: > >> There is no link available for the "Cavium implementation" by Support >> Account on the ODP download page.

Re: [lng-odp] [PATCH] example: introducing multi-threaded traffic management case

2017-01-17 Thread Bala Manoharan
There is a lot of code duplication in this example rom example/traffic_mgmt/odp_traffic_mgmt.c file. Maybe the common code should be moved or we should reduce the scope of this example. Regards, Bala On 19 December 2016 at 11:31, wrote: > From: Xuelin Shi > > introduce a new example of traffi

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: packet transformation follows RFCs

2017-01-12 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 13 January 2017 at 11:58, Nikhil Agarwal wrote: > Reviewed-by: Nikhil Agarwal > > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Petri > Savolainen > Sent: Thursday, January 12, 2017 8:16 PM > To: lng-

Re: [lng-odp] [PATCH] test: perf: add assert since src_idx cannot be negative

2017-01-11 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 22 December 2016 at 18:13, Bill Fischofer wrote: > Address Bug https://bugs.linaro.org/show_bug.cgi?id=2790 by adding an > assert. odp_packet_input_index() only returns a negative value if the > packet did not originate on an I/O interface, which is know

Re: [lng-odp] [API-NEXT PATCHv6 1/5] api: packet: add support for packet references

2017-01-09 Thread Bala Manoharan
Except for the Minor documentation comment below Reviewed-by: Balasubramanian Manoharan On 5 January 2017 at 20:25, Bill Fischofer wrote: > Introduce three new APIs that support efficient sharing of portions of > packets. > > odp_packet_ref_static() creates an alias for a base packet > > odp_pa

Re: [lng-odp] [API-NEXT PATCHv4 1/5] api: packet: add support for packet references

2017-01-04 Thread Bala Manoharan
Regards, Bala On 3 January 2017 at 20:02, Bill Fischofer wrote: > On Tue, Jan 3, 2017 at 8:14 AM, Bala Manoharan > wrote: >> Regards, >> Bala >> >> >> On 2 January 2017 at 05:10, Bill Fischofer wrote: >>> Introduce three new APIs that support

Re: [lng-odp] [API-NEXTv2 1/1] api: pktio: adds further definition for classification configuration

2016-12-23 Thread Bala Manoharan
This patch got lost somehow. Pls review the same. Regards, Bala On 4 November 2016 at 23:04, Balasubramanian Manoharan wrote: > Updates classification configuration documentation. > > Signed-off-by: Balasubramanian Manoharan > --- > v2: Incorporates review comments > include/odp/api/spec/pack

Re: [lng-odp] [API-NEXT PATCH 1/7] api: packet: src and dst packet must not be the same

2016-12-23 Thread Bala Manoharan
Reviewed-by: Balasubramanian Manoharan On 22 December 2016 at 20:03, Petri Savolainen wrote: > Concat and copy_from_pkt operations must be called with src and > dst packet handles which refer to the same packet. > > Signed-off-by: Petri Savolainen > --- > include/odp/api/spec/packet.h | 6

  1   2   3   4   5   6   >