[RESEND PATCH] BNX2I - Bug fixes related to MTU change issue when there are active iscsi sessions

2010-04-08 Thread Anil Veerabhadrappa
de when driver timed out waiting for TCP connect request to complete Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i.h |2 ++ drivers/scsi/bnx2i/bnx2i_init.c | 13 - drivers/scsi/bnx2i/bnx2i_iscsi.c | 13 ++--- 3 files changed, 24 insert

Re: PATCH] BNX2I : Bug fixes related to MTU change issue when there are active iscsi sessions

2010-04-08 Thread Anil Veerabhadrappa
On Thu, 2010-04-08 at 15:31 -0700, Mike Christie wrote: > On 04/08/2010 04:16 PM, Anil Veerabhadrappa wrote: > > + /* Wait for all endpoints to be torn down, Chip will be reset once > > +* control returns to network driver. So it is required to cleanup and > > +* r

PATCH] BNX2I : Bug fixes related to MTU change issue when there are active iscsi sessions

2010-04-08 Thread Anil Veerabhadrappa
out waiting for TCP connect request to complete. This was also discovered while debugging MTU change issue Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i.h |2 ++ drivers/scsi/bnx2i/bnx2i_init.c | 13 - drivers/scsi/bnx2i/bnx2i_iscsi.c |

[PATCH 3/3] [BNX2I] update driver description and driver revision

2010-03-25 Thread Anil Veerabhadrappa
[BNX2I] update driver description and driver revision * Add 10G devices to list of devices supported by bnx2i driver Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i_init.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 2/3] [BNX2I] link bnx2i hba and cnic device before registering the device

2010-03-25 Thread Anil Veerabhadrappa
lizing 'hba->cnic' before calling register_device() will fix this issue Signed-off-by: Michael Chan Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i_init.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b

[PATCH 1/3] [BNX2I] instruct firmware to use driver/iscsid provided expected statsn

2010-03-25 Thread Anil Veerabhadrappa
ned-off-by: Eddie Wai Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i_hwi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c index 1af578d..d5d8234 100644 --- a/drivers/scsi/bnx2i/bnx2i_h

Re: Can anybody confirm that bnx2i on 5709 cards works with Equallogic 6xxx?

2010-01-20 Thread Anil Veerabhadrappa
On Wed, 2010-01-20 at 10:46 -0800, Ciprian Vizitiu (GBIF) wrote: > Hi, > > Can anybody here please confirm whether iSCSI offload via bnx2i, on RHEL > 5.4, with 5709 Broadcoms towards EQLs 6000 series works or not? Despite > countless attempts (and latest EQL OS update) I still can't match them

Re: [PATCH 3/5] BNX2I - update CQ arming algorith for 5771x chipsets

2009-12-10 Thread Anil Veerabhadrappa
On Wed, 2009-12-09 at 18:48 -0800, Mike Christie wrote: > Anil Veerabhadrappa wrote: > > * Only affects 5771x (10G chipsets) devices > > > Why don't you do it on 1 gig? Is it just not worth it or is it no > possible due to some limitation? All NetXtreme2 device

Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver

2009-12-10 Thread Anil Veerabhadrappa
On Thu, 2009-12-10 at 07:43 -0800, James Bottomley wrote: > On Wed, 2009-12-09 at 20:45 -0600, Mike Christie wrote: > > Reviewed-by: Mike Christie > > But not by checkpatch: > > ERROR: trailing whitespace > #23: FILE: drivers/scsi/bnx2i/bnx2i_init.c:90: > +^I^Iprintk(KERN_ALERT "bnx2i: unknown d

[PATCH 5/5] BNX2I - minor code cleanup and update driver version

2009-12-07 Thread Anil Veerabhadrappa
* Removed duplicate function call and not-so-useful comment line Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i_init.c |4 ++-- drivers/scsi/bnx2i/bnx2i_iscsi.c |2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b

[PATCH 4/5] BNX2I - Task management ABORT TASK fixes

2009-12-07 Thread Anil Veerabhadrappa
ent is internal to initiator side and only lower bits of ITT as defined by ISCSI_ITT_MASK is is sent on wire * Retrieve LUN directly from the ref_sc and update SQ wqe as per chip HSI (Host Software Interface) specification Signed-off-by: Anil Veerabhadrappa --- drivers/scsi

[PATCH 3/5] BNX2I - update CQ arming algorith for 5771x chipsets

2009-12-07 Thread Anil Veerabhadrappa
* Only affects 5771x (10G chipsets) devices * This is an optimized CQ arming algoritm which takes into account the number of outstanding tasks Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i.h |1 + drivers/scsi/bnx2i/bnx2i_hwi.c | 36

[PATCH 2/5 ] BNX2I - Adjust sq_size module parametr to power of 2 only if a non-zero value is specified

2009-12-07 Thread Anil Veerabhadrappa
27; and forces driver to setup connections with send queue size of '1' and results in lower performance as well Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c

[PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver

2009-12-07 Thread Anil Veerabhadrappa
* Add code to enumerate 5771E device Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i_init.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c index 0c4210d..3c46458 100644 --- a

[PATCH 1/1] BNX2I - Fix context mapping issue for architectures with PAGE_SIZE != 4096

2009-09-11 Thread Anil Veerabhadrappa
by choice lets device use the defaults * So while mapping connection context memory (doorebll registers), driver has to match page size used by the device. Included change fixes the issue we uncovered during IA64 testing Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i

Re: Use iscsi kernel passthrough interface for sendtargets

2009-09-01 Thread Anil Veerabhadrappa
On Sun, 2009-08-30 at 14:31 -0700, Mike Christie wrote: > For offlaod cards, bnx2i, cxgb3i and be2iscsi, we have to do discovery > through a second network interface. The two attached patches has us > instead do discovery through the iscsi class interface, so you do not > have to set up a seper

[PATCH 2/2] bnx2i : Fix "cid #n not valid" issue

2009-07-29 Thread Anil Veerabhadrappa
releasing invalid 'cid' * There is already a check in bnx2i_free_iscsi_cid() not to free invalid iscsi connection handle (-1) Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i_iscsi.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/s

[PATCH 1/2] bnx2i : Fix CMDSN jump issue seen during cable pull test

2009-07-29 Thread Anil Veerabhadrappa
d by bnx2i and connection will never enter recovery state. This fix is required for MPIO to work corectly Signed-off-by: Anil Veerabhadrappa --- drivers/scsi/bnx2i/bnx2i_iscsi.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/driv

Re: [PATCH] cnic: Fix ISCSI_KEVENT_IF_DOWN message handling.

2009-07-29 Thread Anil Veerabhadrappa
On Wed, 2009-07-29 at 00:55 -0700, Michael Chan wrote: > Mike Christie wrote: > > > Michael Chan wrote: > > > When a net device goes down or when the bnx2i driver is unloaded, > > > the code was not generating the ISCSI_KEVENT_IF_DOWN message > > > properly and this could cause the userspace driv

Re: [PATCH] BNX2I: register given device with cnic if shost != NULL in ep_connect()

2009-07-09 Thread Anil Veerabhadrappa
On Thu, 2009-07-09 at 10:43 -0700, Mike Christie wrote: > On 07/09/2009 09:39 AM, Anil Veerabhadrappa wrote: > > On Thu, 2009-07-09 at 00:15 -0700, Michael Chan wrote: > >> Mike Christie wrote: > >>> Anil Veerabhadrappa wrote: > >>>> diff --git a/dri

Re: [PATCH] BNX2I: register given device with cnic if shost != NULL in ep_connect()

2009-07-09 Thread Anil Veerabhadrappa
On Thu, 2009-07-09 at 10:43 -0700, Mike Christie wrote: > On 07/09/2009 09:39 AM, Anil Veerabhadrappa wrote: > > On Thu, 2009-07-09 at 00:15 -0700, Michael Chan wrote: > >> Mike Christie wrote: > >>> Anil Veerabhadrappa wrote: > >>>> diff --git a/dri

Re: [PATCH] BNX2I: register given device with cnic if shost != NULL in ep_connect()

2009-07-09 Thread Anil Veerabhadrappa
On Thu, 2009-07-09 at 00:15 -0700, Michael Chan wrote: > Mike Christie wrote: > > Anil Veerabhadrappa wrote: > > > diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c > > b/drivers/scsi/bnx2i/bnx2i_iscsi.c > > > index f741219..98148f3 100644 > > > --- a/dr

[PATCH] BNX2I: register given device with cnic if shost != NULL in ep_connect()

2009-07-08 Thread Anil Veerabhadrappa
before attempting to offload the connection Signed-off-by: Anil Veerabhadrappa Reviewed-by: Michael Chan --- drivers/scsi/bnx2i/bnx2i_init.c |7 +-- drivers/scsi/bnx2i/bnx2i_iscsi.c |7 +-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/bnx2i

Re: [PATCH] bind offloaded connection to port

2009-04-16 Thread Anil Veerabhadrappa
On Tue, 2009-04-14 at 19:19 -0700, Mike Christie wrote: > Hey offload guys, > > If we are using a offload card, then iface_set_param will match the > iface info to a scsi_host and pass that info down to setup the net > settings of the port (currently we just set the ip address). When we > crea

RE: [RFC] : network configuration for iscsi hba

2009-02-05 Thread Anil Veerabhadrappa
nitions based on guidelines (supported parameter list) outlined in driver's README file. > -Original Message- > From: open-iscsi@googlegroups.com [mailto:open-is...@googlegroups.com] > On Behalf Of Anil Veerabhadrappa > Sent: Thursday, February 05, 2009 5:01 PM > To: open-is

RE: [RFC] : network configuration for iscsi hba

2009-02-05 Thread Anil Veerabhadrappa
works for cxgb3i/qla4xxx/bnx2i/... > Thanks, > Karen > > -Original Message- > From: open-iscsi@googlegroups.com [mailto:open-is...@googlegroups.com] > On Behalf Of Anil Veerabhadrappa > Sent: Thursday, February 05, 2009 4:21 PM > To: open-iscsi@googlegroups.com

RE: [RFC] : network configuration for iscsi hba

2009-02-05 Thread Anil Veerabhadrappa
On Thu, 2009-02-05 at 16:00 -0800, Karen Xie wrote: > Thanks, > What are the possible values of "ISCSI_NET_CFG_BOOTPROTO"? > static and dhcp > Karen > > -Original Message- > From: open-iscsi@googlegroups.com [mailto:open-is...@googlegroups.com] >

RE: [RFC] : network configuration for iscsi hba

2009-02-05 Thread Anil Veerabhadrappa
On Thu, 2009-02-05 at 14:33 -0800, Karen Xie wrote: > -Original Message- > From: open-iscsi@googlegroups.com [mailto:open-is...@googlegroups.com] > On Behalf Of Anil Veerabhadrappa > Sent: Thursday, February 05, 2009 11:23 AM > To: open-iscsi@googlegroups.com; micha...@c

[RFC] : network configuration for iscsi hba

2009-02-05 Thread Anil Veerabhadrappa
i. We would like to hear comments and suggestions from other iscsi offload vendors in defining this interface. Regards, Anil Veerabhadrappa Proposal to add netlink message type: - 3 new netlink message types are required to support network config message exc

RE: Debian etch, bnx2i. Trouble getting it to work

2008-09-29 Thread Anil Veerabhadrappa
Hasse, We will look into this and get back with a definitive answer soon. Can you exactly tell me what Ubuntu release distribution you are using? - Anil Veerabhadrappa From: open-iscsi@googlegroups.com [EMAIL PROTECTED] On Behalf Of Alfafa [EMAIL

Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.

2008-05-23 Thread Anil Veerabhadrappa
On Fri, 2008-05-23 at 13:23 -0700, Roland Dreier wrote: > Hi Michael, I was reading over the driver to try and figure out how you > handle allocating source ports for the offloaded TCP connections you > make so that they don't collide with the main network stack. It looks > like you have: > >

Re: [PATCH 3/3] bnx2i: Add bnx2i iSCSI driver.

2008-05-22 Thread Anil Veerabhadrappa
On Thu, 2008-05-22 at 11:15 -0400, Konrad Rzeszutek wrote: > A cursory glance.. > > .. snip.. > > +struct bnx2i_cleanup_request { > > +#if defined(__BIG_ENDIAN) > > + u8 op_code; > > + u8 reserved1; > > + u16 reserved0; > > +#elif defined(__LITTLE_ENDIAN) > > + u16 reserved0; > > + u8 r

RE: bnx2i driver for RHEL 4?

2008-02-21 Thread Anil Veerabhadrappa
bnx2i is supported on RHEL5 and SUSE10u1 distro. We have explored few options to add RHEL4 support but nothing has materalized yet. -Original Message- From: open-iscsi@googlegroups.com on behalf of extraspecialbitter Sent: Thu 2/21/2008 7:16 AM To: open-iscsi Subject: bnx2i driver for RH

Re: bnx2i driver branches

2008-01-10 Thread Anil Veerabhadrappa
On Thu, 2008-01-10 at 15:55 -0600, Mike Christie wrote: > Mike Christie wrote: > > Anil Veerabhadrappa wrote: > >> On Thu, 2008-01-10 at 14:41 -0600, Mike Christie wrote: > >>> Anil Veerabhadrappa wrote: > >>>> On Thu, 2008-01-10 at 07:22 -0600, Mike

Re: bnx2i driver branches

2008-01-10 Thread Anil Veerabhadrappa
On Thu, 2008-01-10 at 15:15 -0600, Mike Christie wrote: > Mike Christie wrote: > > Hey Broadcom guys and iscsi list, > > > > I put up all my changes to the bnx2i driver in the bnx2i branches of the > > open-iscsi git tree and linux-2.6-iscsi. > > > > It hooks bnx2i into the iscsi layers like ho

Re: bnx2i driver branches

2008-01-10 Thread Anil Veerabhadrappa
On Thu, 2008-01-10 at 14:41 -0600, Mike Christie wrote: > Anil Veerabhadrappa wrote: > > On Thu, 2008-01-10 at 07:22 -0600, Mike Christie wrote: > >> Hey Broadcom guys and iscsi list, > >> > >> I put up all my changes to the bnx2i driver in the bnx2i branches

Re: bnx2i driver branches

2008-01-10 Thread Anil Veerabhadrappa
On Thu, 2008-01-10 at 07:22 -0600, Mike Christie wrote: > Hey Broadcom guys and iscsi list, > > I put up all my changes to the bnx2i driver in the bnx2i branches of the > open-iscsi git tree and linux-2.6-iscsi. Thanks Mike > > It hooks bnx2i into the iscsi layers like how iser and iscsi_tcp i