.
changeset 8f19a61c12d391ffa34dd930713c973192a5b0c5
Author: Anders Widell anders.wid...@ericsson.com
Date: Mon, 12 Jan 2015 16:50:58 +0100
uml: Improve the UML cluster simulator [#1197]
The UML cluster simulator has been improved in a number of ways:
* The shared file
The file must be installed in the directory where bash-completion
expects to find it. The following command prints out the name of the
directory:
pkg-config --variable=completionsdir bash-completion
regards,
Anders Widell
On 01/08/2015 06:10 AM, Sashan Govender wrote:
Hi Anders
Regarding 1
Ack
/ Anders Widell
On 03/09/2015 10:49 AM, Robert Apanowicz wrote:
osaf/services/saf/smfsv/smfd/SmfCallback.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
This change fixes the wrong include of poll.h, which was done by the first
patch of this ticket.
diff --git a/osaf
Just a thought here: are the nodes names stored in a multi-value
attribute in an IMM object? Then maybe you could use the
SA_IMM_ATTR_NO_DUPLICATES flag to avoid duplicates?
/ Anders Widell
On 03/11/2015 04:04 PM, Hans Nordebäck wrote:
Ack, code review only. Perhaps ng_create should check
Hi!
Why did you remove #include poll.h from SmfCallback.cc? There is a
call to the function poll() in this file, and the poll() function is
declared in poll.h (according to the poll man-page). Probably, you
should have removed #include sys/poll.h instead?
regards,
Anders Widell
On 02/18/2015
]
/ Anders Widell
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from
n
Tests n
Other n
Comments (indicate scope for each y above):
-
v2: Fix plm patch so that it works with newer versions of OpenHPI.
changeset 88f1d61cf53ff6d61bcb0e26e0ec3be5643843d7
Author: Anders Widell
osaf/services/saf/amf/amfnd/susm.cc | 12
1 files changed, 4 insertions(+), 8 deletions(-)
The following warning was fixed by replacing the case statement with an if
statement:
susm.cc: In function 'uint32_t avnd_evt_avd_su_pres_evh(AVND_CB*, AVND_EVT*)':
susm.cc:1237:26: error:
osaf/services/saf/plmsv/plms/hpi_intf/plms_hsm.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
The following warning was fixed:
plms_hsm.c: In function 'hsm_discover_and_dispatch':
plms_hsm.c:685:20: error: unused variable 'my_entity_path'
[-Werror=unused-variable]
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset f00c6456ecf708b5af7aae6bafaee2b3ac4157e3
Author: Anders Widell anders.wid...@ericsson.com
Date: Wed, 29 Apr 2015 14:01:52 +0200
osaf/services/saf/amf/amfnd/susm.cc | 12
1 files changed, 4 insertions(+), 8 deletions(-)
The following warning was fixed by replacing the case statement with an if
statement:
susm.cc: In function 'uint32_t avnd_evt_avd_su_pres_evh(AVND_CB*, AVND_EVT*)':
susm.cc:1237:26: error:
osaf/libs/core/mds/mds_dt_tipc.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
The following warning was fixed:
mds_dt_tipc.c: In function 'mdtm_tipc_init':
mds_dt_tipc.c:245:28: error: comparison of constant '2' with boolean expression
is always false
osaf/libs/core/mds/mds_dt_tipc.c | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
The following warning was fixed:
mds_dt_tipc.c: In function 'mdtm_tipc_init':
mds_dt_tipc.c:245:28: error: comparison of constant '2' with boolean expression
is always false
Ack.
/ Anders Widell
On 04/30/2015 01:35 PM, Ingvar Bergstrom wrote:
osaf/services/saf/smfsv/smfd/smfd_smfnd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
smfd may free wrong SmfndNodeT pointer when a smfd node director report UP
and the saClmInitialize() call fail
Ack.
/ Anders Widell
On 04/22/2015 04:35 PM, Hans Nordeback wrote:
bootstrap.sh| 2 +-
osaf/services/saf/amf/amfd/main.cc | 2 +-
osaf/services/saf/amf/amfnd/main.cc | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/bootstrap.sh b
Ack.
Question: Did you try this with an LSB compiler? I am surprised it
didn't complain about PR_SET_DUMPABLE. Maybe it would be good to add an
#ifndef, just in case:
#ifndef PR_SET_DUMPABLE
#define PR_SET_DUMPABLE 4
#endif
/ Anders Widell
On 04/20/2015 02:52 PM, Hans Nordeback wrote
Ack with minor comment: The documentation for the function spawn_wait()
should be updated to say that NCSCC_RC_REQ_TIMEOUT is a possible return
code.
/ Anders Widell
On 04/30/2015 03:13 PM, Hans Nordeback wrote:
osaf/services/infrastructure/nid/nodeinit.c | 56
to the terminate
callback as well as waiting for the process to disappear, before trying
to instantiate the component again. Such a solution could be implemented
as an enhancement ticket.
/ Anders Widell
On 05/06/15 16:47, mathi.naic...@oracle.com wrote:
Summary: osaf: During adminrestart of node
the effort. snprintf is likely to be implemented as
reentrant in glibc.
/ Anders Widell
On 04/09/2015 08:41 AM, ramesh betham wrote:
Please don't use those functions (like syslog etc.) that are not
/Async/-/signal/-/safe /functions in signal handler function.
Thanks,
Ramesh.
On 4/8/2015 6:03 PM
be safer to treat the status variable as undefined in
this case?
4) You need to add the following includes:
#include signal.h // for kill()
#include sys/wait.h // for waitpid()
#include stdint.h // for uint32_t
/ Anders Widell
On 04/02/2015 02:17 PM, Hans Nordeback wrote:
osaf/services
Ack with comments.
* Make sure to have a properly formatted commit message (base: was
duplicated, square brackets missing around ticket number).
* It could be useful to see the identity of one who sent the signal
(PID, maybe also UID).
* See below for inline comments.
/ Anders Widell
On 04/01
Ack. A minor comment is that it would be good to mention in the commit
message why this change was done (i.e. that the OpenSAF version should
be logged also in the cases when OpenSAF FAILS to start...)
/ Anders W
On 06/02/2015 10:34 AM, Hans Nordeback wrote:
Ack from me as well. I haven't looked so carefully at this since I am
not so familiar with the AMF code.
/ Anders Widell
On 06/09/2015 03:47 PM, nagendr...@oracle.com wrote:
Summary: amfnd: wait for applcation exit during its termimation [#1375]
Review request for Trac Ticket(s): #1375
Peer
Ack (for both patches on this ticket), with some comments:
* Boiler plates (licence copyright) are missing in the new files
* The README assumes the developer uses Ubuntu and has sudo rights (root
access). Instead, I think it would be better to describe how to download
the Google test
Other n
Comments (indicate scope for each y above):
-
changeset 628e30d32d1f9fa5c48021f62b6fa0d5ebd8f157
Author: Anders Widell anders.wid...@ericsson.com
Date: Thu, 21 May 2015 13:28:44 +0200
build: Use the C11 standard for C
Makefile.common | 4 ++--
README | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Use the C11 standard when compiling C code, and the C++11 standard when
compiling C++ code. For GCC, this means that we also bump the recommended
minimum version to 4.8.1, which is the first
/pyosaf/utils/immom'
make[6]: Nothing to be done for `install-exec-am'.
make[6]: *** No rule to make target `common.py', needed by
`install-pkgpyosafutilsimmomPYTHON'. Stop.
/ Anders Widell
The file is identical in both the released tarball and in the source
code repository (at the tag 4.6.0). This bug seems to have been fixed in
changeset 6559:e840bacdf25a (ticket [#1373]), which has not yet been
included in any release.
/ Anders Widell
On 08/07/2015 09:45 PM, Alex Jones wrote
I tried building the latest from the devel branch with GCC 4.9.0 and
didn't encounter any problem. Have you tried building from a fresh
clone, without any old object files or other build artifacts?
/ Anders Widell
On 07/27/2015 10:37 AM, Neelakanta Reddy wrote:
when compiled on the chageset
If you apply the patch on the exact same version of the source code that
the patch was generated from, then it shouldn't matter which version of
the patch command you are using.
/ Anders Widell
On 07/24/2015 01:17 PM, Nagendra Kumar wrote:
Hi Anders,
Thanks for your reply. It works when
Yes, this enhancement has now been approved and I will push it later today.
/ Anders Widell
On 07/16/2015 04:32 AM, Gary Lee wrote:
Hi
Any update on this? I'd like to use some C++11 features to refactor some
AMF code. Just simple things
like auto and range-based for loops would make
on the
4.7 branch.
regards,
Anders Widell
--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
v2: Updated Section 4.1 to mention the new SaStringT-based IMM API.
regards,
Anders Widell
On 10/22/2015 12:55 PM, Anders Widell wrote:
Hi!
Please find the OpenSAF Extensions PR document for 4.7 release for
review. I have added "Chapter 5 Scaling".
regards,
And
n
Comments (indicate scope for each "y" above):
-
changeset 8ea3e380f091f67961de443b8b147fc8c9ec595c
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 26 Oct 2015 16:44:42 +0100
imm: Fix build failure on
osaf/services/saf/immsv/immnd/ImmModel.hh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Fix the following build problem which was seen on CentOS 6:
CXX osafimmnd-ImmModel.o
In file included from ImmModel.cc:22:0:
ImmModel.hh:277:43: error: ‘va_list’ has not been declared
release.
regards,
Anders Widell
--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
suitable for running in a cloud.
regards,
Anders Widell
--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
Ack, have tested to build on 32-bit. A minor comment is that it might be
better to use e.g. PRIx64 when the size of the variable is known. This
way, you can avoid type casting.
/ Anders Widell
On 10/07/2015 08:50 AM, Nhat Pham wrote:
> osaf/libs/common/cpsv/cpsv_evt.c |
Hi!
Here is a new version of the opensaf_scale_out example script, where I
have corrected a few warnings from the shell checker tool. Please use
this new version instead (just sending the new version of the example
script instead of a completely new review request).
thanks,
Anders Widell
all OpenSAF
directors will be cold synced in serial. With the other solution, they
can be cold synced in parallel.
/ Anders Widell
On 04/27/2015 11:19 AM, nagendr...@oracle.com wrote:
> Summary: amfd: respond to nid only after initialization is completed [#1334]
> Review request for Trac
this
classification is forgotten, in some future modification of the code.
Zoran, would it be possible to add some sort of assertion (or at least a
log message) that can catch cases where the classification has been
forgotten (or even the string has been misspelt) in the error string?
/ Anders W
Ack from me, with the following comments:
* Correct the copyright year and authors
* It would be good if you run the "2to3" tool on this one so that it is
compatible with both python2 and python 3 (python 3 will soon be the
default version in some Linux distributions).
/ Anders Wid
Hi
See my replies marked with [AndersW] inline.
thanks,
Anders Widell
On 09/10/2015 01:27 PM, Nagendra Kumar wrote:
> Hi Anders,
> Thanks for pointing out. Please find my responses inlined with
> [Nagu].
>
> Thanks
> -Nagu
>> -Original Message
Thanks, we will try it out!
Btw I checked the patch and it only changes the function
avd_role_failover(), but there is no corresponding change in the
function avd_role_failover_qsd_actv(). Doesn't the latter function also
have to be modified?
regards,
Anders Widell
On 09/11/2015 03:08 PM
).
regards,
Anders Widell
On 09/11/2015 11:50 AM, Nagendra Kumar wrote:
> Hi Anders,
> Since you are talking about making FMS redundant and its
> removal and moving from NID to system and since this problem is existing in
> other pre Amf components(Amfnd actually), s
See inline.
/ Anders Widell
On 09/11/2015 12:45 PM, Nagendra Kumar wrote:
> Hi Anders,
> Please check the comment on #1334 : "Amf can provide a reboot
> in this case if fms don't care to handle it.".
[AndersW] Yes, I saw this comment and that's why I was wonde
+ret_z1=$?
+if [ $ret_z1 -ne 0 ] ; then
+echo "Unable to Configure TIPC address, Please try again,
exiting"
+modprobe -r tipc
+exit 1
+fi
+ else
/ Anders Widell
On 09/03/2015 10:37 AM, mahesh.va...@oracle
No, the reason is that CLM doesn't have any OpenSAF configuration
object. :-) We could of course put it in the cluster object, as a SAF
extension.
/ Anders Widell
On 09/29/2015 09:39 AM, Johan Mårtensson O wrote:
> Hi Anders,
>
> This is a good hook to have for the scaling out
osaf/services/saf/clmsv/README | 17 ++
osaf/services/saf/clmsv/clms/clms_cb.h | 31
osaf/services/saf/clmsv/clms/clms_evt.c | 238 ++-
osaf/services/saf/clmsv/clms/clms_main.c | 18 ++
osaf/services/saf/clmsv/config/clmd.conf |9 +
5 files
n
Other n
Comments (indicate scope for each "y" above):
-
changeset e72fa53d3367e17a5e061bb275776f912131bcd1
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 28 Sep 2015 21:24:50 +0200
c
osaf/services/saf/clmsv/nodeagent/cb.h | 7 ++-
osaf/services/saf/clmsv/nodeagent/evt.h | 5 +-
osaf/services/saf/clmsv/nodeagent/main.c | 73 ++-
3 files changed, 79 insertions(+), 6 deletions(-)
When the scale-out feature has been enabled in clmd.conf, CLMD
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset b65bbf23422f9bcdaa0ad7592d9a492f4dd98e92
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 02 Oct 201
Makefile.am |3 +-
opensaf.spec.in |1 +
osaf/services/infrastructure/nid/config/nid.conf |9 +
osaf/services/saf/clmsv/README | 29 ++-
osaf/services/saf/clmsv/clms/clms_cb.h | 37
osaf/services/saf/clmsv/nodeagent/cb.h | 4 +
osaf/services/saf/clmsv/nodeagent/evt.h | 2 +
osaf/services/saf/clmsv/nodeagent/main.c | 70 ++-
3 files changed, 73 insertions(+), 3 deletions(-)
When the scale-out feature has been enabled in clmd.conf, CLMD
October 1.
/ Anders Widell
--
___
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
ge of the sighandler() method? I can see
that we install it as a signal handler for SIGTERM, but it seems it is
not used? If it is not used, it could be removed.
regards,
Anders Widell
On 11/25/2015 06:33 PM, Hans Nordeback wrote:
> configure.ac |1 +
> osaf/
of the improvements that I am planning to do in
ticket [#777].
/ Anders Widell
On 12/10/2015 08:37 AM, Vu Minh Nguyen wrote:
> Hi Lennart,
>
> osaf_secutil.h is a common header file, it is out of OpenSAF LOG scope. So I
> leave the fix to other responsible person.
> I have not
I sent out a fix for osaf_secutil.h as part of ticket [#777].
regards,
Anders Widell
On 12/10/2015 08:37 AM, Vu Minh Nguyen wrote:
> Hi Lennart,
>
> osaf_secutil.h is a common header file, it is out of OpenSAF LOG scope. So I
> leave the fix to other responsible person.
>
?
/ Anders Widell
On 11/06/2015 06:33 AM, mahesh.va...@oracle.com wrote:
> osaf/libs/agents/saf/cpa/cpa_api.c | 111
> ++--
> 1 files changed, 91 insertions(+), 20 deletions(-)
>
>
> If we test upper and lower limits of SaTimeT timeout arg
configure.ac|1 +
osaf/libs/core/common/Makefile.am |2 +-
osaf/libs/core/common/tests/Makefile.am | 51 +
osaf/libs/core/common/tests/mock_clock_gettime.cc | 45 +
n
Comments (indicate scope for each "y" above):
-
changeset 155811ee709c47e0a6feadf8e859a2e8371d7820
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Thu, 10 Dec 2015 11:24:56 +0100
base: Add missing #ifdef ar
osaf/libs/core/common/include/osaf_time.h | 13 +++-
osaf/libs/core/common/osaf_time.c | 51 --
2 files changed, 33 insertions(+), 31 deletions(-)
Simplify osaf_nanosleep() by using clock_nanosleep() instead of nanosleep().
Also add commonly used time
Hi Ramesh!
Have you had time to look at this yet?
regards,
Anders Widell
On 12/22/2015 05:03 PM, Anders Widell wrote:
> Summary: base: Add osaf_timerfd_* utility functions [#777]
> Review request for Trac Ticket(s): 777
> Peer Reviewer(s): Ramesh
> Pull request to:
> Aff
variable called
"timeout", and it reads the timeout parameter from the message it has
received from the agent. But it is not used! Could you please take a
look at this?
thanks,
Anders Widell
On 01/04/2016 07:19 AM, A V Mahesh wrote:
> Hi Anders Widell
>
> Ok I will bum
Hi Ramesh!
Do you have any comments on this review?
regards,
Anders Widell
On 12/10/2015 11:38 AM, Anders Widell wrote:
> Summary: Simplify osaf_nanosleep() and add new time constants
> Review request for Trac Ticket(s): 777
> Peer Reviewer(s): Ramesh, Hans
> Pull request to:
>
See comments inline.
regards,
Anders Widell
On 01/04/2016 11:00 AM, A V Mahesh wrote:
> Hi Anders Widell,
>
> Please find my answers.
>
> On 1/4/2016 2:20 PM, Anders Widell wrote:
>> Ok good, that will solve the backwards compatibility issue! Though I
>> still don't
Ack. Code review only.
/ Anders Widell
On 12/17/2015 01:54 AM, Minh Hon Chau wrote:
> osaf/services/saf/clmsv/clms/clms_evt.c | 17 +
> 1 files changed, 9 insertions(+), 8 deletions(-)
>
>
> The coredump happens if the node_up is sent from clm node agent
osaf/libs/core/common/Makefile.am|1 +
osaf/libs/core/common/include/Makefile.am|1 +
osaf/libs/core/common/include/osaf_timerfd.h | 131 +
osaf/libs/core/common/osaf_timerfd.c | 264 +++
4 files changed, 397 insertions(+), 0
Comments (indicate scope for each "y" above):
-
Note: I plan to contribute a unit test for these functions later.
changeset 14cd662b79b79166632d17a52584d5cdc2776d25
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Tue, 22 D
See comments inline.
regards,
Anders Widell
On 12/21/2015 11:04 AM, A V Mahesh wrote:
> Hi,
>
> - The timeout here is the duration for which the API should wait
> before returning to the user.
> - The patch does not changes the minimum value of 14 seconds. IE.
> Befo
Hi!
See my comments marked [AndersW] inline.
regards,
Anders Widell
On 12/28/2015 05:35 AM, A V Mahesh wrote:
> Hi Anders Widell,
>
> Please find my answers.
>
> On 12/22/2015 10:41 PM, Anders Widell wrote:
>> See comments inline.
>>
>> regards,
>> And
and enters a bad state. In either case, I think it is worth
investigating!
regards,
Anders Widell
On 11/26/2015 10:28 AM, Nhat Pham wrote:
> Hi Anders,
>
> The patch was updated with your comments (1 and 2). Please have a look.
>
> Regarding the comment 3, I didn't see the failed tes
Excellent!
This shows how useful it is to have test cases. :-)
regards,
Anders Widell
On 11/30/2015 10:09 AM, Nhat Pham wrote:
> Hi Anders,
>
> I managed to reproduce the problem. Look like there are several problems in
> ckpt relating to closing and unlinking the non-collocate
n
Comments (indicate scope for each "y" above):
-
changeset 58b4d1f2d496eb548b09e82e8c13319a199f00ce
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Tue, 12 Jan 2016 13:53:28 +0100
base: Treat fai
osaf/libs/core/common/daemon.c | 11 ++-
osaf/libs/core/leap/os_defs.c | 21 +++--
2 files changed, 29 insertions(+), 3 deletions(-)
OpenSAF will now fall back to the SCHED_OTHER scheduling policy when it fails
to set a real-time scheduling policy.
diff --git
(indicate scope for each "y" above):
-
changeset f2309bc01df86422049e5121a69f45aa766b4718
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Thu, 09 Jun 2016 11:13:47 +0200
rde: Fix cppcheck warnings [#1870]
The fo
Excellent, I think this version of the code is more readable and I get
zero warnings from shellcheck. :-)
ACK.
thanks,
Anders Widell
On 06/09/2016 06:19 AM, Hung Nguyen wrote:
> osaf/services/infrastructure/nid/scripts/configure_tipc.in | 12
> +++-
> 1 files changed, 3 i
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 7f4baa44223cf21d52833caf28e6f80dd8be50c6
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 08 Jun 2016 12:36:14 +0200
clm:
osaf/services/saf/clmsv/nodeagent/main.c | 5 +
1 files changed, 5 insertions(+), 0 deletions(-)
The OpenSAF start time for standby system controllers had degraded between
OpenSAF 4.7 and OpenSAF 5.0. The reason was that the CLM node director did not
reply to NID until the standby node had
itution is not supported, even when sh
is actually bash.
^-- SC2039: In POSIX sh, array references are not supported.
Could you take a look at these warnings and see if there is a way to
implement this using POSIX shell features only?
thanks,
Anders Widell
On 06/06/2016 12:55 PM, Hung Ng
osaf/services/saf/mqsv/mqd/mqd_api.c| 2 --
osaf/services/saf/mqsv/mqnd/mqnd_init.c | 3 ---
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/osaf/services/saf/mqsv/mqd/mqd_api.c
b/osaf/services/saf/mqsv/mqd/mqd_api.c
--- a/osaf/services/saf/mqsv/mqd/mqd_api.c
+++
Makefile.am | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
* Use inline suppressions instead of listing them on the command line
* Enable the gnu and posix libraries
* Remove unnecessary defines
diff --git a/Makefile.am b/Makefile.am
--- a/Makefile.am
+++ b/Makefile.am
@@ -255,7
osaf/services/saf/glsv/gld/gld_api.c | 3 ---
osaf/services/saf/glsv/glnd/glnd_cb.c | 3 ---
2 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/osaf/services/saf/glsv/gld/gld_api.c
b/osaf/services/saf/glsv/gld/gld_api.c
--- a/osaf/services/saf/glsv/gld/gld_api.c
+++
osaf/libs/agents/saf/amfa/ava_hdl.cc | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/osaf/libs/agents/saf/amfa/ava_hdl.cc
b/osaf/libs/agents/saf/amfa/ava_hdl.cc
--- a/osaf/libs/agents/saf/amfa/ava_hdl.cc
+++ b/osaf/libs/agents/saf/amfa/ava_hdl.cc
@@ -63,7 +63,6 @@
osaf/libs/common/ais/aisa_api.c |2 +
osaf/libs/core/common/daemon.c | 60 ++-
osaf/libs/core/common/include/osaf_secutil.h | 14 +-
osaf/libs/core/common/ncs_main_pub.c | 19 +-
(indicate scope for each "y" above):
-
changeset 5231c1f8ebff0ffb4c519f4d085241a3296de202
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 15 Jun 2016 16:35:19 +0200
build: Update cppcheck target options [#1879]
Hi all!
We would like to announce that OpenSAF now has an IRC channel (again).
Join our channel #opensaf at irc.freenode.net
This is a general-purpose channel that can be used for communication
between OpenSAF developers.
regards,
Anders Widell
Hi Ramesh!
Did you get any chance to start looking at any of the patches for ticket
[#1870], [#1871] or [#1879] yet.
thanks,
Anders Widell
On 06/09/2016 12:29 PM, Anders Widell wrote:
> Summary: rde: Fix cppcheck warnings [#1870]
> Review request for Trac Ticket(s): 1870
> Peer R
that it works then I don't see any problem with C++ in the agent libraries.
regards,
Anders Widell
On 02/12/2016 02:03 PM, Hans Nordebäck wrote:
> it should also be possible to have different stdc++ libraries, for
> example an c++ application is compiled with clang++ and linked with
different implementation like e.g. libc++).
/ Anders Widell
On 02/08/2016 04:37 PM, Hans Nordebäck wrote:
> Hi Praveen, Nagu, Mathi and Anders,
>
> Any comments on this patch? As Gary mentions below, it would e.g. make
> supporting long DN a lot easier. /Thanks HansN
>
>
>
&g
Hi!
See my comments inline.
regards,
Anders Widell
On 01/29/2016 10:35 AM, Nagendra Kumar wrote:
> To add: There are some get API, which don't depend upon the Director and
> information is at Node-Director, so in that case, what should be behaviour of
> those API in case of
See my comments inline, marked [AndersW3].
regards,
Anders Widell
On 02/24/2016 07:32 AM, Nhat Pham wrote:
>
> Hi Mahesh and Anders,
>
> Please see my comments below.
>
> Best regards,
>
> Nhat Pham
>
> *From:*A V Mahesh [mailto:mahesh.va...@oracle.com]
> *Sent:
Hi!
Please see my comments inline, marked [AndersW2].
regards,
Anders Widell
On 02/22/2016 03:18 AM, Nhat Pham wrote:
>
> Hi Mahesh and Anders,
>
> Please see my comment below.
>
> BTW, have you finished the review and test?
>
> Best regards,
>
> N
Ok, good!
So the compiler actually can detect this bug when using the -O3
optimization level. Interesting.
I will test if the build succeeds after applying this patch.
thanks,
Anders Widell
On 02/26/2016 04:10 AM, Nhat Pham wrote:
> Hi Anders,
>
> The problem was reported in the ti
overflow destination buffer [-Werror]
return __builtin___strncat_chk (__dest, __src, __len, __bos (__dest));
^
I configure OpenSAF using the following command:
./configure CFLAGS=-O3 CXXFLAGS=-O3
regards,
Anders Widell
Hi!
See my comments inline, marked [AndersW4].
regards,
Anders Widell
On 02/25/2016 05:26 AM, A V Mahesh wrote:
> Hi Nhat Pham,
>
> Please see my comment below.
>
> -AVM
>
> On 2/25/2016 7:54 AM, Nhat Pham wrote:
>>
>> Hi Mahesh,
>>
>> Would you agr
See my comments, marked [AndersW5].
regards,
Anders Widell
On 02/25/2016 11:09 AM, Nhat Pham wrote:
>
> Hi Mahesh and Anders,
>
> Please see my comment below with [NhatPham3]
>
> Best regards,
>
> Nhat Pham
>
> *From:*A V Mahesh [mailto:mahesh.va...@oracle.com]
&
Makefile.common |3 +-
configure.ac |3 +
osaf/libs/core/Makefile.am|7 +-
osaf/libs/core/cplusplus/Makefile.am | 21 +
(indicate scope for each "y" above):
-
changeset c9dd036098edc2ab0e9fb8a12e43035e0681a0e4
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 29 Feb 2016 12:34:56 +0100
base: Add C++ utility functions [#836]
A
Hi!
Please find my replies inline.
thanks,
Anders Widell
On 02/29/2016 12:55 PM, ramesh betham wrote:
> Hi Anders.
>
> Ack with minor comments.
>
> * Its very likely that user may pass some invalid value (say.. fd
> value) for which the current implementation i
1 - 100 of 823 matches
Mail list logo
