On Wednesday 11 September 2013 11:06:40 you wrote:
> On 11 September 2013 10:41, Paul Berry wrote:
> > From: Dylan Baker
> >
> > This patch allows testlists to be generated at build time by cmake,
> > these generated testlist are python TestProfile objects that have
On Wednesday 11 September 2013 10:36:41 Paul Berry wrote:
> On 9 September 2013 16:46, Dylan Baker wrote:
> > On Monday 09 September 2013 16:34:08 you wrote:
> > > This series changes the way testlists are generated. This allows us to
> > > generate a TestProfile obje
This adds code in framework/summary.py and framework/core.py to make use
of the status classes in status.py. This makes comparisons between
statuses much simpler and cleaner
Signed-off-by: Dylan Baker
---
framework/core.py| 18 ++-
framework/summary.py | 85
implementing the __int__ method.
This will allow us to remove a number of special functions for sorting
representations of statuses.
Signed-off-by: Dylan Baker
---
framework/status.py | 99 +
1 file changed, 99 insertions(+)
create mode 100644
piglit's use case it is, however, it does not
implement the full API supported by the previous implementation.
Signed-off-by: Dylan Baker
---
framework/core.py | 3 +-
framework/threadpool.py | 455 ++--
framework/threads.py| 8 +-
3
cleans up the Test
derived classes. since they don't have to have a method to add
themselves to the ThreadPool, instead the ThreadPool has a method for
adding tests to itself.
Signed-off-by: Dylan Baker
---
framework/core.py| 36
framework/threads.py
On Monday 16 September 2013 09:25:25 Eric Anholt wrote:
> Dylan Baker writes:
> > This series changes the way testlists are generated. This allows us to
> > generate a TestProfile object only once, at build time. This is
> > accomplished by using python's pickle mod
On Monday 16 September 2013 20:08:33 Marek Olšák wrote:
> ---
> piglit-run.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/piglit-run.py b/piglit-run.py
> index e8e11b7..7945b21 100755
> --- a/piglit-run.py
> +++ b/piglit-run.py
> @@ -62,7 +62,7 @@ def main():
>
On Monday 16 September 2013 20:08:34 Marek Olšák wrote:
> ---
> tests/quick-driver.tests | 14 --
> tests/quick.tests| 6 ++
> 2 files changed, 6 insertions(+), 14 deletions(-)
> delete mode 100644 tests/quick-driver.tests
>
> diff --git a/tests/quick-driver.tests b/test
On Monday 16 September 2013 20:08:35 Marek Olšák wrote:
> The Radeon driver writes GPU page faults to dmesg and we need to know which
> test caused them.
>
> If there is any change in dmesg during a test run, the test result is
> changed as follows:
> * pass -> dmesg-warn
> * warn -> dmesg-warn
>
ors regularly as part of testing,
> +# and for exhaustive error-generation tests (particularly some in
> +# khronos's conformance suite), it can end up ooming your system
> +# trying to parse the strings.
> +if 'MESA_DEBUG' not in os.environ:
> +os.environ[&
(self, o):
> self.passnr += o.passnr
> self.warnnr += o.warnnr
> +self.unstablenr += o.unstablenr
> self.failnr += o.failnr
> self.skipnr += o.skipnr
> self.crashnr += o.crashnr
> @@ -89,11 +91,12 @@ results is an array of TestResult
On Tuesday 17 September 2013 23:57:02 Marek Olšák wrote:
> Yes. I added quick-driver.tests. I was making changes to it. Now I'm
> removing it.
>
> The difference between the two is 5 tests, which is pretty much nothing.
>
> Marek
>
> On Tue, Sep 17, 2013 at 5:46 PM
On Wednesday 18 September 2013 00:48:45 Marek Olšák wrote:
> On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker
wrote:
> > On Monday 16 September 2013 20:08:35 Marek Olšák wrote:
> >> The Radeon driver writes GPU page faults to dmesg and we need to know
> >> which
> >
efore and after the test and the difference between the two
is stored in the test summary.
The piglit-run.py parameter which enables this behavior is --dmesg. It's also
recommended to use -c0.
v2: - Use a simplified class to read dmesg
Signed-off-by: Dylan Baker
---
framework/core.py
ecommended to use -c0.
>
> v2: - Use a simplified class to read dmesg
>
> Signed-off-by: Dylan Baker
> ---
> framework/core.py | 5 +++--
> framework/dmesg.py | 48
> ++
framework/exectest.py |
>
On Wednesday 18 September 2013 15:00:29 Eric Anholt wrote:
> We can compute these lists anyway. Note how we don't really do much
> work to generate
> ---
> framework/summary.py | 59
> 1 file changed, 23
> insertions(+), 36 deletions(-)
>
> dif
and status[i + 1] == 1:
> -self.tests['fixes'].append(test)
> -
> -# Remove duplicate entries from the status lists
> -# If there are 4+ results can result in mutiple passes or
> regressions -# and changes in other words:
On Wednesday 18 September 2013 15:00:28 Eric Anholt wrote:
> I broke these two pages when doing the unstable-result change, because
> I didn't expect absolute numbers to be used on this thing that looked
> like it was for relative severity comparisons.
> ---
> framework/summary.py | 18 +--
On Wednesday 18 September 2013 15:00:30 Eric Anholt wrote:
> Now that the pages-list "optimization" is gone, we can move the
> changes list computation into an obvious place, avoiding any work in
> the single-results-file case.
> ---
> framework/summary.py | 19 ++-
> 1 file change
On Wednesday 18 September 2013 15:48:30 Eric Anholt wrote:
> Dylan Baker writes:
> > On Wednesday 18 September 2013 15:00:29 Eric Anholt wrote:
> >> We can compute these lists anyway. Note how we don't really do much
> >> work to generate
> >>
On Wednesday 18 September 2013 15:54:45 Eric Anholt wrote:
> Dylan Baker writes:
> > This adds code in framework/summary.py and framework/core.py to make use
> > of the status classes in status.py. This makes comparisons between
> > statuses much simpler and cleaner
> >
On Thursday 19 September 2013 16:02:49 Chad Versace wrote:
> On 09/17/2013 08:43 AM, Dylan Baker wrote:
> > On Monday 16 September 2013 20:08:33 Marek Olšák wrote:
> >> ---
> >>
> >> piglit-run.py | 2 +-
> >> 1 file changed, 1 insertion(+), 1 dele
On Thursday 19 September 2013 20:12:34 Ken Phillis Jr wrote:
> I probably should be a little bit more price about issue #3... I do expect
> the times to be different, but there is a problem of seeing less than one
> tenth of the total time when I only have four processors.
>
>
> Good example:
> ~
why I
> had to find and save the timestamp string, and find its position again
> in a new dmesg log.
>
> Marek
>
> On Wed, Sep 18, 2013 at 11:17 PM, Dylan Baker
wrote:
> > On Wednesday 18 September 2013 14:16:11 you wrote:
> >> From: Marek Olšák
> >>
On Wednesday 18 September 2013 01:21:59 Marek Olšák wrote:
> On Wed, Sep 18, 2013 at 1:04 AM, Dylan Baker
wrote:
> > On Wednesday 18 September 2013 00:48:45 Marek Olšák wrote:
> >> On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker
> >
> > wrote:
> >> >
On Saturday, September 21, 2013 02:31:06 AM Marek Olšák wrote:
> The Radeon driver writes GPU page faults to dmesg and we need to know which
> tests caused them.
>
> If there is any change in dmesg during a test run, the test result is
> changed as follows:
> * pass -> dmesg-warn
> * warn -> dmesg
On Monday, September 23, 2013 10:28:17 PM Marek Olšák wrote:
> Is there another, more readable way to emulate the ?: operator from C?
> I don't like adding unnecessary lines of code.
>
> Marek
>
> On Mon, Sep 23, 2013 at 10:23 PM, Dylan Baker
wrote:
> > On Saturday
ser.add_argument("--no-concurrency",
> +parser.add_argument("-1", "--no-concurrency",
> action = "store_false",
> dest= "concurrency",
> help= "Disab
This series is split into 4 seperate parts
Patches 1-2: These implement some conformance tests for the way summary
detects regressions, fixes, changes, and problems.
Patch 3: Fixes the current implementation of piglit to conform to these
tests.
Patches 4-5: These are the patches that were origin
g-warn and dmesg-fail
Signed-off-by: Dylan Baker
---
framework/core.py| 29 ++--
framework/summary.py | 97 ++--
2 files changed, 53 insertions(+), 73 deletions(-)
diff --git a/framework/core.py b/framework/core.py
index 09aebd4..9651
Fixes status hanlding (fixes, regressions, changes) to be compliant with
the status handling in framework_tests/summary.py. Mainly this addresses
notrun -> * and * -> notrun, as well as a few corner cases.
Signed-off-by: Dylan Baker
---
framework/summary.p
code duplication.
This already reveals ~20 problems in the current implementation
Signed-off-by: Dylan Baker
---
framework_tests/__init__.py | 0
framework_tests/helpers.py | 105 +
framework_tests/summary.py | 282
3 files changed
This program gives the option to run the tests. These tests are meant to
test internal features of the piglit framework. Currently there are only
tests for the summary module's handling of regressions, fixes, changes,
and problems.
Signed-off-by: Dylan Baker
---
piglit-framework-tests.py
.
- Add a class for the "Not Run" status
- Adds classes for dmesg-warn and dmesg-fail
- Change statuses to match the standard set in the framework test
Signed-off-by: Dylan Baker
---
framework/status.py | 118
1 file ch
Generating these lists is rather trivial, so just generate them all the
time.
Signed-off-by: Dylan Baker
---
framework/summary.py | 61 +---
1 file changed, 25 insertions(+), 36 deletions(-)
diff --git a/framework/summary.py b/framework
Since there is nothign special about __generate_lists anymore (it just
does the same thing all the time), just fold it back into the
constructor and save on having to call it.
Signed-off-by: Dylan Baker
---
framework/summary.py | 26 --
1 file changed, 4 insertions
On Friday, September 27, 2013 05:29:57 PM Ken Phillis Jr wrote:
> This patch looks good. The only suggest I have is to double check spelling
> on the commit logs and comments... For example, The word "nothign" should
> be nothing.
>
> On Fri, Sep 27, 2013 at 4:39 PM, Dyl
On Monday, September 16, 2013 09:09:34 AM Dylan Baker wrote:
> This patch completely rewrites the threadpool module. This new
> implementation is less complicated than the previous version. It also is
> not an external project pulled in, but an original implementation.
>
> T
On Monday, September 30, 2013 10:11:05 PM Kenney Phillis wrote:
> Increase the Minimum version of CMake that is required from
> version 2.6 to version 2.8. This is because the minimum requirement
> to compile waffle is version 2.8
> ---
> CMakeLists.txt |2 +-
> 1 file changed, 1 insertion(+),
464?siteid=9
> kitware - news: cmake 2.8.0 released ( November 4,2009)
> http://www.kitware.com/news/home/browse/252?siteid=9
> kitware - news: cmake 2.6.4 released ( May 5, 2009 )
> http://www.kitware.com/news/home/browse/229?siteid=9
>
> On Oct 1, 2013 4:37 PM, "
On Tuesday, October 01, 2013 10:42:39 PM Ken Phillis Jr wrote:
> Since i got a few emails over this particular change... I will go ahead and
> explain the primary reason for this change. It's a minor change when you
> consider that most current linux distributions have included some version
> of cm
On Sunday, October 13, 2013 10:51:50 PM Kenneth Graunke wrote:
> On 09/27/2013 02:39 PM, Dylan Baker wrote:
> > This code tests the way Summary.py assigns statuses to tests.
> > Specifically it tests regressions, fixes, changes, and problems,
> > assuring that only the co
On Sunday, October 13, 2013 11:08:27 PM Kenneth Graunke wrote:
> On 09/27/2013 02:39 PM, Dylan Baker wrote:
> > Fixes status hanlding (fixes, regressions, changes) to be compliant with
> > the status handling in framework_tests/summary.py. Mainly this addresses
> > notrun -&g
On Sunday, October 13, 2013 11:13:48 PM Kenneth Graunke wrote:
> On 09/27/2013 02:39 PM, Dylan Baker wrote:
> > These status classes are intended to replace the string statuses
> > currently used by piglit summary.
> >
> > They give a couple of very nice advantages,
On Sunday, October 13, 2013 11:29:02 PM Kenneth Graunke wrote:
> On 09/27/2013 02:39 PM, Dylan Baker wrote:
> > This adds code in framework/summary.py and framework/core.py to make use
> > of the status classes in status.py. This makes comparisons between
> > statuses muc
Currently glean can only return dmesg-warn, dmesg-fail, fail, and pass.
Which means that skip will never be returned even if should be. This
patch adds a catch to find a skip status and return it.
Signed-off-by: Dylan Baker
---
framework/gleantest.py | 4 +++-
1 file changed, 3 insertions(+), 1
Don't clutter the namespace needlessly, just import the full module and
use it.
Signed-off-by: Dylan Baker
---
framework/summary.py | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index 2fecc0c..c6b903b 100644
This is equivalent but simpler.
Signed-off-by: Dylan Baker
---
framework/summary.py | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index c6b903b..62cd91a 100644
--- a/framework/summary.py
+++ b/framework/summary.py
This is groundwork for getting us down to one loader for results.
Signed-off-by: Dylan Baker
---
framework/summary.py | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index 62cd91a..1a15fa7 100644
This adds an optional argument to the constructor for a results file.
This fixes a race condition where a TestrunResult is created, some
entries are added, and then parseFile is called, which overwrites the
contents of the TestrunResult.
Signed-off-by: Dylan Baker
---
framework/core.py| 45
This reduces code duplication, since these two functions were very
similar to begin with.
Signed-off-by: Dylan Baker
---
framework/core.py| 28 +---
framework/summary.py | 18 +-
2 files changed, 18 insertions(+), 28 deletions(-)
diff --git a
This is in keeping with PEP8 sytle guidelines for function names:
"Function names should be lowercase, with words separated by underscores
as necessary to improve readability."
Signed-off-by: Dylan Baker
---
framework/core.py | 2 +-
framework/summary.py| 2 +-
piglit-merge-
This changes some camelCase variables to lowercase underscore separated
variables per PEP8, and a few other minor style nits. There are no
functional changes.
Signed-off-by: Dylan Baker
---
framework/summary.py | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a
Fix style issues with camel case method names.
Signed-off-by: Dylan Baker
---
framework/summary.py | 4 ++--
piglit-summary-html.py | 2 +-
piglit-summary.py | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index 67184b2
This is the commonly excepted "right way" in python.
Signed-off-by: Dylan Baker
---
framework/summary.py | 77
1 file changed, 36 insertions(+), 41 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index 3ab71f
This converts Status objects attributes to class attributes. This should
reduce lookup time and memory consumption of these classes.
Signed-off-by: Dylan Baker
---
framework/status.py | 51 +++
1 file changed, 35 insertions(+), 16 deletions
This patch produces the exact same output as the previous approach, just
in a much simpler way. It also moves some more of the status information
out of if branches and into the Status class in the status module.
Signed-off-by: Dylan Baker
---
framework/status.py | 6 ++-
framework
This was broken by a previous commit 06b185187, this patch corrects
that oversight allowing exclude to continue working.
Signed-off-by: Dylan Baker
---
piglit-summary-html.py | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/piglit-summary-html.py b/piglit
On Tuesday, October 15, 2013 06:16:53 PM Kenneth Graunke wrote:
> On 10/15/2013 03:58 PM, Dylan Baker wrote:
> > This was broken by a previous commit 06b185187, this patch corrects
> > that oversight allowing exclude to continue working.
> >
> >
if it fails.
In the summary path on a single run of quick.tests, simplejson is about
3-4 seconds faster than json, ~7 seconds vs ~11 seconds.
Signed-off-by: Dylan Baker
---
framework/core.py | 5 -
framework/shader_test.py | 5 -
framework/tests/summary.py | 5 -
glapi
On Thursday, October 17, 2013 05:17:03 PM Chris Forbes wrote:
> +def generate_HTML(self, destination, exclude):
>
> Would probably go with 'generate_html'
>
> On Tue, Oct 15, 2013 at 11:13 PM, Dylan Baker
wrote:
> > Fix style issues with camel case metho
On Thursday, October 17, 2013 04:58:34 PM Chris Forbes wrote:
> Much better :)
>
> Reviewed-by: Chris Forbes
>
> On Tue, Oct 15, 2013 at 11:13 PM, Dylan Baker
wrote:
> > This is the commonly excepted "right way" in python.
> >
> > Signed-off-b
This is groundwork for moving more of the logic into mako and killing
the HTMLIndex class in summary.
---
templates/index.mako | 77
1 file changed, 47 insertions(+), 30 deletions(-)
diff --git a/templates/index.mako b/templates/index.mako
inde
This buys two things, a little less code duplication, and allows us to
load one mako template into another one.
Signed-off-by: Dylan Baker
---
framework/summary.py | 54 +++-
1 file changed, 24 insertions(+), 30 deletions(-)
diff --git a
This is easily the ugliest remaining part of the new summary code, this
series addresses this by first simplifying the class, and then moving
the necessary parts into the mako template.
Patches 1-3 lay groundwork for moving more logic into mako
Patch 4 moves some content into the mako templates th
Signed-off-by: Dylan Baker
---
templates/functions.mako | 61
templates/index.mako | 54 ++
2 files changed, 68 insertions(+), 47 deletions(-)
create mode 100644 templates/functions.mako
diff --git a
This moves the irregular entries (like the tabs) to the mako template
and out of the summary module.
Signed-off-by: Dylan Baker
---
framework/summary.py | 32
templates/index.mako | 31 +--
2 files changed, 37 insertions(+), 26
Basically this patch replaces the returnList() function with
os.path.relpath(), which can be used to return essentially the same
output.
Signed-off-by: Dylan Baker
---
framework/summary.py | 116 ++-
1 file changed, 31 insertions(+), 85 deletions
This should make it a little easier for someone looking through the code
to understand what these templates are for.
example: index.mako -> index.html.mako
Signed-off-by: Dylan Baker
---
framework/summary.py | 8 +--
templates/empty_status.html.mako | 27 +
templa
on to the process.
Signed-off-by: Dylan Baker
---
framework/summary.py | 124 ++-
templates/functions.mako | 8 +--
templates/index.mako | 81 ++-
3 files changed, 66 insertions(+), 147 deletions(-)
diff --
the
> subtests. This also eliminates the work-around for NVIDIA's
> glEndTransformFeedback-while-paused bug.
>
> The code currently in all.tests for getting the list of subtests is
> just a place holder. We'll want to refactor this out somewhere else
&g
Specifically for glean tests setting certain environment variables are
needed to run a certain subtest in glean. This patch prints that in the
HTML results.
CC: matts...@gmail.com
Signed-off-by: Dylan Baker
---
framework/summary.py | 3 +++
templates/test_result.mako | 8
2 files
-by: Dylan Baker
---
framework/summary.py | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index 3e5c24e..6084621 100644
--- a/framework/summary.py
+++ b/framework/summary.py
@@ -361,8 +361,12 @@ class Summary:
# Create
Traceback
>
> - ${traceback}
> + ${traceback | h}
>
>
>
> dmesg
>
> - ${dmesg}
> + ${dmesg | h}
>
>
>
I had not idea mako had that feature, but it's dan
This converts Status objects attributes to class attributes. This should
reduce lookup time and memory consumption of these classes.
Tested-by: Ben Widawsky
Signed-off-by: Dylan Baker
---
framework/status.py | 51 +++
1 file changed, 35
ested-by: Ben Widawsky
Signed-off-by: Dylan Baker
---
framework/status.py | 6 +-
framework/summary.py | 153 +++
2 files changed, 48 insertions(+), 111 deletions(-)
diff --git a/framework/status.py b/framework/status.py
index a265317..2fe153e 1
On Sunday, October 27, 2013 04:31:21 PM Ian Romanick wrote:
> On 10/18/2013 10:54 AM, Dylan Baker wrote:
> > On Friday, October 04, 2013 06:11:01 PM Ian Romanick wrote:
> >> From: Ian Romanick
> >>
> >> This covers most of the errors mentioned in the spec
On Friday, October 25, 2013 05:40:47 PM Aaron Watry wrote:
> Pretty basic, but we didn't have any tests for this before...
>
> Tested on r600g w/ CEDAR.
> ---
> generated_tests/generate-cl-math-builtins.py | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/generated_tests/generate-
On Monday, October 28, 2013 11:38:07 AM Ian Romanick wrote:
> On 10/28/2013 10:29 AM, Kenneth Graunke wrote:
> > On 10/15/2013 05:32 PM, Ian Romanick wrote:
> >> From: Ian Romanick
> >>
> >> The utility is that all.tests can do 'sometest -list-subtests' to
> >> automatically get the list of subte
On Tuesday, October 29, 2013 10:35:42 PM Peter Wu wrote:
> Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This
> test verifies two aspects:
>
> - Computation of the second round of a HMAC (using SHA-1).
> - A calculation of the PMK key.
>
> Both tests use test vectors from I
On Tuesday, October 29, 2013 07:58:11 PM Tom Stellard wrote:
> On Tue, Oct 29, 2013 at 04:42:19PM -0700, Dylan Baker wrote:
> > On Tuesday, October 29, 2013 10:35:42 PM Peter Wu wrote:
> > > Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This
> > &g
On Wednesday, October 30, 2013 10:00:28 AM Peter Wu wrote:
> (see below, it is about the Pyrit license)
>
> On Tuesday 29 October 2013 17:06:10 Dylan Baker wrote:
> > On Tuesday, October 29, 2013 07:58:11 PM Tom Stellard wrote:
> > > On Tue, Oct 29, 2013 at 04:42:19PM
s/funtion/function/
On Wednesday, October 30, 2013 04:01:09 PM Yi Sun wrote:
> Via the new arg, we can configure the vector size while generating the
> test.cl. For NOT disturbing previous test cases, set a default value.
>
> Signed-off-by: Yi Sun
>
> diff --git a/generated_tests/genclbuiltins.
Working with paths is hard, and we don't always do it right. Instead of
trying to be perfect, just use python's os.path module to do all of the
hard work for us
Signed-off-by: Dylan Baker
---
framework/core.py | 9 +
framework/exectest.py | 2 +-
framework/gleant
On Thursday, October 31, 2013 09:48:09 AM Kenney Phillis wrote:
> The find_package(PythonInterp) for cmake version 2.8.6 and newer is
> capable of properly handling multiple versions of python. This is
> extremely useful on mixed systems where a person may have Python2 and
> Python3 installed side
ns')
> +pages = ('changes', 'problems', 'skipped', 'fixes',
> 'regressions','crashed')
You need a space after the comma between regressions and crashed
You will also need to wrap the line, since with the extra element will exc
On Friday, November 01, 2013 12:20:46 AM Yi Sun wrote:
> Sometimes we should handle scalar/vector types separately.
> For example some builtin functions only support scalar type input,
> and some relational builtin functions get different results between
> scalar and vector type though with the sam
Could you add a note about python code?
Just something like: "All python code should conform to python's PEP8
standard, using only spaces and no tabs" would be great.
On Fri, Nov 1, 2013 at 1:50 PM, Paul Berry wrote:
> On 1 November 2013 08:14, Brian Paul wrote:
>
>> I've tried to describe Pi
This patch replaces home-rolled code with built-in python functions,
this results in cleaner, simpler, and faster code.
Signed-off-by: Dylan Baker
---
framework/summary.py | 124 +++
1 file changed, 36 insertions(+), 88 deletions(-)
diff --git a
Moving the column headers out of the HTMLIndex class simplifies the
class, since the code that existed for handling this was special case.
Signed-off-by: Dylan Baker
---
framework/summary.py | 17 +
templates/index_columns.mako | 7 +++
2 files changed, 12
formatting changes.
- replace tabs with 8 spaces
- fix long lines
- remove trailing semicolons
- fix hanging indent problems
- add two spaces before and after top level classes and functions
- use os.path.join instead of concat
Signed-off-by: Dylan Baker
---
tests/igt.tests | 73
This change does a couple of really nice things for us, first it cuts
down on the memory consumption by using a generator (which is lazy).
Further, as a part of the Summary.generate_html() method it doesn't need
to have the summary instance passed to it, reducing complexity.
Signed-off-by:
This is groundwork for simplifying the generation of the HTML pages.
Signed-off-by: Dylan Baker
---
framework/summary.py | 25 --
templates/index.mako | 81 --
templates/index_body.mako | 41 +++
templates
This change reduces code duplication by setting arguments to the
templates to be set once, rather than once per template.
Signed-off-by: Dylan Baker
---
framework/summary.py | 56 ++--
1 file changed, 24 insertions(+), 32 deletions(-)
diff --git
This code was left over from an early iteration of the code, and isn't
used.
Signed-off-by: Dylan Baker
---
templates/index_body.mako | 4
1 file changed, 4 deletions(-)
diff --git a/templates/index_body.mako b/templates/index_body.mako
index 0056912..9e67311 100644
--- a/temp
On Tuesday, November 05, 2013 09:38:16 AM Ian Romanick wrote:
> On 11/04/2013 10:18 PM, Matt Turner wrote:
> > We'd like to shrink the window sizes of shader runner when running in
> > simulation, and ortho tests make it difficult to reason about reducing
> > the window size.
> >
> > The following
es don't try to place invalid
> characters that lead to programs failing.
>
>
> As a tip, Just run the glean tests on windows and then try to make a html
> output for it... It'll fail every time due to invalid characters... I have
> tested this on Windows 7 and it sh
This stops subtests from being written as full entries in the json.
Instead, in the summary code the test with subtests is treated as a
group, and the subtests as real tests.
Signed-off-by: Dylan Baker
---
framework/core.py | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
This patch causes tests with subtests to be treated as a group, rather
than as a test. This means that the status the test itself stores will
be overwritten by those in the subtest.
Signed-off-by: Dylan Baker
---
framework/summary.py | 33 +++--
1 file changed, 31
1 - 100 of 3756 matches
Mail list logo
