[Impala-ASF-CR] Impala ABM / LZCNT support

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: Impala ABM / LZCNT support .. Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2 calculation. Turns out this can be done much

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#18). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLAC

[Impala-ASF-CR] IMPALA-4810: Make DECIMAL expr-test cases table driven

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven .. Patch Set 1: Code-Review+1 Looks pretty straightforward -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/18/be/src/udf/udf.h File be/src/udf/udf.h: PS18, Line 582:

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-07 Thread Zach Amsden (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#19). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Imple

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-08 Thread Zach Amsden (Code Review)
Hello Impala Public Jenkins, Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#20). Change subject: IMPALA-4729: Implement REPLACE() ...

[Impala-ASF-CR] Impala ABM / LZCNT support

2017-02-08 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: Impala ABM / LZCNT support .. Impala ABM / LZCNT support I recently added some code that wants to do upwards power of 2 calculation. Turns out this can be done much

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-08 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/5951 Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. IMPALA-2020: Add rounding when casting from decimal to int P

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-08 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. IMPALA-2020: Add rounding when casting from decimal to int Preview diff, not working yet, mostly to see

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-08 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. IMPALA-2020: Add rounding when casting from decimal to int Preview diff, not working yet, mostly to see

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: > I'm not opposed to cleaning up the AnyVal stuff like that, but > given that udf.h stu

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-09 Thread Zach Amsden (Code Review)
Hello Impala Public Jenkins, Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#21). Change subject: IMPALA-4729: Implement REPLACE()

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-09 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. IMPALA-2020: Add rounding when casting from decimal to int First implementation of rounding mode on CAS

[Impala-ASF-CR] IMPALA-4809: Add Stability for codegen constants

2017-02-09 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-4809: Add Stability for codegen constants .. Abandoned Conflicts with Michael's constant injection refactor. -- To view, visit http://gerrit.cloudera.org:8080/5848

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-09 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/3/be/src/runtime/decimal-value.in

[Impala-ASF-CR] IMPALA-2020: Add rounding when casting from decimal to int

2017-02-09 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding when casting from decimal to int .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/4/be/src/udf/udf.h File be/src/udf

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-10 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMAL

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/decimal-operators-ir.cc File be/s

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5952 To unsub

[Impala-ASF-CR] IMPALA-4370: Divide and modulo result types for DECIMAL version V2

2017-02-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4370: Divide and modulo result types for DECIMAL version V2 .. Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/5952/8/be/src/runtime/decima

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-13 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMAL

[Impala-ASF-CR] IMPALA-4809: Enable support for DECIMAL V2 in decimal casting.py

2017-02-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5989/1/tests/query_

[Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".

2017-02-13 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". .. Patch Set 5: Jim, if you haven't done so already, I resolved the merge conflicts here agai

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-02-14 Thread Zach Amsden (Code Review)
Hello Impala Public Jenkins, Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5776 to look at the new patch set (#23). Change subject: IMPALA-4729: Implement REPLACE()

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-14 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMAL

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-14 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/literal.cc File be/src/exprs/lite

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-14 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMAL

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-14 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMAL

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-14 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 9: (10 comments) http://gerrit.cloudera.org:8080/#/c/5951/9/be/src/exprs/decimal-operators-ir.cc File be/

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-14 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/9/be/src/runtime/decimal-value.inline.h File be/s

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-14 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#10). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMA

[Impala-ASF-CR] IMPALA-2020: Make it easy to work with big numbers

2017-02-14 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-2020: Make it easy to work with big numbers .. IMPALA-2020: Make it easy to work with big numbers Well the generic form turned out to not be super useful beca

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 9: (11 comments) http://gerrit.cloudera.org:8080/#/c/5951/10//COMMIT_MSG Commit Message: PS10, Line 10:

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/5/be/src/exprs/literal.cc File be/src/exprs/liter

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/10/be/src/runtime/decimal-value.inline.h File be

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#11). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMA

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 11: I have not updated the Python test yet, as that would require a rebase. Python test and benchmark wi

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-16 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#12). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMA

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/12/be/src/runtime/decimal-value.inline.h File b

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#13). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMA

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#15). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMA

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big number strings We can directly spcecify these in the header instead of keeping the constants out in

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5902/5/be/src/exprs/expr-value.h File be/src/exprs/expr-va

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6068 Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. IMPALA-4936 and IMPALA-4915: Fix decimal overflow test The root

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. IMPALA-4936 and IMPALA-4915: Fix decimal overflow test The root cause of both behaviors turned out to be th

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-02-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big number strings We can directly spcecify these in the header instead of keeping the constants out in

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 12: (8 comments) http://gerrit.cloudera.org:8080/#/c/5951/15//COMMIT_MSG Commit Message: Line 122 > Sure

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#16). Change subject: IMPALA-2020: Add rounding for decimal casts .. IMPALA-2020: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding behavior for both DECIMA

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 10: (1 comment) I am trying to get the DCHECK_EQ to work with int128_t, for which we do provide a defini

[Impala-ASF-CR] IMPALA-2020: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Add rounding for decimal casts .. Patch Set 16: (1 comment) After fighting the compiler for over an hour to figure out why our operator<< was not be

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#17). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/17/be/src/exprs/expr-test.cc File be

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. Patch Set 2: (3 comments) I'm folding this into the cast change anyway. http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#18). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6068/2/be/src/exprs/expr-test.cc File be/s

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#19). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 18: (4 comments) Nope, doesn't solve the DCHECK issue. I added a DCHECK that the static cast

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#20). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#21). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-2020, 4915, 4936: Add rounding for decimal casts This change adds support for DECIMAL_V2 rounding

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-21 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 18: > Uploaded patch set 20. > Uploaded patch set 21. rebased and fixed merge conflict --

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/21/be/src/runtime/decimal-value.inli

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Zach Amsden (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5951 to look at the new patch set (#22). Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. IMPALA-

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-22 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/5951/21/be/src/exprs/expr-test.cc File b

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

2017-02-23 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6068/2/be/src/runtime/decimal-value.inline.

[Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

2017-02-23 Thread Zach Amsden (Code Review)
Zach Amsden has abandoned this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test .. Abandoned Rolled this into casting change -- To view, visit http://gerrit.cloudera.org:8080/6068 To unsubscribe,

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-23 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6132 Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and mult

[Impala-ASF-CR] IMPALA-2020, 4915, 4936: Add rounding for decimal casts

2017-02-23 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts .. Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/5951/22/be/src/runtime/decimal-value.inli

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-23 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 2: (12 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/6132/2//COMMIT_MSG Commit Mess

[Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests

2017-02-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests .. Patch Set 1: Code-Review+1 Looks simple and correct. Maybe add a 39 digit overflow test and a 39 digit

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-24 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6132/2/be/src/exprs/decimal-operators-ir.cc File be/src

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-26 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-26 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 3: Note to reviewers - this diff is only partially ready for review. I wanted to send it anyway to gather

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/2/be/src/runtime/decimal-value.inline.h File be/src

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-27 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 4: Code is ready for review, I don't anticipate much in the way of change there. There are some pre-existi

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 4: (11 comments) http://gerrit.cloudera.org:8080/#/c/6132/4/be/src/runtime/decimal-value.h File be/src/runt

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-27 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#5). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 5: (9 comments) http://gerrit.cloudera.org:8080/#/c/6132/2/be/src/exprs/decimal-operators-ir.cc File be/src

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#6). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/6132/6/be/src/runtime/decimal-value.inline.h File be/sr

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#7). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 7: Okay, this is good for review. Sorry for so many test cases - but they ended up finding a few good bugs

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/runtime/decimal-test.cc File be/src/runtim

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-02-28 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 8: (12 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/exprs/expr-test.

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/6132/8/be/src/runtime/decimal-test.cc File be/src/runti

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-01 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#10). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/10/be/src/runtime/types.h File be/src/runtime/type

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-01 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#11). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-01 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#12). Change subject: IMPALA-4813: Round on divide and multiply .. IMPALA-4813: Round on divide and multiply Address rounding on divide and multiply when results are truncated. Testing:

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-01 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#8). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big number strings We can directly spcecify these in the header instead of keeping the constants out in

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-01 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 13: Oh nice, I thought I would have to rebase and fix the conflicts. Thanks! -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-4813: Round on divide and multiply

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4813: Round on divide and multiply .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/6132/15/be/src/exprs/expr-test.cc File be/src/exprs/exp

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 8: (1 comment) Also fixing the too long lines http://gerrit.cloudera.org:8080/#/c/5902/8/be/src/util/decimal-

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#9). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big number strings We can directly spcecify these in the header instead of keeping the constants out in

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/5902/5//COMMIT_MSG Commit Message: PS5, Line 27: Query: s

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5902 to look at the new patch set (#10). Change subject: IMPALA-2020: Inline big number strings .. IMPALA-2020: Inline big

[Impala-ASF-CR] IMPALA-2020: Inline big number strings

2017-03-02 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-2020: Inline big number strings .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/5902/5//COMMIT_MSG Commit Message: PS5, Line 38: 0.83s >

  1   2   3   4   5   >