[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/3643/8/src/kudu/tserver/hear

[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: c++ client: use operation timeout as deadline for finding new leader master .. Patch Set 2: to work around in that particular test, why not explicitly wait for a

[kudu-CR](gh-pages) www: Add list of committers to the site

2016-07-21 Thread Mike Percy (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3721 to review the following change. Change subject: www: Add list of committers to the site .. www: Add list of committers

[kudu-CR](gh-pages) www: Add list of committers to the site

2016-07-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: www: Add list of committers to the site .. Patch Set 1: Rendered HTML: http://mpercy.github.io/kudu/committers.html -- To view, visit http://gerrit.cloudera.org:8

[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: c++ client: use operation timeout as deadline for finding new leader master .. Patch Set 2: > to work around in that particular test, why not explicitly wait for

[kudu-CR] Remove ASF incubation callouts

2016-07-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Remove ASF incubation callouts .. Patch Set 1: Code-Review+2 If you want to update the mailing list archive links in a follow-up commit, that's fine with me too.

[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. Patch Set 2: (3 comments) Seems like the path of least resistance. I was inclined to vote for re

[kudu-CR] KUDU-1538: prevent block ID reuse to avoid potential data loss

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1538: prevent block ID reuse to avoid potential data loss .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3719/2/src/kudu/fs/log_block_manage

[kudu-CR] WIP: KUDU-1271: allow primary keys not at the start of the row

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3722 Change subject: WIP: KUDU-1271: allow primary keys not at the start of the row .. WIP: KUDU-1271: allow primary keys not at the start of th

[kudu-CR] WIP: KUDU-1271: allow primary keys not at the start of the row

2016-07-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: KUDU-1271: allow primary keys not at the start of the row .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2615/ -- To view, visit http:

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2617/ -- To view, visit http://gerrit.cl

[kudu-CR] client/sample.cc: fixed a couple of crashes

2016-07-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client/sample.cc: fixed a couple of crashes .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2616/ -- To view, visit http://gerrit.cloudera.o

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3723 Change subject: C++ client: deprecating KuduPartialRow::SetString() .. C++ client: deprecating KuduPartialRow::SetString() KuduPartialRo

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/2618/ -- To view, visit htt

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-21 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3648 to look at the new patch set (#13). Change subject: KUDU-1311 [master] support adding and dropping range partitions

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-21 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 13: Got a clean loop an alter_table-test, and consistently get about 0.5% failures on

[kudu-CR](gh-pages) www: Add list of committers to the site

2016-07-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: www: Add list of committers to the site .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3721 To unsubscribe, visit http://gerrit.c

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3723/1/src/kudu/client/stubs.h File src/kudu/cl

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/3648/12/src/kudu/integration-test

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Fix a race involving the read timeout .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2619/ -- To view, visit http://gerrit.cl

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3724 Change subject: [java client] Fix a race involving the read timeout .. [java client] Fix a race involving the read timeout The Read

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Fix a race involving the read timeout .. Patch Set 1: (1 comment) It would be nice to see a test that hits this too. Generally speaking, the main ad

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix a race involving the read timeout .. Patch Set 1: > (1 comment) > > It would be nice to see a test that hits this too. Generally > spe

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Fix a race involving the read timeout .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2620/ -- To view, visit http://gerrit.cl

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix a race involving the read timeout .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3724/1//COMMIT_MSG Commit Message: Lin

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3724 to look at the new patch set (#2). Change subject: [java client] Fix a race involving the read timeout .. [java cli

[kudu-CR] [java client] Fix a race involving the read timeout

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Fix a race involving the read timeout .. Patch Set 2: Code-Review+2 > > (1 comment) > > > > It would be nice to see a test that hits this too. Gener

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2621/ -- To view, visit http://gerrit.cl

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3723/1/src/kudu/client/stubs.h File src/kudu

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3723 to look at the new patch set (#2). Change subject: C++ client: deprecating KuduPartialRow::SetString() .. C++ clien

[kudu-CR] C++ client: deprecating KuduPartialRow::SetString()

2016-07-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: C++ client: deprecating KuduPartialRow::SetString() .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3723 To unsubscribe, visit http

[kudu-CR](gh-pages) www: Add list of committers to the site

2016-07-21 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: www: Add list of committers to the site .. www: Add list of committers to the site Change-Id: Ie3a246e4fdb4656dda4485dcccd3e04bec04b39d Reviewed-on: http:/

[kudu-CR](gh-pages) www: Add list of committers to the site

2016-07-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: www: Add list of committers to the site .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3721 To unsubscribe, visit http://gerrit.cloud