[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180613972 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,50 @@ object ReorderJoin extends Rule[LogicalPla

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21018 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2183/ Tes

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21018 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21018: [SPARK-23880][SQL] Do not trigger any jobs for caching d...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21018 **[Test build #89162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89162/testReport)** for PR 21018 at commit [`313f44b`](https://github.com/apache/spark/commit/31

[GitHub] spark pull request #20963: [SPARK-23849][SQL] Tests for the samplingRatio op...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20963#discussion_r180610436 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2127,4 +2127,39 @@ class JsonSuite extends Qu

[GitHub] spark issue #21017: [SPARK-23748][SS] Fix SS continuous process doesn't supp...

2018-04-10 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/21017 @jose-torres @tdas would you please help to review, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #21009: [SPARK-23905][SQL] Add UDF weekday

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21009 **[Test build #89161 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89161/testReport)** for PR 21009 at commit [`2b5db56`](https://github.com/apache/spark/commit/2b

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21026 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21026 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89157/ Test PASSed. ---

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21026 **[Test build #89157 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89157/testReport)** for PR 21026 at commit [`8ab0931`](https://github.com/apache/spark/commit/8

[GitHub] spark issue #21009: [SPARK-23905][SQL] Add UDF weekday

2018-04-10 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/21009 I did the local testing, all pass. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark issue #21009: [SPARK-23905][SQL] Add UDF weekday

2018-04-10 Thread yucai
Github user yucai commented on the issue: https://github.com/apache/spark/pull/21009 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: rev

[GitHub] spark pull request #20963: [SPARK-23849][SQL] Tests for the samplingRatio op...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20963#discussion_r180605579 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2127,4 +2127,39 @@ class JsonSuite extends Qu

[GitHub] spark pull request #21015: [SPARK-23944][ML] Add the set method for the two ...

2018-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21015 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21015: [SPARK-23944][ML] Add the set method for the two LSHMode...

2018-04-10 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/21015 LGTM Merging with master Thanks @ludatabricks ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #15770: [SPARK-15784][ML]:Add Power Iteration Clustering to spar...

2018-04-10 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15770 @wangmiao1981 Do let me know if you're too busy now to resume this; I know it's been a long time. Thanks! --- - To unsubscri

[GitHub] spark issue #20964: [SPARK-22883] ML test for StructuredStreaming: spark.ml....

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20964 **[Test build #4151 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4151/testReport)** for PR 20964 at commit [`6dff94e`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #20964: [SPARK-22883] ML test for StructuredStreaming: spark.ml....

2018-04-10 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20964 Thanks! I'll rerun tests since they are stale and merge after they pass. --- - To unsubscribe, e-mail: reviews-unsubscr...@spa

[GitHub] spark issue #21013: [WIP][SPARK-23874][SQL][PYTHON] Upgrade Arrow and pyarro...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21013 > do you suggest we should test with the minimum version and current version of pyarrow? yup. --- - To unsubscribe

[GitHub] spark pull request #21034: [SPARK-23926][SQL] Extending reverse function to ...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21034#discussion_r180602624 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -212,6 +213,96 @@ case class SortArray(bas

[GitHub] spark issue #21013: [WIP][SPARK-23874][SQL][PYTHON] Upgrade Arrow and pyarro...

2018-04-10 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/21013 Closing this now, will reopen when the issue is resolved in the next Arrow release --- - To unsubscribe, e-mail: reviews-uns

[GitHub] spark pull request #21013: [WIP][SPARK-23874][SQL][PYTHON] Upgrade Arrow and...

2018-04-10 Thread BryanCutler
Github user BryanCutler closed the pull request at: https://github.com/apache/spark/pull/21013 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.or

[GitHub] spark pull request #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpa...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21007#discussion_r180602148 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/TestQueryExecutionListener.scala --- @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Sof

[GitHub] spark issue #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpark as a...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21007 will address the comments soon. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #20560: [SPARK-23375][SQL] Eliminate unneeded Sort in Opt...

2018-04-10 Thread henryr
Github user henryr commented on a diff in the pull request: https://github.com/apache/spark/pull/20560#discussion_r179003707 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -274,3 +279,7 @@ abstract class BinaryNode extend

[GitHub] spark pull request #20560: [SPARK-23375][SQL] Eliminate unneeded Sort in Opt...

2018-04-10 Thread henryr
Github user henryr commented on a diff in the pull request: https://github.com/apache/spark/pull/20560#discussion_r180601594 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -733,6 +735,17 @@ object EliminateSorts extends Rule[Lo

[GitHub] spark pull request #20560: [SPARK-23375][SQL] Eliminate unneeded Sort in Opt...

2018-04-10 Thread henryr
Github user henryr commented on a diff in the pull request: https://github.com/apache/spark/pull/20560#discussion_r180592716 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala --- @@ -22,10 +22,11 @@ import org.apache.spark.sql.{execution, Row}

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21026 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2182/ Tes

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21026 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21026 **[Test build #89160 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89160/testReport)** for PR 21026 at commit [`e6abd22`](https://github.com/apache/spark/commit/e6

[GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...

2018-04-10 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/21026#discussion_r180598651 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala --- @@ -352,12 +346,10 @@ case class IsNotNull(ch

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21026 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2181/ Tes

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21026 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21026 **[Test build #89159 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89159/testReport)** for PR 21026 at commit [`ce39905`](https://github.com/apache/spark/commit/ce

[GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...

2018-04-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/21026#discussion_r180596423 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala --- @@ -352,12 +346,10 @@ case class IsNotNull(chi

[GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...

2018-04-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/21026#discussion_r180593331 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to

[GitHub] spark issue #20959: [SPARK-23846][SQL] The samplingRatio option for CSV data...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20959 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89154/ Test FAILed. ---

[GitHub] spark issue #20959: [SPARK-23846][SQL] The samplingRatio option for CSV data...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20959 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20959: [SPARK-23846][SQL] The samplingRatio option for CSV data...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20959 **[Test build #89154 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89154/testReport)** for PR 20959 at commit [`d4e815e`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #20280: [SPARK-22232][PYTHON][SQL] Fixed Row pickling to include...

2018-04-10 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20280 Hey @holdenk , yeah I've been meaning to circle back to this and get some kind of resolution. I'll try to take another look later this week. --- --

[GitHub] spark issue #21003: [SPARK-23871][ML][PYTHON]add python api for VectorAssemb...

2018-04-10 Thread huaxingao
Github user huaxingao commented on the issue: https://github.com/apache/spark/pull/21003 @jkbradley Thank you very much for your help! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21013: [WIP][SPARK-23874][SQL][PYTHON] Upgrade Arrow and pyarro...

2018-04-10 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/21013 Yeah, we should be able to keep the minimum version the same, afaik there is no break in compatibility. @HyukjinKwon so do you suggest we should test with the minimum version and current versio

[GitHub] spark pull request #21003: [SPARK-23871][ML][PYTHON]add python api for Vecto...

2018-04-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21003 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20959: [SPARK-23846][SQL] The samplingRatio option for CSV data...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20959 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89155/ Test FAILed. ---

[GitHub] spark issue #20959: [SPARK-23846][SQL] The samplingRatio option for CSV data...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20959 **[Test build #89155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89155/testReport)** for PR 20959 at commit [`d584cfe`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #20959: [SPARK-23846][SQL] The samplingRatio option for CSV data...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20959 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21003: [SPARK-23871][ML][PYTHON]add python api for VectorAssemb...

2018-04-10 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/21003 Merging with master Thanks @huaxingao ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional c

[GitHub] spark pull request #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpa...

2018-04-10 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/21007#discussion_r180584581 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/TestQueryExecutionListener.scala --- @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Sof

[GitHub] spark pull request #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpa...

2018-04-10 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/21007#discussion_r180584207 --- Diff: python/pyspark/sql/tests.py --- @@ -3062,6 +3062,73 @@ def test_sparksession_with_stopped_sparkcontext(self): sc.stop()

[GitHub] spark pull request #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpa...

2018-04-10 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/21007#discussion_r180583899 --- Diff: python/pyspark/sql/tests.py --- @@ -3062,6 +3062,73 @@ def test_sparksession_with_stopped_sparkcontext(self): sc.stop()

[GitHub] spark pull request #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpa...

2018-04-10 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/21007#discussion_r180585895 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/TestQueryExecutionListener.scala --- @@ -0,0 +1,45 @@ +/* --- End diff -- Is it

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89151/ Test PASSed. ---

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20984 **[Test build #89151 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89151/testReport)** for PR 20984 at commit [`a77128f`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20984 **[Test build #89158 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89158/testReport)** for PR 20984 at commit [`a77128f`](https://github.com/apache/spark/commit/a7

[GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...

2018-04-10 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/21026#discussion_r180575894 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateSafeProjection.scala --- @@ -107,7 +110,7 @@ object Gen

[GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...

2018-04-10 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/21026#discussion_r180583517 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed t

[GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...

2018-04-10 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/21026#discussion_r180575717 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala --- @@ -292,8 +292,7 @@ object G

[GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...

2018-04-10 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/21026#discussion_r180575964 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateSafeProjection.scala --- @@ -76,7 +78,7 @@ object Gener

[GitHub] spark pull request #21026: [SPARK-23951][SQL] Use actual java class instead ...

2018-04-10 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/21026#discussion_r180575803 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateSafeProjection.scala --- @@ -128,7 +131,7 @@ object Gen

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2180/ Tes

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark pull request #20981: [SPARK-23873][SQL] Use accessors in interpreted L...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20981#discussion_r180583831 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala --- @@ -119,4 +119,28 @@ object InternalRow { case v: MapData

[GitHub] spark pull request #20981: [SPARK-23873][SQL] Use accessors in interpreted L...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20981#discussion_r180583775 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -65,11 +65,19 @@ trait ExpressionEvalHelpe

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20984 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h.

[GitHub] spark issue #20992: [SPARK-23779][SQL] TaskMemoryManager and UnsafeSorter re...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20992 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89147/ Test PASSed. ---

[GitHub] spark issue #20992: [SPARK-23779][SQL] TaskMemoryManager and UnsafeSorter re...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20992 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20992: [SPARK-23779][SQL] TaskMemoryManager and UnsafeSorter re...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20992 **[Test build #89147 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89147/testReport)** for PR 20992 at commit [`0e1e0a0`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #21003: [SPARK-23871][ML][PYTHON]add python api for VectorAssemb...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21003 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89156/ Test PASSed. ---

[GitHub] spark issue #21003: [SPARK-23871][ML][PYTHON]add python api for VectorAssemb...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21003 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21003: [SPARK-23871][ML][PYTHON]add python api for VectorAssemb...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21003 **[Test build #89156 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89156/testReport)** for PR 21003 at commit [`65e7a02`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21026 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21026 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2179/ Tes

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20874 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89149/ Test FAILed. ---

[GitHub] spark issue #21026: [SPARK-23951][SQL] Use actual java class instead of stri...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21026 **[Test build #89157 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89157/testReport)** for PR 21026 at commit [`8ab0931`](https://github.com/apache/spark/commit/8a

[GitHub] spark issue #20874: [SPARK-23763][SQL] OffHeapColumnVector uses MemoryBlock

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20874 **[Test build #89149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89149/testReport)** for PR 20874 at commit [`9ef19df`](https://github.com/apache/spark/commit/9

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89152/ Test FAILed. ---

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20984 **[Test build #89152 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89152/testReport)** for PR 20984 at commit [`a77128f`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #21024: [SPARK-23917][SQL] Add array_max function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21024 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21024: [SPARK-23917][SQL] Add array_max function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21024 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89145/ Test PASSed. ---

[GitHub] spark issue #21024: [SPARK-23917][SQL] Add array_max function

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21024 **[Test build #89145 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89145/testReport)** for PR 21024 at commit [`e082f00`](https://github.com/apache/spark/commit/e

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20795 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20795 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89142/ Test PASSed. ---

[GitHub] spark issue #21034: [SPARK-23926][SQL] Extending reverse function to support...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21034 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20795: [SPARK-23486]cache the function name from the external c...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20795 **[Test build #89142 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89142/testReport)** for PR 20795 at commit [`d1ee9cb`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #21034: [SPARK-23926][SQL] Extending reverse function to support...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21034 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21034: [SPARK-23926][SQL] Extending reverse function to ...

2018-04-10 Thread mn-mikke
GitHub user mn-mikke opened a pull request: https://github.com/apache/spark/pull/21034 [SPARK-23926][SQL] Extending reverse function to support ArrayType arguments ## What changes were proposed in this pull request? This PR extends reverse functions to be able to operate ove

[GitHub] spark issue #21003: [SPARK-23871][ML][PYTHON]add python api for VectorAssemb...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21003 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21003: [SPARK-23871][ML][PYTHON]add python api for VectorAssemb...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21003 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2178/ Tes

[GitHub] spark issue #21003: [SPARK-23871][ML][PYTHON]add python api for VectorAssemb...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21003 **[Test build #89156 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89156/testReport)** for PR 21003 at commit [`65e7a02`](https://github.com/apache/spark/commit/65

[GitHub] spark issue #21003: [SPARK-23871][ML][PYTHON]add python api for VectorAssemb...

2018-04-10 Thread huaxingao
Github user huaxingao commented on the issue: https://github.com/apache/spark/pull/21003 @jkbradley Thanks for your comment. I will add "and NaN" in the doc. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.a

[GitHub] spark issue #21031: [SPARK-23923][SQL] Add cardinality function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21031 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21031: [SPARK-23923][SQL] Add cardinality function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21031 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89150/ Test FAILed. ---

[GitHub] spark issue #21031: [SPARK-23923][SQL] Add cardinality function

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21031 **[Test build #89150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89150/testReport)** for PR 21031 at commit [`d405d8a`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationDivisor ...

2018-04-10 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/19881 I thought about this more, and I actually think something like this makes more sense: `executorAllocationRatio`. Basically it is just a ratio that determines how aggressive we want Spark to request ful

[GitHub] spark issue #20959: [SPARK-23846][SQL] The samplingRatio option for CSV data...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20959 **[Test build #89155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89155/testReport)** for PR 20959 at commit [`d584cfe`](https://github.com/apache/spark/commit/d5

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #20871: [SPARK-23762][SQL] UTF8StringBuffer uses MemoryBlock

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20871 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89148/ Test FAILed. ---

<    1   2   3   4   5   6   7   8   >