Re: please test the Subsurface 4.0 binaries uploaded to the website

t; > Anyway, now it works, time for some testing! > > Another solution is for Dirk not to build Marble with a /usr/local prefix. > Use > something that is unlikely any other developer will be using. Like > /Users/hohndel/Marble :-) > That

[PATCH] Planner: don't abort when saving a dive

The fix for dereferencing a null pointer from me was a bad fix that broke the possibility of saving a planned dive as a dive. This is a better fix to not dereference a null pointer and be able to save the plan again. Signed-off-by: Anton Lundin --- qt-ui/diveplanner.cpp | 7 --- 1 file

[PATCH] Add preprocessor directives around debug functions

These adds some ifdef's around some debug functions to disable them when not using them. Signed-off-by: Anton Lundin --- deco.c| 2 ++ profile.c | 18 -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/deco.c b/deco.c index 32705dd..698b331 100644

Unused functions and methods

et.ie/~caolan/Packages/callcatcher.html -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH 2/2] Allow the user to specify weight units explicitly

atible with the weirdness of the imperial system so "thank you" Linus for showing more of the horrors lurking there =) But, i should have spotted that one, cause i actually use a bunch of AL80's and AL40's, not for there fantastic volume units, but f

Re: A quite wierd but intresting screenshot...

On 15 January, 2014 - Dirk Hohndel wrote: > On Tue, 2014-01-14 at 21:20 +0100, Anton Lundin wrote: > > Played around with Qt5 today and managed to produce this. > > > > Looks like crap but its a quite nice proof of concept. > > That's on Android? Wow. Oh, and yo

[PATCH 1/2] Fix linking order of libxslt and libxml

libxslt depends on libxml, so we need xslt before xml on the linker-line. Signed-off-by: Anton Lundin --- subsurface-configure.pri | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subsurface-configure.pri b/subsurface-configure.pri index af90035..242a186 100644 --- a

[PATCH 2/2] Query pkg-config with libxml2 via default name to

On Ubuntu and in the source package, libxml2 defaults to naming its pkg-config file to libxml-2.0.pc so query after the package with that name to. I don't know what platform ships it as libxml2, so that might be a typo. Signed-off-by: Anton Lundin --- subsurface-configure.pri | 4 1

[PATCH 09/13] QAbstractItemModel::reset doesn't exist in Qt5

Let the library resolve this one instead. Signed-off-by: Anton Lundin --- qt-ui/marble/GeoDataTreeModel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/marble/GeoDataTreeModel.h b/qt-ui/marble/GeoDataTreeModel.h index 3a9c5d6..2889b65 100644 --- a/qt-ui/marble

[PATCH 04/13] Remove unused variable

Signed-off-by: Anton Lundin --- dive.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dive.c b/dive.c index 1a9bdd9..7d62616 100644 --- a/dive.c +++ b/dive.c @@ -612,7 +612,6 @@ static void mark_used_tanks(struct dive *dive, struct divecomputer *dc) /* walk all divecomputers to find the

[PATCH 01/13] Use the right Qt-module when building with Qt5

Signed-off-by: Anton Lundin --- subsurface.pro | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/subsurface.pro b/subsurface.pro index d230b38..067a24e 100644 --- a/subsurface.pro +++ b/subsurface.pro @@ -1,6 +1,11 @@ include(subsurface-configure.pri) -QT = core gui

[PATCH 03/13] Port this code to work with Qt5

This code had parts that where Qt5-compatible, this introduces the last bits that it needs to be completely compatible. Signed-off-by: Anton Lundin --- qt-ui/subsurfacewebservices.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui

[PATCH 02/13] Add some missing ; in the Qt5 path

Signed-off-by: Anton Lundin --- qt-ui/subsurfacewebservices.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui/subsurfacewebservices.cpp index 30efbad..1789b03 100644 --- a/qt-ui/subsurfacewebservices.cpp +++ b/qt-ui

[PATCH 11/13] Convert to TRUE/FALSE to stdbools true/false

I had problems with this one on Qt5. Signed-off-by: Anton Lundin --- qt-ui/divelistview.cpp | 18 qt-ui/divelogimportdialog.cpp | 2 +- qt-ui/diveplanner.cpp | 2 +- qt-ui/downloadfromdivecomputer.cpp | 2 +- qt-ui/globe.cpp

[PATCH 08/13] Make this code Qt5 compatible

The method have bin renamed in Qt5. Signed-off-by: Anton Lundin --- qt-ui/divelistview.cpp | 4 1 file changed, 4 insertions(+) diff --git a/qt-ui/divelistview.cpp b/qt-ui/divelistview.cpp index 5a436f2..607f878 100644 --- a/qt-ui/divelistview.cpp +++ b/qt-ui/divelistview.cpp @@ -320,7

[PATCH 10/13] Resync included header with upstream

Signed-off-by: Anton Lundin --- qt-ui/marble/GeoDataTreeModel.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/qt-ui/marble/GeoDataTreeModel.h b/qt-ui/marble/GeoDataTreeModel.h index 2889b65..39eff83 100644 --- a/qt-ui/marble/GeoDataTreeModel.h +++ b/qt-ui/marble

[PATCH 05/13] Remove unused import

Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/qt-ui/mainwindow.cpp b/qt-ui/mainwindow.cpp index 389df3d..a3cb5d4 100644 --- a/qt-ui/mainwindow.cpp +++ b/qt-ui/mainwindow.cpp @@ -14,7 +14,6 @@ #include #include #include -#include

[PATCH 06/13] Use setSectionResizeMode if we use Qt5

Signed-off-by: Anton Lundin --- qt-ui/printlayout.cpp | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/qt-ui/printlayout.cpp b/qt-ui/printlayout.cpp index e60a318..b058bbc 100644 --- a/qt-ui/printlayout.cpp +++ b/qt-ui/printlayout.cpp @@ -219,9 +219,14

[PATCH 07/13] Make the include Qt5 compatible

Signed-off-by: Anton Lundin --- qt-ui/groupedlineedit.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/groupedlineedit.h b/qt-ui/groupedlineedit.h index 0433b06..6003573 100644 --- a/qt-ui/groupedlineedit.h +++ b/qt-ui/groupedlineedit.h @@ -30,7 +30,7 @@ #ifndef

[PATCH 12/13] Don't downgrade tags to Ascii

Use Utf8 everywhere, and toAscii is depricated in Qt5 Signed-off-by: Anton Lundin --- qt-ui/maintab.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/maintab.cpp b/qt-ui/maintab.cpp index be25ea1..9fa94c8 100644 --- a/qt-ui/maintab.cpp +++ b/qt-ui/maintab.cpp

[PATCH 13/13] In Qt5 reset() is depricated.

Signed-off-by: Anton Lundin --- qt-ui/models.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qt-ui/models.cpp b/qt-ui/models.cpp index 82aa312..63b97ad 100644 --- a/qt-ui/models.cpp +++ b/qt-ui/models.cpp @@ -1577,7 +1577,8 @@ void TablePrintModel::insertRow(int index

Re: A quite wierd but intresting screenshot... and how you can make your own...

On 14 January, 2014 - Anton Lundin wrote: > Played around with Qt5 today and managed to produce this. > > Looks like crap but its a quite nice proof of concept. > So, after changing the font size it looked much less crap. A cross build script is now available at https://githu

Re: A quite wierd but intresting screenshot... and how you can make your own...

On 15 January, 2014 - Anton Lundin wrote: > On 14 January, 2014 - Anton Lundin wrote: > > > Played around with Qt5 today and managed to produce this. > > > > Looks like crap but its a quite nice proof of concept. > > > > So, after changing the font size it

Re: [PATCH 11/13] Convert to TRUE/FALSE to stdbools true/false

On 15 January, 2014 - Dirk Hohndel wrote: > On Wed, 2014-01-15 at 13:59 +0200, Lubomir I. Ivanov wrote: > > On 15 January 2014 10:30, Anton Lundin wrote: > > > I had problems with this one on Qt5. > > > > > > > this seems like a big change. could you ela

Re: [PATCH 09/13] QAbstractItemModel::reset doesn't exist in Qt5

On 15 January, 2014 - Thiago Macieira wrote: > On quarta-feira, 15 de janeiro de 2014 09:30:40, Anton Lundin wrote: > > -void reset() { QAbstractItemModel::reset(); } > > +void reset(); > > > > I don't see how this one can compile if reset() is virtual

Re: [PATCH 1/2] Fix linking order of libxslt and libxml

On 15 January, 2014 - Thiago Macieira wrote: > On quarta-feira, 15 de janeiro de 2014 09:27:37, Anton Lundin wrote: > > libxslt depends on libxml, so we need xslt before xml on the linker-line. > > +1 > > I guess that you need this for linking statically to those two li

[PATCH] Convert the C code to using stdbool and true/false

Earlier we converted the C++ code to using true/false, and this converts the C code to using the same style. We already depended on stdbool.h in subsurfacestartup.[ch], and we build with -std=gnu99 so nobody could build subsurface without a c99 compiler. Signed-off-by: Anton Lundin --- deco.c

[PATCH] Don't include stdbool.h when included from C++

As noted by Thiago Macieira, we shouldn't include stdbool.h when were included from a C++-file such as main.cpp Signed-off-by: Anton Lundin --- subsurfacestartup.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/subsurfacestartup.h b/subsurfacestartup.h index e5

Re: [PATCH] Stop doing the (very expensive) pow() calculation pointlessly

thor of the code in question. Anton - mind checking my > commentary on the TTS algorithm in my previous mail in the thread? I > might have missed something.. > I've seen this thread and I'm planning to read it, but I'm kinda busy right now with deliveries to customers, planning

Re: [PATCH] Stop doing the (very expensive) pow() calculation pointlessly

tificial, but its present in our hand-crafted test dives. We could instead add a lager step value than 1 s there, something that the POC-patch i attached suggests. I'm heading off on vacation tomorrow, so it might take a while before i resurface on the mailinglist again. //Anton -- Anton

Re: Everyone please read.... Re: GSOC 2014 is almost here - Volunteer mentors needed

Sorry for answering in a weird place in this thread, I'm on my phone with wherry little internet for another week. I can volunteer as a mentor. I also have another idea for a gsoc project. The idea is to build a ci/cb environment to test build our code on all our platforms and have a good stabl

[PATCH] Convert more TRUE/FALSE to stdbools true/false

In Qt5, Qt doesn't define TRUE/FALSE anymore, so we need to stick to stdbools to have Qt5 builds working. Signed-off-by: Anton Lundin --- qt-ui/profile/diveplotdatamodel.cpp | 2 +- qt-ui/simplewidgets.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

Can't find earth/googlesat/googlesat.dgml on out of source builds

o fix that? One simple idea on how to solve it is just to create a target that copies that folder form the source-tree if it doesn't exist. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohn

Gsoc idea: Android downloader

e.com/p/android-serialport-api/ 2. https://github.com/mik3y/usb-serial-for-android 3. http://www.intra2net.com/en/developer/libftdi/ -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/m

[PATCH 2/3] Add some notes about vim settings for our style

Basic vim settings to mostly follow our coding style. Signed-off-by: Anton Lundin --- CodingStyle | 29 + 1 file changed, 29 insertions(+) diff --git a/CodingStyle b/CodingStyle index a3e4fd1..04fe7f5 100644 --- a/CodingStyle +++ b/CodingStyle @@ -197,3 +197,32

[PATCH 3/3] Remove old leftover header

This got merged into a common divelogimportdialog. Signed-off-by: Anton Lundin --- qt-ui/csvimportdialog.h | 53 - 1 file changed, 53 deletions(-) delete mode 100644 qt-ui/csvimportdialog.h diff --git a/qt-ui/csvimportdialog.h b/qt-ui

[PATCH] Switch profile button events, clicked to toggled

This is needed so the underlaying struct preferences prefs, will be updated when we set the buttons to there previous state after we loaded the settings. Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 26 +- qt-ui/mainwindow.h | 26 +- 2

Re: [PATCH] Make Marble optional

BS += -lmarblewidget > +} > > # > # Platform-specific changes > diff --git a/subsurface.pro b/subsurface.pro > index 81cb906..49865d7 100644 > --- a/subsurface.pro > +++ b/subsurface.pro > @@ -4,7 +4,7 @@ QT = core gui network svg > lessThan(QT_MAJOR_VERSION, 5) { > QT += webkit > } else { > - QT += webkitwidgets > + !android: QT += webkitwidgets > } > INCLUDEPATH += qt-ui $$PWD > DEPENDPATH += qt-ui > -- > 1.8.5.3 > > ___ > subsurface mailing list > subsurface@hohndel.org > http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: GSoC project idea - CMake based build system for Subsurface and libdivecomputer

, but its probably doable. So, we already support windows "native" builds. (msvc must be as native as it gets on windows?) //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

[PATCH] Spelling fix, Its called Ndl

Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 4 ++-- qt-ui/mainwindow.h | 2 +- qt-ui/mainwindow.ui | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qt-ui/mainwindow.cpp b/qt-ui/mainwindow.cpp index 02ac233..a451d7e 100644 --- a/qt-ui/mainwindow.cpp +++ b/qt-ui

[PATCH] Set the prefs-value alongside the button status

Previous code just set the button-"status" based on what we stored on the settings. This sets the corresponding value in our prefs-struct. This fixes the same issue as in 63f7f3, without the side effect of magically hiding the mean depth line. Signed-off-by: Anton Lundin

Re: Gsoc idea: Android downloader

On 03 March, 2014 - Jef Driesen wrote: > On 2014-02-26 09:45, Anton Lundin wrote: > >One idea i bin playing with is how to make the Android port capable of > >downloading data from divecomputers. > > A port of libdivecomputer to Android is also something I'm inte

Re: [PATCH] Add unit support for CSV import

gt; > > - > + > > > > > + > + > + > + > + > + > + > + > + > + > > > > - > + > > > > &

Re: [PATCH] Make Marble optional

t; >> And where would we find those changes? > >> > >> /D > >> > >> > >> > > > ___ > subsurface mailing list > subsurface@hohndel.org > http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] Make Marble optional

uld you elaborate on the: "QSettings had to be included into maintab.h in order for QSettings to be defined." I can't find any reason for that change to interact with the rest of the code. //Anton > On Tue, Mar 04, 2014 at 09:33:13AM +0100, Anton Lundin wrote: > > On 0

Re: Gsoc idea: Android downloader

On 05 March, 2014 - Jef Driesen wrote: > On 2014-03-03 15:41, Dirk Hohndel wrote: > >On Mon, 2014-03-03 at 15:24 +0100, Anton Lundin wrote: > >>For subsurface we don't need no stinking jni wrappers, we run real code! > >>=) > > > >Correct. As native ap

Re: [PATCH] Make Marble optional

k, > > the reason for me continuing this thread was to communicate with you and > > then see if you'd like me to ammend the commit message and or send you the > > patch for your SOB. > > > > > > On Tue, Mar 4, 2014 at 5:34 PM, Anton Lundin wrote: > &g

Re: [PATCH] Make Marble optional

e a really bad idea. Compile time switch is just fine. I'm going diving for a week, so, hopefully others can help in the process. So if/when the rest of the list is happy with your changes to my old code, feel free to add a sob to it and have it merged. //Anton > On Thu, Mar 6, 2014 at

Re: Error during compilation of Libdivecomputer for android

rebase those patches but i ran out of steam when trying to whip libgit2 into the build chain. I pushed out what it looks like so far. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Some subsurface notes from a week of diving

th the weight boxes too. When switching to oxygen(EAN100), the EAD and END values in the info box goes -2147483m. Unsigned zero as signed? Add to trip below is missing. -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org h

Re: Error during compilation of Libdivecomputer for android

On 16 March, 2014 - Anton Lundin wrote: > I started to rebase those patches but i ran out of steam when trying to > whip libgit2 into the build chain. > > I pushed out what it looks like so far. Took some time today and reworked some patches and fixed building with libgit2, so now

Re: Error during compilation of Libdivecomputer for android

On 18 March, 2014 - Venkatesh Shukla IIT BHU wrote: > On Mon, Mar 17, 2014 at 9:35 PM, Anton Lundin wrote: > > > On 16 March, 2014 - Anton Lundin wrote: > > > > > I started to rebase those patches but i ran out of steam when trying to > > > whip libgit2

[PATCH] Don't calculate with NaN when on 100% o2

Fixes: 465 Signed-off-by: Anton Lundin --- profile.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/profile.c b/profile.c index 2102179..20f157c 100644 --- a/profile.c +++ b/profile.c @@ -1131,6 +1131,9 @@ static void calculate_gas_information_new(struct dive *dive, struct plot_info *p

[PATCH] Make dc_number defined when using it

Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/qt-ui/mainwindow.cpp b/qt-ui/mainwindow.cpp index 02c424f..686dc2e 100644 --- a/qt-ui/mainwindow.cpp +++ b/qt-ui/mainwindow.cpp @@ -23,6 +23,7 @@ #include "starwidget.h"

[PATCH] Translate using tr() to be Qt5-compatible

There are no utf8 in those strings, and we can translate them as everything else with tr() instead. QApplication::UnicodeUTF8-part is deprecated and removed in Qt5. Signed-off-by: Anton Lundin --- qt-ui/maintab.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qt

[PATCH] Add forward declaration of QSettings

Its needed for Qt5 Signed-off-by: Anton Lundin --- qt-ui/mainwindow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/qt-ui/mainwindow.h b/qt-ui/mainwindow.h index 971bd17..e249398 100644 --- a/qt-ui/mainwindow.h +++ b/qt-ui/mainwindow.h @@ -28,6 +28,7 @@ class GlobeGPS; class MainTab

[PATCH v2] Translate using tr() to be Qt5-compatible

There are no utf8 in those strings, and we can translate them as everything else with tr() instead. QApplication::UnicodeUTF8-part is deprecated and removed in Qt5. Signed-off-by: Anton Lundin --- qt-ui/maintab.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qt

[PATCH v3] Translate using tr() to be Qt5-compatible

There are no utf8 in those strings, and we can translate them as everything else with tr() instead. QApplication::UnicodeUTF8-part is deprecated and removed in Qt5. Signed-off-by: Anton Lundin --- qt-ui/maintab.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qt

Re: [PATCH v2] Translate using tr() to be Qt5-compatible

On 17 March, 2014 - Anton Lundin wrote: > There are no utf8 in those strings, and we can translate them as > everything else with tr() instead. > QApplication::UnicodeUTF8-part is deprecated and removed in Qt5. > > Signed-off-by: Anton Lundin > --- > qt-ui/maintab.cpp |

New profile, line thickness of pp-graphs and ruler in Qt5

I just played around with Qt5 a bit and noticed that the pp-graph lines are way to thick and the ruler line too. As i really don't understand that qt part, I'm just reporting it. A typical gsoc task for someone wanting to learn Qt to figure out. //Anton -- Anton Lundin+46

Re: New profile, line thickness of pp-graphs and ruler in Qt5

On 18 March, 2014 - Lubomir I. Ivanov wrote: > On 18 March 2014 16:40, Lubomir I. Ivanov wrote: > > On 18 March 2014 16:14, Anton Lundin wrote: > >> I just played around with Qt5 a bit and noticed that the pp-graph lines > >> are way to thick and the ruler line too

Re: New profile, line thickness of pp-graphs and ruler in Qt5

On 18 March, 2014 - Dirk Hohndel wrote: > On Tue, 2014-03-18 at 17:05 +0200, Lubomir I. Ivanov wrote: > > On 18 March 2014 16:40, Lubomir I. Ivanov wrote: > > > On 18 March 2014 16:14, Anton Lundin wrote: > > >> I just played around with Qt5 a bit and noticed that

[PATCH] Link to marbledata when building out of tree

When building and running subsurface out of tree, marbledata was inaccessible to subsurface. Signed-off-by: Anton Lundin --- subsurface.pro | 4 1 file changed, 4 insertions(+) diff --git a/subsurface.pro b/subsurface.pro index 988161f..4cca263 100644 --- a/subsurface.pro +++ b

Marbledata for out of tree builds

Nowadays when i testbuild things for Qt4 and Qt5 ive started to build out of tree to make it easy to compare results. I'm not sure if creating a symlink is the best option, but it works for our main build environments so I'm sending this one out. If someone have a better idea how to solve it in a

Re: New profile, line thickness of pp-graphs and ruler in Qt5

> >>> > On 18 March 2014 16:14, Anton Lundin wrote: > >>> >> I just played around with Qt5 a bit and noticed that the pp-graph lines > >>> >> are way to thick and the ruler line too. > >>> >> > >>> > > >>&

Re: Marbledata for out of tree builds

On 18 March, 2014 - Lubomir I. Ivanov wrote: > On 18 March 2014 18:17, Lubomir I. Ivanov wrote: > > On 18 March 2014 17:51, Anton Lundin wrote: > >> Nowadays when i testbuild things for Qt4 and Qt5 ive started to build > >> out of tree to make it easy to compare resu

Re: Marbledata for out of tree builds

On 18 March, 2014 - Lubomir I. Ivanov wrote: > On 18 March 2014 18:29, Anton Lundin wrote: > > On 18 March, 2014 - Lubomir I. Ivanov wrote: > > > >> On 18 March 2014 18:17, Lubomir I. Ivanov wrote: > >> > On 18 March 2014 17:51, Anton Lundin wrote: > >

[PATCH v2] Link to marbledata when building out of tree

When building and running subsurface out of tree, marbledata was inaccessible to subsurface. Signed-off-by: Anton Lundin --- subsurface.pro | 4 1 file changed, 4 insertions(+) diff --git a/subsurface.pro b/subsurface.pro index 988161f..98f23b7 100644 --- a/subsurface.pro +++ b

Re: Marbledata for out of tree builds

On 18 March, 2014 - Dirk Hohndel wrote: > On Tue, 2014-03-18 at 16:51 +0100, Anton Lundin wrote: > > Nowadays when i testbuild things for Qt4 and Qt5 ive started to build > > out of tree to make it easy to compare results. > > > > I'm not sure if creating a sy

[RFC PATCH] Drop like a stone mode in planner

Anyone with a better idea for a name? --- qt-ui/diveplanner.cpp | 13 + qt-ui/diveplanner.h | 2 ++ qt-ui/diveplanner.ui | 7 +++ 3 files changed, 22 insertions(+) diff --git a/qt-ui/diveplanner.cpp b/qt-ui/diveplanner.cpp index 63a00f7..25a547b 100644 --- a/qt-ui/diveplanner

[PATCH] Enable posibility to add dives to trip below

When I'm on a dive trip i usually download dives multiple times to start logging them while i still remember them. When i have already created a trip and downloads new dives they needs to be able to be added to the already existing trip, without relying on autogroup. Signed-off-by: Anton L

Re: Doubt in deco.c code

ehlmann_He_t_halflife[ci] * 60)); > > } > > > > return cache[ci].last_factor; > > } > > > > > > I get that it's some kind of constant involved, but I'm not exactly > > understanding the supporting theory. > > Kindly, help me with th

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

form the tag list, hit enter and save, the "tag"/"buddy" saved becomes "Bud". If i choose the right tag with the mouse instead of the arrow keys it does the right thing. //Anton -- Anton Lundin+46702-161604 ___ sub

Re: [PATCH 2/2] esc-key would discard the new tag selection

th other "tags" to choose from, but the field ends up behind the dropdown when the "This dive is being edited" blob gets created. If i hit esc to get rid of the dropdown, it removes the "Buddy 1" tag, but subsurface haven't noticed that edit on the textbox so when i h

Re: [PATCH] Fixing ticket #468 Up/Down arrows don't work with tags

On 21 March, 2014 - Gehad wrote: > > On 03/21/2014 12:43 PM, Anton Lundin wrote: > >On 19 March, 2014 - Gehad wrote: > > > >>>From 07f1ac411771627cfba9eae98511d82bbbcdc17b Mon Sep 17 00:00:00 2001 > >>From: Gehad elrobey > >>Date: Wed, 19 Mar

Re: Error while building subsurface-android in fedora

es with cross compiling is if you cross environment detects things from your host environment. Give libxslt's configure a --without-crypto to ignore your libgcrypt form your host. Pushed a fix with that in it. //Anton -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

[PATCH] Fix system default font handling

We didn't care about system default fonts and sizes, we just used the Qt default font. Due to how QFont is constructed, there was need to split font and font size. Signed-off-by: Anton Lundin --- linux.c | 3 ++- macos.c | 3 ++- pref.h | 1 +

[PATCH] Enable parts of planner based on define

In bf205726 DEPTH/Switch at was disabled by commenting out that code. This puts it back behind ifdefs Signed-off-by: Anton Lundin --- qt-ui/diveplanner.cpp | 5 +++-- qt-ui/maintab.cpp | 5 +++-- qt-ui/models.cpp | 22 +++--- qt-ui/models.h| 5 - 4 files

[PATCH] Don't crash if we try to save a empty plan

Just treat it as a cancel instead. Signed-off-by: Anton Lundin --- qt-ui/diveplanner.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qt-ui/diveplanner.cpp b/qt-ui/diveplanner.cpp index da5bb53..ac2662c 100644 --- a/qt-ui/diveplanner.cpp +++ b/qt-ui/diveplanner.cpp @@ -1468,6 +1468,9

Re: [PATCH] Don't crash if we try to save a empty plan

On 22 March, 2014 - Lakshman wrote: > On Sat, Mar 22, 2014 at 9:13 AM, Anton Lundin wrote: > > Just treat it as a cancel instead. > > > > Signed-off-by: Anton Lundin > > --- > > qt-ui/diveplanner.cpp | 3 +++ > > 1 file changed, 3 insertions(+) > >

Re: Qt5 on subsurface-android

uses a bit of Qt5's QAndroidJniObject to discover a good place to store the xml[1]. According to the few parts of the Qt5 touch/android documentation I've read it says that it should be possible to build a touch friendly ui with Qt5 so i would suggest starting in that end. //Anton 1.

Re: Qt5 on subsurface-android

On 25 March, 2014 - Anton Lundin wrote: > On 25 March, 2014 - Martin Gysel wrote: > > > Am 25.03.2014 06:46, schrieb Venkatesh Shukla IIT BHU: > > > On the other hand, the user interface is ugly and functionally useless. > > > In the present condition, it can

[PATCH 3/5] Disable marble on Android

marble uses webkit, and thats not compatible with Android. Signed-off-by: Anton Lundin --- subsurface-configure.pri | 3 +++ 1 file changed, 3 insertions(+) diff --git a/subsurface-configure.pri b/subsurface-configure.pri index 84e2599..28c567f 100644 --- a/subsurface-configure.pri +++ b

[PATCH 4/5] Remove usermanual when building for Android

Our usermanual is based on webkit, and thats not supported in Qt for Android. We should probably replace it with a Android native webview somehow. Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 5 + qt-ui/mainwindow.h | 2 +- qt-ui/usermanual.h | 1 - subsurface

[PATCH 2/5] Introduce android specific file

This contains a first stab at Subsurface platform interfacing code for Android, and surrounding parts. Signed-off-by: Anton Lundin --- android.cpp| 81 ++ subsurface-install.pri | 3 ++ subsurface.pro | 6 ++-- 3 files

[PATCH 1/5] Introduce NO_MARBLE define, make GlobeGPS a dummy

the code. Fixes #394 Signed-off-by: Anton Lundin --- qt-ui/globe.cpp | 10 ++ qt-ui/globe.h| 18 ++ qt-ui/mainwindow.cpp | 4 subsurface-configure.pri | 6 -- 4 files changed, 36 insertions(+), 2 deletions(-) diff --git a/qt-ui

[PATCH 5/5] Remove printing when building for Android

Qt for Android doesn't support printing. Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 5 + qt-ui/printdialog.h | 1 - subsurface-configure.pri | 2 +- subsurface.pro | 16 4 files changed, 18 insertions(+), 6 deletions(-) diff --git a/

[PATCH v2 4/4] Remove usermanual when building for Android

Our usermanual is based on webkit, and thats not supported in Qt for Android. We should probably replace it with a Android native webview somehow. Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 8 qt-ui/mainwindow.h | 3 +-- qt-ui/usermanual.h | 1 - subsurface

[PATCH v2 5/5] Remove printing when building for Android

Qt for Android doesn't support printing. Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 7 +++ qt-ui/printdialog.h | 1 - subsurface-configure.pri | 2 +- subsurface.pro | 16 4 files changed, 20 insertions(+), 6 deletions(-) diff --git

Re: [RFC PATCH] Drop like a stone mode in planner

On 19 March, 2014 - Anton Lundin wrote: > Anyone with a better idea for a name? No comments, thus its perfect? =) //Anton > --- > qt-ui/diveplanner.cpp | 13 + > qt-ui/diveplanner.h | 2 ++ > qt-ui/diveplanner.ui | 7 +++ > 3 files changed, 22 inser

Crash after saving to a git repo

f we should try to force a libgit2 > 0.19 or if the bug is somewhere in our code. //Anton -- Braindumping -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

Re: Crash after saving to a git repo

ry guess is > that it's just a libgit2 bug. > I trigger this after loading my xml file and then trying to save it to a new branch in a fresh git-repo. I'm kinda confused that I'm seem to be the only one hitting this one, because i can reproduce it to 100%. //Anton -- Anton

Re: Crash after saving to a git repo

On 31 March, 2014 - Dirk Hohndel wrote: > On Mon, 2014-03-31 at 19:57 +0200, Anton Lundin wrote: > > > I trigger this after loading my xml file and then trying to save it to a > > new branch in a fresh git-repo. > > > > I'm kinda confused that I'm

Re: Crash after saving to a git repo

On 31 March, 2014 - Linus Torvalds wrote: > On Mon, Mar 31, 2014 at 1:21 PM, Anton Lundin wrote: > > > > I managed to figure out that the Ubuntu version is built with > > -DTHREADSAFE=ON, but the packages both in f19 and f20 is built without > > threadsafe. > >

Re: [PATCH] First row visibility fix in Dive List

"), this); > showSearchBox->setShortcut(Qt::CTRL + Qt::Key_F); > -- > 1.8.5.2 (Apple Git-48) > > ___ > subsurface mailing list > subsurface@hohndel.org > http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface -- Anton Lundin+46702-

Re: [PATCH] First row visibility fix in Dive List

this); > >>showSearchBox->setShortcut(Qt::CTRL + Qt::Key_F); > >> -- > >> 1.8.5.2 (Apple Git-48) > >> > >> ___ > >> subsurface mailing list > >> subsurface@hohndel.org > >> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface > > > > -- > > Anton Lundin+46702-161604 -- Anton Lundin+46702-161604 ___ subsurface mailing list subsurface@hohndel.org http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface

[PATCH] Make divelist header corrections Mac specific

The +10 pixels fix was introduced to fix some layout issue on Mac ways back, but it breaks things on Android. This makes sure this only gets applied when build for mac. Signed-off-by: Anton Lundin --- qt-ui/divelistview.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qt-ui

[PATCH] Rely on ENABLE_PLANNER to enable the planner

The removal of the planner menu entry was erroneously commented out. Other parts of the code rely on ENABLE_PLANNER to know if the planner is enabled or not so rely on it here to. Signed-off-by: Anton Lundin --- qt-ui/mainwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: Updates to user manual

on to control if the planner should be in the manual or not. The patch is attached, so then we can continue to develop both the planner and its manual, without releasing it. //Anton -- Anton Lundin+46702-161604 >From e220243a69b11b84c356b10508a8a76d271dc654 Mon Sep 17 00:00:00 2001 Fr

Re: Updates to user manual

On 07 April, 2014 - Anton Lundin wrote: > On 07 April, 2014 - Willem Ferguson wrote: > > > Recently I submitted a patch with updates to the user manual. Included in > > that was a section dealing with the dive planner. It now appears that the > > visibility of the plann

  1   2   3   >