[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-12-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275146#comment-16275146
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #311: [NETBEANS-54] Various module reviews
URL: https://github.com/apache/incubator-netbeans/pull/311
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/css.editor/todo b/css.editor/todo
index b72e8caf8..1ca059e31 100644
--- a/css.editor/todo
+++ b/css.editor/todo
@@ -1,3 +1,6 @@
+Licensed to the Apache Software Foundation (ASF) under one or more contributor 
+license agreements; and to You under the Apache License, Version 2.0.
+
 Css modules list (source http://www.css3.info/modules/)
 
 * Selectors 
diff --git a/java.hints/build.xml b/java.hints/build.xml
index be6dfb4b2..d73020e16 100644
--- a/java.hints/build.xml
+++ b/java.hints/build.xml
@@ -20,13 +20,5 @@
 
 -->
 
-
-
-
-
-   
-
-
-
-   
+  
 
diff --git a/java.hints/test-excludes.txt b/java.hints/test-excludes.txt
deleted file mode 100644
index beb5f9e05..0
--- a/java.hints/test-excludes.txt
+++ /dev/null
@@ -1 +0,0 @@
-**/JavaHintsProviderTest*
diff --git 
a/java.hints/test/unit/src/org/netbeans/modules/java/hints/errors/Class.template
 
b/java.hints/test/unit/src/org/netbeans/modules/java/hints/errors/Class.template
index 864746b92..e7172a25c 100644
--- 
a/java.hints/test/unit/src/org/netbeans/modules/java/hints/errors/Class.template
+++ 
b/java.hints/test/unit/src/org/netbeans/modules/java/hints/errors/Class.template
@@ -1,3 +1,21 @@
+<#-- 
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+  
+ http://www.apache.org/licenses/LICENSE-2.0
+  
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+-->
 <#if package?? && package != "">
 package ${package};
 
diff --git 
a/java.hints/test/unit/src/org/netbeans/modules/java/hints/infrastructure/ErrorHintsProviderTest.java
 
b/java.hints/test/unit/src/org/netbeans/modules/java/hints/infrastructure/ErrorHintsProviderTest.java
index ec8cdd969..35e661650 100644
--- 
a/java.hints/test/unit/src/org/netbeans/modules/java/hints/infrastructure/ErrorHintsProviderTest.java
+++ 
b/java.hints/test/unit/src/org/netbeans/modules/java/hints/infrastructure/ErrorHintsProviderTest.java
@@ -60,12 +60,6 @@ public ErrorHintsProviderTest(String testName) {
 super(testName);
 }
 
-//public static Test suite() {
-//TestSuite suite = new TestSuite(JavaHintsProviderTest.class);
-//
-//return suite;
-//}
-
 private FileObject testSource;
 private JavaSource js;
 private CompilationInfo info;
diff --git a/java.navigation/test/log.txt b/java.navigation/test/log.txt
deleted file mode 100644
index c3f893856..0
--- a/java.navigation/test/log.txt
+++ /dev/null
@@ -1 +0,0 @@
-ant -verbose -Dnetbeans.dest.dir=/home/pzajac/builds/netbeans 
-Dxtest.testtype=qa-functional -Dxtest.attribs=validation
diff --git a/java.source/build.xml b/java.source/build.xml
index 262ea1328..b2c518f73 100644
--- a/java.source/build.xml
+++ b/java.source/build.xml
@@ -22,13 +22,5 @@
 
 
 
-
-
-
-
-
-
-
-
 

diff --git a/java.source/test-excludes.txt b/java.source/test-excludes.txt
deleted file mode 100644
index c5f1fdb99..0
--- a/java.source/test-excludes.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-**/CachingFileManagerTest*
-**/CachingZipArchiveTest*
-**/BasicPerformanceTest*
-**/CachingFolderArchiveTest*
-**/GeneratorTest*
-**/FileManagerTest*
-**/PerfJavacIntefaceGCTest*
-**/PerfResolveTest*
-**/PerfBatchCompilationTest*
-**/AnnotationOnLocVarTest*
-**/ClashingImportsTest*
-**/ImportFormatTest*
-**/LabelsTest*
-**/MemberAdditionTest*
-**/MethodBodyTextTest*
-**/UiUtilsTest*
-**/RepositoryUpdaterTest*
-**/ClassIndexTest*
\ No newline at end of file
diff --git 
a/jshell.support/src/org/netbeans/modules/jshell/resources/ShellClass.java.template
 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-12-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275144#comment-16275144
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #311: [NETBEANS-54] Various module reviews
URL: 
https://github.com/apache/incubator-netbeans/pull/311#issuecomment-348637305
 
 
   Awesome, merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-12-01 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275061#comment-16275061
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing opened a new pull request #311: [NETBEANS-54] Various module 
reviews
URL: https://github.com/apache/incubator-netbeans/pull/311
 
 
   - Removed unused files without license headers
   - Added various headers
   - Added various exclusions
   
   With this we are down to only one module: hibernate. The hibernate XSDs are 
only licensed under LGPL and so can't be included. I would not add them to the 
excludes.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268541#comment-16268541
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #299: [NETBEANS-54] Module Review usersguide
URL: 
https://github.com/apache/incubator-netbeans/pull/299#issuecomment-347483655
 
 
   Nice, thanks, merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268368#comment-16268368
 ] 

ASF GitHub Bot commented on NETBEANS-54:


emilianbold opened a new pull request #299: [NETBEANS-54] Module Review 
usersguide
URL: https://github.com/apache/incubator-netbeans/pull/299
 
 
   Added ASF license footer, replaced the old copyright notice with Apache 2.0.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264833#comment-16264833
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #271: [NETBEANS-54] excluding specific files, 
e.g., licenses via Rat
URL: 
https://github.com/apache/incubator-netbeans/pull/271#issuecomment-346706801
 
 
   Thank you! :-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264713#comment-16264713
 ] 

ASF GitHub Bot commented on NETBEANS-54:


asfgit closed pull request #271: [NETBEANS-54] excluding specific files, e.g., 
licenses via Rat
URL: https://github.com/apache/incubator-netbeans/pull/271
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 5a0c39c84..1d7f74287 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2032,6 +2032,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
  
+ 
  
  
  
@@ -2060,6 +2061,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  

  
+ 
  
  

  
@@ -2077,8 +2079,10 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
  
+ 

  

  
+ 
  
  
  
@@ -2093,6 +2097,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
  
+ 
  
  
  
@@ -2139,6 +2144,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
  
+ 
  

  
  


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264146#comment-16264146
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #271: [NETBEANS-54] excluding specific files, 
e.g., licenses via Rat
URL: 
https://github.com/apache/incubator-netbeans/pull/271#issuecomment-346583435
 
 
   OK, I'll use that to pull this into my tree, but does anything from here 
need to be pushed to Apache NetBeans Git? Sorry, it's getting too complex for 
me in this PR, if there's a way you can commit this, that would be great.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258613#comment-16258613
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #271: [NETBEANS-54] excluding specific 
files, e.g., licenses via Rat
URL: 
https://github.com/apache/incubator-netbeans/pull/271#issuecomment-345548468
 
 
   @geertjanw I extended your work by adding the ALv2 header to all VERSION.txt 
files. You established this in a prior fix and I think it is a good idea. 
Please see here:
   
   https://github.com/matthiasblaesing/incubator-netbeans/tree/pr271-followup
   
   You can full that into your tree as:
   ```
   git pull https://github.com/matthiasblaesing/incubator-netbeans.git 
pr271-followup
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249298#comment-16249298
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #271: [NETBEANS-54] excluding specific files, 
e.g., licenses via Rat
URL: 
https://github.com/apache/incubator-netbeans/pull/271#issuecomment-343864526
 
 
   So, should I simply close this one, is everything handled in #272?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248986#comment-16248986
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing closed pull request #272: [NETBEANS-54] Further license cleanup
URL: https://github.com/apache/incubator-netbeans/pull/272
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/api.htmlui/test/unit/src/org/netbeans/api/htmlui/empty.html 
b/api.htmlui/test/unit/src/org/netbeans/api/htmlui/empty.html
index 36d74b74b..7f152d47c 100644
--- a/api.htmlui/test/unit/src/org/netbeans/api/htmlui/empty.html
+++ b/api.htmlui/test/unit/src/org/netbeans/api/htmlui/empty.html
@@ -19,47 +19,6 @@
 
 -->
 
-
 
 
 TODO supply a title
diff --git a/beans/src/org/netbeans/modules/beans/resources/beansSetting.gif 
b/beans/src/org/netbeans/modules/beans/resources/beansSetting.gif
deleted file mode 100644
index b09c4afe5..0
Binary files a/beans/src/org/netbeans/modules/beans/resources/beansSetting.gif 
and /dev/null differ
diff --git a/gsf.testrunner.ui/src/META-INF/netbeans/translate.names 
b/gsf.testrunner.ui/src/META-INF/netbeans/translate.names
index 1a8b11322..0308f66da 100644
--- a/gsf.testrunner.ui/src/META-INF/netbeans/translate.names
+++ b/gsf.testrunner.ui/src/META-INF/netbeans/translate.names
@@ -1,39 +1,20 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Copyright (c) 2014, 2016 Oracle and/or its affiliates. All rights reserved.
-#
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-#
-# The contents of this file are subject to the terms of either the GNU
-# General Public License Version 2 only ("GPL") or the Common
-# Development and Distribution License("CDDL") (collectively, the
-# "License"). You may not use this file except in compliance with the
-# License. You can obtain a copy of the License at
-# http://www.netbeans.org/cddl-gplv2.html
-# or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
-# specific language governing permissions and limitations under the
-# License.  When distributing the software, include this License Header
-# Notice in each file and include the License file at
-# nbbuild/licenses/CDDL-GPL-2-CP.  Oracle designates this
-# particular file as subject to the "Classpath" exception as provided
-# by Oracle in the GPL Version 2 section of the License file that
-# accompanied this code. If applicable, add the following below the
-# License Header, with the fields enclosed by brackets [] replaced by
-# your own identifying information:
-# "Portions Copyrighted [year] [name of copyright owner]"
-#
-# If you wish your version of this file to be governed by only the CDDL
-# or only the GPL Version 2, indicate your decision by adding
-# "[Contributor] elects to include this software in this distribution
-# under the [CDDL or GPL Version 2] license." If you do not indicate a
-# single choice of license, a recipient has the option to distribute
-# your version of this file under either the CDDL, the GPL Version 2 or
-# to extend the choice of license to its licensees as provided above.
-# However, if you add GPL Version 2 code and therefore, elected the GPL
-# Version 2 license, then the option applies only if the new code is
-# made subject to such option by the copyright holder.
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 # Contributor(s):
 # Changed filename of actions
 
Actions/UnitTests/org-netbeans-modules-gsf-testrunner-TestCreatorAction.instance=Actions/UnitTests/org-netbeans-modules-gsf-testrunner-ui-TestCreatorAction.instance
diff --git a/gsf.testrunner/src/META-INF/netbeans/translate.names 
b/gsf.testrunner/src/META-INF/netbeans/translate.names
index 8a4d6cee6..f0cb86c4d 100644
--- a/gsf.testrunner/src/META-INF/netbeans/translate.names
+++ b/gsf.testrunner/src/META-INF/netbeans/translate.names
@@ -1,40 +1,20 @@
-# DO NOT ALTER OR 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248865#comment-16248865
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on a change in pull request #271: [NETBEANS-54] 
excluding specific files, e.g., licenses via Rat
URL: https://github.com/apache/incubator-netbeans/pull/271#discussion_r150411500
 
 

 ##
 File path: nbbuild/build.xml
 ##
 @@ -2024,8 +2027,11 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
  
+ 

  

  
+ 

 
 Review comment:
   This should not be here. The license header there is CDDL-GPL-2-CP and needs 
to be adjusted. I fixed that in #272.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248864#comment-16248864
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #218: [NETBEANS-54] Module Review xml.jaxb
URL: 
https://github.com/apache/incubator-netbeans/pull/218#issuecomment-343739147
 
 
   @geertjanw you latest change reverts all changes you did to the xml.jaxb 
module. As this looked abandond I had a look at it yesterday and also covered a 
few more files. Please have a look at PR #272 which holds both changesets. 
Merging that would also close this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248862#comment-16248862
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing opened a new pull request #272: [NETBEANS-54] Further license 
cleanup
URL: https://github.com/apache/incubator-netbeans/pull/272
 
 
   There are two changes:
   - cleanup the xml.jaxb module by moving test-data into 
`xml.jaxb/test/unit/data` and fix the remaining files in the modules
   - cleanup modules where the CDDL is still present in primary or secondary 
(file generation) elements


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248832#comment-16248832
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #218: [NETBEANS-54] Module Review xml.jaxb
URL: 
https://github.com/apache/incubator-netbeans/pull/218#issuecomment-343731008
 
 
   Reverted the license header changes on the test data files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248828#comment-16248828
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #271: [NETBEANS-54] excluding specific 
files, e.g., licenses via Rat
URL: https://github.com/apache/incubator-netbeans/pull/271
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16247010#comment-16247010
 ] 

ASF GitHub Bot commented on NETBEANS-54:


junichi11 closed pull request #255: [NETBEANS-54] Module Review api.templates
URL: https://github.com/apache/incubator-netbeans/pull/255
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml 
b/api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml
index 5bddc48f0..b508d10e4 100644
--- a/api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml
+++ b/api.templates/test/unit/src/org/netbeans/modules/templates/utf8.xml
@@ -1,24 +1,3 @@
-
-
 print('');
 print('');
 print('Žluťoučký kůň skákal přes čtvero mezí.');
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index db1024677..11c14a173 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2005,9 +2005,10 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
  
- 
  
+ 

  
+ 
  

  
  


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16244111#comment-16244111
 ] 

ASF GitHub Bot commented on NETBEANS-54:


junichi11 closed pull request #207: [NETBEANS-54] Module Review o.n.upgrader
URL: https://github.com/apache/incubator-netbeans/pull/207
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/systemoptionsimport 
b/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/systemoptionsimport
index 6caf84336..d30b68ebd 100644
--- a/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/systemoptionsimport
+++ b/o.n.upgrader/src/org/netbeans/upgrade/systemoptions/systemoptionsimport
@@ -1,3 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 Services/org-netbeans-core-IDESettings.settings
 Services/org-netbeans-modules-derby-DerbyOptions.settings
 Services/org-apache-tools-ant-module-AntSettings.settings


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-07 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243240#comment-16243240
 ] 

ASF GitHub Bot commented on NETBEANS-54:


junichi11 opened a new pull request #255: [NETBEANS-54] Module Review 
api.templates
URL: https://github.com/apache/incubator-netbeans/pull/255
 
 
   - Remove the license header from utf8.xml because unit tests fail.
   - Exclude utf8.xml from rat.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241491#comment-16241491
 ] 

ASF GitHub Bot commented on NETBEANS-54:


junichi11 commented on issue #207: [NETBEANS-54] Module Review o.n.upgrader
URL: 
https://github.com/apache/incubator-netbeans/pull/207#issuecomment-342379117
 
 
   I'll merge this later. Please let me know if there is a problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239707#comment-16239707
 ] 

ASF GitHub Bot commented on NETBEANS-54:


asfgit closed pull request #235: [NETBEANS-54] Module Review html.editor
URL: https://github.com/apache/incubator-netbeans/pull/235
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/html.editor/src/org/netbeans/modules/html/editor/Bundle.properties 
b/html.editor/src/org/netbeans/modules/html/editor/Bundle.properties
index 93afa1306..2a219fdfb 100644
--- a/html.editor/src/org/netbeans/modules/html/editor/Bundle.properties
+++ b/html.editor/src/org/netbeans/modules/html/editor/Bundle.properties
@@ -1,44 +1,19 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
-
-# Copyright 1997-2010 Oracle and/or its affiliates. All rights reserved.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-
-# The contents of this file are subject to the terms of either the GNU
-# General Public License Version 2 only ("GPL") or the Common
-# Development and Distribution License("CDDL") (collectively, the
-# "License"). You may not use this file except in compliance with the
-# License. You can obtain a copy of the License at
-# http://www.netbeans.org/cddl-gplv2.html
-# or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
-# specific language governing permissions and limitations under the
-# License.  When distributing the software, include this License Header
-# Notice in each file and include the License file at
-# nbbuild/licenses/CDDL-GPL-2-CP.  Oracle designates this
-# particular file as subject to the "Classpath" exception as provided
-# by Oracle in the GPL Version 2 section of the License file that
-# accompanied this code. If applicable, add the following below the
-# License Header, with the fields enclosed by brackets [] replaced by
-# your own identifying information:
-# "Portions Copyrighted [year] [name of copyright owner]"
-
-# Contributor(s):
-
-# The Original Software is NetBeans. The Initial Developer of the Original
-# Software is Sun Microsystems, Inc. Portions Copyright 1997-2006 Sun
-# Microsystems, Inc. All Rights Reserved.
-
-# If you wish your version of this file to be governed by only the CDDL
-# or only the GPL Version 2, indicate your decision by adding
-# "[Contributor] elects to include this software in this distribution
-# under the [CDDL or GPL Version 2] license." If you do not indicate a
-# single choice of license, a recipient has the option to distribute
-# your version of this file under either the CDDL, the GPL Version 2 or
-# to extend the choice of license to its licensees as provided above.
-# However, if you add GPL Version 2 code and therefore, elected the GPL
-# Version 2 license, then the option applies only if the new code is
-# made subject to such option by the copyright holder.
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 HtmlCompletionOptionsPanel.autocompleteQuotesAfterEQSCheckBox.text=Equals-sign 
(=) Keypress After Attribute Name Autocompletes Quote Set
 HtmlCompletionOptionsPanel.autocompleteQuotesCheckBox.text=Quote-mark (") 
Keypress After Attribute Name Autocompletes Closing Quote
 HtmlCompletionOptionsPanel.completionOffersEndTagAfterLt.text=Completion 
Offers End Tags After Less Than (<) Character
diff --git 
a/html.editor/src/org/netbeans/modules/html/editor/hints/Bundle.properties 
b/html.editor/src/org/netbeans/modules/html/editor/hints/Bundle.properties
index ab4dc3874..ea391606a 100644
--- a/html.editor/src/org/netbeans/modules/html/editor/hints/Bundle.properties
+++ b/html.editor/src/org/netbeans/modules/html/editor/hints/Bundle.properties
@@ -1,44 +1,19 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
-
-# Copyright 1997-2010 Oracle and/or its affiliates. All rights reserved.
+# Licensed to the Apache Software Foundation (ASF) 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239683#comment-16239683
 ] 

ASF GitHub Bot commented on NETBEANS-54:


borxa commented on issue #235: [NETBEANS-54] Module Review html.editor
URL: 
https://github.com/apache/incubator-netbeans/pull/235#issuecomment-341996028
 
 
   License from catalog files removed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239455#comment-16239455
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #245: [NETBEANS-54] excluding files via Rat that 
would cause tests to fail etc
URL: https://github.com/apache/incubator-netbeans/pull/245
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 225885912..b872b021f 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -1986,7 +1986,10 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
  
+ 
  
+ 
+ 
  
  
  
@@ -1996,9 +1999,12 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
 
+ 
+ 
+ 
  
-
-
+ 
+ 
  
  
  
@@ -2051,7 +2057,10 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
 
 
  
+ 
+ 
 
+ 

  

  
  


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239450#comment-16239450
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #245: [NETBEANS-54] excluding files via Rat 
that would cause tests to fail etc
URL: https://github.com/apache/incubator-netbeans/pull/245
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239467#comment-16239467
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #246: [NETBEANS-54] excluding 8 files without 
creativity via Rat
URL: https://github.com/apache/incubator-netbeans/pull/246
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index b872b021f..034041752 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2064,9 +2064,17 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  

  
  
+ 
+ 
  
+ 
  
  
+ 
+ 
+ 
+ 
+ 
  
  
  


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239461#comment-16239461
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #246: [NETBEANS-54] excluding 8 files 
without creativity via Rat
URL: https://github.com/apache/incubator-netbeans/pull/246
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239438#comment-16239438
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #225: [NETBEANS-54] exclude .ser files via Rat 
exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/225#issuecomment-341955624
 
 
   Makes sense.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239435#comment-16239435
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #243: [NETBEANS-54] excluding specific files for 
various reasons via Rat ex…
URL: https://github.com/apache/incubator-netbeans/pull/243
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 69ab0f773..225885912 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2021,6 +2021,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  

  
  
+ 

  
  
  
@@ -2035,16 +2036,21 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  

  
+ 
  

  
  

  

+ 
  
  
  
  
+ 
+ 
 
 
+ 
 
  

  
@@ -2052,6 +2058,8 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
  
+ 
+ 
  
  
  


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239436#comment-16239436
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #244: [NETBEANS-54] relicensing 3 files in 
nbbuild module
URL: https://github.com/apache/incubator-netbeans/pull/244
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nbbuild/misc/bundlecheck.pl b/nbbuild/misc/bundlecheck.pl
index 3a6357636..e8b929f40 100644
--- a/nbbuild/misc/bundlecheck.pl
+++ b/nbbuild/misc/bundlecheck.pl
@@ -1,46 +1,21 @@
 #!/usr/bin/env perl
 # -*- perl -*-
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Copyright 1997-2010 Oracle and/or its affiliates. All rights reserved.
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-#
-# The contents of this file are subject to the terms of either the GNU
-# General Public License Version 2 only ("GPL") or the Common
-# Development and Distribution License("CDDL") (collectively, the
-# "License"). You may not use this file except in compliance with the
-# License. You can obtain a copy of the License at
-# http://www.netbeans.org/cddl-gplv2.html
-# or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
-# specific language governing permissions and limitations under the
-# License.  When distributing the software, include this License Header
-# Notice in each file and include the License file at
-# nbbuild/licenses/CDDL-GPL-2-CP.  Oracle designates this
-# particular file as subject to the "Classpath" exception as provided
-# by Oracle in the GPL Version 2 section of the License file that
-# accompanied this code. If applicable, add the following below the
-# License Header, with the fields enclosed by brackets [] replaced by
-# your own identifying information:
-# "Portions Copyrighted [year] [name of copyright owner]"
-#
-# Contributor(s):
-#
-# The Original Software is NetBeans. The Initial Developer of the Original
-# Software is Sun Microsystems, Inc. Portions Copyright 1997-2006 Sun
-# Microsystems, Inc. All Rights Reserved.
-#
-# If you wish your version of this file to be governed by only the CDDL
-# or only the GPL Version 2, indicate your decision by adding
-# "[Contributor] elects to include this software in this distribution
-# under the [CDDL or GPL Version 2] license." If you do not indicate a
-# single choice of license, a recipient has the option to distribute
-# your version of this file under either the CDDL, the GPL Version 2 or
-# to extend the choice of license to its licensees as provided above.
-# However, if you add GPL Version 2 code and therefore, elected the GPL
-# Version 2 license, then the option applies only if the new code is
-# made subject to such option by the copyright holder.
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 
 require 5.005;
 use File::Find;
diff --git a/nbbuild/misc/bundlewc.pl b/nbbuild/misc/bundlewc.pl
index f56834787..9bea7af8f 100644
--- a/nbbuild/misc/bundlewc.pl
+++ b/nbbuild/misc/bundlewc.pl
@@ -1,46 +1,21 @@
 #!/usr/bin/env perl
 # -*- perl -*-
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Copyright 1997-2010 Oracle and/or its affiliates. All rights reserved.
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-#
-# The contents of this file are subject to the terms 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239310#comment-16239310
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #244: [NETBEANS-54] relicensing 3 files in 
nbbuild module
URL: https://github.com/apache/incubator-netbeans/pull/244
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239302#comment-16239302
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #243: [NETBEANS-54] excluding specific 
files for various reasons via Rat ex…
URL: https://github.com/apache/incubator-netbeans/pull/243
 
 
   …clusions


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239280#comment-16239280
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #242: [NETBEANS-54] exclude files without 
creativity via Rat exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/242#issuecomment-341933093
 
 
   Great, thanks, merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239255#comment-16239255
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #242: [NETBEANS-54] exclude files without 
creativity via Rat exclusions
URL: https://github.com/apache/incubator-netbeans/pull/242
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239237#comment-16239237
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #225: [NETBEANS-54] exclude .ser files via 
Rat exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/225#issuecomment-341929759
 
 
   @geertjanw if it helps you or others I'm ok with this, but I'll stay with 
the CLI tools, which also happily work with non-github repositories. Remember: 
sourceforge mostly died because they decided that "free project hosting" does 
not pay bills and then began to modify projects binaries - if github pulls a 
stunt like that, I will just go on and work against the apache hosted 
repository.
   
   What is more with the CLI (or other local tools) I can pull from other 
sources than github, so if contributers don't like github, but host their 
changes in another public git repository (bitbucket, gitlab, ...) we can still 
pull their changes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239209#comment-16239209
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #225: [NETBEANS-54] exclude .ser files via Rat 
exclusions
URL: https://github.com/apache/incubator-netbeans/pull/225
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 748a7ba0d..18616bc3c 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -1981,6 +1981,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  
  
+ 
  
  
  
@@ -1993,6 +1994,7 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
 
 
 
+ 
  
  
  

@@ -2042,6 +2044,9 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  

  
  
+ 
+ 
+ 
  
  
  


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239195#comment-16239195
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #225: [NETBEANS-54] exclude .ser files via 
Rat exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/225#issuecomment-341924911
 
 
   Yes this looks safe.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239177#comment-16239177
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #225: [NETBEANS-54] exclude .ser files via Rat 
exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/225#issuecomment-341922662
 
 
   @matthiasblaesing, is this safe to merge from your point of view, if not, 
will just close this and start a new pull request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239158#comment-16239158
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #225: [NETBEANS-54] exclude .ser files via Rat 
exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/225#issuecomment-341920950
 
 
   Yes, I used the GitHub web interface, not the command line. I wanted to see 
if it was possible to use the conflict like that, and it seems to have worked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239160#comment-16239160
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #225: [NETBEANS-54] exclude .ser files via Rat 
exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/225#issuecomment-341920950
 
 
   Yes, I used the GitHub web interface, not the command line. I wanted to see 
if it was possible to fix the conflict like that, and it seems to have worked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239151#comment-16239151
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #225: [NETBEANS-54] exclude .ser files via Rat 
exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/225#issuecomment-341920049
 
 
   It should be OK now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239091#comment-16239091
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #220: [NETBEANS-54] Module Review performance
URL: https://github.com/apache/incubator-netbeans/pull/220
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/performance/actionsframework/src/org/netbeans/actions/examples/actions.properties
 
b/performance/actionsframework/src/org/netbeans/actions/examples/actions.properties
index fbd453937..61a306158 100644
--- 
a/performance/actionsframework/src/org/netbeans/actions/examples/actions.properties
+++ 
b/performance/actionsframework/src/org/netbeans/actions/examples/actions.properties
@@ -1,41 +1,19 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Copyright (c) 2004, 2016 Oracle and/or its affiliates. All rights reserved.
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-#
-# The contents of this file are subject to the terms of either the GNU
-# General Public License Version 2 only ("GPL") or the Common
-# Development and Distribution License("CDDL") (collectively, the
-# "License"). You may not use this file except in compliance with the
-# License. You can obtain a copy of the License at
-# http://www.netbeans.org/cddl-gplv2.html
-# or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
-# specific language governing permissions and limitations under the
-# License.  When distributing the software, include this License Header
-# Notice in each file and include the License file at
-# nbbuild/licenses/CDDL-GPL-2-CP.  Oracle designates this
-# particular file as subject to the "Classpath" exception as provided
-# by Oracle in the GPL Version 2 section of the License file that
-# accompanied this code. If applicable, add the following below the
-# License Header, with the fields enclosed by brackets [] replaced by
-# your own identifying information:
-# "Portions Copyrighted [year] [name of copyright owner]"
-#
-# If you wish your version of this file to be governed by only the CDDL
-# or only the GPL Version 2, indicate your decision by adding
-# "[Contributor] elects to include this software in this distribution
-# under the [CDDL or GPL Version 2] license." If you do not indicate a
-# single choice of license, a recipient has the option to distribute
-# your version of this file under either the CDDL, the GPL Version 2 or
-# to extend the choice of license to its licensees as provided above.
-# However, if you add GPL Version 2 code and therefore, elected the GPL
-# Version 2 license, then the option applies only if the new code is
-# made subject to such option by the copyright holder.
-#
-# Contributor(s):
-# Sample ResourceBundle properties file
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 file=File
 edit=Edit
 
diff --git 
a/performance/benchmarks/test/reports/src/org/netbeans/performance/results/ComparePanel.form
 
b/performance/benchmarks/test/reports/src/org/netbeans/performance/results/ComparePanel.form
index ae681c40f..acccaa1fe 100644
--- 
a/performance/benchmarks/test/reports/src/org/netbeans/performance/results/ComparePanel.form
+++ 
b/performance/benchmarks/test/reports/src/org/netbeans/performance/results/ComparePanel.form
@@ -1,5 +1,26 @@
 
 
+
+
 
   
 
diff --git a/performance/benchmarks/test/reports/style-html.xsl 
b/performance/benchmarks/test/reports/style-html.xsl
index 5a1dae144..9f077251a 100644
--- a/performance/benchmarks/test/reports/style-html.xsl
+++ b/performance/benchmarks/test/reports/style-html.xsl
@@ -1,4 +1,24 @@
 
+
 http://www.w3.org/1999/XSL/Transform;>
 
diff --git 
a/performance/enterprise/test/qa-functional/data/BPELTestProject/src/SynchronousSample.bpel
 
b/performance/enterprise/test/qa-functional/data/BPELTestProject/src/SynchronousSample.bpel
index 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239059#comment-16239059
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #225: [NETBEANS-54] exclude .ser files via 
Rat exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/225#issuecomment-341905492
 
 
   To resolve the conflict I suggest that you:
   - rebase the changes onto master
   - resolve the conflict while rebasing
   - push the updated branch (you'll need to do a forced-push to be able to 
push a rebased branch)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239053#comment-16239053
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing closed pull request #237: [NETBEANS-54] Module Review 
o.eclipse.equinox.app
URL: https://github.com/apache/incubator-netbeans/pull/237
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/o.eclipse.equinox.app/external/binaries-list 
b/o.eclipse.equinox.app/external/binaries-list
index bdd9386b7..7cf1d975d 100644
--- a/o.eclipse.equinox.app/external/binaries-list
+++ b/o.eclipse.equinox.app/external/binaries-list
@@ -14,4 +14,4 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-BD55836AABD558DC643A7844B78866AD990544BC 
org.eclipse.equinox.app-1.3.100_nosignature.jar
+E7169B33D352F5DDB6EACE73F5A4D29AAE3B91EC 
org.eclipse.equinox:org.eclipse.equinox.app:1.3.100
diff --git a/o.eclipse.equinox.app/nbproject/project.properties 
b/o.eclipse.equinox.app/nbproject/project.properties
index aac99d85b..9618ba067 100644
--- a/o.eclipse.equinox.app/nbproject/project.properties
+++ b/o.eclipse.equinox.app/nbproject/project.properties
@@ -14,6 +14,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-release.external/org.eclipse.equinox.app-1.3.100_nosignature.jar=modules/org-eclipse-equinox-app.jar
+release.external/org.eclipse.equinox.app-1.3.100.jar=modules/org-eclipse-equinox-app.jar
 is.autoload=true
 nbm.module.author=Tomas Stupka
diff --git a/o.eclipse.equinox.app/nbproject/project.xml 
b/o.eclipse.equinox.app/nbproject/project.xml
index 99bc147bc..412dc589a 100644
--- a/o.eclipse.equinox.app/nbproject/project.xml
+++ b/o.eclipse.equinox.app/nbproject/project.xml
@@ -39,7 +39,7 @@
 
 
 
org-eclipse-equinox-app.jar
-
external/org.eclipse.equinox.app-1.3.100_nosignature.jar
+
external/org.eclipse.equinox.app-1.3.100.jar
 
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239052#comment-16239052
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing closed pull request #238: [NETBEANS-54] Module Review 
o.eclipse.equinox.common
URL: https://github.com/apache/incubator-netbeans/pull/238
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/o.eclipse.equinox.common/external/binaries-list 
b/o.eclipse.equinox.common/external/binaries-list
index 72d560dd6..18a56387f 100644
--- a/o.eclipse.equinox.common/external/binaries-list
+++ b/o.eclipse.equinox.common/external/binaries-list
@@ -14,4 +14,4 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-4EE275AE73A140A403903D7E4DBA68C8FBB07001 
org.eclipse.equinox.common_3.6.0.v20110523_nosignature.jar
+AB81FD273D933406A855D23A3C341B668B2F9CEF 
org.jibx.config.3rdparty.org.eclipse:org.eclipse.equinox.common:3.6.0.v20110523
diff --git a/o.eclipse.equinox.common/nbproject/project.properties 
b/o.eclipse.equinox.common/nbproject/project.properties
index 262c8b39d..91a2ee6ba 100644
--- a/o.eclipse.equinox.common/nbproject/project.properties
+++ b/o.eclipse.equinox.common/nbproject/project.properties
@@ -14,6 +14,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-release.external/org.eclipse.equinox.common_3.6.0.v20110523_nosignature.jar=modules/org-eclipse-equinox-common.jar
+release.external/org.eclipse.equinox.common-3.6.0.v20110523.jar=modules/org-eclipse-equinox-common.jar
 is.autoload=true
-nbm.module.author=Tomas Stupka
\ No newline at end of file
+nbm.module.author=Tomas Stupka
diff --git a/o.eclipse.equinox.common/nbproject/project.xml 
b/o.eclipse.equinox.common/nbproject/project.xml
index bea66c285..09098eeba 100644
--- a/o.eclipse.equinox.common/nbproject/project.xml
+++ b/o.eclipse.equinox.common/nbproject/project.xml
@@ -28,8 +28,8 @@



org-eclipse-equinox-common.jar
-
external/org.eclipse.equinox.common_3.6.0.v20110523_nosignature.jar
+
external/org.eclipse.equinox.common-3.6.0.v20110523.jar
 
 
 
-
\ No newline at end of file
+


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239050#comment-16239050
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #235: [NETBEANS-54] Module Review 
html.editor
URL: 
https://github.com/apache/incubator-netbeans/pull/235#issuecomment-341903714
 
 
   My reading of NbReaderProvider is, that there can't be comments in the 
catalog files. At this point the catalog files are useless, as the 
corresponding DTDs are not present anymore. I raised 
[NETBEANS-114](https://issues.apache.org/jira/browse/NETBEANS-114) for this.
   
   To get this on I would do this:
   - remove the license from the catalog files
   - add excludes to build.xml for rat:
   ```xml






   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239049#comment-16239049
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #225: [NETBEANS-54] exclude .ser files via Rat 
exclusions
URL: 
https://github.com/apache/incubator-netbeans/pull/225#issuecomment-341903209
 
 
   Can someone advise how to resolve the conflict here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239046#comment-16239046
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #227: [NETBEANS-54] adding license headers to 
various files in nbbuild
URL: https://github.com/apache/incubator-netbeans/pull/227
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binaries 
b/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binaries
index 174ac962c..6f6c60da6 100644
--- a/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binaries
+++ b/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binaries
@@ -1,3 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 # List of patterns (one per line) to skip over in 
VerifyLibsAndLicenses.testNoStrayThirdPartyBinaries.
 # Uses standard Ant pattern syntax, in ${nb_all} among modules included in 
cluster config.
 # Implicit includes is **/*.jar,**/*.zip.
diff --git 
a/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binary-overlaps 
b/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binary-overlaps
index 90501676d..e40d2b129 100644
--- a/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binary-overlaps
+++ b/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-binary-overlaps
@@ -1,3 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 # List of patterns (one pair per line) to skip over in 
CreateLicenseSummary.testBinariesAreUnique.
 # Both sides of the pair must match for the pair to be skipped.
 # Uses standard Ant pattern syntax, with the basedir being the root of the NB 
build.
diff --git a/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps 
b/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
index db4eb0b56..400ec1b86 100644
--- a/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
+++ b/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/ignored-overlaps
@@ -1,3 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 # List of patterns (one pair per line) to skip over in 
VerifyLibsAndLicenses.testBinaryUniqueness.
 # Both sides of the pair must match for the pair to be skipped.
 # Uses standard Ant pattern syntax, in ${nb_all} among modules included in 
cluster config.
diff --git a/nbbuild/hudson/core-main b/nbbuild/hudson/core-main
index 81bf326b9..4175c77f6 100644
--- a/nbbuild/hudson/core-main
+++ b/nbbuild/hudson/core-main
@@ 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239044#comment-16239044
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #227: [NETBEANS-54] adding license headers to 
various files in nbbuild
URL: 
https://github.com/apache/incubator-netbeans/pull/227#issuecomment-341902049
 
 
   Great, merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239032#comment-16239032
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #227: [NETBEANS-54] adding license headers 
to various files in nbbuild
URL: 
https://github.com/apache/incubator-netbeans/pull/227#issuecomment-341900059
 
 
   Thanks - build looks good, unittests work correctly - feel free to merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238986#comment-16238986
 ] 

ASF GitHub Bot commented on NETBEANS-54:


junichi11 commented on issue #232: [NETBEANS-54] Module Review 
jellytools.platform
URL: 
https://github.com/apache/incubator-netbeans/pull/232#issuecomment-341894836
 
 
   Thank you for fixing it! 
   We can exclude `version_info` from rat as well as `*.mf`.
   
https://github.com/apache/incubator-netbeans/blob/19ec0a5a4d7183ff3c201c804c63f1fbef938392/nbbuild/build.xml#L1979


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238977#comment-16238977
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #227: [NETBEANS-54] adding license headers to 
various files in nbbuild
URL: 
https://github.com/apache/incubator-netbeans/pull/227#issuecomment-341894528
 
 
   I think it worked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238966#comment-16238966
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #227: [NETBEANS-54] adding license headers 
to various files in nbbuild
URL: 
https://github.com/apache/incubator-netbeans/pull/227#issuecomment-341894037
 
 
   @geertjanw for this small change this workflow is overkill, but its good to 
try :-)
   
   I pushed my change into a branch in my repository (branch PR227-update):
   
   https://github.com/matthiasblaesing/incubator-netbeans.git
   
   You can pull my changes with:
   
   ```
   git pull https://github.com/matthiasblaesing/incubator-netbeans.git 
PR227-update
   ```
   
   As I used your commits unmodified a fast-forward merge will be done. After 
the merge one other unittest will fail, that failure is not caused by this 
changeset and already fixed in master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238914#comment-16238914
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #236: [NETBEANS-54] Module Review editor (rat 
exclusions)
URL: https://github.com/apache/incubator-netbeans/pull/236
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/editor/demosrc/README b/editor/demosrc/README
index 23c7ca80b..70a9628b7 100644
--- a/editor/demosrc/README
+++ b/editor/demosrc/README
@@ -1,3 +1,5 @@
+Licensed to the Apache Software Foundation (ASF) under one or more contributor 
license agreements; and to You under the Apache License, Version 2.0.
+
 Introduction:
This is the implementation of simple standalone editor application.
 It is based on the fact that NetBeans editors are pure swing editors.
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 12bd9ada1..fbf2dbdb3 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2002,6 +2002,11 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  

  
+ 

+ 

+ 
+ 
+ 
  
  
  


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238911#comment-16238911
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #236: [NETBEANS-54] Module Review editor (rat 
exclusions)
URL: 
https://github.com/apache/incubator-netbeans/pull/236#issuecomment-341888446
 
 
   Great, thanks, merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238909#comment-16238909
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #227: [NETBEANS-54] adding license headers to 
various files in nbbuild
URL: 
https://github.com/apache/incubator-netbeans/pull/227#issuecomment-341888340
 
 
   Is there a way to integrate your changes via GitHub -- or must I manually 
rework the code in my fork and then push?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238906#comment-16238906
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #232: [NETBEANS-54] Module Review 
jellytools.platform
URL: 
https://github.com/apache/incubator-netbeans/pull/232#issuecomment-341888182
 
 
   OK, removed the license as suggested by @junichi11.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238857#comment-16238857
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #224: [NETBEANS-54] adding licenses to uml files 
in openide.nodes
URL: https://github.com/apache/incubator-netbeans/pull/224
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/openide.nodes/uml/classdiagram6.pgml 
b/openide.nodes/uml/classdiagram6.pgml
index 83db18f43..e585a7e31 100644
--- a/openide.nodes/uml/classdiagram6.pgml
+++ b/openide.nodes/uml/classdiagram6.pgml
@@ -1,4 +1,24 @@
 
+
 
 
+
 
 
+
 
 
+
 
 
   
diff --git a/openide.nodes/uml/node_API.xmi b/openide.nodes/uml/node_API.xmi
index e8bf33bf4..eced6ad75 100644
--- a/openide.nodes/uml/node_API.xmi
+++ b/openide.nodes/uml/node_API.xmi
@@ -1,4 +1,24 @@
 
+
 
 
   
diff --git a/openide.nodes/uml/node_API_API_classdiagram3.pgml 
b/openide.nodes/uml/node_API_API_classdiagram3.pgml
index 074f354ed..a4946da9a 100644
--- a/openide.nodes/uml/node_API_API_classdiagram3.pgml
+++ b/openide.nodes/uml/node_API_API_classdiagram3.pgml
@@ -1,4 +1,24 @@
 
+
 
 
+
 
 
+
 
 
+
 
  Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238856#comment-16238856
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #224: [NETBEANS-54] adding licenses to uml files 
in openide.nodes
URL: 
https://github.com/apache/incubator-netbeans/pull/224#issuecomment-341882768
 
 
   Merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238824#comment-16238824
 ] 

ASF GitHub Bot commented on NETBEANS-54:


vieiro opened a new pull request #238: [NETBEANS-54] Module Review 
o.eclipse.equinox.common
URL: https://github.com/apache/incubator-netbeans/pull/238
 
 
   - Added maven coordinates for the external binary.
   - No other licensing issues found.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238823#comment-16238823
 ] 

ASF GitHub Bot commented on NETBEANS-54:


vieiro opened a new pull request #237: [NETBEANS-54] Module Review 
o.eclipse.equinox.app
URL: https://github.com/apache/incubator-netbeans/pull/237
 
 
- Added maven coordinates for the external binary.
- No other licensing issues found.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238812#comment-16238812
 ] 

ASF GitHub Bot commented on NETBEANS-54:


vieiro commented on issue #42: [NETBEANS-54] Module Review editor
URL: https://github.com/apache/incubator-netbeans/pull/42#issuecomment-341875816
 
 
   See #236 https://github.com/apache/incubator-netbeans/pull/236
   
   @geertjanw I missed your first comments completely (lost in email folders), 
please open an issue for these updates, I won't miss those!
   
   Closing this PR now.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238813#comment-16238813
 ] 

ASF GitHub Bot commented on NETBEANS-54:


vieiro closed pull request #42: [NETBEANS-54] Module Review editor
URL: https://github.com/apache/incubator-netbeans/pull/42
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/editor/demosrc/README b/editor/demosrc/README
index 23c7ca80b..70a9628b7 100644
--- a/editor/demosrc/README
+++ b/editor/demosrc/README
@@ -1,3 +1,5 @@
+Licensed to the Apache Software Foundation (ASF) under one or more contributor 
license agreements; and to You under the Apache License, Version 2.0.
+
 Introduction:
This is the implementation of simple standalone editor application.
 It is based on the fact that NetBeans editors are pure swing editors.
diff --git a/nbbuild/build.xml b/nbbuild/build.xml
index 12bd9ada1..237a9ffa1 100644
--- a/nbbuild/build.xml
+++ b/nbbuild/build.xml
@@ -2002,6 +2002,14 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  

  
+ 
+ 
+ 
+ 
+ 

+ 

+ 

+ 
  
  
  


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238811#comment-16238811
 ] 

ASF GitHub Bot commented on NETBEANS-54:


vieiro opened a new pull request #236: [NETBEANS-54] Module Review editor (rat 
exclusions)
URL: https://github.com/apache/incubator-netbeans/pull/236
 
 
- Added test files to rat exclusion list.
- Added a license to a README file.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238594#comment-16238594
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #227: [NETBEANS-54] adding license headers to 
various files in nbbuild
URL: 
https://github.com/apache/incubator-netbeans/pull/227#issuecomment-341853553
 
 
   Thanks a lot for the review!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238591#comment-16238591
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #232: [NETBEANS-54] Module Review 
jellytools.platform
URL: 
https://github.com/apache/incubator-netbeans/pull/232#issuecomment-341853421
 
 
   Thanks for the review — and will follow your insights here ASAP.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238518#comment-16238518
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #221: [NETBEANS-54] adding license headers to uml 
files in openide.windows
URL: https://github.com/apache/incubator-netbeans/pull/221
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/openide.windows/uml/windowsAPI.argo 
b/openide.windows/uml/windowsAPI.argo
index 4be8eee56..ea56b567a 100644
--- a/openide.windows/uml/windowsAPI.argo
+++ b/openide.windows/uml/windowsAPI.argo
@@ -1,4 +1,24 @@
 
+
 
 
   
diff --git a/openide.windows/uml/windowsAPI.xmi 
b/openide.windows/uml/windowsAPI.xmi
index 8daac2f36..b137dc6f7 100644
--- a/openide.windows/uml/windowsAPI.xmi
+++ b/openide.windows/uml/windowsAPI.xmi
@@ -1,4 +1,24 @@
 
+
 
 
   
diff --git a/openide.windows/uml/windowsAPI_classdiagram1.pgml 
b/openide.windows/uml/windowsAPI_classdiagram1.pgml
index 460d399d0..11a82c601 100644
--- a/openide.windows/uml/windowsAPI_classdiagram1.pgml
+++ b/openide.windows/uml/windowsAPI_classdiagram1.pgml
@@ -1,4 +1,24 @@
 
+
 
 
+
 
 
+
 
  Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238514#comment-16238514
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #226: [NETBEANS-54] adding license headers to UML 
files in openide.options
URL: https://github.com/apache/incubator-netbeans/pull/226
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/openide.options/uml/options.argo b/openide.options/uml/options.argo
index 84dc573a5..bfa9ac79d 100644
--- a/openide.options/uml/options.argo
+++ b/openide.options/uml/options.argo
@@ -1,4 +1,24 @@
 
+
 
 
   
diff --git a/openide.options/uml/options.xmi b/openide.options/uml/options.xmi
index d716a478c..17cfd1877 100644
--- a/openide.options/uml/options.xmi
+++ b/openide.options/uml/options.xmi
@@ -1,4 +1,24 @@
 
+
 
 
   
diff --git a/openide.options/uml/options_classdiagram8.pgml 
b/openide.options/uml/options_classdiagram8.pgml
index 5db37f03c..19dbde928 100644
--- a/openide.options/uml/options_classdiagram8.pgml
+++ b/openide.options/uml/options_classdiagram8.pgml
@@ -1,4 +1,24 @@
 
+
 
 
+
 
  Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238516#comment-16238516
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #221: [NETBEANS-54] adding license headers to uml 
files in openide.windows
URL: 
https://github.com/apache/incubator-netbeans/pull/221#issuecomment-341843893
 
 
   Thanks for the review! Merging now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238513#comment-16238513
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #226: [NETBEANS-54] adding license headers to UML 
files in openide.options
URL: 
https://github.com/apache/incubator-netbeans/pull/226#issuecomment-341843803
 
 
   Thanks for the review! Merging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238264#comment-16238264
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing closed pull request #233:  [NETBEANS-54] Module Review 
o.eclipse.core.runtime
URL: https://github.com/apache/incubator-netbeans/pull/233
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/o.eclipse.core.runtime/external/binaries-list 
b/o.eclipse.core.runtime/external/binaries-list
index 071544d04..cb8539372 100644
--- a/o.eclipse.core.runtime/external/binaries-list
+++ b/o.eclipse.core.runtime/external/binaries-list
@@ -14,4 +14,4 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-D2D2105B1E3C9E2FA6240AD088237A57590DDA8D 
org.eclipse.core.runtime-3.7.0_nosignature.jar
+6658C235056134F7E86295E751129508802D71F2 
org.eclipse.core:org.eclipse.core.runtime:3.7.0
diff --git a/o.eclipse.core.runtime/nbproject/project.properties 
b/o.eclipse.core.runtime/nbproject/project.properties
index 611e0becf..dd023c945 100644
--- a/o.eclipse.core.runtime/nbproject/project.properties
+++ b/o.eclipse.core.runtime/nbproject/project.properties
@@ -14,6 +14,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-release.external/org.eclipse.core.runtime-3.7.0_nosignature.jar=modules/org-eclipse-core-runtime.jar
+release.external/org.eclipse.core.runtime-3.7.0.jar=modules/org-eclipse-core-runtime.jar
 is.autoload=true
 nbm.module.author=Tomas Stupka
diff --git a/o.eclipse.core.runtime/nbproject/project.xml 
b/o.eclipse.core.runtime/nbproject/project.xml
index 56ba189a0..908d3427c 100644
--- a/o.eclipse.core.runtime/nbproject/project.xml
+++ b/o.eclipse.core.runtime/nbproject/project.xml
@@ -76,7 +76,7 @@
 
 
 
org-eclipse-core-runtime.jar
-
external/org.eclipse.core.runtime-3.7.0_nosignature.jar
+
external/org.eclipse.core.runtime-3.7.0.jar
 
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237448#comment-16237448
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #218: [NETBEANS-54] Module Review xml.jaxb
URL: 
https://github.com/apache/incubator-netbeans/pull/218#issuecomment-341673939
 
 
   Thanks a lot for the review, makes sense, will do.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237234#comment-16237234
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #223: [NETBEANS-54] Module Review libs.nbi.ant
URL: https://github.com/apache/incubator-netbeans/pull/223
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/libs.nbi.ant/stub/ext/components/products/helloworld/src/org/mycompany/wizard/panels/Bundle.properties
 
b/libs.nbi.ant/stub/ext/components/products/helloworld/src/org/mycompany/wizard/panels/Bundle.properties
index 1c1b64d4a..96cb31b91 100644
--- 
a/libs.nbi.ant/stub/ext/components/products/helloworld/src/org/mycompany/wizard/panels/Bundle.properties
+++ 
b/libs.nbi.ant/stub/ext/components/products/helloworld/src/org/mycompany/wizard/panels/Bundle.properties
@@ -1,41 +1,19 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Copyright (c) 2010, 2016 Oracle and/or its affiliates. All rights reserved.
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-#
-# The contents of this file are subject to the terms of either the GNU
-# General Public License Version 2 only ("GPL") or the Common
-# Development and Distribution License("CDDL") (collectively, the
-# "License"). You may not use this file except in compliance with the
-# License. You can obtain a copy of the License at
-# http://www.netbeans.org/cddl-gplv2.html
-# or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
-# specific language governing permissions and limitations under the
-# License.  When distributing the software, include this License Header
-# Notice in each file and include the License file at
-# nbbuild/licenses/CDDL-GPL-2-CP.  Oracle designates this
-# particular file as subject to the "Classpath" exception as provided
-# by Oracle in the GPL Version 2 section of the License file that
-# accompanied this code. If applicable, add the following below the
-# License Header, with the fields enclosed by brackets [] replaced by
-# your own identifying information:
-# "Portions Copyrighted [year] [name of copyright owner]"
-#
-# If you wish your version of this file to be governed by only the CDDL
-# or only the GPL Version 2, indicate your decision by adding
-# "[Contributor] elects to include this software in this distribution
-# under the [CDDL or GPL Version 2] license." If you do not indicate a
-# single choice of license, a recipient has the option to distribute
-# your version of this file under either the CDDL, the GPL Version 2 or
-# to extend the choice of license to its licensees as provided above.
-# However, if you add GPL Version 2 code and therefore, elected the GPL
-# Version 2 license, then the option applies only if the new code is
-# made subject to such option by the copyright holder.
-#
-# Contributor(s):
-# HelloWorldPanel.java
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 P.title={product-name} Installation
 P.description=Choose destination folder.
 P.destination.label.text= {product-name} to:
diff --git 
a/libs.nbi.ant/stub/ext/engine/src/org/mycompany/installer/utils/applications/Bundle.properties
 
b/libs.nbi.ant/stub/ext/engine/src/org/mycompany/installer/utils/applications/Bundle.properties
index 56afab3a2..33168547e 100644
--- 
a/libs.nbi.ant/stub/ext/engine/src/org/mycompany/installer/utils/applications/Bundle.properties
+++ 
b/libs.nbi.ant/stub/ext/engine/src/org/mycompany/installer/utils/applications/Bundle.properties
@@ -1,41 +1,19 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237233#comment-16237233
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #230: [NETBEANS-54] Module Review ide
URL: https://github.com/apache/incubator-netbeans/pull/230
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ide/bluejl10n.list b/ide/bluejl10n.list
index bb276dc12..40488f663 100644
--- a/ide/bluejl10n.list
+++ b/ide/bluejl10n.list
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
 ide/bluej-suite/branding/**/Bundle.properties
 ide/bluej-suite/branding/**/*.gif
 ide/bluej-suite/bluej-welcome/**/Bundle.properties
diff --git 
a/ide/launcher/macosx/NetBeansLauncher/English.lproj/MainMenu.nib/info.nib 
b/ide/launcher/macosx/NetBeansLauncher/English.lproj/MainMenu.nib/info.nib
index e0da0549c..ed3fb27a8 100644
--- a/ide/launcher/macosx/NetBeansLauncher/English.lproj/MainMenu.nib/info.nib
+++ b/ide/launcher/macosx/NetBeansLauncher/English.lproj/MainMenu.nib/info.nib
@@ -1,4 +1,24 @@
 
+
 http://www.apple.com/DTDs/PropertyList-1.0.dtd;>
 
 
diff --git a/ide/launcher/netbeans.clusters b/ide/launcher/netbeans.clusters
index 4e2e8859a..2ea6c1cb9 100644
--- a/ide/launcher/netbeans.clusters
+++ b/ide/launcher/netbeans.clusters
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 # platform cluster first
 platform
 # application cluster second
diff --git a/ide/launcher/netbeans.conf b/ide/launcher/netbeans.conf
index e8620d591..dbf8640f1 100644
--- a/ide/launcher/netbeans.conf
+++ b/ide/launcher/netbeans.conf
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
 # Default locations of userdir and cachedir:
 # (http://wiki.netbeans.org/FaqWhatIsUserdir)
 #
diff --git a/ide/launcher/windows/.dep.inc b/ide/launcher/windows/.dep.inc
index 4560e55af..08c0aeb8f 100644
--- a/ide/launcher/windows/.dep.inc
+++ b/ide/launcher/windows/.dep.inc
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237235#comment-16237235
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #219: [NETBEANS-54] Module Review 
websvc.saas.codegen.java
URL: https://github.com/apache/incubator-netbeans/pull/219
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/websvc.saas.codegen.java/src/org/netbeans/modules/websvc/saas/codegen/java/Bundle.properties
 
b/websvc.saas.codegen.java/src/org/netbeans/modules/websvc/saas/codegen/java/Bundle.properties
index 4043c5fb8..ad582864b 100644
--- 
a/websvc.saas.codegen.java/src/org/netbeans/modules/websvc/saas/codegen/java/Bundle.properties
+++ 
b/websvc.saas.codegen.java/src/org/netbeans/modules/websvc/saas/codegen/java/Bundle.properties
@@ -1,45 +1,19 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Copyright 1997-2010 Oracle and/or its affiliates. All rights reserved.
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-#
-# The contents of this file are subject to the terms of either the GNU
-# General Public License Version 2 only ("GPL") or the Common
-# Development and Distribution License("CDDL") (collectively, the
-# "License"). You may not use this file except in compliance with the
-# License. You can obtain a copy of the License at
-# http://www.netbeans.org/cddl-gplv2.html
-# or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
-# specific language governing permissions and limitations under the
-# License.  When distributing the software, include this License Header
-# Notice in each file and include the License file at
-# nbbuild/licenses/CDDL-GPL-2-CP.  Oracle designates this
-# particular file as subject to the "Classpath" exception as provided
-# by Oracle in the GPL Version 2 section of the License file that
-# accompanied this code. If applicable, add the following below the
-# License Header, with the fields enclosed by brackets [] replaced by
-# your own identifying information:
-# "Portions Copyrighted [year] [name of copyright owner]"
-#
-# Contributor(s):
-#
-# The Original Software is NetBeans. The Initial Developer of the Original
-# Software is Sun Microsystems, Inc. Portions Copyright 1997-2006 Sun
-# Microsystems, Inc. All Rights Reserved.
-#
-# If you wish your version of this file to be governed by only the CDDL
-# or only the GPL Version 2, indicate your decision by adding
-# "[Contributor] elects to include this software in this distribution
-# under the [CDDL or GPL Version 2] license." If you do not indicate a
-# single choice of license, a recipient has the option to distribute
-# your version of this file under either the CDDL, the GPL Version 2 or
-# to extend the choice of license to its licensees as provided above.
-# However, if you add GPL Version 2 code and therefore, elected the GPL
-# Version 2 license, then the option applies only if the new code is
-# made subject to such option by the copyright holder.
-# Sample ResourceBundle properties file
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 
 OpenIDE-Module-Name=SaaS Services Code Generation for Java
 OpenIDE-Module-Display-Category=Java
diff --git 
a/websvc.saas.codegen.java/src/org/netbeans/modules/websvc/saas/codegen/java/resources/ApiKeyAuthenticator.template
 
b/websvc.saas.codegen.java/src/org/netbeans/modules/websvc/saas/codegen/java/resources/ApiKeyAuthenticator.template
index 95402f981..4904eb515 100644
--- 
a/websvc.saas.codegen.java/src/org/netbeans/modules/websvc/saas/codegen/java/resources/ApiKeyAuthenticator.template
+++ 
b/websvc.saas.codegen.java/src/org/netbeans/modules/websvc/saas/codegen/java/resources/ApiKeyAuthenticator.template
@@ -1,4 +1,23 @@
-<#-- FreeMarker template (see http://freemarker.org/) -->
+<#-- FreeMarker template (see http://freemarker.org/)
+
+Licensed to the Apache 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237232#comment-16237232
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #228: [NETBEANS-54] Module Review jumpto
URL: https://github.com/apache/incubator-netbeans/pull/228
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/jumpto/nbproject/project.xml b/jumpto/nbproject/project.xml
index ff9ec269d..31b1bd0e5 100644
--- a/jumpto/nbproject/project.xml
+++ b/jumpto/nbproject/project.xml
@@ -19,52 +19,6 @@
 under the License.
 
 -->
-
 http://www.netbeans.org/ns/project/1;>
 org.netbeans.modules.apisupport.project
 
diff --git a/jumpto/src/org/netbeans/modules/jumpto/file/Bundle.properties 
b/jumpto/src/org/netbeans/modules/jumpto/file/Bundle.properties
index e51e9b20d..655f24ef8 100644
--- a/jumpto/src/org/netbeans/modules/jumpto/file/Bundle.properties
+++ b/jumpto/src/org/netbeans/modules/jumpto/file/Bundle.properties
@@ -1,45 +1,19 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Copyright 1997-2010 Oracle and/or its affiliates. All rights reserved.
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-#
-# The contents of this file are subject to the terms of either the GNU
-# General Public License Version 2 only ("GPL") or the Common
-# Development and Distribution License("CDDL") (collectively, the
-# "License"). You may not use this file except in compliance with the
-# License. You can obtain a copy of the License at
-# http://www.netbeans.org/cddl-gplv2.html
-# or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
-# specific language governing permissions and limitations under the
-# License.  When distributing the software, include this License Header
-# Notice in each file and include the License file at
-# nbbuild/licenses/CDDL-GPL-2-CP.  Oracle designates this
-# particular file as subject to the "Classpath" exception as provided
-# by Oracle in the GPL Version 2 section of the License file that
-# accompanied this code. If applicable, add the following below the
-# License Header, with the fields enclosed by brackets [] replaced by
-# your own identifying information:
-# "Portions Copyrighted [year] [name of copyright owner]"
-#
-# Contributor(s):
-#
-# The Original Software is the Accelerators module.
-# The Initial Developer of the Original Software is Andrei Badea.
-# Portions Copyright 2005-2006 Andrei Badea.
-# All Rights Reserved.
-#
-# If you wish your version of this file to be governed by only the CDDL
-# or only the GPL Version 2, indicate your decision by adding
-# "[Contributor] elects to include this software in this distribution
-# under the [CDDL or GPL Version 2] license." If you do not indicate a
-# single choice of license, a recipient has the option to distribute
-# your version of this file under either the CDDL, the GPL Version 2 or
-# to extend the choice of license to its licensees as provided above.
-# However, if you add GPL Version 2 code and therefore, elected the GPL
-# Version 2 license, then the option applies only if the new code is
-# made subject to such option by the copyright holder.
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 
 # FileSearchAction
 CTL_FileSearchAction=Go to 
diff --git a/jumpto/src/org/netbeans/modules/jumpto/file/FileSearchAction.java 
b/jumpto/src/org/netbeans/modules/jumpto/file/FileSearchAction.java
index 56875ce9e..1a451510e 100644
--- a/jumpto/src/org/netbeans/modules/jumpto/file/FileSearchAction.java
+++ b/jumpto/src/org/netbeans/modules/jumpto/file/FileSearchAction.java
@@ -1,47 +1,20 @@
-/*
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
- *
- * Copyright 1997-2010 Oracle and/or its affiliates. All rights reserved.
- *
- * Oracle and Java are registered trademarks of Oracle and/or its affiliates.
- * Other names may be 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237231#comment-16237231
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #229: [NETBEANS-54] Module Review spi.navigator & 
spi.palette
URL: https://github.com/apache/incubator-netbeans/pull/229
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/spi.navigator/src/org/netbeans/modules/navigator/resources/navigator.wsmode 
b/spi.navigator/src/org/netbeans/modules/navigator/resources/navigator.wsmode
index 3efca0fb9..0ecb6e2b6 100644
--- 
a/spi.navigator/src/org/netbeans/modules/navigator/resources/navigator.wsmode
+++ 
b/spi.navigator/src/org/netbeans/modules/navigator/resources/navigator.wsmode
@@ -1,5 +1,24 @@
 
+
 http://www.netbeans.org/dtds/mode-properties2_0.dtd;>
diff --git 
a/spi.palette/src/org/netbeans/modules/palette/resources/commonpalette.wsmode 
b/spi.palette/src/org/netbeans/modules/palette/resources/commonpalette.wsmode
index f3e79db85..0933fd776 100644
--- 
a/spi.palette/src/org/netbeans/modules/palette/resources/commonpalette.wsmode
+++ 
b/spi.palette/src/org/netbeans/modules/palette/resources/commonpalette.wsmode
@@ -1,5 +1,24 @@
 
+
 http://www.netbeans.org/dtds/mode-properties2_0.dtd;>


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237229#comment-16237229
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #231: [NETBEANS-54] Module Review jemmy
URL: https://github.com/apache/incubator-netbeans/pull/231
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/jemmy/CHANGES b/jemmy/CHANGES
index c81e834b3..d2d9b6100 100644
--- a/jemmy/CHANGES
+++ b/jemmy/CHANGES
@@ -1,44 +1,20 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
-
-# Copyright 2009-2017 Oracle and/or its affiliates. All rights reserved.
-#
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-#
-# The contents of this file are subject to the terms of either the GNU
-# General Public License Version 2 only ("GPL") or the Common
-# Development and Distribution License("CDDL") (collectively, the
-# "License"). You may not use this file except in compliance with the
-# License. You can obtain a copy of the License at
-# http://www.netbeans.org/cddl-gplv2.html
-# or nbbuild/licenses/CDDL-GPL-2-CP. See the License for the
-# specific language governing permissions and limitations under the
-# License.  When distributing the software, include this License Header
-# Notice in each file and include the License file at
-# nbbuild/licenses/CDDL-GPL-2-CP.  Oracle designates this
-# particular file as subject to the "Classpath" exception as provided
-# by Oracle in the GPL Version 2 section of the License file that
-# accompanied this code. If applicable, add the following below the
-# License Header, with the fields enclosed by brackets [] replaced by
-# your own identifying information:
-# "Portions Copyrighted [year] [name of copyright owner]"
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Contributor(s):
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
-# The Original Software is NetBeans. The Initial Developer of the Original
-# Software is Sun Microsystems, Inc. Portions Copyright 2009-2010 Sun
-# Microsystems, Inc. All Rights Reserved.
-#
-# If you wish your version of this file to be governed by only the CDDL
-# or only the GPL Version 2, indicate your decision by adding
-# "[Contributor] elects to include this software in this distribution
-# under the [CDDL or GPL Version 2] license." If you do not indicate a
-# single choice of license, a recipient has the option to distribute
-# your version of this file under either the CDDL, the GPL Version 2 or
-# to extend the choice of license to its licensees as provided above.
-# However, if you add GPL Version 2 code and therefore, elected the GPL
-# Version 2 license, then the option applies only if the new code is
-# made subject to such option by the copyright holder.
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
 #VERSION 1.0.1
 
 1. Jemmy versioning has been started.
diff --git a/jemmy/src/org/netbeans/modules/jemmy/idemodule/Bundle.properties 
b/jemmy/src/org/netbeans/modules/jemmy/idemodule/Bundle.properties
index 3ca118a78..2b3297369 100644
--- a/jemmy/src/org/netbeans/modules/jemmy/idemodule/Bundle.properties
+++ b/jemmy/src/org/netbeans/modules/jemmy/idemodule/Bundle.properties
@@ -1,45 +1,19 @@
-# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
 #
-# Copyright 1997-2010 Oracle and/or its affiliates. All rights reserved.
+#   http://www.apache.org/licenses/LICENSE-2.0
 #
-# Oracle and Java are registered trademarks of Oracle and/or its affiliates.
-# Other names may be trademarks of their respective owners.
-#
-# The contents of 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-03 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237228#comment-16237228
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw closed pull request #222: [NETBEANS-54] Module Review javahelp
URL: https://github.com/apache/incubator-netbeans/pull/222
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/javahelp/src/org/netbeans/modules/javahelp/resources/favorites_2_0.dtd 
b/javahelp/src/org/netbeans/modules/javahelp/resources/favorites_2_0.dtd
index 526b34457..a892681a9 100644
--- a/javahelp/src/org/netbeans/modules/javahelp/resources/favorites_2_0.dtd
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/favorites_2_0.dtd
@@ -1,10 +1,24 @@
 
 
-
 
 
diff --git 
a/javahelp/src/org/netbeans/modules/javahelp/resources/helpset_1_0.dtd 
b/javahelp/src/org/netbeans/modules/javahelp/resources/helpset_1_0.dtd
index bc743bb57..d37e3 100644
--- a/javahelp/src/org/netbeans/modules/javahelp/resources/helpset_1_0.dtd
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/helpset_1_0.dtd
@@ -1,10 +1,24 @@
 
 
-
 
 
diff --git 
a/javahelp/src/org/netbeans/modules/javahelp/resources/helpset_2_0.dtd 
b/javahelp/src/org/netbeans/modules/javahelp/resources/helpset_2_0.dtd
index f59f220fa..e2e911791 100644
--- a/javahelp/src/org/netbeans/modules/javahelp/resources/helpset_2_0.dtd
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/helpset_2_0.dtd
@@ -1,10 +1,24 @@
 
 
-
 
 
diff --git a/javahelp/src/org/netbeans/modules/javahelp/resources/index_1_0.dtd 
b/javahelp/src/org/netbeans/modules/javahelp/resources/index_1_0.dtd
index 7f7b1ab67..d2266cb8d 100644
--- a/javahelp/src/org/netbeans/modules/javahelp/resources/index_1_0.dtd
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/index_1_0.dtd
@@ -1,10 +1,24 @@
 
 
-
 
 
diff --git a/javahelp/src/org/netbeans/modules/javahelp/resources/index_2_0.dtd 
b/javahelp/src/org/netbeans/modules/javahelp/resources/index_2_0.dtd
index 4b51dafe2..06ab255a3 100644
--- a/javahelp/src/org/netbeans/modules/javahelp/resources/index_2_0.dtd
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/index_2_0.dtd
@@ -1,10 +1,24 @@
 
 
-
 
 
diff --git a/javahelp/src/org/netbeans/modules/javahelp/resources/map_1_0.dtd 
b/javahelp/src/org/netbeans/modules/javahelp/resources/map_1_0.dtd
index dd4d13db2..637b0eeb9 100644
--- a/javahelp/src/org/netbeans/modules/javahelp/resources/map_1_0.dtd
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/map_1_0.dtd
@@ -1,10 +1,23 @@
 
 
-
 
diff --git a/javahelp/src/org/netbeans/modules/javahelp/resources/map_2_0.dtd 
b/javahelp/src/org/netbeans/modules/javahelp/resources/map_2_0.dtd
index d241d8374..cab8725c1 100644
--- a/javahelp/src/org/netbeans/modules/javahelp/resources/map_2_0.dtd
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/map_2_0.dtd
@@ -1,10 +1,23 @@
 
 
-
 
diff --git a/javahelp/src/org/netbeans/modules/javahelp/resources/toc_1_0.dtd 
b/javahelp/src/org/netbeans/modules/javahelp/resources/toc_1_0.dtd
index a5e9337b8..96bc0d813 100644
--- a/javahelp/src/org/netbeans/modules/javahelp/resources/toc_1_0.dtd
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/toc_1_0.dtd
@@ -1,10 +1,24 @@
 
 
-
 
 
diff --git a/javahelp/src/org/netbeans/modules/javahelp/resources/toc_2_0.dtd 
b/javahelp/src/org/netbeans/modules/javahelp/resources/toc_2_0.dtd
index d8b6908b3..646864dd1 100644
--- a/javahelp/src/org/netbeans/modules/javahelp/resources/toc_2_0.dtd
+++ b/javahelp/src/org/netbeans/modules/javahelp/resources/toc_2_0.dtd
@@ -1,10 +1,24 @@
 
 
-
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and 

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237124#comment-16237124
 ] 

ASF GitHub Bot commented on NETBEANS-54:


vieiro commented on issue #42: [NETBEANS-54] Module Review editor
URL: https://github.com/apache/incubator-netbeans/pull/42#issuecomment-341626789
 
 
   Thanks, guys, for your reviews. 
   
   I'll do a new PR tonight/EU Time.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237073#comment-16237073
 ] 

ASF GitHub Bot commented on NETBEANS-54:


junichi11 commented on a change in pull request #232: [NETBEANS-54] Module 
Review jellytools.platform
URL: https://github.com/apache/incubator-netbeans/pull/232#discussion_r148709253
 
 

 ##
 File path: jellytools.platform/src/org/netbeans/jellytools/version_info
 ##
 @@ -1,3 +1,19 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
 
 Review comment:
   This file is used as a manifest file. So, probably, the license header 
cannot be added.
   
   
https://github.com/apache/incubator-netbeans/blob/7f1440637c74b193db41a9cc26437f94cb41c79c/jellytools.platform/src/org/netbeans/jellytools/JellyVersion.java#L73-L80


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236963#comment-16236963
 ] 

ASF GitHub Bot commented on NETBEANS-54:


junichi11 commented on a change in pull request #42: [NETBEANS-54] Module 
Review editor
URL: https://github.com/apache/incubator-netbeans/pull/42#discussion_r148699327
 
 

 ##
 File path: nbbuild/build.xml
 ##
 @@ -2002,6 +2002,14 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  

  
+ 
+ 
+ 
+ 
 
 Review comment:
   This line is excluded with ``.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236965#comment-16236965
 ] 

ASF GitHub Bot commented on NETBEANS-54:


junichi11 commented on a change in pull request #42: [NETBEANS-54] Module 
Review editor
URL: https://github.com/apache/incubator-netbeans/pull/42#discussion_r148699900
 
 

 ##
 File path: nbbuild/build.xml
 ##
 @@ -2002,6 +2002,14 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y 
to start the system in d
  
  

  
+ 
+ 
+ 
+ 
+ 

 
 Review comment:
   I suggest ``.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236853#comment-16236853
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #233:  [NETBEANS-54] Module Review 
o.eclipse.core.runtime
URL: 
https://github.com/apache/incubator-netbeans/pull/233#issuecomment-341592945
 
 
   Thanks, looks good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236670#comment-16236670
 ] 

ASF GitHub Bot commented on NETBEANS-54:


vieiro opened a new pull request #233:  [NETBEANS-54] Module Review 
o.eclipse.core.runtime
URL: https://github.com/apache/incubator-netbeans/pull/233
 
 
- Added maven coordinates for the binary. 
- No other licensing issues found (but for manifest.mf, to be handled 
centrally).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236484#comment-16236484
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #232: [NETBEANS-54] Module Review 
jellytools.platform
URL: https://github.com/apache/incubator-netbeans/pull/232
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236476#comment-16236476
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #231: [NETBEANS-54] Module Review jemmy
URL: https://github.com/apache/incubator-netbeans/pull/231
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235975#comment-16235975
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #230: [NETBEANS-54] Module Review ide
URL: https://github.com/apache/incubator-netbeans/pull/230
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235805#comment-16235805
 ] 

ASF GitHub Bot commented on NETBEANS-54:


vieiro commented on issue #42: [NETBEANS-54] Module Review editor
URL: https://github.com/apache/incubator-netbeans/pull/42#issuecomment-341436166
 
 
   Will take a look at them tonight.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235800#comment-16235800
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #229: [NETBEANS-54] Module Review 
spi.navigator & spi.palette
URL: https://github.com/apache/incubator-netbeans/pull/229
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235787#comment-16235787
 ] 

ASF GitHub Bot commented on NETBEANS-54:


vieiro opened a new pull request #42: [NETBEANS-54] Module Review editor
URL: https://github.com/apache/incubator-netbeans/pull/42
 
 
   - No external libraries.
   - Checked Rat report: added license to project files. Did NOT add license to 
editor/demosrc/README nor to the rest of test files.
   - Unit tests org.netbeans.editor.PlainDocumentCompatibilityRandomTest and 
org.netbeans.modules.editor.NbEditorToolBarTest fail (but they were also 
failing before this PR).
   - QA Tests should be run.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235786#comment-16235786
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw commented on issue #42: [NETBEANS-54] Module Review editor
URL: https://github.com/apache/incubator-netbeans/pull/42#issuecomment-341431686
 
 
   Reopening with the above question.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235784#comment-16235784
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #228: [NETBEANS-54] Module Review jumpto
URL: https://github.com/apache/incubator-netbeans/pull/228
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235665#comment-16235665
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing closed pull request #210: [NETBEANS-54] Module Review 
o.apache.commons.codec
URL: https://github.com/apache/incubator-netbeans/pull/210
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/o.apache.commons.codec/build.xml b/o.apache.commons.codec/build.xml
index af4316748..20f87dffa 100644
--- a/o.apache.commons.codec/build.xml
+++ b/o.apache.commons.codec/build.xml
@@ -23,7 +23,7 @@
 
 
 
-
+
 
 
 
diff --git a/o.apache.commons.codec/external/binaries-list 
b/o.apache.commons.codec/external/binaries-list
index b34abc540..9caf2fac6 100644
--- a/o.apache.commons.codec/external/binaries-list
+++ b/o.apache.commons.codec/external/binaries-list
@@ -14,4 +14,4 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-FD32786786E2ADB664D5ECC965DA47629DCA14BA apache-commons-codec-1.3.jar
+FD32786786E2ADB664D5ECC965DA47629DCA14BA commons-codec:commons-codec:1.3
diff --git 
a/o.apache.commons.codec/external/org.apache.commons.codec-1.3.0-license.txt 
b/o.apache.commons.codec/external/commons.codec-1.3-license.txt
similarity index 100%
rename from 
o.apache.commons.codec/external/org.apache.commons.codec-1.3.0-license.txt
rename to o.apache.commons.codec/external/commons.codec-1.3-license.txt
diff --git a/o.apache.commons.codec/external/commons.codec-1.3-notice.txt 
b/o.apache.commons.codec/external/commons.codec-1.3-notice.txt
new file mode 100644
index 0..7196130f7
--- /dev/null
+++ b/o.apache.commons.codec/external/commons.codec-1.3-notice.txt
@@ -0,0 +1,2 @@
+This product includes software developed by
+The Apache Software Foundation (http://www.apache.org/).
\ No newline at end of file
diff --git a/o.apache.commons.codec/nbproject/project.xml 
b/o.apache.commons.codec/nbproject/project.xml
index 72f270a8e..19e85cb94 100644
--- a/o.apache.commons.codec/nbproject/project.xml
+++ b/o.apache.commons.codec/nbproject/project.xml
@@ -28,7 +28,7 @@
 
 
 
org-apache-commons-codec.jar
-
external/apache-commons-codec-1.3.jar
+external/commons-codec-1.3.jar
 
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a

[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235663#comment-16235663
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing closed pull request #209:  [NETBEANS-54] Module Review 
o.apache.commons.lang
URL: https://github.com/apache/incubator-netbeans/pull/209
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/o.apache.commons.lang/external/binaries-list 
b/o.apache.commons.lang/external/binaries-list
index 560390362..dd6121416 100644
--- a/o.apache.commons.lang/external/binaries-list
+++ b/o.apache.commons.lang/external/binaries-list
@@ -14,4 +14,4 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-0CE1EDB914C94EBC388F086C6827E8BDEEC71AC2 commons-lang-2.6.jar
+0CE1EDB914C94EBC388F086C6827E8BDEEC71AC2 commons-lang:commons-lang:2.6
diff --git 
a/o.apache.commons.lang/external/org.apache.commons.lang-2.6.0.v201404270220-license.txt
 b/o.apache.commons.lang/external/common-lang-2.6-license.txt
similarity index 100%
rename from 
o.apache.commons.lang/external/org.apache.commons.lang-2.6.0.v201404270220-license.txt
rename to o.apache.commons.lang/external/common-lang-2.6-license.txt
diff --git a/o.apache.commons.lang/external/common-lang-2.6-notice.txt 
b/o.apache.commons.lang/external/common-lang-2.6-notice.txt
new file mode 100644
index 0..c0696a6c3
--- /dev/null
+++ b/o.apache.commons.lang/external/common-lang-2.6-notice.txt
@@ -0,0 +1,5 @@
+Apache Commons Lang
+Copyright 2001-2011 The Apache Software Foundation
+
+This product includes software developed by
+The Apache Software Foundation (http://www.apache.org/).
\ No newline at end of file


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235662#comment-16235662
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #209:  [NETBEANS-54] Module Review 
o.apache.commons.lang
URL: 
https://github.com/apache/incubator-netbeans/pull/209#issuecomment-341408438
 
 
   Thanks for ensuring correct naming!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235656#comment-16235656
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing closed pull request #212:  [NETBEANS-54] Module Review 
o.apache.commons.logging
URL: https://github.com/apache/incubator-netbeans/pull/212
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/o.apache.commons.logging/external/binaries-list 
b/o.apache.commons.logging/external/binaries-list
index fd43abf6f..5f562869c 100644
--- a/o.apache.commons.logging/external/binaries-list
+++ b/o.apache.commons.logging/external/binaries-list
@@ -14,4 +14,4 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-2D859791FBF7D880591864BD4004D8442A8A3B81 commons-logging-1.1.1.jar
+5043BFEBC3DB072ED80FBD362E7CAF00E885D8AE commons-logging:commons-logging:1.1.1
diff --git a/o.apache.commons.logging/external/commons-logging-1.1.1-notice.txt 
b/o.apache.commons.logging/external/commons-logging-1.1.1-notice.txt
new file mode 100644
index 0..3d948f5a6
--- /dev/null
+++ b/o.apache.commons.logging/external/commons-logging-1.1.1-notice.txt
@@ -0,0 +1,5 @@
+Apache Commons Logging
+Copyright 2003-2007 The Apache Software Foundation
+
+This product includes software developed by
+The Apache Software Foundation (http://www.apache.org/).


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235654#comment-16235654
 ] 

ASF GitHub Bot commented on NETBEANS-54:


matthiasblaesing commented on issue #212:  [NETBEANS-54] Module Review 
o.apache.commons.logging
URL: 
https://github.com/apache/incubator-netbeans/pull/212#issuecomment-341408121
 
 
   Thank you - looks good. Merging!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235575#comment-16235575
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #227: [NETBEANS-54] adding license headers 
to various files in nbbuild
URL: https://github.com/apache/incubator-netbeans/pull/227
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1623#comment-1623
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #226: [NETBEANS-54] adding license headers 
to UML files in openide.options
URL: https://github.com/apache/incubator-netbeans/pull/226
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (NETBEANS-54) Clarify the status of donated files from ApacheNetBeansDonation1.zip

2017-11-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NETBEANS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235512#comment-16235512
 ] 

ASF GitHub Bot commented on NETBEANS-54:


geertjanw opened a new pull request #224: [NETBEANS-54] adding licenses to uml 
files in openide.nodes
URL: https://github.com/apache/incubator-netbeans/pull/224
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Clarify the status of donated files from ApacheNetBeansDonation1.zip
> 
>
> Key: NETBEANS-54
> URL: https://issues.apache.org/jira/browse/NETBEANS-54
> Project: NetBeans
>  Issue Type: Bug
>Reporter: Bertrand Delacretaz
>Priority: Major
>  Labels: pull-request-available
> Attachments: JavaApplication9.java, categorized-1.zip, 
> convert-headers-1.zip
>
>
> Reviewing the software grant [1] provided with the first NetBeans code 
> donation, my understanding is that not all files found in that zip are 
> donated.
> The grant indicates that the contents of that file [2] ("Code File") are 
> donated "excluding any third-party and separately licensed material contained 
> within the Code File". 
> I don't think we can consider that code ready to release as is, due to the 
> uncertainty that this creates w.r.t to which files are donated and which are 
> not.
> The zip archive contains about 45'000 files.
> I see the following options:
> a) Review all files and include only those which are not "third-party and 
> separately licensed material". How such files are identified needs to be 
> defined and documented, either in scripts under version control or as a set 
> of rules. The review process must be documented and traceable, so that we can 
> go back to it if problems are found in the future.
> b) Get an updated grant which does not mention such exclusions.
> If someone sees other options please discuss here or on the NetBeans dev 
> list, referencing this ticket.
> [1] in svn under private/documents/grants/oracle-america-netbeans.pdf , ASF 
> members have access
> [2] under http://bits.netbeans.org/download/apache-donation/  - 
> SHA256(ApacheNetBeansDonation1.zip)=
> 7f2ca0f61953a190613c9a0fbcc1b034084b04a4d55d23c02cefffc354e7c24a



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


  1   2   3   4   5   6   >