[incubator-nuttx] branch master updated: arch: xtensa: Call the waiti instruction in up_idle()
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new da3fb9c arch: xtensa: Call the waiti instruction in up_idle()
da3fb9c is described below
commit da3fb9c94f8dc57c2a89d0aa00ae88650b98337b
Author: Masayuki Ishikawa
AuthorDate: Fri Mar 6 13:00:37 2020 +0900
arch: xtensa: Call the waiti instruction in up_idle()
Signed-off-by: Masayuki Ishikawa
---
arch/xtensa/src/common/xtensa_idle.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/xtensa/src/common/xtensa_idle.c
b/arch/xtensa/src/common/xtensa_idle.c
index f6e2c3f..9ac16d4 100644
--- a/arch/xtensa/src/common/xtensa_idle.c
+++ b/arch/xtensa/src/common/xtensa_idle.c
@@ -92,4 +92,11 @@ void up_idle(void)
leave_critical_section(flags);
#endif
#endif
+
+ /* This would be an appropriate place to put some MCU-specific logic to
+ * sleep in a reduced power mode until an interrupt occurs to save power
+ */
+
+ asm("waiti 0");
+
}
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #450: arch: xtensa: Call the waiti instruction in up_idle()
xiaoxiang781216 merged pull request #450: arch: xtensa: Call the waiti instruction in up_idle() URL: https://github.com/apache/incubator-nuttx/pull/450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (4879f22 -> c85cb17)
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 4879f22 nxstyle: Don't complain on ELF things like Elf32_Hdr add c85cb17 nuttx/arch.h: Several nxstyle fixes No new revisions were added by this update. Summary of changes: include/nuttx/arch.h | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-)
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #454: nuttx/arch.h: Several nxstyle fixes
xiaoxiang781216 merged pull request #454: nuttx/arch.h: Several nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595625436 > @liuguo09 also if you have your Dockerfile somewhere I would be happy to submit a PR against it to improve it a bit. There is some low hanging fruit that would reduce the size by quite a bit. I have just made PR here the Dockerfile. https://github.com/apache/incubator-nuttx-testing/pull/13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #450: arch: xtensa: Call the waiti instruction in up_idle()
yamt commented on issue #450: arch: xtensa: Call the waiti instruction in up_idle() URL: https://github.com/apache/incubator-nuttx/pull/450#issuecomment-595620856 lgtm. i have had the identical change in my local tree for a while. i haven't noticed any negative effect at least on qemu. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #454: nuttx/arch.h: Several nxstyle fixes
yamt opened a new pull request #454: nuttx/arch.h: Several nxstyle fixes URL: https://github.com/apache/incubator-nuttx/pull/454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid…
yamt opened a new pull request #453: Revert "tools/nxstyle: Back out part of last commit. Logic to avoid… URL: https://github.com/apache/incubator-nuttx/pull/453 … some false alarms was causing real style problems from being reported." If we are going to use this tool for things like git pre-commit hook or CI workflow, it's critical to avoid false alarms. This reverts commit de764af9aa5364d2dc02e09e377cbab230302d74. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #452: nxstyle: Don't warn on a preprocessor directive after comment
yamt opened a new pull request #452: nxstyle: Don't warn on a preprocessor directive after comment URL: https://github.com/apache/incubator-nuttx/pull/452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #452: nxstyle: Don't warn on a preprocessor directive after comment
yamt commented on issue #452: nxstyle: Don't warn on a preprocessor directive after comment URL: https://github.com/apache/incubator-nuttx/pull/452#issuecomment-595619505 oops, wrong branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt closed pull request #452: nxstyle: Don't warn on a preprocessor directive after comment
yamt closed pull request #452: nxstyle: Don't warn on a preprocessor directive after comment URL: https://github.com/apache/incubator-nuttx/pull/452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #451: nxstyle: Output line numbers when complaining on block comments length
yamt opened a new pull request #451: nxstyle: Output line numbers when complaining on block comments length URL: https://github.com/apache/incubator-nuttx/pull/451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388709203 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: It's fine to add pre-commit in tools folder or generate it from checkpatch.sh, the key point is the pre-commit need to forward the real action to checkpatch.sh because: 1.We will continue to enhance the workflow, especially in the current(initial) phase, it is very important that we can modify the workflow in one place. 2.pre-commit normally need copy to nuttx/.git/hooks and apps/.git/hooks, so it's hard to update it automatically through git pull. And If something in checkpatch.sh isn't good, we can send PR to enhance it, then all caller get the update autoamtically. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #261: Initial checkin nuttx github action CI workflow
xiaoxiang781216 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595593159 Yes, we can select some images(sim, x86, x86-64, qemu for arm/riscv/xtens..) as build artifacts and run the testsuite on this images automatically. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #450: arch: xtensa: Call the waiti instruction in up_idle()
masayuki2009 opened a new pull request #450: arch: xtensa: Call the waiti instruction in up_idle() URL: https://github.com/apache/incubator-nuttx/pull/450 ### Summary - This PR calls the waiti (wait for interrupt) instruction in up_idle() to reduce power consumption. ### Impact - This PR affects xtensa architecture (e.g. esp32) ### Testing - I tested this PR with both ESP32-DevKitC and QEMU for ESP32. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #448: Add a sample of git pre-commit hook
yamt commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388701099 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: i'd like to suggest checkpatch.sh minimum. do not install tools, or set up git hooks. instead, introduce a separate script to do those "heavy" jobs. how do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388699113 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: BTW, I am considering that is it better that we add one option in checkpatch.sh to generate pre-commit and put it into .git/hook? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388698278 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: But it is helping newbie to setup environment, it's hard to generate nxstyle from command line manually. Anyway, we can disscuss whether checkpatch.sh should or not invoke make automatically, but it's better to call checkpatch.sh here to ensure the consistent result with precheck process. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer opened a new pull request #449: Add Apache 2.0 License headers to SAMA5 files — no code changes
adamfeuer opened a new pull request #449: Add Apache 2.0 License headers to SAMA5 files — no code changes URL: https://github.com/apache/incubator-nuttx/pull/449 ### Summary * Adds Apache 2.0 License headers to SAMA5 — no code changes. * Some non-UTF-characters were removed or changed in comments. ### Impact * None if you are not using the SAMA5 chips * Should be none for SAMA5 users, but code files were touched. ### Detail * Non-UTF-8 characters in comments were replaced or removed. All files are now UTF-8 encoded. ### Testing * SAMA5D27-XULT compiles This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #448: Add a sample of git pre-commit hook
yamt commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388695824 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: i was not aware of checkpatch.sh. personally i'm not comfortable to run make in git hooks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #446: nxstyle: Don't complain on ELF things like Elf32_Hdr
patacongo merged pull request #446: nxstyle: Don't complain on ELF things like Elf32_Hdr URL: https://github.com/apache/incubator-nuttx/pull/446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (e5ea0ac -> 4879f22)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from e5ea0ac nxstyle: Don't parse a file if its type is unknown add 4879f22 nxstyle: Don't complain on ELF things like Elf32_Hdr No new revisions were added by this update. Summary of changes: tools/nxstyle.c | 7 +++ 1 file changed, 7 insertions(+)
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
liuguo09 commented on a change in pull request #261: Initial checkin nuttx
github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388694067
##
File path: .github/workflows/main.yml
##
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+branches:
+ - master
+
+jobs:
+ check:
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+steps:
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+path: nuttx
+fetch-depth: 0
+
+- name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+repository: apache/incubator-nuttx-apps
+path: apps
+fetch-depth: 0
+
+- name: Check Pull Request
+ run: |
+cd nuttx
+git log --oneline -5
+ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1
".." $2 }'`
+commits=`git log --reverse --format=format:%H $ranges`
+echo "./tools/checkpatch.sh -g $commits"
+./tools/checkpatch.sh -g $commits
+
+ build:
+needs: check
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+strategy:
+ matrix:
+boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05,
arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+steps:
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+path: nuttx
+fetch-depth: 0
+
+- name: Fetch nuttx tags
+ run: |
+cd nuttx
+git fetch --tags
Review comment:
> This can be done in the checkout step
https://github.com/actions/checkout#fetch-all-tags
Since I'm using the _with_ option for checkout@v2 action, the _run_ step
seems not work together. I'll double check it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 commented on issue #437: Support to run NuttX on ESP32 QEMU
masayuki2009 commented on issue #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#issuecomment-595576729 @maht, thanks for sending this PR. I confirmed that nuttx works on ESP32 QEMU. (SMP configuration also works!) However, I noticed that the difference between nsh/defconfig and qemu-nsh/defconfig is just the following setting. CONFIG_SUPPRESS_UART_CONFIG=y Actually I noticed that this setting works with ESP32-DevKitC board. (Perhaps, bootloader already set UART clock correctly). So I think we should apply the above settings to all configurations so that we can run all configurations on QEMU and also remove qemu-nsh/defconfig. What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388692212 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +name: PR Check CI + +on: + pull_request: Review comment: > I see that it by default includes synchronize so probably fine to leave it, but I would drop the branch. Maybe we still want to keep the push but limited to branch master so there is always a build on master > something like this: > > ``` > on: > pull_request > push: > branches: [master] > ``` Yes, besides master branch, pull request check for feature branch would also be useful. Now I use the pull request git log "Merge new-commit-id into old-commit-id" to filter commits in the PR and then do checkpatch.sh. But for master push, it should not work and skip. Just see the github action _job steps.if_ could be used to judge it. I'll update it later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook
xiaoxiang781216 commented on a change in pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448#discussion_r388691596 ## File path: tools/git-hooks/pre-commit ## @@ -0,0 +1,30 @@ +#!/bin/sh + + +# tools/git-hooks/pre-commit +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + + +# This file is intended to be used as .git/hooks/pre-commit + +if ! type nxstyle > /dev/null 2>&1; then Review comment: Call tools/checkpatch.sh intead, the benefit include: 1.Generate nxstyle automatically 2.Get more precheck in the furture a.copyright check b.spell check 3.The same result as github action(it call checkpatch.sh too) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #448: Add a sample of git pre-commit hook
yamt opened a new pull request #448: Add a sample of git pre-commit hook URL: https://github.com/apache/incubator-nuttx/pull/448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #447: ESP32 module support
yamt commented on issue #447: ESP32 module support URL: https://github.com/apache/incubator-nuttx/pull/447#issuecomment-595569920 @patacongo this pr includes a commit https://github.com/apache/incubator-nuttx/pull/447/commits/243427296613dcbe650138fb248d8009012832f6 which modifies your copyright notice. please review. thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595569258 > This looks great overall. I am excited to get this in and then work on getting the mac and windows configurations going. > > Also I do not think it is required for this first step, but adding build artifacts to the builds would be awesome as well since one could just grab a elf and the debug symbols for a build and throw it on a board to do some other validation on hardware. https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts IMO, It's a good idea. The build artifacts stage could be added in future if agreed and it doesn't add much time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #447: Esp32 module
yamt opened a new pull request #447: Esp32 module URL: https://github.com/apache/incubator-nuttx/pull/447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388680693 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +name: PR Check CI + +on: + pull_request: Review comment: > @liuguo09 also if you have your Dockerfile somewhere I would be happy to submit a PR against it to improve it a bit. There is some low hanging fruit that would reduce the size by quite a bit. Yes, that's great. I meant to add the Dockerfile into nuttx testing repo. I'll add it later. Then you could update it there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] yamt opened a new pull request #446: nxstyle: Don't complain on ELF things like Elf32_Hdr
yamt opened a new pull request #446: nxstyle: Don't complain on ELF things like Elf32_Hdr URL: https://github.com/apache/incubator-nuttx/pull/446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #445: nxstyle: Don't parse a file if its type is unknown
patacongo merged pull request #445: nxstyle: Don't parse a file if its type is unknown URL: https://github.com/apache/incubator-nuttx/pull/445 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (730133d -> e5ea0ac)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 730133d SAMA5D27 peripheral support - USB Host working (#444) add e5ea0ac nxstyle: Don't parse a file if its type is unknown No new revisions were added by this update. Summary of changes: tools/nxstyle.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-)
[GitHub] [incubator-nuttx] yamt opened a new pull request #445: nxstyle: Don't parse a file if its type is unknown
yamt opened a new pull request #445: nxstyle: Don't parse a file if its type is unknown URL: https://github.com/apache/incubator-nuttx/pull/445 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388672456 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +name: PR Check CI + +on: + pull_request: Review comment: I see that it by default includes synchronize so probably fine to leave it, but I would drop the branch. Maybe we still want to keep the push but limited to branch master so there is always a build on master something like this: ``` on: pull_request push: branches: [master] ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #261: Initial checkin nuttx github action CI workflow
btashton commented on issue #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595551685 @liuguo09 also if you have your Dockerfile somewhere I would be happy to submit a PR against it to improve it a bit. There is some low hanging fruit that would reduce the size by quite a bit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388666475 ## File path: .github/workflows/main.yml ## @@ -0,0 +1,85 @@ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +name: PR Check CI + +on: + pull_request: Review comment: Should we not also run on the `push` event? Also I think this restricts to pull requests off master which might not be what we want if there is a long running feature branch. I think is can just be this. `on: [push, pull_request]` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
btashton commented on a change in pull request #261: Initial checkin nuttx
github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388666947
##
File path: .github/workflows/main.yml
##
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+branches:
+ - master
+
+jobs:
+ check:
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+steps:
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+path: nuttx
+fetch-depth: 0
+
+- name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+repository: apache/incubator-nuttx-apps
+path: apps
+fetch-depth: 0
+
+- name: Check Pull Request
+ run: |
+cd nuttx
+git log --oneline -5
+ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1
".." $2 }'`
+commits=`git log --reverse --format=format:%H $ranges`
+echo "./tools/checkpatch.sh -g $commits"
+./tools/checkpatch.sh -g $commits
+
+ build:
+needs: check
+runs-on: ubuntu-18.04
+container: liuguo09/ubuntu-nuttx:18.04
+
+strategy:
+ matrix:
+boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05,
arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+steps:
+- name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+path: nuttx
+fetch-depth: 0
+
+- name: Fetch nuttx tags
+ run: |
+cd nuttx
+git fetch --tags
Review comment:
This can be done in the checkout step
https://github.com/actions/checkout#fetch-all-tags
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo merged pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595508795 @patacongo Thanks— I went through the changed files view and looked to make sure I took care of everything. I resolved all the conversations with your suggestions. It should be good to merge now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr444 created (now 859d694)
This is an automated email from the ASF dual-hosted git repository. gnutt pushed a change to branch pr444 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at 859d694 z20x: Correct RAM wait states. No new revisions were added by this update.
[GitHub] [incubator-nuttx] patacongo commented on issue #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on issue #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595505733 There are quite a few things here. Perhaps you can "Resolve conversation" when the changes are in place. Once all of the conversations have been resoved, I will do the merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388631703 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -26,27 +26,40 @@ CONFIG_AUDIO_NUM_BUFFERS=8 CONFIG_BOARD_LOOPSPERMSEC=65775 CONFIG_BOOT_RUNFROMSDRAM=y CONFIG_BUILTIN=y +CONFIG_CDCACM=y +CONFIG_DEBUG_ERROR=y +CONFIG_DEBUG_FEATURES=y +CONFIG_DEBUG_INFO=y +CONFIG_DEBUG_USB=y +CONFIG_DEBUG_USB_INFO=y +CONFIG_DEBUG_WARN=y Review comment: Also, any new configurations or any changes to existing configurations need to be documented in the board's README.txt file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on issue #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#issuecomment-595502991 @patacongo Thanks for the improvements. I think I made all the suggested fixes, will you take a look and see if there's anything else I need to do? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388630698 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ethernet.c ## @@ -0,0 +1,343 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_ethernet.c + * + * Copyright (C) 2014, 2017 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388606192 ## File path: boards/arm/sama5/sama5d2-xult/src/Makefile ## @@ -1,7 +1,7 @@ -# boards/arm/sama5/sama5d2-xult/src/Makefile +# boards/arm/sama5/sama5d3-xplained/src/Makefile # -# Copyright (C) 2015 Gregory Nutt. All rights reserved. +# Copyright (C) 2014 Gregory Nutt. All rights reserved. Review comment: @patacongo I probably copied the entire file from the SAMA5D3-Xplained to get the peripherals to work. I will update to 2020. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388606207 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -26,27 +26,40 @@ CONFIG_AUDIO_NUM_BUFFERS=8 CONFIG_BOARD_LOOPSPERMSEC=65775 CONFIG_BOOT_RUNFROMSDRAM=y CONFIG_BUILTIN=y +CONFIG_CDCACM=y +CONFIG_DEBUG_ERROR=y +CONFIG_DEBUG_FEATURES=y +CONFIG_DEBUG_INFO=y +CONFIG_DEBUG_USB=y +CONFIG_DEBUG_USB_INFO=y +CONFIG_DEBUG_WARN=y Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388605409 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ajoystick.c ## @@ -0,0 +1,452 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_ajoystick.c + * + * Copyright (C) 2014, 2016, 2018 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388605242 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -8,7 +8,7 @@ # CONFIG_AUDIO_FORMAT_MP3 is not set Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388598106 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ajoystick.c ## @@ -0,0 +1,452 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_ajoystick.c + * + * Copyright (C) 2014, 2016, 2018 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597796 ## File path: boards/arm/sama5/sama5d2-xult/src/Makefile ## @@ -1,7 +1,7 @@ -# boards/arm/sama5/sama5d2-xult/src/Makefile +# boards/arm/sama5/sama5d3-xplained/src/Makefile # -# Copyright (C) 2015 Gregory Nutt. All rights reserved. +# Copyright (C) 2014 Gregory Nutt. All rights reserved. Review comment: Why the the copyright date go backward in time? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597128 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -8,7 +8,7 @@ # CONFIG_AUDIO_FORMAT_MP3 is not set Review comment: Please do not modify the generic nsh configuration. People expect nsh configurations to be simple. Please create a new configuration, perhaps called netnsh (as for other configurations). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597444 ## File path: boards/arm/sama5/sama5d2-xult/configs/nsh/defconfig ## @@ -26,27 +26,40 @@ CONFIG_AUDIO_NUM_BUFFERS=8 CONFIG_BOARD_LOOPSPERMSEC=65775 CONFIG_BOOT_RUNFROMSDRAM=y CONFIG_BUILTIN=y +CONFIG_CDCACM=y +CONFIG_DEBUG_ERROR=y +CONFIG_DEBUG_FEATURES=y +CONFIG_DEBUG_INFO=y +CONFIG_DEBUG_USB=y +CONFIG_DEBUG_USB_INFO=y +CONFIG_DEBUG_WARN=y Review comment: No DEBUG configurations are permitted on commited defconfig files. Please remove these. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597096 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -157,6 +162,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin) } #endif #ifdef CONFIG_SAMA5_PIOF_IRQ + Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral
support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596923
##
File path: arch/arm/src/sama5/sam_pioirq.c
##
@@ -117,6 +117,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
if (irq >= SAM_IRQ_NINT)
{
#ifdef CONFIG_SAMA5_PIOA_IRQ
+
Review comment:
@patacongo Will fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388597017 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -141,6 +144,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin) } #endif #ifdef CONFIG_SAMA5_PIOD_IRQ + Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596967 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -125,6 +126,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin) } #endif #ifdef CONFIG_SAMA5_PIOB_IRQ + Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596891 ## File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h ## @@ -80,6 +81,7 @@ #define SAM_EBICS3_PSECTION 0x6000 /* 0x6000-0x6fff: EBI Chip select 2 */ #define SAM_NFCCR_PSECTION 0x7000 /* 0x7000-0x7fff: NFC Command Registers */ /* 0x8000-0xefff: Undefined */ + Review comment: @patacongo Ok, will remove these blank lines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596219 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -157,6 +162,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin) } #endif #ifdef CONFIG_SAMA5_PIOF_IRQ + Review comment: The blank line belongs after line 163, not here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596066 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ostest.c ## @@ -0,0 +1,114 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_ostest.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595974 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_can.c ## @@ -0,0 +1,115 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_can.c + * + * Copyright (C) 2014, 2016 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595871 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -133,6 +135,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin) } #endif #ifdef CONFIG_SAMA5_PIOC_IRQ + Review comment: The blank line belongs after line 136, not here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596015 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -141,6 +144,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin) } #endif #ifdef CONFIG_SAMA5_PIOD_IRQ + Review comment: The blank line belongs after line 145, not here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596094 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -149,6 +153,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin) } #endif #ifdef CONFIG_SAMA5_PIOE_IRQ + Review comment: The blank line belongs after line 154, not here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596036 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_nandflash.c ## @@ -0,0 +1,234 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_nandflash.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Most of this file derives from Atmel sample code for the SAMA5D3-Xplained + * board. That sample code has licensing that is compatible with the NuttX + * modified BSD license: + * + * Copyright (c) 2012, Atmel Corporation + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor Atmel nor the names of its contributors may + *be used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595906 ## File path: boards/arm/sama5/sama5d2-xult/include/board_498mhz.h ## @@ -0,0 +1,217 @@ +/ + * boards/arm/sama5/sama5d2-xult/include/board_498mhz.h + * + * Copyright (C) 2015 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388596011 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_hsmci.c ## @@ -0,0 +1,344 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_hsmci.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595940 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_at25.c ## @@ -0,0 +1,143 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_at25.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: @patacongo Will fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral
support - USB Host working
URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595455
##
File path: arch/arm/src/sama5/sam_pioirq.c
##
@@ -117,6 +117,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin)
if (irq >= SAM_IRQ_NINT)
{
#ifdef CONFIG_SAMA5_PIOA_IRQ
+
Review comment:
There should be no blank line here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595626 ## File path: arch/arm/src/sama5/sam_pioirq.c ## @@ -125,6 +126,7 @@ static int sam_irqbase(int irq, uint32_t *base, int *pin) } #endif #ifdef CONFIG_SAMA5_PIOB_IRQ + Review comment: The blank line belongs after line 127, not here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388595144 ## File path: arch/arm/src/sama5/hardware/_sama5d3x_memorymap.h ## @@ -80,6 +81,7 @@ #define SAM_EBICS3_PSECTION 0x6000 /* 0x6000-0x6fff: EBI Chip select 2 */ #define SAM_NFCCR_PSECTION 0x7000 /* 0x7000-0x7fff: NFC Command Registers */ /* 0x8000-0xefff: Undefined */ + Review comment: These were unnecessary. THIS is an error from nxstyle (and is documented in the Issues). There should be no blank line follow comments to the right such as in this case. It would be better to remove these blank lines. Many other similar cases below. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388594257 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_usbmsc.c ## @@ -0,0 +1,108 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_usbmsc.c + * + * Copyright (C) 2014, 2016 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Configure and register the SAM3U MMC/SD SDIO block driver. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593823 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ostest.c ## @@ -0,0 +1,114 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_ostest.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593973 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_spi.c ## @@ -0,0 +1,194 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_spi.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593896 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_pwm.c ## @@ -0,0 +1,162 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_pwm.c + * + * Copyright (C) 2014-2016 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593555 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_hsmci.c ## @@ -0,0 +1,344 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_hsmci.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593634 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_i2schar.c ## @@ -0,0 +1,126 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_i2schar.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593741 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_nandflash.c ## @@ -0,0 +1,234 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_nandflash.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Most of this file derives from Atmel sample code for the SAMA5D3-Xplained + * board. That sample code has licensing that is compatible with the NuttX + * modified BSD license: + * + * Copyright (c) 2012, Atmel Corporation + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor Atmel nor the names of its contributors may + *be used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388592910 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_at25.c ## @@ -0,0 +1,143 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_at25.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388592952 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_adc.c ## @@ -0,0 +1,101 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_adc.c + * + * Copyright (C) 2014 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593267 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_ethernet.c ## @@ -0,0 +1,343 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_ethernet.c + * + * Copyright (C) 2014, 2017 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388593179 ## File path: boards/arm/sama5/sama5d2-xult/src/sam_can.c ## @@ -0,0 +1,115 @@ +/ + * boards/arm/sama5/sama5d3-xplained/src/sam_can.c + * + * Copyright (C) 2014, 2016 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working
patacongo commented on a change in pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444#discussion_r388592223 ## File path: boards/arm/sama5/sama5d2-xult/include/board_498mhz.h ## @@ -0,0 +1,217 @@ +/ + * boards/arm/sama5/sama5d2-xult/include/board_498mhz.h + * + * Copyright (C) 2015 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in + *the documentation and/or other materials provided with the + *distribution. + * 3. Neither the name NuttX nor the names of its contributors may be + *used to endorse or promote products derived from this software + *without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN + * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + / Review comment: All new files must have an Apache 2.0 license. This cannot come into therepository this way. Copy the header with not copyright or author information from sched/sched/sched_getcpu.c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] adamfeuer opened a new pull request #444: SAMA5D27 peripheral support - USB Host working
adamfeuer opened a new pull request #444: SAMA5D27 peripheral support - USB Host working URL: https://github.com/apache/incubator-nuttx/pull/444 ### Summary * SAMA5D27 USB Host support working * Other peripherals added as a work in progress, but not tested * Minor nxstyle fixes for some SAMA5D3-Xplained files * USB Host fixes and testing by @centurysys (Takeyoshi Kikuchi) * Testing help from @patacongo ### Impact * None if you aren't using the SAMA5D27 * Adds USB Host support work for the SAMA5D27 * Adds support for other peripherals but these haven't been tested. ### Limitations / TODO * Test the other peripherals, especially SPI, I2C, and Ethernet ### Detail * Much code was copied from the SAMA5D3-Xplained board files. Maybe this should eventually be deduplicated? ### Testing * Manual with USB flash driver and USB keyboard ### How To Verify * Configure using the SAMA5D27-XULT defconfig. * Compile and run * Plug in a USB flash drive with some files on it * Do the following in NuttX: ``` NuttShell (NSH) NuttX-8.2 nsh>ls /dev /dev: console null ramlog random sda ttyS0 zero nsh>mkdir /mnt/usb nsh>mount -t vfat /dev/sda /mnt/usb nsh>ls /mnt/usb /mnt/usb: foo.txt bar.txt nsh>cat /mnt/usb/bar.txt 0 1 2 3 4 5 6 7 8 9 Hello, World! ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated (de07abe -> 859d694)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from de07abe ez80f92: Interrupt improvements. add 859d694 z20x: Correct RAM wait states. No new revisions were added by this update. Summary of changes: arch/z80/src/common/up_assert.c | 20 +++- boards/z80/ez80/z20x/scripts/z20x_copytoram.linkcmd | 2 +- boards/z80/ez80/z20x/scripts/z20x_flash.linkcmd | 2 +- boards/z80/ez80/z20x/scripts/z20x_loader.linkcmd| 2 +- boards/z80/ez80/z20x/scripts/z20x_program.linkcmd | 2 +- 5 files changed, 15 insertions(+), 13 deletions(-)
[GitHub] [incubator-nuttx] patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile.
patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile. URL: https://github.com/apache/incubator-nuttx/issues/442#issuecomment-595443228 Another option is to use a 'define POSTBUILD' in tools/Config.mk. That definition would be empty , but could be overriden in any Make.defs file by adding a 'define POSTBUILD'. I do this for the ZDS-II tools which are not very compatible with GNU tools. I add a zds_Config.mk in tools/zds. That .mk file redefines several things in tools/Config.mk and tools/zds/zds_Config.mk is included by all Make.defs that use ZDS-II tools. As a result, the very strange ZDS-II tools work with not impact to other build-related files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch pr443 updated: z20x: Correct RAM wait states.
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch pr443
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/pr443 by this push:
new 859d694 z20x: Correct RAM wait states.
859d694 is described below
commit 859d694c78cd08fe425d09b2d50857ef7da612cb
Author: Gregory Nutt
AuthorDate: Thu Mar 5 14:17:48 2020 -0600
z20x: Correct RAM wait states.
---
arch/z80/src/common/up_assert.c | 20 +++-
boards/z80/ez80/z20x/scripts/z20x_copytoram.linkcmd | 2 +-
boards/z80/ez80/z20x/scripts/z20x_flash.linkcmd | 2 +-
boards/z80/ez80/z20x/scripts/z20x_loader.linkcmd| 2 +-
boards/z80/ez80/z20x/scripts/z20x_program.linkcmd | 2 +-
5 files changed, 15 insertions(+), 13 deletions(-)
diff --git a/arch/z80/src/common/up_assert.c b/arch/z80/src/common/up_assert.c
index 273d186..55a6149 100644
--- a/arch/z80/src/common/up_assert.c
+++ b/arch/z80/src/common/up_assert.c
@@ -88,19 +88,19 @@ static void _up_assert(int errorcode) /* noreturn_function
*/
if (up_interrupt_context() || running_task()->flink == NULL)
{
- up_irq_save();
-for (;;)
- {
+ up_irq_save();
+ for (; ; )
+{
#if CONFIG_BOARD_RESET_ON_ASSERT >= 1
-board_reset(CONFIG_BOARD_ASSERT_RESET_VALUE);
+ board_reset(CONFIG_BOARD_ASSERT_RESET_VALUE);
#endif
#ifdef CONFIG_ARCH_LEDS
-board_autoled_on(LED_PANIC);
-up_mdelay(250);
-board_autoled_off(LED_PANIC);
-up_mdelay(250);
+ board_autoled_on(LED_PANIC);
+ up_mdelay(250);
+ board_autoled_off(LED_PANIC);
+ up_mdelay(250);
#endif
- }
+}
}
else
{
@@ -190,6 +190,8 @@ void up_assert(void)
syslog_flush();
#ifdef CONFIG_BOARD_CRASHDUMP
+ /* Execute board-specific crash dump logic */
+
board_crashdump(Z80_getsp(), running_task(), filename, lineno);
#endif
diff --git a/boards/z80/ez80/z20x/scripts/z20x_copytoram.linkcmd
b/boards/z80/ez80/z20x/scripts/z20x_copytoram.linkcmd
index f7a9d39..630b22c 100644
--- a/boards/z80/ez80/z20x/scripts/z20x_copytoram.linkcmd
+++ b/boards/z80/ez80/z20x/scripts/z20x_copytoram.linkcmd
@@ -52,7 +52,7 @@ DEFINE __crtl = 1
DEFINE __CS0_LBR_INIT_PARAM = $04
DEFINE __CS0_UBR_INIT_PARAM = $0b
-DEFINE __CS0_CTL_INIT_PARAM = $08
+DEFINE __CS0_CTL_INIT_PARAM = $28
DEFINE __CS0_BMC_INIT_PARAM = $00
DEFINE __CS1_LBR_INIT_PARAM = $00
DEFINE __CS1_UBR_INIT_PARAM = $00
diff --git a/boards/z80/ez80/z20x/scripts/z20x_flash.linkcmd
b/boards/z80/ez80/z20x/scripts/z20x_flash.linkcmd
index 0b28dcc..dcb0519 100644
--- a/boards/z80/ez80/z20x/scripts/z20x_flash.linkcmd
+++ b/boards/z80/ez80/z20x/scripts/z20x_flash.linkcmd
@@ -49,7 +49,7 @@ DEFINE __crtl = 1
DEFINE __CS0_LBR_INIT_PARAM = $04
DEFINE __CS0_UBR_INIT_PARAM = $0b
-DEFINE __CS0_CTL_INIT_PARAM = $08
+DEFINE __CS0_CTL_INIT_PARAM = $28
DEFINE __CS0_BMC_INIT_PARAM = $00
DEFINE __CS1_LBR_INIT_PARAM = $00
DEFINE __CS1_UBR_INIT_PARAM = $00
diff --git a/boards/z80/ez80/z20x/scripts/z20x_loader.linkcmd
b/boards/z80/ez80/z20x/scripts/z20x_loader.linkcmd
index 06a0579..a1d2232 100644
--- a/boards/z80/ez80/z20x/scripts/z20x_loader.linkcmd
+++ b/boards/z80/ez80/z20x/scripts/z20x_loader.linkcmd
@@ -56,7 +56,7 @@ DEFINE __progend = $0b
DEFINE __CS0_LBR_INIT_PARAM = $04
DEFINE __CS0_UBR_INIT_PARAM = $0b
-DEFINE __CS0_CTL_INIT_PARAM = $08
+DEFINE __CS0_CTL_INIT_PARAM = $28
DEFINE __CS0_BMC_INIT_PARAM = $00
DEFINE __CS1_LBR_INIT_PARAM = $00
DEFINE __CS1_UBR_INIT_PARAM = $00
diff --git a/boards/z80/ez80/z20x/scripts/z20x_program.linkcmd
b/boards/z80/ez80/z20x/scripts/z20x_program.linkcmd
index 5ee7d03..509cdc5 100644
--- a/boards/z80/ez80/z20x/scripts/z20x_program.linkcmd
+++ b/boards/z80/ez80/z20x/scripts/z20x_program.linkcmd
@@ -59,7 +59,7 @@ DEFINE __progend = $0b
DEFINE __CS0_LBR_INIT_PARAM = $04
DEFINE __CS0_UBR_INIT_PARAM = $0b
-DEFINE __CS0_CTL_INIT_PARAM = $08
+DEFINE __CS0_CTL_INIT_PARAM = $28
DEFINE __CS0_BMC_INIT_PARAM = $00
DEFINE __CS1_LBR_INIT_PARAM = $00
DEFINE __CS1_UBR_INIT_PARAM = $00
[incubator-nuttx] branch pr443 created (now de07abe)
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch pr443 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. at de07abe ez80f92: Interrupt improvements. No new revisions were added by this update.
[GitHub] [incubator-nuttx] acassis merged pull request #443: z20x: Correct RAM wait states.
acassis merged pull request #443: z20x: Correct RAM wait states. URL: https://github.com/apache/incubator-nuttx/pull/443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo opened a new pull request #443: z20x: Correct RAM wait states.
patacongo opened a new pull request #443: z20x: Correct RAM wait states. URL: https://github.com/apache/incubator-nuttx/pull/443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-nuttx] branch master updated: ez80f92: Interrupt improvements.
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new de07abe ez80f92: Interrupt improvements. de07abe is described below commit de07abe63220e9e62ae8fa6c53bafb52681dedae Author: Gregory Nutt AuthorDate: Wed Mar 4 15:02:51 2020 -0600 ez80f92: Interrupt improvements. arch/z80/: include/ez80/irq.h, src/ez80/ez80f92_*.asm: Correct some comments related to vector address offsets. boards/z80/ez80/z20x/scripts/z20x_loader.linkcmd: Fix RAM offset in linker script --- arch/z80/include/ez80/irq.h | 89 +++ arch/z80/src/ez80/ez80f92_handlers.asm| 130 ++--- arch/z80/src/ez80/ez80f92_loader.asm | 132 +++--- arch/z80/src/ez80/ez80f92_program.asm | 128 ++--- boards/z80/ez80/z20x/scripts/z20x_loader.linkcmd | 2 +- boards/z80/ez80/z20x/scripts/z20x_program.linkcmd | 8 +- 6 files changed, 245 insertions(+), 244 deletions(-) diff --git a/arch/z80/include/ez80/irq.h b/arch/z80/include/ez80/irq.h index 80553a0..d1ebb0e 100644 --- a/arch/z80/include/ez80/irq.h +++ b/arch/z80/include/ez80/irq.h @@ -112,50 +112,51 @@ # define NR_IRQS(46) #elif defined(CONFIG_ARCH_CHIP_EZ80F92) || defined(CONFIG_ARCH_CHIP_EZ80F93) -# /* Vectors 0x40-0x4c unused */ -# define EZ80_FLASH_IRQ (0) /* Vector 0x50 */ - -# define EZ80_TIMER0_IRQ (1) /* Vector 0x54 */ -# define EZ80_TIMER1_IRQ (2) /* Vector 0x58 */ -# define EZ80_TIMER2_IRQ (3) /* Vector 0x5c */ -# define EZ80_TIMER3_IRQ (4) /* Vector 0x60 */ -# define EZ80_TIMER4_IRQ (5) /* Vector 0x64 */ -# define EZ80_TIMER5_IRQ (6) /* Vector 0x68 */ - -# define EZ80_RTC_IRQ(7) /* Vector 0x6C */ -# define EZ80_UART0_IRQ (8) /* Vector 0x70 */ -# define EZ80_UART1_IRQ (9) /* Vector 0x74 */ - -# define EZ80_I2C_IRQ (10) /* Vector 0x78 */ -# define EZ80_SPI_IRQ (11) /* Vector 0x7c */ -# /* Vectors 0x80-0x9c unused */ - -# define EZ80_PORTB0_IRQ(12) /* Vector 0xa0 */ -# define EZ80_PORTB1_IRQ(13) /* Vector 0xa4 */ -# define EZ80_PORTB2_IRQ(14) /* Vector 0xa8 */ -# define EZ80_PORTB3_IRQ(15) /* Vector 0xac */ -# define EZ80_PORTB4_IRQ(16) /* Vector 0xb0 */ -# define EZ80_PORTB5_IRQ(17) /* Vector 0xb4 */ -# define EZ80_PORTB6_IRQ(18) /* Vector 0xb8 */ -# define EZ80_PORTB7_IRQ(19) /* Vector 0xbc */ - -# define EZ80_PORTC0_IRQ(20) /* Vector 0xc0 */ -# define EZ80_PORTC1_IRQ(21) /* Vector 0xc4 */ -# define EZ80_PORTC2_IRQ(22) /* Vector 0xc8 */ -# define EZ80_PORTC3_IRQ(23) /* Vector 0xcc */ -# define EZ80_PORTC4_IRQ(24) /* Vector 0xd0 */ -# define EZ80_PORTC5_IRQ(25) /* Vector 0xd4 */ -# define EZ80_PORTC6_IRQ(26) /* Vector 0xd8 */ -# define EZ80_PORTC7_IRQ(27) /* Vector 0xdc */ - -# define EZ80_PORTD0_IRQ(28) /* Vector 0xe0 */ -# define EZ80_PORTD1_IRQ(29) /* Vector 0xe4 */ -# define EZ80_PORTD2_IRQ(30) /* Vector 0xe8 */ -# define EZ80_PORTD3_IRQ(31) /* Vector 0xec */ -# define EZ80_PORTD4_IRQ(32) /* Vector 0xf0 */ -# define EZ80_PORTD5_IRQ(33) /* Vector 0xf4 */ -# define EZ80_PORTD6_IRQ(34) /* Vector 0xf8 */ -# define EZ80_PORTD7_IRQ(35) /* Vector 0xfc */ +# /* Vectors 0x00-0x06 unused */ +# define EZ80_FLASH_IRQ (0) /* Vector 0x08 */ + +# define EZ80_TIMER0_IRQ (1) /* Vector 0x0a */ +# define EZ80_TIMER1_IRQ (2) /* Vector 0x0c */ +# define EZ80_TIMER2_IRQ (3) /* Vector 0x0e */ +# define EZ80_TIMER3_IRQ (4) /* Vector 0x10 */ +# define EZ80_TIMER4_IRQ (5) /* Vector 0x12 */ +# define EZ80_TIMER5_IRQ (6) /* Vector 0x14 */ + +# define EZ80_RTC_IRQ(7) /* Vector 0x16 */ +# define EZ80_UART0_IRQ (8) /* Vector 0x18 */ +# define EZ80_UART1_IRQ (9) /* Vector 0x1a */ + +# define EZ80_I2C_IRQ (10) /* Vector 0x1c */ +# define EZ80_SPI_IRQ (11) /* Vector 0x1e */ +# /* Vectors 0x20-0x2e unused */ + +# define EZ80_PORTB0_IRQ(12) /* Vector 0x30 */ +# define EZ80_PORTB1_IRQ(13) /* Vector 0x32 */ +# define EZ80_PORTB2_IRQ(14) /* Vector 0x34 */ +# define EZ80_PORTB3_IRQ(15) /* Vector 0x36 */ +# define EZ80_PORTB4_IRQ(16) /* Vector 0x38 */ +# define EZ80_PORTB5_IRQ(17) /* Vector 0x3a */ +# define EZ80_PORTB6_IRQ(18) /* Vector 0x3c */ +# define EZ80_PORTB7_IRQ(19) /* Vector 0x3e */ + +# define EZ80_PORTC0_IRQ(20) /* Vector 0x40 */ +# define EZ80_PORTC1_IRQ(21) /* Vector 0x42 */ +# define EZ80_PORTC2_IRQ(22) /* Vector 0x44 */ +# define EZ80_PORTC3_IRQ(23) /* Vector 0x46 */ +# define EZ80_PORTC4_IRQ(24) /*
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile.
xiaoxiang781216 commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile. URL: https://github.com/apache/incubator-nuttx/issues/442#issuecomment-595338429 > See related #437 > > I am thinking that a more systematic solution is needed both for CXD56xx and ESP32 and for any future platforms that require custom binary generation after the final linking step. I am thinking that perhaps we should support some Makefiles and tools in directories under tools/. Then perhaps we could do a wildcard check for: > > ``` > (TOPDIR)/tools/$(CONFIG_ARCH)/Makefile > ``` Can we reuse the existing Makefile? For example: arch\arm\src\cxd56xx\Make.defs to invoke chipset specific tool arch\xtensa\src\Makefile to invoke arch specific tool boards\arm\cxd56xx\spresense\scripts\Make.defs to invoke board specific tool We just invoke some common target(e.g. postbuild) in the last step, then the above makefile could provide the hook as needed. > > And if it exists, then run it. So in this case, it would check for tools/cxd56xx/Makefile and would executre tools/cxd56xx/Makefile to generate the binary using the changes currently in tools/Makefile.unix > > This would serve the needs of all architectures, existing and future. But tools has the flat directory structure, it's better to put the special tools or script to boards/arch directory: 1.boards/arm//tools for board specific tool 2.arch/arm//tools for chipset specific tool 3.arch/arm/armv7-a/tools for arch specific tool This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] maht commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU
maht commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388424886 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp -f uImage /tftpboot/uImage; \ fi endif +ifeq ($(CONFIG_ESP32_BINARY),y) + @echo "MKIMAGE: ESP32 binary" + $(Q) if ! esptool.py version | grep "v2[.]"; then \ + echo ""; \ + echo "Please install ESP-IDF tools"; \ + echo ""; \ + echo "Check https://docs.espressif.com/projects/esp-idf/en/v4.0/get-started/index.html#installation-step-by-step or run the following command"; \ + echo ""; \ + echo "cd tools/esp32 && make && cd ../.."; \ + echo ""; \ + echo "run make again to create the nuttx.bin image."; \ +else \ + echo "Generating: $(NUTTXNAME).bin (ESP32 compatible)"; \ + esptool.py --chip esp32 elf2image --flash_mode dio --flash_size 4MB -o nuttx.bin nuttx && \ + echo "Generated: $(NUTTXNAME).bin (ESP32 compatible)"; \ + fi +endif Review comment: Ok, then try to move the other examples of bad practice of this case or at least leave a message in the code if the efforts spans more than a week or so. I think once there is no "bad example" on place, it would be easier to anyone to point out what is accepted and what is not, so the human review effort would be less, hopefully. And by the way, from my part, thanks for being so strict :) It pays off on the long term. I will try to port some of the other cases if I have some time or contribute as needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU
patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388419906 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp -f uImage /tftpboot/uImage; \ fi endif +ifeq ($(CONFIG_ESP32_BINARY),y) + @echo "MKIMAGE: ESP32 binary" + $(Q) if ! esptool.py version | grep "v2[.]"; then \ + echo ""; \ + echo "Please install ESP-IDF tools"; \ + echo ""; \ + echo "Check https://docs.espressif.com/projects/esp-idf/en/v4.0/get-started/index.html#installation-step-by-step or run the following command"; \ + echo ""; \ + echo "cd tools/esp32 && make && cd ../.."; \ + echo ""; \ + echo "run make again to create the nuttx.bin image."; \ +else \ + echo "Generating: $(NUTTXNAME).bin (ESP32 compatible)"; \ + esptool.py --chip esp32 elf2image --flash_mode dio --flash_size 4MB -o nuttx.bin nuttx && \ + echo "Generated: $(NUTTXNAME).bin (ESP32 compatible)"; \ + fi +endif Review comment: > Sorry to hear that, I don't wanted to cause trouble. But in my defense, if something is not good in the first place, it generates a dilemma on new additions: should we care more about consistency with existing practices (even bad ones) or should we do the correct one despite that will create inconsistencies. Yes, that is exactly the dilemma. If one bad example is permitted into the architecture, then it provides a precedent and justification for perpetuating that bad example. The only solution is to be more diligent in reviewing changes in the first place. But that is not humanly possible, at least not with the people involved now. Bad things will slip in unnoticed and once they have slipped in, then the problems really begin. I don't have a good solution to that. But we also can't allow one bad implementation to justify its propagation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU
patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388419906 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp -f uImage /tftpboot/uImage; \ fi endif +ifeq ($(CONFIG_ESP32_BINARY),y) + @echo "MKIMAGE: ESP32 binary" + $(Q) if ! esptool.py version | grep "v2[.]"; then \ + echo ""; \ + echo "Please install ESP-IDF tools"; \ + echo ""; \ + echo "Check https://docs.espressif.com/projects/esp-idf/en/v4.0/get-started/index.html#installation-step-by-step or run the following command"; \ + echo ""; \ + echo "cd tools/esp32 && make && cd ../.."; \ + echo ""; \ + echo "run make again to create the nuttx.bin image."; \ +else \ + echo "Generating: $(NUTTXNAME).bin (ESP32 compatible)"; \ + esptool.py --chip esp32 elf2image --flash_mode dio --flash_size 4MB -o nuttx.bin nuttx && \ + echo "Generated: $(NUTTXNAME).bin (ESP32 compatible)"; \ + fi +endif Review comment: > Sorry to hear that, I don't wanted to cause trouble. But in my defense, if something is not good in the first place, it generates a dilemma on new additions: should we care more about consistency with existing practices (even bad ones) or should we do the correct one despite that will create inconsistencies. Yes, that is exactly the dilemma. If one bad example is permitted into the architecture, then it provides a precedent and justification for perpetuating the bad example. The only solution is to be more diligent in review changes in the first place. But that is not humanly possible, at least not with the people involved now. Bad things will slip in unnoticed and one they have slipped in, then the problems begin. I don't have a good solution to that. But we also can't allow one bad implementation to justify its propagation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] igrr commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU
igrr commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388416984 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp -f uImage /tftpboot/uImage; \ fi endif +ifeq ($(CONFIG_ESP32_BINARY),y) + @echo "MKIMAGE: ESP32 binary" + $(Q) if ! esptool.py version | grep "v2[.]"; then \ Review comment: Loading an ELF file directly should be possible, provided that the ELF file includes the necessary CPU startup code and exception vectors. This doesn't happen when you build an ESP-IDF application — currently it always relies on the ROM code to provide the startup code and the exception vectors. However i think that NuttX includes such an option: https://github.com/apache/incubator-nuttx/blob/119a38ce10d8be96b8373b5a19145eda231edd93/boards/xtensa/esp32/esp32-core/README.txt#L491-L499 (i haven't tried it myself). The document mentioned loading the code using OpenOCD, but same logic applies to loading the code over GDB (using the qemu built-in GDB server). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile.
patacongo commented on issue #442: tools/Makefile.unix: Remove FORBIDDEN CXD56 code in common Makefile. URL: https://github.com/apache/incubator-nuttx/issues/442#issuecomment-595325922 See related #437 I am thinking that a more systematic solution is needed both for CXD56xx and ESP32 and for any future platforms that require custom binary generation after the final linking step. I am thinking that perhaps we should support some Makefiles and tools in directories under tools/. Then perhaps we could do a wildcard check for: (TOPDIR)/tools/$(CONFIG_ARCH)/Makefile And if it exists, then run it. So in this case, it would check for tools/cxd56xx/Makefile and would executre tools/cxd56xx/Makefile to generate the binary using the changes currently in tools/Makefile.unix This would serve the needs of all architectures, existing and future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] igrr commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU
igrr commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388416984 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp -f uImage /tftpboot/uImage; \ fi endif +ifeq ($(CONFIG_ESP32_BINARY),y) + @echo "MKIMAGE: ESP32 binary" + $(Q) if ! esptool.py version | grep "v2[.]"; then \ Review comment: Loading an ELF file directly should be possible, provided that the ELF file includes the necessary CPU startup code and exception vectors. This doesn't happen when you build an ESP-IDF application — currently it always relies on the ROM code to provide the startup code and the exception vectors. However i think that NuttX includes such an option: https://github.com/apache/incubator-nuttx/blob/119a38ce10d8be96b8373b5a19145eda231edd93/boards/xtensa/esp32/esp32-core/README.txt#L491-L499 (i haven't tried it myself). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU
patacongo commented on a change in pull request #437: Support to run NuttX on ESP32 QEMU URL: https://github.com/apache/incubator-nuttx/pull/437#discussion_r388415277 ## File path: tools/Makefile.unix ## @@ -501,6 +501,23 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y) cp -f uImage /tftpboot/uImage; \ fi endif +ifeq ($(CONFIG_ESP32_BINARY),y) + @echo "MKIMAGE: ESP32 binary" + $(Q) if ! esptool.py version | grep "v2[.]"; then \ Review comment: I am thinking that a more systematic solution is needed both for CXD56xx and ESP32 and for any future platforms that require custom binary generation after the final linking step. I have started some more general discussion in #442 I am thinking that perhaps we should support some Makefiles and tools in directories under tools/. Then perhaps we could do a wildcard check for: (TOPDIR)/tools/$(CONFIG_ARCH)/Makefile And if it exists, then run it. So in this case, it would check for tools/esp32/Makefile and would execture tools/esp32/Makefile to generate the binary using the changes in this PR. This is more effort, but would serve the needs of all architectures, existing and future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
