[GitHub] [incubator-nuttx] iceaway opened a new pull request #535: nxstyle fixes for a couple drivers

[GitBox]

iceaway opened a new pull request #535: nxstyle fixes for a couple drivers
URL: https://github.com/apache/incubator-nuttx/pull/535
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 edited a comment on issue #528: sched/mqueue:  Correct/update 
license headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597454131
 
 
   > Re "Change the file owned by Greg to Apache license" this should only be 
done if the IP provenance of every line of code is 100% known and the file 
include no code from outside of NuttX.
   > 
   
   We need a concrete guidline here, is it enough that the tool check:
   1.Greg is the copyright owner of files from fossology
   2.The file is BSD license now from fossology
   3.Greg is the first committer from git log
   4.Greg review and  approve PR carefully 
   If not, please append more steps to the list, then we can go through the 
check list one by one.
   
   > Re "NuttX can graduate to the apache top level project by just changing 
Greg's copyright." the answer would be no, as the code base must undergo an IP 
review and get IP clearance. The process of looking at each file and changing 
the headers is part of this. Additional software grants may also help this, and 
reviews of releases will help this. The ASF need confidences that anyone can 
use this code under the Apache license and that there are no unexpected dangers.
   
   As you said, NuttX don't need change other(Xiaomi/Sony/..)'s copyright and 
just need list this known issue in related document. My question is that what 
should we do after we resolve the copyright from Greg.
   Who(or which team) is responsible to do the review and summary what need to 
modify for IP clearance? How we start the process?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597454131
 
 
   > Re "Change the file owned by Greg to Apache license" this should only be 
done if the IP provenance of every line of code is 100% known and the file 
include no code from outside of NuttX.
   > 
   
   We need a concrete guidline here, is it enough that the tool check:
   1.Greg is the copyright owner of files from fossology
   2.The file is BSD license now from fossology
   3.Greg is the first committer from git log
   4.Greg review and  approve PR carefully 
   If not, please append more steps to the list, then we can go through the 
check list one by one.
   
   > Re "NuttX can graduate to the apache top level project by just changing 
Greg's copyright." the answer would be no, as the code base must undergo an IP 
review and get IP clearance. The process of looking at each file and changing 
the headers is part of this. Additional software grants may also help this, and 
reviews of releases will help this. The ASF need confidences that anyone can 
use this code under the Apache license and that there are no unexpected dangers.
   
   As you said, NuttX don't need change other(Xiaomi/Sony/..)'s copyright and 
just need list this known issue in related document. My question is that what 
should we do after we resolve the copyright from Greg.
   
   Who(or which team) is responsible to do the review and summary what need to 
modify for IP clearance? How we start the process?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

adamfeuer commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597449325
 
 
   @justinmclean My idea for using the tool would be to use a report from 
fossology to generate a list of files, then run the tool on them to create PR. 
The PR could be examined carefully before being merged.
   
   Perhaps we could also go in small groups of files so the review isn't so 
long.
   
   Of course I'll wait until we have a plan. In the meantime I am willing to 
work with @btashton on his fossology instance.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

adamfeuer commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597448884
 
 
   @patacongo I won't run the tool or create any PRs changing license headers 
until we think it's the right thing to do.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] yamt opened a new pull request #534: include/nuttx/compiler.h: Appease nxstyle errors

[GitBox]

yamt opened a new pull request #534: include/nuttx/compiler.h: Appease nxstyle 
errors
URL: https://github.com/apache/incubator-nuttx/pull/534
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] masayuki2009 commented on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh

[GitBox]

masayuki2009 commented on issue #502: tools: Add workaround not to build in 
parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-597442522
 
 
   > Hi, @xiaoxiang781216
   > 
   > I might find the root cause. Now I'm repeating parallel build aging test 
with -j1 to -j24 options.
   > And it seems to be stable now. So I'll send a new PR later.
   
   https://github.com/apache/incubator-nuttx-apps/pull/118
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean edited a comment on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean edited a comment on issue #528: sched/mqueue:  Correct/update 
license headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597441219
 
 
   Re "Change the file owned by Greg to Apache license" this should only be 
done if the IP provenance of every line of code is 100% known and the file 
include no code from outside of NuttX.
   
   Re "NuttX can graduate to the apache top level project by just changing 
Greg's copyright." the answer would be no, as the code base must undergo an IP 
review and get IP clearance. The process of looking at each file and changing 
the headers is part of this. Additional software grants may also help this, and 
reviews of releases will help this. The ASF need confidences that anyone can 
use this code under the Apache license and that there are no unexpected dangers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597441219
 
 
   Re "Change the file owned by Greg to Apache license" this should only be 
done if the IP provenance of every line of code is 100% known and the file 
include no code from outside of NuttX.
   
   Re "NuttX can graduate to the apache top level project by just changing 
Greg's copyright." the answer would be no, as the code base must undergo an IP 
review and get IP clearance. The process of looking at each file and changing 
the headers is part of this. Additional software grants may also help this, and 
reviews of releases will help this. The ASF need confidences that anyone can 
use this code under the Apache license and that there are unexpected dangers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] yamt opened a new pull request #533: Appease many of nxstyle errors for esp32 related files

[GitBox]

yamt opened a new pull request #533: Appease many of nxstyle errors for esp32 
related files
URL: https://github.com/apache/incubator-nuttx/pull/533
 
 
   The remaining errors are:
   
   * "Mixed case identifier found" for rom symbols.
 I don't think it's appropriate to "fix" them.
   
   * "Operator/assignment must be preceded with whitespace" for assembly.
 nxstyle doesn't understand assembly.
   
   I skipped the following files and directories because
   they looked too huge and/or foreign.
   
   arch/xtensa/include/esp32/tie.h
   arch/xtensa/include/xtensa/xtensa_corebits.h
   arch/xtensa/src/esp32/hardware/
   arch/xtensa/include/esp32/tie-asm.h
   arch/xtensa/include/xtensa/core.h


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #118: Fix parallel buid errors in examples/elf

[GitBox]

masayuki2009 opened a new pull request #118: Fix parallel buid errors in 
examples/elf
URL: https://github.com/apache/incubator-nuttx-apps/pull/118
 
 
   ### Summary
   
   - This PR fixes build errors in examples/elf in parallel build.
   - I applied the same logic in examples/posix_spawn/Makefile which adds an 
explicit context:: target.
   - Also, I modified tests/Makefile to avoid compiling incomplete symtab.c
   
   ### Impact
   
   - This PR affects examples/elf only.
   
   ### Testing
   
   - I tested this PR for maix-bit:elf configuration with -j1 to -j24 options.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597433998
 
 
   > @patacongo @xiaoxiang781216 @btashton @justinmclean I updated the 
[licenseheaders](https://github.com/adamfeuer/licenseheaders/tree/feature/nuttx-apache-2)
 tool to preserve the block comment length, preserve the filename, and preserve 
any description if there is any. It will also format the filename with the 
correct number of spaces at the beginning... currently not all files have the 
same formatting.
   > 
   > It also can take a list of files or a single file on the command line.
   > 
   > So once we have a list of files, we can run the tool, look at the diffs, 
and commit/create a PR if we want to. The code is pushed to the branch I linked 
above... I'm willing to run the tool if we can get list of files to run it on.
   > 
   
   To avoid the mistake, it's better to get the list owned by Greg from 
fossology like @justinmclean 's suggestion. Since the current report is little 
bit old, it's better to get admin account from @btashton and rerun fossology 
again.
   
   > I'm also willing to fix the tool if it doesn't generate the right output.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597433124
 
 
   > Hi,
   > We already run fossology and generate the report: 
https://fossology.brennanashton.com/repo/ 
 I also take one day to read it's 
document, but I can't find the tutorial to modify the license in batch.
   > Fossology can detect the licenses, you can update headers in groups, you 
could also use it to general a list of file to change and use your script to 
change those. Using it will make your life a lot easier. It also mean people 
can review and see any mistakes. It not only a tool for generating reports and 
it can work on a changing code base.
   
   Could you point me a link which describe the header updating process from 
fossology web ui?
   
   > Can we pass the apache license criteria just by just changing Greg's 
copyright?
   > I’m not sure what you mean by license criteria.
   
   I mean NuttX can graduate to the apache top level project by just changing 
Greg's copyright.
   
   > There is the ASF header and copyright policy [1]. For files developed at 
the ASF or donated as part of a grant the header must change to be the ASF one. 
[2] For all other files the ASF headers MUST remain unchanged. [3]. We only 
have a grant from Gregory so should not be changing headers on any files that 
are copyright other people or companies. Does that make it clearer?
   
   That's why I suggest that we just modify the files owner by Greg first, I 
don't see any reason we can't do this now. Yes, we need take care, but we also 
need make a progress.
   
   > If at the ASF (and not previously) you make major modifications to a 3rd 
party file you might consider changing the header, the PPMC would need to 
discuss this on a case by case basis. Given the code has just arrived at the 
ASFI guess it's unlikely that there are any files that meet that criteria. So 
this is how I would treat files: - All files that are copyright Gregory and 
have been entirely developed in the NuttX project should be changed to use the 
Apache header - Any files with a copyright other than Gregory’s should stay as 
it is - Files that that are copyright Gregory but includes any code from 
outside the NuttX project or code that has an unclear provenance the headers 
should remain as they are. In some cases the history of the file may need to be 
looked at. Hopefully there's only a few cases of this and hopefully Gregory can 
identify those files. - Any new files created since teh project has come to the 
ASF needs to use the ASF header Thanks, Justin 1. 
https://www.apache.org/legal/src-headers.html 2. 
https://www.apache.org/legal/src-headers.html#headers 3. 
https://www.apache.org/legal/src-headers.html#3party
   
   Let's summary my understand:
   1.Change the file owned by Greg to Apache license
   2.Ensure all new file declared with Apache license
   3.Review license in the rest files if the patch make a significant change
   Does we follow the above requirement? IMPC don't block NuttX leaving 
incubation due to license issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

adamfeuer commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597430279
 
 
   @patacongo @xiaoxiang781216 @btashton @justinmclean I updated the 
[licenseheaders](https://github.com/adamfeuer/licenseheaders/tree/feature/nuttx-apache-2)
 tool to preserve the block comment length, preserve the filename, and preserve 
any description if there is any. It will also format the filename with the 
correct number of spaces at the beginning... currently not all files have the 
same formatting.
   
   It also can take a list of files or a single file on the command line. 
   
   So once we have a list of files, we can run the tool, look at the diffs, and 
commit/create a PR if we want to. The code is pushed to the branch I linked 
above... I'm willing to run the tool if we can get list of files to run it on.
   
   I'm also willing to fix the tool if it doesn't generate the right output. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] masayuki2009 commented on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh

[GitBox]

masayuki2009 commented on issue #502: tools: Add workaround not to build in 
parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-597429046
 
 
   Hi, @xiaoxiang781216 
   
   I might find the root cause. Now I'm repeating parallel build aging test 
with -j1 to -j24 options.
   And it seems to be stable now. So I'll send a new PR later.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597428166
 
 
   I'd like an account please


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] btashton commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

btashton commented on issue #528: sched/mqueue:  Correct/update license headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597427397
 
 
   > Hi,
   > We already run fossology and generate the report: 
https://fossology.brennanashton.com/repo/ 
 I also take one day to read it's 
document, but I can't find the tutorial to modify the license in batch.
   > Fossology can detect the licenses, you can update headers in groups, you 
could also use it to general a list of file to change and use your script to 
change those. Using it will make your life a lot easier. It also mean people 
can review and see any mistakes. It not only a tool for generating reports and 
it can work on a changing code base.
   
   Exactly.  I just re-imported everything, and also gave Adam an account since 
he asked.  I'll work on getting a Wiki page put together on the workflow that I 
am using, and I can try to take a stab at generating a first list of files that 
are high confidence.  If anyone else wants an account please shoot me a message 
and I will create one for you.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597426579
 
 
   Hi,
   > We already run fossology and generate the report:
   > https://fossology.brennanashton.com/repo/ 

   > I also take one day to read it's document, but I can't find the tutorial 
to modify the license in batch.
   > 
   Fossology can detect the licenses, you can update headers in groups, you 
could also use it to general a list of file to change and use your script to 
change those. Using it will make your life a lot easier. It also mean people 
can review and see any mistakes. It not only a tool for generating reports and 
it can work on a changing code base.
   
   > Can we pass the apache license criteria just by just changing Greg's 
copyright?
   > 
   
   I’m not sure what you mean by license criteria. There is the ASF header and 
copyright policy [1]. For files developed at the ASF or donated as part of a 
grant the header must change to be the ASF one. [2] For all other files the ASF 
headers MUST remain unchanged. [3].  We only have a grant from Gregory so 
should not be changing headers on any files that are copyright other people or 
companies. Does that make it clearer?
   
   If at the ASF (and not previously) you make major modifications to a 3rd 
party file you might consider changing the header, the PPMC would need to 
discuss this on a case by case basis. Given the code has just arrived at the 
ASFI guess it's unlikely that there are any files that meet that criteria.
   
   So this is how I would treat files:
   - All files that are copyright Gregory and have been entirely developed in 
the NuttX project should be changed to use the Apache header
   - Any files with a copyright other than Gregory’s should stay as it is
   - Files that that are copyright Gregory but includes any code from outside 
the NuttX project or code that has an unclear provenance  the headers should 
remain as they are. In some cases the history of the file may need to be looked 
at. Hopefully there's only a few cases of this and hopefully Gregory can 
identify those files.
   - Any new files created since teh project has come to the ASF needs to use 
the ASF header
   
   Thanks,
   Justin
   
   1. https://www.apache.org/legal/src-headers.html
   2. https://www.apache.org/legal/src-headers.html#headers
   3. https://www.apache.org/legal/src-headers.html#3party


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597420150
 
 
   > Hi, I well aware of the number of copyright holders, and I had pointed 
this out before you entered incubation this would be an issue. This is why I 
suggested using fossology (several times now) and that has been set to deal 
with this. I really don't understand why people are not using it.
   
   We already run fossology and generate the report:
   https://fossology.brennanashton.com/repo/
   I also take one day to read it's document, but I can't find the tutorial to 
modify the license in batch. That is why ask you give us a workable instruction 
step by step, no volunteer want update more than 1 one by one. 
   
   > If you want the headers of files from Xiaomi changed then Xiaomi will need 
to submit a software grant, that is ASF policy. But a SGA is not required if 
you don’t change the headers. But we don't have to change the headers if we 
don’t want to. I’m not understanding the need to change all file headers other 
than the files copyright Gregory Nutt. Thanks, Justin
   
   Can we pass the apache license criteria just by just changing Greg's 
copyright? If so, we also don't want to do this boring thing too.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597417397
 
 
   Hi,
   
   >  We need SGA's from Xiaomi an Sony. 
   
   There are not required. They are only required if you want to change the 
existing headers. There is nothing stopping you from leaving the headers as 
they are fro any file from Xiaomi or Sony and making a release.
   
   Thanks,
   Justin


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597416981
 
 
   Hi,
   
   I well aware of the number of copyright holders, and I had pointed this out 
before you entered incubation this would be an issue. This is why I suggested 
using fossology (several times now) and that has  been set to deal with this. I 
really don't understand why people are not using it.
   
   If you want the headers of files from Xiaomi changed then Xiaomi will need 
to submit a software grant, that is ASF policy. But a SGA is not required if 
you don’t change the headers.
   
   But we don't have to change the headers if we don’t want to. I’m not 
understanding the need to change all file headers other than the files 
copyright Gregory Nutt.
   
   Thanks,
   Justin
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] btashton commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

btashton commented on issue #528: sched/mqueue:  Correct/update license headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597416213
 
 
   With Fossology it is fairly straightforward to identify the license headers 
that are solely Greg's (there are some with multiple) and then work on 
replacing these. The tool also has a way to fairly quickly move between 
license/copyright header to do an additional manual check with the highlighting 
of what the tool identified.
   
   Doing it with a tool like this at least adds some additional confidence at 
least in my book. You can also mark files as reviewed so it is easier to track 
the progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597415968
 
 
   @adamfeuer 
   
   > Thanks for the explanation. I altered the script to take a list of files 
that we can carefully pick, as per patacongo's recommendation. I'll push the 
changes soon so people can see them. Just testing it now.
   
   Let's hold off modifying anything until we have a clearer picture of things. 
 We need SGA's from Xiaomi an Sony.  Let's not get ahead of ourselves.  Please 
don't make any changes for a little while.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597414122
 
 
   > HI,
   > @xiaoxiang781216  If what Justin says 
is the case, then you will need to start discussion as soon as posible with 
ZiAng Zhuang to come to a legal resolution with Xiaomi.
   > I’m not aware of the details here, if you could share (privately if need 
be) then that would be appreciated. A simple option is to keep the original 
headers while this is being sorted out, the code is under an open source 
license so we can use it according to those terms. Thanks, Justin
   
   @justinmclean Sure, I will let Xiaomi lawyer involve the license discussion. 
But, I need say that the whole code base is very large(nuttx: 18090, apps: 
4829), it isn't possible to do all license conversion in one patch or change 
the license manually file by file. It is also possible to modify the wrong file 
even we do the change manually, because people always make mistakes.
   Here is the draft report gatherd by Greg:
   ```
   nuttx/ apps/ TOTAL
   Total Number of (regular) file: 13792  2961  16753
   Total Number of files with Copyrights:  10918  1931  12849  [1]
   Total Number of Copyrights: 12107  2234  14341  [2]
   Copyright holders:
 Gregory Nutt (or Greg Nutt)11314  [3,4,9]
 Sony 444  [5]
 Antony Dzeryn (Woopsi app)   119
 Sebastien Lorquet111
 Haltian Ltd. 109
 Ken Pettit   122  [8]
 Pinecone 105  [6]
 Omni Hoverboards Inc.102
 Alan Carvalho de Assis   100  [3]
 Pierre-Noel Bouteville92
 Nick Johnson (floating point library) 85
 Atmel Corporation 79
 Verge Inc.77  [3,7]
 Uros Platise  75
 Texas Instruments Incorporated71
 Adam Dunkels  65
 Petro Karashchenko51
 Zilogic Systems   39
 Masayuki Ishikawa 38  [3]
 STMicroelectronics38
 NXP Semiconductors, Inc.  35
 Max Holtzberg 34
 Silicon Laboratories, Inc. (Silicon Labs, Inc.)   31
 Michael Haardt30
 Christian Walter (2006)   30
 Intel Corporation 27
 Future Technology Devices International   27
 Freescale Semiconductor, Inc. 26
 ARM Limited   26
 Rommel Marcelo (2010) 25
 Michał Łyszczek   25
 Bill Gatliff  23
 Abdelatif Guettouche  20  [3]
 Li Zhuoyi 20
 Motorola Mobility, LLC19
 Citrus Project (1999) 19
 NX Engineering, S.A.  18  [3,9]
 Vladimir Komendantskiy17
 DS-Automotion GmbH16
 Cadence Design Systems Inc.   15
 B.ZaaR15
 Espressif Systems (Shanghai) PTE LTD  14
 Brennan Ashton14  [8]
 Swedish Institute of Computer Science 18
 The Open Group18
 Gwenhael Goavec-Merou 13
 Evans & Sutherland Computer Corporation   13
 Marawan Ragab 13
 Max Nekludov  13
 Marco Krahl   12
 (no name on copyright line)   12
 CITEL Technologies Ltd. (2002)11
 RAF Research  11
 Extent3D  10
 Peter Andersson   10
 Giorgio Groß  10
 Xiaomi   

[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

adamfeuer commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597404312
 
 
   @justinmclean Thanks for the explanation. I altered the script to take a 
list of files that we can carefully pick, as per @patacongo's recommendation. 
I'll push the changes soon so people can see them. Just testing it now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597403459
 
 
   Hi,
   > But then they could if they did have such permission. Ziang Zhuang would 
still be the person to discuss with (Xiaomi attorney).
   > 
   The ASF would still require a software grant for the headers to be removed.
   
   Thanks,
   Justin


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597402327
 
 
   HI,
   > @xiaoxiang781216  If what Justin says 
is the case, then you will need to start discussion as soon as posible with 
ZiAng Zhuang to come to a legal resolution with Xiaomi.
   > 
   I’m not aware of the details here, if you could share (privately if need be) 
then that would be appreciated. A simple option is to keep the original headers 
while this is being sorted out, the code is under an open source license so we 
can use it according to those terms.
   
   Thanks,
   Justin
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597401902
 
 
   > They may not have permission to change it and the copyright may not 
actually be theirs but the company they work for.
   
   But then they could if they did have such permission. Ziang Zhuang would 
still be the person to discuss with (Xiaomi attorney).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597401156
 
 
   @xiaoxiang781216 If what Justin says is the case, then you will need to 
start discussion as soon as posible with ZiAng Zhuang to come to a legal 
resolution with Xiaomi.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597401092
 
 
   Hi,
   > @justinmclean  Since this is not third 
party code, the current author and claimed copyright hold could simpley change 
the copyright to me correct? People do that all the time. Then any questions 
would be gone.
   > 
   
   They may not have permission to change it and the copyright may not actually 
be theirs but the company they work for. It may depend on their employment 
contract or teh country they work in. It can be complex.
   
   I would start with the low hanging fruit first - identify all files where 
you are the sole owner, that didn’t originally come from another project or had 
any code copy and pasted from elsewhere. i.e. files you are 100% clear that you 
know the provenance of every single line of code and change the headers on 
those. This is probably going tp be the majority off the files but not all of 
them.
   
   Thanks,
   Justin


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597399893
 
 
   Hi,
   
   > What's the difference between using a script to do the edits and doing it
   > manually in a text editor? It seems to me that once you have selected the
   > files to change, there's no difference. Am I missing something?
   
   The script look it it just going to do a bulk replace based on contents of 
existing headers - that may make mistakes. We really need to know the history 
of each file and where it may of originally come from before we change the 
headers.
   
   Thanks,.
   Justin


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597392668
 
 
   @justinmclean Since this is not third party code, the current author and 
claimed copyright hold could simpley change the copyright to me correct?  
People do that all the time.  Then any questions would be gone.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597383418
 
 
   > According to the definition in the Cambridge dictionary, nothing we are 
talking about is third part software: 
https://dictionary.cambridge.org/dictionary/english/third-party-software
   
   This true of a lot of files in NuttX.  Many people clone or extend files 
that I wrote and decide that they should put their name in the copyright.  But 
it is not third party code.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597383147
 
 
   @justinmclean 
   
   > I guess I need to understand what you mean by 3rd party in this case. In 
the case of these files, there is no 3rd party project. These were developed 
for NuttX and have existed only in the NuttX source tree and no where else (may 
not be true of some Sony files). The authors of the NuttX code simply chose to 
put their companies name in the copyright.
   
   According to the definition in the Cambridge dictionary, nothing we are 
talking about is third part software:  
https://dictionary.cambridge.org/dictionary/english/third-party-software
   
   Guidance would the names on the Copyrights would be useful, but this cannot 
be treated as third party software because it is not. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo edited a comment on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597378087
 
 
   > Is the issue that it's too easy to make a mistake selecting the right 
files to change...?
   
   That is why a long, hard review of the changes would be required if the 
files were changed via a script.  The problem previously is that that long hard 
review did not happen.
   
   If properly reviewed, then hand modification is indistinguishable in all 
ways from automated modification.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597378087
 
 
   > Is the issue that it's too easy to make a mistake selecting the right 
files to change...?
   
   That is why a long, hard review of the changes would be required if the 
files were changed via a script.  The problem previous is that that long hard 
review did not happen.
   
   If properly reviewed, then hand modification is indistinguishable in all 
ways from automated modification.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

adamfeuer commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597377510
 
 
   On Tue, Mar 10, 2020 at 2:58 PM Justin Mclean 
   wrote:
   
   > As I said before I would strongly recommend not using a script like this
   > to replace the headers.
   >
   
   Justin,
   
   What's the difference between using a script to do the edits and doing it
   manually in a text editor? It seems to me that once you have selected the
   files to change, there's no difference. Am I missing something?
   
   Is the issue that it's too easy to make a mistake selecting the right files
   to change...?
   
   cheers
   adam
   -- 
   Adam Feuer 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo edited a comment on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597376544
 
 
   @justinmclean 
   
   > I’m not sure this a valid assumption, it is for BSD files copyright 
Gregory Nutt but for for 3rd party files with a single copyright please do not 
change these.
   
   Think this is a valid assumption for the set of files under consideration.  
These are not third party files, these are files developed specifically for 
NuttX and clone the standard NuttX BSD-3 header.
   
   > Sony and Pinecone have not submitted SGAs and their headers should not be 
changed. You can’t remove 3rd party headers without documented permission.
   
   I guess I need to understand what you mean by 3rd party in this case.  In 
the case of these files, there is no 3rd party project.  These were developed 
for NuttX and have existed only in the NuttX source tree and no where else (may 
not be true of some Sony files).  The authors of the NuttX code simply chose to 
put their companies name in the copyright.
   
   (Pinecone is a subsidiary of Xiaomi)
   
   And in this case, the headers would be changed by the same person that 
authored the files and who put the original company copyrights in the headers 
(with the permission of their company).
   
   Does that change your opinion?  Certainly it would be good to get an SGA but 
that would likely takes months in the company legal offices.  If we need SGA's 
we should get the process moving.  But perhaps we don't need them for these 
files?  What say ye.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] Ouss4 merged pull request #532: eZ80F92: Eliminate Spurious Interrupts

[GitBox]

Ouss4 merged pull request #532: eZ80F92: Eliminate Spurious Interrupts
URL: https://github.com/apache/incubator-nuttx/pull/532
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597338976
 
 
   HI,
   > Has Sony and Pinecone official submitted SGAs? Or is this this just a 
verbal permission to change copyrights. The safest thing would be if you were 
to change all Pinecone copyrighted code, not someone else.
   > 
   
   Sony and Pinecone have not submitted SGAs and their headers should not be 
changed. You can’t remove 3rd party headers without documented permission.
   
   Thanks,
   Justin


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] justinmclean commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

justinmclean commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597337763
 
 
   HI,
   
   > The word COPYRIGHT will appear in the BSD license, but not other form of 
the word copyright should appear in the file. I think if there is only one 
Copyright and the name matches, we can change the license
   > 
   
   I’m not sure this a valid assumption, it is for BSD files copyright Gregory 
Nutt but for for 3rd party files with a single copyright please do not change 
these.
   
   Also it not considering the case where a BSD license header may of 
incorrectly been placed on a file. This is because ASF policy is slightly 
different to how the project has previously treated 3rd party files.
   
   As I said before I would strongly recommend not using a script like this to 
replace the headers.
   
   Thanks,
   Justin


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo opened a new pull request #532: eZ80F92: Eliminate Spurious Interrupts

[GitBox]

patacongo opened a new pull request #532: eZ80F92: Eliminate Spurious Interrupts
URL: https://github.com/apache/incubator-nuttx/pull/532
 
 
   Timer control register was not being cleared and, as a result, timer 
interrupts may have been already enabled when the CPU was started by the 
debugger.  This would result in spurious interrupts and Unexpected Interrupt 
crashes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #482: nxstyle: header files that are not header files.

[GitBox]

patacongo edited a comment on issue #482: nxstyle:  header files that are not 
header files.
URL: https://github.com/apache/incubator-nuttx/issues/482#issuecomment-597290899
 
 
   > Even if I state the obvious:
   > Name them .inc (or similar) and have nxstyle treat them as c file.
   > Should be a one liner...
   
   No, that was not obvious to me, but sounds like a good idea.  The extension 
.inc is actuallly used by some toolchains.  The ZiLOG tools, it is an assembly 
language header file.  They use .src too which would be another good option.  
.inc is better beccause .src appears in most .gitignore files, I do not think 
that .inc does.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #482: nxstyle: header files that are not header files.

[GitBox]

patacongo edited a comment on issue #482: nxstyle:  header files that are not 
header files.
URL: https://github.com/apache/incubator-nuttx/issues/482#issuecomment-597290899
 
 
   > Even if I state the obvious:
   > Name them .inc (or similar) and have nxstyle treat them as c file.
   > Should be a one liner...
   
   No, that was not obvious to me, but sounds like a good idea.  The extension 
.inc is actuallly used by some toolchains.  The ZiLOG tools, it is an assembly 
language header file.  They use .src too which would be another good option.  
.inc is better beccause .src appears in most .gitignore files, I do nothing 
think that .inc does.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

adamfeuer commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597291534
 
 
   > The manner in which we do things can and in fact should be different. 
Diversity is strength. But the end-result must all be consistent and look as 
though it were done by one hand, the hand of the team.
   
   Agreed. So I'll see if I can make the tool I'm using meet the requirements 
you and @xiaoxiang781216 laid out and look like the hand of the team.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #482: nxstyle: header files that are not header files.

[GitBox]

patacongo commented on issue #482: nxstyle:  header files that are not header 
files.
URL: https://github.com/apache/incubator-nuttx/issues/482#issuecomment-597290899
 
 
   
   > Even if I state the obvious:
   > Name them .inc (or similar) and have nxstyle treat them as c file.
   > Should be a one liner...
   
   No, that was not obvious to me, but sounds like a good idea.  The extension 
.inc is atuallly used by some toolchains (the ZiLOG tools, it is an assembly 
language header file).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597289815
 
 
   > Does this need to be a tool that's checked into the build system?
   
   No.  It is certainly not a part of the build system.  A copy in tools/ would 
probably be good for posterity but is not necessary.  Another option if you 
can't change the license to Apache would be to use the Buildroot tools 
repository.  That is where all of the NuttX tools with incompatible licensing 
reside.
   
   > @patacongo We all have different ways of doing things. :)
   
   The manner in which we do things can and in fact should be different.  
Diversity is strength.  But the end-result must all be consistent and look as 
though it were done by one hand, the hand of the team.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] johannes-nivus commented on issue #482: nxstyle: header files that are not header files.

[GitBox]

johannes-nivus commented on issue #482: nxstyle:  header files that are not 
header files.
URL: https://github.com/apache/incubator-nuttx/issues/482#issuecomment-597289659
 
 
   Even if I state the obvious:
   Name them .inc (or similar) and have nxstyle treat them as c file.
   Should be a one liner...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

adamfeuer commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597287524
 
 
   @patacongo We all have different ways of doing things. :) 
   
   Does this need to be a tool that's checked into the build system?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597284433
 
 
   > Python is overkill It is 10 lines of bash script.
   > 15 minutes worth of work.
   
   Of course, I don't care what tools you use (if it is not part of the build 
system).  I care about the result that we get.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597283368
 
 
   Just in case you were not aware:  Python scripts are not permitted in the 
build system.  That is because it is not required to install Python in order to 
build NuttX.  But there is nothing wrong with Python tools, just not everyone 
will be able to use them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597282303
 
 
   Python is overkill  It is 10 lines of bash script.
   15 minutes worth of work.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597282019
 
 
   > you could probably really do all of that with head, cat, and tail
   
   yes, for that example i think you could just do:
   
   head -3 sched/init/nx_start.c >tmpfile
   cat license-file.txt >>tmpfile
   cat sched/init/nx_start.c | sed -e 1,32d >>tmpfile
   
   Works like a charm.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

adamfeuer commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597281983
 
 
   @patacongo I'm modifying an existing python tool, 
[licenseheaders](https://github.com/johann-petrak/licenseheaders) ([my fork of 
licenseheaders](https://github.com/adamfeuer/licenseheaders)), so it'll be 
python, not bash. But I'll see if I can match your rules. 
   
   I'll alter the script so it can do one file at a time, or take a list of 
files, so that we can carefully select the list of files to process as you 
suggest.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #527: STM32H753II

[GitBox]

patacongo commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597275720
 
 
   Many people have contributed and reviewed that workflow.  It would be 
extremely bad style to discard that work.  I would have to be opposed to this.
   
   The document must be fully inclusive and represent all people.  If you want 
a fully compkatible, short version, that would have to be in addition to the 
work of others and not a replacement for the work others.
   
   Let's not "steam roller" ovee the community
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #527: STM32H753II

[GitBox]

davids5 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597263918
 
 
   > The reader just need follow the sequence step by step, no any if/else at 
all.
   +1
   
   @xiaoxiang781216 good point - maybe it should be 3 pages. 
   1 Simple highlevel contributing
   2 Contributing workflow
   2 Commiter's workflow
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] adamfeuer commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

adamfeuer commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597260864
 
 
   @xiaoxiang781216 Yes, I will try this. Should I try it on just the files in 
this PR? (And submit a separate branch or PR to look at?)
   
   @patacongo Some questions on the details:
   
   * Ruler width: should the tool try to guess the block comment width from 
looking at the other block comments in the file? Or just the initial license 
block comment?
   * First N lines: There can be important info in the first lines of the 
license block, so the tool should preserve everything up to the first `* ` line 
(blank line starting with a `*`)
   * Retain everything at the end of the license: Do you mean just the bottom 
block close of `*`'s?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[incubator-nuttx] branch master updated: Fixed formatting error I introduced

[xiaoxiang]

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git


The following commit(s) were added to refs/heads/master by this push:
 new 0817ffb  Fixed formatting error I introduced
0817ffb is described below

commit 0817ffbc5424908028ee6b570d047aaa9883f22a
Author: David Sidrane 
AuthorDate: Tue Mar 10 10:30:24 2020 -0700

Fixed formatting error I introduced
---
 sched/mqueue/mqueue.h | 38 +++---
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/sched/mqueue/mqueue.h b/sched/mqueue/mqueue.h
index f9c4b21..0e012ef 100644
--- a/sched/mqueue/mqueue.h
+++ b/sched/mqueue/mqueue.h
@@ -49,13 +49,13 @@
 
 /* This defines the number of messages descriptors to allocate at each
  * "gulp."
- **/
+ */
 
 #define NUM_MSG_DESCRIPTORS 24
 
 /* This defines the number of messages to set aside for exclusive use by
  * interrupt handlers
- **/
+ */
 
 #define NUM_INTERRUPT_MSGS   8
 
@@ -65,24 +65,24 @@
 
 enum mqalloc_e
 {
-  MQ_ALLOC_FIXED = 0,  /* Pre-allocated; never freed **/
-  MQ_ALLOC_DYN,/* Dynamically allocated; free when unused **/
-  MQ_ALLOC_IRQ /* Preallocated, reserved for interrupt handling **/
+  MQ_ALLOC_FIXED = 0,  /* Pre-allocated; never freed */
+  MQ_ALLOC_DYN,/* Dynamically allocated; free when unused */
+  MQ_ALLOC_IRQ /* Preallocated, reserved for interrupt handling */
 };
 
-/* This structure describes one buffered POSIX message. **/
+/* This structure describes one buffered POSIX message. */
 
 struct mqueue_msg_s
 {
-  FAR struct mqueue_msg_s *next;  /* Forward link to next message **/
-  uint8_t type;   /* (Used to manage allocations) **/
-  uint8_t priority;   /* priority of message **/
+  FAR struct mqueue_msg_s *next;  /* Forward link to next message */
+  uint8_t type;   /* (Used to manage allocations) */
+  uint8_t priority;   /* priority of message */
 #if MQ_MAX_BYTES < 256
-  uint8_t msglen; /* Message data length **/
+  uint8_t msglen; /* Message data length */
 #else
-  uint16_t msglen;/* Message data length **/
+  uint16_t msglen;/* Message data length */
 #endif
-  char mail[MQ_MAX_BYTES];/* Message data **/
+  char mail[MQ_MAX_BYTES];/* Message data */
 };
 
 
/
@@ -99,20 +99,20 @@ extern "C"
 
 /* The g_msgfree is a list of messages that are available for general use.
  * The number of messages in this list is a system configuration item.
- **/
+ */
 
 EXTERN sq_queue_t  g_msgfree;
 
 /* The g_msgfreeInt is a list of messages that are reserved for use by
  * interrupt handlers.
- **/
+ */
 
 EXTERN sq_queue_t  g_msgfreeirq;
 
 /* The g_desfree data structure is a list of message descriptors available
  * to the operating system for general use. The number of messages in the
  * pool is a constant.
- **/
+ */
 
 EXTERN sq_queue_t  g_desfree;
 
@@ -120,8 +120,8 @@ EXTERN sq_queue_t  g_desfree;
  * Public Function Prototypes
  
/
 
-struct tcb_s;/* Forward reference **/
-struct task_group_s; /* Forward reference **/
+struct tcb_s;/* Forward reference */
+struct task_group_s; /* Forward reference */
 
 /* Functions defined in mq_initialize.c 
*/
 
@@ -162,5 +162,5 @@ void nxmq_recover(FAR struct tcb_s *tcb);
 }
 #endif
 
-#endif /* CONFIG_MQ_MAXMSGSIZE > 0 **/
-#endif /* __SCHED_MQUEUE_MQUEUE_H **/
+#endif /* CONFIG_MQ_MAXMSGSIZE > 0 */
+#endif /* __SCHED_MQUEUE_MQUEUE_H */

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #530: Fixed formatting error I introduced

[GitBox]

xiaoxiang781216 merged pull request #530: Fixed formatting error I introduced
URL: https://github.com/apache/incubator-nuttx/pull/530
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597257576
 
 
   > > Maybe we can reuse and improve @adamfeuer 's tool, @adamfeuer are you 
interesting with the work?
   > 
   > Sounds like a good idea to me. But we must be much more careful that last 
time. I think the tool should preserved the first N lines everything from:
   > 
   > ```
   > 
/
   > ```
   > 
   > To the first occurence of
   > 
   > ```
   >  *
   > ```
   > 
   > We need to retain the "ruler" width, the file name as well as any optional 
descriptioni of the file which may be more than one line. Then retain 
everything at the end of the license:
   > 
   > ```
   >  *
   >  
/
   > ```
   > 
   > There are some cases I have seen where people put information in the 
licsned comment block after the license text proper. That should be retained as 
well if present.
   > 
   > Plus, as I mentioned before, we must carefully select the files to operate 
on so that the contain the name are replaced ("Gregory Nutt", or "Pinecone", or 
"Sony") and that the the Word Copyright only appears in the file.
   > 
   > And we must carefully review each file so that we are 100% that the tool 
did nothing reckless.
   
   Yes, we should try to run @adamfeuer 's tool with different cases and verify 
the result before we really apply the change. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo edited a comment on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597251644
 
 
   This does the job:
   
   #!/bin/sh
   
   for file in `find . -type f`; do
 if [ "X`grep $1 $file`" != "X" ]; then
   if [ `grep -c Copyright $file` -eq 1 ]; then
 echo $file
   fi
 fi
   done
   
   For a small example restricted to the fs/ sub-directory:
   
   $ cd fs
   $ ../copyright.sh Pinecone
   ./driver/fs_blockpartition.c
   ./driver/fs_mtdpartition.c
   ./driver/fs_mtdproxy.c
   ./hostfs/hostfs_rpmsg.c
   ./hostfs/hostfs_rpmsg.h
   ./hostfs/hostfs_rpmsg_server.c
   ./partition/fs_partition.c
   ./partition/fs_ptable.c
   ./partition/Make.defs
   ./partition/partition.h
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597251644
 
 
   This does the job:
   
   #!/bin/sh
   
   for file in `find . -type f`; do
 if [ "X`grep $1 $file`" != "X" ]; then
   if [ `grep -c Copyright $file` -eq 1 ]; then
 echo $file
   fi
 fi
   done
   
   For a small example restricted to the fs/ sub-directory:
   
   $ cd fs
   $ ../copyright.sh Pinecone
   ./driver/fs_blockpartition.c
   ./driver/fs_mtdpartition.c
   ./driver/fs_mtdproxy.c
   ./hostfs/hostfs_rpmsg.c
   ./hostfs/hostfs_rpmsg.h
   ./hostfs/hostfs_rpmsg_server.c
   ./partition/fs_partition.c
   ./partition/fs_ptable.c
   ./partition/Make.defs
   ./partition/partition.h
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597244761
 
 
   > Maybe we can reuse and improve @adamfeuer 's tool, @adamfeuer are you 
interesting with the work?
   
   Sounds like a good idea to me.  But we must be much more careful that last 
time.  I think the tool should preserved the first N lines everything from:
   
   
/
   
   To the first occurence of 
   
*
   We need to retain the "ruler" width, the file name as well as any optional 
descriptioni of the file which may be more than one line.   Then retain 
everything at the end of the license:
   
*

/
   
   There are some cases I have seen where people put information in the licsned 
comment block after the license text proper.  That should be retained as well 
if present.
   
   Plus, as I mentioned before, we must carefully select the files to operate 
on so that the contain the name are replaced ("Gregory Nutt", or "Pinecone", or 
"Sony") and that the the Word Copyright only appears in the file.
   
   And we must carefully review each file so that we are 100% that the tool did 
nothing reckless.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #531: Add some helpful documentation in checkpatch.sh.

[GitBox]

xiaoxiang781216 merged pull request #531: Add some helpful documentation in 
checkpatch.sh.
URL: https://github.com/apache/incubator-nuttx/pull/531
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[incubator-nuttx] branch master updated (d43cb2f -> 0db4529)

[xiaoxiang]

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.


from d43cb2f  sched/mqueue:  Correct/update license headers.
 add 0db4529  Add some helpful documentation in checkpatch.sh.

No new revisions were added by this update.

Summary of changes:
 tools/checkpatch.sh | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #521: Document checkpatch.sh arguments with examples.

[GitBox]

xiaoxiang781216 closed issue #521: Document checkpatch.sh arguments with 
examples.
URL: https://github.com/apache/incubator-nuttx/issues/521
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597238644
 
 
   > @xiaoxiang781216 Thanks for the merge!
   > 
   > Are you planning to write a tools to do the header changes? Or would you 
do them by hand. If you do them by hand, I will be happy to help out. it is 
really very easy and very fast (and probably safest).
   >
   
   Maybe we can reuse and improve @adamfeuer 's tool, @adamfeuer are you 
interesting with the work?  
   > The probably is that every file you modify will also have to have nxstyle 
ran against it .. either before or after the PR.
   
   Yes, I suggest that we bypass the style check for license PR because:
   1.It's hard to audit or revert license patch if we do style and license 
modification at the same time.
   2.License patch just change the comment, it isn't likely to introduce the 
new style issue or build break.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #527: STM32H753II

[GitBox]

xiaoxiang781216 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597233802
 
 
   > @xiaoxiang781216
   > 
   > > The better approach is append your style patch to this PR and trigger 
the precheck again:
   > > 
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
   > 
   > Yes. That it the right approach, and I will do it that way when I have 
time.
   > 
   > Did you add it to the work flow document?
   
   The workflow document contain many options now, and it's hard for newbie to 
follow up. I would prefer that the main body of workflow document just describe 
the best practice the most contributor use daliy, for example:
   1.One method to get source code
   2.One method to send PR
   3.One method to rework the PR after review
   The reader just need follow the sequence step by step, no any if/else at all.
   And then the document could list other alternatives or advance usage like 
this in the note section.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 opened a new pull request #531: Add some helpful documentation in checkpatch.sh.

[GitBox]

davids5 opened a new pull request #531: Add some helpful documentation in 
checkpatch.sh.
URL: https://github.com/apache/incubator-nuttx/pull/531
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[incubator-nuttx] branch master-help-checkpatch.sh created (now b9214f9)

[davids5]

This is an automated email from the ASF dual-hosted git repository.

davids5 pushed a change to branch master-help-checkpatch.sh
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.


  at b9214f9  Add some helpful documentation in checkpatch.sh.

This branch includes the following new commits:

 new b9214f9  Add some helpful documentation in checkpatch.sh.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[incubator-nuttx] 01/01: Add some helpful documentation in checkpatch.sh.

[davids5]

This is an automated email from the ASF dual-hosted git repository.

davids5 pushed a commit to branch master-help-checkpatch.sh
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit b9214f94564c839a76f7d8fac7df6866cd9145f7
Author: David Sidrane 
AuthorDate: Tue Mar 10 10:49:40 2020 -0700

Add some helpful documentation in checkpatch.sh.
---
 tools/checkpatch.sh | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/checkpatch.sh b/tools/checkpatch.sh
index b6731f5..48b9f29 100755
--- a/tools/checkpatch.sh
+++ b/tools/checkpatch.sh
@@ -29,11 +29,14 @@ usage() {
   echo "-h"
   echo "-c spell check with codespell(install with: pip install codespell)"
   echo "-r range check only (coupled with -p or -g)"
-  echo "-p  (default)"
+  echo "-p  (default)"
   echo "-g "
   echo "-f "
   echo "-  read standard input mainly used by git pre-commit hook as below:"
   echo "   git diff --cached | ./tools/checkpatch.sh -"
+  echo "Where a  is any syntax supported by git for specifying 
git revision, see GITREVISIONS(7)"
+  echo "Where a  is a space separated list of patch file 
names or wildcard. or *.patch"
+ 
 }
 
 check_file() {

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #525: nxstyle: Does not check for braces.

[GitBox]

xiaoxiang781216 commented on issue #525: nxstyle:  Does not check for braces.
URL: https://github.com/apache/incubator-nuttx/issues/525#issuecomment-597224541
 
 
   > @johannes-nivus It is important that we document shortcomings in nxstyle, 
whether we fix them or not. In order to implement this particular feature, some 
minimal syntax parsing would be required; I am not sure we want to go that 
route. But we definitely need an issue in place to remind us that not all 
coding standard issues are addresses.
   > 
   > There are many, many things that are not checked by nxstyle. Some that 
come to mind:
   > 
   > Non-local scope (global) varialbes must begin with g_
   
   How about stdin/stdout/stderr? any naming rule will have exception, but the 
standard has the high priority than coding style.
   
   > Structure names must end with _s, union names must end with _u, 
enumeration names must end with _e, typedef'e names must end with _t
   
   But we need smart here: any struct/union/enum/typedef defined by the 
standard need to keep as before.
   
   > All identifiers are local case except the pre-processor names are all 
upper case.
   > etc.
   > 
   > There are more coding standard issues that are NOT addressed than there 
are coding standard issues addresses. I am not familiar with any automated 
pretty printer than can fix such things either.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 opened a new pull request #530: Fixed formatting error I introduced

[GitBox]

davids5 opened a new pull request #530: Fixed formatting error I introduced
URL: https://github.com/apache/incubator-nuttx/pull/530
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #525: nxstyle: Does not check for braces.

[GitBox]

patacongo commented on issue #525: nxstyle:  Does not check for braces.
URL: https://github.com/apache/incubator-nuttx/issues/525#issuecomment-597214875
 
 
   @johannes-nivus It is important that we document shortcomings in nxstyle, 
whether we fix them or not.  In order to implement this particular feature, 
some minimal syntax parsing would be required; I am not sure we want to go that 
route.  But we definitely need an issue in place to remind us that not all 
coding standard issues are addresses.
   
   There are many, many things that are not checked by nxstyle.  Some that come 
to mind:
   
   Non-local scope (global) varialbes must begin with g_
   Structure names must end with _s, union names must end with _u, enumeration 
names must end with _e, typedef'e names must end with _t
   All identifiers are local case except the pre-processor names are all upper 
case.
   etc.
   
   There are more coding standard issues that are NOT addressed than there are 
coding standard issues addresses.  I am not familiar with any automated pretty 
printer than can fix such things either.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] johannes-nivus commented on issue #525: nxstyle: Does not check for braces.

[GitBox]

johannes-nivus commented on issue #525: nxstyle:  Does not check for braces.
URL: https://github.com/apache/incubator-nuttx/issues/525#issuecomment-597209363
 
 
   I'd like to have a look concerning braces, but I'm not sure if I beat a dead 
horse. If someone is successful with a more common tool (as discussed on 
mailing list) all the work would become obsolete suddenly. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #527: STM32H753II

[GitBox]

davids5 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597209034
 
 
   @xiaoxiang781216 
   
   >The better approach is append your style patch to this PR and trigger the 
precheck again:
   
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
   
   Yes. That it the right approach, and I will do it that way when I have time.
   
   Did you add it to the work flow document?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597196861
 
 
   @xiaoxiang781216 Thanks for the merge!
   
   Are you planning to write a tools to do the header changes?  Or would you do 
them by hand.  If you do them by hand, I will be happy to help out.  it is 
really very easy and very fast (and probably safest).
   
   The probably is that every file you modify will also have to have nxstyle 
ran against it .. either before or after the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #459: stm32h7: support SDRAM via FMC peripherial

[GitBox]

xiaoxiang781216 commented on issue #459: stm32h7: support SDRAM via FMC 
peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597195078
 
 
   > I see, nxstyle.c has changed in the meanwhile.
   > I fixed everything he says now, except this:
   > 
   > arch/arm/src/stm32h7/Kconfig: info: No file extension
   > arch/arm/src/stm32h7/Kconfig: info: Unknown file extension
   > 
   > I hope this will not stop the automatic checks to pass.
   >
   
   This is just an information, don't stop precheck. Actually, a PR already 
remove this info:
   https://github.com/apache/incubator-nuttx/pull/526

   > P.S. Sidenote: in tools/checkpatch.h you could get the list of files in a 
commit much simpler:
   > git show --name-only --pretty="" 
[94a73a8](https://github.com/apache/incubator-nuttx/commit/94a73a87363557b839b8c1bc032f7c77d02e5044)
   > or even
   > git show --name-only --pretty="" 
[94a73a8](https://github.com/apache/incubator-nuttx/commit/94a73a87363557b839b8c1bc032f7c77d02e5044)..HEAD
   
   Yes, but checkpatch.sh support to just check the lines you really modify not 
the whole file. You can try something like this:
   checkpatch.sh -r -g HEAD
   And compare it with:
   checkpatch.sh -g HEAD
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #529: Stm32F7: add external ram config

[GitBox]

patacongo commented on a change in pull request #529: Stm32F7: add external ram 
config
URL: https://github.com/apache/incubator-nuttx/pull/529#discussion_r390457260
 
 

 ##
 File path: arch/arm/src/stm32f7/Kconfig
 ##
 @@ -2136,6 +2136,14 @@ endchoice #"ULPI Selection"
 
 endmenu # OTG_HS Config
 
+config STM32F7_EXTERNAL_RAM
+bool "External RAM on FMC"
+default n
+depends on STM32F7_FMC
+select ARCH_HAVE_HEAP2
+---help---
+In addition to internal SDRAM, external RAM may be available through 
the FMC.
+
 
 Review comment:
   Where is this new configuration option used?  It is not used in 
arch/arm/src/stm32f7 so it does not belong there.
   
   Do you use it in your board?  If so then it belongs in your 
boards/arm/stm32/your-board/Kconfig and it should be named 
CONFIG_YOURBOARD_EXTERNAL_RAM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[incubator-nuttx] branch master updated (e5f5509 -> d43cb2f)

[xiaoxiang]

This is an automated email from the ASF dual-hosted git repository.

xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.


from e5f5509  stm32h7: Added basic support for STM32H753II. (#527)
 add d43cb2f  sched/mqueue:  Correct/update license headers.

No new revisions were added by this update.

Summary of changes:
 sched/mqueue/Make.defs | 39 +++
 sched/mqueue/mq_desclose.c | 39 +++
 sched/mqueue/mq_descreate.c| 39 +++
 sched/mqueue/mq_getattr.c  | 39 +++
 sched/mqueue/mq_initialize.c   | 43 +-
 sched/mqueue/mq_msgfree.c  | 39 +++
 sched/mqueue/mq_msgqalloc.c| 39 +++
 sched/mqueue/mq_msgqfree.c | 39 +++
 sched/mqueue/mq_notify.c   | 39 +++
 sched/mqueue/mq_rcvinternal.c  | 46 ++---
 sched/mqueue/mq_receive.c  | 43 +-
 sched/mqueue/mq_recover.c  | 39 +++
 sched/mqueue/mq_release.c  | 43 +-
 sched/mqueue/mq_send.c | 46 ++---
 sched/mqueue/mq_setattr.c  | 39 +++
 sched/mqueue/mq_sndinternal.c  | 39 +++
 sched/mqueue/mq_timedreceive.c | 40 +++
 sched/mqueue/mq_timedsend.c| 47 ++
 sched/mqueue/mq_waitirq.c  | 39 +++
 sched/mqueue/mqueue.h  | 47 ++
 20 files changed, 262 insertions(+), 561 deletions(-)

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 merged pull request #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #529: Stm32F7: add external ram config

[GitBox]

patacongo commented on a change in pull request #529: Stm32F7: add external ram 
config
URL: https://github.com/apache/incubator-nuttx/pull/529#discussion_r390457260
 
 

 ##
 File path: arch/arm/src/stm32f7/Kconfig
 ##
 @@ -2136,6 +2136,14 @@ endchoice #"ULPI Selection"
 
 endmenu # OTG_HS Config
 
+config STM32F7_EXTERNAL_RAM
+bool "External RAM on FMC"
+default n
+depends on STM32F7_FMC
+select ARCH_HAVE_HEAP2
+---help---
+In addition to internal SDRAM, external RAM may be available through 
the FMC.
+
 
 Review comment:
   Where is this new configuration option used?  It is not used in 
arch/arm/src/stm32f7 so it does not belong there.
   
   Do you use it in your board?  If so then it belongs in your 
boards/arm/stm32//Kconfig


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial

[GitBox]

anpaza commented on issue #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597190237
 
 
   I see, nxstyle.c has changed in the meanwhile.
   I fixed everything he says now, except this:
   
   arch/arm/src/stm32h7/Kconfig: info: No file extension
   arch/arm/src/stm32h7/Kconfig: info: Unknown file extension
   
   I hope this will not stop the automatic checks to pass.
   
   P.S. Sidenote: in tools/checkpatch.h you could get the list of files in a 
commit much simpler:
   git show --name-only --pretty="" 94a73a87363557b839b8c1bc032f7c77d02e5044
   or even
   git show --name-only --pretty="" 
94a73a87363557b839b8c1bc032f7c77d02e5044..HEAD


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597188315
 
 
   > The word COPYRIGHT will appear in the BSD license, but not other form of 
the word copyright should appear in the file. I think if there is only one 
Copyright and the name matches, we can change the license.
   
   No, the word copyright appears in the BSD license too:
   
   $ grep -ci COPYRIGHT sched/init/nx_start.c
   5
   
   Five total as follows:
   
   $ grep -c COPYRIGHT sched/init/nx_start.c
   2
   
   $ grep -c copyright sched/init/nx_start.c
   2
   
   $ grep -c Copyright sched/init/nx_start.c
   1
   
   But the word Copright will appear only once on a file that we can safely 
modify


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597186120
 
 
   @xiaoxiang781216 
   > The report looks right.
   
   yes, I think it ran again and did not fail  I have also pushed the fixes for 
the long lines.
   
   > We can convert the files which don't have any doubt first, otherwise we 
can never finish the copyright work item.
   
   I agree 100%.  I think we can search for names like:
   
   FILELSIT=`find . -type f | xargs grep `
   
   Where name is "Gregory Nutt" or Pinecone or whoever.  Then verify that there 
is only one copright:
   
   for file in $FILELIST; do
 ncopyrights=`grep -c $file`
 if [ ncopyrights -eq 1] ; then
   replace header
 fi
   done
   
   For example:
   
   $ grep "Gregory Nutt" sched/init/nx_start.c
*   Copyright (C) 2007-2014, 2016, 2018 Gregory Nutt. All rights 
reserved.
*   Author: Gregory Nutt 
   
   $ grep -c Copyright sched/init/nx_start.c
   1
   
   The word COPYRIGHT will appear in the BSD license, but not other form of the 
word copyright should appear in the file.  I think if there is only one 
Copyright and the name matches, we can change the license.
   
   
 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial

[GitBox]

davids5 commented on issue #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597178908
 
 
   >If you tell me how, I can fix it myself.
   @anpaza See this commit
   b27e7d7
   
   @xiaoxiang781216 I left it up to the contributor @anpaza  and he said he 
would like to fix it. That is what I am waiting on. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597173905
 
 
   > @xiaoxiang781216 First, note the weird failure mode of this check. Looks 
like a tool failure:
   > 
   > ```
   > Check failure on line 1 in .github
   > @github-actions github-actions / check
   > .github#L1
   > Process completed with exit code 1.
   > ```
   > 
   
   I just saw this:
   
![image](https://user-images.githubusercontent.com/18066964/76332803-c9497700-632b-11ea-96d4-cb3e2e8fb0c6.png)
   The report looks right.
   
   > We need to be very careful with any automated header changes. The are some 
execptions to almost every rule. Some people (inappropriately) added copyright 
to code. It is very common for people to take my file, modify a line or two and 
add themselves to the Copyright holders.
   >
   
   We can convert the files which don't have any doubt first, otherwise we can 
never finish the copyright work item.

   > There are also controversial files that we need to handle separately. So 
any tool would have to carefully check that (1) only one person claims to hold 
a copyright and (2) that person is on e the list of people who have granted 
software to the ASF.
   > 
   
   It's simple, we convert the files step by step:
   1.Convert the files which declare that you are the author
   2.Convert the files which declare Sony and his employee are author
   ...
   This positive search and conversion ensure we don't change the license 
accidently.
   
   > Has Sony and Pinecone official submitted SGAs? Or is this this just a 
verbal permission to change copyrights. The safest thing would be if you were 
to change all Pinecone copyrighted code, not someone else.
   > 
   
   We can submit SGA, where is the document for the workflow?
   
   > I have submitted an SGA.
   > 
   > Others have granted permission to change the copyrights: Ken Pettit and 
others, but we should formalized that process somehow.
   > 
   > This discussion belong on the dev list!
   
   Since the workflow is almost done, I think it's right time to disscuss 
license. Could you start a thread to collect the community feedback?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo edited a comment on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597169706
 
 
   @xiaoxiang781216 I don't think I was clear in my last response.  The short 
answer is YES, let's change the headers that we can but be careful with any 
that have unusual content.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597169706
 
 
   I don't think I was clear in my last response.  The short answer is YES, 
let's change the headers that we can but be careful with any that have unusual 
content.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] AlexanderVasiljev opened a new pull request #529: Stm32F7: add external ram config

[GitBox]

AlexanderVasiljev opened a new pull request #529: Stm32F7: add external ram 
config
URL: https://github.com/apache/incubator-nuttx/pull/529
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597165662
 
 
   @xiaoxiang781216 First, note the weird failure mode of this check.  Looks 
like a tool failure:
   
   Check failure on line 1 in .github
   @github-actions github-actions / check
   .github#L1
   Process completed with exit code 1.
   
   We need to be very careful with any automated header changes.  The are some 
execptions to almost every rule.  Some people (inappropriately) added copyright 
to code.  It is very common for people to take my file, modify a line or two 
and add themselves to the Copyright holders.
   
   There are also controversial files that we need to handle separately.  So 
any tool would have to carefully check that (1) only one person claims to hold 
a copyright and (2) that person is on e the list of people who have granted 
software to the ASF.
   
   Has Sony and Pinecone official submitted SGAs?  Or is this this just a 
verbal permission to change copyrights.  The safest thing would be if you were 
to change all Pinecone copyrighted code, not someone else.
   
   I have submitted an SGA.
   
   Others have granted permission to change the copyrights:  Ken Pettit and 
others, but we should formalized that process somehow.
   
   This discussion belong on the dev list!
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #459: stm32h7: support SDRAM via FMC peripherial

[GitBox]

xiaoxiang781216 commented on issue #459: stm32h7: support SDRAM via FMC 
peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597164914
 
 
   > @anpaza - I think the tools is wrong and flagged things it should not have.
   > 
   > @patacongo would you please advise @anpaza on the rcc file and if we can 
take it in as is?
   
   This PR pass the style/build check, has it any logic issue to fix, @davids5? 
if not why don't we merge it? @anpaza already try his best to fix the coding 
style issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #528: sched/mqueue: Correct/update license headers.

[GitBox]

xiaoxiang781216 commented on issue #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528#issuecomment-597155660
 
 
   > PR #488 introduced an error in a file license header in file 
sched/mqueue/mqueue.h. This commit fixe that error and in the course of doing 
that, changing the license header to the standard Apache 2.0 header. I am the 
author and copyright hold of all modified files.
   
   @patacongo how about we start convert BSD to Apache license now at least for 
you, Xiaomi/Pinecone, Sony and other author which already give us the 
permission? Instead do it case by case, I have saw similar change many time in 
the recent PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #459: stm32h7: support SDRAM via FMC peripherial

[GitBox]

patacongo edited a comment on issue #459: stm32h7: support SDRAM via FMC 
peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597145330
 
 
   I will subit a PR.
   ...
   Please see PR #528 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo opened a new pull request #528: sched/mqueue: Correct/update license headers.

[GitBox]

patacongo opened a new pull request #528: sched/mqueue:  Correct/update license 
headers.
URL: https://github.com/apache/incubator-nuttx/pull/528
 
 
   PR #488 introduced an error in a file license header in file 
sched/mqueue/mqueue.h.  This commit fixe that error and in the course of doing 
that, changing the license header to the standard Apache 2.0 header.  I am the 
author and copyright hold of all modified files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #527: STM32H753II

[GitBox]

xiaoxiang781216 edited a comment on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597146448
 
 
   > @xiaoxiang781216 - Oh so that was your argument.
   > 
   
   Yes, I already express my opinion in email thread. We should try our best to 
follow the rule, right?
   
   > I will do a separate PR and fix all the style issues once the tools can 
report the real ones. This contributor has suffered from the tooling issues.
   
   But can you ensure the change pass the build? Yes, this patch is small, how 
about a little big change?
   The better approach is append your style patch to this PR and trigger the 
precheck again:
   
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #527: STM32H753II

[GitBox]

xiaoxiang781216 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597146448
 
 
   > @xiaoxiang781216 - Oh so that was your argument.
   > 
   
   Yes, I already express my opinion in email thread. We should try our best to 
follow the rule, right?
   
   > I will do a separate PR and fix all the style issues once the tools can 
report the real ones. This contributor has suffered from the tooling issues.
   
   But can you ensure the change can pass the build? Yes, this patch is small, 
how about a little big change?
   The better approach is append your style patch to this PR and trigger the 
precheck again:
   
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial

[GitBox]

patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597145330
 
 
   I will subit a PR.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial

[GitBox]

patacongo commented on issue #459: stm32h7: support SDRAM via FMC peripherial
URL: https://github.com/apache/incubator-nuttx/pull/459#issuecomment-597145174
 
 
   > no it was my mistake!
   
   Is someone going to fix that?  I don't mind doing it but I don't want to 
collide with anyone.
   
   BTW:  The best fix is just to replace the header with the standard Apache 
2.0 header.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #527: STM32H753II

[GitBox]

davids5 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597135580
 
 
   @xiaoxiang781216 - Oh so that was your argument. 
   
   I will do a separate PR and fix all the style issues once the tools can 
report the real ones. This contributor has suffered from the tooling issues.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services