[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/740


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r77284769
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+
+  protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --

@gaohoward Really? I thought they were different like AMQP.

Why do you need the scheduled executor then? just to set the variable?


  protocolManager.getScheduledPool().schedule(new Runnable() {
 @Override
 public void run() {
if (inactivityDuration >= 0) {
   connectionEntry.ttl = inactivityDuration;
}
 }
  }, inactivityDurationInitialDelay, TimeUnit.MILLISECONDS);



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r77283499
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+
+  protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --

With Openwire client there is only one maxInactivityDuration, so the 
client->server and server->client should be the same (if the server and client 
are different values, the smaller is taken). So in case of 1 seconds the server 
will send a ping at leas for every half of the seconds in order to avoid client 
timing out the connection. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r77282443
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+
+  protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --

Say the client->server ping is 1 minute.
The server->client ping is configured to be 1 seconds.

Shouldn't the server ping the client every 1 second in case of inactivity?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r77281820
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+
+  protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --

@clebertsuconic I don't understand. I thought it should be faster. For 
example if client sets the inactivityDuration (ttl) to be 10 src the server 
will sends a ping at least 5 sec (about half of the ttl )back to client 
(current impl). If it sends a ping for every 10 sec, there is a high chance 
client missing a ping and time out the connection.
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r77178512
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+
+  protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --

@gaohoward  I guess this fix is not valid then. If you set the server to 
send Pings to client faster than the client is configured you will later miss 
another ping on the client.

this was a TODO before and I thought you were fixing it. The server must 
ping at a sustained rate regardless of what the client sends.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r77176768
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+
+  protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --

Hi @clebertsuconic, one thing I want to point out is that the scheduler 
only run this task once.
So checkInactivity shouldn't be inside this schedule. Currently its in 
flush() method, which is guaranteed to be called by the core's failure checker 
thread.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76995434
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+
+  protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --

Actually.. scratch what I said before..  I thought the incoming pings were 
being duplicated.


The only issues I see now are:

i - nothing is cancelling the scheduler.

ii - you should call checkInactivity within the Runnable on the scheduler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76991371
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+
+  protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --

ok, let me think of it... Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76989641
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -345,16 +357,19 @@ public void disconnect(boolean criticalError) {
}
 
@Override
-   public boolean checkDataReceived() {
-  boolean res = dataReceived;
-
-  dataReceived = false;
-
-  return res;
+   public void flush() {
+  checkInactivity();
}
 
-   @Override
-   public void flush() {
+   private void checkInactivity() {
+  if (!this.useKeepAlive) {
--- End diff --

we don't need call super because we don't need to do anything special here, 
the super will always be called if we don't override it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76989578
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +756,25 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+
+  protocolManager.getScheduledPool().schedule(new Runnable() {
--- End diff --

I see three things wrong here:

I - you are recreating the TTL mechanism already existing on 
AbstractRemotingConnection. There's already a checker there for received pings 
from the client.

Most of the issues I had on the heavy refactoring we did on artemis 
openwire layer was around duplicated code. Having to figure out what was 
abstract and what needed to be at the openwire level.


II - It seems you 'are not sending the packet to the client through the 
Scheduler.


III - It seems this is leaking a future. I don't see you ever cancelling 
the future upon disconnect. this will leak a connection through the scheduled 
executor. 

You must hold a Future from the call you made on schedule. And cancel after 
the openWireConnection is closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76986566
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -345,16 +357,19 @@ public void disconnect(boolean criticalError) {
}
 
@Override
-   public boolean checkDataReceived() {
-  boolean res = dataReceived;
-
-  dataReceived = false;
-
-  return res;
+   public void flush() {
+  checkInactivity();
}
 
-   @Override
-   public void flush() {
+   private void checkInactivity() {
+  if (!this.useKeepAlive) {
--- End diff --

Call the super method then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76913484
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -345,16 +357,19 @@ public void disconnect(boolean criticalError) {
}
 
@Override
-   public boolean checkDataReceived() {
-  boolean res = dataReceived;
-
-  dataReceived = false;
-
-  return res;
+   public void flush() {
+  checkInactivity();
}
 
-   @Override
-   public void flush() {
+   private void checkInactivity() {
+  if (!this.useKeepAlive) {
--- End diff --

But this method already in the super class, here is just a duplicate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76913251
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -345,16 +357,19 @@ public void disconnect(boolean criticalError) {
}
 
@Override
-   public boolean checkDataReceived() {
-  boolean res = dataReceived;
-
-  dataReceived = false;
-
-  return res;
+   public void flush() {
+  checkInactivity();
}
 
-   @Override
-   public void flush() {
+   private void checkInactivity() {
+  if (!this.useKeepAlive) {
--- End diff --

but this method already in the super class, no need to repeat here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[gaohoward]

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76818458
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +765,31 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+  new Thread(new Runnable() {
--- End diff --

ok I'll use the executor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76802109
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -508,6 +524,9 @@ public WireFormat getMarshaller() {
}
 
private void shutdown(boolean fail) {
+
+  this.ttlLatch.countDown();
--- End diff --

If you didn't use a thread you wouldn't need this.

just use the scheduled executor to send pings to the client please.

Cancel the executor from a future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76801952
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -345,16 +357,19 @@ public void disconnect(boolean criticalError) {
}
 
@Override
-   public boolean checkDataReceived() {
-  boolean res = dataReceived;
-
-  dataReceived = false;
-
-  return res;
+   public void flush() {
+  checkInactivity();
}
 
-   @Override
-   public void flush() {
+   private void checkInactivity() {
+  if (!this.useKeepAlive) {
--- End diff --

You still need to set dataReceived to false, otherwise the TTL from 
ConnectionFActory will kick in and this will be killed per inactivity.


TTL in should be done by the dataREcieved attribute from the super class.


Sending a TTL to the client should be a different thing. i think it's just 
a matter to send the TTL back to the client.



You have changed way more than needed I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76800800
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -742,6 +765,31 @@ public void addConsumer(ConsumerInfo info) throws 
Exception {
   }
}
 
+   public void setConnectionEntry(ConnectionEntry connectionEntry) {
+  this.connectionEntry = connectionEntry;
+   }
+
+   public void setUpTtl(final long inactivityDuration, final long 
inactivityDurationInitialDelay, final boolean useKeepAlive) {
+  this.useKeepAlive = useKeepAlive;
+  this.maxInactivityDuration = inactivityDuration;
+  new Thread(new Runnable() {
--- End diff --

We can't use any thread... There's the Scheduled Executor.. this is no 
good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/740#discussion_r76800400
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
 ---
@@ -286,6 +295,9 @@ public void bufferReceived(Object connectionID, 
ActiveMQBuffer buffer) {
dispatchSync(response);
 }
  }
+ else {
+System.out.println(this + "server received a keepalive: " 
+ System.currentTimeMillis());
--- End diff --

System.out??   use a Logger.getLogger(). then trace.. look at how trace 
is done in other places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #740: ARTEMIS-706 No Keep Alives from Broker

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/740

ARTEMIS-706 No Keep Alives from Broker



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis artemis-706

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #740


commit 6ddd8998ce1b378aa3e9533d179f1efaf59aa742
Author: Howard Gao 
Date:   2016-08-30T02:43:58Z

ARTEMIS-706 No Keep Alives from Broker




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---