Re: [VOTE] Release of Apache Allura 1.11.0
+1 On Fri, Jun 14, 2019 at 10:43 AM Rohan Verma wrote: > +1 > > On Fri, Jun 14, 2019 at 9:35 AM Ingo Hornberger wrote: > > > +1 > > > > Shalitha Suranga schrieb am Fr., 14. Juni > > 2019, > > 02:24: > > > > > +1 > > > > > > On Fri, 14 Jun 2019, 12:40 am Dave Brondsema, > > wrote: > > > > > > > Hello, > > > > > > > > We haven't made a release for many months, so I've started the > process > > > for > > > > our > > > > next release. This is a call for a vote on Apache Allura 1.11.0. > > > > > > > > Source tarball, signature and checksums are available at: > > > > https://dist.apache.org/repos/dist/dev/allura/ > > > > > > > > Checksums: > > > > SHA512: > > > > > > > > > > > > > > 09ebdd22f87a8f2322b19e8bf05e967e701a4dc87686c48e6b7625a4cef106e0dcab8dfade0764ce0b04d4792fa6c26bbf3e7c23b7a7f6a5451c481b8de2ddf7 > > > > allura-1.11.0.tar.gz > > > > > > > > The KEYS file can be found at: > > > > https://www.apache.org/dist/allura/KEYS > > > > > > > > The release has been signed with key > > > > EAB0FABEDEA81AD4086902FE56F0526F9BB3CE70: > > > > > > > > > > > > > > > > > > http://pgp.mit.edu:11371/pks/lookup?op=vindex=0xEAB0FABEDEA81AD4086902FE56F0526F9BB3CE70 > > > > > > > > Source corresponding to this release can be found at: > > > > Commit: 8e79e65dca6379fc90ac4b738412419978f5ab7e > > > > Tag:rel/1.11.0 (pending successful vote) > > > > Browse: > > > > > > > > > > > > > > https://forge-allura.apache.org/p/allura/git/ci/8e79e65dca6379fc90ac4b738412419978f5ab7e/log/ > > > > > > > > Changes for this version are listed at: > > > > > > > > > > > > > > > > > > https://forge-allura.apache.org/p/allura/git/ci/8e79e65dca6379fc90ac4b738412419978f5ab7e/tree/CHANGES > > > > > > > > The RAT license report is available at: > > > > > > > > > > > > > > https://forge-allura.apache.org/p/allura/pastebin/5d029da1c82918000ed5a929 > > > > > > > > Vote will be open for at least 72 hours (Sun, 16 Jun 2019 18:28:10 > > UTC). > > > > Votes > > > > from Allura PMC members are binding, but we welcome all community > > members > > > > to > > > > vote as well. > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > Thanks & Regards > > > > > > > > > > > > -- > Sincerely > Rohan Verma > he...@rohanverma.net > -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
[allura:tickets] #8240 Personal Dashboard - Add dashboard docs
--- ** [tickets:#8240] Personal Dashboard - Add dashboard docs** **Status:** in-progress **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Sat Sep 29, 2018 10:11 AM UTC by Deshani **Last Updated:** Sat Sep 29, 2018 10:11 AM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [VOTE] Release of Apache Allura 1.9.0
+1 On Thu, Sep 20, 2018 at 6:50 PM Kenton Taylor wrote: > +1 > > --- > Kenton Taylor > Principal Engineer - sourceforge.net > Phone: 616-425-9149 > > > On Thu, Sep 20, 2018 at 4:24 AM Simone Gatti > wrote: > > > +1 > > > > Il giorno gio 20 set 2018 alle ore 08:53 Shalitha Suranga < > > shalithasura...@gmail.com> ha scritto: > > > > > Hi.. > > > > > > Thanks for asking about vote from community too. I vote *"+1 approve"* > > > because this release has lot of useful improvements for the project > > Allura > > > > > > Cheers! > > > > > > On Thu, Sep 20, 2018 at 3:14 AM Dave Brondsema > > wrote: > > > > > > > Hello, > > > > > > > > This is a call for a vote on Apache Allura 1.9.0. > > > > > > > > Source tarball, signature and checksums are available at: > > > > https://dist.apache.org/repos/dist/dev/allura/ > > > > > > > > Checksums: > > > > SHA512: > > > > > > > > > > > > > > 23152a60f176afa3868122ccc0bf355c5554cecd22c8bec75cd64d4df858f3241a559efc70bc91a8dbb778b46cf9ebafaa952d60c56ba5e945164330acf2b0f4 > > > > allura-1.9.0.tar.gz > > > > > > > > The KEYS file can be found at: > > > > http://www.apache.org/dist/allura/KEYS > > > > > > > > The release has been signed with key > > > > EAB0FABEDEA81AD4086902FE56F0526F9BB3CE70: > > > > > > > > > > > > > > > > > > http://pgp.mit.edu:11371/pks/lookup?op=vindex=0xEAB0FABEDEA81AD4086902FE56F0526F9BB3CE70 > > > > > > > > Source corresponding to this release can be found at: > > > > Commit: f78c70d1396e9c447ee903c94f6de7ca7d412c8f > > > > Tag:rel/1.9.0 (pending successful vote) > > > > Browse: > > > > > > > > > > > > > > https://forge-allura.apache.org/p/allura/git/ci/f78c70d1396e9c447ee903c94f6de7ca7d412c8f/log/ > > > > > > > > Changes for this version are listed at: > > > > > > > > > > > > > > > > > > https://forge-allura.apache.org/p/allura/git/ci/f78c70d1396e9c447ee903c94f6de7ca7d412c8f/tree/CHANGES > > > > > > > > The RAT license report is available at: > > > > > > > > > > > > > > https://forge-allura.apache.org/p/allura/pastebin/5ba2be4d4227c7000e8bc791 > > > > > > > > Vote will be open for at least 72 hours (Sat, 22 Sep 2018 21:06:10 > > UTC). > > > > Votes > > > > from Allura PMC members are binding, but we welcome all community > > members > > > > to > > > > vote as well. > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > Thanks & Regards > > > > > > > > > > > > > -- > > > Regards, > > > > > > *Shalitha Suranga* > > > > > > www.shalithasuranga.me > > > > > > -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, To move up the activity section in dashboard and profile I've modified the development.ini file. For the user profile, the section order was there but commented, so that I've uncommented the line. For the dashboard section order, I've added a similar line, but it doesn't work. (activity section is not moving up) Do you have any idea about this? I have committed my changes to the repo. ( https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/1955539543430eb71e56a995307135d258247b74/ ) Regards! On Thu, Aug 30, 2018 at 1:27 AM Dave Brondsema wrote: > Hi! > > I've merged that merge request, it looks good. I think the title text is > ok. > The layout of the logo runs into the main gray content though. It'd be > nice if > it had a bit of space like it does on the user profile page, for example. > I see > on the user profile page there is an empty > that > helps push it down. > > Another thing that could be polished is the placement of the Activity box > in the > right column. On both the dashboard and the profile pages it is part way > down > the column, and I think it'd be better at the top of the column. That > might be > fixable by CSS rules, but also by the ordering of the widgets. If it is > the > first widget then when it floats to the right its ok at the top of the > column. > So either by code, or .ini config file you could make it first in the > profile_sections.order and personal_dashboard_sections.order > > On 8/29/18 6:44 AM, Deshani Geethika wrote: > > Hi Dave, > > > > Sorry for the delays. I've done some fixes on dashboard styles and added > a > > merge request ( > > https://forge-allura.apache.org/p/allura/git/merge-requests/271/) > > Please review it and let me know if any improvements required. > > > > Also, for the dashboard title, currently it is shown as *username / > > Dashboard *(eg: Admin1 / Dashboard). Is it alright? Otherwise, do you > have > > a better idea for the dashboard title? > > > > Regards! > > > > On Fri, Jul 27, 2018 at 9:17 PM Deshani Geethika < > deshanigeeth...@gmail.com> > > wrote: > > > >> Thanks a lot. Will try these and let you know > >> > >> On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema > wrote: > >> > >>> Sure, here's some thoughts: > >>> > >>> Inheriting from TestGitRepo means it gets all the test_* functions, so > >>> when I > >>> ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we > >>> don't want > >>> to happen. So I'd remove that inheritance. You probably will have to > >>> duplicate > >>> the setup_with_tools() function in this file then. > >>> > >>> Actually, inheriting from _TestCase in > >>> forgegit/tests/functional/test_controllers.py might be a good option. > It > >>> has > >>> some setup functions you can use (so you don't have to duplicate > >>> setup_with_tools) and it doesn't have any test_* functions. > >>> > >>> The super() call is supposed to use its own name, like > >>> super(TestMergeRequestsSection, self).setUp() Not sure if that makes a > >>> difference here or not. > >>> > >>> merge_request() is a function but you don't have parenthesis on `mr= > >>> self.merge_request` so that function isn't running. > >>> > >>> I realized what happened earlier when I didn't see the "Tickets" > section > >>> in the > >>> HTML output of the tickets test! When I was trying this test now, I > got a > >>> similar situation where the "Merge Requests" section isn't in the HTML > >>> output at > >>> all either. So I looked in the 'test.log' file (where logging goes to > >>> during > >>> tests) and saw "Error rendering section MergeRequestsSection: ..." with > >>> error > >>> details. So these sections trap errors and log them, instead of > letting > >>> the > >>> whole page error. So looking at the test.log output can help see those > >>> errors > >>> when they happen. > >>> > >>> You may need to run ThreadLocalODMSession.flush_all() after creating > the > >>> merge > >>> request object. That is a common test pattern we have when tests > create > >>> something and then need to view it. (Mainly needed in tests, since > >>> regular web > >>> pages will flush at the end of each request). > >>> >
[allura:tickets] #8229 Personal Dashboard - Move activity section to the top in dashboard and profile
--- ** [tickets:#8229] Personal Dashboard - Move activity section to the top in dashboard and profile** **Status:** in-progress **Milestone:** unreleased **Created:** Sun Sep 16, 2018 05:55 PM UTC by Deshani **Last Updated:** Sun Sep 16, 2018 05:55 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8227 Personal Dashboard - Reduce ticket table columns
--- ** [tickets:#8227] Personal Dashboard - Reduce ticket table columns** **Status:** in-progress **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Fri Sep 07, 2018 04:08 PM UTC by Deshani **Last Updated:** Fri Sep 07, 2018 04:08 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: forge-allura update
Hi Dave, What you meant by "Created" column is "Created Date" right? On Fri, Sep 7, 2018 at 9:07 AM Shalitha Suranga wrote: > Hi.. > > Great,, Dashboard looks very useful. > > On Fri, Sep 7, 2018 at 8:07 AM Deshani Geethika > > wrote: > > > Yeah that's good. I'll do the modifications > > > > On Fri, Sep 7, 2018 at 3:27 AM Dave Brondsema > wrote: > > > > > I've updated https://forge-allura.apache.org/ to our latest code, > since > > it > > > hadn't been updated for many months. Also made a little script at > > > /allura-data/update-allura.sh on the server to make updating easier, > > > hopefully > > > will fully-automate it at some point. > > > > > > This includes all of Deshani's Google Summer of Code work on the > > > dashboard, so > > > we can see it in action! (I do notice my tickets table is too wide to > > fit, > > > though, maybe we can remove the Milestone and Created columns?) > > > > > > > > > -- > > > Dave Brondsema : d...@brondsema.net > > > http://www.brondsema.net : personal > > > http://www.splike.com : programming > > > <>< > > > > > > > > > -- > > *Deshani Geethika* > > Undergraduate at Department of Computer Science and Engineering > > Faculty of Engineering - University of Moratuwa Sri Lanka > > LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub > > <https://github.com/deshanigtk> | Mobile - +94776383034 > > > > > -- > Regards, > > *Shalitha Suranga Bsc. CS (UG)* > Director - Software Developer > PCL Marketing - Sri Lanka > www.pclmarketing.com > > +94 71 985 584 3 (Whatsapp/Viber), +94 77 42 750 65 > www.shalithasuranga.me > -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
Re: forge-allura update
Yeah that's good. I'll do the modifications On Fri, Sep 7, 2018 at 3:27 AM Dave Brondsema wrote: > I've updated https://forge-allura.apache.org/ to our latest code, since it > hadn't been updated for many months. Also made a little script at > /allura-data/update-allura.sh on the server to make updating easier, > hopefully > will fully-automate it at some point. > > This includes all of Deshani's Google Summer of Code work on the > dashboard, so > we can see it in action! (I do notice my tickets table is too wide to fit, > though, maybe we can remove the Milestone and Created columns?) > > > -- > Dave Brondsema : d...@brondsema.net > http://www.brondsema.net : personal > http://www.splike.com : programming > <>< > -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
[allura:tickets] #8226 Personal Dashboard - Fix dashboard logo
--- ** [tickets:#8226] Personal Dashboard - Fix dashboard logo** **Status:** in-progress **Milestone:** unreleased **Created:** Wed Sep 05, 2018 02:57 AM UTC by Deshani **Last Updated:** Wed Sep 05, 2018 02:57 AM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8223 Personal Dashboard - Add padding to tickets and merge_requests sections
- **status**: in-progress --> closed --- ** [tickets:#8223] Personal Dashboard - Add padding to tickets and merge_requests sections** **Status:** closed **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Wed Aug 29, 2018 10:20 AM UTC by Deshani **Last Updated:** Wed Aug 29, 2018 10:20 AM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, Sorry for the delays. I've done some fixes on dashboard styles and added a merge request ( https://forge-allura.apache.org/p/allura/git/merge-requests/271/) Please review it and let me know if any improvements required. Also, for the dashboard title, currently it is shown as *username / Dashboard *(eg: Admin1 / Dashboard). Is it alright? Otherwise, do you have a better idea for the dashboard title? Regards! On Fri, Jul 27, 2018 at 9:17 PM Deshani Geethika wrote: > Thanks a lot. Will try these and let you know > > On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema wrote: > >> Sure, here's some thoughts: >> >> Inheriting from TestGitRepo means it gets all the test_* functions, so >> when I >> ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we >> don't want >> to happen. So I'd remove that inheritance. You probably will have to >> duplicate >> the setup_with_tools() function in this file then. >> >> Actually, inheriting from _TestCase in >> forgegit/tests/functional/test_controllers.py might be a good option. It >> has >> some setup functions you can use (so you don't have to duplicate >> setup_with_tools) and it doesn't have any test_* functions. >> >> The super() call is supposed to use its own name, like >> super(TestMergeRequestsSection, self).setUp() Not sure if that makes a >> difference here or not. >> >> merge_request() is a function but you don't have parenthesis on `mr= >> self.merge_request` so that function isn't running. >> >> I realized what happened earlier when I didn't see the "Tickets" section >> in the >> HTML output of the tickets test! When I was trying this test now, I got a >> similar situation where the "Merge Requests" section isn't in the HTML >> output at >> all either. So I looked in the 'test.log' file (where logging goes to >> during >> tests) and saw "Error rendering section MergeRequestsSection: ..." with >> error >> details. So these sections trap errors and log them, instead of letting >> the >> whole page error. So looking at the test.log output can help see those >> errors >> when they happen. >> >> You may need to run ThreadLocalODMSession.flush_all() after creating the >> merge >> request object. That is a common test pattern we have when tests create >> something and then need to view it. (Mainly needed in tests, since >> regular web >> pages will flush at the end of each request). >> >> Hope that helps, let me know how far you get, and I can look at it some >> more if >> needed :) >> >> On 7/27/18 9:11 AM, Deshani Geethika wrote: >> > Hi Dave, >> > >> > I have started to write a test case for Merge Requests Section. For >> that I >> > have followed ForgeGit tests but it doesn't work for me. I was trying to >> > create a merge request and see whether it appears in dashboard. >> > >> > I've pushed the code into my fork >> > < >> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/ >> >. >> > Can you kindly take a look at that? Also, please let me know any >> debugging >> > process can be done for methods called internally when creating a merge >> > request. >> > >> > Regards! >> > >> > On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika < >> deshanigeeth...@gmail.com> >> > wrote: >> > >> >> Hi Dave, >> >> >> >> Thank you for sharing these valuable information. I have added a merge >> >> request < >> https://forge-allura.apache.org/p/allura/git/merge-requests/269/>. >> >> Please review it and let me know any further improvements. >> >> >> >> Regards! >> >> >> >> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema >> wrote: >> >> >> >>> On 7/16/18 9:49 AM, Deshani Geethika wrote: >> >>>> Hi Dave, >> >>>> >> >>>> I have tried with adding above lines, but still doesn't work. Can you >> >>> take >> >>>> a look at my implementation >> >>>> < >> >>> >> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/ >> >>>> >> >>>> ? >> >>>> >> >>>> Thanks! >> >>>> >> >>> >> >>> Here's some debugging process
[allura:tickets] #8223 Personal Dashboard - Add padding to tickets and merge_requests sections
--- ** [tickets:#8223] Personal Dashboard - Add padding to tickets and merge_requests sections** **Status:** in-progress **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Wed Aug 29, 2018 10:20 AM UTC by Deshani **Last Updated:** Wed Aug 29, 2018 10:20 AM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Thanks a lot. Will try these and let you know On Fri, Jul 27, 2018 at 8:52 PM Dave Brondsema wrote: > Sure, here's some thoughts: > > Inheriting from TestGitRepo means it gets all the test_* functions, so > when I > ran nosetests, it ran a lot of TestGitRepo.test_* tests too, which we > don't want > to happen. So I'd remove that inheritance. You probably will have to > duplicate > the setup_with_tools() function in this file then. > > Actually, inheriting from _TestCase in > forgegit/tests/functional/test_controllers.py might be a good option. It > has > some setup functions you can use (so you don't have to duplicate > setup_with_tools) and it doesn't have any test_* functions. > > The super() call is supposed to use its own name, like > super(TestMergeRequestsSection, self).setUp() Not sure if that makes a > difference here or not. > > merge_request() is a function but you don't have parenthesis on `mr= > self.merge_request` so that function isn't running. > > I realized what happened earlier when I didn't see the "Tickets" section > in the > HTML output of the tickets test! When I was trying this test now, I got a > similar situation where the "Merge Requests" section isn't in the HTML > output at > all either. So I looked in the 'test.log' file (where logging goes to > during > tests) and saw "Error rendering section MergeRequestsSection: ..." with > error > details. So these sections trap errors and log them, instead of letting > the > whole page error. So looking at the test.log output can help see those > errors > when they happen. > > You may need to run ThreadLocalODMSession.flush_all() after creating the > merge > request object. That is a common test pattern we have when tests create > something and then need to view it. (Mainly needed in tests, since > regular web > pages will flush at the end of each request). > > Hope that helps, let me know how far you get, and I can look at it some > more if > needed :) > > On 7/27/18 9:11 AM, Deshani Geethika wrote: > > Hi Dave, > > > > I have started to write a test case for Merge Requests Section. For that > I > > have followed ForgeGit tests but it doesn't work for me. I was trying to > > create a merge request and see whether it appears in dashboard. > > > > I've pushed the code into my fork > > < > https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/ > >. > > Can you kindly take a look at that? Also, please let me know any > debugging > > process can be done for methods called internally when creating a merge > > request. > > > > Regards! > > > > On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika < > deshanigeeth...@gmail.com> > > wrote: > > > >> Hi Dave, > >> > >> Thank you for sharing these valuable information. I have added a merge > >> request < > https://forge-allura.apache.org/p/allura/git/merge-requests/269/>. > >> Please review it and let me know any further improvements. > >> > >> Regards! > >> > >> On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema > wrote: > >> > >>> On 7/16/18 9:49 AM, Deshani Geethika wrote: > >>>> Hi Dave, > >>>> > >>>> I have tried with adding above lines, but still doesn't work. Can you > >>> take > >>>> a look at my implementation > >>>> < > >>> > https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/ > >>>> > >>>> ? > >>>> > >>>> Thanks! > >>>> > >>> > >>> Here's some debugging process I did, you can try it too: > >>> > >>> Tests use the MockSOLR class instead of a real solr instance (so that > you > >>> don't > >>> need solr to run tests). I knew that, so I started by going to > >>> MockSOLR.search() and putting in some print statements to debug it. At > >>> the > >>> beginning of search() I added: > >>> > >>> print q > >>> print fq > >>> > >>> And inside the "for obj in self.db.values():" loop, I added "print obj" > >>> > >>> My idea was to see what query is happening and what the stored objects > >>> are, and > >>> see what's not working. I ran just the single test with `nosetests > >>> > >>> > allura.tests.functional
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, I have started to write a test case for Merge Requests Section. For that I have followed ForgeGit tests but it doesn't work for me. I was trying to create a merge request and see whether it appears in dashboard. I've pushed the code into my fork <https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/96613c7854d116130455a343c814e853c2b5d812/>. Can you kindly take a look at that? Also, please let me know any debugging process can be done for methods called internally when creating a merge request. Regards! On Tue, Jul 17, 2018 at 11:19 PM Deshani Geethika wrote: > Hi Dave, > > Thank you for sharing these valuable information. I have added a merge > request <https://forge-allura.apache.org/p/allura/git/merge-requests/269/>. > Please review it and let me know any further improvements. > > Regards! > > On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema wrote: > >> On 7/16/18 9:49 AM, Deshani Geethika wrote: >> > Hi Dave, >> > >> > I have tried with adding above lines, but still doesn't work. Can you >> take >> > a look at my implementation >> > < >> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/ >> > >> > ? >> > >> > Thanks! >> > >> >> Here's some debugging process I did, you can try it too: >> >> Tests use the MockSOLR class instead of a real solr instance (so that you >> don't >> need solr to run tests). I knew that, so I started by going to >> MockSOLR.search() and putting in some print statements to debug it. At >> the >> beginning of search() I added: >> >> print q >> print fq >> >> And inside the "for obj in self.db.values():" loop, I added "print obj" >> >> My idea was to see what query is happening and what the stored objects >> are, and >> see what's not working. I ran just the single test with `nosetests >> >> allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section` >> I noticed there was a 'project_id_s' in the search query, and there >> shouldn't >> be. But after a bit of trial & error to see what was happening, I >> realized that >> was coming from a "update_bin_count" background task, and that wasn't >> related to >> the test really. >> >> So I commented-out the tasks M.MonQTask.run_ready() to avoid all the >> background >> tasks for now and did it again, and there wasn't any of my print >> statements >> occurring. So the dashboard ticket search wasn't even happening it seems. >> >> Then I printed the "response.html" variable to look at the whole >> dashboard page >> and I didn't see the Tickets section in it at all. So indeed, that >> section >> isn't included in this test at all for some reason. >> >> Hopefully those are some helpful examples for this particular situation >> and also >> ideas for how to debug high level (like "is it even running?") and low >> level (to >> see where things might be not working). >> >> Next step of course is to figure out why in this test the dashboard >> section >> isn't even running. I'll let you work on that. My general strategy is >> to put >> debugging in various places to confirm if things are running with the >> right >> values, or where they aren't, and narrow down to the spot where it goes >> wrong. >> >> >> -- >> Dave Brondsema : d...@brondsema.net >> http://www.brondsema.net : personal >> http://www.splike.com : programming >> <>< >> > > > -- > *Deshani Geethika* > Undergraduate at Department of Computer Science and Engineering > Faculty of Engineering - University of Moratuwa Sri Lanka > LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub > <https://github.com/deshanigtk> | Mobile - +94776383034 > > -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
[allura:tickets] #8220 Personal Dashboard - Create Tests for Merge Requests Section
--- ** [tickets:#8220] Personal Dashboard - Create Tests for Merge Requests Section** **Status:** in-progress **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Fri Jul 27, 2018 12:31 PM UTC by Deshani **Last Updated:** Fri Jul 27, 2018 12:31 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, Thank you for sharing these valuable information. I have added a merge request <https://forge-allura.apache.org/p/allura/git/merge-requests/269/>. Please review it and let me know any further improvements. Regards! On Mon, Jul 16, 2018 at 9:54 PM Dave Brondsema wrote: > On 7/16/18 9:49 AM, Deshani Geethika wrote: > > Hi Dave, > > > > I have tried with adding above lines, but still doesn't work. Can you > take > > a look at my implementation > > < > https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/ > > > > ? > > > > Thanks! > > > > Here's some debugging process I did, you can try it too: > > Tests use the MockSOLR class instead of a real solr instance (so that you > don't > need solr to run tests). I knew that, so I started by going to > MockSOLR.search() and putting in some print statements to debug it. At the > beginning of search() I added: > > print q > print fq > > And inside the "for obj in self.db.values():" loop, I added "print obj" > > My idea was to see what query is happening and what the stored objects > are, and > see what's not working. I ran just the single test with `nosetests > > allura.tests.functional.test_personal_dashboard:TestTicketsSection.test_tickets_section` > I noticed there was a 'project_id_s' in the search query, and there > shouldn't > be. But after a bit of trial & error to see what was happening, I > realized that > was coming from a "update_bin_count" background task, and that wasn't > related to > the test really. > > So I commented-out the tasks M.MonQTask.run_ready() to avoid all the > background > tasks for now and did it again, and there wasn't any of my print statements > occurring. So the dashboard ticket search wasn't even happening it seems. > > Then I printed the "response.html" variable to look at the whole dashboard > page > and I didn't see the Tickets section in it at all. So indeed, that section > isn't included in this test at all for some reason. > > Hopefully those are some helpful examples for this particular situation > and also > ideas for how to debug high level (like "is it even running?") and low > level (to > see where things might be not working). > > Next step of course is to figure out why in this test the dashboard section > isn't even running. I'll let you work on that. My general strategy is to > put > debugging in various places to confirm if things are running with the right > values, or where they aren't, and narrow down to the spot where it goes > wrong. > > > -- > Dave Brondsema : d...@brondsema.net > http://www.brondsema.net : personal > http://www.splike.com : programming > <>< > -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, I have tried with adding above lines, but still doesn't work. Can you take a look at my implementation <https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/a7ddd0c0bbcfe89cb14fc5214deff168cbb20477/> ? Thanks! On Fri, Jul 13, 2018 at 7:31 PM Dave Brondsema wrote: > My first thought is that it probably is not getting indexed in solr. That > runs > in a background task, so during tests it won't happen automatically. Try > adding > this: > > ThreadLocalORMSession.flush_all() > M.MonQTask.run_ready() > ThreadLocalORMSession.flush_all() > > The run_ready() call will run the background tasks that are queued up. The > flush_all() lines might not be necessary, but I see them in other tests. > You > can try with and without them. What they do is ensure all changes to > models are > flushed to mongo. > > Let me know if that doesn't help and I'll take a closer look. > > On 7/13/18 8:41 AM, Deshani Geethika wrote: > > Hi Dave, > > > > I have started to create a test case for Tickets Section. > > > > I was trying to create a new ticket and check whether it appears in > > Dashboard, but it doesn't work. It seems like I've done something wrong > > when creating new ticket. > > > > Could you kindly take a look at my implementation > > < > https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/56062d5c56aad503e022727b0dd5b67d37133b2e/ > > > > and help me to sort out the issue? > > > > Thanks! > > > > On Thu, Jul 12, 2018 at 10:04 PM Deshani Geethika < > deshanigeeth...@gmail.com> > > wrote: > > > >> Thanks. I'll start working on it and give you updates > >> > >> On Thu, Jul 12, 2018 at 8:57 PM Dave Brondsema > wrote: > >> > >>> I think it would be good to have a test of each of the sections. At > least > >>> tickets & merge requests. For projects and activity, they are very > >>> similar & > >>> re-use code from the profile sections. So you could either copy the > test > >>> structure and have very similar tests to the user profile tests, or > omit > >>> the > >>> tests for those. > >>> > >>> For tickets & merge requests I think good tests would create a few > >>> tickets (or > >>> merge requests) and then get the /dashboard URL and assert that they > >>> showed up. > >>> The ForgeTracker suite should have plenty of examples of making tickets > >>> without > >>> having to do mocking probably. To make a merge request, > >>> allura.tests.model.test_repo.TestMergeRequest has an abstract test that > >>> uses > >>> some mocking. It'd be better though to use a more real merge request > like > >>> ForgeGit's tests do. > >>> > >>> > >>> On 7/11/18 1:06 PM, Deshani Geethika wrote: > >>>> Hi Dave, > >>>> > >>>> I've created a test case for Dashboard sections and added a merge > >>> request > >>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/268/>. > >>> Please > >>>> review it and let me know if any improvements required. > >>>> > >>>> Also, could you let me know what are the other functionalities should > be > >>>> tested in Dashboard? > >>>> > >>>> Regards! > >>>> > >>>> On Sat, Jul 7, 2018 at 1:55 AM Dave Brondsema > >>> wrote: > >>>> > >>>>> Hi. > >>>>> > >>>>> On profile pages, the self.project refers to that user-project > >>> /u/brondsem > >>>>> for > >>>>> example. You can get a reference to the same project in the > dashboard > >>> with > >>>>> c.user.private_project() > >>>>> > >>>>> On another note, the title "My Followers" sounds like it would be > >>> people > >>>>> who > >>>>> follow me, which isn't correct. On profile pages (if you click to > view > >>>>> all) it > >>>>> says "Activity from people you follow" which is lengthy but better. > Or > >>>>> just > >>>>> "Activity" would be ok. > >>>>> > >>>>> -Dave > >>>>> > >>>>> On 7/6/18 3:13 PM, Deshani Geethika wrot
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave,
I have started to create a test case for Tickets Section.
I was trying to create a new ticket and check whether it appears in
Dashboard, but it doesn't work. It seems like I've done something wrong
when creating new ticket.
Could you kindly take a look at my implementation
<https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/56062d5c56aad503e022727b0dd5b67d37133b2e/>
and help me to sort out the issue?
Thanks!
On Thu, Jul 12, 2018 at 10:04 PM Deshani Geethika
wrote:
> Thanks. I'll start working on it and give you updates
>
> On Thu, Jul 12, 2018 at 8:57 PM Dave Brondsema wrote:
>
>> I think it would be good to have a test of each of the sections. At least
>> tickets & merge requests. For projects and activity, they are very
>> similar &
>> re-use code from the profile sections. So you could either copy the test
>> structure and have very similar tests to the user profile tests, or omit
>> the
>> tests for those.
>>
>> For tickets & merge requests I think good tests would create a few
>> tickets (or
>> merge requests) and then get the /dashboard URL and assert that they
>> showed up.
>> The ForgeTracker suite should have plenty of examples of making tickets
>> without
>> having to do mocking probably. To make a merge request,
>> allura.tests.model.test_repo.TestMergeRequest has an abstract test that
>> uses
>> some mocking. It'd be better though to use a more real merge request like
>> ForgeGit's tests do.
>>
>>
>> On 7/11/18 1:06 PM, Deshani Geethika wrote:
>> > Hi Dave,
>> >
>> > I've created a test case for Dashboard sections and added a merge
>> request
>> > <https://forge-allura.apache.org/p/allura/git/merge-requests/268/>.
>> Please
>> > review it and let me know if any improvements required.
>> >
>> > Also, could you let me know what are the other functionalities should be
>> > tested in Dashboard?
>> >
>> > Regards!
>> >
>> > On Sat, Jul 7, 2018 at 1:55 AM Dave Brondsema
>> wrote:
>> >
>> >> Hi.
>> >>
>> >> On profile pages, the self.project refers to that user-project
>> /u/brondsem
>> >> for
>> >> example. You can get a reference to the same project in the dashboard
>> with
>> >> c.user.private_project()
>> >>
>> >> On another note, the title "My Followers" sounds like it would be
>> people
>> >> who
>> >> follow me, which isn't correct. On profile pages (if you click to view
>> >> all) it
>> >> says "Activity from people you follow" which is lengthy but better. Or
>> >> just
>> >> "Activity" would be ok.
>> >>
>> >> -Dave
>> >>
>> >> On 7/6/18 3:13 PM, Deshani Geethika wrote:
>> >>> Hi Dave,
>> >>>
>> >>> I've started to work on Followers Section and pushed the current code
>> to
>> >> my
>> >>> fork. (
>> >>
>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/6522ff400387f1b1143d27cdd3afd1a63a811785/
>> >>> )
>> >>>
>> >>> I need to create activity_app instance in class FollowersSection in
>> >>> allura/ext/personal_dashboard/dashboard_main.py. (Line #163).
>> >>>
>> >>> In class ForgeActivityProfileSection which is in
>> forgeactivity/main.py,
>> >> the
>> >>> activity_app instance is created by accessing project instance as
>> >>> self.activity_app
>> >>> = self.project.app_instance('activity'). (Line #278)
>> >>>
>> >>> How can I create activity_app instance in dashboard without a project
>> >>> instance?
>> >>>
>> >>> Regards!
>> >>>
>> >>> On Mon, Jul 2, 2018 at 5:21 PM Deshani Geethika <
>> >> deshanigeeth...@gmail.com>
>> >>> wrote:
>> >>>
>> >>>> Hi Dave,
>> >>>>
>> >>>> I've completed the Tickets section and added a merge request
>> >>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/264/>
>> >>>>
>> >>>> Please review it and let me know if any improvements required.
>> >>>>
>> >>>> Regards!
>> >>>>
>> >>>> On Fri, Jun 29, 2018 at 8:48 PM Deshani Geethika <
>> >&
[allura:tickets] #8219 Personal Dashboard - Test Tickets section
- **summary**: Persona Dashboard - Test Tickets section --> Personal Dashboard - Test Tickets section --- ** [tickets:#8219] Personal Dashboard - Test Tickets section** **Status:** in-progress **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Fri Jul 13, 2018 12:00 PM UTC by Deshani **Last Updated:** Fri Jul 13, 2018 12:00 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8219 Persona Dashboard - Test Tickets section
--- ** [tickets:#8219] Persona Dashboard - Test Tickets section** **Status:** in-progress **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Fri Jul 13, 2018 12:00 PM UTC by Deshani **Last Updated:** Fri Jul 13, 2018 12:00 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8218 Personal Dashboard - Test Dashboard sections
- **status**: in-progress --> closed --- ** [tickets:#8218] Personal Dashboard - Test Dashboard sections** **Status:** closed **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Wed Jul 11, 2018 04:55 PM UTC by Deshani **Last Updated:** Wed Jul 11, 2018 04:55 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave,
I've created a test case for Dashboard sections and added a merge request
<https://forge-allura.apache.org/p/allura/git/merge-requests/268/>. Please
review it and let me know if any improvements required.
Also, could you let me know what are the other functionalities should be
tested in Dashboard?
Regards!
On Sat, Jul 7, 2018 at 1:55 AM Dave Brondsema wrote:
> Hi.
>
> On profile pages, the self.project refers to that user-project /u/brondsem
> for
> example. You can get a reference to the same project in the dashboard with
> c.user.private_project()
>
> On another note, the title "My Followers" sounds like it would be people
> who
> follow me, which isn't correct. On profile pages (if you click to view
> all) it
> says "Activity from people you follow" which is lengthy but better. Or
> just
> "Activity" would be ok.
>
> -Dave
>
> On 7/6/18 3:13 PM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > I've started to work on Followers Section and pushed the current code to
> my
> > fork. (
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/6522ff400387f1b1143d27cdd3afd1a63a811785/
> > )
> >
> > I need to create activity_app instance in class FollowersSection in
> > allura/ext/personal_dashboard/dashboard_main.py. (Line #163).
> >
> > In class ForgeActivityProfileSection which is in forgeactivity/main.py,
> the
> > activity_app instance is created by accessing project instance as
> > self.activity_app
> > = self.project.app_instance('activity'). (Line #278)
> >
> > How can I create activity_app instance in dashboard without a project
> > instance?
> >
> > Regards!
> >
> > On Mon, Jul 2, 2018 at 5:21 PM Deshani Geethika <
> deshanigeeth...@gmail.com>
> > wrote:
> >
> >> Hi Dave,
> >>
> >> I've completed the Tickets section and added a merge request
> >> <https://forge-allura.apache.org/p/allura/git/merge-requests/264/>
> >>
> >> Please review it and let me know if any improvements required.
> >>
> >> Regards!
> >>
> >> On Fri, Jun 29, 2018 at 8:48 PM Deshani Geethika <
> >> deshanigeeth...@gmail.com> wrote:
> >>
> >>> Hi Dave,
> >>>
> >>> Thanks. I'm still working on it. Will give you an update soon.
> >>>
> >>> Regards!
> >>>
> >>> On Fri, Jun 29, 2018 at 7:45 PM Dave Brondsema
> >>> wrote:
> >>>
> >>>> Hey Deshani,
> >>>>
> >>>> Just wondering how things are going? If you want to push your current
> >>>> branch,
> >>>> and let me know if any questions or issues, I can offer some more
> help.
> >>>>
> >>>> I am impressed with how much you've figured out on your own. I'm here
> >>>> to mentor
> >>>> and help though too :)
> >>>>
> >>>> -Dave
> >>>>
> >>>> On 6/27/18 12:07 AM, Deshani Geethika wrote:
> >>>>> Thanks. I'll be there today at 11am EDT.
> >>>>>
> >>>>> On Tue, Jun 26, 2018 at 9:18 PM Dave Brondsema >>>>> <mailto:d...@brondsema.net>> wrote:
> >>>>>
> >>>>> Thanks, I've taken a look at the code to get familiar with it and
> >>>> have some
> >>>>> ideas.
> >>>>>
> >>>>> Today I am available today much any time from now until 6pm EDT.
> >>>> Or tomorrow
> >>>>> 10:30-12:00 and 1pm-6pm EDT. What do you prefer? We can switch
> >>>> over to chat to
> >>>>> coordinate too.
> >>>>>
> >>>>>
> >>>>> On 6/26/18 4:04 AM, Deshani Geethika wrote:
> >>>>> > Hi Dave,
> >>>>> >
> >>>>> > I have pushed the current code into my fork.
> >>>>> >
> >>>>> (
> >>>>
> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/0fe5a7d86e06283801cc7c21df70ba4dfa15927b/
> >>>> )
> >>>>> >
> >>>>> > Please let me know a convenient slot to have a call.
> >>>>> >
> >>>>> > Regards!
> >>>>> >
> >>>>> > On Tue, Jun 26, 2018 at 6:49 AM
[allura:tickets] #8218 Personal Dashboard - Test Dashboard sections
--- ** [tickets:#8218] Personal Dashboard - Test Dashboard sections** **Status:** in-progress **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Wed Jul 11, 2018 04:55 PM UTC by Deshani **Last Updated:** Wed Jul 11, 2018 04:55 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8216 Personal Dashboard - Create Activity Section
- **summary**: Personal Dashboard - Create Followers Section --> Personal Dashboard - Create Activity Section --- ** [tickets:#8216] Personal Dashboard - Create Activity Section** **Status:** open **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Fri Jul 06, 2018 06:52 PM UTC by Deshani **Last Updated:** Fri Jul 06, 2018 06:52 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave,
I've started to work on Followers Section and pushed the current code to my
fork.
(https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/6522ff400387f1b1143d27cdd3afd1a63a811785/
)
I need to create activity_app instance in class FollowersSection in
allura/ext/personal_dashboard/dashboard_main.py. (Line #163).
In class ForgeActivityProfileSection which is in forgeactivity/main.py, the
activity_app instance is created by accessing project instance as
self.activity_app
= self.project.app_instance('activity'). (Line #278)
How can I create activity_app instance in dashboard without a project
instance?
Regards!
On Mon, Jul 2, 2018 at 5:21 PM Deshani Geethika
wrote:
> Hi Dave,
>
> I've completed the Tickets section and added a merge request
> <https://forge-allura.apache.org/p/allura/git/merge-requests/264/>
>
> Please review it and let me know if any improvements required.
>
> Regards!
>
> On Fri, Jun 29, 2018 at 8:48 PM Deshani Geethika <
> deshanigeeth...@gmail.com> wrote:
>
>> Hi Dave,
>>
>> Thanks. I'm still working on it. Will give you an update soon.
>>
>> Regards!
>>
>> On Fri, Jun 29, 2018 at 7:45 PM Dave Brondsema
>> wrote:
>>
>>> Hey Deshani,
>>>
>>> Just wondering how things are going? If you want to push your current
>>> branch,
>>> and let me know if any questions or issues, I can offer some more help.
>>>
>>> I am impressed with how much you've figured out on your own. I'm here
>>> to mentor
>>> and help though too :)
>>>
>>> -Dave
>>>
>>> On 6/27/18 12:07 AM, Deshani Geethika wrote:
>>> > Thanks. I'll be there today at 11am EDT.
>>> >
>>> > On Tue, Jun 26, 2018 at 9:18 PM Dave Brondsema >> > <mailto:d...@brondsema.net>> wrote:
>>> >
>>> > Thanks, I've taken a look at the code to get familiar with it and
>>> have some
>>> > ideas.
>>> >
>>> > Today I am available today much any time from now until 6pm EDT.
>>> Or tomorrow
>>> > 10:30-12:00 and 1pm-6pm EDT. What do you prefer? We can switch
>>> over to chat to
>>> > coordinate too.
>>> >
>>> >
>>> > On 6/26/18 4:04 AM, Deshani Geethika wrote:
>>> > > Hi Dave,
>>> > >
>>> > > I have pushed the current code into my fork.
>>> > >
>>> > (
>>> https://forge-allura.apache.org/u/deshani/allura-personal-dashboard/ci/0fe5a7d86e06283801cc7c21df70ba4dfa15927b/
>>> )
>>> > >
>>> > > Please let me know a convenient slot to have a call.
>>> > >
>>> > > Regards!
>>> > >
>>> > > On Tue, Jun 26, 2018 at 6:49 AM Dave Brondsema <
>>> d...@brondsema.net
>>> > <mailto:d...@brondsema.net>
>>> > > <mailto:d...@brondsema.net <mailto:d...@brondsema.net>>> wrote:
>>> > >
>>> > > Hey Deshani, do you want to do another video call? If you
>>> want to
>>> > push your
>>> > > current code to a branch then I could take a look at it too,
>>> and
>>> > understand what
>>> > > you have so far. Then we could do a video/screenshare call,
>>> continue with
>>> > > emails, or do chats. Whatever you prefer.
>>> > >
>>> > > -Dave
>>> > >
>>> > >
>>> > >
>>> > > --
>>> > > *Deshani Geethika*
>>> > > Undergraduate at Department of Computer Science and Engineering
>>> > > Faculty of Engineering - University of Moratuwa Sri Lanka
>>> > > LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
>>> > > <https://github.com/deshanigtk> | Mobile - +94776383034
>>> > >
>>> >
>>> >
>>> >
>>> > --
>>> > Dave Brondsema : d...@brondsema.net <mailto:d...@brondsema.net>
>>> > http://www.brondsema.net : personal
>>> > http://www.splike.com : programming
>>> > <><
>>> >
>>> >
>>> >
>>> > --
>>> > *Deshani Geethika*
>>> > Undergraduate at Department of Computer Science and Engineering
>>> > Faculty
[allura:tickets] #8216 Personal Dashboard - Create Followers Section
--- ** [tickets:#8216] Personal Dashboard - Create Followers Section** **Status:** open **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Fri Jul 06, 2018 06:52 PM UTC by Deshani **Last Updated:** Fri Jul 06, 2018 06:52 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, I've modified the paged_search method and now it is working for dashboard too. But I have some confusions how to call this method to load tickets to UI. Could you help me to sort this out? Regards! On Fri, Jun 22, 2018 at 8:08 AM Deshani Geethika wrote: > Thanks a lot. Will give a try and let you know > > On Thu, Jun 21, 2018 at 11:36 PM Dave Brondsema > wrote: > >> Sounds good, pagination is definitely important if people have a lot of >> tickets. >> In the ForgeTracker tool forgetracker/model/ticket.py there are methods >> paged_search() and paged_query() which might be good reference points. >> It looks >> like they probably can't be re-used directly, since they expect an >> app_config, >> and the dashboard will search across all ticket tracker apps. It also >> supports >> filtering and search terms that aren't needed. But it might be useful. >> >> There's other things in the ForgeTracker that might be useful too. Like >> listing >> the results with the TicketSearchResults class and >> ticket_search_results.html >> template. Again, those have things like filtering, configurable columns, >> etc >> that aren't necessary on the dashboard. But it could be a good reference >> for >> how paging is used, etc. >> >> I would recommend using a solr search rather than a mongo query to find >> the >> tickets. That is because the Ticket class does not have a mongo index >> for the >> submitter, and so querying by submitter could be very slow when there are >> thousands and thousands of tickets. Searching with solr also would also >> let us >> support people filtering & searching their own tickets list, in the >> future if we >> wanted to do that (not necessary this summer). >> >> On 6/21/18 12:11 PM, Deshani Geethika wrote: >> > Hi Dave, >> > >> > Currently I'm working on creating "Tickets Section" of Dashboard. I have >> > implemented to load all of the tickets at once, but I thought to >> paginate >> > this and I'm working on it. >> > >> > Will give you an update soon. If you have any suggestions please let me >> > know. >> > >> > Regards! >> > >> > On Thu, Jun 14, 2018 at 12:22 AM Deshani Geethika < >> deshanigeeth...@gmail.com> >> > wrote: >> > >> >> Hi Dave, >> >> >> >> Thanks for reviewing and merging the above requests. >> >> >> >> I've created a helper method to avoid code duplication in >> >> DashboardController.index and UserProfileApp.profile_sections, and >> added a merge >> >> request < >> https://forge-allura.apache.org/p/allura/git/merge-requests/259/> >> >> . >> >> >> >> Please review it and let me know if any improvements required. >> >> >> >> Regards! >> >> >> >> On Tue, Jun 12, 2018 at 1:20 AM Deshani Geethika < >> >> deshanigeeth...@gmail.com> wrote: >> >> >> >>> Hi Dave, >> >>> >> >>> I've updated the above merge request >> >>> <https://forge-allura.apache.org/p/allura/git/merge-requests/255/>, >> as >> >>> I've fixed an issue in a template. >> >>> >> >>> Meanwhile, I started a new branch for dashboard tests and added a >> simple >> >>> test to check '/dashboard' route. I've created a new merge request >> >>> <https://forge-allura.apache.org/p/allura/git/merge-requests/258/> >> for >> >>> this. Please review it and let me know if any improvements required. >> >>> >> >>> Regards! >> >>> >> >>> On Sat, Jun 9, 2018 at 12:07 PM Deshani Geethika < >> >>> deshanigeeth...@gmail.com> wrote: >> >>> >> >>>> Hi Dave, >> >>>> >> >>>> Thanks for the clarifications :) >> >>>> >> >>>> I've fixed the issues with test cases and updated the merge request >> >>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/255/>. >> >>>> Please review it and let me know if any improvements required >> >>>> >> >>>> Regards! >> >>>> >> >>>> On Wed, Jun 6, 2018 at 8:56 PM Dave Brondsema >> >>>> wrote: >> >>>> >> >>>>> On 6/6/18 5:37 AM, Deshani Geethika wrote: >> >>>>>
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Thanks a lot. Will give a try and let you know
On Thu, Jun 21, 2018 at 11:36 PM Dave Brondsema wrote:
> Sounds good, pagination is definitely important if people have a lot of
> tickets.
> In the ForgeTracker tool forgetracker/model/ticket.py there are methods
> paged_search() and paged_query() which might be good reference points. It
> looks
> like they probably can't be re-used directly, since they expect an
> app_config,
> and the dashboard will search across all ticket tracker apps. It also
> supports
> filtering and search terms that aren't needed. But it might be useful.
>
> There's other things in the ForgeTracker that might be useful too. Like
> listing
> the results with the TicketSearchResults class and
> ticket_search_results.html
> template. Again, those have things like filtering, configurable columns,
> etc
> that aren't necessary on the dashboard. But it could be a good reference
> for
> how paging is used, etc.
>
> I would recommend using a solr search rather than a mongo query to find the
> tickets. That is because the Ticket class does not have a mongo index for
> the
> submitter, and so querying by submitter could be very slow when there are
> thousands and thousands of tickets. Searching with solr also would also
> let us
> support people filtering & searching their own tickets list, in the future
> if we
> wanted to do that (not necessary this summer).
>
> On 6/21/18 12:11 PM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > Currently I'm working on creating "Tickets Section" of Dashboard. I have
> > implemented to load all of the tickets at once, but I thought to paginate
> > this and I'm working on it.
> >
> > Will give you an update soon. If you have any suggestions please let me
> > know.
> >
> > Regards!
> >
> > On Thu, Jun 14, 2018 at 12:22 AM Deshani Geethika <
> deshanigeeth...@gmail.com>
> > wrote:
> >
> >> Hi Dave,
> >>
> >> Thanks for reviewing and merging the above requests.
> >>
> >> I've created a helper method to avoid code duplication in
> >> DashboardController.index and UserProfileApp.profile_sections, and
> added a merge
> >> request <
> https://forge-allura.apache.org/p/allura/git/merge-requests/259/>
> >> .
> >>
> >> Please review it and let me know if any improvements required.
> >>
> >> Regards!
> >>
> >> On Tue, Jun 12, 2018 at 1:20 AM Deshani Geethika <
> >> deshanigeeth...@gmail.com> wrote:
> >>
> >>> Hi Dave,
> >>>
> >>> I've updated the above merge request
> >>> <https://forge-allura.apache.org/p/allura/git/merge-requests/255/>, as
> >>> I've fixed an issue in a template.
> >>>
> >>> Meanwhile, I started a new branch for dashboard tests and added a
> simple
> >>> test to check '/dashboard' route. I've created a new merge request
> >>> <https://forge-allura.apache.org/p/allura/git/merge-requests/258/> for
> >>> this. Please review it and let me know if any improvements required.
> >>>
> >>> Regards!
> >>>
> >>> On Sat, Jun 9, 2018 at 12:07 PM Deshani Geethika <
> >>> deshanigeeth...@gmail.com> wrote:
> >>>
> >>>> Hi Dave,
> >>>>
> >>>> Thanks for the clarifications :)
> >>>>
> >>>> I've fixed the issues with test cases and updated the merge request
> >>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/255/>.
> >>>> Please review it and let me know if any improvements required
> >>>>
> >>>> Regards!
> >>>>
> >>>> On Wed, Jun 6, 2018 at 8:56 PM Dave Brondsema
> >>>> wrote:
> >>>>
> >>>>> On 6/6/18 5:37 AM, Deshani Geethika wrote:
> >>>>>> Hi Dave,
> >>>>>>
> >>>>>> I need some help in understanding an error related to test cases.
> >>>>>>
> >>>>>> I was trying to write a test case to check the '/neighborhood' route
> >>>>> in
> >>>>>> Allura/allura/tests/functional/test_root.py as below.
> >>>>>>
> >>>>>> def test_neighborhood(self):
> >>>>>>> response = self.app.get('/neighborhood/')
> >>>>>>
> >>>>>>
> >>>>>> But I get the following error, when I run the above test case.
&
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave,
Currently I'm working on creating "Tickets Section" of Dashboard. I have
implemented to load all of the tickets at once, but I thought to paginate
this and I'm working on it.
Will give you an update soon. If you have any suggestions please let me
know.
Regards!
On Thu, Jun 14, 2018 at 12:22 AM Deshani Geethika
wrote:
> Hi Dave,
>
> Thanks for reviewing and merging the above requests.
>
> I've created a helper method to avoid code duplication in
> DashboardController.index and UserProfileApp.profile_sections, and added a
> merge
> request <https://forge-allura.apache.org/p/allura/git/merge-requests/259/>
> .
>
> Please review it and let me know if any improvements required.
>
> Regards!
>
> On Tue, Jun 12, 2018 at 1:20 AM Deshani Geethika <
> deshanigeeth...@gmail.com> wrote:
>
>> Hi Dave,
>>
>> I've updated the above merge request
>> <https://forge-allura.apache.org/p/allura/git/merge-requests/255/>, as
>> I've fixed an issue in a template.
>>
>> Meanwhile, I started a new branch for dashboard tests and added a simple
>> test to check '/dashboard' route. I've created a new merge request
>> <https://forge-allura.apache.org/p/allura/git/merge-requests/258/> for
>> this. Please review it and let me know if any improvements required.
>>
>> Regards!
>>
>> On Sat, Jun 9, 2018 at 12:07 PM Deshani Geethika <
>> deshanigeeth...@gmail.com> wrote:
>>
>>> Hi Dave,
>>>
>>> Thanks for the clarifications :)
>>>
>>> I've fixed the issues with test cases and updated the merge request
>>> <https://forge-allura.apache.org/p/allura/git/merge-requests/255/>.
>>> Please review it and let me know if any improvements required
>>>
>>> Regards!
>>>
>>> On Wed, Jun 6, 2018 at 8:56 PM Dave Brondsema
>>> wrote:
>>>
>>>> On 6/6/18 5:37 AM, Deshani Geethika wrote:
>>>> > Hi Dave,
>>>> >
>>>> > I need some help in understanding an error related to test cases.
>>>> >
>>>> > I was trying to write a test case to check the '/neighborhood' route
>>>> in
>>>> > Allura/allura/tests/functional/test_root.py as below.
>>>> >
>>>> > def test_neighborhood(self):
>>>> >> response = self.app.get('/neighborhood/')
>>>> >
>>>> >
>>>> > But I get the following error, when I run the above test case.
>>>> >
>>>> > Traceback (most recent call last):
>>>> >> File
>>>> >>
>>>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/nose/case.py",
>>>> >> line 197, in runTest
>>>> >> self.test(*self.arg)
>>>> >> File
>>>> >>
>>>> "/home/deshani/src/allura/Allura/allura/tests/functional/test_root.py",
>>>> >> line 58, in test_neighborhood
>>>> >> response = self.app.get('/neighborhood/')
>>>> >> File
>>>> "/home/deshani/src/allura/AlluraTest/alluratest/validation.py",
>>>> >> line 322, in get
>>>> >> resp = super(ValidatingTestApp, self).get(*args, **kw)
>>>> >> File
>>>> "/home/deshani/src/allura/AlluraTest/alluratest/validation.py",
>>>> >> line 269, in get
>>>> >> return super(PostParamCheckingTestApp, self).get(*args, **kwargs)
>>>> >> File
>>>> >>
>>>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
>>>> >> line 756, in get
>>>> >> expect_errors=expect_errors)
>>>> >> File
>>>> >>
>>>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
>>>> >> line 1118, in do_request
>>>> >> self._check_status(status, res)
>>>> >> File
>>>> >>
>>>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
>>>> >> line 1154, in _check_status
>>>> >> res)
>>>> >> AppError: Bad response: 404 Not Found (not 200 OK or 3xx redirect for
>>>> >> http://localhost/neighborhood/)
>>>> >
>>>> >
>>>> > Can you help me to understand why this error comes up?
>>>> >
>>>> > Regar
[allura:tickets] #8209 Personal Dashboard - Create Tickets section
- **summary**: Personal Dashboard - Creates Tickets section --> Personal Dashboard - Create Tickets section --- ** [tickets:#8209] Personal Dashboard - Create Tickets section** **Status:** in-progress **Milestone:** unreleased **Created:** Wed Jun 20, 2018 07:38 PM UTC by Deshani **Last Updated:** Wed Jun 20, 2018 07:38 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8209 Personal Dashboard - Creates Tickets section
--- ** [tickets:#8209] Personal Dashboard - Creates Tickets section** **Status:** in-progress **Milestone:** unreleased **Created:** Wed Jun 20, 2018 07:38 PM UTC by Deshani **Last Updated:** Wed Jun 20, 2018 07:38 PM UTC **Owner:** Deshani --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8208 Personal Dashboard - Create Projects section
--- ** [tickets:#8208] Personal Dashboard - Create Projects section** **Status:** in-progress **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Sun Jun 17, 2018 05:03 PM UTC by Deshani **Last Updated:** Sun Jun 17, 2018 05:03 PM UTC **Owner:** Deshani Implement the Projects section of Dashboard --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8207 Personal Dashboard - Add parent class for ProfileSectionBase and DashboardSectionBase
--- ** [tickets:#8207] Personal Dashboard - Add parent class for ProfileSectionBase and DashboardSectionBase ** **Status:** open **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Fri Jun 15, 2018 06:53 PM UTC by Deshani **Last Updated:** Fri Jun 15, 2018 06:53 PM UTC **Owner:** Deshani To avoid code duplication in ProfileSectionBase and DashboardSectionBase, parent class is added. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave,
Thanks for reviewing and merging the above requests.
I've created a helper method to avoid code duplication in
DashboardController.index and UserProfileApp.profile_sections, and
added a merge
request <https://forge-allura.apache.org/p/allura/git/merge-requests/259/>.
Please review it and let me know if any improvements required.
Regards!
On Tue, Jun 12, 2018 at 1:20 AM Deshani Geethika
wrote:
> Hi Dave,
>
> I've updated the above merge request
> <https://forge-allura.apache.org/p/allura/git/merge-requests/255/>, as
> I've fixed an issue in a template.
>
> Meanwhile, I started a new branch for dashboard tests and added a simple
> test to check '/dashboard' route. I've created a new merge request
> <https://forge-allura.apache.org/p/allura/git/merge-requests/258/> for
> this. Please review it and let me know if any improvements required.
>
> Regards!
>
> On Sat, Jun 9, 2018 at 12:07 PM Deshani Geethika <
> deshanigeeth...@gmail.com> wrote:
>
>> Hi Dave,
>>
>> Thanks for the clarifications :)
>>
>> I've fixed the issues with test cases and updated the merge request
>> <https://forge-allura.apache.org/p/allura/git/merge-requests/255/>.
>> Please review it and let me know if any improvements required
>>
>> Regards!
>>
>> On Wed, Jun 6, 2018 at 8:56 PM Dave Brondsema wrote:
>>
>>> On 6/6/18 5:37 AM, Deshani Geethika wrote:
>>> > Hi Dave,
>>> >
>>> > I need some help in understanding an error related to test cases.
>>> >
>>> > I was trying to write a test case to check the '/neighborhood' route in
>>> > Allura/allura/tests/functional/test_root.py as below.
>>> >
>>> > def test_neighborhood(self):
>>> >> response = self.app.get('/neighborhood/')
>>> >
>>> >
>>> > But I get the following error, when I run the above test case.
>>> >
>>> > Traceback (most recent call last):
>>> >> File
>>> >>
>>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/nose/case.py",
>>> >> line 197, in runTest
>>> >> self.test(*self.arg)
>>> >> File
>>> >>
>>> "/home/deshani/src/allura/Allura/allura/tests/functional/test_root.py",
>>> >> line 58, in test_neighborhood
>>> >> response = self.app.get('/neighborhood/')
>>> >> File "/home/deshani/src/allura/AlluraTest/alluratest/validation.py",
>>> >> line 322, in get
>>> >> resp = super(ValidatingTestApp, self).get(*args, **kw)
>>> >> File "/home/deshani/src/allura/AlluraTest/alluratest/validation.py",
>>> >> line 269, in get
>>> >> return super(PostParamCheckingTestApp, self).get(*args, **kwargs)
>>> >> File
>>> >>
>>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
>>> >> line 756, in get
>>> >> expect_errors=expect_errors)
>>> >> File
>>> >>
>>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
>>> >> line 1118, in do_request
>>> >> self._check_status(status, res)
>>> >> File
>>> >>
>>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
>>> >> line 1154, in _check_status
>>> >> res)
>>> >> AppError: Bad response: 404 Not Found (not 200 OK or 3xx redirect for
>>> >> http://localhost/neighborhood/)
>>> >
>>> >
>>> > Can you help me to understand why this error comes up?
>>> >
>>> > Regards!
>>>
>>>
>>> Wow, this was a tricky one! I was stumped about this for a while too.
>>> Its
>>> happening because of some helper code for tests, that is not very
>>> obvious. In
>>> Allura/allura/controllers/basetest_project_root.py a modified root
>>> controller is
>>> used for tests, which makes some project & tool testing easier. This
>>> controller
>>> is used because test.ini specifies "override_root=basetest_project_root"
>>>
>>> And then in this controller on line 71 there is a list of root controller
>>> attributes that is hardcoded. So you will have to add 'neighborhood' and
>>> 'dashboard' to that list.
>>>
>>> I would also recommend adding a comment on the
[allura:tickets] #8206 Personal Dashboard - Add helper method to load sections of Dashboard and Profile
--- ** [tickets:#8206] Personal Dashboard - Add helper method to load sections of Dashboard and Profile** **Status:** open **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Wed Jun 13, 2018 06:32 PM UTC by Deshani **Last Updated:** Wed Jun 13, 2018 06:32 PM UTC **Owner:** Deshani A helper method to avoid code duplication in DashboardController.index and UserProfileApp.profile_sections --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave,
I've updated the above merge request
<https://forge-allura.apache.org/p/allura/git/merge-requests/255/>, as I've
fixed an issue in a template.
Meanwhile, I started a new branch for dashboard tests and added a simple
test to check '/dashboard' route. I've created a new merge request
<https://forge-allura.apache.org/p/allura/git/merge-requests/258/> for
this. Please review it and let me know if any improvements required.
Regards!
On Sat, Jun 9, 2018 at 12:07 PM Deshani Geethika
wrote:
> Hi Dave,
>
> Thanks for the clarifications :)
>
> I've fixed the issues with test cases and updated the merge request
> <https://forge-allura.apache.org/p/allura/git/merge-requests/255/>.
> Please review it and let me know if any improvements required
>
> Regards!
>
> On Wed, Jun 6, 2018 at 8:56 PM Dave Brondsema wrote:
>
>> On 6/6/18 5:37 AM, Deshani Geethika wrote:
>> > Hi Dave,
>> >
>> > I need some help in understanding an error related to test cases.
>> >
>> > I was trying to write a test case to check the '/neighborhood' route in
>> > Allura/allura/tests/functional/test_root.py as below.
>> >
>> > def test_neighborhood(self):
>> >> response = self.app.get('/neighborhood/')
>> >
>> >
>> > But I get the following error, when I run the above test case.
>> >
>> > Traceback (most recent call last):
>> >> File
>> >>
>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/nose/case.py",
>> >> line 197, in runTest
>> >> self.test(*self.arg)
>> >> File
>> >> "/home/deshani/src/allura/Allura/allura/tests/functional/test_root.py",
>> >> line 58, in test_neighborhood
>> >> response = self.app.get('/neighborhood/')
>> >> File "/home/deshani/src/allura/AlluraTest/alluratest/validation.py",
>> >> line 322, in get
>> >> resp = super(ValidatingTestApp, self).get(*args, **kw)
>> >> File "/home/deshani/src/allura/AlluraTest/alluratest/validation.py",
>> >> line 269, in get
>> >> return super(PostParamCheckingTestApp, self).get(*args, **kwargs)
>> >> File
>> >>
>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
>> >> line 756, in get
>> >> expect_errors=expect_errors)
>> >> File
>> >>
>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
>> >> line 1118, in do_request
>> >> self._check_status(status, res)
>> >> File
>> >>
>> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
>> >> line 1154, in _check_status
>> >> res)
>> >> AppError: Bad response: 404 Not Found (not 200 OK or 3xx redirect for
>> >> http://localhost/neighborhood/)
>> >
>> >
>> > Can you help me to understand why this error comes up?
>> >
>> > Regards!
>>
>>
>> Wow, this was a tricky one! I was stumped about this for a while too.
>> Its
>> happening because of some helper code for tests, that is not very
>> obvious. In
>> Allura/allura/controllers/basetest_project_root.py a modified root
>> controller is
>> used for tests, which makes some project & tool testing easier. This
>> controller
>> is used because test.ini specifies "override_root=basetest_project_root"
>>
>> And then in this controller on line 71 there is a list of root controller
>> attributes that is hardcoded. So you will have to add 'neighborhood' and
>> 'dashboard' to that list.
>>
>> I would also recommend adding a comment on the real RootController
>> mentioning
>> the BasetestProjectRootController so that anyone else in the future who
>> adds a
>> root url knows that they have to update the other place too.
>>
>>
>>
>> --
>> Dave Brondsema : d...@brondsema.net
>> http://www.brondsema.net : personal
>> http://www.splike.com : programming
>> <><
>>
>
>
> --
> *Deshani Geethika*
> Undergraduate at Department of Computer Science and Engineering
> Faculty of Engineering - University of Moratuwa Sri Lanka
> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> <https://github.com/deshanigtk> | Mobile - +94776383034
>
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
[allura:tickets] #8205 Personal Dashboard - Add test functionality for Dashboard basics
--- ** [tickets:#8205] Personal Dashboard - Add test functionality for Dashboard basics** **Status:** open **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Mon Jun 11, 2018 07:23 PM UTC by Deshani **Last Updated:** Mon Jun 11, 2018 07:23 PM UTC **Owner:** Deshani Adds test functionality to check the '/dashboard' route. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave,
I need some help in understanding an error related to test cases.
I was trying to write a test case to check the '/neighborhood' route in
Allura/allura/tests/functional/test_root.py as below.
def test_neighborhood(self):
> response = self.app.get('/neighborhood/')
But I get the following error, when I run the above test case.
Traceback (most recent call last):
> File
> "/home/deshani/env-allura/local/lib/python2.7/site-packages/nose/case.py",
> line 197, in runTest
> self.test(*self.arg)
> File
> "/home/deshani/src/allura/Allura/allura/tests/functional/test_root.py",
> line 58, in test_neighborhood
> response = self.app.get('/neighborhood/')
> File "/home/deshani/src/allura/AlluraTest/alluratest/validation.py",
> line 322, in get
> resp = super(ValidatingTestApp, self).get(*args, **kw)
> File "/home/deshani/src/allura/AlluraTest/alluratest/validation.py",
> line 269, in get
> return super(PostParamCheckingTestApp, self).get(*args, **kwargs)
> File
> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
> line 756, in get
> expect_errors=expect_errors)
> File
> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
> line 1118, in do_request
> self._check_status(status, res)
> File
> "/home/deshani/env-allura/local/lib/python2.7/site-packages/webtest/app.py",
> line 1154, in _check_status
> res)
> AppError: Bad response: 404 Not Found (not 200 OK or 3xx redirect for
> http://localhost/neighborhood/)
Can you help me to understand why this error comes up?
Regards!
On Wed, May 30, 2018 at 8:37 PM Deshani Geethika
wrote:
> Hi Dave,
>
> I've added the first merge request for Personal Dashboard. Please review
> it and let me know any improvements.
>
> Merge Request:
> https://forge-allura.apache.org/p/allura/git/merge-requests/255/
>
> Regards!
>
> On Wed, May 30, 2018 at 12:14 AM Dave Brondsema
> wrote:
>
>> On 5/28/18 4:12 AM, Deshani Geethika wrote:
>> > Hi Dave,
>> >
>> > During last week I focused on learning frameworks and basics related to
>> > Allura and now I’m ready to add the first merge request of Personal
>> > Dashboard. When adding the merge request, should it be added to the
>> master
>> > branch of the remote?
>> >
>> > Regards!
>> >
>>
>> I would recommend making a new branch for each task you work on. That
>> way you
>> can have multiple going at the same time, if they are not dependent on
>> each other.
>>
>> That will also let you keep master in sync with upstream master, and not
>> have
>> local changes in it.
>>
>>
>> --
>> Dave Brondsema : d...@brondsema.net
>> http://www.brondsema.net : personal
>> http://www.splike.com : programming
>> <><
>>
>
>
> --
> *Deshani Geethika*
> Undergraduate at Department of Computer Science and Engineering
> Faculty of Engineering - University of Moratuwa Sri Lanka
> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> <https://github.com/deshanigtk> | Mobile - +94776383034
>
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, I've added the first merge request for Personal Dashboard. Please review it and let me know any improvements. Merge Request: https://forge-allura.apache.org/p/allura/git/merge-requests/255/ Regards! On Wed, May 30, 2018 at 12:14 AM Dave Brondsema wrote: > On 5/28/18 4:12 AM, Deshani Geethika wrote: > > Hi Dave, > > > > During last week I focused on learning frameworks and basics related to > > Allura and now I’m ready to add the first merge request of Personal > > Dashboard. When adding the merge request, should it be added to the > master > > branch of the remote? > > > > Regards! > > > > I would recommend making a new branch for each task you work on. That way > you > can have multiple going at the same time, if they are not dependent on > each other. > > That will also let you keep master in sync with upstream master, and not > have > local changes in it. > > > -- > Dave Brondsema : d...@brondsema.net > http://www.brondsema.net : personal > http://www.splike.com : programming > <>< > -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
[allura:tickets] #8202 Personal Dashboard - Creating basics of Dashboard (Creating file structure, defining routes and loading sections to main UI)
--- ** [tickets:#8202] Personal Dashboard - Creating basics of Dashboard (Creating file structure, defining routes and loading sections to main UI)** **Status:** open **Milestone:** unreleased **Labels:** Personal Dashboard **Created:** Mon May 28, 2018 08:18 AM UTC by Deshani **Last Updated:** Mon May 28, 2018 08:18 AM UTC **Owner:** Deshani In this ticket following features are created. 1. Creating the folder and file structure 2. Creating separate routes for ‘neighborhood’ and ‘dashboard’. Here when a user logged in, redirected to Dashboard (‘/dashboard’). If not logged in, redirected to Neighborhood (‘/neighborhood’). However, I didn’t block ‘/neighborhood’ route for a logged in user. (That means by default, when the user is logged in, Dashboard (‘/dashboard’) will be the landing page. Also, he can call Neighborhood route (‘/neighborhood’) manually) 3. Loading sections (eg: ProjectsSection, TicketsSection etc.) to the main UI. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, During last week I focused on learning frameworks and basics related to Allura and now I’m ready to add the first merge request of Personal Dashboard. When adding the merge request, should it be added to the master branch of the remote? Regards! On Fri, May 18, 2018 at 6:41 AM Dave Brondsema <d...@brondsema.net> wrote: > That works, and so does google hangouts. See you then > > On 5/17/18 2:17 PM, Deshani Geethika wrote: > > Thanks. Can we make it tomorrow (18th May) 10am ET? or any other > convenient > > time of your choice. > > > > Is it a Hangouts call? or please let me know if I need to setup any other > > application > > > > Regards! > > > > On Thu, May 17, 2018 at 8:57 PM, Dave Brondsema <d...@brondsema.net> > wrote: > > > >> Sure. I am available 10am-6pm ET on weekdays, and also Sat/Sun could be > >> available 12pm - 10pm. > >> > https://www.timeanddate.com/worldclock/converter.html?p1=tz_ist=tz_et > >> > >> On 5/17/18 7:10 AM, Deshani Geethika wrote: > >>> Hi Dave, > >>> > >>> To get an overview about Allura code-base and conventions, it would be > >>> great if we can arrange a call. Could you tell me your available time > >> slots > >>> for a meeting. > >>> My time zone is IST (+0530). > >>> > >>> Regards! > >>> > >>> On Mon, May 14, 2018 at 9:44 PM, Dave Brondsema <d...@brondsema.net> > >> wrote: > >>> > >>>> Hi, > >>>> > >>>> Allura can be pretty flexible, but in general we follow these > >> conventions: > >>>> > >>>> Core components that are deeply integrated into allura go in the > >>>> Allura/allura/model & controllers directories. > >>>> > >>>> Non-essential components go in the Allura/allura/ext/ directory. Like > >>>> "extra" > >>>> or "extensions". So this would make sense for the personal dashboard > I > >>>> think. > >>>> > >>>> Standalone components that can be their application go in ForgeBlog, > >>>> ForgeChat, > >>>> etc. as separate python packages. > >>>> > >>>> -Dave > >>>> > >>>> On 5/14/18 9:44 AM, Deshani Geethika wrote: > >>>>> Hi Dave, > >>>>> > >>>>> During last few days I was working on my GSoC project and I have few > >>>>> problems to be clarified. > >>>>> > >>>>> In my proposal > >>>>> <https://docs.google.com/document/d/1clWKSJ8- > >>>> ektpVaEgiJyoM34ievwkyCnD4uORMCT0eM8/edit?usp=sharing> > >>>>> I have mentioned that, personal_dashboard folder should be created on > >> the > >>>>> path Allura/allura/ext/personal_dashboard. But, I have a confusion > >>>> whether > >>>>> this path is correct, since the Personal Dashboard is not an > >> application. > >>>>> > >>>>> Therefore, I have followed the neighborhood implementation and found > >> out > >>>>> that its templates are in the path Allura/allura/templates. Also, its > >>>>> implementation (neighborhood.py) is in the path > >>>>> Allura/allura/model/neighborhood.py. > >>>>> > >>>>> From above two paths, what is the correct convention that I should > >>>> follow? > >>>>> > >>>>> Regards! > >>>>> > >>>>> On Thu, May 3, 2018 at 3:21 AM, Dave Brondsema <d...@brondsema.net> > >>>> wrote: > >>>>> > >>>>>> On 5/2/18 11:24 AM, Deshani Geethika wrote: > >>>>>>> Hi Dave, > >>>>>>> > >>>>>>> Thanks for the information. I have few questions to be clarified. > >>>>>>> > >>>>>>> I think replacing spaces with underscores would be a good way to do > >> it, > >>>>>>> since on many wikis they are > >>>>>>> interchangable. (They aren't for allura, but we could move towards > >>>>>> that). > >>>>>>> > >>>>>>> Here do you mean that spaces and underscores in a title are > >> considered > >>>> as > >>>>>>> same chara
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Thanks. Can we make it tomorrow (18th May) 10am ET? or any other convenient time of your choice. Is it a Hangouts call? or please let me know if I need to setup any other application Regards! On Thu, May 17, 2018 at 8:57 PM, Dave Brondsema <d...@brondsema.net> wrote: > Sure. I am available 10am-6pm ET on weekdays, and also Sat/Sun could be > available 12pm - 10pm. > https://www.timeanddate.com/worldclock/converter.html?p1=tz_ist=tz_et > > On 5/17/18 7:10 AM, Deshani Geethika wrote: > > Hi Dave, > > > > To get an overview about Allura code-base and conventions, it would be > > great if we can arrange a call. Could you tell me your available time > slots > > for a meeting. > > My time zone is IST (+0530). > > > > Regards! > > > > On Mon, May 14, 2018 at 9:44 PM, Dave Brondsema <d...@brondsema.net> > wrote: > > > >> Hi, > >> > >> Allura can be pretty flexible, but in general we follow these > conventions: > >> > >> Core components that are deeply integrated into allura go in the > >> Allura/allura/model & controllers directories. > >> > >> Non-essential components go in the Allura/allura/ext/ directory. Like > >> "extra" > >> or "extensions". So this would make sense for the personal dashboard I > >> think. > >> > >> Standalone components that can be their application go in ForgeBlog, > >> ForgeChat, > >> etc. as separate python packages. > >> > >> -Dave > >> > >> On 5/14/18 9:44 AM, Deshani Geethika wrote: > >>> Hi Dave, > >>> > >>> During last few days I was working on my GSoC project and I have few > >>> problems to be clarified. > >>> > >>> In my proposal > >>> <https://docs.google.com/document/d/1clWKSJ8- > >> ektpVaEgiJyoM34ievwkyCnD4uORMCT0eM8/edit?usp=sharing> > >>> I have mentioned that, personal_dashboard folder should be created on > the > >>> path Allura/allura/ext/personal_dashboard. But, I have a confusion > >> whether > >>> this path is correct, since the Personal Dashboard is not an > application. > >>> > >>> Therefore, I have followed the neighborhood implementation and found > out > >>> that its templates are in the path Allura/allura/templates. Also, its > >>> implementation (neighborhood.py) is in the path > >>> Allura/allura/model/neighborhood.py. > >>> > >>> From above two paths, what is the correct convention that I should > >> follow? > >>> > >>> Regards! > >>> > >>> On Thu, May 3, 2018 at 3:21 AM, Dave Brondsema <d...@brondsema.net> > >> wrote: > >>> > >>>> On 5/2/18 11:24 AM, Deshani Geethika wrote: > >>>>> Hi Dave, > >>>>> > >>>>> Thanks for the information. I have few questions to be clarified. > >>>>> > >>>>> I think replacing spaces with underscores would be a good way to do > it, > >>>>> since on many wikis they are > >>>>> interchangable. (They aren't for allura, but we could move towards > >>>> that). > >>>>> > >>>>> Here do you mean that spaces and underscores in a title are > considered > >> as > >>>>> same characters? > >>>>> > >>>>> For example : "The Title" is considered same as "The_Title". > >>>> > >>>> Yes that's what I was thinking. > >>>> > >>>>> > >>>>> In this situation, users should not be allowed to create 2 wikis with > >>>> above > >>>>> titles, because we can't handle inbound emails for both scenarios. > >>>> > >>>> Good point, I hadn't thought of that. That does make this more > >>>> complicated. > >>>> Maybe it could be a followup step to prevent creating a page that > >>>> conflicts with > >>>> another one. And then even later on we could make URLs handle spaces > >> and > >>>> underscores interchangably. > >>>> > >>>> Anyone else have ideas about what would be best? > >>>> > >>>>> > >>>>> Also, we have another problem here. > >>>>> > >>>>> Then this handle_message method could try finding a page for that > >>>&g
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, To get an overview about Allura code-base and conventions, it would be great if we can arrange a call. Could you tell me your available time slots for a meeting. My time zone is IST (+0530). Regards! On Mon, May 14, 2018 at 9:44 PM, Dave Brondsema <d...@brondsema.net> wrote: > Hi, > > Allura can be pretty flexible, but in general we follow these conventions: > > Core components that are deeply integrated into allura go in the > Allura/allura/model & controllers directories. > > Non-essential components go in the Allura/allura/ext/ directory. Like > "extra" > or "extensions". So this would make sense for the personal dashboard I > think. > > Standalone components that can be their application go in ForgeBlog, > ForgeChat, > etc. as separate python packages. > > -Dave > > On 5/14/18 9:44 AM, Deshani Geethika wrote: > > Hi Dave, > > > > During last few days I was working on my GSoC project and I have few > > problems to be clarified. > > > > In my proposal > > <https://docs.google.com/document/d/1clWKSJ8- > ektpVaEgiJyoM34ievwkyCnD4uORMCT0eM8/edit?usp=sharing> > > I have mentioned that, personal_dashboard folder should be created on the > > path Allura/allura/ext/personal_dashboard. But, I have a confusion > whether > > this path is correct, since the Personal Dashboard is not an application. > > > > Therefore, I have followed the neighborhood implementation and found out > > that its templates are in the path Allura/allura/templates. Also, its > > implementation (neighborhood.py) is in the path > > Allura/allura/model/neighborhood.py. > > > > From above two paths, what is the correct convention that I should > follow? > > > > Regards! > > > > On Thu, May 3, 2018 at 3:21 AM, Dave Brondsema <d...@brondsema.net> > wrote: > > > >> On 5/2/18 11:24 AM, Deshani Geethika wrote: > >>> Hi Dave, > >>> > >>> Thanks for the information. I have few questions to be clarified. > >>> > >>> I think replacing spaces with underscores would be a good way to do it, > >>> since on many wikis they are > >>> interchangable. (They aren't for allura, but we could move towards > >> that). > >>> > >>> Here do you mean that spaces and underscores in a title are considered > as > >>> same characters? > >>> > >>> For example : "The Title" is considered same as "The_Title". > >> > >> Yes that's what I was thinking. > >> > >>> > >>> In this situation, users should not be allowed to create 2 wikis with > >> above > >>> titles, because we can't handle inbound emails for both scenarios. > >> > >> Good point, I hadn't thought of that. That does make this more > >> complicated. > >> Maybe it could be a followup step to prevent creating a page that > >> conflicts with > >> another one. And then even later on we could make URLs handle spaces > and > >> underscores interchangably. > >> > >> Anyone else have ideas about what would be best? > >> > >>> > >>> Also, we have another problem here. > >>> > >>> Then this handle_message method could try finding a page for that > >> message, > >>> and if it > >>> doesn't exist, it can convert any underscores back to spaces and then > try > >>> find > >>> the wiki page under that name. > >>> > >>> Here do I need to check for all the possible number of combinations of > >>> underscores and spaces to find out the exact wiki page? > >> > >> > >> I was thinking if an email comes in for "Foo_Bar_Baz" first look for one > >> titled > >> "Foo_Bar_Baz" and then one titled "Foo Bar Baz". Trying every > combination > >> could > >> get crazy. > >> > >>> > >>> Regards! > >>> > >>> > >>> > >>> On Wed, May 2, 2018 at 7:17 AM, Dave Brondsema <d...@brondsema.net> > >> wrote: > >>> > >>>> Cool. That email_address property should be the main one and changing > >> it > >>>> should > >>>> reflect in the outgoing emails that are sent to subscribers after > >>>> commenting or > >>>> editing a wiki page. > >>>> > >>>> Allura also supports *inbound* emails on mos
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, During last few days I was working on my GSoC project and I have few problems to be clarified. In my proposal <https://docs.google.com/document/d/1clWKSJ8-ektpVaEgiJyoM34ievwkyCnD4uORMCT0eM8/edit?usp=sharing> I have mentioned that, personal_dashboard folder should be created on the path Allura/allura/ext/personal_dashboard. But, I have a confusion whether this path is correct, since the Personal Dashboard is not an application. Therefore, I have followed the neighborhood implementation and found out that its templates are in the path Allura/allura/templates. Also, its implementation (neighborhood.py) is in the path Allura/allura/model/neighborhood.py. >From above two paths, what is the correct convention that I should follow? Regards! On Thu, May 3, 2018 at 3:21 AM, Dave Brondsema <d...@brondsema.net> wrote: > On 5/2/18 11:24 AM, Deshani Geethika wrote: > > Hi Dave, > > > > Thanks for the information. I have few questions to be clarified. > > > > I think replacing spaces with underscores would be a good way to do it, > > since on many wikis they are > > interchangable. (They aren't for allura, but we could move towards > that). > > > > Here do you mean that spaces and underscores in a title are considered as > > same characters? > > > > For example : "The Title" is considered same as "The_Title". > > Yes that's what I was thinking. > > > > > In this situation, users should not be allowed to create 2 wikis with > above > > titles, because we can't handle inbound emails for both scenarios. > > Good point, I hadn't thought of that. That does make this more > complicated. > Maybe it could be a followup step to prevent creating a page that > conflicts with > another one. And then even later on we could make URLs handle spaces and > underscores interchangably. > > Anyone else have ideas about what would be best? > > > > > Also, we have another problem here. > > > > Then this handle_message method could try finding a page for that > message, > > and if it > > doesn't exist, it can convert any underscores back to spaces and then try > > find > > the wiki page under that name. > > > > Here do I need to check for all the possible number of combinations of > > underscores and spaces to find out the exact wiki page? > > > I was thinking if an email comes in for "Foo_Bar_Baz" first look for one > titled > "Foo_Bar_Baz" and then one titled "Foo Bar Baz". Trying every combination > could > get crazy. > > > > > Regards! > > > > > > > > On Wed, May 2, 2018 at 7:17 AM, Dave Brondsema <d...@brondsema.net> > wrote: > > > >> Cool. That email_address property should be the main one and changing > it > >> should > >> reflect in the outgoing emails that are sent to subscribers after > >> commenting or > >> editing a wiki page. > >> > >> Allura also supports *inbound* emails on most artifacts including wiki > >> pages. > >> So someone could reply to the wiki email and it would be received by > >> Allura and > >> added as a comment on the wiki page. The > >> forgewiki.wiki_main.ForgeWikiApp#handle_message method is what is > >> responsible > >> for that. So that code should be updated as well. I think replacing > >> spaces > >> with underscores would be a good way to do it, since on many wikis they > are > >> interchangable. (They aren't for allura, but we could move towards > >> that). Then > >> this handle_message method could try finding a page for that message, > and > >> if it > >> doesn't exist, it can convert any underscores back to spaces and then > try > >> find > >> the wiki page under that name. > >> > >> To test the inbound mails, I'm unfortunately not seeing any tests in the > >> code. > >> You could add some. The ForgeWiki/forgewiki/tests/test_app.py file > has a > >> TestBulkExport class and you could copy most of its setup, and then add > a > >> test_email test case that calls wiki.handle_message. > >> > >> The other way is to use telnet or other tools like that to send the mail > >> into > >> the "inmail" docker compose container, or `paster smtp_server` service > if > >> you > >> aren't using docker. There's an example of doing that in the middle of > >> this > >> page: https://forge-allura.apache.org/p/allura/wiki/Notes/ > >> > >> Hope that helps! It sounds a little
Re: #1699 Fix incoming email for wiki pages with space in the title
Hi Dave,
I'm really sorry that I didn't notice it. I have fixed the issue and added
a merge request
<https://forge-allura.apache.org/p/allura/git/merge-requests/253/>.
BTW I have started to work on my GSoC project and will give you an update
soon.
Regards!
On Thu, May 10, 2018 at 12:02 AM, Dave Brondsema <d...@brondsema.net> wrote:
> Hi Deshani,
>
> I merged the request already, but have now realized I didn't test it
> thoroughly
> enough. In the email_address property, self.title.replace(' ', '_')
> doesn't do
> anything on its own. It needs to be saved to a variable and use that, or
> chained onto the existing replace('/', '.')
>
> Want to make another merge request?
>
> Thanks!
>
> On 5/7/18 6:07 PM, Dave Brondsema wrote:
> > Sorry for the delays, I will try to get this tomorrow and post feedback
> on the
> > merge request tomorrow.
> >
> > This is a good opportunity to say that delays and time to discuss &
> coordinate
> > are inevitable. Its a good reason to keep units of work small enough,
> and
> > during "fulltime" work on Allura expect to switch gears to a different
> tasks on
> > different branches while waiting for feedback.
> >
> > Thanks though and hope to post feedback tomorrow!
> >
> > On 5/4/18 3:47 PM, Deshani Geethika wrote:
> >> Hi Dave,
> >>
> >> I've fixed the issue and added a merge request
> >> <https://forge-allura.apache.org/p/allura/git/merge-requests/252/>.
> >>
> >> Please review it and let me know any improvements.
> >>
> >> Regards!
> >>
> >> On Fri, May 4, 2018 at 3:13 AM, Dave Brondsema <d...@brondsema.net>
> wrote:
> >>
> >>> I think this method, handling inbound emails to wiki pages, is probably
> >>> not used
> >>> very much :) I haven't tried it but it does seem like that would let
> >>> people
> >>> create new wiki pages just by emailing to the address.
> >>>
> >>> 1) We probably don't need to allow that. Just allow emails to make
> >>> comments on
> >>> *existing* wiki pages (which I believe handle_artifact_message does)
> >>>
> >>> 2) If you look at `git blame` for handle_message you can see that it is
> >>> quite
> >>> old. Some of the very early work on Allura doesn't make perfect sense
> any
> >>> more.
> >>> So in this case it probably would be fine to remove the try/except
> since
> >>> as you
> >>> say upsert() shouldn't raise any exception. And I don't think the
> >>> underlying
> >>> get() and upsert() calls within upsert() would raise any either.
> >>>
> >>> -Dave
> >>>
> >>> On 5/3/18 11:20 AM, Deshani Geethika wrote:
> >>>> Hi Dave,
> >>>>
> >>>> Let's continue the discussion related to the above issue in this
> thread.
> >>>>
> >>>> I have few confusions on the forgewiki.wiki_main.
> >>> ForgeWikiApp#handle_message
> >>>> *[1]* method. Inside this method, Page.upsert method *[2]* is called,
> and
> >>>> upsert method will update page with 'title' or insert new page with
> that
> >>>> name. Does that means, if somebody sends an email to 'Foo_Baz@123'
> and
> >>> if
> >>>> that page is not available, a new page with the title 'Foo_Baz' will
> be
> >>>> created? If so, we have some problems.
> >>>>
> >>>>1. We can't validate the title
> >>>>2. 'upsert' method will never throw an exception (But in
> >>> handle_message
> >>>>method exception is handled)
> >>>>
> >>>>
> >>>> *[1]*def handle_message(self, topic, message):
> >>>> log.info('Message from %s (%s)',
> >>>> topic, self.config.options.mount_point)
> >>>> log.info('Headers are: %s', message['headers'])
> >>>> try:
> >>>> page = WM.Page.upsert(topic)
> >>>> except:
> >>>> log.exception('Error getting artifact %s', topic)
> >>>> self.handle_artifact_message(page, message)
> >>>>
> >>>> *[2]* @classmethod
> >>>> def upsert(cls, title, version=None):
> >>>> """Update page with `title` or insert new page with that
> name"""
> >>>
Re: #1699 Fix incoming email for wiki pages with space in the title
Hi Dave,
I've fixed the issue and added a merge request
<https://forge-allura.apache.org/p/allura/git/merge-requests/252/>.
Please review it and let me know any improvements.
Regards!
On Fri, May 4, 2018 at 3:13 AM, Dave Brondsema <d...@brondsema.net> wrote:
> I think this method, handling inbound emails to wiki pages, is probably
> not used
> very much :) I haven't tried it but it does seem like that would let
> people
> create new wiki pages just by emailing to the address.
>
> 1) We probably don't need to allow that. Just allow emails to make
> comments on
> *existing* wiki pages (which I believe handle_artifact_message does)
>
> 2) If you look at `git blame` for handle_message you can see that it is
> quite
> old. Some of the very early work on Allura doesn't make perfect sense any
> more.
> So in this case it probably would be fine to remove the try/except since
> as you
> say upsert() shouldn't raise any exception. And I don't think the
> underlying
> get() and upsert() calls within upsert() would raise any either.
>
> -Dave
>
> On 5/3/18 11:20 AM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > Let's continue the discussion related to the above issue in this thread.
> >
> > I have few confusions on the forgewiki.wiki_main.
> ForgeWikiApp#handle_message
> > *[1]* method. Inside this method, Page.upsert method *[2]* is called, and
> > upsert method will update page with 'title' or insert new page with that
> > name. Does that means, if somebody sends an email to 'Foo_Baz@123' and
> if
> > that page is not available, a new page with the title 'Foo_Baz' will be
> > created? If so, we have some problems.
> >
> >1. We can't validate the title
> >2. 'upsert' method will never throw an exception (But in
> handle_message
> >method exception is handled)
> >
> >
> > *[1]*def handle_message(self, topic, message):
> > log.info('Message from %s (%s)',
> > topic, self.config.options.mount_point)
> > log.info('Headers are: %s', message['headers'])
> > try:
> > page = WM.Page.upsert(topic)
> > except:
> > log.exception('Error getting artifact %s', topic)
> > self.handle_artifact_message(page, message)
> >
> > *[2]* @classmethod
> > def upsert(cls, title, version=None):
> > """Update page with `title` or insert new page with that name"""
> > if version is None:
> > # Check for existing page object
> > obj = cls.query.get(
> > app_config_id=context.app.config._id,
> > title=title)
> > if obj is None:
> > obj = cls(
> > title=title,
> > app_config_id=context.app.config._id,
> > )
> > Thread.new(discussion_id=obj.app_config.discussion_id,
> >ref_id=obj.index_id())
> > return obj
> > else:
> > pg = cls.upsert(title)
> > HC = cls.__mongometa__.history_class
> > ss = HC.query.find(
> > {'artifact_id': pg._id, 'version': int(version)}).one()
> > return ss
> >
> > Regards!
> >
> > On Thu, May 3, 2018 at 3:21 AM, Dave Brondsema <d...@brondsema.net>
> wrote:
> >
> >> On 5/2/18 11:24 AM, Deshani Geethika wrote:
> >>> Hi Dave,
> >>>
> >>> Thanks for the information. I have few questions to be clarified.
> >>>
> >>> I think replacing spaces with underscores would be a good way to do it,
> >>> since on many wikis they are
> >>> interchangable. (They aren't for allura, but we could move towards
> >> that).
> >>>
> >>> Here do you mean that spaces and underscores in a title are considered
> as
> >>> same characters?
> >>>
> >>> For example : "The Title" is considered same as "The_Title".
> >>
> >> Yes that's what I was thinking.
> >>
> >>>
> >>> In this situation, users should not be allowed to create 2 wikis with
> >> above
> >>> titles, because we can't handle inbound emails for both scenarios.
> >>
> >> Good point, I hadn't thought of that. That does make this more
> >> complicated.
> >> Maybe it could be a followup step to prevent creating a page that
> >> conflicts with
> >> another one.
#1699 Fix incoming email for wiki pages with space in the title
Hi Dave,
Let's continue the discussion related to the above issue in this thread.
I have few confusions on the forgewiki.wiki_main.ForgeWikiApp#handle_message
*[1]* method. Inside this method, Page.upsert method *[2]* is called, and
upsert method will update page with 'title' or insert new page with that
name. Does that means, if somebody sends an email to 'Foo_Baz@123' and if
that page is not available, a new page with the title 'Foo_Baz' will be
created? If so, we have some problems.
1. We can't validate the title
2. 'upsert' method will never throw an exception (But in handle_message
method exception is handled)
*[1]*def handle_message(self, topic, message):
log.info('Message from %s (%s)',
topic, self.config.options.mount_point)
log.info('Headers are: %s', message['headers'])
try:
page = WM.Page.upsert(topic)
except:
log.exception('Error getting artifact %s', topic)
self.handle_artifact_message(page, message)
*[2]* @classmethod
def upsert(cls, title, version=None):
"""Update page with `title` or insert new page with that name"""
if version is None:
# Check for existing page object
obj = cls.query.get(
app_config_id=context.app.config._id,
title=title)
if obj is None:
obj = cls(
title=title,
app_config_id=context.app.config._id,
)
Thread.new(discussion_id=obj.app_config.discussion_id,
ref_id=obj.index_id())
return obj
else:
pg = cls.upsert(title)
HC = cls.__mongometa__.history_class
ss = HC.query.find(
{'artifact_id': pg._id, 'version': int(version)}).one()
return ss
Regards!
On Thu, May 3, 2018 at 3:21 AM, Dave Brondsema <d...@brondsema.net> wrote:
> On 5/2/18 11:24 AM, Deshani Geethika wrote:
> > Hi Dave,
> >
> > Thanks for the information. I have few questions to be clarified.
> >
> > I think replacing spaces with underscores would be a good way to do it,
> > since on many wikis they are
> > interchangable. (They aren't for allura, but we could move towards
> that).
> >
> > Here do you mean that spaces and underscores in a title are considered as
> > same characters?
> >
> > For example : "The Title" is considered same as "The_Title".
>
> Yes that's what I was thinking.
>
> >
> > In this situation, users should not be allowed to create 2 wikis with
> above
> > titles, because we can't handle inbound emails for both scenarios.
>
> Good point, I hadn't thought of that. That does make this more
> complicated.
> Maybe it could be a followup step to prevent creating a page that
> conflicts with
> another one. And then even later on we could make URLs handle spaces and
> underscores interchangably.
>
> Anyone else have ideas about what would be best?
>
> >
> > Also, we have another problem here.
> >
> > Then this handle_message method could try finding a page for that
> message,
> > and if it
> > doesn't exist, it can convert any underscores back to spaces and then try
> > find
> > the wiki page under that name.
> >
> > Here do I need to check for all the possible number of combinations of
> > underscores and spaces to find out the exact wiki page?
>
>
> I was thinking if an email comes in for "Foo_Bar_Baz" first look for one
> titled
> "Foo_Bar_Baz" and then one titled "Foo Bar Baz". Trying every combination
> could
> get crazy.
>
> >
> > Regards!
> >
> >
> >
> > On Wed, May 2, 2018 at 7:17 AM, Dave Brondsema <d...@brondsema.net>
> wrote:
> >
> >> Cool. That email_address property should be the main one and changing
> it
> >> should
> >> reflect in the outgoing emails that are sent to subscribers after
> >> commenting or
> >> editing a wiki page.
> >>
> >> Allura also supports *inbound* emails on most artifacts including wiki
> >> pages.
> >> So someone could reply to the wiki email and it would be received by
> >> Allura and
> >> added as a comment on the wiki page. The
> >> forgewiki.wiki_main.ForgeWikiApp#handle_message method is what is
> >> responsible
> >> for that. So that code should be updated as well. I think replacing
> >> spaces
> >> with underscores would be a good way to do it, since on many wikis they
> are
> >> interchangable. (They aren't for allura, but we could move towards
&g
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave,
Thanks for the information. I have few questions to be clarified.
I think replacing spaces with underscores would be a good way to do it,
since on many wikis they are
interchangable. (They aren't for allura, but we could move towards that).
Here do you mean that spaces and underscores in a title are considered as
same characters?
For example : "The Title" is considered same as "The_Title".
In this situation, users should not be allowed to create 2 wikis with above
titles, because we can't handle inbound emails for both scenarios.
Also, we have another problem here.
Then this handle_message method could try finding a page for that message,
and if it
doesn't exist, it can convert any underscores back to spaces and then try
find
the wiki page under that name.
Here do I need to check for all the possible number of combinations of
underscores and spaces to find out the exact wiki page?
Regards!
On Wed, May 2, 2018 at 7:17 AM, Dave Brondsema <d...@brondsema.net> wrote:
> Cool. That email_address property should be the main one and changing it
> should
> reflect in the outgoing emails that are sent to subscribers after
> commenting or
> editing a wiki page.
>
> Allura also supports *inbound* emails on most artifacts including wiki
> pages.
> So someone could reply to the wiki email and it would be received by
> Allura and
> added as a comment on the wiki page. The
> forgewiki.wiki_main.ForgeWikiApp#handle_message method is what is
> responsible
> for that. So that code should be updated as well. I think replacing
> spaces
> with underscores would be a good way to do it, since on many wikis they are
> interchangable. (They aren't for allura, but we could move towards
> that). Then
> this handle_message method could try finding a page for that message, and
> if it
> doesn't exist, it can convert any underscores back to spaces and then try
> find
> the wiki page under that name.
>
> To test the inbound mails, I'm unfortunately not seeing any tests in the
> code.
> You could add some. The ForgeWiki/forgewiki/tests/test_app.py file has a
> TestBulkExport class and you could copy most of its setup, and then add a
> test_email test case that calls wiki.handle_message.
>
> The other way is to use telnet or other tools like that to send the mail
> into
> the "inmail" docker compose container, or `paster smtp_server` service if
> you
> aren't using docker. There's an example of doing that in the middle of
> this
> page: https://forge-allura.apache.org/p/allura/wiki/Notes/
>
> Hope that helps! It sounds a little more complex of a ticket than I
> initially
> thought it would be. Let us know if you have any more questions or get
> stuck on
> anything.
>
> -Dave
>
> On 5/1/18 12:45 PM, Deshani Geethika wrote:
> > Hi all,
> >
> > During last few days, I spent time on reading the Allura documentation
> and
> > on getting familiarized with Allura codebase.
> >
> > Then, I have started to work on the ticket - #1699 Fix incoming email for
> > wiki pages with space in the title
> > <https://forge-allura.apache.org/p/allura/tickets/1699/>. According to
> my
> > understanding, it is required to replace the spaces in the title with
> null
> > string (or with some character). Therefore, the getter method for
> > email_address which is in Page.class in ForgeWiki/forgewiki/model/wiki
> .py
> > should be changed as below.
> >
> >
> > @property
> > def email_address(self):
> >if context.app.config.options.get('AllowEmailPosting', True):
> >domain = self.email_domain
> > * self.title.replace(‘ ‘,’’) // Added line*
> >return '%s@%s%s' % (self.title.replace('/', '.'), domain,
> > config.common_suffix)
> >else:
> >return tg_config.get('forgemail.return_path')
> >
> > Could you tell me whether, do I need to modify any method other than the
> > above one?
> >
> >
> > Regards!
> >
> > On Wed, Apr 25, 2018 at 10:30 PM, Deshani Geethika <
> > deshanigeeth...@gmail.com> wrote:
> >
> >> Hi Dave,
> >>
> >> Thanks for the detailed explanation. I will start working on this and
> come
> >> back to you with my progress
> >>
> >> Regards!
> >>
> >> On Wed, Apr 25, 2018 at 9:55 PM, Dave Brondsema <d...@brondsema.net>
> >> wrote:
> >>
> >>> On 4/24/18 11:14 AM, Deshani Geethika wrote:
> >>>> Hi Dave,
> >>>>
> >>>> As per GSoC official time-line, from 23rd April to 14th May period is
> >>>> considered
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi all,
During last few days, I spent time on reading the Allura documentation and
on getting familiarized with Allura codebase.
Then, I have started to work on the ticket - #1699 Fix incoming email for
wiki pages with space in the title
<https://forge-allura.apache.org/p/allura/tickets/1699/>. According to my
understanding, it is required to replace the spaces in the title with null
string (or with some character). Therefore, the getter method for
email_address which is in Page.class in ForgeWiki/forgewiki/model/wiki.py
should be changed as below.
@property
def email_address(self):
if context.app.config.options.get('AllowEmailPosting', True):
domain = self.email_domain
* self.title.replace(‘ ‘,’’) // Added line*
return '%s@%s%s' % (self.title.replace('/', '.'), domain,
config.common_suffix)
else:
return tg_config.get('forgemail.return_path')
Could you tell me whether, do I need to modify any method other than the
above one?
Regards!
On Wed, Apr 25, 2018 at 10:30 PM, Deshani Geethika <
deshanigeeth...@gmail.com> wrote:
> Hi Dave,
>
> Thanks for the detailed explanation. I will start working on this and come
> back to you with my progress
>
> Regards!
>
> On Wed, Apr 25, 2018 at 9:55 PM, Dave Brondsema <d...@brondsema.net>
> wrote:
>
>> On 4/24/18 11:14 AM, Deshani Geethika wrote:
>> > Hi Dave,
>> >
>> > As per GSoC official time-line, from 23rd April to 14th May period is
>> > considered as "Community Bonding Period".
>> >
>> > During this period I would like to finalize my design and separate my
>> > project into several tickets. Also, I would like to get more
>> familiarized
>> > with Allura code-base and Allura team.
>> >
>> > Could you guide me what would be the best way to start off with.
>> >
>> > Regards!
>> >
>>
>> Sounds like good goals for the community bonding period.
>>
>> I've added you as a developer on our self-hosted Allura project
>> https://forge-allura.apache.org/p/allura/ which means you can assign
>> tickets to
>> yourself, make new ones, update existing ones, etc. I'd recommend having
>> many
>> small incremental tickets (perhaps even smaller pieces of work than you
>> outlined
>> in the project proposal), so that its easy to manage them and review
>> them. And
>> of course you don't need to make them all right away :)
>>
>> To familiarize yourself with Allura, you can read more of the
>> documentation -
>> assuming you haven't read it all already ;)
>> https://forge-allura.apache.org/docs/
>>
>> And working on Allura code itself is best. Find an existing ticket or
>> anything
>> you notice that could be made better, and make a fix for it. A really
>> easy one
>> that I could suggest is https://forge-allura.apache.or
>> g/p/allura/tickets/1699/
>>
>> I've also noticed that our test suite has failed the past few times:
>> https://builds.apache.org/blue/organizations/jenkins/Allura/activity It
>> probably is related to the "Make debug pages and post permalinks work
>> correctly
>> when behind a proxy" commit. You could take a look at fixing that if you
>> want.
>> Otherwise I will soon.
>>
>> Lastly, reviewing other people's work is a good way to get familiar with
>> the
>> code and best practices. I will have a fix for
>> https://forge-allura.apache.org/p/allura/tickets/6353/ coming soon, so
>> watch out
>> for that. You won't be able to merge my branch to master, but it can be
>> a good
>> way for you to learn from others. And any constructive feedback would be
>> welcome too, of course.
>>
>>
>>
>>
>> --
>> Dave Brondsema : d...@brondsema.net
>> http://www.brondsema.net : personal
>> http://www.splike.com : programming
>> <><
>>
>
>
>
> --
> *Deshani Geethika*
> Undergraduate at Department of Computer Science and Engineering
> Faculty of Engineering - University of Moratuwa Sri Lanka
> LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
> <https://github.com/deshanigtk> | Mobile - +94776383034
>
>
--
*Deshani Geethika*
Undergraduate at Department of Computer Science and Engineering
Faculty of Engineering - University of Moratuwa Sri Lanka
LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub
<https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, Thanks for the detailed explanation. I will start working on this and come back to you with my progress Regards! On Wed, Apr 25, 2018 at 9:55 PM, Dave Brondsema <d...@brondsema.net> wrote: > On 4/24/18 11:14 AM, Deshani Geethika wrote: > > Hi Dave, > > > > As per GSoC official time-line, from 23rd April to 14th May period is > > considered as "Community Bonding Period". > > > > During this period I would like to finalize my design and separate my > > project into several tickets. Also, I would like to get more familiarized > > with Allura code-base and Allura team. > > > > Could you guide me what would be the best way to start off with. > > > > Regards! > > > > Sounds like good goals for the community bonding period. > > I've added you as a developer on our self-hosted Allura project > https://forge-allura.apache.org/p/allura/ which means you can assign > tickets to > yourself, make new ones, update existing ones, etc. I'd recommend having > many > small incremental tickets (perhaps even smaller pieces of work than you > outlined > in the project proposal), so that its easy to manage them and review > them. And > of course you don't need to make them all right away :) > > To familiarize yourself with Allura, you can read more of the > documentation - > assuming you haven't read it all already ;) https://forge-allura.apache. > org/docs/ > > And working on Allura code itself is best. Find an existing ticket or > anything > you notice that could be made better, and make a fix for it. A really > easy one > that I could suggest is https://forge-allura.apache. > org/p/allura/tickets/1699/ > > I've also noticed that our test suite has failed the past few times: > https://builds.apache.org/blue/organizations/jenkins/Allura/activity It > probably is related to the "Make debug pages and post permalinks work > correctly > when behind a proxy" commit. You could take a look at fixing that if you > want. > Otherwise I will soon. > > Lastly, reviewing other people's work is a good way to get familiar with > the > code and best practices. I will have a fix for > https://forge-allura.apache.org/p/allura/tickets/6353/ coming soon, so > watch out > for that. You won't be able to merge my branch to master, but it can be a > good > way for you to learn from others. And any constructive feedback would be > welcome too, of course. > > > > > -- > Dave Brondsema : d...@brondsema.net > http://www.brondsema.net : personal > http://www.splike.com : programming > <>< > -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
[GSoC] [COMDEV-254] Allura - Personal Dashboard
Hi Dave, As per GSoC official time-line, from 23rd April to 14th May period is considered as "Community Bonding Period". During this period I would like to finalize my design and separate my project into several tickets. Also, I would like to get more familiarized with Allura code-base and Allura team. Could you guide me what would be the best way to start off with. Regards! -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
Re: Deshani and Google Summer of Code
Hi all, Thank you very much for the guidance and support given to me. I am looking forward to contribute to the GSoC project and Apache Allura in the best possible manner. Regards! On Tue, Apr 24, 2018 at 2:45 AM, Dave Brondsema <d...@brondsema.net> wrote: > Deshani Geethika has been accepted as a Google Summer of Code student > working on > Allura this summer. Welcome, Deshani! > > Allura might have a small community but we have a big interesting > codebase, and > follow common open source practices, especially Apache Software Foundation > practices. So I hope you learn a lot and the summer goes well. > > -- > Dave Brondsema : d...@brondsema.net > http://www.brondsema.net : personal > http://www.splike.com : programming > <>< > -- *Deshani Geethika* Undergraduate at Department of Computer Science and Engineering Faculty of Engineering - University of Moratuwa Sri Lanka LinkedIn <https://www.linkedin.com/in/deshanigeethika/> | GitHub <https://github.com/deshanigtk> | Mobile - +94776383034
Re: [GSoC] To start contributing to Apache Allura
Hi Dave, Thank you for your valuable feedback. I've updated the proposal accordingly and uploaded the final version Regards! On Tue, Mar 27, 2018 at 3:40 AM, Dave Brondsema <d...@brondsema.net> wrote: > Comments inline: > > On 3/26/18 9:04 AM, Deshani Geethika wrote: > > Hi All, > > > > I have few questions to be clarified about Personal Dashboard. > > > > Currently, when a user is logged in, neighborhoods are shown in the > landing > > page. We have few options here. > > > >1. Replace that Neighborhood page with the Personal Dashboard page. > Then > >we can give a link for Neighborhood page (Like the link for “Account”) > >2. Neighborhood page will remain as it is and provide a link for > >“Dashboard”. (Like the link for “Account”) > >3. Merge these two pages. That means include neighborhoods in Personal > >Dashboard > > > > Yeah the current landing page with neighborhoods is not super great right > now > anyway. Tickets 7308 and 2601 are related to that and maybe could be a > stretch > goal if your proposal were accepted and there was extra time. > > Anyway, for this. I think separate pages would good. One idea would be > to show > the personal dashboard if logged in, and the neighborhood page if not > logged in. > Maybe have separate URLs like /dashboard and /index so you can still > access > both when logged in and "/" would redirect. > > > > > According to the project description > > <https://issues.apache.org/jira/browse/COMDEV-254?filter=12343065>, when > > implementing the Personal Dashboard we can use a pluggable structure as > in > > User Profile. Therefore, I have included the personal_dashboard directory > > in Allura/allura/ext/personal_dashboard path. Furthermore, the whole > folder > > and file structure can be depicted as below. > > > > > > > > Is it alright to reside the personal_dashboard directory in above path or > > else do we have any other better option? Also, please let me know whether > > this file and folder structure is alright. > > Yes, modeling things after the user profile pluggable structure is good. > This > path is a good one. > > > > > > Moreover, I have included the whole design in my GSoC proposal and I have > > uploaded my drafted GSoC proposal to Apache Software Foundations via > > official GSoC site <https://summerofcode.withgoogle.com/>. Let me know > any > > suggestions for the design and also for the proposal. Please find the > link > > for the proposal below. > > > > Proposal : > > > > https://docs.google.com/document/d/1clWKSJ8- > ektpVaEgiJyoM34ievwkyCnD4uORMCT0eM8/edit?usp=sharing > > > > I've made just one minor suggestion on the proposal so far. Overall it is > pretty good. The most important things are: showing a detailed plan, > breaking > it down into small steps in the timeline, and being able to fully commit > to all > the time during the summer. Those are covered pretty well. If you do > have any > exams or vacation time, please include that in your commitment section. > > I'll add more comments if I think of more constructive feedback. > > > > Regards! > > > > On Fri, Mar 23, 2018 at 10:07 PM, Deshani Geethika < > > deshanigeeth...@gmail.com> wrote: > > > >> Hi Dave, > >> > >> I have drafted the GSoC proposal and would like to get feedback from > you. > >> > >> Please review it from here: > >> GSoC Proposal > >> <https://docs.google.com/document/d/1clWKSJ8- > ektpVaEgiJyoM34ievwkyCnD4uORMCT0eM8/edit?usp=drive_web> > >> > >> Regards! > >> > >> On Thu, Mar 22, 2018 at 9:14 PM, Dave Brondsema <d...@brondsema.net> > >> wrote: > >> > >>> I've commented on the merge request. > >>> > >>> The personal dashboard project would be a great. > >>> https://community.apache.org/gsoc.html has some information about what > >>> makes a > >>> good application. I would recommend you write up a draft of your > >>> proposal ideas > >>> and share it either here on the Allura dev mailing list for public > >>> feedback, or > >>> to me privately if you prefer. Getting feedback on your proposal is > >>> allowed and > >>> helpful. > >>> > >>> > >>> On 3/21/18 2:02 PM, Deshani Geethika wrote: > >>>> Hi Dave, > >>>> > >>>> Thank you for reviewing my merge request :) I’v
Re: [GSoC] To start contributing to Apache Allura
Hi All, I have few questions to be clarified about Personal Dashboard. Currently, when a user is logged in, neighborhoods are shown in the landing page. We have few options here. 1. Replace that Neighborhood page with the Personal Dashboard page. Then we can give a link for Neighborhood page (Like the link for “Account”) 2. Neighborhood page will remain as it is and provide a link for “Dashboard”. (Like the link for “Account”) 3. Merge these two pages. That means include neighborhoods in Personal Dashboard According to the project description <https://issues.apache.org/jira/browse/COMDEV-254?filter=12343065>, when implementing the Personal Dashboard we can use a pluggable structure as in User Profile. Therefore, I have included the personal_dashboard directory in Allura/allura/ext/personal_dashboard path. Furthermore, the whole folder and file structure can be depicted as below. Is it alright to reside the personal_dashboard directory in above path or else do we have any other better option? Also, please let me know whether this file and folder structure is alright. Moreover, I have included the whole design in my GSoC proposal and I have uploaded my drafted GSoC proposal to Apache Software Foundations via official GSoC site <https://summerofcode.withgoogle.com/>. Let me know any suggestions for the design and also for the proposal. Please find the link for the proposal below. Proposal : https://docs.google.com/document/d/1clWKSJ8-ektpVaEgiJyoM34ievwkyCnD4uORMCT0eM8/edit?usp=sharing Regards! On Fri, Mar 23, 2018 at 10:07 PM, Deshani Geethika < deshanigeeth...@gmail.com> wrote: > Hi Dave, > > I have drafted the GSoC proposal and would like to get feedback from you. > > Please review it from here: > GSoC Proposal > <https://docs.google.com/document/d/1clWKSJ8-ektpVaEgiJyoM34ievwkyCnD4uORMCT0eM8/edit?usp=drive_web> > > Regards! > > On Thu, Mar 22, 2018 at 9:14 PM, Dave Brondsema <d...@brondsema.net> > wrote: > >> I've commented on the merge request. >> >> The personal dashboard project would be a great. >> https://community.apache.org/gsoc.html has some information about what >> makes a >> good application. I would recommend you write up a draft of your >> proposal ideas >> and share it either here on the Allura dev mailing list for public >> feedback, or >> to me privately if you prefer. Getting feedback on your proposal is >> allowed and >> helpful. >> >> >> On 3/21/18 2:02 PM, Deshani Geethika wrote: >> > Hi Dave, >> > >> > Thank you for reviewing my merge request :) I’ve refracted the code and >> > added the test coverage as described. Please review it and let me know >> any >> > suggestions. Merge request can be found in [1] >> > >> > Meanwhile, I would like to start working on a GSoC project as I’ve got >> some >> > decent exposure to Allura code-base now. When going through the projects >> > list, I’ve found out the project *[COMDEV-254] Allura - personal >> dashboard* >> > [2] fits my interests. >> > >> > But, if there is any high prioritized project other than this, I would >> > equally interested in accepting it as well. I’m looking forward to know >> > further information in order to apply for Allura GSoC projects. >> > >> > [1] https://forge-allura.apache.org/p/allura/git/merge-requests/248/ >> > [2] https://issues.apache.org/jira/browse/COMDEV-254?filter=12343065 >> > >> > Regards! >> > >> > On Tue, Mar 20, 2018 at 10:14 PM, Dave Brondsema <d...@brondsema.net> >> wrote: >> > >> >> No problem! I'll take a look and post feedback on the merge request. >> >> >> >> On 3/20/18 1:36 AM, Deshani Geethika wrote: >> >>> Hi Dave, >> >>> >> >>> Sorry for messing up. I've created a merge request - >> >>> https://forge-allura.apache.org/p/allura/git/merge-requests/248/ >> >>> >> >>> Regards! >> >>> >> >>> On Mon, Mar 19, 2018 at 9:01 PM, Dave Brondsema <d...@brondsema.net> >> >> wrote: >> >>> >> >>>> Hi Deshani, >> >>>> >> >>>> Thanks for the contribution! Would you mind going to >> >>>> https://forge-allura.apache.org/p/allura/git/ and doing a fork and >> >> merge >> >>>> request >> >>>> there? Allura does its own hosting and we prefer to use that. The >> >> GitHub >> >>>> repo >> >>>> is just a mirror. >> &g
Re: [GSoC] To start contributing to Apache Allura
Hi Dave, Thank you for reviewing my merge request :) I’ve refracted the code and added the test coverage as described. Please review it and let me know any suggestions. Merge request can be found in [1] Meanwhile, I would like to start working on a GSoC project as I’ve got some decent exposure to Allura code-base now. When going through the projects list, I’ve found out the project *[COMDEV-254] Allura - personal dashboard* [2] fits my interests. But, if there is any high prioritized project other than this, I would equally interested in accepting it as well. I’m looking forward to know further information in order to apply for Allura GSoC projects. [1] https://forge-allura.apache.org/p/allura/git/merge-requests/248/ [2] https://issues.apache.org/jira/browse/COMDEV-254?filter=12343065 Regards! On Tue, Mar 20, 2018 at 10:14 PM, Dave Brondsema <d...@brondsema.net> wrote: > No problem! I'll take a look and post feedback on the merge request. > > On 3/20/18 1:36 AM, Deshani Geethika wrote: > > Hi Dave, > > > > Sorry for messing up. I've created a merge request - > > https://forge-allura.apache.org/p/allura/git/merge-requests/248/ > > > > Regards! > > > > On Mon, Mar 19, 2018 at 9:01 PM, Dave Brondsema <d...@brondsema.net> > wrote: > > > >> Hi Deshani, > >> > >> Thanks for the contribution! Would you mind going to > >> https://forge-allura.apache.org/p/allura/git/ and doing a fork and > merge > >> request > >> there? Allura does its own hosting and we prefer to use that. The > GitHub > >> repo > >> is just a mirror. > >> > >> Thanks, > >> > >> On 3/18/18 5:24 AM, Deshani Geethika wrote: > >>> Hi all, > >>> > >>> I've added the functionality for bulk delete tickets and created a pull > >>> request - https://github.com/apache/allura/pull/2 > >>> > >>> Please review it and provide me any suggestions. > >>> > >>> Regards! > >>> > >>> On Sun, Mar 18, 2018 at 10:52 AM, Deshani Geethika < > >>> deshanigeeth...@gmail.com> wrote: > >>> > >>>> Hi Dave, > >>>> > >>>> Thank you for the information. I'll try it again and let you know > >>>> > >>>> Regards! > >>>> Deshani > >>>> > >>>> On Fri, Mar 16, 2018 at 2:52 AM, Dave Brondsema <d...@brondsema.net> > >>>> wrote: > >>>> > >>>>> Hi, > >>>>> > >>>>> Your changes look ok just reading them. What happens when you try > it? > >>>>> Do you > >>>>> get any error? > >>>>> > >>>>> One thought is that bulk edit happens as a background task (because > >>>>> updating > >>>>> hundreds of tickets could take some time). Specifically @task > >> bulk_edit > >>>>> is what > >>>>> calls Globals.update_tickets So make sure you have taskd running. > And > >>>>> if it is > >>>>> running, check to see if bulk_edit task runs and if it has any > errors. > >>>>> > >>>>> Hope that helps, > >>>>> > >>>>> On 3/15/18 9:22 AM, Deshani Geethika wrote: > >>>>>> Hi all, > >>>>>> > >>>>>> During last few days, I’ve been playing with Allura code-base and > >>>>> started > >>>>>> to work on the issue #8149 Bulk Delete for tickets ( > >>>>>> https://forge-allura.apache.org/p/allura/tickets/8149/) > >>>>>> > >>>>>> I have modified the file > >>>>>> ‘ForgeTracker/forgetracker/templates/tracker_widgets/mass_ > >>>>> edit_form.html’ > >>>>>> and added the following set of lines, which is similar to ‘Private’ > >>>>> field > >>>>>> with just boolean values. > >>>>>> > >>>>>> ………... > >>>>>> > >>>>>> > >>>>>> > >>>>>> Delete: > >>>>>> > >>>>>> > >>>>>> > >>>>>>Don't > change > >>>>>> > >>>>>>True > >>>>>> > >>>>>>False > >>>>>> > >>>>>> >
Re: [GSoC] To start contributing to Apache Allura
Hi Dave,
Sorry for messing up. I've created a merge request -
https://forge-allura.apache.org/p/allura/git/merge-requests/248/
Regards!
On Mon, Mar 19, 2018 at 9:01 PM, Dave Brondsema <d...@brondsema.net> wrote:
> Hi Deshani,
>
> Thanks for the contribution! Would you mind going to
> https://forge-allura.apache.org/p/allura/git/ and doing a fork and merge
> request
> there? Allura does its own hosting and we prefer to use that. The GitHub
> repo
> is just a mirror.
>
> Thanks,
>
> On 3/18/18 5:24 AM, Deshani Geethika wrote:
> > Hi all,
> >
> > I've added the functionality for bulk delete tickets and created a pull
> > request - https://github.com/apache/allura/pull/2
> >
> > Please review it and provide me any suggestions.
> >
> > Regards!
> >
> > On Sun, Mar 18, 2018 at 10:52 AM, Deshani Geethika <
> > deshanigeeth...@gmail.com> wrote:
> >
> >> Hi Dave,
> >>
> >> Thank you for the information. I'll try it again and let you know
> >>
> >> Regards!
> >> Deshani
> >>
> >> On Fri, Mar 16, 2018 at 2:52 AM, Dave Brondsema <d...@brondsema.net>
> >> wrote:
> >>
> >>> Hi,
> >>>
> >>> Your changes look ok just reading them. What happens when you try it?
> >>> Do you
> >>> get any error?
> >>>
> >>> One thought is that bulk edit happens as a background task (because
> >>> updating
> >>> hundreds of tickets could take some time). Specifically @task
> bulk_edit
> >>> is what
> >>> calls Globals.update_tickets So make sure you have taskd running. And
> >>> if it is
> >>> running, check to see if bulk_edit task runs and if it has any errors.
> >>>
> >>> Hope that helps,
> >>>
> >>> On 3/15/18 9:22 AM, Deshani Geethika wrote:
> >>>> Hi all,
> >>>>
> >>>> During last few days, I’ve been playing with Allura code-base and
> >>> started
> >>>> to work on the issue #8149 Bulk Delete for tickets (
> >>>> https://forge-allura.apache.org/p/allura/tickets/8149/)
> >>>>
> >>>> I have modified the file
> >>>> ‘ForgeTracker/forgetracker/templates/tracker_widgets/mass_
> >>> edit_form.html’
> >>>> and added the following set of lines, which is similar to ‘Private’
> >>> field
> >>>> with just boolean values.
> >>>>
> >>>> ………...
> >>>>
> >>>>
> >>>>
> >>>> Delete:
> >>>>
> >>>>
> >>>>
> >>>>Don't change
> >>>>
> >>>>True
> >>>>
> >>>>False
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> ………...
> >>>>
> >>>> Then, in ‘model/ticket.py’, class ‘Globals’, method ‘update_tickets’,
> I
> >>>> have added following set of lines.
> >>>>
> >>>> ……...
> >>>>
> >>>> private = post_data.get('private')
> >>>>
> >>>> if private:
> >>>>
> >>>>values['private'] = asbool(private)
> >>>>
> >>>> deleted = post_data.get('deleted')
> >>>>
> >>>> if deleted:
> >>>>
> >>>> values['deleted'] = asbool(deleted)
> >>>>
> >>>> ……...
> >>>>
> >>>> Here, the value of ‘deleted’, which is submitted from
> >>> ‘mass_edit_form.html’
> >>>> is read and saved to ‘values’ dictionary.
> >>>>
> >>>> Then in the same method, as far as I understood, I have to add the
> >>>> functionality for mass delete. Also, I’ve found out the ‘delete’
> method
> >>>> which is implemented to delete a single ticket in
> >>>> ‘ForgeTracker/forgetracker/tracker_main.py’
> >>>> class.
> >>>>
> >>>> Therefore, I have imported the ‘delete’ method from above class, and
> use
> >>>> that method directly to delete tickets one by one (inside the tickets
> >>> loop)
> >>>> as below. I’ve assumed that, if a user needs to delete tickets, then
> >>> other
> >>>> fields (Priv
Re: [GSoC] To start contributing to Apache Allura
Hi all,
I've added the functionality for bulk delete tickets and created a pull
request - https://github.com/apache/allura/pull/2
Please review it and provide me any suggestions.
Regards!
On Sun, Mar 18, 2018 at 10:52 AM, Deshani Geethika <
deshanigeeth...@gmail.com> wrote:
> Hi Dave,
>
> Thank you for the information. I'll try it again and let you know
>
> Regards!
> Deshani
>
> On Fri, Mar 16, 2018 at 2:52 AM, Dave Brondsema <d...@brondsema.net>
> wrote:
>
>> Hi,
>>
>> Your changes look ok just reading them. What happens when you try it?
>> Do you
>> get any error?
>>
>> One thought is that bulk edit happens as a background task (because
>> updating
>> hundreds of tickets could take some time). Specifically @task bulk_edit
>> is what
>> calls Globals.update_tickets So make sure you have taskd running. And
>> if it is
>> running, check to see if bulk_edit task runs and if it has any errors.
>>
>> Hope that helps,
>>
>> On 3/15/18 9:22 AM, Deshani Geethika wrote:
>> > Hi all,
>> >
>> > During last few days, I’ve been playing with Allura code-base and
>> started
>> > to work on the issue #8149 Bulk Delete for tickets (
>> > https://forge-allura.apache.org/p/allura/tickets/8149/)
>> >
>> > I have modified the file
>> > ‘ForgeTracker/forgetracker/templates/tracker_widgets/mass_
>> edit_form.html’
>> > and added the following set of lines, which is similar to ‘Private’
>> field
>> > with just boolean values.
>> >
>> > ………...
>> >
>> >
>> >
>> > Delete:
>> >
>> >
>> >
>> >Don't change
>> >
>> >True
>> >
>> >False
>> >
>> >
>> >
>> >
>> >
>> > ………...
>> >
>> > Then, in ‘model/ticket.py’, class ‘Globals’, method ‘update_tickets’, I
>> > have added following set of lines.
>> >
>> > ……...
>> >
>> > private = post_data.get('private')
>> >
>> > if private:
>> >
>> >values['private'] = asbool(private)
>> >
>> > deleted = post_data.get('deleted')
>> >
>> > if deleted:
>> >
>> > values['deleted'] = asbool(deleted)
>> >
>> > ……...
>> >
>> > Here, the value of ‘deleted’, which is submitted from
>> ‘mass_edit_form.html’
>> > is read and saved to ‘values’ dictionary.
>> >
>> > Then in the same method, as far as I understood, I have to add the
>> > functionality for mass delete. Also, I’ve found out the ‘delete’ method
>> > which is implemented to delete a single ticket in
>> > ‘ForgeTracker/forgetracker/tracker_main.py’
>> > class.
>> >
>> > Therefore, I have imported the ‘delete’ method from above class, and use
>> > that method directly to delete tickets one by one (inside the tickets
>> loop)
>> > as below. I’ve assumed that, if a user needs to delete tickets, then
>> other
>> > fields (Private, Owner, Discussion Disabled etc.) are not required to be
>> > modified. So that, if a ticket is deleted, the loop breaks without
>> further
>> > modifying the ticket.
>> >
>> > …..
>> >
>> > def update_tickets(self, **post_data):
>> >
>> >from forgetracker.tracker_main import get_change_text, get_label,
>> > delete
>> >
>> > ……….
>> >
>> > for ticket in tickets:
>> >
>> > message = ''
>> >
>> > if labels:
>> >
>> > values['labels'] = self.append_new_labels(
>> >
>> > ticket.labels, labels.split(','))
>> >
>> >for k, v in sorted(values.iteritems()):
>> >
>> >if k == 'deleted':
>> >
>> > if v:
>> >
>> > ticket.delete()
>> >
>> > break
>> >
>> >elif k == 'assigned_to_id':
>> >
>> >new_user = User.query.get(_id=v)
>> >
>> >old_user = User.query.get(_id=getattr(ticket, k))
>> >
>> >if new_user:
>> >
>> > message += get_change_text(
>> >
>> >get_label(k),
>> >
>> >new_user.disp
Re: [GSoC] To start contributing to Apache Allura
Hi Dave,
Thank you for the information. I'll try it again and let you know
Regards!
Deshani
On Fri, Mar 16, 2018 at 2:52 AM, Dave Brondsema <d...@brondsema.net> wrote:
> Hi,
>
> Your changes look ok just reading them. What happens when you try it? Do
> you
> get any error?
>
> One thought is that bulk edit happens as a background task (because
> updating
> hundreds of tickets could take some time). Specifically @task bulk_edit
> is what
> calls Globals.update_tickets So make sure you have taskd running. And if
> it is
> running, check to see if bulk_edit task runs and if it has any errors.
>
> Hope that helps,
>
> On 3/15/18 9:22 AM, Deshani Geethika wrote:
> > Hi all,
> >
> > During last few days, I’ve been playing with Allura code-base and started
> > to work on the issue #8149 Bulk Delete for tickets (
> > https://forge-allura.apache.org/p/allura/tickets/8149/)
> >
> > I have modified the file
> > ‘ForgeTracker/forgetracker/templates/tracker_widgets/
> mass_edit_form.html’
> > and added the following set of lines, which is similar to ‘Private’ field
> > with just boolean values.
> >
> > ………...
> >
> >
> >
> > Delete:
> >
> >
> >
> >Don't change
> >
> >True
> >
> >False
> >
> >
> >
> >
> >
> > ………...
> >
> > Then, in ‘model/ticket.py’, class ‘Globals’, method ‘update_tickets’, I
> > have added following set of lines.
> >
> > ……...
> >
> > private = post_data.get('private')
> >
> > if private:
> >
> >values['private'] = asbool(private)
> >
> > deleted = post_data.get('deleted')
> >
> > if deleted:
> >
> > values['deleted'] = asbool(deleted)
> >
> > ……...
> >
> > Here, the value of ‘deleted’, which is submitted from
> ‘mass_edit_form.html’
> > is read and saved to ‘values’ dictionary.
> >
> > Then in the same method, as far as I understood, I have to add the
> > functionality for mass delete. Also, I’ve found out the ‘delete’ method
> > which is implemented to delete a single ticket in
> > ‘ForgeTracker/forgetracker/tracker_main.py’
> > class.
> >
> > Therefore, I have imported the ‘delete’ method from above class, and use
> > that method directly to delete tickets one by one (inside the tickets
> loop)
> > as below. I’ve assumed that, if a user needs to delete tickets, then
> other
> > fields (Private, Owner, Discussion Disabled etc.) are not required to be
> > modified. So that, if a ticket is deleted, the loop breaks without
> further
> > modifying the ticket.
> >
> > …..
> >
> > def update_tickets(self, **post_data):
> >
> >from forgetracker.tracker_main import get_change_text, get_label,
> > delete
> >
> > ……….
> >
> > for ticket in tickets:
> >
> > message = ''
> >
> > if labels:
> >
> > values['labels'] = self.append_new_labels(
> >
> > ticket.labels, labels.split(','))
> >
> >for k, v in sorted(values.iteritems()):
> >
> >if k == 'deleted':
> >
> > if v:
> >
> > ticket.delete()
> >
> > break
> >
> >elif k == 'assigned_to_id':
> >
> >new_user = User.query.get(_id=v)
> >
> >old_user = User.query.get(_id=getattr(ticket, k))
> >
> >if new_user:
> >
> >message += get_change_text(
> >
> >get_label(k),
> >
> >new_user.display_name,
> >
> >old_user.display_name)
> >
> >
> >
> >elif k == 'private' or k == 'discussion_disabled':
> >
> > def _text(val):
> >
> > if val:
> >
> >return 'Yes'
> >
> >else:
> >
> >return 'No'
> >
> >message += get_change_text(
> >
> >get_label(k),
> >
> >_text(v),
> >
> >_text(getattr(ticket, k)))
> >
> >else:
> >
> > message += get_change_text(
> >
> >get_label(k),
Re: [GSoC] To start contributing to Apache Allura
Hi all,
During last few days, I’ve been playing with Allura code-base and started
to work on the issue #8149 Bulk Delete for tickets (
https://forge-allura.apache.org/p/allura/tickets/8149/)
I have modified the file
‘ForgeTracker/forgetracker/templates/tracker_widgets/mass_edit_form.html’
and added the following set of lines, which is similar to ‘Private’ field
with just boolean values.
………...
Delete:
Don't change
True
False
………...
Then, in ‘model/ticket.py’, class ‘Globals’, method ‘update_tickets’, I
have added following set of lines.
……...
private = post_data.get('private')
if private:
values['private'] = asbool(private)
deleted = post_data.get('deleted')
if deleted:
values['deleted'] = asbool(deleted)
……...
Here, the value of ‘deleted’, which is submitted from ‘mass_edit_form.html’
is read and saved to ‘values’ dictionary.
Then in the same method, as far as I understood, I have to add the
functionality for mass delete. Also, I’ve found out the ‘delete’ method
which is implemented to delete a single ticket in
‘ForgeTracker/forgetracker/tracker_main.py’
class.
Therefore, I have imported the ‘delete’ method from above class, and use
that method directly to delete tickets one by one (inside the tickets loop)
as below. I’ve assumed that, if a user needs to delete tickets, then other
fields (Private, Owner, Discussion Disabled etc.) are not required to be
modified. So that, if a ticket is deleted, the loop breaks without further
modifying the ticket.
…..
def update_tickets(self, **post_data):
from forgetracker.tracker_main import get_change_text, get_label,
delete
……….
for ticket in tickets:
message = ''
if labels:
values['labels'] = self.append_new_labels(
ticket.labels, labels.split(','))
for k, v in sorted(values.iteritems()):
if k == 'deleted':
if v:
ticket.delete()
break
elif k == 'assigned_to_id':
new_user = User.query.get(_id=v)
old_user = User.query.get(_id=getattr(ticket, k))
if new_user:
message += get_change_text(
get_label(k),
new_user.display_name,
old_user.display_name)
elif k == 'private' or k == 'discussion_disabled':
def _text(val):
if val:
return 'Yes'
else:
return 'No'
message += get_change_text(
get_label(k),
_text(v),
_text(getattr(ticket, k)))
else:
message += get_change_text(
get_label(k),
v,getattr(ticket, k))
setattr(ticket, k, v)
……….
But, the mass delete functionality is not working and I’m not sure whether
I’m on the right path. Could you help me to solve this issue.
Regards!
Deshani
On Fri, Mar 9, 2018 at 10:46 PM, Deshani Geethika <deshanigeeth...@gmail.com
> wrote:
> Hi Dave,
>
> Thank you for your guidance. I'll get back if I get anything to be
> clarified
>
> Regards!
> -Deshani
>
> On Fri, Mar 9, 2018 at 9:55 PM, Dave Brondsema <d...@brondsema.net> wrote:
>
>> Hi Deshani,
>>
>> Welcome! Sounds like you're off to a good start. I would suggest getting
>> familiar with the codebase of Allura would be a good next step.
>> https://forge-allura.apache.org/docs/development/contributing.html
>> explains some
>> of the basics and is a good read. If there are small changes you want to
>> make
>> (whether related to a larger GSoC task or not) you could try to make
>> them. Feel
>> free to ask for help here, or if you make a small fix or improvement, go
>> ahead
>> and submit a merge request :)
>>
>> -Dave
>>
>> On 3/9/18 12:48 AM, deshanigeeth...@gmail.com wrote:
>> > Hi all,
>> >
>> > I’m Deshani Geethika, a final year undergraduate at Department of
>> Computer Science and Engineering, University of Moratuwa, Sri Lanka. I
>> would like to participate in GSoC 2018 and I found out some interesting
>> projects of Apache Allura.
>> >
>> > I have gone through the documentation and set up Allura in my local
>> machine. Also, I wrote a blog article (https://medium.com/@deshanige
>> ethika/in-progress-setting-up-apache-allura-in-ubuntu-1fa166406448)
>> about setting up Allura.
>> >
>> > Since I’m new to this community, it is really appreciated if anyone
>> suggest me a way to begin contributing to Allura.
>> >
>> > Regards!
>> >
>>
>>
>>
>> --
>> Dave Brondsema : d...@brondsema.net
>> http://www.brondsema.net : personal
>> http://www.splike.com : programming
>> <><
>>
>
>
Re: [GSoC] To start contributing to Apache Allura
Hi Dave, Thank you for your guidance. I'll get back if I get anything to be clarified Regards! -Deshani On Fri, Mar 9, 2018 at 9:55 PM, Dave Brondsema <d...@brondsema.net> wrote: > Hi Deshani, > > Welcome! Sounds like you're off to a good start. I would suggest getting > familiar with the codebase of Allura would be a good next step. > https://forge-allura.apache.org/docs/development/contributing.html > explains some > of the basics and is a good read. If there are small changes you want to > make > (whether related to a larger GSoC task or not) you could try to make > them. Feel > free to ask for help here, or if you make a small fix or improvement, go > ahead > and submit a merge request :) > > -Dave > > On 3/9/18 12:48 AM, deshanigeeth...@gmail.com wrote: > > Hi all, > > > > I’m Deshani Geethika, a final year undergraduate at Department of > Computer Science and Engineering, University of Moratuwa, Sri Lanka. I > would like to participate in GSoC 2018 and I found out some interesting > projects of Apache Allura. > > > > I have gone through the documentation and set up Allura in my local > machine. Also, I wrote a blog article (https://medium.com/@ > deshanigeethika/in-progress-setting-up-apache-allura-in- > ubuntu-1fa166406448) about setting up Allura. > > > > Since I’m new to this community, it is really appreciated if anyone > suggest me a way to begin contributing to Allura. > > > > Regards! > > > > > > -- > Dave Brondsema : d...@brondsema.net > http://www.brondsema.net : personal > http://www.splike.com : programming > <>< >
