[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

[nitt10prashant]

Github user nitt10prashant commented on the pull request:

https://github.com/apache/cloudstack/pull/1417#issuecomment-220521199
  
@swill  i do not see any comment on parent ticket CLOUDSTACK-8676 , i have 
asked Sateesh to update the ticket , will update the PR as soon as i hear from 
him.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Ardhendu Shekhar]

Congratulations, Will.

Regards,
Ardhendu

Ardhendu Shekhar
Senior Manager, Program Management | CloudPlatform | Accelerite, Hyderabad |
Extn:  29370 | Desk: +91 40 6742 9370 | Cell: +91 988-500-2788 | 
ardhendu.shek...@accelerite.com |
 


On 5/19/16, 12:26 PM, "Sebastien Goasguen"  wrote:

>Morning Everyone,
>
>Yesterday at the ASF board meeting, the board passed the resolution making 
>Will Stevens the new Vice President of the Apache CloudStack project.
>
>Join me in congratulating Will on this appointment, wish him luck and bring 
>your unwavering support !
>
>You may have noticed that Will took on RM duties for the new releases going 
>forward and has also taken a very active role to finish bringing us to github 
>based  workflow and CI. Will has some updates on that front that I am sure you 
>will all like.
>
>-Sebastien
>Former VP CloudStack




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-220517071
  
?OK, I can create one and open a PR up against it reverting those variable 
names.



From: Anshul Gangwar 
Sent: Thursday, May 19, 2016 10:50 PM
To: apache/cloudstack
Cc: Tutkowski, Mike; Mention
Subject: Re: [apache/cloudstack] Notify listeners when a host has been 
added to a cluster, is about to… (#816)


@mike-tutkowski No, I have not created 
ticket. You can create one.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on 
GitHub



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Variable renaming in classes meant for Agents

[Tutkowski, Mike]

Thanks for sending out this e-mail, Anshul.

This is a bit of a strange situation because we need to make sure people are 
either aware of the fact that properties in Command classes are serialized (and 
not change existing variable names) or come up with a less fragile way of 
choosing property names when sending data (perhaps using annotations).

At the very least, we should have comments in these classes indicating the 
dangers of changing property names. It might also be beneficial to have unit 
tests in place that expect certain variable names and assert if they are not as 
expected.

In the meanwhile, I plan to change the variable names back that were changed in 
PR #816.

Additional thoughts on how this should be addressed long term?

Thanks!
Mike

From: Anshul Gangwar 
Sent: Thursday, May 19, 2016 10:47 PM
To: dev@cloudstack.apache.org
Subject: Variable renaming in classes meant for Agents

Hi,

We should not allow renaming of variables in classes which ends with Command 
and TO. As these objects are meant to be consumed by Agents.

Agents may not be written in java so relying on these variable names to get the 
info. One such example is Hyper-V agent.

Hyper-V support is currently broken as there are some variables renamed in PR 
https://github.com/apache/cloudstack/pull/816.

Regards,
Anshul






DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-220516738
  
@mike-tutkowski No, I have not created ticket. You can create one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: Notify listeners when a host has been add...

[Tutkowski, Mike]

I see that you just sent an e-mail to @dev about this - thanks!

From: mike-tutkowski 
Sent: Thursday, May 19, 2016 10:46 PM
To: dev@cloudstack.apache.org
Subject: [GitHub] cloudstack pull request: Notify listeners when a host has 
been add...

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-220516362

Yes, I can send an e-mail out in a bit.


In the short term (at least for 4.9), I can just revert the changed names 
in those Command classes.


Do you have a ticket I can open the PR against?


Thanks!



From: Anshul Gangwar 
Sent: Thursday, May 19, 2016 10:30 PM
To: apache/cloudstack
Cc: Tutkowski, Mike; Mention
Subject: Re: [apache/cloudstack] Notify listeners when a host has been 
added to a cluster, is about to… (#816)


@mike-tutkowski then we can raise this 
in dev list.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on 
GitHub



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Variable renaming in classes meant for Agents

[Anshul Gangwar]

Hi,

We should not allow renaming of variables in classes which ends with Command 
and TO. As these objects are meant to be consumed by Agents.

Agents may not be written in java so relying on these variable names to get the 
info. One such example is Hyper-V agent.

Hyper-V support is currently broken as there are some variables renamed in PR 
https://github.com/apache/cloudstack/pull/816.

Regards,
Anshul






DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-220516362
  
Yes, I can send an e-mail out in a bit.


In the short term (at least for 4.9), I can just revert the changed names 
in those Command classes.


Do you have a ticket I can open the PR against?


Thanks!



From: Anshul Gangwar 
Sent: Thursday, May 19, 2016 10:30 PM
To: apache/cloudstack
Cc: Tutkowski, Mike; Mention
Subject: Re: [apache/cloudstack] Notify listeners when a host has been 
added to a cluster, is about to… (#816)


@mike-tutkowski then we can raise this 
in dev list.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on 
GitHub



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Regarding files generated by WSDL

[sangeeta lal]

Dear CloudStack Team,


I am Sangeeta, a PhD scholar from India. I am working in the area of
automated software engineering and my aim is to analyse logging statements.

While analysing the CloudStack project,* I found may files having following
statement written in them*:


*/*This file was auto-generated from WSDL*
* * by the Apache Axis2 version: 1.5.6  Built on : Aug 30, 2011 (10:00:16
CEST)*
*/


1. Can anyone please tell me *what this means*?
2. Are the kinds of file have *no user contribution*?


I  highly appreciate your help!

Thank You
-- 
Regards...
Sangeeta
Assistant Professor
CSE Department @JIIT Noida

[GitHub] cloudstack pull request: CLOUDSTACK-9289:Automation for feature de...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1417#issuecomment-220515109
  
@nitt10prashant any update on this one?  I am very close to freezing, so I 
figured I would check in.  Cheers...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [Bug-Id: CLOUDSTACK-9306]Replace testdata...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1436#issuecomment-220514893
  
@sanju1010 ping...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-220514841
  
@mike-tutkowski then we can raise this in dev list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1514#issuecomment-220514409
  
@dsclose can you please rebase and repush this one to kick off jenkins and 
travis again.  We have fixes in both travis and jenkins so we should be able to 
get this one green.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-220514243
  
I wonder how many people are actually aware of that. :-)

Sent from my iPhone

On May 19, 2016, at 9:04 PM, Anshul Gangwar 
> wrote:


@mike-tutkowski I believe class name 
ending in Command signifies that they are meant for agent and should be treated 
like API params.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on 
GitHub



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1499#issuecomment-220513799
  
@alexandrelimassantana this one has merge conflicts.  Can you rebase and 
fix the conflicts?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/883#issuecomment-220513693
  
Can someone with a xenserver setup validate this one?  @bvbharat can you 
queue this one up for us?  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/846#issuecomment-220513570
  
@kishankavala please rebase this PR as we have merge conflicts.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1516#issuecomment-220512874
  


### CI RESULTS

```
Tests Run: 84
  Skipped: 0
   Failed: 0
   Errors: 2
 Duration: 8h 36m 08s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_OMDZZF/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_OMDZZF/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_49_54_JIUQTZ:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1516/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_49_54_JIUQTZ/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1516/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_49_54_JIUQTZ/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1516/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_49_54_JIUQTZ/runinfo.txt)

**`/tmp/MarvinLogs/test_capacity_host_delete_B4HOBT:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1516/tmp/MarvinLogs/test_capacity_host_delete_B4HOBT/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1516/tmp/MarvinLogs/test_capacity_host_delete_B4HOBT/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1516/tmp/MarvinLogs/test_capacity_host_delete_B4HOBT/runinfo.txt)

**`/tmp/MarvinLogs/test_network_OMDZZF:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1516/tmp/MarvinLogs/test_network_OMDZZF/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1516/tmp/MarvinLogs/test_network_OMDZZF/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1516/tmp/MarvinLogs/test_network_OMDZZF/runinfo.txt)


Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220512533
  
These failures are not related to this PR, but if you have ideas why they 
are happening I would be interested.  I will wait till @wido has a chance to 
work on this PR to run the CI again.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220512458
  


### CI RESULTS

```
Tests Run: 78
  Skipped: 0
   Failed: 0
   Errors: 4
 Duration: 7h 47m 49s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
296, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_YJVJO9/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_YJVJO9/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_YJVJO9/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: 

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-220512436
  
@mike-tutkowski I believe class name ending in Command signifies that they 
are meant for agent and should be treated like API params.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-220512305
  
I don't think these issues are related to this PR, but if you have any 
insight as to why they might be happening I would be interested.  I will run 
this CI again to see if we can get a bit of a cleaner report.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9180: Optimize concurrent VM d...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1251#issuecomment-220512147
  


### CI RESULTS

```
Tests Run: 82
  Skipped: 0
   Failed: 1
   Errors: 4
 Duration: 9h 31m 01s
```

**Summary of the problem(s):**
```
ERROR: Test to verify access to loadbalancer haproxy admin stats page
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/smoke/test_internal_lb.py", line 
854, in tearDown
raise Exception("Cleanup failed with %s" % e)
Exception: Cleanup failed with Job failed: {jobprocstatus : 0, created : 
u'2016-05-20T01:01:48+0200', jobresult : {errorcode : 530, errortext : u'Failed 
to delete network'}, cmd : 
u'org.apache.cloudstack.api.command.user.network.DeleteNetworkCmd', userid : 
u'7419d6d0-1de7-11e6-9293-5254001daa61', jobstatus : 2, jobid : 
u'63713d1c-6f2b-480f-a7a3-8f5bac6328bc', jobresultcode : 530, jobresulttype : 
u'object', jobinstancetype : u'Network', accountid : 
u'7419c212-1de7-11e6-9293-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_network_TL42E7/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_TL42E7/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_TL42E7/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_TL42E7/results.txt
```

```
FAIL: Test destroy(expunge) Virtual Machine

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220512003
  
These errors are not related to this PR, but if you know where these errors 
are coming from I would be interested in some input.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220511935
  


### CI RESULTS

```
Tests Run: 82
  Skipped: 0
   Failed: 0
   Errors: 3
 Duration: 8h 29m 09s
```

**Summary of the problem(s):**
```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 835, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_0H4UMM/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 293, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_0H4UMM/results.txt
```

```
ERROR: test suite for 
--
Traceback (most recent call last):
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
209, in run
self.setUp()
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
292, in setUp
self.setupContext(ancestor)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/suite.py", line 
315, in setupContext
try_run(context, names)
  File 
"/usr/lib/python2.7/site-packages/nose-1.3.7-py2.7.egg/nose/util.py", line 471, 
in try_run
return func()
  File "/data/git/cs1/cloudstack/test/integration/smoke/test_vpc_vpn.py", 
line 472, in setUpClass
cls.template.download(cls.apiclient)
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 1350, in 
download
elif 'Downloaded' in template.status:
TypeError: argument of type 'NoneType' is not iterable
--
Additional details in: /tmp/MarvinLogs/test_network_0H4UMM/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_32_28_UUXUPD:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_32_28_UUXUPD/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_32_28_UUXUPD/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_32_28_UUXUPD/runinfo.txt)

**`/tmp/MarvinLogs/test_network_0H4UMM:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_network_0H4UMM/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_network_0H4UMM/results.txt)
* 

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220511825
  
I am going to run the test again because it was an intermittent issue, so a 
couple tests is not a bad idea.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220511743
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 8h 51m 55s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_29_38_NAMX3Q:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_29_38_NAMX3Q/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_29_38_NAMX3Q/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/DeployDataCenter__May_19_2016_19_29_38_NAMX3Q/runinfo.txt)

**`/tmp/MarvinLogs/test_network_V1CHD4:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_network_V1CHD4/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_network_V1CHD4/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_network_V1CHD4/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_L9ZGGS:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_vpc_routers_L9ZGGS/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_vpc_routers_L9ZGGS/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1549/tmp/MarvinLogs/test_vpc_routers_L9ZGGS/runinfo.txt)


Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r63988259
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
--- End diff --

Answered above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r63988285
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -1298,6 +1304,27 @@ private static DiskTO getIsoDiskTO(DiskTO[] disks) {
 return null;
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+VmwareManager mgr = 
getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
+File keyFile = mgr.getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
--- End diff --

Answered above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[anshul1886]

Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r63988200
  
--- Diff: 
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 ---
@@ -594,6 +597,25 @@ private PlugNicAnswer execute(final PlugNicCommand 
cmd) {
 }
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+File keyFile = getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
--- End diff --

SshHelper is throwing Exception so I am catching Exception. If you are 
talking about handling it here and not passing to CopyFileInVmAnswer then 
CopyFileInVmAnswer is just passing the exception message and not full 
exception. Applicable constructor from CopyFileInVmAnswer 
public CopyFileInVmAnswer(CopyFileInVmCommand cmd, Exception e) {
super(cmd, false, e.getMessage());
}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-220505362
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 4h 18m 28s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_19_2016_22_22_03_6D9IF9:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/DeployDataCenter__May_19_2016_22_22_03_6D9IF9/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/DeployDataCenter__May_19_2016_22_22_03_6D9IF9/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/DeployDataCenter__May_19_2016_22_22_03_6D9IF9/runinfo.txt)

**`/tmp/MarvinLogs/test_network_EBEJNE:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_network_EBEJNE/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_network_EBEJNE/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_network_EBEJNE/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_SKQ505:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_vpc_routers_SKQ505/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_vpc_routers_SKQ505/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_vpc_routers_SKQ505/runinfo.txt)


Uploads will be available until `2016-07-20 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Refactoring CitrixResourceBase

[Rafael Weingärtner]

Hi Syed,
That is a great idea; however, it is a very hard task.
The idea of Tim is great; actually, we already have some sort of hierarchy
that is used in “CitrixResourceBase.java”.
I would suggest you first removing the unused code, unused variable, and
duplicate methods; that would be one PR. You can use a tool called
UCdetector to find unused code. To find duplicated code you can use PMD.

One very good example of code duplicity are the methods called
“com.cloud.hypervisor.xenserver.resource.CitrixResourceBase.callHostPluginAsync(…)”.

After you have cleaned the class, I suggest you analyzing where each
remaining method is used and then look for the proper place to put them.
It might be a good idea on separating between singletons that are
responsible for well-defined tasks such as managing storage, networking,
VMs creating and deletion, VMs monitoring and others.

If you need any help, please do not hesitate on asking for our help.


On Thu, May 19, 2016 at 4:50 PM, Daan Hoogland 
wrote:

> Syed,
>
> gogogo. actually it has shrunk to 5k lines since 2012 ;)
>
> I like your initiative and initial direction. A lot of small steps to
> improve the blob have been taken and I would sugest to keep going in small
> steps.
>
> On Thu, May 19, 2016 at 9:44 PM, Tim Mackey  wrote:
>
> > +1
> >
> > When I went through this last time, not only was it hard to understand
> the
> > flows, but the XenServer version management was a pain. Would suggest
> > creating a base class which always works (i.e. is independent of
> XenServer
> > version) for core functions. Then add in that which exists for a specific
> > version. Should help greatly with testing IMO.
> >
> > -tim
> >
> > On Thu, May 19, 2016 at 2:37 PM, Syed Mushtaq 
> > wrote:
> >
> > > Hi All,
> > >
> > > I would like to refactor CitrixResourceBase class which is responsible
> > for
> > > communicating with Xenserver. It has grown too long (>5K lines) and has
> > > absolutely no testing.
> > >
> > > In my first pass I want to separate out the functionality buy the
> > subsystem
> > > it targets (compute, storage, network etc) and will go on from there.
> > What
> > > do you think? Is anyone working on this currently?
> > >
> > > Thanks,
> > > -Syed
> > >
> >
>
>
>
> --
> Daan
>



-- 
Rafael Weingärtner

Re: Migrating CloudStack content from download.cloud.com

[Daan Hoogland]

sounds good, so if we put both sections together the worry is over. acs is
a complex system and requires a lot of reading so let''s not put it in a
different section. would be duplicate code anyhow.

On Thu, May 19, 2016 at 11:56 PM, Chiradeep Vittal 
wrote:

> Well, you have to define "worry" :)
>
> I'm proposing an almost identical step to
>
> http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.6/management-server/#prepare-the-system-vm-template
>
> If they can do that, then it is not a stretch to assume they can download
> the default template in a similar manner. The
> "cloud-install-default-template" (proposed) script can do the mirror
> checking etc.
>
>
>
>
> On Thu, May 19, 2016 at 2:44 PM, Will Stevens 
> wrote:
>
> > I definitely agree with this.  I don't think people doing a PoC should
> have
> > to worry about getting a template installed on first setup.  I think that
> > is a basic feature if we want platform adoption.  Getting the first boot
> > process from download to first VM launched should be as smooth as
> possible.
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
> > On Thu, May 19, 2016 at 5:37 PM, Daan Hoogland 
> > wrote:
> >
> > > Chiradeep,
> > >
> > > It makes sense not to have this old default very insecure guest
> template
> > > still be downloaded but it would be nice to have some kind of meta-data
> > > pointing to the latest version of an acceptable template (symlink) for
> > > trial installs so PoCcers are swiftly on their way. Would you agree?
> > >
> > > On Thu, May 19, 2016 at 8:15 PM, Chiradeep Vittal <
> chirade...@gmail.com>
> > > wrote:
> > >
> > > > Pierre,
> > > > I meant the auto-download of default templates, not systemvm.
> > > > Note that the initial systemvm template has to be hand-downloaded
> > anyway.
> > > > If you are a single hypervisor cloud, then that is all that is
> needed.
> > > >
> > > > On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion <
> pd...@cloudops.com>
> > > > wrote:
> > > >
> > > > > I would be -1 about disabling the autodownload of the systemvm
> > > template,
> > > > > has this should be simplify deployment of a cloudstack system.
> > > > > although, the download URL should be a configurable value, maybe
> in a
> > > > > property file or thru the API somehow or via a pre-install command.
> > > > >
> > > > > I really like  download.cloudstack.org + mirror. I'm looking at
> > > getting
> > > > > the
> > > > > DNS entry: builds.cloudstack.org for the new Jenkins and I got no
> > > > > objections on using the cloudstack.org domain for community
> services
> > > so
> > > > > I'm
> > > > > pretty sure we would be ok to use download.cloudstack.org, where
> > would
> > > > we
> > > > > setting this up? on the current webserver of our website? could we
> ?
> > > > >
> > > > >
> > > > > Cheers,
> > > > >
> > > > > PL
> > > > >
> > > > > On Thu, May 19, 2016 at 11:00 AM, Giles Sirett <
> > > > giles.sir...@shapeblue.com
> > > > > >
> > > > > wrote:
> > > > >
> > > > > > Erik
> > > > > > I agree on the existing users - not the end of the world. We
> could
> > > even
> > > > > > release a tiny patch to update the DB records
> > > > > >
> > > > > > The piece that we need to be really careful with is the "I've
> just
> > > > > > downloaded cloudstack  thing for the first time" scenario
> > > > > >
> > > > > > But - there seems to be plenty of good ideas flowing on that
> > > > > >
> > > > > >
> > > > > > Kind Regards
> > > > > > Giles
> > > > > >
> > > > > >
> > > > > > giles.sir...@shapeblue.com
> > > > > > www.shapeblue.com
> > > > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > > > > @shapeblue
> > > > > >
> > > > > >
> > > > > >
> > > > > > -Original Message-
> > > > > > From: Erik Weber [mailto:terbol...@gmail.com]
> > > > > > Sent: 19 May 2016 09:32
> > > > > > To: dev 
> > > > > > Subject: Re: Migrating CloudStack content from
> download.cloud.com
> > > > > >
> > > > > > As a user (with old ACS installations) I'd say that this isn't
> all
> > > that
> > > > > > troublesome, this is easily fixed by updating the appropriate db
> > > > records.
> > > > > >
> > > > > > We should ensure that we have some good posts discovered by
> Google
> > > and
> > > > > > other search engines, so that when somebody running old
> > installations
> > > > hit
> > > > > > this issue they find the workaround.
> > > > > > There's a lot of time to reach out to users and inform of the fix
> > > > > > necessary.
> > > > > >
> > > > > > --
> > > > > > Erik
> > > > > >
> > > > > >
> > > > > > On Tue, May 17, 2016 at 10:34 AM, Giles Sirett <
> > > > > giles.sir...@shapeblue.com
> > > > > > >
> > > > > > wrote:
> > > > > >
> > > > > > > This is a MAJOR problem and needs to be figured out before the
> > > > 

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/669#issuecomment-220464828
  
Really like the functionality so I think we must get this in. I have some 
remarks about the code that I stand by even though they are not entirely to 
blame on @anshul1886 as he calls methods fthrowing Exception, rom SshHelper 
mainly. It is a bad smell due to the older code and will not facilitate trouble 
shooting for the end user. So I would like to see the exception-handlers be 
enriched with some better diagnosis and *maybe* messages. nothing else to nag 
about.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Migrating CloudStack content from download.cloud.com

[Chiradeep Vittal]

Well, you have to define "worry" :)

I'm proposing an almost identical step to
http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.6/management-server/#prepare-the-system-vm-template

If they can do that, then it is not a stretch to assume they can download
the default template in a similar manner. The
"cloud-install-default-template" (proposed) script can do the mirror
checking etc.




On Thu, May 19, 2016 at 2:44 PM, Will Stevens  wrote:

> I definitely agree with this.  I don't think people doing a PoC should have
> to worry about getting a template installed on first setup.  I think that
> is a basic feature if we want platform adoption.  Getting the first boot
> process from download to first VM launched should be as smooth as possible.
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On Thu, May 19, 2016 at 5:37 PM, Daan Hoogland 
> wrote:
>
> > Chiradeep,
> >
> > It makes sense not to have this old default very insecure guest template
> > still be downloaded but it would be nice to have some kind of meta-data
> > pointing to the latest version of an acceptable template (symlink) for
> > trial installs so PoCcers are swiftly on their way. Would you agree?
> >
> > On Thu, May 19, 2016 at 8:15 PM, Chiradeep Vittal 
> > wrote:
> >
> > > Pierre,
> > > I meant the auto-download of default templates, not systemvm.
> > > Note that the initial systemvm template has to be hand-downloaded
> anyway.
> > > If you are a single hypervisor cloud, then that is all that is needed.
> > >
> > > On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion 
> > > wrote:
> > >
> > > > I would be -1 about disabling the autodownload of the systemvm
> > template,
> > > > has this should be simplify deployment of a cloudstack system.
> > > > although, the download URL should be a configurable value, maybe in a
> > > > property file or thru the API somehow or via a pre-install command.
> > > >
> > > > I really like  download.cloudstack.org + mirror. I'm looking at
> > getting
> > > > the
> > > > DNS entry: builds.cloudstack.org for the new Jenkins and I got no
> > > > objections on using the cloudstack.org domain for community services
> > so
> > > > I'm
> > > > pretty sure we would be ok to use download.cloudstack.org, where
> would
> > > we
> > > > setting this up? on the current webserver of our website? could we ?
> > > >
> > > >
> > > > Cheers,
> > > >
> > > > PL
> > > >
> > > > On Thu, May 19, 2016 at 11:00 AM, Giles Sirett <
> > > giles.sir...@shapeblue.com
> > > > >
> > > > wrote:
> > > >
> > > > > Erik
> > > > > I agree on the existing users - not the end of the world. We could
> > even
> > > > > release a tiny patch to update the DB records
> > > > >
> > > > > The piece that we need to be really careful with is the "I've just
> > > > > downloaded cloudstack  thing for the first time" scenario
> > > > >
> > > > > But - there seems to be plenty of good ideas flowing on that
> > > > >
> > > > >
> > > > > Kind Regards
> > > > > Giles
> > > > >
> > > > >
> > > > > giles.sir...@shapeblue.com
> > > > > www.shapeblue.com
> > > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > > > @shapeblue
> > > > >
> > > > >
> > > > >
> > > > > -Original Message-
> > > > > From: Erik Weber [mailto:terbol...@gmail.com]
> > > > > Sent: 19 May 2016 09:32
> > > > > To: dev 
> > > > > Subject: Re: Migrating CloudStack content from download.cloud.com
> > > > >
> > > > > As a user (with old ACS installations) I'd say that this isn't all
> > that
> > > > > troublesome, this is easily fixed by updating the appropriate db
> > > records.
> > > > >
> > > > > We should ensure that we have some good posts discovered by Google
> > and
> > > > > other search engines, so that when somebody running old
> installations
> > > hit
> > > > > this issue they find the workaround.
> > > > > There's a lot of time to reach out to users and inform of the fix
> > > > > necessary.
> > > > >
> > > > > --
> > > > > Erik
> > > > >
> > > > >
> > > > > On Tue, May 17, 2016 at 10:34 AM, Giles Sirett <
> > > > giles.sir...@shapeblue.com
> > > > > >
> > > > > wrote:
> > > > >
> > > > > > This is a MAJOR problem and needs to be figured out before the
> > > current
> > > > > > download site is removed - @Raja - have Citrix committed to it
> > being
> > > > > there
> > > > > > another year ?
> > > > > >
> > > > > > It is my understanding that Cloudstack relies on this download at
> > > > initial
> > > > > > build/startup and then periodically if people do things like
> build
> > a
> > > > new
> > > > > > zone
> > > > > >
> > > > > > So, users environments aren't going to stop if its pulled, but
> > nobody
> > > > > > would be a able to build/install cloudstack and it may cause
> issues
> > > as
> > > > > and
> > > > > 

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r63961096
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package com.cloud.hypervisor.xenserver.resource.wrapper.xenbase;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.xenserver.resource.CitrixResourceBase;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ExecutionResult;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class CitrixCopyFileInVmCommandWrapper  extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(CitrixCopyFileInVmCommandWrapper.class);
+
+@Override
+public Answer execute(final CopyFileInVmCommand cmd, final 
CitrixResourceBase citrixResourceBase) {
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for(File f : FileUtils.listFiles(file, 
TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+ExecutionResult result = 
citrixResourceBase.copyFileInVm(cmd.getVmIp(), f, cmd.getDest());
+if(!result.isSuccess()) {
+return new CopyFileInVmAnswer(cmd, 
result.getDetails());
+}
+}
+} else {
+ExecutionResult result = 
citrixResourceBase.copyFileInVm(cmd.getVmIp(), file, cmd.getDest());
+if(!result.isSuccess()) {
+return new CopyFileInVmAnswer(cmd, 
result.getDetails());
+}
+}
+}
+
+} catch (Exception e) {
--- End diff --

please catch more specific exceptions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r63960701
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -5402,4 +5402,20 @@ public boolean 
attachConfigDriveToMigratedVm(Connection conn, String vmName, Str
 
 }
 
-}
+public ExecutionResult copyFileInVm(String vmIp, File file, String 
dest) {
+final Connection conn = getConnection();
+final String hostPath = "/tmp/";
+
+s_logger.debug("Copying file to VM with ip " + vmIp + " using host 
" + _host.getIp());
+try {
+SshHelper.scpTo(_host.getIp(), 22, _username, null, 
_password.peek(), hostPath, file.getCanonicalPath(), null);
+} catch (final Exception e) {
--- End diff --

please catch more specific exceptions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r63960622
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -1298,6 +1304,27 @@ private static DiskTO getIsoDiskTO(DiskTO[] disks) {
 return null;
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+VmwareManager mgr = 
getServiceContext().getStockObject(VmwareManager.CONTEXT_STOCK_NAME);
+File keyFile = mgr.getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
--- End diff --

please catch more specific exception(s)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r63959786
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
--- End diff --

please replace the two lines above with
```try (File file = new File(cmd.getSrc());) {```
 to make sure the file resource is closed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r63959351
  
--- Diff: 
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 ---
@@ -594,6 +597,25 @@ private PlugNicAnswer execute(final PlugNicCommand 
cmd) {
 }
 }
 
+private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+File keyFile = getSystemVMKeyFile();
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
--- End diff --

can you catch more specific exceptions here, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Migrating CloudStack content from download.cloud.com

[Will Stevens]

I definitely agree with this.  I don't think people doing a PoC should have
to worry about getting a template installed on first setup.  I think that
is a basic feature if we want platform adoption.  Getting the first boot
process from download to first VM launched should be as smooth as possible.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Thu, May 19, 2016 at 5:37 PM, Daan Hoogland 
wrote:

> Chiradeep,
>
> It makes sense not to have this old default very insecure guest template
> still be downloaded but it would be nice to have some kind of meta-data
> pointing to the latest version of an acceptable template (symlink) for
> trial installs so PoCcers are swiftly on their way. Would you agree?
>
> On Thu, May 19, 2016 at 8:15 PM, Chiradeep Vittal 
> wrote:
>
> > Pierre,
> > I meant the auto-download of default templates, not systemvm.
> > Note that the initial systemvm template has to be hand-downloaded anyway.
> > If you are a single hypervisor cloud, then that is all that is needed.
> >
> > On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion 
> > wrote:
> >
> > > I would be -1 about disabling the autodownload of the systemvm
> template,
> > > has this should be simplify deployment of a cloudstack system.
> > > although, the download URL should be a configurable value, maybe in a
> > > property file or thru the API somehow or via a pre-install command.
> > >
> > > I really like  download.cloudstack.org + mirror. I'm looking at
> getting
> > > the
> > > DNS entry: builds.cloudstack.org for the new Jenkins and I got no
> > > objections on using the cloudstack.org domain for community services
> so
> > > I'm
> > > pretty sure we would be ok to use download.cloudstack.org, where would
> > we
> > > setting this up? on the current webserver of our website? could we ?
> > >
> > >
> > > Cheers,
> > >
> > > PL
> > >
> > > On Thu, May 19, 2016 at 11:00 AM, Giles Sirett <
> > giles.sir...@shapeblue.com
> > > >
> > > wrote:
> > >
> > > > Erik
> > > > I agree on the existing users - not the end of the world. We could
> even
> > > > release a tiny patch to update the DB records
> > > >
> > > > The piece that we need to be really careful with is the "I've just
> > > > downloaded cloudstack  thing for the first time" scenario
> > > >
> > > > But - there seems to be plenty of good ideas flowing on that
> > > >
> > > >
> > > > Kind Regards
> > > > Giles
> > > >
> > > >
> > > > giles.sir...@shapeblue.com
> > > > www.shapeblue.com
> > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > > @shapeblue
> > > >
> > > >
> > > >
> > > > -Original Message-
> > > > From: Erik Weber [mailto:terbol...@gmail.com]
> > > > Sent: 19 May 2016 09:32
> > > > To: dev 
> > > > Subject: Re: Migrating CloudStack content from download.cloud.com
> > > >
> > > > As a user (with old ACS installations) I'd say that this isn't all
> that
> > > > troublesome, this is easily fixed by updating the appropriate db
> > records.
> > > >
> > > > We should ensure that we have some good posts discovered by Google
> and
> > > > other search engines, so that when somebody running old installations
> > hit
> > > > this issue they find the workaround.
> > > > There's a lot of time to reach out to users and inform of the fix
> > > > necessary.
> > > >
> > > > --
> > > > Erik
> > > >
> > > >
> > > > On Tue, May 17, 2016 at 10:34 AM, Giles Sirett <
> > > giles.sir...@shapeblue.com
> > > > >
> > > > wrote:
> > > >
> > > > > This is a MAJOR problem and needs to be figured out before the
> > current
> > > > > download site is removed - @Raja - have Citrix committed to it
> being
> > > > there
> > > > > another year ?
> > > > >
> > > > > It is my understanding that Cloudstack relies on this download at
> > > initial
> > > > > build/startup and then periodically if people do things like build
> a
> > > new
> > > > > zone
> > > > >
> > > > > So, users environments aren't going to stop if its pulled, but
> nobody
> > > > > would be a able to build/install cloudstack and it may cause issues
> > as
> > > > and
> > > > > when users make config changes
> > > > >
> > > > > The problem is, for new builds, its hard coded : you start the  Sec
> > > > > Storage VM, CloudStack will try to download the built in template
> > from
> > > > > download.cloud.com
> > > > >
> > > > > My understanding is that its simple db  change to make once an
> > > > environment
> > > > > is running (exisiting users) but *may* require a code patch to fix
> > the
> > > > > initial install
> > > > >
> > > > > #notideal
> > > > >
> > > > > Really, this should be maintained by ASF/ the project as its key to
> > the
> > > > > software working, however my understanding is it involves binaries
> > > which
> > > > > ASF is never keen on (and may be some 3rd party binaries) - so that
> > > just
> 

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/669#discussion_r63959496
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
 ---
@@ -0,0 +1,59 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing,
+ *   software distributed under the License is distributed on an
+ *   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *   KIND, either express or implied.  See the License for the
+ *   specific language governing permissions and limitations
+ *   under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper   extends 
CommandWrapper {
+
+private static final Logger s_logger = 
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd, 
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
+if(file.exists()) {
+if(file.isDirectory()) {
+for (File f : FileUtils.listFiles(new 
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", 
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+}
+} else {
+SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile, 
null, cmd.getDest(), file.getCanonicalPath(), null);
+}
+}
+} catch (Exception e) {
--- End diff --

please, catch more specific exceptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Migrating CloudStack content from download.cloud.com

[Daan Hoogland]

Chiradeep,

It makes sense not to have this old default very insecure guest template
still be downloaded but it would be nice to have some kind of meta-data
pointing to the latest version of an acceptable template (symlink) for
trial installs so PoCcers are swiftly on their way. Would you agree?

On Thu, May 19, 2016 at 8:15 PM, Chiradeep Vittal 
wrote:

> Pierre,
> I meant the auto-download of default templates, not systemvm.
> Note that the initial systemvm template has to be hand-downloaded anyway.
> If you are a single hypervisor cloud, then that is all that is needed.
>
> On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion 
> wrote:
>
> > I would be -1 about disabling the autodownload of the systemvm template,
> > has this should be simplify deployment of a cloudstack system.
> > although, the download URL should be a configurable value, maybe in a
> > property file or thru the API somehow or via a pre-install command.
> >
> > I really like  download.cloudstack.org + mirror. I'm looking at getting
> > the
> > DNS entry: builds.cloudstack.org for the new Jenkins and I got no
> > objections on using the cloudstack.org domain for community services so
> > I'm
> > pretty sure we would be ok to use download.cloudstack.org, where would
> we
> > setting this up? on the current webserver of our website? could we ?
> >
> >
> > Cheers,
> >
> > PL
> >
> > On Thu, May 19, 2016 at 11:00 AM, Giles Sirett <
> giles.sir...@shapeblue.com
> > >
> > wrote:
> >
> > > Erik
> > > I agree on the existing users - not the end of the world. We could even
> > > release a tiny patch to update the DB records
> > >
> > > The piece that we need to be really careful with is the "I've just
> > > downloaded cloudstack  thing for the first time" scenario
> > >
> > > But - there seems to be plenty of good ideas flowing on that
> > >
> > >
> > > Kind Regards
> > > Giles
> > >
> > >
> > > giles.sir...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > @shapeblue
> > >
> > >
> > >
> > > -Original Message-
> > > From: Erik Weber [mailto:terbol...@gmail.com]
> > > Sent: 19 May 2016 09:32
> > > To: dev 
> > > Subject: Re: Migrating CloudStack content from download.cloud.com
> > >
> > > As a user (with old ACS installations) I'd say that this isn't all that
> > > troublesome, this is easily fixed by updating the appropriate db
> records.
> > >
> > > We should ensure that we have some good posts discovered by Google and
> > > other search engines, so that when somebody running old installations
> hit
> > > this issue they find the workaround.
> > > There's a lot of time to reach out to users and inform of the fix
> > > necessary.
> > >
> > > --
> > > Erik
> > >
> > >
> > > On Tue, May 17, 2016 at 10:34 AM, Giles Sirett <
> > giles.sir...@shapeblue.com
> > > >
> > > wrote:
> > >
> > > > This is a MAJOR problem and needs to be figured out before the
> current
> > > > download site is removed - @Raja - have Citrix committed to it being
> > > there
> > > > another year ?
> > > >
> > > > It is my understanding that Cloudstack relies on this download at
> > initial
> > > > build/startup and then periodically if people do things like build a
> > new
> > > > zone
> > > >
> > > > So, users environments aren't going to stop if its pulled, but nobody
> > > > would be a able to build/install cloudstack and it may cause issues
> as
> > > and
> > > > when users make config changes
> > > >
> > > > The problem is, for new builds, its hard coded : you start the  Sec
> > > > Storage VM, CloudStack will try to download the built in template
> from
> > > > download.cloud.com
> > > >
> > > > My understanding is that its simple db  change to make once an
> > > environment
> > > > is running (exisiting users) but *may* require a code patch to fix
> the
> > > > initial install
> > > >
> > > > #notideal
> > > >
> > > > Really, this should be maintained by ASF/ the project as its key to
> the
> > > > software working, however my understanding is it involves binaries
> > which
> > > > ASF is never keen on (and may be some 3rd party binaries) - so that
> > just
> > > > wont happen
> > > >
> > > >
> > > >
> > > > Apt-get is controlled by Wido et al (for which we all owe him a
> massive
> > > > thanks)  - but you are right, it is a 3rd party dependency and
> > arguably a
> > > > SPOF.  But, if ASF wont host binaries, we're always going to have
> this
> > > > issue.
> > > >
> > > > So, we could patch the code to point somewhere else - but where ? -
> by
> > > > definition its got to be something maintained by a 3rd party
> > > >
> > > >
> > > > We had this debate some time ago when talking about the repositories.
> > We
> > > > (ShapeBlue) maintain a repo for our customers, which wev'e always
> > opened
> > > up
> > > > as public. However, there were concerns about having a company domain
> > > name
> > > > (which I understand) - so apt-get became 

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220458013
  
thanks @KrisSterckx, and to make it even more very clear: basically you 
will only need to install acs and nuage and configure them correctly. neat. you 
guys are a rocking vendor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1518#discussion_r63955721
  
--- Diff: 
engine/storage/src/org/apache/cloudstack/storage/image/NfsImageStoreDriverImpl.java
 ---
@@ -0,0 +1,30 @@
+package org.apache.cloudstack.storage.image;
--- End diff --

license missing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/669#issuecomment-220447959
  
I think with @milamberspace's review, we are only missing one code review 
to get this one in.  Thanks everyone...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Made the adding new keyboard language sup...

[milamberspace]

Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/669#issuecomment-220446031
  

LGTM. 
Tested manually with a real test deployment of CS49, with my French azerty 
keyboard: works fine.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220440726
  
@swill I will work on the changes tomorrow morning (my time, CET). 
Shouldn't be very hard to do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-220433360
  
@swill I must have made a booboo spliting the style parts from the test 
upgrades. I will look at it over the weekend.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Refactoring CitrixResourceBase

[Daan Hoogland]

Syed,

gogogo. actually it has shrunk to 5k lines since 2012 ;)

I like your initiative and initial direction. A lot of small steps to
improve the blob have been taken and I would sugest to keep going in small
steps.

On Thu, May 19, 2016 at 9:44 PM, Tim Mackey  wrote:

> +1
>
> When I went through this last time, not only was it hard to understand the
> flows, but the XenServer version management was a pain. Would suggest
> creating a base class which always works (i.e. is independent of XenServer
> version) for core functions. Then add in that which exists for a specific
> version. Should help greatly with testing IMO.
>
> -tim
>
> On Thu, May 19, 2016 at 2:37 PM, Syed Mushtaq 
> wrote:
>
> > Hi All,
> >
> > I would like to refactor CitrixResourceBase class which is responsible
> for
> > communicating with Xenserver. It has grown too long (>5K lines) and has
> > absolutely no testing.
> >
> > In my first pass I want to separate out the functionality buy the
> subsystem
> > it targets (compute, storage, network etc) and will go on from there.
> What
> > do you think? Is anyone working on this currently?
> >
> > Thanks,
> > -Syed
> >
>



-- 
Daan

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1511#issuecomment-220431955
  
This is failing to build for me.
```
Running org.apache.cloudstack.affinity.AffinityApiUnitTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.086 sec - 
in org.apache.cloudstack.affinity.AffinityApiUnitTest
Running org.apache.cloudstack.network.lb.CertServiceTest
Tests run: 13, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.63 sec 
<<< FAILURE! - in org.apache.cloudstack.network.lb.CertServiceTest

runUploadSslCertBadkeyAlgo(org.apache.cloudstack.network.lb.CertServiceTest)  
Time elapsed: 0.476 sec  <<< FAILURE!
java.lang.AssertionError: Did not expect message: Error parsing certificate 
data Parsing certificate/key failed: Invalid Key format.
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at 
org.apache.cloudstack.network.lb.CertServiceTest.runUploadSslCertBadkeyAlgo(CertServiceTest.java:480)


runUploadSslCertBadPassword(org.apache.cloudstack.network.lb.CertServiceTest)  
Time elapsed: 0.006 sec  <<< FAILURE!
java.lang.AssertionError: Did not expect message: Error parsing certificate 
data Parsing certificate/key failed: Invalid Key format.
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at 
org.apache.cloudstack.network.lb.CertServiceTest.runUploadSslCertBadPassword(CertServiceTest.java:392)

Running org.apache.cloudstack.network.lb.ApplicationLoadBalancerTest
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.105 sec 
- in org.apache.cloudstack.network.lb.ApplicationLoadBalancerTest
Running 
org.cloud.network.router.deployment.VpcRouterDeploymentDefinitionTest
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.17 sec - 
in org.cloud.network.router.deployment.VpcRouterDeploymentDefinitionTest
Running org.cloud.network.router.deployment.RouterDeploymentDefinitionTest
Tests run: 39, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.113 sec 
- in org.cloud.network.router.deployment.RouterDeploymentDefinitionTest

Results :

Failed tests:
  CertServiceTest.runUploadSslCertBadPassword:392 Did not expect message: 
Error parsing certificate data Parsing certificate/key failed: Invalid Key 
format.
  CertServiceTest.runUploadSslCertBadkeyAlgo:480 Did not expect message: 
Error parsing certificate data Parsing certificate/key failed: Invalid Key 
format.

Tests run: 359, Failures: 2, Errors: 0, Skipped: 5
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Refactoring CitrixResourceBase

[Tim Mackey]

+1

When I went through this last time, not only was it hard to understand the
flows, but the XenServer version management was a pain. Would suggest
creating a base class which always works (i.e. is independent of XenServer
version) for core functions. Then add in that which exists for a specific
version. Should help greatly with testing IMO.

-tim

On Thu, May 19, 2016 at 2:37 PM, Syed Mushtaq 
wrote:

> Hi All,
>
> I would like to refactor CitrixResourceBase class which is responsible for
> communicating with Xenserver. It has grown too long (>5K lines) and has
> absolutely no testing.
>
> In my first pass I want to separate out the functionality buy the subsystem
> it targets (compute, storage, network etc) and will go on from there. What
> do you think? Is anyone working on this currently?
>
> Thanks,
> -Syed
>

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-220427628
  
@koushik-das I pushed new changes including an intermediate class as you 
suggested
@swill hopefully CI passes now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Refactoring CitrixResourceBase

[Syed Mushtaq]

Hi All,

I would like to refactor CitrixResourceBase class which is responsible for
communicating with Xenserver. It has grown too long (>5K lines) and has
absolutely no testing.

In my first pass I want to separate out the functionality buy the subsystem
it targets (compute, storage, network etc) and will go on from there. What
do you think? Is anyone working on this currently?

Thanks,
-Syed

[ANNOUNCE] GitHub Changes

[Will Stevens]

Hey Everyone,
As Seb alluded to in the VP announcement thread, we have some reasonably
big news to report.

As many of you know, we have been working with the ASF to find ways to
better utilize the features of Github.  Github has been working very well
as a medium for managing pull requests and handling code review.
Unfortunately, due to a lack of permission granularity at
the Github organization level, we have not been able to take advantage
of features such as labels, commit hooks and other similar functionality.

I am happy to report that the ASF has approved a proposal put forward by
the ACS PMC to move the 'cloudstack' mirror repository on Github from the
'apache' Github organization to the 'apachecloudstack' Github
organization.  With this move, the ACS PMC will have more control over the
permissions in the organization, enabling us to use features such as
labels, commit hooks, etc, without it affecting every other apache project.

This is a major step for us to be able to better integrate automated
testing, as well as remove a lot of the busy work from the RM in
maintaining the status of every PR.

The PMC will be working with the ASF Infra team to work out the final
logistical details for the move and agree on how we should handle some of
the permission delegation in the new 'apachecloudstack' Github organization.

The development workflow and the commit process will not change.  The
'apachecloudstack/cloudstack' repo will remain a read-only mirror of the
canonical ASF repository and committers will still have to push commits to
the ASF repo.  Ross Gardler, the ASF chair, has a proposal in play to allow
Apache projects to use Github as their canonical repositories, but there
are still many challenges to be resolved before that can take effect.  We
will likely adopt that option when it becomes available, but there is no
timeline yet for that proposal as more work needs to be done to make it a
reality.

I have attached the proposal put forth by the PMC, which the ASF accepted,
so everyone has a clearer understanding of the changes we can expect to see
in the near future.

Cheers,

Will



## Objective:
   The purpose of this report is to expedite the process of moving the
GitHub
   mirror from `apache/cloudstack` to `apachecloudstack/cloudstack` as per
the
   details outlined in this report.  We would like to request that the ASF
Board
   consider this report and approve the move.  We would also request that
the
   ASF Infra team engage with us and do the actual transfer.

## Description:
   Apache CloudStack (ACS) is an IaaS (Infrastructure as a Service) cloud
   orchestration platform.  ACS manages many types of hypervisors, storage
and
   networking devices. Due to the infrastructure complexity, testing and
   validating ACS is a time consuming and costly endeavor.  Our community
is
   willing to share the labor and costs associated with building
distributed and
   automated testing environments, but we are facing many challenges with
the
   available automation integration points.

## Issue:
   Apache CloudStack has been making extensive use of GitHub pull requests
and
   they have become integral in the development workflow in our community.
The
   ACS GitHub repository is a mirror of the ASF repository, which is used
as the
   source of truth for the project code and only committers can contribute
to
   the ASF repository.  Currently the ACS GitHub repository is under the
   `apache` GitHub organization.  Unfortunately, due to the lack of
permissions
   on specific repositories inside a GitHub organization, no changes can be
made
   to a single repository without being applied to all repositories under
that
   organization.  This has become a problem for our project because we do
not
   have access to features such as being able to Label pull requests or add
   post commit hooks in order to kick off Continuous Integration runs when a
   branch changes, to give a couple examples.

   The ACS PMC has proposed and voted on a resolution to move the ACS GitHub
   mirror out of the `apache` GitHub organization and into the
   `apachecloudstack` GitHub organization.  The commit workflow will not
change
   and the ASF git repository will remain the source of truth for the
project.
   Both the ASF Infra team and members of the ACS PMC will have ownership
rights
   on the `apachecloudstack` GitHub organization.

   There are many motivating factors for this change, a few of which are
briefly
   outlined in the following list:
   - The Release Management of the ACS project has been a daunting task due
to
 a highly manual process, with very few hooks for support from the
greater
 community or through automation.  The RM task is currently a full time
job,
 making it difficult to find individuals willing to step up to the RM
role.
 This has had a negative impact on our project because periods of time
 without a RM gives the impression that the project is stagnant.
   - The ability to 

Re: Migrating CloudStack content from download.cloud.com

[Chiradeep Vittal]

Pierre,
I meant the auto-download of default templates, not systemvm.
Note that the initial systemvm template has to be hand-downloaded anyway.
If you are a single hypervisor cloud, then that is all that is needed.

On Thu, May 19, 2016 at 11:08 AM, Pierre-Luc Dion 
wrote:

> I would be -1 about disabling the autodownload of the systemvm template,
> has this should be simplify deployment of a cloudstack system.
> although, the download URL should be a configurable value, maybe in a
> property file or thru the API somehow or via a pre-install command.
>
> I really like  download.cloudstack.org + mirror. I'm looking at getting
> the
> DNS entry: builds.cloudstack.org for the new Jenkins and I got no
> objections on using the cloudstack.org domain for community services so
> I'm
> pretty sure we would be ok to use download.cloudstack.org, where would we
> setting this up? on the current webserver of our website? could we ?
>
>
> Cheers,
>
> PL
>
> On Thu, May 19, 2016 at 11:00 AM, Giles Sirett  >
> wrote:
>
> > Erik
> > I agree on the existing users - not the end of the world. We could even
> > release a tiny patch to update the DB records
> >
> > The piece that we need to be really careful with is the "I've just
> > downloaded cloudstack  thing for the first time" scenario
> >
> > But - there seems to be plenty of good ideas flowing on that
> >
> >
> > Kind Regards
> > Giles
> >
> >
> > giles.sir...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> > -Original Message-
> > From: Erik Weber [mailto:terbol...@gmail.com]
> > Sent: 19 May 2016 09:32
> > To: dev 
> > Subject: Re: Migrating CloudStack content from download.cloud.com
> >
> > As a user (with old ACS installations) I'd say that this isn't all that
> > troublesome, this is easily fixed by updating the appropriate db records.
> >
> > We should ensure that we have some good posts discovered by Google and
> > other search engines, so that when somebody running old installations hit
> > this issue they find the workaround.
> > There's a lot of time to reach out to users and inform of the fix
> > necessary.
> >
> > --
> > Erik
> >
> >
> > On Tue, May 17, 2016 at 10:34 AM, Giles Sirett <
> giles.sir...@shapeblue.com
> > >
> > wrote:
> >
> > > This is a MAJOR problem and needs to be figured out before the current
> > > download site is removed - @Raja - have Citrix committed to it being
> > there
> > > another year ?
> > >
> > > It is my understanding that Cloudstack relies on this download at
> initial
> > > build/startup and then periodically if people do things like build a
> new
> > > zone
> > >
> > > So, users environments aren't going to stop if its pulled, but nobody
> > > would be a able to build/install cloudstack and it may cause issues as
> > and
> > > when users make config changes
> > >
> > > The problem is, for new builds, its hard coded : you start the  Sec
> > > Storage VM, CloudStack will try to download the built in template from
> > > download.cloud.com
> > >
> > > My understanding is that its simple db  change to make once an
> > environment
> > > is running (exisiting users) but *may* require a code patch to fix the
> > > initial install
> > >
> > > #notideal
> > >
> > > Really, this should be maintained by ASF/ the project as its key to the
> > > software working, however my understanding is it involves binaries
> which
> > > ASF is never keen on (and may be some 3rd party binaries) - so that
> just
> > > wont happen
> > >
> > >
> > >
> > > Apt-get is controlled by Wido et al (for which we all owe him a massive
> > > thanks)  - but you are right, it is a 3rd party dependency and
> arguably a
> > > SPOF.  But, if ASF wont host binaries, we're always going to have this
> > > issue.
> > >
> > > So, we could patch the code to point somewhere else - but where ? - by
> > > definition its got to be something maintained by a 3rd party
> > >
> > >
> > > We had this debate some time ago when talking about the repositories.
> We
> > > (ShapeBlue) maintain a repo for our customers, which wev'e always
> opened
> > up
> > > as public. However, there were concerns about having a company domain
> > name
> > > (which I understand) - so apt-get became our preferred repo.
> > >
> > >
> > > Thoughts on how to fix this:
> > >
> > > 1. if ASF would allow us to create the host entry
> > download.cloudstack.org.
> > > Its under their domain, but with the site being with a 3rd party it
> could
> > > be allowed
> > >
> > > 2. maybe Citrix could commit to pointing the current DNS entry to a new
> > > location (would be simplest but may be legally complex and relies on
> > > ongoing goodwill)
> > >
> > > 3. make a mod to allow users to choose the download location on
> install.
> > > We can then maintain apt-get. To remove the SPOF, we could then get the
> > > templates copied to a number of 3rd party locations 

Re: Migrating CloudStack content from download.cloud.com

[Pierre-Luc Dion]

I would be -1 about disabling the autodownload of the systemvm template,
has this should be simplify deployment of a cloudstack system.
although, the download URL should be a configurable value, maybe in a
property file or thru the API somehow or via a pre-install command.

I really like  download.cloudstack.org + mirror. I'm looking at getting the
DNS entry: builds.cloudstack.org for the new Jenkins and I got no
objections on using the cloudstack.org domain for community services so I'm
pretty sure we would be ok to use download.cloudstack.org, where would we
setting this up? on the current webserver of our website? could we ?


Cheers,

PL

On Thu, May 19, 2016 at 11:00 AM, Giles Sirett 
wrote:

> Erik
> I agree on the existing users - not the end of the world. We could even
> release a tiny patch to update the DB records
>
> The piece that we need to be really careful with is the "I've just
> downloaded cloudstack  thing for the first time" scenario
>
> But - there seems to be plenty of good ideas flowing on that
>
>
> Kind Regards
> Giles
>
>
> giles.sir...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> -Original Message-
> From: Erik Weber [mailto:terbol...@gmail.com]
> Sent: 19 May 2016 09:32
> To: dev 
> Subject: Re: Migrating CloudStack content from download.cloud.com
>
> As a user (with old ACS installations) I'd say that this isn't all that
> troublesome, this is easily fixed by updating the appropriate db records.
>
> We should ensure that we have some good posts discovered by Google and
> other search engines, so that when somebody running old installations hit
> this issue they find the workaround.
> There's a lot of time to reach out to users and inform of the fix
> necessary.
>
> --
> Erik
>
>
> On Tue, May 17, 2016 at 10:34 AM, Giles Sirett  >
> wrote:
>
> > This is a MAJOR problem and needs to be figured out before the current
> > download site is removed - @Raja - have Citrix committed to it being
> there
> > another year ?
> >
> > It is my understanding that Cloudstack relies on this download at initial
> > build/startup and then periodically if people do things like build a new
> > zone
> >
> > So, users environments aren't going to stop if its pulled, but nobody
> > would be a able to build/install cloudstack and it may cause issues as
> and
> > when users make config changes
> >
> > The problem is, for new builds, its hard coded : you start the  Sec
> > Storage VM, CloudStack will try to download the built in template from
> > download.cloud.com
> >
> > My understanding is that its simple db  change to make once an
> environment
> > is running (exisiting users) but *may* require a code patch to fix the
> > initial install
> >
> > #notideal
> >
> > Really, this should be maintained by ASF/ the project as its key to the
> > software working, however my understanding is it involves binaries which
> > ASF is never keen on (and may be some 3rd party binaries) - so that just
> > wont happen
> >
> >
> >
> > Apt-get is controlled by Wido et al (for which we all owe him a massive
> > thanks)  - but you are right, it is a 3rd party dependency and arguably a
> > SPOF.  But, if ASF wont host binaries, we're always going to have this
> > issue.
> >
> > So, we could patch the code to point somewhere else - but where ? - by
> > definition its got to be something maintained by a 3rd party
> >
> >
> > We had this debate some time ago when talking about the repositories. We
> > (ShapeBlue) maintain a repo for our customers, which wev'e always opened
> up
> > as public. However, there were concerns about having a company domain
> name
> > (which I understand) - so apt-get became our preferred repo.
> >
> >
> > Thoughts on how to fix this:
> >
> > 1. if ASF would allow us to create the host entry
> download.cloudstack.org.
> > Its under their domain, but with the site being with a 3rd party it could
> > be allowed
> >
> > 2. maybe Citrix could commit to pointing the current DNS entry to a new
> > location (would be simplest but may be legally complex and relies on
> > ongoing goodwill)
> >
> > 3. make a mod to allow users to choose the download location on install.
> > We can then maintain apt-get. To remove the SPOF, we could then get the
> > templates copied to a number of 3rd party locations and allow people to
> > choose which one they use
> >
> >
> >
> >
> > Kind Regards
> > Giles
> >
> >
> > giles.sir...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> > -Original Message-
> > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > Behalf Of Will Stevens
> > Sent: 16 May 2016 18:59
> > To: dev@cloudstack.apache.org
> > Cc: Wido den Hollander 
> > Subject: Re: Migrating CloudStack content from download.cloud.com
> >
> > @Ian, yes, but I 

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-220397187
  
@rhtyd thanks, just wanted to make sure we extracted anything that was 
useful from @anshul1886's experience.  Thanks for working this out guys...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-220396410
  
I will kick off another CI run just to verify again.  Thanks for the update 
on this @ustcweizhou.  👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220395388
  
I already started another run against this PR, so that should also validate 
nothing was accidentally broken.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[KrisSterckx]

Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220394412
  
Hi @DaanHoogland 

The architecture is 

`cloudstack   ---cmp-->  nuage-vsp-acs-client  ---cfg-->  
Nuage VSP platform`

with 

- nuagevsp-plugin : the plugin in cloudstack
- nuage-vsp-acs-client : publicly available middleware which glues the 
plugin to the Nuage VSP platform
- Nuage VSP platform : the Nuage Networks SDN platform, commercially 
available (http://www.nuagenetworks.net)

and

- `---cmp-->` a compile-time dependency (resolved by Maven, cfr @nlivens's 
update of the pom file)
- `---cfg-->` a configuration-time dependency, resolved at cloudstack 
infrastructure provisioning time when adding the cloudstack NuageVsp device to 
its Physical Network (and part of that, provisioning the API URL and 
credentials of the Nuage VSP platform itself).

Adding the NuageVsp device in cloudstack will fail when invalid Nuage VSP 
configuration is submitted (wrong API URL and/or wrong credentials) (as at that 
time the nuage-vsp-acs-client software will attempt to logon to the specified 
Nuage VSP platform), which would happen when the user has no Nuage VSP platform 
at all. The end-result of that is that no device is added, and so the physical 
network remaining unusable until another device is added.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1516#issuecomment-220393200
  
Thank you for the clean up.  It looks much better now.  I will rerun CI on 
this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-220389940
  
@swill the problem was environment dependent where an unclean environment 
was used to build/run management server, it is recommended to git clean -fdx 
one's local repository (or at least run a mvn clean -P developer,systemvm 
-Dnoredist -Dsimulator) to get rid of old files.

The case has been documented on the FS that for `dynamic roles feature to 
work the setting value should be true and there should be no 
commands.properties file readable on the classpath`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: jenkins pr check

[Will Stevens]

Ya, we will see if people actually do kick off new jenkins runs.  I will
follow up with a few people to ask them to as I know their PRs are running
into some of the problems we have discussed.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Thu, May 19, 2016 at 11:45 AM, Daan Hoogland 
wrote:

> Maybe I should have formulated my request A little less open minded :) Hope
> it did help. As I choose one of two possible solutions let me know if I
> should try the other one.
>
> On Thu, May 19, 2016 at 5:25 PM, Will Stevens 
> wrote:
>
> > Haha.  Too bad you can't batch this email to a smaller groups.  Daan just
> > crashed the Jenkins...  :P
> >
> > Seriously, thank you for your help on this.  I think this will make a big
> > difference going forward.
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
> > On Thu, May 19, 2016 at 7:46 AM, Daan Hoogland 
> > wrote:
> >
> > > People,
> > >
> > > I've asked several people to reopen their pr because of jenkins
> > > configuration problems. I think i found the little checkbox that needed
> > > setting now. Please do not hurry but reopen any failed PRs on jenkins
> > > problems, if you fell it wasn't in your code. don't do it all at once
> as
> > > builds.a.o is kind of heavily loaded.
> > >
> > > --
> > > Daan
> > >
> >
>
>
>
> --
> Daan
>

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-220385286
  
Thanks guys for getting that sorted out.  Is the problems that @anshul1886 
ran into something that others could potentially run into?  Would it be useful 
to document the problem and the solution so others can benefit from it if they 
run into it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Sateesh Chodapuneedi]

Congrats, Will!
Wish you the best.

Regards,
Sateesh Chodapuneedi
Chief Product Engineer, CloudPlatform Development, Accelerite.
Off: +91 80 6772 1329 | EMail: sateesh.chodapune...@accelerite.com

> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: Thursday, May 19, 2016 12:27 PM
> To: dev@cloudstack.apache.org; market...@cloudstack.apache.org;
> us...@cloudstack.apache.org
> Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
>
> Morning Everyone,
>
> Yesterday at the ASF board meeting, the board passed the resolution making
> Will Stevens the new Vice President of the Apache CloudStack project.
>
> Join me in congratulating Will on this appointment, wish him luck and bring 
> your
> unwavering support !
>
> You may have noticed that Will took on RM duties for the new releases going
> forward and has also taken a very active role to finish bringing us to github
> based  workflow and CI. Will has some updates on that front that I am sure you
> will all like.
>
> -Sebastien
> Former VP CloudStack



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-220382990
  
Thanks for the update @ustcweizhou, now I can't find anything to :-1: this 
code.
Based on code review and the CI result, the code LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220380639
  
@swill thanks, though the latter changes are all packaging related. I've 
built rpm/deb repository to show packaging works: 
http://packages.shapeblue.com/cloudstack/custom/master-latest/ (this is master 
+ this PR)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[rhtyd]

GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1549

CLOUDSTACK-9348: NioConnection improvements

Reopened PR with squashed changes for a re-review and testing after 
https://github.com/apache/cloudstack/pull/1493 and sub-sequent PRs got reverted

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack nio-fixagain-singlepr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1549.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1549


commit 9c7518698d2f4a9fcc6a83fd22dd5b2fc4260232
Author: Rohit Yadav 
Date:   2016-04-14T18:54:53Z

CLOUDSTACK-9348: NioConnection improvements

- Unit test to demonstrate denial of service attack
  The NioConnection uses blocking handlers for various events such as 
connect,
  accept, read, write. In case a client connects NioServer (used by
  agent mgr to service agents on port 8250) but fails to participate in SSL
  handshake or just sits idle, this would block the main IO/selector loop in
  NioConnection. Such a client could be either malicious or aggresive.

  This unit test demonstrates such a malicious client that can perform a
  denial-of-service attack on NioServer that blocks it to serve any other 
client.

- Use non-blocking SSL handshake
  - Uses non-blocking socket config in NioClient and NioServer/NioConnection
  - Scalable connectivity from agents and peer clustered-management server
  - Removes blocking ssl handshake code with a non-blocking code
  - Protects from denial-of-service issues that can degrade mgmt server 
responsiveness
due to an aggressive/malicious client
  - Uses separate executor services for handling ssl handshakes

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1549


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220380081
  
@swill yes, this PR includes all the reverted changes and the addHost fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220379062
  
This was run prior to your changes.  I will need to rerun to incorporate 
the recent changes...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1551#issuecomment-220378822
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 4h 15m 16s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_18_2016_19_54_53_7SYUR4:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/DeployDataCenter__May_18_2016_19_54_53_7SYUR4/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/DeployDataCenter__May_18_2016_19_54_53_7SYUR4/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/DeployDataCenter__May_18_2016_19_54_53_7SYUR4/runinfo.txt)

**`/tmp/MarvinLogs/test_network_2ZOCMY:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_network_2ZOCMY/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_network_2ZOCMY/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_network_2ZOCMY/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_M227NQ:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_vpc_routers_M227NQ/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_vpc_routers_M227NQ/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1551/tmp/MarvinLogs/test_vpc_routers_M227NQ/runinfo.txt)


Uploads will be available until `2016-07-19 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220375273
  
So @KrisSterckx what are the copile, install, configuration and runtime 
dependencies that users of your plugin will encounter? What do they need to buy 
(except for the control plain) and how will they be notified when they try to 
use nuage in their setup?
As this passes CI your answer will not be of much consequence to this PR 
but we do want to have a sound model to make sure #cloudstackworks for 
everyone. Especially those experimenting with how to setup their environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: jenkins pr check

[Daan Hoogland]

Maybe I should have formulated my request A little less open minded :) Hope
it did help. As I choose one of two possible solutions let me know if I
should try the other one.

On Thu, May 19, 2016 at 5:25 PM, Will Stevens  wrote:

> Haha.  Too bad you can't batch this email to a smaller groups.  Daan just
> crashed the Jenkins...  :P
>
> Seriously, thank you for your help on this.  I think this will make a big
> difference going forward.
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On Thu, May 19, 2016 at 7:46 AM, Daan Hoogland 
> wrote:
>
> > People,
> >
> > I've asked several people to reopen their pr because of jenkins
> > configuration problems. I think i found the little checkbox that needed
> > setting now. Please do not hurry but reopen any failed PRs on jenkins
> > problems, if you fell it wasn't in your code. don't do it all at once as
> > builds.a.o is kind of heavily loaded.
> >
> > --
> > Daan
> >
>



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220365886
  
Sorry, I need to queue this one up...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1549#issuecomment-220362988
  
I will get this run through CI.  Just to be clear, this PR includes all of 
the changes that were included in 1543, 1538, 1534, 1493 as well as a fix for 
the `addHost` issue.  Is that correct?  Thx...  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Gabriel Beims Bräscher]

Thank you for all the effort Sebastien.
Congrats Will!!

Let’s keep up this great work.

Cheers,
Gabriel.

2016-05-19 12:17 GMT-03:00 Will Stevens :

> Thank you all for the well wishes.  :)
>
> Thank you Seb for all the hard work you have put into this project.  You
> have enabled us to make larger strides forward and we all really appreciate
> that.  Thanks...  
>
> On Thu, May 19, 2016 at 10:56 AM, Giles Sirett  >
> wrote:
>
> > Sebastien - thank you for your drive, dedication and hard work over the
> > last year
> >
> > Will - many congratulations - keep up the good work !
> >
> > Kind Regards
> > Giles
> >
> > giles.sir...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> > -Original Message-
> > From: Sebastien Goasguen [mailto:run...@gmail.com]
> > Sent: 19 May 2016 07:57
> > To: dev@cloudstack.apache.org; market...@cloudstack.apache.org;
> > us...@cloudstack.apache.org
> > Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
> >
> > Morning Everyone,
> >
> > Yesterday at the ASF board meeting, the board passed the resolution
> making
> > Will Stevens the new Vice President of the Apache CloudStack project.
> >
> > Join me in congratulating Will on this appointment, wish him luck and
> > bring your unwavering support !
> >
> > You may have noticed that Will took on RM duties for the new releases
> > going forward and has also taken a very active role to finish bringing us
> > to github based  workflow and CI. Will has some updates on that front
> that
> > I am sure you will all like.
> >
> > -Sebastien
> > Former VP CloudStack
> >
>

Re: jenkins pr check

[Will Stevens]

Haha.  Too bad you can't batch this email to a smaller groups.  Daan just
crashed the Jenkins...  :P

Seriously, thank you for your help on this.  I think this will make a big
difference going forward.

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Thu, May 19, 2016 at 7:46 AM, Daan Hoogland 
wrote:

> People,
>
> I've asked several people to reopen their pr because of jenkins
> configuration problems. I think i found the little checkbox that needed
> setting now. Please do not hurry but reopen any failed PRs on jenkins
> problems, if you fell it wasn't in your code. don't do it all at once as
> builds.a.o is kind of heavily loaded.
>
> --
> Daan
>

Re: How to fix Jenkins git workspace issues

[Will Stevens]

Thanks guys.  I think this will make a big difference.  

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Thu, May 19, 2016 at 5:01 AM, Daan Hoogland 
wrote:

> On Thu, May 19, 2016 at 7:22 AM, Rajani Karuturi 
> wrote:
>
> > untracked
>
>
> ​good call Rajani, it was only doing an ordinary clean in the rat check
> step.​
>
>
>
> --
> Daan
>

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Will Stevens]

Thank you all for the well wishes.  :)

Thank you Seb for all the hard work you have put into this project.  You
have enabled us to make larger strides forward and we all really appreciate
that.  Thanks...  

On Thu, May 19, 2016 at 10:56 AM, Giles Sirett 
wrote:

> Sebastien - thank you for your drive, dedication and hard work over the
> last year
>
> Will - many congratulations - keep up the good work !
>
> Kind Regards
> Giles
>
> giles.sir...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: 19 May 2016 07:57
> To: dev@cloudstack.apache.org; market...@cloudstack.apache.org;
> us...@cloudstack.apache.org
> Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
>
> Morning Everyone,
>
> Yesterday at the ASF board meeting, the board passed the resolution making
> Will Stevens the new Vice President of the Apache CloudStack project.
>
> Join me in congratulating Will on this appointment, wish him luck and
> bring your unwavering support !
>
> You may have noticed that Will took on RM duties for the new releases
> going forward and has also taken a very active role to finish bringing us
> to github based  workflow and CI. Will has some updates on that front that
> I am sure you will all like.
>
> -Sebastien
> Former VP CloudStack
>

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[sudhansu7]

Github user sudhansu7 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1516#discussion_r63895181
  
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless   by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test from the Marvin - Testing in Python wiki
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+
+# Import Integration Libraries
+
+# base - contains all resources as entities and defines create, delete,
+# list operations on them
+from marvin.lib.base import Host, Cluster, Zone, Pod
+
+# utils - utility classes for common cleanup, external library wrappers etc
+from marvin.lib.utils import cleanup_resources
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_zone, get_domain, list_hosts, get_pod
+
+from nose.plugins.attrib import attr
+
+import time
+import logging
+# These tests need to be run separately and not in parallel with other 
tests.
+# Because it disables the host
+# host_id column of op_host_capacity refers to host_id or a storage pool id
+#
+# This test is to make sure that Disable host only disables the capacities 
of type
+# CPU and MEMORY
+#
+# TEST:
+# Base Condition: There exists a host and storage pool with same id
+#
+# Steps:
+# 1. Find a host and storage pool having same id
+# 2. Disable the host
+# 3. verify that the CPU(1) and MEMORY(0) capacity in op_host_capacity for 
above host
+#is disabled
+# 4. verify that the STORAGE(3) capacity in op_host_capacity for storage 
pool with id
+#same as above host is not disabled
+#
+
+def update_host(apiclient, state, host_id):
+"""
+Function to Enable/Disable Host
+"""
+host_status = Host.update(
+apiclient,
+id=host_id,
+allocationstate=state
+)
+return host_status.resourcestate
+
+
+def check_db(self, host_state):
+"""
+Function to check capacity_state in op_host_capacity table
+"""
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type in (0,1) order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertEqual(
+capacity_state[0][0],
--- End diff --

In my last check in I have added checks for this.

Actually we don't have to add these checks for inner list. The array is 
generated from mysql cursor. So either its empty (if no rows found)  or it has 
a value in [0][0].



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Giles Sirett]

Sebastien - thank you for your drive, dedication and hard work over the last 
year

Will - many congratulations - keep up the good work !

Kind Regards
Giles

giles.sir...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue



-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: 19 May 2016 07:57
To: dev@cloudstack.apache.org; market...@cloudstack.apache.org; 
us...@cloudstack.apache.org
Subject: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

Morning Everyone,

Yesterday at the ASF board meeting, the board passed the resolution making Will 
Stevens the new Vice President of the Apache CloudStack project.

Join me in congratulating Will on this appointment, wish him luck and bring 
your unwavering support !

You may have noticed that Will took on RM duties for the new releases going 
forward and has also taken a very active role to finish bringing us to github 
based  workflow and CI. Will has some updates on that front that I am sure you 
will all like.

-Sebastien
Former VP CloudStack

RE: Migrating CloudStack content from download.cloud.com

[Giles Sirett]

Erik
I agree on the existing users - not the end of the world. We could even release 
a tiny patch to update the DB records

The piece that we need to be really careful with is the "I've just downloaded 
cloudstack  thing for the first time" scenario 

But - there seems to be plenty of good ideas flowing on that


Kind Regards
Giles


giles.sir...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue



-Original Message-
From: Erik Weber [mailto:terbol...@gmail.com] 
Sent: 19 May 2016 09:32
To: dev 
Subject: Re: Migrating CloudStack content from download.cloud.com

As a user (with old ACS installations) I'd say that this isn't all that 
troublesome, this is easily fixed by updating the appropriate db records.

We should ensure that we have some good posts discovered by Google and other 
search engines, so that when somebody running old installations hit this issue 
they find the workaround.
There's a lot of time to reach out to users and inform of the fix necessary.

--
Erik


On Tue, May 17, 2016 at 10:34 AM, Giles Sirett 
wrote:

> This is a MAJOR problem and needs to be figured out before the current
> download site is removed - @Raja - have Citrix committed to it being there
> another year ?
>
> It is my understanding that Cloudstack relies on this download at initial
> build/startup and then periodically if people do things like build a new
> zone
>
> So, users environments aren't going to stop if its pulled, but nobody
> would be a able to build/install cloudstack and it may cause issues as and
> when users make config changes
>
> The problem is, for new builds, its hard coded : you start the  Sec
> Storage VM, CloudStack will try to download the built in template from
> download.cloud.com
>
> My understanding is that its simple db  change to make once an environment
> is running (exisiting users) but *may* require a code patch to fix the
> initial install
>
> #notideal
>
> Really, this should be maintained by ASF/ the project as its key to the
> software working, however my understanding is it involves binaries which
> ASF is never keen on (and may be some 3rd party binaries) - so that just
> wont happen
>
>
>
> Apt-get is controlled by Wido et al (for which we all owe him a massive
> thanks)  - but you are right, it is a 3rd party dependency and arguably a
> SPOF.  But, if ASF wont host binaries, we're always going to have this
> issue.
>
> So, we could patch the code to point somewhere else - but where ? - by
> definition its got to be something maintained by a 3rd party
>
>
> We had this debate some time ago when talking about the repositories. We
> (ShapeBlue) maintain a repo for our customers, which wev'e always opened up
> as public. However, there were concerns about having a company domain name
> (which I understand) - so apt-get became our preferred repo.
>
>
> Thoughts on how to fix this:
>
> 1. if ASF would allow us to create the host entry download.cloudstack.org.
> Its under their domain, but with the site being with a 3rd party it could
> be allowed
>
> 2. maybe Citrix could commit to pointing the current DNS entry to a new
> location (would be simplest but may be legally complex and relies on
> ongoing goodwill)
>
> 3. make a mod to allow users to choose the download location on install.
> We can then maintain apt-get. To remove the SPOF, we could then get the
> templates copied to a number of 3rd party locations and allow people to
> choose which one they use
>
>
>
>
> Kind Regards
> Giles
>
>
> giles.sir...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> Behalf Of Will Stevens
> Sent: 16 May 2016 18:59
> To: dev@cloudstack.apache.org
> Cc: Wido den Hollander 
> Subject: Re: Migrating CloudStack content from download.cloud.com
>
> @Ian, yes, but I think there is more to it than that.  We can change it
> going forward and we can move everything from there over to a new domain.
> I believe the problem is with all of the existing ACS or CCP installs out
> there currently pointing at the download.cloud.com URL, so when it goes
> down, those installs have to be updated.
>
> Maybe I don't understand exactly, but that is the impression I am getting
> from this thread.  Can this be confirmed?
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw
> @CloudOps_
>
> On Mon, May 16, 2016 at 1:38 PM, Ian Rae  wrote:
>
> > Hey guys, who controls apt-get.eu and given the (rather concerning)
> > level of dependency on the operation of the download.cloud.com - would
> > it not make sense to use a domain that is under the control of party
> > whose alignment with CloudStack will not shift. I hesitate to
> > 

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[sudhansu7]

Github user sudhansu7 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1516#discussion_r63894357
  
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless   by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test from the Marvin - Testing in Python wiki
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+
+# Import Integration Libraries
+
+# base - contains all resources as entities and defines create, delete,
+# list operations on them
+from marvin.lib.base import Host, Cluster, Zone, Pod
+
+# utils - utility classes for common cleanup, external library wrappers etc
+from marvin.lib.utils import cleanup_resources
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_zone, get_domain, list_hosts, get_pod
+
+from nose.plugins.attrib import attr
+
+import time
+import logging
+# These tests need to be run separately and not in parallel with other 
tests.
+# Because it disables the host
+# host_id column of op_host_capacity refers to host_id or a storage pool id
+#
+# This test is to make sure that Disable host only disables the capacities 
of type
+# CPU and MEMORY
+#
+# TEST:
+# Base Condition: There exists a host and storage pool with same id
+#
+# Steps:
+# 1. Find a host and storage pool having same id
+# 2. Disable the host
+# 3. verify that the CPU(1) and MEMORY(0) capacity in op_host_capacity for 
above host
+#is disabled
+# 4. verify that the STORAGE(3) capacity in op_host_capacity for storage 
pool with id
+#same as above host is not disabled
+#
+
+def update_host(apiclient, state, host_id):
+"""
+Function to Enable/Disable Host
+"""
+host_status = Host.update(
+apiclient,
+id=host_id,
+allocationstate=state
+)
+return host_status.resourcestate
+
+
+def check_db(self, host_state):
+"""
+Function to check capacity_state in op_host_capacity table
+"""
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type in (0,1) order by capacity_type asc;" %
+self.host_db_id[0][0])
--- End diff --

This check is not required. The check_db will only be invoked if there is a 
host_db_id, storage_pool_db_id and capacity check =3. 
In my last check in I have added checks for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[sudhansu7]

Github user sudhansu7 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1516#discussion_r63893826
  
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless   by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test from the Marvin - Testing in Python wiki
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+
+# Import Integration Libraries
+
+# base - contains all resources as entities and defines create, delete,
+# list operations on them
+from marvin.lib.base import Host, Cluster, Zone, Pod
+
+# utils - utility classes for common cleanup, external library wrappers etc
+from marvin.lib.utils import cleanup_resources
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_zone, get_domain, list_hosts, get_pod
+
+from nose.plugins.attrib import attr
+
+import time
+import logging
+# These tests need to be run separately and not in parallel with other 
tests.
+# Because it disables the host
+# host_id column of op_host_capacity refers to host_id or a storage pool id
+#
+# This test is to make sure that Disable host only disables the capacities 
of type
+# CPU and MEMORY
+#
+# TEST:
+# Base Condition: There exists a host and storage pool with same id
+#
+# Steps:
+# 1. Find a host and storage pool having same id
+# 2. Disable the host
+# 3. verify that the CPU(1) and MEMORY(0) capacity in op_host_capacity for 
above host
+#is disabled
+# 4. verify that the STORAGE(3) capacity in op_host_capacity for storage 
pool with id
+#same as above host is not disabled
+#
+
+def update_host(apiclient, state, host_id):
+"""
+Function to Enable/Disable Host
+"""
+host_status = Host.update(
+apiclient,
+id=host_id,
+allocationstate=state
+)
+return host_status.resourcestate
+
+
+def check_db(self, host_state):
+"""
+Function to check capacity_state in op_host_capacity table
+"""
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type in (0,1) order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertEqual(
+capacity_state[0][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[0][0])
+self.assertEqual(
+capacity_state[1][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[1][0])
+
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type = 3 order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertNotEqual(
+capacity_state[0][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[0][0])
+return capacity_state[0][0]
+
+
+class TestHosts(cloudstackTestCase):
+
+"""
+Testing Hosts
+"""
+@classmethod
+def setUpClass(cls):
+cls.testClient = super(TestHosts, cls).getClsTestClient()
+cls.testdata = cls.testClient.getParsedTestDataConfig()
+cls.apiclient = cls.testClient.getApiClient()
+cls.dbclient = cls.testClient.getDbConnection()
+cls._cleanup = []
+
+# get zone, domain etc
+cls.zone = Zone(get_zone(cls.apiclient, 
cls.testClient.getZoneForTests()).__dict__)
+cls.domain = get_domain(cls.apiclient)
+cls.pod = get_pod(cls.apiclient, cls.zone.id)
+
+cls.logger = logging.getLogger('TestHosts')
+cls.stream_handler = 

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

[sudhansu7]

Github user sudhansu7 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1516#discussion_r63893791
  
--- Diff: test/integration/component/maint/test_capacity_host_delete.py ---
@@ -0,0 +1,195 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless   by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Test from the Marvin - Testing in Python wiki
+
+# All tests inherit from cloudstackTestCase
+from marvin.cloudstackTestCase import cloudstackTestCase, unittest
+
+# Import Integration Libraries
+
+# base - contains all resources as entities and defines create, delete,
+# list operations on them
+from marvin.lib.base import Host, Cluster, Zone, Pod
+
+# utils - utility classes for common cleanup, external library wrappers etc
+from marvin.lib.utils import cleanup_resources
+
+# common - commonly used methods for all tests are listed here
+from marvin.lib.common import get_zone, get_domain, list_hosts, get_pod
+
+from nose.plugins.attrib import attr
+
+import time
+import logging
+# These tests need to be run separately and not in parallel with other 
tests.
+# Because it disables the host
+# host_id column of op_host_capacity refers to host_id or a storage pool id
+#
+# This test is to make sure that Disable host only disables the capacities 
of type
+# CPU and MEMORY
+#
+# TEST:
+# Base Condition: There exists a host and storage pool with same id
+#
+# Steps:
+# 1. Find a host and storage pool having same id
+# 2. Disable the host
+# 3. verify that the CPU(1) and MEMORY(0) capacity in op_host_capacity for 
above host
+#is disabled
+# 4. verify that the STORAGE(3) capacity in op_host_capacity for storage 
pool with id
+#same as above host is not disabled
+#
+
+def update_host(apiclient, state, host_id):
+"""
+Function to Enable/Disable Host
+"""
+host_status = Host.update(
+apiclient,
+id=host_id,
+allocationstate=state
+)
+return host_status.resourcestate
+
+
+def check_db(self, host_state):
+"""
+Function to check capacity_state in op_host_capacity table
+"""
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type in (0,1) order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertEqual(
+capacity_state[0][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[0][0])
+self.assertEqual(
+capacity_state[1][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[1][0])
+
+capacity_state = self.dbclient.execute(
+"select capacity_state from op_host_capacity where host_id='%s' 
and capacity_type = 3 order by capacity_type asc;" %
+self.host_db_id[0][0])
+self.assertNotEqual(
+capacity_state[0][0],
+host_state +
+"d",
+"Invalid db query response for capacity_state %s" %
+capacity_state[0][0])
+return capacity_state[0][0]
+
+
+class TestHosts(cloudstackTestCase):
+
+"""
+Testing Hosts
+"""
+@classmethod
+def setUpClass(cls):
+cls.testClient = super(TestHosts, cls).getClsTestClient()
+cls.testdata = cls.testClient.getParsedTestDataConfig()
+cls.apiclient = cls.testClient.getApiClient()
+cls.dbclient = cls.testClient.getDbConnection()
+cls._cleanup = []
+
+# get zone, domain etc
+cls.zone = Zone(get_zone(cls.apiclient, 
cls.testClient.getZoneForTests()).__dict__)
+cls.domain = get_domain(cls.apiclient)
+cls.pod = get_pod(cls.apiclient, cls.zone.id)
+
+cls.logger = logging.getLogger('TestHosts')
+cls.stream_handler = 

[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1552#issuecomment-220349481
  
Can cofirm the dhcp folder on Ubuntu Trusty LTS (14.04) LGTM.

```
 $ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:Ubuntu 14.04.1 LTS
Release:14.04
Codename:   trusty

$ls  /var/lib/dhcp/
dhclient.leases

```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1545#discussion_r63889814
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -1978,11 +1978,16 @@ So if getMinSpeed() returns null we fall back to 
getSpeed().
 final SerialDef serial = new SerialDef("pty", null, (short)0);
 devices.addDevice(serial);
 
+/* Add a VirtIO channel for SystemVMs for communication and 
provisioning */
 if (vmTO.getType() != VirtualMachine.Type.User) {
-final VirtioSerialDef vserial = new 
VirtioSerialDef(vmTO.getName(), null);
-devices.addDevice(vserial);
+devices.addDevice(new ChannelDef(vmTO.getName() + ".vport", 
ChannelDef.ChannelType.UNIX,
+ "/var/lib/libvirt/qemu/" + 
vmTO.getName() + ".agent"));
--- End diff --

This has always been hardcoded, it's just that I'm moving this part.

This is the SSVM socket which is already there. The socket patch code wants 
to find the .agent there. Not much I can do there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1545#issuecomment-220342553
  
Thanks for the feedback, I will work on that tomorrow.

@rhtyd I tested this on both Ubuntu and CentOS systems.

The main issue with Ubuntu is AppArmor where libvirt isn't allowed to write 
in /var/lib/qemu.

I'll make that directory configurable, but keep in mind that on all 
platforms I know that is the directory where the sockets are stored.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Ahmad Emneina]

Awesome stuff Will! Congrats.

Ahmad E

> On May 18, 2016, at 11:56 PM, Sebastien Goasguen  wrote:
> 
> Morning Everyone,
> 
> Yesterday at the ASF board meeting, the board passed the resolution making 
> Will Stevens the new Vice President of the Apache CloudStack project.
> 
> Join me in congratulating Will on this appointment, wish him luck and bring 
> your unwavering support !
> 
> You may have noticed that Will took on RM duties for the new releases going 
> forward and has also taken a very active role to finish bringing us to github 
> based  workflow and CI. Will has some updates on that front that I am sure 
> you will all like.
> 
> -Sebastien
> Former VP CloudStack

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Nicolás Vázquez]

Congratulations Will!

2016-05-19 11:21 GMT-03:00 Rafael Weingärtner :

> Thanks for all the hard work you have been doing.
> Congratulations Will.
>
>
> On Thu, May 19, 2016 at 11:11 AM, Suresh Sadhu <
> suresh.sa...@accelerite.com>
> wrote:
>
> > Congratulations Will!!
> >
> > Regards
> > Sadhu
> >
> > -Original Message-
> > From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> > Sent: Thursday, May 19, 2016 2:55 PM
> > To: dev 
> > Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
> > Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
> >
> > thanks Sebastien,
> >
> > looking forward to a workshop on your new endevours and please have a
> > thought for poor Will once in a while.
> >
> > On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi <
> > jayapal.ur...@accelerite.com> wrote:
> >
> > > Congrats Will.
> > >
> > > Thanks,
> > > Jayapal
> > > > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> > > wrote:
> > > >
> > > > Congrats Will.
> > > >
> > > > Regards,
> > > > Rohit Yadav
> > > >
> > > >
> > > > rohit.ya...@shapeblue.com
> > > > www.shapeblue.com
> > > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> > > >
> > > >
> > > > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> > > wrote:
> > > >
> > > > Morning Everyone,
> > > >
> > > > Yesterday at the ASF board meeting, the board passed the resolution
> > > making Will Stevens the new Vice President of the Apache CloudStack
> > project.
> > > >
> > > > Join me in congratulating Will on this appointment, wish him luck
> > > > and
> > > bring your unwavering support !
> > > >
> > > > You may have noticed that Will took on RM duties for the new
> > > > releases
> > > going forward and has also taken a very active role to finish bringing
> > > us to github based workflow and CI. Will has some updates on that
> > > front that I am sure you will all like.
> > > >
> > > > -Sebastien
> > > > Former VP CloudStack
> > >
> > >
> > >
> > >
> > > DISCLAIMER
> > > ==
> > > This e-mail may contain privileged and confidential information which
> > > is the property of Accelerite, a Persistent Systems business. It is
> > > intended only for the use of the individual or entity to which it is
> > > addressed. If you are not the intended recipient, you are not
> > > authorized to read, retain, copy, print, distribute or use this
> > > message. If you have received this communication in error, please
> > > notify the sender and delete all copies of this message. Accelerite, a
> > > Persistent Systems business does not accept any liability for virus
> > infected mails.
> > >
> >
> >
> >
> > --
> > Daan
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
>
>
>
> --
> Rafael Weingärtner
>

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Rafael Weingärtner]

Thanks for all the hard work you have been doing.
Congratulations Will.


On Thu, May 19, 2016 at 11:11 AM, Suresh Sadhu 
wrote:

> Congratulations Will!!
>
> Regards
> Sadhu
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, May 19, 2016 2:55 PM
> To: dev 
> Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
> Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP
>
> thanks Sebastien,
>
> looking forward to a workshop on your new endevours and please have a
> thought for poor Will once in a while.
>
> On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi <
> jayapal.ur...@accelerite.com> wrote:
>
> > Congrats Will.
> >
> > Thanks,
> > Jayapal
> > > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> > wrote:
> > >
> > > Congrats Will.
> > >
> > > Regards,
> > > Rohit Yadav
> > >
> > >
> > > rohit.ya...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> > >
> > >
> > > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> > wrote:
> > >
> > > Morning Everyone,
> > >
> > > Yesterday at the ASF board meeting, the board passed the resolution
> > making Will Stevens the new Vice President of the Apache CloudStack
> project.
> > >
> > > Join me in congratulating Will on this appointment, wish him luck
> > > and
> > bring your unwavering support !
> > >
> > > You may have noticed that Will took on RM duties for the new
> > > releases
> > going forward and has also taken a very active role to finish bringing
> > us to github based workflow and CI. Will has some updates on that
> > front that I am sure you will all like.
> > >
> > > -Sebastien
> > > Former VP CloudStack
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which
> > is the property of Accelerite, a Persistent Systems business. It is
> > intended only for the use of the individual or entity to which it is
> > addressed. If you are not the intended recipient, you are not
> > authorized to read, retain, copy, print, distribute or use this
> > message. If you have received this communication in error, please
> > notify the sender and delete all copies of this message. Accelerite, a
> > Persistent Systems business does not accept any liability for virus
> infected mails.
> >
>
>
>
> --
> Daan
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>



-- 
Rafael Weingärtner

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Suresh Sadhu]

Congratulations Will!!

Regards
Sadhu

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: Thursday, May 19, 2016 2:55 PM
To: dev 
Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

thanks Sebastien,

looking forward to a workshop on your new endevours and please have a thought 
for poor Will once in a while.

On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi < jayapal.ur...@accelerite.com> 
wrote:

> Congrats Will.
>
> Thanks,
> Jayapal
> > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> wrote:
> >
> > Congrats Will.
> >
> > Regards,
> > Rohit Yadav
> >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
> >
> > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> wrote:
> >
> > Morning Everyone,
> >
> > Yesterday at the ASF board meeting, the board passed the resolution
> making Will Stevens the new Vice President of the Apache CloudStack project.
> >
> > Join me in congratulating Will on this appointment, wish him luck 
> > and
> bring your unwavering support !
> >
> > You may have noticed that Will took on RM duties for the new 
> > releases
> going forward and has also taken a very active role to finish bringing 
> us to github based workflow and CI. Will has some updates on that 
> front that I am sure you will all like.
> >
> > -Sebastien
> > Former VP CloudStack
>
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which 
> is the property of Accelerite, a Persistent Systems business. It is 
> intended only for the use of the individual or entity to which it is 
> addressed. If you are not the intended recipient, you are not 
> authorized to read, retain, copy, print, distribute or use this 
> message. If you have received this communication in error, please 
> notify the sender and delete all copies of this message. Accelerite, a 
> Persistent Systems business does not accept any liability for virus infected 
> mails.
>



--
Daan



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Paul Angus]

Thank you Sebastien and congratulations Will.


Kind regards,

Paul Angus

paul.an...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue



-Original Message-
From: Syed Mushtaq [mailto:syed1.mush...@gmail.com] 
Sent: 19 May 2016 14:25
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

Congratulations Will! Super excited to be working with you :)

-Syed

On Thu, May 19, 2016 at 5:24 AM, Daan Hoogland 
wrote:

> thanks Sebastien,
>
> looking forward to a workshop on your new endevours and please have a 
> thought for poor Will once in a while.
>
> On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi < 
> jayapal.ur...@accelerite.com> wrote:
>
> > Congrats Will.
> >
> > Thanks,
> > Jayapal
> > > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> > > 
> > wrote:
> > >
> > > Congrats Will.
> > >
> > > Regards,
> > > Rohit Yadav
> > >
> > >
> > > rohit.ya...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> > >
> > >
> > > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> > wrote:
> > >
> > > Morning Everyone,
> > >
> > > Yesterday at the ASF board meeting, the board passed the resolution
> > making Will Stevens the new Vice President of the Apache CloudStack
> project.
> > >
> > > Join me in congratulating Will on this appointment, wish him luck and
> > bring your unwavering support !
> > >
> > > You may have noticed that Will took on RM duties for the new releases
> > going forward and has also taken a very active role to finish bringing us
> > to github based workflow and CI. Will has some updates on that front
> that I
> > am sure you will all like.
> > >
> > > -Sebastien
> > > Former VP CloudStack
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
>
>
>
> --
> Daan
>

[GitHub] cloudstack pull request: Remodeling of Nuage VSP Plugin + CLOUDSTA...

[KrisSterckx]

Github user KrisSterckx commented on the pull request:

https://github.com/apache/cloudstack/pull/1494#issuecomment-220326489
  
@DaanHoogland  to your question :

We are embarking full CloudStack build automation as that gives us 
cloudstack-nuagevsp-plugin <> nuagevsp-client-jar version compatibility by 
design, and provides us higher development efficiency as it gives us java 
compile time checking.

We could publish the code at our github.com/nuagenetworks repo's if that is 
desired. I see this is not consistently applied by other vendors though.

Let me know if there are other actions to take, or feel free to shoot any 
additional question.

cheers,
Kris


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Syed Mushtaq]

Congratulations Will! Super excited to be working with you :)

-Syed

On Thu, May 19, 2016 at 5:24 AM, Daan Hoogland 
wrote:

> thanks Sebastien,
>
> looking forward to a workshop on your new endevours and please have a
> thought for poor Will once in a while.
>
> On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi <
> jayapal.ur...@accelerite.com> wrote:
>
> > Congrats Will.
> >
> > Thanks,
> > Jayapal
> > > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> > wrote:
> > >
> > > Congrats Will.
> > >
> > > Regards,
> > > Rohit Yadav
> > >
> > >
> > > rohit.ya...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > @shapeblue
> > >
> > >
> > > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> > wrote:
> > >
> > > Morning Everyone,
> > >
> > > Yesterday at the ASF board meeting, the board passed the resolution
> > making Will Stevens the new Vice President of the Apache CloudStack
> project.
> > >
> > > Join me in congratulating Will on this appointment, wish him luck and
> > bring your unwavering support !
> > >
> > > You may have noticed that Will took on RM duties for the new releases
> > going forward and has also taken a very active role to finish bringing us
> > to github based workflow and CI. Will has some updates on that front
> that I
> > am sure you will all like.
> > >
> > > -Sebastien
> > > Former VP CloudStack
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> retain,
> > copy, print, distribute or use this message. If you have received this
> > communication in error, please notify the sender and delete all copies of
> > this message. Accelerite, a Persistent Systems business does not accept
> any
> > liability for virus infected mails.
> >
>
>
>
> --
> Daan
>

RE: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

[Sanjeev Neelarapu]

Congratulations Will!!

Best Regards,
Sanjeev N
Chief Product Engineer, Accelerite
Off: +91 40 6722 9368 | EMail: sanjeev.neelar...@accelerite.com 



-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Thursday, May 19, 2016 2:55 PM
To: dev 
Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
Subject: Re: [ANNOUNCE] Will Stevens as new Apache CloudStack VP

thanks Sebastien,

looking forward to a workshop on your new endevours and please have a thought 
for poor Will once in a while.

On Thu, May 19, 2016 at 10:32 AM, Jayapal Uradi < jayapal.ur...@accelerite.com> 
wrote:

> Congrats Will.
>
> Thanks,
> Jayapal
> > On 19-May-2016, at 1:54 pm, Rohit Yadav 
> wrote:
> >
> > Congrats Will.
> >
> > Regards,
> > Rohit Yadav
> >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> >
> >
> > On May 19 2016, at 12:26 pm, Sebastien Goasguen 
> wrote:
> >
> > Morning Everyone,
> >
> > Yesterday at the ASF board meeting, the board passed the resolution
> making Will Stevens the new Vice President of the Apache CloudStack project.
> >
> > Join me in congratulating Will on this appointment, wish him luck and
> bring your unwavering support !
> >
> > You may have noticed that Will took on RM duties for the new releases
> going forward and has also taken a very active role to finish bringing us
> to github based workflow and CI. Will has some updates on that front that I
> am sure you will all like.
> >
> > -Sebastien
> > Former VP CloudStack
>
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>



-- 
Daan



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

Re: MySQL : No suitable driver found for jdbc:mysql

[Nick LIVENS]

When I add the mysql-connector-java.jar to /usr/lib/jvm/java/jre/lib/ext
without touching the CLASSPATH in /etc/sysconfig/cloudstack-management it's
working fine as well..
So either something is broken in the tomcat class loading mechanism, either
it's related to some environment specifics of mine..

Still digging deeper, keeping you guys posted..

Kind regards,
Nick Livens

On Thu, May 19, 2016 at 10:05 AM, Nick LIVENS  wrote:

> Now I'm totally clueless, perhaps I'm hitting a bug in tomcat?
> Following the official documentation of Apache Tomcat 7.0 (
> http://tomcat.apache.org/tomcat-7.0-doc/jndi-datasource-examples-howto.html
> )
>
> Especially the following part :
> "java.sql.DriverManager supports the service provider
> 
>  mechanism. This feature is that all the available JDBC drivers that
> announce themselves by providing a META-INF/services/java.sql.Driver file
> are automatically discovered, loaded and registered, relieving you from the
> need to load the database driver explicitly before you create a JDBC
> connection. However, the implementation is fundamentally broken in all Java
> versions for a servlet container environment. The problem is that
> java.sql.DriverManager will scan for the drivers only once.
>
> The JRE Memory Leak Prevention Listener
>  that is
> included with Apache Tomcat solves this by triggering the drivers scan
> during Tomcat startup. This is enabled by default. It means that only
> libraries visible to the listener such as the ones in $CATALINA_BASE/lib will
> be scanned for database drivers. If you are considering disabling this
> feature, note that the scan would be triggered by the first web application
> that is using JDBC, leading to failures when this web application is
> reloaded and for other web applications that rely on this feature.
>
> Thus, the web applications that have database drivers in their WEB-INF/lib 
> directory
> cannot rely on the service provider mechanism and should register the
> drivers explicitly.
>
> The list of drivers in java.sql.DriverManager is also a known source of
> memory leaks. Any Drivers registered by a web application must be
> deregistered when the web application stops. Tomcat will attempt to
> automatically discover and deregister any JDBC drivers loaded by the web
> application class loader when the web application stops. However, it is
> expected that applications do this for themselves via a
> ServletContextListener."
> I've checked all steps :
> * My mysql-connector-java contains the META-INF/services/java.sql.Driver
> file
> * This JAR is located in /usr/share/cloudstack-management/lib/
> * CATALINA_BASE = /usr/share/cloudstack-management
>
> These are the 3 steps to make the JDBC drivers auto register themselves,
> and this is not working.
> I've also found a thread on stackoverflow where someone is hitting the
> same issue - 2nd reply (
> http://stackoverflow.com/questions/20224222/how-to-register-oracle-jdbc-driver-on-tomcat-7-0-47-startup
> )
>
> Kind regards,
> Nick Livens
>
> On Wed, May 18, 2016 at 6:25 PM, Simon Weller  wrote:
>
>> Are you able to test this on a cleanly installed OS?
>>
>> It sounds like you've potentially got quite a few customizations and I
>> think it would be helpful to see whether this can be reproduced on a clean
>> install.
>>
>> 
>> From: Nick LIVENS 
>> Sent: Wednesday, May 18, 2016 11:02 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: MySQL : No suitable driver found for jdbc:mysql
>>
>> I've digged a bit deeper, and I've got it working by explicitly loading
>> the
>> MySQL JDBC driver with the following code change in
>> TransactionLegacy.java :
>>
>> static {
>> try {
>> Class.forName("com.mysql.jdbc.Driver");
>> } catch (ClassNotFoundException e) {
>> throw new CloudRuntimeException("Failed to load MySQL JDBC
>> driver", e);
>> }
>>
>> // Initialize with assumed db.properties file
>> initDataSource(DbProperties.getDbProperties());
>> }
>>
>> This is the old way of doing it (< JDBC 4.0)
>> I know that from that version onwards that these drivers are loaded
>> automatically, so I thought that our mysql-connector was outdated.
>> I've replaced it with the latest, but without success. The issue is still
>> there.
>>
>> I've got 2 solutions, but either way, it should work with the current
>> master ACS without changing stuff manually.
>> * This code change
>> * Changing the /etc/sysconfig/cloudstack-management file again, so that
>> CLASSPATH contains the mysql-connector-java.jar again
>>
>> Any help / suggestions / ideas are much appreciated.
>>
>> Kind regards,
>> Nick Livens
>>
>>
>> On Wed, May 18, 2016 at 4:43 PM, Nick LIVENS <
>> 

Re: [Discuss] CloudStack documentation

[Ron Wheeler]

Identify where most issues are raised in the ML and fix the docs to 
reduce the confusion.
I suspect that Networking is the source of most problems but perhaps 
other have a better sense of this.


Ron

On 19/05/2016 8:29 AM, Ron Wheeler wrote:
Removal of duplicate information as part of item 2 . Item 5 has this 
implicitly.


Item 3 +1

"Marketing" information targeted at SMB market.

Ron

On 19/05/2016 6:54 AM, Dag Sonstebo wrote:

All,

since we've added CloudStack documentation to the discussion topics 
for the Montreal meetup I wanted to gauge peoples opinion on areas of 
improvement.


Personally I would like to see the following:

   1.  Overall documentation navigation needs to be improved.
   2.  Ideally all documentation should be under a single 
documentation tree with a single table of contents. All content 
should be searchable without having to visit each of the current 
documentation roots separately (Getting Started / Installation Guide 
/ Admin Guide / Release Notes).
   3.  Advanced topics should be moved away from the "Getting Started 
Docs". The people reading the getting started / concepts sections are 
typically new CloudStack users  who will easily be put off by 
immediately being presented with advanced topics.

   4.  API documentation to be a chapter of the Developers guide.
   5.  Upgrade instructions to be moved from the release notes to the 
installation guide.
   6.  Compatibility matrix in single location only – i.e. not in 
both the release notes and installation guide as this has caused 
discrepancies in the past.


I appreciate we are also working against multiple Github repositories 
which complicates things slightly, but if we can overall improve the 
end user experience this is worth the effort.


Thoughts?

Regards,

dag.sonst...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue








--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102