Re: Review Request 30821: CLOUDSTACK-8236: Automation test cases for storage migration test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30821/ --- (Updated March 2, 2015, 9:12 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Changes --- Added live migrate scenarios and snapshot scenarios. Bugs: CLOUDSTACK-8236 https://issues.apache.org/jira/browse/CLOUDSTACK-8236 Repository: cloudstack-git Description (updated) --- Test cases for Storage Migration test path. Diffs (updated) - test/integration/testpaths/testpath_storage_migration.py PRE-CREATION tools/marvin/marvin/codes.py a7e8ec8 tools/marvin/marvin/config/test_data.py 80e0abd tools/marvin/marvin/lib/base.py 7443373 Diff: https://reviews.apache.org/r/30821/diff/ Testing (updated) --- Live migrate scenario log on Xen. Test migrate Volume (root and data disk) ... === TestName: test_01_migrate_root_and_data_disk_live | Status : SUCCESS === ok -- Ran 1 test in 529.320s OK Thanks, Ashutosh Kelkar
Re: Review Request 30821: CLOUDSTACK-8236: Automation test cases for storage migration test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30821/ --- (Updated Feb. 20, 2015, 7:38 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Changes --- Addded 10 more scenarios and code re-factor of existing code. Bugs: CLOUDSTACK-8236 https://issues.apache.org/jira/browse/CLOUDSTACK-8236 Repository: cloudstack-git Description --- First few test scenarios for storage migration test path. Diffs (updated) - test/integration/testpaths/testpath_storage_migration.py PRE-CREATION tools/marvin/marvin/codes.py a7e8ec8 tools/marvin/marvin/config/test_data.py e8365ed tools/marvin/marvin/lib/base.py 7443373 Diff: https://reviews.apache.org/r/30821/diff/ Testing --- Some scenarios are failing, e.g migrating volume from CWSP to ZWSP should raise exception, but it is not. Investigating on that. Thanks, Ashutosh Kelkar
Re: Review Request 30821: CLOUDSTACK-8236: Automation test cases for storage migration test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30821/ --- (Updated Feb. 17, 2015, 12:06 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Changes --- Code refactor. Bugs: CLOUDSTACK-8236 https://issues.apache.org/jira/browse/CLOUDSTACK-8236 Repository: cloudstack-git Description --- First few test scenarios for storage migration test path. Diffs (updated) - test/integration/testpaths/testpath_storage_migration.py PRE-CREATION tools/marvin/marvin/codes.py a7e8ec8 tools/marvin/marvin/config/test_data.py e3645a7 tools/marvin/marvin/lib/base.py 7443373 Diff: https://reviews.apache.org/r/30821/diff/ Testing --- Some scenarios are failing, e.g migrating volume from CWSP to ZWSP should raise exception, but it is not. Investigating on that. Thanks, Ashutosh Kelkar
Re: Review Request 30821: CLOUDSTACK-8236: Automation test cases for storage migration test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30821/ --- (Updated Feb. 16, 2015, 4:34 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8236 https://issues.apache.org/jira/browse/CLOUDSTACK-8236 Repository: cloudstack-git Description --- First few test scenarios for storage migration test path. Diffs (updated) - test/integration/testpaths/testpath_storage_migration.py PRE-CREATION tools/marvin/marvin/codes.py a7e8ec8 tools/marvin/marvin/config/test_data.py e3645a7 tools/marvin/marvin/lib/base.py 5bad6b7 Diff: https://reviews.apache.org/r/30821/diff/ Testing (updated) --- Some scenarios are failing, e.g migrating volume from CWSP to ZWSP should raise exception, but it is not. Investigating on that. Thanks, Ashutosh Kelkar
Re: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/#review72574 --- As discussed, removed the code snippet, and all the test cases are passing. Please review and mark it as ship. - Ashutosh Kelkar On Feb. 16, 2015, 5:16 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/ --- (Updated Feb. 16, 2015, 5:16 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7594 https://issues.apache.org/jira/browse/CLOUDSTACK-7594 Repository: cloudstack-git Description --- Automation test cases for Stopped VM test path. Diffs - test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION Diff: https://reviews.apache.org/r/25885/diff/ Testing --- Yes. Advanced zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok Basic zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok -- Ran 10 tests in 2792.968s OK Thanks, Ashutosh Kelkar
Re: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/ --- (Updated Feb. 16, 2015, 5:16 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Changes --- Review changes and rebase patch against latest master. Bugs: CLOUDSTACK-7594 https://issues.apache.org/jira/browse/CLOUDSTACK-7594 Repository: cloudstack-git Description --- Automation test cases for Stopped VM test path. Diffs (updated) - test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION Diff: https://reviews.apache.org/r/25885/diff/ Testing --- Yes. Advanced zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok Basic zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok -- Ran 10 tests in 2792.968s OK Thanks, Ashutosh Kelkar
Re: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path
On Feb. 4, 2015, 10:48 a.m., suresh sadhu wrote: you didn't remove the below code... as its not required in test03 -- here vm deployed in stopped state.. if str(self.zone.networktype).lower() == advanced: response = VerifyRouterState( self.apiclient, self.account.name, self.account.domainid, STOPPED ) I have added new patch removing the code snippet and also rebased it against latest master branch. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/#review70943 --- On Feb. 16, 2015, 5:16 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/ --- (Updated Feb. 16, 2015, 5:16 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7594 https://issues.apache.org/jira/browse/CLOUDSTACK-7594 Repository: cloudstack-git Description --- Automation test cases for Stopped VM test path. Diffs - test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION Diff: https://reviews.apache.org/r/25885/diff/ Testing --- Yes. Advanced zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok Basic zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok -- Ran 10 tests in 2792.968s OK Thanks, Ashutosh Kelkar
Review Request 30821: CLOUDSTACK-8236: Automation test cases for storage migration test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30821/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8236 https://issues.apache.org/jira/browse/CLOUDSTACK-8236 Repository: cloudstack-git Description --- First few test scenarios for storage migration test path. Diffs - test/integration/component/test_storage_migration.py PRE-CREATION tools/marvin/marvin/codes.py a7e8ec8 tools/marvin/marvin/lib/base.py e38c394 Diff: https://reviews.apache.org/r/30821/diff/ Testing --- Test migrate Volume (root and data disk) ... === TestName: test_01_migrate_root_and_data_disk_nonlive | Status : SUCCESS === ok -- Ran 1 test in 663.665s OK Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 9, 2015, 5:38 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs (updated) - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 911 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line911 dint get the need or use of this validation ... Will add check for equality here as the usage should remain same after template deletion. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71192 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 2030 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2030 this is PF rule usage (type 12) i dont see usage type 12 created in this test case. NAT rule is created in this test case. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71381 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 4, 2015, 10:52 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 473 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line473 veirfy no further usage for this deleted template and iso is generated in next aggregation interval Sure On Feb. 4, 2015, 10:52 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 553 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line553 for running vm usage you are using vmallocatedusagerecordafterdestroy ? it's only the debug statement. It's allocated usage only. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review70945 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 998 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line998 i dont think these two fileds templtat.id and record.usageid are same It's as mentioned here - http://cloudstack-administration.readthedocs.org/en/latest/usage.html They are the same. On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 1060 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1060 change message to reflect usage for snamshot Yes, will update the comment. On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 1251 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1251 we can find acurate timing as well .so better check than just checking 0 Yes, will compare with exact value for usage. On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 1031 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1031 check only for equality Okay On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 969 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line969 the check should only check for equality Okay On Feb. 5, 2015, 12:09 p.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 935 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line935 i think just checking snapshot in description is a loose check we should check based on volume id Yes, agree will fix it. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71192 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 2509 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2509 not te right candidate for automation as we need to wt for 60 mins before usage records will be generated Okay, Agree. We can skipp this test since we will have to wait for 60 mins before usage records will be generated. On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 2401 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2401 neeed to chane this as well no unknow in response Yes, the actual response value to compare is cloudstack-usage: unrecognized service, I will fix it. On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 2156 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2156 not the right way to calculate network bytes send or receive in vpc networks. The calulation is done per public gateway for all the eth. Yes, agree. I will investiage on how to get this information from Router. On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 2108 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2108 its vpn user usage Yes, correct need to fix the Exception message saying VPN user usage not matching On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 2099 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line2099 testing usage for vpn user Yes, correct need to fix the Exception message saying VPN user usage not matching On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 1943 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1943 not validating network usage for ip but for network offerings Yes, correct. On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 1933 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1933 similar usage ned to be checked for isolated network as well Yes, correct. I will add check for isolated network as well along with VPC network. On Feb. 6, 2015, 9:13 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 1595 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1595 need to check for acurate bytes only than will not help Yes, agree. I will investiage on how to get this information from Router. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71381 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 5, 2015, 12:19 p.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 1394 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line1394 not the right way for calculting usage of bytes send and received . We measure byte send and received on router and verify those values in usage records Yes, agree. I will investiage on how to get this information from Router. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71202 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 5, 2015, 8:55 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 455 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line455 yes there will be . allocation time starts as soon as resources are allocated ..i.e vm comes into starting state ... but running time starts only when VM is in running state ok I will add usage check here. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review71180 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 289 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line289 when uage server is not installed follwoing is the output service cloudstack-usage status cloudstack-usage: unrecognized service unknown is still not in the response I will fix this. On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 329 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line329 Sorry i my sound stupid as i am reviewing the code for the first time but still can you please explain what is validated over here ? content of the list ? content of the list or soemthing else? It's verifying the list is not empty. (validateList function is present in utils.py file) On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 402 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line402 again can you please specify what are you verifying here ? It verifies the response returned from the function is PASS. if it FAIL, then exception returned will be thrown by the assert. On Feb. 4, 2015, 8:46 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 405 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line405 Several other veirfication also need to be done apart from size . First the usage time shown is correct or not. For this we need to get created time from usage-event table for template create event and then usage job execution time and calculate time and this time should be equal to the time shown in usage api Ok, will add this check. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review70929 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 4, 2015, 9:33 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 455 https://reviews.apache.org/r/28030/diff/3/?file=845517#file845517line455 we need to have usage for VM allocation type as well. and need to check that allocation time usage running time usage of the VM Will there by any difference in two usages just after starting the VM? We have not stopped the VM yet. If yes, then will add check here. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review70936 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/#review70927 --- I have addressed all the review comments, and also verified that patch is still valid against latest master branch. It applies cleanly. Sadhu, can you please look at this? - Ashutosh Kelkar On Oct. 1, 2014, 9:18 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/ --- (Updated Oct. 1, 2014, 9:18 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7594 https://issues.apache.org/jira/browse/CLOUDSTACK-7594 Repository: cloudstack-git Description --- Automation test cases for Stopped VM test path. Diffs - test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION tools/marvin/marvin/lib/base.py d623386 Diff: https://reviews.apache.org/r/25885/diff/ Testing --- Yes. Advanced zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok Basic zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok -- Ran 10 tests in 2792.968s OK Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs (updated) - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
On Feb. 3, 2015, 10:41 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 141 https://reviews.apache.org/r/28030/diff/2/?file=841878#file841878line141 why are we setting these value in seconds ? by default this config value is required in mins. and are we setting configs[0].value somewhere during setup so that here you are trying to increase by a min? by default this parameter value is 1440 (24hrs) We are just listing the value here and increasing it by one minute. And it is converted to seconds because it is used in time.sleep() function. The value is used while waiting for usage job to run. Once the sleep period is over, generateUsage command is fired and usage is listed. While setting the range, value is passed in minutes only. (See line number 201) On Feb. 3, 2015, 10:41 a.m., shweta agarwal wrote: test/integration/testpaths/testpath_usage.py, line 266 https://reviews.apache.org/r/28030/diff/2/?file=841878#file841878line266 when do you expect to get unknown in response ? service cloudstack-usage status command output will be something like cloudstack-usage is stopped or cloudstack-usage is running When usage server is not installed, then we will get unknown while checking the status. It is assumed that if the usage server is installed, then it is running. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/#review70731 --- On Feb. 3, 2015, 12:24 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Feb. 3, 2015, 12:24 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 28030: CLOUDSTACK-7911: Automation test cases for Usage test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28030/ --- (Updated Jan. 30, 2015, 4:29 p.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7911 https://issues.apache.org/jira/browse/CLOUDSTACK-7911 Repository: cloudstack-git Description (updated) --- Automation test cases for Usage test path. More test cases to follow. This is first patch. Diffs (updated) - test/integration/testpaths/testpath_usage.py PRE-CREATION tools/marvin/marvin/config/test_data.py d5ed353 tools/marvin/marvin/dbConnection.py 66c6cb1 tools/marvin/marvin/lib/base.py e38c394 tools/marvin/marvin/lib/utils.py 8788b3b Diff: https://reviews.apache.org/r/28030/diff/ Testing (updated) --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 27321: CLOUDSTACK-7815: Automation test cases for system VM HA test path
On Nov. 14, 2014, 7:34 a.m., suresh sadhu wrote: Test cases are talking about host down scenario's but scripts are dealing with host maiantenannce scenarios. Cloudstack behaves diffrenlty in these 2 situations(host down and host maintenance).. so please corect the scripts accordingly. Does that mean we have to disable the host? (updateHost api with allocationstate=disable) - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27321/#review61414 --- On Nov. 3, 2014, 8:51 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27321/ --- (Updated Nov. 3, 2014, 8:51 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7815 https://issues.apache.org/jira/browse/CLOUDSTACK-7815 Repository: cloudstack-git Description --- Convers around 12 scenarios. More patches to follow if scenarios are automatable. Diffs - test/integration/testpaths/testpath_system_vm_ha.py PRE-CREATION Diff: https://reviews.apache.org/r/27321/diff/ Testing --- Bring down the host on which SSVM is running ... === TestName: test_01_bring_ssvm_host_down | Status : SUCCESS === ok Bring down the host on which CPVM is running ... === TestName: test_02_bring_cpvm_host_down | Status : SUCCESS === ok Bring down the host on which router is running ... === TestName: test_03_bring_router_host_down | Status : SUCCESS === ok -- Ran 3 tests in 1137.479s OK Thanks, Ashutosh Kelkar
Re: Review Request 27321: CLOUDSTACK-7815: Automation test cases for system VM HA test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27321/ --- (Updated Jan. 22, 2015, 10:33 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7815 https://issues.apache.org/jira/browse/CLOUDSTACK-7815 Repository: cloudstack-git Description --- Convers around 12 scenarios. More patches to follow if scenarios are automatable. Diffs (updated) - test/integration/testpaths/testpath_system_vm_ha.py PRE-CREATION Diff: https://reviews.apache.org/r/27321/diff/ Testing --- Bring down the host on which SSVM is running ... === TestName: test_01_bring_ssvm_host_down | Status : SUCCESS === ok Bring down the host on which CPVM is running ... === TestName: test_02_bring_cpvm_host_down | Status : SUCCESS === ok Bring down the host on which router is running ... === TestName: test_03_bring_router_host_down | Status : SUCCESS === ok -- Ran 3 tests in 1137.479s OK Thanks, Ashutosh Kelkar
Re: Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/#review69160 --- test/integration/testpaths/testpath_stopped_vm.py https://reviews.apache.org/r/25885/#comment113781 2nd test verifies SSH to VM, while this test is targetted to check the router state. - Ashutosh Kelkar On Oct. 1, 2014, 9:18 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/ --- (Updated Oct. 1, 2014, 9:18 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7594 https://issues.apache.org/jira/browse/CLOUDSTACK-7594 Repository: cloudstack-git Description --- Automation test cases for Stopped VM test path. Diffs - test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION tools/marvin/marvin/lib/base.py d623386 Diff: https://reviews.apache.org/r/25885/diff/ Testing --- Yes. Advanced zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok Basic zone: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : SUCCESS === ok Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : SUCCESS === ok Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : SUCCESS === ok Positive test for stopped VM test path - T3 and variant, T9 ... === TestName: test_04_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_05_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_06_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_07_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T10 ... === TestName: test_08_pt_startvm_false_password_enabled_template | Status : SUCCESS === ok Positive test for stopped VM test path - T11 ... === TestName: test_09_pt_destroy_stopped_vm | Status : SUCCESS === ok Positive test for stopped VM test path - T12 ... === TestName: test_10_max_account_limit | Status : SUCCESS === ok -- Ran 10 tests in 2792.968s OK Thanks, Ashutosh Kelkar
Review Request 29847: CLOUDSTACK-8153: Adding global setting value check for few test cases in test_custom_hostname.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29847/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8153 https://issues.apache.org/jira/browse/CLOUDSTACK-8153 Repository: cloudstack-git Description --- The test cases need vm.instancename.flag set to be true. Added check for that. Diffs - test/integration/component/test_custom_hostname.py fcd497e Diff: https://reviews.apache.org/r/29847/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 29806: CLOUDSTACK-8147: Fixed typo in test case test_redundant_router.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29806/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8147 https://issues.apache.org/jira/browse/CLOUDSTACK-8147 Repository: cloudstack-git Description --- The test case has typo connction instead of connection. Diffs - test/integration/component/maint/test_redundant_router.py 01d635b Diff: https://reviews.apache.org/r/29806/diff/ Testing --- yes. Thanks, Ashutosh Kelkar
Review Request 29843: CLOUDSTACK-8149: Code-refactor - test_VirtualRouter_alerts.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29843/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8149 https://issues.apache.org/jira/browse/CLOUDSTACK-8149 Repository: cloudstack-git Description --- The test case needed a major code-refactor. Also it had import issues and pep8 issues. Fixed those too. Diffs - test/integration/component/test_VirtualRouter_alerts.py bff12f9 Diff: https://reviews.apache.org/r/29843/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 29620: CLOUDSTACK-8143: Corrected a test in BVT test_routers.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29620/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8143 https://issues.apache.org/jira/browse/CLOUDSTACK-8143 Repository: cloudstack-git Description --- The test case test_03_restart_network_cleanup is restarting the network with cleanup=True and verifying that the linklocalip of the new router should be different than the linklocalip of the old router. However this may not be true as the linklocalip is assigned randomly and hence can be same for the new router. The test case should instead check that the publicip of the new router should be the same as publicip of the old router. Diffs - test/integration/smoke/test_routers.py 7d5f267 Diff: https://reviews.apache.org/r/29620/diff/ Testing --- Test router internal basic zone ... SKIP: Skip Test router internal advanced zone ... SKIP: Skip Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS === ok Test restart network without cleanup ... SKIP: Skip Test router basic setup ... SKIP: Skip Test router advanced setup ... SKIP: Skip Test stop router ... SKIP: Skip Test start router ... SKIP: Skip Test reboot router ... SKIP: Skip -- Ran 9 tests in 231.829s OK (SKIP=8) Thanks, Ashutosh Kelkar
Review Request 29478: CLOUDSTACK-8137: Fixed cleanup issue in sec group tests in test_escalations_instances.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29478/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8137 https://issues.apache.org/jira/browse/CLOUDSTACK-8137 Repository: cloudstack-git Description --- The test case failed while deleting the security groups in cleanup operation because those were deleted as part of account cleanup. No need to add security groups in cleanup list explicitly. Diffs - test/integration/component/test_escalations_instances.py 1e5ec53 Diff: https://reviews.apache.org/r/29478/diff/ Testing --- @Desc: Test to verify deploy VM with multiple Security Groups ... -- Ran 1 test in 0.477s OK Thanks, Ashutosh Kelkar
Review Request 29453: CLOUDSTACK-8132: Fixed issue related to secondary storage count of template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29453/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8132 https://issues.apache.org/jira/browse/CLOUDSTACK-8132 Repository: cloudstack-git Description --- The test case faiiled because the tempalte was registered through root account api client. It was supposed to be registered using the api client of the correct account (child account in this case). Corrected the code related to it. Diffs - test/integration/component/test_ss_limits.py c498302 Diff: https://reviews.apache.org/r/29453/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 29477: CLOUDSTACK-8135: Fixed cleanup issue in test_escalations_instances.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29477/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8135 https://issues.apache.org/jira/browse/CLOUDSTACK-8135 Repository: cloudstack-git Description --- The test case failed in cleanup operation because the VM gets cleaned up as a part of account cleanup. Hence no need to add the VM in to cleanup list explicitly. Diffs - test/integration/component/test_escalations_instances.py 1e5ec53 Diff: https://reviews.apache.org/r/29477/diff/ Testing --- @Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS === ok -- Ran 1 test in 167.918s OK Thanks, Ashutosh Kelkar
Review Request 29425: CLOUDSTACK-8130: Fixed test_escalations_templates.py - Removed test case dependency on each other
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29425/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7130 https://issues.apache.org/jira/browse/CLOUDSTACK-7130 Repository: cloudstack-git Description --- The test cases were using the common account, hence one test affected other test case oepration sometimes. Created new account for each test case. Diffs - test/integration/component/test_escalations_templates.py 3dc24c1 Diff: https://reviews.apache.org/r/29425/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 29246: CLOUDSTACK-8099: Fixed missing import in test_dynamic_compute_offering.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29246/ --- (Updated Dec. 22, 2014, 10:16 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8099 https://issues.apache.org/jira/browse/CLOUDSTACK-8099 Repository: cloudstack-git Description --- Fixed the missing unittest import and pep8 issues. Diffs (updated) - test/integration/component/test_dynamic_compute_offering.py 1e47579 Diff: https://reviews.apache.org/r/29246/diff/ Testing --- Tested with python command and pylint. Thanks, Ashutosh Kelkar
Review Request 29246: CLOUDSTACK-8099: Fixed missing import in test_dynamic_compute_offering.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29246/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8099 https://issues.apache.org/jira/browse/CLOUDSTACK-8099 Repository: cloudstack-git Description --- Fixed the missing unittest import and pep8 issues. Diffs - test/integration/component/test_dynamic_compute_offering.py d96fd84 Diff: https://reviews.apache.org/r/29246/diff/ Testing --- Tested with python command and pylint. Thanks, Ashutosh Kelkar
Review Request 29241: CLOUDSTACK-8095: Fixed Iso attach issue in test_escalations_instances.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29241/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8095 https://issues.apache.org/jira/browse/CLOUDSTACK-8095 Repository: cloudstack-git Description --- The test case was failing while attaching Iso to VM because it did not check whether the Iso is compatible to the VM. Added the check for xenserver and vmware compatible Iso so that xs-tools iso would get attached in case of XenServer and similar to vmware. Also fixed pep8 issues. Diffs - test/integration/component/test_escalations_instances.py e79cd3d Diff: https://reviews.apache.org/r/29241/diff/ Testing --- @Desc: Test Attach ISO to VM and Detach ISO from VM. ... === TestName: test_13_attach_detach_iso | Status : SUCCESS === ok -- Ran 1 test in 167.657s OK Thanks, Ashutosh Kelkar
Review Request 29194: CLOUDSTACK-8087: Fixed test_vpc_on_host_maintenance.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29194/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8087 https://issues.apache.org/jira/browse/CLOUDSTACK-8087 Repository: cloudstack-git Description --- Passed start=False while creating VPC because it is being created when hosts are in maintenance state. Fixed pep8 issues too. Diffs - test/integration/component/maint/test_vpc_on_host_maintenance.py eb3360a Diff: https://reviews.apache.org/r/29194/diff/ Testing --- Yes. It still fails while asserting the state of VPC. On hold until heard from developer. Logged product bug for this. Thanks, Ashutosh Kelkar
Review Request 29094: CLOUDSTACK-8074: Fixed maint/test_multiple_ip_ranges.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29094/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8074 https://issues.apache.org/jira/browse/CLOUDSTACK-8074 Repository: cloudstack-git Description --- There were many issues in this test suite, almost rewrote it (69%). Diffs - test/integration/component/maint/test_multiple_ip_ranges.py 982dd7c Diff: https://reviews.apache.org/r/29094/diff/ Testing --- Deploy guest vm after adding guest IP range in new CIDR ... === TestName: test_01_deploy_vm_in_new_cidr | Status : SUCCESS === ok Deploy guest vm in new CIDR and verify dns service on alias ip ... === TestName: test_02_dns_service_on_alias_ip | Status : SUCCESS === ok Deploy guest vm in new CIDR and verify passwd service on alias ip ... === TestName: test_03_passwd_service_on_alias_IP | Status : SUCCESS === ok Deploy guest vm in new CIDR and verify userdata service on alias ip ... === TestName: test_04_userdata_service_on_alias_IP | Status : SUCCESS === ok Destroy lastvm in the CIDR and verifly alias removal ... === TestName: test_05_del_cidr_verify_alias_removal | Status : SUCCESS === ok Reboot VR and verify ip alias ... === TestName: test_06_reboot_VR_verify_ip_alias | Status : SUCCESS === ok Reboot VR and verify ip alias ... === TestName: test_07_stop_start_VR_verify_ip_alias | Status : SUCCESS === ok -- Ran 7 tests in 1151.865s OK Thanks, Ashutosh Kelkar
Review Request 29046: CLOUDSTACK-8071: Fixed api key issue in test_snapshots_improvement.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29046/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8071 https://issues.apache.org/jira/browse/CLOUDSTACK-8071 Repository: cloudstack-git Description --- The test case failed with Api key does not map with valid account. That is because the apiclient object was assigned previous account's value in another test case. It is important that all test cases use different account and their respective api clients. Made appropriate changes. Diffs - test/integration/component/test_snapshots_improvement.py 6638ddd Diff: https://reviews.apache.org/r/29046/diff/ Testing --- Test perform concurrent snapshots and migrate the vm from one host ... === TestName: test_01_concurrent_snapshots_live_migrate | Status : SUCCESS === ok Test stop running VM while performing concurrent snapshot on volume ... === TestName: test_02_stop_vm_concurrent_snapshots | Status : SUCCESS === ok Test while parent concurrent snapshot job in progress,create ... === TestName: test_03_concurrent_snapshots_create_template | Status : SUCCESS === ok Test while parent concurrent snapshot job in progress,create volume ... === TestName: test_04_concurrent_snapshots_create_volume | Status : SUCCESS === ok -- Ran 4 tests in 1132.201s OK Thanks, Ashutosh Kelkar
Review Request 28695: CLOUDSTACK-8020: test_snapshots.py - Fixed cleanup issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28695/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8020 https://issues.apache.org/jira/browse/CLOUDSTACK-8020 Repository: cloudstack-git Description --- Fixed cleanup issue. Test case failed while deleting snapshot in the cleanup opearation. Snapshot gets cleaned as a part of account cleanup. No need to add it seperately to cleanup list. Diffs - test/integration/component/test_snapshots.py 62f2f06 Diff: https://reviews.apache.org/r/28695/diff/ Testing --- Test Creating snapshot from volume having spaces in name(KVM) ... SKIP: skip Test Snapshot Data Disk ... SKIP: skip Test snapshot from detached disk ... === TestName: test_03_snapshot_detachedDisk | Status : SUCCESS === ok Test Delete Snapshot ... SKIP: skip Create Template from snapshot ... SKIP: skip -- Ran 5 tests in 193.566s OK (SKIP=4) Thanks, Ashutosh Kelkar
Review Request 28642: CLOUDSTACK-7998: test_escalations_instances.py - Correcting code related to detach volume
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28642/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7998 https://issues.apache.org/jira/browse/CLOUDSTACK-7998 Repository: cloudstack-git Description --- Corrected test code according to mentioned steps. Also, removed code that was trying to detach root disk from VM. Diffs - test/integration/component/test_escalations_instances.py cc1f78b Diff: https://reviews.apache.org/r/28642/diff/ Testing --- @Desc: Test Attach ISO to VM and Detach ISO from VM. ... SKIP: Skip @Desc: Test VM Snapshots pagination. ... SKIP: Skip @Desc: Test Revert VM to Snapshot functionality. ... SKIP: Skip @Desc: Test to verify pagination of Volumes for a VM ... === TestName: test_16_list_vm_volumes_pagination | Status : SUCCESS === ok @Desc: Test to verify change service for Running VM ... SKIP: Skip @Desc: Test to verify change service for Stopped VM ... SKIP: Skip @Desc: Test to verify creation and reset of SSH Key for VM ... SKIP: Skip @Desc: Test to verify Update VM details ... SKIP: Skip @Desc: Test to verify Restore VM ... SKIP: Skip @Desc: Test to verify deploy VM with multiple networks ... SKIP: Skip @Desc: Test to verify deploy VM with multiple Security Groups ... SKIP: Skip @Desc: Test to verify deploy VM with static ip address assignment ... SKIP: Skip @Desc: Test to verify dnsmasq dhcp conflict issue due to ... SKIP: Skip @Desc: Test List Instances pagination ... SKIP: Skip @Desc: Test List Running VM's ... SKIP: Skip @Desc: Test List Stopped VM's ... SKIP: Skip @Desc: Test List Destroyed VM's ... SKIP: Skip @Desc: Test List VM by Id ... SKIP: Skip @Desc: Test List VM's by Name ... SKIP: Skip @Desc: Test List VM's by Name and State ... SKIP: Skip @Desc: Test List VM by Zone. ... SKIP: Skip @Desc: Test List VM by Zone. ... SKIP: Skip @Desc: Test List VM by Zone. ... SKIP: Skip @Desc: Test to verify registering and reset of SSH Key for VM ... SKIP: Skip @Desc: Test to verify change service for Running VM ... SKIP: Skip @Desc: Test to verify Nics for a VM ... SKIP: Skip -- Ran 26 tests in 169.896s OK (SKIP=25) Thanks, Ashutosh Kelkar
Review Request 28390: CLOUDSTACK-7965: Fix script related to force delete domain test case
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28390/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7965 https://issues.apache.org/jira/browse/CLOUDSTACK-7965 Repository: cloudstack-git Description --- Fixing a test script issue. When forceful domain deletion fails, code in except adds the child accounts in cleanup list. But they might have deleted during the domain deletion operation. In that case the cleanup operation fails. Domain deletion should be outside the try catch block. Diffs - test/integration/component/test_persistent_networks.py f782700 Diff: https://reviews.apache.org/r/28390/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 28389: CLOUDSTACK-7963: Fixed test case in test_dedicate_guest_vlan_ranges.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28389/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7963 https://issues.apache.org/jira/browse/CLOUDSTACK-7963 Repository: cloudstack-git Description --- Test case failed with exception: int() argument must be a string or a number, not 'NoneType' It fails while checking if the vlan id of the network is from the dedicated range. The network does not get vlan id in the first place because it is not in implemented state. Solution: Either deploy a VM in the network or implement the network with persistent network offering Changes: Used persistent network offering instead of normal offering. Diffs - test/integration/component/test_dedicate_guest_vlan_ranges.py efba229 Diff: https://reviews.apache.org/r/28389/diff/ Testing --- Release a dedicated vlan range when no vlan id is in use ... === TestName: test_05_release_range_vlan_in_use | Status : SUCCESS === ok -- Ran 1 test in 61.409s OK Thanks, Ashutosh Kelkar
Review Request 28278: CLOUDSTACK-7949: Fixing issue in test_base_image_updation.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28278/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7949 https://issues.apache.org/jira/browse/CLOUDSTACK-7949 Repository: cloudstack-git Description --- The test case test_04 failed while rebooting because the template it was using was being deleted in test_03. Instead the template should be deleted after all the test cases have executed. Made according changes and also fixeed the assertion. Diffs - test/integration/component/test_base_image_updation.py 8288f2c Diff: https://reviews.apache.org/r/28278/diff/ Testing --- Test deploy an instance with service offerings with IsVolatile set. ... === TestName: test_01_deploy_instance_with_is_volatile_offering | Status : SUCCESS === ok Test rebooting instances created with isVolatile service offerings ... === TestName: test_02_reboot_instance_with_is_volatile_offering | Status : SUCCESS === ok Test restoring a vm with different template than the one it was created with ... === TestName: test_03_restore_vm_with_new_template | Status : SUCCESS === ok 1) Create a VM using the Service offering IsVolatile enabled ... === TestName: test_04_reoccuring_snapshot_rules | Status : SUCCESS === ok -- Ran 4 tests in 5416.231s OK Thanks, Ashutosh Kelkar
Review Request 28281: CLOUDSTACK-7953: Fixed time wait period for verifying snapshot policy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28281/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7953 https://issues.apache.org/jira/browse/CLOUDSTACK-7953 Repository: cloudstack-git Description --- The wait period for checking the max snapshots created by snapshot policy should be double the snapshot policy time. In that way we can be sure that snapshot policy is not creating snapshots more than maxsnaps parameter. Diffs - test/integration/component/test_snapshot_limits.py 18a1c65 Diff: https://reviews.apache.org/r/28281/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 28225: CLOUDSTACK-7942: Fixing account permission issue in test_template.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28225/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7942 https://issues.apache.org/jira/browse/CLOUDSTACK-7942 Repository: cloudstack-git Description --- Creating virtual machine was failing because it was using the template created with the root admin account. Instead the account should create the template. Diffs - test/integration/component/test_templates.py 769848d Diff: https://reviews.apache.org/r/28225/diff/ Testing --- Create Template from snapshot ... === TestName: test_04_template_from_snapshot | Status : SUCCESS === ok -- Ran 1 test in 588.850s OK Thanks, Ashutosh Kelkar
Review Request 28163: CLOUDSTACK-7934: Fixed cleanup issues test_escalations_volumes.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28163/ --- Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7934 https://issues.apache.org/jira/browse/CLOUDSTACK-7934 Repository: cloudstack-git Description --- Snapshots, volumes get cleaned up after each test case as part of account cleanup. No need to add them separately to cleanup list. Diffs - test/integration/component/test_escalations_volumes.py 7290325 Diff: https://reviews.apache.org/r/28163/diff/ Testing --- Yes. Log: @summary: Test List Volumes pagination ... SKIP: Skip @summary: Test List Volumes with Id ... SKIP: Skip @summary: Test to verify creation and resize of data volume ... SKIP: Skip @summary: Test to verify creation and resize of custom volume ... SKIP: Skip @summary: Test to verify creation of snapshot from volume ... SKIP: Skip @summary: Test to verify creation of Hourly Snapshot policies ... SKIP: Skip @summary: Test to verify creation of Daily Snapshot policies ... SKIP: Skip @summary: Test to verify creation of Weekly Snapshot policies ... SKIP: Skip @summary: Test to verify creation of Monthly Snapshot policies ... SKIP: Skip @summary: Test to verify pagination of snapshots for Volume ... SKIP: Skip @summary: Test to verify extract/download a Volume ... SKIP: Skip @summary: Test to verify upload volume ... SKIP: Skip @Desc:Create volume from custom disk offering does not work as expected ... === TestName: test_13_volume_custom_disk_size | Status : SUCCESS === ok -- Ran 13 tests in 170.553s OK (SKIP=12) @summary: Test List Volumes pagination ... SKIP: Skip @summary: Test List Volumes with Id ... SKIP: Skip @summary: Test to verify creation and resize of data volume ... SKIP: Skip @summary: Test to verify creation and resize of custom volume ... SKIP: Skip @summary: Test to verify creation of snapshot from volume ... === TestName: test_05_volume_snapshot | Status : SUCCESS === ok @summary: Test to verify creation of Hourly Snapshot policies ... SKIP: Skip @summary: Test to verify creation of Daily Snapshot policies ... SKIP: Skip @summary: Test to verify creation of Weekly Snapshot policies ... SKIP: Skip @summary: Test to verify creation of Monthly Snapshot policies ... SKIP: Skip @summary: Test to verify pagination of snapshots for Volume ... === TestName: test_10_volume_snapshots_pagination | Status : SUCCESS === ok Thanks, Ashutosh Kelkar
Re: Review Request 27321: CLOUDSTACK-7815: Automation test cases for system VM HA test path
On Nov. 10, 2014, 12:05 p.m., SrikanteswaraRao Talluri wrote: test/integration/testpaths/testpath_system_vm_ha.py, line 462 https://reviews.apache.org/r/27321/diff/2/?file=747212#file747212line462 I feel this step is not related to this test. We are just making sure none of the VM or System VM is still present on the host. If any was present, then it's migrated. I have updated the comment. On Nov. 10, 2014, 12:05 p.m., SrikanteswaraRao Talluri wrote: test/integration/testpaths/testpath_system_vm_ha.py, line 532 https://reviews.apache.org/r/27321/diff/2/?file=747212#file747212line532 how do you make sure that guest VMs and router VMs are on the same host. otherwise, you will not see them migrate to another host. Yes, we are only checking that no vm/system Vm is present on the host and if any it is moved to other host. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27321/#review60579 --- On Nov. 3, 2014, 8:51 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27321/ --- (Updated Nov. 3, 2014, 8:51 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7815 https://issues.apache.org/jira/browse/CLOUDSTACK-7815 Repository: cloudstack-git Description --- Convers around 12 scenarios. More patches to follow if scenarios are automatable. Diffs - test/integration/testpaths/testpath_system_vm_ha.py PRE-CREATION Diff: https://reviews.apache.org/r/27321/diff/ Testing --- Bring down the host on which SSVM is running ... === TestName: test_01_bring_ssvm_host_down | Status : SUCCESS === ok Bring down the host on which CPVM is running ... === TestName: test_02_bring_cpvm_host_down | Status : SUCCESS === ok Bring down the host on which router is running ... === TestName: test_03_bring_router_host_down | Status : SUCCESS === ok -- Ran 3 tests in 1137.479s OK Thanks, Ashutosh Kelkar
Re: Review Request 27321: CLOUDSTACK-7815: Automation test cases for system VM HA test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27321/ --- (Updated Nov. 3, 2014, 8:51 a.m.) Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7815 https://issues.apache.org/jira/browse/CLOUDSTACK-7815 Repository: cloudstack-git Description (updated) --- Convers around 12 scenarios. More patches to follow if scenarios are automatable. Diffs (updated) - test/integration/testpaths/testpath_system_vm_ha.py PRE-CREATION Diff: https://reviews.apache.org/r/27321/diff/ Testing (updated) --- Bring down the host on which SSVM is running ... === TestName: test_01_bring_ssvm_host_down | Status : SUCCESS === ok Bring down the host on which CPVM is running ... === TestName: test_02_bring_cpvm_host_down | Status : SUCCESS === ok Bring down the host on which router is running ... === TestName: test_03_bring_router_host_down | Status : SUCCESS === ok -- Ran 3 tests in 1137.479s OK Thanks, Ashutosh Kelkar
Review Request 27321: CLOUDSTACK-7815: Automation test cases for system VM HA test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27321/ --- Review request for cloudstack, suresh sadhu and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7815 https://issues.apache.org/jira/browse/CLOUDSTACK-7815 Repository: cloudstack-git Description --- This is the first patch for system VM HA test path. IT convers around 10 scenarios. More patches to follow. Diffs - test/integration/testpaths/testpath_system_vm_ha.py PRE-CREATION Diff: https://reviews.apache.org/r/27321/diff/ Testing --- Bring the host on which SSVM is running, down ... === TestName: test_01_bring_ssvm_host_down | Status : SUCCESS === ok Bring the host on which CPVM is running, down ... === TestName: test_02_bring_cpvm_host_down | Status : SUCCESS === ok -- Ran 2 tests in 1720.132s OK Thanks, Ashutosh Kelkar
Error while deploying System VMs
Hello all, I set up CS on latest master code, and I observe error while starting the system VMs. Also, the secondary storage is shown as 0/0 on Dashboard. I can see the error while mounting secondary storage, could not identify the cause. I have executed cloud-install-sys-tmplt command it successfully seeds the system templates. Please help me in identifying the exact issue, here are the management server logs. WARN [c.c.u.d.Merovingian2] (Work-Job-Executor-19:ctx-0e65266f job-306/job-336 ctx-b37c0c6e) Was unable to find lock for the key template_spool_ref126 and thread id 4 18267521 com.cloud.utils.exception.CloudRuntimeException: Was unable to find lock for the key template_spool_ref126 and thread id 418267521 at com.cloud.utils.db.Merovingian2.release(Merovingian2.java:274) at com.cloud.utils.db.TransactionLegacy.release(TransactionLegacy.java:397) at com.cloud.utils.db.GenericDaoBase.releaseFromLockTable(GenericDaoBase.java:1045) at sun.reflect.GeneratedMethodAccessor157.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:183) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:150) at com.cloud.utils.db.TransactionContextInterceptor.invoke(TransactionContextInterceptor.java:34) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:161) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:91) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204) at com.sun.proxy.$Proxy73.releaseFromLockTable(Unknown Source) at org.apache.cloudstack.storage.volume.VolumeServiceImpl.createBaseImageAsync(VolumeServiceImpl.java:514) at org.apache.cloudstack.storage.volume.VolumeServiceImpl.createVolumeFromTemplateAsync(VolumeServiceImpl.java:748) at org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.recreateVolume(VolumeOrchestrator.java:1227) at org.apache.cloudstack.engine.orchestration.VolumeOrchestrator.prepare(VolumeOrchestrator.java:1297) at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:974) at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:4600) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at com.cloud.vm.VmWorkJobHandlerProxy.handleVmWorkJob(VmWorkJobHandlerProxy.java:107) at com.cloud.vm.VirtualMachineManagerImpl.handleVmWorkJob(VirtualMachineManagerImpl.java:4756) at com.cloud.vm.VmWorkJobDispatcher.runJob(VmWorkJobDispatcher.java:102) at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:513) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:470) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:745) INFO [c.c.v.VirtualMachineManagerImpl] (Work-Job-Executor-19:ctx-0e65266f job-306/job-336 ctx-b37c0c6e) Unable to contact resource. com.cloud.exception.StorageUnavailableException: Resource [StoragePool:1] is unreachable: Unable to create Vol[2|vm=2|ROOT]:Catch Exception com.cloud.utils.exception.C loudRuntimeException for template + due to
Review Request 25885: CLOUDSTACK-7594: Adding automation test cases for Stopped VM test path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25885/ --- Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-7594 https://issues.apache.org/jira/browse/CLOUDSTACK-7594 Repository: cloudstack-git Description --- Automation test cases for Stopped VM test path. Diffs - test/integration/testpaths/__init__.py PRE-CREATION test/integration/testpaths/testpath_stopped_vm.py PRE-CREATION Diff: https://reviews.apache.org/r/25885/diff/ Testing --- Yes. 4 test cases are failing due to wrong router state, I am investigating on this. Log: Positive test for stopped VM test path - T1 ... === TestName: test_01_pt_deploy_vm_without_startvm | Status : FAILED === FAIL Positive test for stopped VM test path - T1 variant ... === TestName: test_02_pt_deploy_vm_with_startvm_true | Status : FAILED === FAIL Positive test for stopped VM test path - T2 ... === TestName: test_03_pt_deploy_vm_with_startvm_false | Status : FAILED === FAIL Positive test for stopped VM test path - T2 variant ... === TestName: test_04_pt_deploy_vm_with_startvm_true | Status : FAILED === FAIL Positive test for stopped VM test path - T3 and variant ... === TestName: test_05_pt_startvm_false_attach_disk | Status : SUCCESS === ok Positive test for stopped VM test path - T4 ... === TestName: test_06_pt_startvm_false_attach_disk_change_SO | Status : SUCCESS === ok Positive test for stopped VM test path - T5 ... === TestName: test_07_pt_startvm_false_attach_iso | Status : SUCCESS === ok Positive test for stopped VM test path - T5 variant ... === TestName: test_08_pt_startvm_false_attach_iso_running_vm | Status : SUCCESS === ok == FAIL: Positive test for stopped VM test path - T1 -- Traceback (most recent call last): File /root/test/testpath_stopped_vm.py, line 260, in test_01_pt_deploy_vm_without_startvm self.assertTrue(response[0], response[1]) AssertionError: Router state should be Stopped, it is Running begin captured stdout - === TestName: test_01_pt_deploy_vm_without_startvm | Status : FAILED === Thanks, Ashutosh Kelkar
Re: Review Request 25094: CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25094/ --- (Updated Aug. 28, 2014, 7:50 a.m.) Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-2251 https://issues.apache.org/jira/browse/CLOUDSTACK-2251 Repository: cloudstack-git Description --- Review Changes done as suggested in https://reviews.apache.org/r/23819/ CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature Diffs - test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION tools/marvin/marvin/config/test_data.py ade8657 tools/marvin/marvin/lib/base.py 99a541a Diff: https://reviews.apache.org/r/25094/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
On Aug. 18, 2014, 12:19 p.m., sanjeev n wrote: test/integration/component/test_dedicate_public_ip_range.py, line 920 https://reviews.apache.org/r/23819/diff/1/?file=639413#file639413line920 What is the need for acquiring ip address here? Not deploying any vms in the netowrk so why do we need IP address for source nat? I will be working on this patch. Apparently we can't add a guest network without source nat, the network offering does not list out when we try to create a network with network offering which does not provide source nat. And when the source nat service is enabled for a network, the first public IP acquired is used for source nat and we can't disassociate it. On Aug. 18, 2014, 12:19 p.m., sanjeev n wrote: test/integration/component/test_dedicate_public_ip_range.py, line 1080 https://reviews.apache.org/r/23819/diff/1/?file=639413#file639413line1080 Add code to verify the ip range release is success or not. Will do. I will add the patch with review changes through my account. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23819/#review50869 --- On July 22, 2014, 5:52 p.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23819/ --- (Updated July 22, 2014, 5:52 p.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-2251 https://issues.apache.org/jira/browse/CLOUDSTACK-2251 Repository: cloudstack-git Description --- CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature Diffs - test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION tools/marvin/marvin/config/test_data.py 3cd4b6c tools/marvin/marvin/lib/base.py 1a32275 Diff: https://reviews.apache.org/r/23819/diff/ Testing --- Yes Thanks, Girish Shilamkar
Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits
On July 22, 2014, 12:19 p.m., sanjeev n wrote: test/integration/component/test_ss_domain_limits.py, line 244 https://reviews.apache.org/r/22805/diff/3/?file=616580#file616580line244 Step6 is missing. Please add test for step6 Done. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22805/#review48358 --- On July 22, 2014, 8:39 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22805/ --- (Updated July 22, 2014, 8:39 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow. Diffs - test/integration/component/test_ss_domain_limits.py PRE-CREATION test/integration/component/test_ss_limits.py PRE-CREATION test/integration/component/test_ss_max_limits.py PRE-CREATION test/integration/component/test_ss_project_limits.py PRE-CREATION tools/marvin/marvin/config/test_data.py d870c98 tools/marvin/marvin/lib/base.py 1ea4fa7 Diff: https://reviews.apache.org/r/22805/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23819/#review51646 --- Review Changes included in patch at: https://reviews.apache.org/r/25094/ - Ashutosh Kelkar On July 22, 2014, 5:52 p.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23819/ --- (Updated July 22, 2014, 5:52 p.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-2251 https://issues.apache.org/jira/browse/CLOUDSTACK-2251 Repository: cloudstack-git Description --- CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature Diffs - test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION tools/marvin/marvin/config/test_data.py 3cd4b6c tools/marvin/marvin/lib/base.py 1a32275 Diff: https://reviews.apache.org/r/23819/diff/ Testing --- Yes Thanks, Girish Shilamkar
Re: Review Request 24055: CLOUDSTACK-2251: Automation test cases for feature - Dedicated guest VLAN ranges per tenant
On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: test/integration/component/test_dedicate_guest_vlan_ranges.py, line 1197 https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line1197 This assert statement does not make sense because no vlan would be assigned to the network created here. Not sure what would be the value of netowrks[0].vlan when there is no vlan assigned for the network. Ashutosh Kelkar wrote: Why would there be no vlan assigned? The network takes vlan from the dedicated range automatically, and if dedicated range is not availble, then it will take random vlan from the vlan range of physical network. I have used persistent network here, hence it will automatically get a vlan id even when VM is not deployed in it. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/#review50850 --- On Aug. 22, 2014, 10:14 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/ --- (Updated Aug. 22, 2014, 10:14 a.m.) Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and Sowmya Krishnan. Bugs: CLOUDSTACK-2251 https://issues.apache.org/jira/browse/CLOUDSTACK-2251 Repository: cloudstack-git Description --- Automation test cases for feature - Dedicated guest VLAN ranges per tenant Diffs - test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION tools/marvin/marvin/lib/base.py f0d53a6 tools/marvin/marvin/lib/common.py 3706456 Diff: https://reviews.apache.org/r/24055/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23452/ --- (Updated Aug. 22, 2014, 6:24 a.m.) Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri. Changes --- Review Changes. Bugs: CLOUDSTACK-4840 https://issues.apache.org/jira/browse/CLOUDSTACK-4840 Repository: cloudstack-git Description --- Adding automation tests for LB for secondary IP Diffs (updated) - test/integration/component/test_lb_secondary_ip.py PRE-CREATION tools/marvin/marvin/config/test_data.py a93b883 tools/marvin/marvin/lib/base.py f0d53a6 Diff: https://reviews.apache.org/r/23452/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP
On Aug. 12, 2014, 11:07 a.m., sanjeev n wrote: test/integration/component/test_lb_secondary_ip.py, line 205 https://reviews.apache.org/r/23452/diff/2/?file=658387#file658387line205 Add Assertion to check whether assigning lb rule to secondary ip address is success or not. Applicable in all tests Added common function to check that LB rule is created for given ip addresses or not. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23452/#review50299 --- On Aug. 22, 2014, 6:24 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23452/ --- (Updated Aug. 22, 2014, 6:24 a.m.) Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-4840 https://issues.apache.org/jira/browse/CLOUDSTACK-4840 Repository: cloudstack-git Description --- Adding automation tests for LB for secondary IP Diffs - test/integration/component/test_lb_secondary_ip.py PRE-CREATION tools/marvin/marvin/config/test_data.py a93b883 tools/marvin/marvin/lib/base.py f0d53a6 Diff: https://reviews.apache.org/r/23452/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 24055: CLOUDSTACK-2251: Automation test cases for feature - Dedicated guest VLAN ranges per tenant
On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: test/integration/component/test_dedicate_guest_vlan_ranges.py, line 1197 https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line1197 This assert statement does not make sense because no vlan would be assigned to the network created here. Not sure what would be the value of netowrks[0].vlan when there is no vlan assigned for the network. Why would there be no vlan assigned? The network takes vlan from the dedicated range automatically, and if dedicated range is not availble, then it will take random vlan from the vlan range of physical network. On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: test/integration/component/test_dedicate_guest_vlan_ranges.py, line 1201 https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line1201 Not catching the exception if releasing vlan range fails for some reason. Add code to handle the error in releasing vlan range. I don't think that is necessary, because anyway cleanup operation will be called when exception occurs in the test case. And if releasing vlan range fails then there is nothing to do explicitly. We will get to see the reason in the logs. On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: test/integration/component/test_dedicate_guest_vlan_ranges.py, line 567 https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line567 Add assertions to check whether the vlan dedecation is success or not. Applies to account2 as well. Will do. On Aug. 18, 2014, 5:36 a.m., sanjeev n wrote: test/integration/component/test_dedicate_guest_vlan_ranges.py, line 962 https://reviews.apache.org/r/24055/diff/1/?file=644474#file644474line962 Add assertion since this is where the actual test is happening. Will do. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/#review50850 --- On July 29, 2014, 2:20 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/ --- (Updated July 29, 2014, 2:20 p.m.) Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and Sowmya Krishnan. Bugs: CLOUDSTACK-2251 https://issues.apache.org/jira/browse/CLOUDSTACK-2251 Repository: cloudstack-git Description --- Automation test cases for feature - Dedicated guest VLAN ranges per tenant Diffs - test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION tools/marvin/marvin/lib/base.py 58033c6 tools/marvin/marvin/lib/common.py 187ede6 Diff: https://reviews.apache.org/r/24055/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 24055: CLOUDSTACK-2251: Automation test cases for feature - Dedicated guest VLAN ranges per tenant
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/ --- (Updated Aug. 22, 2014, 10:14 a.m.) Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and Sowmya Krishnan. Changes --- Review Changes. Bugs: CLOUDSTACK-2251 https://issues.apache.org/jira/browse/CLOUDSTACK-2251 Repository: cloudstack-git Description --- Automation test cases for feature - Dedicated guest VLAN ranges per tenant Diffs (updated) - test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION tools/marvin/marvin/lib/base.py f0d53a6 tools/marvin/marvin/lib/common.py 3706456 Diff: https://reviews.apache.org/r/24055/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 24055: CLOUDSTACK-2251: Automation test cases for feature - Dedicated guest VLAN ranges per tenant
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/ --- Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and Sowmya Krishnan. Bugs: CLOUDSTACK-2251 https://issues.apache.org/jira/browse/CLOUDSTACK-2251 Repository: cloudstack-git Description --- Automation test cases for feature - Dedicated guest VLAN ranges per tenant Diffs - test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION tools/marvin/marvin/lib/base.py 58033c6 tools/marvin/marvin/lib/common.py 187ede6 Diff: https://reviews.apache.org/r/24055/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23452/ --- (Updated July 25, 2014, 12:25 p.m.) Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, Sowmya Krishnan, and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-4840 https://issues.apache.org/jira/browse/CLOUDSTACK-4840 Repository: cloudstack-git Description --- Adding automation tests for LB for secondary IP Diffs - test/integration/component/test_lb_secondary_ip.py PRE-CREATION tools/marvin/marvin/lib/base.py 1a32275 Diff: https://reviews.apache.org/r/23452/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23452/ --- (Updated July 23, 2014, 6:32 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-4840 https://issues.apache.org/jira/browse/CLOUDSTACK-4840 Repository: cloudstack-git Description --- Adding automation tests for LB for secondary IP Diffs - test/integration/component/test_lb_secondary_ip.py PRE-CREATION tools/marvin/marvin/lib/base.py 1a32275 Diff: https://reviews.apache.org/r/23452/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 23793: CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23793/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7137 https://issues.apache.org/jira/browse/CLOUDSTACK-7137 Repository: cloudstack-git Description --- Resolved the cleanup issue. The security group was not removed from cleanup list after deleting it. So it failed to find the security group in cleanup operation. Also, removed the unnecessary imports. Diffs - test/integration/component/test_escalations_securitygroups.py 8934088 Diff: https://reviews.apache.org/r/23793/diff/ Testing --- Yes. Log: @Desc: Test to List Security Groups pagination ... === TestName: test_01_list_securitygroups_pagination | Status : SUCCESS === ok @Desc: Test to Authorize and Revoke Ingress for Security Group ... SKIP: skip @Desc: Test to Authorize and Revoke Egress for Security Group ... SKIP: skip -- Ran 3 tests in 5.845s OK (SKIP=2) Thanks, Ashutosh Kelkar
Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22805/ --- (Updated July 22, 2014, 8:39 a.m.) Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow. Diffs - test/integration/component/test_ss_domain_limits.py PRE-CREATION test/integration/component/test_ss_limits.py PRE-CREATION test/integration/component/test_ss_max_limits.py PRE-CREATION test/integration/component/test_ss_project_limits.py PRE-CREATION tools/marvin/marvin/config/test_data.py d870c98 tools/marvin/marvin/lib/base.py 1ea4fa7 Diff: https://reviews.apache.org/r/22805/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 23813: CLOUDSTACK-7044: Portable IP Range test case changes - reading portable ip range from test_data.py file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23813/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7044 https://issues.apache.org/jira/browse/CLOUDSTACK-7044 Repository: cloudstack-git Description --- Changes: 1. Removing method getPortableIpRangeServices from common.py file 2. Reading the portable IP range data from test_data.py file Diffs - test/integration/component/test_portable_ip.py ce27dd8 tools/marvin/marvin/config/test_data.py 19b9aa4 tools/marvin/marvin/lib/common.py bc6b9c7 Diff: https://reviews.apache.org/r/23813/diff/ Testing --- Yes. Tested on KVM Advanced setup. Thanks, Ashutosh Kelkar
Review Request 23814: CLOUDSTACK-7148: Adding missing list in method call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23814/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7148 https://issues.apache.org/jira/browse/CLOUDSTACK-7148 Repository: cloudstack-git Description --- Adding missing list in method call. Diffs - test/integration/component/test_redundant_router_cleanups.py 444fa3a Diff: https://reviews.apache.org/r/23814/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 23677: CLOUDSTACK-7024: Resolved cleanup issue in test script
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23677/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7024 https://issues.apache.org/jira/browse/CLOUDSTACK-7024 Repository: cloudstack-git Description --- Resolved issue related to order of cleanup items. The project must be removed before the account which manages it. Diffs - test/integration/component/test_project_usage.py 5e0dda5 Diff: https://reviews.apache.org/r/23677/diff/ Testing --- Yes. Log: Test Upload/ delete a template and verify correct usage is generated ... === TestName: test_01_template_usage | Status : SUCCESS === ok -- Ran 1 test in 285.451s OK Thanks, Ashutosh Kelkar
Review Request 23607: CLOUDSTACK-7020:Fixed test script issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23607/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7020 https://issues.apache.org/jira/browse/CLOUDSTACK-7020 Repository: cloudstack-git Description --- Fixed test script issue related to cleanup Diffs - test/integration/component/test_usage.py 4413f43 Diff: https://reviews.apache.org/r/23607/diff/ Testing --- Yes. Log: Test Upload/ delete a template and verify correct usage is generated ... === TestName: test_01_template_usage | Status : SUCCESS === ok -- Ran 1 test in 573.037s OK Thanks, Ashutosh Kelkar
Review Request 23608: CLOUDSTACK-7014: Resolving test script related to affinity groups tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23608/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7014 https://issues.apache.org/jira/browse/CLOUDSTACK-7014 Repository: cloudstack-git Description --- Changing __cleanup to _cleanup Diffs - test/integration/component/test_affinity_groups.py de5f007 Diff: https://reviews.apache.org/r/23608/diff/ Testing --- Yes Thanks, Ashutosh Kelkar
Review Request 23613: CLOUDSTACK-7022: Fixed typo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23613/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-7022 https://issues.apache.org/jira/browse/CLOUDSTACK-7022 Repository: cloudstack-git Description --- Fixed typo. Diffs - test/integration/component/test_usage.py 4f9d1d7 Diff: https://reviews.apache.org/r/23613/diff/ Testing --- Thanks, Ashutosh Kelkar
Review Request 23452: CLOUDSTACK-4840: Automation tests - LB for secondary IP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23452/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-4840 https://issues.apache.org/jira/browse/CLOUDSTACK-4840 Repository: cloudstack-git Description --- Adding automation tests for LB for secondary IP Diffs - test/integration/component/test_lb_secondary_ip.py PRE-CREATION tools/marvin/marvin/lib/base.py 1a32275 Diff: https://reviews.apache.org/r/23452/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22805/ --- (Updated June 25, 2014, 3:24 p.m.) Review request for cloudstack and Girish Shilamkar. Changes --- Updating patch with final test suite. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow. Diffs (updated) - test/integration/component/test_ss_domain_limits.py PRE-CREATION test/integration/component/test_ss_limits.py PRE-CREATION test/integration/component/test_ss_max_limits.py PRE-CREATION test/integration/component/test_ss_project_limits.py PRE-CREATION tools/marvin/marvin/config/test_data.py d870c98 tools/marvin/marvin/lib/base.py 1ea4fa7 Diff: https://reviews.apache.org/r/22805/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22805/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow. Diffs - test/integration/component/test_ss_domain_limits.py PRE-CREATION test/integration/component/test_ss_limits.py PRE-CREATION tools/marvin/marvin/config/test_data.py d870c98 tools/marvin/marvin/lib/base.py 8b89087 Diff: https://reviews.apache.org/r/22805/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 22805: CLOUDSTACK-1466:Adding automation tests for Secondary Storage Limits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22805/ --- (Updated June 20, 2014, 3:10 p.m.) Review request for cloudstack and Girish Shilamkar. Changes --- Adding one more test suite. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Automation tests for Secondary Storage Limits. This patch contains 2 test suites. 2 more test suites to follow. Diffs (updated) - test/integration/component/test_ss_domain_limits.py PRE-CREATION test/integration/component/test_ss_limits.py PRE-CREATION test/integration/component/test_ss_max_limits.py PRE-CREATION tools/marvin/marvin/config/test_data.py d870c98 tools/marvin/marvin/lib/base.py c3d98c9 Diff: https://reviews.apache.org/r/22805/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 22674: CLOUDSTACK-1466: Automation - Secondary Storage Test Cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22674/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Adding 2 test suites for secondary storage limit test cases. More test suites to follow. The common and utility functions used are already available in primary storage limits patch added by Gaurav (https://reviews.apache.org/r/20316/). Diffs - test/integration/component/test_ss_domain_limits.py PRE-CREATION test/integration/component/test_ss_limits.py PRE-CREATION tools/marvin/marvin/config/test_data.py d870c98 tools/marvin/marvin/lib/base.py 8b89087 Diff: https://reviews.apache.org/r/22674/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in portable ip test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21973/ --- (Updated June 10, 2014, 11:16 a.m.) Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. Changes --- Santhosh, please take a look at updated patch. Bugs: CLOUDSTACK-6780 https://issues.apache.org/jira/browse/CLOUDSTACK-6780 Repository: cloudstack-git Description --- Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup. Diffs - test/integration/component/test_portable_ip.py 847bb4a Diff: https://reviews.apache.org/r/21973/diff/ Testing --- Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS === ok Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS === ok Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS === ok -- Ran 3 tests in 263.215s OK Thanks, Ashutosh Kelkar
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py
On June 3, 2014, 12:27 p.m., Santhosh Edukulla wrote: test/integration/smoke/test_non_contigiousvlan.py, line 47 https://reviews.apache.org/r/22197/diff/2/?file=602802#file602802line47 As well, can we run these changes once and see no issues if its possible? Yes I did run it again after the changes. On June 3, 2014, 12:27 p.m., Santhosh Edukulla wrote: test/integration/smoke/test_non_contigiousvlan.py, line 45 https://reviews.apache.org/r/22197/diff/2/?file=602802#file602802line45 It seems we are not reading test data. Can we check that? It is not required here. As only test data the test case was earlier reading was vlan ids. And now we have removed that data and getting the free vlan ids through code from the setup. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44616 --- On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/ --- (Updated June 3, 2014, 11:45 a.m.) Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. Bugs: CLOUDSTACK-6776 https://issues.apache.org/jira/browse/CLOUDSTACK-6776 Repository: cloudstack-git Description --- The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically. Diffs - test/integration/smoke/test_non_contigiousvlan.py 90235ec Diff: https://reviews.apache.org/r/22197/diff/ Testing --- Yes. Log: Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS === ok -- Ran 1 test in 15.328s OK ~ ~ Thanks, Ashutosh Kelkar
Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/ --- Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. Bugs: CLOUDSTACK-6776 https://issues.apache.org/jira/browse/CLOUDSTACK-6776 Repository: cloudstack-git Description --- The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically. Diffs - test/integration/smoke/test_non_contigiousvlan.py 90235ec Diff: https://reviews.apache.org/r/22197/diff/ Testing --- Yes. Log: Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS === ok -- Ran 1 test in 15.328s OK ~ ~ Thanks, Ashutosh Kelkar
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py
On June 3, 2014, 11:22 a.m., Santhosh Edukulla wrote: test/integration/smoke/test_non_contigiousvlan.py, line 29 https://reviews.apache.org/r/22197/diff/1/?file=602789#file602789line29 Is it ok to move to test data? Removed services dictionary as it is no longer used - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/#review44612 --- On June 3, 2014, 11:45 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/ --- (Updated June 3, 2014, 11:45 a.m.) Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. Bugs: CLOUDSTACK-6776 https://issues.apache.org/jira/browse/CLOUDSTACK-6776 Repository: cloudstack-git Description --- The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically. Diffs - test/integration/smoke/test_non_contigiousvlan.py 90235ec Diff: https://reviews.apache.org/r/22197/diff/ Testing --- Yes. Log: Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS === ok -- Ran 1 test in 15.328s OK ~ ~ Thanks, Ashutosh Kelkar
Re: Review Request 22197: CLOUDSTACK-6776: Removed hard coded vlan ids from BVT test_non_contiguous_vlan.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22197/ --- (Updated June 3, 2014, 11:45 a.m.) Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. Changes --- Review changes. Bugs: CLOUDSTACK-6776 https://issues.apache.org/jira/browse/CLOUDSTACK-6776 Repository: cloudstack-git Description --- The test case fails whenever hard coded values overlap with already configured VLAN in the physical network. Removed hard code VLAN ids and used the common function to get unused VLAN ids from the physical network dynamically. Diffs (updated) - test/integration/smoke/test_non_contigiousvlan.py 90235ec Diff: https://reviews.apache.org/r/22197/diff/ Testing --- Yes. Log: Test to update a physical network and extend its vlan ... === TestName: test_extendPhysicalNetworkVlan | Status : SUCCESS === ok -- Ran 1 test in 15.328s OK ~ ~ Thanks, Ashutosh Kelkar
Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in portable ip test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21973/ --- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6780 https://issues.apache.org/jira/browse/CLOUDSTACK-6780 Repository: cloudstack-git Description --- Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup. Diffs - test/integration/component/test_portable_ip.py 847bb4a Diff: https://reviews.apache.org/r/21973/diff/ Testing --- Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS === ok Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS === ok Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS === ok -- Ran 3 tests in 263.215s OK Thanks, Ashutosh Kelkar
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in portable ip test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21973/ --- (Updated May 28, 2014, 9:38 a.m.) Review request for cloudstack and Girish Shilamkar. Changes --- Updated patch. Bugs: CLOUDSTACK-6780 https://issues.apache.org/jira/browse/CLOUDSTACK-6780 Repository: cloudstack-git Description --- Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup. Diffs (updated) - test/integration/component/test_portable_ip.py 847bb4a Diff: https://reviews.apache.org/r/21973/diff/ Testing --- Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS === ok Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS === ok Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS === ok -- Ran 3 tests in 263.215s OK Thanks, Ashutosh Kelkar
Re: Review Request 21973: CLOUDSTACK-6780: Resolved cleanup issue in portable ip test cases
On May 28, 2014, 7:09 a.m., Santhosh Edukulla wrote: test/integration/component/test_portable_ip.py, line 1118 https://reviews.apache.org/r/21973/diff/1/?file=597289#file597289line1118 Here, we are deleting with api_client_user, but in finally self.apiclient. Is that the purpose? We are trying to delete with api client of the account which was not used to create IP address. This should fail. And then before test case returns, we must delete ip with api client of account which was used to create it (in this case self.apiclient), so that all IP addresses are disassociated and IP range gets deleted successfully in cleanup. On May 28, 2014, 7:09 a.m., Santhosh Edukulla wrote: test/integration/component/test_portable_ip.py, line 1123 https://reviews.apache.org/r/21973/diff/1/?file=597289#file597289line1123 same entity is getting deleting both in try\finally. This case can happen when there is no exception thrown from CS and it will hit try and then finally. It will lead to exception again. You are right, we should have it only in try block. Corrected in upadated patch. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21973/#review44103 --- On May 28, 2014, 9:38 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21973/ --- (Updated May 28, 2014, 9:38 a.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-6780 https://issues.apache.org/jira/browse/CLOUDSTACK-6780 Repository: cloudstack-git Description --- Portable IP address was not getting disassociated. Added it to finally block so that it will get associated always and portable ip range gets cleaned up properly during cleanup. Diffs - test/integration/component/test_portable_ip.py 847bb4a Diff: https://reviews.apache.org/r/21973/diff/ Testing --- Test disassociating portable ip ... === TestName: test_disassociate_ip_address_no_services | Status : SUCCESS === ok Test disassociating portable IP with non-owner account ... === TestName: test_disassociate_ip_address_other_account | Status : SUCCESS === ok Test disassociating portable ip ... === TestName: test_disassociate_ip_address_services_enabled | Status : SUCCESS === ok -- Ran 3 tests in 263.215s OK Thanks, Ashutosh Kelkar
Review Request 20832: CLOUDSTACK-1466: Adding first set of test cases for secondary storage limits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20832/ --- Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Adding first set of test cases for Secondary Storage Limits. The common functions are added by Gaurav in Primary Storage patch so not including them here. Diffs - test/integration/component/test_ss_limits.py PRE-CREATION tools/marvin/marvin/config/test_data.py 1a29ed9 tools/marvin/marvin/lib/base.py 9606532 Diff: https://reviews.apache.org/r/20832/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 20832: CLOUDSTACK-1466: Adding first set of test cases for secondary storage limits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20832/ --- (Updated April 29, 2014, 9:53 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Adding first set of test cases for Secondary Storage Limits. The common functions are added by Gaurav in Primary Storage patch so not including them here. Diffs (updated) - test/integration/component/test_ss_domain_limits.py PRE-CREATION test/integration/component/test_ss_limits.py PRE-CREATION tools/marvin/marvin/config/test_data.py 1a29ed9 tools/marvin/marvin/lib/base.py 9606532 Diff: https://reviews.apache.org/r/20832/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 20832: CLOUDSTACK-1466: Adding first set of test cases for secondary storage limits
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20832/ --- (Updated April 29, 2014, 12:53 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Adding first set of test cases for Secondary Storage Limits. The common functions are added by Gaurav in Primary Storage patch so not including them here. Diffs (updated) - test/integration/component/test_ss_domain_limits.py PRE-CREATION test/integration/component/test_ss_limits.py PRE-CREATION test/integration/component/test_ss_max_limits.py PRE-CREATION tools/marvin/marvin/config/test_data.py 1a29ed9 tools/marvin/marvin/lib/base.py 9606532 Diff: https://reviews.apache.org/r/20832/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Review Request 20258: CLOUDSTACK-1466: Automation tests for Primary Storage Limits Feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20258/ --- Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. Bugs: CLOUDSTACK-1466 https://issues.apache.org/jira/browse/CLOUDSTACK-1466 Repository: cloudstack-git Description --- Automation tests for Primary Storage Limits feature. Diffs - test/integration/component/test_ps_limits.py PRE-CREATION test/integration/component/test_ps_project_limits.py PRE-CREATION tools/marvin/marvin/codes.py 92d6cf9 tools/marvin/marvin/config/config.cfg 017c00d tools/marvin/marvin/integration/lib/common.py d38773a Diff: https://reviews.apache.org/r/20258/diff/ Testing --- Yes. Independent test cases have been tested differently so don't have consolidated logs for now. Thanks, Ashutosh Kelkar
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation
On March 19, 2014, 3:32 p.m., Santhosh Edukulla wrote: test/integration/component/test_usage.py, line 680 https://reviews.apache.org/r/19399/diff/1/?file=528014#file528014line680 Also, just a thought. If stop operation itself verifies the state and return, so test case can check some thing like if virtual_machine.stop() == FAIL: raise\fail. I believe we can use getState inside stop operation itself. Basically, stop operation return can be enforced and checked. Here if we don't want to touch existing test cases with stop operation, we will have to raise Exception through stop method if getState return FAIL to Stop method. Is that ok? - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19399/#review37723 --- On March 19, 2014, 3:10 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19399/ --- (Updated March 19, 2014, 3:10 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6257 https://issues.apache.org/jira/browse/CLOUDSTACK-6257 Repository: cloudstack-git Description --- As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure. Diffs - test/integration/component/test_project_usage.py ba0a63c test/integration/component/test_resource_limits.py f0d558e test/integration/component/test_tags.py 2a6e076 test/integration/component/test_templates.py 3e83615 test/integration/component/test_usage.py 5979a0a tools/marvin/marvin/integration/lib/base.py 775b289 Diff: https://reviews.apache.org/r/19399/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19399/ --- (Updated March 20, 2014, 11:56 a.m.) Review request for cloudstack and Santhosh Edukulla. Changes --- Review changes. Bugs: CLOUDSTACK-6257 https://issues.apache.org/jira/browse/CLOUDSTACK-6257 Repository: cloudstack-git Description --- As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure. Diffs (updated) - test/integration/component/test_project_usage.py ba0a63c test/integration/component/test_resource_limits.py f0d558e test/integration/component/test_tags.py 2a6e076 test/integration/component/test_templates.py 3e83615 test/integration/component/test_usage.py 5979a0a tools/marvin/marvin/codes.py e4a0f6a tools/marvin/marvin/integration/lib/base.py 775b289 Diff: https://reviews.apache.org/r/19399/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation
On March 19, 2014, 3:32 p.m., Santhosh Edukulla wrote: test/integration/component/test_usage.py, line 680 https://reviews.apache.org/r/19399/diff/1/?file=528014#file528014line680 Also, just a thought. If stop operation itself verifies the state and return, so test case can check some thing like if virtual_machine.stop() == FAIL: raise\fail. I believe we can use getState inside stop operation itself. Basically, stop operation return can be enforced and checked. Ashutosh Kelkar wrote: Here if we don't want to touch existing test cases with stop operation, we will have to raise Exception through stop method if getState return FAIL to Stop method. Is that ok? Santhosh Edukulla wrote: That should be fine. Ok I will update the patch with that change. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19399/#review37723 --- On March 20, 2014, 11:56 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19399/ --- (Updated March 20, 2014, 11:56 a.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6257 https://issues.apache.org/jira/browse/CLOUDSTACK-6257 Repository: cloudstack-git Description --- As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure. Diffs - test/integration/component/test_project_usage.py ba0a63c test/integration/component/test_resource_limits.py f0d558e test/integration/component/test_tags.py 2a6e076 test/integration/component/test_templates.py 3e83615 test/integration/component/test_usage.py 5979a0a tools/marvin/marvin/codes.py e4a0f6a tools/marvin/marvin/integration/lib/base.py 775b289 Diff: https://reviews.apache.org/r/19399/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature
On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 258 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line258 Move this to a utility function i believe. Also, do we have a class in base.py for Router to verify state. If not update or use that. We are just listing the routers here and matching the state. There is no API for matching router state as such. I have moved this function to utility. On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 296 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line296 The validation comment at step2 mentions about to verify that the guest vm ip is not changed. I believe we are just listing the vms, should that satisfy to verify ip as well, i mean is listing vms is equal to verify that ip is not changed? IPs have been matched in step below it to verify it is not changed. On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 318 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line318 Step1 is not validated it seems? It is verified in the function called on line 246 On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 328 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line328 is 10.1.1.9 outside of 10.1.1.0/29? 10.1.1.0/29 translates to 10.1.1.0 to 10.1.1.7 On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 1021 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line1021 Change this to one single assert? The utility function you have suggested checks if the element is present in list. But here we have to check particular attributes of object, I think it won't be possible to combine two alerts with using utility function. On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 265 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line265 We have a utility function under utils.py verifyElementInList, this can help remove two asserts in to one i believe, please check. The utility function you have suggested checks if the element is present in list. But here we have to check particular attributes of object, I think it won't be possible to combine two alerts with using utility function. On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 483 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line483 Will it be possible to check the update state of router rather sleep? It will help other test cases as well. I have used router.check.interval instead of sleeping for any random time, and we are using verifyRouterState function to check the router state is changed or not. This is a validation part of test case. On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 1271 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line1271 This function seems to be used in many classes, so if possible move it as a util\library function for better usage. This is used only in this class and very specific to the test cases in this suite. On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 1277 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line1277 Will this be cleaned automatically? It will be cleaned up as part of account cleanup. On March 18, 2014, 6:57 a.m., Santhosh Edukulla wrote: test/integration/component/test_ip_reservation.py, line 1317 https://reviews.apache.org/r/19039/diff/3/?file=519653#file519653line1317 Is this ok to hardcode these values? instead put it in one place, this way, the values can be altered at one place and effect takes place at all rather changing all test cases in future. Removed hard-coded value, now subnet is taken randomly. - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/#review37538 --- On March 14, 2014, 4:44 p.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/ --- (Updated March 14, 2014, 4:44 p.m.) Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-2266 https://issues.apache.org/jira
Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/ --- (Updated March 20, 2014, 5:31 p.m.) Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. Changes --- Review changes. Bugs: CLOUDSTACK-2266 https://issues.apache.org/jira/browse/CLOUDSTACK-2266 Repository: cloudstack-git Description --- Adding first set of automation tests for IP reservation feature. Diffs (updated) - test/integration/component/test_ip_reservation.py 224212f tools/marvin/marvin/codes.py e4a0f6a tools/marvin/marvin/config/config.cfg 356a291 tools/marvin/marvin/integration/lib/common.py 3b292bf tools/marvin/marvin/integration/lib/utils.py 709fdde Diff: https://reviews.apache.org/r/19039/diff/ Testing --- Yes. Log below. test_RVR_network (test_ip_reservation.TestIpReservation) ... SKIP: Skip - WIP test_ip_reservation_in_multiple_networks_same_account (test_ip_reservation.TestIpReservation) ... ok test_nat_rules_nat rule (test_ip_reservation.TestIpReservation) ... ok test_nat_rules_static nat rule (test_ip_reservation.TestIpReservation) ... ok test_update_cidr_multiple_vms_not_all_inclusive (test_ip_reservation.TestIpReservation) ... ok test_update_cidr_single_vm_not_inclusive (test_ip_reservation.TestIpReservation) ... ok test_user_defined_cidr (test_ip_reservation.TestIpReservation) ... ok test_vm_create_after_reservation_LB-NS (test_ip_reservation.TestIpReservation) ... SKIP: Skipping - this test required netscaler configured in the network test_vm_create_after_reservation_LB-VR (test_ip_reservation.TestIpReservation) ... ok test_vm_create_outside_cidr_after_reservation_LB-NS (test_ip_reservation.TestIpReservation) ... SKIP: Skipping - this test required netscaler configured in the network test_vm_create_outside_cidr_after_reservation_LB-VR (test_ip_reservation.TestIpReservation) ... ok -- Ran 11 tests in 3753.613s OK Two tests which require Netscaler configured are skipped due to netscaler was not available on setup. Thanks, Ashutosh Kelkar
Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation from user VM volume, added method to check the state of VM before template creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19399/ --- Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-6257 https://issues.apache.org/jira/browse/CLOUDSTACK-6257 Repository: cloudstack-git Description --- As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure. Diffs - test/integration/component/test_project_usage.py ba0a63c test/integration/component/test_resource_limits.py f0d558e test/integration/component/test_tags.py 2a6e076 test/integration/component/test_templates.py 3e83615 test/integration/component/test_usage.py 5979a0a tools/marvin/marvin/integration/lib/base.py 775b289 Diff: https://reviews.apache.org/r/19399/diff/ Testing --- Yes. Thanks, Ashutosh Kelkar
Re: Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/ --- (Updated March 14, 2014, 4:44 p.m.) Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. Changes --- Updated patch with next set of test cases. Bugs: CLOUDSTACK-2266 https://issues.apache.org/jira/browse/CLOUDSTACK-2266 Repository: cloudstack-git Description --- Adding first set of automation tests for IP reservation feature. Diffs (updated) - test/integration/component/test_ip_reservation.py 224212f tools/marvin/marvin/config/config.cfg 356a291 Diff: https://reviews.apache.org/r/19039/diff/ Testing --- Yes. Log below. test_RVR_network (test_ip_reservation.TestIpReservation) ... SKIP: Skip - WIP test_ip_reservation_in_multiple_networks_same_account (test_ip_reservation.TestIpReservation) ... ok test_nat_rules_nat rule (test_ip_reservation.TestIpReservation) ... ok test_nat_rules_static nat rule (test_ip_reservation.TestIpReservation) ... ok test_update_cidr_multiple_vms_not_all_inclusive (test_ip_reservation.TestIpReservation) ... ok test_update_cidr_single_vm_not_inclusive (test_ip_reservation.TestIpReservation) ... ok test_user_defined_cidr (test_ip_reservation.TestIpReservation) ... ok test_vm_create_after_reservation_LB-NS (test_ip_reservation.TestIpReservation) ... SKIP: Skipping - this test required netscaler configured in the network test_vm_create_after_reservation_LB-VR (test_ip_reservation.TestIpReservation) ... ok test_vm_create_outside_cidr_after_reservation_LB-NS (test_ip_reservation.TestIpReservation) ... SKIP: Skipping - this test required netscaler configured in the network test_vm_create_outside_cidr_after_reservation_LB-VR (test_ip_reservation.TestIpReservation) ... ok -- Ran 11 tests in 3753.613s OK Two tests which require Netscaler configured are skipped due to netscaler was not available on setup. Thanks, Ashutosh Kelkar
Re: Review Request 18956: CLOUDSTACK-6147: Adding next set of tests for Dynamic Compute Offering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18956/ --- (Updated March 13, 2014, 3:35 p.m.) Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. Changes --- Final patch for Dynamic Compute Offering test cases. Bugs: CLOUDSTACK-6147 https://issues.apache.org/jira/browse/CLOUDSTACK-6147 Repository: cloudstack-git Description --- These are next set of test cases for dynamic compute offering feature. Diffs (updated) - test/integration/component/test_dynamic_compute_offering.py 75cf0d6 tools/marvin/marvin/config/config.cfg 356a291 Diff: https://reviews.apache.org/r/18956/diff/ Testing --- Test log below. Test scale running VM from dynamic offering to dynamic offering ... ok Test scale running VM from dynamic offering to dynamic offering ... ok Test scale running VM from dynamic offering to static offering ... ok Test scale running VM from dynamic offering to static offering ... ok Test scale running VM from static offering to dynamic offering ... ok Test scale running VM from static offering to dynamic offering ... ok Test scale running VM from static offering to static offering ... ok Test scale running VM from static offering to static offering ... ok Test scale stopped VM from dynamic offering to dynamic offering ... ok Test scale stopped VM from dynamic offering to dynamic offering ... ok Test scale stopped VM from dynamic offering to static offering ... ok Test scale stopped VM from dynamic offering to static offering ... ok Test scale stopped VM from static offering to dynamic offering ... ok Test scale stopped VM from static offering to dynamic offering ... ok Test scale stopped VM from static offering to static offering ... ok Test scale stopped VM from static offering to static offering ... ok -- Ran 16 tests in 1150.677s OK Thanks, Ashutosh Kelkar
Review Request 19039: CLOUDSTACK-2266: Adding automation tests for IP reservation feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19039/ --- Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-2266 https://issues.apache.org/jira/browse/CLOUDSTACK-2266 Repository: cloudstack-git Description --- Adding first set of automation tests for IP reservation feature. Diffs - test/integration/component/test_ip_reservation.py 224212f tools/marvin/marvin/config/config.cfg 356a291 Diff: https://reviews.apache.org/r/19039/diff/ Testing --- Yes. Log below. test_RVR_network (test_ip_reservation.TestIpReservation) ... SKIP: Skip - WIP test_ip_reservation_in_multiple_networks_same_account (test_ip_reservation.TestIpReservation) ... ok test_nat_rules_nat rule (test_ip_reservation.TestIpReservation) ... ok test_nat_rules_static nat rule (test_ip_reservation.TestIpReservation) ... ok test_update_cidr_multiple_vms_not_all_inclusive (test_ip_reservation.TestIpReservation) ... ok test_update_cidr_single_vm_not_inclusive (test_ip_reservation.TestIpReservation) ... ok test_user_defined_cidr (test_ip_reservation.TestIpReservation) ... ok test_vm_create_after_reservation_LB-NS (test_ip_reservation.TestIpReservation) ... SKIP: Skipping - this test required netscaler configured in the network test_vm_create_after_reservation_LB-VR (test_ip_reservation.TestIpReservation) ... ok test_vm_create_outside_cidr_after_reservation_LB-NS (test_ip_reservation.TestIpReservation) ... SKIP: Skipping - this test required netscaler configured in the network test_vm_create_outside_cidr_after_reservation_LB-VR (test_ip_reservation.TestIpReservation) ... ok -- Ran 11 tests in 3753.613s OK Two tests which require Netscaler configured are skipped due to netscaler was not available on setup. Thanks, Ashutosh Kelkar
Re: Review Request 18956: CLOUDSTACK-6147: Adding next set of tests for Dynamic Compute Offering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18956/ --- (Updated March 11, 2014, 11:09 a.m.) Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. Changes --- Updated patch with next set of test cases. Bugs: CLOUDSTACK-6147 https://issues.apache.org/jira/browse/CLOUDSTACK-6147 Repository: cloudstack-git Description --- These are next set of test cases for dynamic compute offering feature. Diffs (updated) - test/integration/component/test_dynamic_compute_offering.py 75cf0d6 Diff: https://reviews.apache.org/r/18956/diff/ Testing --- Test log below. Test scale running VM from dynamic offering to dynamic offering ... ok Test scale running VM from dynamic offering to dynamic offering ... ok Test scale running VM from dynamic offering to static offering ... ok Test scale running VM from dynamic offering to static offering ... ok Test scale running VM from static offering to dynamic offering ... ok Test scale running VM from static offering to dynamic offering ... ok Test scale running VM from static offering to static offering ... ok Test scale running VM from static offering to static offering ... ok Test scale stopped VM from dynamic offering to dynamic offering ... ok Test scale stopped VM from dynamic offering to dynamic offering ... ok Test scale stopped VM from dynamic offering to static offering ... ok Test scale stopped VM from dynamic offering to static offering ... ok Test scale stopped VM from static offering to dynamic offering ... ok Test scale stopped VM from static offering to dynamic offering ... ok Test scale stopped VM from static offering to static offering ... ok Test scale stopped VM from static offering to static offering ... ok -- Ran 16 tests in 1150.677s OK Thanks, Ashutosh Kelkar
Review Request 18956: CLOUDSTACK-6147: Adding next set of tests for Dynamic Compute Offering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18956/ --- Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-6147 https://issues.apache.org/jira/browse/CLOUDSTACK-6147 Repository: cloudstack-git Description --- These are next set of test cases for dynamic compute offering feature. Diffs - test/integration/component/test_dynamic_compute_offering.py 75cf0d6 Diff: https://reviews.apache.org/r/18956/diff/ Testing --- Test log below. Test scale running VM from dynamic offering to dynamic offering ... ok Test scale running VM from dynamic offering to dynamic offering ... ok Test scale running VM from dynamic offering to static offering ... ok Test scale running VM from dynamic offering to static offering ... ok Test scale running VM from static offering to dynamic offering ... ok Test scale running VM from static offering to dynamic offering ... ok Test scale running VM from static offering to static offering ... ok Test scale running VM from static offering to static offering ... ok Test scale stopped VM from dynamic offering to dynamic offering ... ok Test scale stopped VM from dynamic offering to dynamic offering ... ok Test scale stopped VM from dynamic offering to static offering ... ok Test scale stopped VM from dynamic offering to static offering ... ok Test scale stopped VM from static offering to dynamic offering ... ok Test scale stopped VM from static offering to dynamic offering ... ok Test scale stopped VM from static offering to static offering ... ok Test scale stopped VM from static offering to static offering ... ok -- Ran 16 tests in 1150.677s OK Thanks, Ashutosh Kelkar
