subject:"\[DISCUSS\] Freezing master for 4.11"

Re: [DISCUSS] Freezing master for 4.11

2018-01-19 Thread Rohit Yadav

Hi Kristian,

I looked at https://issues.apache.org/jira/browse/CLOUDSTACK-10141

If the new VM is deployed with a password and/or ssh-key enabled VM template, 
then VR should get new password and the user/account specific ssh-public key so 
the mentioned issues don't affect such new VMs. However, I agree VMs may have 
access to old VM's password (if not consumed) and ssh-public key if are not 
password/ssh-public-key enabled - but they may be useless/stale information and 
I feel they are more of a GC issue than a security issue.

Are you able to reproduce a case when a new VM deployed using old VM's IP and 
with a password and/or public-key enabled template is getting the password 
and/or ssh-public-key from old VM (and the old user/account)? I think if yes, 
then it's a security issue.

Thoughts, comments?

- Rohit

<https://cloudstack.apache.org>

From: Kristian Liivak <k...@wavecom.ee>
Sent: Monday, January 15, 2018 4:19:03 PM
To: users
Cc: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Freezing master for 4.11

Hello,

I have created issue in jira 2 month ago.
https://issues.apache.org/jira/browse/CLOUDSTACK-10141

In version 4.10 VR password and ssh key distribution don´t work on instance 
creation.
When instance is allreay excisting reset function is operational.

Also there is major security hole. When instance is destroyd and expunged and 
new instance is created with old IP all old data is unaffected in VR
New instance will get then old root password and  ssh key if they were present 
in VR

In my knowledege cloudstack older versions are not affected.

Lugupidamisega / Regards

Kristian Liivak

CTO

WaveCom As
Endla 16, 10142 Tallinn
Estonia
Tel: +3726850001
Gsm: +37256850001
E-mail: k...@wavecom.ee
Skype: kristian.liivak
http://www.wavecom.ee
http://www.facebook.com/wavecom.ee

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

- Original Message -
From: "Rohit Yadav" <rohit.ya...@shapeblue.com>
To: dev@cloudstack.apache.org, "users" <us...@cloudstack.apache.org>
Sent: Sunday, January 14, 2018 8:41:15 PM
Subject: Re: [DISCUSS] Freezing master for 4.11

All,

To give you update, all feature PRs have been reviewed, tested and merged 
towards the 4.11.0.0. I'll engage with Mike and others for any post-merge 
regressions (smoketest to be kicked shortly).

I see an outstanding PR that may be a critical/blocker PR, please advise and 
also review:

https://github.com/apache/cloudstack/pull/2402

If anyone has any blocker to report, please do so. Thanks.

I'll cut RC1 as planned by EOD today (Mon/15 Jan 2018).

- Rohit

<https://cloudstack.apache.org>

From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Saturday, January 13, 2018 3:23:40 AM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Freezing master for 4.11

I’m investigating these now. I have found and fixed two of them so far.

rohit.ya...@shapeblue.com
www.shapeblue.com<http://www.shapeblue.com>
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

> On Jan 12, 2018, at 2:49 PM, Rohit Yadav <rohit.ya...@shapeblue.com> wrote:
>
> Thanks Rafael and Daan.
>
>
>> From: Rafael Weingärtner <rafaelweingart...@gmail.com>
>>
>> I believe there is no problem in merging Wido’s and Mike’s PRs, they have
>> been extensively discussed and improved (specially Mike’s one).
>
> Thanks, Mike's PR has several regression smoketest failures and can be 
> accepted only when those failures are fixed.
>
> We'll cut 4.11 branch start rc1 on Monday that would be a hard freeze. If 
> Mike wants, he can help fix them over the weekend, I can help run smoketests.
>
>> Having said that; I would be ok with it (no need to revert it), but we need
>> to be more careful with these things. If one wants to merge something,
>> there is no harm in waiting and calling for reviewers via Github, Slack, or
>> even email them directly.
>
> Additional review was requested, but mea culpa - thanks for your support, 
> noted.
>
> - Rohit
>
> On Fri, Jan 12, 2018 at 3:57 PM, Rohit Yadav <rohit.ya...@shapeblue.com>
> wrote:
>
>> All,
>>
>>
>> We're down to one feature PR towards 4.11 milestone now:
>>
>> https://github.com/apache/cloudstack/pull/2298
>>
>>
>> The config drive PR from Frank (Nuage) has been accepted today after no
>> regression test failures seen from yesterday's smoketest run. We've also
>> tested, reviewed and merge Wido's (blocker fix) PR.
>>
>>
>> I've asked Mike to stabilize the branch; based on the smoketest results
>> from today we can see some failures caused by the PR. I'm willing to work
>> with Mike and other

Re: [DISCUSS] Freezing master for 4.11

2018-01-16 Thread Rohit Yadav

Hi Kristian,

Can you test and confirm that you can reproduce the issue with 4.11.0.0-rc1?

- Rohit

<https://cloudstack.apache.org>

From: Kristian Liivak <k...@wavecom.ee>
Sent: Tuesday, January 16, 2018 4:10:17 PM
To: users
Cc: dev
Subject: Re: [DISCUSS] Freezing master for 4.11

Daan,

For us and i guess for many others public cloud and vps providers its very big 
hole.
Imagine that 10-20 chinese guys have made fraud orders and 10-20 vps are 
provisioned.
We dealing with fradulent orders daily basis.
Some time later abusers will get catch in the act and vpses will be terminated.
If your customer increase is considerable, most probably one or more ips will 
be given to new customers during same day.
Newly created instances get then abusers keys and root passwords.
If new instance uses only keys, root password will be never changed.
Abusers need just log in with them old passwords and bitcoin mining or spamming 
will be started again.
Some of smarter customers are able to connect dots and serviceprovider 
reputation will be damaged seriously.

Lugupidamisega / Regards

Kristian Liivak

Tegevjuht / Executive director

WaveCom As
Endla 16, 10142 Tallinn
Estonia
Tel: +3726850001
Gsm: +37256850001
E-mail: k...@wavecom.ee
Skype: kristian.liivak
http://www.wavecom.ee
http://www.facebook.com/wavecom.ee

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

- Original Message -
From: "Daan Hoogland" <daan.hoogl...@gmail.com>
To: "users" <us...@cloudstack.apache.org>
Cc: "dev" <dev@cloudstack.apache.org>
Sent: Monday, January 15, 2018 1:49:04 PM
Subject: Re: [DISCUSS] Freezing master for 4.11

Kristian,

On Mon, Jan 15, 2018 at 11:49 AM, Kristian Liivak <k...@wavecom.ee> wrote:
>>
> ...

As for this one:

> Also there is major security hole. When instance is destroyd and expunged
>> > and new instance is created with old IP all old data is unaffected in VR
>> > New instance will get then old root password and  ssh key if they were
>> > present in VR
>>
> I don't see how this is a security issue. The user won't get in and
update the key and password to get in. No harm done or am I overlooking
something?

--
Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-16 Thread Daan Hoogland

please discuss on the VOTE thread Kristian. Give your -1 with explanation
there.

On Tue, Jan 16, 2018 at 11:40 AM, Kristian Liivak <k...@wavecom.ee> wrote:

> Daan,
>
> For us and i guess for many others public cloud and vps providers its very
> big hole.
> Imagine that 10-20 chinese guys have made fraud orders and 10-20 vps are
> provisioned.
> We dealing with fradulent orders daily basis.
> Some time later abusers will get catch in the act and vpses will be
> terminated.
> If your customer increase is considerable, most probably one or more ips
> will be given to new customers during same day.
> Newly created instances get then abusers keys and root passwords.
> If new instance uses only keys, root password will be never changed.
> Abusers need just log in with them old passwords and bitcoin mining or
> spamming will be started again.
> Some of smarter customers are able to connect dots and serviceprovider
> reputation will be damaged seriously.
>
>
> Lugupidamisega / Regards
>
> Kristian Liivak
>
> Tegevjuht / Executive director
>
> WaveCom As
> Endla 16, 10142 Tallinn
> Estonia
> Tel: +3726850001
> Gsm: +37256850001
> E-mail: k...@wavecom.ee
> Skype: kristian.liivak
> http://www.wavecom.ee
> http://www.facebook.com/wavecom.ee
>
> - Original Message -
> From: "Daan Hoogland" <daan.hoogl...@gmail.com>
> To: "users" <us...@cloudstack.apache.org>
> Cc: "dev" <dev@cloudstack.apache.org>
> Sent: Monday, January 15, 2018 1:49:04 PM
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> Kristian,
>
>
>
> On Mon, Jan 15, 2018 at 11:49 AM, Kristian Liivak <k...@wavecom.ee> wrote:
> >>
> > ...
>
>
>
> As for this one:
>
> > Also there is major security hole. When instance is destroyd and expunged
> >> > and new instance is created with old IP all old data is unaffected in
> VR
> >> > New instance will get then old root password and  ssh key if they were
> >> > present in VR
> >>
> > I don't see how this is a security issue. The user won't get in and
> update the key and password to get in. No harm done or am I overlooking
> something?
>
>
> --
> Daan
>



-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-15 Thread Daan Hoogland

I suggest you discuss it on the vote thread for RC1 Kristian.

On Mon, Jan 15, 2018 at 12:47 PM, Kristian Liivak  wrote:

>
> This fix is only for smaller part of password management..
> Is´t possible that someone have look VR password distribution with
> instance creation ?


-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-15 Thread Daan Hoogland

Kristian,



On Mon, Jan 15, 2018 at 11:49 AM, Kristian Liivak  wrote:
>>
> ...



As for this one:

> Also there is major security hole. When instance is destroyd and expunged
>> > and new instance is created with old IP all old data is unaffected in VR
>> > New instance will get then old root password and  ssh key if they were
>> > present in VR
>>
> I don't see how this is a security issue. The user won't get in and
update the key and password to get in. No harm done or am I overlooking
something?


-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-15 Thread Daan Hoogland

Yes, I know. I made that that's why i asked. This fix isn't in 4.10 but is
in 4.11.

On Mon, Jan 15, 2018 at 12:37 PM, Kristian Liivak <k...@wavecom.ee> wrote:

>
> We made lot testing but did´nt had time to dig code this time.
> There was similar VR password management related and fixed issue
> https://issues.apache.org/jira/browse/CLOUDSTACK-10113
>
>
>
> Lugupidamisega / Regards
>
> Kristian Liivak
>
> CTO
> WaveCom As
> Endla 16, 10142 Tallinn
> Estonia
> Tel: +3726850001
> Gsm: +37256850001
> E-mail: k...@wavecom.ee
> Skype: kristian.liivak
> http://www.wavecom.ee
> http://www.facebook.com/wavecom.ee
>
> - Original Message -
> From: "Daan Hoogland" <daan.hoogl...@gmail.com>
> To: "users" <us...@cloudstack.apache.org>
> Cc: "dev" <dev@cloudstack.apache.org>
> Sent: Monday, January 15, 2018 1:22:23 PM
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> kristian,
>
> these sound like serious regressions. Do you have a fix or did you analyse
> the code yet?
>
> On Mon, Jan 15, 2018 at 11:49 AM, Kristian Liivak <k...@wavecom.ee> wrote:
>
> > Hello,
> >
> > I have created issue in jira 2 month ago.
> > https://issues.apache.org/jira/browse/CLOUDSTACK-10141
> >
> > In version 4.10 VR password and ssh key distribution don´t work on
> > instance creation.
> > When instance is allreay excisting reset function is operational.
> >
> > Also there is major security hole. When instance is destroyd and expunged
> > and new instance is created with old IP all old data is unaffected in VR
> > New instance will get then old root password and  ssh key if they were
> > present in VR
> >
> > In my knowledege cloudstack older versions are not affected.
> >
> > Lugupidamisega / Regards
> >
> > Kristian Liivak
> >
> > CTO
> >
> > WaveCom As
> > Endla 16, 10142 Tallinn
> > Estonia
> > Tel: +3726850001
> > Gsm: +37256850001
> > E-mail: k...@wavecom.ee
> > Skype: kristian.liivak
> > http://www.wavecom.ee
> > http://www.facebook.com/wavecom.ee
> >
> > - Original Message -
> > From: "Rohit Yadav" <rohit.ya...@shapeblue.com>
> > To: dev@cloudstack.apache.org, "users" <us...@cloudstack.apache.org>
> > Sent: Sunday, January 14, 2018 8:41:15 PM
> > Subject: Re: [DISCUSS] Freezing master for 4.11
> >
> > All,
> >
> >
> > To give you update, all feature PRs have been reviewed, tested and merged
> > towards the 4.11.0.0. I'll engage with Mike and others for any post-merge
> > regressions (smoketest to be kicked shortly).
> >
> >
> > I see an outstanding PR that may be a critical/blocker PR, please advise
> > and also review:
> >
> > https://github.com/apache/cloudstack/pull/2402
> >
> >
> > If anyone has any blocker to report, please do so. Thanks.
> >
> >
> > I'll cut RC1 as planned by EOD today (Mon/15 Jan 2018).
> >
> >
> > - Rohit
> >
> > <https://cloudstack.apache.org>
> >
> >
> >
> > 
> > From: Tutkowski, Mike <mike.tutkow...@netapp.com>
> > Sent: Saturday, January 13, 2018 3:23:40 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [DISCUSS] Freezing master for 4.11
> >
> > I’m investigating these now. I have found and fixed two of them so far.
> >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> > > On Jan 12, 2018, at 2:49 PM, Rohit Yadav <rohit.ya...@shapeblue.com>
> > wrote:
> > >
> > > Thanks Rafael and Daan.
> > >
> > >
> > >> From: Rafael Weingärtner <rafaelweingart...@gmail.com>
> > >>
> > >> I believe there is no problem in merging Wido’s and Mike’s PRs, they
> > have
> > >> been extensively discussed and improved (specially Mike’s one).
> > >
> > > Thanks, Mike's PR has several regression smoketest failures and can be
> > accepted only when those failures are fixed.
> > >
> > > We'll cut 4.11 branch start rc1 on Monday that would be a hard freeze.
> > If Mike wants, he can help fix them over the weekend, I can help run
> > smoketests.
> > >
> > >> Having said that; I would be ok with it (no need to revert it), but we
> > need
> > >> to be more careful with these things. If one wants to merge

Re: [DISCUSS] Freezing master for 4.11

2018-01-15 Thread Daan Hoogland

kristian,

these sound like serious regressions. Do you have a fix or did you analyse
the code yet?

On Mon, Jan 15, 2018 at 11:49 AM, Kristian Liivak <k...@wavecom.ee> wrote:

> Hello,
>
> I have created issue in jira 2 month ago.
> https://issues.apache.org/jira/browse/CLOUDSTACK-10141
>
> In version 4.10 VR password and ssh key distribution don´t work on
> instance creation.
> When instance is allreay excisting reset function is operational.
>
> Also there is major security hole. When instance is destroyd and expunged
> and new instance is created with old IP all old data is unaffected in VR
> New instance will get then old root password and  ssh key if they were
> present in VR
>
> In my knowledege cloudstack older versions are not affected.
>
> Lugupidamisega / Regards
>
> Kristian Liivak
>
> CTO
>
> WaveCom As
> Endla 16, 10142 Tallinn
> Estonia
> Tel: +3726850001
> Gsm: +37256850001
> E-mail: k...@wavecom.ee
> Skype: kristian.liivak
> http://www.wavecom.ee
> http://www.facebook.com/wavecom.ee
>
> - Original Message -
> From: "Rohit Yadav" <rohit.ya...@shapeblue.com>
> To: dev@cloudstack.apache.org, "users" <us...@cloudstack.apache.org>
> Sent: Sunday, January 14, 2018 8:41:15 PM
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> All,
>
>
> To give you update, all feature PRs have been reviewed, tested and merged
> towards the 4.11.0.0. I'll engage with Mike and others for any post-merge
> regressions (smoketest to be kicked shortly).
>
>
> I see an outstanding PR that may be a critical/blocker PR, please advise
> and also review:
>
> https://github.com/apache/cloudstack/pull/2402
>
>
> If anyone has any blocker to report, please do so. Thanks.
>
>
> I'll cut RC1 as planned by EOD today (Mon/15 Jan 2018).
>
>
> - Rohit
>
> <https://cloudstack.apache.org>
>
>
>
> 
> From: Tutkowski, Mike <mike.tutkow...@netapp.com>
> Sent: Saturday, January 13, 2018 3:23:40 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> I’m investigating these now. I have found and fixed two of them so far.
>
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> > On Jan 12, 2018, at 2:49 PM, Rohit Yadav <rohit.ya...@shapeblue.com>
> wrote:
> >
> > Thanks Rafael and Daan.
> >
> >
> >> From: Rafael Weingärtner <rafaelweingart...@gmail.com>
> >>
> >> I believe there is no problem in merging Wido’s and Mike’s PRs, they
> have
> >> been extensively discussed and improved (specially Mike’s one).
> >
> > Thanks, Mike's PR has several regression smoketest failures and can be
> accepted only when those failures are fixed.
> >
> > We'll cut 4.11 branch start rc1 on Monday that would be a hard freeze.
> If Mike wants, he can help fix them over the weekend, I can help run
> smoketests.
> >
> >> Having said that; I would be ok with it (no need to revert it), but we
> need
> >> to be more careful with these things. If one wants to merge something,
> >> there is no harm in waiting and calling for reviewers via Github,
> Slack, or
> >> even email them directly.
> >
> > Additional review was requested, but mea culpa - thanks for your
> support, noted.
> >
> > - Rohit
> >
> > On Fri, Jan 12, 2018 at 3:57 PM, Rohit Yadav <rohit.ya...@shapeblue.com>
> > wrote:
> >
> >> All,
> >>
> >>
> >> We're down to one feature PR towards 4.11 milestone now:
> >>
> >> https://github.com/apache/cloudstack/pull/2298
> >>
> >>
> >> The config drive PR from Frank (Nuage) has been accepted today after no
> >> regression test failures seen from yesterday's smoketest run. We've also
> >> tested, reviewed and merge Wido's (blocker fix) PR.
> >>
> >>
> >> I've asked Mike to stabilize the branch; based on the smoketest results
> >> from today we can see some failures caused by the PR. I'm willing to
> work
> >> with Mike and others to get this PR tested, and merged over the
> weekends if
> >> we can demonstrate that no regression is caused by it, i.e. no new
> >> smoketest regressions. I'll also try to fix regression and test failures
> >> over the weekend.
> >>
> >>
> >> Lastly, I would like to discuss a mistake I made today with merging the
> >> following PR which per our guideline lacks one code review
>

Re: [DISCUSS] Freezing master for 4.11

2018-01-14 Thread Rohit Yadav

All,


To give you update, all feature PRs have been reviewed, tested and merged 
towards the 4.11.0.0. I'll engage with Mike and others for any post-merge 
regressions (smoketest to be kicked shortly).


I see an outstanding PR that may be a critical/blocker PR, please advise and 
also review:

https://github.com/apache/cloudstack/pull/2402


If anyone has any blocker to report, please do so. Thanks.


I'll cut RC1 as planned by EOD today (Mon/15 Jan 2018).


- Rohit

<https://cloudstack.apache.org>




From: Tutkowski, Mike <mike.tutkow...@netapp.com>
Sent: Saturday, January 13, 2018 3:23:40 AM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Freezing master for 4.11

I’m investigating these now. I have found and fixed two of them so far.


rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

> On Jan 12, 2018, at 2:49 PM, Rohit Yadav <rohit.ya...@shapeblue.com> wrote:
>
> Thanks Rafael and Daan.
>
>
>> From: Rafael Weingärtner <rafaelweingart...@gmail.com>
>>
>> I believe there is no problem in merging Wido’s and Mike’s PRs, they have
>> been extensively discussed and improved (specially Mike’s one).
>
> Thanks, Mike's PR has several regression smoketest failures and can be 
> accepted only when those failures are fixed.
>
> We'll cut 4.11 branch start rc1 on Monday that would be a hard freeze. If 
> Mike wants, he can help fix them over the weekend, I can help run smoketests.
>
>> Having said that; I would be ok with it (no need to revert it), but we need
>> to be more careful with these things. If one wants to merge something,
>> there is no harm in waiting and calling for reviewers via Github, Slack, or
>> even email them directly.
>
> Additional review was requested, but mea culpa - thanks for your support, 
> noted.
>
> - Rohit
>
> On Fri, Jan 12, 2018 at 3:57 PM, Rohit Yadav <rohit.ya...@shapeblue.com>
> wrote:
>
>> All,
>>
>>
>> We're down to one feature PR towards 4.11 milestone now:
>>
>> https://github.com/apache/cloudstack/pull/2298
>>
>>
>> The config drive PR from Frank (Nuage) has been accepted today after no
>> regression test failures seen from yesterday's smoketest run. We've also
>> tested, reviewed and merge Wido's (blocker fix) PR.
>>
>>
>> I've asked Mike to stabilize the branch; based on the smoketest results
>> from today we can see some failures caused by the PR. I'm willing to work
>> with Mike and others to get this PR tested, and merged over the weekends if
>> we can demonstrate that no regression is caused by it, i.e. no new
>> smoketest regressions. I'll also try to fix regression and test failures
>> over the weekend.
>>
>>
>> Lastly, I would like to discuss a mistake I made today with merging the
>> following PR which per our guideline lacks one code review lgtm/approval:
>>
>> https://github.com/apache/cloudstack/pull/2152
>>
>>
>> The changes in above (merged) PR are all localized to a xenserver-swift
>> file, that is not tested by Travis or Trillian, since no new regression
>> failures were seen I accepted and merge it on that discretion. The PR was
>> originally on the 4.11 milestone, however, due to it lacking a JIRA id and
>> no response from the author it was only recently removed from the milestone.
>>
>>
>> Please advise if I need to revert this, or we can review/lgtm it
>> post-merge? I'll also ping on the above PR.
>>
>>
>> - Rohit
>>
>> <https://cloudstack.apache.org>
> Apache CloudStack: Open Source Cloud Computing<https://cloudstack.apache.org/>
> cloudstack.apache.org
> CloudStack is open source cloud computing software for creating, managing, 
> and deploying infrastructure cloud services
>
>
>
>>
>>
>>
>> 
>> From: Wido den Hollander <w...@widodh.nl>
>> Sent: Thursday, January 11, 2018 9:17:26 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>
>>
>>
>>> On 01/10/2018 07:26 PM, Daan Hoogland wrote:
>>> I hope we understand each other correctly: No-one running an earlier
>>> version then 4.11 should miss out on any functionality they are using
>> now.
>>>
>>> So if you use ipv6 and multiple cidrs now it must continue to work with
>> no
>>> loss of functionality. see my question below.
>>>
>>> On Wed, Jan 10, 2018 at 7:06 PM, Ivan Kudryavtsev <
>> kudryavtsev...@bw-sw.com>
>>> wrote:
>>>
>&g

Re: [DISCUSS] Freezing master for 4.11

2018-01-12 Thread Tutkowski, Mike

I’m investigating these now. I have found and fixed two of them so far.

> On Jan 12, 2018, at 2:49 PM, Rohit Yadav <rohit.ya...@shapeblue.com> wrote:
> 
> Thanks Rafael and Daan.
> 
> 
>> From: Rafael Weingärtner <rafaelweingart...@gmail.com>
>> 
>> I believe there is no problem in merging Wido’s and Mike’s PRs, they have
>> been extensively discussed and improved (specially Mike’s one).
> 
> Thanks, Mike's PR has several regression smoketest failures and can be 
> accepted only when those failures are fixed.
> 
> We'll cut 4.11 branch start rc1 on Monday that would be a hard freeze. If 
> Mike wants, he can help fix them over the weekend, I can help run smoketests.
> 
>> Having said that; I would be ok with it (no need to revert it), but we need
>> to be more careful with these things. If one wants to merge something,
>> there is no harm in waiting and calling for reviewers via Github, Slack, or
>> even email them directly.
> 
> Additional review was requested, but mea culpa - thanks for your support, 
> noted.
> 
> - Rohit
> 
> On Fri, Jan 12, 2018 at 3:57 PM, Rohit Yadav <rohit.ya...@shapeblue.com>
> wrote:
> 
>> All,
>> 
>> 
>> We're down to one feature PR towards 4.11 milestone now:
>> 
>> https://github.com/apache/cloudstack/pull/2298
>> 
>> 
>> The config drive PR from Frank (Nuage) has been accepted today after no
>> regression test failures seen from yesterday's smoketest run. We've also
>> tested, reviewed and merge Wido's (blocker fix) PR.
>> 
>> 
>> I've asked Mike to stabilize the branch; based on the smoketest results
>> from today we can see some failures caused by the PR. I'm willing to work
>> with Mike and others to get this PR tested, and merged over the weekends if
>> we can demonstrate that no regression is caused by it, i.e. no new
>> smoketest regressions. I'll also try to fix regression and test failures
>> over the weekend.
>> 
>> 
>> Lastly, I would like to discuss a mistake I made today with merging the
>> following PR which per our guideline lacks one code review lgtm/approval:
>> 
>> https://github.com/apache/cloudstack/pull/2152
>> 
>> 
>> The changes in above (merged) PR are all localized to a xenserver-swift
>> file, that is not tested by Travis or Trillian, since no new regression
>> failures were seen I accepted and merge it on that discretion. The PR was
>> originally on the 4.11 milestone, however, due to it lacking a JIRA id and
>> no response from the author it was only recently removed from the milestone.
>> 
>> 
>> Please advise if I need to revert this, or we can review/lgtm it
>> post-merge? I'll also ping on the above PR.
>> 
>> 
>> - Rohit
>> 
>> <https://cloudstack.apache.org>
> Apache CloudStack: Open Source Cloud Computing<https://cloudstack.apache.org/>
> cloudstack.apache.org
> CloudStack is open source cloud computing software for creating, managing, 
> and deploying infrastructure cloud services
> 
> 
> 
>> 
>> 
>> 
>> 
>> From: Wido den Hollander <w...@widodh.nl>
>> Sent: Thursday, January 11, 2018 9:17:26 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>> 
>> 
>> 
>>> On 01/10/2018 07:26 PM, Daan Hoogland wrote:
>>> I hope we understand each other correctly: No-one running an earlier
>>> version then 4.11 should miss out on any functionality they are using
>> now.
>>> 
>>> So if you use ipv6 and multiple cidrs now it must continue to work with
>> no
>>> loss of functionality. see my question below.
>>> 
>>> On Wed, Jan 10, 2018 at 7:06 PM, Ivan Kudryavtsev <
>> kudryavtsev...@bw-sw.com>
>>> wrote:
>>> 
>>>> Daan, yes this sounds reasonable, I suppose who would like to fix, could
>>>> do custom build for himself...
>>>> 
>>>> But still it should be aknowledged somehow, if you use several cidrs for
>>>> network, don't use v6, or don't upgrade to 4.11 because things will stop
>>>> running well.
>>>> 
>>> Does this mean that several cidrs in ipv6 works in 4.9 and not in 4.11?
>>> 
>> 
>> No, it doesn't. IPv6 was introduced in 4.10 and this broke in 4.10.
>> 
>> You can't run with 4.10 with multiple IPv4 CIDRs as well when you have
>> IPv6 enabled.
>> 
>> So this is broken in 4.10 and 4.11 in that case.
>> 
>> Wido
>> 
>>> 
>>

Re: [DISCUSS] Freezing master for 4.11

2018-01-12 Thread Rohit Yadav

Thanks Rafael and Daan.


> From: Rafael Weingärtner <rafaelweingart...@gmail.com>
>
>I believe there is no problem in merging Wido’s and Mike’s PRs, they have
>been extensively discussed and improved (specially Mike’s one).

Thanks, Mike's PR has several regression smoketest failures and can be accepted 
only when those failures are fixed.

We'll cut 4.11 branch start rc1 on Monday that would be a hard freeze. If Mike 
wants, he can help fix them over the weekend, I can help run smoketests.

>Having said that; I would be ok with it (no need to revert it), but we need
>to be more careful with these things. If one wants to merge something,
>there is no harm in waiting and calling for reviewers via Github, Slack, or
>even email them directly.

Additional review was requested, but mea culpa - thanks for your support, noted.

- Rohit

On Fri, Jan 12, 2018 at 3:57 PM, Rohit Yadav <rohit.ya...@shapeblue.com>
wrote:

> All,
>
>
> We're down to one feature PR towards 4.11 milestone now:
>
> https://github.com/apache/cloudstack/pull/2298
>
>
> The config drive PR from Frank (Nuage) has been accepted today after no
> regression test failures seen from yesterday's smoketest run. We've also
> tested, reviewed and merge Wido's (blocker fix) PR.
>
>
> I've asked Mike to stabilize the branch; based on the smoketest results
> from today we can see some failures caused by the PR. I'm willing to work
> with Mike and others to get this PR tested, and merged over the weekends if
> we can demonstrate that no regression is caused by it, i.e. no new
> smoketest regressions. I'll also try to fix regression and test failures
> over the weekend.
>
>
> Lastly, I would like to discuss a mistake I made today with merging the
> following PR which per our guideline lacks one code review lgtm/approval:
>
> https://github.com/apache/cloudstack/pull/2152
>
>
> The changes in above (merged) PR are all localized to a xenserver-swift
> file, that is not tested by Travis or Trillian, since no new regression
> failures were seen I accepted and merge it on that discretion. The PR was
> originally on the 4.11 milestone, however, due to it lacking a JIRA id and
> no response from the author it was only recently removed from the milestone.
>
>
> Please advise if I need to revert this, or we can review/lgtm it
> post-merge? I'll also ping on the above PR.
>
>
> - Rohit
>
> <https://cloudstack.apache.org>
Apache CloudStack: Open Source Cloud Computing<https://cloudstack.apache.org/>
cloudstack.apache.org
CloudStack is open source cloud computing software for creating, managing, and 
deploying infrastructure cloud services



>
>
>
> ________
> From: Wido den Hollander <w...@widodh.nl>
> Sent: Thursday, January 11, 2018 9:17:26 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
>
>
> On 01/10/2018 07:26 PM, Daan Hoogland wrote:
> > I hope we understand each other correctly: No-one running an earlier
> > version then 4.11 should miss out on any functionality they are using
> now.
> >
> > So if you use ipv6 and multiple cidrs now it must continue to work with
> no
> > loss of functionality. see my question below.
> >
> > On Wed, Jan 10, 2018 at 7:06 PM, Ivan Kudryavtsev <
> kudryavtsev...@bw-sw.com>
> > wrote:
> >
> >> Daan, yes this sounds reasonable, I suppose who would like to fix, could
> >> do custom build for himself...
> >>
> >> But still it should be aknowledged somehow, if you use several cidrs for
> >> network, don't use v6, or don't upgrade to 4.11 because things will stop
> >> running well.
> >>
> > Does this mean that several cidrs in ipv6 works in 4.9 and not in 4.11?
> >
>
> No, it doesn't. IPv6 was introduced in 4.10 and this broke in 4.10.
>
> You can't run with 4.10 with multiple IPv4 CIDRs as well when you have
> IPv6 enabled.
>
> So this is broken in 4.10 and 4.11 in that case.
>
> Wido
>
> >
> > if yes; it is a blocker
> >
> > if no; you might as well upgrade for other features as it doesn't work
> now
> > either.
> >
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com<http://www.shapeblue.com>
[http://www.shapeblue.com/wp-content/uploads/2017/06/logo.png]<http://www.shapeblue.com/>

Shapeblue - The CloudStack Company<http://www.shapeblue.com/>
www.shapeblue.com
Rapid deployment framework for Apache CloudStack IaaS Clouds. CSForge is a 
framework developed by ShapeBlue to deliver the rapid deployment of a 
standardised ...



> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


--
Rafael Weingärtner

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

Re: [DISCUSS] Freezing master for 4.11

2018-01-12 Thread Daan Hoogland

i answers something similar to Rafael's answer here, on the PR itself.

On Fri, Jan 12, 2018 at 7:21 PM, Rafael Weingärtner <
rafaelweingart...@gmail.com> wrote:

> I believe there is no problem in merging Wido’s and Mike’s PRs, they have
> been extensively discussed and improved (specially Mike’s one).
>
> I noticed the merge of #2152 today morning, but crying over spilled milk
> does not help anything… The code seems to be ok, maybe those variable names
> `cmd` and `cmd2` could benefit from something more descriptive; also, the
> magic number `1024`.
>
> Having said that; I would be ok with it (no need to revert it), but we need
> to be more careful with these things. If one wants to merge something,
> there is no harm in waiting and calling for reviewers via Github, Slack, or
> even email them directly.
>
> On Fri, Jan 12, 2018 at 3:57 PM, Rohit Yadav <rohit.ya...@shapeblue.com>
> wrote:
>
> > All,
> >
> >
> > We're down to one feature PR towards 4.11 milestone now:
> >
> > https://github.com/apache/cloudstack/pull/2298
> >
> >
> > The config drive PR from Frank (Nuage) has been accepted today after no
> > regression test failures seen from yesterday's smoketest run. We've also
> > tested, reviewed and merge Wido's (blocker fix) PR.
> >
> >
> > I've asked Mike to stabilize the branch; based on the smoketest results
> > from today we can see some failures caused by the PR. I'm willing to work
> > with Mike and others to get this PR tested, and merged over the weekends
> if
> > we can demonstrate that no regression is caused by it, i.e. no new
> > smoketest regressions. I'll also try to fix regression and test failures
> > over the weekend.
> >
> >
> > Lastly, I would like to discuss a mistake I made today with merging the
> > following PR which per our guideline lacks one code review lgtm/approval:
> >
> > https://github.com/apache/cloudstack/pull/2152
> >
> >
> > The changes in above (merged) PR are all localized to a xenserver-swift
> > file, that is not tested by Travis or Trillian, since no new regression
> > failures were seen I accepted and merge it on that discretion. The PR was
> > originally on the 4.11 milestone, however, due to it lacking a JIRA id
> and
> > no response from the author it was only recently removed from the
> milestone.
> >
> >
> > Please advise if I need to revert this, or we can review/lgtm it
> > post-merge? I'll also ping on the above PR.
> >
> >
> > - Rohit
> >
> > <https://cloudstack.apache.org>
> >
> >
> >
> > 
> > From: Wido den Hollander <w...@widodh.nl>
> > Sent: Thursday, January 11, 2018 9:17:26 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [DISCUSS] Freezing master for 4.11
> >
> >
> >
> > On 01/10/2018 07:26 PM, Daan Hoogland wrote:
> > > I hope we understand each other correctly: No-one running an earlier
> > > version then 4.11 should miss out on any functionality they are using
> > now.
> > >
> > > So if you use ipv6 and multiple cidrs now it must continue to work with
> > no
> > > loss of functionality. see my question below.
> > >
> > > On Wed, Jan 10, 2018 at 7:06 PM, Ivan Kudryavtsev <
> > kudryavtsev...@bw-sw.com>
> > > wrote:
> > >
> > >> Daan, yes this sounds reasonable, I suppose who would like to fix,
> could
> > >> do custom build for himself...
> > >>
> > >> But still it should be aknowledged somehow, if you use several cidrs
> for
> > >> network, don't use v6, or don't upgrade to 4.11 because things will
> stop
> > >> running well.
> > >>
> > > Does this mean that several cidrs in ipv6 works in 4.9 and not in
> 4.11?
> > >
> >
> > No, it doesn't. IPv6 was introduced in 4.10 and this broke in 4.10.
> >
> > You can't run with 4.10 with multiple IPv4 CIDRs as well when you have
> > IPv6 enabled.
> >
> > So this is broken in 4.10 and 4.11 in that case.
> >
> > Wido
> >
> > >
> > > if yes; it is a blocker
> > >
> > > if no; you might as well upgrade for other features as it doesn't work
> > now
> > > either.
> > >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>
>
> --
> Rafael Weingärtner
>



-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-12 Thread Rafael Weingärtner

I believe there is no problem in merging Wido’s and Mike’s PRs, they have
been extensively discussed and improved (specially Mike’s one).

I noticed the merge of #2152 today morning, but crying over spilled milk
does not help anything… The code seems to be ok, maybe those variable names
`cmd` and `cmd2` could benefit from something more descriptive; also, the
magic number `1024`.

Having said that; I would be ok with it (no need to revert it), but we need
to be more careful with these things. If one wants to merge something,
there is no harm in waiting and calling for reviewers via Github, Slack, or
even email them directly.

On Fri, Jan 12, 2018 at 3:57 PM, Rohit Yadav <rohit.ya...@shapeblue.com>
wrote:

> All,
>
>
> We're down to one feature PR towards 4.11 milestone now:
>
> https://github.com/apache/cloudstack/pull/2298
>
>
> The config drive PR from Frank (Nuage) has been accepted today after no
> regression test failures seen from yesterday's smoketest run. We've also
> tested, reviewed and merge Wido's (blocker fix) PR.
>
>
> I've asked Mike to stabilize the branch; based on the smoketest results
> from today we can see some failures caused by the PR. I'm willing to work
> with Mike and others to get this PR tested, and merged over the weekends if
> we can demonstrate that no regression is caused by it, i.e. no new
> smoketest regressions. I'll also try to fix regression and test failures
> over the weekend.
>
>
> Lastly, I would like to discuss a mistake I made today with merging the
> following PR which per our guideline lacks one code review lgtm/approval:
>
> https://github.com/apache/cloudstack/pull/2152
>
>
> The changes in above (merged) PR are all localized to a xenserver-swift
> file, that is not tested by Travis or Trillian, since no new regression
> failures were seen I accepted and merge it on that discretion. The PR was
> originally on the 4.11 milestone, however, due to it lacking a JIRA id and
> no response from the author it was only recently removed from the milestone.
>
>
> Please advise if I need to revert this, or we can review/lgtm it
> post-merge? I'll also ping on the above PR.
>
>
> - Rohit
>
> <https://cloudstack.apache.org>
>
>
>
> ____
> From: Wido den Hollander <w...@widodh.nl>
> Sent: Thursday, January 11, 2018 9:17:26 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
>
>
> On 01/10/2018 07:26 PM, Daan Hoogland wrote:
> > I hope we understand each other correctly: No-one running an earlier
> > version then 4.11 should miss out on any functionality they are using
> now.
> >
> > So if you use ipv6 and multiple cidrs now it must continue to work with
> no
> > loss of functionality. see my question below.
> >
> > On Wed, Jan 10, 2018 at 7:06 PM, Ivan Kudryavtsev <
> kudryavtsev...@bw-sw.com>
> > wrote:
> >
> >> Daan, yes this sounds reasonable, I suppose who would like to fix, could
> >> do custom build for himself...
> >>
> >> But still it should be aknowledged somehow, if you use several cidrs for
> >> network, don't use v6, or don't upgrade to 4.11 because things will stop
> >> running well.
> >>
> > Does this mean that several cidrs in ipv6 works in 4.9 and not in 4.11?
> >
>
> No, it doesn't. IPv6 was introduced in 4.10 and this broke in 4.10.
>
> You can't run with 4.10 with multiple IPv4 CIDRs as well when you have
> IPv6 enabled.
>
> So this is broken in 4.10 and 4.11 in that case.
>
> Wido
>
> >
> > if yes; it is a blocker
> >
> > if no; you might as well upgrade for other features as it doesn't work
> now
> > either.
> >
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


-- 
Rafael Weingärtner

Re: [DISCUSS] Freezing master for 4.11

2018-01-12 Thread Rohit Yadav

All,

We're down to one feature PR towards 4.11 milestone now:

https://github.com/apache/cloudstack/pull/2298

The config drive PR from Frank (Nuage) has been accepted today after no 
regression test failures seen from yesterday's smoketest run. We've also 
tested, reviewed and merge Wido's (blocker fix) PR.

I've asked Mike to stabilize the branch; based on the smoketest results from 
today we can see some failures caused by the PR. I'm willing to work with Mike 
and others to get this PR tested, and merged over the weekends if we can 
demonstrate that no regression is caused by it, i.e. no new smoketest 
regressions. I'll also try to fix regression and test failures over the weekend.

Lastly, I would like to discuss a mistake I made today with merging the 
following PR which per our guideline lacks one code review lgtm/approval:

https://github.com/apache/cloudstack/pull/2152

The changes in above (merged) PR are all localized to a xenserver-swift file, 
that is not tested by Travis or Trillian, since no new regression failures were 
seen I accepted and merge it on that discretion. The PR was originally on the 
4.11 milestone, however, due to it lacking a JIRA id and no response from the 
author it was only recently removed from the milestone.

Please advise if I need to revert this, or we can review/lgtm it post-merge? 
I'll also ping on the above PR.

- Rohit

<https://cloudstack.apache.org>

From: Wido den Hollander <w...@widodh.nl>
Sent: Thursday, January 11, 2018 9:17:26 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Freezing master for 4.11

On 01/10/2018 07:26 PM, Daan Hoogland wrote:
> I hope we understand each other correctly: No-one running an earlier
> version then 4.11 should miss out on any functionality they are using now.
>
> So if you use ipv6 and multiple cidrs now it must continue to work with no
> loss of functionality. see my question below.
>
> On Wed, Jan 10, 2018 at 7:06 PM, Ivan Kudryavtsev <kudryavtsev...@bw-sw.com>
> wrote:
>
>> Daan, yes this sounds reasonable, I suppose who would like to fix, could
>> do custom build for himself...
>>
>> But still it should be aknowledged somehow, if you use several cidrs for
>> network, don't use v6, or don't upgrade to 4.11 because things will stop
>> running well.
>>
> Does this mean that several cidrs in ipv6 works in 4.9 and not in 4.11?
>

No, it doesn't. IPv6 was introduced in 4.10 and this broke in 4.10.

You can't run with 4.10 with multiple IPv4 CIDRs as well when you have
IPv6 enabled.

So this is broken in 4.10 and 4.11 in that case.

Wido

>
> if yes; it is a blocker
>
> if no; you might as well upgrade for other features as it doesn't work now
> either.
>

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

Re: [DISCUSS] Freezing master for 4.11

2018-01-11 Thread Wido den Hollander




On 01/10/2018 07:26 PM, Daan Hoogland wrote:

I hope we understand each other correctly: No-one running an earlier
version then 4.11 should miss out on any functionality they are using now.

So if you use ipv6 and multiple cidrs now it must continue to work with no
loss of functionality. see my question below.

On Wed, Jan 10, 2018 at 7:06 PM, Ivan Kudryavtsev 
wrote:


Daan, yes this sounds reasonable, I suppose who would like to fix, could
do custom build for himself...

But still it should be aknowledged somehow, if you use several cidrs for
network, don't use v6, or don't upgrade to 4.11 because things will stop
running well.


Does this mean that several cidrs in ipv6 works in 4.9 and not in 4.11?



No, it doesn't. IPv6 was introduced in 4.10 and this broke in 4.10.

You can't run with 4.10 with multiple IPv4 CIDRs as well when you have 
IPv6 enabled.


So this is broken in 4.10 and 4.11 in that case.

Wido



if yes; it is a blocker

if no; you might as well upgrade for other features as it doesn't work now
either.

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Daan Hoogland

I hope we understand each other correctly: No-one running an earlier
version then 4.11 should miss out on any functionality they are using now.

So if you use ipv6 and multiple cidrs now it must continue to work with no
loss of functionality. see my question below.

On Wed, Jan 10, 2018 at 7:06 PM, Ivan Kudryavtsev 
wrote:

> Daan, yes this sounds reasonable, I suppose who would like to fix, could
> do custom build for himself...
>
> But still it should be aknowledged somehow, if you use several cidrs for
> network, don't use v6, or don't upgrade to 4.11 because things will stop
> running well.
>
Does this mean that several cidrs in ipv6 works in 4.9 and not in 4.11?

if yes; it is a blocker

if no; you might as well upgrade for other features as it doesn't work now
either.

-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Ivan Kudryavtsev

Daan, yes this sounds reasonable, I suppose who would like to fix, could do
custom build for himself...

But still it should be aknowledged somehow, if you use several cidrs for
network, don't use v6, or don't upgrade to 4.11 because things will stop
running well.

11 янв. 2018 г. 1:00 пользователь "Daan Hoogland" <daan.hoogl...@gmail.com>
написал:

Ivan,
I was composing an answer but i think we agree:

Only if that functionality worked in the past. ipv6 support is still rather
new and must be considered experimental. I think we should fix it in a
maintenance release and not block the release for it. If it was working
before and broke, it should go in. To put it less mildly, I expect more
then ACS can deliver and we can't wait until all my wishes are implemented.


On Wed, Jan 10, 2018 at 6:58 PM, Ivan Kudryavtsev <kudryavtsev...@bw-sw.com>
wrote:

> Sorry, to clarify, I mean (if I correctly understand) that if someone has
> a network with several CIDRs in the basic zone and, lets say, 4.9.3
> upgraded to 4.11, which results that VMs stop getting DHCP announces for
> additional CIDRs from VR, it's a blocker thing...
>
> 2018-01-11 0:52 GMT+07:00 Ivan Kudryavtsev <kudryavtsev...@bw-sw.com>:
>
>> I suppose the bug, reported by Wido prevents adding additional CIDRs to
>> Network if IPv6 configured? If so, it's definitely a blocker thing because
>> everyone expects it's possible, because the function is implemented in ACS.
>>
>> 2018-01-11 0:41 GMT+07:00 Rohit Yadav <rohit.ya...@shapeblue.com>:
>>
>>> +1 what Dasn said.
>>>
>>> Wido - are you seeing (upgrade) failure, or something fails to work
>>> without this fix in basic zone?
>>> 
>>> From: Daan Hoogland <daan.hoogl...@gmail.com>
>>> Sent: Wednesday, January 10, 2018 10:50:22 PM
>>> To: dev
>>> Cc: Rohit Yadav
>>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>>
>>> I think that we agreed in th3 past that a blocker is either something
>>> that prevents ACS to start or upgrade, or something that breaks prior
>>> functionality.
>>>
>>>
>>> rohit.ya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N
>>> <https://maps.google.com/?q=53+Chandos+Place,+Covent+Garden,+London%C2%A0+WC2N=gmail=g>
>>> 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>> On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander <w...@widodh.nl
>>> <mailto:w...@widodh.nl>> wrote:
>>>
>>>
>>> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
>>> All,
>>>
>>>
>>> I want to thank all the reviewers, contributors and PR authors for their
>>> hard work, support and collaboration. We managed to review, test and merge
>>> more than 100 PRs towards the 4.11 milestone!
>>>
>>>
>>> Out of 11 open PRs on Monday, the list is down to 2 now which were
>>> recently added features:
>>>
>>> https://github.com/apache/cloudstack/milestone/3
>>>
>>>
>>> To keep up with the release schedule, I think it's time we should focus
>>> on stabilizing master, testing it, fix any regressions and blockers.
>>>
>>>
>>> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
>>> schedule and master will be open for PRs with following merge criteria:
>>>
>>> - Blocker fixes, especially those blocking the release
>>>
>>> - Test failure and regression fixes
>>>
>>> - Release related fixes for example - upgrade blockers, database path,
>>> packaging and systemvmtemplate related etc.
>>>
>>>
>>> Thoughts, objections?
>>>
>>>
>>> Awesome!
>>>
>>> I'm looking for the definition for a blocker, I recently found this one:
>>> https://github.com/apache/cloudstack/pull/2396
>>>
>>> For us this is a big problem as we keep running into it, but probably
>>> nobody else. I don't want to promote my own PR as a blocker, but what is
>>> the definition?
>>>
>>> Because it's my own PR I didn't add the 4.11 milestone.
>>>
>>> Looking forward to 4.11!
>>>
>>>
>>> Wido
>>>
>>>
>>> - Rohit
>>>
>>> <https://cloudstack.apache.org>
>>>
>>>
>>>
>>> 
>>> From: Khosrow Moossavi <kmooss...@cloudops.com>> kmooss...@cloudops.com>>
>>> Sent: Monday, Janu

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Daan Hoogland

Ivan,
I was composing an answer but i think we agree:

Only if that functionality worked in the past. ipv6 support is still rather
new and must be considered experimental. I think we should fix it in a
maintenance release and not block the release for it. If it was working
before and broke, it should go in. To put it less mildly, I expect more
then ACS can deliver and we can't wait until all my wishes are implemented.


On Wed, Jan 10, 2018 at 6:58 PM, Ivan Kudryavtsev <kudryavtsev...@bw-sw.com>
wrote:

> Sorry, to clarify, I mean (if I correctly understand) that if someone has
> a network with several CIDRs in the basic zone and, lets say, 4.9.3
> upgraded to 4.11, which results that VMs stop getting DHCP announces for
> additional CIDRs from VR, it's a blocker thing...
>
> 2018-01-11 0:52 GMT+07:00 Ivan Kudryavtsev <kudryavtsev...@bw-sw.com>:
>
>> I suppose the bug, reported by Wido prevents adding additional CIDRs to
>> Network if IPv6 configured? If so, it's definitely a blocker thing because
>> everyone expects it's possible, because the function is implemented in ACS.
>>
>> 2018-01-11 0:41 GMT+07:00 Rohit Yadav <rohit.ya...@shapeblue.com>:
>>
>>> +1 what Dasn said.
>>>
>>> Wido - are you seeing (upgrade) failure, or something fails to work
>>> without this fix in basic zone?
>>> 
>>> From: Daan Hoogland <daan.hoogl...@gmail.com>
>>> Sent: Wednesday, January 10, 2018 10:50:22 PM
>>> To: dev
>>> Cc: Rohit Yadav
>>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>>
>>> I think that we agreed in th3 past that a blocker is either something
>>> that prevents ACS to start or upgrade, or something that breaks prior
>>> functionality.
>>>
>>>
>>> rohit.ya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N
>>> <https://maps.google.com/?q=53+Chandos+Place,+Covent+Garden,+London%C2%A0+WC2N=gmail=g>
>>> 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>> On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander <w...@widodh.nl
>>> <mailto:w...@widodh.nl>> wrote:
>>>
>>>
>>> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
>>> All,
>>>
>>>
>>> I want to thank all the reviewers, contributors and PR authors for their
>>> hard work, support and collaboration. We managed to review, test and merge
>>> more than 100 PRs towards the 4.11 milestone!
>>>
>>>
>>> Out of 11 open PRs on Monday, the list is down to 2 now which were
>>> recently added features:
>>>
>>> https://github.com/apache/cloudstack/milestone/3
>>>
>>>
>>> To keep up with the release schedule, I think it's time we should focus
>>> on stabilizing master, testing it, fix any regressions and blockers.
>>>
>>>
>>> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
>>> schedule and master will be open for PRs with following merge criteria:
>>>
>>> - Blocker fixes, especially those blocking the release
>>>
>>> - Test failure and regression fixes
>>>
>>> - Release related fixes for example - upgrade blockers, database path,
>>> packaging and systemvmtemplate related etc.
>>>
>>>
>>> Thoughts, objections?
>>>
>>>
>>> Awesome!
>>>
>>> I'm looking for the definition for a blocker, I recently found this one:
>>> https://github.com/apache/cloudstack/pull/2396
>>>
>>> For us this is a big problem as we keep running into it, but probably
>>> nobody else. I don't want to promote my own PR as a blocker, but what is
>>> the definition?
>>>
>>> Because it's my own PR I didn't add the 4.11 milestone.
>>>
>>> Looking forward to 4.11!
>>>
>>>
>>> Wido
>>>
>>>
>>> - Rohit
>>>
>>> <https://cloudstack.apache.org>
>>>
>>>
>>>
>>> 
>>> From: Khosrow Moossavi <kmooss...@cloudops.com>> kmooss...@cloudops.com>>
>>> Sent: Monday, January 8, 2018 8:59:30 PM
>>> To: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>
>>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>>
>>> +1 Daan and Rohit
>>>
>>> Khosrow Moossavi
>>>
>>> Cloud Infrastructure Developer
>>>
>>> t 514.447.3456
>>>

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Ivan Kudryavtsev

Sorry, to clarify, I mean (if I correctly understand) that if someone has a
network with several CIDRs in the basic zone and, lets say, 4.9.3 upgraded
to 4.11, which results that VMs stop getting DHCP announces for additional
CIDRs from VR, it's a blocker thing...

2018-01-11 0:52 GMT+07:00 Ivan Kudryavtsev <kudryavtsev...@bw-sw.com>:

> I suppose the bug, reported by Wido prevents adding additional CIDRs to
> Network if IPv6 configured? If so, it's definitely a blocker thing because
> everyone expects it's possible, because the function is implemented in ACS.
>
> 2018-01-11 0:41 GMT+07:00 Rohit Yadav <rohit.ya...@shapeblue.com>:
>
>> +1 what Dasn said.
>>
>> Wido - are you seeing (upgrade) failure, or something fails to work
>> without this fix in basic zone?
>> 
>> From: Daan Hoogland <daan.hoogl...@gmail.com>
>> Sent: Wednesday, January 10, 2018 10:50:22 PM
>> To: dev
>> Cc: Rohit Yadav
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>
>> I think that we agreed in th3 past that a blocker is either something
>> that prevents ACS to start or upgrade, or something that breaks prior
>> functionality.
>>
>>
>> rohit.ya...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>
>> On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander <w...@widodh.nl
>> <mailto:w...@widodh.nl>> wrote:
>>
>>
>> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
>> All,
>>
>>
>> I want to thank all the reviewers, contributors and PR authors for their
>> hard work, support and collaboration. We managed to review, test and merge
>> more than 100 PRs towards the 4.11 milestone!
>>
>>
>> Out of 11 open PRs on Monday, the list is down to 2 now which were
>> recently added features:
>>
>> https://github.com/apache/cloudstack/milestone/3
>>
>>
>> To keep up with the release schedule, I think it's time we should focus
>> on stabilizing master, testing it, fix any regressions and blockers.
>>
>>
>> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
>> schedule and master will be open for PRs with following merge criteria:
>>
>> - Blocker fixes, especially those blocking the release
>>
>> - Test failure and regression fixes
>>
>> - Release related fixes for example - upgrade blockers, database path,
>> packaging and systemvmtemplate related etc.
>>
>>
>> Thoughts, objections?
>>
>>
>> Awesome!
>>
>> I'm looking for the definition for a blocker, I recently found this one:
>> https://github.com/apache/cloudstack/pull/2396
>>
>> For us this is a big problem as we keep running into it, but probably
>> nobody else. I don't want to promote my own PR as a blocker, but what is
>> the definition?
>>
>> Because it's my own PR I didn't add the 4.11 milestone.
>>
>> Looking forward to 4.11!
>>
>>
>> Wido
>>
>>
>> - Rohit
>>
>> <https://cloudstack.apache.org>
>>
>>
>>
>> 
>> From: Khosrow Moossavi <kmooss...@cloudops.com> kmooss...@cloudops.com>>
>> Sent: Monday, January 8, 2018 8:59:30 PM
>> To: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>
>> +1 Daan and Rohit
>>
>> Khosrow Moossavi
>>
>> Cloud Infrastructure Developer
>>
>> t 514.447.3456
>>
>> <https://goo.gl/NYZ8KK>
>>
>>
>>
>> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
>> boris.stoya...@shapeblue.com<mailto:boris.stoya...@shapeblue.com>
>> wrote:
>>
>> Yes let’s do that.
>>
>>
>> boris.stoya...@shapeblue.com<mailto:boris.stoya...@shapeblue.com>
>> www.shapeblue.com<http://www.shapeblue.com><http://www.shapeblue.com>
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>
>>
>> rohit.ya...@shapeblue.com<mailto:rohit.ya...@shapeblue.com>
>> www.shapeblue.com<http://www.shapeblue.com>
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>> On 8 Jan 2018, at 14:41, Wido den Hollander <w...@widodh.nl> w...@widodh.nl>> wrote:
>>
>>
>>
>> On 01/08/2018 01:30 PM, Rohit Yadav wrote:
>> All,
>> Thank you everyone for your feedback. Given we're in agreement with
>> Daa

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Ivan Kudryavtsev

I suppose the bug, reported by Wido prevents adding additional CIDRs to
Network if IPv6 configured? If so, it's definitely a blocker thing because
everyone expects it's possible, because the function is implemented in ACS.

2018-01-11 0:41 GMT+07:00 Rohit Yadav <rohit.ya...@shapeblue.com>:

> +1 what Dasn said.
>
> Wido - are you seeing (upgrade) failure, or something fails to work
> without this fix in basic zone?
> 
> From: Daan Hoogland <daan.hoogl...@gmail.com>
> Sent: Wednesday, January 10, 2018 10:50:22 PM
> To: dev
> Cc: Rohit Yadav
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> I think that we agreed in th3 past that a blocker is either something that
> prevents ACS to start or upgrade, or something that breaks prior
> functionality.
>
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander <w...@widodh.nl
> <mailto:w...@widodh.nl>> wrote:
>
>
> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
> All,
>
>
> I want to thank all the reviewers, contributors and PR authors for their
> hard work, support and collaboration. We managed to review, test and merge
> more than 100 PRs towards the 4.11 milestone!
>
>
> Out of 11 open PRs on Monday, the list is down to 2 now which were
> recently added features:
>
> https://github.com/apache/cloudstack/milestone/3
>
>
> To keep up with the release schedule, I think it's time we should focus on
> stabilizing master, testing it, fix any regressions and blockers.
>
>
> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
> schedule and master will be open for PRs with following merge criteria:
>
> - Blocker fixes, especially those blocking the release
>
> - Test failure and regression fixes
>
> - Release related fixes for example - upgrade blockers, database path,
> packaging and systemvmtemplate related etc.
>
>
> Thoughts, objections?
>
>
> Awesome!
>
> I'm looking for the definition for a blocker, I recently found this one:
> https://github.com/apache/cloudstack/pull/2396
>
> For us this is a big problem as we keep running into it, but probably
> nobody else. I don't want to promote my own PR as a blocker, but what is
> the definition?
>
> Because it's my own PR I didn't add the 4.11 milestone.
>
> Looking forward to 4.11!
>
>
> Wido
>
>
> - Rohit
>
> <https://cloudstack.apache.org>
>
>
>
> 
> From: Khosrow Moossavi <kmooss...@cloudops.com kmooss...@cloudops.com>>
> Sent: Monday, January 8, 2018 8:59:30 PM
> To: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> +1 Daan and Rohit
>
> Khosrow Moossavi
>
> Cloud Infrastructure Developer
>
> t 514.447.3456
>
> <https://goo.gl/NYZ8KK>
>
>
>
> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
> boris.stoya...@shapeblue.com<mailto:boris.stoya...@shapeblue.com>
> wrote:
>
> Yes let’s do that.
>
>
> boris.stoya...@shapeblue.com<mailto:boris.stoya...@shapeblue.com>
> www.shapeblue.com<http://www.shapeblue.com><http://www.shapeblue.com>
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>
> rohit.ya...@shapeblue.com<mailto:rohit.ya...@shapeblue.com>
> www.shapeblue.com<http://www.shapeblue.com>
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
> On 8 Jan 2018, at 14:41, Wido den Hollander <w...@widodh.nl<mailto:wido@
> widodh.nl>> wrote:
>
>
>
> On 01/08/2018 01:30 PM, Rohit Yadav wrote:
> All,
> Thank you everyone for your feedback. Given we're in agreement with
> Daan's proposal, I'll summarize and add strategy:
> - We'll freeze the 4.11 milestone to only these 9 PRs:
> https://github.com/apache/cloudstack/milestone/3
> - In addition, only blocker, test fixes, and release/packaging related
> fixes may be accepted in master now.
> - If we don't hear from authors within a day, the PRs may be removed
> from the milestone.
> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
> Does this look agreeable? Thanks.
>
> Yes, it does! When the first RC comes out we should be able to run
> tests, fix what's broken and focus in the release and 4.12 afterwards.
>
> Wido
>
> - Rohit
> <https://cloudstack.apache.org>
> 
> From: Daan Hoogland <daan.hoogl...@gmail.com daan.hoogl...@gmail.com>>
> Sent: Monday, January 8, 2018 4:21:00 PM
> To:

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Rohit Yadav

+1 what Dasn said.

Wido - are you seeing (upgrade) failure, or something fails to work without 
this fix in basic zone?

From: Daan Hoogland <daan.hoogl...@gmail.com>
Sent: Wednesday, January 10, 2018 10:50:22 PM
To: dev
Cc: Rohit Yadav
Subject: Re: [DISCUSS] Freezing master for 4.11

I think that we agreed in th3 past that a blocker is either something that 
prevents ACS to start or upgrade, or something that breaks prior functionality.

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander 
<w...@widodh.nl<mailto:w...@widodh.nl>> wrote:

On 01/10/2018 05:47 PM, Rohit Yadav wrote:
All,

I want to thank all the reviewers, contributors and PR authors for their hard 
work, support and collaboration. We managed to review, test and merge more than 
100 PRs towards the 4.11 milestone!

Out of 11 open PRs on Monday, the list is down to 2 now which were recently 
added features:

https://github.com/apache/cloudstack/milestone/3

To keep up with the release schedule, I think it's time we should focus on 
stabilizing master, testing it, fix any regressions and blockers.

I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the schedule and 
master will be open for PRs with following merge criteria:

- Blocker fixes, especially those blocking the release

- Test failure and regression fixes

- Release related fixes for example - upgrade blockers, database path, 
packaging and systemvmtemplate related etc.

Thoughts, objections?

Awesome!

I'm looking for the definition for a blocker, I recently found this one: 
https://github.com/apache/cloudstack/pull/2396

For us this is a big problem as we keep running into it, but probably nobody 
else. I don't want to promote my own PR as a blocker, but what is the 
definition?

Because it's my own PR I didn't add the 4.11 milestone.

Looking forward to 4.11!

Wido

- Rohit

<https://cloudstack.apache.org>

From: Khosrow Moossavi <kmooss...@cloudops.com<mailto:kmooss...@cloudops.com>>
Sent: Monday, January 8, 2018 8:59:30 PM
To: dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>
Subject: Re: [DISCUSS] Freezing master for 4.11

+1 Daan and Rohit

Khosrow Moossavi

Cloud Infrastructure Developer

t 514.447.3456

<https://goo.gl/NYZ8KK>

On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov 
<boris.stoya...@shapeblue.com<mailto:boris.stoya...@shapeblue.com>
wrote:

Yes let’s do that.

boris.stoya...@shapeblue.com<mailto:boris.stoya...@shapeblue.com>
www.shapeblue.com<http://www.shapeblue.com><http://www.shapeblue.com>
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

rohit.ya...@shapeblue.com<mailto:rohit.ya...@shapeblue.com>
www.shapeblue.com<http://www.shapeblue.com>
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

On 8 Jan 2018, at 14:41, Wido den Hollander 
<w...@widodh.nl<mailto:w...@widodh.nl>> wrote:

On 01/08/2018 01:30 PM, Rohit Yadav wrote:
All,
Thank you everyone for your feedback. Given we're in agreement with
Daan's proposal, I'll summarize and add strategy:
- We'll freeze the 4.11 milestone to only these 9 PRs:
https://github.com/apache/cloudstack/milestone/3
- In addition, only blocker, test fixes, and release/packaging related
fixes may be accepted in master now.
- If we don't hear from authors within a day, the PRs may be removed
from the milestone.
- We'll re-assess the list again by EOD, Wed 10 Jan 2018.
Does this look agreeable? Thanks.

Yes, it does! When the first RC comes out we should be able to run
tests, fix what's broken and focus in the release and 4.12 afterwards.

Wido

- Rohit
<https://cloudstack.apache.org>

From: Daan Hoogland <daan.hoogl...@gmail.com<mailto:daan.hoogl...@gmail.com>>
Sent: Monday, January 8, 2018 4:21:00 PM
To: dev
Subject: Re: [DISCUSS] Freezing master for 4.11
slow display of arrogance in reacting this time ; yeeaahhh
On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com<mailto:igor.voloshane...@gmail.com>> wrote:
You again faster than me )))

2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
igor.voloshane...@gmail.com<mailto:igor.voloshane...@gmail.com>
:

:D tnx )
Updated by my colleague already

2018-01-08 12:06 GMT+02:00 Daan Hoogland 
<daan.hoogl...@gmail.com<mailto:daan.hoogl...@gmail.com>>:

yeah, way ahead of you Igor ;) I asked a question about it

On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com<mailto:igor.voloshane...@gmail.com>> wrote:

Updates posted to https://github.com/apache/cloudstack/pull/2389
Can you please review?

2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
igor.voloshane...@gmail.com<mailto:igor.voloshane...@gmail.c

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Daan Hoogland

I think that we agreed in th3 past that a blocker is either something that
prevents ACS to start or upgrade, or something that breaks prior
functionality.

On Wed, Jan 10, 2018 at 6:13 PM, Wido den Hollander <w...@widodh.nl> wrote:

>
>
> On 01/10/2018 05:47 PM, Rohit Yadav wrote:
>
>> All,
>>
>>
>> I want to thank all the reviewers, contributors and PR authors for their
>> hard work, support and collaboration. We managed to review, test and merge
>> more than 100 PRs towards the 4.11 milestone!
>>
>>
>> Out of 11 open PRs on Monday, the list is down to 2 now which were
>> recently added features:
>>
>> https://github.com/apache/cloudstack/milestone/3
>>
>>
>> To keep up with the release schedule, I think it's time we should focus
>> on stabilizing master, testing it, fix any regressions and blockers.
>>
>>
>> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
>> schedule and master will be open for PRs with following merge criteria:
>>
>> - Blocker fixes, especially those blocking the release
>>
>> - Test failure and regression fixes
>>
>> - Release related fixes for example - upgrade blockers, database path,
>> packaging and systemvmtemplate related etc.
>>
>>
>> Thoughts, objections?
>>
>>
> Awesome!
>
> I'm looking for the definition for a blocker, I recently found this one:
> https://github.com/apache/cloudstack/pull/2396
>
> For us this is a big problem as we keep running into it, but probably
> nobody else. I don't want to promote my own PR as a blocker, but what is
> the definition?
>
> Because it's my own PR I didn't add the 4.11 milestone.
>
> Looking forward to 4.11!
>
>
> Wido
>
>
>> - Rohit
>>
>> <https://cloudstack.apache.org>
>>
>>
>>
>> 
>> From: Khosrow Moossavi <kmooss...@cloudops.com>
>> Sent: Monday, January 8, 2018 8:59:30 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>
>> +1 Daan and Rohit
>>
>> Khosrow Moossavi
>>
>> Cloud Infrastructure Developer
>>
>> t 514.447.3456
>>
>> <https://goo.gl/NYZ8KK>
>>
>>
>>
>> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
>> boris.stoya...@shapeblue.com
>>
>>> wrote:
>>>
>>
>> Yes let’s do that.
>>>
>>>
>>> boris.stoya...@shapeblue.com
>>> www.shapeblue.com<http://www.shapeblue.com>
>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>> @shapeblue
>>>
>>>
>>>
>>>
>>> rohit.ya...@shapeblue.com
>> www.shapeblue.com
>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> @shapeblue
>>
>>
>>> On 8 Jan 2018, at 14:41, Wido den Hollander <w...@widodh.nl> wrote:
>>>
>>>>
>>>>
>>>>
>>>> On 01/08/2018 01:30 PM, Rohit Yadav wrote:
>>>>
>>>>> All,
>>>>> Thank you everyone for your feedback. Given we're in agreement with
>>>>>
>>>> Daan's proposal, I'll summarize and add strategy:
>>>
>>>> - We'll freeze the 4.11 milestone to only these 9 PRs:
>>>>>
>>>> https://github.com/apache/cloudstack/milestone/3
>>>
>>>> - In addition, only blocker, test fixes, and release/packaging related
>>>>>
>>>> fixes may be accepted in master now.
>>>
>>>> - If we don't hear from authors within a day, the PRs may be removed
>>>>>
>>>> from the milestone.
>>>
>>>> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
>>>>> Does this look agreeable? Thanks.
>>>>>
>>>>
>>>> Yes, it does! When the first RC comes out we should be able to run
>>>>
>>> tests, fix what's broken and focus in the release and 4.12 afterwards.
>>>
>>>>
>>>> Wido
>>>>
>>>> - Rohit
>>>>> <https://cloudstack.apache.org>
>>>>> 
>>>>> From: Daan Hoogland <daan.hoogl...@gmail.com>
>>>>> Sent: Monday, January 8, 2018 4:21:00 PM
>>>>> To: dev
>>>>> Subject: Re: [DISCUSS] Freezing master for 4.11
>>>>> slow display of arrogance in reacting this time ; yeeaahhh
>>>>> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
>&g

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Wido den Hollander




On 01/10/2018 05:47 PM, Rohit Yadav wrote:

All,


I want to thank all the reviewers, contributors and PR authors for their hard 
work, support and collaboration. We managed to review, test and merge more than 
100 PRs towards the 4.11 milestone!


Out of 11 open PRs on Monday, the list is down to 2 now which were recently 
added features:

https://github.com/apache/cloudstack/milestone/3


To keep up with the release schedule, I think it's time we should focus on 
stabilizing master, testing it, fix any regressions and blockers.


I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the schedule and 
master will be open for PRs with following merge criteria:

- Blocker fixes, especially those blocking the release

- Test failure and regression fixes

- Release related fixes for example - upgrade blockers, database path, 
packaging and systemvmtemplate related etc.


Thoughts, objections?



Awesome!

I'm looking for the definition for a blocker, I recently found this one: 
https://github.com/apache/cloudstack/pull/2396


For us this is a big problem as we keep running into it, but probably 
nobody else. I don't want to promote my own PR as a blocker, but what is 
the definition?


Because it's my own PR I didn't add the 4.11 milestone.

Looking forward to 4.11!

Wido



- Rohit

<https://cloudstack.apache.org>




From: Khosrow Moossavi <kmooss...@cloudops.com>
Sent: Monday, January 8, 2018 8:59:30 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Freezing master for 4.11

+1 Daan and Rohit

Khosrow Moossavi

Cloud Infrastructure Developer

t 514.447.3456

<https://goo.gl/NYZ8KK>



On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <boris.stoya...@shapeblue.com

wrote:



Yes let’s do that.


boris.stoya...@shapeblue.com
www.shapeblue.com<http://www.shapeblue.com>
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue





rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
   
  


On 8 Jan 2018, at 14:41, Wido den Hollander <w...@widodh.nl> wrote:




On 01/08/2018 01:30 PM, Rohit Yadav wrote:

All,
Thank you everyone for your feedback. Given we're in agreement with

Daan's proposal, I'll summarize and add strategy:

- We'll freeze the 4.11 milestone to only these 9 PRs:

https://github.com/apache/cloudstack/milestone/3

- In addition, only blocker, test fixes, and release/packaging related

fixes may be accepted in master now.

- If we don't hear from authors within a day, the PRs may be removed

from the milestone.

- We'll re-assess the list again by EOD, Wed 10 Jan 2018.
Does this look agreeable? Thanks.


Yes, it does! When the first RC comes out we should be able to run

tests, fix what's broken and focus in the release and 4.12 afterwards.


Wido


- Rohit
<https://cloudstack.apache.org>

From: Daan Hoogland <daan.hoogl...@gmail.com>
Sent: Monday, January 8, 2018 4:21:00 PM
To: dev
Subject: Re: [DISCUSS] Freezing master for 4.11
slow display of arrogance in reacting this time ; yeeaahhh
On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:

You again faster than me )))

2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <

igor.voloshane...@gmail.com

:



:D tnx )
Updated by my colleague already

2018-01-08 12:06 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:


yeah, way ahead of you Igor ;) I asked a question about it

On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:


Updates posted to https://github.com/apache/cloudstack/pull/2389
Can you please review?

2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <

igor.voloshane...@gmail.com

:



Sure. Got it.

Will post update soon

2018-01-08 11:38 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com

:



Igor, I remember your PR and think it is fine. It can also be

argued

that

it needs to go in as a security feature. For an RM it is

unthinkably

late,

but fortunately it is very small. I will however -1 it if it leads

to a

plethora of last minute PRs to include.

On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:


Guys, can we please include https://github.com/apache/clou

dstack/pull/2389

into 4.11
PR very small and updates will be published in next few hours.

As we have this for a while in production for 4.8 branch.

2018-01-08 11:15 GMT+02:00 Boris Stoyanov <

boris.stoya...@shapeblue.com

:


+1 Daan


boris.stoya...@shapeblue.com
www.shapeblue.com<http://www.shapeblue.com>
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue




On 8 Jan 2018, at 10:47, Daan Hoogland <

daan.hoogl...@gmail.com>

wrote:


Rohit, Ivan,

I think we can argue that the five open PRs on the milestone

can

still

go

in as long as active work on them continues. I have not

looked

at

Ivan's

PRs yet but can

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Ivan Kudryavtsev

Congratulations, waiting for RC to do UAT on our dev cloud and switching
cloudstack-ui to 4.11

10 янв. 2018 г. 23:48 пользователь "Rohit Yadav" <rohit.ya...@shapeblue.com>
написал:

> All,
>
>
> I want to thank all the reviewers, contributors and PR authors for their
> hard work, support and collaboration. We managed to review, test and merge
> more than 100 PRs towards the 4.11 milestone!
>
>
> Out of 11 open PRs on Monday, the list is down to 2 now which were
> recently added features:
>
> https://github.com/apache/cloudstack/milestone/3
>
>
> To keep up with the release schedule, I think it's time we should focus on
> stabilizing master, testing it, fix any regressions and blockers.
>
>
> I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the
> schedule and master will be open for PRs with following merge criteria:
>
> - Blocker fixes, especially those blocking the release
>
> - Test failure and regression fixes
>
> - Release related fixes for example - upgrade blockers, database path,
> packaging and systemvmtemplate related etc.
>
>
> Thoughts, objections?
>
>
> - Rohit
>
> <https://cloudstack.apache.org>
>
>
>
> 
> From: Khosrow Moossavi <kmooss...@cloudops.com>
> Sent: Monday, January 8, 2018 8:59:30 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> +1 Daan and Rohit
>
> Khosrow Moossavi
>
> Cloud Infrastructure Developer
>
> t 514.447.3456
>
> <https://goo.gl/NYZ8KK>
>
>
>
> On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <
> boris.stoya...@shapeblue.com
> > wrote:
>
> > Yes let’s do that.
> >
> >
> > boris.stoya...@shapeblue.com
> > www.shapeblue.com<http://www.shapeblue.com>
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> > On 8 Jan 2018, at 14:41, Wido den Hollander <w...@widodh.nl> wrote:
> > >
> > >
> > >
> > > On 01/08/2018 01:30 PM, Rohit Yadav wrote:
> > >> All,
> > >> Thank you everyone for your feedback. Given we're in agreement with
> > Daan's proposal, I'll summarize and add strategy:
> > >> - We'll freeze the 4.11 milestone to only these 9 PRs:
> > https://github.com/apache/cloudstack/milestone/3
> > >> - In addition, only blocker, test fixes, and release/packaging related
> > fixes may be accepted in master now.
> > >> - If we don't hear from authors within a day, the PRs may be removed
> > from the milestone.
> > >> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
> > >> Does this look agreeable? Thanks.
> > >
> > > Yes, it does! When the first RC comes out we should be able to run
> > tests, fix what's broken and focus in the release and 4.12 afterwards.
> > >
> > > Wido
> > >
> > >> - Rohit
> > >> <https://cloudstack.apache.org>
> > >> 
> > >> From: Daan Hoogland <daan.hoogl...@gmail.com>
> > >> Sent: Monday, January 8, 2018 4:21:00 PM
> > >> To: dev
> > >> Subject: Re: [DISCUSS] Freezing master for 4.11
> > >> slow display of arrogance in reacting this time ; yeeaahhh
> > >> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
> > >> igor.voloshane...@gmail.com> wrote:
> > >>> You again faster than me )))
> > >>>
> > >>> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
> > igor.voloshane...@gmail.com
> > >>>> :
> > >>>
> > >>>> :D tnx )
> > >>>> Updated by my colleague already
> > >>>>
> > >>>> 2018-01-08 12:06 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:
> > >>>>
> > >>>>> yeah, way ahead of you Igor ;) I asked a question about it
> > >>>>>
> > >>>>> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
> > >>>>> igor.voloshane...@gmail.com> wrote:
> > >>>>>
> > >>>>>> Updates posted to https://github.com/apache/cloudstack/pull/2389
> > >>>>>> Can you please review?
> > >>>>>>
> > >>>>>> 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
> > >>>>>

Re: [DISCUSS] Freezing master for 4.11

2018-01-10 Thread Rohit Yadav

All,


I want to thank all the reviewers, contributors and PR authors for their hard 
work, support and collaboration. We managed to review, test and merge more than 
100 PRs towards the 4.11 milestone!


Out of 11 open PRs on Monday, the list is down to 2 now which were recently 
added features:

https://github.com/apache/cloudstack/milestone/3


To keep up with the release schedule, I think it's time we should focus on 
stabilizing master, testing it, fix any regressions and blockers.


I'll cut 4.11 branch on Monday (15th Jan) and start RC1 as per the schedule and 
master will be open for PRs with following merge criteria:

- Blocker fixes, especially those blocking the release

- Test failure and regression fixes

- Release related fixes for example - upgrade blockers, database path, 
packaging and systemvmtemplate related etc.


Thoughts, objections?


- Rohit

<https://cloudstack.apache.org>




From: Khosrow Moossavi <kmooss...@cloudops.com>
Sent: Monday, January 8, 2018 8:59:30 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Freezing master for 4.11

+1 Daan and Rohit

Khosrow Moossavi

Cloud Infrastructure Developer

t 514.447.3456

<https://goo.gl/NYZ8KK>



On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <boris.stoya...@shapeblue.com
> wrote:

> Yes let’s do that.
>
>
> boris.stoya...@shapeblue.com
> www.shapeblue.com<http://www.shapeblue.com>
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> 
rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

> On 8 Jan 2018, at 14:41, Wido den Hollander <w...@widodh.nl> wrote:
> >
> >
> >
> > On 01/08/2018 01:30 PM, Rohit Yadav wrote:
> >> All,
> >> Thank you everyone for your feedback. Given we're in agreement with
> Daan's proposal, I'll summarize and add strategy:
> >> - We'll freeze the 4.11 milestone to only these 9 PRs:
> https://github.com/apache/cloudstack/milestone/3
> >> - In addition, only blocker, test fixes, and release/packaging related
> fixes may be accepted in master now.
> >> - If we don't hear from authors within a day, the PRs may be removed
> from the milestone.
> >> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
> >> Does this look agreeable? Thanks.
> >
> > Yes, it does! When the first RC comes out we should be able to run
> tests, fix what's broken and focus in the release and 4.12 afterwards.
> >
> > Wido
> >
> >> - Rohit
> >> <https://cloudstack.apache.org>
> >> 
> >> From: Daan Hoogland <daan.hoogl...@gmail.com>
> >> Sent: Monday, January 8, 2018 4:21:00 PM
> >> To: dev
> >> Subject: Re: [DISCUSS] Freezing master for 4.11
> >> slow display of arrogance in reacting this time ; yeeaahhh
> >> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
> >> igor.voloshane...@gmail.com> wrote:
> >>> You again faster than me )))
> >>>
> >>> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
> igor.voloshane...@gmail.com
> >>>> :
> >>>
> >>>> :D tnx )
> >>>> Updated by my colleague already
> >>>>
> >>>> 2018-01-08 12:06 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:
> >>>>
> >>>>> yeah, way ahead of you Igor ;) I asked a question about it
> >>>>>
> >>>>> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
> >>>>> igor.voloshane...@gmail.com> wrote:
> >>>>>
> >>>>>> Updates posted to https://github.com/apache/cloudstack/pull/2389
> >>>>>> Can you please review?
> >>>>>>
> >>>>>> 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
> >>>>> igor.voloshane...@gmail.com
> >>>>>>> :
> >>>>>>
> >>>>>>> Sure. Got it.
> >>>>>>>
> >>>>>>> Will post update soon
> >>>>>>>
> >>>>>>> 2018-01-08 11:38 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com
> >:
> >>>>>>>
> >>>>>>>> Igor, I remember your PR and think it is fine. It can also be
> >>> argued
> >>>>>> that
> >>>>>>>> it needs to go in as a security feature. For an RM it is
> >>> unthinkably
> >>>>>> late,
> >>>>>>>> but fortunately it is very

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Khosrow Moossavi

+1 Daan and Rohit

Khosrow Moossavi

Cloud Infrastructure Developer

t 514.447.3456

<https://goo.gl/NYZ8KK>



On Mon, Jan 8, 2018 at 7:58 AM, Boris Stoyanov <boris.stoya...@shapeblue.com
> wrote:

> Yes let’s do that.
>
>
> boris.stoya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> > On 8 Jan 2018, at 14:41, Wido den Hollander <w...@widodh.nl> wrote:
> >
> >
> >
> > On 01/08/2018 01:30 PM, Rohit Yadav wrote:
> >> All,
> >> Thank you everyone for your feedback. Given we're in agreement with
> Daan's proposal, I'll summarize and add strategy:
> >> - We'll freeze the 4.11 milestone to only these 9 PRs:
> https://github.com/apache/cloudstack/milestone/3
> >> - In addition, only blocker, test fixes, and release/packaging related
> fixes may be accepted in master now.
> >> - If we don't hear from authors within a day, the PRs may be removed
> from the milestone.
> >> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
> >> Does this look agreeable? Thanks.
> >
> > Yes, it does! When the first RC comes out we should be able to run
> tests, fix what's broken and focus in the release and 4.12 afterwards.
> >
> > Wido
> >
> >> - Rohit
> >> <https://cloudstack.apache.org>
> >> 
> >> From: Daan Hoogland <daan.hoogl...@gmail.com>
> >> Sent: Monday, January 8, 2018 4:21:00 PM
> >> To: dev
> >> Subject: Re: [DISCUSS] Freezing master for 4.11
> >> slow display of arrogance in reacting this time ; yeeaahhh
> >> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
> >> igor.voloshane...@gmail.com> wrote:
> >>> You again faster than me )))
> >>>
> >>> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
> igor.voloshane...@gmail.com
> >>>> :
> >>>
> >>>> :D tnx )
> >>>> Updated by my colleague already
> >>>>
> >>>> 2018-01-08 12:06 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:
> >>>>
> >>>>> yeah, way ahead of you Igor ;) I asked a question about it
> >>>>>
> >>>>> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
> >>>>> igor.voloshane...@gmail.com> wrote:
> >>>>>
> >>>>>> Updates posted to https://github.com/apache/cloudstack/pull/2389
> >>>>>> Can you please review?
> >>>>>>
> >>>>>> 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
> >>>>> igor.voloshane...@gmail.com
> >>>>>>> :
> >>>>>>
> >>>>>>> Sure. Got it.
> >>>>>>>
> >>>>>>> Will post update soon
> >>>>>>>
> >>>>>>> 2018-01-08 11:38 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com
> >:
> >>>>>>>
> >>>>>>>> Igor, I remember your PR and think it is fine. It can also be
> >>> argued
> >>>>>> that
> >>>>>>>> it needs to go in as a security feature. For an RM it is
> >>> unthinkably
> >>>>>> late,
> >>>>>>>> but fortunately it is very small. I will however -1 it if it leads
> >>>>> to a
> >>>>>>>> plethora of last minute PRs to include.
> >>>>>>>>
> >>>>>>>> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
> >>>>>>>> igor.voloshane...@gmail.com> wrote:
> >>>>>>>>
> >>>>>>>>> Guys, can we please include https://github.com/apache/clou
> >>>>>>>> dstack/pull/2389
> >>>>>>>>> into 4.11
> >>>>>>>>> PR very small and updates will be published in next few hours.
> >>>>>>>>>
> >>>>>>>>> As we have this for a while in production for 4.8 branch.
> >>>>>>>>>
> >>>>>>>>> 2018-01-08 11:15 GMT+02:00 Boris Stoyanov <
> >>>>>> boris.stoya...@shapeblue.com
> >>>>>>>>> :
> >>>>>>>>>
> >>>>>>>>>> +1 Daan
> >>>>>>>>>>
> >>>>>>>>>>
>

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Boris Stoyanov

Yes let’s do that.


boris.stoya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

> On 8 Jan 2018, at 14:41, Wido den Hollander <w...@widodh.nl> wrote:
> 
> 
> 
> On 01/08/2018 01:30 PM, Rohit Yadav wrote:
>> All,
>> Thank you everyone for your feedback. Given we're in agreement with Daan's 
>> proposal, I'll summarize and add strategy:
>> - We'll freeze the 4.11 milestone to only these 9 PRs: 
>> https://github.com/apache/cloudstack/milestone/3
>> - In addition, only blocker, test fixes, and release/packaging related fixes 
>> may be accepted in master now.
>> - If we don't hear from authors within a day, the PRs may be removed from 
>> the milestone.
>> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
>> Does this look agreeable? Thanks.
> 
> Yes, it does! When the first RC comes out we should be able to run tests, fix 
> what's broken and focus in the release and 4.12 afterwards.
> 
> Wido
> 
>> - Rohit
>> <https://cloudstack.apache.org>
>> ____
>> From: Daan Hoogland <daan.hoogl...@gmail.com>
>> Sent: Monday, January 8, 2018 4:21:00 PM
>> To: dev
>> Subject: Re: [DISCUSS] Freezing master for 4.11
>> slow display of arrogance in reacting this time ; yeeaahhh
>> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
>> igor.voloshane...@gmail.com> wrote:
>>> You again faster than me )))
>>> 
>>> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <igor.voloshane...@gmail.com
>>>> :
>>> 
>>>> :D tnx )
>>>> Updated by my colleague already
>>>> 
>>>> 2018-01-08 12:06 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:
>>>> 
>>>>> yeah, way ahead of you Igor ;) I asked a question about it
>>>>> 
>>>>> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
>>>>> igor.voloshane...@gmail.com> wrote:
>>>>> 
>>>>>> Updates posted to https://github.com/apache/cloudstack/pull/2389
>>>>>> Can you please review?
>>>>>> 
>>>>>> 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
>>>>> igor.voloshane...@gmail.com
>>>>>>> :
>>>>>> 
>>>>>>> Sure. Got it.
>>>>>>> 
>>>>>>> Will post update soon
>>>>>>> 
>>>>>>> 2018-01-08 11:38 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:
>>>>>>> 
>>>>>>>> Igor, I remember your PR and think it is fine. It can also be
>>> argued
>>>>>> that
>>>>>>>> it needs to go in as a security feature. For an RM it is
>>> unthinkably
>>>>>> late,
>>>>>>>> but fortunately it is very small. I will however -1 it if it leads
>>>>> to a
>>>>>>>> plethora of last minute PRs to include.
>>>>>>>> 
>>>>>>>> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
>>>>>>>> igor.voloshane...@gmail.com> wrote:
>>>>>>>> 
>>>>>>>>> Guys, can we please include https://github.com/apache/clou
>>>>>>>> dstack/pull/2389
>>>>>>>>> into 4.11
>>>>>>>>> PR very small and updates will be published in next few hours.
>>>>>>>>> 
>>>>>>>>> As we have this for a while in production for 4.8 branch.
>>>>>>>>> 
>>>>>>>>> 2018-01-08 11:15 GMT+02:00 Boris Stoyanov <
>>>>>> boris.stoya...@shapeblue.com
>>>>>>>>> :
>>>>>>>>> 
>>>>>>>>>> +1 Daan
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> boris.stoya...@shapeblue.com
>>>>>>>>>> www.shapeblue.com<http://www.shapeblue.com>
>>>>>>>>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>>>>>>>>> @shapeblue
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>>> On 8 Jan 2018, at 10:47, Daan Hoogland <
>>>>> daan.hoogl...@gmail.com>
>>>>>>>>> wrote:
>>>>>>

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Wido den Hollander




On 01/08/2018 01:30 PM, Rohit Yadav wrote:

All,


Thank you everyone for your feedback. Given we're in agreement with Daan's 
proposal, I'll summarize and add strategy:


- We'll freeze the 4.11 milestone to only these 9 PRs: 
https://github.com/apache/cloudstack/milestone/3

- In addition, only blocker, test fixes, and release/packaging related fixes 
may be accepted in master now.

- If we don't hear from authors within a day, the PRs may be removed from the 
milestone.

- We'll re-assess the list again by EOD, Wed 10 Jan 2018.


Does this look agreeable? Thanks.



Yes, it does! When the first RC comes out we should be able to run 
tests, fix what's broken and focus in the release and 4.12 afterwards.


Wido



- Rohit

<https://cloudstack.apache.org>




From: Daan Hoogland <daan.hoogl...@gmail.com>
Sent: Monday, January 8, 2018 4:21:00 PM
To: dev
Subject: Re: [DISCUSS] Freezing master for 4.11

slow display of arrogance in reacting this time ; yeeaahhh

On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:


You again faster than me )))

2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <igor.voloshane...@gmail.com

:



:D tnx )
Updated by my colleague already

2018-01-08 12:06 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:


yeah, way ahead of you Igor ;) I asked a question about it

On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:


Updates posted to https://github.com/apache/cloudstack/pull/2389
Can you please review?

2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <

igor.voloshane...@gmail.com

:



Sure. Got it.

Will post update soon

2018-01-08 11:38 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:


Igor, I remember your PR and think it is fine. It can also be

argued

that

it needs to go in as a security feature. For an RM it is

unthinkably

late,

but fortunately it is very small. I will however -1 it if it leads

to a

plethora of last minute PRs to include.

On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:


Guys, can we please include https://github.com/apache/clou

dstack/pull/2389

into 4.11
PR very small and updates will be published in next few hours.

As we have this for a while in production for 4.8 branch.

2018-01-08 11:15 GMT+02:00 Boris Stoyanov <

boris.stoya...@shapeblue.com

:


+1 Daan


boris.stoya...@shapeblue.com
www.shapeblue.com<http://www.shapeblue.com>
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue




On 8 Jan 2018, at 10:47, Daan Hoogland <

daan.hoogl...@gmail.com>

wrote:


Rohit, Ivan,

I think we can argue that the five open PRs on the milestone

can

still

go

in as long as active work on them continues. I have not

looked

at

Ivan's

PRs yet but can see they were entered in december and he is

actively

working on it so why not include those in the milestone. A

bigger

concern

is that some of the remaining PRs in that milestone are

potentially

conflicting. So we feature freeze now and work only to get

the

set

list

in

(and blockers).


On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev <

kudryavtsev...@bw-sw.com>

wrote:


Rohit, Devs,

just consider adding:

CLOUDSTACK-10188 / https://github.com/apache/

cloudstack/pull/2362

[resouce

accounting blocker bug]
CLOUDSTACK-10170 / https://github.com/apache/

cloudstack/pull/2350

[security
fix, enchancement]

They are ready (we think so) for some time, but *no final

review*

yet.



2018-01-08 14:47 GMT+07:00 Rohit Yadav <

rohit.ya...@shapeblue.com

:



All,


As per the previously shared schedule [1], by EOD today (8

Jan

2018)

we

would freeze master after which we'll only accept

critical/blocker

fixes,

stabilize master and start a voting thread on 4.11 RC1

(est.

by

15

Jan

2018).


I wanted to gather consensus if this is acceptable to

everyone

as

there

are still few outstanding feature PRs that I understand

authors

have

worked

hard to get them in.


Please share your thoughts, comments.  If you're the author

of

such

an

existing PR, please work with us, address outstanding

issues.



In case of no objections, it will be assumed that the plan

is

acceptable

to everyone. Thanks.


[1] http://markmail.org/message/mszlluye35acvn2j


- Rohit

<https://cloudstack.apache.org>



rohit.ya...@shapeblue.com
www.shapeblue.com<http://www.shapeblue.com>
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue







--
With best regards, Ivan Kudryavtsev
Bitworks Software, Ltd.
Cell: +7-923-414-1515
WWW: http://bitworks.software/ <http://bw-sw.com/>





--
Daan









--
Daan










--
Daan










--
Daan

rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Rene Moser

On 01/08/2018 01:30 PM, Rohit Yadav wrote:
> Does this look agreeable? Thanks.

+1

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Rafael Weingärtner

+1

On Mon, Jan 8, 2018 at 10:30 AM, Rohit Yadav <rohit.ya...@shapeblue.com>
wrote:

> All,
>
>
> Thank you everyone for your feedback. Given we're in agreement with Daan's
> proposal, I'll summarize and add strategy:
>
>
> - We'll freeze the 4.11 milestone to only these 9 PRs:
> https://github.com/apache/cloudstack/milestone/3
>
> - In addition, only blocker, test fixes, and release/packaging related
> fixes may be accepted in master now.
>
> - If we don't hear from authors within a day, the PRs may be removed from
> the milestone.
>
> - We'll re-assess the list again by EOD, Wed 10 Jan 2018.
>
>
> Does this look agreeable? Thanks.
>
>
> - Rohit
>
> <https://cloudstack.apache.org>
>
>
>
> 
> From: Daan Hoogland <daan.hoogl...@gmail.com>
> Sent: Monday, January 8, 2018 4:21:00 PM
> To: dev
> Subject: Re: [DISCUSS] Freezing master for 4.11
>
> slow display of arrogance in reacting this time ; yeeaahhh
>
> On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
> igor.voloshane...@gmail.com> wrote:
>
> > You again faster than me )))
> >
> > 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <
> igor.voloshane...@gmail.com
> > >:
> >
> > > :D tnx )
> > > Updated by my colleague already
> > >
> > > 2018-01-08 12:06 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:
> > >
> > >> yeah, way ahead of you Igor ;) I asked a question about it
> > >>
> > >> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
> > >> igor.voloshane...@gmail.com> wrote:
> > >>
> > >> > Updates posted to https://github.com/apache/cloudstack/pull/2389
> > >> > Can you please review?
> > >> >
> > >> > 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
> > >> igor.voloshane...@gmail.com
> > >> > >:
> > >> >
> > >> > > Sure. Got it.
> > >> > >
> > >> > > Will post update soon
> > >> > >
> > >> > > 2018-01-08 11:38 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com
> >:
> > >> > >
> > >> > >> Igor, I remember your PR and think it is fine. It can also be
> > argued
> > >> > that
> > >> > >> it needs to go in as a security feature. For an RM it is
> > unthinkably
> > >> > late,
> > >> > >> but fortunately it is very small. I will however -1 it if it
> leads
> > >> to a
> > >> > >> plethora of last minute PRs to include.
> > >> > >>
> > >> > >> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
> > >> > >> igor.voloshane...@gmail.com> wrote:
> > >> > >>
> > >> > >> > Guys, can we please include https://github.com/apache/clou
> > >> > >> dstack/pull/2389
> > >> > >> > into 4.11
> > >> > >> > PR very small and updates will be published in next few hours.
> > >> > >> >
> > >> > >> > As we have this for a while in production for 4.8 branch.
> > >> > >> >
> > >> > >> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov <
> > >> > boris.stoya...@shapeblue.com
> > >> > >> >:
> > >> > >> >
> > >> > >> > > +1 Daan
> > >> > >> > >
> > >> > >> > >
> > >> > >> > > boris.stoya...@shapeblue.com
> > >> > >> > > www.shapeblue.com<http://www.shapeblue.com>
> > >> > >> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > >> > >> > > @shapeblue
> > >> > >> > >
> > >> > >> > >
> > >> > >> > >
> > >> > >> > > > On 8 Jan 2018, at 10:47, Daan Hoogland <
> > >> daan.hoogl...@gmail.com>
> > >> > >> > wrote:
> > >> > >> > > >
> > >> > >> > > > Rohit, Ivan,
> > >> > >> > > >
> > >> > >> > > > I think we can argue that the five open PRs on the
> milestone
> > >> can
> > >> > >> still
> > >> > >> &g

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Rohit Yadav

All,


Thank you everyone for your feedback. Given we're in agreement with Daan's 
proposal, I'll summarize and add strategy:


- We'll freeze the 4.11 milestone to only these 9 PRs: 
https://github.com/apache/cloudstack/milestone/3

- In addition, only blocker, test fixes, and release/packaging related fixes 
may be accepted in master now.

- If we don't hear from authors within a day, the PRs may be removed from the 
milestone.

- We'll re-assess the list again by EOD, Wed 10 Jan 2018.


Does this look agreeable? Thanks.


- Rohit

<https://cloudstack.apache.org>




From: Daan Hoogland <daan.hoogl...@gmail.com>
Sent: Monday, January 8, 2018 4:21:00 PM
To: dev
Subject: Re: [DISCUSS] Freezing master for 4.11

slow display of arrogance in reacting this time ; yeeaahhh

On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:

> You again faster than me )))
>
> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor <igor.voloshane...@gmail.com
> >:
>
> > :D tnx )
> > Updated by my colleague already
> >
> > 2018-01-08 12:06 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:
> >
> >> yeah, way ahead of you Igor ;) I asked a question about it
> >>
> >> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
> >> igor.voloshane...@gmail.com> wrote:
> >>
> >> > Updates posted to https://github.com/apache/cloudstack/pull/2389
> >> > Can you please review?
> >> >
> >> > 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
> >> igor.voloshane...@gmail.com
> >> > >:
> >> >
> >> > > Sure. Got it.
> >> > >
> >> > > Will post update soon
> >> > >
> >> > > 2018-01-08 11:38 GMT+02:00 Daan Hoogland <daan.hoogl...@gmail.com>:
> >> > >
> >> > >> Igor, I remember your PR and think it is fine. It can also be
> argued
> >> > that
> >> > >> it needs to go in as a security feature. For an RM it is
> unthinkably
> >> > late,
> >> > >> but fortunately it is very small. I will however -1 it if it leads
> >> to a
> >> > >> plethora of last minute PRs to include.
> >> > >>
> >> > >> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
> >> > >> igor.voloshane...@gmail.com> wrote:
> >> > >>
> >> > >> > Guys, can we please include https://github.com/apache/clou
> >> > >> dstack/pull/2389
> >> > >> > into 4.11
> >> > >> > PR very small and updates will be published in next few hours.
> >> > >> >
> >> > >> > As we have this for a while in production for 4.8 branch.
> >> > >> >
> >> > >> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov <
> >> > boris.stoya...@shapeblue.com
> >> > >> >:
> >> > >> >
> >> > >> > > +1 Daan
> >> > >> > >
> >> > >> > >
> >> > >> > > boris.stoya...@shapeblue.com
> >> > >> > > www.shapeblue.com<http://www.shapeblue.com>
> >> > >> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> >> > >> > > @shapeblue
> >> > >> > >
> >> > >> > >
> >> > >> > >
> >> > >> > > > On 8 Jan 2018, at 10:47, Daan Hoogland <
> >> daan.hoogl...@gmail.com>
> >> > >> > wrote:
> >> > >> > > >
> >> > >> > > > Rohit, Ivan,
> >> > >> > > >
> >> > >> > > > I think we can argue that the five open PRs on the milestone
> >> can
> >> > >> still
> >> > >> > go
> >> > >> > > > in as long as active work on them continues. I have not
> looked
> >> at
> >> > >> > Ivan's
> >> > >> > > > PRs yet but can see they were entered in december and he is
> >> > actively
> >> > >> > > > working on it so why not include those in the milestone. A
> >> bigger
> >> > >> > concern
> >> > >> > > > is that some of the remaining PRs in that milestone are
> >> > potentially
> >> > >> > > > conflicting. So we fea

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Daan Hoogland

slow display of arrogance in reacting this time ; yeeaahhh

On Mon, Jan 8, 2018 at 11:22 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:

> You again faster than me )))
>
> 2018-01-08 12:21 GMT+02:00 Voloshanenko Igor  >:
>
> > :D tnx )
> > Updated by my colleague already
> >
> > 2018-01-08 12:06 GMT+02:00 Daan Hoogland :
> >
> >> yeah, way ahead of you Igor ;) I asked a question about it
> >>
> >> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
> >> igor.voloshane...@gmail.com> wrote:
> >>
> >> > Updates posted to https://github.com/apache/cloudstack/pull/2389
> >> > Can you please review?
> >> >
> >> > 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
> >> igor.voloshane...@gmail.com
> >> > >:
> >> >
> >> > > Sure. Got it.
> >> > >
> >> > > Will post update soon
> >> > >
> >> > > 2018-01-08 11:38 GMT+02:00 Daan Hoogland :
> >> > >
> >> > >> Igor, I remember your PR and think it is fine. It can also be
> argued
> >> > that
> >> > >> it needs to go in as a security feature. For an RM it is
> unthinkably
> >> > late,
> >> > >> but fortunately it is very small. I will however -1 it if it leads
> >> to a
> >> > >> plethora of last minute PRs to include.
> >> > >>
> >> > >> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
> >> > >> igor.voloshane...@gmail.com> wrote:
> >> > >>
> >> > >> > Guys, can we please include https://github.com/apache/clou
> >> > >> dstack/pull/2389
> >> > >> > into 4.11
> >> > >> > PR very small and updates will be published in next few hours.
> >> > >> >
> >> > >> > As we have this for a while in production for 4.8 branch.
> >> > >> >
> >> > >> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov <
> >> > boris.stoya...@shapeblue.com
> >> > >> >:
> >> > >> >
> >> > >> > > +1 Daan
> >> > >> > >
> >> > >> > >
> >> > >> > > boris.stoya...@shapeblue.com
> >> > >> > > www.shapeblue.com
> >> > >> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> >> > >> > > @shapeblue
> >> > >> > >
> >> > >> > >
> >> > >> > >
> >> > >> > > > On 8 Jan 2018, at 10:47, Daan Hoogland <
> >> daan.hoogl...@gmail.com>
> >> > >> > wrote:
> >> > >> > > >
> >> > >> > > > Rohit, Ivan,
> >> > >> > > >
> >> > >> > > > I think we can argue that the five open PRs on the milestone
> >> can
> >> > >> still
> >> > >> > go
> >> > >> > > > in as long as active work on them continues. I have not
> looked
> >> at
> >> > >> > Ivan's
> >> > >> > > > PRs yet but can see they were entered in december and he is
> >> > actively
> >> > >> > > > working on it so why not include those in the milestone. A
> >> bigger
> >> > >> > concern
> >> > >> > > > is that some of the remaining PRs in that milestone are
> >> > potentially
> >> > >> > > > conflicting. So we feature freeze now and work only to get
> the
> >> set
> >> > >> list
> >> > >> > > in
> >> > >> > > > (and blockers).
> >> > >> > > >
> >> > >> > > >
> >> > >> > > > On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev <
> >> > >> > > kudryavtsev...@bw-sw.com>
> >> > >> > > > wrote:
> >> > >> > > >
> >> > >> > > >> Rohit, Devs,
> >> > >> > > >>
> >> > >> > > >> just consider adding:
> >> > >> > > >>
> >> > >> > > >> CLOUDSTACK-10188 / https://github.com/apache/
> >> > cloudstack/pull/2362
> >> > >> > > [resouce
> >> > >> > > >> accounting blocker bug]
> >> > >> > > >> CLOUDSTACK-10170 / https://github.com/apache/
> >> > cloudstack/pull/2350
> >> > >> > > >> [security
> >> > >> > > >> fix, enchancement]
> >> > >> > > >>
> >> > >> > > >> They are ready (we think so) for some time, but *no final
> >> review*
> >> > >> yet.
> >> > >> > > >>
> >> > >> > > >>
> >> > >> > > >> 2018-01-08 14:47 GMT+07:00 Rohit Yadav <
> >> > rohit.ya...@shapeblue.com
> >> > >> >:
> >> > >> > > >>
> >> > >> > > >>> All,
> >> > >> > > >>>
> >> > >> > > >>>
> >> > >> > > >>> As per the previously shared schedule [1], by EOD today (8
> >> Jan
> >> > >> 2018)
> >> > >> > we
> >> > >> > > >>> would freeze master after which we'll only accept
> >> > critical/blocker
> >> > >> > > fixes,
> >> > >> > > >>> stabilize master and start a voting thread on 4.11 RC1
> (est.
> >> by
> >> > 15
> >> > >> > Jan
> >> > >> > > >>> 2018).
> >> > >> > > >>>
> >> > >> > > >>>
> >> > >> > > >>> I wanted to gather consensus if this is acceptable to
> >> everyone
> >> > as
> >> > >> > there
> >> > >> > > >>> are still few outstanding feature PRs that I understand
> >> authors
> >> > >> have
> >> > >> > > >> worked
> >> > >> > > >>> hard to get them in.
> >> > >> > > >>>
> >> > >> > > >>>
> >> > >> > > >>> Please share your thoughts, comments.  If you're the author
> >> of
> >> > >> such
> >> > >> > an
> >> > >> > > >>> existing PR, please work with us, address outstanding
> issues.
> >> > >> > > >>>
> >> > >> > > >>>
> >> > >> > > >>> In case of no objections, it will be assumed that the plan
> is
> >> > >> > > acceptable
> >> > >> > > >>> to everyone. Thanks.
> >> > >> > > >>>
> >> > >> > > >>>
> >> > >> > > >>> [1]

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Voloshanenko Igor

You again faster than me )))

2018-01-08 12:21 GMT+02:00 Voloshanenko Igor :

> :D tnx )
> Updated by my colleague already
>
> 2018-01-08 12:06 GMT+02:00 Daan Hoogland :
>
>> yeah, way ahead of you Igor ;) I asked a question about it
>>
>> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
>> igor.voloshane...@gmail.com> wrote:
>>
>> > Updates posted to https://github.com/apache/cloudstack/pull/2389
>> > Can you please review?
>> >
>> > 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
>> igor.voloshane...@gmail.com
>> > >:
>> >
>> > > Sure. Got it.
>> > >
>> > > Will post update soon
>> > >
>> > > 2018-01-08 11:38 GMT+02:00 Daan Hoogland :
>> > >
>> > >> Igor, I remember your PR and think it is fine. It can also be argued
>> > that
>> > >> it needs to go in as a security feature. For an RM it is unthinkably
>> > late,
>> > >> but fortunately it is very small. I will however -1 it if it leads
>> to a
>> > >> plethora of last minute PRs to include.
>> > >>
>> > >> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
>> > >> igor.voloshane...@gmail.com> wrote:
>> > >>
>> > >> > Guys, can we please include https://github.com/apache/clou
>> > >> dstack/pull/2389
>> > >> > into 4.11
>> > >> > PR very small and updates will be published in next few hours.
>> > >> >
>> > >> > As we have this for a while in production for 4.8 branch.
>> > >> >
>> > >> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov <
>> > boris.stoya...@shapeblue.com
>> > >> >:
>> > >> >
>> > >> > > +1 Daan
>> > >> > >
>> > >> > >
>> > >> > > boris.stoya...@shapeblue.com
>> > >> > > www.shapeblue.com
>> > >> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> > >> > > @shapeblue
>> > >> > >
>> > >> > >
>> > >> > >
>> > >> > > > On 8 Jan 2018, at 10:47, Daan Hoogland <
>> daan.hoogl...@gmail.com>
>> > >> > wrote:
>> > >> > > >
>> > >> > > > Rohit, Ivan,
>> > >> > > >
>> > >> > > > I think we can argue that the five open PRs on the milestone
>> can
>> > >> still
>> > >> > go
>> > >> > > > in as long as active work on them continues. I have not looked
>> at
>> > >> > Ivan's
>> > >> > > > PRs yet but can see they were entered in december and he is
>> > actively
>> > >> > > > working on it so why not include those in the milestone. A
>> bigger
>> > >> > concern
>> > >> > > > is that some of the remaining PRs in that milestone are
>> > potentially
>> > >> > > > conflicting. So we feature freeze now and work only to get the
>> set
>> > >> list
>> > >> > > in
>> > >> > > > (and blockers).
>> > >> > > >
>> > >> > > >
>> > >> > > > On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev <
>> > >> > > kudryavtsev...@bw-sw.com>
>> > >> > > > wrote:
>> > >> > > >
>> > >> > > >> Rohit, Devs,
>> > >> > > >>
>> > >> > > >> just consider adding:
>> > >> > > >>
>> > >> > > >> CLOUDSTACK-10188 / https://github.com/apache/
>> > cloudstack/pull/2362
>> > >> > > [resouce
>> > >> > > >> accounting blocker bug]
>> > >> > > >> CLOUDSTACK-10170 / https://github.com/apache/
>> > cloudstack/pull/2350
>> > >> > > >> [security
>> > >> > > >> fix, enchancement]
>> > >> > > >>
>> > >> > > >> They are ready (we think so) for some time, but *no final
>> review*
>> > >> yet.
>> > >> > > >>
>> > >> > > >>
>> > >> > > >> 2018-01-08 14:47 GMT+07:00 Rohit Yadav <
>> > rohit.ya...@shapeblue.com
>> > >> >:
>> > >> > > >>
>> > >> > > >>> All,
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>> As per the previously shared schedule [1], by EOD today (8
>> Jan
>> > >> 2018)
>> > >> > we
>> > >> > > >>> would freeze master after which we'll only accept
>> > critical/blocker
>> > >> > > fixes,
>> > >> > > >>> stabilize master and start a voting thread on 4.11 RC1 (est.
>> by
>> > 15
>> > >> > Jan
>> > >> > > >>> 2018).
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>> I wanted to gather consensus if this is acceptable to
>> everyone
>> > as
>> > >> > there
>> > >> > > >>> are still few outstanding feature PRs that I understand
>> authors
>> > >> have
>> > >> > > >> worked
>> > >> > > >>> hard to get them in.
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>> Please share your thoughts, comments.  If you're the author
>> of
>> > >> such
>> > >> > an
>> > >> > > >>> existing PR, please work with us, address outstanding issues.
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>> In case of no objections, it will be assumed that the plan is
>> > >> > > acceptable
>> > >> > > >>> to everyone. Thanks.
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>> [1] http://markmail.org/message/mszlluye35acvn2j
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>> - Rohit
>> > >> > > >>>
>> > >> > > >>> 
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>> rohit.ya...@shapeblue.com
>> > >> > > >>> www.shapeblue.com
>> > >> > > >>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> > >> > > >>> @shapeblue
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>>
>> > >> > > >>
>> > >> > > >>
>> > >> > > >>

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Voloshanenko Igor

:D tnx )
Updated by my colleague already

2018-01-08 12:06 GMT+02:00 Daan Hoogland :

> yeah, way ahead of you Igor ;) I asked a question about it
>
> On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
> igor.voloshane...@gmail.com> wrote:
>
> > Updates posted to https://github.com/apache/cloudstack/pull/2389
> > Can you please review?
> >
> > 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor <
> igor.voloshane...@gmail.com
> > >:
> >
> > > Sure. Got it.
> > >
> > > Will post update soon
> > >
> > > 2018-01-08 11:38 GMT+02:00 Daan Hoogland :
> > >
> > >> Igor, I remember your PR and think it is fine. It can also be argued
> > that
> > >> it needs to go in as a security feature. For an RM it is unthinkably
> > late,
> > >> but fortunately it is very small. I will however -1 it if it leads to
> a
> > >> plethora of last minute PRs to include.
> > >>
> > >> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
> > >> igor.voloshane...@gmail.com> wrote:
> > >>
> > >> > Guys, can we please include https://github.com/apache/clou
> > >> dstack/pull/2389
> > >> > into 4.11
> > >> > PR very small and updates will be published in next few hours.
> > >> >
> > >> > As we have this for a while in production for 4.8 branch.
> > >> >
> > >> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov <
> > boris.stoya...@shapeblue.com
> > >> >:
> > >> >
> > >> > > +1 Daan
> > >> > >
> > >> > >
> > >> > > boris.stoya...@shapeblue.com
> > >> > > www.shapeblue.com
> > >> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > >> > > @shapeblue
> > >> > >
> > >> > >
> > >> > >
> > >> > > > On 8 Jan 2018, at 10:47, Daan Hoogland  >
> > >> > wrote:
> > >> > > >
> > >> > > > Rohit, Ivan,
> > >> > > >
> > >> > > > I think we can argue that the five open PRs on the milestone can
> > >> still
> > >> > go
> > >> > > > in as long as active work on them continues. I have not looked
> at
> > >> > Ivan's
> > >> > > > PRs yet but can see they were entered in december and he is
> > actively
> > >> > > > working on it so why not include those in the milestone. A
> bigger
> > >> > concern
> > >> > > > is that some of the remaining PRs in that milestone are
> > potentially
> > >> > > > conflicting. So we feature freeze now and work only to get the
> set
> > >> list
> > >> > > in
> > >> > > > (and blockers).
> > >> > > >
> > >> > > >
> > >> > > > On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev <
> > >> > > kudryavtsev...@bw-sw.com>
> > >> > > > wrote:
> > >> > > >
> > >> > > >> Rohit, Devs,
> > >> > > >>
> > >> > > >> just consider adding:
> > >> > > >>
> > >> > > >> CLOUDSTACK-10188 / https://github.com/apache/
> > cloudstack/pull/2362
> > >> > > [resouce
> > >> > > >> accounting blocker bug]
> > >> > > >> CLOUDSTACK-10170 / https://github.com/apache/
> > cloudstack/pull/2350
> > >> > > >> [security
> > >> > > >> fix, enchancement]
> > >> > > >>
> > >> > > >> They are ready (we think so) for some time, but *no final
> review*
> > >> yet.
> > >> > > >>
> > >> > > >>
> > >> > > >> 2018-01-08 14:47 GMT+07:00 Rohit Yadav <
> > rohit.ya...@shapeblue.com
> > >> >:
> > >> > > >>
> > >> > > >>> All,
> > >> > > >>>
> > >> > > >>>
> > >> > > >>> As per the previously shared schedule [1], by EOD today (8 Jan
> > >> 2018)
> > >> > we
> > >> > > >>> would freeze master after which we'll only accept
> > critical/blocker
> > >> > > fixes,
> > >> > > >>> stabilize master and start a voting thread on 4.11 RC1 (est.
> by
> > 15
> > >> > Jan
> > >> > > >>> 2018).
> > >> > > >>>
> > >> > > >>>
> > >> > > >>> I wanted to gather consensus if this is acceptable to everyone
> > as
> > >> > there
> > >> > > >>> are still few outstanding feature PRs that I understand
> authors
> > >> have
> > >> > > >> worked
> > >> > > >>> hard to get them in.
> > >> > > >>>
> > >> > > >>>
> > >> > > >>> Please share your thoughts, comments.  If you're the author of
> > >> such
> > >> > an
> > >> > > >>> existing PR, please work with us, address outstanding issues.
> > >> > > >>>
> > >> > > >>>
> > >> > > >>> In case of no objections, it will be assumed that the plan is
> > >> > > acceptable
> > >> > > >>> to everyone. Thanks.
> > >> > > >>>
> > >> > > >>>
> > >> > > >>> [1] http://markmail.org/message/mszlluye35acvn2j
> > >> > > >>>
> > >> > > >>>
> > >> > > >>> - Rohit
> > >> > > >>>
> > >> > > >>> 
> > >> > > >>>
> > >> > > >>>
> > >> > > >>>
> > >> > > >>> rohit.ya...@shapeblue.com
> > >> > > >>> www.shapeblue.com
> > >> > > >>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > >> > > >>> @shapeblue
> > >> > > >>>
> > >> > > >>>
> > >> > > >>>
> > >> > > >>>
> > >> > > >>
> > >> > > >>
> > >> > > >> --
> > >> > > >> With best regards, Ivan Kudryavtsev
> > >> > > >> Bitworks Software, Ltd.
> > >> > > >> Cell: +7-923-414-1515
> > >> > > >> WWW: http://bitworks.software/ 
> > >> > > >>
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > --
> > >> > > > Daan
> > >> >

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Daan Hoogland

yeah, way ahead of you Igor ;) I asked a question about it

On Mon, Jan 8, 2018 at 11:05 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:

> Updates posted to https://github.com/apache/cloudstack/pull/2389
> Can you please review?
>
> 2018-01-08 11:57 GMT+02:00 Voloshanenko Igor  >:
>
> > Sure. Got it.
> >
> > Will post update soon
> >
> > 2018-01-08 11:38 GMT+02:00 Daan Hoogland :
> >
> >> Igor, I remember your PR and think it is fine. It can also be argued
> that
> >> it needs to go in as a security feature. For an RM it is unthinkably
> late,
> >> but fortunately it is very small. I will however -1 it if it leads to a
> >> plethora of last minute PRs to include.
> >>
> >> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
> >> igor.voloshane...@gmail.com> wrote:
> >>
> >> > Guys, can we please include https://github.com/apache/clou
> >> dstack/pull/2389
> >> > into 4.11
> >> > PR very small and updates will be published in next few hours.
> >> >
> >> > As we have this for a while in production for 4.8 branch.
> >> >
> >> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov <
> boris.stoya...@shapeblue.com
> >> >:
> >> >
> >> > > +1 Daan
> >> > >
> >> > >
> >> > > boris.stoya...@shapeblue.com
> >> > > www.shapeblue.com
> >> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> >> > > @shapeblue
> >> > >
> >> > >
> >> > >
> >> > > > On 8 Jan 2018, at 10:47, Daan Hoogland 
> >> > wrote:
> >> > > >
> >> > > > Rohit, Ivan,
> >> > > >
> >> > > > I think we can argue that the five open PRs on the milestone can
> >> still
> >> > go
> >> > > > in as long as active work on them continues. I have not looked at
> >> > Ivan's
> >> > > > PRs yet but can see they were entered in december and he is
> actively
> >> > > > working on it so why not include those in the milestone. A bigger
> >> > concern
> >> > > > is that some of the remaining PRs in that milestone are
> potentially
> >> > > > conflicting. So we feature freeze now and work only to get the set
> >> list
> >> > > in
> >> > > > (and blockers).
> >> > > >
> >> > > >
> >> > > > On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev <
> >> > > kudryavtsev...@bw-sw.com>
> >> > > > wrote:
> >> > > >
> >> > > >> Rohit, Devs,
> >> > > >>
> >> > > >> just consider adding:
> >> > > >>
> >> > > >> CLOUDSTACK-10188 / https://github.com/apache/
> cloudstack/pull/2362
> >> > > [resouce
> >> > > >> accounting blocker bug]
> >> > > >> CLOUDSTACK-10170 / https://github.com/apache/
> cloudstack/pull/2350
> >> > > >> [security
> >> > > >> fix, enchancement]
> >> > > >>
> >> > > >> They are ready (we think so) for some time, but *no final review*
> >> yet.
> >> > > >>
> >> > > >>
> >> > > >> 2018-01-08 14:47 GMT+07:00 Rohit Yadav <
> rohit.ya...@shapeblue.com
> >> >:
> >> > > >>
> >> > > >>> All,
> >> > > >>>
> >> > > >>>
> >> > > >>> As per the previously shared schedule [1], by EOD today (8 Jan
> >> 2018)
> >> > we
> >> > > >>> would freeze master after which we'll only accept
> critical/blocker
> >> > > fixes,
> >> > > >>> stabilize master and start a voting thread on 4.11 RC1 (est. by
> 15
> >> > Jan
> >> > > >>> 2018).
> >> > > >>>
> >> > > >>>
> >> > > >>> I wanted to gather consensus if this is acceptable to everyone
> as
> >> > there
> >> > > >>> are still few outstanding feature PRs that I understand authors
> >> have
> >> > > >> worked
> >> > > >>> hard to get them in.
> >> > > >>>
> >> > > >>>
> >> > > >>> Please share your thoughts, comments.  If you're the author of
> >> such
> >> > an
> >> > > >>> existing PR, please work with us, address outstanding issues.
> >> > > >>>
> >> > > >>>
> >> > > >>> In case of no objections, it will be assumed that the plan is
> >> > > acceptable
> >> > > >>> to everyone. Thanks.
> >> > > >>>
> >> > > >>>
> >> > > >>> [1] http://markmail.org/message/mszlluye35acvn2j
> >> > > >>>
> >> > > >>>
> >> > > >>> - Rohit
> >> > > >>>
> >> > > >>> 
> >> > > >>>
> >> > > >>>
> >> > > >>>
> >> > > >>> rohit.ya...@shapeblue.com
> >> > > >>> www.shapeblue.com
> >> > > >>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> >> > > >>> @shapeblue
> >> > > >>>
> >> > > >>>
> >> > > >>>
> >> > > >>>
> >> > > >>
> >> > > >>
> >> > > >> --
> >> > > >> With best regards, Ivan Kudryavtsev
> >> > > >> Bitworks Software, Ltd.
> >> > > >> Cell: +7-923-414-1515
> >> > > >> WWW: http://bitworks.software/ 
> >> > > >>
> >> > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > > Daan
> >> > >
> >> > >
> >> >
> >>
> >>
> >>
> >> --
> >> Daan
> >>
> >
> >
>



-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Voloshanenko Igor

Updates posted to https://github.com/apache/cloudstack/pull/2389
Can you please review?

2018-01-08 11:57 GMT+02:00 Voloshanenko Igor :

> Sure. Got it.
>
> Will post update soon
>
> 2018-01-08 11:38 GMT+02:00 Daan Hoogland :
>
>> Igor, I remember your PR and think it is fine. It can also be argued that
>> it needs to go in as a security feature. For an RM it is unthinkably late,
>> but fortunately it is very small. I will however -1 it if it leads to a
>> plethora of last minute PRs to include.
>>
>> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
>> igor.voloshane...@gmail.com> wrote:
>>
>> > Guys, can we please include https://github.com/apache/clou
>> dstack/pull/2389
>> > into 4.11
>> > PR very small and updates will be published in next few hours.
>> >
>> > As we have this for a while in production for 4.8 branch.
>> >
>> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov > >:
>> >
>> > > +1 Daan
>> > >
>> > >
>> > > boris.stoya...@shapeblue.com
>> > > www.shapeblue.com
>> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> > > @shapeblue
>> > >
>> > >
>> > >
>> > > > On 8 Jan 2018, at 10:47, Daan Hoogland 
>> > wrote:
>> > > >
>> > > > Rohit, Ivan,
>> > > >
>> > > > I think we can argue that the five open PRs on the milestone can
>> still
>> > go
>> > > > in as long as active work on them continues. I have not looked at
>> > Ivan's
>> > > > PRs yet but can see they were entered in december and he is actively
>> > > > working on it so why not include those in the milestone. A bigger
>> > concern
>> > > > is that some of the remaining PRs in that milestone are potentially
>> > > > conflicting. So we feature freeze now and work only to get the set
>> list
>> > > in
>> > > > (and blockers).
>> > > >
>> > > >
>> > > > On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev <
>> > > kudryavtsev...@bw-sw.com>
>> > > > wrote:
>> > > >
>> > > >> Rohit, Devs,
>> > > >>
>> > > >> just consider adding:
>> > > >>
>> > > >> CLOUDSTACK-10188 / https://github.com/apache/cloudstack/pull/2362
>> > > [resouce
>> > > >> accounting blocker bug]
>> > > >> CLOUDSTACK-10170 / https://github.com/apache/cloudstack/pull/2350
>> > > >> [security
>> > > >> fix, enchancement]
>> > > >>
>> > > >> They are ready (we think so) for some time, but *no final review*
>> yet.
>> > > >>
>> > > >>
>> > > >> 2018-01-08 14:47 GMT+07:00 Rohit Yadav > >:
>> > > >>
>> > > >>> All,
>> > > >>>
>> > > >>>
>> > > >>> As per the previously shared schedule [1], by EOD today (8 Jan
>> 2018)
>> > we
>> > > >>> would freeze master after which we'll only accept critical/blocker
>> > > fixes,
>> > > >>> stabilize master and start a voting thread on 4.11 RC1 (est. by 15
>> > Jan
>> > > >>> 2018).
>> > > >>>
>> > > >>>
>> > > >>> I wanted to gather consensus if this is acceptable to everyone as
>> > there
>> > > >>> are still few outstanding feature PRs that I understand authors
>> have
>> > > >> worked
>> > > >>> hard to get them in.
>> > > >>>
>> > > >>>
>> > > >>> Please share your thoughts, comments.  If you're the author of
>> such
>> > an
>> > > >>> existing PR, please work with us, address outstanding issues.
>> > > >>>
>> > > >>>
>> > > >>> In case of no objections, it will be assumed that the plan is
>> > > acceptable
>> > > >>> to everyone. Thanks.
>> > > >>>
>> > > >>>
>> > > >>> [1] http://markmail.org/message/mszlluye35acvn2j
>> > > >>>
>> > > >>>
>> > > >>> - Rohit
>> > > >>>
>> > > >>> 
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>> rohit.ya...@shapeblue.com
>> > > >>> www.shapeblue.com
>> > > >>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>> > > >>> @shapeblue
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>
>> > > >>
>> > > >> --
>> > > >> With best regards, Ivan Kudryavtsev
>> > > >> Bitworks Software, Ltd.
>> > > >> Cell: +7-923-414-1515
>> > > >> WWW: http://bitworks.software/ 
>> > > >>
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Daan
>> > >
>> > >
>> >
>>
>>
>>
>> --
>> Daan
>>
>
>

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Kris Sterckx

Hi Rohit

+1

We will work hard to address recent comments posted to
https://github.com/apache/cloudstack/pull/2097  for generalized Config
Drive support and hope to get that into 4.11 !

Kris


On 8 January 2018 at 08:47, Rohit Yadav  wrote:

> All,
>
>
> As per the previously shared schedule [1], by EOD today (8 Jan 2018) we
> would freeze master after which we'll only accept critical/blocker fixes,
> stabilize master and start a voting thread on 4.11 RC1 (est. by 15 Jan
> 2018).
>
>
> I wanted to gather consensus if this is acceptable to everyone as there
> are still few outstanding feature PRs that I understand authors have worked
> hard to get them in.
>
>
> Please share your thoughts, comments.  If you're the author of such an
> existing PR, please work with us, address outstanding issues.
>
>
> In case of no objections, it will be assumed that the plan is acceptable
> to everyone. Thanks.
>
>
> [1] http://markmail.org/message/mszlluye35acvn2j
>
>
> - Rohit
>
> 
>
>
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Wido den Hollander




On 01/08/2018 09:47 AM, Daan Hoogland wrote:

Rohit, Ivan,

I think we can argue that the five open PRs on the milestone can still go
in as long as active work on them continues. I have not looked at Ivan's
PRs yet but can see they were entered in december and he is actively
working on it so why not include those in the milestone. A bigger concern
is that some of the remaining PRs in that milestone are potentially
conflicting. So we feature freeze now and work only to get the set list in
(and blockers).



Seems like a sane thing! Let's do that and only merge fixes afterwards.

Wido



On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev 
wrote:


Rohit, Devs,

just consider adding:

CLOUDSTACK-10188 / https://github.com/apache/cloudstack/pull/2362 [resouce
accounting blocker bug]
CLOUDSTACK-10170 / https://github.com/apache/cloudstack/pull/2350
[security
fix, enchancement]

They are ready (we think so) for some time, but *no final review* yet.


2018-01-08 14:47 GMT+07:00 Rohit Yadav :


All,


As per the previously shared schedule [1], by EOD today (8 Jan 2018) we
would freeze master after which we'll only accept critical/blocker fixes,
stabilize master and start a voting thread on 4.11 RC1 (est. by 15 Jan
2018).


I wanted to gather consensus if this is acceptable to everyone as there
are still few outstanding feature PRs that I understand authors have

worked

hard to get them in.


Please share your thoughts, comments.  If you're the author of such an
existing PR, please work with us, address outstanding issues.


In case of no objections, it will be assumed that the plan is acceptable
to everyone. Thanks.


[1] http://markmail.org/message/mszlluye35acvn2j


- Rohit





rohit.ya...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue







--
With best regards, Ivan Kudryavtsev
Bitworks Software, Ltd.
Cell: +7-923-414-1515
WWW: http://bitworks.software/

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Voloshanenko Igor

Sure. Got it.

Will post update soon

2018-01-08 11:38 GMT+02:00 Daan Hoogland :

> Igor, I remember your PR and think it is fine. It can also be argued that
> it needs to go in as a security feature. For an RM it is unthinkably late,
> but fortunately it is very small. I will however -1 it if it leads to a
> plethora of last minute PRs to include.
>
> On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
> igor.voloshane...@gmail.com> wrote:
>
> > Guys, can we please include https://github.com/apache/
> cloudstack/pull/2389
> > into 4.11
> > PR very small and updates will be published in next few hours.
> >
> > As we have this for a while in production for 4.8 branch.
> >
> > 2018-01-08 11:15 GMT+02:00 Boris Stoyanov 
> :
> >
> > > +1 Daan
> > >
> > >
> > > boris.stoya...@shapeblue.com
> > > www.shapeblue.com
> > > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > @shapeblue
> > >
> > >
> > >
> > > > On 8 Jan 2018, at 10:47, Daan Hoogland 
> > wrote:
> > > >
> > > > Rohit, Ivan,
> > > >
> > > > I think we can argue that the five open PRs on the milestone can
> still
> > go
> > > > in as long as active work on them continues. I have not looked at
> > Ivan's
> > > > PRs yet but can see they were entered in december and he is actively
> > > > working on it so why not include those in the milestone. A bigger
> > concern
> > > > is that some of the remaining PRs in that milestone are potentially
> > > > conflicting. So we feature freeze now and work only to get the set
> list
> > > in
> > > > (and blockers).
> > > >
> > > >
> > > > On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev <
> > > kudryavtsev...@bw-sw.com>
> > > > wrote:
> > > >
> > > >> Rohit, Devs,
> > > >>
> > > >> just consider adding:
> > > >>
> > > >> CLOUDSTACK-10188 / https://github.com/apache/cloudstack/pull/2362
> > > [resouce
> > > >> accounting blocker bug]
> > > >> CLOUDSTACK-10170 / https://github.com/apache/cloudstack/pull/2350
> > > >> [security
> > > >> fix, enchancement]
> > > >>
> > > >> They are ready (we think so) for some time, but *no final review*
> yet.
> > > >>
> > > >>
> > > >> 2018-01-08 14:47 GMT+07:00 Rohit Yadav :
> > > >>
> > > >>> All,
> > > >>>
> > > >>>
> > > >>> As per the previously shared schedule [1], by EOD today (8 Jan
> 2018)
> > we
> > > >>> would freeze master after which we'll only accept critical/blocker
> > > fixes,
> > > >>> stabilize master and start a voting thread on 4.11 RC1 (est. by 15
> > Jan
> > > >>> 2018).
> > > >>>
> > > >>>
> > > >>> I wanted to gather consensus if this is acceptable to everyone as
> > there
> > > >>> are still few outstanding feature PRs that I understand authors
> have
> > > >> worked
> > > >>> hard to get them in.
> > > >>>
> > > >>>
> > > >>> Please share your thoughts, comments.  If you're the author of such
> > an
> > > >>> existing PR, please work with us, address outstanding issues.
> > > >>>
> > > >>>
> > > >>> In case of no objections, it will be assumed that the plan is
> > > acceptable
> > > >>> to everyone. Thanks.
> > > >>>
> > > >>>
> > > >>> [1] http://markmail.org/message/mszlluye35acvn2j
> > > >>>
> > > >>>
> > > >>> - Rohit
> > > >>>
> > > >>> 
> > > >>>
> > > >>>
> > > >>>
> > > >>> rohit.ya...@shapeblue.com
> > > >>> www.shapeblue.com
> > > >>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > > >>> @shapeblue
> > > >>>
> > > >>>
> > > >>>
> > > >>>
> > > >>
> > > >>
> > > >> --
> > > >> With best regards, Ivan Kudryavtsev
> > > >> Bitworks Software, Ltd.
> > > >> Cell: +7-923-414-1515
> > > >> WWW: http://bitworks.software/ 
> > > >>
> > > >
> > > >
> > > >
> > > > --
> > > > Daan
> > >
> > >
> >
>
>
>
> --
> Daan
>

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Rene Moser

On 01/08/2018 09:47 AM, Daan Hoogland wrote:
> Rohit, Ivan,
> 
> I think we can argue that the five open PRs on the milestone can still go
> in as long as active work on them continues. I have not looked at Ivan's
> PRs yet but can see they were entered in december and he is actively
> working on it so why not include those in the milestone. A bigger concern
> is that some of the remaining PRs in that milestone are potentially
> conflicting. So we feature freeze now and work only to get the set list in
> (and blockers).

+1 Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Daan Hoogland

Igor, I remember your PR and think it is fine. It can also be argued that
it needs to go in as a security feature. For an RM it is unthinkably late,
but fortunately it is very small. I will however -1 it if it leads to a
plethora of last minute PRs to include.

On Mon, Jan 8, 2018 at 10:33 AM, Voloshanenko Igor <
igor.voloshane...@gmail.com> wrote:

> Guys, can we please include https://github.com/apache/cloudstack/pull/2389
> into 4.11
> PR very small and updates will be published in next few hours.
>
> As we have this for a while in production for 4.8 branch.
>
> 2018-01-08 11:15 GMT+02:00 Boris Stoyanov :
>
> > +1 Daan
> >
> >
> > boris.stoya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> > > On 8 Jan 2018, at 10:47, Daan Hoogland 
> wrote:
> > >
> > > Rohit, Ivan,
> > >
> > > I think we can argue that the five open PRs on the milestone can still
> go
> > > in as long as active work on them continues. I have not looked at
> Ivan's
> > > PRs yet but can see they were entered in december and he is actively
> > > working on it so why not include those in the milestone. A bigger
> concern
> > > is that some of the remaining PRs in that milestone are potentially
> > > conflicting. So we feature freeze now and work only to get the set list
> > in
> > > (and blockers).
> > >
> > >
> > > On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev <
> > kudryavtsev...@bw-sw.com>
> > > wrote:
> > >
> > >> Rohit, Devs,
> > >>
> > >> just consider adding:
> > >>
> > >> CLOUDSTACK-10188 / https://github.com/apache/cloudstack/pull/2362
> > [resouce
> > >> accounting blocker bug]
> > >> CLOUDSTACK-10170 / https://github.com/apache/cloudstack/pull/2350
> > >> [security
> > >> fix, enchancement]
> > >>
> > >> They are ready (we think so) for some time, but *no final review* yet.
> > >>
> > >>
> > >> 2018-01-08 14:47 GMT+07:00 Rohit Yadav :
> > >>
> > >>> All,
> > >>>
> > >>>
> > >>> As per the previously shared schedule [1], by EOD today (8 Jan 2018)
> we
> > >>> would freeze master after which we'll only accept critical/blocker
> > fixes,
> > >>> stabilize master and start a voting thread on 4.11 RC1 (est. by 15
> Jan
> > >>> 2018).
> > >>>
> > >>>
> > >>> I wanted to gather consensus if this is acceptable to everyone as
> there
> > >>> are still few outstanding feature PRs that I understand authors have
> > >> worked
> > >>> hard to get them in.
> > >>>
> > >>>
> > >>> Please share your thoughts, comments.  If you're the author of such
> an
> > >>> existing PR, please work with us, address outstanding issues.
> > >>>
> > >>>
> > >>> In case of no objections, it will be assumed that the plan is
> > acceptable
> > >>> to everyone. Thanks.
> > >>>
> > >>>
> > >>> [1] http://markmail.org/message/mszlluye35acvn2j
> > >>>
> > >>>
> > >>> - Rohit
> > >>>
> > >>> 
> > >>>
> > >>>
> > >>>
> > >>> rohit.ya...@shapeblue.com
> > >>> www.shapeblue.com
> > >>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > >>> @shapeblue
> > >>>
> > >>>
> > >>>
> > >>>
> > >>
> > >>
> > >> --
> > >> With best regards, Ivan Kudryavtsev
> > >> Bitworks Software, Ltd.
> > >> Cell: +7-923-414-1515
> > >> WWW: http://bitworks.software/ 
> > >>
> > >
> > >
> > >
> > > --
> > > Daan
> >
> >
>



-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Voloshanenko Igor

Guys, can we please include https://github.com/apache/cloudstack/pull/2389
into 4.11
PR very small and updates will be published in next few hours.

As we have this for a while in production for 4.8 branch.

2018-01-08 11:15 GMT+02:00 Boris Stoyanov :

> +1 Daan
>
>
> boris.stoya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
> > On 8 Jan 2018, at 10:47, Daan Hoogland  wrote:
> >
> > Rohit, Ivan,
> >
> > I think we can argue that the five open PRs on the milestone can still go
> > in as long as active work on them continues. I have not looked at Ivan's
> > PRs yet but can see they were entered in december and he is actively
> > working on it so why not include those in the milestone. A bigger concern
> > is that some of the remaining PRs in that milestone are potentially
> > conflicting. So we feature freeze now and work only to get the set list
> in
> > (and blockers).
> >
> >
> > On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev <
> kudryavtsev...@bw-sw.com>
> > wrote:
> >
> >> Rohit, Devs,
> >>
> >> just consider adding:
> >>
> >> CLOUDSTACK-10188 / https://github.com/apache/cloudstack/pull/2362
> [resouce
> >> accounting blocker bug]
> >> CLOUDSTACK-10170 / https://github.com/apache/cloudstack/pull/2350
> >> [security
> >> fix, enchancement]
> >>
> >> They are ready (we think so) for some time, but *no final review* yet.
> >>
> >>
> >> 2018-01-08 14:47 GMT+07:00 Rohit Yadav :
> >>
> >>> All,
> >>>
> >>>
> >>> As per the previously shared schedule [1], by EOD today (8 Jan 2018) we
> >>> would freeze master after which we'll only accept critical/blocker
> fixes,
> >>> stabilize master and start a voting thread on 4.11 RC1 (est. by 15 Jan
> >>> 2018).
> >>>
> >>>
> >>> I wanted to gather consensus if this is acceptable to everyone as there
> >>> are still few outstanding feature PRs that I understand authors have
> >> worked
> >>> hard to get them in.
> >>>
> >>>
> >>> Please share your thoughts, comments.  If you're the author of such an
> >>> existing PR, please work with us, address outstanding issues.
> >>>
> >>>
> >>> In case of no objections, it will be assumed that the plan is
> acceptable
> >>> to everyone. Thanks.
> >>>
> >>>
> >>> [1] http://markmail.org/message/mszlluye35acvn2j
> >>>
> >>>
> >>> - Rohit
> >>>
> >>> 
> >>>
> >>>
> >>>
> >>> rohit.ya...@shapeblue.com
> >>> www.shapeblue.com
> >>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> >>> @shapeblue
> >>>
> >>>
> >>>
> >>>
> >>
> >>
> >> --
> >> With best regards, Ivan Kudryavtsev
> >> Bitworks Software, Ltd.
> >> Cell: +7-923-414-1515
> >> WWW: http://bitworks.software/ 
> >>
> >
> >
> >
> > --
> > Daan
>
>

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Boris Stoyanov

+1 Daan


boris.stoya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

> On 8 Jan 2018, at 10:47, Daan Hoogland  wrote:
> 
> Rohit, Ivan,
> 
> I think we can argue that the five open PRs on the milestone can still go
> in as long as active work on them continues. I have not looked at Ivan's
> PRs yet but can see they were entered in december and he is actively
> working on it so why not include those in the milestone. A bigger concern
> is that some of the remaining PRs in that milestone are potentially
> conflicting. So we feature freeze now and work only to get the set list in
> (and blockers).
> 
> 
> On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev 
> wrote:
> 
>> Rohit, Devs,
>> 
>> just consider adding:
>> 
>> CLOUDSTACK-10188 / https://github.com/apache/cloudstack/pull/2362 [resouce
>> accounting blocker bug]
>> CLOUDSTACK-10170 / https://github.com/apache/cloudstack/pull/2350
>> [security
>> fix, enchancement]
>> 
>> They are ready (we think so) for some time, but *no final review* yet.
>> 
>> 
>> 2018-01-08 14:47 GMT+07:00 Rohit Yadav :
>> 
>>> All,
>>> 
>>> 
>>> As per the previously shared schedule [1], by EOD today (8 Jan 2018) we
>>> would freeze master after which we'll only accept critical/blocker fixes,
>>> stabilize master and start a voting thread on 4.11 RC1 (est. by 15 Jan
>>> 2018).
>>> 
>>> 
>>> I wanted to gather consensus if this is acceptable to everyone as there
>>> are still few outstanding feature PRs that I understand authors have
>> worked
>>> hard to get them in.
>>> 
>>> 
>>> Please share your thoughts, comments.  If you're the author of such an
>>> existing PR, please work with us, address outstanding issues.
>>> 
>>> 
>>> In case of no objections, it will be assumed that the plan is acceptable
>>> to everyone. Thanks.
>>> 
>>> 
>>> [1] http://markmail.org/message/mszlluye35acvn2j
>>> 
>>> 
>>> - Rohit
>>> 
>>> 
>>> 
>>> 
>>> 
>>> rohit.ya...@shapeblue.com
>>> www.shapeblue.com
>>> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
>>> @shapeblue
>>> 
>>> 
>>> 
>>> 
>> 
>> 
>> --
>> With best regards, Ivan Kudryavtsev
>> Bitworks Software, Ltd.
>> Cell: +7-923-414-1515
>> WWW: http://bitworks.software/ 
>> 
> 
> 
> 
> -- 
> Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Daan Hoogland

Rohit, Ivan,

I think we can argue that the five open PRs on the milestone can still go
in as long as active work on them continues. I have not looked at Ivan's
PRs yet but can see they were entered in december and he is actively
working on it so why not include those in the milestone. A bigger concern
is that some of the remaining PRs in that milestone are potentially
conflicting. So we feature freeze now and work only to get the set list in
(and blockers).


On Mon, Jan 8, 2018 at 9:39 AM, Ivan Kudryavtsev 
wrote:

> Rohit, Devs,
>
> just consider adding:
>
> CLOUDSTACK-10188 / https://github.com/apache/cloudstack/pull/2362 [resouce
> accounting blocker bug]
> CLOUDSTACK-10170 / https://github.com/apache/cloudstack/pull/2350
> [security
> fix, enchancement]
>
> They are ready (we think so) for some time, but *no final review* yet.
>
>
> 2018-01-08 14:47 GMT+07:00 Rohit Yadav :
>
> > All,
> >
> >
> > As per the previously shared schedule [1], by EOD today (8 Jan 2018) we
> > would freeze master after which we'll only accept critical/blocker fixes,
> > stabilize master and start a voting thread on 4.11 RC1 (est. by 15 Jan
> > 2018).
> >
> >
> > I wanted to gather consensus if this is acceptable to everyone as there
> > are still few outstanding feature PRs that I understand authors have
> worked
> > hard to get them in.
> >
> >
> > Please share your thoughts, comments.  If you're the author of such an
> > existing PR, please work with us, address outstanding issues.
> >
> >
> > In case of no objections, it will be assumed that the plan is acceptable
> > to everyone. Thanks.
> >
> >
> > [1] http://markmail.org/message/mszlluye35acvn2j
> >
> >
> > - Rohit
> >
> > 
> >
> >
> >
> > rohit.ya...@shapeblue.com
> > www.shapeblue.com
> > 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> > @shapeblue
> >
> >
> >
> >
>
>
> --
> With best regards, Ivan Kudryavtsev
> Bitworks Software, Ltd.
> Cell: +7-923-414-1515
> WWW: http://bitworks.software/ 
>



-- 
Daan

Re: [DISCUSS] Freezing master for 4.11

2018-01-08 Thread Ivan Kudryavtsev

Rohit, Devs,

just consider adding:

CLOUDSTACK-10188 / https://github.com/apache/cloudstack/pull/2362 [resouce
accounting blocker bug]
CLOUDSTACK-10170 / https://github.com/apache/cloudstack/pull/2350 [security
fix, enchancement]

They are ready (we think so) for some time, but *no final review* yet.


2018-01-08 14:47 GMT+07:00 Rohit Yadav :

> All,
>
>
> As per the previously shared schedule [1], by EOD today (8 Jan 2018) we
> would freeze master after which we'll only accept critical/blocker fixes,
> stabilize master and start a voting thread on 4.11 RC1 (est. by 15 Jan
> 2018).
>
>
> I wanted to gather consensus if this is acceptable to everyone as there
> are still few outstanding feature PRs that I understand authors have worked
> hard to get them in.
>
>
> Please share your thoughts, comments.  If you're the author of such an
> existing PR, please work with us, address outstanding issues.
>
>
> In case of no objections, it will be assumed that the plan is acceptable
> to everyone. Thanks.
>
>
> [1] http://markmail.org/message/mszlluye35acvn2j
>
>
> - Rohit
>
> 
>
>
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>
>


-- 
With best regards, Ivan Kudryavtsev
Bitworks Software, Ltd.
Cell: +7-923-414-1515
WWW: http://bitworks.software/

[DISCUSS] Freezing master for 4.11

2018-01-07 Thread Rohit Yadav

All,


As per the previously shared schedule [1], by EOD today (8 Jan 2018) we would 
freeze master after which we'll only accept critical/blocker fixes, stabilize 
master and start a voting thread on 4.11 RC1 (est. by 15 Jan 2018).


I wanted to gather consensus if this is acceptable to everyone as there are 
still few outstanding feature PRs that I understand authors have worked hard to 
get them in.


Please share your thoughts, comments.  If you're the author of such an existing 
PR, please work with us, address outstanding issues.


In case of no objections, it will be assumed that the plan is acceptable to 
everyone. Thanks.


[1] http://markmail.org/message/mszlluye35acvn2j


- Rohit





rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

45 matches

Mail list logo