Re: [VOTE] Apache CXF 3.2.6
+1 (binding) Christian Am Do., 9. Aug. 2018 um 01:15 Uhr schrieb Daniel Kulp : > This is a vote to release CXF 3.2.6. > > > Staging repo: > https://repository.apache.org/content/repositories/orgapachecxf-1120/ < > https://repository.apache.org/content/repositories/orgapachecxf-1120/> > > > Tag: > > https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=f0b4f939f81894c9943c24ea6891c7fa08df00a6 > < > https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h=f0b4f939f81894c9943c24ea6891c7fa08df00a6 > > > > > Here is my +1 > > > -- > Daniel Kulp > dk...@apache.org <mailto:dk...@apache.org> - http://dankulp.com/blog < > http://dankulp.com/blog> > Talend Community Coder - http://talend.com <http://coders.talend.com/> > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
Re: Help wanted please :-)
I see the same problem. It also happens for other builds outside CXF. Can you open an INFRA issue? Christian Am So., 8. Juli 2018 um 00:37 Uhr schrieb Andriy Redko : > Hey guys, > > I would really appreciate if someone could help. I have created the > Jenkins build for 3.2.x (https://builds.apache.org/job/CXF-3.2.x) out of > the CXF-Trunk-JDK18. For some reasons, the configuration page ( > https://builds.apache.org/job/CXF-3.2.x/configure) never loads for me, > always stuck in "Loading" spinner (tried it many times during the day), so > I cannot change the branch to */3.2.x-fixes for this job. Anyone would be > able to help me there (or hint the workaround)? Thanks! > > Best Regards, > Andriy Redko > > > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
Re: A few 'Feature' questions
It does not work automagically. You still have to add the logging feature to your service. Christan 2018-04-28 21:39 GMT+02:00 Mark Struberg <strub...@yahoo.de.invalid>: > Hi Christian! > > > ( I hope you are talking about the new logging feature described here: > > http://cxf.apache.org/docs/message-logging.html). > > Yes. I actually tried that but failed. Probably I missed something. > > Should this work like a plugin? Means, should it simply work out of the > box if I just drop it into the classpath? > Because I tried that and it didn't work... > > Note that I'm using CXF as part of Apache Meecrowave. So not with Spring > but with Apache OpenWebBeans as CDI container. > > txs and LieGrue, > strub > > > Am 27.04.2018 um 09:10 schrieb Christian Schneider < > ch...@die-schneider.net>: > > > > I think your case is valid in general. > > > > What I do not understand is why you do not install the logging feature in > > production > > ( I hope you are talking about the new logging feature described here: > > http://cxf.apache.org/docs/message-logging.html). > > > > The feature is designed to be added to all services and then be enabled / > > disabled via the logging configuration. So it should have almost no > > performance impact > > when switched off). I think it is very important to be able to enable > > logging while in production if it is needed and you typically do not know > > if it is needed at build time. > > > > Christian > > > > > > 2018-04-27 8:36 GMT+02:00 Mark Struberg <strub...@yahoo.de.invalid>: > > > >> Sure, here is my use case: > >> > >> We want to make use of the LoggingFeature, but would love to completely > >> disable it in production. So we don't even want to enable the Feature > >> depending on a configuration setting. > >> That means we also cannot use the @Feature annotation but need to apply > it > >> programmatically. > >> > >> I know that I can enable a Feature programmatically via the Bus. But > >> setFeatures() has to be done at exactly the right point in time. This > is a > >> bit tricky as it depends on the integration scenario. > >> > >> In my case (Apache Meecrowave) I went the way of doing this in my > >> Application. > >> > >>> @ApplicationScoped > >>> @ApplicationPath("/api") > >>> public class MyApp extends Application { > >>> // configuration is done via Apache DeltaSpike > >>> private static ConfigResolver.TypedResolver logEnabled > >>>= ConfigResolver.resolve("myapp.cxf.logging.enabled") > >>>.as(Boolean.class) > >>>.evaluateVariables(true) > >>>.withDefault(Boolean.FALSE) > >>>.cacheFor(TimeUnit.MINUTES, 30); > >>> > >>> private @Inject Bus bus; > >>> > >>> @PostConstruct > >>> public void initKonnektorApp() { > >>>if (Boolean.TRUE == logEnabled.getValue()) { > >>>log.info("CXF LogInterceptors enabled"); > >>>Collection features = new ArrayList<>(); > >>>features.add(new LoggingFeature()); > >>>bus.setFeatures(features); > >>>} > >>> } > >>> } > >> > >> This works great in Meecrowave since the Application is picked up as CDI > >> bean and the Bus is also available via CDI. > >> But this is actually not guaranteed, so it's not really portable. It > isn't > >> guaranteed to work that way in say IBM Liberty or Apache TomEE. > >> > >> > >> That's the reason why I'd love to see a more portable version. > >> Which brought me to using @DynamicFeature to register that Feature. > >> But as already noted: cxf.Feature != javax rs.Feature > >> > >> Makes sense? > >> Is there another way to enable that feature in a programmatic way which > >> I've simply missed? > >> > >> txs and LieGrue, > >> strub > >> > >> > >> > >> > >>> Am 26.04.2018 um 22:22 schrieb Andrey Redko <drr...@gmail.com>: > >>> > >>> Yeah, certainly, would be good to get a bit more details or small code > >>> snippets to understand the problem. Mark, is it possible? Thanks. > >>> > >>> Best Regards, > >>> Andriy Redko > >>> > >>> On Thu, Apr 26, 2018, 12:40 AM
Re: A few 'Feature' questions
; AM> For #2 - I'd like others to weigh in, but I do think that this is > the > >>> AM> intended behavior. IIUC, org.apache.cxf.feature.Feature existed > >>> before the > >>> AM> JAX-RS spec and is used in a variety of non-JAX-RS scenarios > (JAX-WS, > >>> AM> etc.). The LoggingInterceptor is not actually a JAX-RS provider - > >>> rather > >>> AM> it is an interceptor used on the CXF chain. JAX-RS Providers are > >>> typically > >>> AM> invoked from the JAXRSInInterceptor and JAXRSOutInterceptor on the > >>> chain. > >>> AM> It may be possible to add a LoggingInterceptor to the chain at that > >>> point, > >>> AM> but it doesn't seem advisable - I haven't done much with chain > >>> AM> manipulation, so would definitely recommend a second opinion here. > >>> > >>> AM> Thanks for the patch, > >>> > >>> AM> Andy > >>> > >>> AM> On Wed, Apr 25, 2018 at 3:26 PM, Mark Struberg > >>> <strub...@yahoo.de.invalid> > >>> AM> wrote: > >>> > >>>>> hi folks! > >>> > >>>>> I have two questions: > >>> > >>>>> 1.) Could anybody plz take a quick look at CXF-7713 and review the > >>> patch? > >>> > >>>>> 2.) I've created a DynamicFeature @Provider and tried to register a > CXF > >>>>> LoggingInterceptor. > >>>>> And this doesn't work since it seems to only pick up > >>>>> javax.ws.rs.core.Feature instances, but not > >>>>> org.apache.cxf.feature.Feature > >>> > >>>>> Is this observation correct? > >>>>> Is this behaviour intended? > >>> > >>>>> I know I can register it via Bus#setFeatures, but that is not as > >>> modular > >>>>> in comparison to the @Provider. > >>> > >>>>> txs and LieGrue, > >>>>> strub > >>> > >>> > >>> > >>> > >>> > > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
Re: [VOTE] CXF 2.3.4
+1 Christian 2018-03-22 22:18 GMT+01:00 Daniel Kulp <dk...@apache.org>: > > This is a vote to release CXF 3.2.4. We only fixed a few issues since > 3.2.3, but it fixes a severe regression for Syncope as well as fixes a > potential corruption issue with the JSONProvider. > > Staging area: > https://repository.apache.org/content/repositories/orgapachecxf-1115/ > > Tag: > https://gitbox.apache.org/repos/asf?p=cxf.git;a=tag;h= > ad8b056676799c92d4d81e9c006c5711be35d62c > > Here is my +1. > > > -- > Daniel Kulp > dk...@apache.org - http://dankulp.com/blog > Talend Community Coder - http://coders.talend.com > > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
Re: Going offline soon
Hi Sergey, thanks for all your great contributions to CXF. JAX-RS would not be anywhere the level it is without you. We will all miss you here and I hope we can still ask you from time to time when difficult questions come up. I wish you all the best with your new job. Cheers, Christian 2018-02-09 12:23 GMT+01:00 Sergey Beryozkin <sberyoz...@gmail.com>: > Hi Guys, > Just a short note that I'll be going offline for a while pretty soon, at > the end of next week, this is due to me starting a new job in a company > with their own JAX-RS investment/interest, and joining the project which > depends on that, with no CXF JAX-RS link. > > Please get in touch privately if you reckon I might be of some help, > > Thank you all and best of luck :-) > > Sergey > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
Re: New Logging interceptors
Instead of the interceptors you should use the new LoggingFeature. It will make sure the interceptors are correctly wired. If you use it like this then the system property is not required. See http://cxf.apache.org/docs/message-logging.html Christian 2018-01-19 11:56 GMT+01:00 Colm O hEigeartaigh <cohei...@apache.org>: > Hi all, > > With the old logging interceptors in CXF core (org.apache.cxf.interceptor) > you just had to attach them to the interceptor chain to see the > outbound/inbound requests. These interceptors are now deprecated. > > However in the new interceptors (org.apache.cxf.ext.logging), attaching > them to the interceptor chain is not enough to see the requests. You also > need to set the system property org.apache.cxf.logging.enabled to "true". > > Is this change in behaviour intended? > > Colm. > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > -- -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
Re: New Java 9 master
2017-11-17 4:40 GMT+01:00 Jeff Genender <jgenen...@apache.org>: > > > > On Nov 16, 2017, at 6:02 AM, Christian Schneider < > ch...@die-schneider.net> wrote: > > > > I am not sure sure about the need for Java 9 modules. Currently I see no > > user requesting this. > > We need a user to request it? Whats wrong with us looking in a crystal > ball? Doesn’t one of our own committers count as a user requesting it? > Absolutely Sergeys request is surely valid. I just fear the additional overhead and that a java 9 master might prevent some java 8 developers from supplying patches as they would be forced to develop on java 9. So I completely agree that we will have a java 9 master at some point .. The question is only when. My approach to this is to switch as late as possible while still allowing us to explore java 9. > > > It is also not yet fully clear how these modules > > behave in OSGi. > > They are just jars with manifests, no? I would believe they would both > operate based on their own manifest file contents. Let stay it and find > out. ;-). No harm no foul. > Yes. I completely agree to try this. I would rather experiment with this in a side branch though. The ideal solution would be a jar that is both a java 9 module and a regular java 8 jar. Not sure if that works though. If Dans assumption is right that all our deps must be JAva 9 modules before we switch this will take quite a while anyway. So I think the right time to switch to add java 9 modules is when all dependencies are modules. For other java 9 features we might want to provide support earlier though. > > > > > So I think the current situation with a master that works on Java 9 and > > Java 8 is a pretty good situation that we should keep for as long as > > possible. > > I am not sure how attractive the other Java 9 features are. Personally I > > were really eager to adopt Java 8 because of the closures but I see no > real > > need for myself to rush to java 9. > > > > But others do use it. I'm one of those who did go all in JDK 9… call me a > cutting edge person. ;-). I have people asking me all the time about this. > Different strokes for different folks. ;-) > > > When I remember how reluctant we were when it came to adopting the > previous > > java versions like 7 and 8 as minimal requirement I think it makes sense > to > > do this rather slowly. > > And what did that reluctancy buy us except people wondering what is taking > so long. Why not get ahead of the curve this time instead of being > dinosaurs and the last ones to the table. > > Whats the harm in doing it? Its just a git repo that has zero impact on > the Java 8 code base. Everything will feed it as an upstream code base. > The harm is that every change in CXF will be coded and tested on the Java 9 master first then. Additionally it would need to be backported to the older branches. So we would force all CXF developers to switch to Java 9. This is the price and it will be especially high while most people are still on Java 8. On the other hand the gain is that Java 9 developers can already work with Java 9 features. At the start this gain is very low. It will grow over time when people migrate to Java 9. So the question is simply when there is the right time for this switch. Christian -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Computer Scientist http://www.adobe.com
Re: New Java 9 master
I mean simple in regard to everyday work on the code. The effort would be mainly in setting up this build once. I simply had bad experiences in the past with a master that is never released for a long time. For example there was a camel 3 master for a long time and it deteriorated more and more over time as people concentrated on the code that was going into the releases they use on a daily basis. So no one really cared about a master that everyone knew is not released anytime (soon). Personally I even prefer to simply stay on a java 8+9 master until a big percentage of people switched to java 9. This will not allow us to use java 9 features until then but honestly I personally have no intention to ever switch to java 9. I will probably wait if java 10 brings anything convincing. Christian 2017-11-16 16:57 GMT+01:00 Sergey Beryozkin <sberyoz...@gmail.com>: > Sorry, looks like a pretty messy and non convincing plan to me. > Simple for users and us ? Seriously ? This would be Java 9 only branch > would be released probably once in at least a year time from now. > > Cheers, Sergey > > On 16/11/17 15:42, Christian Schneider wrote: > >> So lets make this a little more concrete. What do we expect that people do >> in the Java 9 master? >> >> Java 9 modules -> As Andriy explained this only works when all our >> dependencies are Java 9 modules. So this will not be near term. >> Java 9 reactive streams. Could be interesting but there is already rxjava >> and project reactor. So people have the reactive capabilities already. So >> I >> am not sure how many people are really interested in this. We can do kind >> of a poll on the user list. >> I do not think there are any other Java 9 features that are really an >> incentive for a java 9 only branch. >> >> So I think the Java 9 only code could be limited to only a few modules. >> For >> example we could have a REST client with java 9 Flow support. >> So how about having a build that checks if the developer has a jdk8. If >> yes >> then we skip the java 9 modules in the build. If the developer has java 9 >> we build all modules. We could then do our release with Java 9 but make >> sure that most modules can run with java 8 and only the few java 9 modules >> require java 9. Not sure if that is possible but it would make our and the >> users life a lot simpler than a pure java 9 master. >> >> Christian >> >> >> 2017-11-16 15:02 GMT+01:00 Sergey Beryozkin <sberyoz...@gmail.com>: >> >> Indeed it will take a long time for a team with the limited resources to >>> have CXF embracing Java 9. Postponing the start of this long process for >>> 2 >>> years or so and wait for the users to come in and say, when will CXF will >>> do what SpringBoot with Java 9 can do, is not strategically right move >>> IMHO. >>> >>> Have the Java 9 branch, let people spend as much time as needed to play >>> there, keep going with Java 8+9 in 3.2.1. I don't see where the conflict >>> is. >>> >>> Cheers. Sergey >>> >>> On 16/11/17 13:53, Andriy Redko wrote: >>> >>> Modules are really far away in the future (IMHO). As per my >>>> understanding, we >>>> could think about real modules only when all our dependencies are >>>> modularized, >>>> which would take quite a lot of time I suppose. The Reactive Streams >>>> part >>>> is >>>> really appealing *BUT* even there we **could** keep the same master for >>>> 8 >>>> and 9 >>>> (http://openjdk.java.net/jeps/238). >>>> >>>> Honestly, I am not 100% sure we have to branch off the new master and >>>> keep it >>>> Java 9 only right now. May be the good moment will be when we >>>> discountinue >>>> 3.1.x so at least the code will be much easier to cherry-pick? >>>> >>>> Best Regards, >>>> Andriy Redko >>>> >>>> CS> I am not sure sure about the need for Java 9 modules. Currently I >>>> see >>>> no >>>> CS> user requesting this. It is also not yet fully clear how these >>>> modules >>>> CS> behave in OSGi. As far as I understood as soon as we start with this >>>> we >>>> CS> have code that is not working in Java 8. As we require every change >>>> to be >>>> CS> done in master first this means we have a lot of back port work. A >>>> Java 9 >>>> CS> only master will also make it much harder for Java 8 users t
Re: New Java 9 master
seen successfull builds from >>>>> https://builds.apache.org/job/CXF-Master-JDK9) ? >>>>> >>>> >> Best Regards, >>>>> Andriy Redko >>>>> >>>> >> SB> It's pretty simple really. It's about having a new impetus for the CXF >>>>> SB> development. >>>>> >>>> >> SB> Without a Java 9 only master CXF will be about fixing the bugs only. >>>>> SB> JAX-WS is done long time ago, next version of JAX-RS will take N >>>>> amount >>>>> SB> of time to materialize. >>>>> >>>> >> SB> Java 9 with its Flow class will let CXF do new work around Reactive >>>>> SB> support. It will have new features that only work with Java 9 and >>>>> may >>>>> SB> give new ideas for the contributions. >>>>> >>>> >> SB> 3.2.x is at the start of its life-cycle and will have a couple of >>>>> years >>>>> SB> at least for it to retire, giving Java 8 support. >>>>> >>>> >> SB> 3.1.x has probably 6 months or so left in it, and after it's gone we >>>>> SB> will have 3.2.x and 4.0.x or whatever new version is preferred. >>>>> >>>> >> SB> Sergey >>>>> SB> On 16/11/17 08:15, Dennis Kieselhorst wrote: >>>>> >>>> >> On 2017-11-16 07:27, Christian Schneider <ch...@die-schneider.net> >>>>>> >>>>>>> wrote: >>>>>>> >>>>>> >> I dont think we can already predict when users move to Java 9. >>>>>>>> So creating a Java 9 only branch at this time means we have to >>>>>>>> maintain two >>>>>>>> main branches over a long time. >>>>>>>> >>>>>>> >> What is the rationale behind a Java 9 only branch compared to being >>>>>>>> Java 9 >>>>>>>> and Java 8 compatible on master? >>>>>>>> >>>>>>> >> >> I also don't see a good reason to do that at the moment. Let's release >>>>>>> the XJC plugin and users should be able to use CXF with Java 9 or am >>>>>>> I >>>>>>> missing something? >>>>>>> >>>>>> >> Cheers >>>>>>> Dennis >>>>>>> >>>>>> >> >> >> >> >> CS> -- >> >> -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Computer Scientist http://www.adobe.com
Re: New Java 9 master
I am not sure sure about the need for Java 9 modules. Currently I see no user requesting this. It is also not yet fully clear how these modules behave in OSGi. As far as I understood as soon as we start with this we have code that is not working in Java 8. As we require every change to be done in master first this means we have a lot of back port work. A Java 9 only master will also make it much harder for Java 8 users to supply pull requests as they have to develop and test on java 9 which is not their production system. So I think the current situation with a master that works on Java 9 and Java 8 is a pretty good situation that we should keep for as long as possible. I am not sure how attractive the other Java 9 features are. Personally I were really eager to adopt Java 8 because of the closures but I see no real need for myself to rush to java 9. When I remember how reluctant we were when it came to adopting the previous java versions like 7 and 8 as minimal requirement I think it makes sense to do this rather slowly. Christian 2017-11-16 13:31 GMT+01:00 Sergey Beryozkin <sberyoz...@gmail.com>: > Hi Andriy > > I'm only presuming that yes, a Java 9 only master would have to support > the new Java 9 modules system, so I'd say a lot of exciting work would > await for the CXF dev community :-) > > Cheers, Sergey > > On 16/11/17 12:19, Andriy Redko wrote: > >> Hey Sergey, >> >> Do we have a goal to support Java 9 modules (aka Jigsaw) for >> the new master branch? Or we just looking to benefit from the >> latest changes in stardand library (as you mentioned, Flow & Co, >> collections are also a good example)? Is our current master JDK9 >> compatible actually (haven't seen successfull builds from >> https://builds.apache.org/job/CXF-Master-JDK9) ? >> >> Best Regards, >> Andriy Redko >> >> SB> It's pretty simple really. It's about having a new impetus for the CXF >> SB> development. >> >> SB> Without a Java 9 only master CXF will be about fixing the bugs only. >> SB> JAX-WS is done long time ago, next version of JAX-RS will take N >> amount >> SB> of time to materialize. >> >> SB> Java 9 with its Flow class will let CXF do new work around Reactive >> SB> support. It will have new features that only work with Java 9 and may >> SB> give new ideas for the contributions. >> >> SB> 3.2.x is at the start of its life-cycle and will have a couple of >> years >> SB> at least for it to retire, giving Java 8 support. >> >> SB> 3.1.x has probably 6 months or so left in it, and after it's gone we >> SB> will have 3.2.x and 4.0.x or whatever new version is preferred. >> >> SB> Sergey >> SB> On 16/11/17 08:15, Dennis Kieselhorst wrote: >> >>> On 2017-11-16 07:27, Christian Schneider <ch...@die-schneider.net> >>>> wrote: >>>> >>>>> I dont think we can already predict when users move to Java 9. >>>>> So creating a Java 9 only branch at this time means we have to >>>>> maintain two >>>>> main branches over a long time. >>>>> >>>>> What is the rationale behind a Java 9 only branch compared to being >>>>> Java 9 >>>>> and Java 8 compatible on master? >>>>> >>>> >>>> I also don't see a good reason to do that at the moment. Let's release >>>> the XJC plugin and users should be able to use CXF with Java 9 or am I >>>> missing something? >>>> >>>> Cheers >>>> Dennis >>>> >>>> >> -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Computer Scientist http://www.adobe.com
Re: New Java 9 master
I dont think we can already predict when users move to Java 9. So creating a Java 9 only branch at this time means we have to maintain two main branches over a long time. What is the rationale behind a Java 9 only branch compared to being Java 9 and Java 8 compatible on master? Christian 2017-11-15 12:47 GMT+01:00 Sergey Beryozkin <sberyoz...@gmail.com>: > Hi > > Should we open a new Java 9 only master soon enough ? > > Thanks, Sergey > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Computer Scientist http://www.adobe.com
[RESULT][VOTE] - Release Apache CXF DOSGi 2.3.0 .. take 2
With 5 +1 this vote passes. Christian 2017-09-25 16:25 GMT+02:00 Colm O hEigeartaigh <cohei...@apache.org>: > +1 (minor quibble : There are ^M characters in the license + notice in the > distribution). > > Colm. > > On Mon, Sep 25, 2017 at 1:41 AM, Freeman Fang <freeman.f...@gmail.com> > wrote: > > > +1 > > - > > Freeman(Yue) Fang > > > > Red Hat, Inc. > > FuseSource is now part of Red Hat > > > > > > > > > On Sep 23, 2017, at 6:46 PM, Christian Schneider < > > ch...@die-schneider.net> wrote: > > > > > > This is a vote to release Apache CXF-DOSGi 2.3.0. > > > > > > I cut a second release as the first one missed the LICENSE and NOTICE > > files > > > in the correct position. As another small improvement I upgraded to > jline > > > 3.5.1 which has better colors on windows. > > > > > > Highlights: > > > > > > * The multi bundle distro is now built using bnd-export-plugin and a > > bndrun > > > file instead of by exporting karaf features. The new approach makes > sure > > > the bundles form a consistent and minimal deployment. In fact the > distro > > in > > > now only 15MB instead of 22 MB. > > > > > > * The multi bundle distro now includes apache felix and can be directly > > > started > > > > > > * We do not list the bundles in the config anymore. Felix simply starts > > all > > > bundles in the directory bundle. There are also no more start level > > tweaks. > > > > > > * The distro now uses the felix http service instead of pax web. This > > saves > > > us a lot of bundles > > > > > > I found one issue which I can not fix before the release as requires a > > CXF > > > release: > > > https://issues.apache.org/jira/browse/DOSGI-276 > > > Another issue is an exception thrown by gogo jline when starting the > > > distro. I will try to get that fixed too for 2.4.0. > > > > > > > > > Release Notes - CXF Distributed OSGi - Version 2.3.0 > > > > > > ** Bug > > >* [DOSGI-254] - ServiceInvocationHandler does not handle checked > > > super-interface exceptions correctly > > >* [DOSGI-267] - ContainerRequestFilter intents do not get registered > > as > > > providers > > >* [DOSGI-275] - Include felix and samples in multibundle distro > > > > > > ** Improvement > > >* [DOSGI-273] - Use bnd resolver to create multibundle distro > > >* [DOSGI-274] - Upgrade to CXF 3.2.0 > > > > > > > > > Tag: > > > https://gitbox.apache.org/repos/asf?p=cxf-dosgi.git;a= > > tag;h=refs/tags/cxf-dosgi-2.3.0 > > > > > > Maven Artifacts: > > > https://repository.apache.org/content/repositories/orgapachecxf-1106 > > > > > > > > > +1 from me. > > > > > > > > > > > > Christian > > > > > > -- > > > -- > > > Christian Schneider > > > http://www.liquid-reality.de > > > <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba5 > 2bd062c5a7e > > 46=http%3a%2f%2fwww.liquid-reality.de> > > > > > > Open Source Architect > > > http://www.talend.com > > > <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba5 > 2bd062c5a7e > > 46=http%3a%2f%2fwww.talend.com> > > > > > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Computer Scientist http://www.adobe.com
[VOTE] - Release Apache CXF DOSGi 2.3.0 .. take 2
This is a vote to release Apache CXF-DOSGi 2.3.0. I cut a second release as the first one missed the LICENSE and NOTICE files in the correct position. As another small improvement I upgraded to jline 3.5.1 which has better colors on windows. Highlights: * The multi bundle distro is now built using bnd-export-plugin and a bndrun file instead of by exporting karaf features. The new approach makes sure the bundles form a consistent and minimal deployment. In fact the distro in now only 15MB instead of 22 MB. * The multi bundle distro now includes apache felix and can be directly started * We do not list the bundles in the config anymore. Felix simply starts all bundles in the directory bundle. There are also no more start level tweaks. * The distro now uses the felix http service instead of pax web. This saves us a lot of bundles I found one issue which I can not fix before the release as requires a CXF release: https://issues.apache.org/jira/browse/DOSGI-276 Another issue is an exception thrown by gogo jline when starting the distro. I will try to get that fixed too for 2.4.0. Release Notes - CXF Distributed OSGi - Version 2.3.0 ** Bug * [DOSGI-254] - ServiceInvocationHandler does not handle checked super-interface exceptions correctly * [DOSGI-267] - ContainerRequestFilter intents do not get registered as providers * [DOSGI-275] - Include felix and samples in multibundle distro ** Improvement * [DOSGI-273] - Use bnd resolver to create multibundle distro * [DOSGI-274] - Upgrade to CXF 3.2.0 Tag: https://gitbox.apache.org/repos/asf?p=cxf-dosgi.git;a=tag;h=refs/tags/cxf-dosgi-2.3.0 Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1106 +1 from me. Christian -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: [VOTE] - Release Apache CXF DOSGi 2.3.0
I agree ..better be safe than sorry in legal issues. I will cut a new release but it will take some time as I already cleaned my work notebook to return it. I hope I can prepare my home windows system for a release. Christian 2017-09-22 14:15 GMT+02:00 Colm O hEigeartaigh <cohei...@apache.org>: > From: http://www.apache.org/dev/licensing-howto.html > > "LICENSE and NOTICE belong at the top level of the source tree > <http://www.apache.org/legal/src-headers.html#notice>.". I'm not sure if > this is a hard requirement, but I would say it's probably better to fix it > for this release. > > Colm. > > On Fri, Sep 22, 2017 at 12:54 PM, Christian Schneider < > ch...@die-schneider.net> wrote: > > > No .. I forgot to place them in the top level dir. > > I will fix this. Do you think it is ok to fix this for the next release? > > > > Christian > > > > 2017-09-22 13:08 GMT+02:00 Colm O hEigeartaigh <cohei...@apache.org>: > > > > > Thanks. In the distribution, is there a reason the LICENSE + NOTICE > file > > > are hidden away in "target/maven-shared-archive-resources/META-INF" > > > instead > > > of the root directory of the distribution? > > > > > > Colm. > > > > > > On Fri, Sep 22, 2017 at 11:53 AM, Christian Schneider < > > > ch...@die-schneider.net> wrote: > > > > > > > Hmm .. somehow I posted the wrong repo url. The correct one is: > > > > https://repository.apache.org/content/repositories/orgapachecxf-1104 > > > > > > > > Best > > > > Christian > > > > > > > > 2017-09-22 12:36 GMT+02:00 Colm O hEigeartaigh <cohei...@apache.org > >: > > > > > > > >> I'm getting a 404 for the maven repo: > > > >> > > > >> https://repository.apache.org/content/repositories/ > orgapachecxf-1094/ > > > >> > > > >> Perhaps it's temporarily down? > > > >> > > > >> Colm. > > > >> > > > >> On Thu, Sep 21, 2017 at 5:23 PM, Daniel Kulp <dk...@apache.org> > > wrote: > > > >> > > > >> > > > > >> > +1 > > > >> > > > > >> > Dan > > > >> > > > > >> > > > > >> > > > > >> > > On Sep 21, 2017, at 8:43 AM, Christian Schneider < > > > >> > ch...@die-schneider.net> wrote: > > > >> > > > > > >> > > This is a vote to release Apache CXF-DOSGi 2.3.0. > > > >> > > > > > >> > > Highlights: > > > >> > > > > > >> > > * The multi bundle distro is now built using bnd-export-plugin > > and a > > > >> > bndrun file instead of by exporting karaf features. The new > approach > > > >> makes > > > >> > sure the bundles form a consistent and minimal deployment. In fact > > the > > > >> > distro in now only 15MB instead of 22 MB. > > > >> > > > > > >> > > * The multi bundle distro now includes apache felix and can be > > > >> directly > > > >> > started > > > >> > > > > > >> > > * We do not list the bundles in the config anymore. Felix simply > > > >> starts > > > >> > all bundles in the directory bundle. There are also no more start > > > level > > > >> > tweaks. > > > >> > > > > > >> > > * The distro now uses the felix http service instead of pax web. > > > This > > > >> > saves us a lot of bundles > > > >> > > > > > >> > > I found one issue which I can not fix before the release as > > > requires a > > > >> > CXF release: > > > >> > > https://issues.apache.org/jira/browse/DOSGI-276 > > > >> > > > > > >> > > > > > >> > > Release Notes - CXF Distributed OSGi - Version 2.3.0 > > > >> > > > > > >> > > ** Bug > > > >> > >* [DOSGI-254] - ServiceInvocationHandler does not handle > > checked > > > >> > super-interface exceptions correctly > > > >> > >* [DOSGI-267] - ContainerRequestFilter intents do not get > > > >> registered > > > >> > as providers > > > >>
Re: [VOTE] - Release Apache CXF DOSGi 2.3.0
No .. I forgot to place them in the top level dir. I will fix this. Do you think it is ok to fix this for the next release? Christian 2017-09-22 13:08 GMT+02:00 Colm O hEigeartaigh <cohei...@apache.org>: > Thanks. In the distribution, is there a reason the LICENSE + NOTICE file > are hidden away in "target/maven-shared-archive-resources/META-INF" > instead > of the root directory of the distribution? > > Colm. > > On Fri, Sep 22, 2017 at 11:53 AM, Christian Schneider < > ch...@die-schneider.net> wrote: > > > Hmm .. somehow I posted the wrong repo url. The correct one is: > > https://repository.apache.org/content/repositories/orgapachecxf-1104 > > > > Best > > Christian > > > > 2017-09-22 12:36 GMT+02:00 Colm O hEigeartaigh <cohei...@apache.org>: > > > >> I'm getting a 404 for the maven repo: > >> > >> https://repository.apache.org/content/repositories/orgapachecxf-1094/ > >> > >> Perhaps it's temporarily down? > >> > >> Colm. > >> > >> On Thu, Sep 21, 2017 at 5:23 PM, Daniel Kulp <dk...@apache.org> wrote: > >> > >> > > >> > +1 > >> > > >> > Dan > >> > > >> > > >> > > >> > > On Sep 21, 2017, at 8:43 AM, Christian Schneider < > >> > ch...@die-schneider.net> wrote: > >> > > > >> > > This is a vote to release Apache CXF-DOSGi 2.3.0. > >> > > > >> > > Highlights: > >> > > > >> > > * The multi bundle distro is now built using bnd-export-plugin and a > >> > bndrun file instead of by exporting karaf features. The new approach > >> makes > >> > sure the bundles form a consistent and minimal deployment. In fact the > >> > distro in now only 15MB instead of 22 MB. > >> > > > >> > > * The multi bundle distro now includes apache felix and can be > >> directly > >> > started > >> > > > >> > > * We do not list the bundles in the config anymore. Felix simply > >> starts > >> > all bundles in the directory bundle. There are also no more start > level > >> > tweaks. > >> > > > >> > > * The distro now uses the felix http service instead of pax web. > This > >> > saves us a lot of bundles > >> > > > >> > > I found one issue which I can not fix before the release as > requires a > >> > CXF release: > >> > > https://issues.apache.org/jira/browse/DOSGI-276 > >> > > > >> > > > >> > > Release Notes - CXF Distributed OSGi - Version 2.3.0 > >> > > > >> > > ** Bug > >> > >* [DOSGI-254] - ServiceInvocationHandler does not handle checked > >> > super-interface exceptions correctly > >> > >* [DOSGI-267] - ContainerRequestFilter intents do not get > >> registered > >> > as providers > >> > >* [DOSGI-275] - Include felix and samples in multibundle distro > >> > > > >> > > ** Improvement > >> > >* [DOSGI-273] - Use bnd resolver to create multibundle distro > >> > >* [DOSGI-274] - Upgrade to CXF 3.2.0 > >> > > > >> > > > >> > > Tag: > >> > > https://gitbox.apache.org/repos/asf?p=cxf-dosgi.git;a= > >> > tag;h=refs/tags/cxf-dosgi-2.3.0 > >> > > > >> > > Maven Artifacts: > >> > > https://repository.apache.org/content/repositories/ > orgapachecxf-1094/ > >> > > > >> > > > >> > > +1 from me. > >> > > > >> > > Christian > >> > > > >> > > -- > >> > > Christian Schneider > >> > > http://www.liquid-reality.de > >> > > > >> > > Open Source Architect > >> > > http://www.talend.com > >> > > > >> > > >> > -- > >> > Daniel Kulp > >> > dk...@apache.org - http://dankulp.com/blog > >> > Talend Community Coder - http://coders.talend.com > >> > > >> > > >> > >> > >> -- > >> Colm O hEigeartaigh > >> > >> Talend Community Coder > >> http://coders.talend.com > >> > > > > > > > > -- > > -- > > Christian Schneider > > http://www.liquid-reality.de > > <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e > 46=http%3a%2f%2fwww.liquid-reality.de> > > > > Open Source Architect > > http://www.talend.com > > <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e > 46=http%3a%2f%2fwww.talend.com> > > > > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: [VOTE] - Release Apache CXF DOSGi 2.3.0
Hmm .. somehow I posted the wrong repo url. The correct one is: https://repository.apache.org/content/repositories/orgapachecxf-1104 Best Christian 2017-09-22 12:36 GMT+02:00 Colm O hEigeartaigh <cohei...@apache.org>: > I'm getting a 404 for the maven repo: > > https://repository.apache.org/content/repositories/orgapachecxf-1094/ > > Perhaps it's temporarily down? > > Colm. > > On Thu, Sep 21, 2017 at 5:23 PM, Daniel Kulp <dk...@apache.org> wrote: > > > > > +1 > > > > Dan > > > > > > > > > On Sep 21, 2017, at 8:43 AM, Christian Schneider < > > ch...@die-schneider.net> wrote: > > > > > > This is a vote to release Apache CXF-DOSGi 2.3.0. > > > > > > Highlights: > > > > > > * The multi bundle distro is now built using bnd-export-plugin and a > > bndrun file instead of by exporting karaf features. The new approach > makes > > sure the bundles form a consistent and minimal deployment. In fact the > > distro in now only 15MB instead of 22 MB. > > > > > > * The multi bundle distro now includes apache felix and can be directly > > started > > > > > > * We do not list the bundles in the config anymore. Felix simply starts > > all bundles in the directory bundle. There are also no more start level > > tweaks. > > > > > > * The distro now uses the felix http service instead of pax web. This > > saves us a lot of bundles > > > > > > I found one issue which I can not fix before the release as requires a > > CXF release: > > > https://issues.apache.org/jira/browse/DOSGI-276 > > > > > > > > > Release Notes - CXF Distributed OSGi - Version 2.3.0 > > > > > > ** Bug > > >* [DOSGI-254] - ServiceInvocationHandler does not handle checked > > super-interface exceptions correctly > > >* [DOSGI-267] - ContainerRequestFilter intents do not get registered > > as providers > > >* [DOSGI-275] - Include felix and samples in multibundle distro > > > > > > ** Improvement > > >* [DOSGI-273] - Use bnd resolver to create multibundle distro > > >* [DOSGI-274] - Upgrade to CXF 3.2.0 > > > > > > > > > Tag: > > > https://gitbox.apache.org/repos/asf?p=cxf-dosgi.git;a= > > tag;h=refs/tags/cxf-dosgi-2.3.0 > > > > > > Maven Artifacts: > > > https://repository.apache.org/content/repositories/orgapachecxf-1094/ > > > > > > > > > +1 from me. > > > > > > Christian > > > > > > -- > > > Christian Schneider > > > http://www.liquid-reality.de > > > > > > Open Source Architect > > > http://www.talend.com > > > > > > > -- > > Daniel Kulp > > dk...@apache.org - http://dankulp.com/blog > > Talend Community Coder - http://coders.talend.com > > > > > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
[VOTE] - Release Apache CXF DOSGi 2.3.0
This is a vote to release Apache CXF-DOSGi 2.3.0. Highlights: * The multi bundle distro is now built using bnd-export-plugin and a bndrun file instead of by exporting karaf features. The new approach makes sure the bundles form a consistent and minimal deployment. In fact the distro in now only 15MB instead of 22 MB. * The multi bundle distro now includes apache felix and can be directly started * We do not list the bundles in the config anymore. Felix simply starts all bundles in the directory bundle. There are also no more start level tweaks. * The distro now uses the felix http service instead of pax web. This saves us a lot of bundles I found one issue which I can not fix before the release as requires a CXF release: https://issues.apache.org/jira/browse/DOSGI-276 Release Notes - CXF Distributed OSGi - Version 2.3.0 ** Bug * [DOSGI-254] - ServiceInvocationHandler does not handle checked super-interface exceptions correctly * [DOSGI-267] - ContainerRequestFilter intents do not get registered as providers * [DOSGI-275] - Include felix and samples in multibundle distro ** Improvement * [DOSGI-273] - Use bnd resolver to create multibundle distro * [DOSGI-274] - Upgrade to CXF 3.2.0 Tag: https://gitbox.apache.org/repos/asf?p=cxf-dosgi.git;a=tag;h=refs/tags/cxf-dosgi-2.3.0 Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1094/ +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [Discuss] Release CXF-DOSGi 2.3.0 during the next days
Thanks for spotting this. There is an up to date release notes file in the top of the cxf-dosgi source which I could use. I would even prefer though to not have release notes in the source code like you proposed. So question to the PMC members: Are we required to have a release notes file in the source/distro? Christian On 18.09.2017 16:21, Dennis Kieselhorst wrote: Hi Christian, sounds good. Just one short remark: The release_notes.txt file is outdated (1.6.0 is the latest version), I think a link to the JIRA releases page would be also ok. I noticed an exception on startup but it doesn't seem to block anything. Regards Dennis java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.felix.gogo.runtime.CommandSessionImpl.inspect(CommandSessionImpl.java:445) at org.apache.felix.gogo.runtime.CommandSessionImpl.format(CommandSessionImpl.java:422) at org.apache.felix.gogo.runtime.CommandSessionImpl.format(CommandSessionImpl.java:482) at org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:427) at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:227) at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: java.net.UnknownServiceException: no content-type at java.net.URLConnection.getContentHandler(URLConnection.java:1241) at java.net.URLConnection.getContent(URLConnection.java:740) at java.net.URL.getContent(URL.java:1059) ... 14 more Am 18.09.2017 um 13:21 schrieb Christian Schneider: I did some interesting changes to CXF-DOSGi that I think should go into a new release soon. - Update to CF 3.2.0. So DOSGi is now again at the forefront of CXF - Build multi bundle distro using bnd-export-plugin. This makes the distro a lot smaller and also easier to recreate for users to customize it for their own distros. This way the distro is now only 15 MB instead of 22MB before. - Make it easier to try the multi bundle distro. The distro is now directly start-able like the new felix distros. It also includes the examples. The distro also uses gogo jline which has shell features similar to karaf (history, completion, coloring). This is the full set of issues. There are 3 open issues which I intend to move if no one steps in to work on them: https://issues.apache.org/jira/projects/DOSGI/versions/12341079 I encourage everyone to give the current snapshot a try: https://repository.apache.org/content/repositories/snapshots/org/apache/cxf/dosgi/cxf-dosgi-multibundle-distribution/2.3.0-SNAPSHOT/cxf-dosgi-multibundle-distribution-2.3.0-20170918.111439-13-dir.tar.gz Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] Apache CXF 3.2.0
I just checked with Guillaume to get some other opinion. He also approves going ahead with the release. So I am back to +1 again but we should not wait too long with a 3.2.1. Christian On 11.09.2017 12:57, Sergey Beryozkin wrote: 3.2.0 has been open for 2 years so I doubt major OSGI integrators will start using it immediately, will try it, not all of them necessarily use karaf-maven-plugin. 3.2.1 will follow in a few weeks... By the way, I see [INFO] Verification of feature cxf-jaxrs-cdi/3.2.1.SNAPSHOT succeeded (and it was fine with 3.2.0-SNAPSHOT) from the Karaf Maven plugin:verify Cheers, Sergey On 11/09/17 11:38, Christian Schneider wrote: Updating cxf-dosgi would of course not be a blocker. The problem is that I think this might also block people from building custom distros that include cxf 3.2.0. Christian On 11.09.2017 12:33, Sergey Beryozkin wrote: Christian Looks like it is only happening with the DOSGI, if you try to update it to 3.2.0 - but does the issue you see with updating DOSGi to 3.2.0 warrants -1 ? Can't you just wait till 3.2.1 ? Cheers, Sergey On 11/09/17 11:30, Christian Schneider wrote: Reverting my vote to -1 until we have a decision about the issues I found below. I just tried to update cxf-dosgi to cxf 3.2.0. I get an error when building the multi bundle distro. [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.1.2:features-export-meta-data (features-add-to-repository) on project cxf-dosgi-multibundle-distribution: Error populating repository: Can't resolve artifact org.ops4j.pax.cdi:pax-cdi-features:xml:features:[1.0.0.RC1,2): Failure to find org.ops4j.pax.cdi:pax-cdi-features:xml:features:[1.0.0.RC1,2) in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced So it seems like the karaf-maven-plugin does not work with a version range in the feature file. I think this is a bug and will report and fix it in karaf. Even if this might be a problem in karaf I wonder if using a range in the CXF feature is a good idea at this time. It will probably affect all karaf users that build a custom distro. I also tried to install the cxf-jaxrs-cdi feature from cxf 3.2.0 in karaf. The installation works but uses the 1.0.0-SNAPSHOT of the pax-cdi feature which is probably not what users expect. Christian On 06.09.2017 20:14, Daniel Kulp wrote: It’s been 2 years since the last major CXF release.We have well over 100 JIRA’s of new features and enhancements that are only targeted toward 3.2. Let’s get it out! Staging repo: https://repository.apache.org/content/repositories/orgapachecxf-1102/ Tag: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=79c1486ed9cf34d90a04d943ed72475500f83c48 Here is my +1 -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] Apache CXF 3.2.0
Updating cxf-dosgi would of course not be a blocker. The problem is that I think this might also block people from building custom distros that include cxf 3.2.0. Christian On 11.09.2017 12:33, Sergey Beryozkin wrote: Christian Looks like it is only happening with the DOSGI, if you try to update it to 3.2.0 - but does the issue you see with updating DOSGi to 3.2.0 warrants -1 ? Can't you just wait till 3.2.1 ? Cheers, Sergey On 11/09/17 11:30, Christian Schneider wrote: Reverting my vote to -1 until we have a decision about the issues I found below. I just tried to update cxf-dosgi to cxf 3.2.0. I get an error when building the multi bundle distro. [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.1.2:features-export-meta-data (features-add-to-repository) on project cxf-dosgi-multibundle-distribution: Error populating repository: Can't resolve artifact org.ops4j.pax.cdi:pax-cdi-features:xml:features:[1.0.0.RC1,2): Failure to find org.ops4j.pax.cdi:pax-cdi-features:xml:features:[1.0.0.RC1,2) in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced So it seems like the karaf-maven-plugin does not work with a version range in the feature file. I think this is a bug and will report and fix it in karaf. Even if this might be a problem in karaf I wonder if using a range in the CXF feature is a good idea at this time. It will probably affect all karaf users that build a custom distro. I also tried to install the cxf-jaxrs-cdi feature from cxf 3.2.0 in karaf. The installation works but uses the 1.0.0-SNAPSHOT of the pax-cdi feature which is probably not what users expect. Christian On 06.09.2017 20:14, Daniel Kulp wrote: It’s been 2 years since the last major CXF release.We have well over 100 JIRA’s of new features and enhancements that are only targeted toward 3.2. Let’s get it out! Staging repo: https://repository.apache.org/content/repositories/orgapachecxf-1102/ Tag: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=79c1486ed9cf34d90a04d943ed72475500f83c48 Here is my +1 -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] Apache CXF 3.2.0
Reverting my vote to -1 until we have a decision about the issues I found below. I just tried to update cxf-dosgi to cxf 3.2.0. I get an error when building the multi bundle distro. [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven-plugin:4.1.2:features-export-meta-data (features-add-to-repository) on project cxf-dosgi-multibundle-distribution: Error populating repository: Can't resolve artifact org.ops4j.pax.cdi:pax-cdi-features:xml:features:[1.0.0.RC1,2): Failure to find org.ops4j.pax.cdi:pax-cdi-features:xml:features:[1.0.0.RC1,2) in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced So it seems like the karaf-maven-plugin does not work with a version range in the feature file. I think this is a bug and will report and fix it in karaf. Even if this might be a problem in karaf I wonder if using a range in the CXF feature is a good idea at this time. It will probably affect all karaf users that build a custom distro. I also tried to install the cxf-jaxrs-cdi feature from cxf 3.2.0 in karaf. The installation works but uses the 1.0.0-SNAPSHOT of the pax-cdi feature which is probably not what users expect. Christian On 06.09.2017 20:14, Daniel Kulp wrote: It’s been 2 years since the last major CXF release.We have well over 100 JIRA’s of new features and enhancements that are only targeted toward 3.2. Let’s get it out! Staging repo: https://repository.apache.org/content/repositories/orgapachecxf-1102/ Tag: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=79c1486ed9cf34d90a04d943ed72475500f83c48 Here is my +1 -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] Apache CXF 3.2.0
+1 Christian On 06.09.2017 20:14, Daniel Kulp wrote: It’s been 2 years since the last major CXF release.We have well over 100 JIRA’s of new features and enhancements that are only targeted toward 3.2. Let’s get it out! Staging repo: https://repository.apache.org/content/repositories/orgapachecxf-1102/ Tag: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=79c1486ed9cf34d90a04d943ed72475500f83c48 Here is my +1 -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] Apache CXF 3.0.15 and 3.1.13 patch releases...
+1 Christian On 06.09.2017 20:12, Daniel Kulp wrote: It’s been over 2 months since the last release. We’ve fixed over 35 JIRA’s for 3.1.13. Thus, let’s get them out. Staging repos: 3.0.15: https://repository.apache.org/content/repositories/orgapachecxf-1100/ 3.1.13: https://repository.apache.org/content/repositories/orgapachecxf-1101/ Tags: 3.0.15: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=2e4c59bdfb3e503621904e91e6be7042c787bfff 3.1.13: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=4870bfd0ff967819df4cce794c8ebd61efdf92ca Here is my +1. Vote will be open for at least 72h. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: All CXF repos moved to gitbox....
I also just did the migration to gitbox. Some remarks: After activating the 2FA it takes a while until the asf bot adds you to the team. You will get a mail once that is completed. The link to the cxf committers team only works once you are added to the team. So it is normal to get a 404 until then. Christian On 09.09.2017 08:40, Dennis Kieselhorst wrote: FYI, all our repos have now been moved over to gitbox. In order to commit to the repos, you will need to do the gitbox setup to associate your Apache ID with your GitHub account. Follow the steps at: https://gitbox.apache.org/setup/ There are a bunch of steps starting from enabling the 2FA on GitHub, getting yourself added to the Apache organization, etc… Once that is all done, you SHOULD be able to push directly to the GitHub repo and manage pull requests and such there. Great, I've just changed the Jenkins Jobs to use gitbox.apache.org instead of git-wip-us.apache.org. Link to the Github team: https://github.com/orgs/apache/teams/cxf-committers/members All missing team members will automatically added by asfgit after they have completed the Gitbox setup steps. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[RESULT] [VOTE] - Release Apache CXF DOSGi 2.2.0
This vote passes with 6 +1 and no other votes. I will publish the artifacts. Christian On 10.07.2017 15:56, Christian Schneider wrote: This is a vote to release Apache CXF DOSGi 2.2.0. Highlights are swagger support, ContextProvider support and it is simpler to add features to a DOSGi endpoint by using @Features or the new IntentsProvider interface. Most can be seen in the jax-rs sample https://github.com/apache/cxf-dosgi/tree/master/samples/rest Release Notes - CXF Distributed OSGi - Version 2.2.0 ** Bug * [DOSGI-253] - CXF DOSGI JAX-RS incompatible with Camel features * [DOSGI-262] - Configure intent objects from service object (IntentsProvider, @Features) * [DOSGI-264] - Add features to OSGi service using @Features annotation ** Improvement * [DOSGI-268] - Update CXF to 3.1.12 * [DOSGI-269] - Update Aries RSA to 1.11.0 ** New Feature * [DOSGI-261] - Sample for rest with jackson provider * [DOSGI-266] - Support for org.apache.cxf.jaxrs.ext.ContextProvider * [DOSGI-270] - Create sample for swagger documentation Tag: https://git-wip-us.apache.org/repos/asf?p=cxf-dosgi.git;a=tag;h=refs/tags/cxf-dosgi-2.2.0 Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1094/ Repo mirror: https://github.com/apache/cxf-dosgi +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[VOTE] - Release Apache CXF DOSGi 2.2.0
This is a vote to release Apache CXF DOSGi 2.2.0. Highlights are swagger support, ContextProvider support and it is simpler to add features to a DOSGi endpoint by using @Features or the new IntentsProvider interface. Most can be seen in the jax-rs sample https://github.com/apache/cxf-dosgi/tree/master/samples/rest Release Notes - CXF Distributed OSGi - Version 2.2.0 ** Bug * [DOSGI-253] - CXF DOSGI JAX-RS incompatible with Camel features * [DOSGI-262] - Configure intent objects from service object (IntentsProvider, @Features) * [DOSGI-264] - Add features to OSGi service using @Features annotation ** Improvement * [DOSGI-268] - Update CXF to 3.1.12 * [DOSGI-269] - Update Aries RSA to 1.11.0 ** New Feature * [DOSGI-261] - Sample for rest with jackson provider * [DOSGI-266] - Support for org.apache.cxf.jaxrs.ext.ContextProvider * [DOSGI-270] - Create sample for swagger documentation Tag: https://git-wip-us.apache.org/repos/asf?p=cxf-dosgi.git;a=tag;h=refs/tags/cxf-dosgi-2.2.0 Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1094/ Repo mirror: https://github.com/apache/cxf-dosgi +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] Apache CXF 3.1.12 and 3.0.14
+1 Christian 2017-06-27 0:23 GMT+02:00 Daniel Kulp <dk...@apache.org>: > It’s been over 2 months since the last release. We’ve fixed over 50 JIRA’s > for 3.1.12. Thus, let’s get it out. > > Staging repos: > 3.0.14: > https://repository.apache.org/content/repositories/orgapachecxf-1093/ > 3.1.12: > https://repository.apache.org/content/repositories/orgapachecxf-1092/ > > Tags: > 3.0.14: > https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h= > a74c456018afc62d273cb8cb0a459fec5b12d265 > 3.1.12: > https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h= > 6b41994254531a6ea6b2451277063c71ecfac320 > > Here is my +1. Vote will be open for at least 72h. > > > -- > Daniel Kulp > dk...@apache.org - http://dankulp.com/blog > Talend Community Coder - http://coders.talend.com > > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: Configurable logging categeory for payload logging
How about we add the type "rs" or "ws" as category before the packagename? Christian 2017-04-24 12:28 GMT+02:00 Sergey Beryozkin <sberyoz...@gmail.com>: > Hi David > > I can add that option back, can you try something else in meantime, > a default JAXRS service QName is "{packagename}ClassName". > I wonder if you set a category to this value, would it help ? > > Sergey > > On 24/04/17 09:56, David Karlsen wrote: > >> See change in: >> https://issues.apache.org/jira/browse/CXF-7254 >> vs >> https://issues.apache.org/jira/browse/CXF-6936 >> >> our usecase: >> we have "dualstack" jax-ws / jax-rs servers (which are also clients >> towards >> other systems, mainly as jax-ws clients) - and want to cleanly separate: >> inbound jax-ws >> inbound jax-rs >> outbound jax-ws >> outbound jax-rs >> >> traffic into distinct logs. >> This is most easily done as a single line logger configuration in logback >> onto distinct appenders, and thus logfiles. >> >> It might seem we lost this possibility with CXF-7254 ? >> >> >> >> > > -- > Sergey Beryozkin > > Talend Community Coders > http://coders.talend.com/ > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: [VOTE] - Release Apache CXF Fediz 1.3.2 and 1.2.4
+1 Christian 2017-04-24 11:53 GMT+02:00 Jan Bernhardt <jbernha...@talend.com>: > +1 from me. > > > Jan > > > Von: Colm O hEigeartaigh <cohei...@apache.org> > Gesendet: Freitag, 21. April 2017 14:06:55 > An: dev@cxf.apache.org > Betreff: [VOTE] - Release Apache CXF Fediz 1.3.2 and 1.2.4 > > This is a vote to release Apache CXF Fediz 1.3.2 and 1.2.4. The vote for > 1.4.0 will follow next week. > > *1.3.2* > > Artifacts: > https://repository.apache.org/content/repositories/orgapachecxf-1089/ > > Git tag: > https://git-wip-us.apache.org/repos/asf?p=cxf-fediz.git;a=commit;h= > 7aff8635b4078fe952c63306e4ebb4ace25302df > > Issues fixed: > https://issues.apache.org/jira/browse/FEDIZ/fixforversion/12338091 > > *1.2.4* > > Artifacts: > https://repository.apache.org/content/repositories/orgapachecxf-1090/ > > Git tag: > https://git-wip-us.apache.org/repos/asf?p=cxf-fediz.git;a=tag;h= > 2fcb252a6931eccedac668f22f895e6a106f7f27 > > Issues fixed: > https://issues.apache.org/jira/browse/FEDIZ/fixforversion/12338219/ > > +1 from me. > > Colm. > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: Fred : which branch to work on?
Whenever possible we try to fix issues on master first and then backport to the individual branches. You should first clone the cxf git repo on github, then create a branch named like the issue id. You can then work on the branch and do your commits. The commits should have the format "[issue-id] description". When finished you create a pull request. If the commits are named like this the PR should automatically appear in the respective issue in jira. Christian 2017-04-12 5:28 GMT+02:00 Fred Assi <java2010...@gmail.com>: > Hi guys, > > I would like to start work on some bugs , Im not sure about your > procedures, can you advise please? > which branch should I pull to work on? > > Regards, > > Fred Assi > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: [VOTE] Apache CXF 3.1.11 and 3.0.13
+1 Christian On 06.04.2017 01:43, Daniel Kulp wrote: It’s been about 2 months since the last release. However, we’ve fixed over 100 JIRA’s for 3.1.11 which is a large number of fixes. Thus, let’s get it out. Staging repos: 3.0.13: https://repository.apache.org/content/repositories/orgapachecxf-1087/ 3.1.11: https://repository.apache.org/content/repositories/orgapachecxf-1088/ Tags: 3.0.13: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=444c58f6d36243e1a73efe3f0e748091cfbd499b 3.1.11: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=2ae6483276825a93e7ebe40fbcfc11866d364530 Here is my +1. Vote will be open for at least 72h. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: cxf git commit: [CXF-7281] Create new Logging annotation that allows to configure all settings
Oops :-) It is also not ignored by default. Christian 2017-03-13 18:37 GMT+01:00 Daniel Kulp <dk...@apache.org>: > > > On Mar 13, 2017, at 12:50 PM, cschnei...@apache.org wrote: > > > > +/** > > + * Ignore binary payloads by default > > + */ > > +boolean logMultiplart() default true; > > +} > > > Multiplart? :) > > > -- > Daniel Kulp > dk...@apache.org - http://dankulp.com/blog > Talend Community Coder - http://coders.talend.com > > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
[Discuss] How do we remove the old logging
For some time now we have the new logging system (located in rt/features/logging). I would like to discuss how we transition to the new system. I propose the following: We deprecate all parts of the old logging system and define a CXF version when it will be removed. The new logging should completely life in the features/logging module. I propose we remove the old logging either in CXF 3.3 or in CXF 4 depending if we plan to do a new major version in mid term (~ a year). As soon as we decided which version to remove the logging in we should document the planned removal in the javadoc of the entry points of logging and on the website. So people will have an early warning. Some implications when switching to the new system: - When using the class switch to this class: org.apache.cxf.ext.logging.LoggingFeature - When using the annotation: Switch to org.apache.cxf.ext.logging.Logging - The xml namespace will not exist in the new system. Use either the class or the annotation - Some configs of the old system will not exist in the new one. In general it the new system should be more flexible though Dan is following a slightly different style by for example reusing the old @Logging annotation and not deprecating it. I personally would like to avoid that to have a clean cut. What do you think? Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] - Release Apache CXF DOSGi 2.1.0
This vote passes with 5 +1 and no other votes. I will deploy the artifacts. Christian On 11.02.2017 19:53, Christian Schneider wrote: This is a vote to release Apache CXF DOSGi 2.1.0. I just found the documentation does not yet reflect the new features. I will fix that asap on master. This is not ideal but I guess most people use the docs from master anyway. Release Notes - CXF Distributed OSGi - Version 2.1.0 ** Bug * [DOSGI-258] - itests fail when port 8080 is in use ** Improvement * [DOSGI-251] - Allow to export services with less service properties * [DOSGI-256] - ContextResolver intents should be registered as providers * [DOSGI-257] - Allow to set bus properties Tag: https://git-wip-us.apache.org/repos/asf?p=cxf-dosgi.git;a=tag;h=refs/tags/cxf-dosgi-2.1.0 Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1086 Repo mirror: https://github.com/apache/cxf-dosgi +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[VOTE] - Release Apache CXF DOSGi 2.1.0
This is a vote to release Apache CXF DOSGi 2.1.0. I just found the documentation does not yet reflect the new features. I will fix that asap on master. This is not ideal but I guess most people use the docs from master anyway. Release Notes - CXF Distributed OSGi - Version 2.1.0 ** Bug * [DOSGI-258] - itests fail when port 8080 is in use ** Improvement * [DOSGI-251] - Allow to export services with less service properties * [DOSGI-256] - ContextResolver intents should be registered as providers * [DOSGI-257] - Allow to set bus properties Tag: https://git-wip-us.apache.org/repos/asf?p=cxf-dosgi.git;a=tag;h=refs/tags/cxf-dosgi-2.1.0 Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1086 Repo mirror: https://github.com/apache/cxf-dosgi +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[Heads up] CXF-DOSGi release this weekend
I would like to do another CXF-DOSGi release this weekend. It is now more than 3 months since the last release and we fixed some issues: See https://issues.apache.org/jira/browse/DOSGI/fixforversion/12338258 So if anyone wants to get something into the release now would be a good time. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] Apache CXF 3.1.10
+1 Christian On 27.01.2017 20:28, Daniel Kulp wrote: This is a vote for Apache CXF 3.1.10. We’ve fixed a bunch of issues and I’d like to get it out so we can start trying to concentrate on getting 3.2 out. Staging area: https://repository.apache.org/content/repositories/orgapachecxf-1085/ Tag: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=59f79f3cfca1beb6e8f3a3a3f60f7d1d62eb8422 Vote will be open for 72h. Here is my +1. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[DISCUSS] Add promotion for Apache events on website
On the apache member list there is the request to help promoting the next Apachecon. The proposal is to add the snippet below our web site. This allows the foundation to promote the current event. I would like to help with this effort. Any opinions? Christian --- http://www.apache.org/events/current-event.html;> http://www.apache.org/events/current-event-{size}.png"/> where {size} = 125x125 or 234x60 Maintenance of current-event* files: - update text in content/events/current-event.mdtext - replace content/events/current-event-*.png files with the new versions from content/ads/ApacheCon See also content/ads/README.txt -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] - Release Apache CXF XJC Utils 3.1.0
+1 Christian On 15.12.2016 17:32, Colm O hEigeartaigh wrote: This is a vote to release Apache CXF XJC Utils 3.1.0. Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1084/ Git tag: https://git-wip-us.apache.org/repos/asf?p=cxf-xjc-utils.git;a=commit;h=729224ef42279fff2c7faeb0d2e7c7a4152799ad Issues fixed: https://issues.apache.org/jira/browse/CXFXJC/fixforversion/12338810 +1 from me. Colm. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] CXF 3.1.9 and 3.0.12
Would it be ok to tackle this in the next bugfix release and maybe get it out a little quicker? (Like 2-3 weeks instead of the usual 4 weeks) Christian On 11.12.2016 17:27, John D. Ament wrote: No, I -0'd a release because something's busted. I raised the PR to fix that busted thing. John On Sun, Dec 11, 2016 at 11:03 AM Jeff Genender <jgenen...@apache.org> wrote: You -0’d a release because the pull request that you submitted at 12/11/16 15:30 GMT didn’t make it into a release whose vote was kicked off nearly 42 hours before at 12/9/16 21:47 GMT? Seriously? Jeff On Dec 11, 2016, at 7:16 AM, John D. Ament <johndam...@apache.org> wrote: I did find one issue. Its not a new issue, but the CDI integration changes made the problem more profound when using CXF + Weld in an Arquillian test. https://issues.apache.org/jira/browse/CXF-7175 So -0 since I won't be able to upgrade yet. On Fri, Dec 9, 2016 at 3:47 PM Daniel Kulp <dk...@apache.org> wrote: Since there are several folks waiting for this release and it would be good to get it out before the holidays, I’d like to call a vote for CXF 3.1.9 and 3.0.12. Staging areas: 3.1.9: https://repository.apache.org/content/repositories/orgapachecxf-1083/ 3.0.12: https://repository.apache.org/content/repositories/orgapachecxf-1082/ Tags: 3.0.12: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=commit;h=c98cb3181ae1153c37240a851aefe8e4f3a40ae9 3.1.9: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=commit;h=7cd4d49a7fe7d24a715192112a2170bdd708e6c7 Vote will be open for 72h. Here is my +1. -- Daniel Kulp dk...@apache.org - http://dankulp.com/blog Talend Community Coder - http://coders.talend.com -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] CXF 3.1.9 and 3.0.12
+1 Christian 2016-12-10 19:51 GMT+01:00 Francesco Chicchiriccò <ilgro...@apache.org>: > On 9 Dec 2016 21:47:05 CET, Daniel Kulp <dk...@apache.org> wrote: > >Since there are several folks waiting for this release and it would be > >good to get it out before the holidays, I’d like to call a vote for CXF > >3.1.9 and 3.0.12. > > > >Staging areas: > >3.1.9: > >https://repository.apache.org/content/repositories/orgapachecxf-1083/ > >3.0.12: > >https://repository.apache.org/content/repositories/orgapachecxf-1082/ > > > >Tags: > >3.0.12: > >https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=commit;h= > c98cb3181ae1153c37240a851aefe8e4f3a40ae9 > >3.1.9: > >https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=commit;h= > 7cd4d49a7fe7d24a715192112a2170bdd708e6c7 > > > > > >Vote will be open for 72h. > > +1 > Regards > > -- > Francesco Chicchiriccò > > Tirasa - Open Source Excellence > http://www.tirasa.net/ > > Member at The Apache Software Foundation Syncope, Cocoon, Olingo, CXF, > OpenJPA, PonyMail > http://home.apache.org/~ilgrosso/ > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: cxf git commit: [CXF-7164] Support tracing using Zipkin Brave
The new logging support in rt/features/logging already creates exchange id and message id. It also allows to send the message id over the wire. I have already fed the data into elastic search. There I was able to correlate request to reply and request sent out from the client to request received on the server. Would that already work? See http://cxf.apache.org/docs/message-logging.html Christian On 08.12.2016 08:58, Romain Manni-Bucau wrote: Hello guys, would it make sense to have a lighter tracker in cxf? idea is just to have a header accumulator but not all the data zipkin requires. I often saw it used in companies to track the data path but often it is self contained and only contains the host list. In term of delivery it would be a jaxrs client/server provider (or interceptor) to handle the header and soap equivalent probably. Wdyt? (to make it clear client1 would send Cxf-Tracking: host1, if received on host2 the program does another request it will send Cxf-Tracking: host1,host2 etc...) -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: cxf git commit: [CXF-7164] Support tracing using Zipkin Brave
Would be great if we could work together on this. I saw that you were part of the brave-cxf development. Maybe you could start with the actual tracing in cxf. For me another important part is the brave OSGi integration and CXF-DOSGi integration. So I could start with that. I am not sure where to put the brave OSGi part as it is not really related to CXF but an important prerequisite to get it working in OSGi. Maybe this can go to brave itself. I am thinking about a config driven Brave OSGi service. So you simply need to create a config and get a working service. The CXF tracing could then simply inject the Brave service instead of taking care of the Brave setup directly. Christian 2016-12-07 15:50 GMT+01:00 Andrey Redko <drr...@gmail.com>: > I think it is very good idea to integrate brave-cxf into CXF. Christian, do > you have enough time to work on that? I think I could help you out with > that, I have reviewed brave-cxf PRs awhile back. Thanks. > > On Wed, Dec 7, 2016 at 5:00 AM, Christian Schneider < > ch...@die-schneider.net > > wrote: > > > I just talked to Adrian Cole. He prefers to have the brave cxf > integration > > in cxf instead of brave. So we can go ahead and improve the module in cxf > > and he will deprecate the > > brave-cxf module in brave once ours is good enough to cover all cases. > > > > Christian > > > > On 07.12.2016 11:46, Sergey Beryozkin wrote: > > > >> Hi Christian > >> > >> May be you can contribute your CXF Brave Feature code to the Brave CXF 3 > >> module (the docs show the interceptors are registered directly) ? > Otherwise > >> Brave and CXF own Brave interceptors will start competing for who has > the > >> latest code :-) > >> > >> CXF HTrace is quite advanced thanks to the work Andriy did. But I > believe > >> your reservation about it was that HTrace was not working well in OSGI. > >> > >> But if CXF RS/WS services are running in Spring Boot or other non-OSGI > >> containers then what we have with HTrace is good. We'd like to consider > >> enhancing it a bit: > >> > >> https://issues.apache.org/jira/browse/CXF-7129 > >> > >> so that the hTrac-ing can be optionally implicit. > >> > >> Cheers, Sergey > >> > > > > -- > > Christian Schneider > > http://www.liquid-reality.de > > > > Open Source Architect > > http://www.talend.com > > > > > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: cxf git commit: [CXF-7164] Support tracing using Zipkin Brave
I just talked to Adrian Cole. He prefers to have the brave cxf integration in cxf instead of brave. So we can go ahead and improve the module in cxf and he will deprecate the brave-cxf module in brave once ours is good enough to cover all cases. Christian On 07.12.2016 11:46, Sergey Beryozkin wrote: Hi Christian May be you can contribute your CXF Brave Feature code to the Brave CXF 3 module (the docs show the interceptors are registered directly) ? Otherwise Brave and CXF own Brave interceptors will start competing for who has the latest code :-) CXF HTrace is quite advanced thanks to the work Andriy did. But I believe your reservation about it was that HTrace was not working well in OSGI. But if CXF RS/WS services are running in Spring Boot or other non-OSGI containers then what we have with HTrace is good. We'd like to consider enhancing it a bit: https://issues.apache.org/jira/browse/CXF-7129 so that the hTrac-ing can be optionally implicit. Cheers, Sergey -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: cxf git commit: [CXF-7164] Support tracing using Zipkin Brave
Damn ... I just found there is also general CXF support for brave at https://github.com/openzipkin/brave/tree/master/brave-cxf3 . So maybe this already solved the problem before. We should decide how to proceed. I think one approach is to help at brave-cxf3 to make it as good as possible and revert the cxf module I created. The other is to focus on the cxf trace zipkin module .. Actually I am not sure what is the better option. Any opinions? Christian 2016-12-06 20:49 GMT+01:00 Andrey Redko <drr...@gmail.com>: > That's right, the JAX-RS part should be supported by Brave already thanks > to dedicated CXF integration (I was involved in late-stage discussions for > the PR in question but not in the implementation). > > Best Regards, > Andriy Redko > > On Tue, Dec 6, 2016 at 12:09 PM, Christian Schneider < > ch...@die-schneider.net> wrote: > > > My orignal plan was to just support SOAP as REST is well supported by > brave > > rest support already. > > In the end my code was able to support both REST and SOAP without much > > overhead so I removed the soap package again. > > > > Christian > > > > 2016-12-06 14:41 GMT+01:00 Sergey Beryozkin <sberyoz...@gmail.com>: > > > > > Christian, what is SOAP specific in this code ? > > > Looks like that can work with JAX-RS too ? > > > > > > Usually we try to accommodate both frontends, example, Andriy Redko > made > > > sure HTrace interceptors work for JAXWS, similarly for Bean validation > > > > > > Sergey > > > > > > > > > > > > On 06/12/16 13:36, cschnei...@apache.org wrote: > > > > > >> Repository: cxf > > >> Updated Branches: > > >> refs/heads/master 892a4ca84 -> fd77d3f33 > > >> > > >> > > >> [CXF-7164] Support tracing using Zipkin Brave > > >> > > >> > > >> Project: http://git-wip-us.apache.org/repos/asf/cxf/repo > > >> Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/fd77d3f3 > > >> Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/fd77d3f3 > > >> Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/fd77d3f3 > > >> > > >> Branch: refs/heads/master > > >> Commit: fd77d3f3380f805db3547d37cbb2ff72bd033ad0 > > >> Parents: 892a4ca > > >> Author: Christian Schneider <ch...@die-schneider.net> > > >> Authored: Tue Dec 6 14:35:35 2016 +0100 > > >> Committer: Christian Schneider <ch...@die-schneider.net> > > >> Committed: Tue Dec 6 14:36:01 2016 +0100 > > >> > > >> > -- > > >> rt/features/pom.xml | 1 + > > >> rt/features/tracing-brave/pom.xml | 87 + > > >> .../brave/soap/CxfHttpClientRequest.java| 49 > > >> .../tracing/brave/soap/CxfServerRequest.java| 48 > > >> .../cxf/tracing/brave/soap/HttpResponse200.java | 28 + > > >> .../cxf/tracing/brave/soap/ParsedMessage.java | 121 > > >> +++ > > >> .../cxf/tracing/brave/soap/TraceFeature.java| 50 > > >> .../tracing/brave/soap/TraceInInterceptor.java | 58 + > > >> .../tracing/brave/soap/TraceOutInterceptor.java | 57 + > > >> .../cxf/tracing/brave/soap/BraveTraceTest.java | 99 > +++ > > >> .../brave/soap/LoggingSpanNameProvider.java | 31 + > > >> .../cxf/tracing/brave/soap/MyService.java | 26 > > >> .../cxf/tracing/brave/soap/MyServiceImpl.java | 28 + > > >> 13 files changed, 683 insertions(+) > > >> > -- > > >> > > >> > > >> http://git-wip-us.apache.org/repos/asf/cxf/blob/fd77d3f3/rt/ > > >> features/pom.xml > > >> > -- > > >> diff --git a/rt/features/pom.xml b/rt/features/pom.xml > > >> index 0365bf6..a4cfdff 100644 > > >> --- a/rt/features/pom.xml > > >> +++ b/rt/features/pom.xml > > >> @@ -34,5 +34,6 @@ > > >> logging > > >> metrics > > >> throttling > > >> +tracing-brave > > >> > > >> > > >> > > >> http://git-wip-us.apache.org/repos/asf/cxf/blo
Re: cxf git commit: [CXF-7164] Support tracing using Zipkin Brave
My orignal plan was to just support SOAP as REST is well supported by brave rest support already. In the end my code was able to support both REST and SOAP without much overhead so I removed the soap package again. Christian 2016-12-06 14:41 GMT+01:00 Sergey Beryozkin <sberyoz...@gmail.com>: > Christian, what is SOAP specific in this code ? > Looks like that can work with JAX-RS too ? > > Usually we try to accommodate both frontends, example, Andriy Redko made > sure HTrace interceptors work for JAXWS, similarly for Bean validation > > Sergey > > > > On 06/12/16 13:36, cschnei...@apache.org wrote: > >> Repository: cxf >> Updated Branches: >> refs/heads/master 892a4ca84 -> fd77d3f33 >> >> >> [CXF-7164] Support tracing using Zipkin Brave >> >> >> Project: http://git-wip-us.apache.org/repos/asf/cxf/repo >> Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/fd77d3f3 >> Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/fd77d3f3 >> Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/fd77d3f3 >> >> Branch: refs/heads/master >> Commit: fd77d3f3380f805db3547d37cbb2ff72bd033ad0 >> Parents: 892a4ca >> Author: Christian Schneider <ch...@die-schneider.net> >> Authored: Tue Dec 6 14:35:35 2016 +0100 >> Committer: Christian Schneider <ch...@die-schneider.net> >> Committed: Tue Dec 6 14:36:01 2016 +0100 >> >> -- >> rt/features/pom.xml | 1 + >> rt/features/tracing-brave/pom.xml | 87 + >> .../brave/soap/CxfHttpClientRequest.java| 49 >> .../tracing/brave/soap/CxfServerRequest.java| 48 >> .../cxf/tracing/brave/soap/HttpResponse200.java | 28 + >> .../cxf/tracing/brave/soap/ParsedMessage.java | 121 >> +++ >> .../cxf/tracing/brave/soap/TraceFeature.java| 50 >> .../tracing/brave/soap/TraceInInterceptor.java | 58 + >> .../tracing/brave/soap/TraceOutInterceptor.java | 57 + >> .../cxf/tracing/brave/soap/BraveTraceTest.java | 99 +++ >> .../brave/soap/LoggingSpanNameProvider.java | 31 + >> .../cxf/tracing/brave/soap/MyService.java | 26 >> .../cxf/tracing/brave/soap/MyServiceImpl.java | 28 + >> 13 files changed, 683 insertions(+) >> -- >> >> >> http://git-wip-us.apache.org/repos/asf/cxf/blob/fd77d3f3/rt/ >> features/pom.xml >> -- >> diff --git a/rt/features/pom.xml b/rt/features/pom.xml >> index 0365bf6..a4cfdff 100644 >> --- a/rt/features/pom.xml >> +++ b/rt/features/pom.xml >> @@ -34,5 +34,6 @@ >> logging >> metrics >> throttling >> +tracing-brave >> >> >> >> http://git-wip-us.apache.org/repos/asf/cxf/blob/fd77d3f3/rt/ >> features/tracing-brave/pom.xml >> -- >> diff --git a/rt/features/tracing-brave/pom.xml >> b/rt/features/tracing-brave/pom.xml >> new file mode 100644 >> index 000..9af22e4 >> --- /dev/null >> +++ b/rt/features/tracing-brave/pom.xml >> @@ -0,0 +1,87 @@ >> + >> + >> +http://maven.apache.org/POM/4.0.0; xmlns:xsi=" >> http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://mav >> en.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd;> >> +4.0.0 >> +cxf-rt-features-tracing-brave >> +jar >> +Apache CXF Tracing using Zipkin Brave >> +http://cxf.apache.org >> + >> +org.apache.cxf >> +cxf-parent >> +3.2.0-SNAPSHOT >> +../../../parent/pom.xml >> + >> + >> + >> + >> +org.apache.cxf.tracing.brave.soap >> + >> +3.15.1 >> + >> + >> + >> + >> +junit >> +junit >> +test >> + >> + >> +org.apache.cxf >> +cxf-core >> +${project.version} >> + >> + >> + >> +org.apache.cxf >> +cxf-rt-features-logging >> +${project.version} >> + >> + >> + io.zipkin.brave >> + brave-core >>
Re: [ANNOUNCE] Introducing Microbule...
One thing about the implementation. I noticed that microbule is using blueprint for its own setup. I would switch this rather to DS as it has a smaller footprint. If someone is using microbule with DS then the blueprint overhead is substantial. If someone would use a DS based microbule with blueprint then the DS overhead would be a lot smaller. Christian On 21.11.2016 19:03, James Carman wrote: We've been working on a Microservices framework called "Microbule" which leverages CXF and Karaf (hence the cross-post): https://github.com/jwcarman/microbule The idea is to make writing Microservices easy and fun, by providing many of the oft-requested features for you out-of-the-box (CORS, Caching, JSON transformation, validation, etc.). There's a README page that explains how to install/run Microbule in Karaf and how to write your own services. If you're interested, take it for a spin and let us know what you think. Thanks, James -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [ANNOUNCE] Introducing Microbule...
I really like the microbule project scope. We really need a project that can bring mircoservice development on CXF and OSGi to the same level as spring boot. I am only concerned that many different projects seem to cover parts of this at the moment. So if we are not careful we again will have too many separate efforts inside the already small OSGi space. Some things you might want to look into: In the CXF-DOSGi samples I have bndrun that shows how to package cxf and the felix http service. https://github.com/apache/cxf-dosgi/blob/master/samples/soap/soap.bndrun I used the /myservice addresses and it works quite well. Felix http service is a a lot simpler to deploy than pax web. As CXF-DOSGi just uses the HttpService it is easy to use pax-web when deployed in karaf and felix http service for microservice like deployments. Another project to look into is the Aries JAX-RS-whiteboard. It is implementing the JAX-RS Whiteboard OSGi spec in Aries. Your project should have a big overlap with CXF-DOSGi and JAX-RS-whiteboard. I wonder if we could combine these efforts. One possible solution would be to concentrate the efforts of exporting REST services in JAX-RS whiteboard. Then your framework could concentrate on the remaining aspects of microservices like circuit breaker, discovery and packaging. The Aries JAX-RS whiteboard project is currently in a very early stage. So I think this should provide a great opportunity to get your ideas into the project. Another interesting part of JAX-RS whiteboard is that it can provide OSGi enabled JAX-RS ClientBuilder instances. So that could be used to create clients without depending on CXF in the user code. CXF-DOSGi on the other hand can provide fully transparent type safe clients as OSGi services which could also provide some value. I am also working on getting zipkin and brave tracing working inside OSGi. See https://github.com/cschneider/brave-osgi-example Brave already offers JAX-RS interceptors for logging and I added a PR to offer a jax-rs Feature. That will make it really easy to add tracing to CXF and any other JAX-RS 2 impl. Before that I was not aware that JAX-RS has such a nice portable Feature interface. So I think a lot of the microservice features like circuit breaker could be created in a portable way. This would give the user the free choice of the JAX-RS impl. I also had pretty good experiences using bndtools to create the packaging into a runnable jar. The result is a lot smaller than karaf (~9mb for a full REST example) and matches the docker concepts better. Sorry for this highly uncohesive list but I just wanted to give you some ideas to pursue :-) Christian On 22.11.2016 21:55, Benson Margulies wrote: A small update with some irony here. At the job I just finished today, we reached the conclusion that we weren't getting much value out of Karaf and pax-web; no criticism intended, we just don't dynamically provision, and we don't need any HTTP except for CXF services. So, over the last few weeks, we refactored the thing to use cxf-rt-transport-http-jetty in the Felix container, with our own rather tiny class responsible for launching. We lost a bit of flexibility in that we can't create an endpoint 'inside' of the namespace of another endpoint, but otherwise it works just fine. The code that that I showed James is hardly changed at all. The endpoint addresses now look like "http://0.0.0.0:n/base/whatever; instead "/whatever". Maybe some day there will be an ultramicrobule that anticipates this mode of operation. On Mon, Nov 21, 2016 at 7:13 PM, James Carman <ja...@carmanconsulting.com> wrote: Small update. Microbule 0.1.0 release has been cut and will soon be available in Maven Central (awaiting sync from Nexus OSS). Enjoy, folks! On Mon, Nov 21, 2016 at 1:03 PM James Carman <ja...@carmanconsulting.com> wrote: We've been working on a Microservices framework called "Microbule" which leverages CXF and Karaf (hence the cross-post): https://github.com/jwcarman/microbule The idea is to make writing Microservices easy and fun, by providing many of the oft-requested features for you out-of-the-box (CORS, Caching, JSON transformation, validation, etc.). There's a README page that explains how to install/run Microbule in Karaf and how to write your own services. If you're interested, take it for a spin and let us know what you think. Thanks, James -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] CXF 3.0.11/3.1.8
+1 Christian On 14.10.2016 20:59, Daniel Kulp wrote: This is a vote to release 3.0.11/3.1.8. We’ve resolved over 55 issues for 3.1.8. Staging areas: 3.1.8: https://repository.apache.org/content/repositories/orgapachecxf-1081/ 3.0.11: https://repository.apache.org/content/repositories/orgapachecxf-1080/ Tags: 3.1.8: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=80473c6a929cd797d5b0b0134f31818a716011e8 3.0.11: https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=209f5f9d04b2b49e05c4894034a719eea40bd0e4 Here is my +1 -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [Discuss] Move spring and blueprint support out of cxf-core
On 30.09.2016 17:56, Guillaume Nodet wrote: 2016-09-30 16:28 GMT+02:00 Christian Schneider <ch...@die-schneider.net>: I hope we can get DOSGi on the same level as CXF + blueprint. Basically we just need to make sure we provide a programmatic way to configure all aspects of CXF (e.g. using Features). The big advantage is that this will bring first class CXF support to all other platforms too. So my first goal is to get the most important CXF features configureable. I think with CXF DOSGi 2 we should already cover the need of most users. Maybe not yet as convenient as possible but at least possible. Having a programmatic way to configure CXF is not really specific to DOSGi, is it ? Exactly. This is why I want to make sure we support it. It will help other platforms too and also help people who want to provide specific tooling for a platform. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [Discuss] Move spring and blueprint support out of cxf-core
I hope we can get DOSGi on the same level as CXF + blueprint. Basically we just need to make sure we provide a programmatic way to configure all aspects of CXF (e.g. using Features). The big advantage is that this will bring first class CXF support to all other platforms too. So my first goal is to get the most important CXF features configureable. I think with CXF DOSGi 2 we should already cover the need of most users. Maybe not yet as convenient as possible but at least possible. Christian 2016-09-30 14:51 GMT+02:00 Sergey Beryozkin <sberyoz...@gmail.com>: > Christian, I'll be happy to see DOSGI getting more attention but this > 'simply use DOSGI' will simply not work - the flexibility of Blueprint (and > Spring in or outside of OSGI) is rated highly by the CXF users. > DOSGI has its niche but it has its limitations too. > > Cheers, Sergey > > > > > On 30/09/16 12:59, Christian Schneider wrote: > >> Hi Benson, >> >> DS and CXF already work quite well. Simply use CXF-DOSGi to expose and use >> services. >> The new samples in version 2.0 all use DS. >> >> https://github.com/apache/cxf-dosgi/tree/master/samples >> >> Honestly I think the blueprint / spring namespaces never were such a good >> idea. They are much too intrusive. >> I plan to point people to using DOSGi as the default way of using CXF in >> OSGi. >> >> Christian >> >> >> >> 2016-09-29 17:07 GMT+02:00 Benson Margulies <bimargul...@gmail.com>: >> >> There's more to OSGi than Blueprint. I'd be very happy to use CXF with >>> DS and no blueprint. >>> >>> On Thu, Sep 29, 2016 at 8:13 AM, Andrei Shakirin <ashaki...@talend.com> >>> wrote: >>> >>>> Just more detail description: >>>> >>>> After removing the optional spring imports packages from CXF jars >>>> >>> Manifests, the users still can use CXF with Spring in Web, JEE and >>> standalone deployments, but not in OSGi with SpringDM. >>> >>>> >>>> Removing can be done for example with maven bundle plugin instruction: >>>> >>>> org.apache.felix >>>> maven-bundle-plugin >>>> true >>>> >>>> >>>> >>>> !org.springframework*, >>>> * >>>> >>>> >>>> >>>> >>>> >>>> CXF reloading issue should be fixed with that. >>>> >>>> However the OSGi users using CXF in OSGi with SpringDM wouldn't be >>>> >>> supported anymore. >>> >>>> >>>> WDYT? >>>> >>>> Regards, >>>> Andrei. >>>> >>>> -Original Message- >>>>> From: Andrei Shakirin [mailto:ashaki...@talend.com] >>>>> Sent: Freitag, 23. September 2016 18:09 >>>>> To: dev@cxf.apache.org >>>>> Subject: RE: [Discuss] Move spring and blueprint support out of >>>>> cxf-core >>>>> >>>>> Hi Christian, >>>>> >>>>> Regarding Karaf4 and OSGi: as Guillaume says the Spring DM isn't >>>>> >>>> supported >>> >>>> anymore. >>>>> I am not sure how many users still use CXF + Spring in OSGi. >>>>> Do you think it will be an option just to remove optional spring >>>>> >>>> imports from >>> >>>> the Manifest (for example using maven bundle plugin)? >>>>> >>>>> Regards, >>>>> Andrei. >>>>> >>>>> -Original Message- >>>>>> From: Christian Schneider [mailto:cschneider...@gmail.com] On Behalf >>>>>> Of Christian Schneider >>>>>> Sent: Freitag, 23. September 2016 17:29 >>>>>> To: dev@cxf.apache.org >>>>>> Subject: Re: [Discuss] Move spring and blueprint support out of >>>>>> cxf-core >>>>>> >>>>>> Hmm .. the dynamic imports would be worth a try. The namespaces might >>>>>> work this way. >>>>>> The focus is indeed mainly on spring though as blueprint is pre >>>>>> installed most times and is only present in one version. >>>>>> >>>>>> Christian >>>>>> >>>>>> On 23.09.2016 16:38, Guillaume Nodet wrote: >>>>>> >>>>>>> I think w
Re: [Discuss] Move spring and blueprint support out of cxf-core
I am still hoping for better CDI support in OSGi. So that would be really cool. On the other hand I think DS can do the job in most cases. With CXF-DOSGi for services and JPATemplate or tx-control for db access DS is already quite usable in the enterprise space. I just did an OSGi training at a customer. We chose blueprint with the blueprint-maven-plugin as the customer already knows it but all the code we did would have worked with DS too. Christian 2016-09-29 17:10 GMT+02:00 Guillaume Nodet <gno...@apache.org>: > But DS provides no extension point and can't really be used to do pure > dependency injection. > I'd think CDI might be a better goal if we want to support a new framework. > > Guillaume > > 2016-09-29 17:07 GMT+02:00 Benson Margulies <bimargul...@gmail.com>: > > > There's more to OSGi than Blueprint. I'd be very happy to use CXF with > > DS and no blueprint. > > > > On Thu, Sep 29, 2016 at 8:13 AM, Andrei Shakirin <ashaki...@talend.com> > > wrote: > > > Just more detail description: > > > > > > After removing the optional spring imports packages from CXF jars > > Manifests, the users still can use CXF with Spring in Web, JEE and > > standalone deployments, but not in OSGi with SpringDM. > > > > > > Removing can be done for example with maven bundle plugin instruction: > > > > > > org.apache.felix > > > maven-bundle-plugin > > > true > > > > > > > > > > > > !org.springframework*, > > > * > > > > > > > > > > > > > > > > > > CXF reloading issue should be fixed with that. > > > > > > However the OSGi users using CXF in OSGi with SpringDM wouldn't be > > supported anymore. > > > > > > WDYT? > > > > > > Regards, > > > Andrei. > > > > > >> -Original Message- > > >> From: Andrei Shakirin [mailto:ashaki...@talend.com] > > >> Sent: Freitag, 23. September 2016 18:09 > > >> To: dev@cxf.apache.org > > >> Subject: RE: [Discuss] Move spring and blueprint support out of > cxf-core > > >> > > >> Hi Christian, > > >> > > >> Regarding Karaf4 and OSGi: as Guillaume says the Spring DM isn't > > supported > > >> anymore. > > >> I am not sure how many users still use CXF + Spring in OSGi. > > >> Do you think it will be an option just to remove optional spring > > imports from > > >> the Manifest (for example using maven bundle plugin)? > > >> > > >> Regards, > > >> Andrei. > > >> > > >> > -Original Message- > > >> > From: Christian Schneider [mailto:cschneider...@gmail.com] On > Behalf > > >> > Of Christian Schneider > > >> > Sent: Freitag, 23. September 2016 17:29 > > >> > To: dev@cxf.apache.org > > >> > Subject: Re: [Discuss] Move spring and blueprint support out of > > >> > cxf-core > > >> > > > >> > Hmm .. the dynamic imports would be worth a try. The namespaces > might > > >> > work this way. > > >> > The focus is indeed mainly on spring though as blueprint is pre > > >> > installed most times and is only present in one version. > > >> > > > >> > Christian > > >> > > > >> > On 23.09.2016 16:38, Guillaume Nodet wrote: > > >> > > I think we can solve the refresh problem from blueprint : > > >> > >* remove the bundle activators that registers the blueprint > > handlers > > >> > >* create an extender which will scan for the blueprint.handlers > > >> > > files in bundles and register the namespaces > > >> > >* replace the cxf bundles Import-Package > > >> > > org.apache.aries.blueprint.* and > > >> > > org.osgi.service.blueprint.* packages with > DynamicImport-Package(s) > > >> > > I think this way, we should be able to deploy cxf-jaxws, then > deploy > > >> > > blueprint, and have blueprint namespaces available without having > > >> > > any cxf bundle refreshed. > > >> > > > > >> > > For spring, I'm not sure we can do the same. Though spring-dm is > > >> > > not supported anymore, so I think at some point, we can safely not > > >> > > support it
Re: [Discuss] Move spring and blueprint support out of cxf-core
Hi Benson, DS and CXF already work quite well. Simply use CXF-DOSGi to expose and use services. The new samples in version 2.0 all use DS. https://github.com/apache/cxf-dosgi/tree/master/samples Honestly I think the blueprint / spring namespaces never were such a good idea. They are much too intrusive. I plan to point people to using DOSGi as the default way of using CXF in OSGi. Christian 2016-09-29 17:07 GMT+02:00 Benson Margulies <bimargul...@gmail.com>: > There's more to OSGi than Blueprint. I'd be very happy to use CXF with > DS and no blueprint. > > On Thu, Sep 29, 2016 at 8:13 AM, Andrei Shakirin <ashaki...@talend.com> > wrote: > > Just more detail description: > > > > After removing the optional spring imports packages from CXF jars > Manifests, the users still can use CXF with Spring in Web, JEE and > standalone deployments, but not in OSGi with SpringDM. > > > > Removing can be done for example with maven bundle plugin instruction: > > > > org.apache.felix > > maven-bundle-plugin > > true > > > > > > > > !org.springframework*, > > * > > > > > > > > > > > > CXF reloading issue should be fixed with that. > > > > However the OSGi users using CXF in OSGi with SpringDM wouldn't be > supported anymore. > > > > WDYT? > > > > Regards, > > Andrei. > > > >> -Original Message- > >> From: Andrei Shakirin [mailto:ashaki...@talend.com] > >> Sent: Freitag, 23. September 2016 18:09 > >> To: dev@cxf.apache.org > >> Subject: RE: [Discuss] Move spring and blueprint support out of cxf-core > >> > >> Hi Christian, > >> > >> Regarding Karaf4 and OSGi: as Guillaume says the Spring DM isn't > supported > >> anymore. > >> I am not sure how many users still use CXF + Spring in OSGi. > >> Do you think it will be an option just to remove optional spring > imports from > >> the Manifest (for example using maven bundle plugin)? > >> > >> Regards, > >> Andrei. > >> > >> > -Original Message- > >> > From: Christian Schneider [mailto:cschneider...@gmail.com] On Behalf > >> > Of Christian Schneider > >> > Sent: Freitag, 23. September 2016 17:29 > >> > To: dev@cxf.apache.org > >> > Subject: Re: [Discuss] Move spring and blueprint support out of > >> > cxf-core > >> > > >> > Hmm .. the dynamic imports would be worth a try. The namespaces might > >> > work this way. > >> > The focus is indeed mainly on spring though as blueprint is pre > >> > installed most times and is only present in one version. > >> > > >> > Christian > >> > > >> > On 23.09.2016 16:38, Guillaume Nodet wrote: > >> > > I think we can solve the refresh problem from blueprint : > >> > >* remove the bundle activators that registers the blueprint > handlers > >> > >* create an extender which will scan for the blueprint.handlers > >> > > files in bundles and register the namespaces > >> > >* replace the cxf bundles Import-Package > >> > > org.apache.aries.blueprint.* and > >> > > org.osgi.service.blueprint.* packages with DynamicImport-Package(s) > >> > > I think this way, we should be able to deploy cxf-jaxws, then deploy > >> > > blueprint, and have blueprint namespaces available without having > >> > > any cxf bundle refreshed. > >> > > > >> > > For spring, I'm not sure we can do the same. Though spring-dm is > >> > > not supported anymore, so I think at some point, we can safely not > >> > > support it anymore. It could be replaced by the spring-dm > >> > > compatible support from aries blueprint, in which case, we have a > bit more > >> room to hack there. > >> > > But even with plain spring-dm, the same idea as above should work, > >> > > as both spring-dm and the spring support in aries-blueprint do use > >> > > an extender and scan for META-INF/spring.handlers. > >> > > > >> > > > >> > > > >> > > 2016-09-23 16:11 GMT+02:00 Christian Schneider <chris@die- > >> schneider.net>: > >> > > > >> > >> I agree. I would not make sense to have that many additional jars. > >> > >> On the other hand we cou
Re: [Discuss] Move spring and blueprint support out of cxf-core
Hmm .. the dynamic imports would be worth a try. The namespaces might work this way. The focus is indeed mainly on spring though as blueprint is pre installed most times and is only present in one version. Christian On 23.09.2016 16:38, Guillaume Nodet wrote: I think we can solve the refresh problem from blueprint : * remove the bundle activators that registers the blueprint handlers * create an extender which will scan for the blueprint.handlers files in bundles and register the namespaces * replace the cxf bundles Import-Package org.apache.aries.blueprint.* and org.osgi.service.blueprint.* packages with DynamicImport-Package(s) I think this way, we should be able to deploy cxf-jaxws, then deploy blueprint, and have blueprint namespaces available without having any cxf bundle refreshed. For spring, I'm not sure we can do the same. Though spring-dm is not supported anymore, so I think at some point, we can safely not support it anymore. It could be replaced by the spring-dm compatible support from aries blueprint, in which case, we have a bit more room to hack there. But even with plain spring-dm, the same idea as above should work, as both spring-dm and the spring support in aries-blueprint do use an extender and scan for META-INF/spring.handlers. 2016-09-23 16:11 GMT+02:00 Christian Schneider <ch...@die-schneider.net>: I agree. I would not make sense to have that many additional jars. On the other hand we could only create the extra modules for the most important bundles like jaxrs, jaxws, http and http jetty. These are the ones that people use a lot and that would cause most of the refreshs. Honestly I think we have too many special namespaces anyway. So at the start I would concentrate on the pain points above. Another approach might be to have some generic support for namespaces. After all the namespaces represent configuration. We could define the configuration in a neutral form (like pojos) and create the xsds as well as the spring or blueprint namespace handler registration centrally. Then there could be one module that collects and registers the spring namespaces and another for the blueprint ones. These modules would then also parse the user xml and return the common pojos. The approach might be a bit difficult to code but would save a lot of code in the individual modules. So this is not something I would start with but it could be a mid term goal. Christian On 23.09.2016 15:38, Daniel Kulp wrote: My biggest concern would be the “jar explosion” that would occur if you add a -blueprint and -spring jar for each of the jars that contains those. We already have a ton of jars, not sure adding another 30-40 is the best idea. Several years ago, I also started experimenting a bit: https://github.com/apache/cxf/tree/split-spring < https://github.com/apache/cxf/tree/split-spring> But didn’t really pursue it much further. On Sep 23, 2016, at 8:31 AM, Christian Schneider <ch...@die-schneider.net> wrote: On 23.09.2016 14:03, Sergey Beryozkin wrote: IMHO the most important thing is to preserve the CXF stability. FYI, CommomUtil helpers which can use Spring are heavily used - some of them in JAX-WS and a lot in JAX-RS. For example, JAX-RS SpringBoot starter does depend a lot on the ClassScanner Spring, and JAX-RS runtime depends in various places on ClassHelper to help with dealing with Spring proxified beans. The code which refers to these helpers can not afford to start referring to Spring variants because of course not all CXF users are Spring users. One needs to be aware that Spring (and now SpringBoot) is very much a major platform for many CXF users. We should definitely keep the good support for spring that we currently have. What I am not sure of is if we still need the pretty extensive xml namespaces in the future. The modern spring platform is now almost completely annotation based. So I can imagine that cxf 4 might drop xml namespaces in favor of comprehensive annotation based spring support. Personally I'd like see a very clear and concrete plan first: - How to preserve the runtime code portability which depends on CommonUtil helpers such that it works as before in/out of Spring I am not yet at the stage where I have a concrete plan. My first attempt was just to find out how deeply spring is wired into CXF. As it seems the unwrapping of proxies seems to be the most problematic part. So one first task is to find a good way to make this still work while having a separate module for the spring support. - How to keep CXF Spring user code which depends on Spring Namespace support (starting from cxf:bus and then for all other modules) operating. As a first step I would simply add the new cxf-core-spring jar to all modules that define namespaces. That might then not provide the full advantage of the separation but it should guarantee that all modules work as before. This change should make sure that refreshs only happen to mo
Re: [Discuss] Move spring and blueprint support out of cxf-core
I agree. I would not make sense to have that many additional jars. On the other hand we could only create the extra modules for the most important bundles like jaxrs, jaxws, http and http jetty. These are the ones that people use a lot and that would cause most of the refreshs. Honestly I think we have too many special namespaces anyway. So at the start I would concentrate on the pain points above. Another approach might be to have some generic support for namespaces. After all the namespaces represent configuration. We could define the configuration in a neutral form (like pojos) and create the xsds as well as the spring or blueprint namespace handler registration centrally. Then there could be one module that collects and registers the spring namespaces and another for the blueprint ones. These modules would then also parse the user xml and return the common pojos. The approach might be a bit difficult to code but would save a lot of code in the individual modules. So this is not something I would start with but it could be a mid term goal. Christian On 23.09.2016 15:38, Daniel Kulp wrote: My biggest concern would be the “jar explosion” that would occur if you add a -blueprint and -spring jar for each of the jars that contains those. We already have a ton of jars, not sure adding another 30-40 is the best idea. Several years ago, I also started experimenting a bit: https://github.com/apache/cxf/tree/split-spring <https://github.com/apache/cxf/tree/split-spring> But didn’t really pursue it much further. On Sep 23, 2016, at 8:31 AM, Christian Schneider <ch...@die-schneider.net> wrote: On 23.09.2016 14:03, Sergey Beryozkin wrote: IMHO the most important thing is to preserve the CXF stability. FYI, CommomUtil helpers which can use Spring are heavily used - some of them in JAX-WS and a lot in JAX-RS. For example, JAX-RS SpringBoot starter does depend a lot on the ClassScanner Spring, and JAX-RS runtime depends in various places on ClassHelper to help with dealing with Spring proxified beans. The code which refers to these helpers can not afford to start referring to Spring variants because of course not all CXF users are Spring users. One needs to be aware that Spring (and now SpringBoot) is very much a major platform for many CXF users. We should definitely keep the good support for spring that we currently have. What I am not sure of is if we still need the pretty extensive xml namespaces in the future. The modern spring platform is now almost completely annotation based. So I can imagine that cxf 4 might drop xml namespaces in favor of comprehensive annotation based spring support. Personally I'd like see a very clear and concrete plan first: - How to preserve the runtime code portability which depends on CommonUtil helpers such that it works as before in/out of Spring I am not yet at the stage where I have a concrete plan. My first attempt was just to find out how deeply spring is wired into CXF. As it seems the unwrapping of proxies seems to be the most problematic part. So one first task is to find a good way to make this still work while having a separate module for the spring support. - How to keep CXF Spring user code which depends on Spring Namespace support (starting from cxf:bus and then for all other modules) operating. As a first step I would simply add the new cxf-core-spring jar to all modules that define namespaces. That might then not provide the full advantage of the separation but it should guarantee that all modules work as before. This change should make sure that refreshs only happen to modules that provide namespaces. As a second step we should then check if we can improve on that. This all of course depends if we find a feasible solution and if the changes have the desired effect. In any case I will make sure that we keep all problematic changes in a branch so we can decide about them before they reach the master. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: TomEE CDI and CXF CDI
I also think is would be great to have the CDI support directly in cxf as a portable extension. It could then also be reused in pax-cdi for OSGi and also for standalone CDI cases. Christian On 23.09.2016 15:33, Sergey Beryozkin wrote: Hi Romain What do you think of trying to utilize CXF CDI code for the purpose of supporting CXF CDI services in TomEE ? You mentioned you had to hack ObjectHelper in TomEE so I guess CXF CDI code 'missed out' :-). We have some CDI experts here on the list so may be it can make sense... Thanks, Sergey -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [Discuss] Move spring and blueprint support out of cxf-core
On 23.09.2016 14:03, Sergey Beryozkin wrote: IMHO the most important thing is to preserve the CXF stability. FYI, CommomUtil helpers which can use Spring are heavily used - some of them in JAX-WS and a lot in JAX-RS. For example, JAX-RS SpringBoot starter does depend a lot on the ClassScanner Spring, and JAX-RS runtime depends in various places on ClassHelper to help with dealing with Spring proxified beans. The code which refers to these helpers can not afford to start referring to Spring variants because of course not all CXF users are Spring users. One needs to be aware that Spring (and now SpringBoot) is very much a major platform for many CXF users. We should definitely keep the good support for spring that we currently have. What I am not sure of is if we still need the pretty extensive xml namespaces in the future. The modern spring platform is now almost completely annotation based. So I can imagine that cxf 4 might drop xml namespaces in favor of comprehensive annotation based spring support. Personally I'd like see a very clear and concrete plan first: - How to preserve the runtime code portability which depends on CommonUtil helpers such that it works as before in/out of Spring I am not yet at the stage where I have a concrete plan. My first attempt was just to find out how deeply spring is wired into CXF. As it seems the unwrapping of proxies seems to be the most problematic part. So one first task is to find a good way to make this still work while having a separate module for the spring support. - How to keep CXF Spring user code which depends on Spring Namespace support (starting from cxf:bus and then for all other modules) operating. As a first step I would simply add the new cxf-core-spring jar to all modules that define namespaces. That might then not provide the full advantage of the separation but it should guarantee that all modules work as before. This change should make sure that refreshs only happen to modules that provide namespaces. As a second step we should then check if we can improve on that. This all of course depends if we find a feasible solution and if the changes have the desired effect. In any case I will make sure that we keep all problematic changes in a branch so we can decide about them before they reach the master. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[Discuss] Move spring and blueprint support out of cxf-core
Current state Currently cxf-core has optional dependencies on several spring and blueprint modules. Especially the spring dependencies are quite problematic. Problem Since apache karaf 4 the feature service will refresh bundles if any of their optional dependencies become available or change. So for example if you first install the cxf features and then install or change any spring bundles then cxf-core will have to refresh. As all cxf modules and most user code that involves services depends on cxf-core this causes half the bundles in karaf to refresh and restart. As not all code is able to handle this situation this can lead to some bundles not starting correctly again or starting but not fully working. Proposed Solution A solution could be to put the spring and blueprint dependent classes of cxf-core and potentially cxf-jaxws and cxf-jaxrs in separate bundles. Eventually we can keep the optional blueprint dependency as it is not very common that the blueprint bundles change at runtime. The result should be that there are less cases when all the bundles have to refresh. Especially if you do not use spring then refreshs should be quite rare after the change. Proof of concept See the branch https://github.com/apache/cxf/tree/poc-remove-spring-bp where I simply removed all spring and blueprint related classes. This at least allows to compile and test cxf-core. The other modules obviously will not work of course. What can be seen from the changes is that most spring and blueprint related classes are already in separate package which should make it relatively easy to move them into a spearate jar. The big notable exceptions are some classes in common.util. These would have to be moved. As the util classes should be internal to cxf I would not expect that many of our users would have changes in their own code. This small poc does not yet cover if we can make the extracted code work in its own bundle and if the result really helps much with the refreshs. Still I think it looks rather promising. Btw. I found another branch from Dan which is called split-spring which might have had a similar scope. I would be happy about any comments and feedback. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[RESULT][VOTE] - Release Apache CXF DOSGi 2.0.0
This vote passes with 7 +1 votes and no other votes. I will publish the artifacts. Christian 2016-09-14 16:16 GMT+02:00 Christian Schneider <ch...@die-schneider.net>: > This is a vote to release Apache CXF DOSGi 2.0.0. > > The main change in this version is to split the SOAP support from the REST > support. So it is now possible to only install SOAP support or only REST > support. The multi bundle distro still contains both variants but the karaf > features are now separate. > > As a new distro style we now offer a repository pom with the bundle > dependencies which is suitable to create a bndtools index from it. So it is > very easy to use CXF-DOSGi in bndtools. There is also such a repository pom > for the samples that contains everything needed to run the samples from > bndtools. The first example that uses this is the soap example. It contains > a soap.bndrun file that can be directly started and debugged from eclipse. > This pom based repo might be a replacement for the current multi bundle > distro as it is much smaller and more flexible. > > The bndtools based assembly uses the resolver to create a minimal set of > bundles for the sample. For SOAP and REST together I was able to make this > as small as 9 MB. For pure SOAP it is just 7.7 MB. > > Another big change is that the examples are now based on a slightly > changed TaskList service which is easier to understand that the previous > Greeter example. The examples now have karaf features to make it easy to > test them in karaf. > > Apart from these major changes I looked through the open issues and marked > a lot of them as fixed as they should be solved in the new code. Please > give feedback if anything is not yet solved. > I have not yet changed the wiki documentation to reflect the new code. As > it would be difficult to have the old and new documentation side by side in > the wiki I did most of the documentation in the code using github markdown > syntax. This allows to have the documentation closer to the code and also > will allow to look into the documentation of previous releases. > I plan to point to the gihub docs from the wiki and keep the old wiki > contents as documentation of the 1.x releases. > > You can find the new documentation here: > > https://github.com/apache/cxf-dosgi > > If you want to try the new code I recommend to follow the installation > instructions of the examples: > > https://github.com/apache/cxf-dosgi/tree/master/samples > > Btw. as usual .. until the release is pushed to maven central you will > have to add the maven repo listed below to your karaf instance. > Release Notes - CXF Distributed OSGi - Version 2.0.0 > > > ** Bug > * [DOSGI-19] - Discovery Software doesn't notice changed Service > Properties. > * [DOSGI-22] - It would benefit the RFC 119 TCK if multiple instances > of DOSGi could be run in a single OSGi container. > * [DOSGI-52] - -Dorg.apache.cxf.spring.validation.mode=VALIDATION_NONE > doesn't have an effect > * [DOSGI-73] - OSGi Declarative Service-based consumer does not > register proxy service on demand > * [DOSGI-108] - service.exported.interfaces doesn't support > comma-seperated String value > * [DOSGI-124] - ReceiveTimeout not configurable while using cxf-rest > service in OSGI > * [DOSGI-159] - Endpoint description contains wrong > org.apache.cxf.ws.address when using HTTPService style > * [DOSGI-171] - service objects are never released (using ungetService) > * [DOSGI-185] - Restarting of Jetty/PaxWeb makes exported services > unavailable > * [DOSGI-186] - documentation incorrect > * [DOSGI-187] - service configuration for service-namespace, > service-name and service-port only take affect if wsdl-location is also > configured > * [DOSGI-196] - Greeter demo does not work in standalone Felix > * [DOSGI-199] - NoSuchMethodError in tests (Jetty version mismatch) > * [DOSGI-209] - when bundles registers two WS with different > SoapBinding Style Document/RPC then one of the STYLE is not as expected > * [DOSGI-213] - ASM library not in Multibundle 1.6.0, so no naming of > webservice parameters possible > * [DOSGI-219] - DOSGi Fails to Publish Service Under Apache Karaf 3.0.3 > * [DOSGI-225] - Service publication with > org.apache.cxf.ws.httpservice.context > property does not work > * [DOSGI-226] - Cannot configure org.apache.cxf.dosgi.dsw.Activator > via Felix fileinstall > * [DOSGI-227] - Build fails with JDK 8 > * [DOSGI-236] - IllegalArgumentException: No SchemaFactory exception > during build > * [DOSGI-240] - Fix checkstyle in eclipse > * [DOSGI-242] - Refactor provider to prepare for split > > ** Improvement >
[VOTE] - Release Apache CXF DOSGi 2.0.0
and SSL example * [DOSGI-248] - Update to CXF 3.1.7 * [DOSGI-249] - Redesign examples * [DOSGI-250] - Support capabilities and requirements specified in RSA 1.1 ** New Feature * [DOSGI-211] - Support SOAP over JMS in DOSGI ** Task * [DOSGI-194] - Decide how DOSGi needs to handle service.exported.interfaces with multiple values Tag: https://git-wip-us.apache.org/repos/asf?p=cxf-dosgi.git;a=tag;h=33493e0ac7f19947fb250ee5f53feb68fde1c260 Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1079 +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[Heads up] CXF DOSGi 2.0.0 release soon (maybe next week)
The new major release of CXF DOSGi has matured quite nicely during the last weeks. The things left to do are * Solving the distribution question I handled in the previous mail (optionally) * Some improvements in the examples to make them more usable * Documentation on the CXF Wiki Apart from this I think we are almost ready for a CXF DOSGi release. So I would like to encourage everyone to try out the new version and give feedback if something important should be changed before the major release. I am also happy about any bug reports of course but it is even more important to review the changes. As the documentation is still a bit sparse in some areas I offer to help anyone personally who is willing to try the version on master. Below you can find a recap of how the new version is structured. The easiest way to test CXF-DOSGi is in apache karaf. The examples in the source should provide explanations of how to install in karaf. Apart from this I experiemented with bndtools based packaging which seems to be very suitable for microservice work. See https://github.com/cschneider/osgi-chat This is also backed by my talk Lean microservices on OSGi: http://www.slideshare.net/ChristianSchneider3/lean-microservices-on-osgi Christian --- So the goals for CXF DOSGi 2 were to make it simpler and more light weight and of course to fully support Java 8. So this is the new design looks like this: - cxf-dosgi-common : HttpServiceManager, IntentManager, ProxyFactory and other small util classes. These are all shared for the providers - cxf-dosgi-provider-ws: SOAP support. If @Webservice annotation is present it does JAXWS/JAXB if not it does Simple/Aegis - cxf-dosgi-provider-rs: REST support. Exposes the service as a default JAX-RS service. It has not property support for setting providers or interceptors - cxf-dosgi-decorator: Allows to expose services using xml. I am not sure if we still need this as Aries RSA can now expose services using configs - cxf-dosgi-repository: Pom that defines all dependencies to OSGi bundles. This can be used as a OSGi repository in the upcoming bnd and bndtools Both providers support intents which can be used to set DataBinding, Binding Config and Features. I think we might be missing support for JAXRS @Provider classes but I am not sure. Apart from this I removed all deprecated config properties and also slimmed down the other config properties. I hope we still cover most use cases but I need your feedback. I created some Readme.md docs in the source code to explain the current properties. The multi bundle distro is still there and is not really smaller as it still relies on the current karaf cxf and pax-web features which are really big. The karaf features are split into ws and rs. So we do not need to install everything at runtime. To show how small a DOSGi deployment can be I created a small example using bndtools and the repository above and was able to get a SOAP service exported with a runnable jar that just is about 6 MB. So I hope we can support much smaller deployments of CXF DOSGi in the future. Unfortunately I can not yet add this example to CXF DOSGi as it relies on some an experimental pom based repo plugin. As soon as this support is part of a bnd release I will add an example for this packaging. I also hope the new CXF DOSGi can be the default way for karaf boot to expose and consume REST services. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[Discuss] Alternatives to multi bundle distro in CXF-DOSGi
Current state Currently we build the multi bundle distro of CXF-DOSGi in this way: * Create a karaf feature file that also includes the CXF and Aries RSA feature files * Export the bundles using the karaf-maven-plugin with the goal features-add-to-repository * Export the bundle meta data using features-export-meta-data * Process the meta data using different xslt files to filter unwanted bundles and create the config for felix and equinox * Package all into a tar.gz What is the problem? One problem is that the goal features-export-meta-data is discontinued in the karaf plugin. So we have to rely on an old version which might not work anymore int the future if karaf changes. Another problem is that the result still requires some manual work to add it to felix or equinox. What you then get is a framework with just CXF-DOSGi and none of your own code. So this does not help the user much. I think karaf is covered fine by the karaf features we provide. So for karaf itself I do not see any need to change something. Possible solutions? 1. Just deliver poms and an example for bndtools I am currently experimenting a lot using bndtools to create application during a regular maven build. It works like this: Aries rsa and CXF-DOSGi provide poms that list all bundles that are needed for the frameworks. The user then creates his own project with a normal manven build. In one module he creates a local OBR index. This is done by listing maven dependencies to bundles. The poms we created above help a lot with this as the user can add cxf-dosgi with just one maven dependency. An alternative to this is the upcoming bndtools maven based indexes that allow to directly add pom as a repository source. So the creation of the local index is not necessary. The packaging is then done using a maven plugin that executes the bnd resolve and export steps. The result is a runnable jar. The one thing missing here at the moment is the bnd-export-maven-plugin or the maven based index which should be released with bndtools 3.3 soon. Of course this approach just helps if you plan to use bndtools. 2. Provide a p2 repository for eclipse users For eclipse users the easiest solution would be a p2 repository that they can then directly consume. Does anyone have experience with this? Are there maven plugins to create a p2 repository from a dependencies in a pom? Where would we host such a repo? Can the bundles still come from maven central? 3. ? In what other ways would people like to use CXF-DOSGi? How could we help them? As always I would be happy about feedback. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: Coding style
CXF Checkstyle seems to have a strange preference for import ordering. I am also often hit by this. I think this is defined in etc/eclipse/CXF.importorder. Not sure how to get eclipse to use it though. Christian On 10.08.2016 12:17, Sergey Beryozkin wrote: Hi Having static imports always has Checkstyle complaining for me. I'm fine with the new tests contributed which have the static imports that pass the command line builds :-). Refactoring the existing tests - are you referring to all of CXF unit tests ? Sergey On 10/08/16 11:09, Behrang Saeedzadeh wrote: Hi, I have noticed some test cases extend Assert (e.g. JwkUtilsTest <https://github.com/apache/cxf/blob/e6ce20a8fb434abb5ff34f769e63ac1c71f919b0/rt/rs/security/jose-parent/jose/src/test/java/org/apache/cxf/rs/security/jose/jwk/JwkUtilsTest.java>) while some test cases don't. I assume the extending Assert is a pre Java-5 style as back then we didn't have static imports. Any objections to refactor these test cases and make them extend nothing (well, Object) and instead use static imports? Best regards, Behrang Saeedzadeh -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: Coding style
+1 to refactor Christian On 10.08.2016 12:09, Behrang Saeedzadeh wrote: Hi, I have noticed some test cases extend Assert (e.g. JwkUtilsTest <https://github.com/apache/cxf/blob/e6ce20a8fb434abb5ff34f769e63ac1c71f919b0/rt/rs/security/jose-parent/jose/src/test/java/org/apache/cxf/rs/security/jose/jwk/JwkUtilsTest.java>) while some test cases don't. I assume the extending Assert is a pre Java-5 style as back then we didn't have static imports. Any objections to refactor these test cases and make them extend nothing (well, Object) and instead use static imports? Best regards, Behrang Saeedzadeh -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [DISCUSS] PR Builder
+1 Sounds good. From my side feel free to do the enhancements. Christian On 08.08.2016 02:25, John D. Ament wrote: Hi, I wanted to propose that the PR Builder should have a longer window for builds. Sometimes a build will fail for random reasons - flakey tests, bad build nodes, etc. Depending on how many PRs get raised, the build could disappear from jenkins and not able to be rebuilt. I wanted to recommend to keep all builds for the latest 7 days. If you're raising a PR, I would expect you're addressing issues within 7 days. PS - I hope no one minds. After my latest failure, I made two changes to the existing job. Change JDK from "latest1.8" to "JDK 1.8 (latest)" (this is a request from INFRA) (if you want, I can also fix your other jobs if they're pointing incorrectly) Exclude the H10 node explicitly from the pool (for some reason, that seems to have something bad installed or something or it hates me). You can find the diff here: https://builds.apache.org/job/CXF-Trunk-PR/jobConfigHistory/showDiffFiles?timestamp1=2015-11-30_15-55-26=2016-08-08_00-19-12 -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [Heads up] Design of new major version of CXF DOSGi
I was able to configure the server side on the level of pax web and the client side using the ConduitFeature as an intent. This way I was able to do a full example using SSL and cert based client auth. So while configuring the server side in the pax web config is not very Remote Service like it is a good work around in my opinion. Christian On 21.07.2016 16:58, Christian Schneider wrote: Unfortunately this did not work for the server side. The TlsServerParameters can not be set using a feature. Seems like they are configured in the JettyHTTPServerEngineFactory. I found that it is possible to configure server side ssl using config admin and will test if this helps. Christian On 21.07.2016 16:32, Sergey Beryozkin wrote: Hi Christian Nice, IMHO this is a nice improvement which will help not only (D)OSGI users, I'll tweak a bit the features to accept JAX-RS clients (they implement InterceptorProvider & ConduitSelectorHolder) -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] Apache CXF 3.0.10 and 3.1.7
+1 Christian 2016-07-26 21:48 GMT+02:00 Sergey Beryozkin <sberyoz...@gmail.com>: > +1 > > Thanks, Sergey > > On 26/07/16 21:25, Daniel Kulp wrote: > >> >> It’s been a long time coming, but we’re finally ready to release 3.0.10/ >> 3.1.7. We’ve resolved over 75 issues for 3.1.7 which is a LOT for a >> “.7” release. >> >> Staging areas: >> 3.1.7: >> https://repository.apache.org/content/repositories/orgapachecxf-1074/ < >> https://repository.apache.org/content/repositories/orgapachecxf-1074/> >> 3.0.10: >> https://repository.apache.org/content/repositories/orgapachecxf-1073 < >> https://repository.apache.org/content/repositories/orgapachecxf-1073>/ >> >> >> Tags: >> 3.1.7: >> >> https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=687d104d55d88449778dce8582bc549857460ded >> < >> https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=687d104d55d88449778dce8582bc549857460ded >> > >> 3.0.10: >> >> https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=a8745ba730bd7081b0f51dc1ff3edb3329fbc854 >> < >> https://git-wip-us.apache.org/repos/asf?p=cxf.git;a=tag;h=a8745ba730bd7081b0f51dc1ff3edb3329fbc854 >> > >> >> >> Here is my +1 >> >> >> > > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: [Heads up] Design of new major version of CXF DOSGi
Unfortunately this did not work for the server side. The TlsServerParameters can not be set using a feature. Seems like they are configured in the JettyHTTPServerEngineFactory. I found that it is possible to configure server side ssl using config admin and will test if this helps. Christian On 21.07.2016 16:32, Sergey Beryozkin wrote: Hi Christian Nice, IMHO this is a nice improvement which will help not only (D)OSGI users, I'll tweak a bit the features to accept JAX-RS clients (they implement InterceptorProvider & ConduitSelectorHolder) -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [Heads up] Design of new major version of CXF DOSGi
One more update on this. On the mailing list we had a request for configure https with DOSGi. I have now created two new features (https://issues.apache.org/jira/browse/CXF-6973): https://github.com/apache/cxf/blob/master/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpConduitFeature.java https://github.com/apache/cxf/blob/master/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpDestinationFeature.java These allow to configure http conduits and destinations using features. For DOSGi you can create such a Feature and publish it as an OSGi service with an intent name and require the intent in the service. The feature will then be applied and the service will be configured with all settings you do in the features. For the https clients this should already be enough. For the https endpoints I found that the jetty transport uses a JettyHTTPServerEngineFactory that is retrieved from the bus. I am not sure what is the best way to hook into that. There already is a way to configure this using config admin. Maybe this is enough. I would be happy about any feedback. It would be a little difficult to configure this using intents as it seems the jetty settings are configured per port and not per endpoint. So it does not make much sense to have an intent on the service. I will create an example that shows https with CXF-DOSGi to prove this actually works. Christian On 12.07.2016 09:25, Christian Schneider wrote: I have taken some more time to look into possible solutions for customizing CXF services and clients. Current situation (1.x) The 1.x tree provides a way to set these things on a CXF service: inInterceptors, outInterceptors, faultInInterceptors, faultOutInterceptors, features These could be set by providing either the class name or the instance object in a service property. On the JAXRS side there is a way to set providers using Class names and by looking up services with a specific marker property. Issues with the 1.x solution Setting interceptors and providers by instance is very convenient for plain OSGi and blueprint but does not work in DS. It is also not possible to send these instances to discovery to also create the client from these. So I am not sure if this option was spec conformant at all. Another problem is that on the client side you typically need different interceptors. For example if you add something as a header you would use an OutInterceptor on the client and an InInterceptor on the server. So as both client and server must be able to be created from the same set of service properties I think interceptors are not a good choice. A better choice is a feature as the implementation can do different things on the client and server with the same feature definition.* * Possible solution I propose to use intents for all customizations. An intent is an OSGi service of several possible types that is identified by a special property (org.apache.cxf.dosgi.IntentName). A service can specify a list of named intents it requires. The service is then only published when all intents are present as services. In the current code on master it is possible to use intents for Databinding, Binding Config, Feature and Provider. I have also introduced a new interface IntentProvider with one method List getIntents(). It allows to specify a whole list of intents with one name. This is useful if these intents should always be used together. As IntentProvider is not CXF specific we could even move this interface to the Aries RSA spi bundle. An example for this can be see in this test. It uses the intent "my" with a MessageBodyWriter and a MessageBodyReader. Both service endpoint and client proxy can be created from this intent and allow a full roundtrip for a call with customized serialization: https://github.com/apache/cxf-dosgi/tree/master/provider-rs/src/test/java/org/apache/cxf/dosgi/dsw/handlers/rest/provider Such IntentProvider services are easy to publish using any dependency injection framework and allow to set instances which can even be injected with other services if necessary. So I think this solution should be viable to set all typical needs for SOAP as well as REST. So what do you think? Can we use this to replace all the old config options? Christian On 07.07.2016 11:52, Sergey Beryozkin wrote: I'm not seeing this code in a WS provider either: https://github.com/apache/cxf-dosgi/blob/cxf-dosgi-ri-1.8.0/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/handlers/AbstractPojoConfigurationTypeHandler.java#L186 so it is not possible to add extra CXF interceptors for JAX-WS users too. The use-cases for adding them to JAX-WS endpoints would be the same as for JAX-RS. Only https://github.com/apache/cxf-dosgi/blob/cxf-dosgi-ri-1.8.0/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/handlers/AbstractPojoConfigurationTypeHandler.java#L235 is kept across the provid
Re: [Heads up] Design of new major version of CXF DOSGi
I have taken some more time to look into possible solutions for customizing CXF services and clients. Current situation (1.x) The 1.x tree provides a way to set these things on a CXF service: inInterceptors, outInterceptors, faultInInterceptors, faultOutInterceptors, features These could be set by providing either the class name or the instance object in a service property. On the JAXRS side there is a way to set providers using Class names and by looking up services with a specific marker property. Issues with the 1.x solution Setting interceptors and providers by instance is very convenient for plain OSGi and blueprint but does not work in DS. It is also not possible to send these instances to discovery to also create the client from these. So I am not sure if this option was spec conformant at all. Another problem is that on the client side you typically need different interceptors. For example if you add something as a header you would use an OutInterceptor on the client and an InInterceptor on the server. So as both client and server must be able to be created from the same set of service properties I think interceptors are not a good choice. A better choice is a feature as the implementation can do different things on the client and server with the same feature definition.* * Possible solution I propose to use intents for all customizations. An intent is an OSGi service of several possible types that is identified by a special property (org.apache.cxf.dosgi.IntentName). A service can specify a list of named intents it requires. The service is then only published when all intents are present as services. In the current code on master it is possible to use intents for Databinding, Binding Config, Feature and Provider. I have also introduced a new interface IntentProvider with one method List getIntents(). It allows to specify a whole list of intents with one name. This is useful if these intents should always be used together. As IntentProvider is not CXF specific we could even move this interface to the Aries RSA spi bundle. An example for this can be see in this test. It uses the intent "my" with a MessageBodyWriter and a MessageBodyReader. Both service endpoint and client proxy can be created from this intent and allow a full roundtrip for a call with customized serialization: https://github.com/apache/cxf-dosgi/tree/master/provider-rs/src/test/java/org/apache/cxf/dosgi/dsw/handlers/rest/provider Such IntentProvider services are easy to publish using any dependency injection framework and allow to set instances which can even be injected with other services if necessary. So I think this solution should be viable to set all typical needs for SOAP as well as REST. So what do you think? Can we use this to replace all the old config options? Christian On 07.07.2016 11:52, Sergey Beryozkin wrote: I'm not seeing this code in a WS provider either: https://github.com/apache/cxf-dosgi/blob/cxf-dosgi-ri-1.8.0/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/handlers/AbstractPojoConfigurationTypeHandler.java#L186 so it is not possible to add extra CXF interceptors for JAX-WS users too. The use-cases for adding them to JAX-WS endpoints would be the same as for JAX-RS. Only https://github.com/apache/cxf-dosgi/blob/cxf-dosgi-ri-1.8.0/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/handlers/AbstractPojoConfigurationTypeHandler.java#L235 is kept across the providers. Look, it is not really a big deal for me :-). But if one has a DS or Blueprint context it is handy to add CXF logging features or something else OOB by simply registering a bean in the context. I'd still prefer to keep that code for now at least, then do the intent POCs, and only then decide if the code can be removed or not. Cheers, Sergey -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[RESULT][VOTE] - Release Apache CXF Build Utils 3.2.1 take2
Sending again with correct subject. This vote passes with 8 +1 and no other votes. Christian On 05.07.2016 10:57, Christian Schneider wrote: This is a vote to release Apache CXF Build Utils 3.2.1. It contains changes for checkstyle config to make it compatible to Eclipse Neon. In version 3.2.0 Neon shows a lot of false checkstyle errors. After my first change seemed to be incompatible with older checkstyle versions I removed the return count check now to make sure it works in all scenarios. See https://issues.apache.org/jira/browse/CXF-6961 Git tag is: https://git-wip-us.apache.org/repos/asf?p=cxf-build-utils.git;a=tag;h=4dbfa24b3cd27da45b4dd219e1aadd89ac5d3cba Maven artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1072 +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] - Release Apache CXF Build Utils 3.2.1 take2
This vote passes with 8 +1 and no other votes. Christian 2016-07-07 14:19 GMT+02:00 Alessio Soldano <asold...@redhat.com>: > +1 > > > Il 05/07/2016 10:57, Christian Schneider ha scritto: > >> This is a vote to release Apache CXF Build Utils 3.2.1. >> >> It contains changes for checkstyle config to make it compatible to >> Eclipse Neon. In version 3.2.0 Neon shows a lot of false checkstyle errors. >> >> After my first change seemed to be incompatible with older checkstyle >> versions I removed the return count check now to make sure it works in >> all scenarios. >> >> See >> https://issues.apache.org/jira/browse/CXF-6961 >> >> Git tag is: >> >> https://git-wip-us.apache.org/repos/asf?p=cxf-build-utils.git;a=tag;h=4dbfa24b3cd27da45b4dd219e1aadd89ac5d3cba >> >> Maven artifacts: >> >> https://repository.apache.org/content/repositories/orgapachecxf-1072 >> >> +1 from me. >> >> Christian >> >> > > -- > Alessio Soldano > Web Service Lead, JBoss > > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: [Heads up] Design of new major version of CXF DOSGi
Hi Sergey, the problem is that we can not easily remove options after the major release as minor releases then should be compatible. So I would like to get rid of as many options as possible. On the other hand we need all important use cases to still work. The big problem for me is that I do not know enough about the JAX-RS use cases. So I would like to first set up some cases to see what we need to get working and then look into the possible soluitions. The current tests and examples still work with all those features removed. So I think our tests and examples do not reflect the typical use cases. I have no big pressure to release DOSGi 2 very soon. So I can guarantee you that I will not push for a release until we have a solution you are fine with. That might very well be putting back in all the options but I want to make sure these are really the best solution. So I would like to take the chance to learn from you what typical JAX-RS services need. So I propose we talk on skype to discuss the use cases and then sketch some examples. These will then be the barrier the new impl must pass. Christian On 07.07.2016 11:10, Sergey Beryozkin wrote: Hi Christian Having a POC is a good idea and given it let me suggest a slightly different path. I'd like to keep the code which is working for JAX-RS users mostly intact - if there's some code there which tries to load classes from their String names then I agree we can let it go but the code which deals with the already instantiated JAX-RS providers without depending on some wildcard imports in the DOSGI impl IMHO needs to stay. I do not know if anyone still uses DOSGi JAX-RS but I 100% sure I worked with some of them specifically on the issue of supporting injected providers and properties. Having an intent alternative is interesting and here a POC will help us understand how it can be done in a pure DOSGi way. Even if it works well I'd still favor keeping the existing JAX-RS option while we can start encouraging users to migrate to the Intents way. However, the goal of this re-design is not to make the JAX-RS part more DOSGI-y :-). It is about making a clean split of the monolitic CXF DOSGi which I fully support. Let it be done first and then we can try and go for a POC - it won't have to be done for JAX-RS only, we can try and see how it works for JAX-WS, example, having a 'BeanValidation' intent or 'Logging' intent, etc. Sounds reasonable ? Cheers, Sergey -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [Heads up] Design of new major version of CXF DOSGi
Hi Sergey, I propose we do a poc for that. Let´s create some customizations for a jaxrs service in 1.8.0 syntax together and then I can try to do the same on the 2.0 syntax. If we find gaps I will add the code to 2.0 again of course. Christian 2016-07-06 21:28 GMT+02:00 Sergey Beryozkin <sberyoz...@gmail.com>: > Hi Christian > On 06/07/16 18:42, Christian Schneider wrote: > >> I have removed all that code as I hope we have other measures to do this. >> One approach are the intents that allow to set interceptors using a >> feature. >> >> Another approach might be to use the annoations for features and >> interceptors like >> @org.apache.cxf.feature.Features (features = >> "org.apache.cxf.jaxws.service.AnnotationFeature") >> I think together they should provide the same level of configurability. >> >> The problem with all approaches that take class names is the visibility of >> these classes. The intent approach allows to offer a feature as a service >> so the user bundle with the service using the intent does not need access >> to the impl classes of the feature and interceptors. >> >> Most of this code as far as I know deals with instances, not classes. > > What do you think? Should that work? >> > Let me ask you instead, will it work ? > With DOSGI 1.8.0, as far as I recall, one just registers an instance of a > given provider and it works. > What DOSGI RS users would need to do to register an instance of a Jackson > provider for example, start creating some intent like "json" ? I honestly > do not how it will work. > > I don't mind with 2.0 the DOSGi users being encouraged to do pure DOSGi > with the intents, but IMHO the JAX-RS provider *instance* registration code > which already works should continue be there rather than remove it and hope > for the best the intents will help :-). > > Thanks, Sergey > > >> Christian >> >> 2016-07-06 16:49 GMT+02:00 Sergey Beryozkin <sberyoz...@gmail.com>: >> >> Hi Christian >>> >>> It all looks like a fine way forward, though I do believe there was a >>> code >>> before which allowed setting JAX-RS providers/interceptors >>> >>> This line adds interceptors/features: >>> >>> >>> >>> https://github.com/apache/cxf-dosgi/blob/cxf-dosgi-ri-1.8.0/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/handlers/JaxRSPojoConfigurationTypeHandler.java#L98 >>> >>> This line should add the providers: >>> >>> >>> >>> https://github.com/apache/cxf-dosgi/blob/cxf-dosgi-ri-1.8.0/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/handlers/JaxRSPojoConfigurationTypeHandler.java#L106 >>> >>> Have you preserved this code ? >>> >>> Thanks, Sergey >>> >>> On 06/07/16 11:44, Christian Schneider wrote: >>> >>> In the previous days I was working on a new design for CXF DOSGi 2. >>>> >>>> I would like to begin with a recap of the state of CXF DOSGi 1.8: >>>> Since the creation of Aries RSA the CXF DOSGi project is not a full OSGi >>>> remote service admin impl anymore. It only provides a >>>> DistributionProvider for CXF that can run >>>> in Aries RSA. The main problem is that there is just one provider that >>>> can do REST and SOAP services. So it always has to carry all >>>> dependencies. In the multi bundle distro these are about 100 bundles. >>>> There are also a lot of configuration properties including older >>>> deprecated properties. The Aegis support in the 1.8 version can not be >>>> used with Java8 as Aegis produces an exception during init. >>>> >>>> So the goals for CXF DOSGi 2 were to make it simpler and more light >>>> weight and of course to fully support Java 8. >>>> >>>> So this is the new design looks like this: >>>> >>>> - cxf-dosgi-common : HttpServiceManager, IntentManager, ProxyFactory and >>>> other small util classes. These are all shared for the providers >>>> - cxf-dosgi-provider-ws: SOAP support. If @Webservice annotation is >>>> present it does JAXWS/JAXB if not it does Simple/Aegis >>>> - cxf-dosgi-provider-rs: REST support. Exposes the service as a default >>>> JAX-RS service. It has not property support for setting providers or >>>> interceptors >>>> - cxf-dosgi-decorator: Allows to expose services using xml. I am not >>>> sure if we still need this as Aries RSA can now expose services using >>>> configs >>>
Re: [Heads up] Design of new major version of CXF DOSGi
I have removed all that code as I hope we have other measures to do this. One approach are the intents that allow to set interceptors using a feature. Another approach might be to use the annoations for features and interceptors like @org.apache.cxf.feature.Features (features = "org.apache.cxf.jaxws.service.AnnotationFeature") I think together they should provide the same level of configurability. The problem with all approaches that take class names is the visibility of these classes. The intent approach allows to offer a feature as a service so the user bundle with the service using the intent does not need access to the impl classes of the feature and interceptors. What do you think? Should that work? Christian 2016-07-06 16:49 GMT+02:00 Sergey Beryozkin <sberyoz...@gmail.com>: > Hi Christian > > It all looks like a fine way forward, though I do believe there was a code > before which allowed setting JAX-RS providers/interceptors > > This line adds interceptors/features: > > > https://github.com/apache/cxf-dosgi/blob/cxf-dosgi-ri-1.8.0/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/handlers/JaxRSPojoConfigurationTypeHandler.java#L98 > > This line should add the providers: > > > https://github.com/apache/cxf-dosgi/blob/cxf-dosgi-ri-1.8.0/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/handlers/JaxRSPojoConfigurationTypeHandler.java#L106 > > Have you preserved this code ? > > Thanks, Sergey > > On 06/07/16 11:44, Christian Schneider wrote: > >> In the previous days I was working on a new design for CXF DOSGi 2. >> >> I would like to begin with a recap of the state of CXF DOSGi 1.8: >> Since the creation of Aries RSA the CXF DOSGi project is not a full OSGi >> remote service admin impl anymore. It only provides a >> DistributionProvider for CXF that can run >> in Aries RSA. The main problem is that there is just one provider that >> can do REST and SOAP services. So it always has to carry all >> dependencies. In the multi bundle distro these are about 100 bundles. >> There are also a lot of configuration properties including older >> deprecated properties. The Aegis support in the 1.8 version can not be >> used with Java8 as Aegis produces an exception during init. >> >> So the goals for CXF DOSGi 2 were to make it simpler and more light >> weight and of course to fully support Java 8. >> >> So this is the new design looks like this: >> >> - cxf-dosgi-common : HttpServiceManager, IntentManager, ProxyFactory and >> other small util classes. These are all shared for the providers >> - cxf-dosgi-provider-ws: SOAP support. If @Webservice annotation is >> present it does JAXWS/JAXB if not it does Simple/Aegis >> - cxf-dosgi-provider-rs: REST support. Exposes the service as a default >> JAX-RS service. It has not property support for setting providers or >> interceptors >> - cxf-dosgi-decorator: Allows to expose services using xml. I am not >> sure if we still need this as Aries RSA can now expose services using >> configs >> - cxf-dosgi-repository: Pom that defines all dependencies to OSGi >> bundles. This can be used as a OSGi repository in the upcoming bnd and >> bndtools >> >> Both providers support intents which can be used to set DataBinding, >> Binding Config and Features. I think we might be missing support for >> JAXRS @Provider classes but I am not sure. >> Apart from this I removed all deprecated config properties and also >> slimmed down the other config properties. I hope we still cover most use >> cases but I need your feedback. >> I created some Readme.md docs in the source code to explain the current >> properties. >> >> The multi bundle distro is still there and is not really smaller as it >> still relies on the current karaf cxf and pax-web features which are >> really big. The karaf features are split into ws and rs. So we do not >> need to install everything at runtime. >> >> To show how small a DOSGi deployment can be I created a small example >> using bndtools and the repository above and was able to get a SOAP >> service exported with a runnable jar that just is about >> 6 MB. So I hope we can support much smaller deployments of CXF DOSGi in >> the future. Unfortunately I can not yet add this example to CXF DOSGi as >> it relies on some an experimental pom based repo plugin. As soon as this >> support is part of a bnd release I will add an example for this packaging. >> >> I also hope the new CXF DOSGi can be the default way for karaf boot to >> expose and consume REST services. >> >> I would be happy about your feedback on the new design. Before we do a >> 2
[Heads up] Design of new major version of CXF DOSGi
In the previous days I was working on a new design for CXF DOSGi 2. I would like to begin with a recap of the state of CXF DOSGi 1.8: Since the creation of Aries RSA the CXF DOSGi project is not a full OSGi remote service admin impl anymore. It only provides a DistributionProvider for CXF that can run in Aries RSA. The main problem is that there is just one provider that can do REST and SOAP services. So it always has to carry all dependencies. In the multi bundle distro these are about 100 bundles. There are also a lot of configuration properties including older deprecated properties. The Aegis support in the 1.8 version can not be used with Java8 as Aegis produces an exception during init. So the goals for CXF DOSGi 2 were to make it simpler and more light weight and of course to fully support Java 8. So this is the new design looks like this: - cxf-dosgi-common : HttpServiceManager, IntentManager, ProxyFactory and other small util classes. These are all shared for the providers - cxf-dosgi-provider-ws: SOAP support. If @Webservice annotation is present it does JAXWS/JAXB if not it does Simple/Aegis - cxf-dosgi-provider-rs: REST support. Exposes the service as a default JAX-RS service. It has not property support for setting providers or interceptors - cxf-dosgi-decorator: Allows to expose services using xml. I am not sure if we still need this as Aries RSA can now expose services using configs - cxf-dosgi-repository: Pom that defines all dependencies to OSGi bundles. This can be used as a OSGi repository in the upcoming bnd and bndtools Both providers support intents which can be used to set DataBinding, Binding Config and Features. I think we might be missing support for JAXRS @Provider classes but I am not sure. Apart from this I removed all deprecated config properties and also slimmed down the other config properties. I hope we still cover most use cases but I need your feedback. I created some Readme.md docs in the source code to explain the current properties. The multi bundle distro is still there and is not really smaller as it still relies on the current karaf cxf and pax-web features which are really big. The karaf features are split into ws and rs. So we do not need to install everything at runtime. To show how small a DOSGi deployment can be I created a small example using bndtools and the repository above and was able to get a SOAP service exported with a runnable jar that just is about 6 MB. So I hope we can support much smaller deployments of CXF DOSGi in the future. Unfortunately I can not yet add this example to CXF DOSGi as it relies on some an experimental pom based repo plugin. As soon as this support is part of a bnd release I will add an example for this packaging. I also hope the new CXF DOSGi can be the default way for karaf boot to expose and consume REST services. I would be happy about your feedback on the new design. Before we do a 2.0.0 release nothing is really fixed so please speak up to get your use cases in. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[VOTE] - Release Apache CXF Build Utils 3.2.1 take2
This is a vote to release Apache CXF Build Utils 3.2.1. It contains changes for checkstyle config to make it compatible to Eclipse Neon. In version 3.2.0 Neon shows a lot of false checkstyle errors. After my first change seemed to be incompatible with older checkstyle versions I removed the return count check now to make sure it works in all scenarios. See https://issues.apache.org/jira/browse/CXF-6961 Git tag is: https://git-wip-us.apache.org/repos/asf?p=cxf-build-utils.git;a=tag;h=4dbfa24b3cd27da45b4dd219e1aadd89ac5d3cba Maven artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1072 +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] - Release Apache CXF Build Utils 3.2.1
Cancelling the release. Seems I tested the wrong version of build utils. The new property for void method returns is wrong. I will fix it and do a new build. Christian On 05.07.2016 09:25, Christian Schneider wrote: This is a vote to release Apache CXF Build Utils 3.2.1. It contains changes for checkstyle config to make it compatible to Eclipse Neon. In version 3.2.0 Neon shows a lot of false checkstyle errors. See https://issues.apache.org/jira/browse/CXF-6961 Git tag is: https://git-wip-us.apache.org/repos/asf?p=cxf-build-utils.git;a=tag;h=3012f578053bd4b3f87f50eb82002300515b4a6a Maven artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1071 +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[VOTE] - Release Apache CXF Build Utils 3.2.1
This is a vote to release Apache CXF Build Utils 3.2.1. It contains changes for checkstyle config to make it compatible to Eclipse Neon. In version 3.2.0 Neon shows a lot of false checkstyle errors. See https://issues.apache.org/jira/browse/CXF-6961 Git tag is: https://git-wip-us.apache.org/repos/asf?p=cxf-build-utils.git;a=tag;h=3012f578053bd4b3f87f50eb82002300515b4a6a Maven artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1071 +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: Does JAXRSServerFactoryBean support a request log
You can use the logging feature to log all details of the calls: http://www.liquid-reality.de/display/liquid/2015/06/08/Enterprise+ready+request+logging+with+CXF+3.1.0+and+elastic+search By configuring the log format you should be able to retireve the same details as in the jetty case. When running as servlet you can of course use the plain jetty logging too. Christian 2016-04-30 0:45 GMT+02:00 tomstark <tom.st...@polycom.com>: > When using the JAXRSServerFactoryBean to create a server, is it possible to > configure it to create a request log similar to what Jetty supports?See > > https://eclipse.org/jetty/documentation/current/configuring-jetty-request-logs.html > > > > -- > View this message in context: > http://cxf.547215.n5.nabble.com/Does-JAXRSServerFactoryBean-support-a-request-log-tp5768286.html > Sent from the cxf-dev mailing list archive at Nabble.com. > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: CXF Repository Build
This is caused by the local index policy. I set it to REQUIRED now. Which means that local build should work with local snapshots. The bad thing is only that these builds then will have file: urls in the index. The bnd-indexer-plugin still sucks in my opinion. I hope the indexes will support mvn style urls at some points then this will go away. If it creates to much trouble we can disable it. Christian On 27.04.2016 11:52, Sergey Beryozkin wrote: Hi All CXF Repository Build (on 3.2.0-SNAPSHOT master) is downloading 3.2.0-SNAPSHOTS for all the modules, though the master has just been built and the snapshots are available locally, has someone observed it too ? Cheers, Sergey -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[RESULT] [VOTE] - Release Apache CXF DOSGi 1.8.0
This vote passes with 8 binding +1 and no other votes. I will publish the artifacts. Christian On 31.03.2016 15:45, Christian Schneider wrote: This is a vote to release Apache CXF DOSGi 1.8.0. The main change in this release to move out the core of Remote Service Admin and the discovery support to the Apache Aries Remote Service Admin project. http://aries.apache.org/modules/rsa.html So the functionality that remains in CXF DOSGi is to implement a provider for Aries RSA and the multibundle distribtuion and karaf features. Release Notes - CXF Distributed OSGi - Version 1.8.0 https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%201.8.0%20AND%20project%20%3D%20DOSGI ** Bug * [DOSGI-221] - HttpServiceManager.getHttpService sometimes return null ** Improvement * [DOSGI-235] - Switch to Aries RSA release 1.8.0 * [DOSGI-228] - Upgrade to CXF 3.1.5 * [DOSGI-229] - Refactor to make Remote Service Admin core independent of CXF * [DOSGI-232] - Remove code that moved to aries-rsa ** New Feature * [DOSGI-230] - Create TCP provider * [DOSGI-231] - Create ExportPolicy SPI Tag: https://git-wip-us.apache.org/repos/asf?p=cxf-dosgi.git;a=tag;h=42f3fa3aa36552a511ca7db7c52f5925e8c92fdd Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1070 +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[VOTE] - Release Apache CXF DOSGi 1.8.0
This is a vote to release Apache CXF DOSGi 1.8.0. The main change in this release to move out the core of Remote Service Admin and the discovery support to the Apache Aries Remote Service Admin project. http://aries.apache.org/modules/rsa.html So the functionality that remains in CXF DOSGi is to implement a provider for Aries RSA and the multibundle distribtuion and karaf features. Release Notes - CXF Distributed OSGi - Version 1.8.0 https://issues.apache.org/jira/issues/?jql=fixVersion%20%3D%201.8.0%20AND%20project%20%3D%20DOSGI ** Bug * [DOSGI-221] - HttpServiceManager.getHttpService sometimes return null ** Improvement * [DOSGI-235] - Switch to Aries RSA release 1.8.0 * [DOSGI-228] - Upgrade to CXF 3.1.5 * [DOSGI-229] - Refactor to make Remote Service Admin core independent of CXF * [DOSGI-232] - Remove code that moved to aries-rsa ** New Feature * [DOSGI-230] - Create TCP provider * [DOSGI-231] - Create ExportPolicy SPI Tag: https://git-wip-us.apache.org/repos/asf?p=cxf-dosgi.git;a=tag;h=42f3fa3aa36552a511ca7db7c52f5925e8c92fdd Maven Artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1070 +1 from me. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] CXF 3.1.6/3.0.9
+1 Christian 2016-03-23 21:48 GMT+01:00 Daniel Kulp <dk...@apache.org>: > > It’s been awhile since the last set of releases and we’ve fixed over 45 > JIRA’s (some of which may be needed for the Fediz release) so I’d like to > get this out. > > Staging areas: > 3.0.9: > https://repository.apache.org/content/repositories/orgapachecxf-1066/ > 3.1.6: > https://repository.apache.org/content/repositories/orgapachecxf-1065/ > > Tags: > 3.0.9: > > https://git1-us-west.apache.org/repos/asf?p=cxf.git;a=tag;h=26f17fad2f123d655ccf2d3a7bd2f4d7f8c81862 > 3.1.6: > > https://git1-us-west.apache.org/repos/asf?p=cxf.git;a=tag;h=ff9419a6292393159d44f134c15570f0c7c80bdb > > > Vote will be open for 72h. > > Here is my +1. > > -- > Daniel Kulp > dk...@apache.org - http://dankulp.com/blog > Talend Community Coder - http://coders.talend.com > > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: [VOTE] - Release Apache CXF Build Utils 3.2.0
+1 Christian On 15.03.2016 11:56, Colm O hEigeartaigh wrote: This is a vote to release Apache CXF Build Utils 3.2.0. It just contains some plugin updates. The reason behind the release is to avoid introducing an old Apache Ant dependency to downstream projects, which has a security advisory against it. The plugin updates requires a move to JDK 7, hence 3.2.0 rather than 3.1.1. Git tag: https://git-wip-us.apache.org/repos/asf?p=cxf-build-utils.git;a=commit;h=d2cd514af6e8ff296786ca7ca33cd5aff5fcd830 Maven artifacts: https://repository.apache.org/content/repositories/orgapachecxf-1064/ +1 from me. Colm. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: Errors building CXF from git repo
Hi, you can look at https://builds.apache.org/me/my-views/view/My/job/CXF-Trunk-JDK18 to see the current status of the CXF build. At the moment there are test failures even there. As CXF is actively developed you can not expect the build to always succeed. Do you need the custom build because you need to apply some patche of your own? If yes then the best option is to start with a release tag of CXF and apply you patches to it. Beware though that even a release is not required to run all tests succesfully. The most common reason for build failures on a test server (except actual errors in the code) is that ports are not available. So check which ports the test uses and check if these ports a maybe used on your system. Abot the failures you reported. Can you give the full stack trace of the errors. They sometimes show what is wrong. Christian On 12.03.2016 22:27, Dan Wlodarski wrote: To anyone whom may have insight: The relevant environment info: CXF version: direct from the CXF Git repository Platform: Ubuntu Server 14.04.04 64b guest OS running under Windows VirtualBox v5.0.16 JDK: v1.8.0_74 (Oracle-official) I am looking to implement a custom build of CXF to simulate an external SOAP server. The CXF build needs to support multiple web services and export of a standalone server for machine-local testing. However, I can't even get the build to complete. A couple of minutes after calling the Maven install target, the build fails on the "Apache CXF Runtime JMS Transport" step. The two specific tests that fail: * RequestResponseTest.testRequestTopicResponseStaticQueue:90->sendAndReceiveMessages:134->AbstractJMSTester.sendMessage:129->AbstractJMSTester.sendoutMessage:152 > Runtime * RequestResponseTest.testRequestTopicResponseTempQueue:83->sendAndReceiveMessages:134->AbstractJMSTester.sendMessage:129->AbstractJMSTester.sendoutMessage:152 > Runtime As this will be a development server to be pushed to a production tier, it is required that it passes all unit tests. Thanks for any guidance, Dan C. Wlodarski The Design Knowledge Company 3100 Presidential Drive Suite 103 Fairborn, Ohio 45324 Phone: 937-427-4276 x175 Fax: 937-427-1242 dwlodar...@tdkc.com www.tdkc.com -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [Discuss] Provider API for DOSGi and move core of CXF-DOSGi to Aries
Hi Sergey, just saw that my paste was incomplete. The createServer method already contains a map and the createProxy method contains the EndpointDescription which also has a map inside. So I think we should already be able to push additional data through the Maps. Sorry for the error. Btw. One thing I hope to be able to remove is the dswContext. I think it should be internal to the provider. Christian https://github.com/apache/cxf-dosgi/blob/master/dsw/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/api/ConfigurationTypeHandler.java public interface ConfigurationTypeHandler { ExportResult createServer(ServiceReference serviceReference, BundleContext dswContext, BundleContext callingContext, Map<String, Object> sd, Class iClass, Object serviceBean); Object createProxy(ServiceReference serviceReference, BundleContext dswContext, BundleContext callingContext, Class iClass, EndpointDescription endpoint) throws IntentUnsatisfiedException; } EndpointDescription endpoint) throws IntentUnsatisfiedException; On 29.02.2016 12:01, Sergey Beryozkin wrote: Hi Christian I think it is a good idea to make some of CXF-DSW code re-usable. It may help to give more 'energy' to CXF DOSGI itself (as well to DOSGi in general), and also indeed make for yet another connection between CXF and Aries. As far as ConfigurationTypeHandler is concerned, what happens if in some future one extra parameter needs to be passed along. If it were in CXF DSW then it would be only a quick internal update. Might be worth adding an extra parameter such as Map<String, Object>, so that the extra objects can be passed if needed without breaking the implementations. May be that interface will never change :-) or may be a better idea can be realized... Cheers, Sergey -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
[Discuss] Provider API for DOSGi and move core of CXF-DOSGi to Aries
Sascha Vogt and Johannes Utzig started a discussion on karaf dev to find a way to implement a light weight DOSGi implemention (using RMI). See: http://karaf.922171.n3.nabble.com/Proposal-Lightweight-standalone-remote-OSGi-implementation-for-karaf-cellar-td4045343.html After looking into the possible places to put this we found that the CXF-DOSGi code might provide a good starting point for it. As the code is coupled to CXF it needs some work of course. The discovery and topology manager parts are already nicely separated from CXF. Only the dsw-cxf module is tightly coupled to CXF. Unfortunately this part contains a big part of the remote services reference impl. So the idea is to split this module in the impl of RemoteServiceAdmin and into one or more modules for the CXF providers (WSDL, pojo, rest). I already started this to make sure it is possible. In the current master I refactored the code inside the module to decouple CXF and the spec parts. These packages implement the RemoteServiceAdmin spec part while the other packages implement the CXF providers. https://github.com/apache/cxf-dosgi/tree/master/dsw/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/api https://github.com/apache/cxf-dosgi/tree/master/dsw/cxf-dsw/src/main/java/org/apache/cxf/dosgi/dsw/service The idea is to use an API like this for providers: public interface ConfigurationTypeHandler { ExportResult createServer(ServiceReference serviceReference, BundleContext dswContext, BundleContext callingContext, Map<String, Object> sd, Class iClass, Object serviceBean); Object createProxy(ServiceReference serviceReference, BundleContext dswContext, BundleContext callingContext, Class iClass, } So a provide needs to be able to expose a service to the outside world and create a local proxy for a remote service. An API like this will make it a lot easier to write additional transports /serializations that are not related to CXF. Providers would then provide a OSGi service of the above interface and be responsible for one remote service configuration type each. So one point of discussion is if we want to create such an API for the public and how it should look like. The other point is that the CXF independent parts then would not have any dependency on CXF. So I think they would be better placed in Aries as they implement an OSGi spec. The CXF implementations for Soap and Rest providers would of course stay in CXF but might then be moved into the CXF main project to follow the changes and releases in CXF more closely. We should also discuss with Eclipse ECF if the API above (or similar) could be supported by both so providers could run in both implementations. Johannes even proposed that such an API could be part of a future remote services spec. What do you think? Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] CXF 3.1.5/3.0.8
+1 Christian 2016-02-03 12:08 GMT+01:00 Colm O hEigeartaigh <cohei...@apache.org>: > +1. > > Colm. > > On Wed, Feb 3, 2016 at 9:56 AM, Sergey Beryozkin <sberyoz...@gmail.com> > wrote: > > > +1 > > > > Thanks, Sergey > > > > On 02/02/16 21:28, Daniel Kulp wrote: > > > >> It’s been 3 months since the last patch releases so we really need to > get > >> these out. > >> > >> Staging areas: > >> 3.1.5 > >> https://repository.apache.org/content/repositories/orgapachecxf-1059/ > >> 3.0.8 > >> https://repository.apache.org/content/repositories/orgapachecxf-1060/ > >> > >> Tags: > >> 3.1.5: > >> > >> > https://git1-us-west.apache.org/repos/asf?p=cxf.git;a=tag;h=9a864cf721b510621f73f36e0ffabc17fd13c53c > >> 3.0.8: > >> > >> > https://git1-us-west.apache.org/repos/asf?p=cxf.git;a=tag;h=257a6d23948cb120b1e24e3668e128d8b6672829 > >> > >> Vote will be open for at least 72 hours. > >> > >> > >> Here is my +1 > >> > >> > > > > > > > > > -- > Colm O hEigeartaigh > > Talend Community Coder > http://coders.talend.com > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: Fixing up bean validation in OSGi
If you want to provide a pull request for karaf I would be happy to apply it. Christian 2015-12-15 4:55 GMT+01:00 Benson Margulies <bimargul...@gmail.com>: > Or move them to Karaf, for that matter. > > > On Mon, Dec 14, 2015 at 3:25 PM, Benson Margulies <bimargul...@gmail.com> > wrote: > > I've had a PR outstanding at Bval for weeks, with no response to the > > email or JIRA. My patch might fix it's current behavior in OSGi for > > me, which is to call every bean valid. If any of you can wake the bval > > committers up from their, ahem, hibernating state, I would work > > further on it. I'm happy to set up dueling hibernate and bval features > > in CXF for 3.2.0. > > > > > > On Mon, Dec 14, 2015 at 1:38 PM, Christian Schneider > > <ch...@die-schneider.net> wrote: > >> +1 for making the bean-validation feature independent from hibernate. I > >> intended to do this for 3.2 anyway. I propose to just add the > >> javax.validation api bundle with dependency=true and remove the > reference > >> to the bean-validation-core feature. Not sure if this is a good idea in > >> 3.1.x as it is slightly incompatible. > >> > >> I am -1 of adding a bval feature to CXF. Instead let us create the > feature > >> either in karaf or directly provided by bval which I think would be the > >> best option. I offer my help in doing so. > >> > >> Christian > >> > >> 2015-12-14 13:37 GMT+01:00 Francesco Chicchiriccò <ilgro...@apache.org > >: > >> > >>> On 14/12/2015 13:34, Romain Manni-Bucau wrote: > >>> > >>>> 2015-12-14 13:17 GMT+01:00 Francesco Chicchiriccò < > ilgro...@apache.org>: > >>>> > >>>> On 14/12/2015 12:59, Romain Manni-Bucau wrote: > >>>>> > >>>>> 2015-12-14 12:45 GMT+01:00 Sergey Beryozkin <sberyoz...@gmail.com>: > >>>>>> > >>>>>> Hi Benson > >>>>>> > >>>>>>> On 11/12/15 16:19, Benson Margulies wrote: > >>>>>>> > >>>>>>> https://issues.apache.org/jira/browse/CXF-6706 > >>>>>>> > >>>>>>>> https://issues.apache.org/jira/browse/CXF-6705 > >>>>>>>> > >>>>>>>> The changes I've committed for CXF-6705 make it possible to use > bean > >>>>>>>> validation, but ... > >>>>>>>> > >>>>>>>> 1: only with hibernate > >>>>>>>> 2: only with extra code to obtain the validation provider. > >>>>>>>> > >>>>>>>> This raises two questions. > >>>>>>>> > >>>>>>>> 1: should I restructure the features to split > >>>>>>>> 'cxf-bean-validation-hibernate' from 'cxf-bean-validation', > leaving > >>>>>>>> room for bval? > >>>>>>>> > >>>>>>>> Please, I've heard Apache BVal is less complete, but I think we > should > >>>>>>> keep the option open for users who would like to experiment with > this > >>>>>>> Apache project > >>>>>>> > >>>>>>> Hi guys, happy to help fixing any gap there if you need. BVal > passes > >>>>>> TCKs > >>>>>> so IMO it is a valid option. > >>>>>> > >>>>>> Hi Romain, > >>>>> AFAICT, current BVal release (2012!) passes the TCK for JSR-303 (e.g. > >>>>> Bean > >>>>> Validation 1.0), not JSR-349 (e.g. Bean Validation 1.1) > >>>>> > >>>>> http://bval.apache.org/downloads.html > >>>>> > >>>>> Am I wrong? > >>>>> > >>>>> Incidentally, this is the reason why we had to switch from BVal to > >>>>> Hibernate Validator in Syncope, a couple of major releases ago. > >>>>> > >>>>> > >>>>> http://repo1.maven.org/maven2/org/apache/bval/bval-jsr/1.1.0/ > passes 1.1 > >>>> TCKs (we renamed the main artifact cause naming jsr303 a jsr349 impl > was > >>>> odd). Will see if I can update the website - this is one area I didnt > work > >>>> on yet. > >>>> > >>> > >>> Oh, that's good to hear, thanks for update. > >>> > >>
Re: Fixing up bean validation in OSGi
+1 for making the bean-validation feature independent from hibernate. I intended to do this for 3.2 anyway. I propose to just add the javax.validation api bundle with dependency=true and remove the reference to the bean-validation-core feature. Not sure if this is a good idea in 3.1.x as it is slightly incompatible. I am -1 of adding a bval feature to CXF. Instead let us create the feature either in karaf or directly provided by bval which I think would be the best option. I offer my help in doing so. Christian 2015-12-14 13:37 GMT+01:00 Francesco Chicchiriccò <ilgro...@apache.org>: > On 14/12/2015 13:34, Romain Manni-Bucau wrote: > >> 2015-12-14 13:17 GMT+01:00 Francesco Chicchiriccò <ilgro...@apache.org>: >> >> On 14/12/2015 12:59, Romain Manni-Bucau wrote: >>> >>> 2015-12-14 12:45 GMT+01:00 Sergey Beryozkin <sberyoz...@gmail.com>: >>>> >>>> Hi Benson >>>> >>>>> On 11/12/15 16:19, Benson Margulies wrote: >>>>> >>>>> https://issues.apache.org/jira/browse/CXF-6706 >>>>> >>>>>> https://issues.apache.org/jira/browse/CXF-6705 >>>>>> >>>>>> The changes I've committed for CXF-6705 make it possible to use bean >>>>>> validation, but ... >>>>>> >>>>>> 1: only with hibernate >>>>>> 2: only with extra code to obtain the validation provider. >>>>>> >>>>>> This raises two questions. >>>>>> >>>>>> 1: should I restructure the features to split >>>>>> 'cxf-bean-validation-hibernate' from 'cxf-bean-validation', leaving >>>>>> room for bval? >>>>>> >>>>>> Please, I've heard Apache BVal is less complete, but I think we should >>>>> keep the option open for users who would like to experiment with this >>>>> Apache project >>>>> >>>>> Hi guys, happy to help fixing any gap there if you need. BVal passes >>>> TCKs >>>> so IMO it is a valid option. >>>> >>>> Hi Romain, >>> AFAICT, current BVal release (2012!) passes the TCK for JSR-303 (e.g. >>> Bean >>> Validation 1.0), not JSR-349 (e.g. Bean Validation 1.1) >>> >>> http://bval.apache.org/downloads.html >>> >>> Am I wrong? >>> >>> Incidentally, this is the reason why we had to switch from BVal to >>> Hibernate Validator in Syncope, a couple of major releases ago. >>> >>> >>> http://repo1.maven.org/maven2/org/apache/bval/bval-jsr/1.1.0/ passes 1.1 >> TCKs (we renamed the main artifact cause naming jsr303 a jsr349 impl was >> odd). Will see if I can update the website - this is one area I didnt work >> on yet. >> > > Oh, that's good to hear, thanks for update. > > > Regards. > > 2: should I put the code in place that actually makes it work, and, if >>> >>>> so, where? I think it would be an additional bundle under 'osgi' that >>>>>> provided a BeanValidationProviderFactory or a >>>>>> ValidationProviderHelper. >>>>>> >>>>>> I guess the servicemix API spec bundle should help. >>>>>> >>>>>> Hi JB, do you think a new BVal spec bundle may need to be released ? >>>>> >>>>> See https://issues.apache.org/jira/browse/SMX4-1618, in the >>>>> description, >>>>> >>>>> Thanks, Sergey >>>>> >>>> > -- > Francesco Chicchiriccò > > Tirasa - Open Source Excellence > http://www.tirasa.net/ > > Involved at The Apache Software Foundation: > member, Syncope PMC chair, Cocoon PMC, Olingo PMC, CXF committer > http://home.apache.org/~ilgrosso/ > > -- -- Christian Schneider http://www.liquid-reality.de <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.liquid-reality.de> Open Source Architect http://www.talend.com <https://owa.talend.com/owa/redir.aspx?C=3aa4083e0c744ae1ba52bd062c5a7e46=http%3a%2f%2fwww.talend.com>
Re: Feedback of my Phd work in CXF project
The criteria you mention sound a bit academic. Isn't the real reason of the combined change rather that the classes are connected to each other? I also do not yet get what the use cases for the prediction are. Of course it is interesting that you can predict such changes but what can be done with this information. Christian On 10.12.2015 00:29, igorwiese wrote: Hi, CXF Community. My name is Igor Wiese, phd Student from Brazil. I am investigating two important questions: What makes two files change together? Can we predict when they are going to co-change again? I've tried to investigate this question on the CXF project. I've collected data from issue reports, discussions and commits and using some machine learning techniques to build a prediction model. I collected a total of 6384 commits in which a pair of files changed together and could correctly predict 86% commits. These were the most useful information for predicting co-changes of files: - number of lines of code added, - number of lines of code removed, - sum of number of lines of code added, modified and removed, - number of words used to describe and discuss the issues, and - number of comments in each issue. To illustrate, consider the following example from our analysis. For release 2.7, the files "cxf/jaxrs/provider/AbstractJAXBProvider.java" and "cxf/jaxrs/provider/JAXBElementProvider.java" changed together in 11 commits. In another 11 commits, only the first file changed, but not the second. Collecting contextual information for each commit made to first file in release 2.6, we were able to predict 9 commits in which both files changed together in release 2.7, and we only issued one false positive, and one wrong prediction. For this pair of files, the most important contextual information was the number of lines of code added in each commit, the number of lines of code removed in each commit, the sum of lines of code removed, added and modified in each commit and the number of words used to describe and discuss the issues. - Do these results surprise you? Can you think in any explanation for the results? - Do you think that our rate of prediction is good enough to be used for building tool support for the software community? - Do you have any suggestion on what can be done to improve the change recommendation? You can visit a webpage to inspect the results in details: http://flosscoach.com/index.php/17-cochanges/68-cxf All the best, Igor Wiese Phd Candidate -- View this message in context: http://cxf.547215.n5.nabble.com/Feedback-of-my-Phd-work-in-CXF-project-tp5763765.html Sent from the cxf-dev mailing list archive at Nabble.com. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: Feedback of my Phd work in CXF project
Thanks for the explanations. I think the idea of giving people some hint that classes are connected (according to your rules) makes a lot of sense. Like you said this can help newcomers to navigate around the code. For this purpose an IDE plugin makes sense. I am not sure about the review part. As a reviewer you will always see the changeset and you know you got to review all changes. Your tool could report a file that was expected to be also changed but was not. As this would probably mean that something was forgotten to change a test should catch that. Btw. JMSConduit and JMSOldConfigHolder are connected through JMSConfiguration. So there is no direct connection but they are also not far from each other structurally. I am not sure if your system takes the connections into account but it would surely make sense to do so. For example if you find out that files are often changed together you could graphically show how they are connected structurally. This together with the statistical predictions could be some real help. Christian On 10.12.2015 14:03, igorwiese wrote: Hi Christian. Thanks for answer. Your first question is interesting. Usually this is the natural reason why we changed two files. We are always expecting some kind of structural connection between classes (eg implements, extends, instantiation, etc.). However we found many cases (issues) with commits where files are not "structurally connected". For example: JMSConduit.java and JMSOldConfigHolder.java are not structurally connected, despite being in the same package. We found that 15 commits they changed together, but in other 18 commits only JMSConduit changed without the presence of JMSOldConfigHolder.java. If you consider a "natural" reason you can make 18 mistakes, or at least, you will lost your time inspecting JMSOldConfigHolder.java 18 times. Our assumption is that "this real reason" can be, in fact, "many different reason". Because of this, using only structural dependencies can be not good in all situations, and can misleading the developers. A simple scenario: - You are working in a issue, and committed the file JMSConduit.java. What other files you could change to complete this issue? - Based on the past issues/commits when JMSConduit was changed, we collect contextual information that describe the situations when JMSConduit changed or not with JMSOldConfigHolder.java, and then we can recommend you to inspect this file to change or not. We collect data from all possible combinations envolving JMSConduit and other files of the system. - What we are reporting is that in 86% of the cases that we tested this combinations (you can check all of combination in the website), we correctly predicted when both files will change together in an specific issue/commit. About the practical aspects (what can be done). A researcher from our research group interviewed newcomers and they said that it is difficult to find right files to change in their first contributions. In this case, as a newcomer is difficult to complete the issues/pull requests because they don't understand much the code or the architecture. Debugging tasks are also not trivial in all projects. In such cases newcomers could use our approach (we are building a tool) to receive recommendations while performing the task. In the other hand, let's suppose that you are a core member and you are reviewing the Pull Request, we could give you a list of files to check, if all of them are in the set of commits made to the issue/pull request. Of course we are not claiming that you need to stop the test cases or the continuous integration. It is another tool to help during the code review tasks. We are working in a prototype.. we don't know yeat if we will build a "monitor" as a web service that you could integrate inside the Issue tracker, or as a plugin to some IDE. So the main ideia here is "avoid" the incomplete change that could causes a new bug appearing, or avoid waisting time to inspect files/debugging system to find files to change in a issue. -- View this message in context: http://cxf.547215.n5.nabble.com/Feedback-of-my-Phd-work-in-CXF-project-tp5763765p5763780.html Sent from the cxf-dev mailing list archive at Nabble.com. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: Introducing myself
Hi Francesco, congratulations, it is great to have you in the CXF team. I just checked the permissions on the CXF wiki. It seems the group cxf-committers has all permissions. So as long as this group is managed centrally it is probably only a matter of time until you get access. If not then we need to get you into that group. Christian On 28.11.2015 12:39, Francesco Chicchiriccò wrote: Colm O hEigeartaigh wrote: Hi Francesco, The website is published automatically from the wiki - so feel free to update it as you see fit :-) Thanks Colm: I'd need some permission on Confluence CXF space then (username: ilgrosso): can you help? Regards -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: Java2Ws and JSR 303 Annotations
Hi Benedikt, this seems to be related to what you do. Though it is the other way round: https://github.com/krasa/krasa-jaxb-tools Christian Am 19.11.2015 um 21:21 schrieb Benedikt Ritter: Hello, one of the projects at my company currently has the need to generate WSDLs from Java classes annotated with JSR 303 annotations [1]. They are using CXF's java2ws-maven-plugin, but the plugin does not process JSR 303 annotations. We're currently evaluating ways to generate XSD facets for representing the annotations. One idea is to extend the java2ws-maven-plugin so that is can generate this as well. Would the CXF project be interested in such a contribution? If so, I can elaborate more about how JSR 303 annotations could be mapped to facets. Regards, Benedikt [1] http://beanvalidation.org/
Re: Drop support for Jetty 8?
+1 Christian On 12.11.2015 16:40, Daniel Kulp wrote: You may have seen a bunch of updates for 3.2 around getting the Jetty support updated to allow for Jetty 9.3 (which requires Java 8, BTW). I have all the tests passing with both Jetty 9.2 and Jetty 9.3 now which is a good start. However, looking through the code, we still have a lot of reflection and other hacks to support Jetty 8. This was kind of required to be able to support CXF on Karaf 3 and 2.x. With Karaf 4.0 out for a while now (with several patches) and with us updating to CXF 3.2, could we drop support for Jetty 8 entirely and remove a bunch of those hacks? Could we maybe make 9.2 the minimum (since that’s what’s in Karaf 4)? My next step is to update the jetty transport to support http/2, but that definitely would require Jetty >=9.2 unless we do a bunch more detection logic and such. Thoughts? -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: CXF + Karaf 4: how to access the CXFNonSpringServlet
Hi Jerome, maybe you can instead just avoid that the CXF servlet is installed in the first place: https://github.com/apache/cxf/blob/master/rt/transports/http/src/main/java/org/apache/cxf/transport/http/osgi/HTTPTransportActivator.java See the property org.apache.cxf.osgi.http.transport.disable Christian Am 13.08.2015 um 21:42 schrieb Jérôme Revillard: Dear all, Since a couple of days, I'm trying to secure or web services which are running inside a Karaf 4 container with keycloak (http://keycloak.jboss.org). I followed a bit the demo here: https://github.com/keycloak/keycloak/tree/master/examples/fuse and more particularly the *Builtin web applications* part which is here to secure the all /cxf context. I had to update different things to be able to work with Karaf 4 but, I cannot make it working because I cannot get access to the cxf servlet. If you look at the blueprint.xml https://github.com/keycloak/keycloak/blob/master/examples/fuse/cxf-jaxrs/src/main/resources/OSGI-INF/blueprint/blueprint.xml file, you can see: bean id=defaultCxfReregistration class=org.keycloak.adapters.osgi.ServletReregistrationService depends-on=cxfKeycloakPaxWebIntegration init-method=start destroy-method=stop property name=bundleContext ref=blueprintBundleContext / property name=servletReference reference interface=javax.servlet.Servlet filter=(alias=/cxf) timeout=5000 / /property /bean Unfortunately, this bean is never instanciated because there is no javax.servlet.Servlet registered as service as it should be as written in ServletReregistrationService.java https://github.com/keycloak/keycloak/blob/5301b556f09a8e06b8d2fd8c957c5b2a6251e3ab/integration/osgi-adapter/src/main/java/org/keycloak/adapters/osgi/ServletReregistrationService.java: Service, which allows to remove previously registered servlets in karaf/fuse environment. It assumes that particular servlet was previously registered as service in OSGI container under {@link javax.servlet.Servlet} interface. I can get access to the ServletExporter but, the servlet object is private there, without anyway to retrieve it. Could somebody help me to solve this issue please ? Would there have another approach ? Thanks in advance! Jerome -- = Dr Jérôme Revillard CTO MAAT/GNUBILA France www.gnubila.fr 174 Impasse des Prés d'en Bas 74370 Argonay (France) Mob.0033 676 108 185 Tel.0033 450 685 601 =
Re: [VOTE] - Release Apache CXF Fediz 1.2.1
+1 Christian On 06.08.2015 16:02, Colm O hEigeartaigh wrote: This is a vote to release Apache CXF Fediz 1.2.1. Maven artifacts (shared with 1.1.3): https://repository.apache.org/content/repositories/orgapachecxf-1052/ Issued fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313420version=12332051 Git tag: https://git-wip-us.apache.org/repos/asf?p=cxf-fediz.git;a=commit;h=97ea63580759503576da76b1fb91aa20113664ae +1 from me. Colm. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: [VOTE] - Release Apache CXF Fediz 1.1.3
+1 Christian On 06.08.2015 16:03, Colm O hEigeartaigh wrote: This is a vote to release Apache CXF Fediz 1.1.3. Maven artifacts (shared with 1.2.1): https://repository.apache.org/content/repositories/orgapachecxf-1052/ Issued fixed: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313420version=12328874 Git tag: https://git-wip-us.apache.org/repos/asf?p=cxf-fediz.git;a=commit;h=e47da03c3f638c5330e0961f351d9ccf43386562 +1 from me. Colm. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com