[jira] [Created] (HIVE-18521) Vectorization: query failing in reducer VectorUDAFAvgDecimalPartial2 java.lang.ClassCastException StructTypeInfo --> DecimalTypeInfo

[Matt McCline (JIRA)]

Matt McCline created HIVE-18521:
---

 Summary: Vectorization: query failing in reducer 
VectorUDAFAvgDecimalPartial2 java.lang.ClassCastException StructTypeInfo --> 
DecimalTypeInfo
 Key: HIVE-18521
 URL: https://issues.apache.org/jira/browse/HIVE-18521
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 3.0.0
Reporter: Matt McCline
Assignee: Matt McCline






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 65304: HIVE-18513 Query results caching

[Jason Dere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65304/
---

Review request for hive, Ashutosh Chauhan, Gopal V, and Jesús Camacho Rodríguez.


Bugs: HIVE-18513
https://issues.apache.org/jira/browse/HIVE-18513


Repository: hive-git


Description
---

- For queries that result in MR/Tez/Spark jobs on the cluster, save the 
temporary query results to a cache directory where they can be re-used.
- Add QueryResultsCache to manage cached results. Currently cache invalidation 
is time-based, update-based cache invalidation needs to be added later.
- Driver/SemanticAnalyzer/Calcite planner changes to lookup queries in the 
cache and use in place of the query plan.


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 05c2acd 
  common/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java 2767bca 
  itests/src/test/resources/testconfiguration.properties 1017249 
  itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 3f377f9 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 74595b0 
  ql/src/java/org/apache/hadoop/hive/ql/cache/results/CacheUsage.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java 
PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 2e1fd37 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java 
f0dd167 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOpMaterializationValidator.java
 PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 372cfad 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 85a1f34 
  ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java ae2ec3d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 28e1041 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java 7243dc7 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 8af19d8 
  ql/src/test/queries/clientpositive/results_cache_1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/results_cache_2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/results_cache_capacity.q PRE-CREATION 
  ql/src/test/queries/clientpositive/results_cache_lifetime.q PRE-CREATION 
  ql/src/test/queries/clientpositive/results_cache_temptable.q PRE-CREATION 
  ql/src/test/queries/clientpositive/results_cache_with_masking.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/results_cache_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/results_cache_1.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/results_cache_2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/results_cache_capacity.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/results_cache_lifetime.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/results_cache_temptable.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/results_cache_with_masking.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/65304/diff/1/


Testing
---

qfile tests added.


Thanks,

Jason Dere

[jira] [Created] (HIVE-18520) add current txnid to ValidTxnList

[Eugene Koifman (JIRA)]

Eugene Koifman created HIVE-18520:
-

 Summary: add current txnid to ValidTxnList
 Key: HIVE-18520
 URL: https://issues.apache.org/jira/browse/HIVE-18520
 Project: Hive
  Issue Type: Improvement
  Components: Transactions
Affects Versions: 1.0.0
Reporter: Eugene Koifman
Assignee: Eugene Koifman


add the Id of the transaction that obtained this ValidTxnList

if nothing else, convenient for debugging

in particular include it in ErrorMsg.ACID_NOT_ENOUGH_HISTORY



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (HIVE-18519) do not create materialized CTEs with ACID/MM

[Sergey Shelukhin (JIRA)]

Sergey Shelukhin created HIVE-18519:
---

 Summary: do not create materialized CTEs with ACID/MM
 Key: HIVE-18519
 URL: https://issues.apache.org/jira/browse/HIVE-18519
 Project: Hive
  Issue Type: Bug
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 65296: HIVE-18259

[Jesús Camacho Rodríguez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65296/
---

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-18259
https://issues.apache.org/jira/browse/HIVE-18259


Repository: hive-git


Description
---

HIVE-18259


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
05c2acd0ff40e018bf41f077c47599ea6f9ef7df 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
23983d85b33d71c81ea255cbcea7aeca86017024 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsCacheCleanerTask.java
 PRE-CREATION 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java
 de912d5630ec04f0d0f7c1ac059d6acec92e9bcc 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
 3c8d005e3cb55739c91c340d2718850cb00747de 
  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreMaterializationsCacheCleaner.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65296/diff/1/


Testing
---


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65075/
---

(Updated Jan. 23, 2018, 8:27 p.m.)


Review request for hive, Aihua Xu, Andrew Sherman, and Sergio Pena.


Changes
---

Addressed comments by adding new test to verify 
HushableRandomAccessFileAppender.


Bugs: HIVE-18426
https://issues.apache.org/jira/browse/HIVE-18426


Repository: hive-git


Description
---

Each new operation creates new entry in the ConcurrentMap in RoutingAppender 
but when the operation ends, AppenderControl stored in the map is retrieved and 
stopped but the entry in ConcurrentMap is never cleaned up.


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/common/LogUtils.java 
5c7ec69f04587ab18704a10fade6e3a47601a87f 
  
itests/hive-unit/src/test/java/org/apache/hive/service/cli/operation/TestOperationLoggingLayout.java
 8febe3e79ff892c54b696b6c6ef92f7026c46033 


Diff: https://reviews.apache.org/r/65075/diff/3/

Changes: https://reviews.apache.org/r/65075/diff/2-3/


Testing
---

Made sure that the new tests updated to verify this change are passing.


Thanks,

kalyan kumar kalvagadda

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

[kalyan kumar kalvagadda via Review Board]

> On Jan. 11, 2018, 9:51 p.m., Andrew Sherman wrote:
> > itests/hive-unit/src/test/java/org/apache/hive/service/cli/operation/TestOperationLoggingLayout.java
> > Line 162 (original), 163 (patched)
> > 
> >
> > This code was to check the case described in 
> > https://issues.apache.org/jira/browse/HIVE-17826?focusedCommentId=16208636=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16208636
> > I think this is no longer tested. Is that OK?
> 
> kalyan kumar kalvagadda wrote:
> I have couple of observations with the limited knowledge that I have. 
> Correct me if i'm wrong here.
> 
> 1. HIVE-17128: Code changes done as part of this jira makes sure that 
> log4j Appender is closed when operation is closed to avoid file descriptors.
> 2. HIVE-17826: Added HushableRandomAccessFileAppender which is a copy of 
> RandomAccessFileAppender but has a explicit check in append() method to see 
> if the appender is closed.
> 
>  I think issue reported in HIVE-17826 is seen only because the 
> RoutingAppender is not properly cleaned-up when the operation is stopped. If 
> we have the patch i submitted we may not see the issue reported in HIVE-17826 
> even with out the fix of adding HushableRandomAccessFileAppender.
> 
> Andrew Sherman wrote:
> OK

I have added new test to verify HushableRandomAccessFileAppender


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65075/#review195255
---


On Jan. 12, 2018, 8:09 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65075/
> ---
> 
> (Updated Jan. 12, 2018, 8:09 p.m.)
> 
> 
> Review request for hive, Aihua Xu, Andrew Sherman, and Sergio Pena.
> 
> 
> Bugs: HIVE-18426
> https://issues.apache.org/jira/browse/HIVE-18426
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Each new operation creates new entry in the ConcurrentMap in RoutingAppender 
> but when the operation ends, AppenderControl stored in the map is retrieved 
> and stopped but the entry in ConcurrentMap is never cleaned up.
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/common/LogUtils.java 
> 0a3e0c72011951b6b1543352308bd51233c847fb 
>   
> itests/hive-unit/src/test/java/org/apache/hive/service/cli/operation/TestOperationLoggingLayout.java
>  8febe3e79ff892c54b696b6c6ef92f7026c46033 
> 
> 
> Diff: https://reviews.apache.org/r/65075/diff/2/
> 
> 
> Testing
> ---
> 
> Made sure that the new tests updated to verify this change are passing.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

[Sahil Takiar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65210/#review196065
---



A few comments, in general the tests look very thorough. Nice work!


standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
Lines 236 (patched)


Should we be filing JIRAs for the TODO items?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
Lines 246 (patched)


shouldn't this test have an assert somewhere? is it possible to used the 
`expected` parameter of `@Test` with multiple exceptions?

Same with the tests below. I think all unit tests should have an Assert, 
even if its asserting that a specific exception is being thrown. It helps 
define the contract for the test.


- Sahil Takiar


On Jan. 23, 2018, 4:47 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65210/
> ---
> 
> (Updated Jan. 23, 2018, 4:47 p.m.)
> 
> 
> Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang 
> Karajgaonkar.
> 
> 
> Bugs: HIVE-18480
> https://issues.apache.org/jira/browse/HIVE-18480
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The test tries to go throught all af the function related tests and test with 
> various imputs, so not only the happy path, but the edge cases are covered too
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65210/diff/3/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

[Marta Kuczora via Review Board]

> On Jan. 22, 2018, 2:21 p.m., Peter Vary wrote:
> > Thanks for the patch Marta! Only one question below

Thanks a lot Peter for the review.


- Marta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65241/#review195904
---


On Jan. 23, 2018, 5:21 p.m., Marta Kuczora wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65241/
> ---
> 
> (Updated Jan. 23, 2018, 5:21 p.m.)
> 
> 
> Review request for hive, Peter Vary and Adam Szita.
> 
> 
> Bugs: HIVE-18496
> https://issues.apache.org/jira/browse/HIVE-18496
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following methods of IMetaStoreClient are covered by this test.
> - void createIndex(Index, Table)
> - boolean dropIndex(String, String, String, boolean)
> - void alter_index(String, String, String, Index)
> 
> The test covers not just the happy pathes, but the edge cases as well.
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65241/diff/2/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

[Marta Kuczora via Review Board]

> On Jan. 22, 2018, 2:12 p.m., Adam Szita wrote:
> > Thanks for this patch Marta, it looks good! I've made a few recommendations 
> > only

Thanks a lot Adam for the review.


- Marta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65241/#review195900
---


On Jan. 23, 2018, 5:21 p.m., Marta Kuczora wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65241/
> ---
> 
> (Updated Jan. 23, 2018, 5:21 p.m.)
> 
> 
> Review request for hive, Peter Vary and Adam Szita.
> 
> 
> Bugs: HIVE-18496
> https://issues.apache.org/jira/browse/HIVE-18496
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following methods of IMetaStoreClient are covered by this test.
> - void createIndex(Index, Table)
> - boolean dropIndex(String, String, String, boolean)
> - void alter_index(String, String, String, Index)
> 
> The test covers not just the happy pathes, but the edge cases as well.
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65241/diff/2/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65241/
---

(Updated Jan. 23, 2018, 5:21 p.m.)


Review request for hive, Peter Vary and Adam Szita.


Changes
---

Addressed review findings.


Bugs: HIVE-18496
https://issues.apache.org/jira/browse/HIVE-18496


Repository: hive-git


Description
---

The following methods of IMetaStoreClient are covered by this test.
- void createIndex(Index, Table)
- boolean dropIndex(String, String, String, boolean)
- void alter_index(String, String, String, Index)

The test covers not just the happy pathes, but the edge cases as well.


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65241/diff/2/

Changes: https://reviews.apache.org/r/65241/diff/1-2/


Testing
---

Run the tests


Thanks,

Marta Kuczora

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

[Marta Kuczora via Review Board]

> On Jan. 22, 2018, 2:12 p.m., Adam Szita wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java
> > Lines 678 (patched)
> > 
> >
> > For handling future bug fixes more easily we could use consistent 
> > notation for these TODOs, see line 343.

Fixed it. Thanks for pointing this out.


> On Jan. 22, 2018, 2:12 p.m., Adam Szita wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java
> > Lines 876-880 (patched)
> > 
> >
> > If you'd like to shorten this one, I can recommend something like this:
> > 
> > cols.stream().collect(
> >   Collectors.toMap(col->col.getName(), col->col)
> > ).get("id")

Thanks a lot for the hint, I changed the code to be like this.


- Marta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65241/#review195900
---


On Jan. 19, 2018, 3:17 p.m., Marta Kuczora wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65241/
> ---
> 
> (Updated Jan. 19, 2018, 3:17 p.m.)
> 
> 
> Review request for hive, Peter Vary and Adam Szita.
> 
> 
> Bugs: HIVE-18496
> https://issues.apache.org/jira/browse/HIVE-18496
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following methods of IMetaStoreClient are covered by this test.
> - void createIndex(Index, Table)
> - boolean dropIndex(String, String, String, boolean)
> - void alter_index(String, String, String, Index)
> 
> The test covers not just the happy pathes, but the edge cases as well.
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65241/diff/1/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

[Marta Kuczora via Review Board]

> On Jan. 22, 2018, 2:21 p.m., Peter Vary wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java
> > Lines 218 (patched)
> > 
> >
> > Is this ok to have this characters in the index name?

Currently it is allowed to add, get and drop indexes with names like this. But 
for table names, special characters are not allowed, so we should consider 
restricting the index names like this. I will add a TODO and fix this issue in 
a separate Jira.


- Marta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65241/#review195904
---


On Jan. 19, 2018, 3:17 p.m., Marta Kuczora wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65241/
> ---
> 
> (Updated Jan. 19, 2018, 3:17 p.m.)
> 
> 
> Review request for hive, Peter Vary and Adam Szita.
> 
> 
> Bugs: HIVE-18496
> https://issues.apache.org/jira/browse/HIVE-18496
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following methods of IMetaStoreClient are covered by this test.
> - void createIndex(Index, Table)
> - boolean dropIndex(String, String, String, boolean)
> - void alter_index(String, String, String, Index)
> 
> The test covers not just the happy pathes, but the edge cases as well.
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddAlterDropIndexes.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65241/diff/1/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

[Peter Vary via Review Board]

> On Jan. 23, 2018, 4:17 p.m., Adam Szita wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 234-235 (patched)
> > 
> >
> > Could use assertEquals here instead IMHO

Changed. Thanks!


> On Jan. 23, 2018, 4:17 p.m., Adam Szita wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 429 (patched)
> > 
> >
> > Is this line of code necessary here?

Removed :)


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65265/#review196012
---


On Jan. 23, 2018, 4:54 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65265/
> ---
> 
> (Updated Jan. 23, 2018, 4:54 p.m.)
> 
> 
> Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-18509
> https://issues.apache.org/jira/browse/HIVE-18509
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Added the new tests.
> Modified AbstractMetaStoreService, so when starting mini-metastore it is 
> possible to provide configuration value overrides for non-metastore config 
> values (like fs trash settings)
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
>  PRE-CREATION 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java
>  ed071f8 
> 
> 
> Diff: https://reviews.apache.org/r/65265/diff/4/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

[Peter Vary via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65265/
---

(Updated Jan. 23, 2018, 4:54 p.m.)


Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.


Changes
---

Addressed Adam's comments


Bugs: HIVE-18509
https://issues.apache.org/jira/browse/HIVE-18509


Repository: hive-git


Description
---

Added the new tests.
Modified AbstractMetaStoreService, so when starting mini-metastore it is 
possible to provide configuration value overrides for non-metastore config 
values (like fs trash settings)


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
 PRE-CREATION 
  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java
 ed071f8 


Diff: https://reviews.apache.org/r/65265/diff/4/

Changes: https://reviews.apache.org/r/65265/diff/3-4/


Testing
---

Run the tests


Thanks,

Peter Vary

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

[Adam Szita via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65210/#review196031
---


Ship it!




Ship It!

- Adam Szita


On Jan. 23, 2018, 4:47 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65210/
> ---
> 
> (Updated Jan. 23, 2018, 4:47 p.m.)
> 
> 
> Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang 
> Karajgaonkar.
> 
> 
> Bugs: HIVE-18480
> https://issues.apache.org/jira/browse/HIVE-18480
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The test tries to go throught all af the function related tests and test with 
> various imputs, so not only the happy path, but the edge cases are covered too
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65210/diff/3/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

[Adam Szita via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65264/#review196029
---


Ship it!




Ship It!

- Adam Szita


On Jan. 23, 2018, 11:18 a.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65264/
> ---
> 
> (Updated Jan. 23, 2018, 11:18 a.m.)
> 
> 
> Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-18481
> https://issues.apache.org/jira/browse/HIVE-18481
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Create IMetaStoreClient tests to cover the table query methods
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65264/diff/3/
> 
> 
> Testing
> ---
> 
> Run the created tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

[Peter Vary via Review Board]

> On Jan. 23, 2018, 2:07 p.m., Adam Szita wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
> > Lines 103 (patched)
> > 
> >
> > Should we extract 
> > "org.apache.hadoop.hive.ql.udf.generic.GenericUDFUpper" into a constant as 
> > it is used multiple times here?

Done. Thanks!


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65210/#review196003
---


On Jan. 23, 2018, 4:47 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65210/
> ---
> 
> (Updated Jan. 23, 2018, 4:47 p.m.)
> 
> 
> Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang 
> Karajgaonkar.
> 
> 
> Bugs: HIVE-18480
> https://issues.apache.org/jira/browse/HIVE-18480
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The test tries to go throught all af the function related tests and test with 
> various imputs, so not only the happy path, but the edge cases are covered too
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65210/diff/3/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

[Peter Vary via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65210/
---

(Updated Jan. 23, 2018, 4:47 p.m.)


Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang 
Karajgaonkar.


Changes
---

Addessed Adam's comment


Bugs: HIVE-18480
https://issues.apache.org/jira/browse/HIVE-18480


Repository: hive-git


Description
---

The test tries to go throught all af the function related tests and test with 
various imputs, so not only the happy path, but the edge cases are covered too


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65210/diff/3/

Changes: https://reviews.apache.org/r/65210/diff/2-3/


Testing
---

Run the tests


Thanks,

Peter Vary

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

[Adam Szita via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65265/#review196012
---


Fix it, then Ship it!




Looking good, thanks Peter!


standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
Lines 234-235 (patched)


Could use assertEquals here instead IMHO



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
Lines 429 (patched)


Is this line of code necessary here?


- Adam Szita


On Jan. 23, 2018, 11:48 a.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65265/
> ---
> 
> (Updated Jan. 23, 2018, 11:48 a.m.)
> 
> 
> Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-18509
> https://issues.apache.org/jira/browse/HIVE-18509
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Added the new tests.
> Modified AbstractMetaStoreService, so when starting mini-metastore it is 
> possible to provide configuration value overrides for non-metastore config 
> values (like fs trash settings)
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
>  PRE-CREATION 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java
>  ed071f8 
> 
> 
> Diff: https://reviews.apache.org/r/65265/diff/3/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65285: Create tests to cover getPartition(s) methods

[Peter Vary via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/#review196018
---



Just 2 more test cases I can come up with.
Is it worth to create a test case for them?


standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Lines 200 (patched)


Maybe test for case insensitivity?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Lines 236 (patched)


Maybe test for no db?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Lines 305 (patched)


Maybe test for no database?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Lines 347 (patched)


Maybe test for case insensitivity?


- Peter Vary


On Jan. 23, 2018, 9:42 a.m., Adam Szita wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65285/
> ---
> 
> (Updated Jan. 23, 2018, 9:42 a.m.)
> 
> 
> Review request for hive, Marta Kuczora and Peter Vary.
> 
> 
> Bugs: HIVE-18483
> https://issues.apache.org/jira/browse/HIVE-18483
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Create tests to cover getPartition(s) methods
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65285/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Adam Szita
> 
>

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

[Adam Szita via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65210/#review196003
---


Fix it, then Ship it!




Looks good Peter, thanks for the patch!


standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
Lines 103 (patched)


Should we extract "org.apache.hadoop.hive.ql.udf.generic.GenericUDFUpper" 
into a constant as it is used multiple times here?


- Adam Szita


On Jan. 22, 2018, 2:33 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65210/
> ---
> 
> (Updated Jan. 22, 2018, 2:33 p.m.)
> 
> 
> Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang 
> Karajgaonkar.
> 
> 
> Bugs: HIVE-18480
> https://issues.apache.org/jira/browse/HIVE-18480
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The test tries to go throught all af the function related tests and test with 
> various imputs, so not only the happy path, but the edge cases are covered too
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65210/diff/2/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65284: Create tests to cover listPartition(s) methods

[Peter Vary via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65284/#review195996
---



That is a hugh number of tests.
Might add some more. Please check if the proposed ones are valid


standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 145 (patched)


This is strange :)
What is the puprose of this?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 181 (patched)


nit: _



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 192 (patched)


nit: Java 8?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 290 (patched)


Is this needed?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 303 (patched)


Is this needed?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 360 (patched)


Maybe a case, when there is no result?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 435 (patched)


nit: newline?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 442 (patched)


nit: newline?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 524 (patched)


nit: checkstyle?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 623 (patched)


Shouldn't we check the results?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 662 (patched)


NoDb test case?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 701 (patched)


Shouldn't we check the results?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 708 (patched)


Shouldn't we check the results?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 794 (patched)


What happens with empty ("") filter?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 810 (patched)


What are the allowed keywords?
- OR
- AND
- ?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 815 (patched)


What happens with filter like this:
"YYyy=\"2017\""?



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
Lines 1061 (patched)


Do we want to use the result? :)


- Peter Vary


On Jan. 23, 2018, 9:34 a.m., Adam Szita wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65284/
> ---
> 
> (Updated Jan. 23, 2018, 9:34 a.m.)
> 
> 
> Review request for hive, Marta Kuczora and Peter Vary.
> 
> 
> Bugs: HIVE-18484
> https://issues.apache.org/jira/browse/HIVE-18484
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Create tests to cover listPartition(s) methods
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65284/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Adam Szita
> 
>

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65213/
---

(Updated Jan. 23, 2018, 1:57 p.m.)


Review request for hive, Peter Vary and Adam Szita.


Bugs: HIVE-18479
https://issues.apache.org/jira/browse/HIVE-18479


Repository: hive-git


Description
---

The following methods of IMetaStoreClient are covered by this test.
- boolean dropPartition(String, String, List, boolean)
- boolean dropPartition(String, String, List, PartitionDropOptions)
- boolean dropPartition(String, String, String, boolean)

The test covers not just the happy pathes, but the edge cases as well.


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65213/diff/3/

Changes: https://reviews.apache.org/r/65213/diff/2-3/


Testing
---

Run the tests


Thanks,

Marta Kuczora

[jira] [Created] (HIVE-18518) Upgrade druid version to 0.11.0

[Nishant Bangarwa (JIRA)]

Nishant Bangarwa created HIVE-18518:
---

 Summary: Upgrade druid version to 0.11.0
 Key: HIVE-18518
 URL: https://issues.apache.org/jira/browse/HIVE-18518
 Project: Hive
  Issue Type: Bug
Reporter: Nishant Bangarwa
Assignee: Nishant Bangarwa


this task is to upgrade to druid version 0.11.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

[Adam Szita via Review Board]

> On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java
> > Lines 223 (patched)
> > 
> >
> > When altering a partition, is it possible to modify its 
> > StorageDescriptor and location? 
> > If so, what happens if we try to modify the sd or location to null or 
> > empty? 
> > Is it possible to change the columns in the partition's storage 
> > descriptor?

SD can be changed completely, I change location by hand and I also added a 
change for col list now, thanks!


> On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java
> > Lines 497 (patched)
> > 
> >
> > When tyring to alter two partitions, but an exception occurs during 
> > altering one of them, what happens with the other? All modification will be 
> > rolled back correctly?

Altered my test case to check this, it is rolled back correctly


> On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java
> > Lines 769 (patched)
> > 
> >
> > What happens if the newPart partition has different db/table than the 
> > ones set in the method parameter?

Added test case for this


> On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java
> > Lines 770 (patched)
> > 
> >
> > What happens if the db/table is null in the newPart partition?

Added test case for this


> On Jan. 22, 2018, 3:21 p.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java
> > Lines 771 (patched)
> > 
> >
> > Is it possible to change any other attribute of a partition besides the 
> > value with the rename method?

Added test case for this


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65217/#review195910
---


On Jan. 23, 2018, 1:38 p.m., Adam Szita wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65217/
> ---
> 
> (Updated Jan. 23, 2018, 1:38 p.m.)
> 
> 
> Review request for hive, Marta Kuczora and Peter Vary.
> 
> 
> Bugs: HIVE-18468
> https://issues.apache.org/jira/browse/HIVE-18468
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Adding IMetastoreClient API tests that cover alterPartition ande 
> renamePartition methods
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65217/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Adam Szita
> 
>

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

[Adam Szita via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65217/
---

(Updated Jan. 23, 2018, 1:38 p.m.)


Review request for hive, Marta Kuczora and Peter Vary.


Changes
---

Added additional cases as per Marta's comments


Bugs: HIVE-18468
https://issues.apache.org/jira/browse/HIVE-18468


Repository: hive-git


Description
---

Adding IMetastoreClient API tests that cover alterPartition ande 
renamePartition methods


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65217/diff/3/

Changes: https://reviews.apache.org/r/65217/diff/2-3/


Testing
---


Thanks,

Adam Szita

Re: Review Request 65285: Create tests to cover getPartition(s) methods

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/#review195995
---



Thanks a lot Adam for the patch. It looks very good to me.

- Marta Kuczora


On Jan. 23, 2018, 9:42 a.m., Adam Szita wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65285/
> ---
> 
> (Updated Jan. 23, 2018, 9:42 a.m.)
> 
> 
> Review request for hive, Marta Kuczora and Peter Vary.
> 
> 
> Bugs: HIVE-18483
> https://issues.apache.org/jira/browse/HIVE-18483
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Create tests to cover getPartition(s) methods
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65285/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Adam Szita
> 
>

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

[Peter Vary via Review Board]

> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 323 (patched)
> > 
> >
> > Maybe this could be moved to a separate test case (like create table 
> > with null location). It was a bit hard to notice after the asserts of the 
> > previous test case.

Done


> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 505 (patched)
> > 
> >
> > It might be good to check if the table is really deleted.

Done. Thanks for pointing this out!


> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 602 (patched)
> > 
> >
> > This test contains three well defined use cases so I think it would 
> > make sense to split them into 3 tests.

Done


> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
> > Lines 911 (patched)
> > 
> >
> > What happens if the location of the table is changed to null? Is it a 
> > valid use case or an exception will occur?

Good idea. Done


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65265/#review195980
---


On Jan. 23, 2018, 11:48 a.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65265/
> ---
> 
> (Updated Jan. 23, 2018, 11:48 a.m.)
> 
> 
> Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-18509
> https://issues.apache.org/jira/browse/HIVE-18509
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Added the new tests.
> Modified AbstractMetaStoreService, so when starting mini-metastore it is 
> possible to provide configuration value overrides for non-metastore config 
> values (like fs trash settings)
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
>  PRE-CREATION 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java
>  ed071f8 
> 
> 
> Diff: https://reviews.apache.org/r/65265/diff/3/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

[Peter Vary via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65265/
---

(Updated Jan. 23, 2018, 11:48 a.m.)


Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.


Changes
---

Addressed Marta's comments


Bugs: HIVE-18509
https://issues.apache.org/jira/browse/HIVE-18509


Repository: hive-git


Description
---

Added the new tests.
Modified AbstractMetaStoreService, so when starting mini-metastore it is 
possible to provide configuration value overrides for non-metastore config 
values (like fs trash settings)


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
 PRE-CREATION 
  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java
 ed071f8 


Diff: https://reviews.apache.org/r/65265/diff/3/

Changes: https://reviews.apache.org/r/65265/diff/2-3/


Testing
---

Run the tests


Thanks,

Peter Vary

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65264/#review195984
---


Ship it!




Ship It!

- Marta Kuczora


On Jan. 23, 2018, 11:18 a.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65264/
> ---
> 
> (Updated Jan. 23, 2018, 11:18 a.m.)
> 
> 
> Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-18481
> https://issues.apache.org/jira/browse/HIVE-18481
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Create IMetaStoreClient tests to cover the table query methods
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65264/diff/3/
> 
> 
> Testing
> ---
> 
> Run the created tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

[Peter Vary via Review Board]

> On Jan. 23, 2018, 10:56 a.m., Marta Kuczora wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java
> > Lines 285 (patched)
> > 
> >
> > Might worth to add a test with empty filter.

Done. Thanks for pointing this out!


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65264/#review195979
---


On Jan. 23, 2018, 11:18 a.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65264/
> ---
> 
> (Updated Jan. 23, 2018, 11:18 a.m.)
> 
> 
> Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-18481
> https://issues.apache.org/jira/browse/HIVE-18481
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Create IMetaStoreClient tests to cover the table query methods
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65264/diff/3/
> 
> 
> Testing
> ---
> 
> Run the created tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

[Peter Vary via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65264/
---

(Updated Jan. 23, 2018, 11:18 a.m.)


Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.


Changes
---

Addressed Marta's comment


Bugs: HIVE-18481
https://issues.apache.org/jira/browse/HIVE-18481


Repository: hive-git


Description
---

Create IMetaStoreClient tests to cover the table query methods


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65264/diff/3/

Changes: https://reviews.apache.org/r/65264/diff/2-3/


Testing
---

Run the created tests


Thanks,

Peter Vary

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65210/#review195981
---


Ship it!




Ship It!

- Marta Kuczora


On Jan. 22, 2018, 2:33 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65210/
> ---
> 
> (Updated Jan. 22, 2018, 2:33 p.m.)
> 
> 
> Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang 
> Karajgaonkar.
> 
> 
> Bugs: HIVE-18480
> https://issues.apache.org/jira/browse/HIVE-18480
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The test tries to go throught all af the function related tests and test with 
> various imputs, so not only the happy path, but the edge cases are covered too
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65210/diff/2/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65265/#review195980
---



Thanks a lot Peter for the patch.
It looks really good to me, I have only few nits.


standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
Lines 323 (patched)


Maybe this could be moved to a separate test case (like create table with 
null location). It was a bit hard to notice after the asserts of the previous 
test case.



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
Lines 505 (patched)


It might be good to check if the table is really deleted.



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
Lines 602 (patched)


This test contains three well defined use cases so I think it would make 
sense to split them into 3 tests.



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
Lines 911 (patched)


What happens if the location of the table is changed to null? Is it a valid 
use case or an exception will occur?


- Marta Kuczora


On Jan. 22, 2018, 3:36 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65265/
> ---
> 
> (Updated Jan. 22, 2018, 3:36 p.m.)
> 
> 
> Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-18509
> https://issues.apache.org/jira/browse/HIVE-18509
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Added the new tests.
> Modified AbstractMetaStoreService, so when starting mini-metastore it is 
> possible to provide configuration value overrides for non-metastore config 
> values (like fs trash settings)
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java
>  PRE-CREATION 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java
>  ed071f8 
> 
> 
> Diff: https://reviews.apache.org/r/65265/diff/2/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65264/#review195979
---



Thanks a lot Peter for the patch.
I looks really good to me, I have only one comment.


standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java
Lines 285 (patched)


Might worth to add a test with empty filter.


- Marta Kuczora


On Jan. 22, 2018, 3:38 p.m., Peter Vary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65264/
> ---
> 
> (Updated Jan. 22, 2018, 3:38 p.m.)
> 
> 
> Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-18481
> https://issues.apache.org/jira/browse/HIVE-18481
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Create IMetaStoreClient tests to cover the table query methods
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65264/diff/2/
> 
> 
> Testing
> ---
> 
> Run the created tests
> 
> 
> Thanks,
> 
> Peter Vary
> 
>

Review Request 65285: Create tests to cover getPartition(s) methods

[Adam Szita via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/
---

Review request for hive, Marta Kuczora and Peter Vary.


Bugs: HIVE-18483
https://issues.apache.org/jira/browse/HIVE-18483


Repository: hive-git


Description
---

Create tests to cover getPartition(s) methods


Diffs
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65285/diff/1/


Testing
---


Thanks,

Adam Szita

Review Request 65284: Create tests to cover listPartition(s) methods

[Adam Szita via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65284/
---

Review request for hive, Marta Kuczora and Peter Vary.


Bugs: HIVE-18484
https://issues.apache.org/jira/browse/HIVE-18484


Repository: hive-git


Description
---

Create tests to cover listPartition(s) methods


Diffs
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestListPartitions.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65284/diff/1/


Testing
---


Thanks,

Adam Szita

[jira] [Created] (HIVE-18517) Vectorization: Fix VectorMapOperator to accept VRBs to support LLAP Caching

[Matt McCline (JIRA)]

Matt McCline created HIVE-18517:
---

 Summary: Vectorization: Fix VectorMapOperator to accept VRBs to 
support LLAP Caching
 Key: HIVE-18517
 URL: https://issues.apache.org/jira/browse/HIVE-18517
 Project: Hive
  Issue Type: Bug
  Components: Hive
Affects Versions: 3.0.0
Reporter: Matt McCline
Assignee: Matt McCline


LLAP is able to deserialize and cache data from an input format (e.g. 
TextInputFormat) and will deliver that cached data to VectorMapOperator as VRBs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)