Re: PHP test cases

[Rich Bowen]

On Tue, Nov 21, 2017, 17:32 Daniel Ruggeri  wrote:

> Hi, all;
>
> I have only one set of remaining test cases to complete my
> automated-build-and-test-and-report thingamajig. I've identified a
> potential issue with our expected test results and could use a pointer
> from anyone who tests PHP regularly.
>

I'm curious if you've also asked over on the php lists. Istr they were
pushing pretty hard for a move to 7 but I don't know what the position is
for old versions.



>
> I'm looking at t/php/safemode.t and according to [1], safemode was
> removed in 5.4.0. The thing I'm wondering is if we should first test for
> PHP <5.4.0 before proceeding or if we should eliminate t/php/safemode.t
> altogether. I'm leaning toward the latter as it's a removed feature and
> shouldn't hold up our own testing.
>
>
> Also, t/php/getlastmod.t fails because of a warning[2] unless php.ini
> has been set to explicitly declare a timezone (unsure of which version
> PHP made this a warning). Should we modify our php script or modify the
> comparison to be a match that includes the month? My workaround was to
> create a php.ini on the fly but we ought to handle this better in the code.
>
>
> Side note... t/filter/case.t fails unless perl documentation is
> installed. We should note this or pick a better file :-)
>
>
> [1] http://php.net/manual/en/features.safe-mode.php
>
> [2]
> http://php.net/manual/en/function.date.php#refsect1-function.date-errors
>
> --
> Daniel Ruggeri
>
>

Re: [docs] mod_md documentation clarification

[Rich Bowen]

On 11/28/2017 11:06 AM, Stefan Eissing wrote:




Am 28.11.2017 um 16:40 schrieb Rich Bowen :

I'm reading the mod_md docs, and want some clarification on the following. In 
the docs for directive ManagedDomain, we have:


Thanks for reviewing these.


There are two special names that you may use in this directive: 'manual' and 
'auto'. This determines if a Managed Domain shall have exactly the name list as 
is configured ('manual') or offer more convenience. With 'auto' all names of a 
virtual host are added to a MD.

This is followed by an example that uses neither 'manual' nor 'auto', and thus 
it's unclear what the above paragraph refers to.


I updated the section with an additional example and more explanation.


Thanks. That's much clearer, and not the way I had interpreted it before.

Re: [docs] mod_md documentation clarification

[Stefan Eissing]

> Am 28.11.2017 um 16:40 schrieb Rich Bowen :
> 
> I'm reading the mod_md docs, and want some clarification on the following. In 
> the docs for directive ManagedDomain, we have:

Thanks for reviewing these.

> There are two special names that you may use in this directive: 'manual' and 
> 'auto'. This determines if a Managed Domain shall have exactly the name list 
> as is configured ('manual') or offer more convenience. With 'auto' all names 
> of a virtual host are added to a MD.
> 
> This is followed by an example that uses neither 'manual' nor 'auto', and 
> thus it's unclear what the above paragraph refers to.

I updated the section with an additional example and more explanation.

> I believe that it refers to the MDDriveMode directive, which does not appear 
> in the example.
> 
> I propose to patch the above paragraph to clarify that that's what's being 
> talked about.
> 


> Related: I also would like to question the wisdom of having a ManagedDomain 
> directive and a  container. This will most assuredly lead to 
> user confusion and lengthy IRC conversations. I would request that the naming 
> of one of these directives be reconsidered. (No, I'm not suggesting anything. 
> I suck at naming things.)

I concur that you have more experience in supporting httpd users than myself. 
Personally, I do like it obviously. 

(I am biased and suck at renaming things.)

-Stefan

mod_ssl and SSLPolicy

[Rich Bowen]

As one of the folks that answers questions on IRC, I would like to 
object to the existence of SSLPolicy and . I think it's 
unwise to have two directives with the same name, for reasons of 
end-user support.


As long as it's still only in trunk, we still have an opportunity to 
avert user confusion.


I request that one of these be renamed. (No, I'm not suggesting specific 
names. I suck at naming things.)


Thanks.

--Rich

[docs] mod_md documentation clarification

[Rich Bowen]

I'm reading the mod_md docs, and want some clarification on the 
following. In the docs for directive ManagedDomain, we have:


There are two special names that you may use in this directive: 'manual' 
and 'auto'. This determines if a Managed Domain shall have exactly the 
name list as is configured ('manual') or offer more convenience. With 
'auto' all names of a virtual host are added to a MD.


This is followed by an example that uses neither 'manual' nor 'auto', 
and thus it's unclear what the above paragraph refers to.


I believe that it refers to the MDDriveMode directive, which does not 
appear in the example.


I propose to patch the above paragraph to clarify that that's what's 
being talked about.


Related: I also would like to question the wisdom of having a 
ManagedDomain directive and a  container. This will most 
assuredly lead to user confusion and lengthy IRC conversations. I would 
request that the naming of one of these directives be reconsidered. (No, 
I'm not suggesting anything. I suck at naming things.)