[jira] [Commented] (LENS-1325) Support encoded urls for query HTTP notifications
[ https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588492#comment-15588492 ] Puneet Gupta commented on LENS-1325: https://reviews.apache.org/r/52341 > Support encoded urls for query HTTP notifications > - > > Key: LENS-1325 > URL: https://issues.apache.org/jira/browse/LENS-1325 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.7 > > > This notification url is working : > http://x:8000/v1/data/?access_token=ABC123 > This is giving 400 bad request : > http://:8000/v1/data/?access_token=ABC123=xyz > Please check. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52341/ --- (Updated Oct. 19, 2016, 9:50 a.m.) Review request for lens. Changes --- - Fixed Review comment - Merged with master again Bugs: lens-1325 https://issues.apache.org/jira/browse/lens-1325 Repository: lens Description --- 1. Added test cases to test multiple query parsms 2. Test with complex param value that requires encoding at the time of submission Diffs (updated) - lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java 1760bec lens-server/src/main/resources/lenssession-default.xml b6bfa2e lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java 6a57b20 lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 415f56f src/site/apt/admin/session-config.apt c4b3c04 Diff: https://reviews.apache.org/r/52341/diff/ Testing --- mvn test -Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" -pl lens-server T E S T S --- Running org.apache.lens.server.query.TestQueryService Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - in org.apache.lens.server.query.TestQueryService Results : Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 **Logs form TestQueryNotifictaionResource show params access_token and data are recived correctly** lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt: Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0 lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status: SUCCESSFUL lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status Message: Query is successful! lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is Result Set Available: true lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt- eventtype:FINISHED access_token:ABC123 data:null lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log -- lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt: Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0 lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status: SUCCESSFUL lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status Message: Query is successful! lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is Result Set Available: true lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt- eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log **Logs from lens server show succes for both the urls** puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent successfully" lens-server/target/test.log 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a [QueryEndHttpNotifier_AsyncThread-2] INFO org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a to http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123. Response code 204 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a [QueryEndHttpNotifier_AsyncThread-2] INFO org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a to http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123=x%3C%3Eyz%2C%22abc. Response code 204 Thanks, Puneet Gupta
Re: Review Request 51964: LENS-317: Server side calls for updating database jars
er/metastore/MetastoreResource.java (line 1581) <https://reviews.apache.org/r/51964/#comment32> This file size is passed by the client and can be dummy size. Do we need to reconfirm theactual size on server (This can be done while copying jar to local)? lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (lines 1582 - 1584) <https://reviews.apache.org/r/51964/#comment31> Space required before FileSize and AllowedSize lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 51) <https://reviews.apache.org/r/51964/#comment221940> can we update the variable name to match the ds lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 84) <https://reviews.apache.org/r/51964/#comment221943> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 91) <https://reviews.apache.org/r/51964/#comment221947> should we call this in the end ? I feel, the INITED state can be flagged after local initialization. lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (lines 113 - 116) <https://reviews.apache.org/r/51964/#comment221950> else part can be skipped. resTopDir is already initialized. If it makes sense , we can move this initialization (resTopDir = getHiveConf().get(LensConfConstants.DATABASE_RESOURCE_DIR...)) to init() method also. lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 121) <https://reviews.apache.org/r/51964/#comment221977> Should we change this to "DB resources base location does not exist" ? lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 125) <https://reviews.apache.org/r/51964/#comment221978> Should we chnage the message to "Error locating DB resources base directory" ? lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 192) <https://reviews.apache.org/r/51964/#comment222001> can we log "dbResEntryMap.get(dbname)" instaed lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 295) <https://reviews.apache.org/r/51964/#comment222037> can we also add DB name in error message lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 415) <https://reviews.apache.org/r/51964/#comment23> Should we remove Map from method name lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 429) <https://reviews.apache.org/r/51964/#comment22> When is readClassLoaderFromCache false ? - Puneet Gupta On Oct. 14, 2016, 8:29 a.m., Sushil Mohanty wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51964/ > --- > > (Updated Oct. 14, 2016, 8:29 a.m.) > > > Review request for lens. > > > Bugs: LENS-317 > https://issues.apache.org/jira/browse/LENS-317 > > > Repository: lens > > > Description > --- > > Server side api call to update database jar without restarting lens server. > More details can be found in LENS-317. > > > Diffs > - > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java > c6ae02b > lens-client/src/main/java/org/apache/lens/client/LensClient.java e936798 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > bb15b23 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 8cf617b > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > lens-server/pom.xml 6dea9a7 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 9d823da > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java > 511e4cf > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 34c901c > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > e48eab4 > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 7cccf30 > lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java > 67cee57 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestDatabaseService.java > PRE-CREATION > > lens-server/src/test/java/
Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52924/#review152869 --- lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java (line 42) <https://reviews.apache.org/r/52924/#comment222034> This needs to be done based on cost in post estimate. - Puneet Gupta On Oct. 17, 2016, 12:08 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52924/ > --- > > (Updated Oct. 17, 2016, 12:08 p.m.) > > > Review request for lens. > > > Bugs: LENS-1359 > https://issues.apache.org/jira/browse/LENS-1359 > > > Repository: lens > > > Description > --- > > > Diffs > - > > lens-driver-hive/src/main/resources/hivedriver-default.xml > f5fd3bb20b9d6b82292c4483d860ea14c8104c5c > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 43b33f331f4d9017d76bccbe0f6936aaeb184f8f > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > 961ec4ec781d3d7fd0f28edc4f23e9b39549592f > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 3ae59c6ca126f0a3535974352adf97e7a495838f > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > 8f30aa06ab234cedb53acb17544210ba4190ab53 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java > 69a1a0b7ce57c24602a17ea7c97c0664a77c6568 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java > f8a9ee07d8c8b737a41de339ab44ca7752c90748 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 146223942d05cfd952599297144e2a6bc02df273 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java > 4f1f2eb99ed0bec8e6e471a9723a6b002a092202 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/PriorityBasedQueryHookTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java > f70979abf7c44d3b4ed3588628de5a7517adfa81 > src/site/apt/admin/hivedriver-config.apt > b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 > > Diff: https://reviews.apache.org/r/52924/diff/ > > > Testing > --- > > > Thanks, > > Rajat Khandelwal > >
Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52924/#review152845 --- lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java (line 38) <https://reviews.apache.org/r/52924/#comment222011> Can we add a simple test case for this? To keep it simple we can use mutiple usser hooks in the chain and test pre rewrite. lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java (line 28) <https://reviews.apache.org/r/52924/#comment222007> Should we add class level documentation expaling when this will be useful ? lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java (lines 31 - 32) <https://reviews.apache.org/r/52924/#comment222009> Can we use a Set instead for faster search/conatins opeartion ? - Puneet Gupta On Oct. 17, 2016, 10:25 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52924/ > --- > > (Updated Oct. 17, 2016, 10:25 a.m.) > > > Review request for lens. > > > Bugs: LENS-1359 > https://issues.apache.org/jira/browse/LENS-1359 > > > Repository: lens > > > Description > --- > > > Diffs > - > > lens-driver-hive/src/main/resources/hivedriver-default.xml > f5fd3bb20b9d6b82292c4483d860ea14c8104c5c > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 43b33f331f4d9017d76bccbe0f6936aaeb184f8f > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > 961ec4ec781d3d7fd0f28edc4f23e9b39549592f > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 3ae59c6ca126f0a3535974352adf97e7a495838f > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > 8f30aa06ab234cedb53acb17544210ba4190ab53 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java > 69a1a0b7ce57c24602a17ea7c97c0664a77c6568 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java > f8a9ee07d8c8b737a41de339ab44ca7752c90748 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 146223942d05cfd952599297144e2a6bc02df273 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java > 4f1f2eb99ed0bec8e6e471a9723a6b002a092202 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java > f70979abf7c44d3b4ed3588628de5a7517adfa81 > src/site/apt/admin/hivedriver-config.apt > b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 > > Diff: https://reviews.apache.org/r/52924/diff/ > > > Testing > --- > > > Thanks, > > Rajat Khandelwal > >
Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications
> On Sept. 29, 2016, 9:59 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java, > > line 1910 > > <https://reviews.apache.org/r/52341/diff/1/?file=1511960#file1511960line1910> > > > > Should we encode the full url, instead of only values passed? lens server is posting notification on the received url as such without modifying it. To do this the base path should not be encoded. only parameter values need to be encoded incase they have special characters. if the parameter values have no special character, encoding is not required. - Puneet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52341/#review150831 --- On Sept. 28, 2016, 11:18 a.m., Puneet Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52341/ > --- > > (Updated Sept. 28, 2016, 11:18 a.m.) > > > Review request for lens. > > > Bugs: lens-1325 > https://issues.apache.org/jira/browse/lens-1325 > > > Repository: lens > > > Description > --- > > 1. Added test cases to test multiple query parsms > 2. Test with complex param value that requires encoding at the time of > submission > > > Diffs > - > > > lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java > f264603c03f3444d2d38e17be9f6b1fcd708d0bf > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java > 3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > f755508529f6745caadd8eee0f63e81e1f14ed75 > > Diff: https://reviews.apache.org/r/52341/diff/ > > > Testing > --- > > mvn test > -Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" > -pl lens-server > > > T E S T S > --- > Running org.apache.lens.server.query.TestQueryService > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - > in org.apache.lens.server.query.TestQueryService > > Results : > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 > > > **Logs form TestQueryNotifictaionResource show params access_token and data > are recived correctly** > > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt: > Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a > queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0 > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status: > SUCCESSFUL > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status > Message: Query is successful! > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is > Result Set Available: true > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt- > eventtype:FINISHED access_token:ABC123 data:null > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep > 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log > -- > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt: > Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a > queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0 > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status: > SUCCESSFUL > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status > Message: Query is successful! > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is > Result Set Available: true > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt- > eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc > lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep > 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log > > > **Logs from lens server show succes for both the urls** > > puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP N
Re: Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52341/ --- (Updated Sept. 28, 2016, 11:18 a.m.) Review request for lens. Changes --- Updated testing messages Bugs: lens-1325 https://issues.apache.org/jira/browse/lens-1325 Repository: lens Description --- 1. Added test cases to test multiple query parsms 2. Test with complex param value that requires encoding at the time of submission Diffs - lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java f264603c03f3444d2d38e17be9f6b1fcd708d0bf lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java 3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java f755508529f6745caadd8eee0f63e81e1f14ed75 Diff: https://reviews.apache.org/r/52341/diff/ Testing (updated) --- mvn test -Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" -pl lens-server T E S T S --- Running org.apache.lens.server.query.TestQueryService Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - in org.apache.lens.server.query.TestQueryService Results : Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 **Logs form TestQueryNotifictaionResource show params access_token and data are recived correctly** lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt: Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0 lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status: SUCCESSFUL lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status Message: Query is successful! lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is Result Set Available: true lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt- eventtype:FINISHED access_token:ABC123 data:null lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log -- lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt: Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0 lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status: SUCCESSFUL lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status Message: Query is successful! lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is Result Set Available: true lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt- eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log **Logs from lens server show succes for both the urls** puneet.gupta$ grep "QueryEventHttpNotifier - FINISHED HTTP Notification sent successfully" lens-server/target/test.log 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a [QueryEndHttpNotifier_AsyncThread-2] INFO org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a to http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123. Response code 204 28 Sep 2016 11:05:05 e16f40de-57cc-4d53-86f6-54dac397b04a [QueryEndHttpNotifier_AsyncThread-2] INFO org.apache.lens.server.query.QueryEventHttpNotifier - FINISHED HTTP Notification sent successfully for query e16f40de-57cc-4d53-86f6-54dac397b04a to http://localhost:49847/lens-server/queryapi/notifictaion/finished?access_token=ABC123=x%3C%3Eyz%2C%22abc. Response code 204 Thanks, Puneet Gupta
Review Request 52341: LENS-1325: Support encoded urls for query HTTP notifications
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52341/ --- Review request for lens. Bugs: lens-1325 https://issues.apache.org/jira/browse/lens-1325 Repository: lens Description --- 1. Added test cases to test multiple query parsms 2. Test with complex param value that requires encoding at the time of submission Diffs - lens-server/src/main/java/org/apache/lens/server/query/QueryEventHttpNotifier.java f264603c03f3444d2d38e17be9f6b1fcd708d0bf lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java 3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java f755508529f6745caadd8eee0f63e81e1f14ed75 Diff: https://reviews.apache.org/r/52341/diff/ Testing --- mvn test -Dtest="org.apache.lens.server.query.TestQueryService#testFinishedNotifictaion" -pl lens-server T E S T S --- Running org.apache.lens.server.query.TestQueryService Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.449 sec - in org.apache.lens.server.query.TestQueryService Results : Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 **Logs form TestQueryNotifictaionResource show params access_token and data are recived correctly lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt: Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0 lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status: SUCCESSFUL lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status Message: Query is successful! lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is Result Set Available: true lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt- eventtype:FINISHED access_token:ABC123 data:null lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log -- lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt: Received Finished Event for queryid: e16f40de-57cc-4d53-86f6-54dac397b04a queryname:testHttpNotifictaionQuery user:foo status:Progress: 1.0 lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status: SUCCESSFUL lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Status Message: Query is successful! lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Is Result Set Available: true lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt- eventtype:FINISHED access_token:ABC123 data:x<>yz,"abc lens-server/target/surefire-reports/org.apache.lens.server.query.TestQueryService-output.txt-Sep 28, 2016 4:35:05 PM org.glassfish.jersey.filter.LoggingFilter log Thanks, Puneet Gupta
[jira] [Work started] (LENS-1325) Support encoded urls for query HTTP notifications
[ https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-1325 started by Puneet Gupta. -- > Support encoded urls for query HTTP notifications > - > > Key: LENS-1325 > URL: https://issues.apache.org/jira/browse/LENS-1325 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.7 > > > This notification url is working : > http://x:8000/v1/data/?access_token=ABC123 > This is giving 400 bad request : > http://:8000/v1/data/?access_token=ABC123=xyz > Please check. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release of Apache Lens 2.6.1
Guys, I will be traveling. Will be back after a week. In my absence Rajat Khandelwal will take care of 2.6.1 release Thanks, Puneet Gupta On Wed, Sep 28, 2016 at 2:24 PM, Amareshwari Sriramdasu < amareshw...@apache.org> wrote: > +1 to release the candidate. But found a couple of issues with release > which are noted down. > > Verified the following : > + Jars in Nexus repo : Good. > + Signatures : Good > + Checksums : Good > + No unexpected binaries found in the source release. > + NOTICE is good. > + Building from source : Successful > - LICENSE issues : found an issue with one of the files > : ./lens-ui/app/dispatcher/AppDispatcher.js > The file is having copyright from Facebook and text says the license is BSD > style which is in root directory of the source. But I don't see any > corresponding license in root directory of the source. Seems the file is > added in 2.5 release itself, but we need to put its corresponding license > to top level LICENSE file. I'm fine fixing it in next release. > - Ran examples from binary distribution : Seeing all cube queries are > failing. Not sure if the issue is only with examples. > > > > Successful queries 14 out of 151queries > > Total time for running examples(in millis) :39462 > > --- > > Thanks > Amareshwari > > On Tue, Sep 27, 2016 at 7:43 PM, Puneet Gupta <puneetgu...@apache.org> > wrote: > > > Hi everyone, > > > > I propose the following RC to be released as official Apache Lens 2.6.1 > > release. > > > > The commit id is 7224d832de56ac7a22a06bb285808cfac33f32f2: > > http://git-wip-us.apache.org/repos/asf/lens/commit/7224d832d > > > > This corresponds to the tag: apache-lens-2.6.1: > > https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=r > > efs/tags/apache-lens-2.6.1 > > > > Release archives (tar.gz/.zip), signature, and checksums are here: > > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.1-rc0/ > > > > You can find the KEYS file here: > > https://dist.apache.org/repos/dist/release/lens/KEYS > > > > The release candidate consists of the following source distribution > archive > > apache-lens-2.6.1-source-release.zip: > > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6. > > 1-rc0/apache-lens-2.6.1-source-release.zip > > > > In addition, the following supplementary binary distributions are > provided > > for user convenience at the same location:apache-lens-2.6.1-bin.tar.gz: > > https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6. > > 1-rc0/apache-lens-2.6.1-bin.tar.gz > > > > The licensing of bundled bits in the archives are documented at > > https://cwiki.apache.org/confluence/display/LENS/ > Licensing+in+Apache+Lens > > > > Nexus staging url: > > https://repository.apache.org/content/repositories/orgapachelens-1010/ > > > > Release notes available at > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > > ctId=12315923=12333846 > > > > > > Vote will be open for at least 72 hours > > > > [ ] +1 approve > > [ ] 0 no opinion > > [ ] -1 disapprove (and reason why) > > > > +1 from my side for the release. > > > > For folks not familiar with vetting a release, please refer to > > > > http://incubator.apache.org/guides/releasemanagement.html#check-list > > >
Re: Review Request 52337: LENS-1324: Support more hooks in DriverQueryHook
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52337/ --- (Updated Sept. 28, 2016, 7:04 a.m.) Review request for lens. Changes --- Fixed Checkstyle Bugs: lens-1324 https://issues.apache.org/jira/browse/lens-1324 Repository: lens Description --- Currently we have two hooks 1. preLaunch 2. postDriverSelection Need to add some hooks that can hook into rewrite and estimate flow also. 1.preRewrite, postRewrite 2.preEstimate,postEstimate NoOpDriverQueryHook will have default empty implementation for these new methods . Also added void setDriver(LensDriver driver) in Driver Hook to pass the driver information. Diffs (updated) - lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 84d9933 lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 3bf5e8f lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 03079e2 lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java da125bd lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 8cd03cb lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 792508b lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 168b3cc lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java 0c4a3f0 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 0bb106e lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java f755508 Diff: https://reviews.apache.org/r/52337/diff/ Testing --- --- T E S T S --- Running org.apache.lens.server.query.TestQueryService Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 84.906 sec - in org.apache.lens.server.query.TestQueryService Results : Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 04:41 min [INFO] Finished at: 2016-09-28T11:47:07+05:30 [INFO] Final Memory: 133M/1482M [INFO] Thanks, Puneet Gupta
Re: Review Request 52028: LENS-1308: User config loader database calls not inserting entries
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52028/#review150689 --- Fix it, then Ship it! Ship It! lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (line 84) <https://reviews.apache.org/r/52028/#comment218727> Can we confirm that before this patch createFinishedQueriesTable() was not creating a table for a non in-memory database since there is no explicit commit statement and auto commit was turned off ? Test cases seem to pass, but then we use in-memory dbs for test cases. - Puneet Gupta On Sept. 19, 2016, 11:35 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52028/ > --- > > (Updated Sept. 19, 2016, 11:35 a.m.) > > > Review request for lens. > > > Bugs: LENS-1308 > https://issues.apache.org/jira/browse/LENS-1308 > > > Repository: lens > > > Description > --- > > > Diffs > - > > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 2ec938e951522b3026f6485ff900268d6e0039cd > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 90226d121b5a1ca50e3fcb786437a9198d97a692 > > Diff: https://reviews.apache.org/r/52028/diff/ > > > Testing > --- > > > Thanks, > > Rajat Khandelwal > >
[jira] [Commented] (LENS-1324) Support more hooks in DriverQueryHook
[ https://issues.apache.org/jira/browse/LENS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528607#comment-15528607 ] Puneet Gupta commented on LENS-1324: https://reviews.apache.org/r/52337/ > Support more hooks in DriverQueryHook > - > > Key: LENS-1324 > URL: https://issues.apache.org/jira/browse/LENS-1324 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.7 > > > Currently we have two hooks > 1. preLaunch > 2. postDriverSelection > Need to add some hooks that can hook into rewrite and estimate flow also. > 1.preRewrite, postRewrite > 2.preEstimate,postEstimate > NoOpDriverQueryHook will have default empty implementation for these new > methods . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Review Request 52337: LENS-1324: Support more hooks in DriverQueryHook
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52337/ --- Review request for lens. Bugs: lens-1324 https://issues.apache.org/jira/browse/lens-1324 Repository: lens Description --- Currently we have two hooks 1. preLaunch 2. postDriverSelection Need to add some hooks that can hook into rewrite and estimate flow also. 1.preRewrite, postRewrite 2.preEstimate,postEstimate NoOpDriverQueryHook will have default empty implementation for these new methods . Also added void setDriver(LensDriver driver) in Driver Hook to pass the driver information. Diffs - lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 84d9933da506e3f1bff2d3e0ea403ed1edf0fe35 lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 3bf5e8f7dc9d032e46d06c3245048096acb4572e lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java 03079e2dc353fa028f3c5d5a03a8ae2dbf728004 lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java da125bd920aea82dc910fad92290d07fcc2a2387 lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java 8cd03cb11ae88413973a9fc384fd828014b1aa0c lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java 792508b14b9228ff20437d03f78e38165d920798 lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 168b3cc8a2e32e4fddb66f480af38e77adef62c2 lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java 0c4a3f05ce752091d2187badf2054c3926c7c9f6 lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 0bb106ed77306094710c126fc652d5c56a908d85 lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java f755508529f6745caadd8eee0f63e81e1f14ed75 Diff: https://reviews.apache.org/r/52337/diff/ Testing --- --- T E S T S --- Running org.apache.lens.server.query.TestQueryService Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 84.906 sec - in org.apache.lens.server.query.TestQueryService Results : Tests run: 2, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 04:41 min [INFO] Finished at: 2016-09-28T11:47:07+05:30 [INFO] Final Memory: 133M/1482M [INFO] Thanks, Puneet Gupta
[jira] [Work started] (LENS-1324) Support more hooks in DriverQueryHook
[ https://issues.apache.org/jira/browse/LENS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-1324 started by Puneet Gupta. -- > Support more hooks in DriverQueryHook > - > > Key: LENS-1324 > URL: https://issues.apache.org/jira/browse/LENS-1324 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.7 > > > Currently we have two hooks > 1. preLaunch > 2. postDriverSelection > Need to add some hooks that can hook into rewrite and estimate flow also. > 1.preRewrite, postRewrite > 2.preEstimate,postEstimate > NoOpDriverQueryHook will have default empty implementation for these new > methods . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-743) Query failure retries for transient errors
[ https://issues.apache.org/jira/browse/LENS-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528395#comment-15528395 ] Puneet Gupta commented on LENS-743: --- [~prongs] Thanks for documenting this one in such detail. +1 for dual re-policy (driver+server) I had one doubt. Suppose we have 3 drivers (d1,d,2,d3). Query was run on d1 and failed twice and d1's policy confirmed a no-retry. The server policy said try on d2,d3 and d2 was chosen based on cost. Then 2 tries were done on d2 and they failed too and d2's policy confirmed a no-retry. Will the server policy now try on d3 alone now or d1 and d3? > Query failure retries for transient errors > -- > > Key: LENS-743 > URL: https://issues.apache.org/jira/browse/LENS-743 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Amareshwari Sriramadasu >Assignee: Rajat Khandelwal > Labels: gsoc2016, java > > There have to be retries for query failures for transient errors like network > errors (Hive server not reachable/ Metastore not reachable/ DB not > reachable). Retries should be available for each phase - submission, > execution, updating status, fetching results and formatting. > Right now, any such failure results in marking query as failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[VOTE] Release of Apache Lens 2.6.1
Hi everyone, I propose the following RC to be released as official Apache Lens 2.6.1 release. The commit id is 7224d832de56ac7a22a06bb285808cfac33f32f2: http://git-wip-us.apache.org/repos/asf/lens/commit/7224d832d This corresponds to the tag: apache-lens-2.6.1: https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=refs/tags/apache-lens-2.6.1 Release archives (tar.gz/.zip), signature, and checksums are here: https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.1-rc0/ You can find the KEYS file here: https://dist.apache.org/repos/dist/release/lens/KEYS The release candidate consists of the following source distribution archive apache-lens-2.6.1-source-release.zip: https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.1-rc0/apache-lens-2.6.1-source-release.zip In addition, the following supplementary binary distributions are provided for user convenience at the same location:apache-lens-2.6.1-bin.tar.gz: https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.1-rc0/apache-lens-2.6.1-bin.tar.gz The licensing of bundled bits in the archives are documented at https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens Nexus staging url: https://repository.apache.org/content/repositories/orgapachelens-1010/ Release notes available at https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315923=12333846 Vote will be open for at least 72 hours [ ] +1 approve [ ] 0 no opinion [ ] -1 disapprove (and reason why) +1 from my side for the release. For folks not familiar with vetting a release, please refer to http://incubator.apache.org/guides/releasemanagement.html#check-list
Re: Review Request 52297: LENS-1336: lens/contrib is not included in modules
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52297/#review150535 --- Ship it! Ship It! - Puneet Gupta On Sept. 27, 2016, 8:17 a.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52297/ > --- > > (Updated Sept. 27, 2016, 8:17 a.m.) > > > Review request for lens. > > > Bugs: LENS-1336 > https://issues.apache.org/jira/browse/LENS-1336 > > > Repository: lens > > > Description > --- > > > Diffs > - > > contrib/clients/python/README.md 93a19c998f7fb4b98c8f0d8f641c729a1391d24d > contrib/clients/python/pom.xml a849038ba4c6b52fc898e3a7ae41c604e9452de1 > > Diff: https://reviews.apache.org/r/52297/diff/ > > > Testing > --- > > > Thanks, > > Rajat Khandelwal > >
[jira] [Updated] (LENS-1337) Update Release documentation for lens 2.6.1
[ https://issues.apache.org/jira/browse/LENS-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1337: --- Attachment: lens-1337.v2.patch "updated 2.6.x docs link to 2.6.1" in release-history.apt > Update Release documentation for lens 2.6.1 > --- > > Key: LENS-1337 > URL: https://issues.apache.org/jira/browse/LENS-1337 > Project: Apache Lens > Issue Type: Sub-task > Components: build >Affects Versions: 2.6 >Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.6 > > Attachments: lens-1337.patch, lens-1337.v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (LENS-1337) Update Release documentation for lens 2.6.1
[ https://issues.apache.org/jira/browse/LENS-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta reassigned LENS-1337: -- Assignee: Puneet Gupta > Update Release documentation for lens 2.6.1 > --- > > Key: LENS-1337 > URL: https://issues.apache.org/jira/browse/LENS-1337 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Attachments: lens-1337.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (LENS-1337) Update Release documentation for lens 2.6.1
[ https://issues.apache.org/jira/browse/LENS-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516706#comment-15516706 ] Puneet Gupta edited comment on LENS-1337 at 9/23/16 3:05 PM: - [~amareshwari] can you check the doc changes was (Author: puneet884): @Amareshwari can you check the doc changes > Update Release documentation for lens 2.6.1 > --- > > Key: LENS-1337 > URL: https://issues.apache.org/jira/browse/LENS-1337 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Attachments: lens-1337.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1337) Update Release documentation for lens 2.6.1
[ https://issues.apache.org/jira/browse/LENS-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516706#comment-15516706 ] Puneet Gupta commented on LENS-1337: @Amareshwari can you check the doc changes > Update Release documentation for lens 2.6.1 > --- > > Key: LENS-1337 > URL: https://issues.apache.org/jira/browse/LENS-1337 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Attachments: lens-1337.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1337) Update Release documentation for lens 2.6.1
[ https://issues.apache.org/jira/browse/LENS-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1337: --- Attachment: lens-1337.patch > Update Release documentation for lens 2.6.1 > --- > > Key: LENS-1337 > URL: https://issues.apache.org/jira/browse/LENS-1337 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta > Attachments: lens-1337.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1337) Update Release documentation for lens 2.6.1
[ https://issues.apache.org/jira/browse/LENS-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15516701#comment-15516701 ] Puneet Gupta commented on LENS-1337: Looks like only release-history.apt needs version change. The download.apt should not require change in download link. > Update Release documentation for lens 2.6.1 > --- > > Key: LENS-1337 > URL: https://issues.apache.org/jira/browse/LENS-1337 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Issue Comment Deleted] (LENS-1336) lens/contrib is not included in modules
[ https://issues.apache.org/jira/browse/LENS-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1336: --- Comment: was deleted (was: Simple patch attaching directly .) > lens/contrib is not included in modules > > > Key: LENS-1336 > URL: https://issues.apache.org/jira/browse/LENS-1336 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta >Priority: Blocker > Fix For: 2.6 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1336) lens/contrib is not included in modules
[ https://issues.apache.org/jira/browse/LENS-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1336: --- Attachment: (was: lens-1336.patch) > lens/contrib is not included in modules > > > Key: LENS-1336 > URL: https://issues.apache.org/jira/browse/LENS-1336 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta >Priority: Blocker > Fix For: 2.6 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1336) lens/contrib is not included in modules
[ https://issues.apache.org/jira/browse/LENS-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1336: --- Attachment: lens-1336.patch Simple patch attaching directly . > lens/contrib is not included in modules > > > Key: LENS-1336 > URL: https://issues.apache.org/jira/browse/LENS-1336 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta >Priority: Blocker > Fix For: 2.6 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1337) Update Release documentation for lens 2.6.1
Puneet Gupta created LENS-1337: -- Summary: Update Release documentation for lens 2.6.1 Key: LENS-1337 URL: https://issues.apache.org/jira/browse/LENS-1337 Project: Apache Lens Issue Type: Sub-task Reporter: Puneet Gupta -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release of Apache Lens 2.6.0
Canceling the vote . LENS-1336 needs to be fixed to include lens contrib module Thanks, Puneet Gupta On Fri, Sep 23, 2016 at 5:59 PM, Raju Bairishetti <r...@apache.org> wrote: > -1 from my side. > > Looks like you need to manually update the version in contrib module > after* > release:prepare step* as version changes are done by release:prepare step. > > On Fri, Sep 23, 2016 at 5:02 PM, Raju Bairishetti <r...@apache.org> wrote: > > > Hi Puneet, > > > >Release version was not updated to 2.6.0 in *contrib* module(i.e. > > python-lens-client) contrib-pom.xml > > <https://github.com/apache/lens/blob/apache-lens-2.6.0/contrib/pom.xml>. > > *contrib *module is not part of modules section. So updating version > > through `*mvn versions:set`* command won't update the versions in the > > contrib module. We need to update the release version manually :). > > > > Can you update the release process about this issue on the cwiki as > well? > > > > I have not verified release fully. I will post my vote after verifying > > the release fully. > > > > > > On Thu, Sep 22, 2016 at 10:34 PM, Puneet Gupta <puneetgu...@apache.org> > > wrote: > > > >> Hi everyone, > >> > >> I propose the following RC to be released as official Apache Lens 2.6.0 > >> release. > >> > >> The commit id is 925094f44923b33767a9d1d4bc9ea6b2bb3fe229: > >> http://git-wip-us.apache.org/repos/asf/lens/commit/925094f44 > >> > >> This corresponds to the tag: apache-lens-2.6.0: > >> https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=r > >> efs/tags/apache-lens-2.6.0 > >> > >> Release archives (tar.gz/.zip), signature, and checksums are here: > >> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.0-rc0/ > >> > >> You can find the KEYS file here: > >> https://dist.apache.org/repos/dist/release/lens/KEYS > >> > >> The release candidate consists of the following source distribution > >> archive > >> apache-lens-2.6.0-source-release.zip: > >> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6. > >> 0-rc0/apache-lens-2.6.0-source-release.zip > >> > >> In addition, the following supplementary binary distributions are > provided > >> for user convenience at the same location:apache-lens-2.6.0-bin.tar.gz: > >> https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6. > >> 0-rc0/apache-lens-2.6.0-bin.tar.gz > >> > >> The licensing of bundled bits in the archives are documented at > >> https://cwiki.apache.org/confluence/display/LENS/Licensing+ > in+Apache+Lens > >> > >> Nexus staging url: > >> https://repository.apache.org/content/repositories/orgapachelens-1009/ > >> > >> Release notes available at > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje > >> ctId=12315923=12333846 > >> > >> > >> Vote will be open for at least 72 hours > >> > >> [ ] +1 approve > >> [ ] 0 no opinion > >> [ ] -1 disapprove (and reason why) > >> > >> +1 from my side for the release. > >> > >> For folks not familiar with vetting a release, please refer to > >> > >> http://incubator.apache.org/guides/releasemanagement.html#check-list > >> > > > > > > > > -- > > > > -- > > Thanks, > > Raju Bairishetti, > > www.lazada.com > > > > > > -- > > -- > Thanks, > Raju Bairishetti, > www.lazada.com > -- _ The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email and then delete it from your system. The firm is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.
[jira] [Created] (LENS-1336) lens/contrib is not included in modules
Puneet Gupta created LENS-1336: -- Summary: lens/contrib is not included in modules Key: LENS-1336 URL: https://issues.apache.org/jira/browse/LENS-1336 Project: Apache Lens Issue Type: Bug Reporter: Puneet Gupta Priority: Blocker Fix For: 2.6 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Tableau with Lens
+Deepak
Thanks,
Puneet Gupta
On Wed, Sep 21, 2016 at 7:53 PM, Pawan Malwal <pawan.mal...@huawei.com>
wrote:
> I followed the same document and tried it. But I did not use these
> parameters
>
> ? delimited by ;>#
>
> in my URL and also I am not sure if it is mandatory to put
> *lens-client-site.xml* in LENSCPPATH. I think it would consider all the
> default values. Please let me know if you think I have missed something.
>
>
>
> Thanks
>
> Pawan Malwal
>
>
>
>
>
>
>
> *From:* amareshwarisr . [mailto:amareshw...@gmail.com]
> *Sent:* 21 September 2016 16:17
> *To:* dev <dev@lens.apache.org>; Piyush Mukati <piyush.muk...@gmail.com>
> *Cc:* u...@lens.apache.org; Sharanabasappa G Keriwaddi <sha...@huawei.com>
> *Subject:* Re: Tableau with Lens
>
>
>
> AFAIK, JDBC client should automatically connect with correct url and
> configuration as documented at http://lens.apache.org/user/jd
> bc-client.html.
>
>
>
>
>
>
>
> On Wed, Sep 21, 2016 at 3:58 PM, Puneet Gupta <puneet.gu...@inmobi.com>
> wrote:
>
> Can someone have a look at this feature.
> Jaideep, Amruth, Amareshwari ?
>
> Thanks,
> Puneet Gupta
>
> -- Forwarded message --
> From: Pawan Malwal <pawan.mal...@huawei.com>
> Date: Wed, Sep 21, 2016 at 11:24 AM
> Subject: RE: Tableau with Lens
> To: "u...@lens.apache.org" <u...@lens.apache.org>
> Cc: Sharanabasappa G Keriwaddi <sha...@huawei.com>
>
>
> Hi Puneet,
>
>
>
> I tried using this JDBC driver “org.apache.lens.client.jdbc.L
> ensJdbcDriver”
> but it is throwing “No suitable driver found for jdbc”.
>
>
>
> I checked the code of LensJdbcDriver class and found that connect method is
> not implemented and it just returns null. Not sure if I have done it right.
> Please have a look at it and let me know your views.
>
>
>
> https://github.com/apache/lens/blob/master/lens-client/src/
> main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java
>
>
>
> *public* Connection connect(String s, Properties properties) *throws*
> SQLException {
>
> *return* *null*;
>
> }
>
>
>
>
>
> Regards
>
> Pawan Malwal
>
>
>
> *From:* Puneet Gupta [mailto:puneet.gu...@inmobi.com]
> *Sent:* 19 September 2016 21:15
> *To:* u...@lens.apache.org
> *Subject:* Re: Tableau with Lens
>
>
>
>
> Hi Pawan,
>
>
>
> There is a JDBC driver . I think this will be the right place to look at to
> integrate with tableau.
>
> Also please note, there might be holes in JDBC driver implementation as its
> not tested throughly. Do give it a try. Making minor modifications should
> be easy.
>
>
>
> Code Path : lens-client/src/main/java/org/apache/lens/client/jdbc/
>
>
>
> Thanks,
>
> Puneet Gupta
>
>
>
> On Mon, Sep 19, 2016 at 6:20 PM, Pawan Malwal <pawan.mal...@huawei.com>
> wrote:
>
> Hi Lens Developers,
>
>
>
> I am trying to use Tableau with Lens. Not sure how it should be
> configured.? Is there any plugin or something.? Could you please let me
> know how can this be done or direct me to any link or documentation.
>
>
>
> Regards
>
> Pawan Malwal
>
>
>
>
>
>
>
>
>
>
>
>
>
> _
>
> The information contained in this communication is intended solely for the
> use of the individual or entity to whom it is addressed and others
> authorized to receive it. It may contain confidential or legally privileged
> information. If you are not the intended recipient you are hereby notified
> that any disclosure, copying, distribution or taking any action in reliance
> on the contents of this information is strictly prohibited and may be
> unlawful. If you have received this communication in error, please notify
> us immediately by responding to this email and then delete it from your
> system. The firm is neither liable for the proper and complete transmission
> of the information contained in this communication nor for any delay in its
> receipt.
>
> --
>
> _
> The information contained in this communication is intended solely for the
> use of the individual or entity to whom it is addressed and others
> authorized to receive it. It may contain confidential or legally privileged
> information. If you are not the intended recipient you are hereby notified
> that any disclosure, copying, distribution or taking any action in reliance
> on the contents of this information is strictly prohibited and may be
> unlawful. If you have recei
[VOTE] Release of Apache Lens 2.6.0
Hi everyone, I propose the following RC to be released as official Apache Lens 2.6.0 release. The commit id is 925094f44923b33767a9d1d4bc9ea6b2bb3fe229: http://git-wip-us.apache.org/repos/asf/lens/commit/925094f44 This corresponds to the tag: apache-lens-2.6.0: https://git-wip-us.apache.org/repos/asf?p=lens.git;a=tag;h=refs/tags/apache-lens-2.6.0 Release archives (tar.gz/.zip), signature, and checksums are here: https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.0-rc0/ You can find the KEYS file here: https://dist.apache.org/repos/dist/release/lens/KEYS The release candidate consists of the following source distribution archive apache-lens-2.6.0-source-release.zip: https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.0-rc0/apache-lens-2.6.0-source-release.zip In addition, the following supplementary binary distributions are provided for user convenience at the same location:apache-lens-2.6.0-bin.tar.gz: https://dist.apache.org/repos/dist/dev/lens/apache-lens-2.6.0-rc0/apache-lens-2.6.0-bin.tar.gz The licensing of bundled bits in the archives are documented at https://cwiki.apache.org/confluence/display/LENS/Licensing+in+Apache+Lens Nexus staging url: https://repository.apache.org/content/repositories/orgapachelens-1009/ Release notes available at https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315923=12333846 Vote will be open for at least 72 hours [ ] +1 approve [ ] 0 no opinion [ ] -1 disapprove (and reason why) +1 from my side for the release. For folks not familiar with vetting a release, please refer to http://incubator.apache.org/guides/releasemanagement.html#check-list
[jira] [Commented] (LENS-1315) Update gpg keys in dist repo
[ https://issues.apache.org/jira/browse/LENS-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513092#comment-15513092 ] Puneet Gupta commented on LENS-1315: Added here too https://dist.apache.org/repos/dist/release/lens/KEYS > Update gpg keys in dist repo > > > Key: LENS-1315 > URL: https://issues.apache.org/jira/browse/LENS-1315 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.6 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (LENS-1329) Validate license for new dependencies
[ https://issues.apache.org/jira/browse/LENS-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta resolved LENS-1329. Resolution: Fixed Fix Version/s: 2.6 > Validate license for new dependencies > - > > Key: LENS-1329 > URL: https://issues.apache.org/jira/browse/LENS-1329 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.6 > > > - Run "git diff -- pom.xml" > Example git diff apache-lens-2.5.0-beta -- pom.xml > - Check the license for new dependencies and make sure its compatible with > apache licensing scheme https://www.apache.org/legal/resolved.html > - If any of the new dependencies added are not apache licensed, and are > getting bundled in binary distribution, LICENSE and NOTICE should be updated > in bin-dist-files/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1331) Remove protobuf dependency from lens
[
https://issues.apache.org/jira/browse/LENS-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509795#comment-15509795
]
Puneet Gupta commented on LENS-1331:
+1
> Remove protobuf dependency from lens
>
>
> Key: LENS-1331
> URL: https://issues.apache.org/jira/browse/LENS-1331
> Project: Apache Lens
> Issue Type: Bug
> Components: build
>Affects Versions: 2.6
>Reporter: Puneet Gupta
>Assignee: Archana H
>Priority: Blocker
> Fix For: 2.6
>
> Attachments: LENS-1331.patch
>
>
> protobuf is not required to be bundled
> {noformat}
>
> com.google.protobuf
> protobuf-java
> ${protobuf.version}
>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Fwd: Tableau with Lens
Can someone have a look at this feature.
Jaideep, Amruth, Amareshwari ?
Thanks,
Puneet Gupta
-- Forwarded message --
From: Pawan Malwal <pawan.mal...@huawei.com>
Date: Wed, Sep 21, 2016 at 11:24 AM
Subject: RE: Tableau with Lens
To: "u...@lens.apache.org" <u...@lens.apache.org>
Cc: Sharanabasappa G Keriwaddi <sha...@huawei.com>
Hi Puneet,
I tried using this JDBC driver “org.apache.lens.client.jdbc.LensJdbcDriver”
but it is throwing “No suitable driver found for jdbc”.
I checked the code of LensJdbcDriver class and found that connect method is
not implemented and it just returns null. Not sure if I have done it right.
Please have a look at it and let me know your views.
https://github.com/apache/lens/blob/master/lens-client/src/
main/java/org/apache/lens/client/jdbc/LensJdbcDriver.java
*public* Connection connect(String s, Properties properties) *throws*
SQLException {
*return* *null*;
}
Regards
Pawan Malwal
*From:* Puneet Gupta [mailto:puneet.gu...@inmobi.com]
*Sent:* 19 September 2016 21:15
*To:* u...@lens.apache.org
*Subject:* Re: Tableau with Lens
Hi Pawan,
There is a JDBC driver . I think this will be the right place to look at to
integrate with tableau.
Also please note, there might be holes in JDBC driver implementation as its
not tested throughly. Do give it a try. Making minor modifications should
be easy.
Code Path : lens-client/src/main/java/org/apache/lens/client/jdbc/
Thanks,
Puneet Gupta
On Mon, Sep 19, 2016 at 6:20 PM, Pawan Malwal <pawan.mal...@huawei.com>
wrote:
Hi Lens Developers,
I am trying to use Tableau with Lens. Not sure how it should be
configured.? Is there any plugin or something.? Could you please let me
know how can this be done or direct me to any link or documentation.
Regards
Pawan Malwal
_
The information contained in this communication is intended solely for the
use of the individual or entity to whom it is addressed and others
authorized to receive it. It may contain confidential or legally privileged
information. If you are not the intended recipient you are hereby notified
that any disclosure, copying, distribution or taking any action in reliance
on the contents of this information is strictly prohibited and may be
unlawful. If you have received this communication in error, please notify
us immediately by responding to this email and then delete it from your
system. The firm is neither liable for the proper and complete transmission
of the information contained in this communication nor for any delay in its
receipt.
--
_
The information contained in this communication is intended solely for the
use of the individual or entity to whom it is addressed and others
authorized to receive it. It may contain confidential or legally privileged
information. If you are not the intended recipient you are hereby notified
that any disclosure, copying, distribution or taking any action in reliance
on the contents of this information is strictly prohibited and may be
unlawful. If you have received this communication in error, please notify
us immediately by responding to this email and then delete it from your
system. The firm is neither liable for the proper and complete transmission
of the information contained in this communication nor for any delay in its
receipt.
[jira] [Updated] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Resolution: Fixed Status: Resolved (was: Patch Available) > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Components: build, ml, regression > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.6, 2.7 > > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508918#comment-15508918 ] Puneet Gupta commented on LENS-1321: Committed myself. > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Components: build, ml, regression > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.6, 2.7 > > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Fix Version/s: 2.7 > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Components: build, ml, regression > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.6, 2.7 > > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1332) Fetching large set of queries from Lens state store shouldn't allowed
[ https://issues.apache.org/jira/browse/LENS-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508697#comment-15508697 ] Puneet Gupta commented on LENS-1332: Can we cap the number of rows returned by this REST API. If the cap is 1000 rows, we can add 1001 as limit in the SQL query and If we indeed get 1001 rows we can either fail this REST call with appropriate message or we can choose to return 1000 rows and indicate partial result. > Fetching large set of queries from Lens state store shouldn't allowed > - > > Key: LENS-1332 > URL: https://issues.apache.org/jira/browse/LENS-1332 > Project: Apache Lens > Issue Type: Improvement >Affects Versions: 2.7 >Reporter: Srikanth Sundarrajan >Assignee: Srikanth Sundarrajan > Fix For: 2.7 > > > Currently when we query the Lens server to get a list of queries, it can > result in a deluge of results if appropriate and sane filters aren't applied > (particularly for finished queries). The proposal is to apply restrictions on > the filter conditions being used. > For ex: > * One of user name, query name should be present if time & status filters > aren't applied > * If only time filter is present, it can't exceed (say 3 months) > * If status before queried is exclusively unfinished queries, these > restrictions need not apply -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (LENS-1330) Remove protobuf dependency from lens
[
https://issues.apache.org/jira/browse/LENS-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Puneet Gupta resolved LENS-1330.
Resolution: Duplicate
> Remove protobuf dependency from lens
>
>
> Key: LENS-1330
> URL: https://issues.apache.org/jira/browse/LENS-1330
> Project: Apache Lens
> Issue Type: Bug
> Reporter: Puneet Gupta
> Assignee: Puneet Gupta
>
> protobuf is not required to be bundled
> {noformat}
>
> com.google.protobuf
> protobuf-java
> ${protobuf.version}
>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (LENS-1314) Update 2.6 release documentation
[ https://issues.apache.org/jira/browse/LENS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1314: --- Fix Version/s: 2.6 Status: Patch Available (was: Open) > Update 2.6 release documentation > > > Key: LENS-1314 > URL: https://issues.apache.org/jira/browse/LENS-1314 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.6 > > Attachments: lens-1314.v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1314) Update 2.6 release documentation
[ https://issues.apache.org/jira/browse/LENS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1314: --- Attachment: (was: lens-1314.patch) > Update 2.6 release documentation > > > Key: LENS-1314 > URL: https://issues.apache.org/jira/browse/LENS-1314 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Attachments: lens-1314.v2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1013) DriverQueryHook should support postSelect option also.
[ https://issues.apache.org/jira/browse/LENS-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1013: --- Labels: incompatible (was: ) > DriverQueryHook should support postSelect option also. > -- > > Key: LENS-1013 > URL: https://issues.apache.org/jira/browse/LENS-1013 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Labels: incompatible > Fix For: 2.6 > > Attachments: lens-1013.v7.patch > > > as of now DriverQueryHook has a preLaunch() method which is called just > before launching the query . > We should also have an option to interact with hook on postSelect() which > will be called once query has been accepted by lens server and appropriate > driver has been selected for it. > Also as of now, the preLaunch() is called by individual driver. This should > be moved to server and drivers should not manage this operation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1187) Refactor exception handling in MetastoreResource
[ https://issues.apache.org/jira/browse/LENS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1187: --- Labels: incompatible (was: ) > Refactor exception handling in MetastoreResource > > > Key: LENS-1187 > URL: https://issues.apache.org/jira/browse/LENS-1187 > Project: Apache Lens > Issue Type: Sub-task >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Labels: incompatible > Fix For: 2.6 > > Attachments: LENS-1187.04.patch, LENS-1187.06.patch, > LENS-1187.07.patch, LENS-1187.09.patch, LENS-1187.10.patch, LENS-1187.11.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-909) We should avoid sending email notification with inmemory results
[
https://issues.apache.org/jira/browse/LENS-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Puneet Gupta updated LENS-909:
--
Labels: incompatible (was: )
> We should avoid sending email notification with inmemory results
>
>
> Key: LENS-909
> URL: https://issues.apache.org/jira/browse/LENS-909
> Project: Apache Lens
> Issue Type: Improvement
> Components: server
>Reporter: Amareshwari Sriramadasu
>Assignee: Puneet Gupta
> Labels: incompatible
> Fix For: 2.6
>
> Attachments: lens-909.v8.patch
>
>
> Right now, when result is not persisted , result will be available in memory.
> And user would fetch the results inmemory.
> With email notification being sent, only of them will be able to fetch
> results.
> If email notifier already reads the results, then client cannot fetch and
> vice versa.
> {noformat}
> 22 Dec 2015 05:23:55 [3afde72b-05ba-4979-91d0-185984e25a40]
> [event_processor_thread] ERROR org.apache.lens.server.query.QueryEndNotifier
> - Error retrieving result of query handle
> 3afde72b-05ba-4979-91d0-185984e25a40 for sending e-mail
> org.apache.lens.server.api.error.LensException: INTERNAL_SERVER_ERROR
> at
> org.apache.lens.driver.jdbc.JDBCResultSet.hasNext(JDBCResultSet.java:323)
> ~[lens-driver-jdbc-2.5.1-inm.jar:2.5.1-inm]
> at
> org.apache.lens.server.api.driver.InMemoryResultSet.toQueryResult(InMemoryResultSet.java:80)
> ~[lens-server-api-2.5.1-inm.jar:2.5.1-inm]
> at
> org.apache.lens.server.api.driver.InMemoryResultSet.toQueryResult(InMemoryResultSet.java:33)
> ~[lens-server-api-2.5.1-inm.jar:2.5.1-inm]
> at
> org.apache.lens.server.query.QueryEndNotifier.getResultMessage(QueryEndNotifier.java:163)
> [classes/:na]
> at
> org.apache.lens.server.query.QueryEndNotifier.createMailMessage(QueryEndNotifier.java:143)
> [classes/:na]
> at
> org.apache.lens.server.query.QueryEndNotifier.process(QueryEndNotifier.java:125)
> [classes/:na]
> at
> org.apache.lens.server.query.QueryEndNotifier.process(QueryEndNotifier.java:54)
> [classes/:na]
> at
> org.apache.lens.server.api.events.AsyncEventListener$2.run(AsyncEventListener.java:101)
> [lens-server-api-2.5.1-inm.jar:2.5.1-inm]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> [na:1.7.0_67]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> [na:1.7.0_67]
> at java.lang.Thread.run(Thread.java:745) [na:1.7.0_67]
> Caused by: java.sql.SQLException: You can't operate on a closed ResultSet!!!
> at com.mchange.v2.sql.SqlUtils.toSQLException(SqlUtils.java:118)
> ~[mchange-commons-java-0.2.9.jar:0.2.9]
> at com.mchange.v2.sql.SqlUtils.toSQLException(SqlUtils.java:77)
> ~[mchange-commons-java-0.2.9.jar:0.2.9]
> at
> com.mchange.v2.c3p0.impl.NewProxyResultSet.next(NewProxyResultSet.java:690)
> ~[c3p0-0.9.5.jar:0.9.5]
> at
> org.apache.lens.driver.jdbc.JDBCResultSet.hasNext(JDBCResultSet.java:317)
> ~[lens-driver-jdbc-2.5.1-inm.jar:2.5.1-inm]
> at
> org.apache.lens.driver.jdbc.JDBCResultSet.hasNext(JDBCResultSet.java:317)
> ~[lens-driver-jdbc-2.5.1-inm.jar:2.5.1-inm]
> ... 10 common frames omitted
> Caused by: java.lang.NullPointerException: null
> at
> com.mchange.v2.c3p0.impl.NewProxyResultSet.next(NewProxyResultSet.java:684)
> ~[c3p0-0.9.5.jar:0.9.5]
> ... 11 common frames omitted
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (LENS-1215) Move cluster user determination to cli from client
[ https://issues.apache.org/jira/browse/LENS-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1215: --- Labels: incompatible (was: ) > Move cluster user determination to cli from client > -- > > Key: LENS-1215 > URL: https://issues.apache.org/jira/browse/LENS-1215 > Project: Apache Lens > Issue Type: Bug >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Labels: incompatible > Fix For: 2.6 > > Attachments: LENS-1215.2016-07-14_17:44:23.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1217) Remove old java ui server
[ https://issues.apache.org/jira/browse/LENS-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1217: --- Labels: incompatible (was: ) > Remove old java ui server > - > > Key: LENS-1217 > URL: https://issues.apache.org/jira/browse/LENS-1217 > Project: Apache Lens > Issue Type: Improvement > Components: docs, server >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Labels: incompatible > Fix For: 2.6 > > Attachments: LENS-1217.03.patch, LENS-1217.05.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1244) Mark 2.6.x release as GA and remove beta
[ https://issues.apache.org/jira/browse/LENS-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1244: --- Labels: incompatible (was: ) > Mark 2.6.x release as GA and remove beta > - > > Key: LENS-1244 > URL: https://issues.apache.org/jira/browse/LENS-1244 > Project: Apache Lens > Issue Type: Task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta >Priority: Blocker > Labels: incompatible > Fix For: 2.6 > > > Creating this issue to decide on whether we want to call current release > planned as GA release. > Please see LENS-344 for the previous discussion on marking release as beta -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1212) Enable saved queries by default
[ https://issues.apache.org/jira/browse/LENS-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1212: --- Labels: incompatible (was: ) > Enable saved queries by default > --- > > Key: LENS-1212 > URL: https://issues.apache.org/jira/browse/LENS-1212 > Project: Apache Lens > Issue Type: Task > Components: server >Reporter: Rajat Khandelwal >Assignee: Rajat Khandelwal > Labels: incompatible > Fix For: 2.6 > > Attachments: LENS-1212.2016-07-12_16:39:59.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1198) Update hive dependency to apache hive 2.1.0
[ https://issues.apache.org/jira/browse/LENS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1198: --- Labels: incompatible (was: ) > Update hive dependency to apache hive 2.1.0 > --- > > Key: LENS-1198 > URL: https://issues.apache.org/jira/browse/LENS-1198 > Project: Apache Lens > Issue Type: Task > Components: build >Reporter: Amareshwari Sriramadasu >Assignee: Rajat Khandelwal >Priority: Critical > Labels: incompatible > Fix For: 2.6 > > Attachments: LENS-1198.01.patch, LENS-1198.03.patch, > LENS-1198.2016-07-19_16:40:13.patch > > > Now that hive 2.1.0 release is available - > http://mail-archives.apache.org/mod_mbox/hive-dev/201606.mbox/%3C7194557D-CB5E-45B7-B905-82F27B7CB33F%40apache.org%3E. > We should change the dependency to apache hive 2.1.0 and remove > github.com/Inmobi/mvn-repo from repositories to look up. > Also update documentation - install and run doc, build from source doc to > use apache hive everywhere. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-919) Persist Query Priority in Lens DB
[ https://issues.apache.org/jira/browse/LENS-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-919: -- Labels: incompatible (was: ) > Persist Query Priority in Lens DB > -- > > Key: LENS-919 > URL: https://issues.apache.org/jira/browse/LENS-919 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta >Priority: Minor > Labels: incompatible > Fix For: 2.6 > > Attachments: lens-919.03.patch, lens-919.patch > > > As of now Query Priority is not persisted. The query details API shows query > priority only until query is in memory. Once purged this info is not > available . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1314) Update 2.6 release documentation
[ https://issues.apache.org/jira/browse/LENS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506065#comment-15506065 ] Puneet Gupta commented on LENS-1314: 1. Will update 2. Was already done as part of Lens-1029 ( updated doc will not reflect on webpage until 2.6 release) > Update 2.6 release documentation > > > Key: LENS-1314 > URL: https://issues.apache.org/jira/browse/LENS-1314 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Attachments: lens-1314.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [ANNOUNCE] New Apache Lens PMC member : Puneet Gupta
Thank you guys :-) Regards, Puneet Gupta On Tue, Sep 20, 2016 at 12:54 PM, archana h <archana.h...@gmail.com> wrote: > Congrats Puneet..!! :) > > On Tue, Sep 20, 2016 at 11:37 AM, Raju Bairishetti <r...@apache.org> > wrote: > > > Congratulations Puneet :) > > > > On Tue, Sep 20, 2016 at 1:43 PM, Raghavendra Singh < > > raghavendra.si...@inmobi.com> wrote: > > > > > Congrats Puneet!! > > > > > > On Sep 20, 2016 10:50 AM, "Srikanth Sundarrajan" <srik...@hotmail.com> > > > wrote: > > > > > > > Congrats Puneet. > > > > RegardsSrikanth Sundarrajan > > > > > > > > > From: amareshw...@apache.org > > > > > Date: Tue, 20 Sep 2016 09:58:54 +0530 > > > > > Subject: [ANNOUNCE] New Apache Lens PMC member : Puneet Gupta > > > > > To: dev@lens.apache.org; u...@lens.apache.org > > > > > > > > > > The Apache Lens PMC has asked Puneet Gupta to join Lens PMC. We are > > > > pleased > > > > > to announce that he has accepted. > > > > > > > > > > Being a PMC member enables Puneet to guide the direction of the > > > project. > > > > > > > > > > Join me in Congratulating Puneet ! > > > > > > > > > > Congratulations, Puneet! Looking forward for more of your > > contributions > > > > in > > > > > Apache Lens. > > > > > > > > > > Thanks > > > > > > > > > > -- > > > _ > > > The information contained in this communication is intended solely for > > the > > > use of the individual or entity to whom it is addressed and others > > > authorized to receive it. It may contain confidential or legally > > privileged > > > information. If you are not the intended recipient you are hereby > > notified > > > that any disclosure, copying, distribution or taking any action in > > reliance > > > on the contents of this information is strictly prohibited and may be > > > unlawful. If you have received this communication in error, please > notify > > > us immediately by responding to this email and then delete it from your > > > system. The firm is neither liable for the proper and complete > > transmission > > > of the information contained in this communication nor for any delay in > > its > > > receipt. > > > > > > > > > > > -- > > > > -- > > Thanks, > > Raju Bairishetti, > > www.lazada.com > > > -- _ The information contained in this communication is intended solely for the use of the individual or entity to whom it is addressed and others authorized to receive it. It may contain confidential or legally privileged information. If you are not the intended recipient you are hereby notified that any disclosure, copying, distribution or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication in error, please notify us immediately by responding to this email and then delete it from your system. The firm is neither liable for the proper and complete transmission of the information contained in this communication nor for any delay in its receipt.
[jira] [Commented] (LENS-1329) Validate license for new dependencies
[
https://issues.apache.org/jira/browse/LENS-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505996#comment-15505996
]
Puneet Gupta commented on LENS-1329:
New Dependencies
{noformat}
2.2.2
2.5.0 - TO be removed LENS-1331
{noformat}
New TEST scope dependencies (All have Apache license)
{noformat}
10.11.1.1
4.2.1
3.2.0-m3
4.1.7
{noformat}
> Validate license for new dependencies
> -
>
> Key: LENS-1329
> URL: https://issues.apache.org/jira/browse/LENS-1329
> Project: Apache Lens
> Issue Type: Sub-task
> Components: build
> Reporter: Puneet Gupta
>Assignee: Puneet Gupta
>
> - Run "git diff -- pom.xml"
> Example git diff apache-lens-2.5.0-beta -- pom.xml
> - Check the license for new dependencies and make sure its compatible with
> apache licensing scheme https://www.apache.org/legal/resolved.html
> - If any of the new dependencies added are not apache licensed, and are
> getting bundled in binary distribution, LICENSE and NOTICE should be updated
> in bin-dist-files/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Issue Comment Deleted] (LENS-1328) RAT Check for new files
[
https://issues.apache.org/jira/browse/LENS-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Puneet Gupta updated LENS-1328:
---
Comment: was deleted
(was: New Dependencies
{noformat}
2.2.2
2.5.0 - TO be removed LENS-1331
{noformat}
New TEST scope dependencies (Apache license)
{noformat}
10.11.1.1
4.2.1
3.2.0-m3
4.1.7
{noformat}
)
> RAT Check for new files
> ---
>
> Key: LENS-1328
> URL: https://issues.apache.org/jira/browse/LENS-1328
> Project: Apache Lens
> Issue Type: Sub-task
> Components: build
> Reporter: Puneet Gupta
>Assignee: Puneet Gupta
>
> Check if any new files are added which are without Apache license notice.
> Decide whether to add such files a part of rat check exclusion list in
> POM.xml or not.
> Steps:
> - 'git tag' can give you all tags, pick last release tag name
> - git diff . In the less view, search for "\-\-\-
> /dev/null" for finding files added. Search for "+++ /dev/null" for files
> deleted.
> One can also get list of added files using : git dif
> --summary | grep create . Example git diff apache-lens-2.5.0-beta --summary |
> grep create
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (LENS-1330) Remove protobuf dependency from lens
Puneet Gupta created LENS-1330:
--
Summary: Remove protobuf dependency from lens
Key: LENS-1330
URL: https://issues.apache.org/jira/browse/LENS-1330
Project: Apache Lens
Issue Type: Bug
Reporter: Puneet Gupta
Assignee: Archana H
protobuf is not required to be bundled
{noformat}
com.google.protobuf
protobuf-java
${protobuf.version}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (LENS-1331) Remove protobuf dependency from lens
Puneet Gupta created LENS-1331:
--
Summary: Remove protobuf dependency from lens
Key: LENS-1331
URL: https://issues.apache.org/jira/browse/LENS-1331
Project: Apache Lens
Issue Type: Bug
Reporter: Puneet Gupta
Assignee: Archana H
protobuf is not required to be bundled
{noformat}
com.google.protobuf
protobuf-java
${protobuf.version}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (LENS-1329) Validate license for new dependencies
Puneet Gupta created LENS-1329: -- Summary: Validate license for new dependencies Key: LENS-1329 URL: https://issues.apache.org/jira/browse/LENS-1329 Project: Apache Lens Issue Type: Sub-task Reporter: Puneet Gupta Assignee: Puneet Gupta - Run "git diff -- pom.xml" Example git diff apache-lens-2.5.0-beta -- pom.xml - Check the license for new dependencies and make sure its compatible with apache licensing scheme https://www.apache.org/legal/resolved.html - If any of the new dependencies added are not apache licensed, and are getting bundled in binary distribution, LICENSE and NOTICE should be updated in bin-dist-files/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1328) RAT Check for new files
[ https://issues.apache.org/jira/browse/LENS-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1328: --- Description: Check if any new files are added which are without Apache license notice. Decide whether to add such files a part of rat check exclusion list in POM.xml or not. Steps: - 'git tag' can give you all tags, pick last release tag name - git diff . In the less view, search for "\-\-\- /dev/null" for finding files added. Search for "+++ /dev/null" for files deleted. One can also get list of added files using : git dif --summary | grep creat . Example git diff apache-lens-2.5.0-beta --summary | grep create was: Check if any new files are added which are without Apache license. Decide whether to add such files a part of rat check exclusion list in POM.xml or not. Steps: - 'git tag' can give you all tags, pick last release tag name - git diff . In the less view, search for "\-\-\- /dev/null" for finding files added. Search for "+++ /dev/null" for files deleted. One can also get list of added files using : git dif --summary | grep creat . Example git diff apache-lens-2.5.0-beta --summary | grep create > RAT Check for new files > --- > > Key: LENS-1328 > URL: https://issues.apache.org/jira/browse/LENS-1328 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > > Check if any new files are added which are without Apache license notice. > Decide whether to add such files a part of rat check exclusion list in > POM.xml or not. > Steps: > - 'git tag' can give you all tags, pick last release tag name > - git diff . In the less view, search for "\-\-\- > /dev/null" for finding files added. Search for "+++ /dev/null" for files > deleted. > One can also get list of added files using : git dif > --summary | grep creat . Example git diff apache-lens-2.5.0-beta --summary | > grep create -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1328) RAT Check for new files
[ https://issues.apache.org/jira/browse/LENS-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1328: --- Description: Check if any new files are added which are without Apache license notice. Decide whether to add such files a part of rat check exclusion list in POM.xml or not. Steps: - 'git tag' can give you all tags, pick last release tag name - git diff . In the less view, search for "\-\-\- /dev/null" for finding files added. Search for "+++ /dev/null" for files deleted. One can also get list of added files using : git dif --summary | grep create . Example git diff apache-lens-2.5.0-beta --summary | grep create was: Check if any new files are added which are without Apache license notice. Decide whether to add such files a part of rat check exclusion list in POM.xml or not. Steps: - 'git tag' can give you all tags, pick last release tag name - git diff . In the less view, search for "\-\-\- /dev/null" for finding files added. Search for "+++ /dev/null" for files deleted. One can also get list of added files using : git dif --summary | grep creat . Example git diff apache-lens-2.5.0-beta --summary | grep create > RAT Check for new files > --- > > Key: LENS-1328 > URL: https://issues.apache.org/jira/browse/LENS-1328 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > > Check if any new files are added which are without Apache license notice. > Decide whether to add such files a part of rat check exclusion list in > POM.xml or not. > Steps: > - 'git tag' can give you all tags, pick last release tag name > - git diff . In the less view, search for "\-\-\- > /dev/null" for finding files added. Search for "+++ /dev/null" for files > deleted. > One can also get list of added files using : git dif > --summary | grep create . Example git diff apache-lens-2.5.0-beta --summary | > grep create -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1328) RAT Check for new files
[ https://issues.apache.org/jira/browse/LENS-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1328: --- Description: Check if any new files are added which are without Apache license. Decide whether to add such files a part of rat check exclusion list in POM.xml or not. Steps: - 'git tag' can give you all tags, pick last release tag name - git diff . In the less view, search for "\-\-\- /dev/null" for finding files added. Search for "+++ /dev/null" for files deleted. One can also get list of added files using : git dif --summary | grep creat . Example git diff apache-lens-2.5.0-beta --summary | grep create > RAT Check for new files > --- > > Key: LENS-1328 > URL: https://issues.apache.org/jira/browse/LENS-1328 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > > Check if any new files are added which are without Apache license. Decide > whether to add such files a part of rat check exclusion list in POM.xml or > not. > Steps: > - 'git tag' can give you all tags, pick last release tag name > - git diff . In the less view, search for "\-\-\- > /dev/null" for finding files added. Search for "+++ /dev/null" for files > deleted. > One can also get list of added files using : git dif > --summary | grep creat . Example git diff apache-lens-2.5.0-beta --summary | > grep create -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1314) Update 2.6 release documentation
[ https://issues.apache.org/jira/browse/LENS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1314: --- Attachment: lens-1314.patch > Update 2.6 release documentation > > > Key: LENS-1314 > URL: https://issues.apache.org/jira/browse/LENS-1314 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Attachments: lens-1314.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1314) Update 2.6 release documentation
[ https://issues.apache.org/jira/browse/LENS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1314: --- Attachment: (was: lens-1314.patch) > Update 2.6 release documentation > > > Key: LENS-1314 > URL: https://issues.apache.org/jira/browse/LENS-1314 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1314) Update 2.6 release documentation
[ https://issues.apache.org/jira/browse/LENS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1314: --- Status: Open (was: Patch Available) Indentation issue. Will fix and re-submit > Update 2.6 release documentation > > > Key: LENS-1314 > URL: https://issues.apache.org/jira/browse/LENS-1314 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1314) Update 2.6 release documentation
[ https://issues.apache.org/jira/browse/LENS-1314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1314: --- Status: Patch Available (was: Open) > Update 2.6 release documentation > > > Key: LENS-1314 > URL: https://issues.apache.org/jira/browse/LENS-1314 > Project: Apache Lens > Issue Type: Sub-task > Components: build > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Attachments: lens-1314.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1328) RAT Check for new files
Puneet Gupta created LENS-1328: -- Summary: RAT Check for new files Key: LENS-1328 URL: https://issues.apache.org/jira/browse/LENS-1328 Project: Apache Lens Issue Type: Sub-task Reporter: Puneet Gupta Assignee: Puneet Gupta -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1326) session/sessions API returning no data on GUI/api though there are active sessions
[
https://issues.apache.org/jira/browse/LENS-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502689#comment-15502689
]
Puneet Gupta commented on LENS-1326:
*Response code in 410*
19808 293810 > GET http://xxx:80/lensapi/session/sessions
19809 293810 > accept:
text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8
19810 293810 > accept-encoding: gzip, deflate, sdch
19811 293810 > accept-language: en-US,en;q=0.8
19812 293810 > connection: keep-alive
*19819 293810 < 410*
> session/sessions API returning no data on GUI/api though there are active
> sessions
> --
>
> Key: LENS-1326
> URL: https://issues.apache.org/jira/browse/LENS-1326
> Project: Apache Lens
> Issue Type: Bug
>Reporter: Puneet Gupta
>Assignee: Lavkesh Lahngir
>
> The lens GUI and API is showing no sessions via sessions REST end point.
> Server metrics are showing active sessions though.
> {noformat}
> "org.apache.lens.server.api.session.SessionService.active-sessions" : {
> "value" : 5324
>},
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (LENS-1326) session/sessions API returning no data on GUI/api though there are active sessions
Puneet Gupta created LENS-1326:
--
Summary: session/sessions API returning no data on GUI/api though
there are active sessions
Key: LENS-1326
URL: https://issues.apache.org/jira/browse/LENS-1326
Project: Apache Lens
Issue Type: Bug
Reporter: Puneet Gupta
Assignee: Lavkesh Lahngir
The lens GUI and API is showing no sessions via sessions REST end point.
Server metrics are showing active sessions though.
{noformat}
"org.apache.lens.server.api.session.SessionService.active-sessions" : {
"value" : 5324
},
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (LENS-1308) User config loader database calls not inserting entries
[
https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498498#comment-15498498
]
Puneet Gupta edited comment on LENS-1308 at 9/17/16 7:55 AM:
-
Lets keep auto commit false by default and have explicit commit (like we are
doing in org.apache.lens.server.query.LensServerDAO#insertFinishedQuery). Or
else we need to follow a different model where we can keep autocommit true by
default and turn it off wherever we need transactions (may be very few places).
{noformat}
boolean autoCommit = conn.getAutoCommit();
conn.setAutoCommit(false);
try
{
…some logic...
insert one row ..
insert another row..
conn.commit();
} catch(Exception e) {
Log .
}
finally {
conn.setAutoCommit(autoCommit) ; // since this is a pooled connection , lets
set it back to original state
}
{noformat}
between 1st and 2nd row if there is an error we should not commit
Note sure if below are working in current state without any explicit commits.
1. org.apache.lens.server.query.LensServerDAO#createFinishedQueriesTable and
2. org.apache.lens.server.query.LensServerDAO#dropFinishedQueriesTable
was (Author: puneet884):
Lets keep auto commit false by default and have explicit commit (like we are
doing in org.apache.lens.server.query.LensServerDAO#insertFinishedQuery). Or
else we need to follow a different model where we can keep autocommit true by
default and turn it off wherever we need transactions (may be very few places).
{noformat}
boolean autoCommit = conn.getAutoCommit();
conn.setAutoCommit(false);
try
{
…some logic...
insert one row ..
insert another row..
conn.commit();
} Exception {
Log .
}
finally {
conn.setAutoCommit(autoCommit) ; // since this is a pooled connection , lets
set it back to original state
}
{noformat}
between 1st and 2nd row if there is an error we should not commit
Note sure if below are working in current state without any explicit commits.
1. org.apache.lens.server.query.LensServerDAO#createFinishedQueriesTable and
2. org.apache.lens.server.query.LensServerDAO#dropFinishedQueriesTable
> User config loader database calls not inserting entries
> ---
>
> Key: LENS-1308
> URL: https://issues.apache.org/jira/browse/LENS-1308
> Project: Apache Lens
> Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1308.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (LENS-1308) User config loader database calls not inserting entries
[
https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498498#comment-15498498
]
Puneet Gupta edited comment on LENS-1308 at 9/17/16 7:51 AM:
-
Lets keep auto commit false by default and have explicit commit (like we are
doing in org.apache.lens.server.query.LensServerDAO#insertFinishedQuery). Or
else we need to follow a different model where we can keep autocommit true by
default and turn it off wherever we need transactions (may be very few places).
{noformat}
conn.setAutoCommit(false)
try
{
…some logic...
insert one row ..
insert another row..
conn.commit()
} Exception { }
{noformat}
between 1st and 2nd row if there is an error we should not commit
Note sure if below are working in current state without any explicit commits.
1. org.apache.lens.server.query.LensServerDAO#createFinishedQueriesTable and
2. org.apache.lens.server.query.LensServerDAO#dropFinishedQueriesTable
was (Author: puneet884):
Lets keep auto commit false by default and have explicit commit (like we are
doing in org.apache.lens.server.query.LensServerDAO#insertFinishedQuery). Or
else we need to follow a different model where we can keep autocommit true by
default and turn it off wherever we need transactions (may be very few places).
{noformat}
conn.setAutoCommit(false)
try
{
…some logic...
insert one row ..
insert another row..
conn.setAutoCommit(true)
} Exception { }
{noformat}
between 1st and 2nd row if there is an error we should not commit
Note sure if below are working in current state without any explicit commits.
1. org.apache.lens.server.query.LensServerDAO#createFinishedQueriesTable and
2. org.apache.lens.server.query.LensServerDAO#dropFinishedQueriesTable
> User config loader database calls not inserting entries
> ---
>
> Key: LENS-1308
> URL: https://issues.apache.org/jira/browse/LENS-1308
> Project: Apache Lens
> Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1308.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LENS-1308) User config loader database calls not inserting entries
[
https://issues.apache.org/jira/browse/LENS-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498498#comment-15498498
]
Puneet Gupta commented on LENS-1308:
Lets keep auto commit false by default and have explicit commit (like we are
doing in org.apache.lens.server.query.LensServerDAO#insertFinishedQuery). Or
else we need to follow a different model where we can keep autocommit true by
default and turn it off wherever we need transactions (may be very few places).
{noformat}
conn.setAutoCommit(false)
try
{
…some logic...
insert one row ..
insert another row..
conn.setAutoCommit(true)
} Exception { }
{noformat}
between 1st and 2nd row if there is an error we should not commit
Note sure if below are working in current state without any explicit commits.
1. org.apache.lens.server.query.LensServerDAO#createFinishedQueriesTable and
2. org.apache.lens.server.query.LensServerDAO#dropFinishedQueriesTable
> User config loader database calls not inserting entries
> ---
>
> Key: LENS-1308
> URL: https://issues.apache.org/jira/browse/LENS-1308
> Project: Apache Lens
> Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
> Fix For: 2.7
>
> Attachments: LENS-1308.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498452#comment-15498452 ] Puneet Gupta commented on LENS-1321: Re-triggering the build . [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.15:test (default-test) on project lens-cube: There was a timeout or other error in the fork -> [Help 1] > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Components: build, ml, regression >Reporter: Puneet Gupta > Assignee: Puneet Gupta > Fix For: 2.6 > > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Component/s: ml build > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Components: build, ml, regression > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.6 > > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Component/s: regression > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Components: build, ml, regression > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.6 > > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Status: Patch Available (was: Open) > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta > Assignee: Puneet Gupta > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Attachment: lens-1321.patch Simple patch . Attaching directly. Was able to run rat check after the changes. 1. Adding license message in properties file 2. removing .properties files from exclude in rat-check > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta > Assignee: Puneet Gupta > Fix For: 2.6 > > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Fix Version/s: 2.6 > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta > Assignee: Puneet Gupta > Fix For: 2.6 > > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1325) Support encoded urls for query HTTP notifications
[ https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1325: --- Fix Version/s: 2.7 > Support encoded urls for query HTTP notifications > - > > Key: LENS-1325 > URL: https://issues.apache.org/jira/browse/LENS-1325 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.7 > > > This notification url is working : > http://x:8000/v1/data/?access_token=ABC123 > This is giving 400 bad request : > http://:8000/v1/data/?access_token=ABC123=xyz > Please check. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1325) Support encoded urls for query HTTP notifications
[ https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1325: --- Component/s: server > Support encoded urls for query HTTP notifications > - > > Key: LENS-1325 > URL: https://issues.apache.org/jira/browse/LENS-1325 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.7 > > > This notification url is working : > http://x:8000/v1/data/?access_token=ABC123 > This is giving 400 bad request : > http://:8000/v1/data/?access_token=ABC123=xyz > Please check. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1324) Support more hooks in DriverQueryHook
[ https://issues.apache.org/jira/browse/LENS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1324: --- Component/s: server > Support more hooks in DriverQueryHook > - > > Key: LENS-1324 > URL: https://issues.apache.org/jira/browse/LENS-1324 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.7 > > > Currently we have two hooks > 1. preLaunch > 2. postDriverSelection > Need to add some hooks that can hook into rewrite and estimate flow also. > 1.preRewrite, postRewrite > 2.preEstimate,postEstimate > NoOpDriverQueryHook will have default empty implementation for these new > methods . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1324) Support more hooks in DriverQueryHook
[ https://issues.apache.org/jira/browse/LENS-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1324: --- Fix Version/s: 2.7 > Support more hooks in DriverQueryHook > - > > Key: LENS-1324 > URL: https://issues.apache.org/jira/browse/LENS-1324 > Project: Apache Lens > Issue Type: Improvement > Components: server > Reporter: Puneet Gupta >Assignee: Puneet Gupta > Fix For: 2.7 > > > Currently we have two hooks > 1. preLaunch > 2. postDriverSelection > Need to add some hooks that can hook into rewrite and estimate flow also. > 1.preRewrite, postRewrite > 2.preEstimate,postEstimate > NoOpDriverQueryHook will have default empty implementation for these new > methods . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1324) Support more hooks in DriverQueryHook
Puneet Gupta created LENS-1324: -- Summary: Support more hooks in DriverQueryHook Key: LENS-1324 URL: https://issues.apache.org/jira/browse/LENS-1324 Project: Apache Lens Issue Type: Improvement Reporter: Puneet Gupta Assignee: Puneet Gupta Currently we have two hooks 1. preLaunch 2. postDriverSelection Need to add some hooks that can hook into rewrite and estimate flow also. 1.preRewrite, postRewrite 2.preEstimate,postEstimate NoOpDriverQueryHook will have default empty implementation for these new methods . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1321) Add License message for properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Summary: Add License message for properties files (was: Add License message for two new properties files) > Add License message for properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta > Assignee: Puneet Gupta > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1321) Add License message for two new properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Attachment: (was: lens-1321.patch) > Add License message for two new properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta > Assignee: Puneet Gupta > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (LENS-1321) Add License message for two new properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta updated LENS-1321: --- Attachment: lens-1321.patch > Add License message for two new properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta > Assignee: Puneet Gupta > Attachments: lens-1321.patch > > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (LENS-1321) Add License message for two new properties files
[ https://issues.apache.org/jira/browse/LENS-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Puneet Gupta reassigned LENS-1321: -- Assignee: Puneet Gupta > Add License message for two new properties files > > > Key: LENS-1321 > URL: https://issues.apache.org/jira/browse/LENS-1321 > Project: Apache Lens > Issue Type: Bug > Reporter: Puneet Gupta > Assignee: Puneet Gupta > > IM1995-X0:lens puneet.gupta$ git status > On branch current-release-line > Your branch is up-to-date with 'origin/current-release-line'. > nothing to commit, working directory clean > IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | > grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v > ".xml"|grep -v "control$"|grep -v ".data" > create mode 100644 lens-regression/src/main/resources/queries.properties > create mode 100644 > lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (LENS-1321) Add License message for two new properties files
Puneet Gupta created LENS-1321: -- Summary: Add License message for two new properties files Key: LENS-1321 URL: https://issues.apache.org/jira/browse/LENS-1321 Project: Apache Lens Issue Type: Bug Reporter: Puneet Gupta IM1995-X0:lens puneet.gupta$ git status On branch current-release-line Your branch is up-to-date with 'origin/current-release-line'. nothing to commit, working directory clean IM1995-X0:lens puneet.gupta$ git diff apache-lens-2.5.0-beta --summary | grep create | grep -v ".java" | grep -v ".yaml" | grep -v ".py"|grep -v ".xml"|grep -v "control$"|grep -v ".data" create mode 100644 lens-regression/src/main/resources/queries.properties create mode 100644 lens-regression/src/main/resources/template.lens.properties -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [DISCUSS] Release Plan for 2.6
*Final List * LENS-518 Lens 2.6 is compatible with hive 2.1.0 and above LENS-919 For older deployments the schema for "finished_queries" table needs to be modified to include "priority" LENS-1212 Saved query service is enabled by default now LENS-833 Number of open sessions allowed for each user is capped at 10 by default now LENS-1244 Dropping beta from lens releases. Lens 2.6 will be a GA release LENS-909 Query finish email notification message body will not have query results inline in case of inmemory resultset LENS-1198 Lens 2.6 is compatible with hive 2.1.0 and above LENS-1217 Old lens GUI is removed LENS-1215 Cluster user was defaulted to operating system user by lens-client module earlier. This logic have been moved to cli. Direct users of lens-client will see a change in behavior due to this modification LENS-1187 For metastore REST end point most of the apis returning APIResult were giving http status 200 even in case of failure. The payload object had a FAILED APIResult, but the status code was 200. After this, the status code comes as 500. LENS-1029 Lens server configuration lens.server.snapshot.interval is changed to lens.server.state.persistence.interval.millis, lens.server.restart.enabled is changed to lens.server.state.persistence.enabled and lens.server.recover.onrestart is removed LENS-1013 postDriverSelection method has been added DriverQueryHook SPI. Implementation providers need to adapt to new interface Thanks, Puneet Gupta On Mon, Sep 5, 2016 at 7:25 PM, amareshwarisr . <amareshw...@gmail.com> wrote: > We should not be calling > LENS-959 (is only testcase changes) , LENS-950 (is more a bug fix), > LENS-1191 > ( a new feature), LENS-771 ( is a bug fix) and LENS-1159 (is a bug fix). > > More to be labeled as incompatible changes : > LENS-1217 <https://issues.apache.org/jira/browse/LENS-1217> > > Remove old java ui server <https://issues.apache.org/jira/browse/LENS-1217 > > > > LENS-1212 <https://issues.apache.org/jira/browse/LENS-1212> > > Enable saved queries by default > <https://issues.apache.org/jira/browse/LENS-1212> > > On Wed, Aug 24, 2016 at 6:47 PM, Puneet Gupta <puneet.gu...@inmobi.com> > wrote: > > > Hi, > > > > Following list of issues seem like potential incompatibilities (wrt to > lens > > server upgrade, lens db upgrade ). Will share a more pruned list (after > > more analysis). > > Please feel free to add more issues to this list of *incompatible > > issues*. (Complete > > list is available here > > <https://issues.apache.org/jira/issues/?jql=project%20% > > 3D%20LENS%20AND%20fixVersion%20%3D%202.6%20ORDER%20BY%20status%20DESC> > > ) > > > > Sub-task LENS-988 <https://issues.apache.org/jira/browse/LENS-988> > > LENS-124 > > [Server] StateStore for LensScheduler Lavkesh Lahngir Ajay Yadava Major > > Closed Fixed 3/13/16 18:44 8/18/16 9:15 2.6 server > > Wish LENS-518 <https://issues.apache.org/jira/browse/LENS-518> Move > Hive > > dependency to Apache Hive Rajat Khandelwal Amareshwari Sriramadasu Major > > Closed Fixed 4/22/15 8:37 8/18/16 9:21 2.6 build > > Improvement LENS-919 <https://issues.apache.org/jira/browse/LENS-919> > > Persist > > Query Priority in Lens DB Puneet Gupta Puneet Gupta Minor Closed Fixed > > 1/12/16 > > 9:49 8/18/16 11:42 2.6 server > > New Feature LENS-833 <https://issues.apache.org/jira/browse/LENS-833> > > Limit > > number of open sessions per user on session service Raju Bairishetti > > Amareshwari > > Sriramadasu Major Closed Fixed 10/19/15 10:12 8/18/16 12:39 2.6 server > > Task LENS-959 <https://issues.apache.org/jira/browse/LENS-959> remove > > cube keyword from all test cases of lens-cube Rajat Khandelwal Rajat > > Khandelwal Major Closed Fixed 2/16/16 11:03 8/18/16 14:38 2.6 cube > > Task LENS-1244 <https://issues.apache.org/jira/browse/LENS-1244> Mark > > 2.6.x release as GA and remove beta Puneet Gupta Puneet Gupta Blocker > > Closed > > Fixed 7/31/16 3:02 8/19/16 8:12 2.6 build > > Sub-task LENS-1186 <https://issues.apache.org/jira/browse/LENS-1186> > > LENS-1179 > > Refactor exception handling in QueryServiceResource Rajat Khandelwal > Rajat > > Khandelwal Major Resolved Fixed 6/15/16 8:13 6/22/16 9:13 2.6 > > Improvement LENS-950 <https://issues.apache.org/jira/browse/LENS-950> > > Bridge > > table join should ignore join type config Amareshwari Sriramadasu > > Amareshwari > > Sriramadasu Major Resolved Fixed 2/9/16 10:47 2/15/16 15:16 2.6 > > Improvement LENS-909 <https://issues.apache.org/jira/browse/LENS-909> > We > > shou
[jira] [Commented] (LENS-1190) Support Query End Notifictaion to a HTTP end point.
[
https://issues.apache.org/jira/browse/LENS-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492592#comment-15492592
]
Puneet Gupta commented on LENS-1190:
Used lens server itself as a end point.
lens-shell>set lens.query.http.notification.type.FINISHED=true
Set param succeeded
lens-shell>set
lens.query.http.notification.urls=http://192.168.138.184:/lensapi/
Set param succeeded
lens-shell>cube select id,name from sample_db_dim --async
{noformat}
57 > content-type:
multipart/form-data;boundary=Boundary_1_1827494839_1472030457696
57 > host: 192.168.138.184:
57 > mime-version: 1.0
57 > user-agent: Jersey/2.22.1 (HttpUrlConnection 1.8.0_40)
--Boundary_1_1827494839_1472030457696
Content-Type: application/json
Content-Disposition: form-data; name="query"
{
"lensQuery" : {
"queryHandle" : {
"handleId" : "40f404e8-ea4d-4335-a683-8c95c123dfc7"
},
"userQuery" : "cube select id,name from sample_db_dim",
"submittedUser" : "anonymous",
"priority" : "NORMAL",
"isPersistent" : true,
"selectedDriverName" : "jdbc/jdbc1",
"driverQuery" : "SELECT (sample_db_dim.id), (sample_db_dim.name) FROM
exp_yoda.mydb_dim_table3 sample_db_dim",
"status" : {
"progress" : 1.0,
"status" : "SUCCESSFUL",
"statusMessage" : "Query is successful!",
"isResultSetAvailable" : true
},
"resultSetPath" :
"hdfs://192.168.138.184:8020/tmp/lensreports/40f404e8-ea4d-4335-a683-8c95c123dfc7.zip",
"queryConf" : {
},
"submissionTime" : 1472030435326,
"launchTime" : 1472030435679,
"driverStartTime" : 1472030435679,
"driverFinishTime" : 1472030435720,
"finishTime" : 1472030457590,
"closedTime" : 0,
"queryName" : ""
}
}
--Boundary_1_1827494839_1472030457696
Content-Type: text/plain
Content-Disposition: form-data; name="eventtype"
FINISHED
--Boundary_1_1827494839_1472030457696
Content-Type: text/plain
Content-Disposition: form-data; name="eventtime"
1472030457590
--Boundary_1_1827494839_1472030457696--
{noformat}
> Support Query End Notifictaion to a HTTP end point.
> ---
>
> Key: LENS-1190
> URL: https://issues.apache.org/jira/browse/LENS-1190
> Project: Apache Lens
> Issue Type: New Feature
> Components: server
>Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1190.patch
>
>
> As of now query end notification is supported via email.
> On similar lines we can also notify a HTTP end point and the app submitting
> queries on Lens Server can take appropriate action when such a end
> notification is received by it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (LENS-1317) Lens Query Conf to be persisted in Finished_Queries store
[ https://issues.apache.org/jira/browse/LENS-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492100#comment-15492100 ] Puneet Gupta commented on LENS-1317: The failures do seem unrelated to your fix. Giving it one more try https://builds.apache.org/job/PreCommit-Lens-Build/906/ > Lens Query Conf to be persisted in Finished_Queries store > - > > Key: LENS-1317 > URL: https://issues.apache.org/jira/browse/LENS-1317 > Project: Apache Lens > Issue Type: Improvement >Reporter: Srikanth Sundarrajan >Assignee: Srikanth Sundarrajan > Labels: incompatible > Fix For: 2.7 > > Attachments: LENS-1317.patch > > > Lens Conf passed while submitting a query isn't currently persisted in the > finished_queries state store. Conf is available as long as query is in > running or queued state and once the query completes and the same is evicted > from memory, conf (fetched from DB) is no longer available. It would be > useful to record the configurations that a user had used while submitting a > query. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51756/#review149013 --- Ship it! Ship It! - Puneet Gupta On Sept. 14, 2016, 2:55 p.m., Srikanth Sundarrajan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51756/ > --- > > (Updated Sept. 14, 2016, 2:55 p.m.) > > > Review request for lens. > > > Bugs: LENS-1319 > https://issues.apache.org/jira/browse/LENS-1319 > > > Repository: lens > > > Description > --- > > LENS-1319 Lens Client doesn't provide the option to pass query conf while > submitting the query > > > Diffs > - > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 4346c86 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > e1b19de > lens-client/src/main/java/org/apache/lens/client/LensClient.java 9a76118 > lens-client/src/main/java/org/apache/lens/client/LensStatement.java 64c24c7 > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcStatement.java > fb265e5 > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 94a788a > lens-examples/src/main/java/org/apache/lens/examples/SampleQueries.java > e88ed28 > > Diff: https://reviews.apache.org/r/51756/diff/ > > > Testing > --- > > Relevant unit tests added. > > > Thanks, > > Srikanth Sundarrajan > >
Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query
> On Sept. 13, 2016, 1:06 p.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/LensClient.java, line 120 > > <https://reviews.apache.org/r/51756/diff/1/?file=1494959#file1494959line120> > > > > Just had one thought. Is there a way to keep the number of public > > methods to a minimum in LensClient and LensStatement. The motivation for > > this would be have lesser number of execute methods to choose from for end > > user who sometimes seem to struggle which method to use. I Dont see a > > direct way of doing that unless we sacrifice backward compatibility. > > Srikanth Sundarrajan wrote: > While I understand the concern, it would be much needed to expose the > ability to pass the conf, given that the server supports the client to pass > conf. Removing the older method without conf, would be backward incompatible, > I suggest that we annotate the older methods as @Derprecated and remove them > in a subsequent release. > > Srikanth Sundarrajan wrote: > Hi Puneet, If the suggested fix is acceptable, can post a revised patch. > Thanks +1 - Puneet --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51756/#review148713 --- On Sept. 9, 2016, 11:09 a.m., Srikanth Sundarrajan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51756/ > --- > > (Updated Sept. 9, 2016, 11:09 a.m.) > > > Review request for lens. > > > Bugs: LENS-1319 > https://issues.apache.org/jira/browse/LENS-1319 > > > Repository: lens > > > Description > --- > > LENS-1319 Lens Client doesn't provide the option to pass query conf while > submitting the query > > > Diffs > - > > lens-client/src/main/java/org/apache/lens/client/LensClient.java 9a76118 > lens-client/src/main/java/org/apache/lens/client/LensStatement.java 64c24c7 > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 94a788a > > Diff: https://reviews.apache.org/r/51756/diff/ > > > Testing > --- > > Relevant unit tests added. > > > Thanks, > > Srikanth Sundarrajan > >
[jira] [Commented] (LENS-1307) execute_with_timout not timing out after timeout time
[
https://issues.apache.org/jira/browse/LENS-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489478#comment-15489478
]
Puneet Gupta commented on LENS-1307:
Committed myself.
> execute_with_timout not timing out after timeout time
> -
>
> Key: LENS-1307
> URL: https://issues.apache.org/jira/browse/LENS-1307
> Project: Apache Lens
> Issue Type: Bug
> Reporter: Puneet Gupta
> Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1307-v1.patch
>
>
> 3+ minutes (13:31:10 to 13:34:14) 5a32066c-9834-421b-bce9-60f2a8766f26
> {noformat}
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:31:10 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server has received a request on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 > POST
> http://x:8080/lensapi/queryapi/queries
> lensserver-requests.log.2016-08-28.2-91768 > accept: application/json
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:34:14 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server responded with a response on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 < 200
> lensserver-requests.log.2016-08-28.2-91768 < Content-Type: application/json
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (LENS-1307) execute_with_timout not timing out after timeout time
[
https://issues.apache.org/jira/browse/LENS-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Puneet Gupta updated LENS-1307:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> execute_with_timout not timing out after timeout time
> -
>
> Key: LENS-1307
> URL: https://issues.apache.org/jira/browse/LENS-1307
> Project: Apache Lens
> Issue Type: Bug
> Reporter: Puneet Gupta
> Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1307-v1.patch
>
>
> 3+ minutes (13:31:10 to 13:34:14) 5a32066c-9834-421b-bce9-60f2a8766f26
> {noformat}
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:31:10 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server has received a request on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 > POST
> http://x:8080/lensapi/queryapi/queries
> lensserver-requests.log.2016-08-28.2-91768 > accept: application/json
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:34:14 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server responded with a response on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 < 200
> lensserver-requests.log.2016-08-28.2-91768 < Content-Type: application/json
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (LENS-1307) execute_with_timout not timing out after timeout time
[
https://issues.apache.org/jira/browse/LENS-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Puneet Gupta updated LENS-1307:
---
Fix Version/s: 2.7
Status: Patch Available (was: Open)
> execute_with_timout not timing out after timeout time
> -
>
> Key: LENS-1307
> URL: https://issues.apache.org/jira/browse/LENS-1307
> Project: Apache Lens
> Issue Type: Bug
> Reporter: Puneet Gupta
> Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1307-v1.patch
>
>
> 3+ minutes (13:31:10 to 13:34:14) 5a32066c-9834-421b-bce9-60f2a8766f26
> {noformat}
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:31:10 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server has received a request on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 > POST
> http://x:8080/lensapi/queryapi/queries
> lensserver-requests.log.2016-08-28.2-91768 > accept: application/json
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:34:14 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server responded with a response on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 < 200
> lensserver-requests.log.2016-08-28.2-91768 < Content-Type: application/json
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (LENS-1307) execute_with_timout not timing out after timeout time
[
https://issues.apache.org/jira/browse/LENS-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Puneet Gupta updated LENS-1307:
---
Attachment: lens-1307-v1.patch
> execute_with_timout not timing out after timeout time
> -
>
> Key: LENS-1307
> URL: https://issues.apache.org/jira/browse/LENS-1307
> Project: Apache Lens
> Issue Type: Bug
> Reporter: Puneet Gupta
> Assignee: Puneet Gupta
> Attachments: lens-1307-v1.patch
>
>
> 3+ minutes (13:31:10 to 13:34:14) 5a32066c-9834-421b-bce9-60f2a8766f26
> {noformat}
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:31:10 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server has received a request on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 > POST
> http://x:8080/lensapi/queryapi/queries
> lensserver-requests.log.2016-08-28.2-91768 > accept: application/json
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:34:14 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server responded with a response on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 < 200
> lensserver-requests.log.2016-08-28.2-91768 < Content-Type: application/json
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Review Request 51756: LENS-1319 Lens Client doesn't provide the option to pass query conf while submitting the query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51756/#review148713 --- lens-client/src/main/java/org/apache/lens/client/LensClient.java (line 120) <https://reviews.apache.org/r/51756/#comment216215> Just had one thought. Is there a way to keep the number of public methods to a minimum in LensClient and LensStatement. The motivation for this would be have lesser number of execute methods to choose from for end user who sometimes seem to struggle which method to use. I Dont see a direct way of doing that unless we sacrifice backward compatibility. - Puneet Gupta On Sept. 9, 2016, 11:09 a.m., Srikanth Sundarrajan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51756/ > --- > > (Updated Sept. 9, 2016, 11:09 a.m.) > > > Review request for lens. > > > Bugs: LENS-1319 > https://issues.apache.org/jira/browse/LENS-1319 > > > Repository: lens > > > Description > --- > > LENS-1319 Lens Client doesn't provide the option to pass query conf while > submitting the query > > > Diffs > - > > lens-client/src/main/java/org/apache/lens/client/LensClient.java 9a76118 > lens-client/src/main/java/org/apache/lens/client/LensStatement.java 64c24c7 > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 94a788a > > Diff: https://reviews.apache.org/r/51756/diff/ > > > Testing > --- > > Relevant unit tests added. > > > Thanks, > > Srikanth Sundarrajan > >
Re: Review Request 51836: LENS 1307 execute_with_timout not timing out after timeout time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51836/ --- (Updated Sept. 13, 2016, 9:13 a.m.) Review request for lens. Changes --- Addressed review comment Bugs: LENS-1307 https://issues.apache.org/jira/browse/LENS-1307 Repository: lens Description --- Chnaged the wait logic for timeout (wrt to driver completion listener). For hive queries this was taking a lot of time in some cases and the timeout cutoff was missed. Diffs (updated) - lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java a9aa497 Diff: https://reviews.apache.org/r/51836/diff/ Testing --- [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .. SUCCESS [ 10.654 s] [INFO] Lens ... SUCCESS [ 8.416 s] [INFO] Lens API ... SUCCESS [ 19.450 s] [INFO] Lens API for server and extensions . SUCCESS [ 59.253 s] [INFO] Lens Cube .. SUCCESS [ 44.856 s] [INFO] Lens DB storage SUCCESS [ 5.112 s] [INFO] Lens Query Library . SUCCESS [ 12.425 s] [INFO] Lens Hive Driver ... SUCCESS [ 19.061 s] [INFO] Lens Driver for JDBC ... SUCCESS [ 15.814 s] [INFO] Lens Elastic Search Driver . SUCCESS [ 7.666 s] [INFO] Lens Server SUCCESS [02:09 min] [INFO] Lens client SUCCESS [ 14.564 s] [INFO] Lens CLI ... SUCCESS [ 23.772 s] [INFO] Lens Examples .. SUCCESS [ 15.164 s] [INFO] Lens Ship Jars to Distributed Cache SUCCESS [ 6.027 s] [INFO] Lens Distribution .. SUCCESS [ 49.010 s] [INFO] Lens ML Lib SUCCESS [ 25.069 s] [INFO] Lens ML Ext Distribution ... SUCCESS [ 24.512 s] [INFO] Lens Regression SUCCESS [ 18.814 s] [INFO] Lens UI SUCCESS [ 17.385 s] [INFO] [INFO] BUILD SUCCESS [INFO] Thanks, Puneet Gupta
[jira] [Commented] (LENS-1307) execute_with_timout not timing out after timeout time
[
https://issues.apache.org/jira/browse/LENS-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486490#comment-15486490
]
Puneet Gupta commented on LENS-1307:
https://reviews.apache.org/r/51836/
> execute_with_timout not timing out after timeout time
> -
>
> Key: LENS-1307
> URL: https://issues.apache.org/jira/browse/LENS-1307
> Project: Apache Lens
> Issue Type: Bug
> Reporter: Puneet Gupta
> Assignee: Puneet Gupta
>
> 3+ minutes (13:31:10 to 13:34:14) 5a32066c-9834-421b-bce9-60f2a8766f26
> {noformat}
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:31:10 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server has received a request on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 > POST
> http://x:8080/lensapi/queryapi/queries
> lensserver-requests.log.2016-08-28.2-91768 > accept: application/json
> lensserver-requests.log.2016-08-28.2-28 Aug 2016 13:34:14 []
> [grizzly-http-server-11] INFO org.apache.lens.server.LensServer.request -
> 91768 * Server responded with a response on thread grizzly-http-server-11
> lensserver-requests.log.2016-08-28.2:91768 < 200
> lensserver-requests.log.2016-08-28.2-91768 < Content-Type: application/json
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
