[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907651#comment-16907651
]
Nicholas Knize commented on LUCENE-8369:
Sounds good to me. Thanks [~mikemccand] and [~simonw]
[~dsmiley] I think we're good to go on this patch then to remove the spatial
module? I'll handle refactoring {{LatLonShape}} and {{XYShape}} classes to
{{core}} in a separate issue.
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906502#comment-16906502 ] Simon Willnauer commented on LUCENE-8369: - +1 for option 1 above as well. Thanks [~nknize] > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905566#comment-16905566 ] Michael McCandless commented on LUCENE-8369: +1 for option 1 above. > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903204#comment-16903204
]
Nicholas Knize commented on LUCENE-8369:
As a side note: the two classes in the spatial module are no longer used and
can be removed; leaving the spatial module empty.
So it sounds like we're converging on three options then:
1. Move {{LatLonShape}}, {{XYShape}}, queries and supporting classes to core;
delete spatial module
2. Move {{LatLonShape}}, {{XYShape}}, queries and supporting classes to spatial
module; make dependency classes in core public and label w/ _@lucene.internal_
3. Move {{LatLonShape}}, {{XYShape}}, queries and supporting classes to spatial
module for Lucene 9 release; leave core dependency class visibility alone and
use [java modules|https://www.jcp.org/en/jsr/detail?id=376] to expose package
private classes to the spatial module?
I introduce the third option here because a. I think it might strike a nice
balance between separating "esoteric" shape features (whatever that means) to
the spatial module while maintaining proper API visibility, and b. with the
move to Java 11 we can introduce the Java Platform Module system to achieve
proper visibility.
I'll admit I'm no expert when it comes to the Java Module System but I seem to
recall a conversation around this topic a few years back when Java 9 was
released?
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902133#comment-16902133 ] Simon Willnauer commented on LUCENE-8369: - I don't think we should scarify the existence of LatLong point searching out of core for the sake of code visibility. I think we should keep it in core and open up visibility to enable code-reuse in the modules and use _@lucene.internal_ in order to mark classes as internal and prevent users from complaining when the API changes. It's not ideal but progress. Can we separate the disucssion of getting rid of the spacial module from graduating the various shapes from sandbox to wherever? I think keeping a module for 2 classes doesn't make sense. We can move those two classes to core too or even get rid of them altogether I don't think it should influence the discussion if something else should be graduated. One other option would be we move all non-core spacials from sandbox to spatial as long as they don't add any additional dependency. that would be an intermediate step. we can still graduate from there then. > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896516#comment-16896516
]
Nicholas Knize commented on LUCENE-8369:
[~dsmiley] yeah, that seems to be the case more often than not. So under that
construct we would move {{LatLonPointInPolygonQuery}} to the spatial module
which even further fragments everything.
Seems this discussion gains some activity for a short bit, stalls for a year or
two, gains some more activity, then stalls again. I know it's no fun to engage
in the bikeshed activity, but it would be nice to figure out a path forward;
even if that means find a solution for the 9.0 release and just leave
{{LatLonShape}} and {{XYShape}} in sandbox for the rest of the 8.x releases.
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893833#comment-16893833 ] David Smiley commented on LUCENE-8369: -- IMO to most users anything beyond points, rectangles, and point-radius, is exotic/specialized. Many search apps don't even have any spatial at all for that matter. > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893752#comment-16893752 ] Ignacio Vera commented on LUCENE-8369: -- My best example is LUCENE-8746: I am trying to refactor the classes that contain the spatial logic and having them in different packages make it very difficult. In addition, how to asses what is common and what is exotic? Maybe pointInBox (which is a range anyway) is the most common case but pointInPolygon might start moving into the exotic area. > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893211#comment-16893211
]
Nicholas Knize commented on LUCENE-8369:
{quote}Can we simply make the necessary APIs public and marked
{{@lucene.internal}} in our core spatial classes?
{quote}
I think that's what we were trying to avoid because it largely feels like a cop
out to making a foundation class package private vice keeping it exposed. One
example is {{EdgeTree}} this can (and probably should) stay package private to
{{org.apache.lucene.geo}}. But it's used for {{XYShape}}, {{LatLonShape}}, and
{{LatLonPoint}}. So if we fragment those classes between the {{core}} and
{{spatial}} module we are forcing ourselves to keep it public and mark it
{{@lucene.internal}}. Which, again, feels like a cop out to doing (in my
opinion) the "right" thing and making it package private.
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893187#comment-16893187
]
Michael McCandless commented on LUCENE-8369:
{quote}Lots of awesome functionality _commonly_ needed in search is in our
modules – like highlighting, autocomplete, and spellcheck, to name a few. Why
should spatial be an exception?
{quote}
Well, other examples are default analysis ({{StandardAnalyzer}}), common
queries (versus exotic queries in the queries module), most {{Directory}}
implementations, where we have some common choices in core and more exotic
choices in our modules.
I think it (the "common" classes and the "exotic" ones) is a helpful
distinction for our users for areas that have many many options.
[~nknize] can you give a concrete example where the code sharing is making
things difficult? Can we simply make the necessary APIs public and marked
{{@lucene.internal}} in our core spatial classes?
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892820#comment-16892820
]
Nicholas Knize commented on LUCENE-8369:
{quote}Such core use cases should work easily for users without wading thru
extra jars, third party dependencies, crazy licensing, or crazy class
hierarchies.
{quote}
I agree. That's why the `spatial` module should remain dependency free and
apache licensed.
{quote}I don't think adding esoteric functionality (like non-WGS shapes)
{quote}
Except esoteric is in the eye of the beholder so claiming someone will
understand or prefer latitude longitude search any more than basic x, y is
assumptive.
{quote}My fear of having LatLonPoint in a different package to other spatial
fields is code sharing
{quote}
I agree. When we only had LatLonPoint I leaned toward it moving to the spatial
module because of how we could advance the foundation. But since we weren't
there yet, I could understand the argument for having "...basic functionality
in core that solves the 90% geo use case". Now we've added geo shapes and a
cartesian coordinate system and it's quickly becoming a fragmentation issue
impeding development. IMHO it's clearer and cleaner for the dependency free
spatial code to all exist together in the same module called {{spatial}}. Is
there any technical downside or argument against removing it from core? Or is
it all a matter of opinion?
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892785#comment-16892785 ] Ignacio Vera commented on LUCENE-8369: -- My fear of having LatLonPoint in a different package to other spatial fields is code sharing. Most of the code used by LatLotPoint is reused when dealing with more complex shapes and having them in different packages hurts the API (Objects that should be package protected become public because the need of reuse them). This has been already the case working in the sandbox. > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892745#comment-16892745 ] David Smiley commented on LUCENE-8369: -- Lots of awesome functionality _commonly_ needed in search is in our modules -- like highlighting, autocomplete, and spellcheck, to name a few. Why should spatial be an exception? > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892735#comment-16892735 ] Robert Muir commented on LUCENE-8369: - I don't think adding esoteric functionality (like non-WGS shapes) makes any kind of argument to pull basic lat/lon point searching out of core. We could add 10x more such esoteric functionality and it doesn't change a thing. Such core use cases should work easily for users without wading thru extra jars, third party dependencies, crazy licensing, or crazy class hierarchies. > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892413#comment-16892413
]
Lucene/Solr QA commented on LUCENE-8369:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} LUCENE-8369 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/lucene-java/HowToContribute#Contributing_your_work for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8369 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12929126/LUCENE-8369.patch |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/198/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892091#comment-16892091
]
Nicholas Knize commented on LUCENE-8369:
Since the merge of XYShape I wanted to quickly resurrect this conversation.
Given so much of the {{LatLonShape}} foundation is shared between
{{LatLonPoint}} and {{XYShape}} and we have a {{spatial}} module that is
basically empty. I tend to agree with [~dsmiley]'s original proposal to
refactor {{LatLonPoint}}, {{LatLonShape}}, {{XYShape}}, and all query, support,
and util classes currently spread between {{core}} and {{sandbox}} to the
{{spatial}} module.
We can keep the {{spatial}} module dependency free, and still use
{{spatial-extras}} to build on the foundation classes with third-party
dependencies. I think the only major ramification is that {{Geo3d}} will have
to be updated to depend on the spatial module. But I don't see that as a major
blocker.
Comments, thoughts, objections? /cc [~mikemccand] [~jpountz] [~rcmuir]
[~ivera]
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770409#comment-16770409
]
Lucene/Solr QA commented on LUCENE-8369:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
3s{color} | {color:red} spatial in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 3s{color}
| {color:red} spatial in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 24s{color}
| {color:red} lucene_spatial-extras generated 4 new + 6 unchanged - 0 fixed =
10 total (was 6) {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}
0m 3s{color} | {color:red} spatial in the patch failed. {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 24s{color} | {color:green} Release audit (RAT) rat-sources
passed {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}
0m 3s{color} | {color:red} spatial in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} |
{color:red} 0m 3s{color} | {color:red} spatial in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 3s{color}
| {color:red} spatial in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
43s{color} | {color:green} spatial-extras in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 3m 11s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8369 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12929126/LUCENE-8369.patch |
| Optional Tests | ratsources validatesourcepatterns compile javac unit
checkforbiddenapis |
| uname | Linux lucene1-us-west 4.4.0-137-generic #163~14.04.1-Ubuntu SMP Mon
Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 8ac34c2 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_191 |
| compile |
https://builds.apache.org/job/PreCommit-LUCENE-Build/165/artifact/out/patch-compile-lucene_spatial.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/165/artifact/out/patch-compile-lucene_spatial.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/165/artifact/out/diff-compile-javac-lucene_spatial-extras.txt
|
| Release audit (RAT) |
https://builds.apache.org/job/PreCommit-LUCENE-Build/165/artifact/out/patch-compile-lucene_spatial.txt
|
| Check forbidden APIs |
https://builds.apache.org/job/PreCommit-LUCENE-Build/165/artifact/out/patch-compile-lucene_spatial.txt
|
| Validate source patterns |
https://builds.apache.org/job/PreCommit-LUCENE-Build/165/artifact/out/patch-compile-lucene_spatial.txt
|
| unit |
https://builds.apache.org/job/PreCommit-LUCENE-Build/165/artifact/out/patch-unit-lucene_spatial.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/165/testReport/ |
| modules | C: lucene lucene/spatial lucene/spatial-extras U: lucene |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/165/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558426#comment-16558426 ] David Smiley commented on LUCENE-8369: -- Thanks for your support [~aw]! > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556940#comment-16556940 ] Allen Wittenauer commented on LUCENE-8369: -- Hi everyone. I was brought here by YETUS-645. Since there were questions about what went wrong, I re-triggered the test run to see why it was blowing up since the log files had rolled off. First, the good news: The patch applied fine. Yetus definitely supports 0-level patches such as generated by IntelliJ; special handling is there to try to determine what the appropriate patch level should be. If Yetus couldn't apply the patch, it would have reported the fact explicitly. That's clearly not the case here. Now, the bad news: As [~steve_rowe] speculated, Yetus definitely stumbles a bit when modules are moved or deleted in a patch. It has been a known issue for a while (YETUS-14 !). I think it's been a low priority to fix since it doesn't happen that often in a lot of code bases. If you folks need to make sure that works, let me know and I'll try to prioritize fixing it. But the badder news: the patch appears to have introduced 4 new javac warnings in lucene_spatial-extras. Don't let them get lost in that sea of red. ;) > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556912#comment-16556912
]
Lucene/Solr QA commented on LUCENE-8369:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
2s{color} | {color:red} spatial in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 2s{color}
| {color:red} spatial in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 46s{color}
| {color:red} lucene_spatial-extras generated 4 new + 6 unchanged - 0 fixed =
10 total (was 6) {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}
0m 2s{color} | {color:red} spatial in the patch failed. {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 0m 46s{color} | {color:green} Release audit (RAT) rat-sources
passed {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}
0m 2s{color} | {color:red} spatial in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} |
{color:red} 0m 2s{color} | {color:red} spatial in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 2s{color}
| {color:red} spatial in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
15s{color} | {color:green} spatial-extras in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 4m 25s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8369 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12929126/LUCENE-8369.patch |
| Optional Tests | ratsources validatesourcepatterns compile javac unit
checkforbiddenapis |
| uname | Linux lucene1-us-west 3.13.0-88-generic #135-Ubuntu SMP Wed Jun 8
21:10:42 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 6ab3ff8 |
| ant | version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018 |
| Default Java | 1.8.0_172 |
| compile |
https://builds.apache.org/job/PreCommit-LUCENE-Build/54/artifact/out/patch-compile-lucene_spatial.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/54/artifact/out/patch-compile-lucene_spatial.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/54/artifact/out/diff-compile-javac-lucene_spatial-extras.txt
|
| Release audit (RAT) |
https://builds.apache.org/job/PreCommit-LUCENE-Build/54/artifact/out/patch-compile-lucene_spatial.txt
|
| Check forbidden APIs |
https://builds.apache.org/job/PreCommit-LUCENE-Build/54/artifact/out/patch-compile-lucene_spatial.txt
|
| Validate source patterns |
https://builds.apache.org/job/PreCommit-LUCENE-Build/54/artifact/out/patch-compile-lucene_spatial.txt
|
| unit |
https://builds.apache.org/job/PreCommit-LUCENE-Build/54/artifact/out/patch-unit-lucene_spatial.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/54/testReport/ |
| modules | C: lucene lucene/spatial lucene/spatial-extras U: lucene |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/54/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525475#comment-16525475 ] David Smiley commented on LUCENE-8369: -- Thanks Steve; I need to remember this. Adrien: I get what you're saying but then we have yet another spatial module that we could otherwise get rid of -- and one that confusingly is nearly empty right now. Do we even need the scraps in here right now -- should they stay just because we may want the module name in the future? :-/ CC [~nknize] > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525135#comment-16525135 ] Adrien Grand commented on LUCENE-8369: -- I was hoping that lucene/spatial was where we would put dependency-free shape indexing and search based on the points API. If there is agreement on that, it might be easier to keep it around? > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525114#comment-16525114 ] Steve Rowe commented on LUCENE-8369: bq. RE Yetus: I am not sure but I think it failed because it tried to run tests for an affected module that was actually entirely deleted, which isn't a supported scenario of Yetus. I looked at the patch, and it appears to have been generated by IntelliJ. In my experience native git tooling doesn't interact well with such patches. > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525109#comment-16525109 ] David Smiley commented on LUCENE-8369: -- For some reason Yetus didn't post a comment but it did try: https://builds.apache.org/job/PreCommit-LUCENE-Build/40/ I am not sure but I think it failed because it tried to run tests for an affected module that was actually entirely deleted, which isn't a supported scenario of Yetus. Question: can we just outright remove it from 7x or should it be deprecated? My inclination is simply delete it. If someone wants to upgrade to Lucene 7.5.0, our next 7x release, plus these utilities then they can depend on spatial-7.4.0.jar. > Remove the spatial module as it is obsolete > --- > > Key: LUCENE-8369 > URL: https://issues.apache.org/jira/browse/LUCENE-8369 > Project: Lucene - Core > Issue Type: Task > Components: modules/spatial >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > Attachments: LUCENE-8369.patch > > > The "spatial" module is at this juncture nearly empty with only a couple > utilities that aren't used by anything in the entire codebase -- > GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed > earlier in LUCENE-7664 which was the removal of GeoPointField which was > essentially why the module existed. Better late than never. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete
[
https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524271#comment-16524271
]
Lucene/Solr QA commented on LUCENE-8369:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
3s{color} | {color:red} spatial in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 3s{color}
| {color:red} spatial in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Release audit (RAT) {color} | {color:red}
0m 3s{color} | {color:red} spatial in the patch failed. {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 28s{color} | {color:green} Release audit (RAT) rat-sources
passed {color} |
| {color:red}-1{color} | {color:red} Check forbidden APIs {color} | {color:red}
0m 3s{color} | {color:red} spatial in the patch failed. {color} |
| {color:red}-1{color} | {color:red} Validate source patterns {color} |
{color:red} 0m 3s{color} | {color:red} spatial in the patch failed. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 4s{color}
| {color:red} spatial in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
11s{color} | {color:green} spatial-extras in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 4m 46s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8369 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12929126/LUCENE-8369.patch |
| Optional Tests | ratsources validatesourcepatterns compile javac unit
checkforbiddenapis |
| uname | Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP
Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / 1023b83 |
| ant | version: Apache Ant(TM) version 1.9.6 compiled on July 8 2015 |
| Default Java | 1.8.0_172 |
| compile |
https://builds.apache.org/job/PreCommit-LUCENE-Build/40/artifact/out/patch-compile-lucene_spatial.txt
|
| javac |
https://builds.apache.org/job/PreCommit-LUCENE-Build/40/artifact/out/patch-compile-lucene_spatial.txt
|
| Release audit (RAT) |
https://builds.apache.org/job/PreCommit-LUCENE-Build/40/artifact/out/patch-compile-lucene_spatial.txt
|
| Check forbidden APIs |
https://builds.apache.org/job/PreCommit-LUCENE-Build/40/artifact/out/patch-compile-lucene_spatial.txt
|
| Validate source patterns |
https://builds.apache.org/job/PreCommit-LUCENE-Build/40/artifact/out/patch-compile-lucene_spatial.txt
|
| unit |
https://builds.apache.org/job/PreCommit-LUCENE-Build/40/artifact/out/patch-unit-lucene_spatial.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-LUCENE-Build/40/testReport/ |
| modules | C: lucene lucene/spatial lucene/spatial-extras U: lucene |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/40/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Remove the spatial module as it is obsolete
> ---
>
> Key: LUCENE-8369
> URL: https://issues.apache.org/jira/browse/LUCENE-8369
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/spatial
>Reporter: David Smiley
>Assignee: David Smiley
>Priority: Major
> Attachments: LUCENE-8369.patch
>
>
> The "spatial" module is at this juncture nearly empty with only a couple
> utilities that aren't used by anything in the entire codebase --
> GeoRelationUtils, and MortonEncoder. Perhaps it should have been removed
> earlier in LUCENE-7664 which was the removal of GeoPointField which was
> essentially why the module existed. Better late than never.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
