[GitHub] [plc4x] ottobackwards commented on pull request #755: Feature/nifi integration address text
ottobackwards commented on PR #755: URL: https://github.com/apache/plc4x/pull/755#issuecomment-1398554496 Thanks for the contribution! The issues with expression language for addresses and having multiple addresses in that property were at the time: - Putting something complicated to write in a text field is poor for the user - The original didn't use json, but used special character substitution changing the native addresses which was a no-go - The addresses / returns need to have their PLC types resolved, and if the address could change _every_ call ( which you have to assume if you use expression language ) then it would be good to have some kind of caching so that it wasn't so costly every time, and the original PR did not provide that *This PR to land would have to address the caching issue*. Having json addresses the "don't invent a custom addressing delimiter" issue. We would just have to live with how poor writing complicated json in that UI would be ( or doing it external and cut and pasting it in) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] SteinOv closed pull request #715: fix(integrations/camel): Connection now established in doStart() of Producer/Consumer instead of constructors (#713)
SteinOv closed pull request #715: fix(integrations/camel): Connection now established in doStart() of Producer/Consumer instead of constructors (#713) URL: https://github.com/apache/plc4x/pull/715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] SteinOv commented on pull request #715: fix(integrations/camel): Connection now established in doStart() of Producer/Consumer instead of constructors (#713)
SteinOv commented on PR #715: URL: https://github.com/apache/plc4x/pull/715#issuecomment-1398553471 Yes, agreed. I'll close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl closed pull request #704: build(deps): bump plexus-compiler-eclipse from 2.12.1 to 2.13.0
sruehl closed pull request #704: build(deps): bump plexus-compiler-eclipse from 2.12.1 to 2.13.0 URL: https://github.com/apache/plc4x/pull/704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #749: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.5.0
sruehl commented on PR #749: URL: https://github.com/apache/plc4x/pull/749#issuecomment-1398551097 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #715: fix(integrations/camel): Connection now established in doStart() of Producer/Consumer instead of constructors (#713)
sruehl commented on PR #715: URL: https://github.com/apache/plc4x/pull/715#issuecomment-1398542560 @SteinOv & @chrisdutz guess we can close this then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #750: build(deps): bump Saxon-HE from 11.4 to 12.0
sruehl merged PR #750: URL: https://github.com/apache/plc4x/pull/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #753: build(deps): bump javafx.version from 19 to 19.0.2
sruehl merged PR #753: URL: https://github.com/apache/plc4x/pull/753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #754: build(deps): bump woodstox-core from 6.4.0 to 6.5.0
sruehl merged PR #754: URL: https://github.com/apache/plc4x/pull/754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #756: build(deps): bump github.com/spf13/viper from 1.14.0 to 1.15.0 in /plc4go
sruehl merged PR #756: URL: https://github.com/apache/plc4x/pull/756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] ottobackwards merged pull request #752: Feature/nifi integration type mapping
ottobackwards merged PR #752: URL: https://github.com/apache/plc4x/pull/752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #756: build(deps): bump github.com/spf13/viper from 1.14.0 to 1.15.0 in /plc4go
dependabot[bot] opened a new pull request, #756: URL: https://github.com/apache/plc4x/pull/756 Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.14.0 to 1.15.0. Release notes Sourced from https://github.com/spf13/viper/releases;>github.com/spf13/viper's releases. v1.15.0 What's Changed Exciting New Features feat: add multiple endpoints support for remote by https://github.com/mozartz;>@mozartz in https://github-redirect.dependabot.com/spf13/viper/pull/1464;>spf13/viper#1464 Enhancements Add DocBlock to WatchConfig by https://github.com/glebik000;>@glebik000 in https://github-redirect.dependabot.com/spf13/viper/pull/1467;>spf13/viper#1467 Breaking Changes Drop YAML v2 and TOML v1 by https://github.com/sagikazarmark;>@sagikazarmark in https://github-redirect.dependabot.com/spf13/viper/pull/1493;>spf13/viper#1493 Drop support for Go 1.16 by https://github.com/sagikazarmark;>@sagikazarmark in https://github-redirect.dependabot.com/spf13/viper/pull/1494;>spf13/viper#1494 Dependency Updates ⬆️ build(deps): bump github.com/spf13/afero from 1.9.2 to 1.9.3 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/spf13/viper/pull/1465;>spf13/viper#1465 build(deps): bump github.com/magiconair/properties from 1.8.6 to 1.8.7 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/spf13/viper/pull/1475;>spf13/viper#1475 build(deps): bump github.com/pelletier/go-toml/v2 from 2.0.5 to 2.0.6 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/spf13/viper/pull/1466;>spf13/viper#1466 build(deps): bump mheap/github-action-required-labels from 2 to 3 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/spf13/viper/pull/1482;>spf13/viper#1482 build(deps): bump github.com/subosito/gotenv from 1.4.1 to 1.4.2 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/spf13/viper/pull/1488;>spf13/viper#1488 build(deps): bump github.com/sagikazarmark/crypt from 0.8.0 to 0.9.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/spf13/viper/pull/1490;>spf13/viper#1490 New Contributors https://github.com/choar816;>@choar816 made their first contribution in https://github-redirect.dependabot.com/spf13/viper/pull/1481;>spf13/viper#1481 https://github.com/lol768;>@lol768 made their first contribution in https://github-redirect.dependabot.com/spf13/viper/pull/1485;>spf13/viper#1485 https://github.com/mozartz;>@mozartz made their first contribution in https://github-redirect.dependabot.com/spf13/viper/pull/1464;>spf13/viper#1464 https://github.com/glebik000;>@glebik000 made their first contribution in https://github-redirect.dependabot.com/spf13/viper/pull/1467;>spf13/viper#1467 Full Changelog: https://github.com/spf13/viper/compare/v1.14.0...v1.15.0;>https://github.com/spf13/viper/compare/v1.14.0...v1.15.0 Commits https://github.com/spf13/viper/commit/518241257478c557633ab36e474dfcaeb9a3c623;>5182412 Add DocBlock to WatchConfig (https://github-redirect.dependabot.com/spf13/viper/issues/1467;>#1467) https://github.com/spf13/viper/commit/0755477020c2dffa85bdf3ff0d2f4402e8c53971;>0755477 feat: add multiple endpoints support for remote https://github.com/spf13/viper/commit/a7ad8cfcc498bf931c250cbfef65e320c98f707d;>a7ad8cf build(deps): bump github.com/sagikazarmark/crypt from 0.8.0 to 0.9.0 https://github.com/spf13/viper/commit/63630c2fcdf434d40a9396b7678b1d8e020288bc;>63630c2 build(deps): bump github.com/subosito/gotenv from 1.4.1 to 1.4.2 https://github.com/spf13/viper/commit/996ab102144b89fff3318a57e780d62717bcedf8;>996ab10 ci: update golangci-lint https://github.com/spf13/viper/commit/982460e8e1b44e809b2b7d666a65d13aede436ce;>982460e feat!: drop Go 1.16 support https://github.com/spf13/viper/commit/2f5cb62e1fa7874e7044f825095c79155a7776c4;>2f5cb62 ci: cleanup tags https://github.com/spf13/viper/commit/77fc1c3084ea7064db16816828cca7af47c04410;>77fc1c3 feat!: drop toml v1 support https://github.com/spf13/viper/commit/e42b933dbe09a4dca670a89fa98a55dddec014c0;>e42b933 feat!: drop yaml v2 support https://github.com/spf13/viper/commit/9e46b7652ff9b483ba5fde5932a6729d6921b3fa;>9e46b76 build(deps): bump mheap/github-action-required-labels from 2 to 3 Additional commits viewable in https://github.com/spf13/viper/compare/v1.14.0...v1.15.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with
[GitHub] [plc4x] QuanticPony opened a new pull request, #755: Feature/nifi integration address text
QuanticPony opened a new pull request, #755: URL: https://github.com/apache/plc4x/pull/755 Proposal to add a property in NiFi-integration processors to allow users to choose address definition strategy and add support for Expression Language in addresses definition. ## Issues related: * #648: As stated, adding a lot of addresses as dynamic properties can be tedious. * #593 (Jira [PLC4X-196](https://issues.apache.org/jira/browse/PLC4X-196)): Expression Language can be supported easily on addresses definition. ## Actual behavior: Addresses are specified one by one as dynamic properties in the processor and stored in a map when `onScheduled` method is triggered. Expression Language is not supported. ## Proposed behavior: Let user decide between 2 strategies to obtain addresses in the processor: * Properties as addresses (as actual behavior but with Expression Language): 1 address per dynamic property. * Property "Address Text": a property where all addresses can be specified as field-value pairs in a JSON. An address map created every time when `onTrigger` method is called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #754: build(deps): bump woodstox-core from 6.4.0 to 6.5.0
dependabot[bot] opened a new pull request, #754: URL: https://github.com/apache/plc4x/pull/754 Bumps [woodstox-core](https://github.com/FasterXML/woodstox) from 6.4.0 to 6.5.0. Commits https://github.com/FasterXML/woodstox/commit/830654b03458d7bbb3d83fc72d2ef44021db32b5;>830654b [maven-release-plugin] prepare release woodstox-core-6.5.0 https://github.com/FasterXML/woodstox/commit/168eb4b47996eed6e1bcc2ad57f995b40ad04c87;>168eb4b Prepare for Woodstox 6.5.0 release https://github.com/FasterXML/woodstox/commit/c8e64cb146b3902aec0a88c9fd2b387c18bf8f58;>c8e64cb Revert Declare osgi.serviceloader.registrar requirement as optional. (https://github-redirect.dependabot.com/FasterXML/woodstox/issues/155;>#155)... https://github.com/FasterXML/woodstox/commit/2ebb4a5387d206f21fe0dec7987b55c4899887d1;>2ebb4a5 Update master to 6.5.0-SNAPSHOT https://github.com/FasterXML/woodstox/commit/fd835de89d25b55a9396a07df51608a62ae02788;>fd835de fuzzing: add CIFuzz (https://github-redirect.dependabot.com/FasterXML/woodstox/issues/161;>#161) https://github.com/FasterXML/woodstox/commit/44a66e99fc18bdc56dbd48ba3f94f1b569f28710;>44a66e9 Release note update (actually https://github-redirect.dependabot.com/FasterXML/woodstox/issues/160;>#160 and not 162) https://github.com/FasterXML/woodstox/commit/9438a39be28011f4f792b9ec91ff8fdb1602fed3;>9438a39 Merge branch '5.3' https://github.com/FasterXML/woodstox/commit/415d2aa64c907453e2df43b726f13b6c4fe73535;>415d2aa Update release notes wrt https://github-redirect.dependabot.com/FasterXML/woodstox/issues/162;>#162 https://github.com/FasterXML/woodstox/commit/1717fd5c1fb1f84d2131e534831651caf5568b2a;>1717fd5 update release notes https://github.com/FasterXML/woodstox/commit/76435d4f995721c8cbb2c28f2ed01a33e332c15a;>76435d4 Merge branch '5.3' Additional commits viewable in https://github.com/FasterXML/woodstox/compare/woodstox-core-6.4.0...woodstox-core-6.5.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #753: build(deps): bump javafx.version from 19 to 19.0.2
dependabot[bot] opened a new pull request, #753: URL: https://github.com/apache/plc4x/pull/753 Bumps `javafx.version` from 19 to 19.0.2. Updates `javafx-base` from 19 to 19.0.2 Updates `javafx-graphics` from 19 to 19.0.2 Updates `javafx-controls` from 19 to 19.0.2 Updates `javafx-fxml` from 19 to 19.0.2 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] QuanticPony commented on a diff in pull request #752: Feature/nifi integration type mapping
QuanticPony commented on code in PR #752: URL: https://github.com/apache/plc4x/pull/752#discussion_r1073618937 ## plc4j/integrations/apache-nifi/README.md: ## @@ -85,29 +85,25 @@ Also, it is important to keep in mind the Processor Scheduling Configuration. Us Table of data mapping between plc data and Avro + | PLC type | Avro Type | -|--|---| -| PlcBigDecimal | float | -| PlcBigInteger | long | -| PlcBitString | string | +|--:|---| | PlcBOOL | boolean | Review Comment: In Avro specification (https://avro.apache.org/docs/1.11.1/specification/#primitive-types) the primitive type is called bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] ottobackwards commented on a diff in pull request #752: Feature/nifi integration type mapping
ottobackwards commented on code in PR #752: URL: https://github.com/apache/plc4x/pull/752#discussion_r1073603312 ## plc4j/integrations/apache-nifi/README.md: ## @@ -85,29 +85,25 @@ Also, it is important to keep in mind the Processor Scheduling Configuration. Us Table of data mapping between plc data and Avro + | PLC type | Avro Type | -|--|---| -| PlcBigDecimal | float | -| PlcBigInteger | long | -| PlcBitString | string | +|--:|---| | PlcBOOL | boolean | Review Comment: should be byte[]? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] commented on pull request #748: build(deps): bump kotlin.version from 1.7.22 to 1.8.0
dependabot[bot] commented on PR #748: URL: https://github.com/apache/plc4x/pull/748#issuecomment-1387146276 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl closed pull request #748: build(deps): bump kotlin.version from 1.7.22 to 1.8.0
sruehl closed pull request #748: build(deps): bump kotlin.version from 1.7.22 to 1.8.0 URL: https://github.com/apache/plc4x/pull/748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #751: build(deps): bump assertj-core from 3.24.1 to 3.24.2
sruehl merged PR #751: URL: https://github.com/apache/plc4x/pull/751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] QuanticPony opened a new pull request, #752: Feature/nifi integration type mapping
QuanticPony opened a new pull request, #752: URL: https://github.com/apache/plc4x/pull/752 Improvements in type mapping from Plc4x to Avro. Added unit test for record source processor. Changes in mapping: * PlcBYTE: string -> bytes * PlcLINT:string -> long * PlcREAL: double -> float * PlcLREAL: string -> double General improvements in `org.apache.plc4x.nifi.util.Plc4xCommon`: * Reduced repeated code * Updated mapping table in readme * Fixed: reading PlcList not working * Fixed: PlcByte to Avro mapping was set to bool, caused exception, changed to bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #751: build(deps): bump assertj-core from 3.24.1 to 3.24.2
dependabot[bot] opened a new pull request, #751: URL: https://github.com/apache/plc4x/pull/751 Bumps assertj-core from 3.24.1 to 3.24.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #750: build(deps): bump Saxon-HE from 11.4 to 12.0
dependabot[bot] opened a new pull request, #750: URL: https://github.com/apache/plc4x/pull/750 Bumps Saxon-HE from 11.4 to 12.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #749: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.5.0
dependabot[bot] opened a new pull request, #749: URL: https://github.com/apache/plc4x/pull/749 Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.1.2 to 3.5.0. Commits https://github.com/apache/maven-dependency-plugin/commit/520f8fd6ba4a00a8a1174077d5610aa5ecae7595;>520f8fd [maven-release-plugin] prepare release maven-dependency-plugin-3.5.0 https://github.com/apache/maven-dependency-plugin/commit/4b478d61e1e78f5bddda6d1256f91c357c2561a4;>4b478d6 [MDEP-841] Explicitly start and end tables with Doxia Sinks in report renderers https://github.com/apache/maven-dependency-plugin/commit/799ff97da3130fe8dd1daf9e68405db066584080;>799ff97 [MDEP-831] Remove dependency on commons-lang3 (https://github-redirect.dependabot.com/apache/maven-dependency-plugin/issues/270;>#270) https://github.com/apache/maven-dependency-plugin/commit/68b72723d3ece966078daec13567090b17280216;>68b7272 [MDEP-837] Ignore reformat commit from git blame https://github.com/apache/maven-dependency-plugin/commit/cc082ea7d4af7db78c521d59360d261ffbc1b184;>cc082ea [MDEP-837] Reformat code after parent 38 https://github.com/apache/maven-dependency-plugin/commit/803433bccf1bb4a562d05a6662189fde91184b6d;>803433b [MDEP-837] Upgrade Parent to 38 https://github.com/apache/maven-dependency-plugin/commit/a05a2a4f5ce1e6d9053f6db9b84736e8bbc519b7;>a05a2a4 Bump junit from 4.13 to 4.13.2 in /src/it/projects/tree-verbose-small https://github.com/apache/maven-dependency-plugin/commit/ea2a668dcb21e08c69d42c2cdbcf21483fdb3c01;>ea2a668 remove unused beanutils dependency (https://github-redirect.dependabot.com/apache/maven-dependency-plugin/issues/268;>#268) https://github.com/apache/maven-dependency-plugin/commit/ea43fa6ae8b0504d12d794fdb6ff83e995f6a41a;>ea43fa6 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-dependency-plugin/commit/8fecf8a54af68c7b9cb97f90ac6b9c726e33e5ce;>8fecf8a [maven-release-plugin] prepare release maven-dependency-plugin-3.4.0 Additional commits viewable in https://github.com/apache/maven-dependency-plugin/compare/maven-dependency-plugin-3.1.2...maven-dependency-plugin-3.5.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #748: build(deps): bump kotlin.version from 1.7.22 to 1.8.0
dependabot[bot] opened a new pull request, #748: URL: https://github.com/apache/plc4x/pull/748 Bumps `kotlin.version` from 1.7.22 to 1.8.0. Updates `kotlin-stdlib` from 1.7.22 to 1.8.0 Release notes Sourced from https://github.com/JetBrains/kotlin/releases;>kotlin-stdlib's releases. Kotlin 1.8.0 Changelog Analysis API https://youtrack.jetbrains.com/issue/KT-50255;>KT-50255 Analysis API: Implement standalone mode for the Analysis API Analysis API. FIR https://youtrack.jetbrains.com/issue/KT-54292;>KT-54292 Symbol Light classes: implement PsiVariable.computeConstantValue for light field https://youtrack.jetbrains.com/issue/KT-54293;>KT-54293 Analysis API: fix constructor symbol creation when its accessed via type alias Android https://youtrack.jetbrains.com/issue/KT-53342;>KT-53342 TCS: New AndroidSourceSet layout for multiplatform https://youtrack.jetbrains.com/issue/KT-53013;>KT-53013 Increase AGP compile version in KGP to 4.1.3 https://youtrack.jetbrains.com/issue/KT-54013;>KT-54013 Report error when using deprecated Kotlin Android Extensions compiler plugin https://youtrack.jetbrains.com/issue/KT-53709;>KT-53709 MPP, Android SSL2: Conflicting warnings for androidTest/kotlin source set folder Backend. Native. Debug https://youtrack.jetbrains.com/issue/KT-53561;>KT-53561 Invalid LLVM module: inlinable function call in a function with debug info must have a !dbg location Compiler New Features https://youtrack.jetbrains.com/issue/KT-52817;>KT-52817 Add @JvmSerializableLambda annotation to keep old behavior of non-invokedynamic lambdas https://youtrack.jetbrains.com/issue/KT-54460;>KT-54460 Implementation of non-local break and continue https://youtrack.jetbrains.com/issue/KT-53916;>KT-53916 Support Xcode 14 and new Objective-C frameworks in Kotlin/Native compiler https://youtrack.jetbrains.com/issue/KT-32208;>KT-32208 Generate method annotations into bytecode for suspend lambdas (on invokeSuspend) https://youtrack.jetbrains.com/issue/KT-53438;>KT-53438 Introduce a way to get SourceDebugExtension attribute value via JVMTI for profiler and coverage Performance Improvements https://youtrack.jetbrains.com/issue/KT-53347;>KT-53347 Get rid of excess allocations in parser https://youtrack.jetbrains.com/issue/KT-53689;>KT-53689 JVM: Optimize equality on class literals https://youtrack.jetbrains.com/issue/KT-53119;>KT-53119 Improve String Concatenation Lowering Fixes https://youtrack.jetbrains.com/issue/KT-53465;>KT-53465 Unnecessary checkcast to array of reified type is not optimized since Kotlin 1.6.20 https://youtrack.jetbrains.com/issue/KT-49658;>KT-49658 NI: False negative TYPE_MISMATCH on nullable type with when https://youtrack.jetbrains.com/issue/KT-48162;>KT-48162 NON_VARARG_SPREAD isn't reported on *toTypedArray() call https://youtrack.jetbrains.com/issue/KT-43493;>KT-43493 NI: False negative: no compilation error Operator '==' cannot be applied to 'Long' and 'Int' is reported in builder inference lambdas https://youtrack.jetbrains.com/issue/KT-54393;>KT-54393 Change in behavior from 1.7.10 to 1.7.20 for java field override. https://youtrack.jetbrains.com/issue/KT-55357;>KT-55357 IllegalStateException when reading a class that delegates to a Java class with a definitely-not-null type with a flexible upper bound https://youtrack.jetbrains.com/issue/KT-55068;>KT-55068 Kotlin Gradle DSL: No mapping for symbol: VALUE_PARAMETER SCRIPT_IMPLICIT_RECEIVER on JVM IR backend https://youtrack.jetbrains.com/issue/KT-51284;>KT-51284 SAM conversion doesn't work if method has context receivers https://youtrack.jetbrains.com/issue/KT-48532;>KT-48532 Remove old JVM backend ... (truncated) Changelog Sourced from https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md;>kotlin-stdlib's changelog. 1.8.0 Analysis API https://youtrack.jetbrains.com/issue/KT-50255;>KT-50255 Analysis API: Implement standalone mode for the Analysis API Analysis API. FIR https://youtrack.jetbrains.com/issue/KT-54292;>KT-54292 Symbol Light classes: implement PsiVariable.computeConstantValue for light field https://youtrack.jetbrains.com/issue/KT-54293;>KT-54293 Analysis API: fix constructor symbol creation when its accessed via type alias Android https://youtrack.jetbrains.com/issue/KT-53342;>KT-53342 TCS: New AndroidSourceSet layout for multiplatform https://youtrack.jetbrains.com/issue/KT-53013;>KT-53013 Increase AGP compile version in KGP to 4.1.3 https://youtrack.jetbrains.com/issue/KT-54013;>KT-54013 Report error when using deprecated Kotlin Android Extensions compiler plugin https://youtrack.jetbrains.com/issue/KT-53709;>KT-53709 MPP, Android SSL2: Conflicting warnings for androidTest/kotlin source set folder Backend.
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072191526
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java:
##
@@ -16,17 +16,25 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.plc4x.java.utils.connectionpool2;
+package org.apache.plc4x.java.api;
-import org.apache.plc4x.java.api.PlcConnection;
+import org.apache.plc4x.java.DefaultPlcDriverManager;
import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
-/**
- * Simple Factory Method which creates a new PlcConnection
- */
-@FunctionalInterface
-public interface PlcConnectionFactory {
+import java.util.Set;
+
+public interface PlcDriverManager {
+
+static PlcDriverManager getDefault() {
+return new DefaultPlcDriverManager();
+}
+
+Set listDrivers();
+
+PlcDriver getDriver(String protocolCode) throws PlcConnectionException;
+
+PlcDriver getDriverForUrl(String url) throws PlcConnectionException;
-PlcConnection create() throws PlcConnectionException;
Review Comment:
Let's agree on not calling them "customers" as they are missing one
important aspect of a typical customer relation.
I would say that "customers" have the chance to come forward and announce
this would break things for them. I would consider it important to have
backward compatibility once we are at 1.0.0. But I wouldn't object your
proposal. Feel free to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072185474 ## plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml: ## @@ -27,7 +27,7 @@ - + Review Comment: Couple of months back I turned them all up to error as we just exceeded the logoutput because of the size of our build. Those changes where all in the test-logback.xml. Just noticed that this is the main logback file so that should be fine so nvm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072183895
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java:
##
@@ -16,17 +16,25 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.plc4x.java.utils.connectionpool2;
+package org.apache.plc4x.java.api;
-import org.apache.plc4x.java.api.PlcConnection;
+import org.apache.plc4x.java.DefaultPlcDriverManager;
import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
-/**
- * Simple Factory Method which creates a new PlcConnection
- */
-@FunctionalInterface
-public interface PlcConnectionFactory {
+import java.util.Set;
+
+public interface PlcDriverManager {
+
+static PlcDriverManager getDefault() {
+return new DefaultPlcDriverManager();
+}
+
+Set listDrivers();
+
+PlcDriver getDriver(String protocolCode) throws PlcConnectionException;
+
+PlcDriver getDriverForUrl(String url) throws PlcConnectionException;
-PlcConnection create() throws PlcConnectionException;
Review Comment:
because it is part of the API package an might break exiting deployments
from customers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072181255 ## plc4j/examples/hello-ads-telemetry/pom.xml: ## @@ -40,13 +43,31 @@ - org.apache.commons - commons-pool2 + org.slf4j + slf4j-api - org.apache.commons - commons-lang3 + org.slf4j + log4j-over-slf4j + + + ch.qos.logback + logback-classic + + + +org.apache.maven.plugins +maven-dependency-plugin + + +org.slf4j:log4j-over-slf4j + + + + + + Review Comment: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache
chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072148900 ## plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml: ## @@ -27,7 +27,7 @@ - + Review Comment: I'm using the logging to output information on INFO level ... what good would the application be, if we set the log level to Error and just stripped all usable output? If yes, then you should have suggested a logger entry to explicitly set the log level of the application to info, but this change doesn't make any sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache
chrisdutz commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072146589 ## plc4j/examples/hello-ads-telemetry/pom.xml: ## @@ -40,13 +43,31 @@ - org.apache.commons - commons-pool2 + org.slf4j + slf4j-api - org.apache.commons - commons-lang3 + org.slf4j + log4j-over-slf4j + + + ch.qos.logback + logback-classic + + + +org.apache.maven.plugins +maven-dependency-plugin + + +org.slf4j:log4j-over-slf4j + + + + + + Review Comment: Seriously? Not willing to do a discussion on the usage of new-lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072144969
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java:
##
@@ -16,17 +16,25 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.plc4x.java.utils.connectionpool2;
+package org.apache.plc4x.java.api;
-import org.apache.plc4x.java.api.PlcConnection;
+import org.apache.plc4x.java.DefaultPlcDriverManager;
import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
-/**
- * Simple Factory Method which creates a new PlcConnection
- */
-@FunctionalInterface
-public interface PlcConnectionFactory {
+import java.util.Set;
+
+public interface PlcDriverManager {
+
+static PlcDriverManager getDefault() {
+return new DefaultPlcDriverManager();
+}
+
+Set listDrivers();
+
+PlcDriver getDriver(String protocolCode) throws PlcConnectionException;
+
+PlcDriver getDriverForUrl(String url) throws PlcConnectionException;
-PlcConnection create() throws PlcConnectionException;
Review Comment:
What for? I mean ... we're obviously not using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072123552
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.plc4x.java.api;
+
+import org.apache.plc4x.java.api.authentication.PlcAuthentication;
+import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+
+public interface PlcConnectionManager {
+
+/**
+ * Connects to a PLC using the given plc connection string.
+ *
+ * @param url plc connection string.
+ * @return PlcConnection object.
+ * @throws PlcConnectionException an exception if the connection attempt
failed.
+ */
+PlcConnection getConnection(String url) throws PlcConnectionException;
+
+/**
+ * Connects to a PLC using the given plc connection string using given
authentication credentials.
+ *
+ * @param urlplc connection string.
+ * @param authentication authentication credentials.
+ * @return PlcConnection object.
+ * @throws PlcConnectionException an exception if the connection attempt
failed.
+ */
+PlcConnection getConnection(String url, PlcAuthentication authentication)
throws PlcConnectionException;
Review Comment:
Don't think that should be a Problem but maybe I don't see it :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072121894 ## plc4j/tools/scraper-ng/pom.xml: ## @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + + 4.0.0 + + +org.apache.plc4x +plc4j-tools +0.11.0-SNAPSHOT + + + plc4j-scraper-ng + + PLC4J: Tools: Scraper (NG) + Utility to efficiently collect a large number of items on multiple devices by different triggers. + + + Review Comment: maybe remove those outcommented deps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072121595 ## plc4j/tools/scraper/pom.xml: ## @@ -100,12 +96,6 @@ 0.11.0-SNAPSHOT test - - org.apache.plc4x - plc4j-connection-cache - 0.11.0-SNAPSHOT - compile - Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072121286 ## plc4j/tools/scraper-ng/pom.xml: ## @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + + 4.0.0 + + +org.apache.plc4x +plc4j-tools +0.11.0-SNAPSHOT + + + plc4j-scraper-ng + + PLC4J: Tools: Scraper (NG) + Utility to efficiently collect a large number of items on multiple devices by different triggers. + + + + + + + + + + + + + org.apache.plc4x + plc4j-spi + 0.11.0-SNAPSHOT + test + + + + + org.awaitility + awaitility + test + + + org.apache.plc4x + plc4j-driver-mock + 0.11.0-SNAPSHOT + test + + + + Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120717
##
plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/protocol/AdsProtocolLogic.java:
##
@@ -136,11 +136,11 @@ public void onConnect(ConversationContext
context) {
// otherwise just mark the connection as completed instantly.
setupAmsRouteFuture.whenComplete((unused, throwable) -> {
if (!configuration.isLoadSymbolAndDataTypeTables()) {
-future.completeExceptionally(new PlcConnectionException(
-"Lazy loading is generally planned, but not implemented
yet. " +
-"If you are in need for this feature, please reach out
to the community."));
-}
-//if (configuration.isLoadSymbolAndDataTypeTables()) {
+context.fireConnected();
+//future.completeExceptionally(new PlcConnectionException(
Review Comment:
No ... it's a first step to make it possible to still connect to an ADS
without loading the symbol table (if you just use raw addresses) ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120527 ## plc4j/tools/connection-cache/src/test/resources/logback-test.xml: ## @@ -27,7 +27,9 @@ - + + + Review Comment: ```suggestion ``` ## plc4j/tools/connection-cache/src/test/resources/logback-test.xml: ## @@ -27,7 +27,9 @@ - + Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072120180
##
plc4j/tools/connection-cache/src/test/java/org/apache/plc4x/java/utils/cache/CachedPlcConnectionManagerTest.java:
##
@@ -0,0 +1,174 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.plc4x.java.utils.cache;
+
+import org.apache.plc4x.java.api.PlcConnection;
+import org.apache.plc4x.java.api.PlcConnectionManager;
+import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+import org.apache.plc4x.java.api.exceptions.PlcRuntimeException;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+
+import java.time.Duration;
+
+public class CachedPlcConnectionManagerTest {
+
+/**
+ * This is the simplest possible test. Here the ConnectionManager is used
exactly once.
+ * So not really much of the caching we can test, but it tests if we're
creating connections the right way.
+ *
+ * @throws PlcConnectionException something went wrong
+ */
+@Test
+public void testSingleConnectionRequestTest() throws
PlcConnectionException {
+PlcConnectionManager mockConnectionManager =
Mockito.mock(PlcConnectionManager.class);
Review Comment:
There is also the Mockito Annotation which is pretty cool to use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072118836
##
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/CachedPlcConnectionManager.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.plc4x.java.utils.cache;
+
+import org.apache.plc4x.java.DefaultPlcDriverManager;
+import org.apache.plc4x.java.api.PlcConnection;
+import org.apache.plc4x.java.api.PlcConnectionManager;
+import org.apache.plc4x.java.api.authentication.PlcAuthentication;
+import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.time.Duration;
+import java.util.*;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class CachedPlcConnectionManager implements PlcConnectionManager {
+
+private static final Logger LOG =
LoggerFactory.getLogger(CachedPlcConnectionManager.class);
+
+private final PlcConnectionManager connectionManager;
+private final Duration maxLeaseTime;
+private final Duration maxWaitTime;
+
+private final Map connectionContainers;
+
+public static Builder getBuilder() {
+return new Builder(new DefaultPlcDriverManager());
+}
+
+public static Builder getBuilder(PlcConnectionManager connectionManager) {
+return new Builder(connectionManager);
+}
+
+public CachedPlcConnectionManager(PlcConnectionManager connectionManager,
Duration maxLeaseTime, Duration maxWaitTime) {
+this.connectionManager = connectionManager;
+this.maxLeaseTime = maxLeaseTime;
+this.maxWaitTime = maxWaitTime;
+this.connectionContainers = new HashMap<>();
+}
+
+public PlcConnection getConnection(String url) throws
PlcConnectionException {
+ConnectionContainer connectionContainer;
+synchronized (connectionContainers) {
Review Comment:
an alternative here might be the use of the ConcurrentHashMap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072117311 ## plc4j/examples/hello-ads-telemetry/src/main/resources/logback.xml: ## @@ -27,7 +27,7 @@ - + Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747: URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116783 ## plc4j/examples/hello-ads-telemetry/pom.xml: ## @@ -40,13 +43,31 @@ - org.apache.commons - commons-pool2 + org.slf4j + slf4j-api - org.apache.commons - commons-lang3 + org.slf4j + log4j-over-slf4j + + + ch.qos.logback + logback-classic + + + +org.apache.maven.plugins +maven-dependency-plugin + + +org.slf4j:log4j-over-slf4j + + + + + + Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116126
##
plc4j/drivers/ads/src/main/java/org/apache/plc4x/java/ads/protocol/AdsProtocolLogic.java:
##
@@ -136,11 +136,11 @@ public void onConnect(ConversationContext
context) {
// otherwise just mark the connection as completed instantly.
setupAmsRouteFuture.whenComplete((unused, throwable) -> {
if (!configuration.isLoadSymbolAndDataTypeTables()) {
-future.completeExceptionally(new PlcConnectionException(
-"Lazy loading is generally planned, but not implemented
yet. " +
-"If you are in need for this feature, please reach out
to the community."));
-}
-//if (configuration.isLoadSymbolAndDataTypeTables()) {
+context.fireConnected();
+//future.completeExceptionally(new PlcConnectionException(
Review Comment:
is the outcommmented code here an accident?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116724
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.plc4x.java.api;
+
+import org.apache.plc4x.java.api.authentication.PlcAuthentication;
+import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+
+public interface PlcConnectionManager {
+
+/**
+ * Connects to a PLC using the given plc connection string.
+ *
+ * @param url plc connection string.
+ * @return PlcConnection object.
+ * @throws PlcConnectionException an exception if the connection attempt
failed.
+ */
+PlcConnection getConnection(String url) throws PlcConnectionException;
+
+/**
+ * Connects to a PLC using the given plc connection string using given
authentication credentials.
+ *
+ * @param urlplc connection string.
+ * @param authentication authentication credentials.
+ * @return PlcConnection object.
+ * @throws PlcConnectionException an exception if the connection attempt
failed.
+ */
+PlcConnection getConnection(String url, PlcAuthentication authentication)
throws PlcConnectionException;
Review Comment:
At least I think so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #747: New Implementation of the Connection-Cache
chrisdutz commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072116329
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.plc4x.java.api;
+
+import org.apache.plc4x.java.api.authentication.PlcAuthentication;
+import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+
+public interface PlcConnectionManager {
+
+/**
+ * Connects to a PLC using the given plc connection string.
+ *
+ * @param url plc connection string.
+ * @return PlcConnection object.
+ * @throws PlcConnectionException an exception if the connection attempt
failed.
+ */
+PlcConnection getConnection(String url) throws PlcConnectionException;
+
+/**
+ * Connects to a PLC using the given plc connection string using given
authentication credentials.
+ *
+ * @param urlplc connection string.
+ * @param authentication authentication credentials.
+ * @return PlcConnection object.
+ * @throws PlcConnectionException an exception if the connection attempt
failed.
+ */
+PlcConnection getConnection(String url, PlcAuthentication authentication)
throws PlcConnectionException;
Review Comment:
Well that is incompatible with the try-with-resources pattern ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072115260
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcDriverManager.java:
##
@@ -16,17 +16,25 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.plc4x.java.utils.connectionpool2;
+package org.apache.plc4x.java.api;
-import org.apache.plc4x.java.api.PlcConnection;
+import org.apache.plc4x.java.DefaultPlcDriverManager;
import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
-/**
- * Simple Factory Method which creates a new PlcConnection
- */
-@FunctionalInterface
-public interface PlcConnectionFactory {
+import java.util.Set;
+
+public interface PlcDriverManager {
+
+static PlcDriverManager getDefault() {
+return new DefaultPlcDriverManager();
+}
+
+Set listDrivers();
+
+PlcDriver getDriver(String protocolCode) throws PlcConnectionException;
+
+PlcDriver getDriverForUrl(String url) throws PlcConnectionException;
-PlcConnection create() throws PlcConnectionException;
Review Comment:
I wonder if we should leave the create method as deprecated default
implementation:
```
default PlcConnection create() {
return getConnectionManager().create();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072113699
##
plc4j/api/src/main/java/org/apache/plc4x/java/api/PlcConnectionManager.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.plc4x.java.api;
+
+import org.apache.plc4x.java.api.authentication.PlcAuthentication;
+import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+
+public interface PlcConnectionManager {
+
+/**
+ * Connects to a PLC using the given plc connection string.
+ *
+ * @param url plc connection string.
+ * @return PlcConnection object.
+ * @throws PlcConnectionException an exception if the connection attempt
failed.
+ */
+PlcConnection getConnection(String url) throws PlcConnectionException;
+
+/**
+ * Connects to a PLC using the given plc connection string using given
authentication credentials.
+ *
+ * @param urlplc connection string.
+ * @param authentication authentication credentials.
+ * @return PlcConnection object.
+ * @throws PlcConnectionException an exception if the connection attempt
failed.
+ */
+PlcConnection getConnection(String url, PlcAuthentication authentication)
throws PlcConnectionException;
Review Comment:
@chrisdutz we should some day think about using the option pattern from
Golang here to (the ones with the varargs options). This way we could combine
the getConnection into one method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on a diff in pull request #747: New Implementation of the Connection-Cache
sruehl commented on code in PR #747:
URL: https://github.com/apache/plc4x/pull/747#discussion_r1072112458
##
plc4j/api/src/main/java/org/apache/plc4x/java/DefaultPlcDriverManager.java:
##
@@ -32,19 +34,19 @@
import java.util.ServiceLoader;
import java.util.Set;
-public class PlcDriverManager {
+public class DefaultPlcDriverManager implements PlcDriverManager,
PlcConnectionManager {
-private static final Logger LOGGER =
LoggerFactory.getLogger(PlcDriverManager.class);
+private static final Logger LOGGER =
LoggerFactory.getLogger(org.apache.plc4x.java.DefaultPlcDriverManager.class);
Review Comment:
```suggestion
private static final Logger LOGGER =
LoggerFactory.getLogger(DefaultPlcDriverManager.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #745: build(deps): bump netty-bom from 4.1.86.Final to 4.1.87.Final
sruehl merged PR #745: URL: https://github.com/apache/plc4x/pull/745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #744: build(deps): bump freemarker from 2.3.31 to 2.3.32
sruehl merged PR #744: URL: https://github.com/apache/plc4x/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #745: build(deps): bump netty-bom from 4.1.86.Final to 4.1.87.Final
sruehl commented on PR #745: URL: https://github.com/apache/plc4x/pull/745#issuecomment-1385187601 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #746: build(deps): bump mockito.version from 4.11.0 to 5.0.0
sruehl merged PR #746: URL: https://github.com/apache/plc4x/pull/746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request, #53: chore(deps): bump maven-plugin-annotations from 3.7.0 to 3.7.1
dependabot[bot] opened a new pull request, #53: URL: https://github.com/apache/plc4x-build-tools/pull/53 Bumps [maven-plugin-annotations](https://github.com/apache/maven-plugin-tools) from 3.7.0 to 3.7.1. Release notes Sourced from https://github.com/apache/maven-plugin-tools/releases;>maven-plugin-annotations's releases. 3.7.1 Commits https://github.com/apache/maven-plugin-tools/commit/52afb9ff7129912a1ff2d02c42487dc3a33f8364;>52afb9f [maven-release-plugin] prepare release maven-plugin-tools-3.7.1 https://github.com/apache/maven-plugin-tools/commit/73065a1ba216235150b832edad4b43ad3207e3ce;>73065a1 Set version to 3.7.1-SNAPSHOT https://github.com/apache/maven-plugin-tools/commit/17aabccca1590f01925db9f63f04a67bd0a4c2f1;>17aabcc [MPLUGIN-452] Maven scope and module name logs at wrong level (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/190;>#190) See full diff in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.7.0...maven-plugin-tools-3.7.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request, #52: chore(deps): bump maven-plugin-plugin from 3.7.0 to 3.7.1
dependabot[bot] opened a new pull request, #52: URL: https://github.com/apache/plc4x-build-tools/pull/52 Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.7.0 to 3.7.1. Release notes Sourced from https://github.com/apache/maven-plugin-tools/releases;>maven-plugin-plugin's releases. 3.7.1 Commits https://github.com/apache/maven-plugin-tools/commit/52afb9ff7129912a1ff2d02c42487dc3a33f8364;>52afb9f [maven-release-plugin] prepare release maven-plugin-tools-3.7.1 https://github.com/apache/maven-plugin-tools/commit/73065a1ba216235150b832edad4b43ad3207e3ce;>73065a1 Set version to 3.7.1-SNAPSHOT https://github.com/apache/maven-plugin-tools/commit/17aabccca1590f01925db9f63f04a67bd0a4c2f1;>17aabcc [MPLUGIN-452] Maven scope and module name logs at wrong level (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/190;>#190) See full diff in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.7.0...maven-plugin-tools-3.7.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #746: build(deps): bump mockito.version from 4.11.0 to 5.0.0
dependabot[bot] opened a new pull request, #746: URL: https://github.com/apache/plc4x/pull/746 Bumps `mockito.version` from 4.11.0 to 5.0.0. Updates `mockito-core` from 4.11.0 to 5.0.0 Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases. v5.0.0 Mockito 5: prepare for future JDK versions For a while now, we have seen an increase in problems/incompatibilities with recent versions of the JDK due to our usage of JVM-internal API. Most notably, JDK 17 made some changes which are incompatible with the current subclass mockmaker. Therefore, to prepare for the future of JDK, we are making some core changes to ensure Mockito keeps on working. Switch the default mockmaker to mockito-inline Back in Mockito 2.7.6, we published a new mockmaker based on the inline bytecode principle. This mockmaker creates mocks manipulating bytecode equivalent within the original class such that its method implementations hook into the normal Mockito machinery. As a comparison, the subclass mockmaker generates real subclasses for mocks, to mimic the same behavior. While the approaches are similar, the inline mockmaker avoids certain restrictions that the JDK imposes. For example, it does not violate module boundaries (introduced in JDK 9, but more heavily used in JDK 17) and avoids the leaking of the creation of the subclass. Massive thanks to community member https://github.com/reta;>@reta who implemented this change. When should I still be using the subclass mockmaker? There are legitimate remaining use cases for the subclass mockmaker. For example, on the Graal VM's native image, the inline mockmaker will not work and the subclass mockmaker is the appropriate choice. Additionally, if you would like to avoid mocking final classes, using the subclass mockmaker is a possibibility. Note however that if you solely want to use the subclass mockmaker to avoid mocking final, you will run into the above mentioned issues on JDK 17+. We want to leave this choice up to our users, which is why we will keep on supporting the subclass mockmaker. If you want to use the subclass mockmaker instead, you can use the new mockito-subclass artifact (published https://search.maven.org/artifact/org.mockito/mockito-subclass;>on Maven Central along with all our other artifacts). Update the minimum supported Java version to 11 Mockito 4 supports Java 8 and above. Similar to other open source projects, we are moving away from JDK 8 and to newer versions. The primary reason for moving away from JDK 8 is the increasing maintenance costs with keeping our own infrastructure working. Lately we have been running into more and more JDK 8 breakages. Additionally, while we want to support the newest JDK API's, our current solution to support both JDK 8 and newer versions causes https://github-redirect.dependabot.com/mockito/mockito/issues/2798;>issues with the SecurityManager. Since we want Mockito to work on the newest version and more and more businesses adopting JDK 11, we have decided to make the switch as well. Massive thanks to community member https://github.com/reta;>@reta who implemented this change. What should I do if I still run JDK 8? For JDK 8 and below, you can keep on using Mockito 4. This is similar to if you are using JDK 6, for which you can keep on using Mockito 2. The changes in Mockito 5 (for now) are primarily focused on the latest JDK versions, which means the API differences between Mockito 4 and 5 are minimal. However, over time this will most likely widen, so we do recommend adopting JDK 11 in the future. New type() method on ArgumentMatcher One of our most used public API's for customizing Mockito is the https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/ArgumentMatcher.html;>ArgumentMatcher interface. The interface allows you to define a custom matcher, which you can pass into method arguments to provide more targeted matches. One major shortcoming of the ArgumentMatcher was the lack of varargs support. ... (truncated) Commits https://github.com/mockito/mockito/commit/adf528d173f8b763fcd4fedab245ed485b465211;>adf528d Bump versions.bytebuddy from 1.12.21 to 1.12.22 (https://github-redirect.dependabot.com/mockito/mockito/issues/2864;>#2864) https://github.com/mockito/mockito/commit/2418419a1915bd234332eac2b4d5de85622d4699;>2418419 Bump versions.junitJupiter from 5.9.1 to 5.9.2 (https://github-redirect.dependabot.com/mockito/mockito/issues/2858;>#2858) https://github.com/mockito/mockito/commit/3d40cd51d3982e33f7c2a2670c65d28233ceb66e;>3d40cd5 Bump junit-platform-launcher from 1.9.1 to 1.9.2 (https://github-redirect.dependabot.com/mockito/mockito/issues/2859;>#2859) https://github.com/mockito/mockito/commit/9bec8e3a1a0f57e4baa9b64825d67641e9eb2d5e;>9bec8e3 Bump versions.errorprone
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #745: build(deps): bump netty-bom from 4.1.86.Final to 4.1.87.Final
dependabot[bot] opened a new pull request, #745: URL: https://github.com/apache/plc4x/pull/745 Bumps [netty-bom](https://github.com/netty/netty) from 4.1.86.Final to 4.1.87.Final. Commits https://github.com/netty/netty/commit/53fa91f6f644f24bcd085fbeb64bfec01e8fb61e;>53fa91f [maven-release-plugin] prepare release netty-4.1.87.Final https://github.com/netty/netty/commit/0097c2b72521c422d42bf8c45273db05a7ff068c;>0097c2b Upgrade to latest netty-tcnative release which doesnt link libcrypt (https://github-redirect.dependabot.com/netty/netty/issues/13112;>#13112) https://github.com/netty/netty/commit/b9a2e961a6ff2887ab6057d1eaf0d668d0e43ddf;>b9a2e96 Use defined osmaven version everywhere (https://github-redirect.dependabot.com/netty/netty/issues/13111;>#13111) https://github.com/netty/netty/commit/ba78f17b2b2fffd33f09c06f0af1c199e5a00d3a;>ba78f17 Fix NPE caused by old bundle plugin version (https://github-redirect.dependabot.com/netty/netty/issues/13106;>#13106) https://github.com/netty/netty/commit/05153ac9ff98f45b5dafe679ce8e2cce56803615;>05153ac Bump up os-maven-plugin to 1.7.1 (https://github-redirect.dependabot.com/netty/netty/issues/13107;>#13107) https://github.com/netty/netty/commit/e19860a3f626b07bfbc9dadb682072c685bf0688;>e19860a Create thread dumps for all running JVMs when the build gets cancelled (https://github-redirect.dependabot.com/netty/netty/issues/13100;>#13100) https://github.com/netty/netty/commit/d03f3ed0157e857ebb0bb28d0ddb5439dc181b61;>d03f3ed Add recvmmsg sendmmsg syscall number for loongarch64 (https://github-redirect.dependabot.com/netty/netty/issues/13097;>#13097) https://github.com/netty/netty/commit/e530cd610d17cdaaca7f3adf5e7c8d224571e89c;>e530cd6 Return correct value from SSLSession.getPacketSize() when using native SSL im... https://github.com/netty/netty/commit/fdfbb0441d49f16068903fa85b623790cce889ff;>fdfbb04 Remove Redundant bitwise operations (https://github-redirect.dependabot.com/netty/netty/issues/13094;>#13094) https://github.com/netty/netty/commit/f027fa2df77af7719aa9686659633ee0fc73ebf9;>f027fa2 Upgrade to latest version of JMH (https://github-redirect.dependabot.com/netty/netty/issues/13080;>#13080) Additional commits viewable in https://github.com/netty/netty/compare/netty-4.1.86.Final...netty-4.1.87.Final;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #744: build(deps): bump freemarker from 2.3.31 to 2.3.32
dependabot[bot] opened a new pull request, #744: URL: https://github.com/apache/plc4x/pull/744 Bumps freemarker from 2.3.31 to 2.3.32. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #740: build(deps): bump xmlunit.version from 2.9.0 to 2.9.1
sruehl merged PR #740: URL: https://github.com/apache/plc4x/pull/740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #741: build(deps): bump byte-buddy from 1.12.21 to 1.12.22
sruehl merged PR #741: URL: https://github.com/apache/plc4x/pull/741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #742: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.5.0
sruehl merged PR #742: URL: https://github.com/apache/plc4x/pull/742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #741: build(deps): bump byte-buddy from 1.12.21 to 1.12.22
dependabot[bot] opened a new pull request, #741: URL: https://github.com/apache/plc4x/pull/741 Bumps [byte-buddy](https://github.com/raphw/byte-buddy) from 1.12.21 to 1.12.22. Release notes Sourced from https://github.com/raphw/byte-buddy/releases;>byte-buddy's releases. Byte Buddy 1.12.22 Support MethodHandle and MethodType in Advice.Origin annotation. Support MethodHandles.Lookup in Origin and Advice.Origin annotations. Use modern API for Gradle Android API, if available, to avoid now failing cast. Changelog Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md;>byte-buddy's changelog. Byte Buddy release notes Commits https://github.com/raphw/byte-buddy/commit/641f5a329ea471d7e2808249184e795e18b94874;>641f5a3 [maven-release-plugin] prepare release byte-buddy-1.12.22 https://github.com/raphw/byte-buddy/commit/d732497c77cb5c960b082fbdc9a761461246fddb;>d732497 [release] Release new version https://github.com/raphw/byte-buddy/commit/cc7c5c207cdb1a3e3d9bc4719e071f7f3b1229b8;>cc7c5c2 Adjust internal type hierarchy. https://github.com/raphw/byte-buddy/commit/99e6861754a9cfb3cbe6679280ce18f36119644f;>99e6861 Merge pull request https://github-redirect.dependabot.com/raphw/byte-buddy/issues/1389;>#1389 from LikeTheSalad/master https://github.com/raphw/byte-buddy/commit/6fe8a5c4ab0486b4603b426d60d309e90ce14a99;>6fe8a5c Using debug logs for DependenciesClasspathProvider https://github.com/raphw/byte-buddy/commit/0ba7bd78ed9801e336643fcac7558a545e4e4678;>0ba7bd7 Added class headers https://github.com/raphw/byte-buddy/commit/e8c15a67bc1049ba05f1c9500b4156647dd3b522;>e8c15a6 Using DependenciesClasspathProvider implementations https://github.com/raphw/byte-buddy/commit/6ff15e3fdad2d391d2c75da6ef82de6f4d1db553;>6ff15e3 Created the DependenciesClasspathProvider interface and its implementations https://github.com/raphw/byte-buddy/commit/6a3facab94fae0cd657445f90964398926f1f6e4;>6a3faca Updated dependencies verification metadata https://github.com/raphw/byte-buddy/commit/493eb7d1b71d18d415053add558079fcdca9fd06;>493eb7d Update to latest version. Additional commits viewable in https://github.com/raphw/byte-buddy/compare/byte-buddy-1.12.21...byte-buddy-1.12.22;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #742: build(deps): bump maven-dependency-plugin from 3.1.2 to 3.5.0
dependabot[bot] opened a new pull request, #742: URL: https://github.com/apache/plc4x/pull/742 Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.1.2 to 3.5.0. Commits https://github.com/apache/maven-dependency-plugin/commit/520f8fd6ba4a00a8a1174077d5610aa5ecae7595;>520f8fd [maven-release-plugin] prepare release maven-dependency-plugin-3.5.0 https://github.com/apache/maven-dependency-plugin/commit/4b478d61e1e78f5bddda6d1256f91c357c2561a4;>4b478d6 [MDEP-841] Explicitly start and end tables with Doxia Sinks in report renderers https://github.com/apache/maven-dependency-plugin/commit/799ff97da3130fe8dd1daf9e68405db066584080;>799ff97 [MDEP-831] Remove dependency on commons-lang3 (https://github-redirect.dependabot.com/apache/maven-dependency-plugin/issues/270;>#270) https://github.com/apache/maven-dependency-plugin/commit/68b72723d3ece966078daec13567090b17280216;>68b7272 [MDEP-837] Ignore reformat commit from git blame https://github.com/apache/maven-dependency-plugin/commit/cc082ea7d4af7db78c521d59360d261ffbc1b184;>cc082ea [MDEP-837] Reformat code after parent 38 https://github.com/apache/maven-dependency-plugin/commit/803433bccf1bb4a562d05a6662189fde91184b6d;>803433b [MDEP-837] Upgrade Parent to 38 https://github.com/apache/maven-dependency-plugin/commit/a05a2a4f5ce1e6d9053f6db9b84736e8bbc519b7;>a05a2a4 Bump junit from 4.13 to 4.13.2 in /src/it/projects/tree-verbose-small https://github.com/apache/maven-dependency-plugin/commit/ea2a668dcb21e08c69d42c2cdbcf21483fdb3c01;>ea2a668 remove unused beanutils dependency (https://github-redirect.dependabot.com/apache/maven-dependency-plugin/issues/268;>#268) https://github.com/apache/maven-dependency-plugin/commit/ea43fa6ae8b0504d12d794fdb6ff83e995f6a41a;>ea43fa6 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-dependency-plugin/commit/8fecf8a54af68c7b9cb97f90ac6b9c726e33e5ce;>8fecf8a [maven-release-plugin] prepare release maven-dependency-plugin-3.4.0 Additional commits viewable in https://github.com/apache/maven-dependency-plugin/compare/maven-dependency-plugin-3.1.2...maven-dependency-plugin-3.5.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #740: build(deps): bump xmlunit.version from 2.9.0 to 2.9.1
dependabot[bot] opened a new pull request, #740: URL: https://github.com/apache/plc4x/pull/740 Bumps `xmlunit.version` from 2.9.0 to 2.9.1. Updates `xmlunit-core` from 2.9.0 to 2.9.1 Release notes Sourced from https://github.com/xmlunit/xmlunit/releases;>xmlunit-core's releases. XMLUnit for Java 2.9.1 fixed some AssertJ tests that didn't work on Windows. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/252;>#252 and PR https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/253;>#253 by https://github.com/Boiarshinov;>@Boiarshinov added overloads to ElementSelectors.byXPath that accept a XPathEngine argument. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/255;>#255 added Cyclone DX SBOMs to release artifacts Changelog Sourced from https://github.com/xmlunit/xmlunit/blob/main/RELEASE_NOTES.md;>xmlunit-core's changelog. XMLUnit for Java 2.9.1 - /Released 2023-01-10/ fixed some AssertJ tests that didn't work on Windows. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/252;>#252 and PR https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/253;>#253 by https://github.com/Boiarshinov;>@Boiarshinov added overloads to ElementSelectors.byXPath that accept a XPathEngine argument. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/255;>#255 added Cyclone DX SBOMs to release artifacts Commits https://github.com/xmlunit/xmlunit/commit/9118af20aeaa6b8665be9c13fc84c1fd25b51acd;>9118af2 prepare XMLUnit 2.9.1 https://github.com/xmlunit/xmlunit/commit/c8fcf0a5575af8d434f43a2c051a9814b51df5e3;>c8fcf0a fix remaining javadoc warnings raised by Java 17 https://github.com/xmlunit/xmlunit/commit/f4aa630bb5238dfc8fd963f86eddb8fde459ee72;>f4aa630 next batch of fixed javadoc warnings, just a few hundred left https://github.com/xmlunit/xmlunit/commit/5e53d0fb2c8958cc416bc72cda68fba5be58d714;>5e53d0f chip away on javadoc warnings found by Java 17 https://github.com/xmlunit/xmlunit/commit/78f66d2d7a2490f3b459a586afb132c55c90d3ed;>78f66d2 allow javadocs to be built using Java 17 https://github.com/xmlunit/xmlunit/commit/737789db2aa06029c4ec93d7e293545d0fa2f851;>737789d reference to a third jar is misleading https://github.com/xmlunit/xmlunit/commit/1cced6e34cd225ed2f4dff672bff59a468e70382;>1cced6e provide descriptions for all modules https://github.com/xmlunit/xmlunit/commit/0baf9e9078bdf1f34f92b36b6118b6f5c1bccf02;>0baf9e9 update javadoc plugin, fix new javadoc warnings https://github.com/xmlunit/xmlunit/commit/505f014b13e60ae215473a37f7b0d9587308da8a;>505f014 javadoc warning https://github.com/xmlunit/xmlunit/commit/98dc0be49204fe14823fc7c278e62b211629edaf;>98dc0be really hide cyclonedx plugin when building on Java 7 Additional commits viewable in https://github.com/xmlunit/xmlunit/compare/v2.9.0...v2.9.1;>compare view Updates `xmlunit-matchers` from 2.9.0 to 2.9.1 Release notes Sourced from https://github.com/xmlunit/xmlunit/releases;>xmlunit-matchers's releases. XMLUnit for Java 2.9.1 fixed some AssertJ tests that didn't work on Windows. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/252;>#252 and PR https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/253;>#253 by https://github.com/Boiarshinov;>@Boiarshinov added overloads to ElementSelectors.byXPath that accept a XPathEngine argument. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/255;>#255 added Cyclone DX SBOMs to release artifacts Changelog Sourced from https://github.com/xmlunit/xmlunit/blob/main/RELEASE_NOTES.md;>xmlunit-matchers's changelog. XMLUnit for Java 2.9.1 - /Released 2023-01-10/ fixed some AssertJ tests that didn't work on Windows. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/252;>#252 and PR https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/253;>#253 by https://github.com/Boiarshinov;>@Boiarshinov added overloads to ElementSelectors.byXPath that accept a XPathEngine argument. Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/255;>#255 added Cyclone DX SBOMs to release artifacts Commits https://github.com/xmlunit/xmlunit/commit/9118af20aeaa6b8665be9c13fc84c1fd25b51acd;>9118af2 prepare XMLUnit 2.9.1 https://github.com/xmlunit/xmlunit/commit/c8fcf0a5575af8d434f43a2c051a9814b51df5e3;>c8fcf0a fix remaining javadoc warnings raised by Java 17 https://github.com/xmlunit/xmlunit/commit/f4aa630bb5238dfc8fd963f86eddb8fde459ee72;>f4aa630 next batch of fixed javadoc warnings, just a few hundred left
[GitHub] [plc4x] sruehl merged pull request #737: build(deps): bump karaf-maven-plugin from 4.4.2 to 4.4.3
sruehl merged PR #737: URL: https://github.com/apache/plc4x/pull/737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #739: build(deps): bump maven-surefire-plugin from 3.0.0-M7 to 3.0.0-M8
sruehl merged PR #739: URL: https://github.com/apache/plc4x/pull/739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #738: build(deps): bump jakarta.activation-api from 2.1.0 to 2.1.1
sruehl merged PR #738: URL: https://github.com/apache/plc4x/pull/738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #739: build(deps): bump maven-surefire-plugin from 3.0.0-M7 to 3.0.0-M8
dependabot[bot] opened a new pull request, #739: URL: https://github.com/apache/plc4x/pull/739 Bumps [maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.0.0-M7 to 3.0.0-M8. Commits https://github.com/apache/maven-surefire/commit/54dfdc194d60b11d26943fed09027ddeec9a4c79;>54dfdc1 [maven-release-plugin] prepare release surefire-3.0.0-M8 https://github.com/apache/maven-surefire/commit/c068b121a556028b45632f04dd310e582623487d;>c068b12 [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directo... https://github.com/apache/maven-surefire/commit/0097a41879983b4790299ce1663edd669f321400;>0097a41 [SUREFIRE-1962] Unit test for ProviderInfo#isApplicable https://github.com/apache/maven-surefire/commit/d3dafe4d36b6dd981c399dd816111762213186f3;>d3dafe4 [SUREFIRE-2138] Update JUnit4/JUnit5 versions in ITs https://github.com/apache/maven-surefire/commit/dd707721590b20443cb5aa2395cc736919d18b42;>dd70772 [SUREFIRE-2138] Update JUnit4/JUnit5 versions in docs https://github.com/apache/maven-surefire/commit/6420f7c34e74eafbc0097c70ef860f399a89f4fa;>6420f7c [SUREFIRE-2137] Run JUnitPlatform ITs with latest 5.8.x/5.9.x as well https://github.com/apache/maven-surefire/commit/348bfa119650533cf143137c03bc1e01289bd017;>348bfa1 Disable build on Windows by Jenkins https://github.com/apache/maven-surefire/commit/0c35f44c93c911ac04cc8e9b81e0794aae019796;>0c35f44 [SUREFIRE-2139] Replace EOL JDK18 with JDK19 in build https://github.com/apache/maven-surefire/commit/adfb7f5ce38ff40e45515dfa6c7d960d4a027a6e;>adfb7f5 [SUREFIRE-2139] Raise plexus-java to 1.1.2 for full Java 19 bytecode support https://github.com/apache/maven-surefire/commit/4f4ac976181e4f9303acf6476884544218f03e2e;>4f4ac97 [SUREFIRE-2117] Include package + outer classes in XML report of https://github.com/Nested;>@Nested Additional commits viewable in https://github.com/apache/maven-surefire/compare/surefire-3.0.0-M7...surefire-3.0.0-M8;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #738: build(deps): bump jakarta.activation-api from 2.1.0 to 2.1.1
dependabot[bot] opened a new pull request, #738: URL: https://github.com/apache/plc4x/pull/738 Bumps [jakarta.activation-api](https://github.com/jakartaee/jaf-api) from 2.1.0 to 2.1.1. Commits https://github.com/jakartaee/jaf-api/commit/6c7dd2d757f6a705048c8b4e074c6f741dee110d;>6c7dd2d Prepare release jakarta.activation:jakarta.activation-api:2.1.1 https://github.com/jakartaee/jaf-api/commit/9e62ccbb83da4865e2ef062434af47a492b58673;>9e62ccb fix version string https://github.com/jakartaee/jaf-api/commit/024f612572a470c8ec14e94a9be06b0a1e2bd12f;>024f612 minor tweak to osgi requirements https://github.com/jakartaee/jaf-api/commit/7894db2871c0c7f7d0fbc7eca6a9814d6054f633;>7894db2 update build plugins, remove unused ones https://github.com/jakartaee/jaf-api/commit/f25c309fa3a54bb41070bd1b436c7d149cb871ab;>f25c309 update pointers in pom to the new location https://github.com/jakartaee/jaf-api/commit/dc32a44ea2eb0293fb5ce6bf108ec93ec15ebcd1;>dc32a44 fix verification job trigger https://github.com/jakartaee/jaf-api/commit/64b41f6c31c997de3d8ec6cced9b3b6c51394ec0;>64b41f6 try api jar loader when loading a provider from the system property https://github.com/jakartaee/jaf-api/commit/0c7bfebd55f7cf4ea681f2f8f176e1dd6c22904e;>0c7bfeb Bump nokogiri from 1.13.9 to 1.13.10 in /www https://github.com/jakartaee/jaf-api/commit/35dc5da5a1d51bf4681adbb819765cd76c0e10ed;>35dc5da remove unused references to implementation classes https://github.com/jakartaee/jaf-api/commit/2de77798bfc2c16b00f37ff39862a3455f8fe869;>2de7779 add info about 2.1.1 release Additional commits viewable in https://github.com/jakartaee/jaf-api/compare/2.1.0...2.1.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #737: build(deps): bump karaf-maven-plugin from 4.4.2 to 4.4.3
dependabot[bot] opened a new pull request, #737: URL: https://github.com/apache/plc4x/pull/737 Bumps karaf-maven-plugin from 4.4.2 to 4.4.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request, #51: chore(deps): bump maven-project-info-reports-plugin from 3.4.1 to 3.4.2
dependabot[bot] opened a new pull request, #51: URL: https://github.com/apache/plc4x-build-tools/pull/51 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.4.1 to 3.4.2. Commits https://github.com/apache/maven-project-info-reports-plugin/commit/c1eb1d4bcd28f260762045cfa9eea1d53539a58f;>c1eb1d4 [maven-release-plugin] prepare release maven-project-info-reports-plugin-3.4.2 https://github.com/apache/maven-project-info-reports-plugin/commit/dee3a29c0248c497a9229043490b70cac17b8c12;>dee3a29 [MPIR-425] Verbatim content should be rendered as plain text https://github.com/apache/maven-project-info-reports-plugin/commit/88f2f7690059d71bc4def3a3e4db0bad0cae3e80;>88f2f76 [MPIR-427] Explicitly start and end tables with Doxia Sinks in report renderers https://github.com/apache/maven-project-info-reports-plugin/commit/7f80826d74ffbbc66bad4eaff85c0f4c236fd9d0;>7f80826 [MPIR-426] Remove Apache Buildr from Dependency Information Report https://github.com/apache/maven-project-info-reports-plugin/commit/6f03e00075792c1b0d477f4013713848c03fb063;>6f03e00 update Reproducible Builds badge link https://github.com/apache/maven-project-info-reports-plugin/commit/f069182ac218e3696a699c241b2ebf5233c4dd3f;>f069182 Fix typo https://github.com/apache/maven-project-info-reports-plugin/commit/6ca70bc3317a93a5f9c51e8281bd9f128c0bf120;>6ca70bc [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.4.1...maven-project-info-reports-plugin-3.4.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request, #50: chore(deps): bump maven-dependency-plugin from 3.4.0 to 3.5.0
dependabot[bot] opened a new pull request, #50: URL: https://github.com/apache/plc4x-build-tools/pull/50 Bumps [maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.4.0 to 3.5.0. Commits https://github.com/apache/maven-dependency-plugin/commit/520f8fd6ba4a00a8a1174077d5610aa5ecae7595;>520f8fd [maven-release-plugin] prepare release maven-dependency-plugin-3.5.0 https://github.com/apache/maven-dependency-plugin/commit/4b478d61e1e78f5bddda6d1256f91c357c2561a4;>4b478d6 [MDEP-841] Explicitly start and end tables with Doxia Sinks in report renderers https://github.com/apache/maven-dependency-plugin/commit/799ff97da3130fe8dd1daf9e68405db066584080;>799ff97 [MDEP-831] Remove dependency on commons-lang3 (https://github-redirect.dependabot.com/apache/maven-dependency-plugin/issues/270;>#270) https://github.com/apache/maven-dependency-plugin/commit/68b72723d3ece966078daec13567090b17280216;>68b7272 [MDEP-837] Ignore reformat commit from git blame https://github.com/apache/maven-dependency-plugin/commit/cc082ea7d4af7db78c521d59360d261ffbc1b184;>cc082ea [MDEP-837] Reformat code after parent 38 https://github.com/apache/maven-dependency-plugin/commit/803433bccf1bb4a562d05a6662189fde91184b6d;>803433b [MDEP-837] Upgrade Parent to 38 https://github.com/apache/maven-dependency-plugin/commit/a05a2a4f5ce1e6d9053f6db9b84736e8bbc519b7;>a05a2a4 Bump junit from 4.13 to 4.13.2 in /src/it/projects/tree-verbose-small https://github.com/apache/maven-dependency-plugin/commit/ea2a668dcb21e08c69d42c2cdbcf21483fdb3c01;>ea2a668 remove unused beanutils dependency (https://github-redirect.dependabot.com/apache/maven-dependency-plugin/issues/268;>#268) https://github.com/apache/maven-dependency-plugin/commit/ea43fa6ae8b0504d12d794fdb6ff83e995f6a41a;>ea43fa6 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-dependency-plugin/compare/maven-dependency-plugin-3.4.0...maven-dependency-plugin-3.5.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] splatch merged pull request #691: Make sure s7 packet len is specified to avoid serialization errors
splatch merged PR #691: URL: https://github.com/apache/plc4x/pull/691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #729: build(deps): bump checker-qual from 3.28.0 to 3.29.0
sruehl merged PR #729: URL: https://github.com/apache/plc4x/pull/729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #736: build(deps): bump error_prone_annotations from 2.17.0 to 2.18.0
sruehl merged PR #736: URL: https://github.com/apache/plc4x/pull/736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #729: build(deps): bump checker-qual from 3.28.0 to 3.29.0
sruehl commented on PR #729: URL: https://github.com/apache/plc4x/pull/729#issuecomment-1378579443 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #735: build(deps): bump junit.jupiter.version from 5.9.1 to 5.9.2
sruehl merged PR #735: URL: https://github.com/apache/plc4x/pull/735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #736: build(deps): bump error_prone_annotations from 2.17.0 to 2.18.0
dependabot[bot] opened a new pull request, #736: URL: https://github.com/apache/plc4x/pull/736 Bumps [error_prone_annotations](https://github.com/google/error-prone) from 2.17.0 to 2.18.0. Release notes Sourced from https://github.com/google/error-prone/releases;>error_prone_annotations's releases. Error Prone 2.18.0 New Checkers: https://errorprone.info/bugpattern/InjectOnBugCheckers;>InjectOnBugCheckers https://errorprone.info/bugpattern/LabelledBreakTarget;>LabelledBreakTarget https://errorprone.info/bugpattern/UnusedLabel;>UnusedLabel https://errorprone.info/bugpattern/YodaCondition;>YodaCondition Fixes issues: https://github-redirect.dependabot.com/google/error-prone/issues/1650;>#1650, https://github-redirect.dependabot.com/google/error-prone/issues/2706;>#2706, https://github-redirect.dependabot.com/google/error-prone/issues/3404;>#3404, https://github-redirect.dependabot.com/google/error-prone/issues/3493;>#3493, https://github-redirect.dependabot.com/google/error-prone/issues/3504;>#3504, https://github-redirect.dependabot.com/google/error-prone/issues/3519;>#3519, https://github-redirect.dependabot.com/google/error-prone/issues/3579;>#3579, https://github-redirect.dependabot.com/google/error-prone/issues/3610;>#3610, https://github-redirect.dependabot.com/google/error-prone/issues/3632;>#3632, https://github-redirect.dependabot.com/google/error-prone/issues/3638;>#3638, https://github-redirect.dependabot.com/google/error-prone/i ssues/3645">#3645, https://github-redirect.dependabot.com/google/error-prone/issues/3646;>#3646, https://github-redirect.dependabot.com/google/error-prone/issues/3652;>#3652, https://github-redirect.dependabot.com/google/error-prone/issues/3690;>#3690 Full Changelog: https://github.com/google/error-prone/compare/v2.17.0...v2.18.0;>https://github.com/google/error-prone/compare/v2.17.0...v2.18.0 Commits https://github.com/google/error-prone/commit/34730decfeb81a35909db858399387f81c06c01f;>34730de Release Error Prone 2.18.0 https://github.com/google/error-prone/commit/ee1e7778d3e90d27303d9666c87b360cea6d4bf0;>ee1e777 Remove DoNoCall flags for checking Thread.run and various getClass meth... https://github.com/google/error-prone/commit/bb9ede9f250660199a718b36407cffec36b2be46;>bb9ede9 Delete dependabot.yml https://github.com/google/error-prone/commit/7f459e14cd74f9a126c5f5edc7311be49a7e4421;>7f459e1 Refaster: support method invocation type argument inlining https://github.com/google/error-prone/commit/a57309b0183c0c70f6afe7bceea3678b62c4791b;>a57309b Add a check to reverse Yoda conditions. https://github.com/google/error-prone/commit/181f9918bc4978a8999765e2961d1782ad452b5c;>181f991 Use ASTHelpers.enclosingClass. https://github.com/google/error-prone/commit/360ed99da20a1e888f6b6bc407f96d1894651793;>360ed99 Don't generate a Suppression section that recommends `@SuppressWarnings(Ch... https://github.com/google/error-prone/commit/c06c7b8b6e90fa709bca8089a881db6a999ea811;>c06c7b8 Look for infinite recursion in the first statement of multi-statement methods. https://github.com/google/error-prone/commit/0f5753f67b89d77c0fa1eac209625b953059c7bb;>0f5753f Reverse Yoda conditions in EP. https://github.com/google/error-prone/commit/f36a502b5f934639a60107ec6a0a1d6f54edaa51;>f36a502 Make MemoizeConstantVisitorStateLookups check suppressible Additional commits viewable in https://github.com/google/error-prone/compare/v2.17.0...v2.18.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #735: build(deps): bump junit.jupiter.version from 5.9.1 to 5.9.2
dependabot[bot] opened a new pull request, #735: URL: https://github.com/apache/plc4x/pull/735 Bumps `junit.jupiter.version` from 5.9.1 to 5.9.2. Updates `junit-jupiter` from 5.9.1 to 5.9.2 Release notes Sourced from https://github.com/junit-team/junit5/releases;>junit-jupiter's releases. JUnit 5.9.2 = Platform 1.9.2 + Jupiter 5.9.2 + Vintage 5.9.2 See http://junit.org/junit5/docs/5.9.2/release-notes/;>Release Notes. Commits https://github.com/junit-team/junit5/commit/8ed3c66c7eb20b835cf92f50a7bf8830838c462e;>8ed3c66 Release 5.9.2 https://github.com/junit-team/junit5/commit/742f99fcce6d8b8fbd38c7f541c55bdda771e220;>742f99f Prepare 5.9.2 release notes https://github.com/junit-team/junit5/commit/a9a3cf5fb75ad9adf8c197224981226db8f41181;>a9a3cf5 Fix bug and polish contribution https://github.com/junit-team/junit5/commit/825ea38857bff2dcbc200c6ceb7972dbc89482b0;>825ea38 Introduce new @MethodSource syntax to differentiate overloaded local factor... https://github.com/junit-team/junit5/commit/0c40f5ef057c90a8d4b2249dd9a0b6e289426424;>0c40f5e Polish Javadoc https://github.com/junit-team/junit5/commit/7d54016421d611a13db8196ea9625dfe1d9036c8;>7d54016 Update codecov-action https://github.com/junit-team/junit5/commit/bfeeac4d4142a3680737626a0ccdb9a708cabb2a;>bfeeac4 Remove duplicate copyright comment https://github.com/junit-team/junit5/commit/b0d9083315426b69d2bf38153987cdeb83460257;>b0d9083 Format integration test projects with Spotless as well https://github.com/junit-team/junit5/commit/c4ed325cb2ff825ecd0bda3870cf8444bdf646f0;>c4ed325 Update copyright https://github.com/junit-team/junit5/commit/0e3a1d32e504c63a09dbafc8c1926b66df417774;>0e3a1d3 Update upload-artifact action Additional commits viewable in https://github.com/junit-team/junit5/compare/r5.9.1...r5.9.2;>compare view Updates `junit-jupiter-api` from 5.9.1 to 5.9.2 Release notes Sourced from https://github.com/junit-team/junit5/releases;>junit-jupiter-api's releases. JUnit 5.9.2 = Platform 1.9.2 + Jupiter 5.9.2 + Vintage 5.9.2 See http://junit.org/junit5/docs/5.9.2/release-notes/;>Release Notes. Commits https://github.com/junit-team/junit5/commit/8ed3c66c7eb20b835cf92f50a7bf8830838c462e;>8ed3c66 Release 5.9.2 https://github.com/junit-team/junit5/commit/742f99fcce6d8b8fbd38c7f541c55bdda771e220;>742f99f Prepare 5.9.2 release notes https://github.com/junit-team/junit5/commit/a9a3cf5fb75ad9adf8c197224981226db8f41181;>a9a3cf5 Fix bug and polish contribution https://github.com/junit-team/junit5/commit/825ea38857bff2dcbc200c6ceb7972dbc89482b0;>825ea38 Introduce new @MethodSource syntax to differentiate overloaded local factor... https://github.com/junit-team/junit5/commit/0c40f5ef057c90a8d4b2249dd9a0b6e289426424;>0c40f5e Polish Javadoc https://github.com/junit-team/junit5/commit/7d54016421d611a13db8196ea9625dfe1d9036c8;>7d54016 Update codecov-action https://github.com/junit-team/junit5/commit/bfeeac4d4142a3680737626a0ccdb9a708cabb2a;>bfeeac4 Remove duplicate copyright comment https://github.com/junit-team/junit5/commit/b0d9083315426b69d2bf38153987cdeb83460257;>b0d9083 Format integration test projects with Spotless as well https://github.com/junit-team/junit5/commit/c4ed325cb2ff825ecd0bda3870cf8444bdf646f0;>c4ed325 Update copyright https://github.com/junit-team/junit5/commit/0e3a1d32e504c63a09dbafc8c1926b66df417774;>0e3a1d3 Update upload-artifact action Additional commits viewable in https://github.com/junit-team/junit5/compare/r5.9.1...r5.9.2;>compare view Updates `junit-jupiter-engine` from 5.9.1 to 5.9.2 Release notes Sourced from https://github.com/junit-team/junit5/releases;>junit-jupiter-engine's releases. JUnit 5.9.2 = Platform 1.9.2 + Jupiter 5.9.2 + Vintage 5.9.2 See http://junit.org/junit5/docs/5.9.2/release-notes/;>Release Notes. Commits https://github.com/junit-team/junit5/commit/8ed3c66c7eb20b835cf92f50a7bf8830838c462e;>8ed3c66 Release 5.9.2 https://github.com/junit-team/junit5/commit/742f99fcce6d8b8fbd38c7f541c55bdda771e220;>742f99f Prepare 5.9.2 release notes https://github.com/junit-team/junit5/commit/a9a3cf5fb75ad9adf8c197224981226db8f41181;>a9a3cf5 Fix bug and polish contribution https://github.com/junit-team/junit5/commit/825ea38857bff2dcbc200c6ceb7972dbc89482b0;>825ea38 Introduce new @MethodSource syntax to differentiate overloaded local factor... https://github.com/junit-team/junit5/commit/0c40f5ef057c90a8d4b2249dd9a0b6e289426424;>0c40f5e Polish Javadoc https://github.com/junit-team/junit5/commit/7d54016421d611a13db8196ea9625dfe1d9036c8;>7d54016 Update codecov-action https://github.com/junit-team/junit5/commit/bfeeac4d4142a3680737626a0ccdb9a708cabb2a;>bfeeac4 Remove duplicate copyright comment
[GitHub] [plc4x] sruehl merged pull request #734: build(deps): bump gson from 2.10 to 2.10.1
sruehl merged PR #734: URL: https://github.com/apache/plc4x/pull/734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #733: build(deps): bump assertj-core from 3.24.0 to 3.24.1
sruehl merged PR #733: URL: https://github.com/apache/plc4x/pull/733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #545: feat(plc4go): Implementing the correct reading of BOOL types
chrisdutz commented on PR #545: URL: https://github.com/apache/plc4x/pull/545#issuecomment-1375345033 Always happy to help educate :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #734: build(deps): bump gson from 2.10 to 2.10.1
dependabot[bot] opened a new pull request, #734: URL: https://github.com/apache/plc4x/pull/734 Bumps [gson](https://github.com/google/gson) from 2.10 to 2.10.1. Release notes Sourced from https://github.com/google/gson/releases;>gson's releases. Gson 2.10.1 This is technically a minor release rather than a patch release because there is one small API change: a new JsonObject.isEmpty() method. What's Changed: User-Visible Changes Added JsonObject method isEmpty() by https://github.com/dhoard;>@dhoard in https://github-redirect.dependabot.com/google/gson/pull/2233;>google/gson#2233 Fix non-threadsafe creation of adapter for type with cyclic dependency by https://github.com/Marcono1234;>@Marcono1234 in https://github-redirect.dependabot.com/google/gson/pull/1832;>google/gson#1832 Remove EOFException special casing of JsonStreamParser.next() by https://github.com/Marcono1234;>@Marcono1234 in https://github-redirect.dependabot.com/google/gson/pull/2281;>google/gson#2281 Improve exception message for duplicate field names by https://github.com/Marcono1234;>@Marcono1234 in https://github-redirect.dependabot.com/google/gson/pull/2251;>google/gson#2251 Fix the javadoc of JsonDeserializer.deserialize() by https://github.com/MaicolAntali;>@MaicolAntali in https://github-redirect.dependabot.com/google/gson/pull/2243;>google/gson#2243 Bump os-maven-plugin from 1.7.0 to 1.7.1 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/google/gson/pull/2235;>google/gson#2235 Bump jackson-databind from 2.13.4.2 to 2.14.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/google/gson/pull/2234;>google/gson#2234 Bump maven-release-plugin from 3.0.0-M6 to 3.0.0-M7 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/google/gson/pull/2232;>google/gson#2232 Bump japicmp-maven-plugin from 0.16.0 to 0.17.1 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/google/gson/pull/2238;>google/gson#2238 Bump jackson-databind from 2.14.0 to 2.14.1 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/google/gson/pull/2241;>google/gson#2241 Bump bnd-maven-plugin from 6.3.1 to 6.4.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/google/gson/pull/2245;>google/gson#2245 Site Documentation and Maintenance Changes (these were already visible) Add troubleshooting guide by https://github.com/Marcono1234;>@Marcono1234 in https://github-redirect.dependabot.com/google/gson/pull/2285;>google/gson#2285 Replace custom user guide header anchors by https://github.com/Marcono1234;>@Marcono1234 in https://github-redirect.dependabot.com/google/gson/pull/2289;>google/gson#2289 Improve variable names in user guide by https://github.com/Marcono1234;>@Marcono1234 in https://github-redirect.dependabot.com/google/gson/pull/2290;>google/gson#2290 Add 2.10 changes to CHANGELOG; minor release follow-ups by https://github.com/Marcono1234;>@Marcono1234 in https://github-redirect.dependabot.com/google/gson/pull/2229;>google/gson#2229 Mention in CHANGELOG that GitHub Releases are used in the future by https://github.com/Marcono1234;>@Marcono1234 in https://github-redirect.dependabot.com/google/gson/pull/2230;>google/gson#2230 GitHub Workflows security hardening by https://github.com/sashashura;>@sashashura in https://github-redirect.dependabot.com/google/gson/pull/2274;>google/gson#2274 Other Changes Making consistent prefixs in PerformanceTest by https://github.com/CirQ;>@CirQ in https://github-redirect.dependabot.com/google/gson/pull/1760;>google/gson#1760 Adjust version numbers and a test to conform to the SemVer spec. by https://github.com/eamonnmcmanus;>@eamonnmcmanus in https://github-redirect.dependabot.com/google/gson/pull/2237;>google/gson#2237 Remove covered condition in JsonNull.equals() by https://github.com/MaicolAntali;>@MaicolAntali in https://github-redirect.dependabot.com/google/gson/pull/2271;>google/gson#2271 Remove the final keyword from private method by https://github.com/MaicolAntali;>@MaicolAntali in https://github-redirect.dependabot.com/google/gson/pull/2276;>google/gson#2276 Code cleanup by https://github.com/MaicolAntali;>@MaicolAntali in https://github-redirect.dependabot.com/google/gson/pull/2282;>google/gson#2282 Unnecessary unboxing at JsonPrimitive.getAsBoolean() by https://github.com/MaicolAntali;>@MaicolAntali in https://github-redirect.dependabot.com/google/gson/pull/2277;>google/gson#2277 Rewrite the testParsingDatesFormattedWithSystemLocale(), Fix https://github-redirect.dependabot.com/google/gson/issues/2199;>#2199 by https://github.com/MaicolAntali;>@MaicolAntali in https://github-redirect.dependabot.com/google/gson/pull/2287;>google/gson#2287 Port tests
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #733: build(deps): bump assertj-core from 3.24.0 to 3.24.1
dependabot[bot] opened a new pull request, #733: URL: https://github.com/apache/plc4x/pull/733 Bumps assertj-core from 3.24.0 to 3.24.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] hongjinlin commented on pull request #545: feat(plc4go): Implementing the correct reading of BOOL types
hongjinlin commented on PR #545: URL: https://github.com/apache/plc4x/pull/545#issuecomment-1375071236 > In general, the changes look good, however you manually seem to have edited generated code, so the changes will get lost the next time the maven build is executed. Hi Chris, Thank you very much for reviewing the code. I have a revert commit(https://github.com/apache/plc4x/commit/8a793e26d8b24060ee657d7ca9e6114d89c724a1) of this commit(https://github.com/apache/plc4x/commit/17d7f765c670f86c3fd110f010a3faafe8ee1c5a) after Ben remind me that the Golang build failed after my push, sorry for that. The reason the Golang build failed is just what you said I edited generated file directly. But don’t worry I will be familiar with the code generation and have a PR for that as soon as possible. Jinlin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz merged pull request #732: fix(plc4j/modbus): Cleanup of ModbusTag
chrisdutz merged PR #732: URL: https://github.com/apache/plc4x/pull/732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] nielsbasjes commented on pull request #732: fix(plc4j/modbus): Cleanup of ModbusTag
nielsbasjes commented on PR #732: URL: https://github.com/apache/plc4x/pull/732#issuecomment-1374852494 Usually I'm happy to contribute. Right now I would like to focus on the actual application code I'm building (in Java). So currently I won't be digging in to the Go/C/Rust code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #732: fix(plc4j/modbus): Cleanup of ModbusTag
chrisdutz commented on PR #732: URL: https://github.com/apache/plc4x/pull/732#issuecomment-1374851509 Thank you for those changes :-) And I guess ... if you would like to get started in Plc4go, I would be happy to assist you ... PLC4C right now is probably not really worth the effort. It's a pretty "experimental" thing which might even be replaced by PLC4Rust once that's done. If you're not interested, no worries :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] nielsbasjes commented on pull request #732: fix(plc4j/modbus): Cleanup of ModbusTag
nielsbasjes commented on PR #732: URL: https://github.com/apache/plc4x/pull/732#issuecomment-1374851037 I have put up some additional changes with a getAddressStringPrefix() method. About the C and Go code ... I have never written any Go code yet and the last time I touched C/C++ was > 20 years ago. At this point I don't even know the basics of the build systems that are used (I assume things have changed since 2003). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #732: fix(plc4j/modbus): Cleanup of ModbusTag
chrisdutz commented on PR #732: URL: https://github.com/apache/plc4x/pull/732#issuecomment-1374845489 And just asking ... would you feel able to do the same for the PLC4Go and/or PLC4C implementation? We're trying to keep them as in-sync as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] nielsbasjes opened a new pull request, #732: fix(plc4j/modbus): Cleanup of ModbusTag
nielsbasjes opened a new pull request, #732: URL: https://github.com/apache/plc4x/pull/732 This is my proposed set of (what I think are) improvements for the ModbusTag code. Summary: - The equals and hashcode were incorrect because the name of the actual class also matters. - My take on reducing the confusion around the -1 offset and the code complexity around all of this: - Simplified the code for readability - There is now a getLogicalAddress which returns the address the user configured. - The getAddressString returns a string that parses (which was not the case) AND yields an identical new tag when parsed (which was not the case: was shifted by 1 most of the time). - A more extensive set of tests that verifies all of this and ensures all supported formats for all tags yield the correct tag that is identical regardless of the used format. Looking forward to your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on pull request #545: feat(plc4go): Implementing the correct reading of BOOL types
chrisdutz commented on PR #545: URL: https://github.com/apache/plc4x/pull/545#issuecomment-1374593134 In general, the changes look good, however you manually seem to have edited generated code, so the changes will get lost the next time the maven build is executed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #545: feat(plc4go): Implementing the correct reading of BOOL types
chrisdutz commented on code in PR #545:
URL: https://github.com/apache/plc4x/pull/545#discussion_r1064040985
##
plc4go/protocols/modbus/readwrite/model/DataItem.go:
##
@@ -24,30 +24,48 @@ import (
"github.com/apache/plc4x/plc4go/spi/utils"
"github.com/apache/plc4x/plc4go/spi/values"
"github.com/pkg/errors"
+ "math"
)
// Code generated by code-generation. DO NOT EDIT.
Review Comment:
I hope you read this line and didn't manually edit this file ... because the
next time you'll run the full maven build these changes are going to be
replaced with the old values.
##
plc4go/protocols/modbus/readwrite/ParserHelper.go:
##
@@ -40,7 +40,7 @@ func (m ModbusParserHelper) Parse(typeName string, arguments
[]string, io utils.
if err != nil {
return nil, errors.Wrap(err, "Error parsing")
}
- return model.DataItemParse(io, dataType, numberOfValues)
+ return model.DataItemParse(io, dataType, numberOfValues, 0)
Review Comment:
This is a generated file and will be replaced by an updated version,
effectively reverting your changes the next time "mvn install" is executed in
the parent.
##
plc4go/protocols/modbus/readwrite/XmlParserHelper.go:
##
@@ -51,7 +51,7 @@ func (m ModbusXmlParserHelper) Parse(typeName string,
xmlString string, parserAr
return nil, err
}
numberOfValues := uint16(parsedUint1)
- return
model.DataItemParse(utils.NewXmlReadBuffer(strings.NewReader(xmlString)),
dataType, numberOfValues)
+ return
model.DataItemParse(utils.NewXmlReadBuffer(strings.NewReader(xmlString)),
dataType, numberOfValues, 0)
Review Comment:
This is a generated file and will be replaced by an updated version,
effectively reverting your changes the next time "mvn install" is executed in
the parent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #545: feat(plc4go): Implementing the correct reading of BOOL types
chrisdutz commented on code in PR #545:
URL: https://github.com/apache/plc4x/pull/545#discussion_r1064040882
##
plc4go/protocols/modbus/readwrite/model/DataItem.go:
##
@@ -24,30 +24,48 @@ import (
"github.com/apache/plc4x/plc4go/spi/utils"
"github.com/apache/plc4x/plc4go/spi/values"
"github.com/pkg/errors"
+ "math"
)
// Code generated by code-generation. DO NOT EDIT.
-func DataItemParse(readBuffer utils.ReadBuffer, dataType ModbusDataType,
numberOfValues uint16) (api.PlcValue, error) {
+func DataItemParse(readBuffer utils.ReadBuffer, dataType ModbusDataType,
numberOfValues uint16, offset uint16) (api.PlcValue, error) {
readBuffer.PullContext("DataItem")
switch {
case dataType == ModbusDataType_BOOL && numberOfValues == uint16(1): //
BOOL
- // Reserved Field (Just skip the bytes)
- if _, _err := readBuffer.ReadUint16("reserved", 15); _err !=
nil {
- return nil, errors.Wrap(_err, "Error parsing reserved
field")
- }
-
- // Simple Field (value)
- value, _valueErr := readBuffer.ReadBit("value")
- if _valueErr != nil {
- return nil, errors.Wrap(_valueErr, "Error parsing
'value' field")
+ _numberOfValues := uint16(math.Ceil(float64((offset +
numberOfValues)) / float64(16)))
Review Comment:
In this branch "numberOfValues" is always 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] chrisdutz commented on a diff in pull request #545: feat(plc4go): Implementing the correct reading of BOOL types
chrisdutz commented on code in PR #545:
URL: https://github.com/apache/plc4x/pull/545#discussion_r1064040681
##
plc4go/examples/read/hello_world_plc4go_read.go:
##
@@ -31,7 +31,7 @@ func main() {
drivers.RegisterModbusTcpDriver(driverManager)
// Get a connection to a remote PLC
- crc := driverManager.GetConnection("modbus-tcp://192.168.23.30")
+ crc := driverManager.GetConnection("modbus-tcp://192.168.10.180")
Review Comment:
We should probably externalize this because every one is probably going to
have the device at a different IP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x] hongjinlin commented on pull request #545: feat(plc4go): Implementing the correct reading of BOOL types
hongjinlin commented on PR #545: URL: https://github.com/apache/plc4x/pull/545#issuecomment-1374359457 @chrisdutz Hi Chris, I have updated it, and have a commit([17d7f7](https://github.com/apache/plc4x/commit/17d7f765c670f86c3fd110f010a3faafe8ee1c5a)) about it, please review it when you have time. Jinlin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #730: build(deps): bump assertj-core from 3.23.1 to 3.24.0
sruehl merged PR #730: URL: https://github.com/apache/plc4x/pull/730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] dependabot[bot] opened a new pull request, #730: build(deps): bump assertj-core from 3.23.1 to 3.24.0
dependabot[bot] opened a new pull request, #730: URL: https://github.com/apache/plc4x/pull/730 Bumps assertj-core from 3.23.1 to 3.24.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #728: build(deps): bump github.com/schollz/progressbar/v3 from 3.12.2 to 3.13.0 in /plc4go
sruehl merged PR #728: URL: https://github.com/apache/plc4x/pull/728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl commented on pull request #728: build(deps): bump github.com/schollz/progressbar/v3 from 3.12.2 to 3.13.0 in /plc4go
sruehl commented on PR #728: URL: https://github.com/apache/plc4x/pull/728#issuecomment-1372071255 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x] sruehl merged pull request #726: build(deps): bump byte-buddy from 1.12.20 to 1.12.21
sruehl merged PR #726: URL: https://github.com/apache/plc4x/pull/726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
