[GitHub] [storm] bipinprasad opened a new pull request, #3510: [STORM-3884] Update calcite to 1.16.0
bipinprasad opened a new pull request, #3510: URL: https://github.com/apache/storm/pull/3510 ## What is the purpose of the change *Dependabot recommendation is to bump up calcite to 1.32.0, however this is an intermediate step that compiles* ## How was the change tested *build and run tests* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3509: [STORM-3884] Bump calcite-core from 1.14.0 to 1.32.0
bipinprasad opened a new pull request, #3509: URL: https://github.com/apache/storm/pull/3509 ## What is the purpose of the change *Recommended by Dependabot - however that PR fails to build* ## How was the change tested *mvn test* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] xiayingfeng closed pull request #3435: Improve MAVEN build Performance
xiayingfeng closed pull request #3435: Improve MAVEN build Performance URL: https://github.com/apache/storm/pull/3435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] vesense merged pull request #3508: [hotfix] fix typo
vesense merged PR #3508: URL: https://github.com/apache/storm/pull/3508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] wuyouwuyoulian opened a new pull request, #3508: [hotfix] fix typo
wuyouwuyoulian opened a new pull request, #3508: URL: https://github.com/apache/storm/pull/3508 ## What is the purpose of the change fix typo ## How was the change tested fix typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] skysiders commented on pull request #3506: STORM-3888 HdfsBlobStoreFile set wrong permission for file
skysiders commented on PR #3506: URL: https://github.com/apache/storm/pull/3506#issuecomment-1375017907 Hi @bipinprasad , could you please have a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] vesense merged pull request #3505: [STORM-3887] Add AWS Kafka command processor
vesense merged PR #3505: URL: https://github.com/apache/storm/pull/3505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] ScottBrenner commented on pull request #35: Update meetups.yml
ScottBrenner commented on PR #35: URL: https://github.com/apache/storm-site/pull/35#issuecomment-1374223661 @bipinprasad please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] dependabot[bot] closed pull request #3504: [STORM-3889] Bump snakeyaml from 1.26 to 1.32
dependabot[bot] closed pull request #3504: [STORM-3889] Bump snakeyaml from 1.26 to 1.32 URL: https://github.com/apache/storm/pull/3504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] dependabot[bot] commented on pull request #3504: [STORM-3889] Bump snakeyaml from 1.26 to 1.32
dependabot[bot] commented on PR #3504: URL: https://github.com/apache/storm/pull/3504#issuecomment-1372429246 Looks like org.yaml:snakeyaml is no longer updatable, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3504: [STORM-3889] Bump snakeyaml from 1.26 to 1.32
bipinprasad commented on PR #3504: URL: https://github.com/apache/storm/pull/3504#issuecomment-1372428506 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3507: [STORM-3889] Bump snakeyaml from 1.26 to 1.32
bipinprasad merged PR #3507: URL: https://github.com/apache/storm/pull/3507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3497: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15
bipinprasad commented on code in PR #3497: URL: https://github.com/apache/storm/pull/3497#discussion_r1061040175 ## external/storm-mqtt/pom.xml: ## @@ -73,7 +73,7 @@ org.fusesource.mqtt-client mqtt-client -1.10 +1.15 Review Comment: Also Update the DEPENDENCY and LICENSE files so that the build will go to success. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3497: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15
bipinprasad commented on code in PR #3497: URL: https://github.com/apache/storm/pull/3497#discussion_r1061039904 ## external/storm-mqtt/pom.xml: ## @@ -13,8 +14,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ---> -http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +-->http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> Review Comment: Here as well: a new line after the end of the copyright comment - for consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3497: fix(sec): upgrade org.fusesource.mqtt-client:mqtt-client to 1.15
bipinprasad commented on code in PR #3497: URL: https://github.com/apache/storm/pull/3497#discussion_r1061039453 ## examples/storm-mqtt-examples/pom.xml: ## @@ -13,9 +14,7 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. ---> - -http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +-->http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> Review Comment: Can you insert a new line after the comment end to be consistent with the other pom files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3507: [STORM-3889] Bump snakeyaml from 1.26 to 1.32
bipinprasad opened a new pull request, #3507: URL: https://github.com/apache/storm/pull/3507 ## What is the purpose of the change *Dependabot recommendation* ## How was the change tested *Run unit and integration test* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] skysiders opened a new pull request, #3506: STORM-3888 HdfsBlobStoreFile set wrong permission for file
skysiders opened a new pull request, #3506:
URL: https://github.com/apache/storm/pull/3506
```java
public OutputStream getOutputStream() throws IOException {
FsPermission fileperms = new FsPermission(BLOBSTORE_FILE_PERMISSION);
try {
out = fileSystem.create(path, (short)
this.getMetadata().get_replication_factor());
fileSystem.setPermission(path, fileperms);
fileSystem.setReplication(path, (short)
this.getMetadata().get_replication_factor());
} catch (IOException e) {
..
out = fileSystem.create(path, (short)
this.getMetadata().get_replication_factor());
fileSystem.setPermission(path, dirperms);
fileSystem.setReplication(path, (short)
this.getMetadata().get_replication_factor());
}
..
}
```
We can see that there are permission settings for path in both try and
catch, but the permission in catch is different from that in try. In catch, the
permission `dirperms` is given to the file. I think there is a problem here,
and it should be the same as The permissions in try are consistent.
Permissions should be set according to the following code
```java
public OutputStream getOutputStream() throws IOException {
FsPermission fileperms = new FsPermission(BLOBSTORE_FILE_PERMISSION);
try {
out = fileSystem.create(path, (short)
this.getMetadata().get_replication_factor());
fileSystem.setPermission(path, fileperms);
fileSystem.setReplication(path, (short)
this.getMetadata().get_replication_factor());
} catch (IOException e) {
..
out = fileSystem.create(path, (short)
this.getMetadata().get_replication_factor());
fileSystem.setPermission(path, fileperms);
fileSystem.setReplication(path, (short)
this.getMetadata().get_replication_factor());
}
..
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad opened a new pull request, #3505: [STORM-3887] Add AWS Kafka command processor
bipinprasad opened a new pull request, #3505: URL: https://github.com/apache/storm/pull/3505 ## What is the purpose of the change *Command processor to interact with AWS Kafka cluster* ## How was the change tested *Ran each command* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] dependabot[bot] closed pull request #3490: Bump snakeyaml from 1.26 to 1.31
dependabot[bot] closed pull request #3490: Bump snakeyaml from 1.26 to 1.31 URL: https://github.com/apache/storm/pull/3490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] dependabot[bot] commented on pull request #3490: Bump snakeyaml from 1.26 to 1.31
dependabot[bot] commented on PR #3490: URL: https://github.com/apache/storm/pull/3490#issuecomment-1352145129 Superseded by #3504. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] dependabot[bot] opened a new pull request, #3504: Bump snakeyaml from 1.26 to 1.32
dependabot[bot] opened a new pull request, #3504: URL: https://github.com/apache/storm/pull/3504 [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/storm/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3503: Adding IgnoreUnrecognizedVMOptions to make worker start with jdk-11
bipinprasad merged PR #3503: URL: https://github.com/apache/storm/pull/3503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] atulsm commented on pull request #3503: Adding IgnoreUnrecognizedVMOptions to make worker start with jdk-11
atulsm commented on PR #3503: URL: https://github.com/apache/storm/pull/3503#issuecomment-1345868301 @bipinprasad , can you please merge to master if all looks good ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] atulsm commented on pull request #3503: Adding IgnoreUnrecognizedVMOptions to make worker start with jdk-11
atulsm commented on PR #3503: URL: https://github.com/apache/storm/pull/3503#issuecomment-1341872275 @bipinprasad , can this be merged to master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] atulsm opened a new pull request, #3503: Adding IgnoreUnrecognizedVMOptions to make worker start with jdk-11
atulsm opened a new pull request, #3503: URL: https://github.com/apache/storm/pull/3503 Issue: May of the default worker JVM parameters is no longer supported in java versions > 11. This will result in the worker process getting crashed. eg: https://github.com/31z4/storm-docker/issues/32 The official storm docker hub (https://hub.docker.com/_/storm) now ships jdk-11 and worker process fails with Error: Could not create the Java Virtual Machine. ## What is the purpose of the change To make storm workers run in jdk-11 and above *(Explain why we should have this change)* Storm workers are not able to start in jdk-11 and above ## How was the change tested Tested by running " storm supervisor -c worker.childopts= .. " with open-jdk11 and see that the topology is working as expected and worker process is getting started. *(Explain what tests did you do to verify the code change)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] ScottBrenner closed pull request #35: Update meetups.yml
ScottBrenner closed pull request #35: Update meetups.yml URL: https://github.com/apache/storm-site/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] ScottBrenner commented on pull request #35: Update meetups.yml
ScottBrenner commented on PR #35: URL: https://github.com/apache/storm-site/pull/35#issuecomment-1305097243 @bipinprasad Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] shahidhs-ibm commented on pull request #3492: Enable s390x builds on Travis
shahidhs-ibm commented on PR #3492: URL: https://github.com/apache/storm/pull/3492#issuecomment-1293025974 Any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3496: fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0
bipinprasad commented on PR #3496: URL: https://github.com/apache/storm/pull/3496#issuecomment-1287558076 This will need some code change: change class org.apache.storm.thrift.transport.TFramedTransport --> org.apache.storm.thrift.transport.layered.TFramedTransport And some other minor signature changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on a diff in pull request #3496: fix(sec): upgrade org.apache.thrift:libthrift to 0.14.0
bipinprasad commented on code in PR #3496:
URL: https://github.com/apache/storm/pull/3496#discussion_r1002255399
##
external/storm-hive/pom.xml:
##
@@ -202,7 +201,7 @@
org.apache.thrift
libthrift
- 0.9.3
+ 0.14.0
Review Comment:
Can this use ${thrift.version}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3498: fix(sec): upgrade org.elasticsearch:elasticsearch to 6.8.17
bipinprasad commented on PR #3498: URL: https://github.com/apache/storm/pull/3498#issuecomment-1287523290 Probably needs some code change. https://app.travis-ci.com/github/apache/storm/jobs/585564257 line 6680 Error in external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsTestUtil.java:[56,30] cannot find symbol Breaking change with NodeBuilder: https://www.elastic.co/guide/en/elasticsearch/reference/5.5/breaking_50_java_api_changes.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3501: [STORM-3885] fix(sec): upgrade com.fasterxml.jackson.core:jackson-databind to 2.12.6.1
bipinprasad commented on PR #3501: URL: https://github.com/apache/storm/pull/3501#issuecomment-1287522460 Probably needs some code change. https://app.travis-ci.com/github/apache/storm/jobs/585564257 line 6680 Error in external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsTestUtil.java:[56,30] cannot find symbol Breaking change with NodeBuilder: https://www.elastic.co/guide/en/elasticsearch/reference/5.5/breaking_50_java_api_changes.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3500: fix(sec): upgrade com.google.guava:guava to 30.0-jre
bipinprasad commented on PR #3500: URL: https://github.com/apache/storm/pull/3500#issuecomment-1287511964 DEPENDENCY-LICENSES needs to be changed as well. License check failed https://app.travis-ci.com/github/apache/storm/jobs/585571698 line 3190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3494: fix(sec): upgrade commons-codec:commons-codec to 1.13
bipinprasad commented on PR #3494: URL: https://github.com/apache/storm/pull/3494#issuecomment-1287508449 For license failures, you can check the output. There will be current file vs expected file. Diff will show what needs to be changed in DEPENDENCY-LICENSES file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3494: fix(sec): upgrade commons-codec:commons-codec to 1.13
bipinprasad commented on PR #3494: URL: https://github.com/apache/storm/pull/3494#issuecomment-1287507110 Seems like a good fix. Any reason why this PR should be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3501: [STORM-3885] fix(sec): upgrade com.fasterxml.jackson.core:jackson-databind to 2.12.6.1
bipinprasad commented on PR #3501: URL: https://github.com/apache/storm/pull/3501#issuecomment-1287457886 https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind shows that 2.12.6.1 has two different vulnerabilities: Direct vulnerabilities: [CVE-2022-42004](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-42004) [CVE-2022-42003](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-42003) ref page: https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind/2.12.6.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3501: fix(sec): upgrade com.fasterxml.jackson.core:jackson-databind to 2.12.6.1
bipinprasad commented on PR #3501: URL: https://github.com/apache/storm/pull/3501#issuecomment-1287441366 Looks like this needs some code change since the class com/fasterxml/jackson/core/util/JacksonFeature is not found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3491: [STORM-3884] Bump calcite-core from 1.14.0 to 1.32.0
bipinprasad commented on PR #3491: URL: https://github.com/apache/storm/pull/3491#issuecomment-1287439674 Created Jira https://issues.apache.org/jira/browse/STORM-3884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3502: [STORM-3883] Update Kryo to version 4.0.2
bipinprasad merged PR #3502: URL: https://github.com/apache/storm/pull/3502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] 645775992 closed pull request #3494: fix(sec): upgrade commons-codec:commons-codec to 1.13
645775992 closed pull request #3494: fix(sec): upgrade commons-codec:commons-codec to 1.13 URL: https://github.com/apache/storm/pull/3494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] closed pull request #31: Bump nokogiri from 1.13.3 to 1.13.6 in /content
dependabot[bot] closed pull request #31: Bump nokogiri from 1.13.3 to 1.13.6 in /content URL: https://github.com/apache/storm-site/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] closed pull request #32: Bump nokogiri from 1.13.3 to 1.13.6
dependabot[bot] closed pull request #32: Bump nokogiri from 1.13.3 to 1.13.6 URL: https://github.com/apache/storm-site/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] commented on pull request #31: Bump nokogiri from 1.13.3 to 1.13.6 in /content
dependabot[bot] commented on PR #31: URL: https://github.com/apache/storm-site/pull/31#issuecomment-1286369395 Superseded by #37. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] commented on pull request #32: Bump nokogiri from 1.13.3 to 1.13.6
dependabot[bot] commented on PR #32: URL: https://github.com/apache/storm-site/pull/32#issuecomment-1286369388 Superseded by #36. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] opened a new pull request, #37: Bump nokogiri from 1.13.3 to 1.13.9 in /content
dependabot[bot] opened a new pull request, #37: URL: https://github.com/apache/storm-site/pull/37 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.13.9. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's releases. 1.13.9 / 2022-10-18 Security [CRuby] Vendored libxml2 is updated to address https://nvd.nist.gov/vuln/detail/CVE-2022-2309;>CVE-2022-2309, https://nvd.nist.gov/vuln/detail/CVE-2022-40304;>CVE-2022-40304, and https://nvd.nist.gov/vuln/detail/CVE-2022-40303;>CVE-2022-40303. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-2qc6-mcvw-92cw;>GHSA-2qc6-mcvw-92cw for more information. [CRuby] Vendored zlib is updated to address https://ubuntu.com/security/CVE-2022-37434;>CVE-2022-37434. Nokogiri was not affected by this vulnerability, but this version of zlib was being flagged up by some vulnerability scanners, see https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2626;>#2626 for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.10.3;>v2.10.3 from v2.9.14. [CRuby] Vendored libxslt is updated to https://gitlab.gnome.org/GNOME/libxslt/-/releases/v1.1.37;>v1.1.37 from v1.1.35. [CRuby] Vendored zlib is updated from 1.2.12 to 1.2.13. (See https://github.com/sparklemotion/nokogiri/blob/v1.13.x/LICENSE-DEPENDENCIES.md#platform-releases;>LICENSE-DEPENDENCIES.md for details on which packages redistribute this library.) Fixed [CRuby] Nokogiri::XML::Namespace objects, when compacted, update their internal struct's reference to the Ruby object wrapper. Previously, with GC compaction enabled, a segmentation fault was possible after compaction was triggered. [https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2658;>#2658] (Thanks, https://github.com/eightbitraptor;>@​eightbitraptor and https://github.com/peterzhu2118;>@​peterzhu2118!) [CRuby] Document#remove_namespaces! now defers freeing the underlying xmlNs struct until the Document is GCed. Previously, maintaining a reference to a Namespace object that was removed in this way could lead to a segfault. [https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2658;>#2658] sha256 checksums: 9b69829561d30c4461ea803baeaf3460e8b145cff7a26ce397119577a4083a02 nokogiri-1.13.9-aarch64-linux.gem e76ebb4b7b2e02c72b2d1541289f8b0679fb5984867cf199d89b8ef485764956 nokogiri-1.13.9-arm64-darwin.gem 15bae7d08bddeaa898d8e3f558723300137c26a2dc2632a1f89c8574c4467165 nokogiri-1.13.9-java.gem f6a1dbc7229184357f3129503530af73cc59ceba4932c700a458a561edbe04b9 nokogiri-1.13.9-x64-mingw-ucrt.gem 36d935d799baa4dc488024f71881ff0bc8b172cecdfc54781169c40ec02cbdb3 nokogiri-1.13.9-x64-mingw32.gem ebaf82aa9a11b8fafb67873d19ee48efb565040f04c898cdce8ca0cd53ff1a12 nokogiri-1.13.9-x86-linux.gem 11789a2a11b28bc028ee111f23311461104d8c4468d5b901ab7536b282504154 nokogiri-1.13.9-x86-mingw32.gem 01830e1646803ff91c0fe94bc768ff40082c6de8cfa563dafd01b3f7d5f9d795 nokogiri-1.13.9-x86_64-darwin.gem 8e93b8adec22958013799c8690d81c2cdf8a90b6f6e8150ab22e11895844d781 nokogiri-1.13.9-x86_64-linux.gem 96f37c1baf0234d3ae54c2c89aef7220d4a8a1b03d2675ff7723565b0a095531 nokogiri-1.13.9.gem 1.13.8 / 2022-07-23 Deprecated XML::Reader#attribute_nodes is deprecated due to incompatibility between libxml2's xmlReader memory semantics and Ruby's garbage collector. Although this method continues to exist for backwards compatibility, it is unsafe to call and may segfault. This method will be removed in a future version of Nokogiri, and callers should use #attribute_hash instead. [https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2598;>#2598] Improvements XML::Reader#attribute_hash is a new method to safely retrieve the attributes of a node from XML::Reader. [https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2598;>#2598, https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2599;>#2599] Fixed ... (truncated) Changelog Sourced from https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md;>nokogiri's changelog. 1.13.9 / 2022-10-18 Security [CRuby] Vendored libxml2 is updated to address https://nvd.nist.gov/vuln/detail/CVE-2022-2309;>CVE-2022-2309, https://nvd.nist.gov/vuln/detail/CVE-2022-40304;>CVE-2022-40304, and https://nvd.nist.gov/vuln/detail/CVE-2022-40303;>CVE-2022-40303. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-2qc6-mcvw-92cw;>GHSA-2qc6-mcvw-92cw for more information. [CRuby] Vendored zlib is updated to address https://ubuntu.com/security/CVE-2022-37434;>CVE-2022-37434. Nokogiri was not affected by this vulnerability, but this version of zlib was being flagged up by some vulnerability
[GitHub] [storm-site] dependabot[bot] opened a new pull request, #36: Bump nokogiri from 1.13.3 to 1.13.9
dependabot[bot] opened a new pull request, #36: URL: https://github.com/apache/storm-site/pull/36 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.13.9. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's releases. 1.13.9 / 2022-10-18 Security [CRuby] Vendored libxml2 is updated to address https://nvd.nist.gov/vuln/detail/CVE-2022-2309;>CVE-2022-2309, https://nvd.nist.gov/vuln/detail/CVE-2022-40304;>CVE-2022-40304, and https://nvd.nist.gov/vuln/detail/CVE-2022-40303;>CVE-2022-40303. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-2qc6-mcvw-92cw;>GHSA-2qc6-mcvw-92cw for more information. [CRuby] Vendored zlib is updated to address https://ubuntu.com/security/CVE-2022-37434;>CVE-2022-37434. Nokogiri was not affected by this vulnerability, but this version of zlib was being flagged up by some vulnerability scanners, see https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2626;>#2626 for more information. Dependencies [CRuby] Vendored libxml2 is updated to https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.10.3;>v2.10.3 from v2.9.14. [CRuby] Vendored libxslt is updated to https://gitlab.gnome.org/GNOME/libxslt/-/releases/v1.1.37;>v1.1.37 from v1.1.35. [CRuby] Vendored zlib is updated from 1.2.12 to 1.2.13. (See https://github.com/sparklemotion/nokogiri/blob/v1.13.x/LICENSE-DEPENDENCIES.md#platform-releases;>LICENSE-DEPENDENCIES.md for details on which packages redistribute this library.) Fixed [CRuby] Nokogiri::XML::Namespace objects, when compacted, update their internal struct's reference to the Ruby object wrapper. Previously, with GC compaction enabled, a segmentation fault was possible after compaction was triggered. [https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2658;>#2658] (Thanks, https://github.com/eightbitraptor;>@​eightbitraptor and https://github.com/peterzhu2118;>@​peterzhu2118!) [CRuby] Document#remove_namespaces! now defers freeing the underlying xmlNs struct until the Document is GCed. Previously, maintaining a reference to a Namespace object that was removed in this way could lead to a segfault. [https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2658;>#2658] sha256 checksums: 9b69829561d30c4461ea803baeaf3460e8b145cff7a26ce397119577a4083a02 nokogiri-1.13.9-aarch64-linux.gem e76ebb4b7b2e02c72b2d1541289f8b0679fb5984867cf199d89b8ef485764956 nokogiri-1.13.9-arm64-darwin.gem 15bae7d08bddeaa898d8e3f558723300137c26a2dc2632a1f89c8574c4467165 nokogiri-1.13.9-java.gem f6a1dbc7229184357f3129503530af73cc59ceba4932c700a458a561edbe04b9 nokogiri-1.13.9-x64-mingw-ucrt.gem 36d935d799baa4dc488024f71881ff0bc8b172cecdfc54781169c40ec02cbdb3 nokogiri-1.13.9-x64-mingw32.gem ebaf82aa9a11b8fafb67873d19ee48efb565040f04c898cdce8ca0cd53ff1a12 nokogiri-1.13.9-x86-linux.gem 11789a2a11b28bc028ee111f23311461104d8c4468d5b901ab7536b282504154 nokogiri-1.13.9-x86-mingw32.gem 01830e1646803ff91c0fe94bc768ff40082c6de8cfa563dafd01b3f7d5f9d795 nokogiri-1.13.9-x86_64-darwin.gem 8e93b8adec22958013799c8690d81c2cdf8a90b6f6e8150ab22e11895844d781 nokogiri-1.13.9-x86_64-linux.gem 96f37c1baf0234d3ae54c2c89aef7220d4a8a1b03d2675ff7723565b0a095531 nokogiri-1.13.9.gem 1.13.8 / 2022-07-23 Deprecated XML::Reader#attribute_nodes is deprecated due to incompatibility between libxml2's xmlReader memory semantics and Ruby's garbage collector. Although this method continues to exist for backwards compatibility, it is unsafe to call and may segfault. This method will be removed in a future version of Nokogiri, and callers should use #attribute_hash instead. [https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2598;>#2598] Improvements XML::Reader#attribute_hash is a new method to safely retrieve the attributes of a node from XML::Reader. [https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2598;>#2598, https://github-redirect.dependabot.com/sparklemotion/nokogiri/issues/2599;>#2599] Fixed ... (truncated) Changelog Sourced from https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md;>nokogiri's changelog. 1.13.9 / 2022-10-18 Security [CRuby] Vendored libxml2 is updated to address https://nvd.nist.gov/vuln/detail/CVE-2022-2309;>CVE-2022-2309, https://nvd.nist.gov/vuln/detail/CVE-2022-40304;>CVE-2022-40304, and https://nvd.nist.gov/vuln/detail/CVE-2022-40303;>CVE-2022-40303. See https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-2qc6-mcvw-92cw;>GHSA-2qc6-mcvw-92cw for more information. [CRuby] Vendored zlib is updated to address https://ubuntu.com/security/CVE-2022-37434;>CVE-2022-37434. Nokogiri was not affected by this vulnerability, but this version of zlib was being flagged up by some vulnerability
[GitHub] [storm] bipinprasad opened a new pull request, #3502: [STOM-3883] Update Kryo to version 4.0.2
bipinprasad opened a new pull request, #3502: URL: https://github.com/apache/storm/pull/3502 - Update Maven Dependencies. - Update LICENSE files. - Exclude Kryo 3.0.3 dependency picked by the following dependency: +- org.apache.storm:storm-clojure:jar:2.5.0-SNAPSHOT:compile. | \- com.twitter:carbonite:jar:1.5.0:compile | \- com.twitter:chill-java:jar:0.8.0:compile |\- com.esotericsoftware:kryo-shaded:jar:3.0.3:compile ## What is the purpose of the change *Kryo is now on version 5. Kryo version 3 does some introspection which will be disabled in JVM soon. Upgrade to version 4 is an intermediate step in moving to version 5. Version 5 cannot be used immediately since it requires code change due to compile errors* ## How was the change tested *Run unit tests* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] ScottBrenner opened a new pull request, #35: Update meetups.yml
ScottBrenner opened a new pull request, #35: URL: https://github.com/apache/storm-site/pull/35 Seems these groups no longer exist, proposing deleting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bitmasks closed pull request #3499: fix(sec): upgrade com.google.guava:guava to 30.0-jre
bitmasks closed pull request #3499: fix(sec): upgrade com.google.guava:guava to 30.0-jre URL: https://github.com/apache/storm/pull/3499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bitmasks commented on pull request #3499: fix(sec): upgrade com.google.guava:guava to 30.0-jre
bitmasks commented on PR #3499: URL: https://github.com/apache/storm/pull/3499#issuecomment-1279893608 close -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bitmasks closed pull request #3493: fix(sec): upgrade org.apache.kafka:kafka-clients to 2.7.2
bitmasks closed pull request #3493: fix(sec): upgrade org.apache.kafka:kafka-clients to 2.7.2 URL: https://github.com/apache/storm/pull/3493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bitmasks commented on pull request #3493: fix(sec): upgrade org.apache.kafka:kafka-clients to 2.7.2
bitmasks commented on PR #3493: URL: https://github.com/apache/storm/pull/3493#issuecomment-1279253357 close PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] shahidhs-ibm commented on pull request #3492: Enable s390x builds on Travis
shahidhs-ibm commented on PR #3492: URL: https://github.com/apache/storm/pull/3492#issuecomment-1251940882 The build failures seems unrelated with the commit. Please re-trigger the build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] shahidhs-ibm opened a new pull request, #3492: Enable s390x builds on Travis
shahidhs-ibm opened a new pull request, #3492: URL: https://github.com/apache/storm/pull/3492 Signed-off-by: Shahid Shaikh ## What is the purpose of the change Enable s390x builds on Travis. ## How was the change tested Changes are tested by running Travis [builds](https://app.travis-ci.com/github/linux-on-ibm-z/storm/builds/255643186). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] dependabot[bot] opened a new pull request, #3491: Bump calcite-core from 1.14.0 to 1.32.0
dependabot[bot] opened a new pull request, #3491:
URL: https://github.com/apache/storm/pull/3491
Bumps [calcite-core](https://github.com/apache/calcite) from 1.14.0 to
1.32.0.
Commits
https://github.com/apache/calcite/commit/413eded693a9087402cc1a6eefeca7a29445d337;>413eded
[CALCITE-5275] Release Calcite 1.32.0
https://github.com/apache/calcite/commit/57aafa3551847da0a69696660bfe391e1d3a7a6c;>57aafa3
Cosmetic changes to release notes
https://github.com/apache/calcite/commit/262492527fbd450892df36cda38080d447fc6498;>2624925
[CALCITE-5262] Add many spatial functions, including support for WKB
(well-kn...
https://github.com/apache/calcite/commit/479afa6813c734167a69ae7e6d2168a14a3e9d56;>479afa6
[CALCITE-5278] Upgrade Janino from 3.1.6 to 3.1.8
https://github.com/apache/calcite/commit/1167b125747cd4b157f377ae0ba64f833890a138;>1167b12
[CALCITE-5270] JDBC adapter should not generate 'FILTER (WHERE)' in Firebolt
...
https://github.com/apache/calcite/commit/89c940cc8b6e5ded4c0fa4fa044bab212a7f8599;>89c940c
[CALCITE-5241] Implement CHAR function for MySQL and Spark, also JDBC '{fn
CH...
https://github.com/apache/calcite/commit/d20fd09a1d478a87559027c5f024214f70abb622;>d20fd09
[CALCITE-5274] Improve DocumentBuilderFactory in DiffRepository test class
by...
https://github.com/apache/calcite/commit/6302e6fa85be1d8d9efd8277f6a2bf43195776ac;>6302e6f
[CALCITE-5277] Make EnumerableRelImplementor stashedParameters order
determin...
https://github.com/apache/calcite/commit/baeecc82b98c0b035f479a5046556c65a2a28a98;>baeecc8
[CALCITE-5251] Support SQL hint for Snapshot
https://github.com/apache/calcite/commit/ba80b9156afc0db26b194d97a031fcc0dc7f4c03;>ba80b91
[CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder
Additional commits viewable in https://github.com/apache/calcite/compare/calcite-1.14.0...calcite-1.32.0;>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI
passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and
block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it.
You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the PR or
upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default
for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the
default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the
default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the
default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security
Alerts page](https://github.com/apache/storm/network/alerts).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] dependabot[bot] opened a new pull request, #3490: Bump snakeyaml from 1.26 to 1.31
dependabot[bot] opened a new pull request, #3490: URL: https://github.com/apache/storm/pull/3490 Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.26 to 1.31. Commits https://bitbucket.org/snakeyaml/snakeyaml/commits/a3e641b8d6337d9916b5d709278fd668b0eb8507;>a3e641b Remove unused code for comments https://bitbucket.org/snakeyaml/snakeyaml/commits/d2ed56802d388afb4c714325e41afa8e095478b4;>d2ed568 Remove unused code https://bitbucket.org/snakeyaml/snakeyaml/commits/ab76f8678972f5eb3caaf3b473e63323bcea9e92;>ab76f86 Add https://github.com/Deprecated;>@​Deprecated annotation to constructs marked with https://github.com/deprecated;>@​deprecated javadoc. https://bitbucket.org/snakeyaml/snakeyaml/commits/bc7869b53e27caed452894986c5ee7c4b787a725;>bc7869b Make billionLaughsAttackTest.billionLaughsAttackExpanded() robust https://bitbucket.org/snakeyaml/snakeyaml/commits/4cfb7b78ac9d414590da53557314ae97691dd63e;>4cfb7b7 Merged in make-billion-laughs-attack-test-robust (pull request https://bitbucket.org/snakeyaml/snakeyaml/issues/7;>#7) https://bitbucket.org/snakeyaml/snakeyaml/commits/da5ba160027ec9943d3cd3a67950ca57c15011b7;>da5ba16 Update changes.xml https://bitbucket.org/snakeyaml/snakeyaml/commits/23fbcef0e952adbea3fc147c6b17eb8ab7e3432a;>23fbcef add test with JavaBean property of parameterized Collection https://bitbucket.org/snakeyaml/snakeyaml/commits/6385279ecb0b3ec623563ba934475eab100fb25e;>6385279 change how we set detected type to JavaBean Collection property item https://bitbucket.org/snakeyaml/snakeyaml/commits/04687842700919db5ba4baf176abf9b044b32a45;>0468784 force keyNode to be String for JavaBeans https://bitbucket.org/snakeyaml/snakeyaml/commits/467bcc9d06c6914e334b4c4052fa8aa27f092721;>467bcc9 expect node to be scalar when enforcings String keys Additional commits viewable in https://bitbucket.org/snakeyaml/snakeyaml/branches/compare/snakeyaml-1.31..snakeyaml-1.26;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/storm/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] YuBingZhou opened a new pull request, #3489: Test
YuBingZhou opened a new pull request, #3489: URL: https://github.com/apache/storm/pull/3489 新增storm-kafka- client调试类 ## What is the purpose of the change *(Explain why we should have this change)* ## How was the change tested *(Explain what tests did you do to verify the code change)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm-site] dependabot[bot] opened a new pull request, #34: Bump tzinfo from 1.2.4 to 1.2.10 in /content
dependabot[bot] opened a new pull request, #34:
URL: https://github.com/apache/storm-site/pull/34
Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 1.2.4 to 1.2.10.
Release notes
Sourced from https://github.com/tzinfo/tzinfo/releases;>tzinfo's releases.
v1.2.10
Fixed a relative path traversal bug that could cause arbitrary files to
be loaded with require when used with RubyDataSource. Please refer
to
https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx;>https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx
for details. CVE-2022-31163.
Ignore the SECURITY file from Arch Linux's tzdata package. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/134;>#134.
https://rubygems.org/gems/tzinfo/versions/1.2.10;>TZInfo v1.2.10
on RubyGems.org
v1.2.9
Fixed an incorrect InvalidTimezoneIdentifier exception
raised when loading a zoneinfo file that includes rules specifying an
additional transition to the final defined offset (for example,
Africa/Casablanca in version 2018e of the Time Zone Database). https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/123;>#123.
https://rubygems.org/gems/tzinfo/versions/1.2.9;>TZInfo v1.2.9
on RubyGems.org
v1.2.8
Added support for handling slim format zoneinfo files that
are produced by default by zic version 2020b and later. The POSIX-style TZ
string is now used calculate DST transition times after the final defined
transition in the file. The 64-bit section is now always used regardless of
whether Time has support for 64-bit times. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/120;>#120.
Rubinius is no longer supported.
https://rubygems.org/gems/tzinfo/versions/1.2.8;>TZInfo v1.2.8
on RubyGems.org
v1.2.7
Fixed 'wrong number of arguments' errors when running on JRuby 9.0. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/114;>#114.
Fixed warnings when running on Ruby 2.8. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/112;>#112.
https://rubygems.org/gems/tzinfo/versions/1.2.7;>TZInfo v1.2.7
on RubyGems.org
v1.2.6
Timezone#strftime('%s', time) will now return the correct
number of seconds since the epoch. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/91;>#91.
Removed the unused TZInfo::RubyDataSource::REQUIRE_PATH
constant.
Fixed SecurityError: Insecure operation - require exceptions
when loading data with recent Ruby releases in safe mode.
Fixed warnings when running on Ruby 2.7. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/106;>#106
and https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/111;>#111.
https://rubygems.org/gems/tzinfo/versions/1.2.6;>TZInfo v1.2.6
on RubyGems.org
v1.2.5
Support recursively (deep) freezing Country and
Timezone instances. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/80;>#80.
Allow negative daylight savings time offsets to be derived when reading
from zoneinfo files. The utc_offset and std_offset are now derived correctly
for Europe/Dublin in the 2018a and 2018b releases of the Time Zone
Database.
https://rubygems.org/gems/tzinfo/versions/1.2.5;>TZInfo v1.2.5
on RubyGems.org
Changelog
Sourced from https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md;>tzinfo's
changelog.
Version 1.2.10 - 19-Jul-2022
Fixed a relative path traversal bug that could cause arbitrary files to
be
loaded with require when used with RubyDataSource.
Please refer to
https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx;>https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx
for
details. CVE-2022-31163.
Ignore the SECURITY file from Arch Linux's tzdata package. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/134;>#134.
Version 1.2.9 - 16-Dec-2020
Fixed an incorrect InvalidTimezoneIdentifier exception
raised when loading a
zoneinfo file that includes rules specifying an additional transition to the
final defined offset (for example, Africa/Casablanca in version 2018e of the
Time Zone Database). https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/123;>#123.
Version 1.2.8 - 8-Nov-2020
Added support for handling slim format zoneinfo files that
are produced by
default by zic version 2020b and later. The POSIX-style TZ string is now used
calculate DST transition times after the final defined transition in the
file.
The 64-bit section is now always used regardless of whether Time has support
for 64-bit times. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/120;>#120.
Rubinius is no longer supported.
Version 1.2.7 - 2-Apr-2020
Fixed 'wrong number of arguments' errors when running on JRuby 9.0. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/114;>#114.
Fixed warnings when running on
[GitHub] [storm-site] dependabot[bot] opened a new pull request, #33: Bump tzinfo from 1.2.4 to 1.2.10
dependabot[bot] opened a new pull request, #33:
URL: https://github.com/apache/storm-site/pull/33
Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 1.2.4 to 1.2.10.
Release notes
Sourced from https://github.com/tzinfo/tzinfo/releases;>tzinfo's releases.
v1.2.10
Fixed a relative path traversal bug that could cause arbitrary files to
be loaded with require when used with RubyDataSource. Please refer
to
https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx;>https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx
for details. CVE-2022-31163.
Ignore the SECURITY file from Arch Linux's tzdata package. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/134;>#134.
https://rubygems.org/gems/tzinfo/versions/1.2.10;>TZInfo v1.2.10
on RubyGems.org
v1.2.9
Fixed an incorrect InvalidTimezoneIdentifier exception
raised when loading a zoneinfo file that includes rules specifying an
additional transition to the final defined offset (for example,
Africa/Casablanca in version 2018e of the Time Zone Database). https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/123;>#123.
https://rubygems.org/gems/tzinfo/versions/1.2.9;>TZInfo v1.2.9
on RubyGems.org
v1.2.8
Added support for handling slim format zoneinfo files that
are produced by default by zic version 2020b and later. The POSIX-style TZ
string is now used calculate DST transition times after the final defined
transition in the file. The 64-bit section is now always used regardless of
whether Time has support for 64-bit times. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/120;>#120.
Rubinius is no longer supported.
https://rubygems.org/gems/tzinfo/versions/1.2.8;>TZInfo v1.2.8
on RubyGems.org
v1.2.7
Fixed 'wrong number of arguments' errors when running on JRuby 9.0. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/114;>#114.
Fixed warnings when running on Ruby 2.8. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/112;>#112.
https://rubygems.org/gems/tzinfo/versions/1.2.7;>TZInfo v1.2.7
on RubyGems.org
v1.2.6
Timezone#strftime('%s', time) will now return the correct
number of seconds since the epoch. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/91;>#91.
Removed the unused TZInfo::RubyDataSource::REQUIRE_PATH
constant.
Fixed SecurityError: Insecure operation - require exceptions
when loading data with recent Ruby releases in safe mode.
Fixed warnings when running on Ruby 2.7. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/106;>#106
and https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/111;>#111.
https://rubygems.org/gems/tzinfo/versions/1.2.6;>TZInfo v1.2.6
on RubyGems.org
v1.2.5
Support recursively (deep) freezing Country and
Timezone instances. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/80;>#80.
Allow negative daylight savings time offsets to be derived when reading
from zoneinfo files. The utc_offset and std_offset are now derived correctly
for Europe/Dublin in the 2018a and 2018b releases of the Time Zone
Database.
https://rubygems.org/gems/tzinfo/versions/1.2.5;>TZInfo v1.2.5
on RubyGems.org
Changelog
Sourced from https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md;>tzinfo's
changelog.
Version 1.2.10 - 19-Jul-2022
Fixed a relative path traversal bug that could cause arbitrary files to
be
loaded with require when used with RubyDataSource.
Please refer to
https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx;>https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx
for
details. CVE-2022-31163.
Ignore the SECURITY file from Arch Linux's tzdata package. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/134;>#134.
Version 1.2.9 - 16-Dec-2020
Fixed an incorrect InvalidTimezoneIdentifier exception
raised when loading a
zoneinfo file that includes rules specifying an additional transition to the
final defined offset (for example, Africa/Casablanca in version 2018e of the
Time Zone Database). https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/123;>#123.
Version 1.2.8 - 8-Nov-2020
Added support for handling slim format zoneinfo files that
are produced by
default by zic version 2020b and later. The POSIX-style TZ string is now used
calculate DST transition times after the final defined transition in the
file.
The 64-bit section is now always used regardless of whether Time has support
for 64-bit times. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/120;>#120.
Rubinius is no longer supported.
Version 1.2.7 - 2-Apr-2020
Fixed 'wrong number of arguments' errors when running on JRuby 9.0. https://github-redirect.dependabot.com/tzinfo/tzinfo/issues/114;>#114.
Fixed warnings when running on
[GitHub] [storm] bipinprasad merged pull request #3488: STORM-3873: Remove junit4 dependency
bipinprasad merged PR #3488: URL: https://github.com/apache/storm/pull/3488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] agresch commented on a diff in pull request #3488: STORM-3873: Remove junit4 dependency
agresch commented on code in PR #3488:
URL: https://github.com/apache/storm/pull/3488#discussion_r924587620
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/testing/MiniDFSClusterExtensionClassLevel.java:
##
@@ -52,6 +55,8 @@ public MiniDFSCluster getDfscluster() {
public void beforeAll(ExtensionContext arg0) throws Exception {
System.setProperty(TEST_BUILD_DATA, "target/test/data");
hadoopConf = hadoopConfSupplier.get();
+String tempDir = getTestDir("dfs").getAbsolutePath() + File.separator;
Review Comment:
Thanks for the explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3488: STORM-3873: Remove junit4 dependency
snikhil5 commented on code in PR #3488:
URL: https://github.com/apache/storm/pull/3488#discussion_r924583718
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/testing/MiniDFSClusterExtensionClassLevel.java:
##
@@ -52,6 +55,8 @@ public MiniDFSCluster getDfscluster() {
public void beforeAll(ExtensionContext arg0) throws Exception {
System.setProperty(TEST_BUILD_DATA, "target/test/data");
hadoopConf = hadoopConfSupplier.get();
+String tempDir = getTestDir("dfs").getAbsolutePath() + File.separator;
Review Comment:
Yes it is related to junit. The getTestDir() in MiniDFSCluster class in
Hadoop was using GenericTestUtils (which in turn uses Assert from junit4). This
change gets around that by setting the temp dir here instead of relying on
GenericTestUtils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] agresch commented on a diff in pull request #3488: STORM-3873: Remove junit4 dependency
agresch commented on code in PR #3488:
URL: https://github.com/apache/storm/pull/3488#discussion_r924548205
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/testing/MiniDFSClusterExtensionClassLevel.java:
##
@@ -52,6 +55,8 @@ public MiniDFSCluster getDfscluster() {
public void beforeAll(ExtensionContext arg0) throws Exception {
System.setProperty(TEST_BUILD_DATA, "target/test/data");
hadoopConf = hadoopConfSupplier.get();
+String tempDir = getTestDir("dfs").getAbsolutePath() + File.separator;
Review Comment:
is this somehow related to junit changes or is this some cleanup to use a
test dir?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 opened a new pull request, #3488: STORM-3873: Remove junit4 dependency
snikhil5 opened a new pull request, #3488: URL: https://github.com/apache/storm/pull/3488 ## What is the purpose of the change Remove junit4 from storm-hdfs and storm-hdfs blobstore to completely remove junit4 from Storm. ## How was the change tested built locally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] agresch merged pull request #3486: STORM-3875 remove topology gc opts from ThroughputVsLatency to allow …
agresch merged PR #3486: URL: https://github.com/apache/storm/pull/3486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] agresch merged pull request #3487: Storm 3872 Excluding some unused packages to enable compiling with maven versions >= 3.8.1
agresch merged PR #3487: URL: https://github.com/apache/storm/pull/3487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] snikhil5 opened a new pull request, #3487: Storm 3872 Excluding some unused packages to enable compiling with maven versions >= 3.8.1
snikhil5 opened a new pull request, #3487: URL: https://github.com/apache/storm/pull/3487 ## What is the purpose of the change Excluding some unused packages to enable compiling with maven versions >= 3.8.1 ## How was the change tested built locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] agresch opened a new pull request, #3486: STORM-3875 remove topology gc opts from ThroughputVsLatency to allow …
agresch opened a new pull request, #3486: URL: https://github.com/apache/storm/pull/3486 …running on JDK11 ## What is the purpose of the change Allow running the topology on JDK11. ## How was the change tested Ran on JDK8 and JDK11 on internal clusters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] agresch merged pull request #3485: MINOR: add blobstore documentation for workerRestart
agresch merged PR #3485: URL: https://github.com/apache/storm/pull/3485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] agresch opened a new pull request, #3485: MINOR: add blobstore documentation for workerRestart
agresch opened a new pull request, #3485: URL: https://github.com/apache/storm/pull/3485 ## What is the purpose of the change Adding documentation for workerRestart option in the blobstore documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
bipinprasad merged PR #3479: URL: https://github.com/apache/storm/pull/3479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3422: STORM-3805 Changing error to warn for retry update operations
bipinprasad merged PR #3422: URL: https://github.com/apache/storm/pull/3422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3475: [STORM-3855] Remove python2 support and move to python3.
bipinprasad merged PR #3475: URL: https://github.com/apache/storm/pull/3475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad closed pull request #3414: DO NOT MERGE: change dist from trusty to xenial
bipinprasad closed pull request #3414: DO NOT MERGE: change dist from trusty to xenial URL: https://github.com/apache/storm/pull/3414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad closed pull request #3458: [STORM-3832] Remove Junit4 dependency
bipinprasad closed pull request #3458: [STORM-3832] Remove Junit4 dependency URL: https://github.com/apache/storm/pull/3458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad commented on pull request #3458: [STORM-3832] Remove Junit4 dependency
bipinprasad commented on PR #3458: URL: https://github.com/apache/storm/pull/3458#issuecomment-1142991406 Replaced by PR https://github.com/apache/storm/pull/3479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] dependabot[bot] opened a new pull request, #3484: Bump hadoop-common from 2.10.1 to 3.2.3
dependabot[bot] opened a new pull request, #3484: URL: https://github.com/apache/storm/pull/3484 Bumps hadoop-common from 2.10.1 to 3.2.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/storm/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] bipinprasad merged pull request #3460: [STORM-3841] Update hive version from 2.3.4 to 2.3.9
bipinprasad merged PR #3460: URL: https://github.com/apache/storm/pull/3460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885714008
##
storm-server/src/test/java/org/apache/storm/security/auth/DefaultHttpCredentialsPluginTest.java:
##
@@ -18,30 +18,32 @@
import javax.security.auth.Subject;
import javax.servlet.http.HttpServletRequest;
import org.apache.storm.shade.com.google.common.collect.ImmutableSet;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
public class DefaultHttpCredentialsPluginTest {
@Test
public void test_getUserName() {
DefaultHttpCredentialsPlugin handler = new
DefaultHttpCredentialsPlugin();
-handler.prepare(new HashMap());
+handler.prepare(new HashMap<>());
-Assert.assertNull("returns null when request is null",
handler.getUserName(null));
+assertNull(handler.getUserName(null), "returns null when request is
null");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885713177
##
storm-server/src/test/java/org/apache/storm/daemon/supervisor/SlotTest.java:
##
@@ -177,39 +174,39 @@ public void testLaunchContainerFromEmpty() throws
Exception {
DynamicState nextState = Slot.stateMachineStep(dynamicState,
staticState);
verify(localizer).requestDownloadTopologyBlobs(newAssignment,
port, cb);
assertEquals(MachineState.WAITING_FOR_BLOB_LOCALIZATION,
nextState.state);
-assertSame("pendingDownload not set properly", blobFuture,
nextState.pendingDownload);
+assertSame(blobFuture, nextState.pendingDownload, "pendingDownload
not set properly");
assertEquals(newAssignment, nextState.pendingLocalization);
assertEquals(0, Time.currentTimeMillis());
nextState = Slot.stateMachineStep(nextState, staticState);
verify(blobFuture).get(1000, TimeUnit.MILLISECONDS);
verify(containerLauncher).launchContainer(port, newAssignment,
state);
assertEquals(MachineState.WAITING_FOR_WORKER_START,
nextState.state);
-assertSame("pendingDownload is not null", null,
nextState.pendingDownload);
+assertSame(null, nextState.pendingDownload, "pendingDownload is
not null");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885711253
##
storm-server/src/test/java/org/apache/storm/TickTupleTest.java:
##
@@ -93,7 +92,7 @@ public void testTickTupleWorksWithSystemBolt() throws
Exception {
} catch (ConditionTimeoutException e) {
throw new AssertionError(e.getMessage());
}
-assertNull("The bolt got a tuple that is not a tick tuple " +
nonTickTuple.get(), nonTickTuple.get());
+assertNull(nonTickTuple.get(), "The bolt got a tuple that is
not a tick tuple " + nonTickTuple.get());
Review Comment:
we don't need to negate here ..
##
storm-server/src/test/java/org/apache/storm/blobstore/LocalFsBlobStoreSynchronizerTest.java:
##
@@ -30,51 +30,46 @@
import
org.apache.storm.shade.org.apache.curator.framework.CuratorFrameworkFactory;
import org.apache.storm.shade.org.apache.curator.retry.ExponentialBackoffRetry;
import org.apache.storm.utils.Utils;
-import org.apache.zookeeper.server.NIOServerCnxnFactory;
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
/**
* Unit tests for most of the testable utility methods
* and LocalFsBlobStoreSynchronizer class methods
*/
public class LocalFsBlobStoreSynchronizerTest {
- private URI base;
- private File baseFile;
- private static Map conf = new HashMap();
- private NIOServerCnxnFactory factory;
+private static Map conf = new HashMap<>();
+
+private File baseFile;
Review Comment:
ok
##
storm-server/src/test/java/org/apache/storm/container/oci/OciUtilsTest.java:
##
@@ -117,22 +126,22 @@ public void adjustImageConfigForTopoTest() throws
InvalidTopologyException {
//case 3: configs are set properly; nothing will happen
topoConf.put(Config.TOPOLOGY_OCI_IMAGE, image1);
OciUtils.adjustImageConfigForTopo(conf, topoConf, topoId);
-Assert.assertEquals(image1, topoConf.get(Config.TOPOLOGY_OCI_IMAGE));
+assertEquals(image1, topoConf.get(Config.TOPOLOGY_OCI_IMAGE));
//case 4: topology oci image is not set; will be set to default image
topoConf.remove(Config.TOPOLOGY_OCI_IMAGE);
OciUtils.adjustImageConfigForTopo(conf, topoConf, topoId);
-Assert.assertEquals(defaultImage,
topoConf.get(Config.TOPOLOGY_OCI_IMAGE));
+assertEquals(defaultImage, topoConf.get(Config.TOPOLOGY_OCI_IMAGE));
//case 5: any topology oci image is allowed
allowedImages.add("*");
String image2 = "storm/rhel7:dev_wow";
topoConf.put(Config.TOPOLOGY_OCI_IMAGE, image2);
OciUtils.adjustImageConfigForTopo(conf, topoConf, topoId);
-Assert.assertEquals(image2, topoConf.get(Config.TOPOLOGY_OCI_IMAGE));
+assertEquals(image2, topoConf.get(Config.TOPOLOGY_OCI_IMAGE));
}
-@Test(expected = WrappedInvalidTopologyException.class)
+@Test
public void adjustImageConfigForTopoNotInAllowedList() throws
InvalidTopologyException {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885709882
##
storm-client/test/jvm/org/apache/storm/streams/processors/CoGroupByKeyProcessorTest.java:
##
@@ -18,24 +18,26 @@
import java.util.List;
import java.util.Set;
import org.apache.storm.streams.Pair;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
-import static org.junit.Assert.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
public class CoGroupByKeyProcessorTest {
private CoGroupByKeyProcessor
coGroupByKeyProcessor;
-private String firstStream = "first";
-private String secondStream = "second";
-private List, List>>> res = new
ArrayList<>();
+private final String firstStream = "first";
+private final String secondStream = "second";
+private final List, List>>> res
= new ArrayList<>();
+
+private final ProcessorContext,
List>>> context =
+new ProcessorContext,
List>>>() {
Review Comment:
No it throws error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885710004
##
storm-client/test/jvm/org/apache/storm/trident/TestTridentTopology.java:
##
@@ -60,7 +61,7 @@ public void testGenBoltId() {
Map cur = topology.get_bolts();
System.out.println(cur.keySet());
if (pre != null) {
-Assert.assertTrue("bold id not consistent with group name",
pre.equals(cur.keySet()));
+assertEquals(pre, cur.keySet(), "bold id not consistent with
group name");
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java:
##
@@ -146,31 +146,31 @@ public void
getConfiguredClientThrowsRuntimeExceptionOnBadArgsTest() throws TTra
try {
new NimbusClient(config, "", 65535);
-Assert.fail("Expected exception to be thrown");
+fail("Expected exception to be thrown");
} catch (RuntimeException e) {
-Assert.assertTrue(
-"Cause is not TTransportException " + e,
-Utils.exceptionCauseIsInstanceOf(TTransportException.class,
e));
+assertTrue(
Review Comment:
done
##
storm-core/test/jvm/org/apache/storm/command/SetLogLevelTest.java:
##
@@ -15,33 +15,35 @@
import java.util.Map;
import org.apache.storm.generated.LogLevel;
import org.apache.storm.generated.LogLevelAction;
-import org.junit.Assert;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
public class SetLogLevelTest {
@Test
public void testUpdateLogLevelParser() {
SetLogLevel.LogLevelsParser logLevelsParser = new
SetLogLevel.LogLevelsParser(LogLevelAction.UPDATE);
LogLevel logLevel = ((Map)
logLevelsParser.parse("com.foo.one=warn")).get("com.foo.one");
-Assert.assertEquals(0, logLevel.get_reset_log_level_timeout_secs());
-Assert.assertEquals("WARN", logLevel.get_target_log_level());
+assertEquals(0, logLevel.get_reset_log_level_timeout_secs());
+assertEquals("WARN", logLevel.get_target_log_level());
logLevel = ((Map)
logLevelsParser.parse("com.foo.two=DEBUG:10")).get("com.foo.two");
-Assert.assertEquals(10, logLevel.get_reset_log_level_timeout_secs());
-Assert.assertEquals("DEBUG", logLevel.get_target_log_level());
+assertEquals(10, logLevel.get_reset_log_level_timeout_secs());
+assertEquals("DEBUG", logLevel.get_target_log_level());
}
-@Test(expected = NumberFormatException.class)
+@Test
public void testInvalidTimeout() {
SetLogLevel.LogLevelsParser logLevelsParser = new
SetLogLevel.LogLevelsParser(LogLevelAction.UPDATE);
-logLevelsParser.parse("com.foo.bar=warn:NaN");
+assertThrows(IllegalArgumentException.class, () ->
logLevelsParser.parse("com.foo.bar=warn:NaN"));
Review Comment:
done
##
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java:
##
@@ -44,13 +47,13 @@ public void testJavaSerialization() throws IOException {
conf.put(Config.TOPOLOGY_FALL_BACK_ON_JAVA_SERIALIZATION, false);
try {
roundtrip(vals, conf);
-Assert.fail("Expected Exception not Thrown for config: " + conf);
+fail("Expected Exception not Thrown for config: " + conf);
} catch (Exception e) {
}
Review Comment:
done
##
storm-server/src/test/java/org/apache/storm/DaemonConfigTest.java:
##
@@ -50,45 +51,39 @@ private void stringOrStringListTest(String key) {
try {
conf.put(key, value);
ConfigValidation.validateFields(conf);
-Assert.fail("Expected Exception not Thrown for value: " +
value);
-} catch (IllegalArgumentException Ex) {
+fail("Expected Exception not Thrown for value: " + value);
+} catch (IllegalArgumentException ignore) {
}
}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885709553
##
storm-client/test/jvm/org/apache/storm/security/auth/authorizer/DRPCSimpleACLAuthorizerTest.java:
##
@@ -68,101 +68,101 @@ private static ReqContext makeMockContext(String user) {
@Test
public void test_partial_authorization() {
-Assert.assertFalse("Deny execute to unauthroized user",
- isPermitted(strictHandler, ReqContext.context(),
"execute", partialFunction));
+assertFalse(isPermitted(strictHandler, ReqContext.context(),
"execute", partialFunction),
+"Deny execute to unauthorized user");
-Assert.assertTrue("Allow execute to authorized kerb user for correct
function",
- isPermitted(strictHandler, aliceKerbContext,
"execute", partialFunction));
+assertTrue(isPermitted(strictHandler, aliceKerbContext, "execute",
partialFunction),
+"Allow execute to authorized kerb user for correct function");
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/security/auth/authorizer/DRPCSimpleACLAuthorizerTest.java:
##
@@ -68,101 +68,101 @@ private static ReqContext makeMockContext(String user) {
@Test
public void test_partial_authorization() {
-Assert.assertFalse("Deny execute to unauthroized user",
- isPermitted(strictHandler, ReqContext.context(),
"execute", partialFunction));
+assertFalse(isPermitted(strictHandler, ReqContext.context(),
"execute", partialFunction),
+"Deny execute to unauthorized user");
-Assert.assertTrue("Allow execute to authorized kerb user for correct
function",
- isPermitted(strictHandler, aliceKerbContext,
"execute", partialFunction));
+assertTrue(isPermitted(strictHandler, aliceKerbContext, "execute",
partialFunction),
+"Allow execute to authorized kerb user for correct function");
-Assert.assertFalse("Deny fetchRequest to unauthorized user for correct
function",
- isPermitted(strictHandler, aliceKerbContext,
"fetchRequest", partialFunction));
+assertFalse(isPermitted(strictHandler, aliceKerbContext,
"fetchRequest", partialFunction),
+"Deny fetchRequest to unauthorized user for correct function");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885709137
##
storm-client/test/jvm/org/apache/storm/grouping/ShuffleGroupingTest.java:
##
@@ -95,24 +95,21 @@ public void testShuffleGroupMultiThreaded() throws
InterruptedException, Executi
List> threadTasks = Lists.newArrayList();
for (int x = 0; x < numThreads; x++) {
-Callable threadTask = new Callable() {
-@Override
-public int[] call() throws Exception {
-int[] taskCounts = new int[availableTaskIds.size()];
-for (int i = 1; i <= groupingExecutionsPerThread; i++) {
-List taskIds =
grouper.chooseTasks(inputTaskId, Lists.newArrayList());
-
-// Validate a single task id return
-assertNotNull("Not null taskId list returned",
taskIds);
-assertEquals("Single task Id returned", 1,
taskIds.size());
-
-int taskId = taskIds.get(0);
-
-assertTrue("TaskId should exist", taskId >= 0 &&
taskId < availableTaskIds.size());
-taskCounts[taskId]++;
-}
-return taskCounts;
+Callable threadTask = () -> {
+int[] taskCounts = new int[availableTaskIds.size()];
+for (int i = 1; i <= groupingExecutionsPerThread; i++) {
+List taskIds = grouper.chooseTasks(inputTaskId,
Lists.newArrayList());
+
+// Validate a single task id return
+assertNotNull(taskIds, "Not null taskId list returned");
+assertEquals(1, taskIds.size(), "Single task Id returned");
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/security/auth/authorizer/DRPCSimpleACLAuthorizerTest.java:
##
@@ -68,101 +68,101 @@ private static ReqContext makeMockContext(String user) {
@Test
public void test_partial_authorization() {
-Assert.assertFalse("Deny execute to unauthroized user",
- isPermitted(strictHandler, ReqContext.context(),
"execute", partialFunction));
+assertFalse(isPermitted(strictHandler, ReqContext.context(),
"execute", partialFunction),
+"Deny execute to unauthorized user");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885708800
##
storm-client/test/jvm/org/apache/storm/grouping/LoadAwareShuffleGroupingTest.java:
##
@@ -204,24 +204,21 @@ private void
testLoadAwareShuffleGroupingWithEvenLoadMultiThreaded(int numTasks)
List> threadTasks = Lists.newArrayList();
for (int x = 0; x < numThreads; x++) {
-Callable threadTask = new Callable() {
-@Override
-public int[] call() throws Exception {
-int[] taskCounts = new int[availableTaskIds.size()];
-for (int i = 1; i <= groupingExecutionsPerThread; i++) {
-List taskIds =
grouper.chooseTasks(inputTaskId, Lists.newArrayList());
-
-// Validate a single task id return
-assertNotNull("Not null taskId list returned",
taskIds);
-assertEquals("Single task Id returned", 1,
taskIds.size());
-
-int taskId = taskIds.get(0);
-
-assertTrue("TaskId should exist", taskId >= 0 &&
taskId < availableTaskIds.size());
-taskCounts[taskId]++;
-}
-return taskCounts;
+Callable threadTask = () -> {
+int[] taskCounts = new int[availableTaskIds.size()];
+for (int i = 1; i <= groupingExecutionsPerThread; i++) {
+List taskIds = grouper.chooseTasks(inputTaskId,
Lists.newArrayList());
+
+// Validate a single task id return
+assertNotNull(taskIds, "Not null taskId list returned");
+assertEquals(1, taskIds.size(), "Single task Id returned");
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/grouping/LoadAwareShuffleGroupingTest.java:
##
@@ -385,12 +371,12 @@ private int[]
runChooseTasksWithVerification(LoadAwareShuffleGrouping grouper, i
.chooseTasks(inputTaskId, Lists.newArrayList());
// Validate a single task id return
-assertNotNull("Not null taskId list returned", taskIds);
-assertEquals("Single task Id returned", 1, taskIds.size());
+assertNotNull(taskIds, "Not null taskId list returned");
+assertEquals(1, taskIds.size(), "Single task Id returned");
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/grouping/ShuffleGroupingTest.java:
##
@@ -55,17 +55,17 @@ public void testShuffleGrouping() {
List taskIds = grouper.chooseTasks(inputTaskId,
Lists.newArrayList());
// Validate a single task id return
-assertNotNull("Not null taskId list returned", taskIds);
-assertEquals("Single task Id returned", 1, taskIds.size());
+assertNotNull(taskIds, "Not null taskId list returned");
+assertEquals(1, taskIds.size(), "Single task Id returned");
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885708268
##
storm-client/test/jvm/org/apache/storm/TestConfigValidate.java:
##
@@ -261,56 +250,57 @@ public void testWorkerChildoptsIsStringOrStringList()
throws InvocationTargetExc
try {
conf.put(Config.TOPOLOGY_WORKER_CHILDOPTS, value);
ConfigValidation.validateFields(conf);
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/TestConfigValidate.java:
##
@@ -261,56 +250,57 @@ public void testWorkerChildoptsIsStringOrStringList()
throws InvocationTargetExc
try {
conf.put(Config.TOPOLOGY_WORKER_CHILDOPTS, value);
ConfigValidation.validateFields(conf);
-Assert.fail("Expected Exception not Thrown for value: " +
value);
-} catch (IllegalArgumentException Ex) {
+fail("Expected Exception not Thrown for value: " + value);
+} catch (IllegalArgumentException ignore) {
}
}
}
@Test
public void testValidity() {
-Map conf = new HashMap();
+Map conf = new HashMap<>();
conf.put(Config.TOPOLOGY_DEBUG, true);
conf.put("q", "asasdasd");
-conf.put("aaa", new Integer("123"));
-conf.put("bbb", new Long("456"));
-List testList = new ArrayList();
+conf.put("aaa", Integer.valueOf("123"));
+conf.put("bbb", Long.valueOf("456"));
+List testList = new ArrayList<>();
testList.add(1);
testList.add(2);
-testList.add(new Integer("3"));
-testList.add(new Long("4"));
+testList.add(Integer.valueOf("3"));
+testList.add(Long.valueOf("4"));
testList.add(new Float("3"));
testList.add(new Double("4"));
testList.add(ImmutableList.of("asdf", 3));
conf.put("eee", testList);
-Assert.assertTrue(Utils.isValidConf(conf));
+assertTrue(Utils.isValidConf(conf));
}
@Test
public void testNonValidConfigChar() {
-Map conf = new HashMap();
+Map conf = new HashMap<>();
conf.put("q", ImmutableList.of("asdf", 'c'));
-Assert.assertFalse(Utils.isValidConf(conf));
+assertFalse(Utils.isValidConf(conf));
}
@Test
public void testNonValidConfigRandomObject() {
-Map conf = new HashMap();
+Map conf = new HashMap<>();
conf.put("q", ImmutableList.of("asdf", new TestConfigValidate()));
-Assert.assertFalse(Utils.isValidConf(conf));
+assertFalse(Utils.isValidConf(conf));
}
@Test
public void testKryoRegValidator() {
KryoRegValidator validator = new KryoRegValidator();
// fail cases
-Object[] failCases = { ImmutableMap.of("f", "g"), ImmutableList.of(1),
Arrays.asList(ImmutableMap.of("a", 1)) };
+Object[] failCases = { ImmutableMap.of("f", "g"), ImmutableList.of(1),
+Collections.singletonList(ImmutableMap.of("a", 1))};
for (Object value : failCases) {
try {
validator.validateField("test", value);
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/TestConfigValidate.java:
##
@@ -326,8 +316,8 @@ public void testPowerOf2Validator() {
for (Object value : failCases) {
try {
validator.validateField("test", value);
-Assert.fail("Expected Exception not Thrown for value: " +
value);
-} catch (IllegalArgumentException Ex) {
+fail("Expected Exception not Thrown for value: " + value);
+} catch (IllegalArgumentException ignore) {
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/TestConfigValidate.java:
##
@@ -352,8 +342,8 @@ public void testPositiveNumberValidator() {
for (Object value : failCases) {
try {
validator.validateField("test", value);
-Assert.fail("Expected Exception not Thrown for value: " +
value);
-} catch (IllegalArgumentException Ex) {
+fail("Expected Exception not Thrown for value: " + value);
+} catch (IllegalArgumentException ignore) {
}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885708005
##
sql/storm-sql-core/src/test/org/apache/storm/sql/TestStormSql.java:
##
@@ -29,13 +29,14 @@
import org.apache.storm.sql.runtime.ISqlStreamsDataSource;
import org.apache.storm.streams.Pair;
import org.apache.storm.tuple.Values;
-import org.junit.Assert;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Assertions;
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/TestConfigValidate.java:
##
@@ -245,13 +234,13 @@ public void testWorkerChildoptsIsStringOrStringList()
throws InvocationTargetExc
try {
conf.put(Config.WORKER_CHILDOPTS, value);
ConfigValidation.validateFields(conf);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885707398
##
flux/flux-core/src/test/java/org/apache/storm/flux/multilang/MultilangEnvironmentTest.java:
##
@@ -38,19 +38,19 @@ public class MultilangEnvironmentTest {
public void testInvokePython() throws Exception {
String[] command = new String[]{"python", "--version"};
int exitVal = invokeCommand(command);
-assertEquals("Exit value for python is 0.", 0, exitVal);
+assertEquals(0, exitVal, "Exit value for python is 0.");
}
@Test
public void testInvokeNode() throws Exception {
String[] command = new String[]{"node", "--version"};
int exitVal = invokeCommand(command);
-assertEquals("Exit value for node is 0.", 0, exitVal);
+assertEquals(0, exitVal, "Exit value for node is 0.");
Review Comment:
done
##
integration-test/src/test/java/org/apache/storm/st/tests/window/SlidingWindowTest.java:
##
@@ -60,7 +57,7 @@ public void testWindowCount(int windowSize, int slideSize)
throws Exception {
if (windowSize <= 0 || slideSize <= 0) {
try {
testable.newTopology();
-Assert.fail("Expected IllegalArgumentException was not
thrown.");
+fail("Expected IllegalArgumentException was not thrown.");
} catch (IllegalArgumentException ignore) {
return;
}
Review Comment:
done
##
integration-test/src/test/java/org/apache/storm/st/tests/window/SlidingWindowTest.java:
##
@@ -94,7 +90,7 @@ public void testTimeWindow(int windowSec, int slideSec)
throws Exception {
if (windowSec <= 0 || slideSec <= 0) {
try {
testable.newTopology();
-Assert.fail("Expected IllegalArgumentException was not
thrown.");
+fail("Expected IllegalArgumentException was not thrown.");
} catch (IllegalArgumentException ignore) {
return;
}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885707723
##
integration-test/src/test/java/org/apache/storm/st/tests/window/TumblingWindowTest.java:
##
@@ -53,7 +51,7 @@ public void testTumbleCount(int tumbleSize) throws Exception {
if (tumbleSize <= 0) {
try {
testable.newTopology();
-Assert.fail("Expected IllegalArgumentException was not
thrown.");
+fail("Expected IllegalArgumentException was not thrown.");
} catch (IllegalArgumentException ignore) {
return;
}
Review Comment:
done
##
integration-test/src/test/java/org/apache/storm/st/tests/window/TumblingWindowTest.java:
##
@@ -82,7 +80,7 @@ public void testTumbleTime(int tumbleSec) throws Exception {
if (tumbleSec <= 0) {
try {
testable.newTopology();
-Assert.fail("Expected IllegalArgumentException was not
thrown.");
+fail("Expected IllegalArgumentException was not thrown.");
} catch (IllegalArgumentException ignore) {
return;
}
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885706412
##
external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/UtilTest.java:
##
@@ -46,20 +46,7 @@ public void testBasic() {
@Test
public void testError() {
-//This test is rather ugly, but it is the only way to see if the error
messages are working correctly.
-try {
-Util.getJavaType(Types.REF);
-fail("didn't throw like expected");
-} catch (Exception e) {
-assertEquals("We do not support tables with SqlType: REF",
e.getMessage());
-}
-
-try {
-Util.getJavaType(-1000);
-fail("didn't throw like expected");
-} catch (Exception e) {
-assertEquals("Unknown sqlType -1000", e.getMessage());
-}
-
+assertThrows(RuntimeException.class, () ->
Util.getJavaType(Types.REF));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885706029
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// ack few
runSpout(spout, "a0", "a1", "a2");
reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
//ack rest
runSpout(spout, "a3", "a4");
reader = getField(spout, "reader");
-Assert.assertNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// go to next file
Path file2 = new Path(source.toString() + "/file2.txt");
createTextFile(file2, 5);
// Read 1 line
runSpout(spout, "r1");
-Assert.assertNotNull(getField(spout, "reader"));
-Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(getField(spout, "reader"));
+assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// ack 1 tuple
runSpout(spout, "a5");
-Assert.assertNotNull(getField(spout, "reader"));
-Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(getField(spout, "reader"));
+assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read and ack remaining lines
runSpout(spout, "r5", "a6", "a7", "a8", "a9");
-Assert.assertNull(getField(spout, "reader"));
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNull(getField(spout, "reader"));
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885705645
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// ack few
runSpout(spout, "a0", "a1", "a2");
reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// ack few
runSpout(spout, "a0", "a1", "a2");
reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
//ack rest
runSpout(spout, "a3", "a4");
reader = getField(spout, "reader");
-Assert.assertNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// ack few
runSpout(spout, "a0", "a1", "a2");
reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
//ack rest
runSpout(spout, "a3", "a4");
reader = getField(spout, "reader");
-Assert.assertNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
// go to next file
Path file2 = new Path(source.toString() + "/file2.txt");
createTextFile(file2, 5);
// Read 1 line
runSpout(spout, "r1");
-
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885705401
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/TestSequenceFileBolt.java:
##
@@ -40,38 +40,30 @@
import org.apache.storm.tuple.Tuple;
import org.apache.storm.tuple.TupleImpl;
import org.apache.storm.tuple.Values;
-import org.junit.After;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ExpectedException;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.extension.RegisterExtension;
import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
import org.mockito.runners.MockitoJUnitRunner;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions;
-@RunWith(MockitoJUnitRunner.class)
+@ExtendWith(MockitoExtension.class)
public class TestSequenceFileBolt {
private static final Logger LOG =
LoggerFactory.getLogger(TestSequenceFileBolt.class);
private static final String testRoot = "/unittest";
-@Rule
-public MiniDFSClusterRule dfsClusterRule = new MiniDFSClusterRule(() -> {
-Configuration conf = new Configuration();
-conf.set("fs.trash.interval", "10");
-conf.setBoolean("dfs.permissions", true);
-File baseDir = new File("./target/hdfs/").getAbsoluteFile();
-FileUtil.fullyDelete(baseDir);
-conf.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR,
baseDir.getAbsolutePath());
-return conf;
-});
-@Rule
-public ExpectedException thrown = ExpectedException.none();
+@RegisterExtension
+public static final MiniDFSClusterExtension DFS_CLUSTER_EXTENSION = new
MiniDFSClusterExtension();
Review Comment:
done
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(false, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/spout/TestHdfsSpout.java:
##
@@ -419,45 +419,45 @@ public void testMultipleFileConsumption_Ack() throws
Exception {
// read few lines from file1 dont ack
runSpout(spout, "r3");
FileReader reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(false, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(false, getBoolField(spout, "fileReadCompletely"));
// read remaining lines
runSpout(spout, "r3");
reader = getField(spout, "reader");
-Assert.assertNotNull(reader);
-Assert.assertEquals(true, getBoolField(spout,
"fileReadCompletely"));
+assertNotNull(reader);
+assertEquals(true, getBoolField(spout, "fileReadCompletely"));
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885705109
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/AvroGenericRecordBoltTest.java:
##
@@ -72,24 +73,17 @@ public class AvroGenericRecordBoltTest {
private static Schema schema2;
private static Tuple tuple1;
private static Tuple tuple2;
-@Rule
-public MiniDFSClusterRule dfsClusterRule = new MiniDFSClusterRule(() -> {
-Configuration conf = new Configuration();
-conf.set("fs.trash.interval", "10");
-conf.setBoolean("dfs.permissions", true);
-File baseDir = new File("./target/hdfs/").getAbsoluteFile();
-FileUtil.fullyDelete(baseDir);
-conf.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR,
baseDir.getAbsolutePath());
-return conf;
-});
+
+@RegisterExtension
+public static final MiniDFSClusterExtension DFS_CLUSTER_EXTENSION = new
MiniDFSClusterExtension();
Review Comment:
done
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/AvroGenericRecordBoltTest.java:
##
@@ -141,12 +136,12 @@ public void multipleTuplesOneFile() throws IOException {
bolt.execute(tuple1);
bolt.execute(tuple1);
-Assert.assertEquals(1, countNonZeroLengthFiles(testRoot));
+assertEquals(1, countNonZeroLengthFiles(testRoot));
verifyAllAvroFiles(testRoot);
}
@Test
-public void multipleTuplesMutliplesFiles() throws IOException {
+public void multipleTuplesMuliplesFiles() throws IOException {
Review Comment:
done
##
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/TestHdfsBolt.java:
##
@@ -43,36 +39,25 @@
import org.apache.storm.tuple.TupleImpl;
import org.apache.storm.tuple.Values;
import org.apache.storm.utils.MockTupleHelpers;
-import org.junit.After;
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ExpectedException;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.extension.RegisterExtension;
import org.mockito.Mock;
-import org.mockito.runners.MockitoJUnitRunner;
+import org.mockito.junit.jupiter.MockitoExtension;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions;
-@RunWith(MockitoJUnitRunner.class)
+@ExtendWith(MockitoExtension.class)
public class TestHdfsBolt {
-
+@RegisterExtension
+public static final MiniDFSClusterExtension DFS_CLUSTER_EXTENSION = new
MiniDFSClusterExtension();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885141605
##
storm-client/test/jvm/org/apache/storm/dependency/DependencyUploaderTest.java:
##
@@ -63,51 +63,55 @@ public class DependencyUploaderTest {
private DependencyUploader sut;
private ClientBlobStore mockBlobStore;
-@Before
+@BeforeEach
public void setUp() throws Exception {
sut = new DependencyUploader();
mockBlobStore = mock(ClientBlobStore.class);
sut.setBlobStore(mockBlobStore);
doNothing().when(mockBlobStore).shutdown();
}
-@After
+@AfterEach
public void tearDown() throws Exception {
sut.shutdown();
}
-@Test(expected = FileNotAvailableException.class)
-public void uploadFilesWhichOneOfThemIsNotFoundInLocal() throws Exception {
-File mockFile = mock(File.class);
-when(mockFile.isFile()).thenReturn(true);
-when(mockFile.exists()).thenReturn(true);
-
-File mockFile2 = mock(File.class);
-when(mockFile.isFile()).thenReturn(true);
-when(mockFile.exists()).thenReturn(false);
-
-List dependencies = new ArrayList<>();
-dependencies.add(mockFile);
-dependencies.add(mockFile2);
-
-sut.uploadFiles(dependencies, false);
-fail("Should throw FileNotAvailableException");
+@Test
+public void uploadFilesWhichOneOfThemIsNotFoundInLocal() {
+assertThrows(FileNotAvailableException.class, () -> {
+File mockFile = mock(File.class);
+when(mockFile.isFile()).thenReturn(true);
+when(mockFile.exists()).thenReturn(true);
+
+File mockFile2 = mock(File.class);
+when(mockFile.isFile()).thenReturn(true);
+when(mockFile.exists()).thenReturn(false);
+
+List dependencies = new ArrayList<>();
+dependencies.add(mockFile);
+dependencies.add(mockFile2);
+
+sut.uploadFiles(dependencies, false);
+});
+// fail("Should throw FileNotAvailableException");
Review Comment:
done
##
storm-client/test/jvm/org/apache/storm/dependency/DependencyUploaderTest.java:
##
@@ -63,51 +63,55 @@ public class DependencyUploaderTest {
private DependencyUploader sut;
private ClientBlobStore mockBlobStore;
-@Before
+@BeforeEach
public void setUp() throws Exception {
sut = new DependencyUploader();
mockBlobStore = mock(ClientBlobStore.class);
sut.setBlobStore(mockBlobStore);
doNothing().when(mockBlobStore).shutdown();
}
-@After
+@AfterEach
public void tearDown() throws Exception {
sut.shutdown();
}
-@Test(expected = FileNotAvailableException.class)
-public void uploadFilesWhichOneOfThemIsNotFoundInLocal() throws Exception {
-File mockFile = mock(File.class);
-when(mockFile.isFile()).thenReturn(true);
-when(mockFile.exists()).thenReturn(true);
-
-File mockFile2 = mock(File.class);
-when(mockFile.isFile()).thenReturn(true);
-when(mockFile.exists()).thenReturn(false);
-
-List dependencies = new ArrayList<>();
-dependencies.add(mockFile);
-dependencies.add(mockFile2);
-
-sut.uploadFiles(dependencies, false);
-fail("Should throw FileNotAvailableException");
+@Test
+public void uploadFilesWhichOneOfThemIsNotFoundInLocal() {
+assertThrows(FileNotAvailableException.class, () -> {
+File mockFile = mock(File.class);
+when(mockFile.isFile()).thenReturn(true);
+when(mockFile.exists()).thenReturn(true);
+
+File mockFile2 = mock(File.class);
+when(mockFile.isFile()).thenReturn(true);
+when(mockFile.exists()).thenReturn(false);
+
+List dependencies = new ArrayList<>();
+dependencies.add(mockFile);
+dependencies.add(mockFile2);
+
+sut.uploadFiles(dependencies, false);
+});
+// fail("Should throw FileNotAvailableException");
}
-@Test(expected = FileNotAvailableException.class)
-public void uploadFilesWhichOneOfThemIsNotFile() throws Exception {
-File mockFile = mock(File.class);
-when(mockFile.isFile()).thenReturn(true);
-when(mockFile.exists()).thenReturn(true);
+@Test
+public void uploadFilesWhichOneOfThemIsNotFile() {
+assertThrows(FileNotAvailableException.class, () -> {
+File mockFile = mock(File.class);
+when(mockFile.isFile()).thenReturn(true);
+when(mockFile.exists()).thenReturn(true);
-File mockFile2 = mock(File.class);
-when(mockFile.isFile()).thenReturn(false);
-when(mockFile.exists()).thenReturn(true);
+File mockFile2 = mock(File.class);
+when(mockFile.isFile()).thenReturn(false);
+
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885141228
##
storm-client/test/jvm/org/apache/storm/TestConfigValidate.java:
##
@@ -822,20 +805,19 @@ public void TestImpersonationAclUserEntryValidator()
throws InvocationTargetExce
for (Object value : passCases) {
config.put(TestConfig.TEST_MAP_CONFIG_6, value);
-ConfigValidation.validateFields(config,
Arrays.asList(TestConfig.class));
+ConfigValidation.validateFields(config,
Collections.singletonList(TestConfig.class));
}
-Map>> failCase1 = new HashMap>>();
-Map> failCase1_hostsAndGroups = new
HashMap>();
-String[] failhosts = { "host.1", "host.2", "host.3" };
+Map>> failCase1 = new HashMap<>();
+Map> failCase1_hostsAndGroups = new HashMap<>();
failCase1_hostsAndGroups.put("hosts", Arrays.asList(hosts));
failCase1.put("jerry", failCase1_hostsAndGroups);
-Map>> failCase2 = new HashMap>>();
-Map> failCase2_hostsAndGroups = new
HashMap>();
+Map>> failCase2 = new HashMap<>();
+Map> failCase2_hostsAndGroups = new HashMap<>();
String[] failgroups = { "group.1", "group.2", "group.3" };
-failCase2_hostsAndGroups.put("groups", Arrays.asList(groups));
+failCase2_hostsAndGroups.put("groups", Arrays.asList(groups)); //
should this be failGroups ?
Review Comment:
removed comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885140762
##
external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java:
##
@@ -88,24 +86,19 @@ public void testInsertConnectionError() {
this.client = new JdbcClient(connectionProvider, 60);
List row = createRow(1, "frank");
-List> rows = new ArrayList>();
+List> rows = new ArrayList<>();
rows.add(row);
String query = "insert into user_details values(?,?,?)";
-thrown.expect(MultipleFailureException.class);
-client.executeInsertQuery(query, rows);
+assertThrows(RuntimeException.class, () ->
client.executeInsertQuery(query, rows));
+assertThrows(RuntimeException.class, () -> client.executeSql("drop
table " + tableName));
Review Comment:
MultipleFailureException was catching these two exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] snikhil5 commented on a diff in pull request #3479: [STORM-3832] Moving unit tests from junit4 to junit5
snikhil5 commented on code in PR #3479:
URL: https://github.com/apache/storm/pull/3479#discussion_r885140028
##
external/storm-jdbc/src/test/java/org/apache/storm/jdbc/common/JdbcClientTest.java:
##
@@ -88,24 +86,19 @@ public void testInsertConnectionError() {
this.client = new JdbcClient(connectionProvider, 60);
List row = createRow(1, "frank");
-List> rows = new ArrayList>();
+List> rows = new ArrayList<>();
rows.add(row);
String query = "insert into user_details values(?,?,?)";
-thrown.expect(MultipleFailureException.class);
-client.executeInsertQuery(query, rows);
+assertThrows(RuntimeException.class, () ->
client.executeInsertQuery(query, rows));
Review Comment:
this was junit4
https://junit.org/junit4/javadoc/4.12/org/junit/runners/model/MultipleFailureException.html
... not used anymore
##
external/storm-hdfs-blobstore/src/test/java/org/apache/storm/hdfs/blobstore/BlobStoreTest.java:
##
@@ -62,10 +61,9 @@ public class BlobStoreTest {
public static final MiniDFSClusterExtension DFS_CLUSTER_EXTENSION = new
MiniDFSClusterExtension();
private static final Logger LOG =
LoggerFactory.getLogger(BlobStoreTest.class);
-URI base;
private static final Map CONF = new HashMap<>();
public static final int READ = 0x01;
-public static final int WRITE = 0x02;
+// public static final int WRITE = 0x02;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [storm] dependabot[bot] opened a new pull request, #3483: Bump elasticsearch from 2.4.4 to 6.8.17 in /examples/storm-elasticsearch-examples
dependabot[bot] opened a new pull request, #3483: URL: https://github.com/apache/storm/pull/3483 Bumps [elasticsearch](https://github.com/elastic/elasticsearch) from 2.4.4 to 6.8.17. Release notes Sourced from https://github.com/elastic/elasticsearch/releases;>elasticsearch's releases. Elasticsearch 6.8.17 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.17.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.17.html Elasticsearch 6.8.16 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.16.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.16.html Elasticsearch 6.8.15 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.15.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.15.html Elasticsearch 6.8.14 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.14.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.14.html Elasticsearch 6.8.13 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.13.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.13.html Elasticsearch 6.8.12 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.12.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.12.html Elasticsearch 6.8.11 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.11.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.11.html Elasticsearch 6.8.10 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.10.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.10.html Elasticsearch 6.8.9 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.9.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.9.html Elasticsearch 6.8.8 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.8.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.8.html Elasticsearch 6.8.7 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.7.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.7.html Elasticsearch 6.8.6 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch Release notes: https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.6.html;>https://www.elastic.co/guide/en/elasticsearch/reference/6.8/release-notes-6.8.6.html Elasticsearch 6.8.5 Downloads: https://elastic.co/downloads/elasticsearch;>https://elastic.co/downloads/elasticsearch ... (truncated) Commits https://github.com/elastic/elasticsearch/commit/206f6a2512f2ca690999b77a5c759ab214536b82;>206f6a2 Improve efficiency of Grok circular reference check (https://github-redirect.dependabot.com/elastic/elasticsearch/issues/74814;>#74814) https://github.com/elastic/elasticsearch/commit/fc90c8878877aae38cec24ee1c4cb15966951b08;>fc90c88 [6.8] Improve circular reference detection in grok processor (https://github-redirect.dependabot.com/elastic/elasticsearch/issues/74581;>#74581) (https://github-redirect.dependabot.com/elastic/elasticsearch/issues/74772;>#74772) https://github.com/elastic/elasticsearch/commit/c3ea8df0f36e7f17b24dfe65cd20f101a502d0bb;>c3ea8df Remove race in ensure remote connection test
