[jira] [Created] (STORM-1688) provide ParallismKillWorkerManager to shutdown workers in parallel
caofangkun created STORM-1688: - Summary: provide ParallismKillWorkerManager to shutdown workers in parallel Key: STORM-1688 URL: https://issues.apache.org/jira/browse/STORM-1688 Project: Apache Storm Issue Type: Improvement Components: storm-core Affects Versions: 2.0.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: [STORM-1567] in defaults.yaml 'topology.disabl...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/1135 [STORM-1567] in defaults.yaml 'topology.disable.loadaware' should be 'topology.disable.loadaware.messaging' You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-1567 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/1135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1135 commit 045dd814e6f5beec7b560d5435de71612ef04ade Author: ablecao <able...@tencent.com> Date: 2016-02-22T09:36:54Z [STORM-1567] in defaults.yaml 'topology.disable.loadaware' should be 'topology.disable.loadaware.messaging' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (STORM-1567) in defaults.yaml 'topology.disable.loadaware' should be 'topology.disable.loadaware.messaging'
[
https://issues.apache.org/jira/browse/STORM-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
caofangkun updated STORM-1567:
--
Description:
{code:title=defaults.yaml|borderStyle=solid}
diff --git a/conf/defaults.yaml b/conf/defaults.yaml
index 166b249..01821e1 100644
--- a/conf/defaults.yaml
+++ b/conf/defaults.yaml
@@ -256,7 +256,7 @@ topology.bolts.outgoing.overflow.buffer.enable: false
topology.disruptor.wait.timeout.millis: 1000
topology.disruptor.batch.size: 100
topology.disruptor.batch.timeout.millis: 1
-topology.disable.loadaware: false
+topology.disable.loadaware.messaging: false
topology.state.checkpoint.interval.ms: 1000
# Configs for Resource Aware Scheduler
{code}
was:
```
diff --git a/conf/defaults.yaml b/conf/defaults.yaml
index 166b249..01821e1 100644
--- a/conf/defaults.yaml
+++ b/conf/defaults.yaml
@@ -256,7 +256,7 @@ topology.bolts.outgoing.overflow.buffer.enable: false
topology.disruptor.wait.timeout.millis: 1000
topology.disruptor.batch.size: 100
topology.disruptor.batch.timeout.millis: 1
-topology.disable.loadaware: false
+topology.disable.loadaware.messaging: false
topology.state.checkpoint.interval.ms: 1000
# Configs for Resource Aware Scheduler
```
> in defaults.yaml 'topology.disable.loadaware' should be
> 'topology.disable.loadaware.messaging'
> ---
>
> Key: STORM-1567
> URL: https://issues.apache.org/jira/browse/STORM-1567
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
>Affects Versions: 2.0.0
>Reporter: caofangkun
>Assignee: caofangkun
>Priority: Trivial
>
> {code:title=defaults.yaml|borderStyle=solid}
> diff --git a/conf/defaults.yaml b/conf/defaults.yaml
> index 166b249..01821e1 100644
> --- a/conf/defaults.yaml
> +++ b/conf/defaults.yaml
> @@ -256,7 +256,7 @@ topology.bolts.outgoing.overflow.buffer.enable: false
> topology.disruptor.wait.timeout.millis: 1000
> topology.disruptor.batch.size: 100
> topology.disruptor.batch.timeout.millis: 1
> -topology.disable.loadaware: false
> +topology.disable.loadaware.messaging: false
> topology.state.checkpoint.interval.ms: 1000
>
> # Configs for Resource Aware Scheduler
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (STORM-1567) in defaults.yaml 'topology.disable.loadaware' should be 'topology.disable.loadaware.messaging'
caofangkun created STORM-1567: - Summary: in defaults.yaml 'topology.disable.loadaware' should be 'topology.disable.loadaware.messaging' Key: STORM-1567 URL: https://issues.apache.org/jira/browse/STORM-1567 Project: Apache Storm Issue Type: Bug Components: storm-core Affects Versions: 2.0.0 Reporter: caofangkun Assignee: caofangkun Priority: Trivial ``` diff --git a/conf/defaults.yaml b/conf/defaults.yaml index 166b249..01821e1 100644 --- a/conf/defaults.yaml +++ b/conf/defaults.yaml @@ -256,7 +256,7 @@ topology.bolts.outgoing.overflow.buffer.enable: false topology.disruptor.wait.timeout.millis: 1000 topology.disruptor.batch.size: 100 topology.disruptor.batch.timeout.millis: 1 -topology.disable.loadaware: false +topology.disable.loadaware.messaging: false topology.state.checkpoint.interval.ms: 1000 # Configs for Resource Aware Scheduler ``` -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: [STORM-1501] launch worker process exception w...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/1046 [STORM-1501] launch worker process exception will cause supervisor process exited [util.clj/async-loop](https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/util.clj#L474) default kill-fn will kill current process when supervisor use [util.clj/launch-process](https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/util.clj#L546) to launch worker process , if exeception occurs , supervisor process will exit. You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-1501-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/1046.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1046 commit 21ef59cadbe4204a0152cef5cf58dffcd928a469 Author: caofangkun <caofang...@gmail.com> Date: 2016-01-26T08:04:53Z [STORM-1501] launch worker process exception will cause supervisor process exited --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-1501) launch worker process exception will cause supervisor process exited
caofangkun created STORM-1501: - Summary: launch worker process exception will cause supervisor process exited Key: STORM-1501 URL: https://issues.apache.org/jira/browse/STORM-1501 Project: Apache Storm Issue Type: Bug Components: storm-core Affects Versions: 2.0.0 Reporter: caofangkun Assignee: caofangkun Priority: Trivial [util.clj/async-loop | https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/util.clj#L474] default kill-fn will kill current process when supervisor use [util.clj/launch-process | https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/util.clj#L546] to launch worker process , if exeception occurs , supervisor process will exit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: [STORM-1453] nimbus.clj/wait-for-desired-code-...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/1003 [STORM-1453] nimbus.clj/wait-for-desired-code-replication print wrong log message You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-1453-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/1003.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1003 commit 64a57a39fe1d4b0a1f3d15a264eb3335d72e1af6 Author: ablecao <able...@tencent.com> Date: 2016-01-12T01:38:41Z [STORM-1453] nimbus.clj/wait-for-desired-code-replication print wrong log message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-1453] nimbus.clj/wait-for-desired-code-...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/996#issuecomment-170755067 Updated as PR #1003 Close this PR . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-1453] nimbus.clj/wait-for-desired-code-...
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/996 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-1453) nimbus.clj/wait-for-desired-code-replication print wrong log message
caofangkun created STORM-1453: - Summary: nimbus.clj/wait-for-desired-code-replication print wrong log message Key: STORM-1453 URL: https://issues.apache.org/jira/browse/STORM-1453 Project: Apache Storm Issue Type: Bug Components: storm-core Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Trivial https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/daemon/nimbus.clj#L516 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: [STORM-1453] nimbus.clj/wait-for-desired-code-...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/996 [STORM-1453] nimbus.clj/wait-for-desired-code-replication print wrong log message You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-1453 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/996.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #996 commit ed25dfda1f47a6fffcaea681f0a395f274ff1bf6 Author: ablecao <able...@tencent.com> Date: 2016-01-08T08:56:58Z [STORM-1453] nimbus.clj/wait-for-desired-code-replication print wrong log message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-668] add external project storm-ui and ...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/992 [STORM-668] add external project storm-ui and generate storm-ui.war and could be deployed on TomCat You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-668-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/992.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #992 commit d9df434d8fdb85184103d60a5ccf4e95d2eec219 Author: ablecao <able...@tencent.com> Date: 2016-01-06T03:34:23Z [STORM-668] add external project storm-ui and generate storm-ui.war and could be deployed on TomCat commit 7c77deaba85b86ec3b9cc94142dd7a136252d195 Author: ablecao <able...@tencent.com> Date: 2016-01-06T03:37:22Z [STORM-668] add README.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-668:Generate storm-ui.war and could be d...
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-1427) add TupleUtils/listHashCode method and delete tuple.clj
caofangkun created STORM-1427: - Summary: add TupleUtils/listHashCode method and delete tuple.clj Key: STORM-1427 URL: https://issues.apache.org/jira/browse/STORM-1427 Project: Apache Storm Issue Type: Bug Components: storm-core Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (STORM-1424) Removed unused topology-path variable in config.clj/read-supervisor-storm-conf
caofangkun created STORM-1424: - Summary: Removed unused topology-path variable in config.clj/read-supervisor-storm-conf Key: STORM-1424 URL: https://issues.apache.org/jira/browse/STORM-1424 Project: Apache Storm Issue Type: Bug Components: storm-core Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: [STORM-1424] Removed unused topology-path vari...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/981 [STORM-1424] Removed unused topology-path variable You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-1424 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/981.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #981 commit 678e6eaf9b5e84c484e7da594933188fca563bcd Author: ablecao <able...@tencent.com> Date: 2015-12-29T01:31:51Z [STORM-1424] Removed unused topology-path variable in config.clj/read-supervisor-storm-conf --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: fastfix-01:Removed unused topology-path variab...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/469#issuecomment-167691552 @d2r this branch is outdated, I fired a new PR #981 and created jira [STORM-1424](https://issues.apache.org/jira/browse/STORM-1424) for it . So close this first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: fastfix-01:Removed unused topology-path variab...
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-1426] keep backtype.storm.tuple.Address...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/983 [STORM-1426] keep backtype.storm.tuple.AddressedTuple and delete duplicated backtype.storm.messaging.AddressedTuple You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-1426 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/983.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #983 commit 5978612d2d5f9bd0fb44714d7056dfcc70d57596 Author: ablecao <able...@tencent.com> Date: 2015-12-29T07:08:54Z [STORM-1426] keep backtype.storm.tuple.AddressedTuple and delete duplicated backtype.storm.messaging.AddressedTuple --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-1426) keep backtype.storm.tuple.AddressedTuple and delete duplicated backtype.storm.messaging.AddressedTuple
caofangkun created STORM-1426: - Summary: keep backtype.storm.tuple.AddressedTuple and delete duplicated backtype.storm.messaging.AddressedTuple Key: STORM-1426 URL: https://issues.apache.org/jira/browse/STORM-1426 Project: Apache Storm Issue Type: Bug Components: storm-core Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: Update timer.clj
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/680#discussion_r36937217 --- Diff: storm-core/src/clj/backtype/storm/timer.clj --- @@ -53,8 +53,11 @@ ;; event generation. If any recurring events ;; are scheduled then we will always go ;; through this branch, sleeping only the - ;; exact necessary amount of time. - (Time/sleep (- time-millis (current-time-millis))) + ;; exact necessary amount of time. We give + ;; an upper bound, e.g. 1000 millis, to the + ;; sleeping time, to limit the response time + ;; for detecting any new event within 1 secs. + (Time/sleep (max 1000 (- time-millis (current-time-millis --- End diff -- I think this shoud use ``` min``` to limit the time. ```(Time/sleep (min 1000 (- time-millis (current-time-millis``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-974 Introduces Tuple - ES document mapp...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/679#discussion_r36938144 --- Diff: external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/trident/EsStateFactory.java --- @@ -19,6 +19,7 @@ import backtype.storm.task.IMetricsContext; import org.apache.storm.elasticsearch.common.EsConfig; +import org.apache.storm.elasticsearch.common.EsTupleMapper; import org.slf4j.Logger; import org.slf4j.LoggerFactory; --- End diff -- this two line slf4j imports could be removed too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-974 Introduces Tuple - ES document mapp...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/679#discussion_r36938292 --- Diff: external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/bolt/EsPercolateBoltTest.java --- @@ -21,6 +21,7 @@ import backtype.storm.tuple.Values; import org.apache.storm.elasticsearch.common.EsConfig; import org.apache.storm.elasticsearch.common.EsTestUtil; +import org.apache.storm.elasticsearch.common.EsTupleMapper; import org.elasticsearch.action.count.CountResponse; import org.elasticsearch.action.percolate.PercolateResponse; import org.elasticsearch.index.query.TermQueryBuilder; --- End diff -- Line 25 27 28 unneeded imports --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-988) supervisor.slots.ports should not allow duplicate element values
caofangkun created STORM-988: Summary: supervisor.slots.ports should not allow duplicate element values Key: STORM-988 URL: https://issues.apache.org/jira/browse/STORM-988 Project: Apache Storm Issue Type: Bug Reporter: caofangkun Assignee: caofangkun Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-974 Introduces Tuple - ES document mapp...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/679#discussion_r36938034 --- Diff: external/storm-elasticsearch/src/main/java/org/apache/storm/elasticsearch/bolt/EsPercolateBolt.java --- @@ -31,14 +32,21 @@ --- End diff -- Trivial, this two line imports could be removed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-974 Introduces Tuple - ES document mapp...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/679#discussion_r36938233 --- Diff: external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/bolt/EsIndexBoltTest.java --- @@ -20,6 +20,7 @@ import backtype.storm.tuple.Tuple; import org.apache.storm.elasticsearch.common.EsConfig; import org.apache.storm.elasticsearch.common.EsTestUtil; +import org.apache.storm.elasticsearch.common.EsTupleMapper; import org.elasticsearch.action.count.CountRequest; import org.elasticsearch.action.count.CountRequestBuilder; import org.elasticsearch.action.count.CountResponse; --- End diff -- Line 24 25 27 are unnecessary imports too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-988: supervisor.slots.ports should not a...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/681 STORM-988: supervisor.slots.ports should not allow duplicate element values You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-988 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/681.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #681 commit 26ea627fb39fb84f31de773e650318a81eba8bd4 Author: caofangkun caofang...@gmail.com Date: 2015-08-13T02:41:23Z STORM-988: supervisor.slots.ports should not allow duplicate element values --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-949] On the topology summary UI page, a...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/675#discussion_r36819256 --- Diff: storm-core/src/ui/public/templates/topology-page-template.html --- @@ -313,6 +320,10 @@ /th th class=headerLast error /th + th class=header --- End diff -- @HeartSaVioR Code style shoud be checked before commit , shall we provide ```.editorconfig ``` with git pre-commit hooks``` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-985) provide .editorconfig with git pre-commit hooks to check code style before commit
caofangkun created STORM-985: Summary: provide .editorconfig with git pre-commit hooks to check code style before commit Key: STORM-985 URL: https://issues.apache.org/jira/browse/STORM-985 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (STORM-986) Caching maven dependencies to speedup CI builds
caofangkun created STORM-986:
Summary: Caching maven dependencies to speedup CI builds
Key: STORM-986
URL: https://issues.apache.org/jira/browse/STORM-986
Project: Apache Storm
Issue Type: Improvement
Reporter: caofangkun
Assignee: caofangkun
Priority: Trivial
See: http://docs.travis-ci.com/user/caching/
Modify
{code}
diff --git a/.travis.yml b/.travis.yml
index a7e2df4..d6e3c8b 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -13,6 +13,9 @@ language: java
jdk:
- oraclejdk7
- oraclejdk8
+cache:
+ directories:
+ - $HOME/.m2/repository
before_install:
- rvm use 2.1.5 --install
- nvm install 0.12.2
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] storm pull request: STORM-986: Caching maven dependencies to speed...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/677 STORM-986: Caching maven dependencies to speedup CI builds You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-986 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/677.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #677 commit 40ed9be608b4e10831f813c26393c78c95261811 Author: caofangkun caofang...@gmail.com Date: 2015-08-12T03:14:28Z STORM-986: Caching maven dependencies to speedup CI builds --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-977 Correct log prefix (-15) when sendin...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/672#discussion_r36708996 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -262,7 +262,7 @@ (psim/kill-process thread-pid)) (doseq [pid pids] (if as-user -(worker-launcher-and-wait conf user [signal pid 9] :log-prefix (str kill -15 pid)) +(worker-launcher-and-wait conf user [signal pid 9] :log-prefix (str kill -9 pid)) --- End diff -- I think should change the signal value but not the ```log-prefix``` should be ```(worker-launcher-and-wait conf user [signal pid 15] :log-prefix (str kill -15 pid))``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-977 Correct log prefix (-15) when sendin...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/672#issuecomment-129691333 The travis ci build failed does not make sense , Does ``` export STORM_TEST_TIMEOUT_MS=10``` not long enough ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-959:remove unnecessary dependency from s...
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/652 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-904: Move bin/storm command line to java...
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/662#discussion_r36284000
--- Diff: storm-core/src/jvm/backtype/storm/utils/StormCommandExecutor.java
---
@@ -0,0 +1,785 @@
+package backtype.storm.utils;
+
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.lang.reflect.InvocationTargetException;
+import java.lang.reflect.Method;
+import java.nio.charset.StandardCharsets;
+import java.util.*;
+
+import clojure.lang.IFn;
+import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang.SystemUtils;
+
+/**
+ * Created by pshah on 7/17/15.
+ */
+abstract class StormCommandExecutor {
+final String NIMBUS_CLASS = backtype.storm.daemon.nimbus;
+final String SUPERVISOR_CLASS = backtype.storm.daemon.supervisor;
+final String UI_CLASS = backtype.storm.ui.core;
+final String LOGVIEWER_CLASS = backtype.storm.daemon.logviewer;
+final String DRPC_CLASS = backtype.storm.daemon.drpc;
+final String REPL_CLASS = clojure.main;
+final String ACTIVATE_CLASS = backtype.storm.command.activate;
+final String DEACTIVATE_CLASS = backtype.storm.command.deactivate;
+final String REBALANCE_CLASS = backtype.storm.command.rebalance;
+final String LIST_CLASS = backtype.storm.command.list;
+String stormHomeDirectory;
+String userConfDirectory;
+String stormConfDirectory;
+String clusterConfDirectory;
+String stormLibDirectory;
+String stormBinDirectory;
+String stormLog4jConfDirectory;
+String configFile = ;
+String javaCommand;
+ListString configOptions = new ArrayListString();
+String stormExternalClasspath;
+String stormExternalClasspathDaemon;
+String fileSeparator;
+final ListString COMMANDS = Arrays.asList(jar, kill, shell,
+nimbus, ui, logviewer, drpc, supervisor,
+localconfvalue, remoteconfvalue, repl, classpath,
+activate, deactivate, rebalance, help, list,
+dev-zookeeper, version, monitor, upload-credentials,
+get-errors);
+
+public static void main (String[] args) {
+for (String arg : args) {
+System.out.println(Argument ++ is + arg);
+}
+StormCommandExecutor stormCommandExecutor;
+if (System.getProperty(os.name).startsWith(Windows)) {
+stormCommandExecutor = new WindowsStormCommandExecutor();
+} else {
+stormCommandExecutor = new UnixStormCommandExecutor();
+}
+stormCommandExecutor.initialize();
+stormCommandExecutor.execute(args);
+}
+
+StormCommandExecutor () {
+
+}
+
+abstract void initialize ();
+
+abstract void execute (String[] args);
+
+void callMethod (String command, ListString args) {
+Class implementation = this.getClass();
+String methodName = command.replace(-, ) + Command;
+try {
+Method method = implementation.getDeclaredMethod(methodName,
List
+.class);
+method.invoke(this, args);
+} catch (NoSuchMethodException ex) {
+System.out.println(No such method exception occured while
trying +
+ to run storm method + command);
+} catch (IllegalAccessException ex) {
+System.out.println(Illegal access exception occured while
trying +
+ to run storm method + command);
+} catch (IllegalArgumentException ex) {
+System.out.println(Illegal argument exception occured while
+
+trying + to run storm method + command);
+} catch (InvocationTargetException ex) {
+System.out.println(Invocation target exception occured while
+
+trying + to run storm method + command);
+}
+}
+}
+
+class UnixStormCommandExecutor extends StormCommandExecutor {
+
+UnixStormCommandExecutor () {
+
+}
+
+void initialize () {
+Collections.sort(this.COMMANDS);
+this.fileSeparator = System .getProperty (file.separator);
+this.stormHomeDirectory = System.getenv(STORM_BASE_DIR);
+this.userConfDirectory = System.getProperty(user.home) +
+this.fileSeparator + +
+.storm;
+this.stormConfDirectory = System.getenv(STORM_CONF_DIR);
+this.clusterConfDirectory = this.stormConfDirectory == null ?
(this
+.stormHomeDirectory + this.fileSeparator
[jira] [Closed] (STORM-970) UT messaging_test.clj#test-receiver-message-order build failed
[
https://issues.apache.org/jira/browse/STORM-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
caofangkun closed STORM-970.
Resolution: Not A Problem
When I set STORM_TEST_TIMEOUT_MS larger , the UT passed.
{code}
➜ storm git:(storm-970) export STORM_TEST_TIMEOUT_MS=10
➜ storm git:(storm-970) dev-tools/test-ns.py backtype.storm.messaging-test
...
2397 [main] INFO b.s.u.Utils - Using defaults.yaml from resources
Running backtype.storm.messaging-test
Tests run: 2, Passed: 3, Failures: 0, Errors: 0
...
{code}
UT messaging_test.clj#test-receiver-message-order build failed
---
Key: STORM-970
URL: https://issues.apache.org/jira/browse/STORM-970
Project: Apache Storm
Issue Type: Bug
Affects Versions: 0.11.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
the CI always build error recently and the failure looks really spurious
Then I build the tests locally and find :
{code}
➜ storm git:(master) dev-tools/test-ns.py backtype.storm.messaging-test
...
[main] INFO b.s.u.Utils - Using defaults.yaml from resources
Running backtype.storm.messaging-test
Tests run: 2, Passed: 2, Failures: 0, Errors: 1(!!!Error occurred but
travis-ci does not push this info out)
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 39.593 s
[INFO] Finished at: 2015-08-05T15:20:26+08:00
[INFO] Final Memory: 27M/205M
[INFO]
[ERROR] Failed to execute goal
com.theoryinpractise:clojure-maven-plugin:1.7.1:test (test-clojure) on
project storm-core: Clojure failed. - [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal com.theoryinpractise:clojure-maven-plugin:1.7.1:test (test-clojure) on
project storm-core: Clojure failed.
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:862)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:286)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:197)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Clojure failed.
at
com.theoryinpractise.clojure.AbstractClojureCompilerMojo.callClojureWith(AbstractClojureCompilerMojo.java:464)
at
com.theoryinpractise.clojure.AbstractClojureCompilerMojo.callClojureWith(AbstractClojureCompilerMojo.java:366)
at
com.theoryinpractise.clojure.ClojureRunTestWithJUnitMojo.execute(ClojureRunTestWithJUnitMojo.java:138)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
... 20 more
{code}
Seems like something went wrong of UT
{code}
messaging_test.clj#test-receiver-message-order
{code}
https://github.com/apache/storm/blob/master/storm-core/test/clj/backtype/storm/messaging_test.clj#L85
--
This message was sent
[GitHub] storm pull request: Storm-Kafka trident topology example
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/666#discussion_r36169516 --- Diff: examples/storm-starter/pom.xml --- @@ -96,6 +96,12 @@ groupIdcom.google.guava/groupId artifactIdguava/artifactId /dependency +dependency + groupIdorg.apache.storm/groupId + artifactIdstorm-kafka/artifactId --- End diff -- should move ``` moduleexamples/storm-starter/module``` in [pom.xml](https://github.com/apache/storm/blob/master/pom.xml#L164) after ```moduleexternal/flux/module``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-966 ConfigValidation.DoubleValidator is ...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/658#issuecomment-127811188 I checked the CI build log and find https://travis-ci.org/apache/storm/jobs/74073153#L4132 and there's a PR on this , @HeartSaVioR Could you please review #652 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-966 ConfigValidation.DoubleValidator is ...
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/658#discussion_r36149821
--- Diff: storm-core/src/jvm/backtype/storm/ConfigValidation.java ---
@@ -28,7 +28,6 @@
/**
* Declares methods for validating configuration values.
*/
-public static interface FieldValidator {
--- End diff --
This interface should not be annotated.
Could you please have a check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Closed] (STORM-751) Move javadoc aggregate to site phase.
[
https://issues.apache.org/jira/browse/STORM-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
caofangkun closed STORM-751.
Resolution: Fixed
Fixed in
https://github.com/apache/storm/commit/e2e17e1c7899fb918562bbad21a7e68394b5f285#diff-600376dffeb79835ede4a0b285078036
Move javadoc aggregate to site phase.
-
Key: STORM-751
URL: https://issues.apache.org/jira/browse/STORM-751
Project: Apache Storm
Issue Type: Bug
Components: storm-hbase
Affects Versions: 0.10.0
Environment: Storm build fails in package phase, as javadoc aggregate
looks for storm-core, which is not built.
Reporter: Ashish Singh
Assignee: Ashish Singh
Priority: Critical
Fix For: 0.10.0, 0.11.0
Attachments: 0001-STORM-751-Move-javadoc-aggregate-to-site-phase.patch
{code}
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] Storm . FAILURE [5.904s]
[INFO] maven-shade-clojure-transformer ... SKIPPED
[INFO] storm-maven-plugins ... SKIPPED
[INFO] Storm Core SKIPPED
[INFO] storm-starter . SKIPPED
[INFO] storm-kafka ... SKIPPED
[INFO] storm-hdfs SKIPPED
[INFO] storm-hbase ... SKIPPED
[INFO] storm-hive SKIPPED
[INFO] storm-jdbc SKIPPED
[INFO] storm-redis ... SKIPPED
[INFO] Storm JMS . SKIPPED
[INFO] Storm Cassandra Support ... SKIPPED
[INFO] Storm Binary Distribution . SKIPPED
[INFO] Storm Source Distribution . SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 6.826s
[INFO] Finished at: Fri Apr 03 14:12:15 EDT 2015
[INFO] Final Memory: 40M/2474M
[INFO]
[ERROR] Failed to execute goal on project storm-kafka: Could not resolve
dependencies for project
org.apache.storm:storm-kafka:jar:0.10.0.2.3.0.0-1493: Could not find artifact
org.apache.storm:storm-core:jar:0.10.0.2.3.0.0-1493 in public
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/615#issuecomment-127095071 @revans2 Please don't forget check this PR in :ï¼ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-933:NullPointerException during KafkaSpo...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/660 STORM-933:NullPointerException during KafkaSpout deactivation You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-933 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/660.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #660 commit 2a1a417f922cbce6239b5c85eb75363b92b9a2d0 Author: caofangkun caofang...@gmail.com Date: 2015-07-31T02:36:42Z STORM-933:NullPointerException during KafkaSpout deactivation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Assigned] (STORM-933) NullPointerException during KafkaSpout deactivation
[ https://issues.apache.org/jira/browse/STORM-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun reassigned STORM-933: Assignee: caofangkun NullPointerException during KafkaSpout deactivation --- Key: STORM-933 URL: https://issues.apache.org/jira/browse/STORM-933 Project: Apache Storm Issue Type: Bug Components: storm-kafka Affects Versions: 0.9.5 Reporter: Patricio Echague Assignee: caofangkun We are seeing this during a topology shutdown 2015-07-09 19:51:48-0700 b.s.util [ERROR] Async loop died! java.lang.NullPointerException: null at storm.kafka.KafkaSpout.commit(KafkaSpout.java:190) ~[stormjar.jar:na] at storm.kafka.KafkaSpout.deactivate(KafkaSpout.java:180) ~[stormjar.jar:na] at com.relateiq.storm.JMXActivatableSpout.deactivate(JMXActivatableSpout.java:75) ~[stormjar.jar:na] at backtype.storm.daemon.executor$fn__6579$fn__6594$fn__6623.invoke(executor.clj:570) ~[storm-core-0.9.5.jar:0.9.5] at backtype.storm.util$async_loop$fn__459.invoke(util.clj:463) ~[storm-core-0.9.5.jar:0.9.5] at clojure.lang.AFn.run(AFn.java:24) [clojure-1.5.1.jar:na] at java.lang.Thread.run(Thread.java:745) [na:1.8.0_31] 2015-07-09 19:51:48-0700 b.s.d.executor [ERROR] Thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-966 ConfigValidation.DoubleValidator is ...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/658#issuecomment-126202559 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-964, add config for worker logwriter to ...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/657#discussion_r35833865 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -675,6 +675,7 @@ (add-to-classpath topo-classpath)) top-gc-opts (storm-conf TOPOLOGY-WORKER-GC-CHILDOPTS) gc-opts (substitute-childopts (if top-gc-opts top-gc-opts (conf WORKER-GC-CHILDOPTS)) worker-id storm-id port) + topo-worker-logwriter-childopts (conf TOPOLOGY-WORKER-LOGWRITER-CHILDOPTS) --- End diff -- should use ```storm-conf``` but not ```conf``` here? ```topo-worker-logwriter-childopts (storm-conf TOPOLOGY-WORKER-LOGWRITER-CHILDOPTS)``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (STORM-838) Upgrade Jackson
[
https://issues.apache.org/jira/browse/STORM-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14642369#comment-14642369
]
caofangkun commented on STORM-838:
--
It may be not necessary to update jackson version .
I checked the project's dependency tree and found jackson was brought in becase
of ring:ring-json
and ring:ring-json:0.3.1 is the latest version.
{code}
[INFO] | +- ring:ring-json:jar:0.3.1:provided
[INFO] | | \- cheshire:cheshire:jar:5.3.1:provided
[INFO] | | +- com.fasterxml.jackson.core:jackson-core:jar:2.3.1:provided
[INFO] | | +-
com.fasterxml.jackson.dataformat:jackson-dataformat-smile:jar:2.3.1:provided
[INFO] | | \- tigris:tigris:jar:0.1.1:provided
{code}
Upgrade Jackson
---
Key: STORM-838
URL: https://issues.apache.org/jira/browse/STORM-838
Project: Apache Storm
Issue Type: Dependency upgrade
Reporter: Sergio Fernández
Priority: Minor
Fix For: 0.11.0
Currently the project is using a very old Jackson version (2.3.1). There are
already many new (and better versions:
http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22com.fasterxml.jackson.core%22%20AND%20a%3A%22jackson-core%22
So it'd be great to upgrade to 2.5.3.
I can provide a patch if you agree on the request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (STORM-962) travis user's $SHELL env is /bin/sh but should be /bin/bash
caofangkun created STORM-962:
Summary: travis user's $SHELL env is /bin/sh but should be
/bin/bash
Key: STORM-962
URL: https://issues.apache.org/jira/browse/STORM-962
Project: Apache Storm
Issue Type: Bug
Reporter: caofangkun
Priority: Trivial
https://travis-ci.org/apache/storm/jobs/72794573#L405
{code}
[INFO] /bin/sh: 14: /home/travis/.jdk_switcher_rc: [[: not found
[INFO] /bin/sh: 22: /home/travis/.jdk_switcher_rc: [[: not found
[INFO] /bin/sh: 32: /home/travis/.jdk_switcher_rc: [[: not found
[INFO] /bin/sh: 42: /home/travis/.jdk_switcher_rc: [[: not found
[INFO] /bin/sh: 3: /etc/profile.d/rvm.sh: [[: not found
[INFO] checking for gcc... gcc
{code}
change $SHELL :
{code}
chsh -s /bin/bash
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (STORM-551) Will be better if Use storm.conf.dir instead of storm.conf.file
[ https://issues.apache.org/jira/browse/STORM-551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun closed STORM-551. Resolution: Duplicate Will be better if Use storm.conf.dir instead of storm.conf.file - Key: STORM-551 URL: https://issues.apache.org/jira/browse/STORM-551 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.9.3-rc2 Reporter: caofangkun Assignee: caofangkun Priority: Minor use --config given the conf dir -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-951. Storm Hive connector leaking connec...
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/645#discussion_r35401647
--- Diff:
external/storm-hive/src/main/java/org/apache/storm/hive/bolt/HiveBolt.java ---
@@ -170,10 +170,10 @@ public void run() {
}
}
-private void flushAllWriters()
+private void flushAllWriters(boolean rollToNext)
throws HiveWriter.CommitFailure, HiveWriter.TxnBatchFailure,
HiveWriter.TxnFailure, InterruptedException {
for(HiveWriter writer: allWriters.values()) {
-writer.flush(true);
+writer.flush(rollToNext);
--- End diff --
If ```rollToNext == false``` should we ``` writer.close()``` ?
Like:
```
writer.flush(rollToNext);
if (!rollToNext) {
writer.close();
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-927: make storm jar wait for deployment ...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/623#issuecomment-124425109 @DevInsanity Do your topology use [StormSubmitter.submitTopologyWithProgressBar](https://github.com/apache/storm/blob/master/storm-core/src/jvm/backtype/storm/StormSubmitter.java#L287) ? It will wait show progress for the topology to deploy before exiting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: [STORM-440] completed exposing the drpcclient ...
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/648#discussion_r35406122
--- Diff: storm-core/src/jvm/backtype/storm/utils/DRPCClient.java ---
@@ -46,7 +46,22 @@ public DRPCClient(Map conf, String host, int port,
Integer timeout) throws TTran
this.port = port;
this.client = new DistributedRPC.Client(_protocol);
}
-
+
+public static DistributedRPC.Client getConfiguredDRPCClient(String
host, int port) {
+return getConfiguredDRPCClient(null, host, port);
+}
+
+public static DistributedRPC.Client getConfiguredDRPCClient(Map conf,
String host, int port) {
+ try {
+Map fullConf = Utils.readStormConfig();
+if (conf != null) {
+ fullConf.putAll(conf);
+}
+return new DRPCClient(conf, host, port).getClient();
--- End diff --
shoud be ```return new DRPCClient(fullConf, host, port).getClient();```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-914: AutoHDFS should also update hdfs.co...
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/606#discussion_r35409819
--- Diff:
external/storm-hdfs/src/test/java/org/apache/storm/hdfs/trident/TridentSequenceTopology.java
---
@@ -60,7 +61,7 @@ public static StormTopology buildTopology(String hdfsUrl){
.withSequenceFormat(new DefaultSequenceFormat(key,
sentence))
.withRotationPolicy(rotationPolicy)
.withFsUrl(hdfsUrl)
-.withConfigKey(hdfs.config)
--- End diff --
@tedxia
if you change ```hdfs.config``` to ```topology.hdfs.config```
should the following several files change too ?
[HdfsFileTopology.java](https://github.com/apache/storm/blob/master/external/storm-hdfs/src/test/java/org/apache/storm/hdfs/bolt/HdfsFileTopology.java#L82)
[simple_hdfs.yaml](https://github.com/apache/storm/blob/master/external/flux/flux-examples/src/main/resources/simple_hdfs.yaml#L74)
[hdfs_test.yaml](https://github.com/apache/storm/blob/master/external/flux/flux-core/src/test/resources/configs/hdfs_test.yaml#L82)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-440] completed exposing the drpcclient ...
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/648#discussion_r35406230
--- Diff: storm-core/src/jvm/backtype/storm/utils/NimbusClient.java ---
@@ -30,11 +30,18 @@
private Nimbus.Client _client;
private static final Logger LOG =
LoggerFactory.getLogger(NimbusClient.class);
+public static NimbusClient getConfiguredClient() {
+ return getConfiguredClient(null);
+}
public static NimbusClient getConfiguredClient(Map conf) {
-try {
-String nimbusHost = (String) conf.get(Config.NIMBUS_HOST);
-return new NimbusClient(conf, nimbusHost);
+ try {
+Map fullConf = Utils.readStormConfig();
+if (conf != null) {
+ fullConf.putAll(conf);
+}
+String nimbusHost = (String) conf.get(Config.NIMBUS_HOST);
+ return new NimbusClient(conf, nimbusHost);
--- End diff --
should be
```
String nimbusHost = (String) fullConf.get(Config.NIMBUS_HOST);
return new NimbusClient(fullConf, nimbusHost);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-959:remove unnecessary dependency from s...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/652#issuecomment-124295316 duplicates #609 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-959) remove unnecessary dependency from storm-hive/pom.xml
caofangkun created STORM-959:
Summary: remove unnecessary dependency from storm-hive/pom.xml
Key: STORM-959
URL: https://issues.apache.org/jira/browse/STORM-959
Project: Apache Storm
Issue Type: Bug
Components: external
Affects Versions: 0.11.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
[org.apache.calcite:calcite-core:0.9.2-incubating|https://github.com/apache/storm/blob/master/external/storm-hive/pom.xml#L84]
does not take affect at all.
Becase of hive-exec org.apache.calcite:calcite-core:0.9.2-incubating-SNAPSHOT
will be downloaded
{code}
Downloading:
https://repository.apache.org/snapshots/org/apache/calcite/calcite-core/0.9.2-incubating-SNAPSHOT/maven-metadata.xml
Downloading:
https://repository.apache.org/snapshots/org/apache/calcite/calcite-core/0.9.2-incubating-SNAPSHOT/calcite-core-0.9.2-incubating-SNAPSHOT.pom
[WARNING] The POM for
org.apache.calcite:calcite-core:jar:0.9.2-incubating-SNAPSHOT is missing, no
dependency information available
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] storm pull request: STORM-959:remove unnecessary dependency from s...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/652#issuecomment-124034146 @harshach Could you please have a look at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-959:remove unnecessary dependency from s...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/652 STORM-959:remove unnecessary dependency from storm-hive/pom.xml org.apache.calcite:calcite-core:0.9.2-incubating does not take affect at all. You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-959 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/652.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #652 commit cd8bdfed00bf6ef6eb8322c2e7be2a32d377235c Author: caofangkun caofang...@gmail.com Date: 2015-07-23T09:32:48Z STORM-959:remove unnecessary dependency from storm-hive/pom.xml --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-947: replace all `backtype.storm.schedul...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/640#discussion_r35073778 --- Diff: storm-core/src/clj/backtype/storm/scheduler/DefaultScheduler.clj --- @@ -18,7 +18,7 @@ (:require [backtype.storm.scheduler.EvenScheduler :as EvenScheduler]) (:import [backtype.storm.scheduler IScheduler Topologies Cluster TopologyDetails WorkerSlot SchedulerAssignment -EvenScheduler ExecutorDetails]) +EvenScheduler]) --- End diff -- @chuanlei Yes, It's unnecessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-955) replace all backtype.storm.daemon.common.clj#StormBase with backtype.storm.generated.StormBase
caofangkun created STORM-955: Summary: replace all backtype.storm.daemon.common.clj#StormBase with backtype.storm.generated.StormBase Key: STORM-955 URL: https://issues.apache.org/jira/browse/STORM-955 Project: Apache Storm Issue Type: Sub-task Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-946: We should remove Closed Client form...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/639#issuecomment-122203636 @tedxia I could only find two situations ( am I right?) will change ```client.status``` to ```closed``` by call ```(.close socket)```. and do not need reconnect at all 1: when [ reresh-connections](https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/daemon/worker.clj#L314) remove unneeded connections and wil remove connecion from ``` cached-node+port-socket ``` 2: when [shutdown](https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/daemon/worker.clj#L462) worker Does have any situation will call ```(.close socket)``` but not removed from ``` cached-node+port-socket ``` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-946: We should remove Closed Client form...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/639#discussion_r34865678 --- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj --- @@ -288,7 +288,18 @@ (filter-key (complement (- worker :task-ids set needed-connections (- needed-assignment vals set) needed-tasks (- needed-assignment keys) - + + closed-connections (into [] (for [[node+port socket] @(:cached-node+port-socket worker)] +(if (.isClosed socket) node+port))) --- End diff -- -1 We need take attention to unneeded connections but not closed connections , sometimes closed connections need to be reconnected by [retry policy](https://github.com/apache/storm/blob/master/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java#L138) to make sure reconnect losted connections. [refresh-connections](https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/daemon/worker.clj#L313) will try remove unneeded connections by the way: ``` java.lang.IllegalArgumentException: No matching field found: isClosed for class backtype.storm.messaging.netty.Client ``` May be you should use [client.status()](https://github.com/apache/storm/blob/master/storm-core/src/jvm/backtype/storm/messaging/netty/Client.java#L191) somewhere when you need . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-947: replace all `backtype.storm.schedul...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/640 STORM-947: replace all `backtype.storm.scheduler.ExecutorDetails` with `backtype.storm.generated.ExecutorInfo ` You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-947 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/640.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #640 commit 713de61c6a32bbb7d54033112f27222f03d9bad4 Author: caofangkun caofang...@gmail.com Date: 2015-07-17T09:47:47Z STORM-947: replace allwith --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (STORM-930) Nimbus server shutting down
[
https://issues.apache.org/jira/browse/STORM-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630676#comment-14630676
]
caofangkun commented on STORM-930:
--
See:
https://github.com/apache/storm/blob/v0.9.3-rc1/storm-core/src/clj/backtype/storm/util.clj#L824
{code}
(defn partition-fixed
[max-num-chunks aseq]
(if (zero? max-num-chunks)
[]
...
{code}
Do you set parallelism-hint of your topology component ?
Nimbus server shutting down
---
Key: STORM-930
URL: https://issues.apache.org/jira/browse/STORM-930
Project: Apache Storm
Issue Type: Bug
Affects Versions: 0.9.3
Environment: Red Hadt Enterprise linux
Reporter: Vezly Gracies
Priority: Blocker
2015-07-09 18:40:53 b.s.d.nimbus [INFO] Starting Nimbus server...
2015-07-09 18:40:54 b.s.d.nimbus [ERROR] Error when processing event
java.lang.NullPointerException: null
at clojure.lang.Numbers.ops(Numbers.java:942) ~[clojure-1.5.1.jar:na]
at clojure.lang.Numbers.isZero(Numbers.java:90) ~[clojure-1.5.1.jar:na]
at backtype.storm.util$partition_fixed.invoke(util.clj:868)
~[storm-core-0.9.3.2.2.6.0-2800.jar:0.9.3.2.2.6.0-2800]
at clojure.lang.AFn.applyToHelper(AFn.java:163) [clojure-1.5.1.jar:na]
at clojure.lang.AFn.applyTo(AFn.java:151) [clojure-1.5.1.jar:na]
at clojure.core$apply.invoke(core.clj:617) ~[clojure-1.5.1.jar:na]
at clojure.lang.AFn.applyToHelper(AFn.java:163) [clojure-1.5.1.jar:na]
at clojure.lang.RestFn.applyTo(RestFn.java:132) ~[clojure-1.5.1.jar:na]
at clojure.core$apply.invoke(core.clj:619) ~[clojure-1.5.1.jar:na]
at clojure.core$partial$fn__4190.doInvoke(core.clj:2396)
~[clojure-1.5.1.jar:na]
at clojure.lang.RestFn.invoke(RestFn.java:408) ~[clojure-1.5.1.jar:na]
at
backtype.storm.util$map_val$iter__273__277$fn__278.invoke(util.clj:291)
~[storm-core-0.9.3.2.2.6.0-2800.jar:0.9.3.2.2.6.0-2800]
at clojure.lang.LazySeq.sval(LazySeq.java:42) ~[clojure-1.5.1.jar:na]
at clojure.lang.LazySeq.seq(LazySeq.java:60) ~[clojure-1.5.1.jar:na]
at clojure.lang.Cons.next(Cons.java:39) ~[clojure-1.5.1.jar:na]
at clojure.lang.RT.next(RT.java:598) ~[clojure-1.5.1.jar:na]
at clojure.core$next.invoke(core.clj:64) ~[clojure-1.5.1.jar:na]
at clojure.core.protocols$fn__6034.invoke(protocols.clj:146)
~[clojure-1.5.1.jar:na]
at
clojure.core.protocols$fn__6005$G__6000__6014.invoke(protocols.clj:19)
~[clojure-1.5.1.jar:na]
at clojure.core.protocols$seq_reduce.invoke(protocols.clj:31)
~[clojure-1.5.1.jar:na]
at clojure.core.protocols$fn__6026.invoke(protocols.clj:54)
~[clojure-1.5.1.jar:na]
at
clojure.core.protocols$fn__5979$G__5974__5992.invoke(protocols.clj:13)
~[clojure-1.5.1.jar:na]
at clojure.core$reduce.invoke(core.clj:6177) ~[clojure-1.5.1.jar:na]
at clojure.core$into.invoke(core.clj:6229) ~[clojure-1.5.1.jar:na]
at backtype.storm.util$map_val.invoke(util.clj:290)
~[storm-core-0.9.3.2.2.6.0-2800.jar:0.9.3.2.2.6.0-2800]
at
backtype.storm.daemon.nimbus$compute_executors.invoke(nimbus.clj:435)
~[storm-core-0.9.3.2.2.6.0-2800.jar:0.9.3.2.2.6.0-2800]
at
backtype.storm.daemon.nimbus$compute_executor__GT_component.invoke(nimbus.clj:446)
~[storm-core-0.9.3.2.2.6.0-2800.jar:0.9.3.2.2.6.0-2800]
at
backtype.storm.daemon.nimbus$read_topology_details.invoke(nimbus.clj:339)
~[storm-core-0.9.3.2.2.6.0-2800.jar:0.9.3.2.2.6.0-2800]
at
backtype.storm.daemon.nimbus$mk_assignments$iter__7285__7289$fn__7290.invoke(nimbus.clj:665)
~[storm-core-0.9.3.2.2.6.0-2800.jar:0.9.3.2.2.6.0-2800]
at clojure.lang.LazySeq.sval(LazySeq.java:42) ~[clojure-1.5.1.jar:na]
at clojure.lang.LazySeq.seq(LazySeq.java:60) ~[clojure-1.5.1.jar:na]
at clojure.lang.RT.seq(RT.java:484) ~[clojure-1.5.1.jar:na]
at clojure.core$seq.invoke(core.clj:133) ~[clojure-1.5.1.jar:na]
at clojure.core.protocols$seq_reduce.invoke(protocols.clj:30)
~[clojure-1.5.1.jar:na]
at clojure.core.protocols$fn__6026.invoke(protocols.clj:54)
~[clojure-1.5.1.jar:na]
at
clojure.core.protocols$fn__5979$G__5974__5992.invoke(protocols.clj:13)
~[clojure-1.5.1.jar:na]
at clojure.core$reduce.invoke(core.clj:6177) ~[clojure-1.5.1.jar:na]
at clojure.core$into.invoke(core.clj:6229) ~[clojure-1.5.1.jar:na]
at backtype.storm.daemon.nimbus$mk_assignments.doInvoke(nimbus.clj:664)
~[storm-core-0.9.3.2.2.6.0-2800.jar:0.9.3.2.2.6.0-2800]
at clojure.lang.RestFn.invoke(RestFn.java:410) ~[clojure-1.5.1.jar:na]
at
backtype.storm.daemon.nimbus$fn__7518$exec_fn__1491__auto7519$fn__7524$fn__7525.invoke(nimbus.clj:994)
~[storm-core-0.9.3.2.2.6.0-2800.jar:0.9.3.2.2.6.0-2800]
at
backtype.storm.daemon.nimbus
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/615#issuecomment-122156319 @revans2 The whole usages call delete-node with ```:force true```, that is the ```:force ``` parameter is unneeded at all. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-945:DefaultRolloverStrategy element is...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/638 STORM-945:DefaultRolloverStrategy element is not a policy,and should not be putted in the Policies element ``` - storm-current bin/storm nimbus Running: /usr/share/jdk-current/bin/java -server -Ddaemon.name=nimbus ... ... 2015-07-17 10:23:36,776 ERROR Policies has no parameter that matches element DefaultRolloverStrategy 2015-07-17 10:23:36,787 ERROR Policies has no parameter that matches element DefaultRolloverStrategy 2015-07-17 10:23:36,795 ERROR Policies has no parameter that matches element DefaultRolloverStrategy ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-945 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/638.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #638 commit 740f02ee0025cc0307a1422205f9612ce18d3652 Author: caofangkun caofang...@gmail.com Date: 2015-07-17T03:35:11Z STORM-945:DefaultRolloverStrategy element is not a policy,and should not be putted in the Policies element --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-945) DefaultRolloverStrategy element is not a policy,and should not be putted in the Policies element.
caofangkun created STORM-945:
Summary: DefaultRolloverStrategy element is not a policy,and
should not be putted in the Policies element.
Key: STORM-945
URL: https://issues.apache.org/jira/browse/STORM-945
Project: Apache Storm
Issue Type: Bug
Affects Versions: 0.11.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
{code}
➜ storm-current bin/storm nimbus
Running: /usr/share/jdk-current/bin/java -server -Ddaemon.name=nimbus ...
...
2015-07-17 10:23:36,776 ERROR Policies has no parameter that matches element
DefaultRolloverStrategy
2015-07-17 10:23:36,787 ERROR Policies has no parameter that matches element
DefaultRolloverStrategy
2015-07-17 10:23:36,795 ERROR Policies has no parameter that matches element
DefaultRolloverStrategy
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] storm pull request: STORM-924:Set the file mode of the files inclu...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/614#issuecomment-118686693 Thanks @HeartSaVioR . I have fixed as you mentioned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-926) change pom to use maven-shade-plugin:1.6 to minimize the size of shade jar
caofangkun created STORM-926:
Summary: change pom to use maven-shade-plugin:1.6 to minimize the
size of shade jar
Key: STORM-926
URL: https://issues.apache.org/jira/browse/STORM-926
Project: Apache Storm
Issue Type: Improvement
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
For example:
Before:
{code}
51M
/home/kuncao/workspace/storm/external/flux/flux-examples/target/flux-examples-0.11.0-SNAPSHOT.jar
{code}
After the patch :
{code}
diff --git a/external/flux/flux-examples/pom.xml
b/external/flux/flux-examples/pom.xml
index e3996e5..f102eaa 100644
--- a/external/flux/flux-examples/pom.xml
+++ b/external/flux/flux-examples/pom.xml
@@ -79,9 +79,10 @@
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-shade-plugin/artifactId
-version1.4/version
+version1.6/version
configuration
createDependencyReducedPomtrue/createDependencyReducedPom
+minimizeJartrue/minimizeJar
/configuration
executions
execution
{code}
The jar minimize to 12M
{code}
12M
/home/kuncao/workspace/storm/external/flux/flux-examples/target/flux-examples-0.11.0-SNAPSHOT.jar
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (STORM-926) change pom to use maven-shade-plugin:2.2 and minimize the size of shade jar and fix duplicated classes warnings of flue-examples
[
https://issues.apache.org/jira/browse/STORM-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
caofangkun updated STORM-926:
-
Summary: change pom to use maven-shade-plugin:2.2 and minimize the size of
shade jar and fix duplicated classes warnings of flue-examples (was: change
pom to use maven-shade-plugin:2.2 and minimize the size of shade jar )
change pom to use maven-shade-plugin:2.2 and minimize the size of shade jar
and fix duplicated classes warnings of flue-examples
-
Key: STORM-926
URL: https://issues.apache.org/jira/browse/STORM-926
Project: Apache Storm
Issue Type: Improvement
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
For example:
Before:
{code}
51M
/home/kuncao/workspace/storm/external/flux/flux-examples/target/flux-examples-0.11.0-SNAPSHOT.jar
{code}
After the patch :
{code}
diff --git a/external/flux/flux-examples/pom.xml
b/external/flux/flux-examples/pom.xml
index e3996e5..f102eaa 100644
--- a/external/flux/flux-examples/pom.xml
+++ b/external/flux/flux-examples/pom.xml
@@ -79,9 +79,10 @@
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-shade-plugin/artifactId
-version1.4/version
+version1.6/version
configuration
createDependencyReducedPomtrue/createDependencyReducedPom
+minimizeJartrue/minimizeJar
/configuration
executions
execution
{code}
The jar minimize to 12M
{code}
12M
/home/kuncao/workspace/storm/external/flux/flux-examples/target/flux-examples-0.11.0-SNAPSHOT.jar
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] storm pull request: STORM-926:change pom to use maven-shade-plugin...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/621 STORM-926:change pom to use maven-shade-plugin:2.2 and minimize the size of shade jar and fix duplicated classes warnings of flue-examples 1: fix external/flux/flux-examples duplicated classes warings ``` [WARNING] commons-collections-3.2.1.jar, commons-beanutils-core-1.8.0.jar, commons-beanutils-1.7.0.jar define 3 overlappping classes: [WARNING] - org.apache.commons.collections.ArrayStack [WARNING] - org.apache.commons.collections.BufferUnderflowException [WARNING] - org.apache.commons.collections.Buffer [WARNING] javax.servlet-3.1.jar, servlet-api-2.5-6.1.14.jar, javax.servlet-api-3.0.1.jar, servlet-api-2.5.jar define 17 overlappping classes: [WARNING] - javax.servlet.ServletInputStream [WARNING] - javax.servlet.Filter [WARNING] - javax.servlet.http.HttpSession [WARNING] - javax.servlet.FilterConfig [WARNING] - javax.servlet.FilterChain [WARNING] - javax.servlet.http.Cookie [WARNING] - javax.servlet.http.HttpServletResponse [WARNING] - javax.servlet.ServletConfig [WARNING] - javax.servlet.RequestDispatcher [WARNING] - javax.servlet.ServletRequest [WARNING] - 7 more... [WARNING] javax.servlet-3.1.jar, javax.servlet-api-3.0.1.jar define 26 overlappping classes: [WARNING] - javax.servlet.Registration [WARNING] - javax.servlet.DispatcherType [WARNING] - javax.servlet.ServletRegistration$Dynamic [WARNING] - javax.servlet.FilterRegistration [WARNING] - javax.servlet.Registration$Dynamic [WARNING] - javax.servlet.annotation.ServletSecurity$TransportGuarantee [WARNING] - javax.servlet.FilterRegistration$Dynamic [WARNING] - javax.servlet.descriptor.JspPropertyGroupDescriptor [WARNING] - javax.servlet.annotation.ServletSecurity$EmptyRoleSemantic [WARNING] - javax.servlet.descriptor.TaglibDescriptor [WARNING] - 16 more... [WARNING] hadoop-yarn-api-2.2.0.jar, hadoop-yarn-common-2.2.0.jar define 1 overlappping classes: [WARNING] - org.apache.hadoop.yarn.util.package-info [WARNING] maven-shade-plugin has detected that some .class files [WARNING] are present in two or more JARs. When this happens, only [WARNING] one single version of the class is copied in the uberjar. [WARNING] Usually this is not harmful and you can skeep these [WARNING] warnings, otherwise try to manually exclude artifacts [WARNING] based on mvn dependency:tree -Ddetail=true and the above [WARNING] output ``` 2. minimized shade jars For example: mini flux-examples-0.11.0-SNAPSHOT.jar size from 52M to 12M You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-926 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/621.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #621 commit 18ca7966583902e2895949e01c8ea07457c44cb5 Author: caofangkun caofang...@gmail.com Date: 2015-07-06T05:14:18Z STORM-926:change pom to use maven-shade-plugin:2.2 and minimize the size of shade jar and fix duplicated classes warnings of flue-examples --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-924) Set the file mode of the files included when packaging release packages
caofangkun created STORM-924: Summary: Set the file mode of the files included when packaging release packages Key: STORM-924 URL: https://issues.apache.org/jira/browse/STORM-924 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (STORM-920) Should we remove duplicated classes/code ?
caofangkun created STORM-920:
Summary: Should we remove duplicated classes/code ?
Key: STORM-920
URL: https://issues.apache.org/jira/browse/STORM-920
Project: Apache Storm
Issue Type: Improvement
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
See:
{code}
backtype.storm.generated.ExecutorInfo vs
backtype.storm.scheduler.ExecutorDetails
backtype.storm.generated.NodeInfo vs backtype.storm.scheduler.WorkerSlot
backtype.storm.generated.SupervisorInfo vs
backtype.storm.scheduler.SupervisorDetails
backtype.storm.generated.StormBase vs backtype.storm.daemon.common.clj#StormBase
backtype.storm.generated.ExecutorStats vs
backtype.storm.daemon.common.clj#ExecutorStats
backtype.storm.generated.SupervisorInfo vs
backtype.storm.daemon.common.clj#SupervisorInfo
backtype.storm.generated.Assignment vs
backtype.storm.daemon.common.clj#Assignment
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/605#discussion_r33326733 --- Diff: pom.xml --- @@ -211,7 +211,7 @@ guava.version16.0.1/guava.version netty.version3.9.0.Final/netty.version log4j-over-slf4j.version1.6.6/log4j-over-slf4j.version -log4j.version2.1/log4j.version +log4j.version2.3/log4j.version --- End diff -- Thank you @HeartSaVioR I have removed this unnessary change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (STORM-913) Use Curator's delete().deletingChildrenIfNeeded() instead of zk/delete-recursive
caofangkun created STORM-913: Summary: Use Curator's delete().deletingChildrenIfNeeded() instead of zk/delete-recursive Key: STORM-913 URL: https://issues.apache.org/jira/browse/STORM-913 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-913:Use Curator's delete().deletingChild...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/605 STORM-913:Use Curator's delete().deletingChildrenIfNeeded() instead of zk/delete-recursive You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-913 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/605.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #605 commit 5d26820167e83358efbb4c05a03976d9c7ea Author: caofangkun caofang...@gmail.com Date: 2015-05-25T03:27:01Z Merge pull request #22 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 5122dea1216c9b6125e8fd5364f90236c84ae196 Author: caofangkun caofang...@gmail.com Date: 2015-06-01T06:30:22Z Merge pull request #23 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 0f71a7db32b47208ff7373e8b1c75f9f5ebaf9b4 Author: caofangkun caofang...@gmail.com Date: 2015-06-12T03:34:44Z Merge pull request #24 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 03d276069797cc993c7078f7ece513802960d40d Author: caofangkun caofang...@gmail.com Date: 2015-06-17T02:22:13Z Merge pull request #25 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 469b7f56f910bc9f9b8d3af7670f86fbdb5c53ed Author: caofangkun caofang...@gmail.com Date: 2015-06-23T03:22:20Z Merge pull request #26 from apache/master Merge from apache/storm to caofangkun/apache-storm commit dddaacbf51d37f97e072df0eed4d14c09cdda453 Author: caofangkun caofang...@gmail.com Date: 2015-06-26T02:28:32Z Merge pull request #27 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 2a7cd49145edec776320c1f519fae6e9cf0a891c Author: caofangkun caofang...@gmail.com Date: 2015-06-26T03:12:27Z STORM-913:Use Curator's delete().deletingChildrenIfNeeded() instead of zk/delete-recursive --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-668:Generate storm-ui.war and could be d...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/423#issuecomment-112737243 @d2r Thank you for your attention of this PR. In my opinion , 1, storm ui is more like a RESTful APIs server than a UI server. 2, We can use jetty embedded server (as the provided code use) for testing; but on production environment, use Apache Tomcat or other WebSever Container may be a better choice. I have implement these as a external project [storm-ui](https://github.com/caofangkun/storm-ui) . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (STORM-736) Add a RESTful API to print all of the thread's information and stack traces of Nimbus/Supervisor/Worker Process
[ https://issues.apache.org/jira/browse/STORM-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-736: - Summary: Add a RESTful API to print all of the thread's information and stack traces of Nimbus/Supervisor/Worker Process (was: Private a RESTful API to print all of the thread's information and stack traces of Nimbus/Supervisor/Worker Process) Add a RESTful API to print all of the thread's information and stack traces of Nimbus/Supervisor/Worker Process Key: STORM-736 URL: https://issues.apache.org/jira/browse/STORM-736 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (STORM-736) Private a RESTful API to print all of the thread's information and stack traces of Nimbus/Supervisor/Worker Process
caofangkun created STORM-736: Summary: Private a RESTful API to print all of the thread's information and stack traces of Nimbus/Supervisor/Worker Process Key: STORM-736 URL: https://issues.apache.org/jira/browse/STORM-736 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.11.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-587. trident transactional state in zk s...
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/475#discussion_r27186979 --- Diff: storm-core/src/jvm/backtype/storm/transactional/state/TransactionalState.java --- @@ -59,7 +59,8 @@ protected TransactionalState(Map conf, String id, Map componentConf, String subr .get(Config.TOPOLOGY_KRYO_REGISTER)); } String transactionalRoot = (String)conf.get(Config.TRANSACTIONAL_ZOOKEEPER_ROOT); -String rootDir = transactionalRoot + / + id + / + subroot; +String topologyName = (String)conf.get(Config.TOPOLOGY_NAME); --- End diff -- What if topologyName is null? Should we give these configs default valuesï¼ Something like: ``` String topologyName = Utils.parseString(conf.get(Config.TOPOLOGY_NAME), default-topology-name); ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-721. Storm UI server should support SSL.
Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/479#discussion_r27090305 --- Diff: storm-core/src/jvm/backtype/storm/Config.java --- @@ -567,6 +567,39 @@ public static final Object UI_HEADER_BUFFER_BYTES_SCHEMA = Number.class; /** + * This port is used by Storm DRPC for receiving HTTPS (SSL) DPRC requests from clients. + */ +public static final String UI_HTTPS_PORT = ui.https.port; --- End diff -- Will be better if you could modify file ``` storm-core/conf/defaults.yaml ``` and give these newly added configs default values. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-694: java.lang.ClassNotFoundException: b...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/449#issuecomment-85783849 @duke-bartholomew It works very well when I try to reproduce this issue: ``` git clone https://github.com/apache/storm.git cd storm mvn package -Dmaven.test.skip=true ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-553:add eclipse java formatter file for ...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/478 STORM-553:add eclipse java formatter file for Apache Storm Java Code You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-553 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/478.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #478 commit f95938b3d973a9d2513d0e326188f77b9bf438c8 Author: caofangkun caofang...@gmail.com Date: 2015-03-16T06:31:04Z Merge pull request #12 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 146bd6b7b18f03b338df78431654d7c54fa0e8a4 Author: caofangkun caofang...@gmail.com Date: 2015-03-18T01:17:37Z Merge pull request #13 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 57a691c865f764cf331abd2e2e6d27bd320813f8 Author: caofangkun caofang...@gmail.com Date: 2015-03-19T02:01:23Z Merge pull request #14 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 2c5b402381dbffd3942c0b67cdb8013462b5552a Author: caofangkun caofang...@gmail.com Date: 2015-03-24T02:44:47Z Merge pull request #15 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 7302df4abd334c3f75bb86cb2a2470e61e9323f7 Author: caofangkun caofang...@gmail.com Date: 2015-03-24T04:00:38Z STORM-553:add eclipse java formatter file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-694: java.lang.ClassNotFoundException: b...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/449#issuecomment-85329513 @duke-bartholomew Does this still a issue? See SupervisorInfo has already be imported at : https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: fastfix-01:modify config.read-supervisor-storm...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/469 fastfix-01:modify config.read-supervisor-storm-conf function remove unused topology-path You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm fastfix-01 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/469.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #469 commit f95938b3d973a9d2513d0e326188f77b9bf438c8 Author: caofangkun caofang...@gmail.com Date: 2015-03-16T06:31:04Z Merge pull request #12 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 146bd6b7b18f03b338df78431654d7c54fa0e8a4 Author: caofangkun caofang...@gmail.com Date: 2015-03-18T01:17:37Z Merge pull request #13 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 57a691c865f764cf331abd2e2e6d27bd320813f8 Author: caofangkun caofang...@gmail.com Date: 2015-03-19T02:01:23Z Merge pull request #14 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 914d07758a2fbbfe237ca825374c038f29890194 Author: caofangkun caofang...@gmail.com Date: 2015-03-19T02:53:24Z fastfix-01:modify config.read-supervisor-storm-conf function remove unused topology-path --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (STORM-701) provide eclipse plugin for monitoring/debugging user topology
[ https://issues.apache.org/jira/browse/STORM-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-701: - Attachment: New Storm Topology Project-03.jpg New Storm Topology Project-02.jpg New Storm Topology Project.jpg provide eclipse plugin for monitoring/debugging user topology -- Key: STORM-701 URL: https://issues.apache.org/jira/browse/STORM-701 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: New Storm Topology Project-02.jpg, New Storm Topology Project-03.jpg, New Storm Topology Project.jpg provide eclipse plugin for debugging user topology, submit topologies and monitor their execution. https://github.com/caofangkun/storm-eclipse-plugin !attached-image.gif! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (STORM-701) provide eclipse plugin for monitoring/debugging user topology
[ https://issues.apache.org/jira/browse/STORM-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-701: - Description: provide eclipse plugin for debugging user topology, submit topologies and monitor their execution. https://github.com/caofangkun/storm-eclipse-plugin !New Storm Topology Project.jpg! !New Storm Topology Project-02.jpg! !New Storm Topology Project-03.jpg! was: provide eclipse plugin for debugging user topology, submit topologies and monitor their execution. https://github.com/caofangkun/storm-eclipse-plugin !attached-image.gif! provide eclipse plugin for monitoring/debugging user topology -- Key: STORM-701 URL: https://issues.apache.org/jira/browse/STORM-701 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: New Storm Topology Project-02.jpg, New Storm Topology Project-03.jpg, New Storm Topology Project.jpg provide eclipse plugin for debugging user topology, submit topologies and monitor their execution. https://github.com/caofangkun/storm-eclipse-plugin !New Storm Topology Project.jpg! !New Storm Topology Project-02.jpg! !New Storm Topology Project-03.jpg! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (STORM-701) provide eclipse plugin for monitoring/debugging user topology
[ https://issues.apache.org/jira/browse/STORM-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-701: - Description: provide eclipse plugin for debugging user topology, submit topologies and monitor their execution. https://github.com/caofangkun/storm-eclipse-plugin !attached-image.gif! was:provide eclipse plugin for debugging user topology, submit topologies and monitor their execution. provide eclipse plugin for monitoring/debugging user topology -- Key: STORM-701 URL: https://issues.apache.org/jira/browse/STORM-701 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor provide eclipse plugin for debugging user topology, submit topologies and monitor their execution. https://github.com/caofangkun/storm-eclipse-plugin !attached-image.gif! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (STORM-701) provide eclipse plugin for creating/monitoring/debugging user topology
[ https://issues.apache.org/jira/browse/STORM-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-701: - Summary: provide eclipse plugin for creating/monitoring/debugging user topology (was: provide eclipse plugin for monitoring/debugging user topology) provide eclipse plugin for creating/monitoring/debugging user topology --- Key: STORM-701 URL: https://issues.apache.org/jira/browse/STORM-701 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: New Storm Topology Project-02.jpg, New Storm Topology Project-03.jpg, New Storm Topology Project.jpg provide eclipse plugin for debugging user topology, submit topologies and monitor their execution. https://github.com/caofangkun/storm-eclipse-plugin !New Storm Topology Project.jpg! !New Storm Topology Project-02.jpg! !New Storm Topology Project-03.jpg! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-541:Clean duplicate dependences in poms
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/422#discussion_r26361833
--- Diff: pom.xml ---
@@ -521,12 +521,6 @@
scopetest/scope
/dependency
dependency
-groupIdorg.clojars.runa/groupId
-artifactIdconjure/artifactId
-version${conjure.version}/version
--- End diff --
Thank you @revans2
Fixed. Please review this PR again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-638:UI should show up process-id of the ...
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/396#discussion_r26362269
--- Diff: storm-core/src/storm.thrift ---
@@ -205,7 +205,8 @@ struct ExecutorSummary {
2: required string component_id;
3: required string host;
4: required i32 port;
- 5: required i32 uptime_secs;
+ 5: required i32 process_id;
--- End diff --
Fixed. Thank you. Please review this again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Created] (STORM-701) provide eclipse plugin for monitoring/debugging user topology
caofangkun created STORM-701: Summary: provide eclipse plugin for monitoring/debugging user topology Key: STORM-701 URL: https://issues.apache.org/jira/browse/STORM-701 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor provide eclipse plugin for debugging user topology, submit topologies and monitor their execution. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/394 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] storm pull request: STORM-534:Store Nimbus Server Information in z...
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/394#issuecomment-73822455 Let's close it for now.More information will be discussed on [STORM-654](https://issues.apache.org/jira/browse/STORM-654) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Closed] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus
[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
caofangkun closed STORM-534.
Resolution: Duplicate
Store Nimbus Server Information in zookeeper path
{storm.zookeeper.root}/nimbus
---
Key: STORM-534
URL: https://issues.apache.org/jira/browse/STORM-534
Project: Apache Storm
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in
{storm.zookeeper.root}/nimbus like localhost:8826:0.9.3-r1234
2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus
Server Information, Configuration like {nimbus.host} {nimbus.thrift.port}
{storm.version} will be ignored
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (STORM-657) make the shutdown-worker sleep time before kill -9 configurable
[ https://issues.apache.org/jira/browse/STORM-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-657: - Affects Version/s: 0.10.0 make the shutdown-worker sleep time before kill -9 configurable --- Key: STORM-657 URL: https://issues.apache.org/jira/browse/STORM-657 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.9.2-incubating, 0.10.0 Reporter: Vincent Russell Assignee: caofangkun Priority: Minor Fix For: 0.9.2-incubating This is a continuation of STORM-183: Supervisor/worker shutdown hook should be called in distributed mode. It would be nice to be able to configure how many seconds (or millis) to sleep for before shutting down the worker process in the shutdown-worker function in supervisor.clj -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (STORM-668) Generate storm-ui war using maven and deployed on TomCat
caofangkun created STORM-668: Summary: Generate storm-ui war using maven and deployed on TomCat Key: STORM-668 URL: https://issues.apache.org/jira/browse/STORM-668 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.10.0 Reporter: caofangkun Assignee: caofangkun Priority: Minor $ mvn package -Dmaven.test.skip=true -P dist -Dwar generate storm-ui.war -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-541:Clean duplicate dependences in poms
Github user caofangkun commented on the pull request: https://github.com/apache/storm/pull/422#issuecomment-73626073 @revans2 Could you please have a review on this PR? Thanks a lot . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Reopened] (STORM-534) Store Nimbus Server Information in zookeeper path {storm.zookeeper.root}/nimbus
[
https://issues.apache.org/jira/browse/STORM-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
caofangkun reopened STORM-534:
--
Store Nimbus Server Information in zookeeper path
{storm.zookeeper.root}/nimbus
---
Key: STORM-534
URL: https://issues.apache.org/jira/browse/STORM-534
Project: Apache Storm
Issue Type: Improvement
Affects Versions: 0.10.0
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
1) {nimbus.host} {nimbus.thrift.port} {storm.version} will be stored in
{storm.zookeeper.root}/nimbus like localhost:8826:0.9.3-r1234
2) Storm Clients only need to configure {storm.zookeeper.root} to get Nimbus
Server Information, Configuration like {nimbus.host} {nimbus.thrift.port}
{storm.version} will be ignored
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (STORM-657) make the shutdown-worker sleep time before kill -9 configurable
[ https://issues.apache.org/jira/browse/STORM-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] caofangkun updated STORM-657: - Fix Version/s: (was: 0.9.2-incubating) make the shutdown-worker sleep time before kill -9 configurable --- Key: STORM-657 URL: https://issues.apache.org/jira/browse/STORM-657 Project: Apache Storm Issue Type: Improvement Affects Versions: 0.9.2-incubating, 0.10.0 Reporter: Vincent Russell Assignee: caofangkun Priority: Minor This is a continuation of STORM-183: Supervisor/worker shutdown hook should be called in distributed mode. It would be nice to be able to configure how many seconds (or millis) to sleep for before shutting down the worker process in the shutdown-worker function in supervisor.clj -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] storm pull request: STORM-668:Generate storm-ui.war and could be d...
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/423 STORM-668:Generate storm-ui.war and could be deployed on TomCat ``` â storm-core git:(storm-668) mvn clean mvn install -Dmaven.test.skip=true -Dwar â storm-core git:(storm-668) cp target/storm-ui.war $TOMCAT_HOME/webapps/ ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apache-storm storm-668 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm/pull/423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #423 commit 6c04e1bea802d28ae92a234ddbaad2c1ed0a6835 Author: caofangkun caofang...@gmail.com Date: 2015-01-23T01:28:46Z Merge pull request #4 from apache/master Merger from apache/storm to caofangkun/apache-storm commit d8c98cb1846bd07aef558bde410607b923aa5c1e Author: caofangkun caofang...@gmail.com Date: 2015-02-04T01:09:22Z Merge pull request #5 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 3af6d18ed2d3b5998d0f7a0e87a10ce220eb207d Author: caofangkun caofang...@gmail.com Date: 2015-02-10T02:07:16Z Merge pull request #6 from apache/master Merge from apache/storm to caofangkun/apache-storm commit 53a2c305f73f9322eb9e5efca15f3184a26847e8 Author: caofangkun caofang...@gmail.com Date: 2015-02-10T04:35:33Z STORM-668:Generate storm-ui.war and could be deployed on TomCat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
