[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275288#comment-14275288 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/294#issuecomment-69754978 @caofangkun one small thing, now that I think of it. It would be nice to change the properties file from `core-version-info.properties` to `storm-core-version-info.properties` This is really minor though, I am still +1 without it. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275280#comment-14275280 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/294#issuecomment-69754059 Looks great to me. +1. I'll give it a few days to be sure no one else has any comments. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273437#comment-14273437 ] ASF GitHub Bot commented on STORM-243: -- Github user mnogu commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r22780669 --- Diff: storm-core/src/saveVersion.sh --- @@ -0,0 +1,42 @@ +#this file is used to generate the package-info.java class that +# records the version, revision, branch, user, timestamp, and url +unset LANG +unset LC_CTYPE +unset LC_TIME +version=$1 +build_dir=$2 +user=`whoami` +date=`date` +cwd=`pwd` +if [ -d ../.git ]; then + revision=`git log -1 --pretty=format:%H` + hostname=`hostname` + branch=`git branch | sed -n -e 's/^* //p'` + url=`git remote -v | sed -n -e 's/^origin[[:space:]]\(.*\)(fetch)/\1/p'` +elif [ -d .svn ]; then --- End diff -- We don't have to check if ```.svn``` exists because we don't use Subversion. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273434#comment-14273434 ] ASF GitHub Bot commented on STORM-243: -- Github user mnogu commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r22780600 --- Diff: storm-core/src/saveVersion.sh --- @@ -0,0 +1,42 @@ +#this file is used to generate the package-info.java class that +# records the version, revision, branch, user, timestamp, and url +unset LANG +unset LC_CTYPE +unset LC_TIME +version=$1 +build_dir=$2 +user=`whoami` +date=`date` +cwd=`pwd` +if [ -d ../.git ]; then + revision=`git log -1 --pretty=format:%H` + hostname=`hostname` --- End diff -- The variable ```hostname``` is referenced nowhere. You can remove this line. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273431#comment-14273431 ] ASF GitHub Bot commented on STORM-243: -- Github user mnogu commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r22780569 --- Diff: storm-core/src/saveVersion.sh --- @@ -0,0 +1,42 @@ +#this file is used to generate the package-info.java class that +# records the version, revision, branch, user, timestamp, and url +unset LANG +unset LC_CTYPE +unset LC_TIME +version=$1 +build_dir=$2 +user=`whoami` +date=`date` +cwd=`pwd` +if [ -d ../.git ]; then + revision=`git log -1 --pretty=format:%H` --- End diff -- You might want to use a shorter command ```git rev-parse HEAD```. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273439#comment-14273439 ] ASF GitHub Bot commented on STORM-243: -- Github user mnogu commented on the pull request: https://github.com/apache/storm/pull/294#issuecomment-69546010 I've added a couple of comments on storm-core/src/saveVersion.sh. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273778#comment-14273778 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/294#issuecomment-69603185 @caofangkun The changes look good to me now. I am still a bit nervous that this will not build on windows, but that can be fixed later. I would also like the comments by @mnogu addressed. After that I am +1 on this. Thanks for the work. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273215#comment-14273215 ] ASF GitHub Bot commented on STORM-243: -- Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r22775294 --- Diff: storm-core/src/saveVersion.sh --- @@ -0,0 +1,42 @@ +#this file is used to generate the package-info.java class that +# records the version, revision, branch, user, timestamp, and url +unset LANG +unset LC_CTYPE +unset LC_TIME +version=$1 +build_dir=$2 +user=`whoami` +date=`date` +cwd=`pwd` +if [ -d ../.git ]; then + revision=`git log -1 --pretty=format:%H` + hostname=`hostname` + branch=`git branch | sed -n -e 's/^* //p'` + url=`git remote -v | sed -n -e 's/^origin\t\(.*\)(fetch)/\1/p'` +elif [ -d .svn ]; then + revision=`svn info | sed -n -e 's/Last Changed Rev: \(.*\)/\1/p'` + url=`svn info | sed -n -e 's/^URL: \(.*\)/\1/p'` + # Get canonical branch (branches/X, tags/X, or trunk) + branch=`echo $url | sed -n -e 's,.*\(branches/.*\)$,\1,p' \ + -e 's,.*\(tags/.*\)$,\1,p' \ + -e 's,.*trunk$,trunk,p'` +else + revision=Unknown + branch=Unknown + url=file://$cwd +fi +srcChecksum=`find src -name '*.java' | LC_ALL=C sort | xargs md5sum | md5sum | cut -d ' ' -f 1` --- End diff -- Filed a follow up JIRA: https://issues.apache.org/jira/browse/STORM-622 Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273168#comment-14273168
]
ASF GitHub Bot commented on STORM-243:
--
Github user caofangkun commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22773509
--- Diff: storm-core/src/clj/backtype/storm/ui/core.clj ---
@@ -510,7 +501,7 @@
(map #(.get_num_executors ^TopologySummary %))
(reduce +))]
{user user
-stormVersion (read-storm-version)
+stormVersion (str (VersionInfo/getVersion))
--- End diff --
Filed a follow up JIAR to expose more version information on UI:
https://issues.apache.org/jira/browse/STORM-621
Record version and revision information in builds
--
Key: STORM-243
URL: https://issues.apache.org/jira/browse/STORM-243
Project: Apache Storm
Issue Type: Improvement
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
Attachments: STORM-243-1.patch, ui.png
The effect shown below,
For Subversion project :
$ storm version
Storm 0.9.2-incubating-SNAPSHOT
Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
or
$ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar
backtype.storm.utils.VersionInfo
Storm 0.9.2-incubating-SNAPSHOT
Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
For Git Project:
$ storm version
➜ storm-current storm version
Running: ... ...
Storm 0.10.0-SNAPSHOT
Subversion https://github.com/caofangkun/apache-storm.git -r
ffba148cc47a92185fa1a5db11f72982de10f106
Branch storm-243
Compiled by caokun on Thu Jan 8 10:47:48 CST 2015
From source with checksum 97e7c942939e3e82dcb854b497991a51
For UI
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273273#comment-14273273 ] ASF GitHub Bot commented on STORM-243: -- Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r22777029 --- Diff: storm-core/src/jvm/backtype/storm/package-info.java --- @@ -0,0 +1,7 @@ +/* --- End diff -- 1: this file will be generated in ./storm-core/target/build directory 2: add the package-info.java to source directory using the add-source goal Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273274#comment-14273274 ] ASF GitHub Bot commented on STORM-243: -- Github user caofangkun commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r22777057 --- Diff: storm-core/src/saveVersion.sh --- @@ -0,0 +1,42 @@ +#this file is used to generate the package-info.java class that +# records the version, revision, branch, user, timestamp, and url +unset LANG +unset LC_CTYPE +unset LC_TIME +version=$1 +build_dir=$2 +user=`whoami` +date=`date` +cwd=`pwd` +if [ -d ../.git ]; then + revision=`git log -1 --pretty=format:%H` + hostname=`hostname` + branch=`git branch | sed -n -e 's/^* //p'` + url=`git remote -v | sed -n -e 's/^origin\t\(.*\)(fetch)/\1/p'` --- End diff -- Use [[:space:]] instead of '\t' . Test Passed on Mac OS X and Ubuntu. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271151#comment-14271151 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/294#issuecomment-69348667 @caofangkun Overall it looks really good, thanks for doing this. I have a few comments, mostly to clean things up a bit, or some follow up work. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271143#comment-14271143 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r22721124 --- Diff: bin/storm --- @@ -88,12 +88,12 @@ def get_config_opts(): global CONFIG_OPTS return -Dstorm.options= + ','.join(map(quote_plus,CONFIG_OPTS)) -if not os.path.exists(STORM_DIR + /RELEASE): +if not os.path.exists(STORM_DIR + /lib/): --- End diff -- Please use `STORM_LIB_DIR` instead of `STORM_DIR + /lib/`. Also the variable `STORM_RELEASE_DIR` is no longer used in the file and should be deleted. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271145#comment-14271145
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r22721149
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -131,13 +131,6 @@
/file
!-- TODO this should be a generated file from target --
file
-source${project.basedir}/../../VERSION/source
-outputDirectory//outputDirectory
-destNameRELEASE/destName
--- End diff --
You fixed this thanks.
Record version and revision information in builds
--
Key: STORM-243
URL: https://issues.apache.org/jira/browse/STORM-243
Project: Apache Storm
Issue Type: Improvement
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
Attachments: STORM-243-1.patch, ui.png
The effect shown below,
For Subversion project :
$ storm version
Storm 0.9.2-incubating-SNAPSHOT
Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
or
$ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar
backtype.storm.utils.VersionInfo
Storm 0.9.2-incubating-SNAPSHOT
Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
For Git Project:
$ storm version
➜ storm-current storm version
Running: ... ...
Storm 0.10.0-SNAPSHOT
Subversion https://github.com/caofangkun/apache-storm.git -r
ffba148cc47a92185fa1a5db11f72982de10f106
Branch storm-243
Compiled by caokun on Thu Jan 8 10:47:48 CST 2015
From source with checksum 97e7c942939e3e82dcb854b497991a51
For UI
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271142#comment-14271142 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r22720912 --- Diff: storm-core/pom.xml --- @@ -464,6 +464,30 @@ /dependencies /plugin plugin +groupIdorg.codehaus.mojo/groupId --- End diff -- This code will not run on a build for Windows. I think it is going to produce build errors if we try. I would like to see this placed in a profile that is activated only for Operating systems that we know it works on. And file a follow up JIRA to make this work on Windows. https://maven.apache.org/guides/introduction/introduction-to-profiles.html Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271112#comment-14271112 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r22720414 --- Diff: storm-core/src/jvm/backtype/storm/package-info.java --- @@ -0,0 +1,7 @@ +/* --- End diff -- This file is also a build artifact and shouldn't be checked in. Please add it to the .gitignore file. I would prefer to have it placed in a different directory from the rest of the source code. The maven plugin org.codehaus.mojo:build-helper-maven-plugin is a good way to add in a generated source directory using the add-source goal. It also allows us to not include a checksum of this generated file in the checksum of the source. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch, ui.png The effect shown below, For Subversion project : $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f For Git Project: $ storm version ➜ storm-current storm version Running: ... ... Storm 0.10.0-SNAPSHOT Subversion https://github.com/caofangkun/apache-storm.git -r ffba148cc47a92185fa1a5db11f72982de10f106 Branch storm-243 Compiled by caokun on Thu Jan 8 10:47:48 CST 2015 From source with checksum 97e7c942939e3e82dcb854b497991a51 For UI -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14270129#comment-14270129 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/294#issuecomment-69259821 @caofangkun It looks like you have fixed most of the issues here. Do you think it is ready for me to review? Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch Patch atteThe effect shown below, $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257325#comment-14257325 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r8158 --- Diff: storm-core/src/clj/backtype/storm/ui/core.clj --- @@ -52,15 +52,9 @@ (map #(.get_stats ^ExecutorSummary %)) (filter not-nil?))) -(defn read-storm-version +(def read-storm-version Returns a string containing the Storm version or 'Unknown'. - [] - (let [storm-home (System/getProperty storm.home) -release-path (format %s/RELEASE storm-home) -release-file (File. release-path)] -(if (and (.exists release-file) (.isFile release-file)) - (trim (slurp release-path)) - Unknown))) + (str VersionInfo/getVersion)) --- End diff -- This is not valid clojure. It should probably be something like ```(str (VersionInfo/getVersion))``` you are also going to have to explicitly import VersionInfo info core.clj. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch Patch atteThe effect shown below, $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257328#comment-14257328 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/294#discussion_r8250 --- Diff: storm-core/src/saveVersion.sh --- @@ -0,0 +1,42 @@ +s file is used to generate the package-info.java class that +# records the version, revision, branch, user, timestamp, and url +unset LANG +unset LC_CTYPE +unset LC_TIME +version=$1 +build_dir=$2 +user=`whoami` +date=`date` +cwd=`pwd` +if [ -d .git ]; then --- End diff -- This does not work with how the code is run from maven. The working directory, at least for me, seems to be storm-core, so it never finds .git and is not able to detect that the code is in git. subversion should not have the same issues. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch Patch atteThe effect shown below, $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[
https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257335#comment-14257335
]
ASF GitHub Bot commented on STORM-243:
--
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/294#discussion_r8357
--- Diff: storm-dist/binary/src/main/assembly/binary.xml ---
@@ -131,13 +131,6 @@
/file
!-- TODO this should be a generated file from target --
file
-source${project.basedir}/../../VERSION/source
-outputDirectory//outputDirectory
-destNameRELEASE/destName
--- End diff --
There are explicit checks elsewhere in the code looking for the RELEASE
file. If it is not present some parts of the code assume they are not part of
a valid release.
https://github.com/caofangkun/apache-storm/blob/storm-243/bin/storm#L86-91
is one example of where this happens.
Record version and revision information in builds
--
Key: STORM-243
URL: https://issues.apache.org/jira/browse/STORM-243
Project: Apache Storm
Issue Type: Improvement
Reporter: caofangkun
Assignee: caofangkun
Priority: Minor
Attachments: STORM-243-1.patch
Patch atteThe effect shown below,
$ storm version
Storm 0.9.2-incubating-SNAPSHOT
Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
or
$ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar
backtype.storm.utils.VersionInfo
Storm 0.9.2-incubating-SNAPSHOT
Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959
Compiled by somebody on Wed Feb 19 11:23:38 CST 2014
From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (STORM-243) Record version and revision information in builds
[ https://issues.apache.org/jira/browse/STORM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257341#comment-14257341 ] ASF GitHub Bot commented on STORM-243: -- Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/294#issuecomment-67985049 @caofangkun thank you for submitting this patch. I appreciate you trying to help. In the future it would be good though, to be sure that your patch complies and the unit tests pass before submitting it for review. Record version and revision information in builds -- Key: STORM-243 URL: https://issues.apache.org/jira/browse/STORM-243 Project: Apache Storm Issue Type: Improvement Reporter: caofangkun Assignee: caofangkun Priority: Minor Attachments: STORM-243-1.patch Patch atteThe effect shown below, $ storm version Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f or $ java -classpath storm-core-0.9.2-incubating-SNAPSHOT.jar backtype.storm.utils.VersionInfo Storm 0.9.2-incubating-SNAPSHOT Subversion https://github.com/apache/incubator-storm/trunk/storm-core -r 1959 Compiled by somebody on Wed Feb 19 11:23:38 CST 2014 From source with checksum 9347aded8a39f3ddf8e8f2f9bf56186f -- This message was sent by Atlassian JIRA (v6.3.4#6332)
