Re: [Dev] Please review and merge PR

[Dinusha Senanayaka]

On Thu, Feb 22, 2018 at 10:29 AM, SajithAR Ariyarathna 
wrote:

> Hi Devs,
>
> Please review & merged PR https://github.com/wso2/carbon-appmgt/pull/709
> which fixes https://github.com/wso2/carbon-appmgt/issues/708 .
>

Merged.

Regards,
Dinusha

>
> Thanks.
>
> --
> Sajith Janaprasad Ariyarathna
> Senior Software Engineer; WSO2, Inc.;  http://wso2.com/
> 
>



-- 
Dinusha Dilrukshi
Technical Lead
WSO2 Inc.: http://wso2.com/
Mobile: +94764069991
Blog: http://dinushasblog.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[김대경]

Hi,

I,m using salesforce connector in EI-6.1.1.

I use this to query the salesforce objects using query and queryMore
functions.

The first query works, but of you do not do anything for about three hours
and then call again. EI get a connection in the connection pool and make an
http call and return a connection reset error.

In normal circumstances, the connection state changes to a stale state, and
a new connection is automatically obtained. However, in some server(in my
case Linux 2.6.32 x86_64) it is still not stale state, so a connection
reset error is detected only after an http call.

And a similar case description is described in the httpcomponents-client
document.

https://hc.apache.org/httpcomponents-client-4.3.x/tutorial/html/connmgmt.html#d5e405

Thank you,
Daekyung Kim



2018. 2. 7. 오전 4:25에 "Nishadi Kirielle" 님이 작성:

Hi Kim,

Thank you for your contribution. We are reviewing your PR.
As we are trying to reproduce the issue, can you please provide the exact
scenario where you faced this issue?

Thank you and regards,
Nishadi

On Sun, Feb 4, 2018 at 9:31 PM, 김대경  wrote:

>
> I wonder how it is progressing...
>
>
>
> 2018. 1. 26. 오후 1:31에 "김대경" 님이 작성:
>
> Can you please review and merge PR[1] .
>
> [1] https://github.com/wso2/wso2-commons-httpclient/pull/18
>
> Best Regards.
> Daekyung Kim.
>
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Nishadi Kirielle*
Software Engineer
WSO2, Inc.

Mobile : +94 70 204 5934
Blog : nishadikirielle.wordpress.com


___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Nishadi Kirielle]

Hi Kim,

Thank you for your contribution. We are reviewing your PR.
As we are trying to reproduce the issue, can you please provide the exact
scenario where you faced this issue?

Thank you and regards,
Nishadi

On Sun, Feb 4, 2018 at 9:31 PM, 김대경  wrote:

>
> I wonder how it is progressing...
>
>
>
> 2018. 1. 26. 오후 1:31에 "김대경" 님이 작성:
>
> Can you please review and merge PR[1] .
>
> [1] https://github.com/wso2/wso2-commons-httpclient/pull/18
>
> Best Regards.
> Daekyung Kim.
>
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Nishadi Kirielle*
Software Engineer
WSO2, Inc.

Mobile : +94 70 204 5934
Blog : nishadikirielle.wordpress.com


___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[김대경]

I wonder how it is progressing...



2018. 1. 26. 오후 1:31에 "김대경" 님이 작성:

Can you please review and merge PR[1] .

[1] https://github.com/wso2/wso2-commons-httpclient/pull/18

Best Regards.
Daekyung Kim.
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Prasanna Dangalla]

Hi Nuwandi,

PR is now merged.

Thanks

*Prasanna Dangalla*
Senior Software Engineer, WSO2, Inc.; http://wso2.com/
lean.enterprise.middleware


*cell: +94 718 11 27 51*
*twitter: @prasa77*

On Mon, Dec 4, 2017 at 10:35 AM, Nuwandi Wickramasinghe 
wrote:

> Hi,
>
> Please review and merge [1]
>
> [1] https://github.com/wso2/carbon-registry/pull/271
>
> thanks
> Nuwandi
>
> --
>
> Best Regards,
>
> Nuwandi Wickramasinghe
>
> Senior Software Engineer
>
> WSO2 Inc.
>
> Web : http://wso2.com
>
> Mobile : 0719214873
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Danesh Kuruppu]

Hi Nuwandi,

Reviewed and merged the PR[1]

1. https://github.com/wso2/carbon-registry/pull/268

Thanks
Danesh

On Wed, Nov 29, 2017 at 1:41 PM, Nuwandi Wickramasinghe 
wrote:

> Hi,
>
> Please review and merge [1]
>
> [1] https://github.com/wso2/carbon-registry/pull/264
>
> thanks
> Nuwandi
>
> --
>
> Best Regards,
>
> Nuwandi Wickramasinghe
>
> Senior Software Engineer
>
> WSO2 Inc.
>
> Web : http://wso2.com
>
> Mobile : 0719214873
>



-- 

*Danesh Kuruppu*
Senior Software Engineer | WSO2

Email: dan...@wso2.com
Mobile: +94 (77) 1690552
Web: WSO2 Inc 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] please review and merge

[Vijitha Ekanayake]

Hi Kim,

Thanks a lot for your contribution. We'll do the needful.

Thanks.

On Wed, Nov 22, 2017 at 7:15 PM, 김대경  wrote:

> Can you please review and merge PR[1] .
>
> [1] https://github.com/wso2/carbon-mediation/pull/906
>
> Best Regards.
> Daekyung Kim.
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Vijitha Ekanayake
Senior Software Engineer*, *WSO2, Inc.; http://wso2.com/
Mobile : +94 777 24 73 39 | +94 718 74 44 08
lean.enterprise.middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Vijitha Ekanayake]

Hi Kim,

Thanks a lot for your contribution. We'll do the needful.

Thanks.

On Mon, Nov 13, 2017 at 8:53 AM, Harsha Kumara  wrote:

>
>
> On Sun, Nov 12, 2017 at 7:28 PM, 김대경  wrote:
>
>> Can you please review and merge PR[1] and PR[2].
>>
>> [1] https://github.com/wso2/wso2-synapse/pull/952
>> [2] https://github.com/wso2/carbon-mediation/pull/906
>>
>> Best Regards.
>> Daekyung Kim.
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Harsha Kumara
> Software Engineer, WSO2 Inc.
> Mobile: +94775505618 <+94%2077%20550%205618>
> Blog:harshcreationz.blogspot.com
>



-- 
Vijitha Ekanayake
Senior Software Engineer*, *WSO2, Inc.; http://wso2.com/
Mobile : +94 777 24 73 39 | +94 718 74 44 08
lean.enterprise.middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Harsha Kumara]

On Sun, Nov 12, 2017 at 7:28 PM, 김대경  wrote:

> Can you please review and merge PR[1] and PR[2].
>
> [1] https://github.com/wso2/wso2-synapse/pull/952
> [2] https://github.com/wso2/carbon-mediation/pull/906
>
> Best Regards.
> Daekyung Kim.
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Harsha Kumara
Software Engineer, WSO2 Inc.
Mobile: +94775505618
Blog:harshcreationz.blogspot.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Isuranga Perera]

Hi Johann,

Sorry for the mistake. I have sent two separate emails for the issue.

On Thu, Oct 12, 2017 at 11:55 AM, Johann Nallathamby 
wrote:

> Hi Isuranga,
>
> First of all thank you for your contribution to WSO2 Identity Server.
>
> However, can you please follow the following protocol in order to get your
> PRs merged faster.
>
> 1. Create one JIRA per issue. Make sure you give the description clearly.
> Add the PRs related to the issue in the JIRA.
> 2. Send a mail to dev with the subject indicating the issue you are fixing
> (prefix with "[IAM]" is recommended).
> 3. Describe the problem (can be the same as description of the JIRA).
> 4. Give the references to the JIRA and PRs.
> 5. Request to review and merge.
>
> In the above mail there is no mention of the issue neither in the subject
> nor body. This won't get the attention of the required individuals (IAM)
> since the dev mailing list is a global mailing list for all development
> queries in WSO2.
>
> Also there are two separate issues in this mail. Always stick to one mail
> per issue so the discussion is focussed on one issue only. You have already
> sent a mail for the balana initialization issue [1]. You can add relevant
> JIRA and PR to that. Please send a separate mail for the custom function
> issue.
>
> Thanks again for the contribution.
>
> [1] "[Dev][IS][XACML] Introducing a Custom functionId"
>
> Regards,
> Johann.
>
> On Thu, Oct 12, 2017 at 10:52 AM, Isuranga Perera <
> isurangamper...@gmail.com> wrote:
>
>> Can you please review and merge PR[1] and PR[2].
>>
>> [1] https://github.com/wso2/balana/pull/75
>> [2] https://github.com/wso2/carbon-identity-framework/pull/1112
>>
>> Best Regards
>> Isuranga Perera
>>
>
>
>
> --
> Thanks & Regards,
>
> *Johann Dilantha Nallathamby*
> Senior Lead Solutions Engineer
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - *+9476950*
> Blog - *http://nallaa.wordpress.com *
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Johann Nallathamby]

Hi Isuranga,

First of all thank you for your contribution to WSO2 Identity Server.

However, can you please follow the following protocol in order to get your
PRs merged faster.

1. Create one JIRA per issue. Make sure you give the description clearly.
Add the PRs related to the issue in the JIRA.
2. Send a mail to dev with the subject indicating the issue you are fixing
(prefix with "[IAM]" is recommended).
3. Describe the problem (can be the same as description of the JIRA).
4. Give the references to the JIRA and PRs.
5. Request to review and merge.

In the above mail there is no mention of the issue neither in the subject
nor body. This won't get the attention of the required individuals (IAM)
since the dev mailing list is a global mailing list for all development
queries in WSO2.

Also there are two separate issues in this mail. Always stick to one mail
per issue so the discussion is focussed on one issue only. You have already
sent a mail for the balana initialization issue [1]. You can add relevant
JIRA and PR to that. Please send a separate mail for the custom function
issue.

Thanks again for the contribution.

[1] "[Dev][IS][XACML] Introducing a Custom functionId"

Regards,
Johann.

On Thu, Oct 12, 2017 at 10:52 AM, Isuranga Perera  wrote:

> Can you please review and merge PR[1] and PR[2].
>
> [1] https://github.com/wso2/balana/pull/75
> [2] https://github.com/wso2/carbon-identity-framework/pull/1112
>
> Best Regards
> Isuranga Perera
>



-- 
Thanks & Regards,

*Johann Dilantha Nallathamby*
Senior Lead Solutions Engineer
WSO2, Inc.
lean.enterprise.middleware

Mobile - *+9476950*
Blog - *http://nallaa.wordpress.com *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Farasath Ahamed]

Thanks Thusitha!

On Tuesday, September 19, 2017, Thusitha Thilina Dayaratne <
thusit...@wso2.com> wrote:

> Hi Farasath,
>
> Merged the PR.
>
>
>
>
> On Tue, Sep 19, 2017 at 6:36 PM, Farasath Ahamed  > wrote:
>
>> Hi,
>>
>> Can you please review and merge the following PR[1]. This needs to go
>> into Kernel 4.4.18
>>
>> [1] https://github.com/wso2/carbon-kernel/pull/1538
>>
>>
>>
>>
>> Thanks,
>> Farasath Ahamed
>> Software Engineer, WSO2 Inc.; http://wso2.com
>> Mobile: +94777603866
>> Blog: blog.farazath.com
>> Twitter: @farazath619 
>> 
>>
>>
>>
>
>
> --
> Thusitha Dayaratne
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> Mobile  +94712756809
> Blog  alokayasoya.blogspot.com
> Abouthttp://about.me/thusithathilina
> 
>
>

-- 
Farasath Ahamed
Software Engineer, WSO2 Inc.; http://wso2.com
Mobile: +94777603866
Blog: blog.farazath.com
Twitter: @farazath619 

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Thusitha Thilina Dayaratne]

Hi Farasath,

Merged the PR.




On Tue, Sep 19, 2017 at 6:36 PM, Farasath Ahamed  wrote:

> Hi,
>
> Can you please review and merge the following PR[1]. This needs to go into
> Kernel 4.4.18
>
> [1] https://github.com/wso2/carbon-kernel/pull/1538
>
>
>
>
> Thanks,
> Farasath Ahamed
> Software Engineer, WSO2 Inc.; http://wso2.com
> Mobile: +94777603866
> Blog: blog.farazath.com
> Twitter: @farazath619 
> 
>
>
>


-- 
Thusitha Dayaratne
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809
Blog  alokayasoya.blogspot.com
Abouthttp://about.me/thusithathilina

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Nilasini Thirunavukkarasu]

thanks.

On Tue, Sep 19, 2017 at 5:02 PM, Thusitha Thilina Dayaratne <
thusit...@wso2.com> wrote:

> Hi Nila,
>
> Merged the PR
>
> Thanks
> Thusitha
>
> On Tue, Sep 19, 2017 at 4:56 PM, Nilasini Thirunavukkarasu <
> nilas...@wso2.com> wrote:
>
>> Hi,
>>
>> Can you please review and merge the following PR.
>> [1] - https://github.com/wso2/carbon-kernel/pull/1533
>>
>>
>> Thanks,
>> Nila.
>>
>> --
>> Nilasini Thirunavukkarasu
>> Software Engineer - WSO2
>>
>> Email : nilas...@wso2.com
>> Mobile : +94775241823 <+94%2077%20524%201823>
>> Web : http://wso2.com/
>>
>>
>> 
>>
>
>
>
> --
> Thusitha Dayaratne
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> Mobile  +94712756809 <+94%2071%20275%206809>
> Blog  alokayasoya.blogspot.com
> Abouthttp://about.me/thusithathilina
> 
>
>


-- 
Nilasini Thirunavukkarasu
Software Engineer - WSO2

Email : nilas...@wso2.com
Mobile : +94775241823
Web : http://wso2.com/



___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Thusitha Thilina Dayaratne]

Hi Nila,

Merged the PR

Thanks
Thusitha

On Tue, Sep 19, 2017 at 4:56 PM, Nilasini Thirunavukkarasu <
nilas...@wso2.com> wrote:

> Hi,
>
> Can you please review and merge the following PR.
> [1] - https://github.com/wso2/carbon-kernel/pull/1533
>
>
> Thanks,
> Nila.
>
> --
> Nilasini Thirunavukkarasu
> Software Engineer - WSO2
>
> Email : nilas...@wso2.com
> Mobile : +94775241823 <+94%2077%20524%201823>
> Web : http://wso2.com/
>
>
> 
>



-- 
Thusitha Dayaratne
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809
Blog  alokayasoya.blogspot.com
Abouthttp://about.me/thusithathilina

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PRs

[Thanuja Jayasinghe]

Thanks.

On Tue, Sep 19, 2017 at 4:33 PM, Thusitha Thilina Dayaratne <
thusit...@wso2.com> wrote:

> Hi Thanuja,
>
> Merged the PRs
>
> Thanks
> Thusitha
>
> On Tue, Sep 19, 2017 at 3:49 PM, Thanuja Jayasinghe 
> wrote:
>
>> Hi,
>>
>> Can you please review and merge the following PRs.
>>
>> [1] - https://github.com/wso2/carbon-kernel/pull/1535
>> [2] - https://github.com/wso2/carbon-kernel/pull/1531
>>
>> Thanks,
>> Thanuja
>>
>> --
>> *Thanuja Lakmal*
>> Associate Technical Lead
>> WSO2 Inc. http://wso2.com/
>> *lean.enterprise.middleware*
>> Mobile: +94715979891
>>
>
>
>
> --
> Thusitha Dayaratne
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> Mobile  +94712756809 <+94%2071%20275%206809>
> Blog  alokayasoya.blogspot.com
> Abouthttp://about.me/thusithathilina
> 
>
>


-- 
*Thanuja Lakmal*
Associate Technical Lead
WSO2 Inc. http://wso2.com/
*lean.enterprise.middleware*
Mobile: +94715979891
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PRs

[Thusitha Thilina Dayaratne]

Hi Thanuja,

Merged the PRs

Thanks
Thusitha

On Tue, Sep 19, 2017 at 3:49 PM, Thanuja Jayasinghe 
wrote:

> Hi,
>
> Can you please review and merge the following PRs.
>
> [1] - https://github.com/wso2/carbon-kernel/pull/1535
> [2] - https://github.com/wso2/carbon-kernel/pull/1531
>
> Thanks,
> Thanuja
>
> --
> *Thanuja Lakmal*
> Associate Technical Lead
> WSO2 Inc. http://wso2.com/
> *lean.enterprise.middleware*
> Mobile: +94715979891
>



-- 
Thusitha Dayaratne
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809
Blog  alokayasoya.blogspot.com
Abouthttp://about.me/thusithathilina

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR for kernel

[Niranjan Karunanandham]

@thusitha: since the PR is sent to the 4.4.x branch, it will not close the
issue when the PR is merged. Therefore we will have to close the issue
after merging the PR.

Regards,
Nira

On Thu, Sep 14, 2017 at 11:28 AM, Thusitha Thilina Dayaratne <
thusit...@wso2.com> wrote:

> Hi Pulasthi,
>
> PR merged.
>
> Thanks
> Thusitha
>
> On Thu, Sep 14, 2017 at 6:51 PM, Pulasthi Mahawithana 
> wrote:
>
>> Hi,
>>
>> Please review and merge [1], which fixes [2]. Related Identity JIRA is at
>> [3].
>>
>> [1] https://github.com/wso2/carbon-kernel/pull/1527
>> 
>> [2] https://github.com/wso2/carbon-kernel/issues/1528
>> [3] https://wso2.org/jira/browse/IDENTITY-6048
>>
>>
>> --
>> *Pulasthi Mahawithana*
>> Senior Software Engineer
>> WSO2 Inc., http://wso2.com/
>> Mobile: +94-71-5179022 <+94%2071%20517%209022>
>> Blog: https://medium.com/@pulasthi7/
>>
>> 
>>
>
>
>
> --
> Thusitha Dayaratne
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> Mobile  +94712756809 <+94%2071%20275%206809>
> Blog  alokayasoya.blogspot.com
> Abouthttp://about.me/thusithathilina
> 
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 


*Niranjan Karunanandham*
Associate Technical Lead - WSO2 Inc.
WSO2 Inc.: http://www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR for kernel

[Thusitha Thilina Dayaratne]

Hi Pulasthi,

PR merged.

Thanks
Thusitha

On Thu, Sep 14, 2017 at 6:51 PM, Pulasthi Mahawithana 
wrote:

> Hi,
>
> Please review and merge [1], which fixes [2]. Related Identity JIRA is at
> [3].
>
> [1] https://github.com/wso2/carbon-kernel/pull/1527
> 
> [2] https://github.com/wso2/carbon-kernel/issues/1528
> [3] https://wso2.org/jira/browse/IDENTITY-6048
>
>
> --
> *Pulasthi Mahawithana*
> Senior Software Engineer
> WSO2 Inc., http://wso2.com/
> Mobile: +94-71-5179022 <+94%2071%20517%209022>
> Blog: https://medium.com/@pulasthi7/
>
> 
>



-- 
Thusitha Dayaratne
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809
Blog  alokayasoya.blogspot.com
Abouthttp://about.me/thusithathilina

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Dilan Udara Ariyaratne]

Hi Sathya,

Your PR was merged to carbon-deployment 4.7.x.

Thanks,
Dilan.

*Dilan U. Ariyaratne*
Senior Software Engineer
WSO2 Inc. 
Mobile: +94766405580 <%2B94766405580>
lean . enterprise . middleware


On Thu, Sep 14, 2017 at 5:39 AM, Dilan Udara Ariyaratne 
wrote:

> Hi Sathya,
>
> Added few more comments. Can you have a look ?
>
> Thanks,
> Dilan.
>
> *Dilan U. Ariyaratne*
> Senior Software Engineer
> WSO2 Inc. 
> Mobile: +94766405580 <%2B94766405580>
> lean . enterprise . middleware
>
>
> On Wed, Sep 13, 2017 at 2:37 PM, Sathya Bandara  wrote:
>
>> Hi,
>>
>> Can you please review and merge the PR [1]. This is regarding the Issue
>> [2].
>>
>> [1] https://github.com/wso2/carbon-deployment/pull/273
>> [2] https://github.com/wso2/carbon-deployment/issues/274
>>
>>
>> Thanks,
>> Sathya
>> --
>> Sathya Bandara
>> Software Engineer
>> WSO2 Inc. http://wso2.com
>> Mobile: (+94) 715 360 421 <+94%2071%20411%205032>
>>
>> <+94%2071%20411%205032>
>>
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Dilan Udara Ariyaratne]

Hi Sathya,

Added few more comments. Can you have a look ?

Thanks,
Dilan.

*Dilan U. Ariyaratne*
Senior Software Engineer
WSO2 Inc. 
Mobile: +94766405580 <%2B94766405580>
lean . enterprise . middleware


On Wed, Sep 13, 2017 at 2:37 PM, Sathya Bandara  wrote:

> Hi,
>
> Can you please review and merge the PR [1]. This is regarding the Issue
> [2].
>
> [1] https://github.com/wso2/carbon-deployment/pull/273
> [2] https://github.com/wso2/carbon-deployment/issues/274
>
>
> Thanks,
> Sathya
> --
> Sathya Bandara
> Software Engineer
> WSO2 Inc. http://wso2.com
> Mobile: (+94) 715 360 421 <+94%2071%20411%205032>
>
> <+94%2071%20411%205032>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Manorama Perera]

Thank you Madhawa.

On Thu, Sep 7, 2017 at 1:04 PM, Madhawa Gunasekara 
wrote:

> Merged.
>
> Regards,
> Madhawa
>
> On Thu, Sep 7, 2017 at 2:10 AM, Manorama Perera  wrote:
>
>> Hi,
>>
>> Please review and merge PR[1].
>>
>> [1] https://github.com/wso2/carbon-commons/pull/278
>>
>> Thanks,
>> Manorama
>>
>> --
>> Manorama Perera
>> Software Engineer
>> WSO2, Inc.;  http://wso2.com/
>>
>
>
>
> --
> *Madhawa Gunasekara*
> Senior Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: +94 719411002 <+94+719411002>
> blog: *http://madhawa-gunasekara.blogspot.com
> *
> linkedin: *http://lk.linkedin.com/in/mgunasekara
> *
>



-- 
Manorama Perera
Software Engineer
WSO2, Inc.;  http://wso2.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Madhawa Gunasekara]

Merged.

Regards,
Madhawa

On Thu, Sep 7, 2017 at 2:10 AM, Manorama Perera  wrote:

> Hi,
>
> Please review and merge PR[1].
>
> [1] https://github.com/wso2/carbon-commons/pull/278
>
> Thanks,
> Manorama
>
> --
> Manorama Perera
> Software Engineer
> WSO2, Inc.;  http://wso2.com/
>



-- 
*Madhawa Gunasekara*
Senior Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: +94 719411002 <+94+719411002>
blog: *http://madhawa-gunasekara.blogspot.com
*
linkedin: *http://lk.linkedin.com/in/mgunasekara
*
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Dilan Udara Ariyaratne]

Thanks, Ashen.

Your PR was merged on to carbon-kernel-4.4.x branch.

Regards,
Dilan.

*Dilan U. Ariyaratne*
Senior Software Engineer
WSO2 Inc. 
Mobile: +94766405580 <%2B94766405580>
lean . enterprise . middleware


On Fri, Aug 11, 2017 at 3:33 PM, Ashen Weerathunga  wrote:

> Hi Dilan,
>
> I have done the changes and successfully build the component and kernel
> with the tests.
>
> Thanks,
> Ashen
>
> On Fri, Aug 11, 2017 at 8:09 AM, Dilan Udara Ariyaratne 
> wrote:
>
>> Hi Ashen,
>>
>> Added Few more suggestions. Please go through and verify.
>>
>> Thanks,
>> Dilan.
>>
>> *Dilan U. Ariyaratne*
>> Senior Software Engineer
>> WSO2 Inc. 
>> Mobile: +94766405580 <%2B94766405580>
>> lean . enterprise . middleware
>>
>>
>> On Thu, Aug 10, 2017 at 7:23 PM, Ashen Weerathunga 
>> wrote:
>>
>>> Hi Dilan,
>>>
>>> I have done the requested changes and updated the PR.
>>>
>>> Thanks,
>>> Ashen
>>>
>>> On Thu, Aug 10, 2017 at 6:23 AM, Dilan Udara Ariyaratne >> > wrote:
>>>
 Hi Ashen,

 Went through the code and added few comments, Please go through and
 verify.

 Thanks,
 Dilan.

 *Dilan U. Ariyaratne*
 Senior Software Engineer
 WSO2 Inc. 
 Mobile: +94766405580 <%2B94766405580>
 lean . enterprise . middleware


 On Wed, Aug 9, 2017 at 1:44 PM, Ashen Weerathunga 
 wrote:

> Hi,
>
> Can you please review and merge the PR [1]. This is regarding the
> Issue [2].
>
> [1] https://github.com/wso2/carbon-kernel/pull/1464
> [2] https://github.com/wso2/carbon-kernel/issues/1467
>
>
> Thanks,
> Ashen
> --
> *Ashen Weerathunga*
> Software Engineer
> WSO2 Inc.: http://wso2.com
> lean.enterprise.middleware
>
> Email: as...@wso2.com
> Mobile: +94716042995 <94716042995>
> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
> *
> 
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>

>>>
>>>
>>> --
>>> *Ashen Weerathunga*
>>> Software Engineer
>>> WSO2 Inc.: http://wso2.com
>>> lean.enterprise.middleware
>>>
>>> Email: as...@wso2.com
>>> Mobile: +94716042995 <94716042995>
>>> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
>>> *
>>> 
>>>
>>
>>
>
>
> --
> *Ashen Weerathunga*
> Software Engineer
> WSO2 Inc.: http://wso2.com
> lean.enterprise.middleware
>
> Email: as...@wso2.com
> Mobile: +94716042995 <94716042995>
> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
> *
> 
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Ashen Weerathunga]

Hi Dilan,

I have done the changes and successfully build the component and kernel
with the tests.

Thanks,
Ashen

On Fri, Aug 11, 2017 at 8:09 AM, Dilan Udara Ariyaratne 
wrote:

> Hi Ashen,
>
> Added Few more suggestions. Please go through and verify.
>
> Thanks,
> Dilan.
>
> *Dilan U. Ariyaratne*
> Senior Software Engineer
> WSO2 Inc. 
> Mobile: +94766405580 <%2B94766405580>
> lean . enterprise . middleware
>
>
> On Thu, Aug 10, 2017 at 7:23 PM, Ashen Weerathunga  wrote:
>
>> Hi Dilan,
>>
>> I have done the requested changes and updated the PR.
>>
>> Thanks,
>> Ashen
>>
>> On Thu, Aug 10, 2017 at 6:23 AM, Dilan Udara Ariyaratne 
>> wrote:
>>
>>> Hi Ashen,
>>>
>>> Went through the code and added few comments, Please go through and
>>> verify.
>>>
>>> Thanks,
>>> Dilan.
>>>
>>> *Dilan U. Ariyaratne*
>>> Senior Software Engineer
>>> WSO2 Inc. 
>>> Mobile: +94766405580 <%2B94766405580>
>>> lean . enterprise . middleware
>>>
>>>
>>> On Wed, Aug 9, 2017 at 1:44 PM, Ashen Weerathunga 
>>> wrote:
>>>
 Hi,

 Can you please review and merge the PR [1]. This is regarding the Issue
 [2].

 [1] https://github.com/wso2/carbon-kernel/pull/1464
 [2] https://github.com/wso2/carbon-kernel/issues/1467


 Thanks,
 Ashen
 --
 *Ashen Weerathunga*
 Software Engineer
 WSO2 Inc.: http://wso2.com
 lean.enterprise.middleware

 Email: as...@wso2.com
 Mobile: +94716042995 <94716042995>
 LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
 *
 

 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev


>>>
>>
>>
>> --
>> *Ashen Weerathunga*
>> Software Engineer
>> WSO2 Inc.: http://wso2.com
>> lean.enterprise.middleware
>>
>> Email: as...@wso2.com
>> Mobile: +94716042995 <94716042995>
>> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
>> *
>> 
>>
>
>


-- 
*Ashen Weerathunga*
Software Engineer
WSO2 Inc.: http://wso2.com
lean.enterprise.middleware

Email: as...@wso2.com
Mobile: +94716042995 <94716042995>
LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
*

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Dilan Udara Ariyaratne]

Hi Ashen,

Added Few more suggestions. Please go through and verify.

Thanks,
Dilan.

*Dilan U. Ariyaratne*
Senior Software Engineer
WSO2 Inc. 
Mobile: +94766405580 <%2B94766405580>
lean . enterprise . middleware


On Thu, Aug 10, 2017 at 7:23 PM, Ashen Weerathunga  wrote:

> Hi Dilan,
>
> I have done the requested changes and updated the PR.
>
> Thanks,
> Ashen
>
> On Thu, Aug 10, 2017 at 6:23 AM, Dilan Udara Ariyaratne 
> wrote:
>
>> Hi Ashen,
>>
>> Went through the code and added few comments, Please go through and
>> verify.
>>
>> Thanks,
>> Dilan.
>>
>> *Dilan U. Ariyaratne*
>> Senior Software Engineer
>> WSO2 Inc. 
>> Mobile: +94766405580 <%2B94766405580>
>> lean . enterprise . middleware
>>
>>
>> On Wed, Aug 9, 2017 at 1:44 PM, Ashen Weerathunga  wrote:
>>
>>> Hi,
>>>
>>> Can you please review and merge the PR [1]. This is regarding the Issue
>>> [2].
>>>
>>> [1] https://github.com/wso2/carbon-kernel/pull/1464
>>> [2] https://github.com/wso2/carbon-kernel/issues/1467
>>>
>>>
>>> Thanks,
>>> Ashen
>>> --
>>> *Ashen Weerathunga*
>>> Software Engineer
>>> WSO2 Inc.: http://wso2.com
>>> lean.enterprise.middleware
>>>
>>> Email: as...@wso2.com
>>> Mobile: +94716042995 <94716042995>
>>> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
>>> *
>>> 
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>
>
> --
> *Ashen Weerathunga*
> Software Engineer
> WSO2 Inc.: http://wso2.com
> lean.enterprise.middleware
>
> Email: as...@wso2.com
> Mobile: +94716042995 <94716042995>
> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
> *
> 
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Ashen Weerathunga]

Hi Dilan,

I have done the requested changes and updated the PR.

Thanks,
Ashen

On Thu, Aug 10, 2017 at 6:23 AM, Dilan Udara Ariyaratne 
wrote:

> Hi Ashen,
>
> Went through the code and added few comments, Please go through and verify.
>
> Thanks,
> Dilan.
>
> *Dilan U. Ariyaratne*
> Senior Software Engineer
> WSO2 Inc. 
> Mobile: +94766405580 <%2B94766405580>
> lean . enterprise . middleware
>
>
> On Wed, Aug 9, 2017 at 1:44 PM, Ashen Weerathunga  wrote:
>
>> Hi,
>>
>> Can you please review and merge the PR [1]. This is regarding the Issue
>> [2].
>>
>> [1] https://github.com/wso2/carbon-kernel/pull/1464
>> [2] https://github.com/wso2/carbon-kernel/issues/1467
>>
>>
>> Thanks,
>> Ashen
>> --
>> *Ashen Weerathunga*
>> Software Engineer
>> WSO2 Inc.: http://wso2.com
>> lean.enterprise.middleware
>>
>> Email: as...@wso2.com
>> Mobile: +94716042995 <94716042995>
>> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
>> *
>> 
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>


-- 
*Ashen Weerathunga*
Software Engineer
WSO2 Inc.: http://wso2.com
lean.enterprise.middleware

Email: as...@wso2.com
Mobile: +94716042995 <94716042995>
LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
*

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Dilan Udara Ariyaratne]

Hi Ashen,

Went through the code and added few comments, Please go through and verify.

Thanks,
Dilan.

*Dilan U. Ariyaratne*
Senior Software Engineer
WSO2 Inc. 
Mobile: +94766405580 <%2B94766405580>
lean . enterprise . middleware


On Wed, Aug 9, 2017 at 1:44 PM, Ashen Weerathunga  wrote:

> Hi,
>
> Can you please review and merge the PR [1]. This is regarding the Issue
> [2].
>
> [1] https://github.com/wso2/carbon-kernel/pull/1464
> [2] https://github.com/wso2/carbon-kernel/issues/1467
>
>
> Thanks,
> Ashen
> --
> *Ashen Weerathunga*
> Software Engineer
> WSO2 Inc.: http://wso2.com
> lean.enterprise.middleware
>
> Email: as...@wso2.com
> Mobile: +94716042995 <94716042995>
> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
> *
> 
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Thusitha Thilina Dayaratne]

Hi Isuri,

PR merged.

Thanks

On Wed, Aug 2, 2017 at 3:56 PM, Isuri Anuradha  wrote:

> changed the commit message.
>
> [1] -https://github.com/wso2/carbon-kernel/pull/1460
>
> Regards,
> Isuri Anuradha.
>
> On Wed, Aug 2, 2017 at 3:33 PM, Isuri Anuradha  wrote:
>
>> Pull request URL.
>>
>> [1] - https://github.com/wso2/carbon-kernel/pull/1460
>>
>> Thanks.
>>
>> On Wed, Aug 2, 2017 at 3:10 PM, Isuri Anuradha  wrote:
>>
>>> Hi!
>>>
>>> Please merge the pull request [1] which contains the fix for [2].
>>>
>>> [1]- https://github.com/wso2/carbon-kernel/pull/1460
>>> [2]- https://github.com/wso2/carbon-kernel/issues/1461
>>>
>>>
>>> Regards,
>>> Isuri Anuradha
>>> --
>>> Isuri Anuradha
>>> Trainne software engineer | WSO2
>>>
>>> Emaii : is...@wso2.com
>>> Mobile : +94775941280 <+94%2077%20594%201280>
>>> web :http://wso2.com
>>>
>>> 
>>>
>>
>>
>>
>> --
>> Isuri Anuradha
>> Trainne software engineer | WSO2
>>
>> Emaii : is...@wso2.com
>> Mobile : +94775941280 <+94%2077%20594%201280>
>> web :http://wso2.com
>>
>> 
>>
>
>
>
> --
> Isuri Anuradha
> Trainne software engineer | WSO2
>
> Emaii : is...@wso2.com
> Mobile : +94775941280 <+94%2077%20594%201280>
> web :http://wso2.com
>
> 
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Thusitha Dayaratne
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809
Blog  alokayasoya.blogspot.com
Abouthttp://about.me/thusithathilina

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Isuri Anuradha]

changed the commit message.

[1] -https://github.com/wso2/carbon-kernel/pull/1460

Regards,
Isuri Anuradha.

On Wed, Aug 2, 2017 at 3:33 PM, Isuri Anuradha  wrote:

> Pull request URL.
>
> [1] - https://github.com/wso2/carbon-kernel/pull/1460
>
> Thanks.
>
> On Wed, Aug 2, 2017 at 3:10 PM, Isuri Anuradha  wrote:
>
>> Hi!
>>
>> Please merge the pull request [1] which contains the fix for [2].
>>
>> [1]- https://github.com/wso2/carbon-kernel/pull/1460
>> [2]- https://github.com/wso2/carbon-kernel/issues/1461
>>
>>
>> Regards,
>> Isuri Anuradha
>> --
>> Isuri Anuradha
>> Trainne software engineer | WSO2
>>
>> Emaii : is...@wso2.com
>> Mobile : +94775941280 <+94%2077%20594%201280>
>> web :http://wso2.com
>>
>> 
>>
>
>
>
> --
> Isuri Anuradha
> Trainne software engineer | WSO2
>
> Emaii : is...@wso2.com
> Mobile : +94775941280 <+94%2077%20594%201280>
> web :http://wso2.com
>
> 
>



-- 
Isuri Anuradha
Trainne software engineer | WSO2

Emaii : is...@wso2.com
Mobile : +94775941280
web :http://wso2.com


___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Isuri Anuradha]

Pull request URL.

[1] - https://github.com/wso2/carbon-kernel/pull/1460

Thanks.

On Wed, Aug 2, 2017 at 3:10 PM, Isuri Anuradha  wrote:

> Hi!
>
> Please merge the pull request [1] which contains the fix for [2].
>
> [1]- https://github.com/wso2/carbon-kernel/pull/1460
> [2]- https://github.com/wso2/carbon-kernel/issues/1461
>
>
> Regards,
> Isuri Anuradha
> --
> Isuri Anuradha
> Trainne software engineer | WSO2
>
> Emaii : is...@wso2.com
> Mobile : +94775941280 <+94%2077%20594%201280>
> web :http://wso2.com
>
> 
>



-- 
Isuri Anuradha
Trainne software engineer | WSO2

Emaii : is...@wso2.com
Mobile : +94775941280
web :http://wso2.com


___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Darshana Gunawardana]

Hi Farasath,

It seems like the PR **url** is correct but the hyperlink is wrong. Just
adding the PR link again to avoid the confusion.

https://github.com/wso2/carbon-kernel/pull/1456

Regards,


On Fri, Jul 28, 2017 at 6:58 PM, Farasath Ahamed  wrote:

>
>
>
> On Fri, Jul 28, 2017 at 6:29 PM, Dewni Weeraman  wrote:
>
>>
>> Hi,
>>
>> Please merge the pull request [1] which contains the fix for [2].
>>
>> [1] - https://github.com/wso2/carbon-kernel/pull/1456
>> 
>>
>
> This PR is already merged. Is this the correct one you intended?
>
>
>> [2] - https://github.com/wso2/carbon-kernel/issues/1455
>>
>>
>> Regards,
>> Dewni Weeraman
>>
>> --
>> *Dewni Weeraman*
>> Trainee Software Engineer | WSO2
>>
>> Email: de...@wso2.com
>> Mobile: +94772979049 <+94%2077%20297%209049>
>> Web: http://wso2.com/
>>
>>
>>
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Regards,


*Darshana Gunawardana*Associate Technical Lead
WSO2 Inc.; http://wso2.com

*E-mail: darsh...@wso2.com *
*Mobile: +94718566859*Lean . Enterprise . Middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Farasath Ahamed]

On Fri, Jul 28, 2017 at 6:29 PM, Dewni Weeraman  wrote:

>
> Hi,
>
> Please merge the pull request [1] which contains the fix for [2].
>
> [1] - https://github.com/wso2/carbon-kernel/pull/1456
> 
>

This PR is already merged. Is this the correct one you intended?


> [2] - https://github.com/wso2/carbon-kernel/issues/1455
>
>
> Regards,
> Dewni Weeraman
>
> --
> *Dewni Weeraman*
> Trainee Software Engineer | WSO2
>
> Email: de...@wso2.com
> Mobile: +94772979049 <+94%2077%20297%209049>
> Web: http://wso2.com/
>
>
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Thanuja Jayasinghe]

Thanks!

On Fri, Jul 21, 2017 at 10:17 AM, Thusitha Thilina Dayaratne <
thusit...@wso2.com> wrote:

> Hi Thanuja,
>
> PR is merged to 4.4.x branch.
>
> Thanks
> Thusitha
>
> On Thu, Jul 20, 2017 at 6:31 PM, Thanuja Jayasinghe 
> wrote:
>
>> Hi Kishanthan,
>>
>> Please merge the pull request [1] which contains the fix for [2].
>>
>> [1] - https://github.com/wso2/carbon-kernel/pull/1445
>> [2] - https://github.com/wso2/carbon-kernel/issues/1444
>>
>> Thanks,
>> Thanuja
>>
>> --
>> *Thanuja Lakmal*
>> Associate Technical Lead
>> WSO2 Inc. http://wso2.com/
>> *lean.enterprise.middleware*
>> Mobile: +94715979891
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Thusitha Dayaratne
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> Mobile  +94712756809 <+94%2071%20275%206809>
> Blog  alokayasoya.blogspot.com
> Abouthttp://about.me/thusithathilina
> 
>
>


-- 
*Thanuja Lakmal*
Associate Technical Lead
WSO2 Inc. http://wso2.com/
*lean.enterprise.middleware*
Mobile: +94715979891
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Thusitha Thilina Dayaratne]

Hi Thanuja,

PR is merged to 4.4.x branch.

Thanks
Thusitha

On Thu, Jul 20, 2017 at 6:31 PM, Thanuja Jayasinghe 
wrote:

> Hi Kishanthan,
>
> Please merge the pull request [1] which contains the fix for [2].
>
> [1] - https://github.com/wso2/carbon-kernel/pull/1445
> [2] - https://github.com/wso2/carbon-kernel/issues/1444
>
> Thanks,
> Thanuja
>
> --
> *Thanuja Lakmal*
> Associate Technical Lead
> WSO2 Inc. http://wso2.com/
> *lean.enterprise.middleware*
> Mobile: +94715979891
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Thusitha Dayaratne
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809
Blog  alokayasoya.blogspot.com
Abouthttp://about.me/thusithathilina

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Thanuja Jayasinghe]

Thanks.

On Wed, May 31, 2017 at 11:58 AM, Jayanga Dissanayake 
wrote:

> Hi Tahnuja,
>
> Merged the PR.
>
> Thanks,
> Jayanga.
>
> *Jayanga Dissanayake*
> Associate Technical Lead
> WSO2 Inc. - http://wso2.com/
> lean . enterprise . middleware
> email: jaya...@wso2.com
> mobile: +94772207259 <+94%2077%20220%207259>
> 
>
> On Tue, May 30, 2017 at 12:28 PM, Thanuja Jayasinghe 
> wrote:
>
>> Hi Jayanga,
>>
>> Please merge the pull request [1] which contains the fix for [2].
>>
>> [1] - https://github.com/wso2/carbon-kernel/pull/1388
>> [2] - https://github.com/wso2/carbon-kernel/issues/1387
>>
>> Thanks,
>> Thanuja
>>
>> --
>> *Thanuja Lakmal*
>> Senior Software Engineer
>> WSO2 Inc. http://wso2.com/
>> *lean.enterprise.middleware*
>> Mobile: +94715979891 +94758009992
>>
>
>


-- 
*Thanuja Lakmal*
Associate Technical Lead
WSO2 Inc. http://wso2.com/
*lean.enterprise.middleware*
Mobile: +94715979891
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Jayanga Dissanayake]

Hi Tahnuja,

Merged the PR.

Thanks,
Jayanga.

*Jayanga Dissanayake*
Associate Technical Lead
WSO2 Inc. - http://wso2.com/
lean . enterprise . middleware
email: jaya...@wso2.com
mobile: +94772207259


On Tue, May 30, 2017 at 12:28 PM, Thanuja Jayasinghe 
wrote:

> Hi Jayanga,
>
> Please merge the pull request [1] which contains the fix for [2].
>
> [1] - https://github.com/wso2/carbon-kernel/pull/1388
> [2] - https://github.com/wso2/carbon-kernel/issues/1387
>
> Thanks,
> Thanuja
>
> --
> *Thanuja Lakmal*
> Senior Software Engineer
> WSO2 Inc. http://wso2.com/
> *lean.enterprise.middleware*
> Mobile: +94715979891 +94758009992
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Farasath Ahamed]

Thanks, Rajjaz.

Farasath Ahamed
Software Engineer, WSO2 Inc.; http://wso2.com
Mobile: +94777603866
Blog: blog.farazath.com
Twitter: @farazath619 




On Sat, May 6, 2017 at 11:29 AM, Rajjaz Mohammed  wrote:

> Hi All,
>
> You can find the new version of extension here[1].
>
> [1] https://store.wso2.com/store/assets/isconnector/details/
> 8affec9a-706f-4e72-83ec-f65c42895d40
>
> On Sat, May 6, 2017 at 9:41 AM, Rajjaz Mohammed  wrote:
>
>> Hi,
>>
>> We will do the needful to release the extension.
>>
>> On Fri, May 5, 2017 at 6:07 PM, Farasath Ahamed 
>> wrote:
>>
>>> Hi Kathees,
>>>
>>> Also, can you do the needful to update the connector store with this
>>> latest version?
>>>
>>>
>>> Thanks,
>>> Farasath
>>>
>>> Farasath Ahamed
>>> Software Engineer, WSO2 Inc.; http://wso2.com
>>> Mobile: +94777603866
>>> Blog: blog.farazath.com
>>> Twitter: @farazath619 
>>> 
>>>
>>>
>>>
>>> On Fri, May 5, 2017 at 5:37 PM, Kathees Rajendram 
>>> wrote:
>>>
 Hi Ishara/Hasanthi,

 The PR is merged.

 Thanks,
 Kathees



 On Fri, May 5, 2017 at 1:00 PM, Ishara Karunarathna 
 wrote:

> Hi connector team,
>
> Can we get this merged ?
>
> -Ishara
>
> On Fri, May 5, 2017 at 10:11 AM, Hasanthi Purnima Dissanayake <
> hasan...@wso2.com> wrote:
>
>> Hi Kathees
>>
>> Fixed the comments.
>>
>> Thanks,
>>
>> Hasanthi Dissanayake
>>
>> Software Engineer | WSO2
>>
>> E: hasan...@wso2.com
>> M :0718407133| http://wso2.com 
>>
>> On Fri, May 5, 2017 at 9:45 AM, Kathees Rajendram 
>> wrote:
>>
>>> Thanks Hasanthi for your fix.
>>>
>>> Please fix those comments in the PR.
>>>
>>> Thanks,
>>> Kathees
>>>
>>> On Thu, May 4, 2017 at 3:16 PM, Hasanthi Purnima Dissanayake <
>>> hasan...@wso2.com> wrote:
>>>
 Hi connector team,
 Please review and merge [1] which fixes [2].
 [1]https://github.com/wso2-extensions/identity-oauth2-grant-
 jwt/pull/14
 [2]https://wso2.org/jira/browse/IDENTITY-5888

 Thanks,

 Hasanthi Dissanayake

 Software Engineer | WSO2

 E: hasan...@wso2.com
 M :0718407133| http://wso2.com 

>>>
>>>
>>>
>>> --
>>> Kathees
>>> Software Engineer,
>>> email: kath...@wso2.com
>>> mobile: +94772596173 <+94%2077%20259%206173>
>>>
>>
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Ishara Karunarathna
> Associate Technical Lead
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> email: isha...@wso2.com,   blog: isharaaruna.blogspot.com,   mobile:
> +94717996791 <+94%2071%20799%206791>
>
>
>


 --
 Kathees
 Software Engineer,
 email: kath...@wso2.com
 mobile: +94772596173 <+94%2077%20259%206173>

 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev


>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> Thank you
>> Best Regards
>>
>> *Rajjaz HM*
>> Software Engineer
>> Platform Extension Team
>> WSO2 Inc. 
>> lean | enterprise | middleware
>> Mobile | +94752833834 <+94%2075%20283%203834>|+94777226874
>> <+94%2077%20722%206874>
>> Email   | raj...@wso2.com
>> LinkedIn  | Blogger
>>  | WSO2 Profile
>> 
>> [image: https://wso2.com/signature] 
>>
>
>
>
> --
> Thank you
> Best Regards
>
> *Rajjaz HM*
> Software Engineer
> Platform Extension Team
> WSO2 Inc. 
> lean | enterprise | middleware
> Mobile | +94752833834 <+94%2075%20283%203834>|+94777226874
> <+94%2077%20722%206874>
> Email   | raj...@wso2.com
> LinkedIn  | Blogger
>  | WSO2 Profile
> 
> [image: https://wso2.com/signature] 
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Rajjaz Mohammed]

Hi All,

You can find the new version of extension here[1].

[1]
https://store.wso2.com/store/assets/isconnector/details/8affec9a-706f-4e72-83ec-f65c42895d40

On Sat, May 6, 2017 at 9:41 AM, Rajjaz Mohammed  wrote:

> Hi,
>
> We will do the needful to release the extension.
>
> On Fri, May 5, 2017 at 6:07 PM, Farasath Ahamed 
> wrote:
>
>> Hi Kathees,
>>
>> Also, can you do the needful to update the connector store with this
>> latest version?
>>
>>
>> Thanks,
>> Farasath
>>
>> Farasath Ahamed
>> Software Engineer, WSO2 Inc.; http://wso2.com
>> Mobile: +94777603866
>> Blog: blog.farazath.com
>> Twitter: @farazath619 
>> 
>>
>>
>>
>> On Fri, May 5, 2017 at 5:37 PM, Kathees Rajendram 
>> wrote:
>>
>>> Hi Ishara/Hasanthi,
>>>
>>> The PR is merged.
>>>
>>> Thanks,
>>> Kathees
>>>
>>>
>>>
>>> On Fri, May 5, 2017 at 1:00 PM, Ishara Karunarathna 
>>> wrote:
>>>
 Hi connector team,

 Can we get this merged ?

 -Ishara

 On Fri, May 5, 2017 at 10:11 AM, Hasanthi Purnima Dissanayake <
 hasan...@wso2.com> wrote:

> Hi Kathees
>
> Fixed the comments.
>
> Thanks,
>
> Hasanthi Dissanayake
>
> Software Engineer | WSO2
>
> E: hasan...@wso2.com
> M :0718407133| http://wso2.com 
>
> On Fri, May 5, 2017 at 9:45 AM, Kathees Rajendram 
> wrote:
>
>> Thanks Hasanthi for your fix.
>>
>> Please fix those comments in the PR.
>>
>> Thanks,
>> Kathees
>>
>> On Thu, May 4, 2017 at 3:16 PM, Hasanthi Purnima Dissanayake <
>> hasan...@wso2.com> wrote:
>>
>>> Hi connector team,
>>> Please review and merge [1] which fixes [2].
>>> [1]https://github.com/wso2-extensions/identity-oauth2-grant-
>>> jwt/pull/14
>>> [2]https://wso2.org/jira/browse/IDENTITY-5888
>>>
>>> Thanks,
>>>
>>> Hasanthi Dissanayake
>>>
>>> Software Engineer | WSO2
>>>
>>> E: hasan...@wso2.com
>>> M :0718407133| http://wso2.com 
>>>
>>
>>
>>
>> --
>> Kathees
>> Software Engineer,
>> email: kath...@wso2.com
>> mobile: +94772596173 <+94%2077%20259%206173>
>>
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


 --
 Ishara Karunarathna
 Associate Technical Lead
 WSO2 Inc. - lean . enterprise . middleware |  wso2.com

 email: isha...@wso2.com,   blog: isharaaruna.blogspot.com,   mobile:
 +94717996791 <+94%2071%20799%206791>



>>>
>>>
>>> --
>>> Kathees
>>> Software Engineer,
>>> email: kath...@wso2.com
>>> mobile: +94772596173 <+94%2077%20259%206173>
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Thank you
> Best Regards
>
> *Rajjaz HM*
> Software Engineer
> Platform Extension Team
> WSO2 Inc. 
> lean | enterprise | middleware
> Mobile | +94752833834 <+94%2075%20283%203834>|+94777226874
> <+94%2077%20722%206874>
> Email   | raj...@wso2.com
> LinkedIn  | Blogger
>  | WSO2 Profile
> 
> [image: https://wso2.com/signature] 
>



-- 
Thank you
Best Regards

*Rajjaz HM*
Software Engineer
Platform Extension Team
WSO2 Inc. 
lean | enterprise | middleware
Mobile | +94752833834|+94777226874
Email   | raj...@wso2.com
LinkedIn  | Blogger
 | WSO2 Profile

[image: https://wso2.com/signature] 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Rajjaz Mohammed]

Hi,

We will do the needful to release the extension.

On Fri, May 5, 2017 at 6:07 PM, Farasath Ahamed  wrote:

> Hi Kathees,
>
> Also, can you do the needful to update the connector store with this
> latest version?
>
>
> Thanks,
> Farasath
>
> Farasath Ahamed
> Software Engineer, WSO2 Inc.; http://wso2.com
> Mobile: +94777603866
> Blog: blog.farazath.com
> Twitter: @farazath619 
> 
>
>
>
> On Fri, May 5, 2017 at 5:37 PM, Kathees Rajendram 
> wrote:
>
>> Hi Ishara/Hasanthi,
>>
>> The PR is merged.
>>
>> Thanks,
>> Kathees
>>
>>
>>
>> On Fri, May 5, 2017 at 1:00 PM, Ishara Karunarathna 
>> wrote:
>>
>>> Hi connector team,
>>>
>>> Can we get this merged ?
>>>
>>> -Ishara
>>>
>>> On Fri, May 5, 2017 at 10:11 AM, Hasanthi Purnima Dissanayake <
>>> hasan...@wso2.com> wrote:
>>>
 Hi Kathees

 Fixed the comments.

 Thanks,

 Hasanthi Dissanayake

 Software Engineer | WSO2

 E: hasan...@wso2.com
 M :0718407133| http://wso2.com 

 On Fri, May 5, 2017 at 9:45 AM, Kathees Rajendram 
 wrote:

> Thanks Hasanthi for your fix.
>
> Please fix those comments in the PR.
>
> Thanks,
> Kathees
>
> On Thu, May 4, 2017 at 3:16 PM, Hasanthi Purnima Dissanayake <
> hasan...@wso2.com> wrote:
>
>> Hi connector team,
>> Please review and merge [1] which fixes [2].
>> [1]https://github.com/wso2-extensions/identity-oauth2-grant-
>> jwt/pull/14
>> [2]https://wso2.org/jira/browse/IDENTITY-5888
>>
>> Thanks,
>>
>> Hasanthi Dissanayake
>>
>> Software Engineer | WSO2
>>
>> E: hasan...@wso2.com
>> M :0718407133| http://wso2.com 
>>
>
>
>
> --
> Kathees
> Software Engineer,
> email: kath...@wso2.com
> mobile: +94772596173 <+94%2077%20259%206173>
>


 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev


>>>
>>>
>>> --
>>> Ishara Karunarathna
>>> Associate Technical Lead
>>> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>>>
>>> email: isha...@wso2.com,   blog: isharaaruna.blogspot.com,   mobile:
>>> +94717996791 <+94%2071%20799%206791>
>>>
>>>
>>>
>>
>>
>> --
>> Kathees
>> Software Engineer,
>> email: kath...@wso2.com
>> mobile: +94772596173 <+94%2077%20259%206173>
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Thank you
Best Regards

*Rajjaz HM*
Software Engineer
Platform Extension Team
WSO2 Inc. 
lean | enterprise | middleware
Mobile | +94752833834|+94777226874
Email   | raj...@wso2.com
LinkedIn  | Blogger
 | WSO2 Profile

[image: https://wso2.com/signature] 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Farasath Ahamed]

Hi Kathees,

Also, can you do the needful to update the connector store with this latest
version?


Thanks,
Farasath

Farasath Ahamed
Software Engineer, WSO2 Inc.; http://wso2.com
Mobile: +94777603866
Blog: blog.farazath.com
Twitter: @farazath619 




On Fri, May 5, 2017 at 5:37 PM, Kathees Rajendram  wrote:

> Hi Ishara/Hasanthi,
>
> The PR is merged.
>
> Thanks,
> Kathees
>
>
>
> On Fri, May 5, 2017 at 1:00 PM, Ishara Karunarathna 
> wrote:
>
>> Hi connector team,
>>
>> Can we get this merged ?
>>
>> -Ishara
>>
>> On Fri, May 5, 2017 at 10:11 AM, Hasanthi Purnima Dissanayake <
>> hasan...@wso2.com> wrote:
>>
>>> Hi Kathees
>>>
>>> Fixed the comments.
>>>
>>> Thanks,
>>>
>>> Hasanthi Dissanayake
>>>
>>> Software Engineer | WSO2
>>>
>>> E: hasan...@wso2.com
>>> M :0718407133| http://wso2.com 
>>>
>>> On Fri, May 5, 2017 at 9:45 AM, Kathees Rajendram 
>>> wrote:
>>>
 Thanks Hasanthi for your fix.

 Please fix those comments in the PR.

 Thanks,
 Kathees

 On Thu, May 4, 2017 at 3:16 PM, Hasanthi Purnima Dissanayake <
 hasan...@wso2.com> wrote:

> Hi connector team,
> Please review and merge [1] which fixes [2].
> [1]https://github.com/wso2-extensions/identity-oauth2-grant-
> jwt/pull/14
> [2]https://wso2.org/jira/browse/IDENTITY-5888
>
> Thanks,
>
> Hasanthi Dissanayake
>
> Software Engineer | WSO2
>
> E: hasan...@wso2.com
> M :0718407133| http://wso2.com 
>



 --
 Kathees
 Software Engineer,
 email: kath...@wso2.com
 mobile: +94772596173 <+94%2077%20259%206173>

>>>
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> Ishara Karunarathna
>> Associate Technical Lead
>> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>>
>> email: isha...@wso2.com,   blog: isharaaruna.blogspot.com,   mobile:
>> +94717996791 <+94%2071%20799%206791>
>>
>>
>>
>
>
> --
> Kathees
> Software Engineer,
> email: kath...@wso2.com
> mobile: +94772596173 <+94%2077%20259%206173>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Kathees Rajendram]

Hi Ishara/Hasanthi,

The PR is merged.

Thanks,
Kathees



On Fri, May 5, 2017 at 1:00 PM, Ishara Karunarathna 
wrote:

> Hi connector team,
>
> Can we get this merged ?
>
> -Ishara
>
> On Fri, May 5, 2017 at 10:11 AM, Hasanthi Purnima Dissanayake <
> hasan...@wso2.com> wrote:
>
>> Hi Kathees
>>
>> Fixed the comments.
>>
>> Thanks,
>>
>> Hasanthi Dissanayake
>>
>> Software Engineer | WSO2
>>
>> E: hasan...@wso2.com
>> M :0718407133| http://wso2.com 
>>
>> On Fri, May 5, 2017 at 9:45 AM, Kathees Rajendram 
>> wrote:
>>
>>> Thanks Hasanthi for your fix.
>>>
>>> Please fix those comments in the PR.
>>>
>>> Thanks,
>>> Kathees
>>>
>>> On Thu, May 4, 2017 at 3:16 PM, Hasanthi Purnima Dissanayake <
>>> hasan...@wso2.com> wrote:
>>>
 Hi connector team,
 Please review and merge [1] which fixes [2].
 [1]https://github.com/wso2-extensions/identity-oauth2-grant-jwt/pull/14
 [2]https://wso2.org/jira/browse/IDENTITY-5888

 Thanks,

 Hasanthi Dissanayake

 Software Engineer | WSO2

 E: hasan...@wso2.com
 M :0718407133| http://wso2.com 

>>>
>>>
>>>
>>> --
>>> Kathees
>>> Software Engineer,
>>> email: kath...@wso2.com
>>> mobile: +94772596173 <+94%2077%20259%206173>
>>>
>>
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Ishara Karunarathna
> Associate Technical Lead
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> email: isha...@wso2.com,   blog: isharaaruna.blogspot.com,   mobile:
> +94717996791 <+94%2071%20799%206791>
>
>
>


-- 
Kathees
Software Engineer,
email: kath...@wso2.com
mobile: +94772596173
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Ishara Karunarathna]

Hi connector team,

Can we get this merged ?

-Ishara

On Fri, May 5, 2017 at 10:11 AM, Hasanthi Purnima Dissanayake <
hasan...@wso2.com> wrote:

> Hi Kathees
>
> Fixed the comments.
>
> Thanks,
>
> Hasanthi Dissanayake
>
> Software Engineer | WSO2
>
> E: hasan...@wso2.com
> M :0718407133| http://wso2.com 
>
> On Fri, May 5, 2017 at 9:45 AM, Kathees Rajendram 
> wrote:
>
>> Thanks Hasanthi for your fix.
>>
>> Please fix those comments in the PR.
>>
>> Thanks,
>> Kathees
>>
>> On Thu, May 4, 2017 at 3:16 PM, Hasanthi Purnima Dissanayake <
>> hasan...@wso2.com> wrote:
>>
>>> Hi connector team,
>>> Please review and merge [1] which fixes [2].
>>> [1]https://github.com/wso2-extensions/identity-oauth2-grant-jwt/pull/14
>>> [2]https://wso2.org/jira/browse/IDENTITY-5888
>>>
>>> Thanks,
>>>
>>> Hasanthi Dissanayake
>>>
>>> Software Engineer | WSO2
>>>
>>> E: hasan...@wso2.com
>>> M :0718407133| http://wso2.com 
>>>
>>
>>
>>
>> --
>> Kathees
>> Software Engineer,
>> email: kath...@wso2.com
>> mobile: +94772596173 <+94%2077%20259%206173>
>>
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Ishara Karunarathna
Associate Technical Lead
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

email: isha...@wso2.com,   blog: isharaaruna.blogspot.com,   mobile:
+94717996791
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Hasanthi Purnima Dissanayake]

Hi Kathees

Fixed the comments.

Thanks,

Hasanthi Dissanayake

Software Engineer | WSO2

E: hasan...@wso2.com
M :0718407133| http://wso2.com 

On Fri, May 5, 2017 at 9:45 AM, Kathees Rajendram  wrote:

> Thanks Hasanthi for your fix.
>
> Please fix those comments in the PR.
>
> Thanks,
> Kathees
>
> On Thu, May 4, 2017 at 3:16 PM, Hasanthi Purnima Dissanayake <
> hasan...@wso2.com> wrote:
>
>> Hi connector team,
>> Please review and merge [1] which fixes [2].
>> [1]https://github.com/wso2-extensions/identity-oauth2-grant-jwt/pull/14
>> [2]https://wso2.org/jira/browse/IDENTITY-5888
>>
>> Thanks,
>>
>> Hasanthi Dissanayake
>>
>> Software Engineer | WSO2
>>
>> E: hasan...@wso2.com
>> M :0718407133| http://wso2.com 
>>
>
>
>
> --
> Kathees
> Software Engineer,
> email: kath...@wso2.com
> mobile: +94772596173 <+94%2077%20259%206173>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Kathees Rajendram]

Thanks Hasanthi for your fix.

Please fix those comments in the PR.

Thanks,
Kathees

On Thu, May 4, 2017 at 3:16 PM, Hasanthi Purnima Dissanayake <
hasan...@wso2.com> wrote:

> Hi connector team,
> Please review and merge [1] which fixes [2].
> [1]https://github.com/wso2-extensions/identity-oauth2-grant-jwt/pull/14
> [2]https://wso2.org/jira/browse/IDENTITY-5888
>
> Thanks,
>
> Hasanthi Dissanayake
>
> Software Engineer | WSO2
>
> E: hasan...@wso2.com
> M :0718407133| http://wso2.com 
>



-- 
Kathees
Software Engineer,
email: kath...@wso2.com
mobile: +94772596173
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Vijitha Ekanayake]

Thanks Thusitha !!!

On Thu, Apr 6, 2017 at 11:58 AM, Thusitha Thilina Dayaratne <
thusit...@wso2.com> wrote:

> Merged.
>
> On Thu, Apr 6, 2017 at 11:54 AM, Vinod Kavinda  wrote:
>
>> Hi Kishanthan,
>> Please review and merge PR[1] for preparing 4.4.16 release.
>>
>> [1] - https://github.com/wso2/carbon-kernel/pull/1350
>>
>> Thanks
>>
>> On Thu, Apr 6, 2017 at 10:37 AM, Vijitha Ekanayake 
>> wrote:
>>
>>> Hi Kishanthan,
>>>
>>> I've updated the PR[1] with the issue[2] and a proper description. Could
>>> you review and merge the pull request?
>>>
>>>
>>> [1]. https://github.com/wso2/carbon-kernel/pull/1349
>>> [2]. https://github.com/wso2/product-ei/issues/322
>>>
>>>
>>> Thanks
>>>
>>> On Thu, Apr 6, 2017 at 9:59 AM, Kishanthan Thangarajah <
>>> kishant...@wso2.com> wrote:
>>>
 Can you also create a github issue with the proper description for this
 and link it with the PR?

 On Wed, Apr 5, 2017 at 9:44 PM, Vijitha Ekanayake 
 wrote:

> Hi Carbon team,
>
> Please merge the pull request [1] which contains critical fixes to
> support DSS multitenancy over passthru transport.
>
> [1]. https://github.com/wso2/carbon-kernel/pull/1349
>
> Thanks.
>
> --
> Vijitha Ekanayake
> Software Engineer*, *WSO2, Inc.; http://wso2.com/
> Mobile : +94 777 24 73 39 | +94 718 74 44 08
> lean.enterprise.middleware
>



 --
 *Kishanthan Thangarajah*
 Technical Lead,
 Platform Technologies Team,
 WSO2, Inc.
 lean.enterprise.middleware

 Mobile - +94773426635 <+94%2077%20342%206635>
 Blog - *http://kishanthan.wordpress.com
 *
 Twitter - *http://twitter.com/kishanthan
 *

>>>
>>>
>>>
>>> --
>>> Vijitha Ekanayake
>>> Software Engineer*, *WSO2, Inc.; http://wso2.com/
>>> Mobile : +94 777 24 73 39 | +94 718 74 44 08
>>> lean.enterprise.middleware
>>>
>>
>>
>>
>> --
>> Vinod Kavinda
>> Software Engineer
>> *WSO2 Inc. - lean . enterprise . middleware .*
>> Mobile : +94 (0) 712 415544
>> Blog : http://soatechflicks.blogspot.com/
>> [image: http://wso2.com/signature]
>> 
>>
>>
>
>
> --
> Thusitha Dayaratne
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> Mobile  +94712756809 <+94%2071%20275%206809>
> Blog  alokayasoya.blogspot.com
> Abouthttp://about.me/thusithathilina
> 
>
>


-- 
Vijitha Ekanayake
Software Engineer*, *WSO2, Inc.; http://wso2.com/
Mobile : +94 777 24 73 39 | +94 718 74 44 08
lean.enterprise.middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Thusitha Thilina Dayaratne]

Merged.

On Thu, Apr 6, 2017 at 11:54 AM, Vinod Kavinda  wrote:

> Hi Kishanthan,
> Please review and merge PR[1] for preparing 4.4.16 release.
>
> [1] - https://github.com/wso2/carbon-kernel/pull/1350
>
> Thanks
>
> On Thu, Apr 6, 2017 at 10:37 AM, Vijitha Ekanayake 
> wrote:
>
>> Hi Kishanthan,
>>
>> I've updated the PR[1] with the issue[2] and a proper description. Could
>> you review and merge the pull request?
>>
>>
>> [1]. https://github.com/wso2/carbon-kernel/pull/1349
>> [2]. https://github.com/wso2/product-ei/issues/322
>>
>>
>> Thanks
>>
>> On Thu, Apr 6, 2017 at 9:59 AM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>> Can you also create a github issue with the proper description for this
>>> and link it with the PR?
>>>
>>> On Wed, Apr 5, 2017 at 9:44 PM, Vijitha Ekanayake 
>>> wrote:
>>>
 Hi Carbon team,

 Please merge the pull request [1] which contains critical fixes to
 support DSS multitenancy over passthru transport.

 [1]. https://github.com/wso2/carbon-kernel/pull/1349

 Thanks.

 --
 Vijitha Ekanayake
 Software Engineer*, *WSO2, Inc.; http://wso2.com/
 Mobile : +94 777 24 73 39 | +94 718 74 44 08
 lean.enterprise.middleware

>>>
>>>
>>>
>>> --
>>> *Kishanthan Thangarajah*
>>> Technical Lead,
>>> Platform Technologies Team,
>>> WSO2, Inc.
>>> lean.enterprise.middleware
>>>
>>> Mobile - +94773426635 <+94%2077%20342%206635>
>>> Blog - *http://kishanthan.wordpress.com
>>> *
>>> Twitter - *http://twitter.com/kishanthan
>>> *
>>>
>>
>>
>>
>> --
>> Vijitha Ekanayake
>> Software Engineer*, *WSO2, Inc.; http://wso2.com/
>> Mobile : +94 777 24 73 39 | +94 718 74 44 08
>> lean.enterprise.middleware
>>
>
>
>
> --
> Vinod Kavinda
> Software Engineer
> *WSO2 Inc. - lean . enterprise . middleware .*
> Mobile : +94 (0) 712 415544
> Blog : http://soatechflicks.blogspot.com/
> [image: http://wso2.com/signature]
> 
>
>


-- 
Thusitha Dayaratne
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809
Blog  alokayasoya.blogspot.com
Abouthttp://about.me/thusithathilina

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Vinod Kavinda]

Hi Kishanthan,
Please review and merge PR[1] for preparing 4.4.16 release.

[1] - https://github.com/wso2/carbon-kernel/pull/1350

Thanks

On Thu, Apr 6, 2017 at 10:37 AM, Vijitha Ekanayake 
wrote:

> Hi Kishanthan,
>
> I've updated the PR[1] with the issue[2] and a proper description. Could
> you review and merge the pull request?
>
>
> [1]. https://github.com/wso2/carbon-kernel/pull/1349
> [2]. https://github.com/wso2/product-ei/issues/322
>
>
> Thanks
>
> On Thu, Apr 6, 2017 at 9:59 AM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> Can you also create a github issue with the proper description for this
>> and link it with the PR?
>>
>> On Wed, Apr 5, 2017 at 9:44 PM, Vijitha Ekanayake 
>> wrote:
>>
>>> Hi Carbon team,
>>>
>>> Please merge the pull request [1] which contains critical fixes to
>>> support DSS multitenancy over passthru transport.
>>>
>>> [1]. https://github.com/wso2/carbon-kernel/pull/1349
>>>
>>> Thanks.
>>>
>>> --
>>> Vijitha Ekanayake
>>> Software Engineer*, *WSO2, Inc.; http://wso2.com/
>>> Mobile : +94 777 24 73 39 | +94 718 74 44 08
>>> lean.enterprise.middleware
>>>
>>
>>
>>
>> --
>> *Kishanthan Thangarajah*
>> Technical Lead,
>> Platform Technologies Team,
>> WSO2, Inc.
>> lean.enterprise.middleware
>>
>> Mobile - +94773426635 <+94%2077%20342%206635>
>> Blog - *http://kishanthan.wordpress.com
>> *
>> Twitter - *http://twitter.com/kishanthan *
>>
>
>
>
> --
> Vijitha Ekanayake
> Software Engineer*, *WSO2, Inc.; http://wso2.com/
> Mobile : +94 777 24 73 39 | +94 718 74 44 08
> lean.enterprise.middleware
>



-- 
Vinod Kavinda
Software Engineer
*WSO2 Inc. - lean . enterprise . middleware .*
Mobile : +94 (0) 712 415544
Blog : http://soatechflicks.blogspot.com/
[image: http://wso2.com/signature]

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Vijitha Ekanayake]

Hi Kishanthan,

I've updated the PR[1] with the issue[2] and a proper description. Could
you review and merge the pull request?


[1]. https://github.com/wso2/carbon-kernel/pull/1349
[2]. https://github.com/wso2/product-ei/issues/322


Thanks

On Thu, Apr 6, 2017 at 9:59 AM, Kishanthan Thangarajah 
wrote:

> Can you also create a github issue with the proper description for this
> and link it with the PR?
>
> On Wed, Apr 5, 2017 at 9:44 PM, Vijitha Ekanayake 
> wrote:
>
>> Hi Carbon team,
>>
>> Please merge the pull request [1] which contains critical fixes to
>> support DSS multitenancy over passthru transport.
>>
>> [1]. https://github.com/wso2/carbon-kernel/pull/1349
>>
>> Thanks.
>>
>> --
>> Vijitha Ekanayake
>> Software Engineer*, *WSO2, Inc.; http://wso2.com/
>> Mobile : +94 777 24 73 39 | +94 718 74 44 08
>> lean.enterprise.middleware
>>
>
>
>
> --
> *Kishanthan Thangarajah*
> Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635 <+94%2077%20342%206635>
> Blog - *http://kishanthan.wordpress.com *
> Twitter - *http://twitter.com/kishanthan *
>



-- 
Vijitha Ekanayake
Software Engineer*, *WSO2, Inc.; http://wso2.com/
Mobile : +94 777 24 73 39 | +94 718 74 44 08
lean.enterprise.middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull request

[Kishanthan Thangarajah]

Can you also create a github issue with the proper description for this and
link it with the PR?

On Wed, Apr 5, 2017 at 9:44 PM, Vijitha Ekanayake  wrote:

> Hi Carbon team,
>
> Please merge the pull request [1] which contains critical fixes to
> support DSS multitenancy over passthru transport.
>
> [1]. https://github.com/wso2/carbon-kernel/pull/1349
>
> Thanks.
>
> --
> Vijitha Ekanayake
> Software Engineer*, *WSO2, Inc.; http://wso2.com/
> Mobile : +94 777 24 73 39 | +94 718 74 44 08
> lean.enterprise.middleware
>



-- 
*Kishanthan Thangarajah*
Technical Lead,
Platform Technologies Team,
WSO2, Inc.
lean.enterprise.middleware

Mobile - +94773426635
Blog - *http://kishanthan.wordpress.com *
Twitter - *http://twitter.com/kishanthan *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Hi all,
Above PR has been closed since it ha2 two branches merged and make so many
confusions and also make it very hard to maintain the code. So all the
comments from the above PR will be resolved and cleaned in
https://github.com/wso2/msf4j/pull/365

Please review and comment.

Thanks and best regards,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne  wrote:

> Hi all,
> Please review the new changes did and comment.
>
> https://github.com/wso2/msf4j/pull/364
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne 
> wrote:
>
>> Hi all,
>> Created new pull request with necessary changes[1].
>>
>> please review and merge.
>>
>> [1]https://github.com/wso2/carbon-messaging/pull/41
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Hi Senduran,
>>> Yes. We can use a general control message type instead of ping and pong
>>> messages. So I removed ping and pong carbon message types from
>>> Carbon-Messaging and added new message type ".
>>>
>>> Please review and merge.
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam <
>>> sendu...@wso2.com> wrote:
>>>
 Hi Irunika,

 The above PR has PingCarbonMessage and PongCarbonMessage. It will be
 better if you could rename those two classes to generalized name.

 Regards
 Senduran

 On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah <
 kishant...@wso2.com> wrote:

> Looks ok.
>
> Senduran/Shafreen, can we merge this PR?
>
> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne 
> wrote:
>
>> Hi,
>> Fixed the issues mentioned.
>> Please review and merge.
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne > > wrote:
>>
>>> Noted.
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
>>> kishant...@wso2.com> wrote:
>>>
 PR has some formatting issue to be fixed. Can you look into it?

 On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne <
 irun...@wso2.com> wrote:

> Hi all,
> Can you please review and merge the PR?
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <
> irun...@wso2.com> wrote:
>
>> Hi all,
>> I modified the Carbon-Messaging according to the requirements.
>> Please review and merge.
>> 

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Hi all,
Above PR has been closed since it ha2 two branches merged and make so many
confusions and also make it very hard to maintain the code. So all the
comments from the above PR will be resolved and cleaned in
https://github.com/wso2/msf4j/pull/365

Please review and comment.

Thanks and best regards,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Thu, Mar 9, 2017 at 10:36 AM, Irunika Weeraratne 
wrote:

> Thanks Vidura. Will check.
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Thu, Mar 9, 2017 at 10:34 AM, Vidura Nanayakkara 
> wrote:
>
>> Hi Irunika,
>>
>> Added some comments in [1] .
>> Please do check.
>>
>> [1] MSF4J Web Socket Pull Request
>> 
>>
>> Thank you,
>> Vidura Nanayakkara
>>
>> On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Hi all,
>>> Please review the new changes did and comment.
>>>
>>> https://github.com/wso2/msf4j/pull/364
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne 
>>> wrote:
>>>
 Hi all,
 Created new pull request with necessary changes[1].

 please review and merge.

 [1]https://github.com/wso2/carbon-messaging/pull/41

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne 
 wrote:

> Hi Senduran,
> Yes. We can use a general control message type instead of ping and
> pong messages. So I removed ping and pong carbon message types from
> Carbon-Messaging and added new message type ".
>
> Please review and merge.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam <
> sendu...@wso2.com> wrote:
>
>> Hi Irunika,
>>
>> The above PR has PingCarbonMessage and PongCarbonMessage. It will be
>> better if you could rename those two classes to generalized name.
>>
>> Regards
>> Senduran
>>
>> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>> Looks ok.
>>>
>>> Senduran/Shafreen, can we merge this PR?
>>>
>>> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne <
>>> irun...@wso2.com> wrote:
>>>
 Hi,
 Fixed the issues mentioned.
 Please review and merge.

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne <
 irun...@wso2.com> wrote:

> Noted.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Thanks Vidura. Will check.

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Thu, Mar 9, 2017 at 10:34 AM, Vidura Nanayakkara 
wrote:

> Hi Irunika,
>
> Added some comments in [1] .
> Please do check.
>
> [1] MSF4J Web Socket Pull Request 
>
> Thank you,
> Vidura Nanayakkara
>
> On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne 
> wrote:
>
>> Hi all,
>> Please review the new changes did and comment.
>>
>> https://github.com/wso2/msf4j/pull/364
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Hi all,
>>> Created new pull request with necessary changes[1].
>>>
>>> please review and merge.
>>>
>>> [1]https://github.com/wso2/carbon-messaging/pull/41
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne 
>>> wrote:
>>>
 Hi Senduran,
 Yes. We can use a general control message type instead of ping and pong
 messages. So I removed ping and pong carbon message types from
 Carbon-Messaging and added new message type ".

 Please review and merge.

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam <
 sendu...@wso2.com> wrote:

> Hi Irunika,
>
> The above PR has PingCarbonMessage and PongCarbonMessage. It will be
> better if you could rename those two classes to generalized name.
>
> Regards
> Senduran
>
> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> Looks ok.
>>
>> Senduran/Shafreen, can we merge this PR?
>>
>> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne > > wrote:
>>
>>> Hi,
>>> Fixed the issues mentioned.
>>> Please review and merge.
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne <
>>> irun...@wso2.com> wrote:
>>>
 Noted.

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
 kishant...@wso2.com> wrote:

> PR has some formatting issue to be fixed. Can you look into it?
>
> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne <
> irun...@wso2.com> wrote:
>
>> Hi all,
>> Can you please review and merge the PR?
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <
>> irun...@wso2.com> wrote:
>>
>>> Hi 

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Vidura Nanayakkara]

Hi Irunika,

Added some comments in [1] . Please
do check.

[1] MSF4J Web Socket Pull Request 

Thank you,
Vidura Nanayakkara

On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne  wrote:

> Hi all,
> Please review the new changes did and comment.
>
> https://github.com/wso2/msf4j/pull/364
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne 
> wrote:
>
>> Hi all,
>> Created new pull request with necessary changes[1].
>>
>> please review and merge.
>>
>> [1]https://github.com/wso2/carbon-messaging/pull/41
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Hi Senduran,
>>> Yes. We can use a general control message type instead of ping and pong
>>> messages. So I removed ping and pong carbon message types from
>>> Carbon-Messaging and added new message type ".
>>>
>>> Please review and merge.
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam <
>>> sendu...@wso2.com> wrote:
>>>
 Hi Irunika,

 The above PR has PingCarbonMessage and PongCarbonMessage. It will be
 better if you could rename those two classes to generalized name.

 Regards
 Senduran

 On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah <
 kishant...@wso2.com> wrote:

> Looks ok.
>
> Senduran/Shafreen, can we merge this PR?
>
> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne 
> wrote:
>
>> Hi,
>> Fixed the issues mentioned.
>> Please review and merge.
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne > > wrote:
>>
>>> Noted.
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
>>> kishant...@wso2.com> wrote:
>>>
 PR has some formatting issue to be fixed. Can you look into it?

 On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne <
 irun...@wso2.com> wrote:

> Hi all,
> Can you please review and merge the PR?
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <
> irun...@wso2.com> wrote:
>
>> Hi all,
>> I modified the Carbon-Messaging according to the requirements.
>> Please review and merge.
>> https://github.com/wso2/carbon-messaging/pull/40
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Hi all,
Please review the new changes did and comment.

https://github.com/wso2/msf4j/pull/364

Thanks,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne  wrote:

> Hi all,
> Created new pull request with necessary changes[1].
>
> please review and merge.
>
> [1]https://github.com/wso2/carbon-messaging/pull/41
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne 
> wrote:
>
>> Hi Senduran,
>> Yes. We can use a general control message type instead of ping and pong
>> messages. So I removed ping and pong carbon message types from
>> Carbon-Messaging and added new message type ".
>>
>> Please review and merge.
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam <
>> sendu...@wso2.com> wrote:
>>
>>> Hi Irunika,
>>>
>>> The above PR has PingCarbonMessage and PongCarbonMessage. It will be
>>> better if you could rename those two classes to generalized name.
>>>
>>> Regards
>>> Senduran
>>>
>>> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah <
>>> kishant...@wso2.com> wrote:
>>>
 Looks ok.

 Senduran/Shafreen, can we merge this PR?

 On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne 
 wrote:

> Hi,
> Fixed the issues mentioned.
> Please review and merge.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne 
> wrote:
>
>> Noted.
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>> PR has some formatting issue to be fixed. Can you look into it?
>>>
>>> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne <
>>> irun...@wso2.com> wrote:
>>>
 Hi all,
 Can you please review and merge the PR?

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <
 irun...@wso2.com> wrote:

> Hi all,
> I modified the Carbon-Messaging according to the requirements.
> Please review and merge.
> https://github.com/wso2/carbon-messaging/pull/40
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne <
> irun...@wso2.com> wrote:
>
>> Hi all,
>> I did necessary changes after the review.
>> Please review and merge
>> https://github.com/wso2/carbon-messaging/pull/40
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | 

Re: [Dev] Please review and merge the PR

[Ashen Weerathunga]

On Tue, Feb 21, 2017 at 6:03 PM, Ashen Weerathunga  wrote:

> Hi,
>
> Can you please review and merge the PR [1]. This is regarding the kernel
> update requested in this mail thread [2].
>
> [1] https://github.com/wso2/carbon-messaging/pull/57
> [2] [IS-6.0] Updating carbon-kernel version to 5.2.0-m3
>
> Thanks,
> Ashen
>
> --
> *Ashen Weerathunga*
> Software Engineer
> WSO2 Inc.: http://wso2.com
> lean.enterprise.middleware
>
> Email: as...@wso2.com
> Mobile: +94716042995 <94716042995>
> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
> *
> 
>



-- 
*Ashen Weerathunga*
Software Engineer
WSO2 Inc.: http://wso2.com
lean.enterprise.middleware

Email: as...@wso2.com
Mobile: +94716042995 <94716042995>
LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
*

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Sagara Gunathunga]

Can you please review and apply this PR in order to proceed with other
Carbon repos ?

Thanks !

On Wed, Feb 15, 2017 at 11:58 AM, Ashen Weerathunga  wrote:

> Hi all,
>
> Can you please review and merge the PR [1]. This is regarding the kernel
> update requested in this mail thread [2].
>
> [1] https://github.com/wso2/carbon-jndi/pull/33
> [2] [IS-6.0] Updating carbon-kernel version to 5.2.0-m3
>
> Thanks,
> Ashen
> --
> *Ashen Weerathunga*
> Software Engineer
> WSO2 Inc.: http://wso2.com
> lean.enterprise.middleware
>
> Email: as...@wso2.com
> Mobile: +94716042995 <94716042995>
> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga
> *
> 
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Sagara Gunathunga

Associate Director / Architect; WSO2, Inc.;  http://wso2.com
V.P Apache Web Services;http://ws.apache.org/
Linkedin; http://www.linkedin.com/in/ssagara
Blog ;  http://ssagara.blogspot.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Hi all,
Created new pull request with necessary changes[1].

please review and merge.

[1]https://github.com/wso2/carbon-messaging/pull/41

Thanks,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne 
wrote:

> Hi Senduran,
> Yes. We can use a general control message type instead of ping and pong
> messages. So I removed ping and pong carbon message types from
> Carbon-Messaging and added new message type ".
>
> Please review and merge.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam <
> sendu...@wso2.com> wrote:
>
>> Hi Irunika,
>>
>> The above PR has PingCarbonMessage and PongCarbonMessage. It will be
>> better if you could rename those two classes to generalized name.
>>
>> Regards
>> Senduran
>>
>> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>> Looks ok.
>>>
>>> Senduran/Shafreen, can we merge this PR?
>>>
>>> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne 
>>> wrote:
>>>
 Hi,
 Fixed the issues mentioned.
 Please review and merge.

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne 
 wrote:

> Noted.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> PR has some formatting issue to be fixed. Can you look into it?
>>
>> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne <
>> irun...@wso2.com> wrote:
>>
>>> Hi all,
>>> Can you please review and merge the PR?
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <
>>> irun...@wso2.com> wrote:
>>>
 Hi all,
 I modified the Carbon-Messaging according to the requirements.
 Please review and merge.
 https://github.com/wso2/carbon-messaging/pull/40

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne <
 irun...@wso2.com> wrote:

> Hi all,
> I did necessary changes after the review.
> Please review and merge
> https://github.com/wso2/carbon-messaging/pull/40
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne <
> irun...@wso2.com> wrote:
>
>> Noted.
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com 

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Hi Senduran,
Yes. We can use a general control message type instead of ping and pong
messages. So I removed ping and pong carbon message types from
Carbon-Messaging and added new message type ".

Please review and merge.

Thanks,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam <
sendu...@wso2.com> wrote:

> Hi Irunika,
>
> The above PR has PingCarbonMessage and PongCarbonMessage. It will be
> better if you could rename those two classes to generalized name.
>
> Regards
> Senduran
>
> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> Looks ok.
>>
>> Senduran/Shafreen, can we merge this PR?
>>
>> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Hi,
>>> Fixed the issues mentioned.
>>> Please review and merge.
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne 
>>> wrote:
>>>
 Noted.

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
 kishant...@wso2.com> wrote:

> PR has some formatting issue to be fixed. Can you look into it?
>
> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne  > wrote:
>
>> Hi all,
>> Can you please review and merge the PR?
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne > > wrote:
>>
>>> Hi all,
>>> I modified the Carbon-Messaging according to the requirements.
>>> Please review and merge.
>>> https://github.com/wso2/carbon-messaging/pull/40
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne <
>>> irun...@wso2.com> wrote:
>>>
 Hi all,
 I did necessary changes after the review.
 Please review and merge
 https://github.com/wso2/carbon-messaging/pull/40

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne <
 irun...@wso2.com> wrote:

> Noted.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> Adding @dev
>>
>> @Irunika, always copy the relevant mailing list.
>>
>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne <
>> irun...@wso2.com> wrote:
>>
>>> Hi,
>>> Please review and merge
>>> https://github.com/wso2/carbon-messaging/pull/39

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Senduran Balasubramaniyam]

Hi Irunika,

The above PR has PingCarbonMessage and PongCarbonMessage. It will be better
if you could rename those two classes to generalized name.

Regards
Senduran

On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah  wrote:

> Looks ok.
>
> Senduran/Shafreen, can we merge this PR?
>
> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne 
> wrote:
>
>> Hi,
>> Fixed the issues mentioned.
>> Please review and merge.
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Noted.
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
>>> kishant...@wso2.com> wrote:
>>>
 PR has some formatting issue to be fixed. Can you look into it?

 On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne 
 wrote:

> Hi all,
> Can you please review and merge the PR?
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne 
> wrote:
>
>> Hi all,
>> I modified the Carbon-Messaging according to the requirements.
>> Please review and merge.
>> https://github.com/wso2/carbon-messaging/pull/40
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne > > wrote:
>>
>>> Hi all,
>>> I did necessary changes after the review.
>>> Please review and merge
>>> https://github.com/wso2/carbon-messaging/pull/40
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne <
>>> irun...@wso2.com> wrote:
>>>
 Noted.

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <
 kishant...@wso2.com> wrote:

> Adding @dev
>
> @Irunika, always copy the relevant mailing list.
>
> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne <
> irun...@wso2.com> wrote:
>
>> Hi,
>> Please review and merge
>> https://github.com/wso2/carbon-messaging/pull/39
>>
>> Thanks,
>> Irunika
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>
>
> --
> *Kishanthan Thangarajah*
> Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635 <+94%2077%20342%206635>
> Blog - *http://kishanthan.wordpress.com
> 

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Kishanthan Thangarajah]

Looks ok.

Senduran/Shafreen, can we merge this PR?

On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne 
wrote:

> Hi,
> Fixed the issues mentioned.
> Please review and merge.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne 
> wrote:
>
>> Noted.
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>> PR has some formatting issue to be fixed. Can you look into it?
>>>
>>> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne 
>>> wrote:
>>>
 Hi all,
 Can you please review and merge the PR?

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne 
 wrote:

> Hi all,
> I modified the Carbon-Messaging according to the requirements.
> Please review and merge.
> https://github.com/wso2/carbon-messaging/pull/40
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne 
> wrote:
>
>> Hi all,
>> I did necessary changes after the review.
>> Please review and merge
>> https://github.com/wso2/carbon-messaging/pull/40
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne > > wrote:
>>
>>> Noted.
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <
>>> kishant...@wso2.com> wrote:
>>>
 Adding @dev

 @Irunika, always copy the relevant mailing list.

 On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne <
 irun...@wso2.com> wrote:

> Hi,
> Please review and merge
> https://github.com/wso2/carbon-messaging/pull/39
>
> Thanks,
> Irunika
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>


 --
 *Kishanthan Thangarajah*
 Technical Lead,
 Platform Technologies Team,
 WSO2, Inc.
 lean.enterprise.middleware

 Mobile - +94773426635 <+94%2077%20342%206635>
 Blog - *http://kishanthan.wordpress.com
 *
 Twitter - *http://twitter.com/kishanthan
 *

>>>
>>>
>>
>

>>>
>>>
>>> --
>>> *Kishanthan Thangarajah*
>>> Technical Lead,
>>> Platform Technologies Team,
>>> WSO2, Inc.
>>> lean.enterprise.middleware
>>>
>>> Mobile - +94773426635 <+94%2077%20342%206635>
>>> Blog - *http://kishanthan.wordpress.com
>>> 

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Hi,
Fixed the issues mentioned.
Please review and merge.

Thanks,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne 
wrote:

> Noted.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> PR has some formatting issue to be fixed. Can you look into it?
>>
>> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Hi all,
>>> Can you please review and merge the PR?
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne 
>>> wrote:
>>>
 Hi all,
 I modified the Carbon-Messaging according to the requirements.
 Please review and merge.
 https://github.com/wso2/carbon-messaging/pull/40

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne 
 wrote:

> Hi all,
> I did necessary changes after the review.
> Please review and merge
> https://github.com/wso2/carbon-messaging/pull/40
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne 
> wrote:
>
>> Noted.
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>> Adding @dev
>>>
>>> @Irunika, always copy the relevant mailing list.
>>>
>>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne <
>>> irun...@wso2.com> wrote:
>>>
 Hi,
 Please review and merge
 https://github.com/wso2/carbon-messaging/pull/39

 Thanks,
 Irunika
 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


>>>
>>>
>>> --
>>> *Kishanthan Thangarajah*
>>> Technical Lead,
>>> Platform Technologies Team,
>>> WSO2, Inc.
>>> lean.enterprise.middleware
>>>
>>> Mobile - +94773426635 <+94%2077%20342%206635>
>>> Blog - *http://kishanthan.wordpress.com
>>> *
>>> Twitter - *http://twitter.com/kishanthan
>>> *
>>>
>>
>>
>

>>>
>>
>>
>> --
>> *Kishanthan Thangarajah*
>> Technical Lead,
>> Platform Technologies Team,
>> WSO2, Inc.
>> lean.enterprise.middleware
>>
>> Mobile - +94773426635 <+94%2077%20342%206635>
>> Blog - *http://kishanthan.wordpress.com
>> *
>> Twitter - *http://twitter.com/kishanthan *
>>
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Noted.

Thanks,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah  wrote:

> PR has some formatting issue to be fixed. Can you look into it?
>
> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne 
> wrote:
>
>> Hi all,
>> Can you please review and merge the PR?
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Hi all,
>>> I modified the Carbon-Messaging according to the requirements.
>>> Please review and merge.
>>> https://github.com/wso2/carbon-messaging/pull/40
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne 
>>> wrote:
>>>
 Hi all,
 I did necessary changes after the review.
 Please review and merge
 https://github.com/wso2/carbon-messaging/pull/40

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne 
 wrote:

> Noted.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> Adding @dev
>>
>> @Irunika, always copy the relevant mailing list.
>>
>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne > > wrote:
>>
>>> Hi,
>>> Please review and merge
>>> https://github.com/wso2/carbon-messaging/pull/39
>>>
>>> Thanks,
>>> Irunika
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>
>>
>> --
>> *Kishanthan Thangarajah*
>> Technical Lead,
>> Platform Technologies Team,
>> WSO2, Inc.
>> lean.enterprise.middleware
>>
>> Mobile - +94773426635 <+94%2077%20342%206635>
>> Blog - *http://kishanthan.wordpress.com
>> *
>> Twitter - *http://twitter.com/kishanthan
>> *
>>
>
>

>>>
>>
>
>
> --
> *Kishanthan Thangarajah*
> Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635 <+94%2077%20342%206635>
> Blog - *http://kishanthan.wordpress.com *
> Twitter - *http://twitter.com/kishanthan *
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Kishanthan Thangarajah]

PR has some formatting issue to be fixed. Can you look into it?

On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne 
wrote:

> Hi all,
> Can you please review and merge the PR?
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne 
> wrote:
>
>> Hi all,
>> I modified the Carbon-Messaging according to the requirements.
>> Please review and merge.
>> https://github.com/wso2/carbon-messaging/pull/40
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Hi all,
>>> I did necessary changes after the review.
>>> Please review and merge
>>> https://github.com/wso2/carbon-messaging/pull/40
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne 
>>> wrote:
>>>
 Noted.

 Thanks,
 Irunika

 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


 On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <
 kishant...@wso2.com> wrote:

> Adding @dev
>
> @Irunika, always copy the relevant mailing list.
>
> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne 
> wrote:
>
>> Hi,
>> Please review and merge
>> https://github.com/wso2/carbon-messaging/pull/39
>>
>> Thanks,
>> Irunika
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>
>
> --
> *Kishanthan Thangarajah*
> Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635 <+94%2077%20342%206635>
> Blog - *http://kishanthan.wordpress.com
> *
> Twitter - *http://twitter.com/kishanthan
> *
>


>>>
>>
>


-- 
*Kishanthan Thangarajah*
Technical Lead,
Platform Technologies Team,
WSO2, Inc.
lean.enterprise.middleware

Mobile - +94773426635
Blog - *http://kishanthan.wordpress.com *
Twitter - *http://twitter.com/kishanthan *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Hi all,
Can you please review and merge the PR?

Thanks,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne 
wrote:

> Hi all,
> I modified the Carbon-Messaging according to the requirements.
> Please review and merge.
> https://github.com/wso2/carbon-messaging/pull/40
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne 
> wrote:
>
>> Hi all,
>> I did necessary changes after the review.
>> Please review and merge
>> https://github.com/wso2/carbon-messaging/pull/40
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Noted.
>>>
>>> Thanks,
>>> Irunika
>>>
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <
>>> kishant...@wso2.com> wrote:
>>>
 Adding @dev

 @Irunika, always copy the relevant mailing list.

 On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne 
 wrote:

> Hi,
> Please review and merge
> https://github.com/wso2/carbon-messaging/pull/39
>
> Thanks,
> Irunika
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>


 --
 *Kishanthan Thangarajah*
 Technical Lead,
 Platform Technologies Team,
 WSO2, Inc.
 lean.enterprise.middleware

 Mobile - +94773426635 <+94%2077%20342%206635>
 Blog - *http://kishanthan.wordpress.com
 *
 Twitter - *http://twitter.com/kishanthan
 *

>>>
>>>
>>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Hi all,
I modified the Carbon-Messaging according to the requirements.
Please review and merge.
https://github.com/wso2/carbon-messaging/pull/40

Thanks,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne 
wrote:

> Hi all,
> I did necessary changes after the review.
> Please review and merge
> https://github.com/wso2/carbon-messaging/pull/40
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne 
> wrote:
>
>> Noted.
>>
>> Thanks,
>> Irunika
>>
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>> Adding @dev
>>>
>>> @Irunika, always copy the relevant mailing list.
>>>
>>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne 
>>> wrote:
>>>
 Hi,
 Please review and merge
 https://github.com/wso2/carbon-messaging/pull/39

 Thanks,
 Irunika
 *Irunika Weeraratne*
 *Software Engineer | WSO2, Inc. *
 *Email : irun...@wso2.com *
 *LinkedIn : https://lk.linkedin.com/in/irunika
 *
 *Mobile : +94712403314 <+94%2071%20240%203314>*
 *Lean . Enterprise . Middleware*


>>>
>>>
>>> --
>>> *Kishanthan Thangarajah*
>>> Technical Lead,
>>> Platform Technologies Team,
>>> WSO2, Inc.
>>> lean.enterprise.middleware
>>>
>>> Mobile - +94773426635 <+94%2077%20342%206635>
>>> Blog - *http://kishanthan.wordpress.com
>>> *
>>> Twitter - *http://twitter.com/kishanthan
>>> *
>>>
>>
>>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Maheshika Goonetilleke]

Hi Kishanthan

Yes we have already configured auto release for this job.

On Thu, Jan 19, 2017 at 11:44 PM, Kishanthan Thangarajah <
kishant...@wso2.com> wrote:

> Hi Maheshika,
>
> Have we enabled auto release for carbon-deployment 4.7.x branch [1]? If
> not, we have to enable it.
>
> [1] https://github.com/wso2/carbon-deployment/tree/4.7.x
>
> On Thu, Jan 19, 2017 at 6:39 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> This is merged.
>>
>> On Thu, Jan 19, 2017 at 6:07 PM, Malith Munasinghe 
>> wrote:
>>
>>> Fixed.
>>>
>>> On Thu, Jan 19, 2017 at 5:39 PM, Kishanthan Thangarajah <
>>> kishant...@wso2.com> wrote:
>>>
 There is a formatting issue in the PR, please fix it.

 On Thu, Jan 19, 2017 at 2:22 PM, Malith Munasinghe 
 wrote:

> Hi All,
>
> Please review and merge [1]. This is used to fix [2].
>
> [1] https://github.com/wso2/carbon-deployment/pull/247
> [2] https://github.com/wso2/carbon-deployment/issues/248
>
> Regards,
> Malith
>
> --
> Malith Munasinghe | Software Engineer
> M: +94 (71) 9401122 <+94%2071%20940%201122>
> E: mali...@wso2.com
> W: http://wso2.com
> 
>



 --
 *Kishanthan Thangarajah*
 Technical Lead,
 Platform Technologies Team,
 WSO2, Inc.
 lean.enterprise.middleware

 Mobile - +94773426635 <+94%2077%20342%206635>
 Blog - *http://kishanthan.wordpress.com
 *
 Twitter - *http://twitter.com/kishanthan
 *

>>>
>>>
>>>
>>> --
>>> Malith Munasinghe | Software Engineer
>>> M: +94 (71) 9401122 <+94%2071%20940%201122>
>>> E: mali...@wso2.com
>>> W: http://wso2.com
>>> 
>>>
>>
>>
>>
>> --
>> *Kishanthan Thangarajah*
>> Technical Lead,
>> Platform Technologies Team,
>> WSO2, Inc.
>> lean.enterprise.middleware
>>
>> Mobile - +94773426635 <+94%2077%20342%206635>
>> Blog - *http://kishanthan.wordpress.com
>> *
>> Twitter - *http://twitter.com/kishanthan *
>>
>
>
>
> --
> *Kishanthan Thangarajah*
> Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635 <+94%2077%20342%206635>
> Blog - *http://kishanthan.wordpress.com *
> Twitter - *http://twitter.com/kishanthan *
>



-- 

Thanks & Best Regards,

Maheshika Goonetilleke
Senior Engineering Process Coordinator

*WSO2 Inc*
*email   : mahesh...@wso2.com *
*mobile : +94 773 596707*
*www: :http://wso2.com *lean . enterprise . middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Kishanthan Thangarajah]

Hi Maheshika,

Have we enabled auto release for carbon-deployment 4.7.x branch [1]? If
not, we have to enable it.

[1] https://github.com/wso2/carbon-deployment/tree/4.7.x

On Thu, Jan 19, 2017 at 6:39 PM, Kishanthan Thangarajah  wrote:

> This is merged.
>
> On Thu, Jan 19, 2017 at 6:07 PM, Malith Munasinghe 
> wrote:
>
>> Fixed.
>>
>> On Thu, Jan 19, 2017 at 5:39 PM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>> There is a formatting issue in the PR, please fix it.
>>>
>>> On Thu, Jan 19, 2017 at 2:22 PM, Malith Munasinghe 
>>> wrote:
>>>
 Hi All,

 Please review and merge [1]. This is used to fix [2].

 [1] https://github.com/wso2/carbon-deployment/pull/247
 [2] https://github.com/wso2/carbon-deployment/issues/248

 Regards,
 Malith

 --
 Malith Munasinghe | Software Engineer
 M: +94 (71) 9401122 <+94%2071%20940%201122>
 E: mali...@wso2.com
 W: http://wso2.com
 

>>>
>>>
>>>
>>> --
>>> *Kishanthan Thangarajah*
>>> Technical Lead,
>>> Platform Technologies Team,
>>> WSO2, Inc.
>>> lean.enterprise.middleware
>>>
>>> Mobile - +94773426635 <+94%2077%20342%206635>
>>> Blog - *http://kishanthan.wordpress.com
>>> *
>>> Twitter - *http://twitter.com/kishanthan
>>> *
>>>
>>
>>
>>
>> --
>> Malith Munasinghe | Software Engineer
>> M: +94 (71) 9401122 <+94%2071%20940%201122>
>> E: mali...@wso2.com
>> W: http://wso2.com
>> 
>>
>
>
>
> --
> *Kishanthan Thangarajah*
> Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635 <+94%2077%20342%206635>
> Blog - *http://kishanthan.wordpress.com *
> Twitter - *http://twitter.com/kishanthan *
>



-- 
*Kishanthan Thangarajah*
Technical Lead,
Platform Technologies Team,
WSO2, Inc.
lean.enterprise.middleware

Mobile - +94773426635
Blog - *http://kishanthan.wordpress.com *
Twitter - *http://twitter.com/kishanthan *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Kishanthan Thangarajah]

This is merged.

On Thu, Jan 19, 2017 at 6:07 PM, Malith Munasinghe  wrote:

> Fixed.
>
> On Thu, Jan 19, 2017 at 5:39 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> There is a formatting issue in the PR, please fix it.
>>
>> On Thu, Jan 19, 2017 at 2:22 PM, Malith Munasinghe 
>> wrote:
>>
>>> Hi All,
>>>
>>> Please review and merge [1]. This is used to fix [2].
>>>
>>> [1] https://github.com/wso2/carbon-deployment/pull/247
>>> [2] https://github.com/wso2/carbon-deployment/issues/248
>>>
>>> Regards,
>>> Malith
>>>
>>> --
>>> Malith Munasinghe | Software Engineer
>>> M: +94 (71) 9401122 <+94%2071%20940%201122>
>>> E: mali...@wso2.com
>>> W: http://wso2.com
>>> 
>>>
>>
>>
>>
>> --
>> *Kishanthan Thangarajah*
>> Technical Lead,
>> Platform Technologies Team,
>> WSO2, Inc.
>> lean.enterprise.middleware
>>
>> Mobile - +94773426635 <+94%2077%20342%206635>
>> Blog - *http://kishanthan.wordpress.com
>> *
>> Twitter - *http://twitter.com/kishanthan *
>>
>
>
>
> --
> Malith Munasinghe | Software Engineer
> M: +94 (71) 9401122 <+94%2071%20940%201122>
> E: mali...@wso2.com
> W: http://wso2.com
> 
>



-- 
*Kishanthan Thangarajah*
Technical Lead,
Platform Technologies Team,
WSO2, Inc.
lean.enterprise.middleware

Mobile - +94773426635
Blog - *http://kishanthan.wordpress.com *
Twitter - *http://twitter.com/kishanthan *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Malith Munasinghe]

Fixed.

On Thu, Jan 19, 2017 at 5:39 PM, Kishanthan Thangarajah  wrote:

> There is a formatting issue in the PR, please fix it.
>
> On Thu, Jan 19, 2017 at 2:22 PM, Malith Munasinghe 
> wrote:
>
>> Hi All,
>>
>> Please review and merge [1]. This is used to fix [2].
>>
>> [1] https://github.com/wso2/carbon-deployment/pull/247
>> [2] https://github.com/wso2/carbon-deployment/issues/248
>>
>> Regards,
>> Malith
>>
>> --
>> Malith Munasinghe | Software Engineer
>> M: +94 (71) 9401122 <+94%2071%20940%201122>
>> E: mali...@wso2.com
>> W: http://wso2.com
>> 
>>
>
>
>
> --
> *Kishanthan Thangarajah*
> Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635 <+94%2077%20342%206635>
> Blog - *http://kishanthan.wordpress.com *
> Twitter - *http://twitter.com/kishanthan *
>



-- 
Malith Munasinghe | Software Engineer
M: +94 (71) 9401122
E: mali...@wso2.com
W: http://wso2.com

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Kishanthan Thangarajah]

There is a formatting issue in the PR, please fix it.

On Thu, Jan 19, 2017 at 2:22 PM, Malith Munasinghe  wrote:

> Hi All,
>
> Please review and merge [1]. This is used to fix [2].
>
> [1] https://github.com/wso2/carbon-deployment/pull/247
> [2] https://github.com/wso2/carbon-deployment/issues/248
>
> Regards,
> Malith
>
> --
> Malith Munasinghe | Software Engineer
> M: +94 (71) 9401122 <+94%2071%20940%201122>
> E: mali...@wso2.com
> W: http://wso2.com
> 
>



-- 
*Kishanthan Thangarajah*
Technical Lead,
Platform Technologies Team,
WSO2, Inc.
lean.enterprise.middleware

Mobile - +94773426635 <+94%2077%20342%206635>
Blog - *http://kishanthan.wordpress.com *
Twitter - *http://twitter.com/kishanthan *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Hi all,
I did necessary changes after the review.
Please review and merge
https://github.com/wso2/carbon-messaging/pull/40

Thanks,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne 
wrote:

> Noted.
>
> Thanks,
> Irunika
>
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>
> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> Adding @dev
>>
>> @Irunika, always copy the relevant mailing list.
>>
>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne 
>> wrote:
>>
>>> Hi,
>>> Please review and merge
>>> https://github.com/wso2/carbon-messaging/pull/39
>>>
>>> Thanks,
>>> Irunika
>>> *Irunika Weeraratne*
>>> *Software Engineer | WSO2, Inc. *
>>> *Email : irun...@wso2.com *
>>> *LinkedIn : https://lk.linkedin.com/in/irunika
>>> *
>>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>>> *Lean . Enterprise . Middleware*
>>>
>>>
>>
>>
>> --
>> *Kishanthan Thangarajah*
>> Technical Lead,
>> Platform Technologies Team,
>> WSO2, Inc.
>> lean.enterprise.middleware
>>
>> Mobile - +94773426635 <+94%2077%20342%206635>
>> Blog - *http://kishanthan.wordpress.com
>> *
>> Twitter - *http://twitter.com/kishanthan *
>>
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Irunika Weeraratne]

Noted.

Thanks,
Irunika

*Irunika Weeraratne*
*Software Engineer | WSO2, Inc. *
*Email : irun...@wso2.com *
*LinkedIn : https://lk.linkedin.com/in/irunika
*
*Mobile : +94712403314*
*Lean . Enterprise . Middleware*


On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah  wrote:

> Adding @dev
>
> @Irunika, always copy the relevant mailing list.
>
> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne 
> wrote:
>
>> Hi,
>> Please review and merge
>> https://github.com/wso2/carbon-messaging/pull/39
>>
>> Thanks,
>> Irunika
>> *Irunika Weeraratne*
>> *Software Engineer | WSO2, Inc. *
>> *Email : irun...@wso2.com *
>> *LinkedIn : https://lk.linkedin.com/in/irunika
>> *
>> *Mobile : +94712403314 <+94%2071%20240%203314>*
>> *Lean . Enterprise . Middleware*
>>
>>
>
>
> --
> *Kishanthan Thangarajah*
> Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635 <+94%2077%20342%206635>
> Blog - *http://kishanthan.wordpress.com *
> Twitter - *http://twitter.com/kishanthan *
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)

[Kishanthan Thangarajah]

Adding @dev

@Irunika, always copy the relevant mailing list.

On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne 
wrote:

> Hi,
> Please review and merge
> https://github.com/wso2/carbon-messaging/pull/39
>
> Thanks,
> Irunika
> *Irunika Weeraratne*
> *Software Engineer | WSO2, Inc. *
> *Email : irun...@wso2.com *
> *LinkedIn : https://lk.linkedin.com/in/irunika
> *
> *Mobile : +94712403314 <+94%2071%20240%203314>*
> *Lean . Enterprise . Middleware*
>
>


-- 
*Kishanthan Thangarajah*
Technical Lead,
Platform Technologies Team,
WSO2, Inc.
lean.enterprise.middleware

Mobile - +94773426635
Blog - *http://kishanthan.wordpress.com *
Twitter - *http://twitter.com/kishanthan *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Isura Karunaratne]

Thanks thusitha.


*Isura Dilhara Karunaratne*
Senior Software Engineer | WSO2
Email: is...@wso2.com
Mob : +94 772 254 810
Blog : http://isurad.blogspot.com/




On Thu, Jul 14, 2016 at 6:34 PM, Thusitha Thilina Dayaratne <
thusit...@wso2.com> wrote:

> Hi Isura,
>
> PR merged with
> https://github.com/wso2/carbon-kernel/commit/977df0deec9078bb2262d65d32c3a9aa6ba93cb5
>
> Thanks
> Thusitha
>
> On Thu, Jul 14, 2016 at 3:12 PM, Isura Karunaratne  wrote:
>
>> Hi Thusitha,
>>
>> Please review and merge following PR [1]
>>
>> I will improve RemoteUserStoreManager test case to validate this [2]
>>
>>
>>
>> [1] https://github.com/wso2/carbon-kernel/pull/1082
>> [2]
>> https://github.com/wso2/product-is/blob/master/modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/user/mgt/remote/RemoteUserStoreManagerServiceTestCase.java
>>
>>
>> Thanks
>>
>> *Isura Dilhara Karunaratne*
>> Senior Software Engineer | WSO2
>> Email: is...@wso2.com
>> Mob : +94 772 254 810
>> Blog : http://isurad.blogspot.com/
>>
>> 
>>
>>
>
>
> --
> Thusitha Dayaratne
> Software Engineer
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> Mobile  +94712756809
> Blog  alokayasoya.blogspot.com
> Abouthttp://about.me/thusithathilina
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Thusitha Thilina Dayaratne]

Hi Isura,

PR merged with
https://github.com/wso2/carbon-kernel/commit/977df0deec9078bb2262d65d32c3a9aa6ba93cb5

Thanks
Thusitha

On Thu, Jul 14, 2016 at 3:12 PM, Isura Karunaratne  wrote:

> Hi Thusitha,
>
> Please review and merge following PR [1]
>
> I will improve RemoteUserStoreManager test case to validate this [2]
>
>
>
> [1] https://github.com/wso2/carbon-kernel/pull/1082
> [2]
> https://github.com/wso2/product-is/blob/master/modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/user/mgt/remote/RemoteUserStoreManagerServiceTestCase.java
>
>
> Thanks
>
> *Isura Dilhara Karunaratne*
> Senior Software Engineer | WSO2
> Email: is...@wso2.com
> Mob : +94 772 254 810
> Blog : http://isurad.blogspot.com/
>
> 
>
>


-- 
Thusitha Dayaratne
Software Engineer
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809
Blog  alokayasoya.blogspot.com
Abouthttp://about.me/thusithathilina
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the following Carbon-Transports pull requests

[Samiyuru Senarathne]

Thank you

On Fri, Mar 4, 2016 at 1:41 PM, Isuru Ranawaka  wrote:

>
>
> On Fri, Mar 4, 2016 at 11:57 AM, Samiyuru Senarathne 
> wrote:
>
>> https://github.com/wso2/carbon-transports/pull/38
>> https://github.com/wso2/carbon-transports/pull/39
>>
>
>
> Merged
>
>
>
>>
>> Best Regards,
>> Samiyuru
>>
>> --
>> Samiyuru Senarathne
>> *Software Engineer*
>> Mobile : +94 (0) 71 134 6087
>> samiy...@wso2.com
>>
>
>
>
> --
> Best Regards
> Isuru Ranawaka
> M: +94714629880
> Blog : http://isurur.blogspot.com/
>



-- 
Samiyuru Senarathne
*Software Engineer*
Mobile : +94 (0) 71 134 6087
samiy...@wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the following Carbon-Transports pull requests

[Isuru Ranawaka]

On Fri, Mar 4, 2016 at 11:57 AM, Samiyuru Senarathne 
wrote:

> https://github.com/wso2/carbon-transports/pull/38
> https://github.com/wso2/carbon-transports/pull/39
>


Merged



>
> Best Regards,
> Samiyuru
>
> --
> Samiyuru Senarathne
> *Software Engineer*
> Mobile : +94 (0) 71 134 6087
> samiy...@wso2.com
>



-- 
Best Regards
Isuru Ranawaka
M: +94714629880
Blog : http://isurur.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the PR

[Sinthuja Ragendran]

Hi Lalanke,


On Fri, Feb 26, 2016 at 7:56 PM, Lalanke Athauda  wrote:

> Hi,
> Please review and merge the PR [1].
> [1] https://github.com/wso2/jaggery/pull/149
>

Done.

Thanks,
Sinthuja.

>
>
> --
> Lalanke Athauda
> Software Engineer
> WSO2 Inc.
> Mobile: 0772264301
>



-- 
*Sinthuja Rajendran*
Associate Technical Lead
WSO2, Inc.:http://wso2.com

Blog: http://sinthu-rajan.blogspot.com/
Mobile: +94774273955
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Nuwan Dias]

Thanks Godwin

On Wednesday, 2 December 2015, Godwin Shrimal  wrote:

> Merged PR
> https://github.com/wso2/carbon-identity/commit/55fff392dc59b0724645d7f5fbfcc55a2176a710
>
> On Mon, Nov 30, 2015 at 11:25 AM, Nuwan Dias  > wrote:
>
>> Hi Godwin,
>>
>> Can we get this merged please? APIM has a blocking issue depending on
>> this fix.
>>
>> Thanks,
>> NuwanD.
>>
>> On Fri, Nov 27, 2015 at 12:36 PM, Malintha Amarasinghe <
>> malint...@wso2.com >
>> wrote:
>>
>>> Hi Godwin,
>>>
>>> Added the fixes with [1]
>>>
>>> Thanks.
>>> Malintha
>>>
>>> [1]
>>> https://github.com/malinthaprasan/carbon-identity/commit/b06e2039f4c86ee80c97186e36327b635feece31
>>>
>>> On Fri, Nov 27, 2015 at 10:32 AM, Godwin Shrimal >> > wrote:
>>>
 Hi Malintha,

 Please check the comments in the PR.


 Thanks
 Godwin



 On Thu, Nov 26, 2015 at 3:15 PM, Malintha Amarasinghe <
 malint...@wso2.com 
 > wrote:

> Hi IS Team,
>
> Can you please merge the following PR [1]. This contains a new NTLM
> grant handler which fixes the following JiRA [2].
>
> [1] https://github.com/wso2/carbon-identity/pull/1485
> [2] https://wso2.org/jira/browse/APIMANAGER-4095
>
> Thanks,
> Malintha
> --
> Malintha Amarasinghe
> Software Engineer
> *WSO2, Inc. - lean | enterprise | middleware*
> http://wso2.com/
>
> Mobile : +94 712383306
>
> ___
> Dev mailing list
> Dev@wso2.org 
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


 --
 *Godwin Amila Shrimal*
 Senior Software Engineer
 WSO2 Inc.; http://wso2.com
 lean.enterprise.middleware

 mobile: *+94772264165*
 linkedin: *http://lnkd.in/KUum6D *
 twitter: https://twitter.com/godwinamila

>>>
>>>
>>>
>>> --
>>> Malintha Amarasinghe
>>> Software Engineer
>>> *WSO2, Inc. - lean | enterprise | middleware*
>>> http://wso2.com/
>>>
>>> Mobile : +94 712383306
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org 
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> Nuwan Dias
>>
>> Technical Lead - WSO2, Inc. http://wso2.com
>> email : nuw...@wso2.com 
>> Phone : +94 777 775 729
>>
>
>
>
> --
> *Godwin Amila Shrimal*
> Senior Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: *+94772264165*
> linkedin: *http://lnkd.in/KUum6D *
> twitter: https://twitter.com/godwinamila
>


-- 
Nuwan Dias

Technical Lead - WSO2, Inc. http://wso2.com
email : nuw...@wso2.com
Phone : +94 777 775 729
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Godwin Shrimal]

Merged PR
https://github.com/wso2/carbon-identity/commit/55fff392dc59b0724645d7f5fbfcc55a2176a710

On Mon, Nov 30, 2015 at 11:25 AM, Nuwan Dias  wrote:

> Hi Godwin,
>
> Can we get this merged please? APIM has a blocking issue depending on this
> fix.
>
> Thanks,
> NuwanD.
>
> On Fri, Nov 27, 2015 at 12:36 PM, Malintha Amarasinghe  > wrote:
>
>> Hi Godwin,
>>
>> Added the fixes with [1]
>>
>> Thanks.
>> Malintha
>>
>> [1]
>> https://github.com/malinthaprasan/carbon-identity/commit/b06e2039f4c86ee80c97186e36327b635feece31
>>
>> On Fri, Nov 27, 2015 at 10:32 AM, Godwin Shrimal  wrote:
>>
>>> Hi Malintha,
>>>
>>> Please check the comments in the PR.
>>>
>>>
>>> Thanks
>>> Godwin
>>>
>>>
>>>
>>> On Thu, Nov 26, 2015 at 3:15 PM, Malintha Amarasinghe <
>>> malint...@wso2.com> wrote:
>>>
 Hi IS Team,

 Can you please merge the following PR [1]. This contains a new NTLM
 grant handler which fixes the following JiRA [2].

 [1] https://github.com/wso2/carbon-identity/pull/1485
 [2] https://wso2.org/jira/browse/APIMANAGER-4095

 Thanks,
 Malintha
 --
 Malintha Amarasinghe
 Software Engineer
 *WSO2, Inc. - lean | enterprise | middleware*
 http://wso2.com/

 Mobile : +94 712383306

 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev


>>>
>>>
>>> --
>>> *Godwin Amila Shrimal*
>>> Senior Software Engineer
>>> WSO2 Inc.; http://wso2.com
>>> lean.enterprise.middleware
>>>
>>> mobile: *+94772264165*
>>> linkedin: *http://lnkd.in/KUum6D *
>>> twitter: https://twitter.com/godwinamila
>>>
>>
>>
>>
>> --
>> Malintha Amarasinghe
>> Software Engineer
>> *WSO2, Inc. - lean | enterprise | middleware*
>> http://wso2.com/
>>
>> Mobile : +94 712383306
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Nuwan Dias
>
> Technical Lead - WSO2, Inc. http://wso2.com
> email : nuw...@wso2.com
> Phone : +94 777 775 729
>



-- 
*Godwin Amila Shrimal*
Senior Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: *+94772264165*
linkedin: *http://lnkd.in/KUum6D *
twitter: https://twitter.com/godwinamila
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Nuwan Dias]

Hi Godwin,

Can we get this merged please? APIM has a blocking issue depending on this
fix.

Thanks,
NuwanD.

On Fri, Nov 27, 2015 at 12:36 PM, Malintha Amarasinghe 
wrote:

> Hi Godwin,
>
> Added the fixes with [1]
>
> Thanks.
> Malintha
>
> [1]
> https://github.com/malinthaprasan/carbon-identity/commit/b06e2039f4c86ee80c97186e36327b635feece31
>
> On Fri, Nov 27, 2015 at 10:32 AM, Godwin Shrimal  wrote:
>
>> Hi Malintha,
>>
>> Please check the comments in the PR.
>>
>>
>> Thanks
>> Godwin
>>
>>
>>
>> On Thu, Nov 26, 2015 at 3:15 PM, Malintha Amarasinghe > > wrote:
>>
>>> Hi IS Team,
>>>
>>> Can you please merge the following PR [1]. This contains a new NTLM
>>> grant handler which fixes the following JiRA [2].
>>>
>>> [1] https://github.com/wso2/carbon-identity/pull/1485
>>> [2] https://wso2.org/jira/browse/APIMANAGER-4095
>>>
>>> Thanks,
>>> Malintha
>>> --
>>> Malintha Amarasinghe
>>> Software Engineer
>>> *WSO2, Inc. - lean | enterprise | middleware*
>>> http://wso2.com/
>>>
>>> Mobile : +94 712383306
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> *Godwin Amila Shrimal*
>> Senior Software Engineer
>> WSO2 Inc.; http://wso2.com
>> lean.enterprise.middleware
>>
>> mobile: *+94772264165*
>> linkedin: *http://lnkd.in/KUum6D *
>> twitter: https://twitter.com/godwinamila
>>
>
>
>
> --
> Malintha Amarasinghe
> Software Engineer
> *WSO2, Inc. - lean | enterprise | middleware*
> http://wso2.com/
>
> Mobile : +94 712383306
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Nuwan Dias

Technical Lead - WSO2, Inc. http://wso2.com
email : nuw...@wso2.com
Phone : +94 777 775 729
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Godwin Shrimal]

Hi Malintha,

Please check the comments in the PR.


Thanks
Godwin



On Thu, Nov 26, 2015 at 3:15 PM, Malintha Amarasinghe 
wrote:

> Hi IS Team,
>
> Can you please merge the following PR [1]. This contains a new NTLM grant
> handler which fixes the following JiRA [2].
>
> [1] https://github.com/wso2/carbon-identity/pull/1485
> [2] https://wso2.org/jira/browse/APIMANAGER-4095
>
> Thanks,
> Malintha
> --
> Malintha Amarasinghe
> Software Engineer
> *WSO2, Inc. - lean | enterprise | middleware*
> http://wso2.com/
>
> Mobile : +94 712383306
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Godwin Amila Shrimal*
Senior Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: *+94772264165*
linkedin: *http://lnkd.in/KUum6D *
twitter: https://twitter.com/godwinamila
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge PR

[Malintha Amarasinghe]

Hi Godwin,

Added the fixes with [1]

Thanks.
Malintha

[1]
https://github.com/malinthaprasan/carbon-identity/commit/b06e2039f4c86ee80c97186e36327b635feece31

On Fri, Nov 27, 2015 at 10:32 AM, Godwin Shrimal  wrote:

> Hi Malintha,
>
> Please check the comments in the PR.
>
>
> Thanks
> Godwin
>
>
>
> On Thu, Nov 26, 2015 at 3:15 PM, Malintha Amarasinghe 
> wrote:
>
>> Hi IS Team,
>>
>> Can you please merge the following PR [1]. This contains a new NTLM grant
>> handler which fixes the following JiRA [2].
>>
>> [1] https://github.com/wso2/carbon-identity/pull/1485
>> [2] https://wso2.org/jira/browse/APIMANAGER-4095
>>
>> Thanks,
>> Malintha
>> --
>> Malintha Amarasinghe
>> Software Engineer
>> *WSO2, Inc. - lean | enterprise | middleware*
>> http://wso2.com/
>>
>> Mobile : +94 712383306
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> *Godwin Amila Shrimal*
> Senior Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: *+94772264165*
> linkedin: *http://lnkd.in/KUum6D *
> twitter: https://twitter.com/godwinamila
>



-- 
Malintha Amarasinghe
Software Engineer
*WSO2, Inc. - lean | enterprise | middleware*
http://wso2.com/

Mobile : +94 712383306
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Sajith Abeywardhana]

The pack I used for the testing is one commit behind and due to that it
didn't render correctly. When we tested with the missing commit we got
Ayesha's mentioned issue and we fixed it.


*Sajith Abeywardhana* | Software Engineer
WSO2, Inc | lean. enterprise. middleware.
#20, Palm Grove, Colombo 03, Sri Lanka.
Mobile: +94772260485
Email: saji...@wso2.com | Web: www.wso2.com

On Wed, Oct 7, 2015 at 11:32 AM, Udara Rathnayake  wrote:

>
>
> On Wed, Oct 7, 2015 at 11:14 AM, Ayesha Dissanayaka 
> wrote:
>
>> Hi Sajith,
>>
>> I am referring to user not logged in sate. In that case if we directly
>> access
>> https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=false
>> URL then we will see the default view.
>>
>> And when there a logged in user viewing
>> https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=false
>> and logout then also default view is shown since the URL has
>> isAnonView=false
>>
>
> This is different from what Sajith mentioned to me. Sajith, Please
> coordinate with ayesha  and fix above (if exists)
>
> Thanks
>
>>
>> Thanks!
>> -Ayesha
>>
>>
>> On Wed, Oct 7, 2015 at 11:02 AM, Sajith Abeywardhana 
>> wrote:
>>
>>> If the user removes the isAnonView param from the url, next time browser
>>> will show url as 
>>> *https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=null
>>> .
>>> *Since null value is a bit ugly I fixed it and committed it to the PR.
>>>
>>> *Sajith Abeywardhana* | Software Engineer
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>> Mobile: +94772260485
>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>
>>> On Wed, Oct 7, 2015 at 10:50 AM, Udara Rathnayake 
>>> wrote:
>>>
 Had a chat with Sajith. Current implementation seems fine..

 On Wed, Oct 7, 2015 at 10:40 AM, Sajith Abeywardhana 
 wrote:

> Hi Ayesha,
>
> Small clarification?
>
>
>> I observed that even *anonymous users* can view the logged in view
>> by setting query parameter "isAnonView=false" or without setting it at 
>> all
>> in the browser.
>>
>
> I think you mean in here when the *logged in user* viewing anonymous
> view he can view logged in view by setting query parameter
> "isAnonView=false" or without setting it at all in the browser.
>
> Anonymous user(with out logging) never able to view logged in view. Am
> I right?
>
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>
>
>
>> Can you check this.
>>
>> Further, instead of having this reflected in the URL can we try keep
>> it internally?
>>
>> Thanks!
>> -Ayesha
>>
>>
>> On Tue, Oct 6, 2015 at 6:42 PM, Sajith Abeywardhana > > wrote:
>>
>>> Both jira's[1][2] which relevant  to anon view committed under one
>>> PR[3]. Please review and merge.
>>>
>>> [1]. https://wso2.org/jira/browse/UES-597
>>> [2]. https://wso2.org/jira/browse/UES-599
>>> [3]. https://github.com/wso2/carbon-dashboards/pull/66
>>>
>>> *Sajith Abeywardhana* | Software Engineer
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>> Mobile: +94772260485
>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>
>>> On Tue, Oct 6, 2015 at 2:16 PM, Sajith Abeywardhana <
>>> saji...@wso2.com> wrote:
>>>
 Fixed the code according to [Dev] [UES][Dashboard Server] Dashboard
 anonymous view landing page. Please merge the PR.

 *Sajith Abeywardhana* | Software Engineer
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka.
 Mobile: +94772260485
 Email: saji...@wso2.com | Web: www.wso2.com

 On Tue, Oct 6, 2015 at 10:59 AM, Sajith Abeywardhana <
 saji...@wso2.com> wrote:

> Please hold this merge. Page link rendering logic should be
> changed. We can't check *!user *after the jira -
> https://wso2.org/jira/browse/UES-597
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>
> On Tue, Oct 6, 2015 at 10:38 AM, Sajith Abeywardhana <
> saji...@wso2.com> wrote:
>
>> Please review and merge
>> https://github.com/wso2/carbon-dashboards/pull/66 for
>> https://wso2.org/jira/browse/UES-599
>>
>>
>> 

Re: [Dev] Please review and merge

[Udara Rathnayake]

On Wed, Oct 7, 2015 at 11:14 AM, Ayesha Dissanayaka  wrote:

> Hi Sajith,
>
> I am referring to user not logged in sate. In that case if we directly
> access
> https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=false
> URL then we will see the default view.
>
> And when there a logged in user viewing
> https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=false
> and logout then also default view is shown since the URL has
> isAnonView=false
>

This is different from what Sajith mentioned to me. Sajith, Please
coordinate with ayesha  and fix above (if exists)

Thanks

>
> Thanks!
> -Ayesha
>
>
> On Wed, Oct 7, 2015 at 11:02 AM, Sajith Abeywardhana 
> wrote:
>
>> If the user removes the isAnonView param from the url, next time browser
>> will show url as 
>> *https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=null
>> .
>> *Since null value is a bit ugly I fixed it and committed it to the PR.
>>
>> *Sajith Abeywardhana* | Software Engineer
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka.
>> Mobile: +94772260485
>> Email: saji...@wso2.com | Web: www.wso2.com
>>
>> On Wed, Oct 7, 2015 at 10:50 AM, Udara Rathnayake 
>> wrote:
>>
>>> Had a chat with Sajith. Current implementation seems fine..
>>>
>>> On Wed, Oct 7, 2015 at 10:40 AM, Sajith Abeywardhana 
>>> wrote:
>>>
 Hi Ayesha,

 Small clarification?


> I observed that even *anonymous users* can view the logged in view by
> setting query parameter "isAnonView=false" or without setting it at all in
> the browser.
>

 I think you mean in here when the *logged in user* viewing anonymous
 view he can view logged in view by setting query parameter
 "isAnonView=false" or without setting it at all in the browser.

 Anonymous user(with out logging) never able to view logged in view. Am
 I right?


 *Sajith Abeywardhana* | Software Engineer
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka.
 Mobile: +94772260485
 Email: saji...@wso2.com | Web: www.wso2.com



> Can you check this.
>
> Further, instead of having this reflected in the URL can we try keep
> it internally?
>
> Thanks!
> -Ayesha
>
>
> On Tue, Oct 6, 2015 at 6:42 PM, Sajith Abeywardhana 
> wrote:
>
>> Both jira's[1][2] which relevant  to anon view committed under one
>> PR[3]. Please review and merge.
>>
>> [1]. https://wso2.org/jira/browse/UES-597
>> [2]. https://wso2.org/jira/browse/UES-599
>> [3]. https://github.com/wso2/carbon-dashboards/pull/66
>>
>> *Sajith Abeywardhana* | Software Engineer
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka.
>> Mobile: +94772260485
>> Email: saji...@wso2.com | Web: www.wso2.com
>>
>> On Tue, Oct 6, 2015 at 2:16 PM, Sajith Abeywardhana > > wrote:
>>
>>> Fixed the code according to [Dev] [UES][Dashboard Server] Dashboard
>>> anonymous view landing page. Please merge the PR.
>>>
>>> *Sajith Abeywardhana* | Software Engineer
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>> Mobile: +94772260485
>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>
>>> On Tue, Oct 6, 2015 at 10:59 AM, Sajith Abeywardhana <
>>> saji...@wso2.com> wrote:
>>>
 Please hold this merge. Page link rendering logic should be
 changed. We can't check *!user *after the jira -
 https://wso2.org/jira/browse/UES-597

 *Sajith Abeywardhana* | Software Engineer
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka.
 Mobile: +94772260485
 Email: saji...@wso2.com | Web: www.wso2.com

 On Tue, Oct 6, 2015 at 10:38 AM, Sajith Abeywardhana <
 saji...@wso2.com> wrote:

> Please review and merge
> https://github.com/wso2/carbon-dashboards/pull/66 for
> https://wso2.org/jira/browse/UES-599
>
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>


>>>
>>
>
>
> --
> *Ayesha Dissanayaka*
> Software Engineer,
> WSO2, Inc : http://wso2.com
> 
> 20, Palmgrove Avenue, Colombo 3
> E-Mail: aye...@wso2.com 
>


>>>
>>
>
>
> --
> *Ayesha 

Re: [Dev] Please review and merge

[Ayesha Dissanayaka]

Hi Sajith,

I am referring to user not logged in sate. In that case if we directly
access
https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=false
URL then we will see the default view.

And when there a logged in user viewing
https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=false
and logout then also default view is shown since the URL has
isAnonView=false

Thanks!
-Ayesha


On Wed, Oct 7, 2015 at 11:02 AM, Sajith Abeywardhana 
wrote:

> If the user removes the isAnonView param from the url, next time browser
> will show url as 
> *https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=null
> .
> *Since null value is a bit ugly I fixed it and committed it to the PR.
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>
> On Wed, Oct 7, 2015 at 10:50 AM, Udara Rathnayake  wrote:
>
>> Had a chat with Sajith. Current implementation seems fine..
>>
>> On Wed, Oct 7, 2015 at 10:40 AM, Sajith Abeywardhana 
>> wrote:
>>
>>> Hi Ayesha,
>>>
>>> Small clarification?
>>>
>>>
 I observed that even *anonymous users* can view the logged in view by
 setting query parameter "isAnonView=false" or without setting it at all in
 the browser.

>>>
>>> I think you mean in here when the *logged in user* viewing anonymous
>>> view he can view logged in view by setting query parameter
>>> "isAnonView=false" or without setting it at all in the browser.
>>>
>>> Anonymous user(with out logging) never able to view logged in view. Am I
>>> right?
>>>
>>>
>>> *Sajith Abeywardhana* | Software Engineer
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>> Mobile: +94772260485
>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>
>>>
>>>
 Can you check this.

 Further, instead of having this reflected in the URL can we try keep it
 internally?

 Thanks!
 -Ayesha


 On Tue, Oct 6, 2015 at 6:42 PM, Sajith Abeywardhana 
 wrote:

> Both jira's[1][2] which relevant  to anon view committed under one
> PR[3]. Please review and merge.
>
> [1]. https://wso2.org/jira/browse/UES-597
> [2]. https://wso2.org/jira/browse/UES-599
> [3]. https://github.com/wso2/carbon-dashboards/pull/66
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>
> On Tue, Oct 6, 2015 at 2:16 PM, Sajith Abeywardhana 
> wrote:
>
>> Fixed the code according to [Dev] [UES][Dashboard Server] Dashboard
>> anonymous view landing page. Please merge the PR.
>>
>> *Sajith Abeywardhana* | Software Engineer
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka.
>> Mobile: +94772260485
>> Email: saji...@wso2.com | Web: www.wso2.com
>>
>> On Tue, Oct 6, 2015 at 10:59 AM, Sajith Abeywardhana <
>> saji...@wso2.com> wrote:
>>
>>> Please hold this merge. Page link rendering logic should be changed.
>>> We can't check *!user *after the jira -
>>> https://wso2.org/jira/browse/UES-597
>>>
>>> *Sajith Abeywardhana* | Software Engineer
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>> Mobile: +94772260485
>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>
>>> On Tue, Oct 6, 2015 at 10:38 AM, Sajith Abeywardhana <
>>> saji...@wso2.com> wrote:
>>>
 Please review and merge
 https://github.com/wso2/carbon-dashboards/pull/66 for
 https://wso2.org/jira/browse/UES-599


 *Sajith Abeywardhana* | Software Engineer
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka.
 Mobile: +94772260485
 Email: saji...@wso2.com | Web: www.wso2.com

>>>
>>>
>>
>


 --
 *Ayesha Dissanayaka*
 Software Engineer,
 WSO2, Inc : http://wso2.com
 
 20, Palmgrove Avenue, Colombo 3
 E-Mail: aye...@wso2.com 

>>>
>>>
>>
>


-- 
*Ayesha Dissanayaka*
Software Engineer,
WSO2, Inc : http://wso2.com

20, Palmgrove Avenue, Colombo 3
E-Mail: aye...@wso2.com 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Sajith Abeywardhana]

Hi Ayesha,

Small clarification?


> I observed that even *anonymous users* can view the logged in view by
> setting query parameter "isAnonView=false" or without setting it at all in
> the browser.
>

I think you mean in here when the *logged in user* viewing anonymous view
he can view logged in view by setting query parameter "isAnonView=false" or
without setting it at all in the browser.

Anonymous user(with out logging) never able to view logged in view. Am I
right?


*Sajith Abeywardhana* | Software Engineer
WSO2, Inc | lean. enterprise. middleware.
#20, Palm Grove, Colombo 03, Sri Lanka.
Mobile: +94772260485
Email: saji...@wso2.com | Web: www.wso2.com



> Can you check this.
>
> Further, instead of having this reflected in the URL can we try keep it
> internally?
>
> Thanks!
> -Ayesha
>
>
> On Tue, Oct 6, 2015 at 6:42 PM, Sajith Abeywardhana 
> wrote:
>
>> Both jira's[1][2] which relevant  to anon view committed under one PR[3].
>> Please review and merge.
>>
>> [1]. https://wso2.org/jira/browse/UES-597
>> [2]. https://wso2.org/jira/browse/UES-599
>> [3]. https://github.com/wso2/carbon-dashboards/pull/66
>>
>> *Sajith Abeywardhana* | Software Engineer
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka.
>> Mobile: +94772260485
>> Email: saji...@wso2.com | Web: www.wso2.com
>>
>> On Tue, Oct 6, 2015 at 2:16 PM, Sajith Abeywardhana 
>> wrote:
>>
>>> Fixed the code according to [Dev] [UES][Dashboard Server] Dashboard
>>> anonymous view landing page. Please merge the PR.
>>>
>>> *Sajith Abeywardhana* | Software Engineer
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>> Mobile: +94772260485
>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>
>>> On Tue, Oct 6, 2015 at 10:59 AM, Sajith Abeywardhana 
>>> wrote:
>>>
 Please hold this merge. Page link rendering logic should be changed. We
 can't check *!user *after the jira -
 https://wso2.org/jira/browse/UES-597

 *Sajith Abeywardhana* | Software Engineer
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka.
 Mobile: +94772260485
 Email: saji...@wso2.com | Web: www.wso2.com

 On Tue, Oct 6, 2015 at 10:38 AM, Sajith Abeywardhana 
 wrote:

> Please review and merge
> https://github.com/wso2/carbon-dashboards/pull/66 for
> https://wso2.org/jira/browse/UES-599
>
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>


>>>
>>
>
>
> --
> *Ayesha Dissanayaka*
> Software Engineer,
> WSO2, Inc : http://wso2.com
> 
> 20, Palmgrove Avenue, Colombo 3
> E-Mail: aye...@wso2.com 
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Udara Rathnayake]

Had a chat with Sajith. Current implementation seems fine..

On Wed, Oct 7, 2015 at 10:40 AM, Sajith Abeywardhana 
wrote:

> Hi Ayesha,
>
> Small clarification?
>
>
>> I observed that even *anonymous users* can view the logged in view by
>> setting query parameter "isAnonView=false" or without setting it at all in
>> the browser.
>>
>
> I think you mean in here when the *logged in user* viewing anonymous view
> he can view logged in view by setting query parameter "isAnonView=false" or
> without setting it at all in the browser.
>
> Anonymous user(with out logging) never able to view logged in view. Am I
> right?
>
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>
>
>
>> Can you check this.
>>
>> Further, instead of having this reflected in the URL can we try keep it
>> internally?
>>
>> Thanks!
>> -Ayesha
>>
>>
>> On Tue, Oct 6, 2015 at 6:42 PM, Sajith Abeywardhana 
>> wrote:
>>
>>> Both jira's[1][2] which relevant  to anon view committed under one
>>> PR[3]. Please review and merge.
>>>
>>> [1]. https://wso2.org/jira/browse/UES-597
>>> [2]. https://wso2.org/jira/browse/UES-599
>>> [3]. https://github.com/wso2/carbon-dashboards/pull/66
>>>
>>> *Sajith Abeywardhana* | Software Engineer
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>> Mobile: +94772260485
>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>
>>> On Tue, Oct 6, 2015 at 2:16 PM, Sajith Abeywardhana 
>>> wrote:
>>>
 Fixed the code according to [Dev] [UES][Dashboard Server] Dashboard
 anonymous view landing page. Please merge the PR.

 *Sajith Abeywardhana* | Software Engineer
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka.
 Mobile: +94772260485
 Email: saji...@wso2.com | Web: www.wso2.com

 On Tue, Oct 6, 2015 at 10:59 AM, Sajith Abeywardhana 
 wrote:

> Please hold this merge. Page link rendering logic should be changed.
> We can't check *!user *after the jira -
> https://wso2.org/jira/browse/UES-597
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>
> On Tue, Oct 6, 2015 at 10:38 AM, Sajith Abeywardhana  > wrote:
>
>> Please review and merge
>> https://github.com/wso2/carbon-dashboards/pull/66 for
>> https://wso2.org/jira/browse/UES-599
>>
>>
>> *Sajith Abeywardhana* | Software Engineer
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka.
>> Mobile: +94772260485
>> Email: saji...@wso2.com | Web: www.wso2.com
>>
>
>

>>>
>>
>>
>> --
>> *Ayesha Dissanayaka*
>> Software Engineer,
>> WSO2, Inc : http://wso2.com
>> 
>> 20, Palmgrove Avenue, Colombo 3
>> E-Mail: aye...@wso2.com 
>>
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Sajith Abeywardhana]

If the user removes the isAnonView param from the url, next time browser
will show url as
*https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=null
.
*Since null value is a bit ugly I fixed it and committed it to the PR.

*Sajith Abeywardhana* | Software Engineer
WSO2, Inc | lean. enterprise. middleware.
#20, Palm Grove, Colombo 03, Sri Lanka.
Mobile: +94772260485
Email: saji...@wso2.com | Web: www.wso2.com

On Wed, Oct 7, 2015 at 10:50 AM, Udara Rathnayake  wrote:

> Had a chat with Sajith. Current implementation seems fine..
>
> On Wed, Oct 7, 2015 at 10:40 AM, Sajith Abeywardhana 
> wrote:
>
>> Hi Ayesha,
>>
>> Small clarification?
>>
>>
>>> I observed that even *anonymous users* can view the logged in view by
>>> setting query parameter "isAnonView=false" or without setting it at all in
>>> the browser.
>>>
>>
>> I think you mean in here when the *logged in user* viewing anonymous
>> view he can view logged in view by setting query parameter
>> "isAnonView=false" or without setting it at all in the browser.
>>
>> Anonymous user(with out logging) never able to view logged in view. Am I
>> right?
>>
>>
>> *Sajith Abeywardhana* | Software Engineer
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka.
>> Mobile: +94772260485
>> Email: saji...@wso2.com | Web: www.wso2.com
>>
>>
>>
>>> Can you check this.
>>>
>>> Further, instead of having this reflected in the URL can we try keep it
>>> internally?
>>>
>>> Thanks!
>>> -Ayesha
>>>
>>>
>>> On Tue, Oct 6, 2015 at 6:42 PM, Sajith Abeywardhana 
>>> wrote:
>>>
 Both jira's[1][2] which relevant  to anon view committed under one
 PR[3]. Please review and merge.

 [1]. https://wso2.org/jira/browse/UES-597
 [2]. https://wso2.org/jira/browse/UES-599
 [3]. https://github.com/wso2/carbon-dashboards/pull/66

 *Sajith Abeywardhana* | Software Engineer
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka.
 Mobile: +94772260485
 Email: saji...@wso2.com | Web: www.wso2.com

 On Tue, Oct 6, 2015 at 2:16 PM, Sajith Abeywardhana 
 wrote:

> Fixed the code according to [Dev] [UES][Dashboard Server] Dashboard
> anonymous view landing page. Please merge the PR.
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>
> On Tue, Oct 6, 2015 at 10:59 AM, Sajith Abeywardhana  > wrote:
>
>> Please hold this merge. Page link rendering logic should be changed.
>> We can't check *!user *after the jira -
>> https://wso2.org/jira/browse/UES-597
>>
>> *Sajith Abeywardhana* | Software Engineer
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka.
>> Mobile: +94772260485
>> Email: saji...@wso2.com | Web: www.wso2.com
>>
>> On Tue, Oct 6, 2015 at 10:38 AM, Sajith Abeywardhana <
>> saji...@wso2.com> wrote:
>>
>>> Please review and merge
>>> https://github.com/wso2/carbon-dashboards/pull/66 for
>>> https://wso2.org/jira/browse/UES-599
>>>
>>>
>>> *Sajith Abeywardhana* | Software Engineer
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>> Mobile: +94772260485
>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>
>>
>>
>

>>>
>>>
>>> --
>>> *Ayesha Dissanayaka*
>>> Software Engineer,
>>> WSO2, Inc : http://wso2.com
>>> 
>>> 20, Palmgrove Avenue, Colombo 3
>>> E-Mail: aye...@wso2.com 
>>>
>>
>>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Ayesha Dissanayaka]

Hi Sajith,

Thanks for the fixes. I've merged the changes locally and testing the
functionality.

I observed that even anonymous users can view the logged in view by setting
query parameter "isAnonView=false" or without setting it at all in the
browser.

Can you check this.

Further, instead of having this reflected in the URL can we try keep it
internally?

Thanks!
-Ayesha


On Tue, Oct 6, 2015 at 6:42 PM, Sajith Abeywardhana 
wrote:

> Both jira's[1][2] which relevant  to anon view committed under one PR[3].
> Please review and merge.
>
> [1]. https://wso2.org/jira/browse/UES-597
> [2]. https://wso2.org/jira/browse/UES-599
> [3]. https://github.com/wso2/carbon-dashboards/pull/66
>
> *Sajith Abeywardhana* | Software Engineer
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka.
> Mobile: +94772260485
> Email: saji...@wso2.com | Web: www.wso2.com
>
> On Tue, Oct 6, 2015 at 2:16 PM, Sajith Abeywardhana 
> wrote:
>
>> Fixed the code according to [Dev] [UES][Dashboard Server] Dashboard
>> anonymous view landing page. Please merge the PR.
>>
>> *Sajith Abeywardhana* | Software Engineer
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka.
>> Mobile: +94772260485
>> Email: saji...@wso2.com | Web: www.wso2.com
>>
>> On Tue, Oct 6, 2015 at 10:59 AM, Sajith Abeywardhana 
>> wrote:
>>
>>> Please hold this merge. Page link rendering logic should be changed. We
>>> can't check *!user *after the jira -
>>> https://wso2.org/jira/browse/UES-597
>>>
>>> *Sajith Abeywardhana* | Software Engineer
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>> Mobile: +94772260485
>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>
>>> On Tue, Oct 6, 2015 at 10:38 AM, Sajith Abeywardhana 
>>> wrote:
>>>
 Please review and merge
 https://github.com/wso2/carbon-dashboards/pull/66 for
 https://wso2.org/jira/browse/UES-599


 *Sajith Abeywardhana* | Software Engineer
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka.
 Mobile: +94772260485
 Email: saji...@wso2.com | Web: www.wso2.com

>>>
>>>
>>
>


-- 
*Ayesha Dissanayaka*
Software Engineer,
WSO2, Inc : http://wso2.com

20, Palmgrove Avenue, Colombo 3
E-Mail: aye...@wso2.com 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Niranjan Karunanandham]

Hi Madhawa,

As mentioned in [1], we have created a patch branch as 4.4.x branch and the
master branch will be 4.5.0. IMO this fix needs to go to both branches.

[1] - [Dev] [VOTE] Release WSO2 Carbon Kernel 4.4.1 RC2

Regards,
Nira


On Tue, Aug 4, 2015 at 12:25 PM, Madhawa Gunasekara madha...@wso2.com
wrote:

 Hi Sameera,

 Kind reminder on this.

 Thanks,
 Madhawa




-- 

*Niranjan Karunanandham*
Senior Software Engineer - WSO2 Inc.
WSO2 Inc.: http://www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Madhawa Gunasekara]

Hi Sameera,

Kind reminder on this.

Thanks,
Madhawa
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Johann Nallathamby]

https://wso2.org/jira/browse/IDENTITY-3166

On Fri, Jul 24, 2015 at 10:15 PM, Aruna Karunarathna ar...@wso2.com wrote:



 On Fri, Jul 24, 2015 at 8:18 PM, Godwin Amila Shrimal god...@wso2.com
 wrote:

 Hi,

 Please review and commit PR [1]

 [1] https://github.com/wso2/carbon4-kernel/pull/333


 Hi Godwin,

 Can you point me to the public jira for this issue? can't seems to find
 the related jira.

 Regards,
 Aruna\



 Thanks
 Godwin

 --
 *Godwin Amila Shrimal*
 Senior Software Engineer
 WSO2 Inc.; http://wso2.com
 lean.enterprise.middleware

 mobile: *+94772264165*
 linkedin: *http://lnkd.in/KUum6D http://lnkd.in/KUum6D*
 twitter: https://twitter.com/godwinamila

 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev




 --

 *Aruna Sujith Karunarathna *| Software Engineer
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka
 Mobile: +94 71 9040362 | Work: +94 112145345
 Email: ar...@wso2.com | Web: www.wso2.com





-- 
Thanks  Regards,

*Johann Dilantha Nallathamby*
Technical Lead  Product Lead of WSO2 Identity Server
Integration Technologies Team
WSO2, Inc.
lean.enterprise.middleware

Mobile - *+9476950*
Blog - *http://nallaa.wordpress.com http://nallaa.wordpress.com*
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Aruna Karunarathna]

On Fri, Jul 24, 2015 at 8:18 PM, Godwin Amila Shrimal god...@wso2.com
wrote:

 Hi,

 Please review and commit PR [1]

 [1] https://github.com/wso2/carbon4-kernel/pull/333


Hi Godwin,

Can you point me to the public jira for this issue? can't seems to find the
related jira.

Regards,
Aruna\



 Thanks
 Godwin

 --
 *Godwin Amila Shrimal*
 Senior Software Engineer
 WSO2 Inc.; http://wso2.com
 lean.enterprise.middleware

 mobile: *+94772264165*
 linkedin: *http://lnkd.in/KUum6D http://lnkd.in/KUum6D*
 twitter: https://twitter.com/godwinamila

 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev




-- 

*Aruna Sujith Karunarathna *| Software Engineer
WSO2, Inc | lean. enterprise. middleware.
#20, Palm Grove, Colombo 03, Sri Lanka
Mobile: +94 71 9040362 | Work: +94 112145345
Email: ar...@wso2.com | Web: www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Malaka Silva]

We can't merge this until we fully test this. There seems to be http
endpoints which may not work with esb 490 beta.

On Wed, Jul 22, 2015 at 2:04 PM, Elilmatha Sivanesan elilma...@wso2.com
wrote:

 Hi Malaka,

 Please review and merge PR [1]

 [1]
 *https://github.com/wso2/esb-connectors/pull/241
 https://github.com/wso2/esb-connectors/pull/241*

 Thank you.

 --
 *S.Elilmatha*
 Associate  Software Engineer,

 WSO2 Inc.; http://wso2.com
 lean.enterprise.middleware

 Mobile 0779842221.




-- 

Best Regards,

Malaka Silva
Senior Tech Lead
M: +94 777 219 791
Tel : 94 11 214 5345
Fax :94 11 2145300
Skype : malaka.sampath.silva
LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77
Blog : http://mrmalakasilva.blogspot.com/

WSO2, Inc.
lean . enterprise . middleware
http://www.wso2.com/
http://www.wso2.com/about/team/malaka-silva/
http://wso2.com/about/team/malaka-silva/

Save a tree -Conserve nature  Save the world for your future. Print this
email only if it is absolutely necessary.
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Elilmatha Sivanesan]

Hi Malaka,

Please review and merge PR[1] for bugherd connector.
After fixing the certificate issue from bugherd support , I have changed
the http endpoints to work with esb beta.

[1] https://github.com/wso2/esb-connectors/pull/241/

Thank you.

On Thu, Jul 23, 2015 at 3:06 AM, Vanjikumaran Sivajothy va...@wso2.com
wrote:

 @eilimatha,
 Please do not send the mail to dev so blank subject! Send with some
 meaningful content and the subject!

 On Wed, Jul 22, 2015 at 8:14 AM, Malaka Silva mal...@wso2.com wrote:

 We can't merge this until we fully test this. There seems to be http
 endpoints which may not work with esb 490 beta.

 On Wed, Jul 22, 2015 at 2:04 PM, Elilmatha Sivanesan elilma...@wso2.com
 wrote:

 Hi Malaka,

 Please review and merge PR [1]

 [1]
 *https://github.com/wso2/esb-connectors/pull/241
 https://github.com/wso2/esb-connectors/pull/241*

 Thank you.

 --
 *S.Elilmatha*
 Associate  Software Engineer,

 WSO2 Inc.; http://wso2.com
 lean.enterprise.middleware

 Mobile 0779842221.




 --

 Best Regards,

 Malaka Silva
 Senior Tech Lead
 M: +94 777 219 791
 Tel : 94 11 214 5345
 Fax :94 11 2145300
 Skype : malaka.sampath.silva
 LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77
 Blog : http://mrmalakasilva.blogspot.com/

 WSO2, Inc.
 lean . enterprise . middleware
 http://www.wso2.com/
 http://www.wso2.com/about/team/malaka-silva/
 http://wso2.com/about/team/malaka-silva/

 Save a tree -Conserve nature  Save the world for your future. Print this
 email only if it is absolutely necessary.

 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev




 --
 Vanjikumaran Sivajothy
 *Associate Technical Lead*
 *WSO2 Inc. http://wso2.com http://wso2.com/*
 *USA Mobile **+1-812-361-1286*
 *Srilanka Mobile:+94-777-219-209*
 [image: Facebook] https://www.facebook.com/vanjikumaran [image: Twitter]
 https://twitter.com/vanjikumaran [image: LinkedIn]
 http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293 [image:
 Blogger] http://vanjikumaran.blogspot.com/ [image: SlideShare]
 http://www.slideshare.net/vanjikumaran

 This communication may contain privileged or other
 confidential information and is intended exclusively for the addressee/s.
 If you are not the intended recipient/s, or believe that you may
 have received this communication in error, please reply to the
 sender indicating that fact and delete the copy you received and in
 addition, you should not print, copy, re-transmit, disseminate, or
 otherwise use the information contained in this communication.
 Internet communications cannot be guaranteed to be timely, secure, error
 or virus-free. The sender does not accept liability for any errors
 or omissions




-- 
*S.Elilmatha*
Associate  Software Engineer,

WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

Mobile 0779842221.
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Malaka Silva]

Hi Elilmatha,

Why the test cases are disabled?

On Tue, Jul 21, 2015 at 10:01 AM, Elilmatha Sivanesan elilma...@wso2.com
wrote:

 Hi Malaka,

 Please review and merge PR [1]

 [1]
 https://github.com/wso2/esb-connectors/pull/240

 Thank you.
 https://github.com/wso2/esb-connectors/pull/240

 --
 *S.Elilmatha*
 Associate  Software Engineer,

 WSO2 Inc.; http://wso2.com
 lean.enterprise.middleware

 Mobile 0779842221.




-- 

Best Regards,

Malaka Silva
Senior Tech Lead
M: +94 777 219 791
Tel : 94 11 214 5345
Fax :94 11 2145300
Skype : malaka.sampath.silva
LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77
Blog : http://mrmalakasilva.blogspot.com/

WSO2, Inc.
lean . enterprise . middleware
http://www.wso2.com/
http://www.wso2.com/about/team/malaka-silva/
http://wso2.com/about/team/malaka-silva/

Save a tree -Conserve nature  Save the world for your future. Print this
email only if it is absolutely necessary.
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge

[Elilmatha Sivanesan]

Hi Malaka,

I have made changes in 3 tests.

Tumblr - testTumblrGetBlogInfo not disabled but changed according to the
response.

Delicious - testOauthDeliciouspostGetAllWithMandatoryParameters disabled in
order to automate since it is used for a trail account. But can be
automated with Basic authentication (which is currently used).

Mandril - testSearchMessageContentWithMandatoryParameters disabled in order
to automate - need to make an api call to send a message (specified in
readme).

Thank you.

On Tue, Jul 21, 2015 at 3:41 PM, Malaka Silva mal...@wso2.com wrote:

 Hi Elilmatha,

 Why the test cases are disabled?

 On Tue, Jul 21, 2015 at 10:01 AM, Elilmatha Sivanesan elilma...@wso2.com
 wrote:

 Hi Malaka,

 Please review and merge PR [1]

 [1]
 https://github.com/wso2/esb-connectors/pull/240

 Thank you.
 https://github.com/wso2/esb-connectors/pull/240

 --
 *S.Elilmatha*
 Associate  Software Engineer,

 WSO2 Inc.; http://wso2.com
 lean.enterprise.middleware

 Mobile 0779842221.




 --

 Best Regards,

 Malaka Silva
 Senior Tech Lead
 M: +94 777 219 791
 Tel : 94 11 214 5345
 Fax :94 11 2145300
 Skype : malaka.sampath.silva
 LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77
 Blog : http://mrmalakasilva.blogspot.com/

 WSO2, Inc.
 lean . enterprise . middleware
 http://www.wso2.com/
 http://www.wso2.com/about/team/malaka-silva/
 http://wso2.com/about/team/malaka-silva/

 Save a tree -Conserve nature  Save the world for your future. Print this
 email only if it is absolutely necessary.




-- 
*S.Elilmatha*
Associate  Software Engineer,

WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

Mobile 0779842221.
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Please review and merge the pull requests

[Rajith Vitharana]

Hi Madhawa,

Merged both requests,

Thanks,

On Mon, Jul 20, 2015 at 2:54 PM, Madhawa Gunasekara madha...@wso2.com
wrote:

 Hi,

 Please review and merge the two pull requests.
 [1] fix for issue [2] and [3] fix for issue [4].

 [1] https://github.com/wso2/carbon-data/pull/9
 [2] https://wso2.org/jira/browse/DS-1039

 [3] https://github.com/wso2/carbon-data/pull/12
 [4] https://wso2.org/jira/browse/DS-1040

 Thanks,
 Madhawa

 --
 *Madhawa Gunasekara*
 Software Engineer
 WSO2 Inc.; http://wso2.com
 lean.enterprise.middleware

 mobile: +94 719411002 +94+719411002
 blog: *http://madhawa-gunasekara.blogspot.com
 http://madhawa-gunasekara.blogspot.com*
 linkedin: *http://lk.linkedin.com/in/mgunasekara
 http://lk.linkedin.com/in/mgunasekara*




-- 
Rajith Vitharana

Software Engineer,
WSO2 Inc. : wso2.com
Mobile : +94715883223
Blog : http://lankavitharana.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev