Re: Package update requires modification of config file in users' home directories
On Tue, Mar 9, 2021, at 10:02 PM, Nico Kadel-Garcia wrote: > On Tue, Mar 9, 2021 at 7:46 AM Vitaly Zaitsev via devel > wrote: > > > > On 09.03.2021 00:10, Alexander Ploumistos wrote: > > > Is there something I can do to sed out the -qt5 suffix, or should I > > > just bite the bullet, build the update and wait for the bug reports to > > > come in? > > > > You cannot modify files in user home directories. > > Well, you *can*, but then you'd be Ubuntu with /home/apache, > /home/tomcat, and violating the File System Hierarchy in all sorts of > ways. It's also outrageous to expect or permit this kind of RPM based > manipulaiton, since "/home/" directories may be NFS mounted across a > wide array of systems.and represents userspace not system space. Not with rpm-ostree, we sandbox scripts: https://coreos.github.io/rpm-ostree/architecture-core/#sandboxing-scripts ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On Tue, Mar 9, 2021 at 7:46 AM Vitaly Zaitsev via devel wrote: > > On 09.03.2021 00:10, Alexander Ploumistos wrote: > > Is there something I can do to sed out the -qt5 suffix, or should I > > just bite the bullet, build the update and wait for the bug reports to > > come in? > > You cannot modify files in user home directories. Well, you *can*, but then you'd be Ubuntu with /home/apache, /home/tomcat, and violating the File System Hierarchy in all sorts of ways. It's also outrageous to expect or permit this kind of RPM based manipulaiton, since "/home/" directories may be NFS mounted across a wide array of systems.and represents userspace not system space. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On 3/9/21 4:21 PM, Alexander Ploumistos wrote:
Do all of the DEs we have in Fedora support the same notification mechanisms?
I'm not 100% sure, but it's freedesktop.org/D-Bus based, so it's about
as standard as it gets these days. (Probably irrelevant, though.)
I added
ln -sf %{_libdir}/%{name}/libobabeliface.so
%{buildroot}%{_libdir}/%{name}/libobabeliface-qt5.so
to the %install section of my spec file
Yeah. If that works it's far and away the easiest way to go about it.
--
In Soviet Russia, Google searches you!
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On Tue, Mar 9, 2021 at 10:27 PM Ian Pilcher wrote:
>
> On 3/9/21 1:39 PM, Alexander Ploumistos wrote:
> > Well, the first option is still a no-no, as the fixup has to happen in
> > the user's home directory. For the second one, I think I'd need to add
> > something like "Requires: zenity", which in turn would pull in other
> > dependencies.
>
> I don't believe that it's forbidden by Fedora's policy, as it would be
> the wrapper making the changes, which is effectively no different from
> the program itself doing it, if it had that capability. The real
> problem with this approach is the potential to mess up the user's
> configuration if the wrapper encounters something that it doesn't
> expect, which is why a warning message approach is probably better.
I saw that a number of our packages do use wrappers that way, but this
feels like cheating ;)
Plus, the concerns behind the policy and those you've just expressed
remain valid.
> You could probably do something very lightweight with the desktop
> notification service, but it isn't an area that I know a lot about.
Do all of the DEs we have in Fedora support the same notification mechanisms?
> > After discussing with upstream, I am going to add a symlink for now
> > and they're going to take care of things programmatically in a
> > subsequent update.
>
> Where are you going to add the symlink?
I added
ln -sf %{_libdir}/%{name}/libobabeliface.so
%{buildroot}%{_libdir}/%{name}/libobabeliface-qt5.so
to the %install section of my spec file
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On 3/9/21 1:39 PM, Alexander Ploumistos wrote: Well, the first option is still a no-no, as the fixup has to happen in the user's home directory. For the second one, I think I'd need to add something like "Requires: zenity", which in turn would pull in other dependencies. I don't believe that it's forbidden by Fedora's policy, as it would be the wrapper making the changes, which is effectively no different from the program itself doing it, if it had that capability. The real problem with this approach is the potential to mess up the user's configuration if the wrapper encounters something that it doesn't expect, which is why a warning message approach is probably better. You could probably do something very lightweight with the desktop notification service, but it isn't an area that I know a lot about. After discussing with upstream, I am going to add a symlink for now and they're going to take care of things programmatically in a subsequent update. Where are you going to add the symlink? -- In Soviet Russia, Google searches you! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On Tue, Mar 9, 2021 at 7:28 PM Ian Pilcher wrote: > > On 3/8/21 5:10 PM, Alexander Ploumistos wrote: > > Is there something I can do to sed out the -qt5 suffix, or should I > > just bite the bullet, build the update and wait for the bug reports to > > come in? > > You could replace the executable with a wrapper script that performs the > necessary fixups before calling the actual executable. Or (probably > better) just shows a message telling the user to do it. Well, the first option is still a no-no, as the fixup has to happen in the user's home directory. For the second one, I think I'd need to add something like "Requires: zenity", which in turn would pull in other dependencies. After discussing with upstream, I am going to add a symlink for now and they're going to take care of things programmatically in a subsequent update. ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On 3/8/21 5:10 PM, Alexander Ploumistos wrote: Is there something I can do to sed out the -qt5 suffix, or should I just bite the bullet, build the update and wait for the bug reports to come in? You could replace the executable with a wrapper script that performs the necessary fixups before calling the actual executable. Or (probably better) just shows a message telling the user to do it. -- In Soviet Russia, Google searches you! ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On 09.03.2021 00:10, Alexander Ploumistos wrote: Is there something I can do to sed out the -qt5 suffix, or should I just bite the bullet, build the update and wait for the bug reports to come in? You cannot modify files in user home directories. -- Sincerely, Vitaly Zaitsev (vit...@easycoding.org) ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
Hi Kevin, On Tue, Mar 9, 2021 at 1:26 AM Kevin Fenzi wrote: > > On Tue, Mar 09, 2021 at 01:03:05AM +0100, Fabio Valentini wrote: > > > > I don't think that packagers should *ever* be in the business of > > modifying the content of users' $HOME directories. > > In fact this has happened before in the past, leading to: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_no_files_or_directories_under_srv_usrlocal_or_homeuser > ie, it's forbidden. Dont do this. > > The app itself/upstream might come up with a way to detect the old > settings and offer to fix them for users? Or just do so... ? I was aware of our policy, in my panic I was asking if there was a way to bend the rules to get out of this catch-22. Both of Kalev's sober suggestions made me go "duh!" (hats off to Kalev) and I'm going to hold off on the update until I've discussed this with the upstream developer. I am so grateful for "git reset --hard HEAD~" right now… Thank you all, Alex ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On Tue, Mar 09, 2021 at 01:03:05AM +0100, Fabio Valentini wrote: > > I don't think that packagers should *ever* be in the business of > modifying the content of users' $HOME directories. In fact this has happened before in the past, leading to: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_no_files_or_directories_under_srv_usrlocal_or_homeuser ie, it's forbidden. Dont do this. The app itself/upstream might come up with a way to detect the old settings and offer to fix them for users? Or just do so... ? kevin signature.asc Description: PGP signature ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On Tue, Mar 9, 2021 at 12:10 AM Alexander Ploumistos < alex.ploumis...@gmail.com> wrote: > Hello, > > Upstream has just released a bugfix update for Molsketch and it's the > kind of update that can't wait for the next fedora release. Among the > other fixes, the new version has dropped support for Qt4 and with it, > the -qt5 suffixes of several files. > While testing it, I realized that after the update, a line in > ~/.config/SourceForge/Molsketch.conf has to change from > obabel-iface-path=/usr/lib64/molsketch/libobabeliface-qt5.so > to > obabel-iface-path=/usr/lib64/molsketch/libobabeliface.so > (on a x86_64 system) otherwise features from OpenBabel are not > available to the program. > > Is there something I can do to sed out the -qt5 suffix, or should I > just bite the bullet, build the update and wait for the bug reports to > come in? > You could maybe try to hack this around by installing a symlink from libobabeliface-qt5.so to libobabeliface.so so that existing config files continue working. Also, reach out to upstream and discuss the issue. The app when it starts up could maybe detect the issue in the config file and update it, or something along those lines. -- Hope this helps, Kalev ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
Hello Fabio, On Tue, Mar 9, 2021 at 1:03 AM Fabio Valentini wrote: > > On Tue, Mar 9, 2021 at 12:10 AM Alexander Ploumistos > wrote: > > > > Upstream has just released a bugfix update for Molsketch and it's the > > kind of update that can't wait for the next fedora release. Among the > > other fixes, the new version has dropped support for Qt4 and with it, > > the -qt5 suffixes of several files. > > While testing it, I realized that after the update, a line in > > ~/.config/SourceForge/Molsketch.conf has to change from > > obabel-iface-path=/usr/lib64/molsketch/libobabeliface-qt5.so > > to > > obabel-iface-path=/usr/lib64/molsketch/libobabeliface.so > > (on a x86_64 system) otherwise features from OpenBabel are not > > available to the program. > > > > Is there something I can do to sed out the -qt5 suffix, or should I > > just bite the bullet, build the update and wait for the bug reports to > > come in? > > I don't think that packagers should *ever* be in the business of > modifying the content of users' $HOME directories. Agreed. > Usually, I'd say that a major change like from Qt4 to Qt5 would > warrant only shipping this with the next Fedora version (and > mentioning the change in the Fedora Release Notes, maybe), but if you > don't want to wait for that, the best I think you can do is to make it > very clear in the update notes in bodhi that this update might break > things without manually editing that config file. Actually, in Fedora we've always had Molsketch built with Qt5, it's just that upstream decided to stop supporting Qt4 and that's why the suffixes were dropped. I think that the bugs that were fixed in this release far outweigh the (temporary) loss of functionality; imagine having spent hours working on a document, only to discover that the saved file contains mostly gibberish. I'll add a note on the update page and hope for the best. Thank you for the input, Alex ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Re: Package update requires modification of config file in users' home directories
On Tue, Mar 9, 2021 at 12:10 AM Alexander Ploumistos wrote: > > Hello, > > Upstream has just released a bugfix update for Molsketch and it's the > kind of update that can't wait for the next fedora release. Among the > other fixes, the new version has dropped support for Qt4 and with it, > the -qt5 suffixes of several files. > While testing it, I realized that after the update, a line in > ~/.config/SourceForge/Molsketch.conf has to change from > obabel-iface-path=/usr/lib64/molsketch/libobabeliface-qt5.so > to > obabel-iface-path=/usr/lib64/molsketch/libobabeliface.so > (on a x86_64 system) otherwise features from OpenBabel are not > available to the program. > > Is there something I can do to sed out the -qt5 suffix, or should I > just bite the bullet, build the update and wait for the bug reports to > come in? I don't think that packagers should *ever* be in the business of modifying the content of users' $HOME directories. Usually, I'd say that a major change like from Qt4 to Qt5 would warrant only shipping this with the next Fedora version (and mentioning the change in the Fedora Release Notes, maybe), but if you don't want to wait for that, the best I think you can do is to make it very clear in the update notes in bodhi that this update might break things without manually editing that config file. Fabio ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
